14 files changed, 65 insertions, 33 deletions

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 7e7e147875bf..fb2bb3099dd9 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -140,6 +140,7 @@ endif
 
 clean-files     := lkc_defs.h qconf.moc .tmp_qtcheck \
                    .tmp_gtkcheck zconf.tab.c lex.zconf.c zconf.hash.c
+clean-files     += mconf qconf gconf
 
 # Needed for systems without gettext
 KBUILD_HAVE_NLS := $(shell \
@@ -183,8 +184,8 @@ $(obj)/.tmp_qtcheck:
           done; \
           if [ -z "$$dir" ]; then \
             echo "*"; \
-            echo "* Unable to find the QT installation. Please make sure that"; \
-            echo "* the QT development package is correctly installed and"; \
+            echo "* Unable to find the QT3 installation. Please make sure that"; \
+            echo "* the QT3 development package is correctly installed and"; \
             echo "* either install pkg-config or set the QTDIR environment"; \
             echo "* variable to the correct location."; \
             echo "*"; \
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 124b341a18c0..1199baf866ca 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -558,6 +558,7 @@ int main(int ac, char **av)
                 if (stat(".config", &tmpstat)) {
                         printf(_("***\n"
                                 "*** You have not yet configured your kernel!\n"
+                                "*** (missing kernel .config file)\n"
                                 "***\n"
                                 "*** Please run some configurator (e.g. \"make oldconfig\" or\n"
                                 "*** \"make menuconfig\" or \"make xconfig\").\n"
diff --git a/scripts/kconfig/lex.zconf.c_shipped b/scripts/kconfig/lex.zconf.c_shipped
index 800f8c71c407..0fdc9049296f 100644
--- a/scripts/kconfig/lex.zconf.c_shipped
+++ b/scripts/kconfig/lex.zconf.c_shipped
@@ -2264,7 +2264,7 @@ FILE *zconf_fopen(const char *name)
         FILE *f;
 
         f = fopen(name, "r");
-        if (!f && name[0] != '/') {
+        if (!f && name != NULL && name[0] != '/') {
                 env = getenv(SRCTREE);
                 if (env) {
                         sprintf(fullname, "%s/%s", env, name);
diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
index 9b2706a41548..8a07ee4f6bd4 100644
--- a/scripts/kconfig/lkc.h
+++ b/scripts/kconfig/lkc.h
@@ -64,6 +64,7 @@ int zconf_lineno(void);
 char *zconf_curname(void);
 
 /* confdata.c */
+const char *conf_get_configname(void);
 char *conf_get_default_confname(void);
 void sym_set_change_count(int count);
 void sym_add_change_count(int count);
diff --git a/scripts/kconfig/lxdialog/dialog.h b/scripts/kconfig/lxdialog/dialog.h
index fd695e1070f7..7e17eba75ae8 100644
--- a/scripts/kconfig/lxdialog/dialog.h
+++ b/scripts/kconfig/lxdialog/dialog.h
@@ -188,6 +188,7 @@ int on_key_esc(WINDOW *win);
 int on_key_resize(void);
 
 void init_dialog(const char *backtitle);
+void set_dialog_backtitle(const char *backtitle);
 void reset_dialog(void);
 void end_dialog(void);
 void attr_clear(WINDOW * win, int height, int width, chtype attr);
diff --git a/scripts/kconfig/lxdialog/util.c b/scripts/kconfig/lxdialog/util.c
index d54440fc166c..a1bddefe73d0 100644
--- a/scripts/kconfig/lxdialog/util.c
+++ b/scripts/kconfig/lxdialog/util.c
@@ -272,6 +272,11 @@ void init_dialog(const char *backtitle)
         color_setup(getenv("MENUCONFIG_COLOR"));
 }
 
+void set_dialog_backtitle(const char *backtitle)
+{
+        dlg.backtitle = backtitle;
+}
+
 void reset_dialog(void)
 {
         initscr();              /* Init curses */
@@ -336,7 +341,7 @@ void print_autowrap(WINDOW * win, const char *prompt, int width, int y, int x)
                 newl = 1;
                 word = tempstr;
                 while (word && *word) {
-                        sp = index(word, ' ');
+                        sp = strchr(word, ' ');
                         if (sp)
                                 *sp++ = 0;
 
@@ -348,7 +353,7 @@ void print_autowrap(WINDOW * win, const char *prompt, int width, int y, int x)
                         if (wlen > room ||
                             (newl && wlen < 4 && sp
                              && wlen + 1 + strlen(sp) > room
-                             && (!(sp2 = index(sp, ' '))
+                             && (!(sp2 = strchr(sp, ' '))
                                  || wlen + 1 + (sp2 - sp) > room))) {
                                 cur_y++;
                                 cur_x = x;
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 3f9a1321b3e6..d0e4fa594fc7 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -26,7 +26,6 @@
 #include "lkc.h"
 #include "lxdialog/dialog.h"
 
-static char menu_backtitle[128];
 static const char mconf_readme[] = N_(
 "Overview\n"
 "--------\n"
@@ -271,7 +270,6 @@ search_help[] = N_(
         "          USB$ => find all CONFIG_ symbols ending with USB\n"
         "\n");
 
-static char filename[PATH_MAX+1] = ".config";
 static int indent;
 static struct termios ios_org;
 static int rows = 0, cols = 0;
@@ -395,6 +393,28 @@ static struct gstr get_relations_str(struct symbol **sym_arr)
         return res;
 }
 
+static char filename[PATH_MAX+1];
+static void set_config_filename(const char *config_filename)
+{
+        static char menu_backtitle[PATH_MAX+128];
+        int size;
+        struct symbol *sym;
+
+        sym = sym_lookup("KERNELVERSION", 0);
+        sym_calc_value(sym);
+        size = snprintf(menu_backtitle, sizeof(menu_backtitle),
+                        _("%s - Linux Kernel v%s Configuration"),
+                        config_filename, sym_get_string_value(sym));
+        if (size >= sizeof(menu_backtitle))
+                menu_backtitle[sizeof(menu_backtitle)-1] = '\0';
+        set_dialog_backtitle(menu_backtitle);
+
+        size = snprintf(filename, sizeof(filename), "%s", config_filename);
+        if (size >= sizeof(filename))
+                filename[sizeof(filename)-1] = '\0';
+}
+
+
 static void search_conf(void)
 {
         struct symbol **sym_arr;
@@ -816,8 +836,10 @@ static void conf_load(void)
                 case 0:
                         if (!dialog_input_result[0])
                                 return;
-                        if (!conf_read(dialog_input_result))
+                        if (!conf_read(dialog_input_result)) {
+                                set_config_filename(dialog_input_result);
                                 return;
+                        }
                         show_textbox(NULL, _("File does not exist!"), 5, 38);
                         break;
                 case 1:
@@ -840,8 +862,10 @@ static void conf_save(void)
                 case 0:
                         if (!dialog_input_result[0])
                                 return;
-                        if (!conf_write(dialog_input_result))
+                        if (!conf_write(dialog_input_result)) {
+                                set_config_filename(dialog_input_result);
                                 return;
+                        }
                         show_textbox(NULL, _("Can't create file!  Probably a nonexistent directory."), 5, 60);
                         break;
                 case 1:
@@ -860,7 +884,6 @@ static void conf_cleanup(void)
 
 int main(int ac, char **av)
 {
-        struct symbol *sym;
         char *mode;
         int res;
 
@@ -871,11 +894,6 @@ int main(int ac, char **av)
         conf_parse(av[1]);
         conf_read(NULL);
 
-        sym = sym_lookup("KERNELVERSION", 0);
-        sym_calc_value(sym);
-        sprintf(menu_backtitle, _("Linux Kernel v%s Configuration"),
-                sym_get_string_value(sym));
-
         mode = getenv("MENUCONFIG_MODE");
         if (mode) {
                 if (!strcasecmp(mode, "single_menu"))
@@ -886,7 +904,8 @@ int main(int ac, char **av)
         atexit(conf_cleanup);
         init_wsize();
         reset_dialog();
-        init_dialog(menu_backtitle);
+        init_dialog(NULL);
+        set_config_filename(conf_get_configname());
         do {
                 conf(&rootmenu);
                 dialog_clear();
@@ -903,7 +922,7 @@ int main(int ac, char **av)
 
         switch (res) {
         case 0:
-                if (conf_write(NULL)) {
+                if (conf_write(filename)) {
                         fprintf(stderr, _("\n\n"
                                 "Error during writing of the kernel configuration.\n"
                                 "Your kernel configuration changes were NOT saved."
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index c86c27f2c761..f14aeac67d4f 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -203,7 +203,7 @@ void sym_check_prop(struct symbol *sym)
                         else if (sym2->type == S_UNKNOWN)
                                 prop_warn(prop,
                                     "'select' used by config symbol '%s' "
-                                    "refer to undefined symbol '%s'",
+                                    "refers to undefined symbol '%s'",
                                     sym->name, sym2->name);
                         else if (sym2->type != S_BOOLEAN && sym2->type != S_TRISTATE)
                                 prop_warn(prop,
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index 512c2f5c341d..f2a23a9c3938 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1182,7 +1182,7 @@ void ConfigInfoView::contentsContextMenuEvent(QContextMenuEvent *e)
         Parent::contentsContextMenuEvent(e);
 }
 
-ConfigSearchWindow::ConfigSearchWindow(QWidget* parent, const char *name)
+ConfigSearchWindow::ConfigSearchWindow(ConfigMainWindow* parent, const char *name)
         : Parent(parent, name), result(NULL)
 {
         setCaption("Search Config");
@@ -1206,6 +1206,9 @@ ConfigSearchWindow::ConfigSearchWindow(QWidget* parent, const char *name)
         info = new ConfigInfoView(split, name);
         connect(list->list, SIGNAL(menuChanged(struct menu *)),
                 info, SLOT(setInfo(struct menu *)));
+        connect(list->list, SIGNAL(menuChanged(struct menu *)),
+                parent, SLOT(setMenuLink(struct menu *)));
+
         layout1->addWidget(split);
 
         if (name) {
diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
index 6fc1c5f14425..b3b5657b6b35 100644
--- a/scripts/kconfig/qconf.h
+++ b/scripts/kconfig/qconf.h
@@ -279,7 +279,7 @@ class ConfigSearchWindow : public QDialog {
         Q_OBJECT
         typedef class QDialog Parent;
 public:
-        ConfigSearchWindow(QWidget* parent, const char *name = 0);
+        ConfigSearchWindow(ConfigMainWindow* parent, const char *name = 0);
 
 public slots:
         void saveSettings(void);
diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
index 8f06c474d800..c35dcc5d6189 100644
--- a/scripts/kconfig/symbol.c
+++ b/scripts/kconfig/symbol.c
@@ -786,13 +786,15 @@ static struct symbol *sym_check_expr_deps(struct expr *e)
         return NULL;
 }
 
+/* return NULL when dependencies are OK */
 struct symbol *sym_check_deps(struct symbol *sym)
 {
         struct symbol *sym2;
         struct property *prop;
 
         if (sym->flags & SYMBOL_CHECK) {
-                printf("Warning! Found recursive dependency: %s", sym->name);
+                fprintf(stderr, "%s:%d:error: found recursive dependency: %s",
+                        sym->prop->file->name, sym->prop->lineno, sym->name);
                 return sym;
         }
         if (sym->flags & SYMBOL_CHECKED)
@@ -816,13 +818,8 @@ struct symbol *sym_check_deps(struct symbol *sym)
                         goto out;
         }
 out:
-        if (sym2) {
-                printf(" %s", sym->name);
-                if (sym2 == sym) {
-                        printf("\n");
-                        sym2 = NULL;
-                }
-        }
+        if (sym2)
+                fprintf(stderr, " -> %s%s", sym->name, sym2 == sym? "\n": "");
         sym->flags &= ~SYMBOL_CHECK;
         return sym2;
 }
diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
index cfa46077c6b4..187d38ccadd5 100644
--- a/scripts/kconfig/zconf.l
+++ b/scripts/kconfig/zconf.l
@@ -265,7 +265,7 @@ FILE *zconf_fopen(const char *name)
         FILE *f;
 
         f = fopen(name, "r");
-        if (!f && name[0] != '/') {
+        if (!f && name != NULL && name[0] != '/') {
                 env = getenv(SRCTREE);
                 if (env) {
                         sprintf(fullname, "%s/%s", env, name);
diff --git a/scripts/kconfig/zconf.tab.c_shipped b/scripts/kconfig/zconf.tab.c_shipped
index d777fe85627f..9a06b6771eee 100644
--- a/scripts/kconfig/zconf.tab.c_shipped
+++ b/scripts/kconfig/zconf.tab.c_shipped
@@ -2132,9 +2132,11 @@ void conf_parse(const char *name)
         }
         menu_finalize(&rootmenu);
         for_all_symbols(i, sym) {
-                sym_check_deps(sym);
+                if (sym_check_deps(sym))
+                        zconfnerrs++;
         }
-
+        if (zconfnerrs)
+                exit(1);
         sym_set_change_count(1);
 }
 
diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y
index 04a5864c03b1..92eb02bdf9c5 100644
--- a/scripts/kconfig/zconf.y
+++ b/scripts/kconfig/zconf.y
@@ -501,9 +501,11 @@ void conf_parse(const char *name)
         }
         menu_finalize(&rootmenu);
         for_all_symbols(i, sym) {
-                sym_check_deps(sym);
+                if (sym_check_deps(sym))
+                        zconfnerrs++;
         }
-
+        if (zconfnerrs)
+                exit(1);
         sym_set_change_count(1);
 }