5 files changed, 57 insertions, 32 deletions

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index fb2bb3099dd9..8986a48c8c49 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -22,24 +22,25 @@ oldconfig: $(obj)/conf
 silentoldconfig: $(obj)/conf
         $< -s arch/$(ARCH)/Kconfig
 
+# Create new linux.po file
+# Adjust charset to UTF-8 in .po file to accept UTF-8 in Kconfig files
+# The symlink is used to repair a deficiency in arch/um
 update-po-config: $(obj)/kxgettext
-        xgettext --default-domain=linux \
-          --add-comments --keyword=_ --keyword=N_ \
-          --files-from=scripts/kconfig/POTFILES.in \
-          --output scripts/kconfig/config.pot
-        $(Q)ln -fs Kconfig_i386 arch/um/Kconfig_arch
-        $(Q)for i in `ls arch/`; \
-        do \
-          scripts/kconfig/kxgettext arch/$$i/Kconfig \
-            | msguniq -o scripts/kconfig/linux_$${i}.pot; \
-        done
-        $(Q)msgcat scripts/kconfig/config.pot \
-          `find scripts/kconfig/ -type f -name linux_*.pot` \
-          --output scripts/kconfig/linux_raw.pot
-        $(Q)msguniq --sort-by-file scripts/kconfig/linux_raw.pot \
-            --output scripts/kconfig/linux.pot
-        $(Q)rm -f arch/um/Kconfig_arch
-        $(Q)rm -f scripts/kconfig/linux_*.pot scripts/kconfig/config.pot
+        xgettext --default-domain=linux                  \
+            --add-comments --keyword=_ --keyword=N_      \
+            --from-code=UTF-8                            \
+            --files-from=scripts/kconfig/POTFILES.in     \
+            --output $(obj)/config.pot
+        $(Q)sed -i s/CHARSET/UTF-8/ $(obj)/config.pot
+        $(Q)ln -fs Kconfig.i386 arch/um/Kconfig.arch
+        (for i in `ls arch/`;                            \
+        do                                               \
+            $(obj)/kxgettext arch/$$i/Kconfig;           \
+        done ) >> $(obj)/config.pot
+        msguniq --sort-by-file --to-code=UTF-8 $(obj)/config.pot \
+            --output $(obj)/linux.pot
+        $(Q)rm -f arch/um/Kconfig.arch
+        $(Q)rm -f $(obj)/config.pot
 
 PHONY += randconfig allyesconfig allnoconfig allmodconfig defconfig
 
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 664fe29dacef..b2913e9da495 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -341,27 +341,42 @@ int conf_read(const char *name)
                 conf_unsaved++;
                 /* maybe print value in verbose mode... */
         sym_ok:
+                if (!sym_is_choice(sym))
+                        continue;
+                /* The choice symbol only has a set value (and thus is not new)
+                 * if all its visible childs have values.
+                 */
+                prop = sym_get_choice_prop(sym);
+                flags = sym->flags;
+                for (e = prop->expr; e; e = e->left.expr)
+                        if (e->right.sym->visible != no)
+                                flags &= e->right.sym->flags;
+                sym->flags &= flags | ~SYMBOL_DEF_USER;
+        }
+
+        for_all_symbols(i, sym) {
                 if (sym_has_value(sym) && !sym_is_choice_value(sym)) {
-                        if (sym->visible == no)
+                        /* Reset values of generates values, so they'll appear
+                         * as new, if they should become visible, but that
+                         * doesn't quite work if the Kconfig and the saved
+                         * configuration disagree.
+                         */
+                        if (sym->visible == no && !conf_unsaved)
                                 sym->flags &= ~SYMBOL_DEF_USER;
                         switch (sym->type) {
                         case S_STRING:
                         case S_INT:
                         case S_HEX:
-                                if (!sym_string_within_range(sym, sym->def[S_DEF_USER].val))
-                                        sym->flags &= ~(SYMBOL_VALID|SYMBOL_DEF_USER);
+                                /* Reset a string value if it's out of range */
+                                if (sym_string_within_range(sym, sym->def[S_DEF_USER].val))
+                                        break;
+                                sym->flags &= ~(SYMBOL_VALID|SYMBOL_DEF_USER);
+                                conf_unsaved++;
+                                break;
                         default:
                                 break;
                         }
                 }
-                if (!sym_is_choice(sym))
-                        continue;
-                prop = sym_get_choice_prop(sym);
-                flags = sym->flags;
-                for (e = prop->expr; e; e = e->left.expr)
-                        if (e->right.sym->visible != no)
-                                flags &= e->right.sym->flags;
-                sym->flags &= flags | ~SYMBOL_DEF_USER;
         }
 
         sym_add_change_count(conf_warnings || conf_unsaved);
diff --git a/scripts/kconfig/kxgettext.c b/scripts/kconfig/kxgettext.c
index abee55ca6174..11f7dab94715 100644
--- a/scripts/kconfig/kxgettext.c
+++ b/scripts/kconfig/kxgettext.c
@@ -212,7 +212,9 @@ void menu__xgettext(void)
         struct message *m = message__list;
 
         while (m != NULL) {
-                message__print_gettext_msgid_msgstr(m);
+                /* skip empty lines ("") */
+                if (strlen(m->msg) > sizeof("\"\""))
+                        message__print_gettext_msgid_msgstr(m);
                 m = m->next;
         }
 }
diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index cdca7388e0f1..9681476b96e7 100644
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -51,7 +51,7 @@ usage() {
         printf "Usage: $0 [-check compiler options|-header|-library]\n"
 }
 
-if [ $# == 0 ]; then
+if [ $# -eq 0 ]; then
         usage
         exit 1
 fi
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index d0e4fa594fc7..d2c2a429887b 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -419,11 +419,13 @@ static void search_conf(void)
 {
         struct symbol **sym_arr;
         struct gstr res;
+        char *dialog_input;
         int dres;
 again:
         dialog_clear();
         dres = dialog_inputbox(_("Search Configuration Parameter"),
-                              _("Enter CONFIG_ (sub)string to search for (omit CONFIG_)"),
+                              _("Enter CONFIG_ (sub)string to search for "
+                                "(with or without \"CONFIG\")"),
                               10, 75, "");
         switch (dres) {
         case 0:
@@ -435,7 +437,12 @@ again:
                 return;
         }
 
-        sym_arr = sym_re_search(dialog_input_result);
+        /* strip CONFIG_ if necessary */
+        dialog_input = dialog_input_result;
+        if (strncasecmp(dialog_input_result, "CONFIG_", 7) == 0)
+                dialog_input += 7;
+
+        sym_arr = sym_re_search(dialog_input);
         res = get_relations_str(sym_arr);
         free(sym_arr);
         show_textbox(_("Search Results"), str_get(&res), 0, 0);