1 files changed, 42 insertions, 7 deletions

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index f9d0d91a3fe4..fdad17367f61 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -15,7 +15,7 @@ static struct menu **last_entry_ptr;
 struct file *file_list;
 struct file *current_file;
 
-static void menu_warn(struct menu *menu, const char *fmt, ...)
+void menu_warn(struct menu *menu, const char *fmt, ...)
 {
         va_list ap;
         va_start(ap, fmt);
@@ -172,6 +172,9 @@ void menu_add_option(int token, char *arg)
                 else if (sym_defconfig_list != current_entry->sym)
                         zconf_error("trying to redefine defconfig symbol");
                 break;
+        case T_OPT_ENV:
+                prop_add_env(arg);
+                break;
         }
 }
 
@@ -239,9 +242,11 @@ void menu_finalize(struct menu *parent)
                         for (menu = parent->list; menu; menu = menu->next) {
                                 if (menu->sym) {
                                         current_entry = parent;
-                                        menu_set_type(menu->sym->type);
+                                        if (sym->type == S_UNKNOWN)
+                                                menu_set_type(menu->sym->type);
                                         current_entry = menu;
-                                        menu_set_type(sym->type);
+                                        if (menu->sym->type == S_UNKNOWN)
+                                                menu_set_type(sym->type);
                                         break;
                                 }
                         }
@@ -326,12 +331,42 @@ void menu_finalize(struct menu *parent)
                                             "values not supported");
                         }
                         current_entry = menu;
-                        menu_set_type(sym->type);
+                        if (menu->sym->type == S_UNKNOWN)
+                                menu_set_type(sym->type);
+                        /* Non-tristate choice values of tristate choices must
+                         * depend on the choice being set to Y. The choice
+                         * values' dependencies were propagated to their
+                         * properties above, so the change here must be re-
+                         * propagated. */
+                        if (sym->type == S_TRISTATE && menu->sym->type != S_TRISTATE) {
+                                basedep = expr_alloc_comp(E_EQUAL, sym, &symbol_yes);
+                                basedep = expr_alloc_and(basedep, menu->dep);
+                                basedep = expr_eliminate_dups(basedep);
+                                menu->dep = basedep;
+                                for (prop = menu->sym->prop; prop; prop = prop->next) {
+                                        if (prop->menu != menu)
+                                                continue;
+                                        dep = expr_alloc_and(expr_copy(basedep),
+                                                             prop->visible.expr);
+                                        dep = expr_eliminate_dups(dep);
+                                        dep = expr_trans_bool(dep);
+                                        prop->visible.expr = dep;
+                                        if (prop->type == P_SELECT) {
+                                                struct symbol *es = prop_get_symbol(prop);
+                                                dep2 = expr_alloc_symbol(menu->sym);
+                                                dep = expr_alloc_and(dep2,
+                                                                     expr_copy(dep));
+                                                dep = expr_alloc_or(es->rev_dep.expr, dep);
+                                                dep = expr_eliminate_dups(dep);
+                                                es->rev_dep.expr = dep;
+                                        }
+                                }
+                        }
                         menu_add_symbol(P_CHOICE, sym, NULL);
                         prop = sym_get_choice_prop(sym);
                         for (ep = &prop->expr; *ep; ep = &(*ep)->left.expr)
                                 ;
-                        *ep = expr_alloc_one(E_CHOICE, NULL);
+                        *ep = expr_alloc_one(E_LIST, NULL);
                         (*ep)->right.sym = menu->sym;
                 }
                 if (menu->list && (!menu->prompt || !menu->prompt->text)) {
@@ -394,9 +429,9 @@ bool menu_is_visible(struct menu *menu)
 const char *menu_get_prompt(struct menu *menu)
 {
         if (menu->prompt)
-                return _(menu->prompt->text);
+                return menu->prompt->text;
         else if (menu->sym)
-                return _(menu->sym->name);
+                return menu->sym->name;
         return NULL;
 }