1 files changed, 123 insertions, 84 deletions

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 9960d1c303f8..5459a38be866 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -10,6 +10,7 @@
 #include <string.h>
 #include <time.h>
 #include <unistd.h>
+#include <getopt.h>
 #include <sys/stat.h>
 #include <sys/time.h>
 
@@ -19,16 +20,21 @@
 static void conf(struct menu *menu);
 static void check_conf(struct menu *menu);
 
-enum {
-        ask_all,
-        ask_new,
-        ask_silent,
-        set_default,
-        set_yes,
-        set_mod,
-        set_no,
-        set_random
-} input_mode = ask_all;
+enum input_mode {
+        oldaskconfig,
+        silentoldconfig,
+        oldconfig,
+        allnoconfig,
+        allyesconfig,
+        allmodconfig,
+        alldefconfig,
+        randconfig,
+        defconfig,
+        savedefconfig,
+        listnewconfig,
+        oldnoconfig,
+} input_mode = oldaskconfig;
+
 char *defconfig_file;
 
 static int indent = 1;
@@ -93,16 +99,16 @@ static int conf_askvalue(struct symbol *sym, const char *def)
         }
 
         switch (input_mode) {
-        case ask_new:
-        case ask_silent:
+        case oldconfig:
+        case silentoldconfig:
                 if (sym_has_value(sym)) {
                         printf("%s\n", def);
                         return 0;
                 }
                 check_stdin();
-        case ask_all:
+        case oldaskconfig:
                 fflush(stdout);
-                fgets(line, 128, stdin);
+                xfgets(line, 128, stdin);
                 return 1;
         default:
                 break;
@@ -156,14 +162,12 @@ static int conf_string(struct menu *menu)
 static int conf_sym(struct menu *menu)
 {
         struct symbol *sym = menu->sym;
-        int type;
         tristate oldval, newval;
 
         while (1) {
                 printf("%*s%s ", indent - 1, "", _(menu->prompt->text));
                 if (sym->name)
                         printf("(%s) ", sym->name);
-                type = sym_get_type(sym);
                 putchar('[');
                 oldval = sym_get_tristate_value(sym);
                 switch (oldval) {
@@ -228,11 +232,9 @@ static int conf_choice(struct menu *menu)
 {
         struct symbol *sym, *def_sym;
         struct menu *child;
-        int type;
         bool is_new;
 
         sym = menu->sym;
-        type = sym_get_type(sym);
         is_new = !sym_has_value(sym);
         if (sym_is_changable(sym)) {
                 conf_sym(menu);
@@ -294,17 +296,17 @@ static int conf_choice(struct menu *menu)
                         printf("?");
                 printf("]: ");
                 switch (input_mode) {
-                case ask_new:
-                case ask_silent:
+                case oldconfig:
+                case silentoldconfig:
                         if (!is_new) {
                                 cnt = def;
                                 printf("%d\n", cnt);
                                 break;
                         }
                         check_stdin();
-                case ask_all:
+                case oldaskconfig:
                         fflush(stdout);
-                        fgets(line, 128, stdin);
+                        xfgets(line, 128, stdin);
                         strip(line);
                         if (line[0] == '?') {
                                 print_help(menu);
@@ -360,7 +362,10 @@ static void conf(struct menu *menu)
 
                 switch (prop->type) {
                 case P_MENU:
-                        if (input_mode == ask_silent && rootEntry != menu) {
+                        if ((input_mode == silentoldconfig ||
+                             input_mode == listnewconfig ||
+                             input_mode == oldnoconfig) &&
+                            rootEntry != menu) {
                                 check_conf(menu);
                                 return;
                         }
@@ -418,10 +423,16 @@ static void check_conf(struct menu *menu)
         if (sym && !sym_has_value(sym)) {
                 if (sym_is_changable(sym) ||
                     (sym_is_choice(sym) && sym_get_tristate_value(sym) == yes)) {
-                        if (!conf_cnt++)
-                                printf(_("*\n* Restart config...\n*\n"));
-                        rootEntry = menu_get_parent_menu(menu);
-                        conf(rootEntry);
+                        if (input_mode == listnewconfig) {
+                                if (sym->name && !sym_is_choice_value(sym)) {
+                                        printf("%s%s\n", CONFIG_, sym->name);
+                                }
+                        } else if (input_mode != oldnoconfig) {
+                                if (!conf_cnt++)
+                                        printf(_("*\n* Restart config...\n*\n"));
+                                rootEntry = menu_get_parent_menu(menu);
+                                conf(rootEntry);
+                        }
                 }
         }
 
@@ -429,6 +440,22 @@ static void check_conf(struct menu *menu)
                 check_conf(child);
 }
 
+static struct option long_opts[] = {
+        {"oldaskconfig",    no_argument,       NULL, oldaskconfig},
+        {"oldconfig",       no_argument,       NULL, oldconfig},
+        {"silentoldconfig", no_argument,       NULL, silentoldconfig},
+        {"defconfig",       optional_argument, NULL, defconfig},
+        {"savedefconfig",   required_argument, NULL, savedefconfig},
+        {"allnoconfig",     no_argument,       NULL, allnoconfig},
+        {"allyesconfig",    no_argument,       NULL, allyesconfig},
+        {"allmodconfig",    no_argument,       NULL, allmodconfig},
+        {"alldefconfig",    no_argument,       NULL, alldefconfig},
+        {"randconfig",      no_argument,       NULL, randconfig},
+        {"listnewconfig",   no_argument,       NULL, listnewconfig},
+        {"oldnoconfig",     no_argument,       NULL, oldnoconfig},
+        {NULL, 0, NULL, 0}
+};
+
 int main(int ac, char **av)
 {
         int opt;
@@ -439,32 +466,17 @@ int main(int ac, char **av)
         bindtextdomain(PACKAGE, LOCALEDIR);
         textdomain(PACKAGE);
 
-        while ((opt = getopt(ac, av, "osdD:nmyrh")) != -1) {
+        while ((opt = getopt_long(ac, av, "", long_opts, NULL)) != -1) {
+                input_mode = (enum input_mode)opt;
                 switch (opt) {
-                case 'o':
-                        input_mode = ask_silent;
-                        break;
-                case 's':
-                        input_mode = ask_silent;
+                case silentoldconfig:
                         sync_kconfig = 1;
                         break;
-                case 'd':
-                        input_mode = set_default;
-                        break;
-                case 'D':
-                        input_mode = set_default;
+                case defconfig:
+                case savedefconfig:
                         defconfig_file = optarg;
                         break;
-                case 'n':
-                        input_mode = set_no;
-                        break;
-                case 'm':
-                        input_mode = set_mod;
-                        break;
-                case 'y':
-                        input_mode = set_yes;
-                        break;
-                case 'r':
+                case randconfig:
                 {
                         struct timeval now;
                         unsigned int seed;
@@ -477,17 +489,12 @@ int main(int ac, char **av)
 
                         seed = (unsigned int)((now.tv_sec + 1) * (now.tv_usec + 1));
                         srand(seed);
-
-                        input_mode = set_random;
                         break;
                 }
-                case 'h':
-                        printf(_("See README for usage info\n"));
-                        exit(0);
-                        break;
-                default:
+                case '?':
                         fprintf(stderr, _("See README for usage info\n"));
                         exit(1);
+                        break;
                 }
         }
         if (ac == optind) {
@@ -501,8 +508,7 @@ int main(int ac, char **av)
                 name = conf_get_configname();
                 if (stat(name, &tmpstat)) {
                         fprintf(stderr, _("***\n"
-                                "*** You have not yet configured your kernel!\n"
-                                "*** (missing kernel config file \"%s\")\n"
+                                "*** Configuration file \"%s\" not found!\n"
                                 "***\n"
                                 "*** Please run some configurator (e.g. \"make oldconfig\" or\n"
                                 "*** \"make menuconfig\" or \"make xconfig\").\n"
@@ -512,7 +518,7 @@ int main(int ac, char **av)
         }
 
         switch (input_mode) {
-        case set_default:
+        case defconfig:
                 if (!defconfig_file)
                         defconfig_file = conf_get_default_confname();
                 if (conf_read(defconfig_file)) {
@@ -522,25 +528,32 @@ int main(int ac, char **av)
                         exit(1);
                 }
                 break;
-        case ask_silent:
-        case ask_all:
-        case ask_new:
+        case savedefconfig:
+                conf_read(NULL);
+                break;
+        case silentoldconfig:
+        case oldaskconfig:
+        case oldconfig:
+        case listnewconfig:
+        case oldnoconfig:
                 conf_read(NULL);
                 break;
-        case set_no:
-        case set_mod:
-        case set_yes:
-        case set_random:
+        case allnoconfig:
+        case allyesconfig:
+        case allmodconfig:
+        case alldefconfig:
+        case randconfig:
                 name = getenv("KCONFIG_ALLCONFIG");
                 if (name && !stat(name, &tmpstat)) {
                         conf_read_simple(name, S_DEF_USER);
                         break;
                 }
                 switch (input_mode) {
-                case set_no:     name = "allno.config"; break;
-                case set_mod:    name = "allmod.config"; break;
-                case set_yes:    name = "allyes.config"; break;
-                case set_random: name = "allrandom.config"; break;
+                case allnoconfig:       name = "allno.config"; break;
+                case allyesconfig:      name = "allyes.config"; break;
+                case allmodconfig:      name = "allmod.config"; break;
+                case alldefconfig:      name = "alldef.config"; break;
+                case randconfig:        name = "allrandom.config"; break;
                 default: break;
                 }
                 if (!stat(name, &tmpstat))
@@ -557,7 +570,7 @@ int main(int ac, char **av)
                         name = getenv("KCONFIG_NOSILENTUPDATE");
                         if (name && *name) {
                                 fprintf(stderr,
-                                        _("\n*** Kernel configuration requires explicit update.\n\n"));
+                                        _("\n*** The configuration requires explicit update.\n\n"));
                                 return 1;
                         }
                 }
@@ -565,33 +578,42 @@ int main(int ac, char **av)
         }
 
         switch (input_mode) {
-        case set_no:
+        case allnoconfig:
                 conf_set_all_new_symbols(def_no);
                 break;
-        case set_yes:
+        case allyesconfig:
                 conf_set_all_new_symbols(def_yes);
                 break;
-        case set_mod:
+        case allmodconfig:
                 conf_set_all_new_symbols(def_mod);
                 break;
-        case set_random:
+        case alldefconfig:
+                conf_set_all_new_symbols(def_default);
+                break;
+        case randconfig:
                 conf_set_all_new_symbols(def_random);
                 break;
-        case set_default:
+        case defconfig:
                 conf_set_all_new_symbols(def_default);
                 break;
-        case ask_new:
-        case ask_all:
+        case savedefconfig:
+                break;
+        case oldaskconfig:
                 rootEntry = &rootmenu;
                 conf(&rootmenu);
-                input_mode = ask_silent;
+                input_mode = silentoldconfig;
                 /* fall through */
-        case ask_silent:
+        case oldconfig:
+        case listnewconfig:
+        case oldnoconfig:
+        case silentoldconfig:
                 /* Update until a loop caused no more changes */
                 do {
                         conf_cnt = 0;
                         check_conf(&rootmenu);
-                } while (conf_cnt);
+                } while (conf_cnt &&
+                         (input_mode != listnewconfig &&
+                          input_mode != oldnoconfig));
                 break;
         }
 
@@ -600,18 +622,35 @@ int main(int ac, char **av)
                  * All other commands are only used to generate a config.
                  */
                 if (conf_get_changed() && conf_write(NULL)) {
-                        fprintf(stderr, _("\n*** Error during writing of the kernel configuration.\n\n"));
+                        fprintf(stderr, _("\n*** Error during writing of the configuration.\n\n"));
                         exit(1);
                 }
                 if (conf_write_autoconf()) {
-                        fprintf(stderr, _("\n*** Error during update of the kernel configuration.\n\n"));
+                        fprintf(stderr, _("\n*** Error during update of the configuration.\n\n"));
                         return 1;
                 }
-        } else {
+        } else if (input_mode == savedefconfig) {
+                if (conf_write_defconfig(defconfig_file)) {
+                        fprintf(stderr, _("n*** Error while saving defconfig to: %s\n\n"),
+                                defconfig_file);
+                        return 1;
+                }
+        } else if (input_mode != listnewconfig) {
                 if (conf_write(NULL)) {
-                        fprintf(stderr, _("\n*** Error during writing of the kernel configuration.\n\n"));
+                        fprintf(stderr, _("\n*** Error during writing of the configuration.\n\n"));
                         exit(1);
                 }
         }
         return 0;
 }
+/*
+ * Helper function to facilitate fgets() by Jean Sacren.
+ */
+void xfgets(str, size, in)
+        char *str;
+        int size;
+        FILE *in;
+{
+        if (fgets(str, size, in) == NULL)
+                fprintf(stderr, "\nError in reading or end of file.\n");
+}