aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
Diffstat (limited to 'net')
-rw-r--r--net/bluetooth/rfcomm/tty.c21
1 files changed, 14 insertions, 7 deletions
diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c
index 84fcf9fff3ea..a535ef148ef6 100644
--- a/net/bluetooth/rfcomm/tty.c
+++ b/net/bluetooth/rfcomm/tty.c
@@ -437,7 +437,8 @@ static int rfcomm_release_dev(void __user *arg)
437 tty_kref_put(tty); 437 tty_kref_put(tty);
438 } 438 }
439 439
440 if (!test_and_set_bit(RFCOMM_TTY_RELEASED, &dev->flags)) 440 if (!test_bit(RFCOMM_RELEASE_ONHUP, &dev->flags) &&
441 !test_and_set_bit(RFCOMM_TTY_RELEASED, &dev->flags))
441 tty_port_put(&dev->port); 442 tty_port_put(&dev->port);
442 443
443 tty_port_put(&dev->port); 444 tty_port_put(&dev->port);
@@ -670,10 +671,20 @@ static int rfcomm_tty_install(struct tty_driver *driver, struct tty_struct *tty)
670 671
671 /* install the tty_port */ 672 /* install the tty_port */
672 err = tty_port_install(&dev->port, driver, tty); 673 err = tty_port_install(&dev->port, driver, tty);
673 if (err) 674 if (err) {
674 rfcomm_tty_cleanup(tty); 675 rfcomm_tty_cleanup(tty);
676 return err;
677 }
675 678
676 return err; 679 /* take over the tty_port reference if the port was created with the
680 * flag RFCOMM_RELEASE_ONHUP. This will force the release of the port
681 * when the last process closes the tty. The behaviour is expected by
682 * userspace.
683 */
684 if (test_bit(RFCOMM_RELEASE_ONHUP, &dev->flags))
685 tty_port_put(&dev->port);
686
687 return 0;
677} 688}
678 689
679static int rfcomm_tty_open(struct tty_struct *tty, struct file *filp) 690static int rfcomm_tty_open(struct tty_struct *tty, struct file *filp)
@@ -1010,10 +1021,6 @@ static void rfcomm_tty_hangup(struct tty_struct *tty)
1010 BT_DBG("tty %p dev %p", tty, dev); 1021 BT_DBG("tty %p dev %p", tty, dev);
1011 1022
1012 tty_port_hangup(&dev->port); 1023 tty_port_hangup(&dev->port);
1013
1014 if (test_bit(RFCOMM_RELEASE_ONHUP, &dev->flags) &&
1015 !test_and_set_bit(RFCOMM_TTY_RELEASED, &dev->flags))
1016 tty_port_put(&dev->port);
1017} 1024}
1018 1025
1019static int rfcomm_tty_tiocmget(struct tty_struct *tty) 1026static int rfcomm_tty_tiocmget(struct tty_struct *tty)