diff options
Diffstat (limited to 'net')
74 files changed, 456 insertions, 328 deletions
diff --git a/net/Kconfig b/net/Kconfig index a81aca43932f..67e39ad8b8b6 100644 --- a/net/Kconfig +++ b/net/Kconfig | |||
| @@ -63,6 +63,7 @@ config INET | |||
| 63 | if INET | 63 | if INET |
| 64 | source "net/ipv4/Kconfig" | 64 | source "net/ipv4/Kconfig" |
| 65 | source "net/ipv6/Kconfig" | 65 | source "net/ipv6/Kconfig" |
| 66 | source "net/netlabel/Kconfig" | ||
| 66 | 67 | ||
| 67 | endif # if INET | 68 | endif # if INET |
| 68 | 69 | ||
| @@ -249,8 +250,6 @@ source "net/ieee80211/Kconfig" | |||
| 249 | config WIRELESS_EXT | 250 | config WIRELESS_EXT |
| 250 | bool | 251 | bool |
| 251 | 252 | ||
| 252 | source "net/netlabel/Kconfig" | ||
| 253 | |||
| 254 | config FIB_RULES | 253 | config FIB_RULES |
| 255 | bool | 254 | bool |
| 256 | 255 | ||
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 708e2e0371af..485e35c3b28b 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c | |||
| @@ -1584,7 +1584,6 @@ static int atalk_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr | |||
| 1584 | 1584 | ||
| 1585 | if (usat->sat_addr.s_net || usat->sat_addr.s_node == ATADDR_ANYNODE) { | 1585 | if (usat->sat_addr.s_net || usat->sat_addr.s_node == ATADDR_ANYNODE) { |
| 1586 | rt = atrtr_find(&usat->sat_addr); | 1586 | rt = atrtr_find(&usat->sat_addr); |
| 1587 | dev = rt->dev; | ||
| 1588 | } else { | 1587 | } else { |
| 1589 | struct atalk_addr at_hint; | 1588 | struct atalk_addr at_hint; |
| 1590 | 1589 | ||
| @@ -1592,7 +1591,6 @@ static int atalk_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr | |||
| 1592 | at_hint.s_net = at->src_net; | 1591 | at_hint.s_net = at->src_net; |
| 1593 | 1592 | ||
| 1594 | rt = atrtr_find(&at_hint); | 1593 | rt = atrtr_find(&at_hint); |
| 1595 | dev = rt->dev; | ||
| 1596 | } | 1594 | } |
| 1597 | if (!rt) | 1595 | if (!rt) |
| 1598 | return -ENETUNREACH; | 1596 | return -ENETUNREACH; |
diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c index c0a4ae28fcfa..62f6ed1f2f98 100644 --- a/net/atm/atm_sysfs.c +++ b/net/atm/atm_sysfs.c | |||
| @@ -141,7 +141,7 @@ static struct class atm_class = { | |||
| 141 | int atm_register_sysfs(struct atm_dev *adev) | 141 | int atm_register_sysfs(struct atm_dev *adev) |
| 142 | { | 142 | { |
| 143 | struct class_device *cdev = &adev->class_dev; | 143 | struct class_device *cdev = &adev->class_dev; |
| 144 | int i, err; | 144 | int i, j, err; |
| 145 | 145 | ||
| 146 | cdev->class = &atm_class; | 146 | cdev->class = &atm_class; |
| 147 | class_set_devdata(cdev, adev); | 147 | class_set_devdata(cdev, adev); |
| @@ -151,10 +151,19 @@ int atm_register_sysfs(struct atm_dev *adev) | |||
| 151 | if (err < 0) | 151 | if (err < 0) |
| 152 | return err; | 152 | return err; |
| 153 | 153 | ||
| 154 | for (i = 0; atm_attrs[i]; i++) | 154 | for (i = 0; atm_attrs[i]; i++) { |
| 155 | class_device_create_file(cdev, atm_attrs[i]); | 155 | err = class_device_create_file(cdev, atm_attrs[i]); |
| 156 | if (err) | ||
| 157 | goto err_out; | ||
| 158 | } | ||
| 156 | 159 | ||
| 157 | return 0; | 160 | return 0; |
| 161 | |||
| 162 | err_out: | ||
| 163 | for (j = 0; j < i; j++) | ||
| 164 | class_device_remove_file(cdev, atm_attrs[j]); | ||
| 165 | class_device_del(cdev); | ||
| 166 | return err; | ||
| 158 | } | 167 | } |
| 159 | 168 | ||
| 160 | void atm_unregister_sysfs(struct atm_dev *adev) | 169 | void atm_unregister_sysfs(struct atm_dev *adev) |
diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c index 96bcb2ff59ab..de9d1a9473f2 100644 --- a/net/bridge/br_sysfs_br.c +++ b/net/bridge/br_sysfs_br.c | |||
| @@ -376,7 +376,7 @@ int br_sysfs_addbr(struct net_device *dev) | |||
| 376 | 376 | ||
| 377 | err = sysfs_create_bin_file(brobj, &bridge_forward); | 377 | err = sysfs_create_bin_file(brobj, &bridge_forward); |
| 378 | if (err) { | 378 | if (err) { |
| 379 | pr_info("%s: can't create attribue file %s/%s\n", | 379 | pr_info("%s: can't create attribute file %s/%s\n", |
| 380 | __FUNCTION__, dev->name, bridge_forward.attr.name); | 380 | __FUNCTION__, dev->name, bridge_forward.attr.name); |
| 381 | goto out2; | 381 | goto out2; |
| 382 | } | 382 | } |
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c index 3df55b2bd91d..9f85666f29f7 100644 --- a/net/bridge/netfilter/ebtables.c +++ b/net/bridge/netfilter/ebtables.c | |||
| @@ -86,7 +86,7 @@ static inline int ebt_do_match (struct ebt_entry_match *m, | |||
| 86 | static inline int ebt_dev_check(char *entry, const struct net_device *device) | 86 | static inline int ebt_dev_check(char *entry, const struct net_device *device) |
| 87 | { | 87 | { |
| 88 | int i = 0; | 88 | int i = 0; |
| 89 | char *devname = device->name; | 89 | const char *devname = device->name; |
| 90 | 90 | ||
| 91 | if (*entry == '\0') | 91 | if (*entry == '\0') |
| 92 | return 0; | 92 | return 0; |
diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 9308af060b44..6589adb14cbf 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c | |||
| @@ -340,6 +340,12 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len) | |||
| 340 | udph->dest = htons(np->remote_port); | 340 | udph->dest = htons(np->remote_port); |
| 341 | udph->len = htons(udp_len); | 341 | udph->len = htons(udp_len); |
| 342 | udph->check = 0; | 342 | udph->check = 0; |
| 343 | udph->check = csum_tcpudp_magic(htonl(np->local_ip), | ||
| 344 | htonl(np->remote_ip), | ||
| 345 | udp_len, IPPROTO_UDP, | ||
| 346 | csum_partial((unsigned char *)udph, udp_len, 0)); | ||
| 347 | if (udph->check == 0) | ||
| 348 | udph->check = -1; | ||
| 343 | 349 | ||
| 344 | skb->nh.iph = iph = (struct iphdr *)skb_push(skb, sizeof(*iph)); | 350 | skb->nh.iph = iph = (struct iphdr *)skb_push(skb, sizeof(*iph)); |
| 345 | 351 | ||
diff --git a/net/core/pktgen.c b/net/core/pktgen.c index dd023fd28304..733d86d0a4fb 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c | |||
| @@ -2304,6 +2304,12 @@ static void mpls_push(__be32 *mpls, struct pktgen_dev *pkt_dev) | |||
| 2304 | *mpls |= MPLS_STACK_BOTTOM; | 2304 | *mpls |= MPLS_STACK_BOTTOM; |
| 2305 | } | 2305 | } |
| 2306 | 2306 | ||
| 2307 | static inline __be16 build_tci(unsigned int id, unsigned int cfi, | ||
| 2308 | unsigned int prio) | ||
| 2309 | { | ||
| 2310 | return htons(id | (cfi << 12) | (prio << 13)); | ||
| 2311 | } | ||
| 2312 | |||
| 2307 | static struct sk_buff *fill_packet_ipv4(struct net_device *odev, | 2313 | static struct sk_buff *fill_packet_ipv4(struct net_device *odev, |
| 2308 | struct pktgen_dev *pkt_dev) | 2314 | struct pktgen_dev *pkt_dev) |
| 2309 | { | 2315 | { |
| @@ -2353,16 +2359,16 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev, | |||
| 2353 | if (pkt_dev->vlan_id != 0xffff) { | 2359 | if (pkt_dev->vlan_id != 0xffff) { |
| 2354 | if(pkt_dev->svlan_id != 0xffff) { | 2360 | if(pkt_dev->svlan_id != 0xffff) { |
| 2355 | svlan_tci = (__be16 *)skb_put(skb, sizeof(__be16)); | 2361 | svlan_tci = (__be16 *)skb_put(skb, sizeof(__be16)); |
| 2356 | *svlan_tci = htons(pkt_dev->svlan_id); | 2362 | *svlan_tci = build_tci(pkt_dev->svlan_id, |
| 2357 | *svlan_tci |= pkt_dev->svlan_p << 5; | 2363 | pkt_dev->svlan_cfi, |
| 2358 | *svlan_tci |= pkt_dev->svlan_cfi << 4; | 2364 | pkt_dev->svlan_p); |
| 2359 | svlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16)); | 2365 | svlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16)); |
| 2360 | *svlan_encapsulated_proto = __constant_htons(ETH_P_8021Q); | 2366 | *svlan_encapsulated_proto = __constant_htons(ETH_P_8021Q); |
| 2361 | } | 2367 | } |
| 2362 | vlan_tci = (__be16 *)skb_put(skb, sizeof(__be16)); | 2368 | vlan_tci = (__be16 *)skb_put(skb, sizeof(__be16)); |
| 2363 | *vlan_tci = htons(pkt_dev->vlan_id); | 2369 | *vlan_tci = build_tci(pkt_dev->vlan_id, |
| 2364 | *vlan_tci |= pkt_dev->vlan_p << 5; | 2370 | pkt_dev->vlan_cfi, |
| 2365 | *vlan_tci |= pkt_dev->vlan_cfi << 4; | 2371 | pkt_dev->vlan_p); |
| 2366 | vlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16)); | 2372 | vlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16)); |
| 2367 | *vlan_encapsulated_proto = __constant_htons(ETH_P_IP); | 2373 | *vlan_encapsulated_proto = __constant_htons(ETH_P_IP); |
| 2368 | } | 2374 | } |
| @@ -2689,16 +2695,16 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev, | |||
| 2689 | if (pkt_dev->vlan_id != 0xffff) { | 2695 | if (pkt_dev->vlan_id != 0xffff) { |
| 2690 | if(pkt_dev->svlan_id != 0xffff) { | 2696 | if(pkt_dev->svlan_id != 0xffff) { |
| 2691 | svlan_tci = (__be16 *)skb_put(skb, sizeof(__be16)); | 2697 | svlan_tci = (__be16 *)skb_put(skb, sizeof(__be16)); |
| 2692 | *svlan_tci = htons(pkt_dev->svlan_id); | 2698 | *svlan_tci = build_tci(pkt_dev->svlan_id, |
| 2693 | *svlan_tci |= pkt_dev->svlan_p << 5; | 2699 | pkt_dev->svlan_cfi, |
| 2694 | *svlan_tci |= pkt_dev->svlan_cfi << 4; | 2700 | pkt_dev->svlan_p); |
| 2695 | svlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16)); | 2701 | svlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16)); |
| 2696 | *svlan_encapsulated_proto = __constant_htons(ETH_P_8021Q); | 2702 | *svlan_encapsulated_proto = __constant_htons(ETH_P_8021Q); |
| 2697 | } | 2703 | } |
| 2698 | vlan_tci = (__be16 *)skb_put(skb, sizeof(__be16)); | 2704 | vlan_tci = (__be16 *)skb_put(skb, sizeof(__be16)); |
| 2699 | *vlan_tci = htons(pkt_dev->vlan_id); | 2705 | *vlan_tci = build_tci(pkt_dev->vlan_id, |
| 2700 | *vlan_tci |= pkt_dev->vlan_p << 5; | 2706 | pkt_dev->vlan_cfi, |
| 2701 | *vlan_tci |= pkt_dev->vlan_cfi << 4; | 2707 | pkt_dev->vlan_p); |
| 2702 | vlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16)); | 2708 | vlan_encapsulated_proto = (__be16 *)skb_put(skb, sizeof(__be16)); |
| 2703 | *vlan_encapsulated_proto = __constant_htons(ETH_P_IPV6); | 2709 | *vlan_encapsulated_proto = __constant_htons(ETH_P_IPV6); |
| 2704 | } | 2710 | } |
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 3c23760c5827..b8b106358040 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c | |||
| @@ -639,6 +639,7 @@ struct sk_buff *pskb_copy(struct sk_buff *skb, gfp_t gfp_mask) | |||
| 639 | n->csum = skb->csum; | 639 | n->csum = skb->csum; |
| 640 | n->ip_summed = skb->ip_summed; | 640 | n->ip_summed = skb->ip_summed; |
| 641 | 641 | ||
| 642 | n->truesize += skb->data_len; | ||
| 642 | n->data_len = skb->data_len; | 643 | n->data_len = skb->data_len; |
| 643 | n->len = skb->len; | 644 | n->len = skb->len; |
| 644 | 645 | ||
| @@ -1946,7 +1947,7 @@ struct sk_buff *skb_segment(struct sk_buff *skb, int features) | |||
| 1946 | do { | 1947 | do { |
| 1947 | struct sk_buff *nskb; | 1948 | struct sk_buff *nskb; |
| 1948 | skb_frag_t *frag; | 1949 | skb_frag_t *frag; |
| 1949 | int hsize, nsize; | 1950 | int hsize; |
| 1950 | int k; | 1951 | int k; |
| 1951 | int size; | 1952 | int size; |
| 1952 | 1953 | ||
| @@ -1957,11 +1958,10 @@ struct sk_buff *skb_segment(struct sk_buff *skb, int features) | |||
| 1957 | hsize = skb_headlen(skb) - offset; | 1958 | hsize = skb_headlen(skb) - offset; |
| 1958 | if (hsize < 0) | 1959 | if (hsize < 0) |
| 1959 | hsize = 0; | 1960 | hsize = 0; |
| 1960 | nsize = hsize + doffset; | 1961 | if (hsize > len || !sg) |
| 1961 | if (nsize > len + doffset || !sg) | 1962 | hsize = len; |
| 1962 | nsize = len + doffset; | ||
| 1963 | 1963 | ||
| 1964 | nskb = alloc_skb(nsize + headroom, GFP_ATOMIC); | 1964 | nskb = alloc_skb(hsize + doffset + headroom, GFP_ATOMIC); |
| 1965 | if (unlikely(!nskb)) | 1965 | if (unlikely(!nskb)) |
| 1966 | goto err; | 1966 | goto err; |
| 1967 | 1967 | ||
diff --git a/net/core/sock.c b/net/core/sock.c index d472db4776c3..ee6cd2541d35 100644 --- a/net/core/sock.c +++ b/net/core/sock.c | |||
| @@ -1160,7 +1160,7 @@ static struct sk_buff *sock_alloc_send_pskb(struct sock *sk, | |||
| 1160 | goto failure; | 1160 | goto failure; |
| 1161 | 1161 | ||
| 1162 | if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf) { | 1162 | if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf) { |
| 1163 | skb = alloc_skb(header_len, sk->sk_allocation); | 1163 | skb = alloc_skb(header_len, gfp_mask); |
| 1164 | if (skb) { | 1164 | if (skb) { |
| 1165 | int npages; | 1165 | int npages; |
| 1166 | int i; | 1166 | int i; |
diff --git a/net/dccp/Kconfig b/net/dccp/Kconfig index e2a095d0fd80..ef8919cca74b 100644 --- a/net/dccp/Kconfig +++ b/net/dccp/Kconfig | |||
| @@ -4,15 +4,15 @@ menu "DCCP Configuration (EXPERIMENTAL)" | |||
| 4 | config IP_DCCP | 4 | config IP_DCCP |
| 5 | tristate "The DCCP Protocol (EXPERIMENTAL)" | 5 | tristate "The DCCP Protocol (EXPERIMENTAL)" |
| 6 | ---help--- | 6 | ---help--- |
| 7 | Datagram Congestion Control Protocol | 7 | Datagram Congestion Control Protocol (RFC 4340) |
| 8 | 8 | ||
| 9 | From draft-ietf-dccp-spec-11 <http://www.icir.org/kohler/dcp/draft-ietf-dccp-spec-11.txt>. | 9 | From http://www.ietf.org/rfc/rfc4340.txt: |
| 10 | 10 | ||
| 11 | The Datagram Congestion Control Protocol (DCCP) is a transport | 11 | The Datagram Congestion Control Protocol (DCCP) is a transport |
| 12 | protocol that implements bidirectional, unicast connections of | 12 | protocol that implements bidirectional, unicast connections of |
| 13 | congestion-controlled, unreliable datagrams. It should be suitable | 13 | congestion-controlled, unreliable datagrams. It should be suitable |
| 14 | for use by applications such as streaming media, Internet telephony, | 14 | for use by applications such as streaming media, Internet telephony, |
| 15 | and on-line games | 15 | and on-line games. |
| 16 | 16 | ||
| 17 | To compile this protocol support as a module, choose M here: the | 17 | To compile this protocol support as a module, choose M here: the |
| 18 | module will be called dccp. | 18 | module will be called dccp. |
diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c index 4d176d33983f..f8208874ac7d 100644 --- a/net/dccp/ackvec.c +++ b/net/dccp/ackvec.c | |||
| @@ -113,7 +113,7 @@ int dccp_insert_option_ackvec(struct sock *sk, struct sk_buff *skb) | |||
| 113 | 113 | ||
| 114 | memcpy(to, from, len); | 114 | memcpy(to, from, len); |
| 115 | /* | 115 | /* |
| 116 | * From draft-ietf-dccp-spec-11.txt: | 116 | * From RFC 4340, A.2: |
| 117 | * | 117 | * |
| 118 | * For each acknowledgement it sends, the HC-Receiver will add an | 118 | * For each acknowledgement it sends, the HC-Receiver will add an |
| 119 | * acknowledgement record. ack_seqno will equal the HC-Receiver | 119 | * acknowledgement record. ack_seqno will equal the HC-Receiver |
| @@ -224,7 +224,7 @@ static inline int dccp_ackvec_set_buf_head_state(struct dccp_ackvec *av, | |||
| 224 | } | 224 | } |
| 225 | 225 | ||
| 226 | /* | 226 | /* |
| 227 | * Implements the draft-ietf-dccp-spec-11.txt Appendix A | 227 | * Implements the RFC 4340, Appendix A |
| 228 | */ | 228 | */ |
| 229 | int dccp_ackvec_add(struct dccp_ackvec *av, const struct sock *sk, | 229 | int dccp_ackvec_add(struct dccp_ackvec *av, const struct sock *sk, |
| 230 | const u64 ackno, const u8 state) | 230 | const u64 ackno, const u8 state) |
| @@ -237,7 +237,7 @@ int dccp_ackvec_add(struct dccp_ackvec *av, const struct sock *sk, | |||
| 237 | * We may well decide to do buffer compression, etc, but for now lets | 237 | * We may well decide to do buffer compression, etc, but for now lets |
| 238 | * just drop. | 238 | * just drop. |
| 239 | * | 239 | * |
| 240 | * From Appendix A: | 240 | * From Appendix A.1.1 (`New Packets'): |
| 241 | * | 241 | * |
| 242 | * Of course, the circular buffer may overflow, either when the | 242 | * Of course, the circular buffer may overflow, either when the |
| 243 | * HC-Sender is sending data at a very high rate, when the | 243 | * HC-Sender is sending data at a very high rate, when the |
| @@ -274,9 +274,9 @@ int dccp_ackvec_add(struct dccp_ackvec *av, const struct sock *sk, | |||
| 274 | /* | 274 | /* |
| 275 | * A.1.2. Old Packets | 275 | * A.1.2. Old Packets |
| 276 | * | 276 | * |
| 277 | * When a packet with Sequence Number S arrives, and | 277 | * When a packet with Sequence Number S <= buf_ackno |
| 278 | * S <= buf_ackno, the HC-Receiver will scan the table | 278 | * arrives, the HC-Receiver will scan the table for |
| 279 | * for the byte corresponding to S. (Indexing structures | 279 | * the byte corresponding to S. (Indexing structures |
| 280 | * could reduce the complexity of this scan.) | 280 | * could reduce the complexity of this scan.) |
| 281 | */ | 281 | */ |
| 282 | u64 delta = dccp_delta_seqno(ackno, av->dccpav_buf_ackno); | 282 | u64 delta = dccp_delta_seqno(ackno, av->dccpav_buf_ackno); |
diff --git a/net/dccp/ackvec.h b/net/dccp/ackvec.h index 2424effac7f6..cf8f20ce23a9 100644 --- a/net/dccp/ackvec.h +++ b/net/dccp/ackvec.h | |||
| @@ -28,8 +28,7 @@ | |||
| 28 | 28 | ||
| 29 | /** struct dccp_ackvec - ack vector | 29 | /** struct dccp_ackvec - ack vector |
| 30 | * | 30 | * |
| 31 | * This data structure is the one defined in the DCCP draft | 31 | * This data structure is the one defined in RFC 4340, Appendix A. |
| 32 | * Appendix A. | ||
| 33 | * | 32 | * |
| 34 | * @dccpav_buf_head - circular buffer head | 33 | * @dccpav_buf_head - circular buffer head |
| 35 | * @dccpav_buf_tail - circular buffer tail | 34 | * @dccpav_buf_tail - circular buffer tail |
diff --git a/net/dccp/ccids/Kconfig b/net/dccp/ccids/Kconfig index 32752f750447..8533dabfb9f8 100644 --- a/net/dccp/ccids/Kconfig +++ b/net/dccp/ccids/Kconfig | |||
| @@ -22,11 +22,11 @@ config IP_DCCP_CCID2 | |||
| 22 | for lost packets, would prefer CCID 2 to CCID 3. On-line games may | 22 | for lost packets, would prefer CCID 2 to CCID 3. On-line games may |
| 23 | also prefer CCID 2. | 23 | also prefer CCID 2. |
| 24 | 24 | ||
| 25 | CCID 2 is further described in: | 25 | CCID 2 is further described in RFC 4341, |
| 26 | http://www.icir.org/kohler/dccp/draft-ietf-dccp-ccid2-10.txt | 26 | http://www.ietf.org/rfc/rfc4341.txt |
| 27 | 27 | ||
| 28 | This text was extracted from: | 28 | This text was extracted from RFC 4340 (sec. 10.1), |
| 29 | http://www.icir.org/kohler/dccp/draft-ietf-dccp-spec-13.txt | 29 | http://www.ietf.org/rfc/rfc4340.txt |
| 30 | 30 | ||
| 31 | If in doubt, say M. | 31 | If in doubt, say M. |
| 32 | 32 | ||
| @@ -53,15 +53,14 @@ config IP_DCCP_CCID3 | |||
| 53 | suitable than CCID 2 for applications such streaming media where a | 53 | suitable than CCID 2 for applications such streaming media where a |
| 54 | relatively smooth sending rate is of importance. | 54 | relatively smooth sending rate is of importance. |
| 55 | 55 | ||
| 56 | CCID 3 is further described in: | 56 | CCID 3 is further described in RFC 4342, |
| 57 | 57 | http://www.ietf.org/rfc/rfc4342.txt | |
| 58 | http://www.icir.org/kohler/dccp/draft-ietf-dccp-ccid3-11.txt. | ||
| 59 | 58 | ||
| 60 | The TFRC congestion control algorithms were initially described in | 59 | The TFRC congestion control algorithms were initially described in |
| 61 | RFC 3448. | 60 | RFC 3448. |
| 62 | 61 | ||
| 63 | This text was extracted from: | 62 | This text was extracted from RFC 4340 (sec. 10.2), |
| 64 | http://www.icir.org/kohler/dccp/draft-ietf-dccp-spec-13.txt | 63 | http://www.ietf.org/rfc/rfc4340.txt |
| 65 | 64 | ||
| 66 | If in doubt, say M. | 65 | If in doubt, say M. |
| 67 | 66 | ||
diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c index 2efb505aeb35..162032baeac0 100644 --- a/net/dccp/ccids/ccid2.c +++ b/net/dccp/ccids/ccid2.c | |||
| @@ -23,7 +23,7 @@ | |||
| 23 | */ | 23 | */ |
| 24 | 24 | ||
| 25 | /* | 25 | /* |
| 26 | * This implementation should follow: draft-ietf-dccp-ccid2-10.txt | 26 | * This implementation should follow RFC 4341 |
| 27 | * | 27 | * |
| 28 | * BUGS: | 28 | * BUGS: |
| 29 | * - sequence number wrapping | 29 | * - sequence number wrapping |
| @@ -352,14 +352,14 @@ static void ccid2_hc_tx_packet_sent(struct sock *sk, int more, int len) | |||
| 352 | 352 | ||
| 353 | #ifdef CONFIG_IP_DCCP_CCID2_DEBUG | 353 | #ifdef CONFIG_IP_DCCP_CCID2_DEBUG |
| 354 | ccid2_pr_debug("pipe=%d\n", hctx->ccid2hctx_pipe); | 354 | ccid2_pr_debug("pipe=%d\n", hctx->ccid2hctx_pipe); |
| 355 | ccid2_pr_debug("Sent: seq=%llu\n", seq); | 355 | ccid2_pr_debug("Sent: seq=%llu\n", (unsigned long long)seq); |
| 356 | do { | 356 | do { |
| 357 | struct ccid2_seq *seqp = hctx->ccid2hctx_seqt; | 357 | struct ccid2_seq *seqp = hctx->ccid2hctx_seqt; |
| 358 | 358 | ||
| 359 | while (seqp != hctx->ccid2hctx_seqh) { | 359 | while (seqp != hctx->ccid2hctx_seqh) { |
| 360 | ccid2_pr_debug("out seq=%llu acked=%d time=%lu\n", | 360 | ccid2_pr_debug("out seq=%llu acked=%d time=%lu\n", |
| 361 | seqp->ccid2s_seq, seqp->ccid2s_acked, | 361 | (unsigned long long)seqp->ccid2s_seq, |
| 362 | seqp->ccid2s_sent); | 362 | seqp->ccid2s_acked, seqp->ccid2s_sent); |
| 363 | seqp = seqp->ccid2s_next; | 363 | seqp = seqp->ccid2s_next; |
| 364 | } | 364 | } |
| 365 | } while (0); | 365 | } while (0); |
| @@ -480,7 +480,8 @@ static inline void ccid2_new_ack(struct sock *sk, | |||
| 480 | /* first measurement */ | 480 | /* first measurement */ |
| 481 | if (hctx->ccid2hctx_srtt == -1) { | 481 | if (hctx->ccid2hctx_srtt == -1) { |
| 482 | ccid2_pr_debug("R: %lu Time=%lu seq=%llu\n", | 482 | ccid2_pr_debug("R: %lu Time=%lu seq=%llu\n", |
| 483 | r, jiffies, seqp->ccid2s_seq); | 483 | r, jiffies, |
| 484 | (unsigned long long)seqp->ccid2s_seq); | ||
| 484 | ccid2_change_srtt(hctx, r); | 485 | ccid2_change_srtt(hctx, r); |
| 485 | hctx->ccid2hctx_rttvar = r >> 1; | 486 | hctx->ccid2hctx_rttvar = r >> 1; |
| 486 | } else { | 487 | } else { |
| @@ -636,8 +637,9 @@ static void ccid2_hc_tx_packet_recv(struct sock *sk, struct sk_buff *skb) | |||
| 636 | u64 ackno_end_rl; | 637 | u64 ackno_end_rl; |
| 637 | 638 | ||
| 638 | dccp_set_seqno(&ackno_end_rl, ackno - rl); | 639 | dccp_set_seqno(&ackno_end_rl, ackno - rl); |
| 639 | ccid2_pr_debug("ackvec start:%llu end:%llu\n", ackno, | 640 | ccid2_pr_debug("ackvec start:%llu end:%llu\n", |
| 640 | ackno_end_rl); | 641 | (unsigned long long)ackno, |
| 642 | (unsigned long long)ackno_end_rl); | ||
| 641 | /* if the seqno we are analyzing is larger than the | 643 | /* if the seqno we are analyzing is larger than the |
| 642 | * current ackno, then move towards the tail of our | 644 | * current ackno, then move towards the tail of our |
| 643 | * seqnos. | 645 | * seqnos. |
| @@ -672,7 +674,7 @@ static void ccid2_hc_tx_packet_recv(struct sock *sk, struct sk_buff *skb) | |||
| 672 | 674 | ||
| 673 | seqp->ccid2s_acked = 1; | 675 | seqp->ccid2s_acked = 1; |
| 674 | ccid2_pr_debug("Got ack for %llu\n", | 676 | ccid2_pr_debug("Got ack for %llu\n", |
| 675 | seqp->ccid2s_seq); | 677 | (unsigned long long)seqp->ccid2s_seq); |
| 676 | ccid2_hc_tx_dec_pipe(sk); | 678 | ccid2_hc_tx_dec_pipe(sk); |
| 677 | } | 679 | } |
| 678 | if (seqp == hctx->ccid2hctx_seqt) { | 680 | if (seqp == hctx->ccid2hctx_seqt) { |
| @@ -718,7 +720,7 @@ static void ccid2_hc_tx_packet_recv(struct sock *sk, struct sk_buff *skb) | |||
| 718 | while (1) { | 720 | while (1) { |
| 719 | if (!seqp->ccid2s_acked) { | 721 | if (!seqp->ccid2s_acked) { |
| 720 | ccid2_pr_debug("Packet lost: %llu\n", | 722 | ccid2_pr_debug("Packet lost: %llu\n", |
| 721 | seqp->ccid2s_seq); | 723 | (unsigned long long)seqp->ccid2s_seq); |
| 722 | /* XXX need to traverse from tail -> head in | 724 | /* XXX need to traverse from tail -> head in |
| 723 | * order to detect multiple congestion events in | 725 | * order to detect multiple congestion events in |
| 724 | * one ack vector. | 726 | * one ack vector. |
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 67d2dc0e7c67..cec23ad286de 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c | |||
| @@ -379,8 +379,7 @@ static void ccid3_hc_tx_packet_sent(struct sock *sk, int more, int len) | |||
| 379 | packet->dccphtx_seqno = dp->dccps_gss; | 379 | packet->dccphtx_seqno = dp->dccps_gss; |
| 380 | /* | 380 | /* |
| 381 | * Check if win_count have changed | 381 | * Check if win_count have changed |
| 382 | * Algorithm in "8.1. Window Counter Valuer" in | 382 | * Algorithm in "8.1. Window Counter Value" in RFC 4342. |
| 383 | * draft-ietf-dccp-ccid3-11.txt | ||
| 384 | */ | 383 | */ |
| 385 | quarter_rtt = timeval_delta(&now, &hctx->ccid3hctx_t_last_win_count); | 384 | quarter_rtt = timeval_delta(&now, &hctx->ccid3hctx_t_last_win_count); |
| 386 | if (likely(hctx->ccid3hctx_rtt > 8)) | 385 | if (likely(hctx->ccid3hctx_rtt > 8)) |
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index 0a21be437ed3..272e8584564e 100644 --- a/net/dccp/dccp.h +++ b/net/dccp/dccp.h | |||
| @@ -50,7 +50,7 @@ extern void dccp_time_wait(struct sock *sk, int state, int timeo); | |||
| 50 | #define DCCP_TIMEWAIT_LEN (60 * HZ) /* how long to wait to destroy TIME-WAIT | 50 | #define DCCP_TIMEWAIT_LEN (60 * HZ) /* how long to wait to destroy TIME-WAIT |
| 51 | * state, about 60 seconds */ | 51 | * state, about 60 seconds */ |
| 52 | 52 | ||
| 53 | /* draft-ietf-dccp-spec-11.txt initial RTO value */ | 53 | /* RFC 1122, 4.2.3.1 initial RTO value */ |
| 54 | #define DCCP_TIMEOUT_INIT ((unsigned)(3 * HZ)) | 54 | #define DCCP_TIMEOUT_INIT ((unsigned)(3 * HZ)) |
| 55 | 55 | ||
| 56 | /* Maximal interval between probes for local resources. */ | 56 | /* Maximal interval between probes for local resources. */ |
diff --git a/net/dccp/input.c b/net/dccp/input.c index 7f9dc6ac58c9..1d24881ac0ab 100644 --- a/net/dccp/input.c +++ b/net/dccp/input.c | |||
| @@ -216,11 +216,11 @@ send_sync: | |||
| 216 | dccp_send_sync(sk, DCCP_SKB_CB(skb)->dccpd_seq, | 216 | dccp_send_sync(sk, DCCP_SKB_CB(skb)->dccpd_seq, |
| 217 | DCCP_PKT_SYNCACK); | 217 | DCCP_PKT_SYNCACK); |
| 218 | /* | 218 | /* |
| 219 | * From the draft: | 219 | * From RFC 4340, sec. 5.7 |
| 220 | * | 220 | * |
| 221 | * As with DCCP-Ack packets, DCCP-Sync and DCCP-SyncAck packets | 221 | * As with DCCP-Ack packets, DCCP-Sync and DCCP-SyncAck packets |
| 222 | * MAY have non-zero-length application data areas, whose | 222 | * MAY have non-zero-length application data areas, whose |
| 223 | * contents * receivers MUST ignore. | 223 | * contents receivers MUST ignore. |
| 224 | */ | 224 | */ |
| 225 | goto discard; | 225 | goto discard; |
| 226 | } | 226 | } |
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 7e746c4c1688..e08e7688a263 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c | |||
| @@ -183,7 +183,7 @@ static inline void dccp_do_pmtu_discovery(struct sock *sk, | |||
| 183 | dccp_sync_mss(sk, mtu); | 183 | dccp_sync_mss(sk, mtu); |
| 184 | 184 | ||
| 185 | /* | 185 | /* |
| 186 | * From: draft-ietf-dccp-spec-11.txt | 186 | * From RFC 4340, sec. 14.1: |
| 187 | * | 187 | * |
| 188 | * DCCP-Sync packets are the best choice for upward | 188 | * DCCP-Sync packets are the best choice for upward |
| 189 | * probing, since DCCP-Sync probes do not risk application | 189 | * probing, since DCCP-Sync probes do not risk application |
| @@ -449,6 +449,8 @@ static inline u64 dccp_v4_init_sequence(const struct sock *sk, | |||
| 449 | dccp_hdr(skb)->dccph_sport); | 449 | dccp_hdr(skb)->dccph_sport); |
| 450 | } | 450 | } |
| 451 | 451 | ||
| 452 | static struct request_sock_ops dccp_request_sock_ops; | ||
| 453 | |||
| 452 | int dccp_v4_conn_request(struct sock *sk, struct sk_buff *skb) | 454 | int dccp_v4_conn_request(struct sock *sk, struct sk_buff *skb) |
| 453 | { | 455 | { |
| 454 | struct inet_request_sock *ireq; | 456 | struct inet_request_sock *ireq; |
| @@ -489,7 +491,7 @@ int dccp_v4_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 489 | if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1) | 491 | if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1) |
| 490 | goto drop; | 492 | goto drop; |
| 491 | 493 | ||
| 492 | req = reqsk_alloc(sk->sk_prot->rsk_prot); | 494 | req = reqsk_alloc(&dccp_request_sock_ops); |
| 493 | if (req == NULL) | 495 | if (req == NULL) |
| 494 | goto drop; | 496 | goto drop; |
| 495 | 497 | ||
| @@ -731,7 +733,7 @@ static void dccp_v4_ctl_send_reset(struct sk_buff *rxskb) | |||
| 731 | dccp_hdr_reset(skb)->dccph_reset_code = | 733 | dccp_hdr_reset(skb)->dccph_reset_code = |
| 732 | DCCP_SKB_CB(rxskb)->dccpd_reset_code; | 734 | DCCP_SKB_CB(rxskb)->dccpd_reset_code; |
| 733 | 735 | ||
| 734 | /* See "8.3.1. Abnormal Termination" in draft-ietf-dccp-spec-11 */ | 736 | /* See "8.3.1. Abnormal Termination" in RFC 4340 */ |
| 735 | seqno = 0; | 737 | seqno = 0; |
| 736 | if (DCCP_SKB_CB(rxskb)->dccpd_ack_seq != DCCP_PKT_WITHOUT_ACK_SEQ) | 738 | if (DCCP_SKB_CB(rxskb)->dccpd_ack_seq != DCCP_PKT_WITHOUT_ACK_SEQ) |
| 737 | dccp_set_seqno(&seqno, DCCP_SKB_CB(rxskb)->dccpd_ack_seq + 1); | 739 | dccp_set_seqno(&seqno, DCCP_SKB_CB(rxskb)->dccpd_ack_seq + 1); |
diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c index 7171a78671aa..eb0ff7ab05ed 100644 --- a/net/dccp/ipv6.c +++ b/net/dccp/ipv6.c | |||
| @@ -550,7 +550,7 @@ static void dccp_v6_ctl_send_reset(struct sk_buff *rxskb) | |||
| 550 | dccp_hdr_reset(skb)->dccph_reset_code = | 550 | dccp_hdr_reset(skb)->dccph_reset_code = |
| 551 | DCCP_SKB_CB(rxskb)->dccpd_reset_code; | 551 | DCCP_SKB_CB(rxskb)->dccpd_reset_code; |
| 552 | 552 | ||
| 553 | /* See "8.3.1. Abnormal Termination" in draft-ietf-dccp-spec-11 */ | 553 | /* See "8.3.1. Abnormal Termination" in RFC 4340 */ |
| 554 | seqno = 0; | 554 | seqno = 0; |
| 555 | if (DCCP_SKB_CB(rxskb)->dccpd_ack_seq != DCCP_PKT_WITHOUT_ACK_SEQ) | 555 | if (DCCP_SKB_CB(rxskb)->dccpd_ack_seq != DCCP_PKT_WITHOUT_ACK_SEQ) |
| 556 | dccp_set_seqno(&seqno, DCCP_SKB_CB(rxskb)->dccpd_ack_seq + 1); | 556 | dccp_set_seqno(&seqno, DCCP_SKB_CB(rxskb)->dccpd_ack_seq + 1); |
| @@ -672,7 +672,6 @@ static struct sock *dccp_v6_hnd_req(struct sock *sk,struct sk_buff *skb) | |||
| 672 | 672 | ||
| 673 | static int dccp_v6_conn_request(struct sock *sk, struct sk_buff *skb) | 673 | static int dccp_v6_conn_request(struct sock *sk, struct sk_buff *skb) |
| 674 | { | 674 | { |
| 675 | struct inet_request_sock *ireq; | ||
| 676 | struct dccp_sock dp; | 675 | struct dccp_sock dp; |
| 677 | struct request_sock *req; | 676 | struct request_sock *req; |
| 678 | struct dccp_request_sock *dreq; | 677 | struct dccp_request_sock *dreq; |
| @@ -701,7 +700,7 @@ static int dccp_v6_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 701 | if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1) | 700 | if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1) |
| 702 | goto drop; | 701 | goto drop; |
| 703 | 702 | ||
| 704 | req = inet6_reqsk_alloc(sk->sk_prot->rsk_prot); | 703 | req = inet6_reqsk_alloc(&dccp6_request_sock_ops); |
| 705 | if (req == NULL) | 704 | if (req == NULL) |
| 706 | goto drop; | 705 | goto drop; |
| 707 | 706 | ||
| @@ -713,7 +712,6 @@ static int dccp_v6_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 713 | goto drop_and_free; | 712 | goto drop_and_free; |
| 714 | 713 | ||
| 715 | ireq6 = inet6_rsk(req); | 714 | ireq6 = inet6_rsk(req); |
| 716 | ireq = inet_rsk(req); | ||
| 717 | ipv6_addr_copy(&ireq6->rmt_addr, &skb->nh.ipv6h->saddr); | 715 | ipv6_addr_copy(&ireq6->rmt_addr, &skb->nh.ipv6h->saddr); |
| 718 | ipv6_addr_copy(&ireq6->loc_addr, &skb->nh.ipv6h->daddr); | 716 | ipv6_addr_copy(&ireq6->loc_addr, &skb->nh.ipv6h->daddr); |
| 719 | req->rcv_wnd = dccp_feat_default_sequence_window; | 717 | req->rcv_wnd = dccp_feat_default_sequence_window; |
| @@ -997,6 +995,10 @@ static int dccp_v6_do_rcv(struct sock *sk, struct sk_buff *skb) | |||
| 997 | if (sk->sk_state == DCCP_OPEN) { /* Fast path */ | 995 | if (sk->sk_state == DCCP_OPEN) { /* Fast path */ |
| 998 | if (dccp_rcv_established(sk, skb, dccp_hdr(skb), skb->len)) | 996 | if (dccp_rcv_established(sk, skb, dccp_hdr(skb), skb->len)) |
| 999 | goto reset; | 997 | goto reset; |
| 998 | if (opt_skb) { | ||
| 999 | /* This is where we would goto ipv6_pktoptions. */ | ||
| 1000 | __kfree_skb(opt_skb); | ||
| 1001 | } | ||
| 1000 | return 0; | 1002 | return 0; |
| 1001 | } | 1003 | } |
| 1002 | 1004 | ||
| @@ -1021,6 +1023,10 @@ static int dccp_v6_do_rcv(struct sock *sk, struct sk_buff *skb) | |||
| 1021 | 1023 | ||
| 1022 | if (dccp_rcv_state_process(sk, skb, dccp_hdr(skb), skb->len)) | 1024 | if (dccp_rcv_state_process(sk, skb, dccp_hdr(skb), skb->len)) |
| 1023 | goto reset; | 1025 | goto reset; |
| 1026 | if (opt_skb) { | ||
| 1027 | /* This is where we would goto ipv6_pktoptions. */ | ||
| 1028 | __kfree_skb(opt_skb); | ||
| 1029 | } | ||
| 1024 | return 0; | 1030 | return 0; |
| 1025 | 1031 | ||
| 1026 | reset: | 1032 | reset: |
diff --git a/net/dccp/options.c b/net/dccp/options.c index 07a34696ac97..fb0db1f7cd7b 100644 --- a/net/dccp/options.c +++ b/net/dccp/options.c | |||
| @@ -215,7 +215,7 @@ int dccp_parse_options(struct sock *sk, struct sk_buff *skb) | |||
| 215 | elapsed_time); | 215 | elapsed_time); |
| 216 | break; | 216 | break; |
| 217 | /* | 217 | /* |
| 218 | * From draft-ietf-dccp-spec-11.txt: | 218 | * From RFC 4340, sec. 10.3: |
| 219 | * | 219 | * |
| 220 | * Option numbers 128 through 191 are for | 220 | * Option numbers 128 through 191 are for |
| 221 | * options sent from the HC-Sender to the | 221 | * options sent from the HC-Sender to the |
diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index 3456cd331835..21f20f21dd32 100644 --- a/net/decnet/af_decnet.c +++ b/net/decnet/af_decnet.c | |||
| @@ -166,7 +166,7 @@ static struct hlist_head *dn_find_list(struct sock *sk) | |||
| 166 | if (scp->addr.sdn_flags & SDF_WILD) | 166 | if (scp->addr.sdn_flags & SDF_WILD) |
| 167 | return hlist_empty(&dn_wild_sk) ? &dn_wild_sk : NULL; | 167 | return hlist_empty(&dn_wild_sk) ? &dn_wild_sk : NULL; |
| 168 | 168 | ||
| 169 | return &dn_sk_hash[scp->addrloc & DN_SK_HASH_MASK]; | 169 | return &dn_sk_hash[dn_ntohs(scp->addrloc) & DN_SK_HASH_MASK]; |
| 170 | } | 170 | } |
| 171 | 171 | ||
| 172 | /* | 172 | /* |
| @@ -180,7 +180,7 @@ static int check_port(__le16 port) | |||
| 180 | if (port == 0) | 180 | if (port == 0) |
| 181 | return -1; | 181 | return -1; |
| 182 | 182 | ||
| 183 | sk_for_each(sk, node, &dn_sk_hash[port & DN_SK_HASH_MASK]) { | 183 | sk_for_each(sk, node, &dn_sk_hash[dn_ntohs(port) & DN_SK_HASH_MASK]) { |
| 184 | struct dn_scp *scp = DN_SK(sk); | 184 | struct dn_scp *scp = DN_SK(sk); |
| 185 | if (scp->addrloc == port) | 185 | if (scp->addrloc == port) |
| 186 | return -1; | 186 | return -1; |
| @@ -194,12 +194,12 @@ static unsigned short port_alloc(struct sock *sk) | |||
| 194 | static unsigned short port = 0x2000; | 194 | static unsigned short port = 0x2000; |
| 195 | unsigned short i_port = port; | 195 | unsigned short i_port = port; |
| 196 | 196 | ||
| 197 | while(check_port(++port) != 0) { | 197 | while(check_port(dn_htons(++port)) != 0) { |
| 198 | if (port == i_port) | 198 | if (port == i_port) |
| 199 | return 0; | 199 | return 0; |
| 200 | } | 200 | } |
| 201 | 201 | ||
| 202 | scp->addrloc = port; | 202 | scp->addrloc = dn_htons(port); |
| 203 | 203 | ||
| 204 | return 1; | 204 | return 1; |
| 205 | } | 205 | } |
| @@ -418,7 +418,7 @@ struct sock *dn_find_by_skb(struct sk_buff *skb) | |||
| 418 | struct dn_scp *scp; | 418 | struct dn_scp *scp; |
| 419 | 419 | ||
| 420 | read_lock(&dn_hash_lock); | 420 | read_lock(&dn_hash_lock); |
| 421 | sk_for_each(sk, node, &dn_sk_hash[cb->dst_port & DN_SK_HASH_MASK]) { | 421 | sk_for_each(sk, node, &dn_sk_hash[dn_ntohs(cb->dst_port) & DN_SK_HASH_MASK]) { |
| 422 | scp = DN_SK(sk); | 422 | scp = DN_SK(sk); |
| 423 | if (cb->src != dn_saddr2dn(&scp->peer)) | 423 | if (cb->src != dn_saddr2dn(&scp->peer)) |
| 424 | continue; | 424 | continue; |
| @@ -1016,13 +1016,14 @@ static void dn_access_copy(struct sk_buff *skb, struct accessdata_dn *acc) | |||
| 1016 | 1016 | ||
| 1017 | static void dn_user_copy(struct sk_buff *skb, struct optdata_dn *opt) | 1017 | static void dn_user_copy(struct sk_buff *skb, struct optdata_dn *opt) |
| 1018 | { | 1018 | { |
| 1019 | unsigned char *ptr = skb->data; | 1019 | unsigned char *ptr = skb->data; |
| 1020 | 1020 | u16 len = *ptr++; /* yes, it's 8bit on the wire */ | |
| 1021 | opt->opt_optl = *ptr++; | 1021 | |
| 1022 | opt->opt_status = 0; | 1022 | BUG_ON(len > 16); /* we've checked the contents earlier */ |
| 1023 | memcpy(opt->opt_data, ptr, opt->opt_optl); | 1023 | opt->opt_optl = dn_htons(len); |
| 1024 | skb_pull(skb, dn_ntohs(opt->opt_optl) + 1); | 1024 | opt->opt_status = 0; |
| 1025 | 1025 | memcpy(opt->opt_data, ptr, len); | |
| 1026 | skb_pull(skb, len + 1); | ||
| 1026 | } | 1027 | } |
| 1027 | 1028 | ||
| 1028 | static struct sk_buff *dn_wait_for_connect(struct sock *sk, long *timeo) | 1029 | static struct sk_buff *dn_wait_for_connect(struct sock *sk, long *timeo) |
diff --git a/net/decnet/dn_nsp_in.c b/net/decnet/dn_nsp_in.c index 72ecc6e62ec4..7683d4f754d2 100644 --- a/net/decnet/dn_nsp_in.c +++ b/net/decnet/dn_nsp_in.c | |||
| @@ -360,9 +360,9 @@ static void dn_nsp_conn_conf(struct sock *sk, struct sk_buff *skb) | |||
| 360 | scp->max_window = decnet_no_fc_max_cwnd; | 360 | scp->max_window = decnet_no_fc_max_cwnd; |
| 361 | 361 | ||
| 362 | if (skb->len > 0) { | 362 | if (skb->len > 0) { |
| 363 | unsigned char dlen = *skb->data; | 363 | u16 dlen = *skb->data; |
| 364 | if ((dlen <= 16) && (dlen <= skb->len)) { | 364 | if ((dlen <= 16) && (dlen <= skb->len)) { |
| 365 | scp->conndata_in.opt_optl = dn_htons((__u16)dlen); | 365 | scp->conndata_in.opt_optl = dn_htons(dlen); |
| 366 | memcpy(scp->conndata_in.opt_data, skb->data + 1, dlen); | 366 | memcpy(scp->conndata_in.opt_data, skb->data + 1, dlen); |
| 367 | } | 367 | } |
| 368 | } | 368 | } |
| @@ -404,9 +404,9 @@ static void dn_nsp_disc_init(struct sock *sk, struct sk_buff *skb) | |||
| 404 | memset(scp->discdata_in.opt_data, 0, 16); | 404 | memset(scp->discdata_in.opt_data, 0, 16); |
| 405 | 405 | ||
| 406 | if (skb->len > 0) { | 406 | if (skb->len > 0) { |
| 407 | unsigned char dlen = *skb->data; | 407 | u16 dlen = *skb->data; |
| 408 | if ((dlen <= 16) && (dlen <= skb->len)) { | 408 | if ((dlen <= 16) && (dlen <= skb->len)) { |
| 409 | scp->discdata_in.opt_optl = dn_htons((__u16)dlen); | 409 | scp->discdata_in.opt_optl = dn_htons(dlen); |
| 410 | memcpy(scp->discdata_in.opt_data, skb->data + 1, dlen); | 410 | memcpy(scp->discdata_in.opt_data, skb->data + 1, dlen); |
| 411 | } | 411 | } |
| 412 | } | 412 | } |
diff --git a/net/decnet/dn_nsp_out.c b/net/decnet/dn_nsp_out.c index c2e21cd89b3c..b342e4e8f5f8 100644 --- a/net/decnet/dn_nsp_out.c +++ b/net/decnet/dn_nsp_out.c | |||
| @@ -526,7 +526,7 @@ void dn_send_conn_conf(struct sock *sk, gfp_t gfp) | |||
| 526 | struct nsp_conn_init_msg *msg; | 526 | struct nsp_conn_init_msg *msg; |
| 527 | __u8 len = (__u8)dn_ntohs(scp->conndata_out.opt_optl); | 527 | __u8 len = (__u8)dn_ntohs(scp->conndata_out.opt_optl); |
| 528 | 528 | ||
| 529 | if ((skb = dn_alloc_skb(sk, 50 + dn_ntohs(scp->conndata_out.opt_optl), gfp)) == NULL) | 529 | if ((skb = dn_alloc_skb(sk, 50 + len, gfp)) == NULL) |
| 530 | return; | 530 | return; |
| 531 | 531 | ||
| 532 | msg = (struct nsp_conn_init_msg *)skb_put(skb, sizeof(*msg)); | 532 | msg = (struct nsp_conn_init_msg *)skb_put(skb, sizeof(*msg)); |
diff --git a/net/decnet/dn_rules.c b/net/decnet/dn_rules.c index 3e0c882c90bf..590e0a72495c 100644 --- a/net/decnet/dn_rules.c +++ b/net/decnet/dn_rules.c | |||
| @@ -124,8 +124,8 @@ static struct nla_policy dn_fib_rule_policy[FRA_MAX+1] __read_mostly = { | |||
| 124 | static int dn_fib_rule_match(struct fib_rule *rule, struct flowi *fl, int flags) | 124 | static int dn_fib_rule_match(struct fib_rule *rule, struct flowi *fl, int flags) |
| 125 | { | 125 | { |
| 126 | struct dn_fib_rule *r = (struct dn_fib_rule *)rule; | 126 | struct dn_fib_rule *r = (struct dn_fib_rule *)rule; |
| 127 | u16 daddr = fl->fld_dst; | 127 | __le16 daddr = fl->fld_dst; |
| 128 | u16 saddr = fl->fld_src; | 128 | __le16 saddr = fl->fld_src; |
| 129 | 129 | ||
| 130 | if (((saddr ^ r->src) & r->srcmask) || | 130 | if (((saddr ^ r->src) & r->srcmask) || |
| 131 | ((daddr ^ r->dst) & r->dstmask)) | 131 | ((daddr ^ r->dst) & r->dstmask)) |
diff --git a/net/ieee80211/Kconfig b/net/ieee80211/Kconfig index f7e84e9d13ad..a64be6cdf078 100644 --- a/net/ieee80211/Kconfig +++ b/net/ieee80211/Kconfig | |||
| @@ -32,6 +32,7 @@ config IEEE80211_CRYPT_WEP | |||
| 32 | depends on IEEE80211 | 32 | depends on IEEE80211 |
| 33 | select CRYPTO | 33 | select CRYPTO |
| 34 | select CRYPTO_ARC4 | 34 | select CRYPTO_ARC4 |
| 35 | select CRYPTO_ECB | ||
| 35 | select CRC32 | 36 | select CRC32 |
| 36 | ---help--- | 37 | ---help--- |
| 37 | Include software based cipher suites in support of IEEE | 38 | Include software based cipher suites in support of IEEE |
| @@ -58,6 +59,7 @@ config IEEE80211_CRYPT_TKIP | |||
| 58 | depends on IEEE80211 && NET_RADIO | 59 | depends on IEEE80211 && NET_RADIO |
| 59 | select CRYPTO | 60 | select CRYPTO |
| 60 | select CRYPTO_MICHAEL_MIC | 61 | select CRYPTO_MICHAEL_MIC |
| 62 | select CRYPTO_ECB | ||
| 61 | select CRC32 | 63 | select CRC32 |
| 62 | ---help--- | 64 | ---help--- |
| 63 | Include software based cipher suites in support of IEEE 802.11i | 65 | Include software based cipher suites in support of IEEE 802.11i |
diff --git a/net/ieee80211/ieee80211_rx.c b/net/ieee80211/ieee80211_rx.c index 770704183a1b..2759312a4204 100644 --- a/net/ieee80211/ieee80211_rx.c +++ b/net/ieee80211/ieee80211_rx.c | |||
| @@ -1078,12 +1078,12 @@ static int ieee80211_parse_info_param(struct ieee80211_info_element | |||
| 1078 | 1078 | ||
| 1079 | while (length >= sizeof(*info_element)) { | 1079 | while (length >= sizeof(*info_element)) { |
| 1080 | if (sizeof(*info_element) + info_element->len > length) { | 1080 | if (sizeof(*info_element) + info_element->len > length) { |
| 1081 | IEEE80211_ERROR("Info elem: parse failed: " | 1081 | IEEE80211_DEBUG_MGMT("Info elem: parse failed: " |
| 1082 | "info_element->len + 2 > left : " | 1082 | "info_element->len + 2 > left : " |
| 1083 | "info_element->len+2=%zd left=%d, id=%d.\n", | 1083 | "info_element->len+2=%zd left=%d, id=%d.\n", |
| 1084 | info_element->len + | 1084 | info_element->len + |
| 1085 | sizeof(*info_element), | 1085 | sizeof(*info_element), |
| 1086 | length, info_element->id); | 1086 | length, info_element->id); |
| 1087 | /* We stop processing but don't return an error here | 1087 | /* We stop processing but don't return an error here |
| 1088 | * because some misbehaviour APs break this rule. ie. | 1088 | * because some misbehaviour APs break this rule. ie. |
| 1089 | * Orinoco AP1000. */ | 1089 | * Orinoco AP1000. */ |
diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c index e2077a3aa8c0..6460233407c7 100644 --- a/net/ipv4/cipso_ipv4.c +++ b/net/ipv4/cipso_ipv4.c | |||
| @@ -1307,7 +1307,8 @@ int cipso_v4_socket_setattr(const struct socket *sock, | |||
| 1307 | 1307 | ||
| 1308 | /* We can't use ip_options_get() directly because it makes a call to | 1308 | /* We can't use ip_options_get() directly because it makes a call to |
| 1309 | * ip_options_get_alloc() which allocates memory with GFP_KERNEL and | 1309 | * ip_options_get_alloc() which allocates memory with GFP_KERNEL and |
| 1310 | * we can't block here. */ | 1310 | * we won't always have CAP_NET_RAW even though we _always_ want to |
| 1311 | * set the IPOPT_CIPSO option. */ | ||
| 1311 | opt_len = (buf_len + 3) & ~3; | 1312 | opt_len = (buf_len + 3) & ~3; |
| 1312 | opt = kzalloc(sizeof(*opt) + opt_len, GFP_ATOMIC); | 1313 | opt = kzalloc(sizeof(*opt) + opt_len, GFP_ATOMIC); |
| 1313 | if (opt == NULL) { | 1314 | if (opt == NULL) { |
| @@ -1317,11 +1318,9 @@ int cipso_v4_socket_setattr(const struct socket *sock, | |||
| 1317 | memcpy(opt->__data, buf, buf_len); | 1318 | memcpy(opt->__data, buf, buf_len); |
| 1318 | opt->optlen = opt_len; | 1319 | opt->optlen = opt_len; |
| 1319 | opt->is_data = 1; | 1320 | opt->is_data = 1; |
| 1321 | opt->cipso = sizeof(struct iphdr); | ||
| 1320 | kfree(buf); | 1322 | kfree(buf); |
| 1321 | buf = NULL; | 1323 | buf = NULL; |
| 1322 | ret_val = ip_options_compile(opt, NULL); | ||
| 1323 | if (ret_val != 0) | ||
| 1324 | goto socket_setattr_failure; | ||
| 1325 | 1324 | ||
| 1326 | sk_inet = inet_sk(sk); | 1325 | sk_inet = inet_sk(sk); |
| 1327 | if (sk_inet->is_icsk) { | 1326 | if (sk_inet->is_icsk) { |
diff --git a/net/ipv4/ip_options.c b/net/ipv4/ip_options.c index 8dabbfc31267..9f02917d6f45 100644 --- a/net/ipv4/ip_options.c +++ b/net/ipv4/ip_options.c | |||
| @@ -443,7 +443,7 @@ int ip_options_compile(struct ip_options * opt, struct sk_buff * skb) | |||
| 443 | opt->router_alert = optptr - iph; | 443 | opt->router_alert = optptr - iph; |
| 444 | break; | 444 | break; |
| 445 | case IPOPT_CIPSO: | 445 | case IPOPT_CIPSO: |
| 446 | if (opt->cipso) { | 446 | if ((!skb && !capable(CAP_NET_RAW)) || opt->cipso) { |
| 447 | pp_ptr = optptr; | 447 | pp_ptr = optptr; |
| 448 | goto error; | 448 | goto error; |
| 449 | } | 449 | } |
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index f8ce84759159..955a07abb91d 100644 --- a/net/ipv4/ipconfig.c +++ b/net/ipv4/ipconfig.c | |||
| @@ -420,7 +420,7 @@ ic_rarp_recv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt | |||
| 420 | { | 420 | { |
| 421 | struct arphdr *rarp; | 421 | struct arphdr *rarp; |
| 422 | unsigned char *rarp_ptr; | 422 | unsigned char *rarp_ptr; |
| 423 | unsigned long sip, tip; | 423 | u32 sip, tip; |
| 424 | unsigned char *sha, *tha; /* s for "source", t for "target" */ | 424 | unsigned char *sha, *tha; /* s for "source", t for "target" */ |
| 425 | struct ic_device *d; | 425 | struct ic_device *d; |
| 426 | 426 | ||
diff --git a/net/ipv4/ipvs/ip_vs_ftp.c b/net/ipv4/ipvs/ip_vs_ftp.c index 6d398f10aa91..687c1de1146f 100644 --- a/net/ipv4/ipvs/ip_vs_ftp.c +++ b/net/ipv4/ipvs/ip_vs_ftp.c | |||
| @@ -200,7 +200,7 @@ static int ip_vs_ftp_out(struct ip_vs_app *app, struct ip_vs_conn *cp, | |||
| 200 | from = n_cp->vaddr; | 200 | from = n_cp->vaddr; |
| 201 | port = n_cp->vport; | 201 | port = n_cp->vport; |
| 202 | sprintf(buf,"%d,%d,%d,%d,%d,%d", NIPQUAD(from), | 202 | sprintf(buf,"%d,%d,%d,%d,%d,%d", NIPQUAD(from), |
| 203 | ntohs(port)&255, (ntohs(port)>>8)&255); | 203 | (ntohs(port)>>8)&255, ntohs(port)&255); |
| 204 | buf_len = strlen(buf); | 204 | buf_len = strlen(buf); |
| 205 | 205 | ||
| 206 | /* | 206 | /* |
diff --git a/net/ipv4/ipvs/ip_vs_proto_tcp.c b/net/ipv4/ipvs/ip_vs_proto_tcp.c index bfe779e74590..6ff05c3a32e6 100644 --- a/net/ipv4/ipvs/ip_vs_proto_tcp.c +++ b/net/ipv4/ipvs/ip_vs_proto_tcp.c | |||
| @@ -117,7 +117,7 @@ tcp_fast_csum_update(struct tcphdr *tcph, __be32 oldip, __be32 newip, | |||
| 117 | { | 117 | { |
| 118 | tcph->check = | 118 | tcph->check = |
| 119 | ip_vs_check_diff(~oldip, newip, | 119 | ip_vs_check_diff(~oldip, newip, |
| 120 | ip_vs_check_diff(oldport ^ htonl(0xFFFF), | 120 | ip_vs_check_diff(oldport ^ htons(0xFFFF), |
| 121 | newport, tcph->check)); | 121 | newport, tcph->check)); |
| 122 | } | 122 | } |
| 123 | 123 | ||
diff --git a/net/ipv4/ipvs/ip_vs_proto_udp.c b/net/ipv4/ipvs/ip_vs_proto_udp.c index 54aa7603591f..691c8b637b29 100644 --- a/net/ipv4/ipvs/ip_vs_proto_udp.c +++ b/net/ipv4/ipvs/ip_vs_proto_udp.c | |||
| @@ -122,10 +122,10 @@ udp_fast_csum_update(struct udphdr *uhdr, __be32 oldip, __be32 newip, | |||
| 122 | { | 122 | { |
| 123 | uhdr->check = | 123 | uhdr->check = |
| 124 | ip_vs_check_diff(~oldip, newip, | 124 | ip_vs_check_diff(~oldip, newip, |
| 125 | ip_vs_check_diff(oldport ^ htonl(0xFFFF), | 125 | ip_vs_check_diff(oldport ^ htons(0xFFFF), |
| 126 | newport, uhdr->check)); | 126 | newport, uhdr->check)); |
| 127 | if (!uhdr->check) | 127 | if (!uhdr->check) |
| 128 | uhdr->check = htonl(0xFFFF); | 128 | uhdr->check = -1; |
| 129 | } | 129 | } |
| 130 | 130 | ||
| 131 | static int | 131 | static int |
| @@ -173,7 +173,7 @@ udp_snat_handler(struct sk_buff **pskb, | |||
| 173 | cp->protocol, | 173 | cp->protocol, |
| 174 | (*pskb)->csum); | 174 | (*pskb)->csum); |
| 175 | if (udph->check == 0) | 175 | if (udph->check == 0) |
| 176 | udph->check = htonl(0xFFFF); | 176 | udph->check = -1; |
| 177 | IP_VS_DBG(11, "O-pkt: %s O-csum=%d (+%zd)\n", | 177 | IP_VS_DBG(11, "O-pkt: %s O-csum=%d (+%zd)\n", |
| 178 | pp->name, udph->check, | 178 | pp->name, udph->check, |
| 179 | (char*)&(udph->check) - (char*)udph); | 179 | (char*)&(udph->check) - (char*)udph); |
| @@ -228,7 +228,7 @@ udp_dnat_handler(struct sk_buff **pskb, | |||
| 228 | cp->protocol, | 228 | cp->protocol, |
| 229 | (*pskb)->csum); | 229 | (*pskb)->csum); |
| 230 | if (udph->check == 0) | 230 | if (udph->check == 0) |
| 231 | udph->check = 0xFFFF; | 231 | udph->check = -1; |
| 232 | (*pskb)->ip_summed = CHECKSUM_UNNECESSARY; | 232 | (*pskb)->ip_summed = CHECKSUM_UNNECESSARY; |
| 233 | } | 233 | } |
| 234 | return 1; | 234 | return 1; |
diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c index 0849f1cced13..413c2d0a1f3d 100644 --- a/net/ipv4/netfilter/arp_tables.c +++ b/net/ipv4/netfilter/arp_tables.c | |||
| @@ -466,7 +466,13 @@ static inline int check_entry(struct arpt_entry *e, const char *name, unsigned i | |||
| 466 | return -EINVAL; | 466 | return -EINVAL; |
| 467 | } | 467 | } |
| 468 | 468 | ||
| 469 | if (e->target_offset + sizeof(struct arpt_entry_target) > e->next_offset) | ||
| 470 | return -EINVAL; | ||
| 471 | |||
| 469 | t = arpt_get_target(e); | 472 | t = arpt_get_target(e); |
| 473 | if (e->target_offset + t->u.target_size > e->next_offset) | ||
| 474 | return -EINVAL; | ||
| 475 | |||
| 470 | target = try_then_request_module(xt_find_target(NF_ARP, t->u.user.name, | 476 | target = try_then_request_module(xt_find_target(NF_ARP, t->u.user.name, |
| 471 | t->u.user.revision), | 477 | t->u.user.revision), |
| 472 | "arpt_%s", t->u.user.name); | 478 | "arpt_%s", t->u.user.name); |
| @@ -621,20 +627,18 @@ static int translate_table(const char *name, | |||
| 621 | } | 627 | } |
| 622 | } | 628 | } |
| 623 | 629 | ||
| 624 | if (!mark_source_chains(newinfo, valid_hooks, entry0)) { | ||
| 625 | duprintf("Looping hook\n"); | ||
| 626 | return -ELOOP; | ||
| 627 | } | ||
| 628 | |||
| 629 | /* Finally, each sanity check must pass */ | 630 | /* Finally, each sanity check must pass */ |
| 630 | i = 0; | 631 | i = 0; |
| 631 | ret = ARPT_ENTRY_ITERATE(entry0, newinfo->size, | 632 | ret = ARPT_ENTRY_ITERATE(entry0, newinfo->size, |
| 632 | check_entry, name, size, &i); | 633 | check_entry, name, size, &i); |
| 633 | 634 | ||
| 634 | if (ret != 0) { | 635 | if (ret != 0) |
| 635 | ARPT_ENTRY_ITERATE(entry0, newinfo->size, | 636 | goto cleanup; |
| 636 | cleanup_entry, &i); | 637 | |
| 637 | return ret; | 638 | ret = -ELOOP; |
| 639 | if (!mark_source_chains(newinfo, valid_hooks, entry0)) { | ||
| 640 | duprintf("Looping hook\n"); | ||
| 641 | goto cleanup; | ||
| 638 | } | 642 | } |
| 639 | 643 | ||
| 640 | /* And one copy for every other CPU */ | 644 | /* And one copy for every other CPU */ |
| @@ -643,6 +647,9 @@ static int translate_table(const char *name, | |||
| 643 | memcpy(newinfo->entries[i], entry0, newinfo->size); | 647 | memcpy(newinfo->entries[i], entry0, newinfo->size); |
| 644 | } | 648 | } |
| 645 | 649 | ||
| 650 | return 0; | ||
| 651 | cleanup: | ||
| 652 | ARPT_ENTRY_ITERATE(entry0, newinfo->size, cleanup_entry, &i); | ||
| 646 | return ret; | 653 | return ret; |
| 647 | } | 654 | } |
| 648 | 655 | ||
diff --git a/net/ipv4/netfilter/ip_queue.c b/net/ipv4/netfilter/ip_queue.c index 7edad790478a..97556cc2e4e0 100644 --- a/net/ipv4/netfilter/ip_queue.c +++ b/net/ipv4/netfilter/ip_queue.c | |||
| @@ -351,9 +351,10 @@ ipq_mangle_ipv4(ipq_verdict_msg_t *v, struct ipq_queue_entry *e) | |||
| 351 | if (v->data_len < sizeof(*user_iph)) | 351 | if (v->data_len < sizeof(*user_iph)) |
| 352 | return 0; | 352 | return 0; |
| 353 | diff = v->data_len - e->skb->len; | 353 | diff = v->data_len - e->skb->len; |
| 354 | if (diff < 0) | 354 | if (diff < 0) { |
| 355 | skb_trim(e->skb, v->data_len); | 355 | if (pskb_trim(e->skb, v->data_len)) |
| 356 | else if (diff > 0) { | 356 | return -ENOMEM; |
| 357 | } else if (diff > 0) { | ||
| 357 | if (v->data_len > 0xFFFF) | 358 | if (v->data_len > 0xFFFF) |
| 358 | return -EINVAL; | 359 | return -EINVAL; |
| 359 | if (diff > skb_tailroom(e->skb)) { | 360 | if (diff > skb_tailroom(e->skb)) { |
diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c index 4b90927619b8..8a455439b128 100644 --- a/net/ipv4/netfilter/ip_tables.c +++ b/net/ipv4/netfilter/ip_tables.c | |||
| @@ -547,12 +547,18 @@ check_entry(struct ipt_entry *e, const char *name, unsigned int size, | |||
| 547 | return -EINVAL; | 547 | return -EINVAL; |
| 548 | } | 548 | } |
| 549 | 549 | ||
| 550 | if (e->target_offset + sizeof(struct ipt_entry_target) > e->next_offset) | ||
| 551 | return -EINVAL; | ||
| 552 | |||
| 550 | j = 0; | 553 | j = 0; |
| 551 | ret = IPT_MATCH_ITERATE(e, check_match, name, &e->ip, e->comefrom, &j); | 554 | ret = IPT_MATCH_ITERATE(e, check_match, name, &e->ip, e->comefrom, &j); |
| 552 | if (ret != 0) | 555 | if (ret != 0) |
| 553 | goto cleanup_matches; | 556 | goto cleanup_matches; |
| 554 | 557 | ||
| 555 | t = ipt_get_target(e); | 558 | t = ipt_get_target(e); |
| 559 | ret = -EINVAL; | ||
| 560 | if (e->target_offset + t->u.target_size > e->next_offset) | ||
| 561 | goto cleanup_matches; | ||
| 556 | target = try_then_request_module(xt_find_target(AF_INET, | 562 | target = try_then_request_module(xt_find_target(AF_INET, |
| 557 | t->u.user.name, | 563 | t->u.user.name, |
| 558 | t->u.user.revision), | 564 | t->u.user.revision), |
| @@ -712,19 +718,17 @@ translate_table(const char *name, | |||
| 712 | } | 718 | } |
| 713 | } | 719 | } |
| 714 | 720 | ||
| 715 | if (!mark_source_chains(newinfo, valid_hooks, entry0)) | ||
| 716 | return -ELOOP; | ||
| 717 | |||
| 718 | /* Finally, each sanity check must pass */ | 721 | /* Finally, each sanity check must pass */ |
| 719 | i = 0; | 722 | i = 0; |
| 720 | ret = IPT_ENTRY_ITERATE(entry0, newinfo->size, | 723 | ret = IPT_ENTRY_ITERATE(entry0, newinfo->size, |
| 721 | check_entry, name, size, &i); | 724 | check_entry, name, size, &i); |
| 722 | 725 | ||
| 723 | if (ret != 0) { | 726 | if (ret != 0) |
| 724 | IPT_ENTRY_ITERATE(entry0, newinfo->size, | 727 | goto cleanup; |
| 725 | cleanup_entry, &i); | 728 | |
| 726 | return ret; | 729 | ret = -ELOOP; |
| 727 | } | 730 | if (!mark_source_chains(newinfo, valid_hooks, entry0)) |
| 731 | goto cleanup; | ||
| 728 | 732 | ||
| 729 | /* And one copy for every other CPU */ | 733 | /* And one copy for every other CPU */ |
| 730 | for_each_possible_cpu(i) { | 734 | for_each_possible_cpu(i) { |
| @@ -732,6 +736,9 @@ translate_table(const char *name, | |||
| 732 | memcpy(newinfo->entries[i], entry0, newinfo->size); | 736 | memcpy(newinfo->entries[i], entry0, newinfo->size); |
| 733 | } | 737 | } |
| 734 | 738 | ||
| 739 | return 0; | ||
| 740 | cleanup: | ||
| 741 | IPT_ENTRY_ITERATE(entry0, newinfo->size, cleanup_entry, &i); | ||
| 735 | return ret; | 742 | return ret; |
| 736 | } | 743 | } |
| 737 | 744 | ||
| @@ -1463,6 +1470,10 @@ check_compat_entry_size_and_hooks(struct ipt_entry *e, | |||
| 1463 | return -EINVAL; | 1470 | return -EINVAL; |
| 1464 | } | 1471 | } |
| 1465 | 1472 | ||
| 1473 | if (e->target_offset + sizeof(struct compat_xt_entry_target) > | ||
| 1474 | e->next_offset) | ||
| 1475 | return -EINVAL; | ||
| 1476 | |||
| 1466 | off = 0; | 1477 | off = 0; |
| 1467 | entry_offset = (void *)e - (void *)base; | 1478 | entry_offset = (void *)e - (void *)base; |
| 1468 | j = 0; | 1479 | j = 0; |
| @@ -1472,6 +1483,9 @@ check_compat_entry_size_and_hooks(struct ipt_entry *e, | |||
| 1472 | goto cleanup_matches; | 1483 | goto cleanup_matches; |
| 1473 | 1484 | ||
| 1474 | t = ipt_get_target(e); | 1485 | t = ipt_get_target(e); |
| 1486 | ret = -EINVAL; | ||
| 1487 | if (e->target_offset + t->u.target_size > e->next_offset) | ||
| 1488 | goto cleanup_matches; | ||
| 1475 | target = try_then_request_module(xt_find_target(AF_INET, | 1489 | target = try_then_request_module(xt_find_target(AF_INET, |
| 1476 | t->u.user.name, | 1490 | t->u.user.name, |
| 1477 | t->u.user.revision), | 1491 | t->u.user.revision), |
| @@ -1513,7 +1527,7 @@ cleanup_matches: | |||
| 1513 | 1527 | ||
| 1514 | static inline int compat_copy_match_from_user(struct ipt_entry_match *m, | 1528 | static inline int compat_copy_match_from_user(struct ipt_entry_match *m, |
| 1515 | void **dstptr, compat_uint_t *size, const char *name, | 1529 | void **dstptr, compat_uint_t *size, const char *name, |
| 1516 | const struct ipt_ip *ip, unsigned int hookmask, int *i) | 1530 | const struct ipt_ip *ip, unsigned int hookmask) |
| 1517 | { | 1531 | { |
| 1518 | struct ipt_entry_match *dm; | 1532 | struct ipt_entry_match *dm; |
| 1519 | struct ipt_match *match; | 1533 | struct ipt_match *match; |
| @@ -1526,22 +1540,13 @@ static inline int compat_copy_match_from_user(struct ipt_entry_match *m, | |||
| 1526 | ret = xt_check_match(match, AF_INET, dm->u.match_size - sizeof(*dm), | 1540 | ret = xt_check_match(match, AF_INET, dm->u.match_size - sizeof(*dm), |
| 1527 | name, hookmask, ip->proto, | 1541 | name, hookmask, ip->proto, |
| 1528 | ip->invflags & IPT_INV_PROTO); | 1542 | ip->invflags & IPT_INV_PROTO); |
| 1529 | if (ret) | 1543 | if (!ret && m->u.kernel.match->checkentry |
| 1530 | goto err; | ||
| 1531 | |||
| 1532 | if (m->u.kernel.match->checkentry | ||
| 1533 | && !m->u.kernel.match->checkentry(name, ip, match, dm->data, | 1544 | && !m->u.kernel.match->checkentry(name, ip, match, dm->data, |
| 1534 | hookmask)) { | 1545 | hookmask)) { |
| 1535 | duprintf("ip_tables: check failed for `%s'.\n", | 1546 | duprintf("ip_tables: check failed for `%s'.\n", |
| 1536 | m->u.kernel.match->name); | 1547 | m->u.kernel.match->name); |
| 1537 | ret = -EINVAL; | 1548 | ret = -EINVAL; |
| 1538 | goto err; | ||
| 1539 | } | 1549 | } |
| 1540 | (*i)++; | ||
| 1541 | return 0; | ||
| 1542 | |||
| 1543 | err: | ||
| 1544 | module_put(m->u.kernel.match->me); | ||
| 1545 | return ret; | 1550 | return ret; |
| 1546 | } | 1551 | } |
| 1547 | 1552 | ||
| @@ -1553,19 +1558,18 @@ static int compat_copy_entry_from_user(struct ipt_entry *e, void **dstptr, | |||
| 1553 | struct ipt_target *target; | 1558 | struct ipt_target *target; |
| 1554 | struct ipt_entry *de; | 1559 | struct ipt_entry *de; |
| 1555 | unsigned int origsize; | 1560 | unsigned int origsize; |
| 1556 | int ret, h, j; | 1561 | int ret, h; |
| 1557 | 1562 | ||
| 1558 | ret = 0; | 1563 | ret = 0; |
| 1559 | origsize = *size; | 1564 | origsize = *size; |
| 1560 | de = (struct ipt_entry *)*dstptr; | 1565 | de = (struct ipt_entry *)*dstptr; |
| 1561 | memcpy(de, e, sizeof(struct ipt_entry)); | 1566 | memcpy(de, e, sizeof(struct ipt_entry)); |
| 1562 | 1567 | ||
| 1563 | j = 0; | ||
| 1564 | *dstptr += sizeof(struct compat_ipt_entry); | 1568 | *dstptr += sizeof(struct compat_ipt_entry); |
| 1565 | ret = IPT_MATCH_ITERATE(e, compat_copy_match_from_user, dstptr, size, | 1569 | ret = IPT_MATCH_ITERATE(e, compat_copy_match_from_user, dstptr, size, |
| 1566 | name, &de->ip, de->comefrom, &j); | 1570 | name, &de->ip, de->comefrom); |
| 1567 | if (ret) | 1571 | if (ret) |
| 1568 | goto cleanup_matches; | 1572 | goto err; |
| 1569 | de->target_offset = e->target_offset - (origsize - *size); | 1573 | de->target_offset = e->target_offset - (origsize - *size); |
| 1570 | t = ipt_get_target(e); | 1574 | t = ipt_get_target(e); |
| 1571 | target = t->u.kernel.target; | 1575 | target = t->u.kernel.target; |
| @@ -1599,12 +1603,7 @@ static int compat_copy_entry_from_user(struct ipt_entry *e, void **dstptr, | |||
| 1599 | goto err; | 1603 | goto err; |
| 1600 | } | 1604 | } |
| 1601 | ret = 0; | 1605 | ret = 0; |
| 1602 | return ret; | ||
| 1603 | |||
| 1604 | err: | 1606 | err: |
| 1605 | module_put(t->u.kernel.target->me); | ||
| 1606 | cleanup_matches: | ||
| 1607 | IPT_MATCH_ITERATE(e, cleanup_match, &j); | ||
| 1608 | return ret; | 1607 | return ret; |
| 1609 | } | 1608 | } |
| 1610 | 1609 | ||
| @@ -1618,7 +1617,7 @@ translate_compat_table(const char *name, | |||
| 1618 | unsigned int *hook_entries, | 1617 | unsigned int *hook_entries, |
| 1619 | unsigned int *underflows) | 1618 | unsigned int *underflows) |
| 1620 | { | 1619 | { |
| 1621 | unsigned int i; | 1620 | unsigned int i, j; |
| 1622 | struct xt_table_info *newinfo, *info; | 1621 | struct xt_table_info *newinfo, *info; |
| 1623 | void *pos, *entry0, *entry1; | 1622 | void *pos, *entry0, *entry1; |
| 1624 | unsigned int size; | 1623 | unsigned int size; |
| @@ -1636,21 +1635,21 @@ translate_compat_table(const char *name, | |||
| 1636 | } | 1635 | } |
| 1637 | 1636 | ||
| 1638 | duprintf("translate_compat_table: size %u\n", info->size); | 1637 | duprintf("translate_compat_table: size %u\n", info->size); |
| 1639 | i = 0; | 1638 | j = 0; |
| 1640 | xt_compat_lock(AF_INET); | 1639 | xt_compat_lock(AF_INET); |
| 1641 | /* Walk through entries, checking offsets. */ | 1640 | /* Walk through entries, checking offsets. */ |
| 1642 | ret = IPT_ENTRY_ITERATE(entry0, total_size, | 1641 | ret = IPT_ENTRY_ITERATE(entry0, total_size, |
| 1643 | check_compat_entry_size_and_hooks, | 1642 | check_compat_entry_size_and_hooks, |
| 1644 | info, &size, entry0, | 1643 | info, &size, entry0, |
| 1645 | entry0 + total_size, | 1644 | entry0 + total_size, |
| 1646 | hook_entries, underflows, &i, name); | 1645 | hook_entries, underflows, &j, name); |
| 1647 | if (ret != 0) | 1646 | if (ret != 0) |
| 1648 | goto out_unlock; | 1647 | goto out_unlock; |
| 1649 | 1648 | ||
| 1650 | ret = -EINVAL; | 1649 | ret = -EINVAL; |
| 1651 | if (i != number) { | 1650 | if (j != number) { |
| 1652 | duprintf("translate_compat_table: %u not %u entries\n", | 1651 | duprintf("translate_compat_table: %u not %u entries\n", |
| 1653 | i, number); | 1652 | j, number); |
| 1654 | goto out_unlock; | 1653 | goto out_unlock; |
| 1655 | } | 1654 | } |
| 1656 | 1655 | ||
| @@ -1709,8 +1708,10 @@ translate_compat_table(const char *name, | |||
| 1709 | free_newinfo: | 1708 | free_newinfo: |
| 1710 | xt_free_table_info(newinfo); | 1709 | xt_free_table_info(newinfo); |
| 1711 | out: | 1710 | out: |
| 1711 | IPT_ENTRY_ITERATE(entry0, total_size, cleanup_entry, &j); | ||
| 1712 | return ret; | 1712 | return ret; |
| 1713 | out_unlock: | 1713 | out_unlock: |
| 1714 | compat_flush_offsets(); | ||
| 1714 | xt_compat_unlock(AF_INET); | 1715 | xt_compat_unlock(AF_INET); |
| 1715 | goto out; | 1716 | goto out; |
| 1716 | } | 1717 | } |
diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c index b430cf2a4f66..5c31dead2bdc 100644 --- a/net/ipv4/raw.c +++ b/net/ipv4/raw.c | |||
| @@ -329,7 +329,7 @@ error: | |||
| 329 | return err; | 329 | return err; |
| 330 | } | 330 | } |
| 331 | 331 | ||
| 332 | static void raw_probe_proto_opt(struct flowi *fl, struct msghdr *msg) | 332 | static int raw_probe_proto_opt(struct flowi *fl, struct msghdr *msg) |
| 333 | { | 333 | { |
| 334 | struct iovec *iov; | 334 | struct iovec *iov; |
| 335 | u8 __user *type = NULL; | 335 | u8 __user *type = NULL; |
| @@ -338,7 +338,7 @@ static void raw_probe_proto_opt(struct flowi *fl, struct msghdr *msg) | |||
| 338 | unsigned int i; | 338 | unsigned int i; |
| 339 | 339 | ||
| 340 | if (!msg->msg_iov) | 340 | if (!msg->msg_iov) |
| 341 | return; | 341 | return 0; |
| 342 | 342 | ||
| 343 | for (i = 0; i < msg->msg_iovlen; i++) { | 343 | for (i = 0; i < msg->msg_iovlen; i++) { |
| 344 | iov = &msg->msg_iov[i]; | 344 | iov = &msg->msg_iov[i]; |
| @@ -360,8 +360,9 @@ static void raw_probe_proto_opt(struct flowi *fl, struct msghdr *msg) | |||
| 360 | code = iov->iov_base; | 360 | code = iov->iov_base; |
| 361 | 361 | ||
| 362 | if (type && code) { | 362 | if (type && code) { |
| 363 | get_user(fl->fl_icmp_type, type); | 363 | if (get_user(fl->fl_icmp_type, type) || |
| 364 | get_user(fl->fl_icmp_code, code); | 364 | get_user(fl->fl_icmp_code, code)) |
| 365 | return -EFAULT; | ||
| 365 | probed = 1; | 366 | probed = 1; |
| 366 | } | 367 | } |
| 367 | break; | 368 | break; |
| @@ -372,6 +373,7 @@ static void raw_probe_proto_opt(struct flowi *fl, struct msghdr *msg) | |||
| 372 | if (probed) | 373 | if (probed) |
| 373 | break; | 374 | break; |
| 374 | } | 375 | } |
| 376 | return 0; | ||
| 375 | } | 377 | } |
| 376 | 378 | ||
| 377 | static int raw_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg, | 379 | static int raw_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg, |
| @@ -480,8 +482,11 @@ static int raw_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg, | |||
| 480 | .proto = inet->hdrincl ? IPPROTO_RAW : | 482 | .proto = inet->hdrincl ? IPPROTO_RAW : |
| 481 | sk->sk_protocol, | 483 | sk->sk_protocol, |
| 482 | }; | 484 | }; |
| 483 | if (!inet->hdrincl) | 485 | if (!inet->hdrincl) { |
| 484 | raw_probe_proto_opt(&fl, msg); | 486 | err = raw_probe_proto_opt(&fl, msg); |
| 487 | if (err) | ||
| 488 | goto done; | ||
| 489 | } | ||
| 485 | 490 | ||
| 486 | security_sk_classify_flow(sk, &fl); | 491 | security_sk_classify_flow(sk, &fl); |
| 487 | err = ip_route_output_flow(&rt, &fl, sk, !(msg->msg_flags&MSG_DONTWAIT)); | 492 | err = ip_route_output_flow(&rt, &fl, sk, !(msg->msg_flags&MSG_DONTWAIT)); |
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index e82a5be894b5..15061b314411 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4/sysctl_net_ipv4.c | |||
| @@ -129,13 +129,6 @@ static int sysctl_tcp_congestion_control(ctl_table *table, int __user *name, | |||
| 129 | return ret; | 129 | return ret; |
| 130 | } | 130 | } |
| 131 | 131 | ||
| 132 | static int __init tcp_congestion_default(void) | ||
| 133 | { | ||
| 134 | return tcp_set_default_congestion_control(CONFIG_DEFAULT_TCP_CONG); | ||
| 135 | } | ||
| 136 | |||
| 137 | late_initcall(tcp_congestion_default); | ||
| 138 | |||
| 139 | ctl_table ipv4_table[] = { | 132 | ctl_table ipv4_table[] = { |
| 140 | { | 133 | { |
| 141 | .ctl_name = NET_IPV4_TCP_TIMESTAMPS, | 134 | .ctl_name = NET_IPV4_TCP_TIMESTAMPS, |
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 66e9a729f6df..c05e8edaf544 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c | |||
| @@ -2270,7 +2270,7 @@ void __init tcp_init(void) | |||
| 2270 | thash_entries, | 2270 | thash_entries, |
| 2271 | (num_physpages >= 128 * 1024) ? | 2271 | (num_physpages >= 128 * 1024) ? |
| 2272 | 13 : 15, | 2272 | 13 : 15, |
| 2273 | HASH_HIGHMEM, | 2273 | 0, |
| 2274 | &tcp_hashinfo.ehash_size, | 2274 | &tcp_hashinfo.ehash_size, |
| 2275 | NULL, | 2275 | NULL, |
| 2276 | 0); | 2276 | 0); |
| @@ -2286,7 +2286,7 @@ void __init tcp_init(void) | |||
| 2286 | tcp_hashinfo.ehash_size, | 2286 | tcp_hashinfo.ehash_size, |
| 2287 | (num_physpages >= 128 * 1024) ? | 2287 | (num_physpages >= 128 * 1024) ? |
| 2288 | 13 : 15, | 2288 | 13 : 15, |
| 2289 | HASH_HIGHMEM, | 2289 | 0, |
| 2290 | &tcp_hashinfo.bhash_size, | 2290 | &tcp_hashinfo.bhash_size, |
| 2291 | NULL, | 2291 | NULL, |
| 2292 | 64 * 1024); | 2292 | 64 * 1024); |
| @@ -2316,9 +2316,10 @@ void __init tcp_init(void) | |||
| 2316 | sysctl_max_syn_backlog = 128; | 2316 | sysctl_max_syn_backlog = 128; |
| 2317 | } | 2317 | } |
| 2318 | 2318 | ||
| 2319 | sysctl_tcp_mem[0] = 768 << order; | 2319 | /* Allow no more than 3/4 kernel memory (usually less) allocated to TCP */ |
| 2320 | sysctl_tcp_mem[1] = 1024 << order; | 2320 | sysctl_tcp_mem[0] = (1536 / sizeof (struct inet_bind_hashbucket)) << order; |
| 2321 | sysctl_tcp_mem[2] = 1536 << order; | 2321 | sysctl_tcp_mem[1] = sysctl_tcp_mem[0] * 4 / 3; |
| 2322 | sysctl_tcp_mem[2] = sysctl_tcp_mem[0] * 2; | ||
| 2322 | 2323 | ||
| 2323 | limit = ((unsigned long)sysctl_tcp_mem[1]) << (PAGE_SHIFT - 7); | 2324 | limit = ((unsigned long)sysctl_tcp_mem[1]) << (PAGE_SHIFT - 7); |
| 2324 | max_share = min(4UL*1024*1024, limit); | 2325 | max_share = min(4UL*1024*1024, limit); |
diff --git a/net/ipv4/tcp_cong.c b/net/ipv4/tcp_cong.c index af0aca1e6be6..1e2982f4acd4 100644 --- a/net/ipv4/tcp_cong.c +++ b/net/ipv4/tcp_cong.c | |||
| @@ -131,6 +131,14 @@ int tcp_set_default_congestion_control(const char *name) | |||
| 131 | return ret; | 131 | return ret; |
| 132 | } | 132 | } |
| 133 | 133 | ||
| 134 | /* Set default value from kernel configuration at bootup */ | ||
| 135 | static int __init tcp_congestion_default(void) | ||
| 136 | { | ||
| 137 | return tcp_set_default_congestion_control(CONFIG_DEFAULT_TCP_CONG); | ||
| 138 | } | ||
| 139 | late_initcall(tcp_congestion_default); | ||
| 140 | |||
| 141 | |||
| 134 | /* Get current default congestion control */ | 142 | /* Get current default congestion control */ |
| 135 | void tcp_get_default_congestion_control(char *name) | 143 | void tcp_get_default_congestion_control(char *name) |
| 136 | { | 144 | { |
diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c index a60ef38d75c6..6ad184802266 100644 --- a/net/ipv4/tcp_cubic.c +++ b/net/ipv4/tcp_cubic.c | |||
| @@ -190,7 +190,7 @@ static inline void bictcp_update(struct bictcp *ca, u32 cwnd) | |||
| 190 | */ | 190 | */ |
| 191 | 191 | ||
| 192 | /* change the unit from HZ to bictcp_HZ */ | 192 | /* change the unit from HZ to bictcp_HZ */ |
| 193 | t = ((tcp_time_stamp + ca->delay_min - ca->epoch_start) | 193 | t = ((tcp_time_stamp + (ca->delay_min>>3) - ca->epoch_start) |
| 194 | << BICTCP_HZ) / HZ; | 194 | << BICTCP_HZ) / HZ; |
| 195 | 195 | ||
| 196 | if (t < ca->bic_K) /* t - K */ | 196 | if (t < ca->bic_K) /* t - K */ |
| @@ -259,7 +259,7 @@ static inline void measure_delay(struct sock *sk) | |||
| 259 | (s32)(tcp_time_stamp - ca->epoch_start) < HZ) | 259 | (s32)(tcp_time_stamp - ca->epoch_start) < HZ) |
| 260 | return; | 260 | return; |
| 261 | 261 | ||
| 262 | delay = tcp_time_stamp - tp->rx_opt.rcv_tsecr; | 262 | delay = (tcp_time_stamp - tp->rx_opt.rcv_tsecr)<<3; |
| 263 | if (delay == 0) | 263 | if (delay == 0) |
| 264 | delay = 1; | 264 | delay = 1; |
| 265 | 265 | ||
| @@ -366,7 +366,7 @@ static int __init cubictcp_register(void) | |||
| 366 | 366 | ||
| 367 | beta_scale = 8*(BICTCP_BETA_SCALE+beta)/ 3 / (BICTCP_BETA_SCALE - beta); | 367 | beta_scale = 8*(BICTCP_BETA_SCALE+beta)/ 3 / (BICTCP_BETA_SCALE - beta); |
| 368 | 368 | ||
| 369 | cube_rtt_scale = (bic_scale << 3) / 10; /* 1024*c/rtt */ | 369 | cube_rtt_scale = (bic_scale * 10); /* 1024*c/rtt */ |
| 370 | 370 | ||
| 371 | /* calculate the "K" for (wmax-cwnd) = c/rtt * K^3 | 371 | /* calculate the "K" for (wmax-cwnd) = c/rtt * K^3 |
| 372 | * so K = cubic_root( (wmax-cwnd)*rtt/c ) | 372 | * so K = cubic_root( (wmax-cwnd)*rtt/c ) |
diff --git a/net/ipv4/tcp_htcp.c b/net/ipv4/tcp_htcp.c index 682e7d5b6f2f..283be3cb4667 100644 --- a/net/ipv4/tcp_htcp.c +++ b/net/ipv4/tcp_htcp.c | |||
| @@ -23,7 +23,7 @@ module_param(use_bandwidth_switch, int, 0644); | |||
| 23 | MODULE_PARM_DESC(use_bandwidth_switch, "turn on/off bandwidth switcher"); | 23 | MODULE_PARM_DESC(use_bandwidth_switch, "turn on/off bandwidth switcher"); |
| 24 | 24 | ||
| 25 | struct htcp { | 25 | struct htcp { |
| 26 | u16 alpha; /* Fixed point arith, << 7 */ | 26 | u32 alpha; /* Fixed point arith, << 7 */ |
| 27 | u8 beta; /* Fixed point arith, << 7 */ | 27 | u8 beta; /* Fixed point arith, << 7 */ |
| 28 | u8 modeswitch; /* Delay modeswitch until we had at least one congestion event */ | 28 | u8 modeswitch; /* Delay modeswitch until we had at least one congestion event */ |
| 29 | u32 last_cong; /* Time since last congestion event end */ | 29 | u32 last_cong; /* Time since last congestion event end */ |
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index 8fcae7a6510b..f98ca30d7c1f 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c | |||
| @@ -169,7 +169,6 @@ static __inline__ void rt6_release(struct rt6_info *rt) | |||
| 169 | 169 | ||
| 170 | static struct fib6_table fib6_main_tbl = { | 170 | static struct fib6_table fib6_main_tbl = { |
| 171 | .tb6_id = RT6_TABLE_MAIN, | 171 | .tb6_id = RT6_TABLE_MAIN, |
| 172 | .tb6_lock = RW_LOCK_UNLOCKED, | ||
| 173 | .tb6_root = { | 172 | .tb6_root = { |
| 174 | .leaf = &ip6_null_entry, | 173 | .leaf = &ip6_null_entry, |
| 175 | .fn_flags = RTN_ROOT | RTN_TL_ROOT | RTN_RTINFO, | 174 | .fn_flags = RTN_ROOT | RTN_TL_ROOT | RTN_RTINFO, |
| @@ -187,6 +186,12 @@ static void fib6_link_table(struct fib6_table *tb) | |||
| 187 | { | 186 | { |
| 188 | unsigned int h; | 187 | unsigned int h; |
| 189 | 188 | ||
| 189 | /* | ||
| 190 | * Initialize table lock at a single place to give lockdep a key, | ||
| 191 | * tables aren't visible prior to being linked to the list. | ||
| 192 | */ | ||
| 193 | rwlock_init(&tb->tb6_lock); | ||
| 194 | |||
| 190 | h = tb->tb6_id & (FIB_TABLE_HASHSZ - 1); | 195 | h = tb->tb6_id & (FIB_TABLE_HASHSZ - 1); |
| 191 | 196 | ||
| 192 | /* | 197 | /* |
| @@ -199,7 +204,6 @@ static void fib6_link_table(struct fib6_table *tb) | |||
| 199 | #ifdef CONFIG_IPV6_MULTIPLE_TABLES | 204 | #ifdef CONFIG_IPV6_MULTIPLE_TABLES |
| 200 | static struct fib6_table fib6_local_tbl = { | 205 | static struct fib6_table fib6_local_tbl = { |
| 201 | .tb6_id = RT6_TABLE_LOCAL, | 206 | .tb6_id = RT6_TABLE_LOCAL, |
| 202 | .tb6_lock = RW_LOCK_UNLOCKED, | ||
| 203 | .tb6_root = { | 207 | .tb6_root = { |
| 204 | .leaf = &ip6_null_entry, | 208 | .leaf = &ip6_null_entry, |
| 205 | .fn_flags = RTN_ROOT | RTN_TL_ROOT | RTN_RTINFO, | 209 | .fn_flags = RTN_ROOT | RTN_TL_ROOT | RTN_RTINFO, |
| @@ -213,7 +217,6 @@ static struct fib6_table *fib6_alloc_table(u32 id) | |||
| 213 | table = kzalloc(sizeof(*table), GFP_ATOMIC); | 217 | table = kzalloc(sizeof(*table), GFP_ATOMIC); |
| 214 | if (table != NULL) { | 218 | if (table != NULL) { |
| 215 | table->tb6_id = id; | 219 | table->tb6_id = id; |
| 216 | table->tb6_lock = RW_LOCK_UNLOCKED; | ||
| 217 | table->tb6_root.leaf = &ip6_null_entry; | 220 | table->tb6_root.leaf = &ip6_null_entry; |
| 218 | table->tb6_root.fn_flags = RTN_ROOT | RTN_TL_ROOT | RTN_RTINFO; | 221 | table->tb6_root.fn_flags = RTN_ROOT | RTN_TL_ROOT | RTN_RTINFO; |
| 219 | } | 222 | } |
diff --git a/net/ipv6/ip6_flowlabel.c b/net/ipv6/ip6_flowlabel.c index 1d672b0547f2..6d4533b58dca 100644 --- a/net/ipv6/ip6_flowlabel.c +++ b/net/ipv6/ip6_flowlabel.c | |||
| @@ -330,8 +330,10 @@ fl_create(struct in6_flowlabel_req *freq, char __user *optval, int optlen, int * | |||
| 330 | fl->share = freq->flr_share; | 330 | fl->share = freq->flr_share; |
| 331 | addr_type = ipv6_addr_type(&freq->flr_dst); | 331 | addr_type = ipv6_addr_type(&freq->flr_dst); |
| 332 | if ((addr_type&IPV6_ADDR_MAPPED) | 332 | if ((addr_type&IPV6_ADDR_MAPPED) |
| 333 | || addr_type == IPV6_ADDR_ANY) | 333 | || addr_type == IPV6_ADDR_ANY) { |
| 334 | err = -EINVAL; | ||
| 334 | goto done; | 335 | goto done; |
| 336 | } | ||
| 335 | ipv6_addr_copy(&fl->dst, &freq->flr_dst); | 337 | ipv6_addr_copy(&fl->dst, &freq->flr_dst); |
| 336 | atomic_set(&fl->users, 1); | 338 | atomic_set(&fl->users, 1); |
| 337 | switch (fl->share) { | 339 | switch (fl->share) { |
| @@ -587,6 +589,8 @@ static struct ip6_flowlabel *ip6fl_get_next(struct seq_file *seq, struct ip6_flo | |||
| 587 | while (!fl) { | 589 | while (!fl) { |
| 588 | if (++state->bucket <= FL_HASH_MASK) | 590 | if (++state->bucket <= FL_HASH_MASK) |
| 589 | fl = fl_ht[state->bucket]; | 591 | fl = fl_ht[state->bucket]; |
| 592 | else | ||
| 593 | break; | ||
| 590 | } | 594 | } |
| 591 | return fl; | 595 | return fl; |
| 592 | } | 596 | } |
| @@ -623,9 +627,13 @@ static void ip6fl_seq_stop(struct seq_file *seq, void *v) | |||
| 623 | read_unlock_bh(&ip6_fl_lock); | 627 | read_unlock_bh(&ip6_fl_lock); |
| 624 | } | 628 | } |
| 625 | 629 | ||
| 626 | static void ip6fl_fl_seq_show(struct seq_file *seq, struct ip6_flowlabel *fl) | 630 | static int ip6fl_seq_show(struct seq_file *seq, void *v) |
| 627 | { | 631 | { |
| 628 | while(fl) { | 632 | if (v == SEQ_START_TOKEN) |
| 633 | seq_printf(seq, "%-5s %-1s %-6s %-6s %-6s %-8s %-32s %s\n", | ||
| 634 | "Label", "S", "Owner", "Users", "Linger", "Expires", "Dst", "Opt"); | ||
| 635 | else { | ||
| 636 | struct ip6_flowlabel *fl = v; | ||
| 629 | seq_printf(seq, | 637 | seq_printf(seq, |
| 630 | "%05X %-1d %-6d %-6d %-6ld %-8ld " NIP6_SEQFMT " %-4d\n", | 638 | "%05X %-1d %-6d %-6d %-6ld %-8ld " NIP6_SEQFMT " %-4d\n", |
| 631 | (unsigned)ntohl(fl->label), | 639 | (unsigned)ntohl(fl->label), |
| @@ -636,17 +644,7 @@ static void ip6fl_fl_seq_show(struct seq_file *seq, struct ip6_flowlabel *fl) | |||
| 636 | (long)(fl->expires - jiffies)/HZ, | 644 | (long)(fl->expires - jiffies)/HZ, |
| 637 | NIP6(fl->dst), | 645 | NIP6(fl->dst), |
| 638 | fl->opt ? fl->opt->opt_nflen : 0); | 646 | fl->opt ? fl->opt->opt_nflen : 0); |
| 639 | fl = fl->next; | ||
| 640 | } | 647 | } |
| 641 | } | ||
| 642 | |||
| 643 | static int ip6fl_seq_show(struct seq_file *seq, void *v) | ||
| 644 | { | ||
| 645 | if (v == SEQ_START_TOKEN) | ||
| 646 | seq_printf(seq, "%-5s %-1s %-6s %-6s %-6s %-8s %-32s %s\n", | ||
| 647 | "Label", "S", "Owner", "Users", "Linger", "Expires", "Dst", "Opt"); | ||
| 648 | else | ||
| 649 | ip6fl_fl_seq_show(seq, v); | ||
| 650 | return 0; | 648 | return 0; |
| 651 | } | 649 | } |
| 652 | 650 | ||
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 41a8a5f06602..73eb8c33e9f0 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c | |||
| @@ -1742,6 +1742,7 @@ int __init ndisc_init(struct net_proto_family *ops) | |||
| 1742 | 1742 | ||
| 1743 | void ndisc_cleanup(void) | 1743 | void ndisc_cleanup(void) |
| 1744 | { | 1744 | { |
| 1745 | unregister_netdevice_notifier(&ndisc_netdev_notifier); | ||
| 1745 | #ifdef CONFIG_SYSCTL | 1746 | #ifdef CONFIG_SYSCTL |
| 1746 | neigh_sysctl_unregister(&nd_tbl.parms); | 1747 | neigh_sysctl_unregister(&nd_tbl.parms); |
| 1747 | #endif | 1748 | #endif |
diff --git a/net/ipv6/netfilter/Kconfig b/net/ipv6/netfilter/Kconfig index 4bc4e5b33794..d7c45a9c15fe 100644 --- a/net/ipv6/netfilter/Kconfig +++ b/net/ipv6/netfilter/Kconfig | |||
| @@ -40,7 +40,7 @@ config IP6_NF_QUEUE | |||
| 40 | To compile it as a module, choose M here. If unsure, say N. | 40 | To compile it as a module, choose M here. If unsure, say N. |
| 41 | 41 | ||
| 42 | config IP6_NF_IPTABLES | 42 | config IP6_NF_IPTABLES |
| 43 | tristate "IP6 tables support (required for filtering/masq/NAT)" | 43 | tristate "IP6 tables support (required for filtering)" |
| 44 | depends on NETFILTER_XTABLES | 44 | depends on NETFILTER_XTABLES |
| 45 | help | 45 | help |
| 46 | ip6tables is a general, extensible packet identification framework. | 46 | ip6tables is a general, extensible packet identification framework. |
diff --git a/net/ipv6/netfilter/ip6_queue.c b/net/ipv6/netfilter/ip6_queue.c index 9510c24ca8d2..9fec832ee08b 100644 --- a/net/ipv6/netfilter/ip6_queue.c +++ b/net/ipv6/netfilter/ip6_queue.c | |||
| @@ -349,9 +349,10 @@ ipq_mangle_ipv6(ipq_verdict_msg_t *v, struct ipq_queue_entry *e) | |||
| 349 | if (v->data_len < sizeof(*user_iph)) | 349 | if (v->data_len < sizeof(*user_iph)) |
| 350 | return 0; | 350 | return 0; |
| 351 | diff = v->data_len - e->skb->len; | 351 | diff = v->data_len - e->skb->len; |
| 352 | if (diff < 0) | 352 | if (diff < 0) { |
| 353 | skb_trim(e->skb, v->data_len); | 353 | if (pskb_trim(e->skb, v->data_len)) |
| 354 | else if (diff > 0) { | 354 | return -ENOMEM; |
| 355 | } else if (diff > 0) { | ||
| 355 | if (v->data_len > 0xFFFF) | 356 | if (v->data_len > 0xFFFF) |
| 356 | return -EINVAL; | 357 | return -EINVAL; |
| 357 | if (diff > skb_tailroom(e->skb)) { | 358 | if (diff > skb_tailroom(e->skb)) { |
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c index 4ab368fa0b8f..204e02162d49 100644 --- a/net/ipv6/netfilter/ip6_tables.c +++ b/net/ipv6/netfilter/ip6_tables.c | |||
| @@ -111,7 +111,7 @@ ip6_packet_match(const struct sk_buff *skb, | |||
| 111 | const char *outdev, | 111 | const char *outdev, |
| 112 | const struct ip6t_ip6 *ip6info, | 112 | const struct ip6t_ip6 *ip6info, |
| 113 | unsigned int *protoff, | 113 | unsigned int *protoff, |
| 114 | int *fragoff) | 114 | int *fragoff, int *hotdrop) |
| 115 | { | 115 | { |
| 116 | size_t i; | 116 | size_t i; |
| 117 | unsigned long ret; | 117 | unsigned long ret; |
| @@ -169,9 +169,11 @@ ip6_packet_match(const struct sk_buff *skb, | |||
| 169 | unsigned short _frag_off; | 169 | unsigned short _frag_off; |
| 170 | 170 | ||
| 171 | protohdr = ipv6_find_hdr(skb, protoff, -1, &_frag_off); | 171 | protohdr = ipv6_find_hdr(skb, protoff, -1, &_frag_off); |
| 172 | if (protohdr < 0) | 172 | if (protohdr < 0) { |
| 173 | if (_frag_off == 0) | ||
| 174 | *hotdrop = 1; | ||
| 173 | return 0; | 175 | return 0; |
| 174 | 176 | } | |
| 175 | *fragoff = _frag_off; | 177 | *fragoff = _frag_off; |
| 176 | 178 | ||
| 177 | dprintf("Packet protocol %hi ?= %s%hi.\n", | 179 | dprintf("Packet protocol %hi ?= %s%hi.\n", |
| @@ -290,7 +292,7 @@ ip6t_do_table(struct sk_buff **pskb, | |||
| 290 | IP_NF_ASSERT(e); | 292 | IP_NF_ASSERT(e); |
| 291 | IP_NF_ASSERT(back); | 293 | IP_NF_ASSERT(back); |
| 292 | if (ip6_packet_match(*pskb, indev, outdev, &e->ipv6, | 294 | if (ip6_packet_match(*pskb, indev, outdev, &e->ipv6, |
| 293 | &protoff, &offset)) { | 295 | &protoff, &offset, &hotdrop)) { |
| 294 | struct ip6t_entry_target *t; | 296 | struct ip6t_entry_target *t; |
| 295 | 297 | ||
| 296 | if (IP6T_MATCH_ITERATE(e, do_match, | 298 | if (IP6T_MATCH_ITERATE(e, do_match, |
| @@ -584,12 +586,19 @@ check_entry(struct ip6t_entry *e, const char *name, unsigned int size, | |||
| 584 | return -EINVAL; | 586 | return -EINVAL; |
| 585 | } | 587 | } |
| 586 | 588 | ||
| 589 | if (e->target_offset + sizeof(struct ip6t_entry_target) > | ||
| 590 | e->next_offset) | ||
| 591 | return -EINVAL; | ||
| 592 | |||
| 587 | j = 0; | 593 | j = 0; |
| 588 | ret = IP6T_MATCH_ITERATE(e, check_match, name, &e->ipv6, e->comefrom, &j); | 594 | ret = IP6T_MATCH_ITERATE(e, check_match, name, &e->ipv6, e->comefrom, &j); |
| 589 | if (ret != 0) | 595 | if (ret != 0) |
| 590 | goto cleanup_matches; | 596 | goto cleanup_matches; |
| 591 | 597 | ||
| 592 | t = ip6t_get_target(e); | 598 | t = ip6t_get_target(e); |
| 599 | ret = -EINVAL; | ||
| 600 | if (e->target_offset + t->u.target_size > e->next_offset) | ||
| 601 | goto cleanup_matches; | ||
| 593 | target = try_then_request_module(xt_find_target(AF_INET6, | 602 | target = try_then_request_module(xt_find_target(AF_INET6, |
| 594 | t->u.user.name, | 603 | t->u.user.name, |
| 595 | t->u.user.revision), | 604 | t->u.user.revision), |
| @@ -749,19 +758,17 @@ translate_table(const char *name, | |||
| 749 | } | 758 | } |
| 750 | } | 759 | } |
| 751 | 760 | ||
| 752 | if (!mark_source_chains(newinfo, valid_hooks, entry0)) | ||
| 753 | return -ELOOP; | ||
| 754 | |||
| 755 | /* Finally, each sanity check must pass */ | 761 | /* Finally, each sanity check must pass */ |
| 756 | i = 0; | 762 | i = 0; |
| 757 | ret = IP6T_ENTRY_ITERATE(entry0, newinfo->size, | 763 | ret = IP6T_ENTRY_ITERATE(entry0, newinfo->size, |
| 758 | check_entry, name, size, &i); | 764 | check_entry, name, size, &i); |
| 759 | 765 | ||
| 760 | if (ret != 0) { | 766 | if (ret != 0) |
| 761 | IP6T_ENTRY_ITERATE(entry0, newinfo->size, | 767 | goto cleanup; |
| 762 | cleanup_entry, &i); | 768 | |
| 763 | return ret; | 769 | ret = -ELOOP; |
| 764 | } | 770 | if (!mark_source_chains(newinfo, valid_hooks, entry0)) |
| 771 | goto cleanup; | ||
| 765 | 772 | ||
| 766 | /* And one copy for every other CPU */ | 773 | /* And one copy for every other CPU */ |
| 767 | for_each_possible_cpu(i) { | 774 | for_each_possible_cpu(i) { |
| @@ -769,6 +776,9 @@ translate_table(const char *name, | |||
| 769 | memcpy(newinfo->entries[i], entry0, newinfo->size); | 776 | memcpy(newinfo->entries[i], entry0, newinfo->size); |
| 770 | } | 777 | } |
| 771 | 778 | ||
| 779 | return 0; | ||
| 780 | cleanup: | ||
| 781 | IP6T_ENTRY_ITERATE(entry0, newinfo->size, cleanup_entry, &i); | ||
| 772 | return ret; | 782 | return ret; |
| 773 | } | 783 | } |
| 774 | 784 | ||
| @@ -1438,6 +1448,9 @@ static void __exit ip6_tables_fini(void) | |||
| 1438 | * If target header is found, its offset is set in *offset and return protocol | 1448 | * If target header is found, its offset is set in *offset and return protocol |
| 1439 | * number. Otherwise, return -1. | 1449 | * number. Otherwise, return -1. |
| 1440 | * | 1450 | * |
| 1451 | * If the first fragment doesn't contain the final protocol header or | ||
| 1452 | * NEXTHDR_NONE it is considered invalid. | ||
| 1453 | * | ||
| 1441 | * Note that non-1st fragment is special case that "the protocol number | 1454 | * Note that non-1st fragment is special case that "the protocol number |
| 1442 | * of last header" is "next header" field in Fragment header. In this case, | 1455 | * of last header" is "next header" field in Fragment header. In this case, |
| 1443 | * *offset is meaningless and fragment offset is stored in *fragoff if fragoff | 1456 | * *offset is meaningless and fragment offset is stored in *fragoff if fragoff |
| @@ -1461,12 +1474,12 @@ int ipv6_find_hdr(const struct sk_buff *skb, unsigned int *offset, | |||
| 1461 | if ((!ipv6_ext_hdr(nexthdr)) || nexthdr == NEXTHDR_NONE) { | 1474 | if ((!ipv6_ext_hdr(nexthdr)) || nexthdr == NEXTHDR_NONE) { |
| 1462 | if (target < 0) | 1475 | if (target < 0) |
| 1463 | break; | 1476 | break; |
| 1464 | return -1; | 1477 | return -ENOENT; |
| 1465 | } | 1478 | } |
| 1466 | 1479 | ||
| 1467 | hp = skb_header_pointer(skb, start, sizeof(_hdr), &_hdr); | 1480 | hp = skb_header_pointer(skb, start, sizeof(_hdr), &_hdr); |
| 1468 | if (hp == NULL) | 1481 | if (hp == NULL) |
| 1469 | return -1; | 1482 | return -EBADMSG; |
| 1470 | if (nexthdr == NEXTHDR_FRAGMENT) { | 1483 | if (nexthdr == NEXTHDR_FRAGMENT) { |
| 1471 | unsigned short _frag_off, *fp; | 1484 | unsigned short _frag_off, *fp; |
| 1472 | fp = skb_header_pointer(skb, | 1485 | fp = skb_header_pointer(skb, |
| @@ -1475,18 +1488,18 @@ int ipv6_find_hdr(const struct sk_buff *skb, unsigned int *offset, | |||
| 1475 | sizeof(_frag_off), | 1488 | sizeof(_frag_off), |
| 1476 | &_frag_off); | 1489 | &_frag_off); |
| 1477 | if (fp == NULL) | 1490 | if (fp == NULL) |
| 1478 | return -1; | 1491 | return -EBADMSG; |
| 1479 | 1492 | ||
| 1480 | _frag_off = ntohs(*fp) & ~0x7; | 1493 | _frag_off = ntohs(*fp) & ~0x7; |
| 1481 | if (_frag_off) { | 1494 | if (_frag_off) { |
| 1482 | if (target < 0 && | 1495 | if (target < 0 && |
| 1483 | ((!ipv6_ext_hdr(hp->nexthdr)) || | 1496 | ((!ipv6_ext_hdr(hp->nexthdr)) || |
| 1484 | nexthdr == NEXTHDR_NONE)) { | 1497 | hp->nexthdr == NEXTHDR_NONE)) { |
| 1485 | if (fragoff) | 1498 | if (fragoff) |
| 1486 | *fragoff = _frag_off; | 1499 | *fragoff = _frag_off; |
| 1487 | return hp->nexthdr; | 1500 | return hp->nexthdr; |
| 1488 | } | 1501 | } |
| 1489 | return -1; | 1502 | return -ENOENT; |
| 1490 | } | 1503 | } |
| 1491 | hdrlen = 8; | 1504 | hdrlen = 8; |
| 1492 | } else if (nexthdr == NEXTHDR_AUTH) | 1505 | } else if (nexthdr == NEXTHDR_AUTH) |
diff --git a/net/ipv6/netfilter/ip6t_ah.c b/net/ipv6/netfilter/ip6t_ah.c index ec1b1608156c..46486645eb75 100644 --- a/net/ipv6/netfilter/ip6t_ah.c +++ b/net/ipv6/netfilter/ip6t_ah.c | |||
| @@ -54,9 +54,14 @@ match(const struct sk_buff *skb, | |||
| 54 | const struct ip6t_ah *ahinfo = matchinfo; | 54 | const struct ip6t_ah *ahinfo = matchinfo; |
| 55 | unsigned int ptr; | 55 | unsigned int ptr; |
| 56 | unsigned int hdrlen = 0; | 56 | unsigned int hdrlen = 0; |
| 57 | int err; | ||
| 57 | 58 | ||
| 58 | if (ipv6_find_hdr(skb, &ptr, NEXTHDR_AUTH, NULL) < 0) | 59 | err = ipv6_find_hdr(skb, &ptr, NEXTHDR_AUTH, NULL); |
| 60 | if (err < 0) { | ||
| 61 | if (err != -ENOENT) | ||
| 62 | *hotdrop = 1; | ||
| 59 | return 0; | 63 | return 0; |
| 64 | } | ||
| 60 | 65 | ||
| 61 | ah = skb_header_pointer(skb, ptr, sizeof(_ah), &_ah); | 66 | ah = skb_header_pointer(skb, ptr, sizeof(_ah), &_ah); |
| 62 | if (ah == NULL) { | 67 | if (ah == NULL) { |
diff --git a/net/ipv6/netfilter/ip6t_frag.c b/net/ipv6/netfilter/ip6t_frag.c index 78d9c8b9e28a..cd22eaaccdca 100644 --- a/net/ipv6/netfilter/ip6t_frag.c +++ b/net/ipv6/netfilter/ip6t_frag.c | |||
| @@ -52,9 +52,14 @@ match(const struct sk_buff *skb, | |||
| 52 | struct frag_hdr _frag, *fh; | 52 | struct frag_hdr _frag, *fh; |
| 53 | const struct ip6t_frag *fraginfo = matchinfo; | 53 | const struct ip6t_frag *fraginfo = matchinfo; |
| 54 | unsigned int ptr; | 54 | unsigned int ptr; |
| 55 | int err; | ||
| 55 | 56 | ||
| 56 | if (ipv6_find_hdr(skb, &ptr, NEXTHDR_FRAGMENT, NULL) < 0) | 57 | err = ipv6_find_hdr(skb, &ptr, NEXTHDR_FRAGMENT, NULL); |
| 58 | if (err < 0) { | ||
| 59 | if (err != -ENOENT) | ||
| 60 | *hotdrop = 1; | ||
| 57 | return 0; | 61 | return 0; |
| 62 | } | ||
| 58 | 63 | ||
| 59 | fh = skb_header_pointer(skb, ptr, sizeof(_frag), &_frag); | 64 | fh = skb_header_pointer(skb, ptr, sizeof(_frag), &_frag); |
| 60 | if (fh == NULL) { | 65 | if (fh == NULL) { |
diff --git a/net/ipv6/netfilter/ip6t_hbh.c b/net/ipv6/netfilter/ip6t_hbh.c index d32a205e3af2..3f25babe0440 100644 --- a/net/ipv6/netfilter/ip6t_hbh.c +++ b/net/ipv6/netfilter/ip6t_hbh.c | |||
| @@ -65,9 +65,14 @@ match(const struct sk_buff *skb, | |||
| 65 | u8 _opttype, *tp = NULL; | 65 | u8 _opttype, *tp = NULL; |
| 66 | u8 _optlen, *lp = NULL; | 66 | u8 _optlen, *lp = NULL; |
| 67 | unsigned int optlen; | 67 | unsigned int optlen; |
| 68 | int err; | ||
| 68 | 69 | ||
| 69 | if (ipv6_find_hdr(skb, &ptr, match->data, NULL) < 0) | 70 | err = ipv6_find_hdr(skb, &ptr, match->data, NULL); |
| 71 | if (err < 0) { | ||
| 72 | if (err != -ENOENT) | ||
| 73 | *hotdrop = 1; | ||
| 70 | return 0; | 74 | return 0; |
| 75 | } | ||
| 71 | 76 | ||
| 72 | oh = skb_header_pointer(skb, ptr, sizeof(_optsh), &_optsh); | 77 | oh = skb_header_pointer(skb, ptr, sizeof(_optsh), &_optsh); |
| 73 | if (oh == NULL) { | 78 | if (oh == NULL) { |
diff --git a/net/ipv6/netfilter/ip6t_rt.c b/net/ipv6/netfilter/ip6t_rt.c index bcb2e168a5bc..54d7d14134fd 100644 --- a/net/ipv6/netfilter/ip6t_rt.c +++ b/net/ipv6/netfilter/ip6t_rt.c | |||
| @@ -58,9 +58,14 @@ match(const struct sk_buff *skb, | |||
| 58 | unsigned int hdrlen = 0; | 58 | unsigned int hdrlen = 0; |
| 59 | unsigned int ret = 0; | 59 | unsigned int ret = 0; |
| 60 | struct in6_addr *ap, _addr; | 60 | struct in6_addr *ap, _addr; |
| 61 | int err; | ||
| 61 | 62 | ||
| 62 | if (ipv6_find_hdr(skb, &ptr, NEXTHDR_ROUTING, NULL) < 0) | 63 | err = ipv6_find_hdr(skb, &ptr, NEXTHDR_ROUTING, NULL); |
| 64 | if (err < 0) { | ||
| 65 | if (err != -ENOENT) | ||
| 66 | *hotdrop = 1; | ||
| 63 | return 0; | 67 | return 0; |
| 68 | } | ||
| 64 | 69 | ||
| 65 | rh = skb_header_pointer(skb, ptr, sizeof(_route), &_route); | 70 | rh = skb_header_pointer(skb, ptr, sizeof(_route), &_route); |
| 66 | if (rh == NULL) { | 71 | if (rh == NULL) { |
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c index d09329ca3267..d6dedc4aec77 100644 --- a/net/ipv6/raw.c +++ b/net/ipv6/raw.c | |||
| @@ -604,7 +604,7 @@ error: | |||
| 604 | return err; | 604 | return err; |
| 605 | } | 605 | } |
| 606 | 606 | ||
| 607 | static void rawv6_probe_proto_opt(struct flowi *fl, struct msghdr *msg) | 607 | static int rawv6_probe_proto_opt(struct flowi *fl, struct msghdr *msg) |
| 608 | { | 608 | { |
| 609 | struct iovec *iov; | 609 | struct iovec *iov; |
| 610 | u8 __user *type = NULL; | 610 | u8 __user *type = NULL; |
| @@ -616,7 +616,7 @@ static void rawv6_probe_proto_opt(struct flowi *fl, struct msghdr *msg) | |||
| 616 | int i; | 616 | int i; |
| 617 | 617 | ||
| 618 | if (!msg->msg_iov) | 618 | if (!msg->msg_iov) |
| 619 | return; | 619 | return 0; |
| 620 | 620 | ||
| 621 | for (i = 0; i < msg->msg_iovlen; i++) { | 621 | for (i = 0; i < msg->msg_iovlen; i++) { |
| 622 | iov = &msg->msg_iov[i]; | 622 | iov = &msg->msg_iov[i]; |
| @@ -638,8 +638,9 @@ static void rawv6_probe_proto_opt(struct flowi *fl, struct msghdr *msg) | |||
| 638 | code = iov->iov_base; | 638 | code = iov->iov_base; |
| 639 | 639 | ||
| 640 | if (type && code) { | 640 | if (type && code) { |
| 641 | get_user(fl->fl_icmp_type, type); | 641 | if (get_user(fl->fl_icmp_type, type) || |
| 642 | get_user(fl->fl_icmp_code, code); | 642 | get_user(fl->fl_icmp_code, code)) |
| 643 | return -EFAULT; | ||
| 643 | probed = 1; | 644 | probed = 1; |
| 644 | } | 645 | } |
| 645 | break; | 646 | break; |
| @@ -650,7 +651,8 @@ static void rawv6_probe_proto_opt(struct flowi *fl, struct msghdr *msg) | |||
| 650 | /* check if type field is readable or not. */ | 651 | /* check if type field is readable or not. */ |
| 651 | if (iov->iov_len > 2 - len) { | 652 | if (iov->iov_len > 2 - len) { |
| 652 | u8 __user *p = iov->iov_base; | 653 | u8 __user *p = iov->iov_base; |
| 653 | get_user(fl->fl_mh_type, &p[2 - len]); | 654 | if (get_user(fl->fl_mh_type, &p[2 - len])) |
| 655 | return -EFAULT; | ||
| 654 | probed = 1; | 656 | probed = 1; |
| 655 | } else | 657 | } else |
| 656 | len += iov->iov_len; | 658 | len += iov->iov_len; |
| @@ -664,6 +666,7 @@ static void rawv6_probe_proto_opt(struct flowi *fl, struct msghdr *msg) | |||
| 664 | if (probed) | 666 | if (probed) |
| 665 | break; | 667 | break; |
| 666 | } | 668 | } |
| 669 | return 0; | ||
| 667 | } | 670 | } |
| 668 | 671 | ||
| 669 | static int rawv6_sendmsg(struct kiocb *iocb, struct sock *sk, | 672 | static int rawv6_sendmsg(struct kiocb *iocb, struct sock *sk, |
| @@ -787,7 +790,9 @@ static int rawv6_sendmsg(struct kiocb *iocb, struct sock *sk, | |||
| 787 | opt = ipv6_fixup_options(&opt_space, opt); | 790 | opt = ipv6_fixup_options(&opt_space, opt); |
| 788 | 791 | ||
| 789 | fl.proto = proto; | 792 | fl.proto = proto; |
| 790 | rawv6_probe_proto_opt(&fl, msg); | 793 | err = rawv6_probe_proto_opt(&fl, msg); |
| 794 | if (err) | ||
| 795 | goto out; | ||
| 791 | 796 | ||
| 792 | ipv6_addr_copy(&fl.fl6_dst, daddr); | 797 | ipv6_addr_copy(&fl.fl6_dst, daddr); |
| 793 | if (ipv6_addr_any(&fl.fl6_src) && !ipv6_addr_any(&np->saddr)) | 798 | if (ipv6_addr_any(&fl.fl6_src) && !ipv6_addr_any(&np->saddr)) |
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index b481a4d780c2..be699f85b2c7 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c | |||
| @@ -854,3 +854,4 @@ int __init sit_init(void) | |||
| 854 | module_init(sit_init); | 854 | module_init(sit_init); |
| 855 | module_exit(sit_cleanup); | 855 | module_exit(sit_cleanup); |
| 856 | MODULE_LICENSE("GPL"); | 856 | MODULE_LICENSE("GPL"); |
| 857 | MODULE_ALIAS("sit0"); | ||
diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c index 7af227bb1551..7931e4f898d4 100644 --- a/net/ipv6/xfrm6_tunnel.c +++ b/net/ipv6/xfrm6_tunnel.c | |||
| @@ -135,7 +135,7 @@ u32 xfrm6_tunnel_spi_lookup(xfrm_address_t *saddr) | |||
| 135 | x6spi = __xfrm6_tunnel_spi_lookup(saddr); | 135 | x6spi = __xfrm6_tunnel_spi_lookup(saddr); |
| 136 | spi = x6spi ? x6spi->spi : 0; | 136 | spi = x6spi ? x6spi->spi : 0; |
| 137 | read_unlock_bh(&xfrm6_tunnel_spi_lock); | 137 | read_unlock_bh(&xfrm6_tunnel_spi_lock); |
| 138 | return spi; | 138 | return htonl(spi); |
| 139 | } | 139 | } |
| 140 | 140 | ||
| 141 | EXPORT_SYMBOL(xfrm6_tunnel_spi_lookup); | 141 | EXPORT_SYMBOL(xfrm6_tunnel_spi_lookup); |
| @@ -210,7 +210,7 @@ u32 xfrm6_tunnel_alloc_spi(xfrm_address_t *saddr) | |||
| 210 | spi = __xfrm6_tunnel_alloc_spi(saddr); | 210 | spi = __xfrm6_tunnel_alloc_spi(saddr); |
| 211 | write_unlock_bh(&xfrm6_tunnel_spi_lock); | 211 | write_unlock_bh(&xfrm6_tunnel_spi_lock); |
| 212 | 212 | ||
| 213 | return spi; | 213 | return htonl(spi); |
| 214 | } | 214 | } |
| 215 | 215 | ||
| 216 | EXPORT_SYMBOL(xfrm6_tunnel_alloc_spi); | 216 | EXPORT_SYMBOL(xfrm6_tunnel_alloc_spi); |
diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c index bef3f61569f7..76c661566dfd 100644 --- a/net/ipx/af_ipx.c +++ b/net/ipx/af_ipx.c | |||
| @@ -83,13 +83,13 @@ DEFINE_SPINLOCK(ipx_interfaces_lock); | |||
| 83 | struct ipx_interface *ipx_primary_net; | 83 | struct ipx_interface *ipx_primary_net; |
| 84 | struct ipx_interface *ipx_internal_net; | 84 | struct ipx_interface *ipx_internal_net; |
| 85 | 85 | ||
| 86 | extern int ipxrtr_add_route(__u32 network, struct ipx_interface *intrfc, | 86 | extern int ipxrtr_add_route(__be32 network, struct ipx_interface *intrfc, |
| 87 | unsigned char *node); | 87 | unsigned char *node); |
| 88 | extern void ipxrtr_del_routes(struct ipx_interface *intrfc); | 88 | extern void ipxrtr_del_routes(struct ipx_interface *intrfc); |
| 89 | extern int ipxrtr_route_packet(struct sock *sk, struct sockaddr_ipx *usipx, | 89 | extern int ipxrtr_route_packet(struct sock *sk, struct sockaddr_ipx *usipx, |
| 90 | struct iovec *iov, int len, int noblock); | 90 | struct iovec *iov, int len, int noblock); |
| 91 | extern int ipxrtr_route_skb(struct sk_buff *skb); | 91 | extern int ipxrtr_route_skb(struct sk_buff *skb); |
| 92 | extern struct ipx_route *ipxrtr_lookup(__u32 net); | 92 | extern struct ipx_route *ipxrtr_lookup(__be32 net); |
| 93 | extern int ipxrtr_ioctl(unsigned int cmd, void __user *arg); | 93 | extern int ipxrtr_ioctl(unsigned int cmd, void __user *arg); |
| 94 | 94 | ||
| 95 | #undef IPX_REFCNT_DEBUG | 95 | #undef IPX_REFCNT_DEBUG |
| @@ -177,7 +177,7 @@ static void ipxitf_clear_primary_net(void) | |||
| 177 | } | 177 | } |
| 178 | 178 | ||
| 179 | static struct ipx_interface *__ipxitf_find_using_phys(struct net_device *dev, | 179 | static struct ipx_interface *__ipxitf_find_using_phys(struct net_device *dev, |
| 180 | unsigned short datalink) | 180 | __be16 datalink) |
| 181 | { | 181 | { |
| 182 | struct ipx_interface *i; | 182 | struct ipx_interface *i; |
| 183 | 183 | ||
| @@ -190,7 +190,7 @@ out: | |||
| 190 | } | 190 | } |
| 191 | 191 | ||
| 192 | static struct ipx_interface *ipxitf_find_using_phys(struct net_device *dev, | 192 | static struct ipx_interface *ipxitf_find_using_phys(struct net_device *dev, |
| 193 | unsigned short datalink) | 193 | __be16 datalink) |
| 194 | { | 194 | { |
| 195 | struct ipx_interface *i; | 195 | struct ipx_interface *i; |
| 196 | 196 | ||
| @@ -202,7 +202,7 @@ static struct ipx_interface *ipxitf_find_using_phys(struct net_device *dev, | |||
| 202 | return i; | 202 | return i; |
| 203 | } | 203 | } |
| 204 | 204 | ||
| 205 | struct ipx_interface *ipxitf_find_using_net(__u32 net) | 205 | struct ipx_interface *ipxitf_find_using_net(__be32 net) |
| 206 | { | 206 | { |
| 207 | struct ipx_interface *i; | 207 | struct ipx_interface *i; |
| 208 | 208 | ||
| @@ -237,7 +237,7 @@ static void ipxitf_insert_socket(struct ipx_interface *intrfc, struct sock *sk) | |||
| 237 | 237 | ||
| 238 | /* caller must hold intrfc->if_sklist_lock */ | 238 | /* caller must hold intrfc->if_sklist_lock */ |
| 239 | static struct sock *__ipxitf_find_socket(struct ipx_interface *intrfc, | 239 | static struct sock *__ipxitf_find_socket(struct ipx_interface *intrfc, |
| 240 | unsigned short port) | 240 | __be16 port) |
| 241 | { | 241 | { |
| 242 | struct sock *s; | 242 | struct sock *s; |
| 243 | struct hlist_node *node; | 243 | struct hlist_node *node; |
| @@ -252,7 +252,7 @@ found: | |||
| 252 | 252 | ||
| 253 | /* caller must hold a reference to intrfc */ | 253 | /* caller must hold a reference to intrfc */ |
| 254 | static struct sock *ipxitf_find_socket(struct ipx_interface *intrfc, | 254 | static struct sock *ipxitf_find_socket(struct ipx_interface *intrfc, |
| 255 | unsigned short port) | 255 | __be16 port) |
| 256 | { | 256 | { |
| 257 | struct sock *s; | 257 | struct sock *s; |
| 258 | 258 | ||
| @@ -268,7 +268,7 @@ static struct sock *ipxitf_find_socket(struct ipx_interface *intrfc, | |||
| 268 | #ifdef CONFIG_IPX_INTERN | 268 | #ifdef CONFIG_IPX_INTERN |
| 269 | static struct sock *ipxitf_find_internal_socket(struct ipx_interface *intrfc, | 269 | static struct sock *ipxitf_find_internal_socket(struct ipx_interface *intrfc, |
| 270 | unsigned char *ipx_node, | 270 | unsigned char *ipx_node, |
| 271 | unsigned short port) | 271 | __be16 port) |
| 272 | { | 272 | { |
| 273 | struct sock *s; | 273 | struct sock *s; |
| 274 | struct hlist_node *node; | 274 | struct hlist_node *node; |
| @@ -600,10 +600,10 @@ int ipxitf_send(struct ipx_interface *intrfc, struct sk_buff *skb, char *node) | |||
| 600 | 600 | ||
| 601 | /* see if we need to include the netnum in the route list */ | 601 | /* see if we need to include the netnum in the route list */ |
| 602 | if (IPX_SKB_CB(skb)->last_hop.index >= 0) { | 602 | if (IPX_SKB_CB(skb)->last_hop.index >= 0) { |
| 603 | u32 *last_hop = (u32 *)(((u8 *) skb->data) + | 603 | __be32 *last_hop = (__be32 *)(((u8 *) skb->data) + |
| 604 | sizeof(struct ipxhdr) + | 604 | sizeof(struct ipxhdr) + |
| 605 | IPX_SKB_CB(skb)->last_hop.index * | 605 | IPX_SKB_CB(skb)->last_hop.index * |
| 606 | sizeof(u32)); | 606 | sizeof(__be32)); |
| 607 | *last_hop = IPX_SKB_CB(skb)->last_hop.netnum; | 607 | *last_hop = IPX_SKB_CB(skb)->last_hop.netnum; |
| 608 | IPX_SKB_CB(skb)->last_hop.index = -1; | 608 | IPX_SKB_CB(skb)->last_hop.index = -1; |
| 609 | } | 609 | } |
| @@ -772,7 +772,7 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc, | |||
| 772 | } else { | 772 | } else { |
| 773 | printk(KERN_WARNING "IPX: Network number collision " | 773 | printk(KERN_WARNING "IPX: Network number collision " |
| 774 | "%lx\n %s %s and %s %s\n", | 774 | "%lx\n %s %s and %s %s\n", |
| 775 | (unsigned long) htonl(cb->ipx_source_net), | 775 | (unsigned long) ntohl(cb->ipx_source_net), |
| 776 | ipx_device_name(i), | 776 | ipx_device_name(i), |
| 777 | ipx_frame_name(i->if_dlink_type), | 777 | ipx_frame_name(i->if_dlink_type), |
| 778 | ipx_device_name(intrfc), | 778 | ipx_device_name(intrfc), |
| @@ -812,7 +812,7 @@ static int ipxitf_pprop(struct ipx_interface *intrfc, struct sk_buff *skb) | |||
| 812 | int i, rc = -EINVAL; | 812 | int i, rc = -EINVAL; |
| 813 | struct ipx_interface *ifcs; | 813 | struct ipx_interface *ifcs; |
| 814 | char *c; | 814 | char *c; |
| 815 | u32 *l; | 815 | __be32 *l; |
| 816 | 816 | ||
| 817 | /* Illegal packet - too many hops or too short */ | 817 | /* Illegal packet - too many hops or too short */ |
| 818 | /* We decide to throw it away: no broadcasting, no local processing. | 818 | /* We decide to throw it away: no broadcasting, no local processing. |
| @@ -833,7 +833,7 @@ static int ipxitf_pprop(struct ipx_interface *intrfc, struct sk_buff *skb) | |||
| 833 | goto out; | 833 | goto out; |
| 834 | 834 | ||
| 835 | c = ((u8 *) ipx) + sizeof(struct ipxhdr); | 835 | c = ((u8 *) ipx) + sizeof(struct ipxhdr); |
| 836 | l = (u32 *) c; | 836 | l = (__be32 *) c; |
| 837 | 837 | ||
| 838 | /* Don't broadcast packet if already seen this net */ | 838 | /* Don't broadcast packet if already seen this net */ |
| 839 | for (i = 0; i < IPX_SKB_CB(skb)->ipx_tctrl; i++) | 839 | for (i = 0; i < IPX_SKB_CB(skb)->ipx_tctrl; i++) |
| @@ -855,7 +855,7 @@ static int ipxitf_pprop(struct ipx_interface *intrfc, struct sk_buff *skb) | |||
| 855 | /* That aren't in the list */ | 855 | /* That aren't in the list */ |
| 856 | if (ifcs == intrfc) | 856 | if (ifcs == intrfc) |
| 857 | continue; | 857 | continue; |
| 858 | l = (__u32 *) c; | 858 | l = (__be32 *) c; |
| 859 | /* don't consider the last entry in the packet list, | 859 | /* don't consider the last entry in the packet list, |
| 860 | * it is our netnum, and it is not there yet */ | 860 | * it is our netnum, and it is not there yet */ |
| 861 | for (i = 0; i < IPX_SKB_CB(skb)->ipx_tctrl; i++) | 861 | for (i = 0; i < IPX_SKB_CB(skb)->ipx_tctrl; i++) |
| @@ -885,8 +885,8 @@ static void ipxitf_insert(struct ipx_interface *intrfc) | |||
| 885 | ipx_primary_net = intrfc; | 885 | ipx_primary_net = intrfc; |
| 886 | } | 886 | } |
| 887 | 887 | ||
| 888 | static struct ipx_interface *ipxitf_alloc(struct net_device *dev, __u32 netnum, | 888 | static struct ipx_interface *ipxitf_alloc(struct net_device *dev, __be32 netnum, |
| 889 | unsigned short dlink_type, | 889 | __be16 dlink_type, |
| 890 | struct datalink_proto *dlink, | 890 | struct datalink_proto *dlink, |
| 891 | unsigned char internal, | 891 | unsigned char internal, |
| 892 | int ipx_offset) | 892 | int ipx_offset) |
| @@ -960,7 +960,7 @@ static __be16 ipx_map_frame_type(unsigned char type) | |||
| 960 | static int ipxitf_create(struct ipx_interface_definition *idef) | 960 | static int ipxitf_create(struct ipx_interface_definition *idef) |
| 961 | { | 961 | { |
| 962 | struct net_device *dev; | 962 | struct net_device *dev; |
| 963 | unsigned short dlink_type = 0; | 963 | __be16 dlink_type = 0; |
| 964 | struct datalink_proto *datalink = NULL; | 964 | struct datalink_proto *datalink = NULL; |
| 965 | struct ipx_interface *intrfc; | 965 | struct ipx_interface *intrfc; |
| 966 | int rc; | 966 | int rc; |
| @@ -1073,7 +1073,7 @@ out: | |||
| 1073 | static int ipxitf_delete(struct ipx_interface_definition *idef) | 1073 | static int ipxitf_delete(struct ipx_interface_definition *idef) |
| 1074 | { | 1074 | { |
| 1075 | struct net_device *dev = NULL; | 1075 | struct net_device *dev = NULL; |
| 1076 | unsigned short dlink_type = 0; | 1076 | __be16 dlink_type = 0; |
| 1077 | struct ipx_interface *intrfc; | 1077 | struct ipx_interface *intrfc; |
| 1078 | int rc = 0; | 1078 | int rc = 0; |
| 1079 | 1079 | ||
| @@ -1110,7 +1110,7 @@ out: | |||
| 1110 | } | 1110 | } |
| 1111 | 1111 | ||
| 1112 | static struct ipx_interface *ipxitf_auto_create(struct net_device *dev, | 1112 | static struct ipx_interface *ipxitf_auto_create(struct net_device *dev, |
| 1113 | unsigned short dlink_type) | 1113 | __be16 dlink_type) |
| 1114 | { | 1114 | { |
| 1115 | struct ipx_interface *intrfc = NULL; | 1115 | struct ipx_interface *intrfc = NULL; |
| 1116 | struct datalink_proto *datalink; | 1116 | struct datalink_proto *datalink; |
| @@ -1122,7 +1122,7 @@ static struct ipx_interface *ipxitf_auto_create(struct net_device *dev, | |||
| 1122 | if (dev->addr_len > IPX_NODE_LEN) | 1122 | if (dev->addr_len > IPX_NODE_LEN) |
| 1123 | goto out; | 1123 | goto out; |
| 1124 | 1124 | ||
| 1125 | switch (htons(dlink_type)) { | 1125 | switch (ntohs(dlink_type)) { |
| 1126 | case ETH_P_IPX: datalink = pEII_datalink; break; | 1126 | case ETH_P_IPX: datalink = pEII_datalink; break; |
| 1127 | case ETH_P_802_2: datalink = p8022_datalink; break; | 1127 | case ETH_P_802_2: datalink = p8022_datalink; break; |
| 1128 | case ETH_P_SNAP: datalink = pSNAP_datalink; break; | 1128 | case ETH_P_SNAP: datalink = pSNAP_datalink; break; |
| @@ -1234,27 +1234,27 @@ static int ipxitf_ioctl(unsigned int cmd, void __user *arg) | |||
| 1234 | /* Note: We assume ipx_tctrl==0 and htons(length)==ipx_pktsize */ | 1234 | /* Note: We assume ipx_tctrl==0 and htons(length)==ipx_pktsize */ |
| 1235 | /* This functions should *not* mess with packet contents */ | 1235 | /* This functions should *not* mess with packet contents */ |
| 1236 | 1236 | ||
| 1237 | __u16 ipx_cksum(struct ipxhdr *packet, int length) | 1237 | __be16 ipx_cksum(struct ipxhdr *packet, int length) |
| 1238 | { | 1238 | { |
| 1239 | /* | 1239 | /* |
| 1240 | * NOTE: sum is a net byte order quantity, which optimizes the | 1240 | * NOTE: sum is a net byte order quantity, which optimizes the |
| 1241 | * loop. This only works on big and little endian machines. (I | 1241 | * loop. This only works on big and little endian machines. (I |
| 1242 | * don't know of a machine that isn't.) | 1242 | * don't know of a machine that isn't.) |
| 1243 | */ | 1243 | */ |
| 1244 | /* start at ipx_dest - We skip the checksum field and start with | 1244 | /* handle the first 3 words separately; checksum should be skipped |
| 1245 | * ipx_type before the loop, not considering ipx_tctrl in the calc */ | 1245 | * and ipx_tctrl masked out */ |
| 1246 | __u16 *p = (__u16 *)&packet->ipx_dest; | 1246 | __u16 *p = (__u16 *)packet; |
| 1247 | __u32 i = (length >> 1) - 1; /* Number of complete words */ | 1247 | __u32 sum = p[1] + (p[2] & (__force u16)htons(0x00ff)); |
| 1248 | __u32 sum = packet->ipx_type << sizeof(packet->ipx_tctrl); | 1248 | __u32 i = (length >> 1) - 3; /* Number of remaining complete words */ |
| 1249 | 1249 | ||
| 1250 | /* Loop through all complete words except the checksum field, | 1250 | /* Loop through them */ |
| 1251 | * ipx_type (accounted above) and ipx_tctrl (not used in the cksum) */ | 1251 | p += 3; |
| 1252 | while (--i) | 1252 | while (i--) |
| 1253 | sum += *p++; | 1253 | sum += *p++; |
| 1254 | 1254 | ||
| 1255 | /* Add on the last part word if it exists */ | 1255 | /* Add on the last part word if it exists */ |
| 1256 | if (packet->ipx_pktsize & htons(1)) | 1256 | if (packet->ipx_pktsize & htons(1)) |
| 1257 | sum += ntohs(0xff00) & *p; | 1257 | sum += (__force u16)htons(0xff00) & *p; |
| 1258 | 1258 | ||
| 1259 | /* Do final fixup */ | 1259 | /* Do final fixup */ |
| 1260 | sum = (sum & 0xffff) + (sum >> 16); | 1260 | sum = (sum & 0xffff) + (sum >> 16); |
| @@ -1263,10 +1263,17 @@ __u16 ipx_cksum(struct ipxhdr *packet, int length) | |||
| 1263 | if (sum >= 0x10000) | 1263 | if (sum >= 0x10000) |
| 1264 | sum++; | 1264 | sum++; |
| 1265 | 1265 | ||
| 1266 | return ~sum; | 1266 | /* |
| 1267 | * Leave 0 alone; we don't want 0xffff here. Note that we can't get | ||
| 1268 | * here with 0x10000, so this check is the same as ((__u16)sum) | ||
| 1269 | */ | ||
| 1270 | if (sum) | ||
| 1271 | sum = ~sum; | ||
| 1272 | |||
| 1273 | return (__force __be16)sum; | ||
| 1267 | } | 1274 | } |
| 1268 | 1275 | ||
| 1269 | const char *ipx_frame_name(unsigned short frame) | 1276 | const char *ipx_frame_name(__be16 frame) |
| 1270 | { | 1277 | { |
| 1271 | char* rc = "None"; | 1278 | char* rc = "None"; |
| 1272 | 1279 | ||
| @@ -1401,7 +1408,7 @@ out: | |||
| 1401 | 1408 | ||
| 1402 | /* caller must hold a reference to intrfc */ | 1409 | /* caller must hold a reference to intrfc */ |
| 1403 | 1410 | ||
| 1404 | static unsigned short ipx_first_free_socketnum(struct ipx_interface *intrfc) | 1411 | static __be16 ipx_first_free_socketnum(struct ipx_interface *intrfc) |
| 1405 | { | 1412 | { |
| 1406 | unsigned short socketNum = intrfc->if_sknum; | 1413 | unsigned short socketNum = intrfc->if_sknum; |
| 1407 | 1414 | ||
| @@ -1410,7 +1417,7 @@ static unsigned short ipx_first_free_socketnum(struct ipx_interface *intrfc) | |||
| 1410 | if (socketNum < IPX_MIN_EPHEMERAL_SOCKET) | 1417 | if (socketNum < IPX_MIN_EPHEMERAL_SOCKET) |
| 1411 | socketNum = IPX_MIN_EPHEMERAL_SOCKET; | 1418 | socketNum = IPX_MIN_EPHEMERAL_SOCKET; |
| 1412 | 1419 | ||
| 1413 | while (__ipxitf_find_socket(intrfc, ntohs(socketNum))) | 1420 | while (__ipxitf_find_socket(intrfc, htons(socketNum))) |
| 1414 | if (socketNum > IPX_MAX_EPHEMERAL_SOCKET) | 1421 | if (socketNum > IPX_MAX_EPHEMERAL_SOCKET) |
| 1415 | socketNum = IPX_MIN_EPHEMERAL_SOCKET; | 1422 | socketNum = IPX_MIN_EPHEMERAL_SOCKET; |
| 1416 | else | 1423 | else |
| @@ -1419,7 +1426,7 @@ static unsigned short ipx_first_free_socketnum(struct ipx_interface *intrfc) | |||
| 1419 | spin_unlock_bh(&intrfc->if_sklist_lock); | 1426 | spin_unlock_bh(&intrfc->if_sklist_lock); |
| 1420 | intrfc->if_sknum = socketNum; | 1427 | intrfc->if_sknum = socketNum; |
| 1421 | 1428 | ||
| 1422 | return ntohs(socketNum); | 1429 | return htons(socketNum); |
| 1423 | } | 1430 | } |
| 1424 | 1431 | ||
| 1425 | static int ipx_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) | 1432 | static int ipx_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) |
| @@ -1473,7 +1480,7 @@ static int ipx_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) | |||
| 1473 | ipxs->port)) { | 1480 | ipxs->port)) { |
| 1474 | SOCK_DEBUG(sk, | 1481 | SOCK_DEBUG(sk, |
| 1475 | "IPX: bind failed because port %X in use.\n", | 1482 | "IPX: bind failed because port %X in use.\n", |
| 1476 | ntohs((int)addr->sipx_port)); | 1483 | ntohs(addr->sipx_port)); |
| 1477 | goto out_put; | 1484 | goto out_put; |
| 1478 | } | 1485 | } |
| 1479 | } else { | 1486 | } else { |
| @@ -1488,7 +1495,7 @@ static int ipx_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) | |||
| 1488 | if (ipxitf_find_socket(intrfc, addr->sipx_port)) { | 1495 | if (ipxitf_find_socket(intrfc, addr->sipx_port)) { |
| 1489 | SOCK_DEBUG(sk, | 1496 | SOCK_DEBUG(sk, |
| 1490 | "IPX: bind failed because port %X in use.\n", | 1497 | "IPX: bind failed because port %X in use.\n", |
| 1491 | ntohs((int)addr->sipx_port)); | 1498 | ntohs(addr->sipx_port)); |
| 1492 | goto out_put; | 1499 | goto out_put; |
| 1493 | } | 1500 | } |
| 1494 | } | 1501 | } |
| @@ -1665,7 +1672,7 @@ static int ipx_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_ty | |||
| 1665 | intrfc = ipxitf_find_using_phys(dev, pt->type); | 1672 | intrfc = ipxitf_find_using_phys(dev, pt->type); |
| 1666 | if (!intrfc) { | 1673 | if (!intrfc) { |
| 1667 | if (ipxcfg_auto_create_interfaces && | 1674 | if (ipxcfg_auto_create_interfaces && |
| 1668 | ntohl(IPX_SKB_CB(skb)->ipx_dest_net)) { | 1675 | IPX_SKB_CB(skb)->ipx_dest_net) { |
| 1669 | intrfc = ipxitf_auto_create(dev, pt->type); | 1676 | intrfc = ipxitf_auto_create(dev, pt->type); |
| 1670 | if (intrfc) | 1677 | if (intrfc) |
| 1671 | ipxitf_hold(intrfc); | 1678 | ipxitf_hold(intrfc); |
diff --git a/net/ipx/ipx_proc.c b/net/ipx/ipx_proc.c index 4c0c71206e54..b7463dfca63e 100644 --- a/net/ipx/ipx_proc.c +++ b/net/ipx/ipx_proc.c | |||
| @@ -260,22 +260,22 @@ static int ipx_seq_socket_show(struct seq_file *seq, void *v) | |||
| 260 | ipxs = ipx_sk(s); | 260 | ipxs = ipx_sk(s); |
| 261 | #ifdef CONFIG_IPX_INTERN | 261 | #ifdef CONFIG_IPX_INTERN |
| 262 | seq_printf(seq, "%08lX:%02X%02X%02X%02X%02X%02X:%04X ", | 262 | seq_printf(seq, "%08lX:%02X%02X%02X%02X%02X%02X:%04X ", |
| 263 | (unsigned long)htonl(ipxs->intrfc->if_netnum), | 263 | (unsigned long)ntohl(ipxs->intrfc->if_netnum), |
| 264 | ipxs->node[0], ipxs->node[1], ipxs->node[2], ipxs->node[3], | 264 | ipxs->node[0], ipxs->node[1], ipxs->node[2], ipxs->node[3], |
| 265 | ipxs->node[4], ipxs->node[5], htons(ipxs->port)); | 265 | ipxs->node[4], ipxs->node[5], ntohs(ipxs->port)); |
| 266 | #else | 266 | #else |
| 267 | seq_printf(seq, "%08lX:%04X ", (unsigned long) htonl(ipxs->intrfc->if_netnum), | 267 | seq_printf(seq, "%08lX:%04X ", (unsigned long) ntohl(ipxs->intrfc->if_netnum), |
| 268 | htons(ipxs->port)); | 268 | ntohs(ipxs->port)); |
| 269 | #endif /* CONFIG_IPX_INTERN */ | 269 | #endif /* CONFIG_IPX_INTERN */ |
| 270 | if (s->sk_state != TCP_ESTABLISHED) | 270 | if (s->sk_state != TCP_ESTABLISHED) |
| 271 | seq_printf(seq, "%-28s", "Not_Connected"); | 271 | seq_printf(seq, "%-28s", "Not_Connected"); |
| 272 | else { | 272 | else { |
| 273 | seq_printf(seq, "%08lX:%02X%02X%02X%02X%02X%02X:%04X ", | 273 | seq_printf(seq, "%08lX:%02X%02X%02X%02X%02X%02X:%04X ", |
| 274 | (unsigned long)htonl(ipxs->dest_addr.net), | 274 | (unsigned long)ntohl(ipxs->dest_addr.net), |
| 275 | ipxs->dest_addr.node[0], ipxs->dest_addr.node[1], | 275 | ipxs->dest_addr.node[0], ipxs->dest_addr.node[1], |
| 276 | ipxs->dest_addr.node[2], ipxs->dest_addr.node[3], | 276 | ipxs->dest_addr.node[2], ipxs->dest_addr.node[3], |
| 277 | ipxs->dest_addr.node[4], ipxs->dest_addr.node[5], | 277 | ipxs->dest_addr.node[4], ipxs->dest_addr.node[5], |
| 278 | htons(ipxs->dest_addr.sock)); | 278 | ntohs(ipxs->dest_addr.sock)); |
| 279 | } | 279 | } |
| 280 | 280 | ||
| 281 | seq_printf(seq, "%08X %08X %02X %03d\n", | 281 | seq_printf(seq, "%08X %08X %02X %03d\n", |
diff --git a/net/ipx/ipx_route.c b/net/ipx/ipx_route.c index a30dbb1e08fb..68560ee0d797 100644 --- a/net/ipx/ipx_route.c +++ b/net/ipx/ipx_route.c | |||
| @@ -19,17 +19,17 @@ DEFINE_RWLOCK(ipx_routes_lock); | |||
| 19 | 19 | ||
| 20 | extern struct ipx_interface *ipx_internal_net; | 20 | extern struct ipx_interface *ipx_internal_net; |
| 21 | 21 | ||
| 22 | extern __u16 ipx_cksum(struct ipxhdr *packet, int length); | 22 | extern __be16 ipx_cksum(struct ipxhdr *packet, int length); |
| 23 | extern struct ipx_interface *ipxitf_find_using_net(__u32 net); | 23 | extern struct ipx_interface *ipxitf_find_using_net(__be32 net); |
| 24 | extern int ipxitf_demux_socket(struct ipx_interface *intrfc, | 24 | extern int ipxitf_demux_socket(struct ipx_interface *intrfc, |
| 25 | struct sk_buff *skb, int copy); | 25 | struct sk_buff *skb, int copy); |
| 26 | extern int ipxitf_demux_socket(struct ipx_interface *intrfc, | 26 | extern int ipxitf_demux_socket(struct ipx_interface *intrfc, |
| 27 | struct sk_buff *skb, int copy); | 27 | struct sk_buff *skb, int copy); |
| 28 | extern int ipxitf_send(struct ipx_interface *intrfc, struct sk_buff *skb, | 28 | extern int ipxitf_send(struct ipx_interface *intrfc, struct sk_buff *skb, |
| 29 | char *node); | 29 | char *node); |
| 30 | extern struct ipx_interface *ipxitf_find_using_net(__u32 net); | 30 | extern struct ipx_interface *ipxitf_find_using_net(__be32 net); |
| 31 | 31 | ||
| 32 | struct ipx_route *ipxrtr_lookup(__u32 net) | 32 | struct ipx_route *ipxrtr_lookup(__be32 net) |
| 33 | { | 33 | { |
| 34 | struct ipx_route *r; | 34 | struct ipx_route *r; |
| 35 | 35 | ||
| @@ -48,7 +48,7 @@ unlock: | |||
| 48 | /* | 48 | /* |
| 49 | * Caller must hold a reference to intrfc | 49 | * Caller must hold a reference to intrfc |
| 50 | */ | 50 | */ |
| 51 | int ipxrtr_add_route(__u32 network, struct ipx_interface *intrfc, | 51 | int ipxrtr_add_route(__be32 network, struct ipx_interface *intrfc, |
| 52 | unsigned char *node) | 52 | unsigned char *node) |
| 53 | { | 53 | { |
| 54 | struct ipx_route *rt; | 54 | struct ipx_route *rt; |
| @@ -118,7 +118,7 @@ out: | |||
| 118 | return rc; | 118 | return rc; |
| 119 | } | 119 | } |
| 120 | 120 | ||
| 121 | static int ipxrtr_delete(__u32 net) | 121 | static int ipxrtr_delete(__be32 net) |
| 122 | { | 122 | { |
| 123 | struct ipx_route *r, *tmp; | 123 | struct ipx_route *r, *tmp; |
| 124 | int rc; | 124 | int rc; |
| @@ -238,7 +238,7 @@ int ipxrtr_route_packet(struct sock *sk, struct sockaddr_ipx *usipx, | |||
| 238 | 238 | ||
| 239 | /* Apply checksum. Not allowed on 802.3 links. */ | 239 | /* Apply checksum. Not allowed on 802.3 links. */ |
| 240 | if (sk->sk_no_check || intrfc->if_dlink_type == htons(IPX_FRAME_8023)) | 240 | if (sk->sk_no_check || intrfc->if_dlink_type == htons(IPX_FRAME_8023)) |
| 241 | ipx->ipx_checksum = 0xFFFF; | 241 | ipx->ipx_checksum = htons(0xFFFF); |
| 242 | else | 242 | else |
| 243 | ipx->ipx_checksum = ipx_cksum(ipx, len + sizeof(struct ipxhdr)); | 243 | ipx->ipx_checksum = ipx_cksum(ipx, len + sizeof(struct ipxhdr)); |
| 244 | 244 | ||
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index 093b3ddc513c..836541e509fe 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter/nf_conntrack_core.c | |||
| @@ -1520,9 +1520,10 @@ get_next_corpse(int (*iter)(struct nf_conn *i, void *data), | |||
| 1520 | if (iter(ct, data)) | 1520 | if (iter(ct, data)) |
| 1521 | goto found; | 1521 | goto found; |
| 1522 | } | 1522 | } |
| 1523 | write_unlock_bh(&nf_conntrack_lock); | ||
| 1523 | return NULL; | 1524 | return NULL; |
| 1524 | found: | 1525 | found: |
| 1525 | atomic_inc(&nf_ct_tuplehash_to_ctrack(h)->ct_general.use); | 1526 | atomic_inc(&ct->ct_general.use); |
| 1526 | write_unlock_bh(&nf_conntrack_lock); | 1527 | write_unlock_bh(&nf_conntrack_lock); |
| 1527 | return ct; | 1528 | return ct; |
| 1528 | } | 1529 | } |
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index b59d3b2bde21..1e5207b80fe5 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c | |||
| @@ -427,7 +427,7 @@ __build_packet_message(struct nfulnl_instance *inst, | |||
| 427 | nfmsg->version = NFNETLINK_V0; | 427 | nfmsg->version = NFNETLINK_V0; |
| 428 | nfmsg->res_id = htons(inst->group_num); | 428 | nfmsg->res_id = htons(inst->group_num); |
| 429 | 429 | ||
| 430 | pmsg.hw_protocol = htons(skb->protocol); | 430 | pmsg.hw_protocol = skb->protocol; |
| 431 | pmsg.hook = hooknum; | 431 | pmsg.hook = hooknum; |
| 432 | 432 | ||
| 433 | NFA_PUT(inst->skb, NFULA_PACKET_HDR, sizeof(pmsg), &pmsg); | 433 | NFA_PUT(inst->skb, NFULA_PACKET_HDR, sizeof(pmsg), &pmsg); |
| @@ -544,7 +544,7 @@ __build_packet_message(struct nfulnl_instance *inst, | |||
| 544 | } | 544 | } |
| 545 | /* global sequence number */ | 545 | /* global sequence number */ |
| 546 | if (inst->flags & NFULNL_CFG_F_SEQ_GLOBAL) { | 546 | if (inst->flags & NFULNL_CFG_F_SEQ_GLOBAL) { |
| 547 | tmp_uint = atomic_inc_return(&global_seq); | 547 | tmp_uint = htonl(atomic_inc_return(&global_seq)); |
| 548 | NFA_PUT(inst->skb, NFULA_SEQ_GLOBAL, sizeof(tmp_uint), &tmp_uint); | 548 | NFA_PUT(inst->skb, NFULA_SEQ_GLOBAL, sizeof(tmp_uint), &tmp_uint); |
| 549 | } | 549 | } |
| 550 | 550 | ||
| @@ -878,7 +878,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, | |||
| 878 | params = NFA_DATA(nfula[NFULA_CFG_MODE-1]); | 878 | params = NFA_DATA(nfula[NFULA_CFG_MODE-1]); |
| 879 | 879 | ||
| 880 | nfulnl_set_mode(inst, params->copy_mode, | 880 | nfulnl_set_mode(inst, params->copy_mode, |
| 881 | ntohs(params->copy_range)); | 881 | ntohl(params->copy_range)); |
| 882 | } | 882 | } |
| 883 | 883 | ||
| 884 | if (nfula[NFULA_CFG_TIMEOUT-1]) { | 884 | if (nfula[NFULA_CFG_TIMEOUT-1]) { |
| @@ -896,8 +896,8 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, | |||
| 896 | } | 896 | } |
| 897 | 897 | ||
| 898 | if (nfula[NFULA_CFG_QTHRESH-1]) { | 898 | if (nfula[NFULA_CFG_QTHRESH-1]) { |
| 899 | u_int32_t qthresh = | 899 | __be32 qthresh = |
| 900 | *(u_int16_t *)NFA_DATA(nfula[NFULA_CFG_QTHRESH-1]); | 900 | *(__be32 *)NFA_DATA(nfula[NFULA_CFG_QTHRESH-1]); |
| 901 | 901 | ||
| 902 | nfulnl_set_qthresh(inst, ntohl(qthresh)); | 902 | nfulnl_set_qthresh(inst, ntohl(qthresh)); |
| 903 | } | 903 | } |
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index 8eb2473d83e1..e815a9aa6e95 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net/netfilter/nfnetlink_queue.c | |||
| @@ -414,7 +414,7 @@ nfqnl_build_packet_message(struct nfqnl_instance *queue, | |||
| 414 | nfmsg->res_id = htons(queue->queue_num); | 414 | nfmsg->res_id = htons(queue->queue_num); |
| 415 | 415 | ||
| 416 | pmsg.packet_id = htonl(entry->id); | 416 | pmsg.packet_id = htonl(entry->id); |
| 417 | pmsg.hw_protocol = htons(entskb->protocol); | 417 | pmsg.hw_protocol = entskb->protocol; |
| 418 | pmsg.hook = entinf->hook; | 418 | pmsg.hook = entinf->hook; |
| 419 | 419 | ||
| 420 | NFA_PUT(skb, NFQA_PACKET_HDR, sizeof(pmsg), &pmsg); | 420 | NFA_PUT(skb, NFQA_PACKET_HDR, sizeof(pmsg), &pmsg); |
| @@ -622,9 +622,10 @@ nfqnl_mangle(void *data, int data_len, struct nfqnl_queue_entry *e) | |||
| 622 | int diff; | 622 | int diff; |
| 623 | 623 | ||
| 624 | diff = data_len - e->skb->len; | 624 | diff = data_len - e->skb->len; |
| 625 | if (diff < 0) | 625 | if (diff < 0) { |
| 626 | skb_trim(e->skb, data_len); | 626 | if (pskb_trim(e->skb, data_len)) |
| 627 | else if (diff > 0) { | 627 | return -ENOMEM; |
| 628 | } else if (diff > 0) { | ||
| 628 | if (data_len > 0xFFFF) | 629 | if (data_len > 0xFFFF) |
| 629 | return -EINVAL; | 630 | return -EINVAL; |
| 630 | if (diff > skb_tailroom(e->skb)) { | 631 | if (diff > skb_tailroom(e->skb)) { |
diff --git a/net/netlabel/Kconfig b/net/netlabel/Kconfig index 9f7121ae13e9..56958c85f2b4 100644 --- a/net/netlabel/Kconfig +++ b/net/netlabel/Kconfig | |||
| @@ -4,7 +4,7 @@ | |||
| 4 | 4 | ||
| 5 | config NETLABEL | 5 | config NETLABEL |
| 6 | bool "NetLabel subsystem support" | 6 | bool "NetLabel subsystem support" |
| 7 | depends on NET && SECURITY | 7 | depends on SECURITY |
| 8 | default n | 8 | default n |
| 9 | ---help--- | 9 | ---help--- |
| 10 | NetLabel provides support for explicit network packet labeling | 10 | NetLabel provides support for explicit network packet labeling |
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index d56e0d21f919..d527c8977b1f 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c | |||
| @@ -1075,8 +1075,9 @@ static int netlink_getsockopt(struct socket *sock, int level, int optname, | |||
| 1075 | return -EINVAL; | 1075 | return -EINVAL; |
| 1076 | len = sizeof(int); | 1076 | len = sizeof(int); |
| 1077 | val = nlk->flags & NETLINK_RECV_PKTINFO ? 1 : 0; | 1077 | val = nlk->flags & NETLINK_RECV_PKTINFO ? 1 : 0; |
| 1078 | put_user(len, optlen); | 1078 | if (put_user(len, optlen) || |
| 1079 | put_user(val, optval); | 1079 | put_user(val, optval)) |
| 1080 | return -EFAULT; | ||
| 1080 | err = 0; | 1081 | err = 0; |
| 1081 | break; | 1082 | break; |
| 1082 | default: | 1083 | default: |
diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index 9b9c555c713f..4b52fa78935a 100644 --- a/net/sched/sch_htb.c +++ b/net/sched/sch_htb.c | |||
| @@ -1284,8 +1284,7 @@ static void htb_destroy_class(struct Qdisc *sch, struct htb_class *cl) | |||
| 1284 | struct htb_class, sibling)); | 1284 | struct htb_class, sibling)); |
| 1285 | 1285 | ||
| 1286 | /* note: this delete may happen twice (see htb_delete) */ | 1286 | /* note: this delete may happen twice (see htb_delete) */ |
| 1287 | if (!hlist_unhashed(&cl->hlist)) | 1287 | hlist_del_init(&cl->hlist); |
| 1288 | hlist_del(&cl->hlist); | ||
| 1289 | list_del(&cl->sibling); | 1288 | list_del(&cl->sibling); |
| 1290 | 1289 | ||
| 1291 | if (cl->prio_activity) | 1290 | if (cl->prio_activity) |
| @@ -1333,8 +1332,7 @@ static int htb_delete(struct Qdisc *sch, unsigned long arg) | |||
| 1333 | sch_tree_lock(sch); | 1332 | sch_tree_lock(sch); |
| 1334 | 1333 | ||
| 1335 | /* delete from hash and active; remainder in destroy_class */ | 1334 | /* delete from hash and active; remainder in destroy_class */ |
| 1336 | if (!hlist_unhashed(&cl->hlist)) | 1335 | hlist_del_init(&cl->hlist); |
| 1337 | hlist_del(&cl->hlist); | ||
| 1338 | 1336 | ||
| 1339 | if (cl->prio_activity) | 1337 | if (cl->prio_activity) |
| 1340 | htb_deactivate(q, cl); | 1338 | htb_deactivate(q, cl); |
diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 45939bafbdf8..0441876aa1e7 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c | |||
| @@ -4,7 +4,7 @@ | |||
| 4 | * This program is free software; you can redistribute it and/or | 4 | * This program is free software; you can redistribute it and/or |
| 5 | * modify it under the terms of the GNU General Public License | 5 | * modify it under the terms of the GNU General Public License |
| 6 | * as published by the Free Software Foundation; either version | 6 | * as published by the Free Software Foundation; either version |
| 7 | * 2 of the License, or (at your option) any later version. | 7 | * 2 of the License. |
| 8 | * | 8 | * |
| 9 | * Many of the algorithms and ideas for this came from | 9 | * Many of the algorithms and ideas for this came from |
| 10 | * NIST Net which is not copyrighted. | 10 | * NIST Net which is not copyrighted. |
| @@ -170,6 +170,8 @@ static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch) | |||
| 170 | return NET_XMIT_BYPASS; | 170 | return NET_XMIT_BYPASS; |
| 171 | } | 171 | } |
| 172 | 172 | ||
| 173 | skb_orphan(skb); | ||
| 174 | |||
| 173 | /* | 175 | /* |
| 174 | * If we need to duplicate packet, then re-insert at top of the | 176 | * If we need to duplicate packet, then re-insert at top of the |
| 175 | * qdisc tree, since parent queuer expects that only one | 177 | * qdisc tree, since parent queuer expects that only one |
diff --git a/net/sctp/associola.c b/net/sctp/associola.c index 27329ce9c311..ed0445fe85e7 100644 --- a/net/sctp/associola.c +++ b/net/sctp/associola.c | |||
| @@ -346,11 +346,18 @@ void sctp_association_free(struct sctp_association *asoc) | |||
| 346 | struct list_head *pos, *temp; | 346 | struct list_head *pos, *temp; |
| 347 | int i; | 347 | int i; |
| 348 | 348 | ||
| 349 | list_del(&asoc->asocs); | 349 | /* Only real associations count against the endpoint, so |
| 350 | * don't bother for if this is a temporary association. | ||
| 351 | */ | ||
| 352 | if (!asoc->temp) { | ||
| 353 | list_del(&asoc->asocs); | ||
| 350 | 354 | ||
| 351 | /* Decrement the backlog value for a TCP-style listening socket. */ | 355 | /* Decrement the backlog value for a TCP-style listening |
| 352 | if (sctp_style(sk, TCP) && sctp_sstate(sk, LISTENING)) | 356 | * socket. |
| 353 | sk->sk_ack_backlog--; | 357 | */ |
| 358 | if (sctp_style(sk, TCP) && sctp_sstate(sk, LISTENING)) | ||
| 359 | sk->sk_ack_backlog--; | ||
| 360 | } | ||
| 354 | 361 | ||
| 355 | /* Mark as dead, so other users can know this structure is | 362 | /* Mark as dead, so other users can know this structure is |
| 356 | * going away. | 363 | * going away. |
diff --git a/net/sctp/endpointola.c b/net/sctp/endpointola.c index 35c49ff2d062..9b6b394b66f6 100644 --- a/net/sctp/endpointola.c +++ b/net/sctp/endpointola.c | |||
| @@ -144,6 +144,13 @@ void sctp_endpoint_add_asoc(struct sctp_endpoint *ep, | |||
| 144 | { | 144 | { |
| 145 | struct sock *sk = ep->base.sk; | 145 | struct sock *sk = ep->base.sk; |
| 146 | 146 | ||
| 147 | /* If this is a temporary association, don't bother | ||
| 148 | * since we'll be removing it shortly and don't | ||
| 149 | * want anyone to find it anyway. | ||
| 150 | */ | ||
| 151 | if (asoc->temp) | ||
| 152 | return; | ||
| 153 | |||
| 147 | /* Now just add it to our list of asocs */ | 154 | /* Now just add it to our list of asocs */ |
| 148 | list_add_tail(&asoc->asocs, &ep->asocs); | 155 | list_add_tail(&asoc->asocs, &ep->asocs); |
| 149 | 156 | ||
diff --git a/net/sctp/input.c b/net/sctp/input.c index 64f630102532..6d82f400d13c 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c | |||
| @@ -135,6 +135,9 @@ int sctp_rcv(struct sk_buff *skb) | |||
| 135 | 135 | ||
| 136 | SCTP_INC_STATS_BH(SCTP_MIB_INSCTPPACKS); | 136 | SCTP_INC_STATS_BH(SCTP_MIB_INSCTPPACKS); |
| 137 | 137 | ||
| 138 | if (skb_linearize(skb)) | ||
| 139 | goto discard_it; | ||
| 140 | |||
| 138 | sh = (struct sctphdr *) skb->h.raw; | 141 | sh = (struct sctphdr *) skb->h.raw; |
| 139 | 142 | ||
| 140 | /* Pull up the IP and SCTP headers. */ | 143 | /* Pull up the IP and SCTP headers. */ |
| @@ -768,6 +771,9 @@ static void __sctp_hash_established(struct sctp_association *asoc) | |||
| 768 | /* Add an association to the hash. Local BH-safe. */ | 771 | /* Add an association to the hash. Local BH-safe. */ |
| 769 | void sctp_hash_established(struct sctp_association *asoc) | 772 | void sctp_hash_established(struct sctp_association *asoc) |
| 770 | { | 773 | { |
| 774 | if (asoc->temp) | ||
| 775 | return; | ||
| 776 | |||
| 771 | sctp_local_bh_disable(); | 777 | sctp_local_bh_disable(); |
| 772 | __sctp_hash_established(asoc); | 778 | __sctp_hash_established(asoc); |
| 773 | sctp_local_bh_enable(); | 779 | sctp_local_bh_enable(); |
| @@ -801,6 +807,9 @@ static void __sctp_unhash_established(struct sctp_association *asoc) | |||
| 801 | /* Remove association from the hash table. Local BH-safe. */ | 807 | /* Remove association from the hash table. Local BH-safe. */ |
| 802 | void sctp_unhash_established(struct sctp_association *asoc) | 808 | void sctp_unhash_established(struct sctp_association *asoc) |
| 803 | { | 809 | { |
| 810 | if (asoc->temp) | ||
| 811 | return; | ||
| 812 | |||
| 804 | sctp_local_bh_disable(); | 813 | sctp_local_bh_disable(); |
| 805 | __sctp_unhash_established(asoc); | 814 | __sctp_unhash_established(asoc); |
| 806 | sctp_local_bh_enable(); | 815 | sctp_local_bh_enable(); |
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index fac7674438a4..5b4f82fd98f8 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c | |||
| @@ -591,7 +591,7 @@ static struct sock *sctp_v4_create_accept_sk(struct sock *sk, | |||
| 591 | newinet->dport = htons(asoc->peer.port); | 591 | newinet->dport = htons(asoc->peer.port); |
| 592 | newinet->daddr = asoc->peer.primary_addr.v4.sin_addr.s_addr; | 592 | newinet->daddr = asoc->peer.primary_addr.v4.sin_addr.s_addr; |
| 593 | newinet->pmtudisc = inet->pmtudisc; | 593 | newinet->pmtudisc = inet->pmtudisc; |
| 594 | newinet->id = 0; | 594 | newinet->id = asoc->next_tsn ^ jiffies; |
| 595 | 595 | ||
| 596 | newinet->uc_ttl = -1; | 596 | newinet->uc_ttl = -1; |
| 597 | newinet->mc_loop = 1; | 597 | newinet->mc_loop = 1; |
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 9f34dec6ff8e..935bc9187fd8 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c | |||
| @@ -3372,6 +3372,7 @@ SCTP_STATIC int sctp_do_peeloff(struct sctp_association *asoc, | |||
| 3372 | { | 3372 | { |
| 3373 | struct sock *sk = asoc->base.sk; | 3373 | struct sock *sk = asoc->base.sk; |
| 3374 | struct socket *sock; | 3374 | struct socket *sock; |
| 3375 | struct inet_sock *inetsk; | ||
| 3375 | int err = 0; | 3376 | int err = 0; |
| 3376 | 3377 | ||
| 3377 | /* An association cannot be branched off from an already peeled-off | 3378 | /* An association cannot be branched off from an already peeled-off |
| @@ -3389,6 +3390,14 @@ SCTP_STATIC int sctp_do_peeloff(struct sctp_association *asoc, | |||
| 3389 | * asoc to the newsk. | 3390 | * asoc to the newsk. |
| 3390 | */ | 3391 | */ |
| 3391 | sctp_sock_migrate(sk, sock->sk, asoc, SCTP_SOCKET_UDP_HIGH_BANDWIDTH); | 3392 | sctp_sock_migrate(sk, sock->sk, asoc, SCTP_SOCKET_UDP_HIGH_BANDWIDTH); |
| 3393 | |||
| 3394 | /* Make peeled-off sockets more like 1-1 accepted sockets. | ||
| 3395 | * Set the daddr and initialize id to something more random | ||
| 3396 | */ | ||
| 3397 | inetsk = inet_sk(sock->sk); | ||
| 3398 | inetsk->daddr = asoc->peer.primary_addr.v4.sin_addr.s_addr; | ||
| 3399 | inetsk->id = asoc->next_tsn ^ jiffies; | ||
| 3400 | |||
| 3392 | *sockp = sock; | 3401 | *sockp = sock; |
| 3393 | 3402 | ||
| 3394 | return err; | 3403 | return err; |
diff --git a/net/sunrpc/svcauth.c b/net/sunrpc/svcauth.c index 8f2320aded5c..ee9bb1522d5e 100644 --- a/net/sunrpc/svcauth.c +++ b/net/sunrpc/svcauth.c | |||
| @@ -126,6 +126,7 @@ void auth_domain_put(struct auth_domain *dom) | |||
| 126 | if (atomic_dec_and_lock(&dom->ref.refcount, &auth_domain_lock)) { | 126 | if (atomic_dec_and_lock(&dom->ref.refcount, &auth_domain_lock)) { |
| 127 | hlist_del(&dom->hash); | 127 | hlist_del(&dom->hash); |
| 128 | dom->flavour->domain_release(dom); | 128 | dom->flavour->domain_release(dom); |
| 129 | spin_unlock(&auth_domain_lock); | ||
| 129 | } | 130 | } |
| 130 | } | 131 | } |
| 131 | 132 | ||
| @@ -147,10 +148,8 @@ auth_domain_lookup(char *name, struct auth_domain *new) | |||
| 147 | return hp; | 148 | return hp; |
| 148 | } | 149 | } |
| 149 | } | 150 | } |
| 150 | if (new) { | 151 | if (new) |
| 151 | hlist_add_head(&new->hash, head); | 152 | hlist_add_head(&new->hash, head); |
| 152 | kref_get(&new->ref); | ||
| 153 | } | ||
| 154 | spin_unlock(&auth_domain_lock); | 153 | spin_unlock(&auth_domain_lock); |
| 155 | return new; | 154 | return new; |
| 156 | } | 155 | } |
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 96521f16342b..64ca1f61dd94 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c | |||
| @@ -299,9 +299,15 @@ void svc_reserve(struct svc_rqst *rqstp, int space) | |||
| 299 | static inline void | 299 | static inline void |
| 300 | svc_sock_put(struct svc_sock *svsk) | 300 | svc_sock_put(struct svc_sock *svsk) |
| 301 | { | 301 | { |
| 302 | if (atomic_dec_and_test(&svsk->sk_inuse) && test_bit(SK_DEAD, &svsk->sk_flags)) { | 302 | if (atomic_dec_and_test(&svsk->sk_inuse) && |
| 303 | test_bit(SK_DEAD, &svsk->sk_flags)) { | ||
| 303 | dprintk("svc: releasing dead socket\n"); | 304 | dprintk("svc: releasing dead socket\n"); |
| 304 | sock_release(svsk->sk_sock); | 305 | if (svsk->sk_sock->file) |
| 306 | sockfd_put(svsk->sk_sock); | ||
| 307 | else | ||
| 308 | sock_release(svsk->sk_sock); | ||
| 309 | if (svsk->sk_info_authunix != NULL) | ||
| 310 | svcauth_unix_info_release(svsk->sk_info_authunix); | ||
| 305 | kfree(svsk); | 311 | kfree(svsk); |
| 306 | } | 312 | } |
| 307 | } | 313 | } |
| @@ -1604,20 +1610,13 @@ svc_delete_socket(struct svc_sock *svsk) | |||
| 1604 | if (test_bit(SK_TEMP, &svsk->sk_flags)) | 1610 | if (test_bit(SK_TEMP, &svsk->sk_flags)) |
| 1605 | serv->sv_tmpcnt--; | 1611 | serv->sv_tmpcnt--; |
| 1606 | 1612 | ||
| 1607 | if (!atomic_read(&svsk->sk_inuse)) { | 1613 | /* This atomic_inc should be needed - svc_delete_socket |
| 1608 | spin_unlock_bh(&serv->sv_lock); | 1614 | * should have the semantic of dropping a reference. |
| 1609 | if (svsk->sk_sock->file) | 1615 | * But it doesn't yet.... |
| 1610 | sockfd_put(svsk->sk_sock); | 1616 | */ |
| 1611 | else | 1617 | atomic_inc(&svsk->sk_inuse); |
| 1612 | sock_release(svsk->sk_sock); | 1618 | spin_unlock_bh(&serv->sv_lock); |
| 1613 | if (svsk->sk_info_authunix != NULL) | 1619 | svc_sock_put(svsk); |
| 1614 | svcauth_unix_info_release(svsk->sk_info_authunix); | ||
| 1615 | kfree(svsk); | ||
| 1616 | } else { | ||
| 1617 | spin_unlock_bh(&serv->sv_lock); | ||
| 1618 | dprintk(KERN_NOTICE "svc: server socket destroy delayed\n"); | ||
| 1619 | /* svsk->sk_server = NULL; */ | ||
| 1620 | } | ||
| 1621 | } | 1620 | } |
| 1622 | 1621 | ||
| 1623 | /* | 1622 | /* |
diff --git a/net/tipc/port.c b/net/tipc/port.c index c1a1a76759b5..b7f3199523ca 100644 --- a/net/tipc/port.c +++ b/net/tipc/port.c | |||
| @@ -1136,11 +1136,12 @@ int tipc_publish(u32 ref, unsigned int scope, struct tipc_name_seq const *seq) | |||
| 1136 | int res = -EINVAL; | 1136 | int res = -EINVAL; |
| 1137 | 1137 | ||
| 1138 | p_ptr = tipc_port_lock(ref); | 1138 | p_ptr = tipc_port_lock(ref); |
| 1139 | if (!p_ptr) | ||
| 1140 | return -EINVAL; | ||
| 1141 | |||
| 1139 | dbg("tipc_publ %u, p_ptr = %x, conn = %x, scope = %x, " | 1142 | dbg("tipc_publ %u, p_ptr = %x, conn = %x, scope = %x, " |
| 1140 | "lower = %u, upper = %u\n", | 1143 | "lower = %u, upper = %u\n", |
| 1141 | ref, p_ptr, p_ptr->publ.connected, scope, seq->lower, seq->upper); | 1144 | ref, p_ptr, p_ptr->publ.connected, scope, seq->lower, seq->upper); |
| 1142 | if (!p_ptr) | ||
| 1143 | return -EINVAL; | ||
| 1144 | if (p_ptr->publ.connected) | 1145 | if (p_ptr->publ.connected) |
| 1145 | goto exit; | 1146 | goto exit; |
| 1146 | if (seq->lower > seq->upper) | 1147 | if (seq->lower > seq->upper) |
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 84bbf8474f3e..899de9ed22a6 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c | |||
| @@ -505,6 +505,14 @@ __xfrm_state_locate(struct xfrm_state *x, int use_spi, int family) | |||
| 505 | x->id.proto, family); | 505 | x->id.proto, family); |
| 506 | } | 506 | } |
| 507 | 507 | ||
| 508 | static void xfrm_hash_grow_check(int have_hash_collision) | ||
| 509 | { | ||
| 510 | if (have_hash_collision && | ||
| 511 | (xfrm_state_hmask + 1) < xfrm_state_hashmax && | ||
| 512 | xfrm_state_num > xfrm_state_hmask) | ||
| 513 | schedule_work(&xfrm_hash_work); | ||
| 514 | } | ||
| 515 | |||
| 508 | struct xfrm_state * | 516 | struct xfrm_state * |
| 509 | xfrm_state_find(xfrm_address_t *daddr, xfrm_address_t *saddr, | 517 | xfrm_state_find(xfrm_address_t *daddr, xfrm_address_t *saddr, |
| 510 | struct flowi *fl, struct xfrm_tmpl *tmpl, | 518 | struct flowi *fl, struct xfrm_tmpl *tmpl, |
| @@ -598,6 +606,8 @@ xfrm_state_find(xfrm_address_t *daddr, xfrm_address_t *saddr, | |||
| 598 | x->lft.hard_add_expires_seconds = XFRM_ACQ_EXPIRES; | 606 | x->lft.hard_add_expires_seconds = XFRM_ACQ_EXPIRES; |
| 599 | x->timer.expires = jiffies + XFRM_ACQ_EXPIRES*HZ; | 607 | x->timer.expires = jiffies + XFRM_ACQ_EXPIRES*HZ; |
| 600 | add_timer(&x->timer); | 608 | add_timer(&x->timer); |
| 609 | xfrm_state_num++; | ||
| 610 | xfrm_hash_grow_check(x->bydst.next != NULL); | ||
| 601 | } else { | 611 | } else { |
| 602 | x->km.state = XFRM_STATE_DEAD; | 612 | x->km.state = XFRM_STATE_DEAD; |
| 603 | xfrm_state_put(x); | 613 | xfrm_state_put(x); |
| @@ -614,14 +624,6 @@ out: | |||
| 614 | return x; | 624 | return x; |
| 615 | } | 625 | } |
| 616 | 626 | ||
| 617 | static void xfrm_hash_grow_check(int have_hash_collision) | ||
| 618 | { | ||
| 619 | if (have_hash_collision && | ||
| 620 | (xfrm_state_hmask + 1) < xfrm_state_hashmax && | ||
| 621 | xfrm_state_num > xfrm_state_hmask) | ||
| 622 | schedule_work(&xfrm_hash_work); | ||
| 623 | } | ||
| 624 | |||
| 625 | static void __xfrm_state_insert(struct xfrm_state *x) | 627 | static void __xfrm_state_insert(struct xfrm_state *x) |
| 626 | { | 628 | { |
| 627 | unsigned int h; | 629 | unsigned int h; |
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 2b2e59d8ffbc..b43e7647e125 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c | |||
| @@ -323,7 +323,7 @@ static void copy_from_user_state(struct xfrm_state *x, struct xfrm_usersa_info * | |||
| 323 | x->props.replay_window = p->replay_window; | 323 | x->props.replay_window = p->replay_window; |
| 324 | x->props.reqid = p->reqid; | 324 | x->props.reqid = p->reqid; |
| 325 | x->props.family = p->family; | 325 | x->props.family = p->family; |
| 326 | x->props.saddr = p->saddr; | 326 | memcpy(&x->props.saddr, &p->saddr, sizeof(x->props.saddr)); |
| 327 | x->props.flags = p->flags; | 327 | x->props.flags = p->flags; |
| 328 | } | 328 | } |
| 329 | 329 | ||
| @@ -545,7 +545,7 @@ static void copy_to_user_state(struct xfrm_state *x, struct xfrm_usersa_info *p) | |||
| 545 | memcpy(&p->lft, &x->lft, sizeof(p->lft)); | 545 | memcpy(&p->lft, &x->lft, sizeof(p->lft)); |
| 546 | memcpy(&p->curlft, &x->curlft, sizeof(p->curlft)); | 546 | memcpy(&p->curlft, &x->curlft, sizeof(p->curlft)); |
| 547 | memcpy(&p->stats, &x->stats, sizeof(p->stats)); | 547 | memcpy(&p->stats, &x->stats, sizeof(p->stats)); |
| 548 | p->saddr = x->props.saddr; | 548 | memcpy(&p->saddr, &x->props.saddr, sizeof(p->saddr)); |
| 549 | p->mode = x->props.mode; | 549 | p->mode = x->props.mode; |
| 550 | p->replay_window = x->props.replay_window; | 550 | p->replay_window = x->props.replay_window; |
| 551 | p->reqid = x->props.reqid; | 551 | p->reqid = x->props.reqid; |
