4 files changed, 120 insertions, 16 deletions

diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index 03725c051752..7bf93df7248b 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -525,6 +525,13 @@ static int x25_create(struct socket *sock, int protocol)
         x25->facilities.pacsize_out = X25_DEFAULT_PACKET_SIZE;
         x25->facilities.throughput  = X25_DEFAULT_THROUGHPUT;
         x25->facilities.reverse     = X25_DEFAULT_REVERSE;
+        x25->dte_facilities.calling_len = 0;
+        x25->dte_facilities.called_len = 0;
+        memset(x25->dte_facilities.called_ae, '\0',
+                        sizeof(x25->dte_facilities.called_ae));
+        memset(x25->dte_facilities.calling_ae, '\0',
+                        sizeof(x25->dte_facilities.calling_ae));
+
         rc = 0;
 out:
         return rc;
@@ -561,6 +568,7 @@ static struct sock *x25_make_new(struct sock *osk)
         x25->t2         = ox25->t2;
         x25->facilities = ox25->facilities;
         x25->qbitincl   = ox25->qbitincl;
+        x25->dte_facilities = ox25->dte_facilities;
         x25->cudmatchlength = ox25->cudmatchlength;
         x25->accptapprv = ox25->accptapprv;
 
@@ -840,6 +848,7 @@ int x25_rx_call_request(struct sk_buff *skb, struct x25_neigh *nb,
         struct x25_sock *makex25;
         struct x25_address source_addr, dest_addr;
         struct x25_facilities facilities;
+        struct x25_dte_facilities dte_facilities;
         int len, rc;
 
         /*
@@ -876,7 +885,8 @@ int x25_rx_call_request(struct sk_buff *skb, struct x25_neigh *nb,
         /*
          *      Try to reach a compromise on the requested facilities.
          */
-        if ((len = x25_negotiate_facilities(skb, sk, &facilities)) == -1)
+        len = x25_negotiate_facilities(skb, sk, &facilities, &dte_facilities);
+        if (len == -1)
                 goto out_sock_put;
 
         /*
@@ -907,9 +917,12 @@ int x25_rx_call_request(struct sk_buff *skb, struct x25_neigh *nb,
         makex25->source_addr   = source_addr;
         makex25->neighbour     = nb;
         makex25->facilities    = facilities;
+        makex25->dte_facilities= dte_facilities;
         makex25->vc_facil_mask = x25_sk(sk)->vc_facil_mask;
         /* ensure no reverse facil on accept */
         makex25->vc_facil_mask &= ~X25_MASK_REVERSE;
+        /* ensure no calling address extension on accept */
+        makex25->vc_facil_mask &= ~X25_MASK_CALLING_AE;
         makex25->cudmatchlength = x25_sk(sk)->cudmatchlength;
 
         /* Normally all calls are accepted immediatly */
@@ -1316,6 +1329,36 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
                         break;
                 }
 
+                case SIOCX25GDTEFACILITIES: {
+                        rc = copy_to_user(argp, &x25->dte_facilities,
+                                                sizeof(x25->dte_facilities));
+                        if (rc)
+                                rc = -EFAULT;
+                        break;
+                }
+
+                case SIOCX25SDTEFACILITIES: {
+                        struct x25_dte_facilities dtefacs;
+                        rc = -EFAULT;
+                        if (copy_from_user(&dtefacs, argp, sizeof(dtefacs)))
+                                break;
+                        rc = -EINVAL;
+                        if (sk->sk_state != TCP_LISTEN &&
+                                        sk->sk_state != TCP_CLOSE)
+                                break;
+                        if (dtefacs.calling_len > X25_MAX_AE_LEN)
+                                break;
+                        if (dtefacs.calling_ae == NULL)
+                                break;
+                        if (dtefacs.called_len > X25_MAX_AE_LEN)
+                                break;
+                        if (dtefacs.called_ae == NULL)
+                                break;
+                        x25->dte_facilities = dtefacs;
+                        rc = 0;
+                        break;
+                }
+
                 case SIOCX25GCALLUSERDATA: {
                         struct x25_calluserdata cud = x25->calluserdata;
                         rc = copy_to_user(argp, &cud,
diff --git a/net/x25/x25_facilities.c b/net/x25/x25_facilities.c
index 54278b962f4c..9f42b9c9de37 100644
--- a/net/x25/x25_facilities.c
+++ b/net/x25/x25_facilities.c
@@ -28,18 +28,28 @@
 #include <net/x25.h>
 
 /*
- *      Parse a set of facilities into the facilities structure. Unrecognised
+ * Parse a set of facilities into the facilities structures. Unrecognised
  *      facilities are written to the debug log file.
  */
-int x25_parse_facilities(struct sk_buff *skb,
-                         struct x25_facilities *facilities,
-                         unsigned long *vc_fac_mask)
+int x25_parse_facilities(struct sk_buff *skb, struct x25_facilities *facilities,
+                struct x25_dte_facilities *dte_facs, unsigned long *vc_fac_mask)
 {
         unsigned char *p = skb->data;
         unsigned int len = *p++;
 
         *vc_fac_mask = 0;
 
+        /*
+         * The kernel knows which facilities were set on an incoming call but
+         * currently this information is not available to userspace.  Here we
+         * give userspace who read incoming call facilities 0 length to indicate
+         * it wasn't set.
+         */
+        dte_facs->calling_len = 0;
+        dte_facs->called_len = 0;
+        memset(dte_facs->called_ae, '\0', sizeof(dte_facs->called_ae));
+        memset(dte_facs->calling_ae, '\0', sizeof(dte_facs->calling_ae));
+
         while (len > 0) {
                 switch (*p & X25_FAC_CLASS_MASK) {
                 case X25_FAC_CLASS_A:
@@ -74,6 +84,8 @@ int x25_parse_facilities(struct sk_buff *skb,
                                 facilities->throughput = p[1];
                                 *vc_fac_mask |= X25_MASK_THROUGHPUT;
                                 break;
+                        case X25_MARKER:
+                                break;
                         default:
                                 printk(KERN_DEBUG "X.25: unknown facility "
                                        "%02X, value %02X\n",
@@ -112,11 +124,30 @@ int x25_parse_facilities(struct sk_buff *skb,
                         len -= 4;
                         break;
                 case X25_FAC_CLASS_D:
-                        printk(KERN_DEBUG "X.25: unknown facility %02X, "
-                               "length %d, values %02X, %02X, %02X, %02X\n",
-                               p[0], p[1], p[2], p[3], p[4], p[5]);
+                        switch (*p) {
+                        case X25_FAC_CALLING_AE:
+                                if (p[1] > X25_MAX_DTE_FACIL_LEN)
+                                        break;
+                                dte_facs->calling_len = p[2];
+                                memcpy(dte_facs->calling_ae, &p[3], p[1] - 1);
+                                *vc_fac_mask |= X25_MASK_CALLING_AE;
+                                break;
+                        case X25_FAC_CALLED_AE:
+                                if (p[1] > X25_MAX_DTE_FACIL_LEN)
+                                        break;
+                                dte_facs->called_len = p[2];
+                                memcpy(dte_facs->called_ae, &p[3], p[1] - 1);
+                                *vc_fac_mask |= X25_MASK_CALLED_AE;
+                                break;
+                        default:
+                                printk(KERN_DEBUG "X.25: unknown facility %02X,"
+                                        "length %d, values %02X, %02X, "
+                                        "%02X, %02X\n",
+                                        p[0], p[1], p[2], p[3], p[4], p[5]);
+                                break;
+                        }
                         len -= p[1] + 2;
-                        p   += p[1] + 2;
+                        p += p[1] + 2;
                         break;
                 }
         }
@@ -128,8 +159,8 @@ int x25_parse_facilities(struct sk_buff *skb,
  *      Create a set of facilities.
  */
 int x25_create_facilities(unsigned char *buffer,
-                          struct x25_facilities *facilities,
-                          unsigned long facil_mask)
+                struct x25_facilities *facilities,
+                struct x25_dte_facilities *dte_facs, unsigned long facil_mask)
 {
         unsigned char *p = buffer + 1;
         int len;
@@ -168,6 +199,33 @@ int x25_create_facilities(unsigned char *buffer,
                 *p++ = facilities->winsize_out ? : facilities->winsize_in;
         }
 
+        if (facil_mask & (X25_MASK_CALLING_AE|X25_MASK_CALLED_AE)) {
+                *p++ = X25_MARKER;
+                *p++ = X25_DTE_SERVICES;
+        }
+
+        if (dte_facs->calling_len && (facil_mask & X25_MASK_CALLING_AE)) {
+                unsigned bytecount = (dte_facs->calling_len % 2) ?
+                                        dte_facs->calling_len / 2 + 1 :
+                                        dte_facs->calling_len / 2;
+                *p++ = X25_FAC_CALLING_AE;
+                *p++ = 1 + bytecount;
+                *p++ = dte_facs->calling_len;
+                memcpy(p, dte_facs->calling_ae, bytecount);
+                p += bytecount;
+        }
+
+        if (dte_facs->called_len && (facil_mask & X25_MASK_CALLED_AE)) {
+                unsigned bytecount = (dte_facs->called_len % 2) ?
+                dte_facs->called_len / 2 + 1 :
+                dte_facs->called_len / 2;
+                *p++ = X25_FAC_CALLED_AE;
+                *p++ = 1 + bytecount;
+                *p++ = dte_facs->called_len;
+                memcpy(p, dte_facs->called_ae, bytecount);
+                p+=bytecount;
+        }
+
         len       = p - buffer;
         buffer[0] = len - 1;
 
@@ -180,7 +238,7 @@ int x25_create_facilities(unsigned char *buffer,
  *      The only real problem is with reverse charging.
  */
 int x25_negotiate_facilities(struct sk_buff *skb, struct sock *sk,
-                             struct x25_facilities *new)
+                struct x25_facilities *new, struct x25_dte_facilities *dte)
 {
         struct x25_sock *x25 = x25_sk(sk);
         struct x25_facilities *ours = &x25->facilities;
@@ -190,7 +248,7 @@ int x25_negotiate_facilities(struct sk_buff *skb, struct sock *sk,
         memset(&theirs, 0, sizeof(theirs));
         memcpy(new, ours, sizeof(*new));
 
-        len = x25_parse_facilities(skb, &theirs, &x25->vc_facil_mask);
+        len = x25_parse_facilities(skb, &theirs, dte, &x25->vc_facil_mask);
 
         /*
          *      They want reverse charging, we won't accept it.
diff --git a/net/x25/x25_in.c b/net/x25/x25_in.c
index 26146874b839..eed50e10f09b 100644
--- a/net/x25/x25_in.c
+++ b/net/x25/x25_in.c
@@ -106,7 +106,8 @@ static int x25_state1_machine(struct sock *sk, struct sk_buff *skb, int frametyp
                         skb_pull(skb, x25_addr_ntoa(skb->data, &source_addr, &dest_addr));
                         skb_pull(skb,
                                  x25_parse_facilities(skb, &x25->facilities,
-                                                      &x25->vc_facil_mask));
+                                                &x25->dte_facilities,
+                                                &x25->vc_facil_mask));
                         /*
                          *      Copy any Call User Data.
                          */
diff --git a/net/x25/x25_subr.c b/net/x25/x25_subr.c
index 8be9b8fbc24d..8d6220aa5d0f 100644
--- a/net/x25/x25_subr.c
+++ b/net/x25/x25_subr.c
@@ -190,8 +190,9 @@ void x25_write_internal(struct sock *sk, int frametype)
                         dptr    = skb_put(skb, len);
                         memcpy(dptr, addresses, len);
                         len     = x25_create_facilities(facilities,
-                                                        &x25->facilities,
-                                             x25->neighbour->global_facil_mask);
+                                        &x25->facilities,
+                                        &x25->dte_facilities,
+                                        x25->neighbour->global_facil_mask);
                         dptr    = skb_put(skb, len);
                         memcpy(dptr, facilities, len);
                         dptr = skb_put(skb, x25->calluserdata.cudlength);
@@ -206,6 +207,7 @@ void x25_write_internal(struct sock *sk, int frametype)
                         *dptr++ = 0x00;         /* Address lengths */
                         len     = x25_create_facilities(facilities,
                                                         &x25->facilities,
+                                                        &x25->dte_facilities,
                                                         x25->vc_facil_mask);
                         dptr    = skb_put(skb, len);
                         memcpy(dptr, facilities, len);