diff options
Diffstat (limited to 'net')
-rw-r--r-- | net/dccp/dccp.h | 16 | ||||
-rw-r--r-- | net/dccp/feat.c | 13 | ||||
-rw-r--r-- | net/dccp/minisocks.c | 11 | ||||
-rw-r--r-- | net/dccp/proto.c | 2 |
4 files changed, 18 insertions, 24 deletions
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index f2230fc168e1..04ae91898a68 100644 --- a/net/dccp/dccp.h +++ b/net/dccp/dccp.h | |||
@@ -409,23 +409,21 @@ static inline void dccp_hdr_set_ack(struct dccp_hdr_ack_bits *dhack, | |||
409 | static inline void dccp_update_gsr(struct sock *sk, u64 seq) | 409 | static inline void dccp_update_gsr(struct sock *sk, u64 seq) |
410 | { | 410 | { |
411 | struct dccp_sock *dp = dccp_sk(sk); | 411 | struct dccp_sock *dp = dccp_sk(sk); |
412 | const struct dccp_minisock *dmsk = dccp_msk(sk); | ||
413 | 412 | ||
414 | dp->dccps_gsr = seq; | 413 | dp->dccps_gsr = seq; |
415 | dccp_set_seqno(&dp->dccps_swl, | 414 | /* Sequence validity window depends on remote Sequence Window (7.5.1) */ |
416 | dp->dccps_gsr + 1 - (dmsk->dccpms_sequence_window / 4)); | 415 | dp->dccps_swl = SUB48(ADD48(dp->dccps_gsr, 1), dp->dccps_r_seq_win / 4); |
417 | dccp_set_seqno(&dp->dccps_swh, | 416 | dp->dccps_swh = ADD48(dp->dccps_gsr, (3 * dp->dccps_r_seq_win) / 4); |
418 | dp->dccps_gsr + (3 * dmsk->dccpms_sequence_window) / 4); | ||
419 | } | 417 | } |
420 | 418 | ||
421 | static inline void dccp_update_gss(struct sock *sk, u64 seq) | 419 | static inline void dccp_update_gss(struct sock *sk, u64 seq) |
422 | { | 420 | { |
423 | struct dccp_sock *dp = dccp_sk(sk); | 421 | struct dccp_sock *dp = dccp_sk(sk); |
424 | 422 | ||
425 | dp->dccps_awh = dp->dccps_gss = seq; | 423 | dp->dccps_gss = seq; |
426 | dccp_set_seqno(&dp->dccps_awl, | 424 | /* Ack validity window depends on local Sequence Window value (7.5.1) */ |
427 | (dp->dccps_gss - | 425 | dp->dccps_awl = SUB48(ADD48(dp->dccps_gss, 1), dp->dccps_l_seq_win); |
428 | dccp_msk(sk)->dccpms_sequence_window + 1)); | 426 | dp->dccps_awh = dp->dccps_gss; |
429 | } | 427 | } |
430 | 428 | ||
431 | static inline int dccp_ack_pending(const struct sock *sk) | 429 | static inline int dccp_ack_pending(const struct sock *sk) |
diff --git a/net/dccp/feat.c b/net/dccp/feat.c index 67ffac9905f8..7303f79705d2 100644 --- a/net/dccp/feat.c +++ b/net/dccp/feat.c | |||
@@ -51,8 +51,17 @@ static int dccp_hdlr_ccid(struct sock *sk, u64 ccid, bool rx) | |||
51 | 51 | ||
52 | static int dccp_hdlr_seq_win(struct sock *sk, u64 seq_win, bool rx) | 52 | static int dccp_hdlr_seq_win(struct sock *sk, u64 seq_win, bool rx) |
53 | { | 53 | { |
54 | if (!rx) | 54 | struct dccp_sock *dp = dccp_sk(sk); |
55 | dccp_msk(sk)->dccpms_sequence_window = seq_win; | 55 | |
56 | if (rx) { | ||
57 | dp->dccps_r_seq_win = seq_win; | ||
58 | /* propagate changes to update SWL/SWH */ | ||
59 | dccp_update_gsr(sk, dp->dccps_gsr); | ||
60 | } else { | ||
61 | dp->dccps_l_seq_win = seq_win; | ||
62 | /* propagate changes to update AWL */ | ||
63 | dccp_update_gss(sk, dp->dccps_gss); | ||
64 | } | ||
56 | return 0; | 65 | return 0; |
57 | } | 66 | } |
58 | 67 | ||
diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c index 6821ae33dd37..5ca49cec95f5 100644 --- a/net/dccp/minisocks.c +++ b/net/dccp/minisocks.c | |||
@@ -42,11 +42,6 @@ struct inet_timewait_death_row dccp_death_row = { | |||
42 | 42 | ||
43 | EXPORT_SYMBOL_GPL(dccp_death_row); | 43 | EXPORT_SYMBOL_GPL(dccp_death_row); |
44 | 44 | ||
45 | void dccp_minisock_init(struct dccp_minisock *dmsk) | ||
46 | { | ||
47 | dmsk->dccpms_sequence_window = sysctl_dccp_feat_sequence_window; | ||
48 | } | ||
49 | |||
50 | void dccp_time_wait(struct sock *sk, int state, int timeo) | 45 | void dccp_time_wait(struct sock *sk, int state, int timeo) |
51 | { | 46 | { |
52 | struct inet_timewait_sock *tw = NULL; | 47 | struct inet_timewait_sock *tw = NULL; |
@@ -110,7 +105,6 @@ struct sock *dccp_create_openreq_child(struct sock *sk, | |||
110 | struct dccp_request_sock *dreq = dccp_rsk(req); | 105 | struct dccp_request_sock *dreq = dccp_rsk(req); |
111 | struct inet_connection_sock *newicsk = inet_csk(newsk); | 106 | struct inet_connection_sock *newicsk = inet_csk(newsk); |
112 | struct dccp_sock *newdp = dccp_sk(newsk); | 107 | struct dccp_sock *newdp = dccp_sk(newsk); |
113 | struct dccp_minisock *newdmsk = dccp_msk(newsk); | ||
114 | 108 | ||
115 | newdp->dccps_role = DCCP_ROLE_SERVER; | 109 | newdp->dccps_role = DCCP_ROLE_SERVER; |
116 | newdp->dccps_hc_rx_ackvec = NULL; | 110 | newdp->dccps_hc_rx_ackvec = NULL; |
@@ -128,10 +122,6 @@ struct sock *dccp_create_openreq_child(struct sock *sk, | |||
128 | * Initialize S.GAR := S.ISS | 122 | * Initialize S.GAR := S.ISS |
129 | * Set S.ISR, S.GSR, S.SWL, S.SWH from packet or Init Cookies | 123 | * Set S.ISR, S.GSR, S.SWL, S.SWH from packet or Init Cookies |
130 | */ | 124 | */ |
131 | |||
132 | /* See dccp_v4_conn_request */ | ||
133 | newdmsk->dccpms_sequence_window = req->rcv_wnd; | ||
134 | |||
135 | newdp->dccps_gar = newdp->dccps_iss = dreq->dreq_iss; | 125 | newdp->dccps_gar = newdp->dccps_iss = dreq->dreq_iss; |
136 | dccp_update_gss(newsk, dreq->dreq_iss); | 126 | dccp_update_gss(newsk, dreq->dreq_iss); |
137 | 127 | ||
@@ -290,7 +280,6 @@ int dccp_reqsk_init(struct request_sock *req, | |||
290 | inet_rsk(req)->rmt_port = dccp_hdr(skb)->dccph_sport; | 280 | inet_rsk(req)->rmt_port = dccp_hdr(skb)->dccph_sport; |
291 | inet_rsk(req)->loc_port = dccp_hdr(skb)->dccph_dport; | 281 | inet_rsk(req)->loc_port = dccp_hdr(skb)->dccph_dport; |
292 | inet_rsk(req)->acked = 0; | 282 | inet_rsk(req)->acked = 0; |
293 | req->rcv_wnd = sysctl_dccp_feat_sequence_window; | ||
294 | dreq->dreq_timestamp_echo = 0; | 283 | dreq->dreq_timestamp_echo = 0; |
295 | 284 | ||
296 | /* inherit feature negotiation options from listening socket */ | 285 | /* inherit feature negotiation options from listening socket */ |
diff --git a/net/dccp/proto.c b/net/dccp/proto.c index 945b4d5d23b3..314a1b5c033c 100644 --- a/net/dccp/proto.c +++ b/net/dccp/proto.c | |||
@@ -174,8 +174,6 @@ int dccp_init_sock(struct sock *sk, const __u8 ctl_sock_initialized) | |||
174 | struct dccp_sock *dp = dccp_sk(sk); | 174 | struct dccp_sock *dp = dccp_sk(sk); |
175 | struct inet_connection_sock *icsk = inet_csk(sk); | 175 | struct inet_connection_sock *icsk = inet_csk(sk); |
176 | 176 | ||
177 | dccp_minisock_init(&dp->dccps_minisock); | ||
178 | |||
179 | icsk->icsk_rto = DCCP_TIMEOUT_INIT; | 177 | icsk->icsk_rto = DCCP_TIMEOUT_INIT; |
180 | icsk->icsk_syn_retries = sysctl_dccp_request_retries; | 178 | icsk->icsk_syn_retries = sysctl_dccp_request_retries; |
181 | sk->sk_state = DCCP_CLOSED; | 179 | sk->sk_state = DCCP_CLOSED; |