diff options
Diffstat (limited to 'net')
| -rw-r--r-- | net/9p/trans_fd.c | 112 | ||||
| -rw-r--r-- | net/core/dev.c | 11 | ||||
| -rw-r--r-- | net/core/rtnetlink.c | 6 | ||||
| -rw-r--r-- | net/core/skbuff.c | 2 | ||||
| -rw-r--r-- | net/ipv4/Kconfig | 6 | ||||
| -rw-r--r-- | net/ipv4/ipconfig.c | 2 | ||||
| -rw-r--r-- | net/ipv4/netfilter/nf_defrag_ipv4.c | 21 | ||||
| -rw-r--r-- | net/ipv4/syncookies.c | 27 | ||||
| -rw-r--r-- | net/ipv4/tcp_input.c | 24 | ||||
| -rw-r--r-- | net/ipv4/tcp_ipv4.c | 21 | ||||
| -rw-r--r-- | net/ipv4/tcp_minisocks.c | 10 | ||||
| -rw-r--r-- | net/ipv4/tcp_output.c | 18 | ||||
| -rw-r--r-- | net/ipv4/udp.c | 7 | ||||
| -rw-r--r-- | net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c | 19 | ||||
| -rw-r--r-- | net/ipv6/netfilter/nf_conntrack_reasm.c | 7 | ||||
| -rw-r--r-- | net/ipv6/reassembly.c | 5 | ||||
| -rw-r--r-- | net/ipv6/syncookies.c | 28 | ||||
| -rw-r--r-- | net/ipv6/tcp_ipv6.c | 3 | ||||
| -rw-r--r-- | net/netfilter/ipvs/ip_vs_core.c | 1 | ||||
| -rw-r--r-- | net/netfilter/ipvs/ip_vs_ctl.c | 4 | ||||
| -rw-r--r-- | net/packet/af_packet.c | 71 | ||||
| -rw-r--r-- | net/rds/ib.c | 4 | ||||
| -rw-r--r-- | net/rds/iw.c | 4 | ||||
| -rw-r--r-- | net/socket.c | 125 | ||||
| -rw-r--r-- | net/sunrpc/sched.c | 15 | ||||
| -rw-r--r-- | net/sunrpc/svc_xprt.c | 31 | ||||
| -rw-r--r-- | net/sunrpc/svcauth_unix.c | 53 |
27 files changed, 293 insertions, 344 deletions
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index 4dd873e3a1bb..be1cb909d8c0 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c | |||
| @@ -42,6 +42,8 @@ | |||
| 42 | #include <net/9p/client.h> | 42 | #include <net/9p/client.h> |
| 43 | #include <net/9p/transport.h> | 43 | #include <net/9p/transport.h> |
| 44 | 44 | ||
| 45 | #include <linux/syscalls.h> /* killme */ | ||
| 46 | |||
| 45 | #define P9_PORT 564 | 47 | #define P9_PORT 564 |
| 46 | #define MAX_SOCK_BUF (64*1024) | 48 | #define MAX_SOCK_BUF (64*1024) |
| 47 | #define MAXPOLLWADDR 2 | 49 | #define MAXPOLLWADDR 2 |
| @@ -788,24 +790,41 @@ static int p9_fd_open(struct p9_client *client, int rfd, int wfd) | |||
| 788 | 790 | ||
| 789 | static int p9_socket_open(struct p9_client *client, struct socket *csocket) | 791 | static int p9_socket_open(struct p9_client *client, struct socket *csocket) |
| 790 | { | 792 | { |
| 791 | int fd, ret; | 793 | struct p9_trans_fd *p; |
| 794 | int ret, fd; | ||
| 795 | |||
| 796 | p = kmalloc(sizeof(struct p9_trans_fd), GFP_KERNEL); | ||
| 797 | if (!p) | ||
| 798 | return -ENOMEM; | ||
| 792 | 799 | ||
| 793 | csocket->sk->sk_allocation = GFP_NOIO; | 800 | csocket->sk->sk_allocation = GFP_NOIO; |
| 794 | fd = sock_map_fd(csocket, 0); | 801 | fd = sock_map_fd(csocket, 0); |
| 795 | if (fd < 0) { | 802 | if (fd < 0) { |
| 796 | P9_EPRINTK(KERN_ERR, "p9_socket_open: failed to map fd\n"); | 803 | P9_EPRINTK(KERN_ERR, "p9_socket_open: failed to map fd\n"); |
| 804 | sock_release(csocket); | ||
| 805 | kfree(p); | ||
| 797 | return fd; | 806 | return fd; |
| 798 | } | 807 | } |
| 799 | 808 | ||
| 800 | ret = p9_fd_open(client, fd, fd); | 809 | get_file(csocket->file); |
| 801 | if (ret < 0) { | 810 | get_file(csocket->file); |
| 802 | P9_EPRINTK(KERN_ERR, "p9_socket_open: failed to open fd\n"); | 811 | p->wr = p->rd = csocket->file; |
| 812 | client->trans = p; | ||
| 813 | client->status = Connected; | ||
| 814 | |||
| 815 | sys_close(fd); /* still racy */ | ||
| 816 | |||
| 817 | p->rd->f_flags |= O_NONBLOCK; | ||
| 818 | |||
| 819 | p->conn = p9_conn_create(client); | ||
| 820 | if (IS_ERR(p->conn)) { | ||
| 821 | ret = PTR_ERR(p->conn); | ||
| 822 | p->conn = NULL; | ||
| 823 | kfree(p); | ||
| 824 | sockfd_put(csocket); | ||
| 803 | sockfd_put(csocket); | 825 | sockfd_put(csocket); |
| 804 | return ret; | 826 | return ret; |
| 805 | } | 827 | } |
| 806 | |||
| 807 | ((struct p9_trans_fd *)client->trans)->rd->f_flags |= O_NONBLOCK; | ||
| 808 | |||
| 809 | return 0; | 828 | return 0; |
| 810 | } | 829 | } |
| 811 | 830 | ||
| @@ -883,7 +902,6 @@ p9_fd_create_tcp(struct p9_client *client, const char *addr, char *args) | |||
| 883 | struct socket *csocket; | 902 | struct socket *csocket; |
| 884 | struct sockaddr_in sin_server; | 903 | struct sockaddr_in sin_server; |
| 885 | struct p9_fd_opts opts; | 904 | struct p9_fd_opts opts; |
| 886 | struct p9_trans_fd *p = NULL; /* this gets allocated in p9_fd_open */ | ||
| 887 | 905 | ||
| 888 | err = parse_opts(args, &opts); | 906 | err = parse_opts(args, &opts); |
| 889 | if (err < 0) | 907 | if (err < 0) |
| @@ -897,12 +915,11 @@ p9_fd_create_tcp(struct p9_client *client, const char *addr, char *args) | |||
| 897 | sin_server.sin_family = AF_INET; | 915 | sin_server.sin_family = AF_INET; |
| 898 | sin_server.sin_addr.s_addr = in_aton(addr); | 916 | sin_server.sin_addr.s_addr = in_aton(addr); |
| 899 | sin_server.sin_port = htons(opts.port); | 917 | sin_server.sin_port = htons(opts.port); |
| 900 | sock_create_kern(PF_INET, SOCK_STREAM, IPPROTO_TCP, &csocket); | 918 | err = sock_create_kern(PF_INET, SOCK_STREAM, IPPROTO_TCP, &csocket); |
| 901 | 919 | ||
| 902 | if (!csocket) { | 920 | if (err) { |
| 903 | P9_EPRINTK(KERN_ERR, "p9_trans_tcp: problem creating socket\n"); | 921 | P9_EPRINTK(KERN_ERR, "p9_trans_tcp: problem creating socket\n"); |
| 904 | err = -EIO; | 922 | return err; |
| 905 | goto error; | ||
| 906 | } | 923 | } |
| 907 | 924 | ||
| 908 | err = csocket->ops->connect(csocket, | 925 | err = csocket->ops->connect(csocket, |
| @@ -912,30 +929,11 @@ p9_fd_create_tcp(struct p9_client *client, const char *addr, char *args) | |||
| 912 | P9_EPRINTK(KERN_ERR, | 929 | P9_EPRINTK(KERN_ERR, |
| 913 | "p9_trans_tcp: problem connecting socket to %s\n", | 930 | "p9_trans_tcp: problem connecting socket to %s\n", |
| 914 | addr); | 931 | addr); |
| 915 | goto error; | ||
| 916 | } | ||
| 917 | |||
| 918 | err = p9_socket_open(client, csocket); | ||
| 919 | if (err < 0) | ||
| 920 | goto error; | ||
| 921 | |||
| 922 | p = (struct p9_trans_fd *) client->trans; | ||
| 923 | p->conn = p9_conn_create(client); | ||
| 924 | if (IS_ERR(p->conn)) { | ||
| 925 | err = PTR_ERR(p->conn); | ||
| 926 | p->conn = NULL; | ||
| 927 | goto error; | ||
| 928 | } | ||
| 929 | |||
| 930 | return 0; | ||
| 931 | |||
| 932 | error: | ||
| 933 | if (csocket) | ||
| 934 | sock_release(csocket); | 932 | sock_release(csocket); |
| 933 | return err; | ||
| 934 | } | ||
| 935 | 935 | ||
| 936 | kfree(p); | 936 | return p9_socket_open(client, csocket); |
| 937 | |||
| 938 | return err; | ||
| 939 | } | 937 | } |
| 940 | 938 | ||
| 941 | static int | 939 | static int |
| @@ -944,49 +942,33 @@ p9_fd_create_unix(struct p9_client *client, const char *addr, char *args) | |||
| 944 | int err; | 942 | int err; |
| 945 | struct socket *csocket; | 943 | struct socket *csocket; |
| 946 | struct sockaddr_un sun_server; | 944 | struct sockaddr_un sun_server; |
| 947 | struct p9_trans_fd *p = NULL; /* this gets allocated in p9_fd_open */ | ||
| 948 | 945 | ||
| 949 | csocket = NULL; | 946 | csocket = NULL; |
| 950 | 947 | ||
| 951 | if (strlen(addr) > UNIX_PATH_MAX) { | 948 | if (strlen(addr) > UNIX_PATH_MAX) { |
| 952 | P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n", | 949 | P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n", |
| 953 | addr); | 950 | addr); |
| 954 | err = -ENAMETOOLONG; | 951 | return -ENAMETOOLONG; |
| 955 | goto error; | ||
| 956 | } | 952 | } |
| 957 | 953 | ||
| 958 | sun_server.sun_family = PF_UNIX; | 954 | sun_server.sun_family = PF_UNIX; |
| 959 | strcpy(sun_server.sun_path, addr); | 955 | strcpy(sun_server.sun_path, addr); |
| 960 | sock_create_kern(PF_UNIX, SOCK_STREAM, 0, &csocket); | 956 | err = sock_create_kern(PF_UNIX, SOCK_STREAM, 0, &csocket); |
| 957 | if (err < 0) { | ||
| 958 | P9_EPRINTK(KERN_ERR, "p9_trans_unix: problem creating socket\n"); | ||
| 959 | return err; | ||
| 960 | } | ||
| 961 | err = csocket->ops->connect(csocket, (struct sockaddr *)&sun_server, | 961 | err = csocket->ops->connect(csocket, (struct sockaddr *)&sun_server, |
| 962 | sizeof(struct sockaddr_un) - 1, 0); | 962 | sizeof(struct sockaddr_un) - 1, 0); |
| 963 | if (err < 0) { | 963 | if (err < 0) { |
| 964 | P9_EPRINTK(KERN_ERR, | 964 | P9_EPRINTK(KERN_ERR, |
| 965 | "p9_trans_unix: problem connecting socket: %s: %d\n", | 965 | "p9_trans_unix: problem connecting socket: %s: %d\n", |
| 966 | addr, err); | 966 | addr, err); |
| 967 | goto error; | ||
| 968 | } | ||
| 969 | |||
| 970 | err = p9_socket_open(client, csocket); | ||
| 971 | if (err < 0) | ||
| 972 | goto error; | ||
| 973 | |||
| 974 | p = (struct p9_trans_fd *) client->trans; | ||
| 975 | p->conn = p9_conn_create(client); | ||
| 976 | if (IS_ERR(p->conn)) { | ||
| 977 | err = PTR_ERR(p->conn); | ||
| 978 | p->conn = NULL; | ||
| 979 | goto error; | ||
| 980 | } | ||
| 981 | |||
| 982 | return 0; | ||
| 983 | |||
| 984 | error: | ||
| 985 | if (csocket) | ||
| 986 | sock_release(csocket); | 967 | sock_release(csocket); |
| 968 | return err; | ||
| 969 | } | ||
| 987 | 970 | ||
| 988 | kfree(p); | 971 | return p9_socket_open(client, csocket); |
| 989 | return err; | ||
| 990 | } | 972 | } |
| 991 | 973 | ||
| 992 | static int | 974 | static int |
| @@ -994,7 +976,7 @@ p9_fd_create(struct p9_client *client, const char *addr, char *args) | |||
| 994 | { | 976 | { |
| 995 | int err; | 977 | int err; |
| 996 | struct p9_fd_opts opts; | 978 | struct p9_fd_opts opts; |
| 997 | struct p9_trans_fd *p = NULL; /* this get allocated in p9_fd_open */ | 979 | struct p9_trans_fd *p; |
| 998 | 980 | ||
| 999 | parse_opts(args, &opts); | 981 | parse_opts(args, &opts); |
| 1000 | 982 | ||
| @@ -1005,21 +987,19 @@ p9_fd_create(struct p9_client *client, const char *addr, char *args) | |||
| 1005 | 987 | ||
| 1006 | err = p9_fd_open(client, opts.rfd, opts.wfd); | 988 | err = p9_fd_open(client, opts.rfd, opts.wfd); |
| 1007 | if (err < 0) | 989 | if (err < 0) |
| 1008 | goto error; | 990 | return err; |
| 1009 | 991 | ||
| 1010 | p = (struct p9_trans_fd *) client->trans; | 992 | p = (struct p9_trans_fd *) client->trans; |
| 1011 | p->conn = p9_conn_create(client); | 993 | p->conn = p9_conn_create(client); |
| 1012 | if (IS_ERR(p->conn)) { | 994 | if (IS_ERR(p->conn)) { |
| 1013 | err = PTR_ERR(p->conn); | 995 | err = PTR_ERR(p->conn); |
| 1014 | p->conn = NULL; | 996 | p->conn = NULL; |
| 1015 | goto error; | 997 | fput(p->rd); |
| 998 | fput(p->wr); | ||
| 999 | return err; | ||
| 1016 | } | 1000 | } |
| 1017 | 1001 | ||
| 1018 | return 0; | 1002 | return 0; |
| 1019 | |||
| 1020 | error: | ||
| 1021 | kfree(p); | ||
| 1022 | return err; | ||
| 1023 | } | 1003 | } |
| 1024 | 1004 | ||
| 1025 | static struct p9_trans_module p9_tcp_trans = { | 1005 | static struct p9_trans_module p9_tcp_trans = { |
diff --git a/net/core/dev.c b/net/core/dev.c index 6fe7d739e59b..be9924f60ec3 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
| @@ -5035,6 +5035,11 @@ int register_netdevice(struct net_device *dev) | |||
| 5035 | rollback_registered(dev); | 5035 | rollback_registered(dev); |
| 5036 | dev->reg_state = NETREG_UNREGISTERED; | 5036 | dev->reg_state = NETREG_UNREGISTERED; |
| 5037 | } | 5037 | } |
| 5038 | /* | ||
| 5039 | * Prevent userspace races by waiting until the network | ||
| 5040 | * device is fully setup before sending notifications. | ||
| 5041 | */ | ||
| 5042 | rtmsg_ifinfo(RTM_NEWLINK, dev, ~0U); | ||
| 5038 | 5043 | ||
| 5039 | out: | 5044 | out: |
| 5040 | return ret; | 5045 | return ret; |
| @@ -5597,6 +5602,12 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char | |||
| 5597 | /* Notify protocols, that a new device appeared. */ | 5602 | /* Notify protocols, that a new device appeared. */ |
| 5598 | call_netdevice_notifiers(NETDEV_REGISTER, dev); | 5603 | call_netdevice_notifiers(NETDEV_REGISTER, dev); |
| 5599 | 5604 | ||
| 5605 | /* | ||
| 5606 | * Prevent userspace races by waiting until the network | ||
| 5607 | * device is fully setup before sending notifications. | ||
| 5608 | */ | ||
| 5609 | rtmsg_ifinfo(RTM_NEWLINK, dev, ~0U); | ||
| 5610 | |||
| 5600 | synchronize_net(); | 5611 | synchronize_net(); |
| 5601 | err = 0; | 5612 | err = 0; |
| 5602 | out: | 5613 | out: |
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 33148a568199..794bcb897ff0 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c | |||
| @@ -1364,15 +1364,15 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi | |||
| 1364 | case NETDEV_UNREGISTER: | 1364 | case NETDEV_UNREGISTER: |
| 1365 | rtmsg_ifinfo(RTM_DELLINK, dev, ~0U); | 1365 | rtmsg_ifinfo(RTM_DELLINK, dev, ~0U); |
| 1366 | break; | 1366 | break; |
| 1367 | case NETDEV_REGISTER: | ||
| 1368 | rtmsg_ifinfo(RTM_NEWLINK, dev, ~0U); | ||
| 1369 | break; | ||
| 1370 | case NETDEV_UP: | 1367 | case NETDEV_UP: |
| 1371 | case NETDEV_DOWN: | 1368 | case NETDEV_DOWN: |
| 1372 | rtmsg_ifinfo(RTM_NEWLINK, dev, IFF_UP|IFF_RUNNING); | 1369 | rtmsg_ifinfo(RTM_NEWLINK, dev, IFF_UP|IFF_RUNNING); |
| 1373 | break; | 1370 | break; |
| 1371 | case NETDEV_POST_INIT: | ||
| 1372 | case NETDEV_REGISTER: | ||
| 1374 | case NETDEV_CHANGE: | 1373 | case NETDEV_CHANGE: |
| 1375 | case NETDEV_GOING_DOWN: | 1374 | case NETDEV_GOING_DOWN: |
| 1375 | case NETDEV_UNREGISTER_BATCH: | ||
| 1376 | break; | 1376 | break; |
| 1377 | default: | 1377 | default: |
| 1378 | rtmsg_ifinfo(RTM_NEWLINK, dev, 0); | 1378 | rtmsg_ifinfo(RTM_NEWLINK, dev, 0); |
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index bfa3e7865a8c..93c4e060c91e 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c | |||
| @@ -93,7 +93,7 @@ static int sock_pipe_buf_steal(struct pipe_inode_info *pipe, | |||
| 93 | 93 | ||
| 94 | 94 | ||
| 95 | /* Pipe buffer operations for a socket. */ | 95 | /* Pipe buffer operations for a socket. */ |
| 96 | static struct pipe_buf_operations sock_pipe_buf_ops = { | 96 | static const struct pipe_buf_operations sock_pipe_buf_ops = { |
| 97 | .can_merge = 0, | 97 | .can_merge = 0, |
| 98 | .map = generic_pipe_buf_map, | 98 | .map = generic_pipe_buf_map, |
| 99 | .unmap = generic_pipe_buf_unmap, | 99 | .unmap = generic_pipe_buf_unmap, |
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig index 70491d9035eb..0c94a1ac2946 100644 --- a/net/ipv4/Kconfig +++ b/net/ipv4/Kconfig | |||
| @@ -166,7 +166,7 @@ config IP_PNP_DHCP | |||
| 166 | 166 | ||
| 167 | If unsure, say Y. Note that if you want to use DHCP, a DHCP server | 167 | If unsure, say Y. Note that if you want to use DHCP, a DHCP server |
| 168 | must be operating on your network. Read | 168 | must be operating on your network. Read |
| 169 | <file:Documentation/filesystems/nfsroot.txt> for details. | 169 | <file:Documentation/filesystems/nfs/nfsroot.txt> for details. |
| 170 | 170 | ||
| 171 | config IP_PNP_BOOTP | 171 | config IP_PNP_BOOTP |
| 172 | bool "IP: BOOTP support" | 172 | bool "IP: BOOTP support" |
| @@ -181,7 +181,7 @@ config IP_PNP_BOOTP | |||
| 181 | does BOOTP itself, providing all necessary information on the kernel | 181 | does BOOTP itself, providing all necessary information on the kernel |
| 182 | command line, you can say N here. If unsure, say Y. Note that if you | 182 | command line, you can say N here. If unsure, say Y. Note that if you |
| 183 | want to use BOOTP, a BOOTP server must be operating on your network. | 183 | want to use BOOTP, a BOOTP server must be operating on your network. |
| 184 | Read <file:Documentation/filesystems/nfsroot.txt> for details. | 184 | Read <file:Documentation/filesystems/nfs/nfsroot.txt> for details. |
| 185 | 185 | ||
| 186 | config IP_PNP_RARP | 186 | config IP_PNP_RARP |
| 187 | bool "IP: RARP support" | 187 | bool "IP: RARP support" |
| @@ -194,7 +194,7 @@ config IP_PNP_RARP | |||
| 194 | older protocol which is being obsoleted by BOOTP and DHCP), say Y | 194 | older protocol which is being obsoleted by BOOTP and DHCP), say Y |
| 195 | here. Note that if you want to use RARP, a RARP server must be | 195 | here. Note that if you want to use RARP, a RARP server must be |
| 196 | operating on your network. Read | 196 | operating on your network. Read |
| 197 | <file:Documentation/filesystems/nfsroot.txt> for details. | 197 | <file:Documentation/filesystems/nfs/nfsroot.txt> for details. |
| 198 | 198 | ||
| 199 | # not yet ready.. | 199 | # not yet ready.. |
| 200 | # bool ' IP: ARP support' CONFIG_IP_PNP_ARP | 200 | # bool ' IP: ARP support' CONFIG_IP_PNP_ARP |
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index 4e08b7f2331c..10a6a604bf32 100644 --- a/net/ipv4/ipconfig.c +++ b/net/ipv4/ipconfig.c | |||
| @@ -1446,7 +1446,7 @@ late_initcall(ip_auto_config); | |||
| 1446 | 1446 | ||
| 1447 | /* | 1447 | /* |
| 1448 | * Decode any IP configuration options in the "ip=" or "nfsaddrs=" kernel | 1448 | * Decode any IP configuration options in the "ip=" or "nfsaddrs=" kernel |
| 1449 | * command line parameter. See Documentation/filesystems/nfsroot.txt. | 1449 | * command line parameter. See Documentation/filesystems/nfs/nfsroot.txt. |
| 1450 | */ | 1450 | */ |
| 1451 | static int __init ic_proto_name(char *name) | 1451 | static int __init ic_proto_name(char *name) |
| 1452 | { | 1452 | { |
diff --git a/net/ipv4/netfilter/nf_defrag_ipv4.c b/net/ipv4/netfilter/nf_defrag_ipv4.c index fa2d6b6fc3e5..331ead3ebd1b 100644 --- a/net/ipv4/netfilter/nf_defrag_ipv4.c +++ b/net/ipv4/netfilter/nf_defrag_ipv4.c | |||
| @@ -14,6 +14,7 @@ | |||
| 14 | #include <net/route.h> | 14 | #include <net/route.h> |
| 15 | #include <net/ip.h> | 15 | #include <net/ip.h> |
| 16 | 16 | ||
| 17 | #include <linux/netfilter_bridge.h> | ||
| 17 | #include <linux/netfilter_ipv4.h> | 18 | #include <linux/netfilter_ipv4.h> |
| 18 | #include <net/netfilter/ipv4/nf_defrag_ipv4.h> | 19 | #include <net/netfilter/ipv4/nf_defrag_ipv4.h> |
| 19 | 20 | ||
| @@ -34,6 +35,20 @@ static int nf_ct_ipv4_gather_frags(struct sk_buff *skb, u_int32_t user) | |||
| 34 | return err; | 35 | return err; |
| 35 | } | 36 | } |
| 36 | 37 | ||
| 38 | static enum ip_defrag_users nf_ct_defrag_user(unsigned int hooknum, | ||
| 39 | struct sk_buff *skb) | ||
| 40 | { | ||
| 41 | #ifdef CONFIG_BRIDGE_NETFILTER | ||
| 42 | if (skb->nf_bridge && | ||
| 43 | skb->nf_bridge->mask & BRNF_NF_BRIDGE_PREROUTING) | ||
| 44 | return IP_DEFRAG_CONNTRACK_BRIDGE_IN; | ||
| 45 | #endif | ||
| 46 | if (hooknum == NF_INET_PRE_ROUTING) | ||
| 47 | return IP_DEFRAG_CONNTRACK_IN; | ||
| 48 | else | ||
| 49 | return IP_DEFRAG_CONNTRACK_OUT; | ||
| 50 | } | ||
| 51 | |||
| 37 | static unsigned int ipv4_conntrack_defrag(unsigned int hooknum, | 52 | static unsigned int ipv4_conntrack_defrag(unsigned int hooknum, |
| 38 | struct sk_buff *skb, | 53 | struct sk_buff *skb, |
| 39 | const struct net_device *in, | 54 | const struct net_device *in, |
| @@ -50,10 +65,8 @@ static unsigned int ipv4_conntrack_defrag(unsigned int hooknum, | |||
| 50 | #endif | 65 | #endif |
| 51 | /* Gather fragments. */ | 66 | /* Gather fragments. */ |
| 52 | if (ip_hdr(skb)->frag_off & htons(IP_MF | IP_OFFSET)) { | 67 | if (ip_hdr(skb)->frag_off & htons(IP_MF | IP_OFFSET)) { |
| 53 | if (nf_ct_ipv4_gather_frags(skb, | 68 | enum ip_defrag_users user = nf_ct_defrag_user(hooknum, skb); |
| 54 | hooknum == NF_INET_PRE_ROUTING ? | 69 | if (nf_ct_ipv4_gather_frags(skb, user)) |
| 55 | IP_DEFRAG_CONNTRACK_IN : | ||
| 56 | IP_DEFRAG_CONNTRACK_OUT)) | ||
| 57 | return NF_STOLEN; | 70 | return NF_STOLEN; |
| 58 | } | 71 | } |
| 59 | return NF_ACCEPT; | 72 | return NF_ACCEPT; |
diff --git a/net/ipv4/syncookies.c b/net/ipv4/syncookies.c index 26399ad2a289..66fd80ef2473 100644 --- a/net/ipv4/syncookies.c +++ b/net/ipv4/syncookies.c | |||
| @@ -277,6 +277,13 @@ struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb, | |||
| 277 | 277 | ||
| 278 | NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_SYNCOOKIESRECV); | 278 | NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_SYNCOOKIESRECV); |
| 279 | 279 | ||
| 280 | /* check for timestamp cookie support */ | ||
| 281 | memset(&tcp_opt, 0, sizeof(tcp_opt)); | ||
| 282 | tcp_parse_options(skb, &tcp_opt, &hash_location, 0); | ||
| 283 | |||
| 284 | if (tcp_opt.saw_tstamp) | ||
| 285 | cookie_check_timestamp(&tcp_opt); | ||
| 286 | |||
| 280 | ret = NULL; | 287 | ret = NULL; |
| 281 | req = inet_reqsk_alloc(&tcp_request_sock_ops); /* for safety */ | 288 | req = inet_reqsk_alloc(&tcp_request_sock_ops); /* for safety */ |
| 282 | if (!req) | 289 | if (!req) |
| @@ -292,6 +299,12 @@ struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb, | |||
| 292 | ireq->loc_addr = ip_hdr(skb)->daddr; | 299 | ireq->loc_addr = ip_hdr(skb)->daddr; |
| 293 | ireq->rmt_addr = ip_hdr(skb)->saddr; | 300 | ireq->rmt_addr = ip_hdr(skb)->saddr; |
| 294 | ireq->ecn_ok = 0; | 301 | ireq->ecn_ok = 0; |
| 302 | ireq->snd_wscale = tcp_opt.snd_wscale; | ||
| 303 | ireq->rcv_wscale = tcp_opt.rcv_wscale; | ||
| 304 | ireq->sack_ok = tcp_opt.sack_ok; | ||
| 305 | ireq->wscale_ok = tcp_opt.wscale_ok; | ||
| 306 | ireq->tstamp_ok = tcp_opt.saw_tstamp; | ||
| 307 | req->ts_recent = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsval : 0; | ||
| 295 | 308 | ||
| 296 | /* We throwed the options of the initial SYN away, so we hope | 309 | /* We throwed the options of the initial SYN away, so we hope |
| 297 | * the ACK carries the same options again (see RFC1122 4.2.3.8) | 310 | * the ACK carries the same options again (see RFC1122 4.2.3.8) |
| @@ -340,20 +353,6 @@ struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb, | |||
| 340 | } | 353 | } |
| 341 | } | 354 | } |
| 342 | 355 | ||
| 343 | /* check for timestamp cookie support */ | ||
| 344 | memset(&tcp_opt, 0, sizeof(tcp_opt)); | ||
| 345 | tcp_parse_options(skb, &tcp_opt, &hash_location, 0, &rt->u.dst); | ||
| 346 | |||
| 347 | if (tcp_opt.saw_tstamp) | ||
| 348 | cookie_check_timestamp(&tcp_opt); | ||
| 349 | |||
| 350 | ireq->snd_wscale = tcp_opt.snd_wscale; | ||
| 351 | ireq->rcv_wscale = tcp_opt.rcv_wscale; | ||
| 352 | ireq->sack_ok = tcp_opt.sack_ok; | ||
| 353 | ireq->wscale_ok = tcp_opt.wscale_ok; | ||
| 354 | ireq->tstamp_ok = tcp_opt.saw_tstamp; | ||
| 355 | req->ts_recent = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsval : 0; | ||
| 356 | |||
| 357 | /* Try to redo what tcp_v4_send_synack did. */ | 356 | /* Try to redo what tcp_v4_send_synack did. */ |
| 358 | req->window_clamp = tp->window_clamp ? :dst_metric(&rt->u.dst, RTAX_WINDOW); | 357 | req->window_clamp = tp->window_clamp ? :dst_metric(&rt->u.dst, RTAX_WINDOW); |
| 359 | 358 | ||
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 12cab7d74dba..28e029632493 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c | |||
| @@ -3727,7 +3727,7 @@ old_ack: | |||
| 3727 | * the fast version below fails. | 3727 | * the fast version below fails. |
| 3728 | */ | 3728 | */ |
| 3729 | void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx, | 3729 | void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx, |
| 3730 | u8 **hvpp, int estab, struct dst_entry *dst) | 3730 | u8 **hvpp, int estab) |
| 3731 | { | 3731 | { |
| 3732 | unsigned char *ptr; | 3732 | unsigned char *ptr; |
| 3733 | struct tcphdr *th = tcp_hdr(skb); | 3733 | struct tcphdr *th = tcp_hdr(skb); |
| @@ -3766,8 +3766,7 @@ void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx, | |||
| 3766 | break; | 3766 | break; |
| 3767 | case TCPOPT_WINDOW: | 3767 | case TCPOPT_WINDOW: |
| 3768 | if (opsize == TCPOLEN_WINDOW && th->syn && | 3768 | if (opsize == TCPOLEN_WINDOW && th->syn && |
| 3769 | !estab && sysctl_tcp_window_scaling && | 3769 | !estab && sysctl_tcp_window_scaling) { |
| 3770 | !dst_feature(dst, RTAX_FEATURE_NO_WSCALE)) { | ||
| 3771 | __u8 snd_wscale = *(__u8 *)ptr; | 3770 | __u8 snd_wscale = *(__u8 *)ptr; |
| 3772 | opt_rx->wscale_ok = 1; | 3771 | opt_rx->wscale_ok = 1; |
| 3773 | if (snd_wscale > 14) { | 3772 | if (snd_wscale > 14) { |
| @@ -3783,8 +3782,7 @@ void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx, | |||
| 3783 | case TCPOPT_TIMESTAMP: | 3782 | case TCPOPT_TIMESTAMP: |
| 3784 | if ((opsize == TCPOLEN_TIMESTAMP) && | 3783 | if ((opsize == TCPOLEN_TIMESTAMP) && |
| 3785 | ((estab && opt_rx->tstamp_ok) || | 3784 | ((estab && opt_rx->tstamp_ok) || |
| 3786 | (!estab && sysctl_tcp_timestamps && | 3785 | (!estab && sysctl_tcp_timestamps))) { |
| 3787 | !dst_feature(dst, RTAX_FEATURE_NO_TSTAMP)))) { | ||
| 3788 | opt_rx->saw_tstamp = 1; | 3786 | opt_rx->saw_tstamp = 1; |
| 3789 | opt_rx->rcv_tsval = get_unaligned_be32(ptr); | 3787 | opt_rx->rcv_tsval = get_unaligned_be32(ptr); |
| 3790 | opt_rx->rcv_tsecr = get_unaligned_be32(ptr + 4); | 3788 | opt_rx->rcv_tsecr = get_unaligned_be32(ptr + 4); |
| @@ -3792,8 +3790,7 @@ void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx, | |||
| 3792 | break; | 3790 | break; |
| 3793 | case TCPOPT_SACK_PERM: | 3791 | case TCPOPT_SACK_PERM: |
| 3794 | if (opsize == TCPOLEN_SACK_PERM && th->syn && | 3792 | if (opsize == TCPOLEN_SACK_PERM && th->syn && |
| 3795 | !estab && sysctl_tcp_sack && | 3793 | !estab && sysctl_tcp_sack) { |
| 3796 | !dst_feature(dst, RTAX_FEATURE_NO_SACK)) { | ||
| 3797 | opt_rx->sack_ok = 1; | 3794 | opt_rx->sack_ok = 1; |
| 3798 | tcp_sack_reset(opt_rx); | 3795 | tcp_sack_reset(opt_rx); |
| 3799 | } | 3796 | } |
| @@ -3878,7 +3875,7 @@ static int tcp_fast_parse_options(struct sk_buff *skb, struct tcphdr *th, | |||
| 3878 | if (tcp_parse_aligned_timestamp(tp, th)) | 3875 | if (tcp_parse_aligned_timestamp(tp, th)) |
| 3879 | return 1; | 3876 | return 1; |
| 3880 | } | 3877 | } |
| 3881 | tcp_parse_options(skb, &tp->rx_opt, hvpp, 1, NULL); | 3878 | tcp_parse_options(skb, &tp->rx_opt, hvpp, 1); |
| 3882 | return 1; | 3879 | return 1; |
| 3883 | } | 3880 | } |
| 3884 | 3881 | ||
| @@ -4133,10 +4130,8 @@ static inline int tcp_sack_extend(struct tcp_sack_block *sp, u32 seq, | |||
| 4133 | static void tcp_dsack_set(struct sock *sk, u32 seq, u32 end_seq) | 4130 | static void tcp_dsack_set(struct sock *sk, u32 seq, u32 end_seq) |
| 4134 | { | 4131 | { |
| 4135 | struct tcp_sock *tp = tcp_sk(sk); | 4132 | struct tcp_sock *tp = tcp_sk(sk); |
| 4136 | struct dst_entry *dst = __sk_dst_get(sk); | ||
| 4137 | 4133 | ||
| 4138 | if (tcp_is_sack(tp) && sysctl_tcp_dsack && | 4134 | if (tcp_is_sack(tp) && sysctl_tcp_dsack) { |
| 4139 | !dst_feature(dst, RTAX_FEATURE_NO_DSACK)) { | ||
| 4140 | int mib_idx; | 4135 | int mib_idx; |
| 4141 | 4136 | ||
| 4142 | if (before(seq, tp->rcv_nxt)) | 4137 | if (before(seq, tp->rcv_nxt)) |
| @@ -4165,15 +4160,13 @@ static void tcp_dsack_extend(struct sock *sk, u32 seq, u32 end_seq) | |||
| 4165 | static void tcp_send_dupack(struct sock *sk, struct sk_buff *skb) | 4160 | static void tcp_send_dupack(struct sock *sk, struct sk_buff *skb) |
| 4166 | { | 4161 | { |
| 4167 | struct tcp_sock *tp = tcp_sk(sk); | 4162 | struct tcp_sock *tp = tcp_sk(sk); |
| 4168 | struct dst_entry *dst = __sk_dst_get(sk); | ||
| 4169 | 4163 | ||
| 4170 | if (TCP_SKB_CB(skb)->end_seq != TCP_SKB_CB(skb)->seq && | 4164 | if (TCP_SKB_CB(skb)->end_seq != TCP_SKB_CB(skb)->seq && |
| 4171 | before(TCP_SKB_CB(skb)->seq, tp->rcv_nxt)) { | 4165 | before(TCP_SKB_CB(skb)->seq, tp->rcv_nxt)) { |
| 4172 | NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_DELAYEDACKLOST); | 4166 | NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_DELAYEDACKLOST); |
| 4173 | tcp_enter_quickack_mode(sk); | 4167 | tcp_enter_quickack_mode(sk); |
| 4174 | 4168 | ||
| 4175 | if (tcp_is_sack(tp) && sysctl_tcp_dsack && | 4169 | if (tcp_is_sack(tp) && sysctl_tcp_dsack) { |
| 4176 | !dst_feature(dst, RTAX_FEATURE_NO_DSACK)) { | ||
| 4177 | u32 end_seq = TCP_SKB_CB(skb)->end_seq; | 4170 | u32 end_seq = TCP_SKB_CB(skb)->end_seq; |
| 4178 | 4171 | ||
| 4179 | if (after(TCP_SKB_CB(skb)->end_seq, tp->rcv_nxt)) | 4172 | if (after(TCP_SKB_CB(skb)->end_seq, tp->rcv_nxt)) |
| @@ -5428,11 +5421,10 @@ static int tcp_rcv_synsent_state_process(struct sock *sk, struct sk_buff *skb, | |||
| 5428 | u8 *hash_location; | 5421 | u8 *hash_location; |
| 5429 | struct inet_connection_sock *icsk = inet_csk(sk); | 5422 | struct inet_connection_sock *icsk = inet_csk(sk); |
| 5430 | struct tcp_sock *tp = tcp_sk(sk); | 5423 | struct tcp_sock *tp = tcp_sk(sk); |
| 5431 | struct dst_entry *dst = __sk_dst_get(sk); | ||
| 5432 | struct tcp_cookie_values *cvp = tp->cookie_values; | 5424 | struct tcp_cookie_values *cvp = tp->cookie_values; |
| 5433 | int saved_clamp = tp->rx_opt.mss_clamp; | 5425 | int saved_clamp = tp->rx_opt.mss_clamp; |
| 5434 | 5426 | ||
| 5435 | tcp_parse_options(skb, &tp->rx_opt, &hash_location, 0, dst); | 5427 | tcp_parse_options(skb, &tp->rx_opt, &hash_location, 0); |
| 5436 | 5428 | ||
| 5437 | if (th->ack) { | 5429 | if (th->ack) { |
| 5438 | /* rfc793: | 5430 | /* rfc793: |
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 15e96030ce47..65b8ebfd078a 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c | |||
| @@ -1262,20 +1262,10 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 1262 | tcp_rsk(req)->af_specific = &tcp_request_sock_ipv4_ops; | 1262 | tcp_rsk(req)->af_specific = &tcp_request_sock_ipv4_ops; |
| 1263 | #endif | 1263 | #endif |
| 1264 | 1264 | ||
| 1265 | ireq = inet_rsk(req); | ||
| 1266 | ireq->loc_addr = daddr; | ||
| 1267 | ireq->rmt_addr = saddr; | ||
| 1268 | ireq->no_srccheck = inet_sk(sk)->transparent; | ||
| 1269 | ireq->opt = tcp_v4_save_options(sk, skb); | ||
| 1270 | |||
| 1271 | dst = inet_csk_route_req(sk, req); | ||
| 1272 | if(!dst) | ||
| 1273 | goto drop_and_free; | ||
| 1274 | |||
| 1275 | tcp_clear_options(&tmp_opt); | 1265 | tcp_clear_options(&tmp_opt); |
| 1276 | tmp_opt.mss_clamp = TCP_MSS_DEFAULT; | 1266 | tmp_opt.mss_clamp = TCP_MSS_DEFAULT; |
| 1277 | tmp_opt.user_mss = tp->rx_opt.user_mss; | 1267 | tmp_opt.user_mss = tp->rx_opt.user_mss; |
| 1278 | tcp_parse_options(skb, &tmp_opt, &hash_location, 0, dst); | 1268 | tcp_parse_options(skb, &tmp_opt, &hash_location, 0); |
| 1279 | 1269 | ||
| 1280 | if (tmp_opt.cookie_plus > 0 && | 1270 | if (tmp_opt.cookie_plus > 0 && |
| 1281 | tmp_opt.saw_tstamp && | 1271 | tmp_opt.saw_tstamp && |
| @@ -1319,8 +1309,14 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 1319 | tmp_opt.tstamp_ok = tmp_opt.saw_tstamp; | 1309 | tmp_opt.tstamp_ok = tmp_opt.saw_tstamp; |
| 1320 | tcp_openreq_init(req, &tmp_opt, skb); | 1310 | tcp_openreq_init(req, &tmp_opt, skb); |
| 1321 | 1311 | ||
| 1312 | ireq = inet_rsk(req); | ||
| 1313 | ireq->loc_addr = daddr; | ||
| 1314 | ireq->rmt_addr = saddr; | ||
| 1315 | ireq->no_srccheck = inet_sk(sk)->transparent; | ||
| 1316 | ireq->opt = tcp_v4_save_options(sk, skb); | ||
| 1317 | |||
| 1322 | if (security_inet_conn_request(sk, skb, req)) | 1318 | if (security_inet_conn_request(sk, skb, req)) |
| 1323 | goto drop_and_release; | 1319 | goto drop_and_free; |
| 1324 | 1320 | ||
| 1325 | if (!want_cookie) | 1321 | if (!want_cookie) |
| 1326 | TCP_ECN_create_request(req, tcp_hdr(skb)); | 1322 | TCP_ECN_create_request(req, tcp_hdr(skb)); |
| @@ -1345,6 +1341,7 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 1345 | */ | 1341 | */ |
| 1346 | if (tmp_opt.saw_tstamp && | 1342 | if (tmp_opt.saw_tstamp && |
| 1347 | tcp_death_row.sysctl_tw_recycle && | 1343 | tcp_death_row.sysctl_tw_recycle && |
| 1344 | (dst = inet_csk_route_req(sk, req)) != NULL && | ||
| 1348 | (peer = rt_get_peer((struct rtable *)dst)) != NULL && | 1345 | (peer = rt_get_peer((struct rtable *)dst)) != NULL && |
| 1349 | peer->v4daddr == saddr) { | 1346 | peer->v4daddr == saddr) { |
| 1350 | if ((u32)get_seconds() - peer->tcp_ts_stamp < TCP_PAWS_MSL && | 1347 | if ((u32)get_seconds() - peer->tcp_ts_stamp < TCP_PAWS_MSL && |
diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c index 87accec8d097..f206ee5dda80 100644 --- a/net/ipv4/tcp_minisocks.c +++ b/net/ipv4/tcp_minisocks.c | |||
| @@ -95,9 +95,9 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb, | |||
| 95 | struct tcp_timewait_sock *tcptw = tcp_twsk((struct sock *)tw); | 95 | struct tcp_timewait_sock *tcptw = tcp_twsk((struct sock *)tw); |
| 96 | int paws_reject = 0; | 96 | int paws_reject = 0; |
| 97 | 97 | ||
| 98 | tmp_opt.saw_tstamp = 0; | ||
| 98 | if (th->doff > (sizeof(*th) >> 2) && tcptw->tw_ts_recent_stamp) { | 99 | if (th->doff > (sizeof(*th) >> 2) && tcptw->tw_ts_recent_stamp) { |
| 99 | tmp_opt.tstamp_ok = 1; | 100 | tcp_parse_options(skb, &tmp_opt, &hash_location, 0); |
| 100 | tcp_parse_options(skb, &tmp_opt, &hash_location, 1, NULL); | ||
| 101 | 101 | ||
| 102 | if (tmp_opt.saw_tstamp) { | 102 | if (tmp_opt.saw_tstamp) { |
| 103 | tmp_opt.ts_recent = tcptw->tw_ts_recent; | 103 | tmp_opt.ts_recent = tcptw->tw_ts_recent; |
| @@ -526,9 +526,9 @@ struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb, | |||
| 526 | __be32 flg = tcp_flag_word(th) & (TCP_FLAG_RST|TCP_FLAG_SYN|TCP_FLAG_ACK); | 526 | __be32 flg = tcp_flag_word(th) & (TCP_FLAG_RST|TCP_FLAG_SYN|TCP_FLAG_ACK); |
| 527 | int paws_reject = 0; | 527 | int paws_reject = 0; |
| 528 | 528 | ||
| 529 | if ((th->doff > (sizeof(*th) >> 2)) && (req->ts_recent)) { | 529 | tmp_opt.saw_tstamp = 0; |
| 530 | tmp_opt.tstamp_ok = 1; | 530 | if (th->doff > (sizeof(struct tcphdr)>>2)) { |
| 531 | tcp_parse_options(skb, &tmp_opt, &hash_location, 1, NULL); | 531 | tcp_parse_options(skb, &tmp_opt, &hash_location, 0); |
| 532 | 532 | ||
| 533 | if (tmp_opt.saw_tstamp) { | 533 | if (tmp_opt.saw_tstamp) { |
| 534 | tmp_opt.ts_recent = req->ts_recent; | 534 | tmp_opt.ts_recent = req->ts_recent; |
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 93316a96d820..383ce237640f 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c | |||
| @@ -553,7 +553,6 @@ static unsigned tcp_syn_options(struct sock *sk, struct sk_buff *skb, | |||
| 553 | struct tcp_md5sig_key **md5) { | 553 | struct tcp_md5sig_key **md5) { |
| 554 | struct tcp_sock *tp = tcp_sk(sk); | 554 | struct tcp_sock *tp = tcp_sk(sk); |
| 555 | struct tcp_cookie_values *cvp = tp->cookie_values; | 555 | struct tcp_cookie_values *cvp = tp->cookie_values; |
| 556 | struct dst_entry *dst = __sk_dst_get(sk); | ||
| 557 | unsigned remaining = MAX_TCP_OPTION_SPACE; | 556 | unsigned remaining = MAX_TCP_OPTION_SPACE; |
| 558 | u8 cookie_size = (!tp->rx_opt.cookie_out_never && cvp != NULL) ? | 557 | u8 cookie_size = (!tp->rx_opt.cookie_out_never && cvp != NULL) ? |
| 559 | tcp_cookie_size_check(cvp->cookie_desired) : | 558 | tcp_cookie_size_check(cvp->cookie_desired) : |
| @@ -581,22 +580,18 @@ static unsigned tcp_syn_options(struct sock *sk, struct sk_buff *skb, | |||
| 581 | opts->mss = tcp_advertise_mss(sk); | 580 | opts->mss = tcp_advertise_mss(sk); |
| 582 | remaining -= TCPOLEN_MSS_ALIGNED; | 581 | remaining -= TCPOLEN_MSS_ALIGNED; |
| 583 | 582 | ||
| 584 | if (likely(sysctl_tcp_timestamps && | 583 | if (likely(sysctl_tcp_timestamps && *md5 == NULL)) { |
| 585 | !dst_feature(dst, RTAX_FEATURE_NO_TSTAMP) && | ||
| 586 | *md5 == NULL)) { | ||
| 587 | opts->options |= OPTION_TS; | 584 | opts->options |= OPTION_TS; |
| 588 | opts->tsval = TCP_SKB_CB(skb)->when; | 585 | opts->tsval = TCP_SKB_CB(skb)->when; |
| 589 | opts->tsecr = tp->rx_opt.ts_recent; | 586 | opts->tsecr = tp->rx_opt.ts_recent; |
| 590 | remaining -= TCPOLEN_TSTAMP_ALIGNED; | 587 | remaining -= TCPOLEN_TSTAMP_ALIGNED; |
| 591 | } | 588 | } |
| 592 | if (likely(sysctl_tcp_window_scaling && | 589 | if (likely(sysctl_tcp_window_scaling)) { |
| 593 | !dst_feature(dst, RTAX_FEATURE_NO_WSCALE))) { | ||
| 594 | opts->ws = tp->rx_opt.rcv_wscale; | 590 | opts->ws = tp->rx_opt.rcv_wscale; |
| 595 | opts->options |= OPTION_WSCALE; | 591 | opts->options |= OPTION_WSCALE; |
| 596 | remaining -= TCPOLEN_WSCALE_ALIGNED; | 592 | remaining -= TCPOLEN_WSCALE_ALIGNED; |
| 597 | } | 593 | } |
| 598 | if (likely(sysctl_tcp_sack && | 594 | if (likely(sysctl_tcp_sack)) { |
| 599 | !dst_feature(dst, RTAX_FEATURE_NO_SACK))) { | ||
| 600 | opts->options |= OPTION_SACK_ADVERTISE; | 595 | opts->options |= OPTION_SACK_ADVERTISE; |
| 601 | if (unlikely(!(OPTION_TS & opts->options))) | 596 | if (unlikely(!(OPTION_TS & opts->options))) |
| 602 | remaining -= TCPOLEN_SACKPERM_ALIGNED; | 597 | remaining -= TCPOLEN_SACKPERM_ALIGNED; |
| @@ -2527,9 +2522,7 @@ static void tcp_connect_init(struct sock *sk) | |||
| 2527 | * See tcp_input.c:tcp_rcv_state_process case TCP_SYN_SENT. | 2522 | * See tcp_input.c:tcp_rcv_state_process case TCP_SYN_SENT. |
| 2528 | */ | 2523 | */ |
| 2529 | tp->tcp_header_len = sizeof(struct tcphdr) + | 2524 | tp->tcp_header_len = sizeof(struct tcphdr) + |
| 2530 | (sysctl_tcp_timestamps && | 2525 | (sysctl_tcp_timestamps ? TCPOLEN_TSTAMP_ALIGNED : 0); |
| 2531 | (!dst_feature(dst, RTAX_FEATURE_NO_TSTAMP) ? | ||
| 2532 | TCPOLEN_TSTAMP_ALIGNED : 0)); | ||
| 2533 | 2526 | ||
| 2534 | #ifdef CONFIG_TCP_MD5SIG | 2527 | #ifdef CONFIG_TCP_MD5SIG |
| 2535 | if (tp->af_specific->md5_lookup(sk, sk) != NULL) | 2528 | if (tp->af_specific->md5_lookup(sk, sk) != NULL) |
| @@ -2555,8 +2548,7 @@ static void tcp_connect_init(struct sock *sk) | |||
| 2555 | tp->advmss - (tp->rx_opt.ts_recent_stamp ? tp->tcp_header_len - sizeof(struct tcphdr) : 0), | 2548 | tp->advmss - (tp->rx_opt.ts_recent_stamp ? tp->tcp_header_len - sizeof(struct tcphdr) : 0), |
| 2556 | &tp->rcv_wnd, | 2549 | &tp->rcv_wnd, |
| 2557 | &tp->window_clamp, | 2550 | &tp->window_clamp, |
| 2558 | (sysctl_tcp_window_scaling && | 2551 | sysctl_tcp_window_scaling, |
| 2559 | !dst_feature(dst, RTAX_FEATURE_NO_WSCALE)), | ||
| 2560 | &rcv_wscale); | 2552 | &rcv_wscale); |
| 2561 | 2553 | ||
| 2562 | tp->rx_opt.rcv_wscale = rcv_wscale; | 2554 | tp->rx_opt.rcv_wscale = rcv_wscale; |
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 1f9534846ca9..f0126fdd7e04 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c | |||
| @@ -216,9 +216,8 @@ int udp_lib_get_port(struct sock *sk, unsigned short snum, | |||
| 216 | * force rand to be an odd multiple of UDP_HTABLE_SIZE | 216 | * force rand to be an odd multiple of UDP_HTABLE_SIZE |
| 217 | */ | 217 | */ |
| 218 | rand = (rand | 1) * (udptable->mask + 1); | 218 | rand = (rand | 1) * (udptable->mask + 1); |
| 219 | for (last = first + udptable->mask + 1; | 219 | last = first + udptable->mask + 1; |
| 220 | first != last; | 220 | do { |
| 221 | first++) { | ||
| 222 | hslot = udp_hashslot(udptable, net, first); | 221 | hslot = udp_hashslot(udptable, net, first); |
| 223 | bitmap_zero(bitmap, PORTS_PER_CHAIN); | 222 | bitmap_zero(bitmap, PORTS_PER_CHAIN); |
| 224 | spin_lock_bh(&hslot->lock); | 223 | spin_lock_bh(&hslot->lock); |
| @@ -238,7 +237,7 @@ int udp_lib_get_port(struct sock *sk, unsigned short snum, | |||
| 238 | snum += rand; | 237 | snum += rand; |
| 239 | } while (snum != first); | 238 | } while (snum != first); |
| 240 | spin_unlock_bh(&hslot->lock); | 239 | spin_unlock_bh(&hslot->lock); |
| 241 | } | 240 | } while (++first != last); |
| 242 | goto fail; | 241 | goto fail; |
| 243 | } else { | 242 | } else { |
| 244 | hslot = udp_hashslot(udptable, net, snum); | 243 | hslot = udp_hashslot(udptable, net, snum); |
diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c index 5f2ec208a8c3..0956ebabbff2 100644 --- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c +++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c | |||
| @@ -20,6 +20,7 @@ | |||
| 20 | #include <net/ipv6.h> | 20 | #include <net/ipv6.h> |
| 21 | #include <net/inet_frag.h> | 21 | #include <net/inet_frag.h> |
| 22 | 22 | ||
| 23 | #include <linux/netfilter_bridge.h> | ||
| 23 | #include <linux/netfilter_ipv6.h> | 24 | #include <linux/netfilter_ipv6.h> |
| 24 | #include <net/netfilter/nf_conntrack.h> | 25 | #include <net/netfilter/nf_conntrack.h> |
| 25 | #include <net/netfilter/nf_conntrack_helper.h> | 26 | #include <net/netfilter/nf_conntrack_helper.h> |
| @@ -187,6 +188,21 @@ out: | |||
| 187 | return nf_conntrack_confirm(skb); | 188 | return nf_conntrack_confirm(skb); |
| 188 | } | 189 | } |
| 189 | 190 | ||
| 191 | static enum ip6_defrag_users nf_ct6_defrag_user(unsigned int hooknum, | ||
| 192 | struct sk_buff *skb) | ||
| 193 | { | ||
| 194 | #ifdef CONFIG_BRIDGE_NETFILTER | ||
| 195 | if (skb->nf_bridge && | ||
| 196 | skb->nf_bridge->mask & BRNF_NF_BRIDGE_PREROUTING) | ||
| 197 | return IP6_DEFRAG_CONNTRACK_BRIDGE_IN; | ||
| 198 | #endif | ||
| 199 | if (hooknum == NF_INET_PRE_ROUTING) | ||
| 200 | return IP6_DEFRAG_CONNTRACK_IN; | ||
| 201 | else | ||
| 202 | return IP6_DEFRAG_CONNTRACK_OUT; | ||
| 203 | |||
| 204 | } | ||
| 205 | |||
| 190 | static unsigned int ipv6_defrag(unsigned int hooknum, | 206 | static unsigned int ipv6_defrag(unsigned int hooknum, |
| 191 | struct sk_buff *skb, | 207 | struct sk_buff *skb, |
| 192 | const struct net_device *in, | 208 | const struct net_device *in, |
| @@ -199,8 +215,7 @@ static unsigned int ipv6_defrag(unsigned int hooknum, | |||
| 199 | if (skb->nfct) | 215 | if (skb->nfct) |
| 200 | return NF_ACCEPT; | 216 | return NF_ACCEPT; |
| 201 | 217 | ||
| 202 | reasm = nf_ct_frag6_gather(skb); | 218 | reasm = nf_ct_frag6_gather(skb, nf_ct6_defrag_user(hooknum, skb)); |
| 203 | |||
| 204 | /* queued */ | 219 | /* queued */ |
| 205 | if (reasm == NULL) | 220 | if (reasm == NULL) |
| 206 | return NF_STOLEN; | 221 | return NF_STOLEN; |
diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c index e0b9424fa1b2..312c20adc83f 100644 --- a/net/ipv6/netfilter/nf_conntrack_reasm.c +++ b/net/ipv6/netfilter/nf_conntrack_reasm.c | |||
| @@ -168,13 +168,14 @@ out: | |||
| 168 | /* Creation primitives. */ | 168 | /* Creation primitives. */ |
| 169 | 169 | ||
| 170 | static __inline__ struct nf_ct_frag6_queue * | 170 | static __inline__ struct nf_ct_frag6_queue * |
| 171 | fq_find(__be32 id, struct in6_addr *src, struct in6_addr *dst) | 171 | fq_find(__be32 id, u32 user, struct in6_addr *src, struct in6_addr *dst) |
| 172 | { | 172 | { |
| 173 | struct inet_frag_queue *q; | 173 | struct inet_frag_queue *q; |
| 174 | struct ip6_create_arg arg; | 174 | struct ip6_create_arg arg; |
| 175 | unsigned int hash; | 175 | unsigned int hash; |
| 176 | 176 | ||
| 177 | arg.id = id; | 177 | arg.id = id; |
| 178 | arg.user = user; | ||
| 178 | arg.src = src; | 179 | arg.src = src; |
| 179 | arg.dst = dst; | 180 | arg.dst = dst; |
| 180 | 181 | ||
| @@ -559,7 +560,7 @@ find_prev_fhdr(struct sk_buff *skb, u8 *prevhdrp, int *prevhoff, int *fhoff) | |||
| 559 | return 0; | 560 | return 0; |
| 560 | } | 561 | } |
| 561 | 562 | ||
| 562 | struct sk_buff *nf_ct_frag6_gather(struct sk_buff *skb) | 563 | struct sk_buff *nf_ct_frag6_gather(struct sk_buff *skb, u32 user) |
| 563 | { | 564 | { |
| 564 | struct sk_buff *clone; | 565 | struct sk_buff *clone; |
| 565 | struct net_device *dev = skb->dev; | 566 | struct net_device *dev = skb->dev; |
| @@ -605,7 +606,7 @@ struct sk_buff *nf_ct_frag6_gather(struct sk_buff *skb) | |||
| 605 | if (atomic_read(&nf_init_frags.mem) > nf_init_frags.high_thresh) | 606 | if (atomic_read(&nf_init_frags.mem) > nf_init_frags.high_thresh) |
| 606 | nf_ct_frag6_evictor(); | 607 | nf_ct_frag6_evictor(); |
| 607 | 608 | ||
| 608 | fq = fq_find(fhdr->identification, &hdr->saddr, &hdr->daddr); | 609 | fq = fq_find(fhdr->identification, user, &hdr->saddr, &hdr->daddr); |
| 609 | if (fq == NULL) { | 610 | if (fq == NULL) { |
| 610 | pr_debug("Can't find and can't create new queue\n"); | 611 | pr_debug("Can't find and can't create new queue\n"); |
| 611 | goto ret_orig; | 612 | goto ret_orig; |
diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c index 4d98549a6868..3b3a95607125 100644 --- a/net/ipv6/reassembly.c +++ b/net/ipv6/reassembly.c | |||
| @@ -72,6 +72,7 @@ struct frag_queue | |||
| 72 | struct inet_frag_queue q; | 72 | struct inet_frag_queue q; |
| 73 | 73 | ||
| 74 | __be32 id; /* fragment id */ | 74 | __be32 id; /* fragment id */ |
| 75 | u32 user; | ||
| 75 | struct in6_addr saddr; | 76 | struct in6_addr saddr; |
| 76 | struct in6_addr daddr; | 77 | struct in6_addr daddr; |
| 77 | 78 | ||
| @@ -141,7 +142,7 @@ int ip6_frag_match(struct inet_frag_queue *q, void *a) | |||
| 141 | struct ip6_create_arg *arg = a; | 142 | struct ip6_create_arg *arg = a; |
| 142 | 143 | ||
| 143 | fq = container_of(q, struct frag_queue, q); | 144 | fq = container_of(q, struct frag_queue, q); |
| 144 | return (fq->id == arg->id && | 145 | return (fq->id == arg->id && fq->user == arg->user && |
| 145 | ipv6_addr_equal(&fq->saddr, arg->src) && | 146 | ipv6_addr_equal(&fq->saddr, arg->src) && |
| 146 | ipv6_addr_equal(&fq->daddr, arg->dst)); | 147 | ipv6_addr_equal(&fq->daddr, arg->dst)); |
| 147 | } | 148 | } |
| @@ -163,6 +164,7 @@ void ip6_frag_init(struct inet_frag_queue *q, void *a) | |||
| 163 | struct ip6_create_arg *arg = a; | 164 | struct ip6_create_arg *arg = a; |
| 164 | 165 | ||
| 165 | fq->id = arg->id; | 166 | fq->id = arg->id; |
| 167 | fq->user = arg->user; | ||
| 166 | ipv6_addr_copy(&fq->saddr, arg->src); | 168 | ipv6_addr_copy(&fq->saddr, arg->src); |
| 167 | ipv6_addr_copy(&fq->daddr, arg->dst); | 169 | ipv6_addr_copy(&fq->daddr, arg->dst); |
| 168 | } | 170 | } |
| @@ -243,6 +245,7 @@ fq_find(struct net *net, __be32 id, struct in6_addr *src, struct in6_addr *dst, | |||
| 243 | unsigned int hash; | 245 | unsigned int hash; |
| 244 | 246 | ||
| 245 | arg.id = id; | 247 | arg.id = id; |
| 248 | arg.user = IP6_DEFRAG_LOCAL_DELIVER; | ||
| 246 | arg.src = src; | 249 | arg.src = src; |
| 247 | arg.dst = dst; | 250 | arg.dst = dst; |
| 248 | 251 | ||
diff --git a/net/ipv6/syncookies.c b/net/ipv6/syncookies.c index 5b9af508b8f2..7208a06576c6 100644 --- a/net/ipv6/syncookies.c +++ b/net/ipv6/syncookies.c | |||
| @@ -185,6 +185,13 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb) | |||
| 185 | 185 | ||
| 186 | NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_SYNCOOKIESRECV); | 186 | NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_SYNCOOKIESRECV); |
| 187 | 187 | ||
| 188 | /* check for timestamp cookie support */ | ||
| 189 | memset(&tcp_opt, 0, sizeof(tcp_opt)); | ||
| 190 | tcp_parse_options(skb, &tcp_opt, &hash_location, 0); | ||
| 191 | |||
| 192 | if (tcp_opt.saw_tstamp) | ||
| 193 | cookie_check_timestamp(&tcp_opt); | ||
| 194 | |||
| 188 | ret = NULL; | 195 | ret = NULL; |
| 189 | req = inet6_reqsk_alloc(&tcp6_request_sock_ops); | 196 | req = inet6_reqsk_alloc(&tcp6_request_sock_ops); |
| 190 | if (!req) | 197 | if (!req) |
| @@ -218,6 +225,12 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb) | |||
| 218 | req->expires = 0UL; | 225 | req->expires = 0UL; |
| 219 | req->retrans = 0; | 226 | req->retrans = 0; |
| 220 | ireq->ecn_ok = 0; | 227 | ireq->ecn_ok = 0; |
| 228 | ireq->snd_wscale = tcp_opt.snd_wscale; | ||
| 229 | ireq->rcv_wscale = tcp_opt.rcv_wscale; | ||
| 230 | ireq->sack_ok = tcp_opt.sack_ok; | ||
| 231 | ireq->wscale_ok = tcp_opt.wscale_ok; | ||
| 232 | ireq->tstamp_ok = tcp_opt.saw_tstamp; | ||
| 233 | req->ts_recent = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsval : 0; | ||
| 221 | treq->rcv_isn = ntohl(th->seq) - 1; | 234 | treq->rcv_isn = ntohl(th->seq) - 1; |
| 222 | treq->snt_isn = cookie; | 235 | treq->snt_isn = cookie; |
| 223 | 236 | ||
| @@ -253,21 +266,6 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb) | |||
| 253 | goto out_free; | 266 | goto out_free; |
| 254 | } | 267 | } |
| 255 | 268 | ||
| 256 | /* check for timestamp cookie support */ | ||
| 257 | memset(&tcp_opt, 0, sizeof(tcp_opt)); | ||
| 258 | tcp_parse_options(skb, &tcp_opt, &hash_location, 0, dst); | ||
| 259 | |||
| 260 | if (tcp_opt.saw_tstamp) | ||
| 261 | cookie_check_timestamp(&tcp_opt); | ||
| 262 | |||
| 263 | req->ts_recent = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsval : 0; | ||
| 264 | |||
| 265 | ireq->snd_wscale = tcp_opt.snd_wscale; | ||
| 266 | ireq->rcv_wscale = tcp_opt.rcv_wscale; | ||
| 267 | ireq->sack_ok = tcp_opt.sack_ok; | ||
| 268 | ireq->wscale_ok = tcp_opt.wscale_ok; | ||
| 269 | ireq->tstamp_ok = tcp_opt.saw_tstamp; | ||
| 270 | |||
| 271 | req->window_clamp = tp->window_clamp ? :dst_metric(dst, RTAX_WINDOW); | 269 | req->window_clamp = tp->window_clamp ? :dst_metric(dst, RTAX_WINDOW); |
| 272 | tcp_select_initial_window(tcp_full_space(sk), req->mss, | 270 | tcp_select_initial_window(tcp_full_space(sk), req->mss, |
| 273 | &req->rcv_wnd, &req->window_clamp, | 271 | &req->rcv_wnd, &req->window_clamp, |
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index ee9cf62458d4..febfd595a40d 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c | |||
| @@ -1169,7 +1169,6 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 1169 | struct inet6_request_sock *treq; | 1169 | struct inet6_request_sock *treq; |
| 1170 | struct ipv6_pinfo *np = inet6_sk(sk); | 1170 | struct ipv6_pinfo *np = inet6_sk(sk); |
| 1171 | struct tcp_sock *tp = tcp_sk(sk); | 1171 | struct tcp_sock *tp = tcp_sk(sk); |
| 1172 | struct dst_entry *dst = __sk_dst_get(sk); | ||
| 1173 | __u32 isn = TCP_SKB_CB(skb)->when; | 1172 | __u32 isn = TCP_SKB_CB(skb)->when; |
| 1174 | #ifdef CONFIG_SYN_COOKIES | 1173 | #ifdef CONFIG_SYN_COOKIES |
| 1175 | int want_cookie = 0; | 1174 | int want_cookie = 0; |
| @@ -1208,7 +1207,7 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 1208 | tcp_clear_options(&tmp_opt); | 1207 | tcp_clear_options(&tmp_opt); |
| 1209 | tmp_opt.mss_clamp = IPV6_MIN_MTU - sizeof(struct tcphdr) - sizeof(struct ipv6hdr); | 1208 | tmp_opt.mss_clamp = IPV6_MIN_MTU - sizeof(struct tcphdr) - sizeof(struct ipv6hdr); |
| 1210 | tmp_opt.user_mss = tp->rx_opt.user_mss; | 1209 | tmp_opt.user_mss = tp->rx_opt.user_mss; |
| 1211 | tcp_parse_options(skb, &tmp_opt, &hash_location, 0, dst); | 1210 | tcp_parse_options(skb, &tmp_opt, &hash_location, 0); |
| 1212 | 1211 | ||
| 1213 | if (tmp_opt.cookie_plus > 0 && | 1212 | if (tmp_opt.cookie_plus > 0 && |
| 1214 | tmp_opt.saw_tstamp && | 1213 | tmp_opt.saw_tstamp && |
diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c index b95699f00545..847ffca40184 100644 --- a/net/netfilter/ipvs/ip_vs_core.c +++ b/net/netfilter/ipvs/ip_vs_core.c | |||
| @@ -1366,6 +1366,7 @@ ip_vs_in(unsigned int hooknum, struct sk_buff *skb, | |||
| 1366 | == sysctl_ip_vs_sync_threshold[0])) || | 1366 | == sysctl_ip_vs_sync_threshold[0])) || |
| 1367 | ((cp->protocol == IPPROTO_TCP) && (cp->old_state != cp->state) && | 1367 | ((cp->protocol == IPPROTO_TCP) && (cp->old_state != cp->state) && |
| 1368 | ((cp->state == IP_VS_TCP_S_FIN_WAIT) || | 1368 | ((cp->state == IP_VS_TCP_S_FIN_WAIT) || |
| 1369 | (cp->state == IP_VS_TCP_S_CLOSE) || | ||
| 1369 | (cp->state == IP_VS_TCP_S_CLOSE_WAIT) || | 1370 | (cp->state == IP_VS_TCP_S_CLOSE_WAIT) || |
| 1370 | (cp->state == IP_VS_TCP_S_TIME_WAIT))))) | 1371 | (cp->state == IP_VS_TCP_S_TIME_WAIT))))) |
| 1371 | ip_vs_sync_conn(cp); | 1372 | ip_vs_sync_conn(cp); |
diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index e55a6861d26f..6bde12da2fe0 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/netfilter/ipvs/ip_vs_ctl.c | |||
| @@ -2714,6 +2714,8 @@ static int ip_vs_genl_parse_service(struct ip_vs_service_user_kern *usvc, | |||
| 2714 | if (!(nla_af && (nla_fwmark || (nla_port && nla_protocol && nla_addr)))) | 2714 | if (!(nla_af && (nla_fwmark || (nla_port && nla_protocol && nla_addr)))) |
| 2715 | return -EINVAL; | 2715 | return -EINVAL; |
| 2716 | 2716 | ||
| 2717 | memset(usvc, 0, sizeof(*usvc)); | ||
| 2718 | |||
| 2717 | usvc->af = nla_get_u16(nla_af); | 2719 | usvc->af = nla_get_u16(nla_af); |
| 2718 | #ifdef CONFIG_IP_VS_IPV6 | 2720 | #ifdef CONFIG_IP_VS_IPV6 |
| 2719 | if (usvc->af != AF_INET && usvc->af != AF_INET6) | 2721 | if (usvc->af != AF_INET && usvc->af != AF_INET6) |
| @@ -2901,6 +2903,8 @@ static int ip_vs_genl_parse_dest(struct ip_vs_dest_user_kern *udest, | |||
| 2901 | if (!(nla_addr && nla_port)) | 2903 | if (!(nla_addr && nla_port)) |
| 2902 | return -EINVAL; | 2904 | return -EINVAL; |
| 2903 | 2905 | ||
| 2906 | memset(udest, 0, sizeof(*udest)); | ||
| 2907 | |||
| 2904 | nla_memcpy(&udest->addr, nla_addr, sizeof(udest->addr)); | 2908 | nla_memcpy(&udest->addr, nla_addr, sizeof(udest->addr)); |
| 2905 | udest->port = nla_get_u16(nla_port); | 2909 | udest->port = nla_get_u16(nla_port); |
| 2906 | 2910 | ||
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 020562164b56..e0516a22be2e 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c | |||
| @@ -415,7 +415,7 @@ static int packet_sendmsg_spkt(struct kiocb *iocb, struct socket *sock, | |||
| 415 | { | 415 | { |
| 416 | struct sock *sk = sock->sk; | 416 | struct sock *sk = sock->sk; |
| 417 | struct sockaddr_pkt *saddr = (struct sockaddr_pkt *)msg->msg_name; | 417 | struct sockaddr_pkt *saddr = (struct sockaddr_pkt *)msg->msg_name; |
| 418 | struct sk_buff *skb; | 418 | struct sk_buff *skb = NULL; |
| 419 | struct net_device *dev; | 419 | struct net_device *dev; |
| 420 | __be16 proto = 0; | 420 | __be16 proto = 0; |
| 421 | int err; | 421 | int err; |
| @@ -437,6 +437,7 @@ static int packet_sendmsg_spkt(struct kiocb *iocb, struct socket *sock, | |||
| 437 | */ | 437 | */ |
| 438 | 438 | ||
| 439 | saddr->spkt_device[13] = 0; | 439 | saddr->spkt_device[13] = 0; |
| 440 | retry: | ||
| 440 | rcu_read_lock(); | 441 | rcu_read_lock(); |
| 441 | dev = dev_get_by_name_rcu(sock_net(sk), saddr->spkt_device); | 442 | dev = dev_get_by_name_rcu(sock_net(sk), saddr->spkt_device); |
| 442 | err = -ENODEV; | 443 | err = -ENODEV; |
| @@ -456,58 +457,48 @@ static int packet_sendmsg_spkt(struct kiocb *iocb, struct socket *sock, | |||
| 456 | if (len > dev->mtu + dev->hard_header_len) | 457 | if (len > dev->mtu + dev->hard_header_len) |
| 457 | goto out_unlock; | 458 | goto out_unlock; |
| 458 | 459 | ||
| 459 | err = -ENOBUFS; | 460 | if (!skb) { |
| 460 | skb = sock_wmalloc(sk, len + LL_RESERVED_SPACE(dev), 0, GFP_KERNEL); | 461 | size_t reserved = LL_RESERVED_SPACE(dev); |
| 461 | 462 | unsigned int hhlen = dev->header_ops ? dev->hard_header_len : 0; | |
| 462 | /* | 463 | |
| 463 | * If the write buffer is full, then tough. At this level the user | 464 | rcu_read_unlock(); |
| 464 | * gets to deal with the problem - do your own algorithmic backoffs. | 465 | skb = sock_wmalloc(sk, len + reserved, 0, GFP_KERNEL); |
| 465 | * That's far more flexible. | 466 | if (skb == NULL) |
| 466 | */ | 467 | return -ENOBUFS; |
| 467 | 468 | /* FIXME: Save some space for broken drivers that write a hard | |
| 468 | if (skb == NULL) | 469 | * header at transmission time by themselves. PPP is the notable |
| 469 | goto out_unlock; | 470 | * one here. This should really be fixed at the driver level. |
| 470 | 471 | */ | |
| 471 | /* | 472 | skb_reserve(skb, reserved); |
| 472 | * Fill it in | 473 | skb_reset_network_header(skb); |
| 473 | */ | 474 | |
| 474 | 475 | /* Try to align data part correctly */ | |
| 475 | /* FIXME: Save some space for broken drivers that write a | 476 | if (hhlen) { |
| 476 | * hard header at transmission time by themselves. PPP is the | 477 | skb->data -= hhlen; |
| 477 | * notable one here. This should really be fixed at the driver level. | 478 | skb->tail -= hhlen; |
| 478 | */ | 479 | if (len < hhlen) |
| 479 | skb_reserve(skb, LL_RESERVED_SPACE(dev)); | 480 | skb_reset_network_header(skb); |
| 480 | skb_reset_network_header(skb); | 481 | } |
| 481 | 482 | err = memcpy_fromiovec(skb_put(skb, len), msg->msg_iov, len); | |
| 482 | /* Try to align data part correctly */ | 483 | if (err) |
| 483 | if (dev->header_ops) { | 484 | goto out_free; |
| 484 | skb->data -= dev->hard_header_len; | 485 | goto retry; |
| 485 | skb->tail -= dev->hard_header_len; | ||
| 486 | if (len < dev->hard_header_len) | ||
| 487 | skb_reset_network_header(skb); | ||
| 488 | } | 486 | } |
| 489 | 487 | ||
| 490 | /* Returns -EFAULT on error */ | 488 | |
| 491 | err = memcpy_fromiovec(skb_put(skb, len), msg->msg_iov, len); | ||
| 492 | skb->protocol = proto; | 489 | skb->protocol = proto; |
| 493 | skb->dev = dev; | 490 | skb->dev = dev; |
| 494 | skb->priority = sk->sk_priority; | 491 | skb->priority = sk->sk_priority; |
| 495 | skb->mark = sk->sk_mark; | 492 | skb->mark = sk->sk_mark; |
| 496 | if (err) | ||
| 497 | goto out_free; | ||
| 498 | |||
| 499 | /* | ||
| 500 | * Now send it | ||
| 501 | */ | ||
| 502 | 493 | ||
| 503 | dev_queue_xmit(skb); | 494 | dev_queue_xmit(skb); |
| 504 | rcu_read_unlock(); | 495 | rcu_read_unlock(); |
| 505 | return len; | 496 | return len; |
| 506 | 497 | ||
| 507 | out_free: | ||
| 508 | kfree_skb(skb); | ||
| 509 | out_unlock: | 498 | out_unlock: |
| 510 | rcu_read_unlock(); | 499 | rcu_read_unlock(); |
| 500 | out_free: | ||
| 501 | kfree_skb(skb); | ||
| 511 | return err; | 502 | return err; |
| 512 | } | 503 | } |
| 513 | 504 | ||
diff --git a/net/rds/ib.c b/net/rds/ib.c index 536ebe5d3f6b..3b8992361042 100644 --- a/net/rds/ib.c +++ b/net/rds/ib.c | |||
| @@ -182,8 +182,8 @@ static int rds_ib_conn_info_visitor(struct rds_connection *conn, | |||
| 182 | ic = conn->c_transport_data; | 182 | ic = conn->c_transport_data; |
| 183 | dev_addr = &ic->i_cm_id->route.addr.dev_addr; | 183 | dev_addr = &ic->i_cm_id->route.addr.dev_addr; |
| 184 | 184 | ||
| 185 | ib_addr_get_sgid(dev_addr, (union ib_gid *) &iinfo->src_gid); | 185 | rdma_addr_get_sgid(dev_addr, (union ib_gid *) &iinfo->src_gid); |
| 186 | ib_addr_get_dgid(dev_addr, (union ib_gid *) &iinfo->dst_gid); | 186 | rdma_addr_get_dgid(dev_addr, (union ib_gid *) &iinfo->dst_gid); |
| 187 | 187 | ||
| 188 | rds_ibdev = ib_get_client_data(ic->i_cm_id->device, &rds_ib_client); | 188 | rds_ibdev = ib_get_client_data(ic->i_cm_id->device, &rds_ib_client); |
| 189 | iinfo->max_send_wr = ic->i_send_ring.w_nr; | 189 | iinfo->max_send_wr = ic->i_send_ring.w_nr; |
diff --git a/net/rds/iw.c b/net/rds/iw.c index db224f7c2937..b28fa8525b24 100644 --- a/net/rds/iw.c +++ b/net/rds/iw.c | |||
| @@ -184,8 +184,8 @@ static int rds_iw_conn_info_visitor(struct rds_connection *conn, | |||
| 184 | ic = conn->c_transport_data; | 184 | ic = conn->c_transport_data; |
| 185 | dev_addr = &ic->i_cm_id->route.addr.dev_addr; | 185 | dev_addr = &ic->i_cm_id->route.addr.dev_addr; |
| 186 | 186 | ||
| 187 | ib_addr_get_sgid(dev_addr, (union ib_gid *) &iinfo->src_gid); | 187 | rdma_addr_get_sgid(dev_addr, (union ib_gid *) &iinfo->src_gid); |
| 188 | ib_addr_get_dgid(dev_addr, (union ib_gid *) &iinfo->dst_gid); | 188 | rdma_addr_get_dgid(dev_addr, (union ib_gid *) &iinfo->dst_gid); |
| 189 | 189 | ||
| 190 | rds_iwdev = ib_get_client_data(ic->i_cm_id->device, &rds_iw_client); | 190 | rds_iwdev = ib_get_client_data(ic->i_cm_id->device, &rds_iw_client); |
| 191 | iinfo->max_send_wr = ic->i_send_ring.w_nr; | 191 | iinfo->max_send_wr = ic->i_send_ring.w_nr; |
diff --git a/net/socket.c b/net/socket.c index b94c3dd71015..769c386bd428 100644 --- a/net/socket.c +++ b/net/socket.c | |||
| @@ -312,18 +312,6 @@ static struct file_system_type sock_fs_type = { | |||
| 312 | .kill_sb = kill_anon_super, | 312 | .kill_sb = kill_anon_super, |
| 313 | }; | 313 | }; |
| 314 | 314 | ||
| 315 | static int sockfs_delete_dentry(struct dentry *dentry) | ||
| 316 | { | ||
| 317 | /* | ||
| 318 | * At creation time, we pretended this dentry was hashed | ||
| 319 | * (by clearing DCACHE_UNHASHED bit in d_flags) | ||
| 320 | * At delete time, we restore the truth : not hashed. | ||
| 321 | * (so that dput() can proceed correctly) | ||
| 322 | */ | ||
| 323 | dentry->d_flags |= DCACHE_UNHASHED; | ||
| 324 | return 0; | ||
| 325 | } | ||
| 326 | |||
| 327 | /* | 315 | /* |
| 328 | * sockfs_dname() is called from d_path(). | 316 | * sockfs_dname() is called from d_path(). |
| 329 | */ | 317 | */ |
| @@ -334,7 +322,6 @@ static char *sockfs_dname(struct dentry *dentry, char *buffer, int buflen) | |||
| 334 | } | 322 | } |
| 335 | 323 | ||
| 336 | static const struct dentry_operations sockfs_dentry_operations = { | 324 | static const struct dentry_operations sockfs_dentry_operations = { |
| 337 | .d_delete = sockfs_delete_dentry, | ||
| 338 | .d_dname = sockfs_dname, | 325 | .d_dname = sockfs_dname, |
| 339 | }; | 326 | }; |
| 340 | 327 | ||
| @@ -355,68 +342,55 @@ static const struct dentry_operations sockfs_dentry_operations = { | |||
| 355 | * but we take care of internal coherence yet. | 342 | * but we take care of internal coherence yet. |
| 356 | */ | 343 | */ |
| 357 | 344 | ||
| 358 | static int sock_alloc_fd(struct file **filep, int flags) | 345 | static int sock_alloc_file(struct socket *sock, struct file **f, int flags) |
| 359 | { | 346 | { |
| 347 | struct qstr name = { .name = "" }; | ||
| 348 | struct path path; | ||
| 349 | struct file *file; | ||
| 360 | int fd; | 350 | int fd; |
| 361 | 351 | ||
| 362 | fd = get_unused_fd_flags(flags); | 352 | fd = get_unused_fd_flags(flags); |
| 363 | if (likely(fd >= 0)) { | 353 | if (unlikely(fd < 0)) |
| 364 | struct file *file = get_empty_filp(); | 354 | return fd; |
| 365 | |||
| 366 | *filep = file; | ||
| 367 | if (unlikely(!file)) { | ||
| 368 | put_unused_fd(fd); | ||
| 369 | return -ENFILE; | ||
| 370 | } | ||
| 371 | } else | ||
| 372 | *filep = NULL; | ||
| 373 | return fd; | ||
| 374 | } | ||
| 375 | |||
| 376 | static int sock_attach_fd(struct socket *sock, struct file *file, int flags) | ||
| 377 | { | ||
| 378 | struct dentry *dentry; | ||
| 379 | struct qstr name = { .name = "" }; | ||
| 380 | 355 | ||
| 381 | dentry = d_alloc(sock_mnt->mnt_sb->s_root, &name); | 356 | path.dentry = d_alloc(sock_mnt->mnt_sb->s_root, &name); |
| 382 | if (unlikely(!dentry)) | 357 | if (unlikely(!path.dentry)) { |
| 358 | put_unused_fd(fd); | ||
| 383 | return -ENOMEM; | 359 | return -ENOMEM; |
| 360 | } | ||
| 361 | path.mnt = mntget(sock_mnt); | ||
| 384 | 362 | ||
| 385 | dentry->d_op = &sockfs_dentry_operations; | 363 | path.dentry->d_op = &sockfs_dentry_operations; |
| 386 | /* | 364 | d_instantiate(path.dentry, SOCK_INODE(sock)); |
| 387 | * We dont want to push this dentry into global dentry hash table. | 365 | SOCK_INODE(sock)->i_fop = &socket_file_ops; |
| 388 | * We pretend dentry is already hashed, by unsetting DCACHE_UNHASHED | ||
| 389 | * This permits a working /proc/$pid/fd/XXX on sockets | ||
| 390 | */ | ||
| 391 | dentry->d_flags &= ~DCACHE_UNHASHED; | ||
| 392 | d_instantiate(dentry, SOCK_INODE(sock)); | ||
| 393 | 366 | ||
| 394 | sock->file = file; | 367 | file = alloc_file(&path, FMODE_READ | FMODE_WRITE, |
| 395 | init_file(file, sock_mnt, dentry, FMODE_READ | FMODE_WRITE, | ||
| 396 | &socket_file_ops); | 368 | &socket_file_ops); |
| 397 | SOCK_INODE(sock)->i_fop = &socket_file_ops; | 369 | if (unlikely(!file)) { |
| 370 | /* drop dentry, keep inode */ | ||
| 371 | atomic_inc(&path.dentry->d_inode->i_count); | ||
| 372 | path_put(&path); | ||
| 373 | put_unused_fd(fd); | ||
| 374 | return -ENFILE; | ||
| 375 | } | ||
| 376 | |||
| 377 | sock->file = file; | ||
| 398 | file->f_flags = O_RDWR | (flags & O_NONBLOCK); | 378 | file->f_flags = O_RDWR | (flags & O_NONBLOCK); |
| 399 | file->f_pos = 0; | 379 | file->f_pos = 0; |
| 400 | file->private_data = sock; | 380 | file->private_data = sock; |
| 401 | 381 | ||
| 402 | return 0; | 382 | *f = file; |
| 383 | return fd; | ||
| 403 | } | 384 | } |
| 404 | 385 | ||
| 405 | int sock_map_fd(struct socket *sock, int flags) | 386 | int sock_map_fd(struct socket *sock, int flags) |
| 406 | { | 387 | { |
| 407 | struct file *newfile; | 388 | struct file *newfile; |
| 408 | int fd = sock_alloc_fd(&newfile, flags); | 389 | int fd = sock_alloc_file(sock, &newfile, flags); |
| 409 | 390 | ||
| 410 | if (likely(fd >= 0)) { | 391 | if (likely(fd >= 0)) |
| 411 | int err = sock_attach_fd(sock, newfile, flags); | ||
| 412 | |||
| 413 | if (unlikely(err < 0)) { | ||
| 414 | put_filp(newfile); | ||
| 415 | put_unused_fd(fd); | ||
| 416 | return err; | ||
| 417 | } | ||
| 418 | fd_install(fd, newfile); | 392 | fd_install(fd, newfile); |
| 419 | } | 393 | |
| 420 | return fd; | 394 | return fd; |
| 421 | } | 395 | } |
| 422 | 396 | ||
| @@ -1390,29 +1364,19 @@ SYSCALL_DEFINE4(socketpair, int, family, int, type, int, protocol, | |||
| 1390 | if (err < 0) | 1364 | if (err < 0) |
| 1391 | goto out_release_both; | 1365 | goto out_release_both; |
| 1392 | 1366 | ||
| 1393 | fd1 = sock_alloc_fd(&newfile1, flags & O_CLOEXEC); | 1367 | fd1 = sock_alloc_file(sock1, &newfile1, flags); |
| 1394 | if (unlikely(fd1 < 0)) { | 1368 | if (unlikely(fd1 < 0)) { |
| 1395 | err = fd1; | 1369 | err = fd1; |
| 1396 | goto out_release_both; | 1370 | goto out_release_both; |
| 1397 | } | 1371 | } |
| 1398 | 1372 | ||
| 1399 | fd2 = sock_alloc_fd(&newfile2, flags & O_CLOEXEC); | 1373 | fd2 = sock_alloc_file(sock2, &newfile2, flags); |
| 1400 | if (unlikely(fd2 < 0)) { | 1374 | if (unlikely(fd2 < 0)) { |
| 1401 | err = fd2; | 1375 | err = fd2; |
| 1402 | put_filp(newfile1); | ||
| 1403 | put_unused_fd(fd1); | ||
| 1404 | goto out_release_both; | ||
| 1405 | } | ||
| 1406 | |||
| 1407 | err = sock_attach_fd(sock1, newfile1, flags & O_NONBLOCK); | ||
| 1408 | if (unlikely(err < 0)) { | ||
| 1409 | goto out_fd2; | ||
| 1410 | } | ||
| 1411 | |||
| 1412 | err = sock_attach_fd(sock2, newfile2, flags & O_NONBLOCK); | ||
| 1413 | if (unlikely(err < 0)) { | ||
| 1414 | fput(newfile1); | 1376 | fput(newfile1); |
| 1415 | goto out_fd1; | 1377 | put_unused_fd(fd1); |
| 1378 | sock_release(sock2); | ||
| 1379 | goto out; | ||
| 1416 | } | 1380 | } |
| 1417 | 1381 | ||
| 1418 | audit_fd_pair(fd1, fd2); | 1382 | audit_fd_pair(fd1, fd2); |
| @@ -1438,16 +1402,6 @@ out_release_1: | |||
| 1438 | sock_release(sock1); | 1402 | sock_release(sock1); |
| 1439 | out: | 1403 | out: |
| 1440 | return err; | 1404 | return err; |
| 1441 | |||
| 1442 | out_fd2: | ||
| 1443 | put_filp(newfile1); | ||
| 1444 | sock_release(sock1); | ||
| 1445 | out_fd1: | ||
| 1446 | put_filp(newfile2); | ||
| 1447 | sock_release(sock2); | ||
| 1448 | put_unused_fd(fd1); | ||
| 1449 | put_unused_fd(fd2); | ||
| 1450 | goto out; | ||
| 1451 | } | 1405 | } |
| 1452 | 1406 | ||
| 1453 | /* | 1407 | /* |
| @@ -1551,17 +1505,13 @@ SYSCALL_DEFINE4(accept4, int, fd, struct sockaddr __user *, upeer_sockaddr, | |||
| 1551 | */ | 1505 | */ |
| 1552 | __module_get(newsock->ops->owner); | 1506 | __module_get(newsock->ops->owner); |
| 1553 | 1507 | ||
| 1554 | newfd = sock_alloc_fd(&newfile, flags & O_CLOEXEC); | 1508 | newfd = sock_alloc_file(newsock, &newfile, flags); |
| 1555 | if (unlikely(newfd < 0)) { | 1509 | if (unlikely(newfd < 0)) { |
| 1556 | err = newfd; | 1510 | err = newfd; |
| 1557 | sock_release(newsock); | 1511 | sock_release(newsock); |
| 1558 | goto out_put; | 1512 | goto out_put; |
| 1559 | } | 1513 | } |
| 1560 | 1514 | ||
| 1561 | err = sock_attach_fd(newsock, newfile, flags & O_NONBLOCK); | ||
| 1562 | if (err < 0) | ||
| 1563 | goto out_fd_simple; | ||
| 1564 | |||
| 1565 | err = security_socket_accept(sock, newsock); | 1515 | err = security_socket_accept(sock, newsock); |
| 1566 | if (err) | 1516 | if (err) |
| 1567 | goto out_fd; | 1517 | goto out_fd; |
| @@ -1591,11 +1541,6 @@ out_put: | |||
| 1591 | fput_light(sock->file, fput_needed); | 1541 | fput_light(sock->file, fput_needed); |
| 1592 | out: | 1542 | out: |
| 1593 | return err; | 1543 | return err; |
| 1594 | out_fd_simple: | ||
| 1595 | sock_release(newsock); | ||
| 1596 | put_filp(newfile); | ||
| 1597 | put_unused_fd(newfd); | ||
| 1598 | goto out_put; | ||
| 1599 | out_fd: | 1544 | out_fd: |
| 1600 | fput(newfile); | 1545 | fput(newfile); |
| 1601 | put_unused_fd(newfd); | 1546 | put_unused_fd(newfd); |
diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index cef74ba0666c..aae6907fd546 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c | |||
| @@ -210,6 +210,7 @@ void rpc_init_priority_wait_queue(struct rpc_wait_queue *queue, const char *qnam | |||
| 210 | { | 210 | { |
| 211 | __rpc_init_priority_wait_queue(queue, qname, RPC_NR_PRIORITY); | 211 | __rpc_init_priority_wait_queue(queue, qname, RPC_NR_PRIORITY); |
| 212 | } | 212 | } |
| 213 | EXPORT_SYMBOL_GPL(rpc_init_priority_wait_queue); | ||
| 213 | 214 | ||
| 214 | void rpc_init_wait_queue(struct rpc_wait_queue *queue, const char *qname) | 215 | void rpc_init_wait_queue(struct rpc_wait_queue *queue, const char *qname) |
| 215 | { | 216 | { |
| @@ -385,6 +386,20 @@ static void rpc_wake_up_task_queue_locked(struct rpc_wait_queue *queue, struct r | |||
| 385 | } | 386 | } |
| 386 | 387 | ||
| 387 | /* | 388 | /* |
| 389 | * Tests whether rpc queue is empty | ||
| 390 | */ | ||
| 391 | int rpc_queue_empty(struct rpc_wait_queue *queue) | ||
| 392 | { | ||
| 393 | int res; | ||
| 394 | |||
| 395 | spin_lock_bh(&queue->lock); | ||
| 396 | res = queue->qlen; | ||
| 397 | spin_unlock_bh(&queue->lock); | ||
| 398 | return (res == 0); | ||
| 399 | } | ||
| 400 | EXPORT_SYMBOL_GPL(rpc_queue_empty); | ||
| 401 | |||
| 402 | /* | ||
| 388 | * Wake up a task on a specific queue | 403 | * Wake up a task on a specific queue |
| 389 | */ | 404 | */ |
| 390 | void rpc_wake_up_queued_task(struct rpc_wait_queue *queue, struct rpc_task *task) | 405 | void rpc_wake_up_queued_task(struct rpc_wait_queue *queue, struct rpc_task *task) |
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c index b845e2293dfe..1c924ee0a1ef 100644 --- a/net/sunrpc/svc_xprt.c +++ b/net/sunrpc/svc_xprt.c | |||
| @@ -16,8 +16,6 @@ | |||
| 16 | 16 | ||
| 17 | #define RPCDBG_FACILITY RPCDBG_SVCXPRT | 17 | #define RPCDBG_FACILITY RPCDBG_SVCXPRT |
| 18 | 18 | ||
| 19 | #define SVC_MAX_WAKING 5 | ||
| 20 | |||
| 21 | static struct svc_deferred_req *svc_deferred_dequeue(struct svc_xprt *xprt); | 19 | static struct svc_deferred_req *svc_deferred_dequeue(struct svc_xprt *xprt); |
| 22 | static int svc_deferred_recv(struct svc_rqst *rqstp); | 20 | static int svc_deferred_recv(struct svc_rqst *rqstp); |
| 23 | static struct cache_deferred_req *svc_defer(struct cache_req *req); | 21 | static struct cache_deferred_req *svc_defer(struct cache_req *req); |
| @@ -306,7 +304,6 @@ void svc_xprt_enqueue(struct svc_xprt *xprt) | |||
| 306 | struct svc_pool *pool; | 304 | struct svc_pool *pool; |
| 307 | struct svc_rqst *rqstp; | 305 | struct svc_rqst *rqstp; |
| 308 | int cpu; | 306 | int cpu; |
| 309 | int thread_avail; | ||
| 310 | 307 | ||
| 311 | if (!(xprt->xpt_flags & | 308 | if (!(xprt->xpt_flags & |
| 312 | ((1<<XPT_CONN)|(1<<XPT_DATA)|(1<<XPT_CLOSE)|(1<<XPT_DEFERRED)))) | 309 | ((1<<XPT_CONN)|(1<<XPT_DATA)|(1<<XPT_CLOSE)|(1<<XPT_DEFERRED)))) |
| @@ -318,6 +315,12 @@ void svc_xprt_enqueue(struct svc_xprt *xprt) | |||
| 318 | 315 | ||
| 319 | spin_lock_bh(&pool->sp_lock); | 316 | spin_lock_bh(&pool->sp_lock); |
| 320 | 317 | ||
| 318 | if (!list_empty(&pool->sp_threads) && | ||
| 319 | !list_empty(&pool->sp_sockets)) | ||
| 320 | printk(KERN_ERR | ||
| 321 | "svc_xprt_enqueue: " | ||
| 322 | "threads and transports both waiting??\n"); | ||
| 323 | |||
| 321 | if (test_bit(XPT_DEAD, &xprt->xpt_flags)) { | 324 | if (test_bit(XPT_DEAD, &xprt->xpt_flags)) { |
| 322 | /* Don't enqueue dead transports */ | 325 | /* Don't enqueue dead transports */ |
| 323 | dprintk("svc: transport %p is dead, not enqueued\n", xprt); | 326 | dprintk("svc: transport %p is dead, not enqueued\n", xprt); |
| @@ -358,15 +361,7 @@ void svc_xprt_enqueue(struct svc_xprt *xprt) | |||
| 358 | } | 361 | } |
| 359 | 362 | ||
| 360 | process: | 363 | process: |
| 361 | /* Work out whether threads are available */ | 364 | if (!list_empty(&pool->sp_threads)) { |
| 362 | thread_avail = !list_empty(&pool->sp_threads); /* threads are asleep */ | ||
| 363 | if (pool->sp_nwaking >= SVC_MAX_WAKING) { | ||
| 364 | /* too many threads are runnable and trying to wake up */ | ||
| 365 | thread_avail = 0; | ||
| 366 | pool->sp_stats.overloads_avoided++; | ||
| 367 | } | ||
| 368 | |||
| 369 | if (thread_avail) { | ||
| 370 | rqstp = list_entry(pool->sp_threads.next, | 365 | rqstp = list_entry(pool->sp_threads.next, |
| 371 | struct svc_rqst, | 366 | struct svc_rqst, |
| 372 | rq_list); | 367 | rq_list); |
| @@ -381,8 +376,6 @@ void svc_xprt_enqueue(struct svc_xprt *xprt) | |||
| 381 | svc_xprt_get(xprt); | 376 | svc_xprt_get(xprt); |
| 382 | rqstp->rq_reserved = serv->sv_max_mesg; | 377 | rqstp->rq_reserved = serv->sv_max_mesg; |
| 383 | atomic_add(rqstp->rq_reserved, &xprt->xpt_reserved); | 378 | atomic_add(rqstp->rq_reserved, &xprt->xpt_reserved); |
| 384 | rqstp->rq_waking = 1; | ||
| 385 | pool->sp_nwaking++; | ||
| 386 | pool->sp_stats.threads_woken++; | 379 | pool->sp_stats.threads_woken++; |
| 387 | BUG_ON(xprt->xpt_pool != pool); | 380 | BUG_ON(xprt->xpt_pool != pool); |
| 388 | wake_up(&rqstp->rq_wait); | 381 | wake_up(&rqstp->rq_wait); |
| @@ -651,11 +644,6 @@ int svc_recv(struct svc_rqst *rqstp, long timeout) | |||
| 651 | return -EINTR; | 644 | return -EINTR; |
| 652 | 645 | ||
| 653 | spin_lock_bh(&pool->sp_lock); | 646 | spin_lock_bh(&pool->sp_lock); |
| 654 | if (rqstp->rq_waking) { | ||
| 655 | rqstp->rq_waking = 0; | ||
| 656 | pool->sp_nwaking--; | ||
| 657 | BUG_ON(pool->sp_nwaking < 0); | ||
| 658 | } | ||
| 659 | xprt = svc_xprt_dequeue(pool); | 647 | xprt = svc_xprt_dequeue(pool); |
| 660 | if (xprt) { | 648 | if (xprt) { |
| 661 | rqstp->rq_xprt = xprt; | 649 | rqstp->rq_xprt = xprt; |
| @@ -1204,16 +1192,15 @@ static int svc_pool_stats_show(struct seq_file *m, void *p) | |||
| 1204 | struct svc_pool *pool = p; | 1192 | struct svc_pool *pool = p; |
| 1205 | 1193 | ||
| 1206 | if (p == SEQ_START_TOKEN) { | 1194 | if (p == SEQ_START_TOKEN) { |
| 1207 | seq_puts(m, "# pool packets-arrived sockets-enqueued threads-woken overloads-avoided threads-timedout\n"); | 1195 | seq_puts(m, "# pool packets-arrived sockets-enqueued threads-woken threads-timedout\n"); |
| 1208 | return 0; | 1196 | return 0; |
| 1209 | } | 1197 | } |
| 1210 | 1198 | ||
| 1211 | seq_printf(m, "%u %lu %lu %lu %lu %lu\n", | 1199 | seq_printf(m, "%u %lu %lu %lu %lu\n", |
| 1212 | pool->sp_id, | 1200 | pool->sp_id, |
| 1213 | pool->sp_stats.packets, | 1201 | pool->sp_stats.packets, |
| 1214 | pool->sp_stats.sockets_queued, | 1202 | pool->sp_stats.sockets_queued, |
| 1215 | pool->sp_stats.threads_woken, | 1203 | pool->sp_stats.threads_woken, |
| 1216 | pool->sp_stats.overloads_avoided, | ||
| 1217 | pool->sp_stats.threads_timedout); | 1204 | pool->sp_stats.threads_timedout); |
| 1218 | 1205 | ||
| 1219 | return 0; | 1206 | return 0; |
diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c index 4a8f6558718a..d8c041114497 100644 --- a/net/sunrpc/svcauth_unix.c +++ b/net/sunrpc/svcauth_unix.c | |||
| @@ -655,23 +655,25 @@ static struct unix_gid *unix_gid_lookup(uid_t uid) | |||
| 655 | return NULL; | 655 | return NULL; |
| 656 | } | 656 | } |
| 657 | 657 | ||
| 658 | static int unix_gid_find(uid_t uid, struct group_info **gip, | 658 | static struct group_info *unix_gid_find(uid_t uid, struct svc_rqst *rqstp) |
| 659 | struct svc_rqst *rqstp) | ||
| 660 | { | 659 | { |
| 661 | struct unix_gid *ug = unix_gid_lookup(uid); | 660 | struct unix_gid *ug; |
| 661 | struct group_info *gi; | ||
| 662 | int ret; | ||
| 663 | |||
| 664 | ug = unix_gid_lookup(uid); | ||
| 662 | if (!ug) | 665 | if (!ug) |
| 663 | return -EAGAIN; | 666 | return ERR_PTR(-EAGAIN); |
| 664 | switch (cache_check(&unix_gid_cache, &ug->h, &rqstp->rq_chandle)) { | 667 | ret = cache_check(&unix_gid_cache, &ug->h, &rqstp->rq_chandle); |
| 668 | switch (ret) { | ||
| 665 | case -ENOENT: | 669 | case -ENOENT: |
| 666 | *gip = NULL; | 670 | return ERR_PTR(-ENOENT); |
| 667 | return 0; | ||
| 668 | case 0: | 671 | case 0: |
| 669 | *gip = ug->gi; | 672 | gi = get_group_info(ug->gi); |
| 670 | get_group_info(*gip); | ||
| 671 | cache_put(&ug->h, &unix_gid_cache); | 673 | cache_put(&ug->h, &unix_gid_cache); |
| 672 | return 0; | 674 | return gi; |
| 673 | default: | 675 | default: |
| 674 | return -EAGAIN; | 676 | return ERR_PTR(-EAGAIN); |
| 675 | } | 677 | } |
| 676 | } | 678 | } |
| 677 | 679 | ||
| @@ -681,6 +683,8 @@ svcauth_unix_set_client(struct svc_rqst *rqstp) | |||
| 681 | struct sockaddr_in *sin; | 683 | struct sockaddr_in *sin; |
| 682 | struct sockaddr_in6 *sin6, sin6_storage; | 684 | struct sockaddr_in6 *sin6, sin6_storage; |
| 683 | struct ip_map *ipm; | 685 | struct ip_map *ipm; |
| 686 | struct group_info *gi; | ||
| 687 | struct svc_cred *cred = &rqstp->rq_cred; | ||
| 684 | 688 | ||
| 685 | switch (rqstp->rq_addr.ss_family) { | 689 | switch (rqstp->rq_addr.ss_family) { |
| 686 | case AF_INET: | 690 | case AF_INET: |
| @@ -721,6 +725,17 @@ svcauth_unix_set_client(struct svc_rqst *rqstp) | |||
| 721 | ip_map_cached_put(rqstp, ipm); | 725 | ip_map_cached_put(rqstp, ipm); |
| 722 | break; | 726 | break; |
| 723 | } | 727 | } |
| 728 | |||
| 729 | gi = unix_gid_find(cred->cr_uid, rqstp); | ||
| 730 | switch (PTR_ERR(gi)) { | ||
| 731 | case -EAGAIN: | ||
| 732 | return SVC_DROP; | ||
| 733 | case -ENOENT: | ||
| 734 | break; | ||
| 735 | default: | ||
| 736 | put_group_info(cred->cr_group_info); | ||
| 737 | cred->cr_group_info = gi; | ||
| 738 | } | ||
| 724 | return SVC_OK; | 739 | return SVC_OK; |
| 725 | } | 740 | } |
| 726 | 741 | ||
| @@ -817,19 +832,11 @@ svcauth_unix_accept(struct svc_rqst *rqstp, __be32 *authp) | |||
| 817 | slen = svc_getnl(argv); /* gids length */ | 832 | slen = svc_getnl(argv); /* gids length */ |
| 818 | if (slen > 16 || (len -= (slen + 2)*4) < 0) | 833 | if (slen > 16 || (len -= (slen + 2)*4) < 0) |
| 819 | goto badcred; | 834 | goto badcred; |
| 820 | if (unix_gid_find(cred->cr_uid, &cred->cr_group_info, rqstp) | 835 | cred->cr_group_info = groups_alloc(slen); |
| 821 | == -EAGAIN) | 836 | if (cred->cr_group_info == NULL) |
| 822 | return SVC_DROP; | 837 | return SVC_DROP; |
| 823 | if (cred->cr_group_info == NULL) { | 838 | for (i = 0; i < slen; i++) |
| 824 | cred->cr_group_info = groups_alloc(slen); | 839 | GROUP_AT(cred->cr_group_info, i) = svc_getnl(argv); |
| 825 | if (cred->cr_group_info == NULL) | ||
| 826 | return SVC_DROP; | ||
| 827 | for (i = 0; i < slen; i++) | ||
| 828 | GROUP_AT(cred->cr_group_info, i) = svc_getnl(argv); | ||
| 829 | } else { | ||
| 830 | for (i = 0; i < slen ; i++) | ||
| 831 | svc_getnl(argv); | ||
| 832 | } | ||
| 833 | if (svc_getu32(argv) != htonl(RPC_AUTH_NULL) || svc_getu32(argv) != 0) { | 840 | if (svc_getu32(argv) != htonl(RPC_AUTH_NULL) || svc_getu32(argv) != 0) { |
| 834 | *authp = rpc_autherr_badverf; | 841 | *authp = rpc_autherr_badverf; |
| 835 | return SVC_DENIED; | 842 | return SVC_DENIED; |
