diff options
Diffstat (limited to 'net/tipc')
| -rw-r--r-- | net/tipc/Kconfig | 7 | ||||
| -rw-r--r-- | net/tipc/Makefile | 2 | ||||
| -rw-r--r-- | net/tipc/bcast.c | 40 | ||||
| -rw-r--r-- | net/tipc/bearer.c | 7 | ||||
| -rw-r--r-- | net/tipc/bearer.h | 16 | ||||
| -rw-r--r-- | net/tipc/core.c | 12 | ||||
| -rw-r--r-- | net/tipc/discover.c | 2 | ||||
| -rw-r--r-- | net/tipc/eth_media.c | 39 | ||||
| -rw-r--r-- | net/tipc/ib_media.c | 387 | ||||
| -rw-r--r-- | net/tipc/link.c | 11 | ||||
| -rw-r--r-- | net/tipc/netlink.c | 6 | ||||
| -rw-r--r-- | net/tipc/socket.c | 7 |
12 files changed, 477 insertions, 59 deletions
diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig index 4f99600a5fed..c890848f9d56 100644 --- a/net/tipc/Kconfig +++ b/net/tipc/Kconfig | |||
| @@ -31,3 +31,10 @@ config TIPC_PORTS | |||
| 31 | 31 | ||
| 32 | Setting this to a smaller value saves some memory, | 32 | Setting this to a smaller value saves some memory, |
| 33 | setting it to higher allows for more ports. | 33 | setting it to higher allows for more ports. |
| 34 | |||
| 35 | config TIPC_MEDIA_IB | ||
| 36 | bool "InfiniBand media type support" | ||
| 37 | depends on TIPC && INFINIBAND_IPOIB | ||
| 38 | help | ||
| 39 | Saying Y here will enable support for running TIPC on | ||
| 40 | IP-over-InfiniBand devices. | ||
diff --git a/net/tipc/Makefile b/net/tipc/Makefile index 6cd55d671d3a..4df8e02d9008 100644 --- a/net/tipc/Makefile +++ b/net/tipc/Makefile | |||
| @@ -9,3 +9,5 @@ tipc-y += addr.o bcast.o bearer.o config.o \ | |||
| 9 | name_distr.o subscr.o name_table.o net.o \ | 9 | name_distr.o subscr.o name_table.o net.o \ |
| 10 | netlink.o node.o node_subscr.o port.o ref.o \ | 10 | netlink.o node.o node_subscr.o port.o ref.o \ |
| 11 | socket.o log.o eth_media.o | 11 | socket.o log.o eth_media.o |
| 12 | |||
| 13 | tipc-$(CONFIG_TIPC_MEDIA_IB) += ib_media.o | ||
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index 2655c9f4ecad..e5f3da507823 100644 --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c | |||
| @@ -584,8 +584,7 @@ static int tipc_bcbearer_send(struct sk_buff *buf, | |||
| 584 | { | 584 | { |
| 585 | int bp_index; | 585 | int bp_index; |
| 586 | 586 | ||
| 587 | /* | 587 | /* Prepare broadcast link message for reliable transmission, |
| 588 | * Prepare broadcast link message for reliable transmission, | ||
| 589 | * if first time trying to send it; | 588 | * if first time trying to send it; |
| 590 | * preparation is skipped for broadcast link protocol messages | 589 | * preparation is skipped for broadcast link protocol messages |
| 591 | * since they are sent in an unreliable manner and don't need it | 590 | * since they are sent in an unreliable manner and don't need it |
| @@ -611,30 +610,43 @@ static int tipc_bcbearer_send(struct sk_buff *buf, | |||
| 611 | for (bp_index = 0; bp_index < MAX_BEARERS; bp_index++) { | 610 | for (bp_index = 0; bp_index < MAX_BEARERS; bp_index++) { |
| 612 | struct tipc_bearer *p = bcbearer->bpairs[bp_index].primary; | 611 | struct tipc_bearer *p = bcbearer->bpairs[bp_index].primary; |
| 613 | struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary; | 612 | struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary; |
| 613 | struct tipc_bearer *b = p; | ||
| 614 | struct sk_buff *tbuf; | ||
| 614 | 615 | ||
| 615 | if (!p) | 616 | if (!p) |
| 616 | break; /* no more bearers to try */ | 617 | break; /* No more bearers to try */ |
| 618 | |||
| 619 | if (tipc_bearer_blocked(p)) { | ||
| 620 | if (!s || tipc_bearer_blocked(s)) | ||
| 621 | continue; /* Can't use either bearer */ | ||
| 622 | b = s; | ||
| 623 | } | ||
| 617 | 624 | ||
| 618 | tipc_nmap_diff(&bcbearer->remains, &p->nodes, &bcbearer->remains_new); | 625 | tipc_nmap_diff(&bcbearer->remains, &b->nodes, |
| 626 | &bcbearer->remains_new); | ||
| 619 | if (bcbearer->remains_new.count == bcbearer->remains.count) | 627 | if (bcbearer->remains_new.count == bcbearer->remains.count) |
| 620 | continue; /* bearer pair doesn't add anything */ | 628 | continue; /* Nothing added by bearer pair */ |
| 621 | 629 | ||
| 622 | if (!tipc_bearer_blocked(p)) | 630 | if (bp_index == 0) { |
| 623 | tipc_bearer_send(p, buf, &p->media->bcast_addr); | 631 | /* Use original buffer for first bearer */ |
| 624 | else if (s && !tipc_bearer_blocked(s)) | 632 | tipc_bearer_send(b, buf, &b->bcast_addr); |
| 625 | /* unable to send on primary bearer */ | 633 | } else { |
| 626 | tipc_bearer_send(s, buf, &s->media->bcast_addr); | 634 | /* Avoid concurrent buffer access */ |
| 627 | else | 635 | tbuf = pskb_copy(buf, GFP_ATOMIC); |
| 628 | /* unable to send on either bearer */ | 636 | if (!tbuf) |
| 629 | continue; | 637 | break; |
| 638 | tipc_bearer_send(b, tbuf, &b->bcast_addr); | ||
| 639 | kfree_skb(tbuf); /* Bearer keeps a clone */ | ||
| 640 | } | ||
| 630 | 641 | ||
| 642 | /* Swap bearers for next packet */ | ||
| 631 | if (s) { | 643 | if (s) { |
| 632 | bcbearer->bpairs[bp_index].primary = s; | 644 | bcbearer->bpairs[bp_index].primary = s; |
| 633 | bcbearer->bpairs[bp_index].secondary = p; | 645 | bcbearer->bpairs[bp_index].secondary = p; |
| 634 | } | 646 | } |
| 635 | 647 | ||
| 636 | if (bcbearer->remains_new.count == 0) | 648 | if (bcbearer->remains_new.count == 0) |
| 637 | break; /* all targets reached */ | 649 | break; /* All targets reached */ |
| 638 | 650 | ||
| 639 | bcbearer->remains = bcbearer->remains_new; | 651 | bcbearer->remains = bcbearer->remains_new; |
| 640 | } | 652 | } |
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index aa62f93a9127..cb29ef7ba2f0 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c | |||
| @@ -39,7 +39,7 @@ | |||
| 39 | #include "bearer.h" | 39 | #include "bearer.h" |
| 40 | #include "discover.h" | 40 | #include "discover.h" |
| 41 | 41 | ||
| 42 | #define MAX_ADDR_STR 32 | 42 | #define MAX_ADDR_STR 60 |
| 43 | 43 | ||
| 44 | static struct tipc_media *media_list[MAX_MEDIA]; | 44 | static struct tipc_media *media_list[MAX_MEDIA]; |
| 45 | static u32 media_count; | 45 | static u32 media_count; |
| @@ -89,9 +89,6 @@ int tipc_register_media(struct tipc_media *m_ptr) | |||
| 89 | 89 | ||
| 90 | if ((strlen(m_ptr->name) + 1) > TIPC_MAX_MEDIA_NAME) | 90 | if ((strlen(m_ptr->name) + 1) > TIPC_MAX_MEDIA_NAME) |
| 91 | goto exit; | 91 | goto exit; |
| 92 | if ((m_ptr->bcast_addr.media_id != m_ptr->type_id) || | ||
| 93 | !m_ptr->bcast_addr.broadcast) | ||
| 94 | goto exit; | ||
| 95 | if (m_ptr->priority > TIPC_MAX_LINK_PRI) | 92 | if (m_ptr->priority > TIPC_MAX_LINK_PRI) |
| 96 | goto exit; | 93 | goto exit; |
| 97 | if ((m_ptr->tolerance < TIPC_MIN_LINK_TOL) || | 94 | if ((m_ptr->tolerance < TIPC_MIN_LINK_TOL) || |
| @@ -407,7 +404,7 @@ restart: | |||
| 407 | INIT_LIST_HEAD(&b_ptr->links); | 404 | INIT_LIST_HEAD(&b_ptr->links); |
| 408 | spin_lock_init(&b_ptr->lock); | 405 | spin_lock_init(&b_ptr->lock); |
| 409 | 406 | ||
| 410 | res = tipc_disc_create(b_ptr, &m_ptr->bcast_addr, disc_domain); | 407 | res = tipc_disc_create(b_ptr, &b_ptr->bcast_addr, disc_domain); |
| 411 | if (res) { | 408 | if (res) { |
| 412 | bearer_disable(b_ptr); | 409 | bearer_disable(b_ptr); |
| 413 | pr_warn("Bearer <%s> rejected, discovery object creation failed\n", | 410 | pr_warn("Bearer <%s> rejected, discovery object creation failed\n", |
diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h index 39f1192d04bf..09c869adcfcf 100644 --- a/net/tipc/bearer.h +++ b/net/tipc/bearer.h | |||
| @@ -56,6 +56,7 @@ | |||
| 56 | * Identifiers of supported TIPC media types | 56 | * Identifiers of supported TIPC media types |
| 57 | */ | 57 | */ |
| 58 | #define TIPC_MEDIA_TYPE_ETH 1 | 58 | #define TIPC_MEDIA_TYPE_ETH 1 |
| 59 | #define TIPC_MEDIA_TYPE_IB 2 | ||
| 59 | 60 | ||
| 60 | /** | 61 | /** |
| 61 | * struct tipc_media_addr - destination address used by TIPC bearers | 62 | * struct tipc_media_addr - destination address used by TIPC bearers |
| @@ -77,7 +78,6 @@ struct tipc_bearer; | |||
| 77 | * @enable_bearer: routine which enables a bearer | 78 | * @enable_bearer: routine which enables a bearer |
| 78 | * @disable_bearer: routine which disables a bearer | 79 | * @disable_bearer: routine which disables a bearer |
| 79 | * @addr2str: routine which converts media address to string | 80 | * @addr2str: routine which converts media address to string |
| 80 | * @str2addr: routine which converts media address from string | ||
| 81 | * @addr2msg: routine which converts media address to protocol message area | 81 | * @addr2msg: routine which converts media address to protocol message area |
| 82 | * @msg2addr: routine which converts media address from protocol message area | 82 | * @msg2addr: routine which converts media address from protocol message area |
| 83 | * @bcast_addr: media address used in broadcasting | 83 | * @bcast_addr: media address used in broadcasting |
| @@ -94,10 +94,9 @@ struct tipc_media { | |||
| 94 | int (*enable_bearer)(struct tipc_bearer *b_ptr); | 94 | int (*enable_bearer)(struct tipc_bearer *b_ptr); |
| 95 | void (*disable_bearer)(struct tipc_bearer *b_ptr); | 95 | void (*disable_bearer)(struct tipc_bearer *b_ptr); |
| 96 | int (*addr2str)(struct tipc_media_addr *a, char *str_buf, int str_size); | 96 | int (*addr2str)(struct tipc_media_addr *a, char *str_buf, int str_size); |
| 97 | int (*str2addr)(struct tipc_media_addr *a, char *str_buf); | ||
| 98 | int (*addr2msg)(struct tipc_media_addr *a, char *msg_area); | 97 | int (*addr2msg)(struct tipc_media_addr *a, char *msg_area); |
| 99 | int (*msg2addr)(struct tipc_media_addr *a, char *msg_area); | 98 | int (*msg2addr)(const struct tipc_bearer *b_ptr, |
| 100 | struct tipc_media_addr bcast_addr; | 99 | struct tipc_media_addr *a, char *msg_area); |
| 101 | u32 priority; | 100 | u32 priority; |
| 102 | u32 tolerance; | 101 | u32 tolerance; |
| 103 | u32 window; | 102 | u32 window; |
| @@ -136,6 +135,7 @@ struct tipc_bearer { | |||
| 136 | char name[TIPC_MAX_BEARER_NAME]; | 135 | char name[TIPC_MAX_BEARER_NAME]; |
| 137 | spinlock_t lock; | 136 | spinlock_t lock; |
| 138 | struct tipc_media *media; | 137 | struct tipc_media *media; |
| 138 | struct tipc_media_addr bcast_addr; | ||
| 139 | u32 priority; | 139 | u32 priority; |
| 140 | u32 window; | 140 | u32 window; |
| 141 | u32 tolerance; | 141 | u32 tolerance; |
| @@ -175,6 +175,14 @@ int tipc_disable_bearer(const char *name); | |||
| 175 | int tipc_eth_media_start(void); | 175 | int tipc_eth_media_start(void); |
| 176 | void tipc_eth_media_stop(void); | 176 | void tipc_eth_media_stop(void); |
| 177 | 177 | ||
| 178 | #ifdef CONFIG_TIPC_MEDIA_IB | ||
| 179 | int tipc_ib_media_start(void); | ||
| 180 | void tipc_ib_media_stop(void); | ||
| 181 | #else | ||
| 182 | static inline int tipc_ib_media_start(void) { return 0; } | ||
| 183 | static inline void tipc_ib_media_stop(void) { return; } | ||
| 184 | #endif | ||
| 185 | |||
| 178 | int tipc_media_set_priority(const char *name, u32 new_value); | 186 | int tipc_media_set_priority(const char *name, u32 new_value); |
| 179 | int tipc_media_set_window(const char *name, u32 new_value); | 187 | int tipc_media_set_window(const char *name, u32 new_value); |
| 180 | void tipc_media_addr_printf(char *buf, int len, struct tipc_media_addr *a); | 188 | void tipc_media_addr_printf(char *buf, int len, struct tipc_media_addr *a); |
diff --git a/net/tipc/core.c b/net/tipc/core.c index fc05cecd7481..7ec2c1eb94f1 100644 --- a/net/tipc/core.c +++ b/net/tipc/core.c | |||
| @@ -82,6 +82,7 @@ static void tipc_core_stop_net(void) | |||
| 82 | { | 82 | { |
| 83 | tipc_net_stop(); | 83 | tipc_net_stop(); |
| 84 | tipc_eth_media_stop(); | 84 | tipc_eth_media_stop(); |
| 85 | tipc_ib_media_stop(); | ||
| 85 | } | 86 | } |
| 86 | 87 | ||
| 87 | /** | 88 | /** |
| @@ -93,8 +94,15 @@ int tipc_core_start_net(unsigned long addr) | |||
| 93 | 94 | ||
| 94 | tipc_net_start(addr); | 95 | tipc_net_start(addr); |
| 95 | res = tipc_eth_media_start(); | 96 | res = tipc_eth_media_start(); |
| 96 | if (res) | 97 | if (res < 0) |
| 97 | tipc_core_stop_net(); | 98 | goto err; |
| 99 | res = tipc_ib_media_start(); | ||
| 100 | if (res < 0) | ||
| 101 | goto err; | ||
| 102 | return res; | ||
| 103 | |||
| 104 | err: | ||
| 105 | tipc_core_stop_net(); | ||
| 98 | return res; | 106 | return res; |
| 99 | } | 107 | } |
| 100 | 108 | ||
diff --git a/net/tipc/discover.c b/net/tipc/discover.c index 1074b9587e81..eedff58d0387 100644 --- a/net/tipc/discover.c +++ b/net/tipc/discover.c | |||
| @@ -129,7 +129,7 @@ void tipc_disc_recv_msg(struct sk_buff *buf, struct tipc_bearer *b_ptr) | |||
| 129 | int link_fully_up; | 129 | int link_fully_up; |
| 130 | 130 | ||
| 131 | media_addr.broadcast = 1; | 131 | media_addr.broadcast = 1; |
| 132 | b_ptr->media->msg2addr(&media_addr, msg_media_addr(msg)); | 132 | b_ptr->media->msg2addr(b_ptr, &media_addr, msg_media_addr(msg)); |
| 133 | kfree_skb(buf); | 133 | kfree_skb(buf); |
| 134 | 134 | ||
| 135 | /* Ensure message from node is valid and communication is permitted */ | 135 | /* Ensure message from node is valid and communication is permitted */ |
diff --git a/net/tipc/eth_media.c b/net/tipc/eth_media.c index 2132c1ef2951..120a676a3360 100644 --- a/net/tipc/eth_media.c +++ b/net/tipc/eth_media.c | |||
| @@ -77,12 +77,13 @@ static struct notifier_block notifier = { | |||
| 77 | * Media-dependent "value" field stores MAC address in first 6 bytes | 77 | * Media-dependent "value" field stores MAC address in first 6 bytes |
| 78 | * and zeroes out the remaining bytes. | 78 | * and zeroes out the remaining bytes. |
| 79 | */ | 79 | */ |
| 80 | static void eth_media_addr_set(struct tipc_media_addr *a, char *mac) | 80 | static void eth_media_addr_set(const struct tipc_bearer *tb_ptr, |
| 81 | struct tipc_media_addr *a, char *mac) | ||
| 81 | { | 82 | { |
| 82 | memcpy(a->value, mac, ETH_ALEN); | 83 | memcpy(a->value, mac, ETH_ALEN); |
| 83 | memset(a->value + ETH_ALEN, 0, sizeof(a->value) - ETH_ALEN); | 84 | memset(a->value + ETH_ALEN, 0, sizeof(a->value) - ETH_ALEN); |
| 84 | a->media_id = TIPC_MEDIA_TYPE_ETH; | 85 | a->media_id = TIPC_MEDIA_TYPE_ETH; |
| 85 | a->broadcast = !memcmp(mac, eth_media_info.bcast_addr.value, ETH_ALEN); | 86 | a->broadcast = !memcmp(mac, tb_ptr->bcast_addr.value, ETH_ALEN); |
| 86 | } | 87 | } |
| 87 | 88 | ||
| 88 | /** | 89 | /** |
| @@ -110,6 +111,7 @@ static int send_msg(struct sk_buff *buf, struct tipc_bearer *tb_ptr, | |||
| 110 | 111 | ||
| 111 | skb_reset_network_header(clone); | 112 | skb_reset_network_header(clone); |
| 112 | clone->dev = dev; | 113 | clone->dev = dev; |
| 114 | clone->protocol = htons(ETH_P_TIPC); | ||
| 113 | dev_hard_header(clone, dev, ETH_P_TIPC, dest->value, | 115 | dev_hard_header(clone, dev, ETH_P_TIPC, dest->value, |
| 114 | dev->dev_addr, clone->len); | 116 | dev->dev_addr, clone->len); |
| 115 | dev_queue_xmit(clone); | 117 | dev_queue_xmit(clone); |
| @@ -201,9 +203,13 @@ static int enable_bearer(struct tipc_bearer *tb_ptr) | |||
| 201 | /* Associate TIPC bearer with Ethernet bearer */ | 203 | /* Associate TIPC bearer with Ethernet bearer */ |
| 202 | eb_ptr->bearer = tb_ptr; | 204 | eb_ptr->bearer = tb_ptr; |
| 203 | tb_ptr->usr_handle = (void *)eb_ptr; | 205 | tb_ptr->usr_handle = (void *)eb_ptr; |
| 206 | memset(tb_ptr->bcast_addr.value, 0, sizeof(tb_ptr->bcast_addr.value)); | ||
| 207 | memcpy(tb_ptr->bcast_addr.value, dev->broadcast, ETH_ALEN); | ||
| 208 | tb_ptr->bcast_addr.media_id = TIPC_MEDIA_TYPE_ETH; | ||
| 209 | tb_ptr->bcast_addr.broadcast = 1; | ||
| 204 | tb_ptr->mtu = dev->mtu; | 210 | tb_ptr->mtu = dev->mtu; |
| 205 | tb_ptr->blocked = 0; | 211 | tb_ptr->blocked = 0; |
| 206 | eth_media_addr_set(&tb_ptr->addr, (char *)dev->dev_addr); | 212 | eth_media_addr_set(tb_ptr, &tb_ptr->addr, (char *)dev->dev_addr); |
| 207 | return 0; | 213 | return 0; |
| 208 | } | 214 | } |
| 209 | 215 | ||
| @@ -302,25 +308,6 @@ static int eth_addr2str(struct tipc_media_addr *a, char *str_buf, int str_size) | |||
| 302 | } | 308 | } |
| 303 | 309 | ||
| 304 | /** | 310 | /** |
| 305 | * eth_str2addr - convert string to Ethernet address | ||
| 306 | */ | ||
| 307 | static int eth_str2addr(struct tipc_media_addr *a, char *str_buf) | ||
| 308 | { | ||
| 309 | char mac[ETH_ALEN]; | ||
| 310 | int r; | ||
| 311 | |||
| 312 | r = sscanf(str_buf, "%02x:%02x:%02x:%02x:%02x:%02x", | ||
| 313 | (u32 *)&mac[0], (u32 *)&mac[1], (u32 *)&mac[2], | ||
| 314 | (u32 *)&mac[3], (u32 *)&mac[4], (u32 *)&mac[5]); | ||
| 315 | |||
| 316 | if (r != ETH_ALEN) | ||
| 317 | return 1; | ||
| 318 | |||
| 319 | eth_media_addr_set(a, mac); | ||
| 320 | return 0; | ||
| 321 | } | ||
| 322 | |||
| 323 | /** | ||
| 324 | * eth_str2addr - convert Ethernet address format to message header format | 311 | * eth_str2addr - convert Ethernet address format to message header format |
| 325 | */ | 312 | */ |
| 326 | static int eth_addr2msg(struct tipc_media_addr *a, char *msg_area) | 313 | static int eth_addr2msg(struct tipc_media_addr *a, char *msg_area) |
| @@ -334,12 +321,13 @@ static int eth_addr2msg(struct tipc_media_addr *a, char *msg_area) | |||
| 334 | /** | 321 | /** |
| 335 | * eth_str2addr - convert message header address format to Ethernet format | 322 | * eth_str2addr - convert message header address format to Ethernet format |
| 336 | */ | 323 | */ |
| 337 | static int eth_msg2addr(struct tipc_media_addr *a, char *msg_area) | 324 | static int eth_msg2addr(const struct tipc_bearer *tb_ptr, |
| 325 | struct tipc_media_addr *a, char *msg_area) | ||
| 338 | { | 326 | { |
| 339 | if (msg_area[TIPC_MEDIA_TYPE_OFFSET] != TIPC_MEDIA_TYPE_ETH) | 327 | if (msg_area[TIPC_MEDIA_TYPE_OFFSET] != TIPC_MEDIA_TYPE_ETH) |
| 340 | return 1; | 328 | return 1; |
| 341 | 329 | ||
| 342 | eth_media_addr_set(a, msg_area + ETH_ADDR_OFFSET); | 330 | eth_media_addr_set(tb_ptr, a, msg_area + ETH_ADDR_OFFSET); |
| 343 | return 0; | 331 | return 0; |
| 344 | } | 332 | } |
| 345 | 333 | ||
| @@ -351,11 +339,8 @@ static struct tipc_media eth_media_info = { | |||
| 351 | .enable_bearer = enable_bearer, | 339 | .enable_bearer = enable_bearer, |
| 352 | .disable_bearer = disable_bearer, | 340 | .disable_bearer = disable_bearer, |
| 353 | .addr2str = eth_addr2str, | 341 | .addr2str = eth_addr2str, |
| 354 | .str2addr = eth_str2addr, | ||
| 355 | .addr2msg = eth_addr2msg, | 342 | .addr2msg = eth_addr2msg, |
| 356 | .msg2addr = eth_msg2addr, | 343 | .msg2addr = eth_msg2addr, |
| 357 | .bcast_addr = { { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }, | ||
| 358 | TIPC_MEDIA_TYPE_ETH, 1 }, | ||
| 359 | .priority = TIPC_DEF_LINK_PRI, | 344 | .priority = TIPC_DEF_LINK_PRI, |
| 360 | .tolerance = TIPC_DEF_LINK_TOL, | 345 | .tolerance = TIPC_DEF_LINK_TOL, |
| 361 | .window = TIPC_DEF_LINK_WIN, | 346 | .window = TIPC_DEF_LINK_WIN, |
diff --git a/net/tipc/ib_media.c b/net/tipc/ib_media.c new file mode 100644 index 000000000000..2a2864c25e15 --- /dev/null +++ b/net/tipc/ib_media.c | |||
| @@ -0,0 +1,387 @@ | |||
| 1 | /* | ||
| 2 | * net/tipc/ib_media.c: Infiniband bearer support for TIPC | ||
| 3 | * | ||
| 4 | * Copyright (c) 2013 Patrick McHardy <kaber@trash.net> | ||
| 5 | * | ||
| 6 | * Based on eth_media.c, which carries the following copyright notice: | ||
| 7 | * | ||
| 8 | * Copyright (c) 2001-2007, Ericsson AB | ||
| 9 | * Copyright (c) 2005-2008, 2011, Wind River Systems | ||
| 10 | * All rights reserved. | ||
| 11 | * | ||
| 12 | * Redistribution and use in source and binary forms, with or without | ||
| 13 | * modification, are permitted provided that the following conditions are met: | ||
| 14 | * | ||
| 15 | * 1. Redistributions of source code must retain the above copyright | ||
| 16 | * notice, this list of conditions and the following disclaimer. | ||
| 17 | * 2. Redistributions in binary form must reproduce the above copyright | ||
| 18 | * notice, this list of conditions and the following disclaimer in the | ||
| 19 | * documentation and/or other materials provided with the distribution. | ||
| 20 | * 3. Neither the names of the copyright holders nor the names of its | ||
| 21 | * contributors may be used to endorse or promote products derived from | ||
| 22 | * this software without specific prior written permission. | ||
| 23 | * | ||
| 24 | * Alternatively, this software may be distributed under the terms of the | ||
| 25 | * GNU General Public License ("GPL") version 2 as published by the Free | ||
| 26 | * Software Foundation. | ||
| 27 | * | ||
| 28 | * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
| 29 | * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| 30 | * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
| 31 | * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE | ||
| 32 | * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
| 33 | * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
| 34 | * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
| 35 | * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| 36 | * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| 37 | * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| 38 | * POSSIBILITY OF SUCH DAMAGE. | ||
| 39 | */ | ||
| 40 | |||
| 41 | #include <linux/if_infiniband.h> | ||
| 42 | #include "core.h" | ||
| 43 | #include "bearer.h" | ||
| 44 | |||
| 45 | #define MAX_IB_BEARERS MAX_BEARERS | ||
| 46 | |||
| 47 | /** | ||
| 48 | * struct ib_bearer - Infiniband bearer data structure | ||
| 49 | * @bearer: ptr to associated "generic" bearer structure | ||
| 50 | * @dev: ptr to associated Infiniband network device | ||
| 51 | * @tipc_packet_type: used in binding TIPC to Infiniband driver | ||
| 52 | * @cleanup: work item used when disabling bearer | ||
| 53 | */ | ||
| 54 | |||
| 55 | struct ib_bearer { | ||
| 56 | struct tipc_bearer *bearer; | ||
| 57 | struct net_device *dev; | ||
| 58 | struct packet_type tipc_packet_type; | ||
| 59 | struct work_struct setup; | ||
| 60 | struct work_struct cleanup; | ||
| 61 | }; | ||
| 62 | |||
| 63 | static struct tipc_media ib_media_info; | ||
| 64 | static struct ib_bearer ib_bearers[MAX_IB_BEARERS]; | ||
| 65 | static int ib_started; | ||
| 66 | |||
| 67 | /** | ||
| 68 | * ib_media_addr_set - initialize Infiniband media address structure | ||
| 69 | * | ||
| 70 | * Media-dependent "value" field stores MAC address in first 6 bytes | ||
| 71 | * and zeroes out the remaining bytes. | ||
| 72 | */ | ||
| 73 | static void ib_media_addr_set(const struct tipc_bearer *tb_ptr, | ||
| 74 | struct tipc_media_addr *a, char *mac) | ||
| 75 | { | ||
| 76 | BUILD_BUG_ON(sizeof(a->value) < INFINIBAND_ALEN); | ||
| 77 | memcpy(a->value, mac, INFINIBAND_ALEN); | ||
| 78 | a->media_id = TIPC_MEDIA_TYPE_IB; | ||
| 79 | a->broadcast = !memcmp(mac, tb_ptr->bcast_addr.value, INFINIBAND_ALEN); | ||
| 80 | } | ||
| 81 | |||
| 82 | /** | ||
| 83 | * send_msg - send a TIPC message out over an InfiniBand interface | ||
| 84 | */ | ||
| 85 | static int send_msg(struct sk_buff *buf, struct tipc_bearer *tb_ptr, | ||
| 86 | struct tipc_media_addr *dest) | ||
| 87 | { | ||
| 88 | struct sk_buff *clone; | ||
| 89 | struct net_device *dev; | ||
| 90 | int delta; | ||
| 91 | |||
| 92 | clone = skb_clone(buf, GFP_ATOMIC); | ||
| 93 | if (!clone) | ||
| 94 | return 0; | ||
| 95 | |||
| 96 | dev = ((struct ib_bearer *)(tb_ptr->usr_handle))->dev; | ||
| 97 | delta = dev->hard_header_len - skb_headroom(buf); | ||
| 98 | |||
| 99 | if ((delta > 0) && | ||
| 100 | pskb_expand_head(clone, SKB_DATA_ALIGN(delta), 0, GFP_ATOMIC)) { | ||
| 101 | kfree_skb(clone); | ||
| 102 | return 0; | ||
| 103 | } | ||
| 104 | |||
| 105 | skb_reset_network_header(clone); | ||
| 106 | clone->dev = dev; | ||
| 107 | clone->protocol = htons(ETH_P_TIPC); | ||
| 108 | dev_hard_header(clone, dev, ETH_P_TIPC, dest->value, | ||
| 109 | dev->dev_addr, clone->len); | ||
| 110 | dev_queue_xmit(clone); | ||
| 111 | return 0; | ||
| 112 | } | ||
| 113 | |||
| 114 | /** | ||
| 115 | * recv_msg - handle incoming TIPC message from an InfiniBand interface | ||
| 116 | * | ||
| 117 | * Accept only packets explicitly sent to this node, or broadcast packets; | ||
| 118 | * ignores packets sent using InfiniBand multicast, and traffic sent to other | ||
| 119 | * nodes (which can happen if interface is running in promiscuous mode). | ||
| 120 | */ | ||
| 121 | static int recv_msg(struct sk_buff *buf, struct net_device *dev, | ||
| 122 | struct packet_type *pt, struct net_device *orig_dev) | ||
| 123 | { | ||
| 124 | struct ib_bearer *ib_ptr = (struct ib_bearer *)pt->af_packet_priv; | ||
| 125 | |||
| 126 | if (!net_eq(dev_net(dev), &init_net)) { | ||
| 127 | kfree_skb(buf); | ||
| 128 | return 0; | ||
| 129 | } | ||
| 130 | |||
| 131 | if (likely(ib_ptr->bearer)) { | ||
| 132 | if (likely(buf->pkt_type <= PACKET_BROADCAST)) { | ||
| 133 | buf->next = NULL; | ||
| 134 | tipc_recv_msg(buf, ib_ptr->bearer); | ||
| 135 | return 0; | ||
| 136 | } | ||
| 137 | } | ||
| 138 | kfree_skb(buf); | ||
| 139 | return 0; | ||
| 140 | } | ||
| 141 | |||
| 142 | /** | ||
| 143 | * setup_bearer - setup association between InfiniBand bearer and interface | ||
| 144 | */ | ||
| 145 | static void setup_bearer(struct work_struct *work) | ||
| 146 | { | ||
| 147 | struct ib_bearer *ib_ptr = | ||
| 148 | container_of(work, struct ib_bearer, setup); | ||
| 149 | |||
| 150 | dev_add_pack(&ib_ptr->tipc_packet_type); | ||
| 151 | } | ||
| 152 | |||
| 153 | /** | ||
| 154 | * enable_bearer - attach TIPC bearer to an InfiniBand interface | ||
| 155 | */ | ||
| 156 | static int enable_bearer(struct tipc_bearer *tb_ptr) | ||
| 157 | { | ||
| 158 | struct net_device *dev = NULL; | ||
| 159 | struct net_device *pdev = NULL; | ||
| 160 | struct ib_bearer *ib_ptr = &ib_bearers[0]; | ||
| 161 | struct ib_bearer *stop = &ib_bearers[MAX_IB_BEARERS]; | ||
| 162 | char *driver_name = strchr((const char *)tb_ptr->name, ':') + 1; | ||
| 163 | int pending_dev = 0; | ||
| 164 | |||
| 165 | /* Find unused InfiniBand bearer structure */ | ||
| 166 | while (ib_ptr->dev) { | ||
| 167 | if (!ib_ptr->bearer) | ||
| 168 | pending_dev++; | ||
| 169 | if (++ib_ptr == stop) | ||
| 170 | return pending_dev ? -EAGAIN : -EDQUOT; | ||
| 171 | } | ||
| 172 | |||
| 173 | /* Find device with specified name */ | ||
| 174 | read_lock(&dev_base_lock); | ||
| 175 | for_each_netdev(&init_net, pdev) { | ||
| 176 | if (!strncmp(pdev->name, driver_name, IFNAMSIZ)) { | ||
| 177 | dev = pdev; | ||
| 178 | dev_hold(dev); | ||
| 179 | break; | ||
| 180 | } | ||
| 181 | } | ||
| 182 | read_unlock(&dev_base_lock); | ||
| 183 | if (!dev) | ||
| 184 | return -ENODEV; | ||
| 185 | |||
| 186 | /* Create InfiniBand bearer for device */ | ||
| 187 | ib_ptr->dev = dev; | ||
| 188 | ib_ptr->tipc_packet_type.type = htons(ETH_P_TIPC); | ||
| 189 | ib_ptr->tipc_packet_type.dev = dev; | ||
| 190 | ib_ptr->tipc_packet_type.func = recv_msg; | ||
| 191 | ib_ptr->tipc_packet_type.af_packet_priv = ib_ptr; | ||
| 192 | INIT_LIST_HEAD(&(ib_ptr->tipc_packet_type.list)); | ||
| 193 | INIT_WORK(&ib_ptr->setup, setup_bearer); | ||
| 194 | schedule_work(&ib_ptr->setup); | ||
| 195 | |||
| 196 | /* Associate TIPC bearer with InfiniBand bearer */ | ||
| 197 | ib_ptr->bearer = tb_ptr; | ||
| 198 | tb_ptr->usr_handle = (void *)ib_ptr; | ||
| 199 | memset(tb_ptr->bcast_addr.value, 0, sizeof(tb_ptr->bcast_addr.value)); | ||
| 200 | memcpy(tb_ptr->bcast_addr.value, dev->broadcast, INFINIBAND_ALEN); | ||
| 201 | tb_ptr->bcast_addr.media_id = TIPC_MEDIA_TYPE_IB; | ||
| 202 | tb_ptr->bcast_addr.broadcast = 1; | ||
| 203 | tb_ptr->mtu = dev->mtu; | ||
| 204 | tb_ptr->blocked = 0; | ||
| 205 | ib_media_addr_set(tb_ptr, &tb_ptr->addr, (char *)dev->dev_addr); | ||
| 206 | return 0; | ||
| 207 | } | ||
| 208 | |||
| 209 | /** | ||
| 210 | * cleanup_bearer - break association between InfiniBand bearer and interface | ||
| 211 | * | ||
| 212 | * This routine must be invoked from a work queue because it can sleep. | ||
| 213 | */ | ||
| 214 | static void cleanup_bearer(struct work_struct *work) | ||
| 215 | { | ||
| 216 | struct ib_bearer *ib_ptr = | ||
| 217 | container_of(work, struct ib_bearer, cleanup); | ||
| 218 | |||
| 219 | dev_remove_pack(&ib_ptr->tipc_packet_type); | ||
| 220 | dev_put(ib_ptr->dev); | ||
| 221 | ib_ptr->dev = NULL; | ||
| 222 | } | ||
| 223 | |||
| 224 | /** | ||
| 225 | * disable_bearer - detach TIPC bearer from an InfiniBand interface | ||
| 226 | * | ||
| 227 | * Mark InfiniBand bearer as inactive so that incoming buffers are thrown away, | ||
| 228 | * then get worker thread to complete bearer cleanup. (Can't do cleanup | ||
| 229 | * here because cleanup code needs to sleep and caller holds spinlocks.) | ||
| 230 | */ | ||
| 231 | static void disable_bearer(struct tipc_bearer *tb_ptr) | ||
| 232 | { | ||
| 233 | struct ib_bearer *ib_ptr = (struct ib_bearer *)tb_ptr->usr_handle; | ||
| 234 | |||
| 235 | ib_ptr->bearer = NULL; | ||
| 236 | INIT_WORK(&ib_ptr->cleanup, cleanup_bearer); | ||
| 237 | schedule_work(&ib_ptr->cleanup); | ||
| 238 | } | ||
| 239 | |||
| 240 | /** | ||
| 241 | * recv_notification - handle device updates from OS | ||
| 242 | * | ||
| 243 | * Change the state of the InfiniBand bearer (if any) associated with the | ||
| 244 | * specified device. | ||
| 245 | */ | ||
| 246 | static int recv_notification(struct notifier_block *nb, unsigned long evt, | ||
| 247 | void *dv) | ||
| 248 | { | ||
| 249 | struct net_device *dev = (struct net_device *)dv; | ||
| 250 | struct ib_bearer *ib_ptr = &ib_bearers[0]; | ||
| 251 | struct ib_bearer *stop = &ib_bearers[MAX_IB_BEARERS]; | ||
| 252 | |||
| 253 | if (!net_eq(dev_net(dev), &init_net)) | ||
| 254 | return NOTIFY_DONE; | ||
| 255 | |||
| 256 | while ((ib_ptr->dev != dev)) { | ||
| 257 | if (++ib_ptr == stop) | ||
| 258 | return NOTIFY_DONE; /* couldn't find device */ | ||
| 259 | } | ||
| 260 | if (!ib_ptr->bearer) | ||
| 261 | return NOTIFY_DONE; /* bearer had been disabled */ | ||
| 262 | |||
| 263 | ib_ptr->bearer->mtu = dev->mtu; | ||
| 264 | |||
| 265 | switch (evt) { | ||
| 266 | case NETDEV_CHANGE: | ||
| 267 | if (netif_carrier_ok(dev)) | ||
| 268 | tipc_continue(ib_ptr->bearer); | ||
| 269 | else | ||
| 270 | tipc_block_bearer(ib_ptr->bearer->name); | ||
| 271 | break; | ||
| 272 | case NETDEV_UP: | ||
| 273 | tipc_continue(ib_ptr->bearer); | ||
| 274 | break; | ||
| 275 | case NETDEV_DOWN: | ||
| 276 | tipc_block_bearer(ib_ptr->bearer->name); | ||
| 277 | break; | ||
| 278 | case NETDEV_CHANGEMTU: | ||
| 279 | case NETDEV_CHANGEADDR: | ||
| 280 | tipc_block_bearer(ib_ptr->bearer->name); | ||
| 281 | tipc_continue(ib_ptr->bearer); | ||
| 282 | break; | ||
| 283 | case NETDEV_UNREGISTER: | ||
| 284 | case NETDEV_CHANGENAME: | ||
| 285 | tipc_disable_bearer(ib_ptr->bearer->name); | ||
| 286 | break; | ||
| 287 | } | ||
| 288 | return NOTIFY_OK; | ||
| 289 | } | ||
| 290 | |||
| 291 | static struct notifier_block notifier = { | ||
| 292 | .notifier_call = recv_notification, | ||
| 293 | .priority = 0, | ||
| 294 | }; | ||
| 295 | |||
| 296 | /** | ||
| 297 | * ib_addr2str - convert InfiniBand address to string | ||
| 298 | */ | ||
| 299 | static int ib_addr2str(struct tipc_media_addr *a, char *str_buf, int str_size) | ||
| 300 | { | ||
| 301 | if (str_size < 60) /* 60 = 19 * strlen("xx:") + strlen("xx\0") */ | ||
| 302 | return 1; | ||
| 303 | |||
| 304 | sprintf(str_buf, "%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:" | ||
| 305 | "%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x", | ||
| 306 | a->value[0], a->value[1], a->value[2], a->value[3], | ||
| 307 | a->value[4], a->value[5], a->value[6], a->value[7], | ||
| 308 | a->value[8], a->value[9], a->value[10], a->value[11], | ||
| 309 | a->value[12], a->value[13], a->value[14], a->value[15], | ||
| 310 | a->value[16], a->value[17], a->value[18], a->value[19]); | ||
| 311 | |||
| 312 | return 0; | ||
| 313 | } | ||
| 314 | |||
| 315 | /** | ||
| 316 | * ib_addr2msg - convert InfiniBand address format to message header format | ||
| 317 | */ | ||
| 318 | static int ib_addr2msg(struct tipc_media_addr *a, char *msg_area) | ||
| 319 | { | ||
| 320 | memset(msg_area, 0, TIPC_MEDIA_ADDR_SIZE); | ||
| 321 | msg_area[TIPC_MEDIA_TYPE_OFFSET] = TIPC_MEDIA_TYPE_IB; | ||
| 322 | memcpy(msg_area, a->value, INFINIBAND_ALEN); | ||
| 323 | return 0; | ||
| 324 | } | ||
| 325 | |||
| 326 | /** | ||
| 327 | * ib_msg2addr - convert message header address format to InfiniBand format | ||
| 328 | */ | ||
| 329 | static int ib_msg2addr(const struct tipc_bearer *tb_ptr, | ||
| 330 | struct tipc_media_addr *a, char *msg_area) | ||
| 331 | { | ||
| 332 | ib_media_addr_set(tb_ptr, a, msg_area); | ||
| 333 | return 0; | ||
| 334 | } | ||
| 335 | |||
| 336 | /* | ||
| 337 | * InfiniBand media registration info | ||
| 338 | */ | ||
| 339 | static struct tipc_media ib_media_info = { | ||
| 340 | .send_msg = send_msg, | ||
| 341 | .enable_bearer = enable_bearer, | ||
| 342 | .disable_bearer = disable_bearer, | ||
| 343 | .addr2str = ib_addr2str, | ||
| 344 | .addr2msg = ib_addr2msg, | ||
| 345 | .msg2addr = ib_msg2addr, | ||
| 346 | .priority = TIPC_DEF_LINK_PRI, | ||
| 347 | .tolerance = TIPC_DEF_LINK_TOL, | ||
| 348 | .window = TIPC_DEF_LINK_WIN, | ||
| 349 | .type_id = TIPC_MEDIA_TYPE_IB, | ||
| 350 | .name = "ib" | ||
| 351 | }; | ||
| 352 | |||
| 353 | /** | ||
| 354 | * tipc_ib_media_start - activate InfiniBand bearer support | ||
| 355 | * | ||
| 356 | * Register InfiniBand media type with TIPC bearer code. Also register | ||
| 357 | * with OS for notifications about device state changes. | ||
| 358 | */ | ||
| 359 | int tipc_ib_media_start(void) | ||
| 360 | { | ||
| 361 | int res; | ||
| 362 | |||
| 363 | if (ib_started) | ||
| 364 | return -EINVAL; | ||
| 365 | |||
| 366 | res = tipc_register_media(&ib_media_info); | ||
| 367 | if (res) | ||
| 368 | return res; | ||
| 369 | |||
| 370 | res = register_netdevice_notifier(¬ifier); | ||
| 371 | if (!res) | ||
| 372 | ib_started = 1; | ||
| 373 | return res; | ||
| 374 | } | ||
| 375 | |||
| 376 | /** | ||
| 377 | * tipc_ib_media_stop - deactivate InfiniBand bearer support | ||
| 378 | */ | ||
| 379 | void tipc_ib_media_stop(void) | ||
| 380 | { | ||
| 381 | if (!ib_started) | ||
| 382 | return; | ||
| 383 | |||
| 384 | flush_scheduled_work(); | ||
| 385 | unregister_netdevice_notifier(¬ifier); | ||
| 386 | ib_started = 0; | ||
| 387 | } | ||
diff --git a/net/tipc/link.c b/net/tipc/link.c index daa6080a2a0c..a80feee5197a 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c | |||
| @@ -2306,8 +2306,11 @@ static int link_recv_changeover_msg(struct tipc_link **l_ptr, | |||
| 2306 | struct tipc_msg *tunnel_msg = buf_msg(tunnel_buf); | 2306 | struct tipc_msg *tunnel_msg = buf_msg(tunnel_buf); |
| 2307 | u32 msg_typ = msg_type(tunnel_msg); | 2307 | u32 msg_typ = msg_type(tunnel_msg); |
| 2308 | u32 msg_count = msg_msgcnt(tunnel_msg); | 2308 | u32 msg_count = msg_msgcnt(tunnel_msg); |
| 2309 | u32 bearer_id = msg_bearer_id(tunnel_msg); | ||
| 2309 | 2310 | ||
| 2310 | dest_link = (*l_ptr)->owner->links[msg_bearer_id(tunnel_msg)]; | 2311 | if (bearer_id >= MAX_BEARERS) |
| 2312 | goto exit; | ||
| 2313 | dest_link = (*l_ptr)->owner->links[bearer_id]; | ||
| 2311 | if (!dest_link) | 2314 | if (!dest_link) |
| 2312 | goto exit; | 2315 | goto exit; |
| 2313 | if (dest_link == *l_ptr) { | 2316 | if (dest_link == *l_ptr) { |
| @@ -2521,14 +2524,16 @@ int tipc_link_recv_fragment(struct sk_buff **pending, struct sk_buff **fb, | |||
| 2521 | struct tipc_msg *imsg = (struct tipc_msg *)msg_data(fragm); | 2524 | struct tipc_msg *imsg = (struct tipc_msg *)msg_data(fragm); |
| 2522 | u32 msg_sz = msg_size(imsg); | 2525 | u32 msg_sz = msg_size(imsg); |
| 2523 | u32 fragm_sz = msg_data_sz(fragm); | 2526 | u32 fragm_sz = msg_data_sz(fragm); |
| 2524 | u32 exp_fragm_cnt = msg_sz/fragm_sz + !!(msg_sz % fragm_sz); | 2527 | u32 exp_fragm_cnt; |
| 2525 | u32 max = TIPC_MAX_USER_MSG_SIZE + NAMED_H_SIZE; | 2528 | u32 max = TIPC_MAX_USER_MSG_SIZE + NAMED_H_SIZE; |
| 2529 | |||
| 2526 | if (msg_type(imsg) == TIPC_MCAST_MSG) | 2530 | if (msg_type(imsg) == TIPC_MCAST_MSG) |
| 2527 | max = TIPC_MAX_USER_MSG_SIZE + MCAST_H_SIZE; | 2531 | max = TIPC_MAX_USER_MSG_SIZE + MCAST_H_SIZE; |
| 2528 | if (msg_size(imsg) > max) { | 2532 | if (fragm_sz == 0 || msg_size(imsg) > max) { |
| 2529 | kfree_skb(fbuf); | 2533 | kfree_skb(fbuf); |
| 2530 | return 0; | 2534 | return 0; |
| 2531 | } | 2535 | } |
| 2536 | exp_fragm_cnt = msg_sz / fragm_sz + !!(msg_sz % fragm_sz); | ||
| 2532 | pbuf = tipc_buf_acquire(msg_size(imsg)); | 2537 | pbuf = tipc_buf_acquire(msg_size(imsg)); |
| 2533 | if (pbuf != NULL) { | 2538 | if (pbuf != NULL) { |
| 2534 | pbuf->next = *pending; | 2539 | pbuf->next = *pending; |
diff --git a/net/tipc/netlink.c b/net/tipc/netlink.c index 6675914dc592..8bcd4985d0fb 100644 --- a/net/tipc/netlink.c +++ b/net/tipc/netlink.c | |||
| @@ -44,7 +44,7 @@ static int handle_cmd(struct sk_buff *skb, struct genl_info *info) | |||
| 44 | struct nlmsghdr *rep_nlh; | 44 | struct nlmsghdr *rep_nlh; |
| 45 | struct nlmsghdr *req_nlh = info->nlhdr; | 45 | struct nlmsghdr *req_nlh = info->nlhdr; |
| 46 | struct tipc_genlmsghdr *req_userhdr = info->userhdr; | 46 | struct tipc_genlmsghdr *req_userhdr = info->userhdr; |
| 47 | int hdr_space = NLMSG_SPACE(GENL_HDRLEN + TIPC_GENL_HDRLEN); | 47 | int hdr_space = nlmsg_total_size(GENL_HDRLEN + TIPC_GENL_HDRLEN); |
| 48 | u16 cmd; | 48 | u16 cmd; |
| 49 | 49 | ||
| 50 | if ((req_userhdr->cmd & 0xC000) && (!capable(CAP_NET_ADMIN))) | 50 | if ((req_userhdr->cmd & 0xC000) && (!capable(CAP_NET_ADMIN))) |
| @@ -53,8 +53,8 @@ static int handle_cmd(struct sk_buff *skb, struct genl_info *info) | |||
| 53 | cmd = req_userhdr->cmd; | 53 | cmd = req_userhdr->cmd; |
| 54 | 54 | ||
| 55 | rep_buf = tipc_cfg_do_cmd(req_userhdr->dest, cmd, | 55 | rep_buf = tipc_cfg_do_cmd(req_userhdr->dest, cmd, |
| 56 | NLMSG_DATA(req_nlh) + GENL_HDRLEN + TIPC_GENL_HDRLEN, | 56 | nlmsg_data(req_nlh) + GENL_HDRLEN + TIPC_GENL_HDRLEN, |
| 57 | NLMSG_PAYLOAD(req_nlh, GENL_HDRLEN + TIPC_GENL_HDRLEN), | 57 | nlmsg_attrlen(req_nlh, GENL_HDRLEN + TIPC_GENL_HDRLEN), |
| 58 | hdr_space); | 58 | hdr_space); |
| 59 | 59 | ||
| 60 | if (rep_buf) { | 60 | if (rep_buf) { |
diff --git a/net/tipc/socket.c b/net/tipc/socket.c index a9622b6cd916..515ce38e4f4c 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c | |||
| @@ -790,6 +790,7 @@ static void set_orig_addr(struct msghdr *m, struct tipc_msg *msg) | |||
| 790 | if (addr) { | 790 | if (addr) { |
| 791 | addr->family = AF_TIPC; | 791 | addr->family = AF_TIPC; |
| 792 | addr->addrtype = TIPC_ADDR_ID; | 792 | addr->addrtype = TIPC_ADDR_ID; |
| 793 | memset(&addr->addr, 0, sizeof(addr->addr)); | ||
| 793 | addr->addr.id.ref = msg_origport(msg); | 794 | addr->addr.id.ref = msg_origport(msg); |
| 794 | addr->addr.id.node = msg_orignode(msg); | 795 | addr->addr.id.node = msg_orignode(msg); |
| 795 | addr->addr.name.domain = 0; /* could leave uninitialized */ | 796 | addr->addr.name.domain = 0; /* could leave uninitialized */ |
| @@ -904,6 +905,9 @@ static int recv_msg(struct kiocb *iocb, struct socket *sock, | |||
| 904 | goto exit; | 905 | goto exit; |
| 905 | } | 906 | } |
| 906 | 907 | ||
| 908 | /* will be updated in set_orig_addr() if needed */ | ||
| 909 | m->msg_namelen = 0; | ||
| 910 | |||
| 907 | timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); | 911 | timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); |
| 908 | restart: | 912 | restart: |
| 909 | 913 | ||
| @@ -1013,6 +1017,9 @@ static int recv_stream(struct kiocb *iocb, struct socket *sock, | |||
| 1013 | goto exit; | 1017 | goto exit; |
| 1014 | } | 1018 | } |
| 1015 | 1019 | ||
| 1020 | /* will be updated in set_orig_addr() if needed */ | ||
| 1021 | m->msg_namelen = 0; | ||
| 1022 | |||
| 1016 | target = sock_rcvlowat(sk, flags & MSG_WAITALL, buf_len); | 1023 | target = sock_rcvlowat(sk, flags & MSG_WAITALL, buf_len); |
| 1017 | timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); | 1024 | timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); |
| 1018 | 1025 | ||
