2 files changed, 17 insertions, 23 deletions

diff --git a/net/tipc/eth_media.c b/net/tipc/eth_media.c
index f72ba774c246..524ba5696d4d 100644
--- a/net/tipc/eth_media.c
+++ b/net/tipc/eth_media.c
@@ -167,7 +167,7 @@ static int enable_bearer(struct tipc_bearer *tb_ptr)
         tb_ptr->mtu = dev->mtu;
         tb_ptr->blocked = 0;
         tb_ptr->addr.type = htonl(TIPC_MEDIA_TYPE_ETH);
-        memcpy(&tb_ptr->addr.dev_addr, &dev->dev_addr, ETH_ALEN);
+        memcpy(&tb_ptr->addr.dev_addr, dev->dev_addr, ETH_ALEN);
         return 0;
 }
 
diff --git a/net/tipc/netlink.c b/net/tipc/netlink.c
index c387217bb230..3c57005e44d1 100644
--- a/net/tipc/netlink.c
+++ b/net/tipc/netlink.c
@@ -68,7 +68,7 @@ static int handle_cmd(struct sk_buff *skb, struct genl_info *info)
         return 0;
 }
 
-static struct genl_family family = {
+static struct genl_family tipc_genl_family = {
         .id             = GENL_ID_GENERATE,
         .name           = TIPC_GENL_NAME,
         .version        = TIPC_GENL_VERSION,
@@ -76,39 +76,33 @@ static struct genl_family family = {
         .maxattr        = 0,
 };
 
-static struct genl_ops ops = {
+static struct genl_ops tipc_genl_ops = {
         .cmd            = TIPC_GENL_CMD,
         .doit           = handle_cmd,
 };
 
-static int family_registered = 0;
+static int tipc_genl_family_registered;
 
 int tipc_netlink_start(void)
 {
+        int res;
 
+        res = genl_register_family_with_ops(&tipc_genl_family,
+                &tipc_genl_ops, 1);
+        if (res) {
+                err("Failed to register netlink interface\n");
+                return res;
+        }
 
-        if (genl_register_family(&family))
-                goto err;
-
-        family_registered = 1;
-
-        if (genl_register_ops(&family, &ops))
-                goto err_unregister;
-
+        tipc_genl_family_registered = 1;
         return 0;
-
- err_unregister:
-        genl_unregister_family(&family);
-        family_registered = 0;
- err:
-        err("Failed to register netlink interface\n");
-        return -EFAULT;
 }
 
 void tipc_netlink_stop(void)
 {
-        if (family_registered) {
-                genl_unregister_family(&family);
-                family_registered = 0;
-        }
+        if (!tipc_genl_family_registered)
+                return;
+
+        genl_unregister_family(&tipc_genl_family);
+        tipc_genl_family_registered = 0;
 }