10 files changed, 187 insertions, 96 deletions

diff --git a/net/sunrpc/addr.c b/net/sunrpc/addr.c
index 4195233c4914..4548757c9871 100644
--- a/net/sunrpc/addr.c
+++ b/net/sunrpc/addr.c
@@ -255,12 +255,13 @@ EXPORT_SYMBOL_GPL(rpc_pton);
 /**
  * rpc_sockaddr2uaddr - Construct a universal address string from @sap.
  * @sap: socket address
+ * @gfp_flags: allocation mode
  *
  * Returns a %NUL-terminated string in dynamically allocated memory;
  * otherwise NULL is returned if an error occurred.  Caller must
  * free the returned string.
  */
-char *rpc_sockaddr2uaddr(const struct sockaddr *sap)
+char *rpc_sockaddr2uaddr(const struct sockaddr *sap, gfp_t gfp_flags)
 {
         char portbuf[RPCBIND_MAXUADDRPLEN];
         char addrbuf[RPCBIND_MAXUADDRLEN];
@@ -288,9 +289,8 @@ char *rpc_sockaddr2uaddr(const struct sockaddr *sap)
         if (strlcat(addrbuf, portbuf, sizeof(addrbuf)) > sizeof(addrbuf))
                 return NULL;
 
-        return kstrdup(addrbuf, GFP_KERNEL);
+        return kstrdup(addrbuf, gfp_flags);
 }
-EXPORT_SYMBOL_GPL(rpc_sockaddr2uaddr);
 
 /**
  * rpc_uaddr2sockaddr - convert a universal address to a socket address.
diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
index 364eb45e989d..afb56553dfe7 100644
--- a/net/sunrpc/auth_gss/auth_gss.c
+++ b/net/sunrpc/auth_gss/auth_gss.c
@@ -122,7 +122,7 @@ gss_cred_set_ctx(struct rpc_cred *cred, struct gss_cl_ctx *ctx)
         if (!test_bit(RPCAUTH_CRED_NEW, &cred->cr_flags))
                 return;
         gss_get_ctx(ctx);
-        rcu_assign_pointer(gss_cred->gc_ctx, ctx);
+        RCU_INIT_POINTER(gss_cred->gc_ctx, ctx);
         set_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags);
         smp_mb__before_clear_bit();
         clear_bit(RPCAUTH_CRED_NEW, &cred->cr_flags);
@@ -603,26 +603,6 @@ out:
         return err;
 }
 
-static ssize_t
-gss_pipe_upcall(struct file *filp, struct rpc_pipe_msg *msg,
-                char __user *dst, size_t buflen)
-{
-        char *data = (char *)msg->data + msg->copied;
-        size_t mlen = min(msg->len, buflen);
-        unsigned long left;
-
-        left = copy_to_user(dst, data, mlen);
-        if (left == mlen) {
-                msg->errno = -EFAULT;
-                return -EFAULT;
-        }
-
-        mlen -= left;
-        msg->copied += mlen;
-        msg->errno = 0;
-        return mlen;
-}
-
 #define MSG_BUF_MAXSIZE 1024
 
 static ssize_t
@@ -970,7 +950,7 @@ gss_destroy_nullcred(struct rpc_cred *cred)
         struct gss_auth *gss_auth = container_of(cred->cr_auth, struct gss_auth, rpc_auth);
         struct gss_cl_ctx *ctx = gss_cred->gc_ctx;
 
-        rcu_assign_pointer(gss_cred->gc_ctx, NULL);
+        RCU_INIT_POINTER(gss_cred->gc_ctx, NULL);
         call_rcu(&cred->cr_rcu, gss_free_cred_callback);
         if (ctx)
                 gss_put_ctx(ctx);
@@ -1590,7 +1570,7 @@ static const struct rpc_credops gss_nullops = {
 };
 
 static const struct rpc_pipe_ops gss_upcall_ops_v0 = {
-        .upcall         = gss_pipe_upcall,
+        .upcall         = rpc_pipe_generic_upcall,
         .downcall       = gss_pipe_downcall,
         .destroy_msg    = gss_pipe_destroy_msg,
         .open_pipe      = gss_pipe_open_v0,
@@ -1598,7 +1578,7 @@ static const struct rpc_pipe_ops gss_upcall_ops_v0 = {
 };
 
 static const struct rpc_pipe_ops gss_upcall_ops_v1 = {
-        .upcall         = gss_pipe_upcall,
+        .upcall         = rpc_pipe_generic_upcall,
         .downcall       = gss_pipe_downcall,
         .destroy_msg    = gss_pipe_destroy_msg,
         .open_pipe      = gss_pipe_open_v1,
diff --git a/net/sunrpc/auth_unix.c b/net/sunrpc/auth_unix.c
index 4cb70dc6e7ad..e50502d8ceb7 100644
--- a/net/sunrpc/auth_unix.c
+++ b/net/sunrpc/auth_unix.c
@@ -129,6 +129,9 @@ unx_match(struct auth_cred *acred, struct rpc_cred *rcred, int flags)
         for (i = 0; i < groups ; i++)
                 if (cred->uc_gids[i] != GROUP_AT(acred->group_info, i))
                         return 0;
+        if (groups < NFS_NGROUPS &&
+            cred->uc_gids[groups] != NOGROUP)
+                return 0;
         return 1;
 }
 
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index c5347d29cfb7..f0268ea7e711 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -850,7 +850,9 @@ rpc_restart_call_prepare(struct rpc_task *task)
 {
         if (RPC_ASSASSINATED(task))
                 return 0;
-        task->tk_action = rpc_prepare_task;
+        task->tk_action = call_start;
+        if (task->tk_ops->rpc_call_prepare != NULL)
+                task->tk_action = rpc_prepare_task;
         return 1;
 }
 EXPORT_SYMBOL_GPL(rpc_restart_call_prepare);
diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
index b181e3441323..bfddd68b31d3 100644
--- a/net/sunrpc/rpc_pipe.c
+++ b/net/sunrpc/rpc_pipe.c
@@ -77,6 +77,26 @@ rpc_timeout_upcall_queue(struct work_struct *work)
         rpc_purge_list(rpci, &free_list, destroy_msg, -ETIMEDOUT);
 }
 
+ssize_t rpc_pipe_generic_upcall(struct file *filp, struct rpc_pipe_msg *msg,
+                                char __user *dst, size_t buflen)
+{
+        char *data = (char *)msg->data + msg->copied;
+        size_t mlen = min(msg->len - msg->copied, buflen);
+        unsigned long left;
+
+        left = copy_to_user(dst, data, mlen);
+        if (left == mlen) {
+                msg->errno = -EFAULT;
+                return -EFAULT;
+        }
+
+        mlen -= left;
+        msg->copied += mlen;
+        msg->errno = 0;
+        return mlen;
+}
+EXPORT_SYMBOL_GPL(rpc_pipe_generic_upcall);
+
 /**
  * rpc_queue_upcall - queue an upcall message to userspace
  * @inode: inode of upcall pipe on which to queue given message
@@ -1084,3 +1104,6 @@ void unregister_rpc_pipefs(void)
         kmem_cache_destroy(rpc_inode_cachep);
         unregister_filesystem(&rpc_pipe_fs_type);
 }
+
+/* Make 'mount -t rpc_pipefs ...' autoload this module. */
+MODULE_ALIAS("rpc_pipefs");
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index e45d2fbbe5a8..8761bf8e36fc 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -114,6 +114,9 @@ static struct rpc_program	rpcb_program;
 static struct rpc_clnt *        rpcb_local_clnt;
 static struct rpc_clnt *        rpcb_local_clnt4;
 
+DEFINE_SPINLOCK(rpcb_clnt_lock);
+unsigned int                    rpcb_users;
+
 struct rpcbind_args {
         struct rpc_xprt *       r_xprt;
 
@@ -161,6 +164,56 @@ static void rpcb_map_release(void *data)
         kfree(map);
 }
 
+static int rpcb_get_local(void)
+{
+        int cnt;
+
+        spin_lock(&rpcb_clnt_lock);
+        if (rpcb_users)
+                rpcb_users++;
+        cnt = rpcb_users;
+        spin_unlock(&rpcb_clnt_lock);
+
+        return cnt;
+}
+
+void rpcb_put_local(void)
+{
+        struct rpc_clnt *clnt = rpcb_local_clnt;
+        struct rpc_clnt *clnt4 = rpcb_local_clnt4;
+        int shutdown;
+
+        spin_lock(&rpcb_clnt_lock);
+        if (--rpcb_users == 0) {
+                rpcb_local_clnt = NULL;
+                rpcb_local_clnt4 = NULL;
+        }
+        shutdown = !rpcb_users;
+        spin_unlock(&rpcb_clnt_lock);
+
+        if (shutdown) {
+                /*
+                 * cleanup_rpcb_clnt - remove xprtsock's sysctls, unregister
+                 */
+                if (clnt4)
+                        rpc_shutdown_client(clnt4);
+                if (clnt)
+                        rpc_shutdown_client(clnt);
+        }
+}
+
+static void rpcb_set_local(struct rpc_clnt *clnt, struct rpc_clnt *clnt4)
+{
+        /* Protected by rpcb_create_local_mutex */
+        rpcb_local_clnt = clnt;
+        rpcb_local_clnt4 = clnt4;
+        smp_wmb(); 
+        rpcb_users = 1;
+        dprintk("RPC:       created new rpcb local clients (rpcb_local_clnt: "
+                        "%p, rpcb_local_clnt4: %p)\n", rpcb_local_clnt,
+                        rpcb_local_clnt4);
+}
+
 /*
  * Returns zero on success, otherwise a negative errno value
  * is returned.
@@ -205,9 +258,7 @@ static int rpcb_create_local_unix(void)
                 clnt4 = NULL;
         }
 
-        /* Protected by rpcb_create_local_mutex */
-        rpcb_local_clnt = clnt;
-        rpcb_local_clnt4 = clnt4;
+        rpcb_set_local(clnt, clnt4);
 
 out:
         return result;
@@ -259,9 +310,7 @@ static int rpcb_create_local_net(void)
                 clnt4 = NULL;
         }
 
-        /* Protected by rpcb_create_local_mutex */
-        rpcb_local_clnt = clnt;
-        rpcb_local_clnt4 = clnt4;
+        rpcb_set_local(clnt, clnt4);
 
 out:
         return result;
@@ -271,16 +320,16 @@ out:
  * Returns zero on success, otherwise a negative errno value
  * is returned.
  */
-static int rpcb_create_local(void)
+int rpcb_create_local(void)
 {
         static DEFINE_MUTEX(rpcb_create_local_mutex);
         int result = 0;
 
-        if (rpcb_local_clnt)
+        if (rpcb_get_local())
                 return result;
 
         mutex_lock(&rpcb_create_local_mutex);
-        if (rpcb_local_clnt)
+        if (rpcb_get_local())
                 goto out;
 
         if (rpcb_create_local_unix() != 0)
@@ -382,11 +431,6 @@ int rpcb_register(u32 prog, u32 vers, int prot, unsigned short port)
         struct rpc_message msg = {
                 .rpc_argp       = &map,
         };
-        int error;
-
-        error = rpcb_create_local();
-        if (error)
-                return error;
 
         dprintk("RPC:       %sregistering (%u, %u, %d, %u) with local "
                         "rpcbind\n", (port ? "" : "un"),
@@ -410,7 +454,7 @@ static int rpcb_register_inet4(const struct sockaddr *sap,
         unsigned short port = ntohs(sin->sin_port);
         int result;
 
-        map->r_addr = rpc_sockaddr2uaddr(sap);
+        map->r_addr = rpc_sockaddr2uaddr(sap, GFP_KERNEL);
 
         dprintk("RPC:       %sregistering [%u, %u, %s, '%s'] with "
                 "local rpcbind\n", (port ? "" : "un"),
@@ -437,7 +481,7 @@ static int rpcb_register_inet6(const struct sockaddr *sap,
         unsigned short port = ntohs(sin6->sin6_port);
         int result;
 
-        map->r_addr = rpc_sockaddr2uaddr(sap);
+        map->r_addr = rpc_sockaddr2uaddr(sap, GFP_KERNEL);
 
         dprintk("RPC:       %sregistering [%u, %u, %s, '%s'] with "
                 "local rpcbind\n", (port ? "" : "un"),
@@ -522,11 +566,7 @@ int rpcb_v4_register(const u32 program, const u32 version,
         struct rpc_message msg = {
                 .rpc_argp       = &map,
         };
-        int error;
 
-        error = rpcb_create_local();
-        if (error)
-                return error;
         if (rpcb_local_clnt4 == NULL)
                 return -EPROTONOSUPPORT;
 
@@ -686,7 +726,7 @@ void rpcb_getport_async(struct rpc_task *task)
         case RPCBVERS_4:
         case RPCBVERS_3:
                 map->r_netid = rpc_peeraddr2str(clnt, RPC_DISPLAY_NETID);
-                map->r_addr = rpc_sockaddr2uaddr(sap);
+                map->r_addr = rpc_sockaddr2uaddr(sap, GFP_ATOMIC);
                 map->r_owner = "";
                 break;
         case RPCBVERS_2:
@@ -1060,15 +1100,3 @@ static struct rpc_program rpcb_program = {
         .version        = rpcb_version,
         .stats          = &rpcb_stats,
 };
-
-/**
- * cleanup_rpcb_clnt - remove xprtsock's sysctls, unregister
- *
- */
-void cleanup_rpcb_clnt(void)
-{
-        if (rpcb_local_clnt4)
-                rpc_shutdown_client(rpcb_local_clnt4);
-        if (rpcb_local_clnt)
-                rpc_shutdown_client(rpcb_local_clnt);
-}
diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c
index 9d0809160994..8ec9778c3f4a 100644
--- a/net/sunrpc/sunrpc_syms.c
+++ b/net/sunrpc/sunrpc_syms.c
@@ -61,8 +61,6 @@ static struct pernet_operations sunrpc_net_ops = {
 
 extern struct cache_detail unix_gid_cache;
 
-extern void cleanup_rpcb_clnt(void);
-
 static int __init
 init_sunrpc(void)
 {
@@ -102,7 +100,6 @@ out:
 static void __exit
 cleanup_sunrpc(void)
 {
-        cleanup_rpcb_clnt();
         rpcauth_remove_module();
         cleanup_socket_xprt();
         svc_cleanup_xprt_sock();
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 6a69a1131fb7..6e038884ae0c 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -295,6 +295,18 @@ svc_pool_map_put(void)
 }
 
 
+static int svc_pool_map_get_node(unsigned int pidx)
+{
+        const struct svc_pool_map *m = &svc_pool_map;
+
+        if (m->count) {
+                if (m->mode == SVC_POOL_PERCPU)
+                        return cpu_to_node(m->pool_to[pidx]);
+                if (m->mode == SVC_POOL_PERNODE)
+                        return m->pool_to[pidx];
+        }
+        return NUMA_NO_NODE;
+}
 /*
  * Set the given thread's cpus_allowed mask so that it
  * will only run on cpus in the given pool.
@@ -354,6 +366,42 @@ svc_pool_for_cpu(struct svc_serv *serv, int cpu)
         return &serv->sv_pools[pidx % serv->sv_nrpools];
 }
 
+static int svc_rpcb_setup(struct svc_serv *serv)
+{
+        int err;
+
+        err = rpcb_create_local();
+        if (err)
+                return err;
+
+        /* Remove any stale portmap registrations */
+        svc_unregister(serv);
+        return 0;
+}
+
+void svc_rpcb_cleanup(struct svc_serv *serv)
+{
+        svc_unregister(serv);
+        rpcb_put_local();
+}
+EXPORT_SYMBOL_GPL(svc_rpcb_cleanup);
+
+static int svc_uses_rpcbind(struct svc_serv *serv)
+{
+        struct svc_program      *progp;
+        unsigned int            i;
+
+        for (progp = serv->sv_program; progp; progp = progp->pg_next) {
+                for (i = 0; i < progp->pg_nvers; i++) {
+                        if (progp->pg_vers[i] == NULL)
+                                continue;
+                        if (progp->pg_vers[i]->vs_hidden == 0)
+                                return 1;
+                }
+        }
+
+        return 0;
+}
 
 /*
  * Create an RPC service
@@ -419,8 +467,15 @@ __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
                 spin_lock_init(&pool->sp_lock);
         }
 
-        /* Remove any stale portmap registrations */
-        svc_unregister(serv);
+        if (svc_uses_rpcbind(serv)) {
+                if (svc_rpcb_setup(serv) < 0) {
+                        kfree(serv->sv_pools);
+                        kfree(serv);
+                        return NULL;
+                }
+                if (!serv->sv_shutdown)
+                        serv->sv_shutdown = svc_rpcb_cleanup;
+        }
 
         return serv;
 }
@@ -488,7 +543,6 @@ svc_destroy(struct svc_serv *serv)
         if (svc_serv_is_pooled(serv))
                 svc_pool_map_put();
 
-        svc_unregister(serv);
         kfree(serv->sv_pools);
         kfree(serv);
 }
@@ -499,7 +553,7 @@ EXPORT_SYMBOL_GPL(svc_destroy);
  * We allocate pages and place them in rq_argpages.
  */
 static int
-svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
+svc_init_buffer(struct svc_rqst *rqstp, unsigned int size, int node)
 {
         unsigned int pages, arghi;
 
@@ -513,7 +567,7 @@ svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
         arghi = 0;
         BUG_ON(pages > RPCSVC_MAXPAGES);
         while (pages) {
-                struct page *p = alloc_page(GFP_KERNEL);
+                struct page *p = alloc_pages_node(node, GFP_KERNEL, 0);
                 if (!p)
                         break;
                 rqstp->rq_pages[arghi++] = p;
@@ -536,11 +590,11 @@ svc_release_buffer(struct svc_rqst *rqstp)
 }
 
 struct svc_rqst *
-svc_prepare_thread(struct svc_serv *serv, struct svc_pool *pool)
+svc_prepare_thread(struct svc_serv *serv, struct svc_pool *pool, int node)
 {
         struct svc_rqst *rqstp;
 
-        rqstp = kzalloc(sizeof(*rqstp), GFP_KERNEL);
+        rqstp = kzalloc_node(sizeof(*rqstp), GFP_KERNEL, node);
         if (!rqstp)
                 goto out_enomem;
 
@@ -554,15 +608,15 @@ svc_prepare_thread(struct svc_serv *serv, struct svc_pool *pool)
         rqstp->rq_server = serv;
         rqstp->rq_pool = pool;
 
-        rqstp->rq_argp = kmalloc(serv->sv_xdrsize, GFP_KERNEL);
+        rqstp->rq_argp = kmalloc_node(serv->sv_xdrsize, GFP_KERNEL, node);
         if (!rqstp->rq_argp)
                 goto out_thread;
 
-        rqstp->rq_resp = kmalloc(serv->sv_xdrsize, GFP_KERNEL);
+        rqstp->rq_resp = kmalloc_node(serv->sv_xdrsize, GFP_KERNEL, node);
         if (!rqstp->rq_resp)
                 goto out_thread;
 
-        if (!svc_init_buffer(rqstp, serv->sv_max_mesg))
+        if (!svc_init_buffer(rqstp, serv->sv_max_mesg, node))
                 goto out_thread;
 
         return rqstp;
@@ -647,6 +701,7 @@ svc_set_num_threads(struct svc_serv *serv, struct svc_pool *pool, int nrservs)
         struct svc_pool *chosen_pool;
         int error = 0;
         unsigned int state = serv->sv_nrthreads-1;
+        int node;
 
         if (pool == NULL) {
                 /* The -1 assumes caller has done a svc_get() */
@@ -662,14 +717,16 @@ svc_set_num_threads(struct svc_serv *serv, struct svc_pool *pool, int nrservs)
                 nrservs--;
                 chosen_pool = choose_pool(serv, pool, &state);
 
-                rqstp = svc_prepare_thread(serv, chosen_pool);
+                node = svc_pool_map_get_node(chosen_pool->sp_id);
+                rqstp = svc_prepare_thread(serv, chosen_pool, node);
                 if (IS_ERR(rqstp)) {
                         error = PTR_ERR(rqstp);
                         break;
                 }
 
                 __module_get(serv->sv_module);
-                task = kthread_create(serv->sv_function, rqstp, serv->sv_name);
+                task = kthread_create_on_node(serv->sv_function, rqstp,
+                                              node, serv->sv_name);
                 if (IS_ERR(task)) {
                         error = PTR_ERR(task);
                         module_put(serv->sv_module);
@@ -956,9 +1013,8 @@ static void svc_unregister(const struct svc_serv *serv)
 /*
  * Printk the given error with the address of the client that caused it.
  */
-static int
-__attribute__ ((format (printf, 2, 3)))
-svc_printk(struct svc_rqst *rqstp, const char *fmt, ...)
+static __printf(2, 3)
+int svc_printk(struct svc_rqst *rqstp, const char *fmt, ...)
 {
         va_list args;
         int     r;
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index bd31208bbb61..d86bb673e1f6 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -254,8 +254,6 @@ EXPORT_SYMBOL_GPL(svc_create_xprt);
  */
 void svc_xprt_copy_addrs(struct svc_rqst *rqstp, struct svc_xprt *xprt)
 {
-        struct sockaddr *sin;
-
         memcpy(&rqstp->rq_addr, &xprt->xpt_remote, xprt->xpt_remotelen);
         rqstp->rq_addrlen = xprt->xpt_remotelen;
 
@@ -263,15 +261,8 @@ void svc_xprt_copy_addrs(struct svc_rqst *rqstp, struct svc_xprt *xprt)
          * Destination address in request is needed for binding the
          * source address in RPC replies/callbacks later.
          */
-        sin = (struct sockaddr *)&xprt->xpt_local;
-        switch (sin->sa_family) {
-        case AF_INET:
-                rqstp->rq_daddr.addr = ((struct sockaddr_in *)sin)->sin_addr;
-                break;
-        case AF_INET6:
-                rqstp->rq_daddr.addr6 = ((struct sockaddr_in6 *)sin)->sin6_addr;
-                break;
-        }
+        memcpy(&rqstp->rq_daddr, &xprt->xpt_local, xprt->xpt_locallen);
+        rqstp->rq_daddrlen = xprt->xpt_locallen;
 }
 EXPORT_SYMBOL_GPL(svc_xprt_copy_addrs);
 
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index 767d494de7a2..dfd686eb0b7f 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -143,19 +143,20 @@ static void svc_set_cmsg_data(struct svc_rqst *rqstp, struct cmsghdr *cmh)
                         cmh->cmsg_level = SOL_IP;
                         cmh->cmsg_type = IP_PKTINFO;
                         pki->ipi_ifindex = 0;
-                        pki->ipi_spec_dst.s_addr = rqstp->rq_daddr.addr.s_addr;
+                        pki->ipi_spec_dst.s_addr =
+                                 svc_daddr_in(rqstp)->sin_addr.s_addr;
                         cmh->cmsg_len = CMSG_LEN(sizeof(*pki));
                 }
                 break;
 
         case AF_INET6: {
                         struct in6_pktinfo *pki = CMSG_DATA(cmh);
+                        struct sockaddr_in6 *daddr = svc_daddr_in6(rqstp);
 
                         cmh->cmsg_level = SOL_IPV6;
                         cmh->cmsg_type = IPV6_PKTINFO;
-                        pki->ipi6_ifindex = 0;
-                        ipv6_addr_copy(&pki->ipi6_addr,
-                                        &rqstp->rq_daddr.addr6);
+                        pki->ipi6_ifindex = daddr->sin6_scope_id;
+                        ipv6_addr_copy(&pki->ipi6_addr, &daddr->sin6_addr);
                         cmh->cmsg_len = CMSG_LEN(sizeof(*pki));
                 }
                 break;
@@ -498,9 +499,13 @@ static int svc_udp_get_dest_address4(struct svc_rqst *rqstp,
                                      struct cmsghdr *cmh)
 {
         struct in_pktinfo *pki = CMSG_DATA(cmh);
+        struct sockaddr_in *daddr = svc_daddr_in(rqstp);
+
         if (cmh->cmsg_type != IP_PKTINFO)
                 return 0;
-        rqstp->rq_daddr.addr.s_addr = pki->ipi_spec_dst.s_addr;
+
+        daddr->sin_family = AF_INET;
+        daddr->sin_addr.s_addr = pki->ipi_spec_dst.s_addr;
         return 1;
 }
 
@@ -511,9 +516,14 @@ static int svc_udp_get_dest_address6(struct svc_rqst *rqstp,
                                      struct cmsghdr *cmh)
 {
         struct in6_pktinfo *pki = CMSG_DATA(cmh);
+        struct sockaddr_in6 *daddr = svc_daddr_in6(rqstp);
+
         if (cmh->cmsg_type != IPV6_PKTINFO)
                 return 0;
-        ipv6_addr_copy(&rqstp->rq_daddr.addr6, &pki->ipi6_addr);
+
+        daddr->sin6_family = AF_INET6;
+        ipv6_addr_copy(&daddr->sin6_addr, &pki->ipi6_addr);
+        daddr->sin6_scope_id = pki->ipi6_ifindex;
         return 1;
 }
 
@@ -614,6 +624,7 @@ static int svc_udp_recvfrom(struct svc_rqst *rqstp)
                 skb_free_datagram_locked(svsk->sk_sk, skb);
                 return 0;
         }
+        rqstp->rq_daddrlen = svc_addr_len(svc_daddr(rqstp));
 
         if (skb_is_nonlinear(skb)) {
                 /* we have to copy */