1 files changed, 51 insertions, 29 deletions

diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
index c64c0ef519b5..0cbcd1ab49ab 100644
--- a/net/sunrpc/xprt.c
+++ b/net/sunrpc/xprt.c
@@ -66,6 +66,7 @@ static void	 xprt_init(struct rpc_xprt *xprt, struct net *net);
 static void     xprt_request_init(struct rpc_task *, struct rpc_xprt *);
 static void     xprt_connect_status(struct rpc_task *task);
 static int      __xprt_get_cong(struct rpc_xprt *, struct rpc_task *);
+static void      xprt_destroy(struct rpc_xprt *xprt);
 
 static DEFINE_SPINLOCK(xprt_list_lock);
 static LIST_HEAD(xprt_list);
@@ -292,54 +293,57 @@ static inline int xprt_lock_write(struct rpc_xprt *xprt, struct rpc_task *task)
         return retval;
 }
 
-static void __xprt_lock_write_next(struct rpc_xprt *xprt)
+static bool __xprt_lock_write_func(struct rpc_task *task, void *data)
 {
-        struct rpc_task *task;
+        struct rpc_xprt *xprt = data;
         struct rpc_rqst *req;
 
-        if (test_and_set_bit(XPRT_LOCKED, &xprt->state))
-                return;
-
-        task = rpc_wake_up_next(&xprt->sending);
-        if (task == NULL)
-                goto out_unlock;
-
         req = task->tk_rqstp;
         xprt->snd_task = task;
         if (req) {
                 req->rq_bytes_sent = 0;
                 req->rq_ntrans++;
         }
-        return;
+        return true;
+}
 
-out_unlock:
+static void __xprt_lock_write_next(struct rpc_xprt *xprt)
+{
+        if (test_and_set_bit(XPRT_LOCKED, &xprt->state))
+                return;
+
+        if (rpc_wake_up_first(&xprt->sending, __xprt_lock_write_func, xprt))
+                return;
         xprt_clear_locked(xprt);
 }
 
-static void __xprt_lock_write_next_cong(struct rpc_xprt *xprt)
+static bool __xprt_lock_write_cong_func(struct rpc_task *task, void *data)
 {
-        struct rpc_task *task;
+        struct rpc_xprt *xprt = data;
         struct rpc_rqst *req;
 
-        if (test_and_set_bit(XPRT_LOCKED, &xprt->state))
-                return;
-        if (RPCXPRT_CONGESTED(xprt))
-                goto out_unlock;
-        task = rpc_wake_up_next(&xprt->sending);
-        if (task == NULL)
-                goto out_unlock;
-
         req = task->tk_rqstp;
         if (req == NULL) {
                 xprt->snd_task = task;
-                return;
+                return true;
         }
         if (__xprt_get_cong(xprt, task)) {
                 xprt->snd_task = task;
                 req->rq_bytes_sent = 0;
                 req->rq_ntrans++;
-                return;
+                return true;
         }
+        return false;
+}
+
+static void __xprt_lock_write_next_cong(struct rpc_xprt *xprt)
+{
+        if (test_and_set_bit(XPRT_LOCKED, &xprt->state))
+                return;
+        if (RPCXPRT_CONGESTED(xprt))
+                goto out_unlock;
+        if (rpc_wake_up_first(&xprt->sending, __xprt_lock_write_cong_func, xprt))
+                return;
 out_unlock:
         xprt_clear_locked(xprt);
 }
@@ -712,9 +716,7 @@ void xprt_connect(struct rpc_task *task)
         if (xprt_connected(xprt))
                 xprt_release_write(xprt, task);
         else {
-                if (task->tk_rqstp)
-                        task->tk_rqstp->rq_bytes_sent = 0;
-
+                task->tk_rqstp->rq_bytes_sent = 0;
                 task->tk_timeout = task->tk_rqstp->rq_timeout;
                 rpc_sleep_on(&xprt->pending, task, xprt_connect_status);
 
@@ -750,7 +752,7 @@ static void xprt_connect_status(struct rpc_task *task)
         default:
                 dprintk("RPC: %5u xprt_connect_status: error %d connecting to "
                                 "server %s\n", task->tk_pid, -task->tk_status,
-                                task->tk_client->cl_server);
+                                xprt->servername);
                 xprt_release_write(xprt, task);
                 task->tk_status = -EIO;
         }
@@ -884,7 +886,7 @@ void xprt_transmit(struct rpc_task *task)
 {
         struct rpc_rqst *req = task->tk_rqstp;
         struct rpc_xprt *xprt = req->rq_xprt;
-        int status;
+        int status, numreqs;
 
         dprintk("RPC: %5u xprt_transmit(%u)\n", task->tk_pid, req->rq_slen);
 
@@ -921,9 +923,14 @@ void xprt_transmit(struct rpc_task *task)
 
         xprt->ops->set_retrans_timeout(task);
 
+        numreqs = atomic_read(&xprt->num_reqs);
+        if (numreqs > xprt->stat.max_slots)
+                xprt->stat.max_slots = numreqs;
         xprt->stat.sends++;
         xprt->stat.req_u += xprt->stat.sends - xprt->stat.recvs;
         xprt->stat.bklog_u += xprt->backlog.qlen;
+        xprt->stat.sending_u += xprt->sending.qlen;
+        xprt->stat.pending_u += xprt->pending.qlen;
 
         /* Don't race with disconnect */
         if (!xprt_connected(xprt))
@@ -1131,7 +1138,10 @@ void xprt_release(struct rpc_task *task)
                 return;
 
         xprt = req->rq_xprt;
-        rpc_count_iostats(task);
+        if (task->tk_ops->rpc_count_stats != NULL)
+                task->tk_ops->rpc_count_stats(task, task->tk_calldata);
+        else if (task->tk_client)
+                rpc_count_iostats(task, task->tk_client->cl_metrics);
         spin_lock_bh(&xprt->transport_lock);
         xprt->ops->release_xprt(xprt, task);
         if (xprt->ops->release_request)
@@ -1220,6 +1230,17 @@ found:
                             (unsigned long)xprt);
         else
                 init_timer(&xprt->timer);
+
+        if (strlen(args->servername) > RPC_MAXNETNAMELEN) {
+                xprt_destroy(xprt);
+                return ERR_PTR(-EINVAL);
+        }
+        xprt->servername = kstrdup(args->servername, GFP_KERNEL);
+        if (xprt->servername == NULL) {
+                xprt_destroy(xprt);
+                return ERR_PTR(-ENOMEM);
+        }
+
         dprintk("RPC:       created transport %p with %u slots\n", xprt,
                         xprt->max_reqs);
 out:
@@ -1242,6 +1263,7 @@ static void xprt_destroy(struct rpc_xprt *xprt)
         rpc_destroy_wait_queue(&xprt->sending);
         rpc_destroy_wait_queue(&xprt->backlog);
         cancel_work_sync(&xprt->task_cleanup);
+        kfree(xprt->servername);
         /*
          * Tear down transport state and free the rpc_xprt
          */