1 files changed, 68 insertions, 53 deletions

diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index 24db2b4d12d3..41013dd66ac3 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -20,6 +20,7 @@
 #include <linux/in6.h>
 #include <linux/kernel.h>
 #include <linux/errno.h>
+#include <net/ipv6.h>
 
 #include <linux/sunrpc/clnt.h>
 #include <linux/sunrpc/sched.h>
@@ -176,13 +177,12 @@ static struct rpc_clnt *rpcb_create(char *hostname, struct sockaddr *srvaddr,
 }
 
 static int rpcb_register_call(struct sockaddr *addr, size_t addrlen,
-                              u32 version, struct rpc_message *msg,
-                              int *result)
+                              u32 version, struct rpc_message *msg)
 {
         struct rpc_clnt *rpcb_clnt;
-        int error = 0;
+        int result, error = 0;
 
-        *result = 0;
+        msg->rpc_resp = &result;
 
         rpcb_clnt = rpcb_create_local(addr, addrlen, version);
         if (!IS_ERR(rpcb_clnt)) {
@@ -191,12 +191,15 @@ static int rpcb_register_call(struct sockaddr *addr, size_t addrlen,
         } else
                 error = PTR_ERR(rpcb_clnt);
 
-        if (error < 0)
+        if (error < 0) {
                 printk(KERN_WARNING "RPC: failed to contact local rpcbind "
                                 "server (errno %d).\n", -error);
-        dprintk("RPC:       registration status %d/%d\n", error, *result);
+                return error;
+        }
 
-        return error;
+        if (!result)
+                return -EACCES;
+        return 0;
 }
 
 /**
@@ -205,7 +208,11 @@ static int rpcb_register_call(struct sockaddr *addr, size_t addrlen,
  * @vers: RPC version number to bind
  * @prot: transport protocol to register
  * @port: port value to register
- * @okay: OUT: result code
+ *
+ * Returns zero if the registration request was dispatched successfully
+ * and the rpcbind daemon returned success.  Otherwise, returns an errno
+ * value that reflects the nature of the error (request could not be
+ * dispatched, timed out, or rpcbind returned an error).
  *
  * RPC services invoke this function to advertise their contact
  * information via the system's rpcbind daemon.  RPC services
@@ -217,15 +224,6 @@ static int rpcb_register_call(struct sockaddr *addr, size_t addrlen,
  * all registered transports for [program, version] from the local
  * rpcbind database.
  *
- * Returns zero if the registration request was dispatched
- * successfully and a reply was received.  The rpcbind daemon's
- * boolean result code is stored in *okay.
- *
- * Returns an errno value and sets *result to zero if there was
- * some problem that prevented the rpcbind request from being
- * dispatched, or if the rpcbind daemon did not respond within
- * the timeout.
- *
  * This function uses rpcbind protocol version 2 to contact the
  * local rpcbind daemon.
  *
@@ -236,7 +234,7 @@ static int rpcb_register_call(struct sockaddr *addr, size_t addrlen,
  * IN6ADDR_ANY (ie available for all AF_INET and AF_INET6
  * addresses).
  */
-int rpcb_register(u32 prog, u32 vers, int prot, unsigned short port, int *okay)
+int rpcb_register(u32 prog, u32 vers, int prot, unsigned short port)
 {
         struct rpcbind_args map = {
                 .r_prog         = prog,
@@ -246,7 +244,6 @@ int rpcb_register(u32 prog, u32 vers, int prot, unsigned short port, int *okay)
         };
         struct rpc_message msg = {
                 .rpc_argp       = &map,
-                .rpc_resp       = okay,
         };
 
         dprintk("RPC:       %sregistering (%u, %u, %d, %u) with local "
@@ -259,7 +256,7 @@ int rpcb_register(u32 prog, u32 vers, int prot, unsigned short port, int *okay)
 
         return rpcb_register_call((struct sockaddr *)&rpcb_inaddr_loopback,
                                         sizeof(rpcb_inaddr_loopback),
-                                        RPCBVERS_2, &msg, okay);
+                                        RPCBVERS_2, &msg);
 }
 
 /*
@@ -290,7 +287,7 @@ static int rpcb_register_netid4(struct sockaddr_in *address_to_register,
 
         return rpcb_register_call((struct sockaddr *)&rpcb_inaddr_loopback,
                                         sizeof(rpcb_inaddr_loopback),
-                                        RPCBVERS_4, msg, msg->rpc_resp);
+                                        RPCBVERS_4, msg);
 }
 
 /*
@@ -304,10 +301,13 @@ static int rpcb_register_netid6(struct sockaddr_in6 *address_to_register,
         char buf[64];
 
         /* Construct AF_INET6 universal address */
-        snprintf(buf, sizeof(buf),
-                        NIP6_FMT".%u.%u",
-                        NIP6(address_to_register->sin6_addr),
-                        port >> 8, port & 0xff);
+        if (ipv6_addr_any(&address_to_register->sin6_addr))
+                snprintf(buf, sizeof(buf), "::.%u.%u",
+                                port >> 8, port & 0xff);
+        else
+                snprintf(buf, sizeof(buf), NIP6_FMT".%u.%u",
+                                NIP6(address_to_register->sin6_addr),
+                                port >> 8, port & 0xff);
         map->r_addr = buf;
 
         dprintk("RPC:       %sregistering [%u, %u, %s, '%s'] with "
@@ -321,7 +321,7 @@ static int rpcb_register_netid6(struct sockaddr_in6 *address_to_register,
 
         return rpcb_register_call((struct sockaddr *)&rpcb_in6addr_loopback,
                                         sizeof(rpcb_in6addr_loopback),
-                                        RPCBVERS_4, msg, msg->rpc_resp);
+                                        RPCBVERS_4, msg);
 }
 
 /**
@@ -330,7 +330,11 @@ static int rpcb_register_netid6(struct sockaddr_in6 *address_to_register,
  * @version: RPC version number of service to (un)register
  * @address: address family, IP address, and port to (un)register
  * @netid: netid of transport protocol to (un)register
- * @result: result code from rpcbind RPC call
+ *
+ * Returns zero if the registration request was dispatched successfully
+ * and the rpcbind daemon returned success.  Otherwise, returns an errno
+ * value that reflects the nature of the error (request could not be
+ * dispatched, timed out, or rpcbind returned an error).
  *
  * RPC services invoke this function to advertise their contact
  * information via the system's rpcbind daemon.  RPC services
@@ -342,15 +346,6 @@ static int rpcb_register_netid6(struct sockaddr_in6 *address_to_register,
  * to zero.  Callers pass a netid of "" to unregister all
  * transport netids associated with [program, version, address].
  *
- * Returns zero if the registration request was dispatched
- * successfully and a reply was received.  The rpcbind daemon's
- * result code is stored in *result.
- *
- * Returns an errno value and sets *result to zero if there was
- * some problem that prevented the rpcbind request from being
- * dispatched, or if the rpcbind daemon did not respond within
- * the timeout.
- *
  * This function uses rpcbind protocol version 4 to contact the
  * local rpcbind daemon.  The local rpcbind daemon must support
  * version 4 of the rpcbind protocol in order for these functions
@@ -372,8 +367,7 @@ static int rpcb_register_netid6(struct sockaddr_in6 *address_to_register,
  * advertises the service on all IPv4 and IPv6 addresses.
  */
 int rpcb_v4_register(const u32 program, const u32 version,
-                     const struct sockaddr *address, const char *netid,
-                     int *result)
+                     const struct sockaddr *address, const char *netid)
 {
         struct rpcbind_args map = {
                 .r_prog         = program,
@@ -383,11 +377,8 @@ int rpcb_v4_register(const u32 program, const u32 version,
         };
         struct rpc_message msg = {
                 .rpc_argp       = &map,
-                .rpc_resp       = result,
         };
 
-        *result = 0;
-
         switch (address->sa_family) {
         case AF_INET:
                 return rpcb_register_netid4((struct sockaddr_in *)address,
@@ -469,6 +460,28 @@ static struct rpc_task *rpcb_call_async(struct rpc_clnt *rpcb_clnt, struct rpcbi
         return rpc_run_task(&task_setup_data);
 }
 
+/*
+ * In the case where rpc clients have been cloned, we want to make
+ * sure that we use the program number/version etc of the actual
+ * owner of the xprt. To do so, we walk back up the tree of parents
+ * to find whoever created the transport and/or whoever has the
+ * autobind flag set.
+ */
+static struct rpc_clnt *rpcb_find_transport_owner(struct rpc_clnt *clnt)
+{
+        struct rpc_clnt *parent = clnt->cl_parent;
+
+        while (parent != clnt) {
+                if (parent->cl_xprt != clnt->cl_xprt)
+                        break;
+                if (clnt->cl_autobind)
+                        break;
+                clnt = parent;
+                parent = parent->cl_parent;
+        }
+        return clnt;
+}
+
 /**
  * rpcb_getport_async - obtain the port for a given RPC service on a given host
  * @task: task that is waiting for portmapper request
@@ -478,10 +491,10 @@ static struct rpc_task *rpcb_call_async(struct rpc_clnt *rpcb_clnt, struct rpcbi
  */
 void rpcb_getport_async(struct rpc_task *task)
 {
-        struct rpc_clnt *clnt = task->tk_client;
+        struct rpc_clnt *clnt;
         struct rpc_procinfo *proc;
         u32 bind_version;
-        struct rpc_xprt *xprt = task->tk_xprt;
+        struct rpc_xprt *xprt;
         struct rpc_clnt *rpcb_clnt;
         static struct rpcbind_args *map;
         struct rpc_task *child;
@@ -490,13 +503,13 @@ void rpcb_getport_async(struct rpc_task *task)
         size_t salen;
         int status;
 
+        clnt = rpcb_find_transport_owner(task->tk_client);
+        xprt = clnt->cl_xprt;
+
         dprintk("RPC: %5u %s(%s, %u, %u, %d)\n",
                 task->tk_pid, __func__,
                 clnt->cl_server, clnt->cl_prog, clnt->cl_vers, xprt->prot);
 
-        /* Autobind on cloned rpc clients is discouraged */
-        BUG_ON(clnt->cl_parent != clnt);
-
         /* Put self on the wait queue to ensure we get notified if
          * some other task is already attempting to bind the port */
         rpc_sleep_on(&xprt->binding, task, NULL);
@@ -558,7 +571,7 @@ void rpcb_getport_async(struct rpc_task *task)
                 status = -ENOMEM;
                 dprintk("RPC: %5u %s: no memory available\n",
                         task->tk_pid, __func__);
-                goto bailout_nofree;
+                goto bailout_release_client;
         }
         map->r_prog = clnt->cl_prog;
         map->r_vers = clnt->cl_vers;
@@ -578,11 +591,13 @@ void rpcb_getport_async(struct rpc_task *task)
                         task->tk_pid, __func__);
                 return;
         }
-        rpc_put_task(child);
 
-        task->tk_xprt->stat.bind_count++;
+        xprt->stat.bind_count++;
+        rpc_put_task(child);
         return;
 
+bailout_release_client:
+        rpc_release_client(rpcb_clnt);
 bailout_nofree:
         rpcb_wake_rpcbind_waiters(xprt, status);
         task->tk_status = status;
@@ -633,7 +648,7 @@ static void rpcb_getport_done(struct rpc_task *child, void *data)
 static int rpcb_encode_mapping(struct rpc_rqst *req, __be32 *p,
                                struct rpcbind_args *rpcb)
 {
-        dprintk("RPC:       rpcb_encode_mapping(%u, %u, %d, %u)\n",
+        dprintk("RPC:       encoding rpcb request (%u, %u, %d, %u)\n",
                         rpcb->r_prog, rpcb->r_vers, rpcb->r_prot, rpcb->r_port);
         *p++ = htonl(rpcb->r_prog);
         *p++ = htonl(rpcb->r_vers);
@@ -648,7 +663,7 @@ static int rpcb_decode_getport(struct rpc_rqst *req, __be32 *p,
                                unsigned short *portp)
 {
         *portp = (unsigned short) ntohl(*p++);
-        dprintk("RPC:       rpcb_decode_getport result %u\n",
+        dprintk("RPC:       rpcb getport result: %u\n",
                         *portp);
         return 0;
 }
@@ -657,7 +672,7 @@ static int rpcb_decode_set(struct rpc_rqst *req, __be32 *p,
                            unsigned int *boolp)
 {
         *boolp = (unsigned int) ntohl(*p++);
-        dprintk("RPC:       rpcb_decode_set: call %s\n",
+        dprintk("RPC:       rpcb set/unset call %s\n",
                         (*boolp ? "succeeded" : "failed"));
         return 0;
 }
@@ -665,7 +680,7 @@ static int rpcb_decode_set(struct rpc_rqst *req, __be32 *p,
 static int rpcb_encode_getaddr(struct rpc_rqst *req, __be32 *p,
                                struct rpcbind_args *rpcb)
 {
-        dprintk("RPC:       rpcb_encode_getaddr(%u, %u, %s)\n",
+        dprintk("RPC:       encoding rpcb request (%u, %u, %s)\n",
                         rpcb->r_prog, rpcb->r_vers, rpcb->r_addr);
         *p++ = htonl(rpcb->r_prog);
         *p++ = htonl(rpcb->r_vers);