2 files changed, 4 insertions, 16 deletions

diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 43cd0dd9149d..fa261a3594c2 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -66,13 +66,6 @@ static void sctp_assoc_bh_rcv(struct work_struct *work);
 static void sctp_assoc_free_asconf_acks(struct sctp_association *asoc);
 static void sctp_assoc_free_asconf_queue(struct sctp_association *asoc);
 
-/* Keep track of the new idr low so that we don't re-use association id
- * numbers too fast.  It is protected by they idr spin lock is in the
- * range of 1 - INT_MAX.
- */
-static u32 idr_low = 1;
-
-
 /* 1st Level Abstractions. */
 
 /* Initialize a new association from provided memory. */
@@ -1079,7 +1072,7 @@ struct sctp_transport *sctp_assoc_lookup_tsn(struct sctp_association *asoc,
                         transports) {
 
                 if (transport == active)
-                        break;
+                        continue;
                 list_for_each_entry(chunk, &transport->transmitted,
                                 transmitted_list) {
                         if (key == chunk->subh.data_hdr->tsn) {
@@ -1601,13 +1594,8 @@ int sctp_assoc_set_id(struct sctp_association *asoc, gfp_t gfp)
         if (preload)
                 idr_preload(gfp);
         spin_lock_bh(&sctp_assocs_id_lock);
-        /* 0 is not a valid id, idr_low is always >= 1 */
-        ret = idr_alloc(&sctp_assocs_id, asoc, idr_low, 0, GFP_NOWAIT);
-        if (ret >= 0) {
-                idr_low = ret + 1;
-                if (idr_low == INT_MAX)
-                        idr_low = 1;
-        }
+        /* 0 is not a valid assoc_id, must be >= 1 */
+        ret = idr_alloc_cyclic(&sctp_assocs_id, asoc, 1, 0, GFP_NOWAIT);
         spin_unlock_bh(&sctp_assocs_id_lock);
         if (preload)
                 idr_preload_end();
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index 5131fcfedb03..de1a0138317f 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -2082,7 +2082,7 @@ sctp_disposition_t sctp_sf_do_5_2_4_dupcook(struct net *net,
         }
 
         /* Delete the tempory new association. */
-        sctp_add_cmd_sf(commands, SCTP_CMD_NEW_ASOC, SCTP_ASOC(new_asoc));
+        sctp_add_cmd_sf(commands, SCTP_CMD_SET_ASOC, SCTP_ASOC(new_asoc));
         sctp_add_cmd_sf(commands, SCTP_CMD_DELETE_TCB, SCTP_NULL());
 
         /* Restore association pointer to provide SCTP command interpeter