diff options
Diffstat (limited to 'net/rds/tcp_recv.c')
| -rw-r--r-- | net/rds/tcp_recv.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/net/rds/tcp_recv.c b/net/rds/tcp_recv.c index 1aba6878fa5d..7017f3af80b6 100644 --- a/net/rds/tcp_recv.c +++ b/net/rds/tcp_recv.c | |||
| @@ -39,7 +39,7 @@ | |||
| 39 | 39 | ||
| 40 | static struct kmem_cache *rds_tcp_incoming_slab; | 40 | static struct kmem_cache *rds_tcp_incoming_slab; |
| 41 | 41 | ||
| 42 | void rds_tcp_inc_purge(struct rds_incoming *inc) | 42 | static void rds_tcp_inc_purge(struct rds_incoming *inc) |
| 43 | { | 43 | { |
| 44 | struct rds_tcp_incoming *tinc; | 44 | struct rds_tcp_incoming *tinc; |
| 45 | tinc = container_of(inc, struct rds_tcp_incoming, ti_inc); | 45 | tinc = container_of(inc, struct rds_tcp_incoming, ti_inc); |
| @@ -190,10 +190,10 @@ static int rds_tcp_data_recv(read_descriptor_t *desc, struct sk_buff *skb, | |||
| 190 | * processing. | 190 | * processing. |
| 191 | */ | 191 | */ |
| 192 | while (left) { | 192 | while (left) { |
| 193 | if (tinc == NULL) { | 193 | if (!tinc) { |
| 194 | tinc = kmem_cache_alloc(rds_tcp_incoming_slab, | 194 | tinc = kmem_cache_alloc(rds_tcp_incoming_slab, |
| 195 | arg->gfp); | 195 | arg->gfp); |
| 196 | if (tinc == NULL) { | 196 | if (!tinc) { |
| 197 | desc->error = -ENOMEM; | 197 | desc->error = -ENOMEM; |
| 198 | goto out; | 198 | goto out; |
| 199 | } | 199 | } |
| @@ -229,7 +229,7 @@ static int rds_tcp_data_recv(read_descriptor_t *desc, struct sk_buff *skb, | |||
| 229 | 229 | ||
| 230 | if (left && tc->t_tinc_data_rem) { | 230 | if (left && tc->t_tinc_data_rem) { |
| 231 | clone = skb_clone(skb, arg->gfp); | 231 | clone = skb_clone(skb, arg->gfp); |
| 232 | if (clone == NULL) { | 232 | if (!clone) { |
| 233 | desc->error = -ENOMEM; | 233 | desc->error = -ENOMEM; |
| 234 | goto out; | 234 | goto out; |
| 235 | } | 235 | } |
| @@ -326,7 +326,7 @@ void rds_tcp_data_ready(struct sock *sk, int bytes) | |||
| 326 | 326 | ||
| 327 | read_lock(&sk->sk_callback_lock); | 327 | read_lock(&sk->sk_callback_lock); |
| 328 | conn = sk->sk_user_data; | 328 | conn = sk->sk_user_data; |
| 329 | if (conn == NULL) { /* check for teardown race */ | 329 | if (!conn) { /* check for teardown race */ |
| 330 | ready = sk->sk_data_ready; | 330 | ready = sk->sk_data_ready; |
| 331 | goto out; | 331 | goto out; |
| 332 | } | 332 | } |
| @@ -342,12 +342,12 @@ out: | |||
| 342 | ready(sk, bytes); | 342 | ready(sk, bytes); |
| 343 | } | 343 | } |
| 344 | 344 | ||
| 345 | int __init rds_tcp_recv_init(void) | 345 | int rds_tcp_recv_init(void) |
| 346 | { | 346 | { |
| 347 | rds_tcp_incoming_slab = kmem_cache_create("rds_tcp_incoming", | 347 | rds_tcp_incoming_slab = kmem_cache_create("rds_tcp_incoming", |
| 348 | sizeof(struct rds_tcp_incoming), | 348 | sizeof(struct rds_tcp_incoming), |
| 349 | 0, 0, NULL); | 349 | 0, 0, NULL); |
| 350 | if (rds_tcp_incoming_slab == NULL) | 350 | if (!rds_tcp_incoming_slab) |
| 351 | return -ENOMEM; | 351 | return -ENOMEM; |
| 352 | return 0; | 352 | return 0; |
| 353 | } | 353 | } |
