diff options
Diffstat (limited to 'net/rds/send.c')
-rw-r--r-- | net/rds/send.c | 27 |
1 files changed, 13 insertions, 14 deletions
diff --git a/net/rds/send.c b/net/rds/send.c index 28c88ff3d038..b2fccfc20769 100644 --- a/net/rds/send.c +++ b/net/rds/send.c | |||
@@ -235,8 +235,8 @@ int rds_send_xmit(struct rds_connection *conn) | |||
235 | * connection. | 235 | * connection. |
236 | * Therefore, we never retransmit messages with RDMA ops. | 236 | * Therefore, we never retransmit messages with RDMA ops. |
237 | */ | 237 | */ |
238 | if (rm->m_rdma_op | 238 | if (rm->m_rdma_op && |
239 | && test_bit(RDS_MSG_RETRANSMITTED, &rm->m_flags)) { | 239 | test_bit(RDS_MSG_RETRANSMITTED, &rm->m_flags)) { |
240 | spin_lock_irqsave(&conn->c_lock, flags); | 240 | spin_lock_irqsave(&conn->c_lock, flags); |
241 | if (test_and_clear_bit(RDS_MSG_ON_CONN, &rm->m_flags)) | 241 | if (test_and_clear_bit(RDS_MSG_ON_CONN, &rm->m_flags)) |
242 | list_move(&rm->m_conn_item, &to_be_dropped); | 242 | list_move(&rm->m_conn_item, &to_be_dropped); |
@@ -247,8 +247,8 @@ int rds_send_xmit(struct rds_connection *conn) | |||
247 | 247 | ||
248 | /* Require an ACK every once in a while */ | 248 | /* Require an ACK every once in a while */ |
249 | len = ntohl(rm->m_inc.i_hdr.h_len); | 249 | len = ntohl(rm->m_inc.i_hdr.h_len); |
250 | if (conn->c_unacked_packets == 0 | 250 | if (conn->c_unacked_packets == 0 || |
251 | || conn->c_unacked_bytes < len) { | 251 | conn->c_unacked_bytes < len) { |
252 | __set_bit(RDS_MSG_ACK_REQUIRED, &rm->m_flags); | 252 | __set_bit(RDS_MSG_ACK_REQUIRED, &rm->m_flags); |
253 | 253 | ||
254 | conn->c_unacked_packets = rds_sysctl_max_unacked_packets; | 254 | conn->c_unacked_packets = rds_sysctl_max_unacked_packets; |
@@ -418,8 +418,8 @@ void rds_rdma_send_complete(struct rds_message *rm, int status) | |||
418 | spin_lock(&rm->m_rs_lock); | 418 | spin_lock(&rm->m_rs_lock); |
419 | 419 | ||
420 | ro = rm->m_rdma_op; | 420 | ro = rm->m_rdma_op; |
421 | if (test_bit(RDS_MSG_ON_SOCK, &rm->m_flags) | 421 | if (test_bit(RDS_MSG_ON_SOCK, &rm->m_flags) && |
422 | && ro && ro->r_notify && ro->r_notifier) { | 422 | ro && ro->r_notify && ro->r_notifier) { |
423 | notifier = ro->r_notifier; | 423 | notifier = ro->r_notifier; |
424 | rs = rm->m_rs; | 424 | rs = rm->m_rs; |
425 | sock_hold(rds_rs_to_sk(rs)); | 425 | sock_hold(rds_rs_to_sk(rs)); |
@@ -549,8 +549,7 @@ void rds_send_remove_from_sock(struct list_head *messages, int status) | |||
549 | list_del_init(&rm->m_sock_item); | 549 | list_del_init(&rm->m_sock_item); |
550 | rds_send_sndbuf_remove(rs, rm); | 550 | rds_send_sndbuf_remove(rs, rm); |
551 | 551 | ||
552 | if (ro && ro->r_notifier | 552 | if (ro && ro->r_notifier && (status || ro->r_notify)) { |
553 | && (status || ro->r_notify)) { | ||
554 | notifier = ro->r_notifier; | 553 | notifier = ro->r_notifier; |
555 | list_add_tail(¬ifier->n_list, | 554 | list_add_tail(¬ifier->n_list, |
556 | &rs->rs_notify_queue); | 555 | &rs->rs_notify_queue); |
@@ -877,8 +876,8 @@ int rds_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr *msg, | |||
877 | if (ret) | 876 | if (ret) |
878 | goto out; | 877 | goto out; |
879 | 878 | ||
880 | if ((rm->m_rdma_cookie || rm->m_rdma_op) | 879 | if ((rm->m_rdma_cookie || rm->m_rdma_op) && |
881 | && conn->c_trans->xmit_rdma == NULL) { | 880 | conn->c_trans->xmit_rdma == NULL) { |
882 | if (printk_ratelimit()) | 881 | if (printk_ratelimit()) |
883 | printk(KERN_NOTICE "rdma_op %p conn xmit_rdma %p\n", | 882 | printk(KERN_NOTICE "rdma_op %p conn xmit_rdma %p\n", |
884 | rm->m_rdma_op, conn->c_trans->xmit_rdma); | 883 | rm->m_rdma_op, conn->c_trans->xmit_rdma); |
@@ -890,8 +889,8 @@ int rds_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr *msg, | |||
890 | * have scheduled a delayed reconnect however - in this case | 889 | * have scheduled a delayed reconnect however - in this case |
891 | * we should not interfere. | 890 | * we should not interfere. |
892 | */ | 891 | */ |
893 | if (rds_conn_state(conn) == RDS_CONN_DOWN | 892 | if (rds_conn_state(conn) == RDS_CONN_DOWN && |
894 | && !test_and_set_bit(RDS_RECONNECT_PENDING, &conn->c_flags)) | 893 | !test_and_set_bit(RDS_RECONNECT_PENDING, &conn->c_flags)) |
895 | queue_delayed_work(rds_wq, &conn->c_conn_w, 0); | 894 | queue_delayed_work(rds_wq, &conn->c_conn_w, 0); |
896 | 895 | ||
897 | ret = rds_cong_wait(conn->c_fcong, dport, nonblock, rs); | 896 | ret = rds_cong_wait(conn->c_fcong, dport, nonblock, rs); |
@@ -973,8 +972,8 @@ rds_send_pong(struct rds_connection *conn, __be16 dport) | |||
973 | * have scheduled a delayed reconnect however - in this case | 972 | * have scheduled a delayed reconnect however - in this case |
974 | * we should not interfere. | 973 | * we should not interfere. |
975 | */ | 974 | */ |
976 | if (rds_conn_state(conn) == RDS_CONN_DOWN | 975 | if (rds_conn_state(conn) == RDS_CONN_DOWN && |
977 | && !test_and_set_bit(RDS_RECONNECT_PENDING, &conn->c_flags)) | 976 | !test_and_set_bit(RDS_RECONNECT_PENDING, &conn->c_flags)) |
978 | queue_delayed_work(rds_wq, &conn->c_conn_w, 0); | 977 | queue_delayed_work(rds_wq, &conn->c_conn_w, 0); |
979 | 978 | ||
980 | ret = rds_cong_wait(conn->c_fcong, dport, 1, NULL); | 979 | ret = rds_cong_wait(conn->c_fcong, dport, 1, NULL); |