diff options
Diffstat (limited to 'net/openvswitch/flow.c')
-rw-r--r-- | net/openvswitch/flow.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c index c7bf2f26525a..98c70630ad06 100644 --- a/net/openvswitch/flow.c +++ b/net/openvswitch/flow.c | |||
@@ -203,10 +203,7 @@ struct sw_flow_actions *ovs_flow_actions_alloc(const struct nlattr *actions) | |||
203 | int actions_len = nla_len(actions); | 203 | int actions_len = nla_len(actions); |
204 | struct sw_flow_actions *sfa; | 204 | struct sw_flow_actions *sfa; |
205 | 205 | ||
206 | /* At least DP_MAX_PORTS actions are required to be able to flood a | 206 | if (actions_len > MAX_ACTIONS_BUFSIZE) |
207 | * packet to every port. Factor of 2 allows for setting VLAN tags, | ||
208 | * etc. */ | ||
209 | if (actions_len > 2 * DP_MAX_PORTS * nla_total_size(4)) | ||
210 | return ERR_PTR(-EINVAL); | 207 | return ERR_PTR(-EINVAL); |
211 | 208 | ||
212 | sfa = kmalloc(sizeof(*sfa) + actions_len, GFP_KERNEL); | 209 | sfa = kmalloc(sizeof(*sfa) + actions_len, GFP_KERNEL); |
@@ -992,7 +989,7 @@ int ovs_flow_from_nlattrs(struct sw_flow_key *swkey, int *key_lenp, | |||
992 | swkey->phy.in_port = in_port; | 989 | swkey->phy.in_port = in_port; |
993 | attrs &= ~(1 << OVS_KEY_ATTR_IN_PORT); | 990 | attrs &= ~(1 << OVS_KEY_ATTR_IN_PORT); |
994 | } else { | 991 | } else { |
995 | swkey->phy.in_port = USHRT_MAX; | 992 | swkey->phy.in_port = DP_MAX_PORTS; |
996 | } | 993 | } |
997 | 994 | ||
998 | /* Data attributes. */ | 995 | /* Data attributes. */ |
@@ -1135,7 +1132,7 @@ int ovs_flow_metadata_from_nlattrs(u32 *priority, u16 *in_port, | |||
1135 | const struct nlattr *nla; | 1132 | const struct nlattr *nla; |
1136 | int rem; | 1133 | int rem; |
1137 | 1134 | ||
1138 | *in_port = USHRT_MAX; | 1135 | *in_port = DP_MAX_PORTS; |
1139 | *priority = 0; | 1136 | *priority = 0; |
1140 | 1137 | ||
1141 | nla_for_each_nested(nla, attr, rem) { | 1138 | nla_for_each_nested(nla, attr, rem) { |
@@ -1172,7 +1169,7 @@ int ovs_flow_to_nlattrs(const struct sw_flow_key *swkey, struct sk_buff *skb) | |||
1172 | nla_put_u32(skb, OVS_KEY_ATTR_PRIORITY, swkey->phy.priority)) | 1169 | nla_put_u32(skb, OVS_KEY_ATTR_PRIORITY, swkey->phy.priority)) |
1173 | goto nla_put_failure; | 1170 | goto nla_put_failure; |
1174 | 1171 | ||
1175 | if (swkey->phy.in_port != USHRT_MAX && | 1172 | if (swkey->phy.in_port != DP_MAX_PORTS && |
1176 | nla_put_u32(skb, OVS_KEY_ATTR_IN_PORT, swkey->phy.in_port)) | 1173 | nla_put_u32(skb, OVS_KEY_ATTR_IN_PORT, swkey->phy.in_port)) |
1177 | goto nla_put_failure; | 1174 | goto nla_put_failure; |
1178 | 1175 | ||