diff options
Diffstat (limited to 'net/openvswitch/flow.c')
-rw-r--r-- | net/openvswitch/flow.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c index b7f38b161909..f9f211d95ebe 100644 --- a/net/openvswitch/flow.c +++ b/net/openvswitch/flow.c | |||
@@ -203,10 +203,7 @@ struct sw_flow_actions *ovs_flow_actions_alloc(const struct nlattr *actions) | |||
203 | int actions_len = nla_len(actions); | 203 | int actions_len = nla_len(actions); |
204 | struct sw_flow_actions *sfa; | 204 | struct sw_flow_actions *sfa; |
205 | 205 | ||
206 | /* At least DP_MAX_PORTS actions are required to be able to flood a | 206 | if (actions_len > MAX_ACTIONS_BUFSIZE) |
207 | * packet to every port. Factor of 2 allows for setting VLAN tags, | ||
208 | * etc. */ | ||
209 | if (actions_len > 2 * DP_MAX_PORTS * nla_total_size(4)) | ||
210 | return ERR_PTR(-EINVAL); | 207 | return ERR_PTR(-EINVAL); |
211 | 208 | ||
212 | sfa = kmalloc(sizeof(*sfa) + actions_len, GFP_KERNEL); | 209 | sfa = kmalloc(sizeof(*sfa) + actions_len, GFP_KERNEL); |
@@ -1000,7 +997,7 @@ int ovs_flow_from_nlattrs(struct sw_flow_key *swkey, int *key_lenp, | |||
1000 | swkey->phy.in_port = in_port; | 997 | swkey->phy.in_port = in_port; |
1001 | attrs &= ~(1 << OVS_KEY_ATTR_IN_PORT); | 998 | attrs &= ~(1 << OVS_KEY_ATTR_IN_PORT); |
1002 | } else { | 999 | } else { |
1003 | swkey->phy.in_port = USHRT_MAX; | 1000 | swkey->phy.in_port = DP_MAX_PORTS; |
1004 | } | 1001 | } |
1005 | 1002 | ||
1006 | /* Data attributes. */ | 1003 | /* Data attributes. */ |
@@ -1143,7 +1140,7 @@ int ovs_flow_metadata_from_nlattrs(u32 *priority, u16 *in_port, | |||
1143 | const struct nlattr *nla; | 1140 | const struct nlattr *nla; |
1144 | int rem; | 1141 | int rem; |
1145 | 1142 | ||
1146 | *in_port = USHRT_MAX; | 1143 | *in_port = DP_MAX_PORTS; |
1147 | *priority = 0; | 1144 | *priority = 0; |
1148 | 1145 | ||
1149 | nla_for_each_nested(nla, attr, rem) { | 1146 | nla_for_each_nested(nla, attr, rem) { |
@@ -1180,7 +1177,7 @@ int ovs_flow_to_nlattrs(const struct sw_flow_key *swkey, struct sk_buff *skb) | |||
1180 | nla_put_u32(skb, OVS_KEY_ATTR_PRIORITY, swkey->phy.priority)) | 1177 | nla_put_u32(skb, OVS_KEY_ATTR_PRIORITY, swkey->phy.priority)) |
1181 | goto nla_put_failure; | 1178 | goto nla_put_failure; |
1182 | 1179 | ||
1183 | if (swkey->phy.in_port != USHRT_MAX && | 1180 | if (swkey->phy.in_port != DP_MAX_PORTS && |
1184 | nla_put_u32(skb, OVS_KEY_ATTR_IN_PORT, swkey->phy.in_port)) | 1181 | nla_put_u32(skb, OVS_KEY_ATTR_IN_PORT, swkey->phy.in_port)) |
1185 | goto nla_put_failure; | 1182 | goto nla_put_failure; |
1186 | 1183 | ||