aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4
diff options
context:
space:
mode:
Diffstat (limited to 'net/ipv4')
-rw-r--r--net/ipv4/netfilter/arp_tables.c10
-rw-r--r--net/ipv4/netfilter/ip_tables.c11
2 files changed, 6 insertions, 15 deletions
diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
index 7505dff4ffdf..b9f7243f4220 100644
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -341,15 +341,11 @@ unsigned int arpt_do_table(struct sk_buff *skb,
341} 341}
342 342
343/* All zeroes == unconditional rule. */ 343/* All zeroes == unconditional rule. */
344static inline int unconditional(const struct arpt_arp *arp) 344static inline bool unconditional(const struct arpt_arp *arp)
345{ 345{
346 unsigned int i; 346 static const struct arpt_arp uncond;
347
348 for (i = 0; i < sizeof(*arp)/sizeof(__u32); i++)
349 if (((__u32 *)arp)[i])
350 return 0;
351 347
352 return 1; 348 return memcmp(arp, &uncond, sizeof(uncond)) == 0;
353} 349}
354 350
355/* Figures out from what hook each rule can be called: returns 0 if 351/* Figures out from what hook each rule can be called: returns 0 if
diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c
index 3856aa3f231e..3431a771ff1f 100644
--- a/net/ipv4/netfilter/ip_tables.c
+++ b/net/ipv4/netfilter/ip_tables.c
@@ -190,16 +190,11 @@ get_entry(void *base, unsigned int offset)
190 190
191/* All zeroes == unconditional rule. */ 191/* All zeroes == unconditional rule. */
192/* Mildly perf critical (only if packet tracing is on) */ 192/* Mildly perf critical (only if packet tracing is on) */
193static inline int 193static inline bool unconditional(const struct ipt_ip *ip)
194unconditional(const struct ipt_ip *ip)
195{ 194{
196 unsigned int i; 195 static const struct ipt_ip uncond;
197 196
198 for (i = 0; i < sizeof(*ip)/sizeof(__u32); i++) 197 return memcmp(ip, &uncond, sizeof(uncond)) == 0;
199 if (((__u32 *)ip)[i])
200 return 0;
201
202 return 1;
203#undef FWINV 198#undef FWINV
204} 199}
205 200