diff options
Diffstat (limited to 'net/ipv4/tcp_input.c')
-rw-r--r-- | net/ipv4/tcp_input.c | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 08bbe6096528..9c6225780bd5 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c | |||
@@ -2743,8 +2743,8 @@ static void tcp_process_loss(struct sock *sk, int flag, bool is_dupack) | |||
2743 | * tcp_xmit_retransmit_queue(). | 2743 | * tcp_xmit_retransmit_queue(). |
2744 | */ | 2744 | */ |
2745 | static void tcp_fastretrans_alert(struct sock *sk, int pkts_acked, | 2745 | static void tcp_fastretrans_alert(struct sock *sk, int pkts_acked, |
2746 | int prior_sacked, bool is_dupack, | 2746 | int prior_sacked, int prior_packets, |
2747 | int flag) | 2747 | bool is_dupack, int flag) |
2748 | { | 2748 | { |
2749 | struct inet_connection_sock *icsk = inet_csk(sk); | 2749 | struct inet_connection_sock *icsk = inet_csk(sk); |
2750 | struct tcp_sock *tp = tcp_sk(sk); | 2750 | struct tcp_sock *tp = tcp_sk(sk); |
@@ -2804,7 +2804,8 @@ static void tcp_fastretrans_alert(struct sock *sk, int pkts_acked, | |||
2804 | tcp_add_reno_sack(sk); | 2804 | tcp_add_reno_sack(sk); |
2805 | } else | 2805 | } else |
2806 | do_lost = tcp_try_undo_partial(sk, pkts_acked); | 2806 | do_lost = tcp_try_undo_partial(sk, pkts_acked); |
2807 | newly_acked_sacked = pkts_acked + tp->sacked_out - prior_sacked; | 2807 | newly_acked_sacked = prior_packets - tp->packets_out + |
2808 | tp->sacked_out - prior_sacked; | ||
2808 | break; | 2809 | break; |
2809 | case TCP_CA_Loss: | 2810 | case TCP_CA_Loss: |
2810 | tcp_process_loss(sk, flag, is_dupack); | 2811 | tcp_process_loss(sk, flag, is_dupack); |
@@ -2818,7 +2819,8 @@ static void tcp_fastretrans_alert(struct sock *sk, int pkts_acked, | |||
2818 | if (is_dupack) | 2819 | if (is_dupack) |
2819 | tcp_add_reno_sack(sk); | 2820 | tcp_add_reno_sack(sk); |
2820 | } | 2821 | } |
2821 | newly_acked_sacked = pkts_acked + tp->sacked_out - prior_sacked; | 2822 | newly_acked_sacked = prior_packets - tp->packets_out + |
2823 | tp->sacked_out - prior_sacked; | ||
2822 | 2824 | ||
2823 | if (icsk->icsk_ca_state <= TCP_CA_Disorder) | 2825 | if (icsk->icsk_ca_state <= TCP_CA_Disorder) |
2824 | tcp_try_undo_dsack(sk); | 2826 | tcp_try_undo_dsack(sk); |
@@ -3330,9 +3332,10 @@ static int tcp_ack(struct sock *sk, const struct sk_buff *skb, int flag) | |||
3330 | bool is_dupack = false; | 3332 | bool is_dupack = false; |
3331 | u32 prior_in_flight; | 3333 | u32 prior_in_flight; |
3332 | u32 prior_fackets; | 3334 | u32 prior_fackets; |
3333 | int prior_packets; | 3335 | int prior_packets = tp->packets_out; |
3334 | int prior_sacked = tp->sacked_out; | 3336 | int prior_sacked = tp->sacked_out; |
3335 | int pkts_acked = 0; | 3337 | int pkts_acked = 0; |
3338 | int previous_packets_out = 0; | ||
3336 | 3339 | ||
3337 | /* If the ack is older than previous acks | 3340 | /* If the ack is older than previous acks |
3338 | * then we can probably ignore it. | 3341 | * then we can probably ignore it. |
@@ -3403,14 +3406,14 @@ static int tcp_ack(struct sock *sk, const struct sk_buff *skb, int flag) | |||
3403 | sk->sk_err_soft = 0; | 3406 | sk->sk_err_soft = 0; |
3404 | icsk->icsk_probes_out = 0; | 3407 | icsk->icsk_probes_out = 0; |
3405 | tp->rcv_tstamp = tcp_time_stamp; | 3408 | tp->rcv_tstamp = tcp_time_stamp; |
3406 | prior_packets = tp->packets_out; | ||
3407 | if (!prior_packets) | 3409 | if (!prior_packets) |
3408 | goto no_queue; | 3410 | goto no_queue; |
3409 | 3411 | ||
3410 | /* See if we can take anything off of the retransmit queue. */ | 3412 | /* See if we can take anything off of the retransmit queue. */ |
3413 | previous_packets_out = tp->packets_out; | ||
3411 | flag |= tcp_clean_rtx_queue(sk, prior_fackets, prior_snd_una); | 3414 | flag |= tcp_clean_rtx_queue(sk, prior_fackets, prior_snd_una); |
3412 | 3415 | ||
3413 | pkts_acked = prior_packets - tp->packets_out; | 3416 | pkts_acked = previous_packets_out - tp->packets_out; |
3414 | 3417 | ||
3415 | if (tcp_ack_is_dubious(sk, flag)) { | 3418 | if (tcp_ack_is_dubious(sk, flag)) { |
3416 | /* Advance CWND, if state allows this. */ | 3419 | /* Advance CWND, if state allows this. */ |
@@ -3418,7 +3421,7 @@ static int tcp_ack(struct sock *sk, const struct sk_buff *skb, int flag) | |||
3418 | tcp_cong_avoid(sk, ack, prior_in_flight); | 3421 | tcp_cong_avoid(sk, ack, prior_in_flight); |
3419 | is_dupack = !(flag & (FLAG_SND_UNA_ADVANCED | FLAG_NOT_DUP)); | 3422 | is_dupack = !(flag & (FLAG_SND_UNA_ADVANCED | FLAG_NOT_DUP)); |
3420 | tcp_fastretrans_alert(sk, pkts_acked, prior_sacked, | 3423 | tcp_fastretrans_alert(sk, pkts_acked, prior_sacked, |
3421 | is_dupack, flag); | 3424 | prior_packets, is_dupack, flag); |
3422 | } else { | 3425 | } else { |
3423 | if (flag & FLAG_DATA_ACKED) | 3426 | if (flag & FLAG_DATA_ACKED) |
3424 | tcp_cong_avoid(sk, ack, prior_in_flight); | 3427 | tcp_cong_avoid(sk, ack, prior_in_flight); |
@@ -3441,7 +3444,7 @@ no_queue: | |||
3441 | /* If data was DSACKed, see if we can undo a cwnd reduction. */ | 3444 | /* If data was DSACKed, see if we can undo a cwnd reduction. */ |
3442 | if (flag & FLAG_DSACKING_ACK) | 3445 | if (flag & FLAG_DSACKING_ACK) |
3443 | tcp_fastretrans_alert(sk, pkts_acked, prior_sacked, | 3446 | tcp_fastretrans_alert(sk, pkts_acked, prior_sacked, |
3444 | is_dupack, flag); | 3447 | prior_packets, is_dupack, flag); |
3445 | /* If this ack opens up a zero window, clear backoff. It was | 3448 | /* If this ack opens up a zero window, clear backoff. It was |
3446 | * being used to time the probes, and is probably far higher than | 3449 | * being used to time the probes, and is probably far higher than |
3447 | * it needs to be for normal retransmission. | 3450 | * it needs to be for normal retransmission. |
@@ -3464,7 +3467,7 @@ old_ack: | |||
3464 | if (TCP_SKB_CB(skb)->sacked) { | 3467 | if (TCP_SKB_CB(skb)->sacked) { |
3465 | flag |= tcp_sacktag_write_queue(sk, skb, prior_snd_una); | 3468 | flag |= tcp_sacktag_write_queue(sk, skb, prior_snd_una); |
3466 | tcp_fastretrans_alert(sk, pkts_acked, prior_sacked, | 3469 | tcp_fastretrans_alert(sk, pkts_acked, prior_sacked, |
3467 | is_dupack, flag); | 3470 | prior_packets, is_dupack, flag); |
3468 | } | 3471 | } |
3469 | 3472 | ||
3470 | SOCK_DEBUG(sk, "Ack %u before %u:%u\n", ack, tp->snd_una, tp->snd_nxt); | 3473 | SOCK_DEBUG(sk, "Ack %u before %u:%u\n", ack, tp->snd_una, tp->snd_nxt); |