diff options
Diffstat (limited to 'net/ipv4/route.c')
-rw-r--r-- | net/ipv4/route.c | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 78d81543766d..e376354dcb65 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c | |||
@@ -1289,20 +1289,15 @@ static void ip_select_fb_ident(struct iphdr *iph) | |||
1289 | 1289 | ||
1290 | void __ip_select_ident(struct iphdr *iph, struct dst_entry *dst, int more) | 1290 | void __ip_select_ident(struct iphdr *iph, struct dst_entry *dst, int more) |
1291 | { | 1291 | { |
1292 | struct rtable *rt = (struct rtable *) dst; | 1292 | struct net *net = dev_net(dst->dev); |
1293 | 1293 | struct inet_peer *peer; | |
1294 | if (rt && !(rt->dst.flags & DST_NOPEER)) { | ||
1295 | struct inet_peer *peer = rt_get_peer_create(rt, rt->rt_dst); | ||
1296 | 1294 | ||
1297 | /* If peer is attached to destination, it is never detached, | 1295 | peer = inet_getpeer_v4(net->ipv4.peers, iph->daddr, 1); |
1298 | so that we need not to grab a lock to dereference it. | 1296 | if (peer) { |
1299 | */ | 1297 | iph->id = htons(inet_getid(peer, more)); |
1300 | if (peer) { | 1298 | inet_putpeer(peer); |
1301 | iph->id = htons(inet_getid(peer, more)); | 1299 | return; |
1302 | return; | 1300 | } |
1303 | } | ||
1304 | } else if (!rt) | ||
1305 | pr_debug("rt_bind_peer(0) @%p\n", __builtin_return_address(0)); | ||
1306 | 1301 | ||
1307 | ip_select_fb_ident(iph); | 1302 | ip_select_fb_ident(iph); |
1308 | } | 1303 | } |
@@ -1492,6 +1487,7 @@ void ip_rt_send_redirect(struct sk_buff *skb) | |||
1492 | struct rtable *rt = skb_rtable(skb); | 1487 | struct rtable *rt = skb_rtable(skb); |
1493 | struct in_device *in_dev; | 1488 | struct in_device *in_dev; |
1494 | struct inet_peer *peer; | 1489 | struct inet_peer *peer; |
1490 | struct net *net; | ||
1495 | int log_martians; | 1491 | int log_martians; |
1496 | 1492 | ||
1497 | rcu_read_lock(); | 1493 | rcu_read_lock(); |
@@ -1503,7 +1499,8 @@ void ip_rt_send_redirect(struct sk_buff *skb) | |||
1503 | log_martians = IN_DEV_LOG_MARTIANS(in_dev); | 1499 | log_martians = IN_DEV_LOG_MARTIANS(in_dev); |
1504 | rcu_read_unlock(); | 1500 | rcu_read_unlock(); |
1505 | 1501 | ||
1506 | peer = rt_get_peer_create(rt, rt->rt_dst); | 1502 | net = dev_net(rt->dst.dev); |
1503 | peer = inet_getpeer_v4(net->ipv4.peers, ip_hdr(skb)->saddr, 1); | ||
1507 | if (!peer) { | 1504 | if (!peer) { |
1508 | icmp_send(skb, ICMP_REDIRECT, ICMP_REDIR_HOST, rt->rt_gateway); | 1505 | icmp_send(skb, ICMP_REDIRECT, ICMP_REDIR_HOST, rt->rt_gateway); |
1509 | return; | 1506 | return; |
@@ -1520,7 +1517,7 @@ void ip_rt_send_redirect(struct sk_buff *skb) | |||
1520 | */ | 1517 | */ |
1521 | if (peer->rate_tokens >= ip_rt_redirect_number) { | 1518 | if (peer->rate_tokens >= ip_rt_redirect_number) { |
1522 | peer->rate_last = jiffies; | 1519 | peer->rate_last = jiffies; |
1523 | return; | 1520 | goto out_put_peer; |
1524 | } | 1521 | } |
1525 | 1522 | ||
1526 | /* Check for load limit; set rate_last to the latest sent | 1523 | /* Check for load limit; set rate_last to the latest sent |
@@ -1541,6 +1538,8 @@ void ip_rt_send_redirect(struct sk_buff *skb) | |||
1541 | &rt->rt_dst, &rt->rt_gateway); | 1538 | &rt->rt_dst, &rt->rt_gateway); |
1542 | #endif | 1539 | #endif |
1543 | } | 1540 | } |
1541 | out_put_peer: | ||
1542 | inet_putpeer(peer); | ||
1544 | } | 1543 | } |
1545 | 1544 | ||
1546 | static int ip_error(struct sk_buff *skb) | 1545 | static int ip_error(struct sk_buff *skb) |
@@ -1583,7 +1582,7 @@ static int ip_error(struct sk_buff *skb) | |||
1583 | break; | 1582 | break; |
1584 | } | 1583 | } |
1585 | 1584 | ||
1586 | peer = rt_get_peer_create(rt, rt->rt_dst); | 1585 | peer = inet_getpeer_v4(net->ipv4.peers, ip_hdr(skb)->saddr, 1); |
1587 | 1586 | ||
1588 | send = true; | 1587 | send = true; |
1589 | if (peer) { | 1588 | if (peer) { |
@@ -1596,6 +1595,7 @@ static int ip_error(struct sk_buff *skb) | |||
1596 | peer->rate_tokens -= ip_rt_error_cost; | 1595 | peer->rate_tokens -= ip_rt_error_cost; |
1597 | else | 1596 | else |
1598 | send = false; | 1597 | send = false; |
1598 | inet_putpeer(peer); | ||
1599 | } | 1599 | } |
1600 | if (send) | 1600 | if (send) |
1601 | icmp_send(skb, ICMP_DEST_UNREACH, code, 0); | 1601 | icmp_send(skb, ICMP_DEST_UNREACH, code, 0); |