diff options
Diffstat (limited to 'net/ipv4/arp.c')
-rw-r--r-- | net/ipv4/arp.c | 245 |
1 files changed, 132 insertions, 113 deletions
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index 96c1955b3e2f..d8e540c5b071 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c | |||
@@ -55,7 +55,7 @@ | |||
55 | * Stuart Cheshire : Metricom and grat arp fixes | 55 | * Stuart Cheshire : Metricom and grat arp fixes |
56 | * *** FOR 2.1 clean this up *** | 56 | * *** FOR 2.1 clean this up *** |
57 | * Lawrence V. Stefani: (08/12/96) Added FDDI support. | 57 | * Lawrence V. Stefani: (08/12/96) Added FDDI support. |
58 | * Alan Cox : Took the AP1000 nasty FDDI hack and | 58 | * Alan Cox : Took the AP1000 nasty FDDI hack and |
59 | * folded into the mainstream FDDI code. | 59 | * folded into the mainstream FDDI code. |
60 | * Ack spit, Linus how did you allow that | 60 | * Ack spit, Linus how did you allow that |
61 | * one in... | 61 | * one in... |
@@ -120,14 +120,14 @@ EXPORT_SYMBOL(clip_tbl_hook); | |||
120 | #endif | 120 | #endif |
121 | 121 | ||
122 | #include <asm/system.h> | 122 | #include <asm/system.h> |
123 | #include <asm/uaccess.h> | 123 | #include <linux/uaccess.h> |
124 | 124 | ||
125 | #include <linux/netfilter_arp.h> | 125 | #include <linux/netfilter_arp.h> |
126 | 126 | ||
127 | /* | 127 | /* |
128 | * Interface to generic neighbour cache. | 128 | * Interface to generic neighbour cache. |
129 | */ | 129 | */ |
130 | static u32 arp_hash(const void *pkey, const struct net_device *dev); | 130 | static u32 arp_hash(const void *pkey, const struct net_device *dev, __u32 rnd); |
131 | static int arp_constructor(struct neighbour *neigh); | 131 | static int arp_constructor(struct neighbour *neigh); |
132 | static void arp_solicit(struct neighbour *neigh, struct sk_buff *skb); | 132 | static void arp_solicit(struct neighbour *neigh, struct sk_buff *skb); |
133 | static void arp_error_report(struct neighbour *neigh, struct sk_buff *skb); | 133 | static void arp_error_report(struct neighbour *neigh, struct sk_buff *skb); |
@@ -161,7 +161,7 @@ static const struct neigh_ops arp_direct_ops = { | |||
161 | .queue_xmit = dev_queue_xmit, | 161 | .queue_xmit = dev_queue_xmit, |
162 | }; | 162 | }; |
163 | 163 | ||
164 | const struct neigh_ops arp_broken_ops = { | 164 | static const struct neigh_ops arp_broken_ops = { |
165 | .family = AF_INET, | 165 | .family = AF_INET, |
166 | .solicit = arp_solicit, | 166 | .solicit = arp_solicit, |
167 | .error_report = arp_error_report, | 167 | .error_report = arp_error_report, |
@@ -170,35 +170,34 @@ const struct neigh_ops arp_broken_ops = { | |||
170 | .hh_output = dev_queue_xmit, | 170 | .hh_output = dev_queue_xmit, |
171 | .queue_xmit = dev_queue_xmit, | 171 | .queue_xmit = dev_queue_xmit, |
172 | }; | 172 | }; |
173 | EXPORT_SYMBOL(arp_broken_ops); | ||
174 | 173 | ||
175 | struct neigh_table arp_tbl = { | 174 | struct neigh_table arp_tbl = { |
176 | .family = AF_INET, | 175 | .family = AF_INET, |
177 | .entry_size = sizeof(struct neighbour) + 4, | 176 | .entry_size = sizeof(struct neighbour) + 4, |
178 | .key_len = 4, | 177 | .key_len = 4, |
179 | .hash = arp_hash, | 178 | .hash = arp_hash, |
180 | .constructor = arp_constructor, | 179 | .constructor = arp_constructor, |
181 | .proxy_redo = parp_redo, | 180 | .proxy_redo = parp_redo, |
182 | .id = "arp_cache", | 181 | .id = "arp_cache", |
183 | .parms = { | 182 | .parms = { |
184 | .tbl = &arp_tbl, | 183 | .tbl = &arp_tbl, |
185 | .base_reachable_time = 30 * HZ, | 184 | .base_reachable_time = 30 * HZ, |
186 | .retrans_time = 1 * HZ, | 185 | .retrans_time = 1 * HZ, |
187 | .gc_staletime = 60 * HZ, | 186 | .gc_staletime = 60 * HZ, |
188 | .reachable_time = 30 * HZ, | 187 | .reachable_time = 30 * HZ, |
189 | .delay_probe_time = 5 * HZ, | 188 | .delay_probe_time = 5 * HZ, |
190 | .queue_len = 3, | 189 | .queue_len = 3, |
191 | .ucast_probes = 3, | 190 | .ucast_probes = 3, |
192 | .mcast_probes = 3, | 191 | .mcast_probes = 3, |
193 | .anycast_delay = 1 * HZ, | 192 | .anycast_delay = 1 * HZ, |
194 | .proxy_delay = (8 * HZ) / 10, | 193 | .proxy_delay = (8 * HZ) / 10, |
195 | .proxy_qlen = 64, | 194 | .proxy_qlen = 64, |
196 | .locktime = 1 * HZ, | 195 | .locktime = 1 * HZ, |
197 | }, | 196 | }, |
198 | .gc_interval = 30 * HZ, | 197 | .gc_interval = 30 * HZ, |
199 | .gc_thresh1 = 128, | 198 | .gc_thresh1 = 128, |
200 | .gc_thresh2 = 512, | 199 | .gc_thresh2 = 512, |
201 | .gc_thresh3 = 1024, | 200 | .gc_thresh3 = 1024, |
202 | }; | 201 | }; |
203 | EXPORT_SYMBOL(arp_tbl); | 202 | EXPORT_SYMBOL(arp_tbl); |
204 | 203 | ||
@@ -226,14 +225,16 @@ int arp_mc_map(__be32 addr, u8 *haddr, struct net_device *dev, int dir) | |||
226 | } | 225 | } |
227 | 226 | ||
228 | 227 | ||
229 | static u32 arp_hash(const void *pkey, const struct net_device *dev) | 228 | static u32 arp_hash(const void *pkey, |
229 | const struct net_device *dev, | ||
230 | __u32 hash_rnd) | ||
230 | { | 231 | { |
231 | return jhash_2words(*(u32 *)pkey, dev->ifindex, arp_tbl.hash_rnd); | 232 | return jhash_2words(*(u32 *)pkey, dev->ifindex, hash_rnd); |
232 | } | 233 | } |
233 | 234 | ||
234 | static int arp_constructor(struct neighbour *neigh) | 235 | static int arp_constructor(struct neighbour *neigh) |
235 | { | 236 | { |
236 | __be32 addr = *(__be32*)neigh->primary_key; | 237 | __be32 addr = *(__be32 *)neigh->primary_key; |
237 | struct net_device *dev = neigh->dev; | 238 | struct net_device *dev = neigh->dev; |
238 | struct in_device *in_dev; | 239 | struct in_device *in_dev; |
239 | struct neigh_parms *parms; | 240 | struct neigh_parms *parms; |
@@ -296,16 +297,19 @@ static int arp_constructor(struct neighbour *neigh) | |||
296 | neigh->ops = &arp_broken_ops; | 297 | neigh->ops = &arp_broken_ops; |
297 | neigh->output = neigh->ops->output; | 298 | neigh->output = neigh->ops->output; |
298 | return 0; | 299 | return 0; |
300 | #else | ||
301 | break; | ||
299 | #endif | 302 | #endif |
300 | ;} | 303 | } |
301 | #endif | 304 | #endif |
302 | if (neigh->type == RTN_MULTICAST) { | 305 | if (neigh->type == RTN_MULTICAST) { |
303 | neigh->nud_state = NUD_NOARP; | 306 | neigh->nud_state = NUD_NOARP; |
304 | arp_mc_map(addr, neigh->ha, dev, 1); | 307 | arp_mc_map(addr, neigh->ha, dev, 1); |
305 | } else if (dev->flags&(IFF_NOARP|IFF_LOOPBACK)) { | 308 | } else if (dev->flags & (IFF_NOARP | IFF_LOOPBACK)) { |
306 | neigh->nud_state = NUD_NOARP; | 309 | neigh->nud_state = NUD_NOARP; |
307 | memcpy(neigh->ha, dev->dev_addr, dev->addr_len); | 310 | memcpy(neigh->ha, dev->dev_addr, dev->addr_len); |
308 | } else if (neigh->type == RTN_BROADCAST || dev->flags&IFF_POINTOPOINT) { | 311 | } else if (neigh->type == RTN_BROADCAST || |
312 | (dev->flags & IFF_POINTOPOINT)) { | ||
309 | neigh->nud_state = NUD_NOARP; | 313 | neigh->nud_state = NUD_NOARP; |
310 | memcpy(neigh->ha, dev->broadcast, dev->addr_len); | 314 | memcpy(neigh->ha, dev->broadcast, dev->addr_len); |
311 | } | 315 | } |
@@ -315,7 +319,7 @@ static int arp_constructor(struct neighbour *neigh) | |||
315 | else | 319 | else |
316 | neigh->ops = &arp_generic_ops; | 320 | neigh->ops = &arp_generic_ops; |
317 | 321 | ||
318 | if (neigh->nud_state&NUD_VALID) | 322 | if (neigh->nud_state & NUD_VALID) |
319 | neigh->output = neigh->ops->connected_output; | 323 | neigh->output = neigh->ops->connected_output; |
320 | else | 324 | else |
321 | neigh->output = neigh->ops->output; | 325 | neigh->output = neigh->ops->output; |
@@ -334,7 +338,7 @@ static void arp_solicit(struct neighbour *neigh, struct sk_buff *skb) | |||
334 | __be32 saddr = 0; | 338 | __be32 saddr = 0; |
335 | u8 *dst_ha = NULL; | 339 | u8 *dst_ha = NULL; |
336 | struct net_device *dev = neigh->dev; | 340 | struct net_device *dev = neigh->dev; |
337 | __be32 target = *(__be32*)neigh->primary_key; | 341 | __be32 target = *(__be32 *)neigh->primary_key; |
338 | int probes = atomic_read(&neigh->probes); | 342 | int probes = atomic_read(&neigh->probes); |
339 | struct in_device *in_dev; | 343 | struct in_device *in_dev; |
340 | 344 | ||
@@ -347,7 +351,8 @@ static void arp_solicit(struct neighbour *neigh, struct sk_buff *skb) | |||
347 | switch (IN_DEV_ARP_ANNOUNCE(in_dev)) { | 351 | switch (IN_DEV_ARP_ANNOUNCE(in_dev)) { |
348 | default: | 352 | default: |
349 | case 0: /* By default announce any local IP */ | 353 | case 0: /* By default announce any local IP */ |
350 | if (skb && inet_addr_type(dev_net(dev), ip_hdr(skb)->saddr) == RTN_LOCAL) | 354 | if (skb && inet_addr_type(dev_net(dev), |
355 | ip_hdr(skb)->saddr) == RTN_LOCAL) | ||
351 | saddr = ip_hdr(skb)->saddr; | 356 | saddr = ip_hdr(skb)->saddr; |
352 | break; | 357 | break; |
353 | case 1: /* Restrict announcements of saddr in same subnet */ | 358 | case 1: /* Restrict announcements of saddr in same subnet */ |
@@ -369,16 +374,21 @@ static void arp_solicit(struct neighbour *neigh, struct sk_buff *skb) | |||
369 | if (!saddr) | 374 | if (!saddr) |
370 | saddr = inet_select_addr(dev, target, RT_SCOPE_LINK); | 375 | saddr = inet_select_addr(dev, target, RT_SCOPE_LINK); |
371 | 376 | ||
372 | if ((probes -= neigh->parms->ucast_probes) < 0) { | 377 | probes -= neigh->parms->ucast_probes; |
373 | if (!(neigh->nud_state&NUD_VALID)) | 378 | if (probes < 0) { |
374 | printk(KERN_DEBUG "trying to ucast probe in NUD_INVALID\n"); | 379 | if (!(neigh->nud_state & NUD_VALID)) |
380 | printk(KERN_DEBUG | ||
381 | "trying to ucast probe in NUD_INVALID\n"); | ||
375 | dst_ha = neigh->ha; | 382 | dst_ha = neigh->ha; |
376 | read_lock_bh(&neigh->lock); | 383 | read_lock_bh(&neigh->lock); |
377 | } else if ((probes -= neigh->parms->app_probes) < 0) { | 384 | } else { |
385 | probes -= neigh->parms->app_probes; | ||
386 | if (probes < 0) { | ||
378 | #ifdef CONFIG_ARPD | 387 | #ifdef CONFIG_ARPD |
379 | neigh_app_ns(neigh); | 388 | neigh_app_ns(neigh); |
380 | #endif | 389 | #endif |
381 | return; | 390 | return; |
391 | } | ||
382 | } | 392 | } |
383 | 393 | ||
384 | arp_send(ARPOP_REQUEST, ETH_P_ARP, target, dev, saddr, | 394 | arp_send(ARPOP_REQUEST, ETH_P_ARP, target, dev, saddr, |
@@ -451,7 +461,8 @@ static int arp_filter(__be32 sip, __be32 tip, struct net_device *dev) | |||
451 | * is allowed to use this function, it is scheduled to be removed. --ANK | 461 | * is allowed to use this function, it is scheduled to be removed. --ANK |
452 | */ | 462 | */ |
453 | 463 | ||
454 | static int arp_set_predefined(int addr_hint, unsigned char * haddr, __be32 paddr, struct net_device * dev) | 464 | static int arp_set_predefined(int addr_hint, unsigned char *haddr, |
465 | __be32 paddr, struct net_device *dev) | ||
455 | { | 466 | { |
456 | switch (addr_hint) { | 467 | switch (addr_hint) { |
457 | case RTN_LOCAL: | 468 | case RTN_LOCAL: |
@@ -483,17 +494,16 @@ int arp_find(unsigned char *haddr, struct sk_buff *skb) | |||
483 | 494 | ||
484 | paddr = skb_rtable(skb)->rt_gateway; | 495 | paddr = skb_rtable(skb)->rt_gateway; |
485 | 496 | ||
486 | if (arp_set_predefined(inet_addr_type(dev_net(dev), paddr), haddr, paddr, dev)) | 497 | if (arp_set_predefined(inet_addr_type(dev_net(dev), paddr), haddr, |
498 | paddr, dev)) | ||
487 | return 0; | 499 | return 0; |
488 | 500 | ||
489 | n = __neigh_lookup(&arp_tbl, &paddr, dev, 1); | 501 | n = __neigh_lookup(&arp_tbl, &paddr, dev, 1); |
490 | 502 | ||
491 | if (n) { | 503 | if (n) { |
492 | n->used = jiffies; | 504 | n->used = jiffies; |
493 | if (n->nud_state&NUD_VALID || neigh_event_send(n, skb) == 0) { | 505 | if (n->nud_state & NUD_VALID || neigh_event_send(n, skb) == 0) { |
494 | read_lock_bh(&n->lock); | 506 | neigh_ha_snapshot(haddr, n, dev); |
495 | memcpy(haddr, n->ha, dev->addr_len); | ||
496 | read_unlock_bh(&n->lock); | ||
497 | neigh_release(n); | 507 | neigh_release(n); |
498 | return 0; | 508 | return 0; |
499 | } | 509 | } |
@@ -515,13 +525,14 @@ int arp_bind_neighbour(struct dst_entry *dst) | |||
515 | return -EINVAL; | 525 | return -EINVAL; |
516 | if (n == NULL) { | 526 | if (n == NULL) { |
517 | __be32 nexthop = ((struct rtable *)dst)->rt_gateway; | 527 | __be32 nexthop = ((struct rtable *)dst)->rt_gateway; |
518 | if (dev->flags&(IFF_LOOPBACK|IFF_POINTOPOINT)) | 528 | if (dev->flags & (IFF_LOOPBACK | IFF_POINTOPOINT)) |
519 | nexthop = 0; | 529 | nexthop = 0; |
520 | n = __neigh_lookup_errno( | 530 | n = __neigh_lookup_errno( |
521 | #if defined(CONFIG_ATM_CLIP) || defined(CONFIG_ATM_CLIP_MODULE) | 531 | #if defined(CONFIG_ATM_CLIP) || defined(CONFIG_ATM_CLIP_MODULE) |
522 | dev->type == ARPHRD_ATM ? clip_tbl_hook : | 532 | dev->type == ARPHRD_ATM ? |
533 | clip_tbl_hook : | ||
523 | #endif | 534 | #endif |
524 | &arp_tbl, &nexthop, dev); | 535 | &arp_tbl, &nexthop, dev); |
525 | if (IS_ERR(n)) | 536 | if (IS_ERR(n)) |
526 | return PTR_ERR(n); | 537 | return PTR_ERR(n); |
527 | dst->neighbour = n; | 538 | dst->neighbour = n; |
@@ -543,8 +554,8 @@ static inline int arp_fwd_proxy(struct in_device *in_dev, | |||
543 | 554 | ||
544 | if (!IN_DEV_PROXY_ARP(in_dev)) | 555 | if (!IN_DEV_PROXY_ARP(in_dev)) |
545 | return 0; | 556 | return 0; |
546 | 557 | imi = IN_DEV_MEDIUM_ID(in_dev); | |
547 | if ((imi = IN_DEV_MEDIUM_ID(in_dev)) == 0) | 558 | if (imi == 0) |
548 | return 1; | 559 | return 1; |
549 | if (imi == -1) | 560 | if (imi == -1) |
550 | return 0; | 561 | return 0; |
@@ -555,7 +566,7 @@ static inline int arp_fwd_proxy(struct in_device *in_dev, | |||
555 | if (out_dev) | 566 | if (out_dev) |
556 | omi = IN_DEV_MEDIUM_ID(out_dev); | 567 | omi = IN_DEV_MEDIUM_ID(out_dev); |
557 | 568 | ||
558 | return (omi != imi && omi != -1); | 569 | return omi != imi && omi != -1; |
559 | } | 570 | } |
560 | 571 | ||
561 | /* | 572 | /* |
@@ -685,7 +696,7 @@ struct sk_buff *arp_create(int type, int ptype, __be32 dest_ip, | |||
685 | arp->ar_pln = 4; | 696 | arp->ar_pln = 4; |
686 | arp->ar_op = htons(type); | 697 | arp->ar_op = htons(type); |
687 | 698 | ||
688 | arp_ptr=(unsigned char *)(arp+1); | 699 | arp_ptr = (unsigned char *)(arp + 1); |
689 | 700 | ||
690 | memcpy(arp_ptr, src_hw, dev->addr_len); | 701 | memcpy(arp_ptr, src_hw, dev->addr_len); |
691 | arp_ptr += dev->addr_len; | 702 | arp_ptr += dev->addr_len; |
@@ -735,9 +746,8 @@ void arp_send(int type, int ptype, __be32 dest_ip, | |||
735 | 746 | ||
736 | skb = arp_create(type, ptype, dest_ip, dev, src_ip, | 747 | skb = arp_create(type, ptype, dest_ip, dev, src_ip, |
737 | dest_hw, src_hw, target_hw); | 748 | dest_hw, src_hw, target_hw); |
738 | if (skb == NULL) { | 749 | if (skb == NULL) |
739 | return; | 750 | return; |
740 | } | ||
741 | 751 | ||
742 | arp_xmit(skb); | 752 | arp_xmit(skb); |
743 | } | 753 | } |
@@ -815,7 +825,7 @@ static int arp_process(struct sk_buff *skb) | |||
815 | /* | 825 | /* |
816 | * Extract fields | 826 | * Extract fields |
817 | */ | 827 | */ |
818 | arp_ptr= (unsigned char *)(arp+1); | 828 | arp_ptr = (unsigned char *)(arp + 1); |
819 | sha = arp_ptr; | 829 | sha = arp_ptr; |
820 | arp_ptr += dev->addr_len; | 830 | arp_ptr += dev->addr_len; |
821 | memcpy(&sip, arp_ptr, 4); | 831 | memcpy(&sip, arp_ptr, 4); |
@@ -869,16 +879,17 @@ static int arp_process(struct sk_buff *skb) | |||
869 | addr_type = rt->rt_type; | 879 | addr_type = rt->rt_type; |
870 | 880 | ||
871 | if (addr_type == RTN_LOCAL) { | 881 | if (addr_type == RTN_LOCAL) { |
872 | int dont_send = 0; | 882 | int dont_send; |
873 | 883 | ||
874 | if (!dont_send) | 884 | dont_send = arp_ignore(in_dev, sip, tip); |
875 | dont_send |= arp_ignore(in_dev,sip,tip); | ||
876 | if (!dont_send && IN_DEV_ARPFILTER(in_dev)) | 885 | if (!dont_send && IN_DEV_ARPFILTER(in_dev)) |
877 | dont_send |= arp_filter(sip,tip,dev); | 886 | dont_send |= arp_filter(sip, tip, dev); |
878 | if (!dont_send) { | 887 | if (!dont_send) { |
879 | n = neigh_event_ns(&arp_tbl, sha, &sip, dev); | 888 | n = neigh_event_ns(&arp_tbl, sha, &sip, dev); |
880 | if (n) { | 889 | if (n) { |
881 | arp_send(ARPOP_REPLY,ETH_P_ARP,sip,dev,tip,sha,dev->dev_addr,sha); | 890 | arp_send(ARPOP_REPLY, ETH_P_ARP, sip, |
891 | dev, tip, sha, dev->dev_addr, | ||
892 | sha); | ||
882 | neigh_release(n); | 893 | neigh_release(n); |
883 | } | 894 | } |
884 | } | 895 | } |
@@ -887,8 +898,7 @@ static int arp_process(struct sk_buff *skb) | |||
887 | if (addr_type == RTN_UNICAST && | 898 | if (addr_type == RTN_UNICAST && |
888 | (arp_fwd_proxy(in_dev, dev, rt) || | 899 | (arp_fwd_proxy(in_dev, dev, rt) || |
889 | arp_fwd_pvlan(in_dev, dev, rt, sip, tip) || | 900 | arp_fwd_pvlan(in_dev, dev, rt, sip, tip) || |
890 | pneigh_lookup(&arp_tbl, net, &tip, dev, 0))) | 901 | pneigh_lookup(&arp_tbl, net, &tip, dev, 0))) { |
891 | { | ||
892 | n = neigh_event_ns(&arp_tbl, sha, &sip, dev); | 902 | n = neigh_event_ns(&arp_tbl, sha, &sip, dev); |
893 | if (n) | 903 | if (n) |
894 | neigh_release(n); | 904 | neigh_release(n); |
@@ -896,9 +906,12 @@ static int arp_process(struct sk_buff *skb) | |||
896 | if (NEIGH_CB(skb)->flags & LOCALLY_ENQUEUED || | 906 | if (NEIGH_CB(skb)->flags & LOCALLY_ENQUEUED || |
897 | skb->pkt_type == PACKET_HOST || | 907 | skb->pkt_type == PACKET_HOST || |
898 | in_dev->arp_parms->proxy_delay == 0) { | 908 | in_dev->arp_parms->proxy_delay == 0) { |
899 | arp_send(ARPOP_REPLY,ETH_P_ARP,sip,dev,tip,sha,dev->dev_addr,sha); | 909 | arp_send(ARPOP_REPLY, ETH_P_ARP, sip, |
910 | dev, tip, sha, dev->dev_addr, | ||
911 | sha); | ||
900 | } else { | 912 | } else { |
901 | pneigh_enqueue(&arp_tbl, in_dev->arp_parms, skb); | 913 | pneigh_enqueue(&arp_tbl, |
914 | in_dev->arp_parms, skb); | ||
902 | return 0; | 915 | return 0; |
903 | } | 916 | } |
904 | goto out; | 917 | goto out; |
@@ -939,7 +952,8 @@ static int arp_process(struct sk_buff *skb) | |||
939 | if (arp->ar_op != htons(ARPOP_REPLY) || | 952 | if (arp->ar_op != htons(ARPOP_REPLY) || |
940 | skb->pkt_type != PACKET_HOST) | 953 | skb->pkt_type != PACKET_HOST) |
941 | state = NUD_STALE; | 954 | state = NUD_STALE; |
942 | neigh_update(n, sha, state, override ? NEIGH_UPDATE_F_OVERRIDE : 0); | 955 | neigh_update(n, sha, state, |
956 | override ? NEIGH_UPDATE_F_OVERRIDE : 0); | ||
943 | neigh_release(n); | 957 | neigh_release(n); |
944 | } | 958 | } |
945 | 959 | ||
@@ -975,7 +989,8 @@ static int arp_rcv(struct sk_buff *skb, struct net_device *dev, | |||
975 | arp->ar_pln != 4) | 989 | arp->ar_pln != 4) |
976 | goto freeskb; | 990 | goto freeskb; |
977 | 991 | ||
978 | if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) | 992 | skb = skb_share_check(skb, GFP_ATOMIC); |
993 | if (skb == NULL) | ||
979 | goto out_of_mem; | 994 | goto out_of_mem; |
980 | 995 | ||
981 | memset(NEIGH_CB(skb), 0, sizeof(struct neighbour_cb)); | 996 | memset(NEIGH_CB(skb), 0, sizeof(struct neighbour_cb)); |
@@ -1019,7 +1034,7 @@ static int arp_req_set_public(struct net *net, struct arpreq *r, | |||
1019 | return -EINVAL; | 1034 | return -EINVAL; |
1020 | if (!dev && (r->arp_flags & ATF_COM)) { | 1035 | if (!dev && (r->arp_flags & ATF_COM)) { |
1021 | dev = dev_getbyhwaddr(net, r->arp_ha.sa_family, | 1036 | dev = dev_getbyhwaddr(net, r->arp_ha.sa_family, |
1022 | r->arp_ha.sa_data); | 1037 | r->arp_ha.sa_data); |
1023 | if (!dev) | 1038 | if (!dev) |
1024 | return -ENODEV; | 1039 | return -ENODEV; |
1025 | } | 1040 | } |
@@ -1033,7 +1048,7 @@ static int arp_req_set_public(struct net *net, struct arpreq *r, | |||
1033 | } | 1048 | } |
1034 | 1049 | ||
1035 | static int arp_req_set(struct net *net, struct arpreq *r, | 1050 | static int arp_req_set(struct net *net, struct arpreq *r, |
1036 | struct net_device * dev) | 1051 | struct net_device *dev) |
1037 | { | 1052 | { |
1038 | __be32 ip; | 1053 | __be32 ip; |
1039 | struct neighbour *neigh; | 1054 | struct neighbour *neigh; |
@@ -1046,10 +1061,11 @@ static int arp_req_set(struct net *net, struct arpreq *r, | |||
1046 | if (r->arp_flags & ATF_PERM) | 1061 | if (r->arp_flags & ATF_PERM) |
1047 | r->arp_flags |= ATF_COM; | 1062 | r->arp_flags |= ATF_COM; |
1048 | if (dev == NULL) { | 1063 | if (dev == NULL) { |
1049 | struct flowi fl = { .nl_u = { .ip4_u = { .daddr = ip, | 1064 | struct flowi fl = { .nl_u.ip4_u = { .daddr = ip, |
1050 | .tos = RTO_ONLINK } } }; | 1065 | .tos = RTO_ONLINK } }; |
1051 | struct rtable * rt; | 1066 | struct rtable *rt; |
1052 | if ((err = ip_route_output_key(net, &rt, &fl)) != 0) | 1067 | err = ip_route_output_key(net, &rt, &fl); |
1068 | if (err != 0) | ||
1053 | return err; | 1069 | return err; |
1054 | dev = rt->dst.dev; | 1070 | dev = rt->dst.dev; |
1055 | ip_rt_put(rt); | 1071 | ip_rt_put(rt); |
@@ -1083,9 +1099,9 @@ static int arp_req_set(struct net *net, struct arpreq *r, | |||
1083 | unsigned state = NUD_STALE; | 1099 | unsigned state = NUD_STALE; |
1084 | if (r->arp_flags & ATF_PERM) | 1100 | if (r->arp_flags & ATF_PERM) |
1085 | state = NUD_PERMANENT; | 1101 | state = NUD_PERMANENT; |
1086 | err = neigh_update(neigh, (r->arp_flags&ATF_COM) ? | 1102 | err = neigh_update(neigh, (r->arp_flags & ATF_COM) ? |
1087 | r->arp_ha.sa_data : NULL, state, | 1103 | r->arp_ha.sa_data : NULL, state, |
1088 | NEIGH_UPDATE_F_OVERRIDE| | 1104 | NEIGH_UPDATE_F_OVERRIDE | |
1089 | NEIGH_UPDATE_F_ADMIN); | 1105 | NEIGH_UPDATE_F_ADMIN); |
1090 | neigh_release(neigh); | 1106 | neigh_release(neigh); |
1091 | } | 1107 | } |
@@ -1094,12 +1110,12 @@ static int arp_req_set(struct net *net, struct arpreq *r, | |||
1094 | 1110 | ||
1095 | static unsigned arp_state_to_flags(struct neighbour *neigh) | 1111 | static unsigned arp_state_to_flags(struct neighbour *neigh) |
1096 | { | 1112 | { |
1097 | unsigned flags = 0; | ||
1098 | if (neigh->nud_state&NUD_PERMANENT) | 1113 | if (neigh->nud_state&NUD_PERMANENT) |
1099 | flags = ATF_PERM|ATF_COM; | 1114 | return ATF_PERM | ATF_COM; |
1100 | else if (neigh->nud_state&NUD_VALID) | 1115 | else if (neigh->nud_state&NUD_VALID) |
1101 | flags = ATF_COM; | 1116 | return ATF_COM; |
1102 | return flags; | 1117 | else |
1118 | return 0; | ||
1103 | } | 1119 | } |
1104 | 1120 | ||
1105 | /* | 1121 | /* |
@@ -1142,7 +1158,7 @@ static int arp_req_delete_public(struct net *net, struct arpreq *r, | |||
1142 | } | 1158 | } |
1143 | 1159 | ||
1144 | static int arp_req_delete(struct net *net, struct arpreq *r, | 1160 | static int arp_req_delete(struct net *net, struct arpreq *r, |
1145 | struct net_device * dev) | 1161 | struct net_device *dev) |
1146 | { | 1162 | { |
1147 | int err; | 1163 | int err; |
1148 | __be32 ip; | 1164 | __be32 ip; |
@@ -1153,10 +1169,11 @@ static int arp_req_delete(struct net *net, struct arpreq *r, | |||
1153 | 1169 | ||
1154 | ip = ((struct sockaddr_in *)&r->arp_pa)->sin_addr.s_addr; | 1170 | ip = ((struct sockaddr_in *)&r->arp_pa)->sin_addr.s_addr; |
1155 | if (dev == NULL) { | 1171 | if (dev == NULL) { |
1156 | struct flowi fl = { .nl_u = { .ip4_u = { .daddr = ip, | 1172 | struct flowi fl = { .nl_u.ip4_u = { .daddr = ip, |
1157 | .tos = RTO_ONLINK } } }; | 1173 | .tos = RTO_ONLINK } }; |
1158 | struct rtable * rt; | 1174 | struct rtable *rt; |
1159 | if ((err = ip_route_output_key(net, &rt, &fl)) != 0) | 1175 | err = ip_route_output_key(net, &rt, &fl); |
1176 | if (err != 0) | ||
1160 | return err; | 1177 | return err; |
1161 | dev = rt->dst.dev; | 1178 | dev = rt->dst.dev; |
1162 | ip_rt_put(rt); | 1179 | ip_rt_put(rt); |
@@ -1166,7 +1183,7 @@ static int arp_req_delete(struct net *net, struct arpreq *r, | |||
1166 | err = -ENXIO; | 1183 | err = -ENXIO; |
1167 | neigh = neigh_lookup(&arp_tbl, &ip, dev); | 1184 | neigh = neigh_lookup(&arp_tbl, &ip, dev); |
1168 | if (neigh) { | 1185 | if (neigh) { |
1169 | if (neigh->nud_state&~NUD_NOARP) | 1186 | if (neigh->nud_state & ~NUD_NOARP) |
1170 | err = neigh_update(neigh, NULL, NUD_FAILED, | 1187 | err = neigh_update(neigh, NULL, NUD_FAILED, |
1171 | NEIGH_UPDATE_F_OVERRIDE| | 1188 | NEIGH_UPDATE_F_OVERRIDE| |
1172 | NEIGH_UPDATE_F_ADMIN); | 1189 | NEIGH_UPDATE_F_ADMIN); |
@@ -1186,24 +1203,24 @@ int arp_ioctl(struct net *net, unsigned int cmd, void __user *arg) | |||
1186 | struct net_device *dev = NULL; | 1203 | struct net_device *dev = NULL; |
1187 | 1204 | ||
1188 | switch (cmd) { | 1205 | switch (cmd) { |
1189 | case SIOCDARP: | 1206 | case SIOCDARP: |
1190 | case SIOCSARP: | 1207 | case SIOCSARP: |
1191 | if (!capable(CAP_NET_ADMIN)) | 1208 | if (!capable(CAP_NET_ADMIN)) |
1192 | return -EPERM; | 1209 | return -EPERM; |
1193 | case SIOCGARP: | 1210 | case SIOCGARP: |
1194 | err = copy_from_user(&r, arg, sizeof(struct arpreq)); | 1211 | err = copy_from_user(&r, arg, sizeof(struct arpreq)); |
1195 | if (err) | 1212 | if (err) |
1196 | return -EFAULT; | 1213 | return -EFAULT; |
1197 | break; | 1214 | break; |
1198 | default: | 1215 | default: |
1199 | return -EINVAL; | 1216 | return -EINVAL; |
1200 | } | 1217 | } |
1201 | 1218 | ||
1202 | if (r.arp_pa.sa_family != AF_INET) | 1219 | if (r.arp_pa.sa_family != AF_INET) |
1203 | return -EPFNOSUPPORT; | 1220 | return -EPFNOSUPPORT; |
1204 | 1221 | ||
1205 | if (!(r.arp_flags & ATF_PUBL) && | 1222 | if (!(r.arp_flags & ATF_PUBL) && |
1206 | (r.arp_flags & (ATF_NETMASK|ATF_DONTPUB))) | 1223 | (r.arp_flags & (ATF_NETMASK | ATF_DONTPUB))) |
1207 | return -EINVAL; | 1224 | return -EINVAL; |
1208 | if (!(r.arp_flags & ATF_NETMASK)) | 1225 | if (!(r.arp_flags & ATF_NETMASK)) |
1209 | ((struct sockaddr_in *)&r.arp_netmask)->sin_addr.s_addr = | 1226 | ((struct sockaddr_in *)&r.arp_netmask)->sin_addr.s_addr = |
@@ -1211,7 +1228,8 @@ int arp_ioctl(struct net *net, unsigned int cmd, void __user *arg) | |||
1211 | rtnl_lock(); | 1228 | rtnl_lock(); |
1212 | if (r.arp_dev[0]) { | 1229 | if (r.arp_dev[0]) { |
1213 | err = -ENODEV; | 1230 | err = -ENODEV; |
1214 | if ((dev = __dev_get_by_name(net, r.arp_dev)) == NULL) | 1231 | dev = __dev_get_by_name(net, r.arp_dev); |
1232 | if (dev == NULL) | ||
1215 | goto out; | 1233 | goto out; |
1216 | 1234 | ||
1217 | /* Mmmm... It is wrong... ARPHRD_NETROM==0 */ | 1235 | /* Mmmm... It is wrong... ARPHRD_NETROM==0 */ |
@@ -1243,7 +1261,8 @@ out: | |||
1243 | return err; | 1261 | return err; |
1244 | } | 1262 | } |
1245 | 1263 | ||
1246 | static int arp_netdev_event(struct notifier_block *this, unsigned long event, void *ptr) | 1264 | static int arp_netdev_event(struct notifier_block *this, unsigned long event, |
1265 | void *ptr) | ||
1247 | { | 1266 | { |
1248 | struct net_device *dev = ptr; | 1267 | struct net_device *dev = ptr; |
1249 | 1268 | ||
@@ -1311,12 +1330,13 @@ static char *ax2asc2(ax25_address *a, char *buf) | |||
1311 | for (n = 0, s = buf; n < 6; n++) { | 1330 | for (n = 0, s = buf; n < 6; n++) { |
1312 | c = (a->ax25_call[n] >> 1) & 0x7F; | 1331 | c = (a->ax25_call[n] >> 1) & 0x7F; |
1313 | 1332 | ||
1314 | if (c != ' ') *s++ = c; | 1333 | if (c != ' ') |
1334 | *s++ = c; | ||
1315 | } | 1335 | } |
1316 | 1336 | ||
1317 | *s++ = '-'; | 1337 | *s++ = '-'; |
1318 | 1338 | n = (a->ax25_call[6] >> 1) & 0x0F; | |
1319 | if ((n = ((a->ax25_call[6] >> 1) & 0x0F)) > 9) { | 1339 | if (n > 9) { |
1320 | *s++ = '1'; | 1340 | *s++ = '1'; |
1321 | n -= 10; | 1341 | n -= 10; |
1322 | } | 1342 | } |
@@ -1325,10 +1345,9 @@ static char *ax2asc2(ax25_address *a, char *buf) | |||
1325 | *s++ = '\0'; | 1345 | *s++ = '\0'; |
1326 | 1346 | ||
1327 | if (*buf == '\0' || *buf == '-') | 1347 | if (*buf == '\0' || *buf == '-') |
1328 | return "*"; | 1348 | return "*"; |
1329 | 1349 | ||
1330 | return buf; | 1350 | return buf; |
1331 | |||
1332 | } | 1351 | } |
1333 | #endif /* CONFIG_AX25 */ | 1352 | #endif /* CONFIG_AX25 */ |
1334 | 1353 | ||
@@ -1408,10 +1427,10 @@ static void *arp_seq_start(struct seq_file *seq, loff_t *pos) | |||
1408 | /* ------------------------------------------------------------------------ */ | 1427 | /* ------------------------------------------------------------------------ */ |
1409 | 1428 | ||
1410 | static const struct seq_operations arp_seq_ops = { | 1429 | static const struct seq_operations arp_seq_ops = { |
1411 | .start = arp_seq_start, | 1430 | .start = arp_seq_start, |
1412 | .next = neigh_seq_next, | 1431 | .next = neigh_seq_next, |
1413 | .stop = neigh_seq_stop, | 1432 | .stop = neigh_seq_stop, |
1414 | .show = arp_seq_show, | 1433 | .show = arp_seq_show, |
1415 | }; | 1434 | }; |
1416 | 1435 | ||
1417 | static int arp_seq_open(struct inode *inode, struct file *file) | 1436 | static int arp_seq_open(struct inode *inode, struct file *file) |