1 files changed, 12 insertions, 11 deletions

diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index c6b4362bb1d7..bdf784c422b5 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c
@@ -512,7 +512,17 @@ static int do_dccp_setsockopt(struct sock *sk, int level, int optname,
         struct dccp_sock *dp = dccp_sk(sk);
         int val, err = 0;
 
-        if (optlen < sizeof(int))
+        switch (optname) {
+        case DCCP_SOCKOPT_PACKET_SIZE:
+                DCCP_WARN("sockopt(PACKET_SIZE) is deprecated: fix your app\n");
+                return 0;
+        case DCCP_SOCKOPT_CHANGE_L:
+        case DCCP_SOCKOPT_CHANGE_R:
+                DCCP_WARN("sockopt(CHANGE_L/R) is deprecated: fix your app\n");
+                return 0;
+        }
+
+        if (optlen < (int)sizeof(int))
                 return -EINVAL;
 
         if (get_user(val, (int __user *)optval))
@@ -523,15 +533,6 @@ static int do_dccp_setsockopt(struct sock *sk, int level, int optname,
 
         lock_sock(sk);
         switch (optname) {
-        case DCCP_SOCKOPT_PACKET_SIZE:
-                DCCP_WARN("sockopt(PACKET_SIZE) is deprecated: fix your app\n");
-                err = 0;
-                break;
-        case DCCP_SOCKOPT_CHANGE_L:
-        case DCCP_SOCKOPT_CHANGE_R:
-                DCCP_WARN("sockopt(CHANGE_L/R) is deprecated: fix your app\n");
-                err = 0;
-                break;
         case DCCP_SOCKOPT_SERVER_TIMEWAIT:
                 if (dp->dccps_role != DCCP_ROLE_SERVER)
                         err = -EOPNOTSUPP;
@@ -548,8 +549,8 @@ static int do_dccp_setsockopt(struct sock *sk, int level, int optname,
                 err = -ENOPROTOOPT;
                 break;
         }
-
         release_sock(sk);
+
         return err;
 }