4 files changed, 161 insertions, 97 deletions

diff --git a/net/core/dev.c b/net/core/dev.c
index 6ca32f6b3105..763a0eda7158 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -446,7 +446,7 @@ void __dev_remove_pack(struct packet_type *pt)
                 }
         }
 
-        printk(KERN_WARNING "dev_remove_pack: %p not found.\n", pt);
+        pr_warn("dev_remove_pack: %p not found\n", pt);
 out:
         spin_unlock(&ptype_lock);
 }
@@ -1039,8 +1039,7 @@ rollback:
                         memcpy(dev->name, oldname, IFNAMSIZ);
                         goto rollback;
                 } else {
-                        printk(KERN_ERR
-                               "%s: name change rollback failed: %d.\n",
+                        pr_err("%s: name change rollback failed: %d\n",
                                dev->name, ret);
                 }
         }
@@ -1139,9 +1138,8 @@ void dev_load(struct net *net, const char *name)
                 no_module = request_module("netdev-%s", name);
         if (no_module && capable(CAP_SYS_MODULE)) {
                 if (!request_module("%s", name))
-                        pr_err("Loading kernel module for a network device "
-"with CAP_SYS_MODULE (deprecated).  Use CAP_NET_ADMIN and alias netdev-%s "
-"instead\n", name);
+                        pr_err("Loading kernel module for a network device with CAP_SYS_MODULE (deprecated).  Use CAP_NET_ADMIN and alias netdev-%s instead.\n",
+                               name);
         }
 }
 EXPORT_SYMBOL(dev_load);
@@ -1655,10 +1653,9 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev)
                         if (skb_network_header(skb2) < skb2->data ||
                             skb2->network_header > skb2->tail) {
                                 if (net_ratelimit())
-                                        printk(KERN_CRIT "protocol %04x is "
-                                               "buggy, dev %s\n",
-                                               ntohs(skb2->protocol),
-                                               dev->name);
+                                        pr_crit("protocol %04x is buggy, dev %s\n",
+                                                ntohs(skb2->protocol),
+                                                dev->name);
                                 skb_reset_network_header(skb2);
                         }
 
@@ -1691,9 +1688,7 @@ static void netif_setup_tc(struct net_device *dev, unsigned int txq)
 
         /* If TC0 is invalidated disable TC mapping */
         if (tc->offset + tc->count > txq) {
-                pr_warning("Number of in use tx queues changed "
-                           "invalidating tc mappings. Priority "
-                           "traffic classification disabled!\n");
+                pr_warn("Number of in use tx queues changed invalidating tc mappings. Priority traffic classification disabled!\n");
                 dev->num_tc = 0;
                 return;
         }
@@ -1704,11 +1699,8 @@ static void netif_setup_tc(struct net_device *dev, unsigned int txq)
 
                 tc = &dev->tc_to_txq[q];
                 if (tc->offset + tc->count > txq) {
-                        pr_warning("Number of in use tx queues "
-                                   "changed. Priority %i to tc "
-                                   "mapping %i is no longer valid "
-                                   "setting map to 0\n",
-                                   i, q);
+                        pr_warn("Number of in use tx queues changed. Priority %i to tc mapping %i is no longer valid. Setting map to 0\n",
+                                i, q);
                         netdev_set_prio_tc_map(dev, i, 0);
                 }
         }
@@ -2014,8 +2006,7 @@ EXPORT_SYMBOL(skb_gso_segment);
 void netdev_rx_csum_fault(struct net_device *dev)
 {
         if (net_ratelimit()) {
-                printk(KERN_ERR "%s: hw csum failure.\n",
-                        dev ? dev->name : "<unknown>");
+                pr_err("%s: hw csum failure\n", dev ? dev->name : "<unknown>");
                 dump_stack();
         }
 }
@@ -2332,9 +2323,9 @@ static inline u16 dev_cap_txqueue(struct net_device *dev, u16 queue_index)
 {
         if (unlikely(queue_index >= dev->real_num_tx_queues)) {
                 if (net_ratelimit()) {
-                        pr_warning("%s selects TX queue %d, but "
-                                "real number of TX queues is %d\n",
-                                dev->name, queue_index, dev->real_num_tx_queues);
+                        pr_warn("%s selects TX queue %d, but real number of TX queues is %d\n",
+                                dev->name, queue_index,
+                                dev->real_num_tx_queues);
                 }
                 return 0;
         }
@@ -2578,16 +2569,16 @@ int dev_queue_xmit(struct sk_buff *skb)
                         }
                         HARD_TX_UNLOCK(dev, txq);
                         if (net_ratelimit())
-                                printk(KERN_CRIT "Virtual device %s asks to "
-                                       "queue packet!\n", dev->name);
+                                pr_crit("Virtual device %s asks to queue packet!\n",
+                                        dev->name);
                 } else {
                         /* Recursion is detected! It is possible,
                          * unfortunately
                          */
 recursion_alert:
                         if (net_ratelimit())
-                                printk(KERN_CRIT "Dead loop on virtual device "
-                                       "%s, fix it urgently!\n", dev->name);
+                                pr_crit("Dead loop on virtual device %s, fix it urgently!\n",
+                                        dev->name);
                 }
         }
 
@@ -3069,8 +3060,8 @@ static int ing_filter(struct sk_buff *skb, struct netdev_queue *rxq)
 
         if (unlikely(MAX_RED_LOOP < ttl++)) {
                 if (net_ratelimit())
-                        pr_warning( "Redir loop detected Dropping packet (%d->%d)\n",
-                               skb->skb_iif, dev->ifindex);
+                        pr_warn("Redir loop detected Dropping packet (%d->%d)\n",
+                                skb->skb_iif, dev->ifindex);
                 return TC_ACT_SHOT;
         }
 
@@ -4497,16 +4488,15 @@ static int __dev_set_promiscuity(struct net_device *dev, int inc)
                         dev->flags &= ~IFF_PROMISC;
                 else {
                         dev->promiscuity -= inc;
-                        printk(KERN_WARNING "%s: promiscuity touches roof, "
-                                "set promiscuity failed, promiscuity feature "
-                                "of device might be broken.\n", dev->name);
+                        pr_warn("%s: promiscuity touches roof, set promiscuity failed. promiscuity feature of device might be broken.\n",
+                                dev->name);
                         return -EOVERFLOW;
                 }
         }
         if (dev->flags != old_flags) {
-                printk(KERN_INFO "device %s %s promiscuous mode\n",
-                       dev->name, (dev->flags & IFF_PROMISC) ? "entered" :
-                                                               "left");
+                pr_info("device %s %s promiscuous mode\n",
+                        dev->name,
+                        dev->flags & IFF_PROMISC ? "entered" : "left");
                 if (audit_enabled) {
                         current_uid_gid(&uid, &gid);
                         audit_log(current->audit_context, GFP_ATOMIC,
@@ -4579,9 +4569,8 @@ int dev_set_allmulti(struct net_device *dev, int inc)
                         dev->flags &= ~IFF_ALLMULTI;
                 else {
                         dev->allmulti -= inc;
-                        printk(KERN_WARNING "%s: allmulti touches roof, "
-                                "set allmulti failed, allmulti feature of "
-                                "device might be broken.\n", dev->name);
+                        pr_warn("%s: allmulti touches roof, set allmulti failed. allmulti feature of device might be broken.\n",
+                                dev->name);
                         return -EOVERFLOW;
                 }
         }
@@ -5238,8 +5227,8 @@ static void rollback_registered_many(struct list_head *head)
                  * devices and proceed with the remaining.
                  */
                 if (dev->reg_state == NETREG_UNINITIALIZED) {
-                        pr_debug("unregister_netdevice: device %s/%p never "
-                                 "was registered\n", dev->name, dev);
+                        pr_debug("unregister_netdevice: device %s/%p never was registered\n",
+                                 dev->name, dev);
 
                         WARN_ON(1);
                         list_del(&dev->unreg_list);
@@ -5471,7 +5460,7 @@ static int netif_alloc_rx_queues(struct net_device *dev)
 
         rx = kcalloc(count, sizeof(struct netdev_rx_queue), GFP_KERNEL);
         if (!rx) {
-                pr_err("netdev: Unable to allocate %u rx queues.\n", count);
+                pr_err("netdev: Unable to allocate %u rx queues\n", count);
                 return -ENOMEM;
         }
         dev->_rx = rx;
@@ -5505,8 +5494,7 @@ static int netif_alloc_netdev_queues(struct net_device *dev)
 
         tx = kcalloc(count, sizeof(struct netdev_queue), GFP_KERNEL);
         if (!tx) {
-                pr_err("netdev: Unable to allocate %u tx queues.\n",
-                       count);
+                pr_err("netdev: Unable to allocate %u tx queues\n", count);
                 return -ENOMEM;
         }
         dev->_tx = tx;
@@ -5765,10 +5753,8 @@ static void netdev_wait_allrefs(struct net_device *dev)
                 refcnt = netdev_refcnt_read(dev);
 
                 if (time_after(jiffies, warning_time + 10 * HZ)) {
-                        printk(KERN_EMERG "unregister_netdevice: "
-                               "waiting for %s to become free. Usage "
-                               "count = %d\n",
-                               dev->name, refcnt);
+                        pr_emerg("unregister_netdevice: waiting for %s to become free. Usage count = %d\n",
+                                 dev->name, refcnt);
                         warning_time = jiffies;
                 }
         }
@@ -5819,7 +5805,7 @@ void netdev_run_todo(void)
                 list_del(&dev->todo_list);
 
                 if (unlikely(dev->reg_state != NETREG_UNREGISTERING)) {
-                        printk(KERN_ERR "network todo '%s' but state %d\n",
+                        pr_err("network todo '%s' but state %d\n",
                                dev->name, dev->reg_state);
                         dump_stack();
                         continue;
@@ -5935,15 +5921,13 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, const char *name,
         BUG_ON(strlen(name) >= sizeof(dev->name));
 
         if (txqs < 1) {
-                pr_err("alloc_netdev: Unable to allocate device "
-                       "with zero queues.\n");
+                pr_err("alloc_netdev: Unable to allocate device with zero queues\n");
                 return NULL;
         }
 
 #ifdef CONFIG_RPS
         if (rxqs < 1) {
-                pr_err("alloc_netdev: Unable to allocate device "
-                       "with zero RX queues.\n");
+                pr_err("alloc_netdev: Unable to allocate device with zero RX queues\n");
                 return NULL;
         }
 #endif
@@ -5959,7 +5943,7 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, const char *name,
 
         p = kzalloc(alloc_size, GFP_KERNEL);
         if (!p) {
-                printk(KERN_ERR "alloc_netdev: Unable to allocate device.\n");
+                pr_err("alloc_netdev: Unable to allocate device\n");
                 return NULL;
         }
 
@@ -6492,8 +6476,8 @@ static void __net_exit default_device_exit(struct net *net)
                 snprintf(fb_name, IFNAMSIZ, "dev%d", dev->ifindex);
                 err = dev_change_net_namespace(dev, &init_net, fb_name);
                 if (err) {
-                        printk(KERN_EMERG "%s: failed to move %s to init_net: %d\n",
-                                __func__, dev->name, err);
+                        pr_emerg("%s: failed to move %s to init_net: %d\n",
+                                 __func__, dev->name, err);
                         BUG();
                 }
         }
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index e287346e0934..f98ec444133a 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -2165,6 +2165,35 @@ nla_put_failure:
         return -EMSGSIZE;
 }
 
+static int pneigh_fill_info(struct sk_buff *skb, struct pneigh_entry *pn,
+                            u32 pid, u32 seq, int type, unsigned int flags,
+                            struct neigh_table *tbl)
+{
+        struct nlmsghdr *nlh;
+        struct ndmsg *ndm;
+
+        nlh = nlmsg_put(skb, pid, seq, type, sizeof(*ndm), flags);
+        if (nlh == NULL)
+                return -EMSGSIZE;
+
+        ndm = nlmsg_data(nlh);
+        ndm->ndm_family  = tbl->family;
+        ndm->ndm_pad1    = 0;
+        ndm->ndm_pad2    = 0;
+        ndm->ndm_flags   = pn->flags | NTF_PROXY;
+        ndm->ndm_type    = NDA_DST;
+        ndm->ndm_ifindex = pn->dev->ifindex;
+        ndm->ndm_state   = NUD_NONE;
+
+        NLA_PUT(skb, NDA_DST, tbl->key_len, pn->key);
+
+        return nlmsg_end(skb, nlh);
+
+nla_put_failure:
+        nlmsg_cancel(skb, nlh);
+        return -EMSGSIZE;
+}
+
 static void neigh_update_notify(struct neighbour *neigh)
 {
         call_netevent_notifiers(NETEVENT_NEIGH_UPDATE, neigh);
@@ -2214,23 +2243,78 @@ out:
         return rc;
 }
 
+static int pneigh_dump_table(struct neigh_table *tbl, struct sk_buff *skb,
+                             struct netlink_callback *cb)
+{
+        struct pneigh_entry *n;
+        struct net *net = sock_net(skb->sk);
+        int rc, h, s_h = cb->args[3];
+        int idx, s_idx = idx = cb->args[4];
+
+        read_lock_bh(&tbl->lock);
+
+        for (h = 0; h <= PNEIGH_HASHMASK; h++) {
+                if (h < s_h)
+                        continue;
+                if (h > s_h)
+                        s_idx = 0;
+                for (n = tbl->phash_buckets[h], idx = 0; n; n = n->next) {
+                        if (dev_net(n->dev) != net)
+                                continue;
+                        if (idx < s_idx)
+                                goto next;
+                        if (pneigh_fill_info(skb, n, NETLINK_CB(cb->skb).pid,
+                                            cb->nlh->nlmsg_seq,
+                                            RTM_NEWNEIGH,
+                                            NLM_F_MULTI, tbl) <= 0) {
+                                read_unlock_bh(&tbl->lock);
+                                rc = -1;
+                                goto out;
+                        }
+                next:
+                        idx++;
+                }
+        }
+
+        read_unlock_bh(&tbl->lock);
+        rc = skb->len;
+out:
+        cb->args[3] = h;
+        cb->args[4] = idx;
+        return rc;
+
+}
+
 static int neigh_dump_info(struct sk_buff *skb, struct netlink_callback *cb)
 {
         struct neigh_table *tbl;
         int t, family, s_t;
+        int proxy = 0;
+        int err = 0;
 
         read_lock(&neigh_tbl_lock);
         family = ((struct rtgenmsg *) nlmsg_data(cb->nlh))->rtgen_family;
+
+        /* check for full ndmsg structure presence, family member is
+         * the same for both structures
+         */
+        if (nlmsg_len(cb->nlh) >= sizeof(struct ndmsg) &&
+            ((struct ndmsg *) nlmsg_data(cb->nlh))->ndm_flags == NTF_PROXY)
+                proxy = 1;
+
         s_t = cb->args[0];
 
-        for (tbl = neigh_tables, t = 0; tbl; tbl = tbl->next, t++) {
+        for (tbl = neigh_tables, t = 0; tbl && (err >= 0);
+             tbl = tbl->next, t++) {
                 if (t < s_t || (family && tbl->family != family))
                         continue;
                 if (t > s_t)
                         memset(&cb->args[1], 0, sizeof(cb->args) -
                                                 sizeof(cb->args[0]));
-                if (neigh_dump_table(tbl, skb, cb) < 0)
-                        break;
+                if (proxy)
+                        err = pneigh_dump_table(tbl, skb, cb);
+                else
+                        err = neigh_dump_table(tbl, skb, cb);
         }
         read_unlock(&neigh_tbl_lock);
 
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index ddefc513b44a..3d84fb9d8873 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -9,6 +9,8 @@
  * Copyright (C) 2002  Red Hat, Inc.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/moduleparam.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
@@ -45,9 +47,11 @@ static atomic_t trapped;
 #define NETPOLL_RX_ENABLED  1
 #define NETPOLL_RX_DROP     2
 
-#define MAX_SKB_SIZE \
-                (MAX_UDP_CHUNK + sizeof(struct udphdr) + \
-                                sizeof(struct iphdr) + sizeof(struct ethhdr))
+#define MAX_SKB_SIZE                                                    \
+        (sizeof(struct ethhdr) +                                        \
+         sizeof(struct iphdr) +                                         \
+         sizeof(struct udphdr) +                                        \
+         MAX_UDP_CHUNK)
 
 static void zap_completion_queue(void);
 static void arp_reply(struct sk_buff *skb);
@@ -55,6 +59,13 @@ static void arp_reply(struct sk_buff *skb);
 static unsigned int carrier_timeout = 4;
 module_param(carrier_timeout, uint, 0644);
 
+#define np_info(np, fmt, ...)                           \
+        pr_info("%s: " fmt, np->name, ##__VA_ARGS__)
+#define np_err(np, fmt, ...)                            \
+        pr_err("%s: " fmt, np->name, ##__VA_ARGS__)
+#define np_notice(np, fmt, ...)                         \
+        pr_notice("%s: " fmt, np->name, ##__VA_ARGS__)
+
 static void queue_process(struct work_struct *work)
 {
         struct netpoll_info *npinfo =
@@ -627,18 +638,12 @@ out:
 
 void netpoll_print_options(struct netpoll *np)
 {
-        printk(KERN_INFO "%s: local port %d\n",
-                         np->name, np->local_port);
-        printk(KERN_INFO "%s: local IP %pI4\n",
-                         np->name, &np->local_ip);
-        printk(KERN_INFO "%s: interface '%s'\n",
-                         np->name, np->dev_name);
-        printk(KERN_INFO "%s: remote port %d\n",
-                         np->name, np->remote_port);
-        printk(KERN_INFO "%s: remote IP %pI4\n",
-                         np->name, &np->remote_ip);
-        printk(KERN_INFO "%s: remote ethernet address %pM\n",
-                         np->name, np->remote_mac);
+        np_info(np, "local port %d\n", np->local_port);
+        np_info(np, "local IP %pI4\n", &np->local_ip);
+        np_info(np, "interface '%s'\n", np->dev_name);
+        np_info(np, "remote port %d\n", np->remote_port);
+        np_info(np, "remote IP %pI4\n", &np->remote_ip);
+        np_info(np, "remote ethernet address %pM\n", np->remote_mac);
 }
 EXPORT_SYMBOL(netpoll_print_options);
 
@@ -680,8 +685,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
                         goto parse_failed;
                 *delim = 0;
                 if (*cur == ' ' || *cur == '\t')
-                        printk(KERN_INFO "%s: warning: whitespace"
-                                        "is not allowed\n", np->name);
+                        np_info(np, "warning: whitespace is not allowed\n");
                 np->remote_port = simple_strtol(cur, NULL, 10);
                 cur = delim;
         }
@@ -705,8 +709,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
         return 0;
 
  parse_failed:
-        printk(KERN_INFO "%s: couldn't parse config at '%s'!\n",
-               np->name, cur);
+        np_info(np, "couldn't parse config at '%s'!\n", cur);
         return -1;
 }
 EXPORT_SYMBOL(netpoll_parse_options);
@@ -721,8 +724,8 @@ int __netpoll_setup(struct netpoll *np)
 
         if ((ndev->priv_flags & IFF_DISABLE_NETPOLL) ||
             !ndev->netdev_ops->ndo_poll_controller) {
-                printk(KERN_ERR "%s: %s doesn't support polling, aborting.\n",
-                       np->name, np->dev_name);
+                np_err(np, "%s doesn't support polling, aborting\n",
+                       np->dev_name);
                 err = -ENOTSUPP;
                 goto out;
         }
@@ -785,14 +788,12 @@ int netpoll_setup(struct netpoll *np)
         if (np->dev_name)
                 ndev = dev_get_by_name(&init_net, np->dev_name);
         if (!ndev) {
-                printk(KERN_ERR "%s: %s doesn't exist, aborting.\n",
-                       np->name, np->dev_name);
+                np_err(np, "%s doesn't exist, aborting\n", np->dev_name);
                 return -ENODEV;
         }
 
         if (ndev->master) {
-                printk(KERN_ERR "%s: %s is a slave device, aborting.\n",
-                       np->name, np->dev_name);
+                np_err(np, "%s is a slave device, aborting\n", np->dev_name);
                 err = -EBUSY;
                 goto put;
         }
@@ -800,16 +801,14 @@ int netpoll_setup(struct netpoll *np)
         if (!netif_running(ndev)) {
                 unsigned long atmost, atleast;
 
-                printk(KERN_INFO "%s: device %s not up yet, forcing it\n",
-                       np->name, np->dev_name);
+                np_info(np, "device %s not up yet, forcing it\n", np->dev_name);
 
                 rtnl_lock();
                 err = dev_open(ndev);
                 rtnl_unlock();
 
                 if (err) {
-                        printk(KERN_ERR "%s: failed to open %s\n",
-                               np->name, ndev->name);
+                        np_err(np, "failed to open %s\n", ndev->name);
                         goto put;
                 }
 
@@ -817,9 +816,7 @@ int netpoll_setup(struct netpoll *np)
                 atmost = jiffies + carrier_timeout * HZ;
                 while (!netif_carrier_ok(ndev)) {
                         if (time_after(jiffies, atmost)) {
-                                printk(KERN_NOTICE
-                                       "%s: timeout waiting for carrier\n",
-                                       np->name);
+                                np_notice(np, "timeout waiting for carrier\n");
                                 break;
                         }
                         msleep(1);
@@ -831,9 +828,7 @@ int netpoll_setup(struct netpoll *np)
                  */
 
                 if (time_before(jiffies, atleast)) {
-                        printk(KERN_NOTICE "%s: carrier detect appears"
-                               " untrustworthy, waiting 4 seconds\n",
-                               np->name);
+                        np_notice(np, "carrier detect appears untrustworthy, waiting 4 seconds\n");
                         msleep(4000);
                 }
         }
@@ -844,15 +839,15 @@ int netpoll_setup(struct netpoll *np)
 
                 if (!in_dev || !in_dev->ifa_list) {
                         rcu_read_unlock();
-                        printk(KERN_ERR "%s: no IP address for %s, aborting\n",
-                               np->name, np->dev_name);
+                        np_err(np, "no IP address for %s, aborting\n",
+                               np->dev_name);
                         err = -EDESTADDRREQ;
                         goto put;
                 }
 
                 np->local_ip = in_dev->ifa_list->ifa_local;
                 rcu_read_unlock();
-                printk(KERN_INFO "%s: local IP %pI4\n", np->name, &np->local_ip);
+                np_info(np, "local IP %pI4\n", &np->local_ip);
         }
 
         np->dev = ndev;
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index da0c97f2fab4..f3a530780753 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -2906,7 +2906,7 @@ int skb_gro_receive(struct sk_buff **head, struct sk_buff *skb)
         nskb->prev = p;
 
         nskb->data_len += p->len;
-        nskb->truesize += p->len;
+        nskb->truesize += p->truesize;
         nskb->len += p->len;
 
         *head = nskb;
@@ -2916,6 +2916,7 @@ int skb_gro_receive(struct sk_buff **head, struct sk_buff *skb)
         p = nskb;
 
 merge:
+        p->truesize += skb->truesize - len;
         if (offset > headlen) {
                 unsigned int eat = offset - headlen;