diff options
Diffstat (limited to 'net/core')
-rw-r--r-- | net/core/dev.c | 12 | ||||
-rw-r--r-- | net/core/flow.c | 11 | ||||
-rw-r--r-- | net/core/net-procfs.c | 3 | ||||
-rw-r--r-- | net/core/rtnetlink.c | 3 |
4 files changed, 11 insertions, 18 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 18d8b5acc343..a06a7a58dd11 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
@@ -658,11 +658,10 @@ __setup("netdev=", netdev_boot_setup); | |||
658 | 658 | ||
659 | struct net_device *__dev_get_by_name(struct net *net, const char *name) | 659 | struct net_device *__dev_get_by_name(struct net *net, const char *name) |
660 | { | 660 | { |
661 | struct hlist_node *p; | ||
662 | struct net_device *dev; | 661 | struct net_device *dev; |
663 | struct hlist_head *head = dev_name_hash(net, name); | 662 | struct hlist_head *head = dev_name_hash(net, name); |
664 | 663 | ||
665 | hlist_for_each_entry(dev, p, head, name_hlist) | 664 | hlist_for_each_entry(dev, head, name_hlist) |
666 | if (!strncmp(dev->name, name, IFNAMSIZ)) | 665 | if (!strncmp(dev->name, name, IFNAMSIZ)) |
667 | return dev; | 666 | return dev; |
668 | 667 | ||
@@ -684,11 +683,10 @@ EXPORT_SYMBOL(__dev_get_by_name); | |||
684 | 683 | ||
685 | struct net_device *dev_get_by_name_rcu(struct net *net, const char *name) | 684 | struct net_device *dev_get_by_name_rcu(struct net *net, const char *name) |
686 | { | 685 | { |
687 | struct hlist_node *p; | ||
688 | struct net_device *dev; | 686 | struct net_device *dev; |
689 | struct hlist_head *head = dev_name_hash(net, name); | 687 | struct hlist_head *head = dev_name_hash(net, name); |
690 | 688 | ||
691 | hlist_for_each_entry_rcu(dev, p, head, name_hlist) | 689 | hlist_for_each_entry_rcu(dev, head, name_hlist) |
692 | if (!strncmp(dev->name, name, IFNAMSIZ)) | 690 | if (!strncmp(dev->name, name, IFNAMSIZ)) |
693 | return dev; | 691 | return dev; |
694 | 692 | ||
@@ -735,11 +733,10 @@ EXPORT_SYMBOL(dev_get_by_name); | |||
735 | 733 | ||
736 | struct net_device *__dev_get_by_index(struct net *net, int ifindex) | 734 | struct net_device *__dev_get_by_index(struct net *net, int ifindex) |
737 | { | 735 | { |
738 | struct hlist_node *p; | ||
739 | struct net_device *dev; | 736 | struct net_device *dev; |
740 | struct hlist_head *head = dev_index_hash(net, ifindex); | 737 | struct hlist_head *head = dev_index_hash(net, ifindex); |
741 | 738 | ||
742 | hlist_for_each_entry(dev, p, head, index_hlist) | 739 | hlist_for_each_entry(dev, head, index_hlist) |
743 | if (dev->ifindex == ifindex) | 740 | if (dev->ifindex == ifindex) |
744 | return dev; | 741 | return dev; |
745 | 742 | ||
@@ -760,11 +757,10 @@ EXPORT_SYMBOL(__dev_get_by_index); | |||
760 | 757 | ||
761 | struct net_device *dev_get_by_index_rcu(struct net *net, int ifindex) | 758 | struct net_device *dev_get_by_index_rcu(struct net *net, int ifindex) |
762 | { | 759 | { |
763 | struct hlist_node *p; | ||
764 | struct net_device *dev; | 760 | struct net_device *dev; |
765 | struct hlist_head *head = dev_index_hash(net, ifindex); | 761 | struct hlist_head *head = dev_index_hash(net, ifindex); |
766 | 762 | ||
767 | hlist_for_each_entry_rcu(dev, p, head, index_hlist) | 763 | hlist_for_each_entry_rcu(dev, head, index_hlist) |
768 | if (dev->ifindex == ifindex) | 764 | if (dev->ifindex == ifindex) |
769 | return dev; | 765 | return dev; |
770 | 766 | ||
diff --git a/net/core/flow.c b/net/core/flow.c index 43f7495df27a..c56ea6f7f6c7 100644 --- a/net/core/flow.c +++ b/net/core/flow.c | |||
@@ -132,14 +132,14 @@ static void __flow_cache_shrink(struct flow_cache *fc, | |||
132 | int shrink_to) | 132 | int shrink_to) |
133 | { | 133 | { |
134 | struct flow_cache_entry *fle; | 134 | struct flow_cache_entry *fle; |
135 | struct hlist_node *entry, *tmp; | 135 | struct hlist_node *tmp; |
136 | LIST_HEAD(gc_list); | 136 | LIST_HEAD(gc_list); |
137 | int i, deleted = 0; | 137 | int i, deleted = 0; |
138 | 138 | ||
139 | for (i = 0; i < flow_cache_hash_size(fc); i++) { | 139 | for (i = 0; i < flow_cache_hash_size(fc); i++) { |
140 | int saved = 0; | 140 | int saved = 0; |
141 | 141 | ||
142 | hlist_for_each_entry_safe(fle, entry, tmp, | 142 | hlist_for_each_entry_safe(fle, tmp, |
143 | &fcp->hash_table[i], u.hlist) { | 143 | &fcp->hash_table[i], u.hlist) { |
144 | if (saved < shrink_to && | 144 | if (saved < shrink_to && |
145 | flow_entry_valid(fle)) { | 145 | flow_entry_valid(fle)) { |
@@ -211,7 +211,6 @@ flow_cache_lookup(struct net *net, const struct flowi *key, u16 family, u8 dir, | |||
211 | struct flow_cache *fc = &flow_cache_global; | 211 | struct flow_cache *fc = &flow_cache_global; |
212 | struct flow_cache_percpu *fcp; | 212 | struct flow_cache_percpu *fcp; |
213 | struct flow_cache_entry *fle, *tfle; | 213 | struct flow_cache_entry *fle, *tfle; |
214 | struct hlist_node *entry; | ||
215 | struct flow_cache_object *flo; | 214 | struct flow_cache_object *flo; |
216 | size_t keysize; | 215 | size_t keysize; |
217 | unsigned int hash; | 216 | unsigned int hash; |
@@ -235,7 +234,7 @@ flow_cache_lookup(struct net *net, const struct flowi *key, u16 family, u8 dir, | |||
235 | flow_new_hash_rnd(fc, fcp); | 234 | flow_new_hash_rnd(fc, fcp); |
236 | 235 | ||
237 | hash = flow_hash_code(fc, fcp, key, keysize); | 236 | hash = flow_hash_code(fc, fcp, key, keysize); |
238 | hlist_for_each_entry(tfle, entry, &fcp->hash_table[hash], u.hlist) { | 237 | hlist_for_each_entry(tfle, &fcp->hash_table[hash], u.hlist) { |
239 | if (tfle->net == net && | 238 | if (tfle->net == net && |
240 | tfle->family == family && | 239 | tfle->family == family && |
241 | tfle->dir == dir && | 240 | tfle->dir == dir && |
@@ -301,13 +300,13 @@ static void flow_cache_flush_tasklet(unsigned long data) | |||
301 | struct flow_cache *fc = info->cache; | 300 | struct flow_cache *fc = info->cache; |
302 | struct flow_cache_percpu *fcp; | 301 | struct flow_cache_percpu *fcp; |
303 | struct flow_cache_entry *fle; | 302 | struct flow_cache_entry *fle; |
304 | struct hlist_node *entry, *tmp; | 303 | struct hlist_node *tmp; |
305 | LIST_HEAD(gc_list); | 304 | LIST_HEAD(gc_list); |
306 | int i, deleted = 0; | 305 | int i, deleted = 0; |
307 | 306 | ||
308 | fcp = this_cpu_ptr(fc->percpu); | 307 | fcp = this_cpu_ptr(fc->percpu); |
309 | for (i = 0; i < flow_cache_hash_size(fc); i++) { | 308 | for (i = 0; i < flow_cache_hash_size(fc); i++) { |
310 | hlist_for_each_entry_safe(fle, entry, tmp, | 309 | hlist_for_each_entry_safe(fle, tmp, |
311 | &fcp->hash_table[i], u.hlist) { | 310 | &fcp->hash_table[i], u.hlist) { |
312 | if (flow_entry_valid(fle)) | 311 | if (flow_entry_valid(fle)) |
313 | continue; | 312 | continue; |
diff --git a/net/core/net-procfs.c b/net/core/net-procfs.c index 0f6bb6f8d391..3174f1998ee6 100644 --- a/net/core/net-procfs.c +++ b/net/core/net-procfs.c | |||
@@ -16,12 +16,11 @@ static inline struct net_device *dev_from_same_bucket(struct seq_file *seq, loff | |||
16 | { | 16 | { |
17 | struct net *net = seq_file_net(seq); | 17 | struct net *net = seq_file_net(seq); |
18 | struct net_device *dev; | 18 | struct net_device *dev; |
19 | struct hlist_node *p; | ||
20 | struct hlist_head *h; | 19 | struct hlist_head *h; |
21 | unsigned int count = 0, offset = get_offset(*pos); | 20 | unsigned int count = 0, offset = get_offset(*pos); |
22 | 21 | ||
23 | h = &net->dev_name_head[get_bucket(*pos)]; | 22 | h = &net->dev_name_head[get_bucket(*pos)]; |
24 | hlist_for_each_entry_rcu(dev, p, h, name_hlist) { | 23 | hlist_for_each_entry_rcu(dev, h, name_hlist) { |
25 | if (++count == offset) | 24 | if (++count == offset) |
26 | return dev; | 25 | return dev; |
27 | } | 26 | } |
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index d8aa20f6a46e..b376410ff259 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c | |||
@@ -1060,7 +1060,6 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb) | |||
1060 | int idx = 0, s_idx; | 1060 | int idx = 0, s_idx; |
1061 | struct net_device *dev; | 1061 | struct net_device *dev; |
1062 | struct hlist_head *head; | 1062 | struct hlist_head *head; |
1063 | struct hlist_node *node; | ||
1064 | struct nlattr *tb[IFLA_MAX+1]; | 1063 | struct nlattr *tb[IFLA_MAX+1]; |
1065 | u32 ext_filter_mask = 0; | 1064 | u32 ext_filter_mask = 0; |
1066 | 1065 | ||
@@ -1080,7 +1079,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb) | |||
1080 | for (h = s_h; h < NETDEV_HASHENTRIES; h++, s_idx = 0) { | 1079 | for (h = s_h; h < NETDEV_HASHENTRIES; h++, s_idx = 0) { |
1081 | idx = 0; | 1080 | idx = 0; |
1082 | head = &net->dev_index_head[h]; | 1081 | head = &net->dev_index_head[h]; |
1083 | hlist_for_each_entry_rcu(dev, node, head, index_hlist) { | 1082 | hlist_for_each_entry_rcu(dev, head, index_hlist) { |
1084 | if (idx < s_idx) | 1083 | if (idx < s_idx) |
1085 | goto cont; | 1084 | goto cont; |
1086 | if (rtnl_fill_ifinfo(skb, dev, RTM_NEWLINK, | 1085 | if (rtnl_fill_ifinfo(skb, dev, RTM_NEWLINK, |