diff options
Diffstat (limited to 'net/core/dst.c')
-rw-r--r-- | net/core/dst.c | 29 |
1 files changed, 28 insertions, 1 deletions
diff --git a/net/core/dst.c b/net/core/dst.c index 32e542d7f472..8abe628b79f1 100644 --- a/net/core/dst.c +++ b/net/core/dst.c | |||
@@ -271,13 +271,40 @@ void dst_release(struct dst_entry *dst) | |||
271 | if (dst) { | 271 | if (dst) { |
272 | int newrefcnt; | 272 | int newrefcnt; |
273 | 273 | ||
274 | smp_mb__before_atomic_dec(); | ||
275 | newrefcnt = atomic_dec_return(&dst->__refcnt); | 274 | newrefcnt = atomic_dec_return(&dst->__refcnt); |
276 | WARN_ON(newrefcnt < 0); | 275 | WARN_ON(newrefcnt < 0); |
276 | if (unlikely(dst->flags & DST_NOCACHE) && !newrefcnt) { | ||
277 | dst = dst_destroy(dst); | ||
278 | if (dst) | ||
279 | __dst_free(dst); | ||
280 | } | ||
277 | } | 281 | } |
278 | } | 282 | } |
279 | EXPORT_SYMBOL(dst_release); | 283 | EXPORT_SYMBOL(dst_release); |
280 | 284 | ||
285 | /** | ||
286 | * skb_dst_set_noref - sets skb dst, without a reference | ||
287 | * @skb: buffer | ||
288 | * @dst: dst entry | ||
289 | * | ||
290 | * Sets skb dst, assuming a reference was not taken on dst | ||
291 | * skb_dst_drop() should not dst_release() this dst | ||
292 | */ | ||
293 | void skb_dst_set_noref(struct sk_buff *skb, struct dst_entry *dst) | ||
294 | { | ||
295 | WARN_ON(!rcu_read_lock_held() && !rcu_read_lock_bh_held()); | ||
296 | /* If dst not in cache, we must take a reference, because | ||
297 | * dst_release() will destroy dst as soon as its refcount becomes zero | ||
298 | */ | ||
299 | if (unlikely(dst->flags & DST_NOCACHE)) { | ||
300 | dst_hold(dst); | ||
301 | skb_dst_set(skb, dst); | ||
302 | } else { | ||
303 | skb->_skb_refdst = (unsigned long)dst | SKB_DST_NOREF; | ||
304 | } | ||
305 | } | ||
306 | EXPORT_SYMBOL(skb_dst_set_noref); | ||
307 | |||
281 | /* Dirty hack. We did it in 2.2 (in __dst_free), | 308 | /* Dirty hack. We did it in 2.2 (in __dst_free), |
282 | * we have _very_ good reasons not to repeat | 309 | * we have _very_ good reasons not to repeat |
283 | * this mistake in 2.3, but we have no choice | 310 | * this mistake in 2.3, but we have no choice |