1 files changed, 25 insertions, 28 deletions

diff --git a/net/compat.c b/net/compat.c
index ec24d9edb025..63d260e81472 100644
--- a/net/compat.c
+++ b/net/compat.c
@@ -81,7 +81,7 @@ int verify_compat_iovec(struct msghdr *kern_msg, struct iovec *kern_iov,
         int tot_len;
 
         if (kern_msg->msg_namelen) {
-                if (mode==VERIFY_READ) {
+                if (mode == VERIFY_READ) {
                         int err = move_addr_to_kernel(kern_msg->msg_name,
                                                       kern_msg->msg_namelen,
                                                       kern_address);
@@ -354,7 +354,7 @@ static int do_set_attach_filter(struct socket *sock, int level, int optname,
 static int do_set_sock_timeout(struct socket *sock, int level,
                 int optname, char __user *optval, unsigned int optlen)
 {
-        struct compat_timeval __user *up = (struct compat_timeval __user *) optval;
+        struct compat_timeval __user *up = (struct compat_timeval __user *)optval;
         struct timeval ktime;
         mm_segment_t old_fs;
         int err;
@@ -367,7 +367,7 @@ static int do_set_sock_timeout(struct socket *sock, int level,
                 return -EFAULT;
         old_fs = get_fs();
         set_fs(KERNEL_DS);
-        err = sock_setsockopt(sock, level, optname, (char *) &ktime, sizeof(ktime));
+        err = sock_setsockopt(sock, level, optname, (char *)&ktime, sizeof(ktime));
         set_fs(old_fs);
 
         return err;
@@ -389,11 +389,10 @@ asmlinkage long compat_sys_setsockopt(int fd, int level, int optname,
                                 char __user *optval, unsigned int optlen)
 {
         int err;
-        struct socket *sock;
+        struct socket *sock = sockfd_lookup(fd, &err);
 
-        if ((sock = sockfd_lookup(fd, &err))!=NULL)
-        {
-                err = security_socket_setsockopt(sock,level,optname);
+        if (sock) {
+                err = security_socket_setsockopt(sock, level, optname);
                 if (err) {
                         sockfd_put(sock);
                         return err;
@@ -453,7 +452,7 @@ static int compat_sock_getsockopt(struct socket *sock, int level, int optname,
 int compat_sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp)
 {
         struct compat_timeval __user *ctv =
-                        (struct compat_timeval __user*) userstamp;
+                        (struct compat_timeval __user *) userstamp;
         int err = -ENOENT;
         struct timeval tv;
 
@@ -477,7 +476,7 @@ EXPORT_SYMBOL(compat_sock_get_timestamp);
 int compat_sock_get_timestampns(struct sock *sk, struct timespec __user *userstamp)
 {
         struct compat_timespec __user *ctv =
-                        (struct compat_timespec __user*) userstamp;
+                        (struct compat_timespec __user *) userstamp;
         int err = -ENOENT;
         struct timespec ts;
 
@@ -502,12 +501,10 @@ asmlinkage long compat_sys_getsockopt(int fd, int level, int optname,
                                 char __user *optval, int __user *optlen)
 {
         int err;
-        struct socket *sock;
+        struct socket *sock = sockfd_lookup(fd, &err);
 
-        if ((sock = sockfd_lookup(fd, &err))!=NULL)
-        {
-                err = security_socket_getsockopt(sock, level,
-                                                           optname);
+        if (sock) {
+                err = security_socket_getsockopt(sock, level, optname);
                 if (err) {
                         sockfd_put(sock);
                         return err;
@@ -531,7 +528,7 @@ struct compat_group_req {
         __u32                            gr_interface;
         struct __kernel_sockaddr_storage gr_group
                 __attribute__ ((aligned(4)));
-} __attribute__ ((packed));
+} __packed;
 
 struct compat_group_source_req {
         __u32                            gsr_interface;
@@ -539,7 +536,7 @@ struct compat_group_source_req {
                 __attribute__ ((aligned(4)));
         struct __kernel_sockaddr_storage gsr_source
                 __attribute__ ((aligned(4)));
-} __attribute__ ((packed));
+} __packed;
 
 struct compat_group_filter {
         __u32                            gf_interface;
@@ -549,7 +546,7 @@ struct compat_group_filter {
         __u32                            gf_numsrc;
         struct __kernel_sockaddr_storage gf_slist[1]
                 __attribute__ ((aligned(4)));
-} __attribute__ ((packed));
+} __packed;
 
 #define __COMPAT_GF0_SIZE (sizeof(struct compat_group_filter) - \
                         sizeof(struct __kernel_sockaddr_storage))
@@ -557,7 +554,7 @@ struct compat_group_filter {
 
 int compat_mc_setsockopt(struct sock *sock, int level, int optname,
         char __user *optval, unsigned int optlen,
-        int (*setsockopt)(struct sock *,int,int,char __user *,unsigned int))
+        int (*setsockopt)(struct sock *, int, int, char __user *, unsigned int))
 {
         char __user     *koptval = optval;
         int             koptlen = optlen;
@@ -640,12 +637,11 @@ int compat_mc_setsockopt(struct sock *sock, int level, int optname,
         }
         return setsockopt(sock, level, optname, koptval, koptlen);
 }
-
 EXPORT_SYMBOL(compat_mc_setsockopt);
 
 int compat_mc_getsockopt(struct sock *sock, int level, int optname,
         char __user *optval, int __user *optlen,
-        int (*getsockopt)(struct sock *,int,int,char __user *,int __user *))
+        int (*getsockopt)(struct sock *, int, int, char __user *, int __user *))
 {
         struct compat_group_filter __user *gf32 = (void *)optval;
         struct group_filter __user *kgf;
@@ -681,7 +677,7 @@ int compat_mc_getsockopt(struct sock *sock, int level, int optname,
             __put_user(interface, &kgf->gf_interface) ||
             __put_user(fmode, &kgf->gf_fmode) ||
             __put_user(numsrc, &kgf->gf_numsrc) ||
-            copy_in_user(&kgf->gf_group,&gf32->gf_group,sizeof(kgf->gf_group)))
+            copy_in_user(&kgf->gf_group, &gf32->gf_group, sizeof(kgf->gf_group)))
                 return -EFAULT;
 
         err = getsockopt(sock, level, optname, (char __user *)kgf, koptlen);
@@ -714,21 +710,22 @@ int compat_mc_getsockopt(struct sock *sock, int level, int optname,
                 copylen = numsrc * sizeof(gf32->gf_slist[0]);
                 if (copylen > klen)
                         copylen = klen;
-                if (copy_in_user(gf32->gf_slist, kgf->gf_slist, copylen))
+                if (copy_in_user(gf32->gf_slist, kgf->gf_slist, copylen))
                         return -EFAULT;
         }
         return err;
 }
-
 EXPORT_SYMBOL(compat_mc_getsockopt);
 
 
 /* Argument list sizes for compat_sys_socketcall */
 #define AL(x) ((x) * sizeof(u32))
-static unsigned char nas[20]={AL(0),AL(3),AL(3),AL(3),AL(2),AL(3),
-                                AL(3),AL(3),AL(4),AL(4),AL(4),AL(6),
-                                AL(6),AL(2),AL(5),AL(5),AL(3),AL(3),
-                                AL(4),AL(5)};
+static unsigned char nas[20] = {
+        AL(0), AL(3), AL(3), AL(3), AL(2), AL(3),
+        AL(3), AL(3), AL(4), AL(4), AL(4), AL(6),
+        AL(6), AL(2), AL(5), AL(5), AL(3), AL(3),
+        AL(4), AL(5)
+};
 #undef AL
 
 asmlinkage long compat_sys_sendmsg(int fd, struct compat_msghdr __user *msg, unsigned flags)
@@ -827,7 +824,7 @@ asmlinkage long compat_sys_socketcall(int call, u32 __user *args)
                                           compat_ptr(a[4]), compat_ptr(a[5]));
                 break;
         case SYS_SHUTDOWN:
-                ret = sys_shutdown(a0,a1);
+                ret = sys_shutdown(a0, a1);
                 break;
         case SYS_SETSOCKOPT:
                 ret = compat_sys_setsockopt(a0, a1, a[2],