diff options
Diffstat (limited to 'net/caif/chnl_net.c')
-rw-r--r-- | net/caif/chnl_net.c | 46 |
1 files changed, 21 insertions, 25 deletions
diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c index 4293e190ec53..86aac24b0225 100644 --- a/net/caif/chnl_net.c +++ b/net/caif/chnl_net.c | |||
@@ -5,6 +5,8 @@ | |||
5 | * License terms: GNU General Public License (GPL) version 2 | 5 | * License terms: GNU General Public License (GPL) version 2 |
6 | */ | 6 | */ |
7 | 7 | ||
8 | #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ | ||
9 | |||
8 | #include <linux/version.h> | 10 | #include <linux/version.h> |
9 | #include <linux/fs.h> | 11 | #include <linux/fs.h> |
10 | #include <linux/init.h> | 12 | #include <linux/init.h> |
@@ -29,7 +31,7 @@ | |||
29 | #define CAIF_NET_DEFAULT_QUEUE_LEN 500 | 31 | #define CAIF_NET_DEFAULT_QUEUE_LEN 500 |
30 | 32 | ||
31 | #undef pr_debug | 33 | #undef pr_debug |
32 | #define pr_debug pr_warning | 34 | #define pr_debug pr_warn |
33 | 35 | ||
34 | /*This list is protected by the rtnl lock. */ | 36 | /*This list is protected by the rtnl lock. */ |
35 | static LIST_HEAD(chnl_net_list); | 37 | static LIST_HEAD(chnl_net_list); |
@@ -142,8 +144,7 @@ static void chnl_flowctrl_cb(struct cflayer *layr, enum caif_ctrlcmd flow, | |||
142 | int phyid) | 144 | int phyid) |
143 | { | 145 | { |
144 | struct chnl_net *priv = container_of(layr, struct chnl_net, chnl); | 146 | struct chnl_net *priv = container_of(layr, struct chnl_net, chnl); |
145 | pr_debug("CAIF: %s(): NET flowctrl func called flow: %s\n", | 147 | pr_debug("NET flowctrl func called flow: %s\n", |
146 | __func__, | ||
147 | flow == CAIF_CTRLCMD_FLOW_ON_IND ? "ON" : | 148 | flow == CAIF_CTRLCMD_FLOW_ON_IND ? "ON" : |
148 | flow == CAIF_CTRLCMD_INIT_RSP ? "INIT" : | 149 | flow == CAIF_CTRLCMD_INIT_RSP ? "INIT" : |
149 | flow == CAIF_CTRLCMD_FLOW_OFF_IND ? "OFF" : | 150 | flow == CAIF_CTRLCMD_FLOW_OFF_IND ? "OFF" : |
@@ -196,12 +197,12 @@ static int chnl_net_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
196 | priv = netdev_priv(dev); | 197 | priv = netdev_priv(dev); |
197 | 198 | ||
198 | if (skb->len > priv->netdev->mtu) { | 199 | if (skb->len > priv->netdev->mtu) { |
199 | pr_warning("CAIF: %s(): Size of skb exceeded MTU\n", __func__); | 200 | pr_warn("Size of skb exceeded MTU\n"); |
200 | return -ENOSPC; | 201 | return -ENOSPC; |
201 | } | 202 | } |
202 | 203 | ||
203 | if (!priv->flowenabled) { | 204 | if (!priv->flowenabled) { |
204 | pr_debug("CAIF: %s(): dropping packets flow off\n", __func__); | 205 | pr_debug("dropping packets flow off\n"); |
205 | return NETDEV_TX_BUSY; | 206 | return NETDEV_TX_BUSY; |
206 | } | 207 | } |
207 | 208 | ||
@@ -237,7 +238,7 @@ static int chnl_net_open(struct net_device *dev) | |||
237 | ASSERT_RTNL(); | 238 | ASSERT_RTNL(); |
238 | priv = netdev_priv(dev); | 239 | priv = netdev_priv(dev); |
239 | if (!priv) { | 240 | if (!priv) { |
240 | pr_debug("CAIF: %s(): chnl_net_open: no priv\n", __func__); | 241 | pr_debug("chnl_net_open: no priv\n"); |
241 | return -ENODEV; | 242 | return -ENODEV; |
242 | } | 243 | } |
243 | 244 | ||
@@ -246,18 +247,17 @@ static int chnl_net_open(struct net_device *dev) | |||
246 | result = caif_connect_client(&priv->conn_req, &priv->chnl, | 247 | result = caif_connect_client(&priv->conn_req, &priv->chnl, |
247 | &llifindex, &headroom, &tailroom); | 248 | &llifindex, &headroom, &tailroom); |
248 | if (result != 0) { | 249 | if (result != 0) { |
249 | pr_debug("CAIF: %s(): err: " | 250 | pr_debug("err: " |
250 | "Unable to register and open device," | 251 | "Unable to register and open device," |
251 | " Err:%d\n", | 252 | " Err:%d\n", |
252 | __func__, | 253 | result); |
253 | result); | ||
254 | goto error; | 254 | goto error; |
255 | } | 255 | } |
256 | 256 | ||
257 | lldev = dev_get_by_index(dev_net(dev), llifindex); | 257 | lldev = dev_get_by_index(dev_net(dev), llifindex); |
258 | 258 | ||
259 | if (lldev == NULL) { | 259 | if (lldev == NULL) { |
260 | pr_debug("CAIF: %s(): no interface?\n", __func__); | 260 | pr_debug("no interface?\n"); |
261 | result = -ENODEV; | 261 | result = -ENODEV; |
262 | goto error; | 262 | goto error; |
263 | } | 263 | } |
@@ -279,9 +279,7 @@ static int chnl_net_open(struct net_device *dev) | |||
279 | dev_put(lldev); | 279 | dev_put(lldev); |
280 | 280 | ||
281 | if (mtu < 100) { | 281 | if (mtu < 100) { |
282 | pr_warning("CAIF: %s(): " | 282 | pr_warn("CAIF Interface MTU too small (%d)\n", mtu); |
283 | "CAIF Interface MTU too small (%d)\n", | ||
284 | __func__, mtu); | ||
285 | result = -ENODEV; | 283 | result = -ENODEV; |
286 | goto error; | 284 | goto error; |
287 | } | 285 | } |
@@ -296,33 +294,32 @@ static int chnl_net_open(struct net_device *dev) | |||
296 | rtnl_lock(); | 294 | rtnl_lock(); |
297 | 295 | ||
298 | if (result == -ERESTARTSYS) { | 296 | if (result == -ERESTARTSYS) { |
299 | pr_debug("CAIF: %s(): wait_event_interruptible" | 297 | pr_debug("wait_event_interruptible woken by a signal\n"); |
300 | " woken by a signal\n", __func__); | ||
301 | result = -ERESTARTSYS; | 298 | result = -ERESTARTSYS; |
302 | goto error; | 299 | goto error; |
303 | } | 300 | } |
304 | 301 | ||
305 | if (result == 0) { | 302 | if (result == 0) { |
306 | pr_debug("CAIF: %s(): connect timeout\n", __func__); | 303 | pr_debug("connect timeout\n"); |
307 | caif_disconnect_client(&priv->chnl); | 304 | caif_disconnect_client(&priv->chnl); |
308 | priv->state = CAIF_DISCONNECTED; | 305 | priv->state = CAIF_DISCONNECTED; |
309 | pr_debug("CAIF: %s(): state disconnected\n", __func__); | 306 | pr_debug("state disconnected\n"); |
310 | result = -ETIMEDOUT; | 307 | result = -ETIMEDOUT; |
311 | goto error; | 308 | goto error; |
312 | } | 309 | } |
313 | 310 | ||
314 | if (priv->state != CAIF_CONNECTED) { | 311 | if (priv->state != CAIF_CONNECTED) { |
315 | pr_debug("CAIF: %s(): connect failed\n", __func__); | 312 | pr_debug("connect failed\n"); |
316 | result = -ECONNREFUSED; | 313 | result = -ECONNREFUSED; |
317 | goto error; | 314 | goto error; |
318 | } | 315 | } |
319 | pr_debug("CAIF: %s(): CAIF Netdevice connected\n", __func__); | 316 | pr_debug("CAIF Netdevice connected\n"); |
320 | return 0; | 317 | return 0; |
321 | 318 | ||
322 | error: | 319 | error: |
323 | caif_disconnect_client(&priv->chnl); | 320 | caif_disconnect_client(&priv->chnl); |
324 | priv->state = CAIF_DISCONNECTED; | 321 | priv->state = CAIF_DISCONNECTED; |
325 | pr_debug("CAIF: %s(): state disconnected\n", __func__); | 322 | pr_debug("state disconnected\n"); |
326 | return result; | 323 | return result; |
327 | 324 | ||
328 | } | 325 | } |
@@ -413,7 +410,7 @@ static void caif_netlink_parms(struct nlattr *data[], | |||
413 | struct caif_connect_request *conn_req) | 410 | struct caif_connect_request *conn_req) |
414 | { | 411 | { |
415 | if (!data) { | 412 | if (!data) { |
416 | pr_warning("CAIF: %s: no params data found\n", __func__); | 413 | pr_warn("no params data found\n"); |
417 | return; | 414 | return; |
418 | } | 415 | } |
419 | if (data[IFLA_CAIF_IPV4_CONNID]) | 416 | if (data[IFLA_CAIF_IPV4_CONNID]) |
@@ -442,8 +439,7 @@ static int ipcaif_newlink(struct net *src_net, struct net_device *dev, | |||
442 | 439 | ||
443 | ret = register_netdevice(dev); | 440 | ret = register_netdevice(dev); |
444 | if (ret) | 441 | if (ret) |
445 | pr_warning("CAIF: %s(): device rtml registration failed\n", | 442 | pr_warn("device rtml registration failed\n"); |
446 | __func__); | ||
447 | return ret; | 443 | return ret; |
448 | } | 444 | } |
449 | 445 | ||