diff options
Diffstat (limited to 'net/bridge/br_fdb.c')
-rw-r--r-- | net/bridge/br_fdb.c | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index 8117900af4de..b0812c91c0f0 100644 --- a/net/bridge/br_fdb.c +++ b/net/bridge/br_fdb.c | |||
@@ -181,9 +181,9 @@ void br_fdb_cleanup(unsigned long _data) | |||
181 | spin_lock(&br->hash_lock); | 181 | spin_lock(&br->hash_lock); |
182 | for (i = 0; i < BR_HASH_SIZE; i++) { | 182 | for (i = 0; i < BR_HASH_SIZE; i++) { |
183 | struct net_bridge_fdb_entry *f; | 183 | struct net_bridge_fdb_entry *f; |
184 | struct hlist_node *h, *n; | 184 | struct hlist_node *n; |
185 | 185 | ||
186 | hlist_for_each_entry_safe(f, h, n, &br->hash[i], hlist) { | 186 | hlist_for_each_entry_safe(f, n, &br->hash[i], hlist) { |
187 | unsigned long this_timer; | 187 | unsigned long this_timer; |
188 | if (f->is_static) | 188 | if (f->is_static) |
189 | continue; | 189 | continue; |
@@ -207,8 +207,8 @@ void br_fdb_flush(struct net_bridge *br) | |||
207 | spin_lock_bh(&br->hash_lock); | 207 | spin_lock_bh(&br->hash_lock); |
208 | for (i = 0; i < BR_HASH_SIZE; i++) { | 208 | for (i = 0; i < BR_HASH_SIZE; i++) { |
209 | struct net_bridge_fdb_entry *f; | 209 | struct net_bridge_fdb_entry *f; |
210 | struct hlist_node *h, *n; | 210 | struct hlist_node *n; |
211 | hlist_for_each_entry_safe(f, h, n, &br->hash[i], hlist) { | 211 | hlist_for_each_entry_safe(f, n, &br->hash[i], hlist) { |
212 | if (!f->is_static) | 212 | if (!f->is_static) |
213 | fdb_delete(br, f); | 213 | fdb_delete(br, f); |
214 | } | 214 | } |
@@ -266,10 +266,9 @@ struct net_bridge_fdb_entry *__br_fdb_get(struct net_bridge *br, | |||
266 | const unsigned char *addr, | 266 | const unsigned char *addr, |
267 | __u16 vid) | 267 | __u16 vid) |
268 | { | 268 | { |
269 | struct hlist_node *h; | ||
270 | struct net_bridge_fdb_entry *fdb; | 269 | struct net_bridge_fdb_entry *fdb; |
271 | 270 | ||
272 | hlist_for_each_entry_rcu(fdb, h, | 271 | hlist_for_each_entry_rcu(fdb, |
273 | &br->hash[br_mac_hash(addr, vid)], hlist) { | 272 | &br->hash[br_mac_hash(addr, vid)], hlist) { |
274 | if (ether_addr_equal(fdb->addr.addr, addr) && | 273 | if (ether_addr_equal(fdb->addr.addr, addr) && |
275 | fdb->vlan_id == vid) { | 274 | fdb->vlan_id == vid) { |
@@ -315,14 +314,13 @@ int br_fdb_fillbuf(struct net_bridge *br, void *buf, | |||
315 | { | 314 | { |
316 | struct __fdb_entry *fe = buf; | 315 | struct __fdb_entry *fe = buf; |
317 | int i, num = 0; | 316 | int i, num = 0; |
318 | struct hlist_node *h; | ||
319 | struct net_bridge_fdb_entry *f; | 317 | struct net_bridge_fdb_entry *f; |
320 | 318 | ||
321 | memset(buf, 0, maxnum*sizeof(struct __fdb_entry)); | 319 | memset(buf, 0, maxnum*sizeof(struct __fdb_entry)); |
322 | 320 | ||
323 | rcu_read_lock(); | 321 | rcu_read_lock(); |
324 | for (i = 0; i < BR_HASH_SIZE; i++) { | 322 | for (i = 0; i < BR_HASH_SIZE; i++) { |
325 | hlist_for_each_entry_rcu(f, h, &br->hash[i], hlist) { | 323 | hlist_for_each_entry_rcu(f, &br->hash[i], hlist) { |
326 | if (num >= maxnum) | 324 | if (num >= maxnum) |
327 | goto out; | 325 | goto out; |
328 | 326 | ||
@@ -363,10 +361,9 @@ static struct net_bridge_fdb_entry *fdb_find(struct hlist_head *head, | |||
363 | const unsigned char *addr, | 361 | const unsigned char *addr, |
364 | __u16 vid) | 362 | __u16 vid) |
365 | { | 363 | { |
366 | struct hlist_node *h; | ||
367 | struct net_bridge_fdb_entry *fdb; | 364 | struct net_bridge_fdb_entry *fdb; |
368 | 365 | ||
369 | hlist_for_each_entry(fdb, h, head, hlist) { | 366 | hlist_for_each_entry(fdb, head, hlist) { |
370 | if (ether_addr_equal(fdb->addr.addr, addr) && | 367 | if (ether_addr_equal(fdb->addr.addr, addr) && |
371 | fdb->vlan_id == vid) | 368 | fdb->vlan_id == vid) |
372 | return fdb; | 369 | return fdb; |
@@ -378,10 +375,9 @@ static struct net_bridge_fdb_entry *fdb_find_rcu(struct hlist_head *head, | |||
378 | const unsigned char *addr, | 375 | const unsigned char *addr, |
379 | __u16 vid) | 376 | __u16 vid) |
380 | { | 377 | { |
381 | struct hlist_node *h; | ||
382 | struct net_bridge_fdb_entry *fdb; | 378 | struct net_bridge_fdb_entry *fdb; |
383 | 379 | ||
384 | hlist_for_each_entry_rcu(fdb, h, head, hlist) { | 380 | hlist_for_each_entry_rcu(fdb, head, hlist) { |
385 | if (ether_addr_equal(fdb->addr.addr, addr) && | 381 | if (ether_addr_equal(fdb->addr.addr, addr) && |
386 | fdb->vlan_id == vid) | 382 | fdb->vlan_id == vid) |
387 | return fdb; | 383 | return fdb; |
@@ -593,10 +589,9 @@ int br_fdb_dump(struct sk_buff *skb, | |||
593 | goto out; | 589 | goto out; |
594 | 590 | ||
595 | for (i = 0; i < BR_HASH_SIZE; i++) { | 591 | for (i = 0; i < BR_HASH_SIZE; i++) { |
596 | struct hlist_node *h; | ||
597 | struct net_bridge_fdb_entry *f; | 592 | struct net_bridge_fdb_entry *f; |
598 | 593 | ||
599 | hlist_for_each_entry_rcu(f, h, &br->hash[i], hlist) { | 594 | hlist_for_each_entry_rcu(f, &br->hash[i], hlist) { |
600 | if (idx < cb->args[0]) | 595 | if (idx < cb->args[0]) |
601 | goto skip; | 596 | goto skip; |
602 | 597 | ||