1 files changed, 22 insertions, 23 deletions

diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c
index c258796313e0..fa8f4de53b99 100644
--- a/net/bluetooth/rfcomm/tty.c
+++ b/net/bluetooth/rfcomm/tty.c
@@ -34,6 +34,7 @@
 #include <linux/capability.h>
 #include <linux/slab.h>
 #include <linux/skbuff.h>
+#include <linux/workqueue.h>
 
 #include <net/bluetooth/bluetooth.h>
 #include <net/bluetooth/hci_core.h>
@@ -65,7 +66,7 @@ struct rfcomm_dev {
         struct rfcomm_dlc       *dlc;
         struct tty_struct       *tty;
         wait_queue_head_t       wait;
-        struct tasklet_struct   wakeup_task;
+        struct work_struct      wakeup_task;
 
         struct device           *tty_dev;
 
@@ -81,7 +82,7 @@ static void rfcomm_dev_data_ready(struct rfcomm_dlc *dlc, struct sk_buff *skb);
 static void rfcomm_dev_state_change(struct rfcomm_dlc *dlc, int err);
 static void rfcomm_dev_modem_status(struct rfcomm_dlc *dlc, u8 v24_sig);
 
-static void rfcomm_tty_wakeup(unsigned long arg);
+static void rfcomm_tty_wakeup(struct work_struct *work);
 
 /* ---- Device functions ---- */
 static void rfcomm_dev_destruct(struct rfcomm_dev *dev)
@@ -133,13 +134,10 @@ static inline void rfcomm_dev_put(struct rfcomm_dev *dev)
 static struct rfcomm_dev *__rfcomm_dev_get(int id)
 {
         struct rfcomm_dev *dev;
-        struct list_head  *p;
 
-        list_for_each(p, &rfcomm_dev_list) {
-                dev = list_entry(p, struct rfcomm_dev, list);
+        list_for_each_entry(dev, &rfcomm_dev_list, list)
                 if (dev->id == id)
                         return dev;
-        }
 
         return NULL;
 }
@@ -197,7 +195,7 @@ static DEVICE_ATTR(channel, S_IRUGO, show_channel, NULL);
 
 static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc)
 {
-        struct rfcomm_dev *dev;
+        struct rfcomm_dev *dev, *entry;
         struct list_head *head = &rfcomm_dev_list, *p;
         int err = 0;
 
@@ -212,8 +210,8 @@ static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc)
         if (req->dev_id < 0) {
                 dev->id = 0;
 
-                list_for_each(p, &rfcomm_dev_list) {
-                        if (list_entry(p, struct rfcomm_dev, list)->id != dev->id)
+                list_for_each_entry(entry, &rfcomm_dev_list, list) {
+                        if (entry->id != dev->id)
                                 break;
 
                         dev->id++;
@@ -222,9 +220,7 @@ static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc)
         } else {
                 dev->id = req->dev_id;
 
-                list_for_each(p, &rfcomm_dev_list) {
-                        struct rfcomm_dev *entry = list_entry(p, struct rfcomm_dev, list);
-
+                list_for_each_entry(entry, &rfcomm_dev_list, list) {
                         if (entry->id == dev->id) {
                                 err = -EADDRINUSE;
                                 goto out;
@@ -257,7 +253,7 @@ static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc)
         atomic_set(&dev->opened, 0);
 
         init_waitqueue_head(&dev->wait);
-        tasklet_init(&dev->wakeup_task, rfcomm_tty_wakeup, (unsigned long) dev);
+        INIT_WORK(&dev->wakeup_task, rfcomm_tty_wakeup);
 
         skb_queue_head_init(&dev->pending);
 
@@ -351,7 +347,7 @@ static void rfcomm_wfree(struct sk_buff *skb)
         struct rfcomm_dev *dev = (void *) skb->sk;
         atomic_sub(skb->truesize, &dev->wmem_alloc);
         if (test_bit(RFCOMM_TTY_ATTACHED, &dev->flags))
-                tasklet_schedule(&dev->wakeup_task);
+                queue_work(system_nrt_wq, &dev->wakeup_task);
         rfcomm_dev_put(dev);
 }
 
@@ -455,9 +451,9 @@ static int rfcomm_release_dev(void __user *arg)
 
 static int rfcomm_get_dev_list(void __user *arg)
 {
+        struct rfcomm_dev *dev;
         struct rfcomm_dev_list_req *dl;
         struct rfcomm_dev_info *di;
-        struct list_head *p;
         int n = 0, size, err;
         u16 dev_num;
 
@@ -479,8 +475,7 @@ static int rfcomm_get_dev_list(void __user *arg)
 
         read_lock_bh(&rfcomm_dev_lock);
 
-        list_for_each(p, &rfcomm_dev_list) {
-                struct rfcomm_dev *dev = list_entry(p, struct rfcomm_dev, list);
+        list_for_each_entry(dev, &rfcomm_dev_list, list) {
                 if (test_bit(RFCOMM_TTY_RELEASED, &dev->flags))
                         continue;
                 (di + n)->id      = dev->id;
@@ -635,9 +630,10 @@ static void rfcomm_dev_modem_status(struct rfcomm_dlc *dlc, u8 v24_sig)
 }
 
 /* ---- TTY functions ---- */
-static void rfcomm_tty_wakeup(unsigned long arg)
+static void rfcomm_tty_wakeup(struct work_struct *work)
 {
-        struct rfcomm_dev *dev = (void *) arg;
+        struct rfcomm_dev *dev = container_of(work, struct rfcomm_dev,
+                                                                wakeup_task);
         struct tty_struct *tty = dev->tty;
         if (!tty)
                 return;
@@ -762,7 +758,7 @@ static void rfcomm_tty_close(struct tty_struct *tty, struct file *filp)
                 rfcomm_dlc_close(dev->dlc, 0);
 
                 clear_bit(RFCOMM_TTY_ATTACHED, &dev->flags);
-                tasklet_kill(&dev->wakeup_task);
+                cancel_work_sync(&dev->wakeup_task);
 
                 rfcomm_dlc_lock(dev->dlc);
                 tty->driver_data = NULL;
@@ -1155,9 +1151,11 @@ static const struct tty_operations rfcomm_ops = {
 
 int __init rfcomm_init_ttys(void)
 {
+        int error;
+
         rfcomm_tty_driver = alloc_tty_driver(RFCOMM_TTY_PORTS);
         if (!rfcomm_tty_driver)
-                return -1;
+                return -ENOMEM;
 
         rfcomm_tty_driver->owner        = THIS_MODULE;
         rfcomm_tty_driver->driver_name  = "rfcomm";
@@ -1172,10 +1170,11 @@ int __init rfcomm_init_ttys(void)
         rfcomm_tty_driver->init_termios.c_lflag &= ~ICANON;
         tty_set_operations(rfcomm_tty_driver, &rfcomm_ops);
 
-        if (tty_register_driver(rfcomm_tty_driver)) {
+        error = tty_register_driver(rfcomm_tty_driver);
+        if (error) {
                 BT_ERR("Can't register RFCOMM TTY driver");
                 put_tty_driver(rfcomm_tty_driver);
-                return -1;
+                return error;
         }
 
         BT_INFO("RFCOMM TTY layer initialized");