diff options
Diffstat (limited to 'net/batman-adv/distributed-arp-table.c')
-rw-r--r-- | net/batman-adv/distributed-arp-table.c | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index 761a59002e34..d54188a112ea 100644 --- a/net/batman-adv/distributed-arp-table.c +++ b/net/batman-adv/distributed-arp-table.c | |||
@@ -83,7 +83,7 @@ static void __batadv_dat_purge(struct batadv_priv *bat_priv, | |||
83 | { | 83 | { |
84 | spinlock_t *list_lock; /* protects write access to the hash lists */ | 84 | spinlock_t *list_lock; /* protects write access to the hash lists */ |
85 | struct batadv_dat_entry *dat_entry; | 85 | struct batadv_dat_entry *dat_entry; |
86 | struct hlist_node *node, *node_tmp; | 86 | struct hlist_node *node_tmp; |
87 | struct hlist_head *head; | 87 | struct hlist_head *head; |
88 | uint32_t i; | 88 | uint32_t i; |
89 | 89 | ||
@@ -95,7 +95,7 @@ static void __batadv_dat_purge(struct batadv_priv *bat_priv, | |||
95 | list_lock = &bat_priv->dat.hash->list_locks[i]; | 95 | list_lock = &bat_priv->dat.hash->list_locks[i]; |
96 | 96 | ||
97 | spin_lock_bh(list_lock); | 97 | spin_lock_bh(list_lock); |
98 | hlist_for_each_entry_safe(dat_entry, node, node_tmp, head, | 98 | hlist_for_each_entry_safe(dat_entry, node_tmp, head, |
99 | hash_entry) { | 99 | hash_entry) { |
100 | /* if an helper function has been passed as parameter, | 100 | /* if an helper function has been passed as parameter, |
101 | * ask it if the entry has to be purged or not | 101 | * ask it if the entry has to be purged or not |
@@ -103,7 +103,7 @@ static void __batadv_dat_purge(struct batadv_priv *bat_priv, | |||
103 | if (to_purge && !to_purge(dat_entry)) | 103 | if (to_purge && !to_purge(dat_entry)) |
104 | continue; | 104 | continue; |
105 | 105 | ||
106 | hlist_del_rcu(node); | 106 | hlist_del_rcu(&dat_entry->hash_entry); |
107 | batadv_dat_entry_free_ref(dat_entry); | 107 | batadv_dat_entry_free_ref(dat_entry); |
108 | } | 108 | } |
109 | spin_unlock_bh(list_lock); | 109 | spin_unlock_bh(list_lock); |
@@ -235,7 +235,6 @@ static struct batadv_dat_entry * | |||
235 | batadv_dat_entry_hash_find(struct batadv_priv *bat_priv, __be32 ip) | 235 | batadv_dat_entry_hash_find(struct batadv_priv *bat_priv, __be32 ip) |
236 | { | 236 | { |
237 | struct hlist_head *head; | 237 | struct hlist_head *head; |
238 | struct hlist_node *node; | ||
239 | struct batadv_dat_entry *dat_entry, *dat_entry_tmp = NULL; | 238 | struct batadv_dat_entry *dat_entry, *dat_entry_tmp = NULL; |
240 | struct batadv_hashtable *hash = bat_priv->dat.hash; | 239 | struct batadv_hashtable *hash = bat_priv->dat.hash; |
241 | uint32_t index; | 240 | uint32_t index; |
@@ -247,7 +246,7 @@ batadv_dat_entry_hash_find(struct batadv_priv *bat_priv, __be32 ip) | |||
247 | head = &hash->table[index]; | 246 | head = &hash->table[index]; |
248 | 247 | ||
249 | rcu_read_lock(); | 248 | rcu_read_lock(); |
250 | hlist_for_each_entry_rcu(dat_entry, node, head, hash_entry) { | 249 | hlist_for_each_entry_rcu(dat_entry, head, hash_entry) { |
251 | if (dat_entry->ip != ip) | 250 | if (dat_entry->ip != ip) |
252 | continue; | 251 | continue; |
253 | 252 | ||
@@ -465,7 +464,6 @@ static void batadv_choose_next_candidate(struct batadv_priv *bat_priv, | |||
465 | batadv_dat_addr_t max = 0, tmp_max = 0; | 464 | batadv_dat_addr_t max = 0, tmp_max = 0; |
466 | struct batadv_orig_node *orig_node, *max_orig_node = NULL; | 465 | struct batadv_orig_node *orig_node, *max_orig_node = NULL; |
467 | struct batadv_hashtable *hash = bat_priv->orig_hash; | 466 | struct batadv_hashtable *hash = bat_priv->orig_hash; |
468 | struct hlist_node *node; | ||
469 | struct hlist_head *head; | 467 | struct hlist_head *head; |
470 | int i; | 468 | int i; |
471 | 469 | ||
@@ -481,7 +479,7 @@ static void batadv_choose_next_candidate(struct batadv_priv *bat_priv, | |||
481 | head = &hash->table[i]; | 479 | head = &hash->table[i]; |
482 | 480 | ||
483 | rcu_read_lock(); | 481 | rcu_read_lock(); |
484 | hlist_for_each_entry_rcu(orig_node, node, head, hash_entry) { | 482 | hlist_for_each_entry_rcu(orig_node, head, hash_entry) { |
485 | /* the dht space is a ring and addresses are unsigned */ | 483 | /* the dht space is a ring and addresses are unsigned */ |
486 | tmp_max = BATADV_DAT_ADDR_MAX - orig_node->dat_addr + | 484 | tmp_max = BATADV_DAT_ADDR_MAX - orig_node->dat_addr + |
487 | ip_key; | 485 | ip_key; |
@@ -686,7 +684,6 @@ int batadv_dat_cache_seq_print_text(struct seq_file *seq, void *offset) | |||
686 | struct batadv_hashtable *hash = bat_priv->dat.hash; | 684 | struct batadv_hashtable *hash = bat_priv->dat.hash; |
687 | struct batadv_dat_entry *dat_entry; | 685 | struct batadv_dat_entry *dat_entry; |
688 | struct batadv_hard_iface *primary_if; | 686 | struct batadv_hard_iface *primary_if; |
689 | struct hlist_node *node; | ||
690 | struct hlist_head *head; | 687 | struct hlist_head *head; |
691 | unsigned long last_seen_jiffies; | 688 | unsigned long last_seen_jiffies; |
692 | int last_seen_msecs, last_seen_secs, last_seen_mins; | 689 | int last_seen_msecs, last_seen_secs, last_seen_mins; |
@@ -704,7 +701,7 @@ int batadv_dat_cache_seq_print_text(struct seq_file *seq, void *offset) | |||
704 | head = &hash->table[i]; | 701 | head = &hash->table[i]; |
705 | 702 | ||
706 | rcu_read_lock(); | 703 | rcu_read_lock(); |
707 | hlist_for_each_entry_rcu(dat_entry, node, head, hash_entry) { | 704 | hlist_for_each_entry_rcu(dat_entry, head, hash_entry) { |
708 | last_seen_jiffies = jiffies - dat_entry->last_update; | 705 | last_seen_jiffies = jiffies - dat_entry->last_update; |
709 | last_seen_msecs = jiffies_to_msecs(last_seen_jiffies); | 706 | last_seen_msecs = jiffies_to_msecs(last_seen_jiffies); |
710 | last_seen_mins = last_seen_msecs / 60000; | 707 | last_seen_mins = last_seen_msecs / 60000; |