1 files changed, 133 insertions, 165 deletions

diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 5d055c242ed8..f42bc2b26b85 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -21,21 +21,15 @@
  */
 
 #include <linux/module.h>
-#include <linux/mm.h>
-#include <linux/in.h>
-#include <linux/init.h>
-#include <asm/uaccess.h> /* for copy_from_user */
 #include <linux/skbuff.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
-#include <net/datalink.h>
-#include <net/p8022.h>
+#include <linux/ethtool.h>
 #include <net/arp.h>
 
 #include "vlan.h"
 #include "vlanproc.h"
 #include <linux/if_vlan.h>
-#include <net/ip.h>
 
 /*
  *      Rebuild the Ethernet MAC header. This is called after an ARP
@@ -73,11 +67,8 @@ static int vlan_dev_rebuild_header(struct sk_buff *skb)
 static inline struct sk_buff *vlan_check_reorder_header(struct sk_buff *skb)
 {
         if (vlan_dev_info(skb->dev)->flags & VLAN_FLAG_REORDER_HDR) {
-                if (skb_shared(skb) || skb_cloned(skb)) {
-                        struct sk_buff *nskb = skb_copy(skb, GFP_ATOMIC);
-                        kfree_skb(skb);
-                        skb = nskb;
-                }
+                if (skb_cow(skb, skb_headroom(skb)) < 0)
+                        skb = NULL;
                 if (skb) {
                         /* Lifted from Gleb's VLAN code... */
                         memmove(skb->data - ETH_HLEN,
@@ -149,9 +140,9 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
                   struct packet_type *ptype, struct net_device *orig_dev)
 {
         struct vlan_hdr *vhdr;
-        unsigned short vid;
         struct net_device_stats *stats;
-        unsigned short vlan_TCI;
+        u16 vlan_id;
+        u16 vlan_tci;
 
         skb = skb_share_check(skb, GFP_ATOMIC);
         if (skb == NULL)
@@ -161,14 +152,14 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
                 goto err_free;
 
         vhdr = (struct vlan_hdr *)skb->data;
-        vlan_TCI = ntohs(vhdr->h_vlan_TCI);
-        vid = (vlan_TCI & VLAN_VID_MASK);
+        vlan_tci = ntohs(vhdr->h_vlan_TCI);
+        vlan_id = vlan_tci & VLAN_VID_MASK;
 
         rcu_read_lock();
-        skb->dev = __find_vlan_dev(dev, vid);
+        skb->dev = __find_vlan_dev(dev, vlan_id);
         if (!skb->dev) {
                 pr_debug("%s: ERROR: No net_device for VID: %u on dev: %s\n",
-                         __func__, (unsigned int)vid, dev->name);
+                         __func__, vlan_id, dev->name);
                 goto err_unlock;
         }
 
@@ -180,11 +171,10 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
 
         skb_pull_rcsum(skb, VLAN_HLEN);
 
-        skb->priority = vlan_get_ingress_priority(skb->dev,
-                                                  ntohs(vhdr->h_vlan_TCI));
+        skb->priority = vlan_get_ingress_priority(skb->dev, vlan_tci);
 
         pr_debug("%s: priority: %u for TCI: %hu\n",
-                 __func__, skb->priority, ntohs(vhdr->h_vlan_TCI));
+                 __func__, skb->priority, vlan_tci);
 
         switch (skb->pkt_type) {
         case PACKET_BROADCAST: /* Yeah, stats collect these together.. */
@@ -227,7 +217,7 @@ err_free:
         return NET_RX_DROP;
 }
 
-static inline unsigned short
+static inline u16
 vlan_dev_get_egress_qos_mask(struct net_device *dev, struct sk_buff *skb)
 {
         struct vlan_priority_tci_mapping *mp;
@@ -259,103 +249,44 @@ static int vlan_dev_hard_header(struct sk_buff *skb, struct net_device *dev,
                                 unsigned int len)
 {
         struct vlan_hdr *vhdr;
-        unsigned short veth_TCI = 0;
-        int rc = 0;
-        int build_vlan_header = 0;
-        struct net_device *vdev = dev;
-
-        pr_debug("%s: skb: %p type: %hx len: %u vlan_id: %hx, daddr: %p\n",
-                 __func__, skb, type, len, vlan_dev_info(dev)->vlan_id,
-                 daddr);
-
-        /* build vlan header only if re_order_header flag is NOT set.  This
-         * fixes some programs that get confused when they see a VLAN device
-         * sending a frame that is VLAN encoded (the consensus is that the VLAN
-         * device should look completely like an Ethernet device when the
-         * REORDER_HEADER flag is set)  The drawback to this is some extra
-         * header shuffling in the hard_start_xmit.  Users can turn off this
-         * REORDER behaviour with the vconfig tool.
-         */
-        if (!(vlan_dev_info(dev)->flags & VLAN_FLAG_REORDER_HDR))
-                build_vlan_header = 1;
+        unsigned int vhdrlen = 0;
+        u16 vlan_tci = 0;
+        int rc;
 
-        if (build_vlan_header) {
-                vhdr = (struct vlan_hdr *) skb_push(skb, VLAN_HLEN);
+        if (WARN_ON(skb_headroom(skb) < dev->hard_header_len))
+                return -ENOSPC;
 
-                /* build the four bytes that make this a VLAN header. */
-
-                /* Now, construct the second two bytes. This field looks
-                 * something like:
-                 * usr_priority: 3 bits  (high bits)
-                 * CFI           1 bit
-                 * VLAN ID       12 bits (low bits)
-                 *
-                 */
-                veth_TCI = vlan_dev_info(dev)->vlan_id;
-                veth_TCI |= vlan_dev_get_egress_qos_mask(dev, skb);
+        if (!(vlan_dev_info(dev)->flags & VLAN_FLAG_REORDER_HDR)) {
+                vhdr = (struct vlan_hdr *) skb_push(skb, VLAN_HLEN);
 
-                vhdr->h_vlan_TCI = htons(veth_TCI);
+                vlan_tci = vlan_dev_info(dev)->vlan_id;
+                vlan_tci |= vlan_dev_get_egress_qos_mask(dev, skb);
+                vhdr->h_vlan_TCI = htons(vlan_tci);
 
                 /*
                  *  Set the protocol type. For a packet of type ETH_P_802_3 we
                  *  put the length in here instead. It is up to the 802.2
                  *  layer to carry protocol information.
                  */
-
                 if (type != ETH_P_802_3)
                         vhdr->h_vlan_encapsulated_proto = htons(type);
                 else
                         vhdr->h_vlan_encapsulated_proto = htons(len);
 
                 skb->protocol = htons(ETH_P_8021Q);
-                skb_reset_network_header(skb);
+                type = ETH_P_8021Q;
+                vhdrlen = VLAN_HLEN;
         }
 
         /* Before delegating work to the lower layer, enter our MAC-address */
         if (saddr == NULL)
                 saddr = dev->dev_addr;
 
+        /* Now make the underlying real hard header */
         dev = vlan_dev_info(dev)->real_dev;
-
-        /* MPLS can send us skbuffs w/out enough space. This check will grow
-         * the skb if it doesn't have enough headroom. Not a beautiful solution,
-         * so I'll tick a counter so that users can know it's happening...
-         * If they care...
-         */
-
-        /* NOTE: This may still break if the underlying device is not the final
-         * device (and thus there are more headers to add...) It should work for
-         * good-ole-ethernet though.
-         */
-        if (skb_headroom(skb) < dev->hard_header_len) {
-                struct sk_buff *sk_tmp = skb;
-                skb = skb_realloc_headroom(sk_tmp, dev->hard_header_len);
-                kfree_skb(sk_tmp);
-                if (skb == NULL) {
-                        struct net_device_stats *stats = &vdev->stats;
-                        stats->tx_dropped++;
-                        return -ENOMEM;
-                }
-                vlan_dev_info(vdev)->cnt_inc_headroom_on_tx++;
-                pr_debug("%s: %s: had to grow skb\n", __func__, vdev->name);
-        }
-
-        if (build_vlan_header) {
-                /* Now make the underlying real hard header */
-                rc = dev_hard_header(skb, dev, ETH_P_8021Q, daddr, saddr,
-                                     len + VLAN_HLEN);
-                if (rc > 0)
-                        rc += VLAN_HLEN;
-                else if (rc < 0)
-                        rc -= VLAN_HLEN;
-        } else
-                /* If here, then we'll just make a normal looking ethernet
-                 * frame, but, the hard_start_xmit method will insert the tag
-                 * (it has to be able to do this for bridged and other skbs
-                 * that don't come down the protocol stack in an orderly manner.
-                 */
-                rc = dev_hard_header(skb, dev, type, daddr, saddr, len);
-
+        rc = dev_hard_header(skb, dev, type, daddr, saddr, len + vhdrlen);
+        if (rc > 0)
+                rc += vhdrlen;
         return rc;
 }
 
@@ -369,78 +300,49 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
          * NOTE: THIS ASSUMES DIX ETHERNET, SPECIFICALLY NOT SUPPORTING
          * OTHER THINGS LIKE FDDI/TokenRing/802.3 SNAPs...
          */
-
         if (veth->h_vlan_proto != htons(ETH_P_8021Q) ||
-                vlan_dev_info(dev)->flags & VLAN_FLAG_REORDER_HDR) {
-                int orig_headroom = skb_headroom(skb);
-                unsigned short veth_TCI;
+            vlan_dev_info(dev)->flags & VLAN_FLAG_REORDER_HDR) {
+                unsigned int orig_headroom = skb_headroom(skb);
+                u16 vlan_tci;
 
-                /* This is not a VLAN frame...but we can fix that! */
                 vlan_dev_info(dev)->cnt_encap_on_xmit++;
 
-                pr_debug("%s: proto to encap: 0x%hx\n",
-                         __func__, ntohs(veth->h_vlan_proto));
-                /* Construct the second two bytes. This field looks something
-                 * like:
-                 * usr_priority: 3 bits  (high bits)
-                 * CFI           1 bit
-                 * VLAN ID       12 bits (low bits)
-                 */
-                veth_TCI = vlan_dev_info(dev)->vlan_id;
-                veth_TCI |= vlan_dev_get_egress_qos_mask(dev, skb);
-
-                skb = __vlan_put_tag(skb, veth_TCI);
+                vlan_tci = vlan_dev_info(dev)->vlan_id;
+                vlan_tci |= vlan_dev_get_egress_qos_mask(dev, skb);
+                skb = __vlan_put_tag(skb, vlan_tci);
                 if (!skb) {
                         stats->tx_dropped++;
-                        return 0;
+                        return NETDEV_TX_OK;
                 }
 
                 if (orig_headroom < VLAN_HLEN)
                         vlan_dev_info(dev)->cnt_inc_headroom_on_tx++;
         }
 
-        pr_debug("%s: about to send skb: %p to dev: %s\n",
-                __func__, skb, skb->dev->name);
-        pr_debug("  " MAC_FMT " " MAC_FMT " %4hx %4hx %4hx\n",
-                 veth->h_dest[0], veth->h_dest[1], veth->h_dest[2],
-                 veth->h_dest[3], veth->h_dest[4], veth->h_dest[5],
-                 veth->h_source[0], veth->h_source[1], veth->h_source[2],
-                 veth->h_source[3], veth->h_source[4], veth->h_source[5],
-                 veth->h_vlan_proto, veth->h_vlan_TCI,
-                 veth->h_vlan_encapsulated_proto);
-
-        stats->tx_packets++; /* for statics only */
+        stats->tx_packets++;
         stats->tx_bytes += skb->len;
 
         skb->dev = vlan_dev_info(dev)->real_dev;
         dev_queue_xmit(skb);
-
-        return 0;
+        return NETDEV_TX_OK;
 }
 
 static int vlan_dev_hwaccel_hard_start_xmit(struct sk_buff *skb,
                                             struct net_device *dev)
 {
         struct net_device_stats *stats = &dev->stats;
-        unsigned short veth_TCI;
+        u16 vlan_tci;
 
-        /* Construct the second two bytes. This field looks something
-         * like:
-         * usr_priority: 3 bits  (high bits)
-         * CFI           1 bit
-         * VLAN ID       12 bits (low bits)
-         */
-        veth_TCI = vlan_dev_info(dev)->vlan_id;
-        veth_TCI |= vlan_dev_get_egress_qos_mask(dev, skb);
-        skb = __vlan_hwaccel_put_tag(skb, veth_TCI);
+        vlan_tci = vlan_dev_info(dev)->vlan_id;
+        vlan_tci |= vlan_dev_get_egress_qos_mask(dev, skb);
+        skb = __vlan_hwaccel_put_tag(skb, vlan_tci);
 
         stats->tx_packets++;
         stats->tx_bytes += skb->len;
 
         skb->dev = vlan_dev_info(dev)->real_dev;
         dev_queue_xmit(skb);
-
-        return 0;
+        return NETDEV_TX_OK;
 }
 
 static int vlan_dev_change_mtu(struct net_device *dev, int new_mtu)
@@ -457,7 +359,7 @@ static int vlan_dev_change_mtu(struct net_device *dev, int new_mtu)
 }
 
 void vlan_dev_set_ingress_priority(const struct net_device *dev,
-                                   u32 skb_prio, short vlan_prio)
+                                   u32 skb_prio, u16 vlan_prio)
 {
         struct vlan_dev_info *vlan = vlan_dev_info(dev);
 
@@ -470,7 +372,7 @@ void vlan_dev_set_ingress_priority(const struct net_device *dev,
 }
 
 int vlan_dev_set_egress_priority(const struct net_device *dev,
-                                 u32 skb_prio, short vlan_prio)
+                                 u32 skb_prio, u16 vlan_prio)
 {
         struct vlan_dev_info *vlan = vlan_dev_info(dev);
         struct vlan_priority_tci_mapping *mp = NULL;
@@ -507,18 +409,23 @@ int vlan_dev_set_egress_priority(const struct net_device *dev,
 }
 
 /* Flags are defined in the vlan_flags enum in include/linux/if_vlan.h file. */
-int vlan_dev_set_vlan_flag(const struct net_device *dev,
-                           u32 flag, short flag_val)
+int vlan_dev_change_flags(const struct net_device *dev, u32 flags, u32 mask)
 {
-        /* verify flag is supported */
-        if (flag == VLAN_FLAG_REORDER_HDR) {
-                if (flag_val)
-                        vlan_dev_info(dev)->flags |= VLAN_FLAG_REORDER_HDR;
+        struct vlan_dev_info *vlan = vlan_dev_info(dev);
+        u32 old_flags = vlan->flags;
+
+        if (mask & ~(VLAN_FLAG_REORDER_HDR | VLAN_FLAG_GVRP))
+                return -EINVAL;
+
+        vlan->flags = (old_flags & ~mask) | (flags & mask);
+
+        if (netif_running(dev) && (vlan->flags ^ old_flags) & VLAN_FLAG_GVRP) {
+                if (vlan->flags & VLAN_FLAG_GVRP)
+                        vlan_gvrp_request_join(dev);
                 else
-                        vlan_dev_info(dev)->flags &= ~VLAN_FLAG_REORDER_HDR;
-                return 0;
+                        vlan_gvrp_request_leave(dev);
         }
-        return -EINVAL;
+        return 0;
 }
 
 void vlan_dev_get_realdev_name(const struct net_device *dev, char *result)
@@ -526,11 +433,6 @@ void vlan_dev_get_realdev_name(const struct net_device *dev, char *result)
         strncpy(result, vlan_dev_info(dev)->real_dev->name, 23);
 }
 
-void vlan_dev_get_vid(const struct net_device *dev, unsigned short *result)
-{
-        *result = vlan_dev_info(dev)->vlan_id;
-}
-
 static int vlan_dev_open(struct net_device *dev)
 {
         struct vlan_dev_info *vlan = vlan_dev_info(dev);
@@ -543,21 +445,44 @@ static int vlan_dev_open(struct net_device *dev)
         if (compare_ether_addr(dev->dev_addr, real_dev->dev_addr)) {
                 err = dev_unicast_add(real_dev, dev->dev_addr, ETH_ALEN);
                 if (err < 0)
-                        return err;
+                        goto out;
+        }
+
+        if (dev->flags & IFF_ALLMULTI) {
+                err = dev_set_allmulti(real_dev, 1);
+                if (err < 0)
+                        goto del_unicast;
         }
+        if (dev->flags & IFF_PROMISC) {
+                err = dev_set_promiscuity(real_dev, 1);
+                if (err < 0)
+                        goto clear_allmulti;
+        }
+
         memcpy(vlan->real_dev_addr, real_dev->dev_addr, ETH_ALEN);
 
-        if (dev->flags & IFF_ALLMULTI)
-                dev_set_allmulti(real_dev, 1);
-        if (dev->flags & IFF_PROMISC)
-                dev_set_promiscuity(real_dev, 1);
+        if (vlan->flags & VLAN_FLAG_GVRP)
+                vlan_gvrp_request_join(dev);
 
         return 0;
+
+clear_allmulti:
+        if (dev->flags & IFF_ALLMULTI)
+                dev_set_allmulti(real_dev, -1);
+del_unicast:
+        if (compare_ether_addr(dev->dev_addr, real_dev->dev_addr))
+                dev_unicast_delete(real_dev, dev->dev_addr, ETH_ALEN);
+out:
+        return err;
 }
 
 static int vlan_dev_stop(struct net_device *dev)
 {
-        struct net_device *real_dev = vlan_dev_info(dev)->real_dev;
+        struct vlan_dev_info *vlan = vlan_dev_info(dev);
+        struct net_device *real_dev = vlan->real_dev;
+
+        if (vlan->flags & VLAN_FLAG_GVRP)
+                vlan_gvrp_request_leave(dev);
 
         dev_mc_unsync(real_dev, dev);
         dev_unicast_unsync(real_dev, dev);
@@ -645,6 +570,20 @@ static void vlan_dev_set_rx_mode(struct net_device *vlan_dev)
  */
 static struct lock_class_key vlan_netdev_xmit_lock_key;
 
+static void vlan_dev_set_lockdep_one(struct net_device *dev,
+                                     struct netdev_queue *txq,
+                                     void *_subclass)
+{
+        lockdep_set_class_and_subclass(&txq->_xmit_lock,
+                                       &vlan_netdev_xmit_lock_key,
+                                       *(int *)_subclass);
+}
+
+static void vlan_dev_set_lockdep_class(struct net_device *dev, int subclass)
+{
+        netdev_for_each_tx_queue(dev, vlan_dev_set_lockdep_one, &subclass);
+}
+
 static const struct header_ops vlan_header_ops = {
         .create  = vlan_dev_hard_header,
         .rebuild = vlan_dev_rebuild_header,
@@ -683,11 +622,10 @@ static int vlan_dev_init(struct net_device *dev)
                 dev->hard_start_xmit = vlan_dev_hard_start_xmit;
         }
 
-        if (real_dev->priv_flags & IFF_802_1Q_VLAN)
+        if (is_vlan_dev(real_dev))
                 subclass = 1;
 
-        lockdep_set_class_and_subclass(&dev->_xmit_lock,
-                                &vlan_netdev_xmit_lock_key, subclass);
+        vlan_dev_set_lockdep_class(dev, subclass);
         return 0;
 }
 
@@ -705,6 +643,35 @@ static void vlan_dev_uninit(struct net_device *dev)
         }
 }
 
+static u32 vlan_ethtool_get_rx_csum(struct net_device *dev)
+{
+        const struct vlan_dev_info *vlan = vlan_dev_info(dev);
+        struct net_device *real_dev = vlan->real_dev;
+
+        if (real_dev->ethtool_ops == NULL ||
+            real_dev->ethtool_ops->get_rx_csum == NULL)
+                return 0;
+        return real_dev->ethtool_ops->get_rx_csum(real_dev);
+}
+
+static u32 vlan_ethtool_get_flags(struct net_device *dev)
+{
+        const struct vlan_dev_info *vlan = vlan_dev_info(dev);
+        struct net_device *real_dev = vlan->real_dev;
+
+        if (!(real_dev->features & NETIF_F_HW_VLAN_RX) ||
+            real_dev->ethtool_ops == NULL ||
+            real_dev->ethtool_ops->get_flags == NULL)
+                return 0;
+        return real_dev->ethtool_ops->get_flags(real_dev);
+}
+
+static const struct ethtool_ops vlan_ethtool_ops = {
+        .get_link               = ethtool_op_get_link,
+        .get_rx_csum            = vlan_ethtool_get_rx_csum,
+        .get_flags              = vlan_ethtool_get_flags,
+};
+
 void vlan_setup(struct net_device *dev)
 {
         ether_setup(dev);
@@ -723,6 +690,7 @@ void vlan_setup(struct net_device *dev)
         dev->change_rx_flags    = vlan_dev_change_rx_flags;
         dev->do_ioctl           = vlan_dev_ioctl;
         dev->destructor         = free_netdev;
+        dev->ethtool_ops        = &vlan_ethtool_ops;
 
         memset(dev->broadcast, 0, ETH_ALEN);
 }