diff options
Diffstat (limited to 'mm/slub.c')
-rw-r--r-- | mm/slub.c | 30 |
1 files changed, 8 insertions, 22 deletions
@@ -210,14 +210,11 @@ enum track_item { TRACK_ALLOC, TRACK_FREE }; | |||
210 | #ifdef CONFIG_SYSFS | 210 | #ifdef CONFIG_SYSFS |
211 | static int sysfs_slab_add(struct kmem_cache *); | 211 | static int sysfs_slab_add(struct kmem_cache *); |
212 | static int sysfs_slab_alias(struct kmem_cache *, const char *); | 212 | static int sysfs_slab_alias(struct kmem_cache *, const char *); |
213 | static void sysfs_slab_remove(struct kmem_cache *); | ||
214 | static void memcg_propagate_slab_attrs(struct kmem_cache *s); | 213 | static void memcg_propagate_slab_attrs(struct kmem_cache *s); |
215 | #else | 214 | #else |
216 | static inline int sysfs_slab_add(struct kmem_cache *s) { return 0; } | 215 | static inline int sysfs_slab_add(struct kmem_cache *s) { return 0; } |
217 | static inline int sysfs_slab_alias(struct kmem_cache *s, const char *p) | 216 | static inline int sysfs_slab_alias(struct kmem_cache *s, const char *p) |
218 | { return 0; } | 217 | { return 0; } |
219 | static inline void sysfs_slab_remove(struct kmem_cache *s) { } | ||
220 | |||
221 | static inline void memcg_propagate_slab_attrs(struct kmem_cache *s) { } | 218 | static inline void memcg_propagate_slab_attrs(struct kmem_cache *s) { } |
222 | #endif | 219 | #endif |
223 | 220 | ||
@@ -3238,24 +3235,7 @@ static inline int kmem_cache_close(struct kmem_cache *s) | |||
3238 | 3235 | ||
3239 | int __kmem_cache_shutdown(struct kmem_cache *s) | 3236 | int __kmem_cache_shutdown(struct kmem_cache *s) |
3240 | { | 3237 | { |
3241 | int rc = kmem_cache_close(s); | 3238 | return kmem_cache_close(s); |
3242 | |||
3243 | if (!rc) { | ||
3244 | /* | ||
3245 | * Since slab_attr_store may take the slab_mutex, we should | ||
3246 | * release the lock while removing the sysfs entry in order to | ||
3247 | * avoid a deadlock. Because this is pretty much the last | ||
3248 | * operation we do and the lock will be released shortly after | ||
3249 | * that in slab_common.c, we could just move sysfs_slab_remove | ||
3250 | * to a later point in common code. We should do that when we | ||
3251 | * have a common sysfs framework for all allocators. | ||
3252 | */ | ||
3253 | mutex_unlock(&slab_mutex); | ||
3254 | sysfs_slab_remove(s); | ||
3255 | mutex_lock(&slab_mutex); | ||
3256 | } | ||
3257 | |||
3258 | return rc; | ||
3259 | } | 3239 | } |
3260 | 3240 | ||
3261 | /******************************************************************** | 3241 | /******************************************************************** |
@@ -5122,6 +5102,11 @@ static void memcg_propagate_slab_attrs(struct kmem_cache *s) | |||
5122 | #endif | 5102 | #endif |
5123 | } | 5103 | } |
5124 | 5104 | ||
5105 | static void kmem_cache_release(struct kobject *k) | ||
5106 | { | ||
5107 | slab_kmem_cache_release(to_slab(k)); | ||
5108 | } | ||
5109 | |||
5125 | static const struct sysfs_ops slab_sysfs_ops = { | 5110 | static const struct sysfs_ops slab_sysfs_ops = { |
5126 | .show = slab_attr_show, | 5111 | .show = slab_attr_show, |
5127 | .store = slab_attr_store, | 5112 | .store = slab_attr_store, |
@@ -5129,6 +5114,7 @@ static const struct sysfs_ops slab_sysfs_ops = { | |||
5129 | 5114 | ||
5130 | static struct kobj_type slab_ktype = { | 5115 | static struct kobj_type slab_ktype = { |
5131 | .sysfs_ops = &slab_sysfs_ops, | 5116 | .sysfs_ops = &slab_sysfs_ops, |
5117 | .release = kmem_cache_release, | ||
5132 | }; | 5118 | }; |
5133 | 5119 | ||
5134 | static int uevent_filter(struct kset *kset, struct kobject *kobj) | 5120 | static int uevent_filter(struct kset *kset, struct kobject *kobj) |
@@ -5255,7 +5241,7 @@ out_put_kobj: | |||
5255 | goto out; | 5241 | goto out; |
5256 | } | 5242 | } |
5257 | 5243 | ||
5258 | static void sysfs_slab_remove(struct kmem_cache *s) | 5244 | void sysfs_slab_remove(struct kmem_cache *s) |
5259 | { | 5245 | { |
5260 | if (slab_state < FULL) | 5246 | if (slab_state < FULL) |
5261 | /* | 5247 | /* |