1 files changed, 28 insertions, 26 deletions

diff --git a/mm/filemap.c b/mm/filemap.c
index 8558732e85c1..7b84dc814347 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -467,25 +467,15 @@ int add_to_page_cache_lru(struct page *page, struct address_space *mapping,
 }
 
 #ifdef CONFIG_NUMA
-struct page *page_cache_alloc(struct address_space *x)
+struct page *__page_cache_alloc(gfp_t gfp)
 {
         if (cpuset_do_page_mem_spread()) {
                 int n = cpuset_mem_spread_node();
-                return alloc_pages_node(n, mapping_gfp_mask(x), 0);
+                return alloc_pages_node(n, gfp, 0);
         }
-        return alloc_pages(mapping_gfp_mask(x), 0);
+        return alloc_pages(gfp, 0);
 }
-EXPORT_SYMBOL(page_cache_alloc);
-
-struct page *page_cache_alloc_cold(struct address_space *x)
-{
-        if (cpuset_do_page_mem_spread()) {
-                int n = cpuset_mem_spread_node();
-                return alloc_pages_node(n, mapping_gfp_mask(x)|__GFP_COLD, 0);
-        }
-        return alloc_pages(mapping_gfp_mask(x)|__GFP_COLD, 0);
-}
-EXPORT_SYMBOL(page_cache_alloc_cold);
+EXPORT_SYMBOL(__page_cache_alloc);
 #endif
 
 static int __sleep_on_page_lock(void *word)
@@ -826,7 +816,6 @@ struct page *
 grab_cache_page_nowait(struct address_space *mapping, unsigned long index)
 {
         struct page *page = find_get_page(mapping, index);
-        gfp_t gfp_mask;
 
         if (page) {
                 if (!TestSetPageLocked(page))
@@ -834,9 +823,8 @@ grab_cache_page_nowait(struct address_space *mapping, unsigned long index)
                 page_cache_release(page);
                 return NULL;
         }
-        gfp_mask = mapping_gfp_mask(mapping) & ~__GFP_FS;
-        page = alloc_pages(gfp_mask, 0);
-        if (page && add_to_page_cache_lru(page, mapping, index, gfp_mask)) {
+        page = __page_cache_alloc(mapping_gfp_mask(mapping) & ~__GFP_FS);
+        if (page && add_to_page_cache_lru(page, mapping, index, GFP_KERNEL)) {
                 page_cache_release(page);
                 page = NULL;
         }
@@ -1884,11 +1872,10 @@ repeat:
  *      if suid or (sgid and xgrp)
  *              remove privs
  */
-int remove_suid(struct dentry *dentry)
+int should_remove_suid(struct dentry *dentry)
 {
         mode_t mode = dentry->d_inode->i_mode;
         int kill = 0;
-        int result = 0;
 
         /* suid always must be killed */
         if (unlikely(mode & S_ISUID))
@@ -1901,13 +1888,28 @@ int remove_suid(struct dentry *dentry)
         if (unlikely((mode & S_ISGID) && (mode & S_IXGRP)))
                 kill |= ATTR_KILL_SGID;
 
-        if (unlikely(kill && !capable(CAP_FSETID))) {
-                struct iattr newattrs;
+        if (unlikely(kill && !capable(CAP_FSETID)))
+                return kill;
 
-                newattrs.ia_valid = ATTR_FORCE | kill;
-                result = notify_change(dentry, &newattrs);
-        }
-        return result;
+        return 0;
+}
+
+int __remove_suid(struct dentry *dentry, int kill)
+{
+        struct iattr newattrs;
+
+        newattrs.ia_valid = ATTR_FORCE | kill;
+        return notify_change(dentry, &newattrs);
+}
+
+int remove_suid(struct dentry *dentry)
+{
+        int kill = should_remove_suid(dentry);
+
+        if (unlikely(kill))
+                return __remove_suid(dentry, kill);
+
+        return 0;
 }
 EXPORT_SYMBOL(remove_suid);