diff options
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/cgroup.c | 14 | ||||
| -rw-r--r-- | kernel/events/core.c | 10 | ||||
| -rw-r--r-- | kernel/mutex.c | 32 | ||||
| -rw-r--r-- | kernel/power/Kconfig | 16 | ||||
| -rw-r--r-- | kernel/power/hibernate.c | 2 | ||||
| -rw-r--r-- | kernel/power/qos.c | 26 | ||||
| -rw-r--r-- | kernel/power/user.c | 20 | ||||
| -rw-r--r-- | kernel/time/clockevents.c | 65 |
8 files changed, 110 insertions, 75 deletions
diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 2418b6e71a85..8bd9cfdc70d7 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c | |||
| @@ -2039,7 +2039,7 @@ static int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk, | |||
| 2039 | 2039 | ||
| 2040 | /* @tsk either already exited or can't exit until the end */ | 2040 | /* @tsk either already exited or can't exit until the end */ |
| 2041 | if (tsk->flags & PF_EXITING) | 2041 | if (tsk->flags & PF_EXITING) |
| 2042 | continue; | 2042 | goto next; |
| 2043 | 2043 | ||
| 2044 | /* as per above, nr_threads may decrease, but not increase. */ | 2044 | /* as per above, nr_threads may decrease, but not increase. */ |
| 2045 | BUG_ON(i >= group_size); | 2045 | BUG_ON(i >= group_size); |
| @@ -2047,7 +2047,7 @@ static int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk, | |||
| 2047 | ent.cgrp = task_cgroup_from_root(tsk, root); | 2047 | ent.cgrp = task_cgroup_from_root(tsk, root); |
| 2048 | /* nothing to do if this task is already in the cgroup */ | 2048 | /* nothing to do if this task is already in the cgroup */ |
| 2049 | if (ent.cgrp == cgrp) | 2049 | if (ent.cgrp == cgrp) |
| 2050 | continue; | 2050 | goto next; |
| 2051 | /* | 2051 | /* |
| 2052 | * saying GFP_ATOMIC has no effect here because we did prealloc | 2052 | * saying GFP_ATOMIC has no effect here because we did prealloc |
| 2053 | * earlier, but it's good form to communicate our expectations. | 2053 | * earlier, but it's good form to communicate our expectations. |
| @@ -2055,7 +2055,7 @@ static int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk, | |||
| 2055 | retval = flex_array_put(group, i, &ent, GFP_ATOMIC); | 2055 | retval = flex_array_put(group, i, &ent, GFP_ATOMIC); |
| 2056 | BUG_ON(retval != 0); | 2056 | BUG_ON(retval != 0); |
| 2057 | i++; | 2057 | i++; |
| 2058 | 2058 | next: | |
| 2059 | if (!threadgroup) | 2059 | if (!threadgroup) |
| 2060 | break; | 2060 | break; |
| 2061 | } while_each_thread(leader, tsk); | 2061 | } while_each_thread(leader, tsk); |
| @@ -3188,11 +3188,9 @@ css_next_descendant_post(struct cgroup_subsys_state *pos, | |||
| 3188 | 3188 | ||
| 3189 | WARN_ON_ONCE(!rcu_read_lock_held()); | 3189 | WARN_ON_ONCE(!rcu_read_lock_held()); |
| 3190 | 3190 | ||
| 3191 | /* if first iteration, visit the leftmost descendant */ | 3191 | /* if first iteration, visit leftmost descendant which may be @root */ |
| 3192 | if (!pos) { | 3192 | if (!pos) |
| 3193 | next = css_leftmost_descendant(root); | 3193 | return css_leftmost_descendant(root); |
| 3194 | return next != root ? next : NULL; | ||
| 3195 | } | ||
| 3196 | 3194 | ||
| 3197 | /* if we visited @root, we're done */ | 3195 | /* if we visited @root, we're done */ |
| 3198 | if (pos == root) | 3196 | if (pos == root) |
diff --git a/kernel/events/core.c b/kernel/events/core.c index cb4238e85b38..953c14348375 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c | |||
| @@ -6767,6 +6767,10 @@ static int perf_copy_attr(struct perf_event_attr __user *uattr, | |||
| 6767 | if (ret) | 6767 | if (ret) |
| 6768 | return -EFAULT; | 6768 | return -EFAULT; |
| 6769 | 6769 | ||
| 6770 | /* disabled for now */ | ||
| 6771 | if (attr->mmap2) | ||
| 6772 | return -EINVAL; | ||
| 6773 | |||
| 6770 | if (attr->__reserved_1) | 6774 | if (attr->__reserved_1) |
| 6771 | return -EINVAL; | 6775 | return -EINVAL; |
| 6772 | 6776 | ||
| @@ -7234,15 +7238,15 @@ void perf_pmu_migrate_context(struct pmu *pmu, int src_cpu, int dst_cpu) | |||
| 7234 | perf_remove_from_context(event); | 7238 | perf_remove_from_context(event); |
| 7235 | unaccount_event_cpu(event, src_cpu); | 7239 | unaccount_event_cpu(event, src_cpu); |
| 7236 | put_ctx(src_ctx); | 7240 | put_ctx(src_ctx); |
| 7237 | list_add(&event->event_entry, &events); | 7241 | list_add(&event->migrate_entry, &events); |
| 7238 | } | 7242 | } |
| 7239 | mutex_unlock(&src_ctx->mutex); | 7243 | mutex_unlock(&src_ctx->mutex); |
| 7240 | 7244 | ||
| 7241 | synchronize_rcu(); | 7245 | synchronize_rcu(); |
| 7242 | 7246 | ||
| 7243 | mutex_lock(&dst_ctx->mutex); | 7247 | mutex_lock(&dst_ctx->mutex); |
| 7244 | list_for_each_entry_safe(event, tmp, &events, event_entry) { | 7248 | list_for_each_entry_safe(event, tmp, &events, migrate_entry) { |
| 7245 | list_del(&event->event_entry); | 7249 | list_del(&event->migrate_entry); |
| 7246 | if (event->state >= PERF_EVENT_STATE_OFF) | 7250 | if (event->state >= PERF_EVENT_STATE_OFF) |
| 7247 | event->state = PERF_EVENT_STATE_INACTIVE; | 7251 | event->state = PERF_EVENT_STATE_INACTIVE; |
| 7248 | account_event_cpu(event, dst_cpu); | 7252 | account_event_cpu(event, dst_cpu); |
diff --git a/kernel/mutex.c b/kernel/mutex.c index 6d647aedffea..d24105b1b794 100644 --- a/kernel/mutex.c +++ b/kernel/mutex.c | |||
| @@ -410,7 +410,7 @@ ww_mutex_set_context_fastpath(struct ww_mutex *lock, | |||
| 410 | static __always_inline int __sched | 410 | static __always_inline int __sched |
| 411 | __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass, | 411 | __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass, |
| 412 | struct lockdep_map *nest_lock, unsigned long ip, | 412 | struct lockdep_map *nest_lock, unsigned long ip, |
| 413 | struct ww_acquire_ctx *ww_ctx) | 413 | struct ww_acquire_ctx *ww_ctx, const bool use_ww_ctx) |
| 414 | { | 414 | { |
| 415 | struct task_struct *task = current; | 415 | struct task_struct *task = current; |
| 416 | struct mutex_waiter waiter; | 416 | struct mutex_waiter waiter; |
| @@ -450,7 +450,7 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass, | |||
| 450 | struct task_struct *owner; | 450 | struct task_struct *owner; |
| 451 | struct mspin_node node; | 451 | struct mspin_node node; |
| 452 | 452 | ||
| 453 | if (!__builtin_constant_p(ww_ctx == NULL) && ww_ctx->acquired > 0) { | 453 | if (use_ww_ctx && ww_ctx->acquired > 0) { |
| 454 | struct ww_mutex *ww; | 454 | struct ww_mutex *ww; |
| 455 | 455 | ||
| 456 | ww = container_of(lock, struct ww_mutex, base); | 456 | ww = container_of(lock, struct ww_mutex, base); |
| @@ -480,7 +480,7 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass, | |||
| 480 | if ((atomic_read(&lock->count) == 1) && | 480 | if ((atomic_read(&lock->count) == 1) && |
| 481 | (atomic_cmpxchg(&lock->count, 1, 0) == 1)) { | 481 | (atomic_cmpxchg(&lock->count, 1, 0) == 1)) { |
| 482 | lock_acquired(&lock->dep_map, ip); | 482 | lock_acquired(&lock->dep_map, ip); |
| 483 | if (!__builtin_constant_p(ww_ctx == NULL)) { | 483 | if (use_ww_ctx) { |
| 484 | struct ww_mutex *ww; | 484 | struct ww_mutex *ww; |
| 485 | ww = container_of(lock, struct ww_mutex, base); | 485 | ww = container_of(lock, struct ww_mutex, base); |
| 486 | 486 | ||
| @@ -551,7 +551,7 @@ slowpath: | |||
| 551 | goto err; | 551 | goto err; |
| 552 | } | 552 | } |
| 553 | 553 | ||
| 554 | if (!__builtin_constant_p(ww_ctx == NULL) && ww_ctx->acquired > 0) { | 554 | if (use_ww_ctx && ww_ctx->acquired > 0) { |
| 555 | ret = __mutex_lock_check_stamp(lock, ww_ctx); | 555 | ret = __mutex_lock_check_stamp(lock, ww_ctx); |
| 556 | if (ret) | 556 | if (ret) |
| 557 | goto err; | 557 | goto err; |
| @@ -575,7 +575,7 @@ skip_wait: | |||
| 575 | lock_acquired(&lock->dep_map, ip); | 575 | lock_acquired(&lock->dep_map, ip); |
| 576 | mutex_set_owner(lock); | 576 | mutex_set_owner(lock); |
| 577 | 577 | ||
| 578 | if (!__builtin_constant_p(ww_ctx == NULL)) { | 578 | if (use_ww_ctx) { |
| 579 | struct ww_mutex *ww = container_of(lock, struct ww_mutex, base); | 579 | struct ww_mutex *ww = container_of(lock, struct ww_mutex, base); |
| 580 | struct mutex_waiter *cur; | 580 | struct mutex_waiter *cur; |
| 581 | 581 | ||
| @@ -615,7 +615,7 @@ mutex_lock_nested(struct mutex *lock, unsigned int subclass) | |||
| 615 | { | 615 | { |
| 616 | might_sleep(); | 616 | might_sleep(); |
| 617 | __mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, | 617 | __mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, |
| 618 | subclass, NULL, _RET_IP_, NULL); | 618 | subclass, NULL, _RET_IP_, NULL, 0); |
| 619 | } | 619 | } |
| 620 | 620 | ||
| 621 | EXPORT_SYMBOL_GPL(mutex_lock_nested); | 621 | EXPORT_SYMBOL_GPL(mutex_lock_nested); |
| @@ -625,7 +625,7 @@ _mutex_lock_nest_lock(struct mutex *lock, struct lockdep_map *nest) | |||
| 625 | { | 625 | { |
| 626 | might_sleep(); | 626 | might_sleep(); |
| 627 | __mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, | 627 | __mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, |
| 628 | 0, nest, _RET_IP_, NULL); | 628 | 0, nest, _RET_IP_, NULL, 0); |
| 629 | } | 629 | } |
| 630 | 630 | ||
| 631 | EXPORT_SYMBOL_GPL(_mutex_lock_nest_lock); | 631 | EXPORT_SYMBOL_GPL(_mutex_lock_nest_lock); |
| @@ -635,7 +635,7 @@ mutex_lock_killable_nested(struct mutex *lock, unsigned int subclass) | |||
| 635 | { | 635 | { |
| 636 | might_sleep(); | 636 | might_sleep(); |
| 637 | return __mutex_lock_common(lock, TASK_KILLABLE, | 637 | return __mutex_lock_common(lock, TASK_KILLABLE, |
| 638 | subclass, NULL, _RET_IP_, NULL); | 638 | subclass, NULL, _RET_IP_, NULL, 0); |
| 639 | } | 639 | } |
| 640 | EXPORT_SYMBOL_GPL(mutex_lock_killable_nested); | 640 | EXPORT_SYMBOL_GPL(mutex_lock_killable_nested); |
| 641 | 641 | ||
| @@ -644,7 +644,7 @@ mutex_lock_interruptible_nested(struct mutex *lock, unsigned int subclass) | |||
| 644 | { | 644 | { |
| 645 | might_sleep(); | 645 | might_sleep(); |
| 646 | return __mutex_lock_common(lock, TASK_INTERRUPTIBLE, | 646 | return __mutex_lock_common(lock, TASK_INTERRUPTIBLE, |
| 647 | subclass, NULL, _RET_IP_, NULL); | 647 | subclass, NULL, _RET_IP_, NULL, 0); |
| 648 | } | 648 | } |
| 649 | 649 | ||
| 650 | EXPORT_SYMBOL_GPL(mutex_lock_interruptible_nested); | 650 | EXPORT_SYMBOL_GPL(mutex_lock_interruptible_nested); |
| @@ -682,7 +682,7 @@ __ww_mutex_lock(struct ww_mutex *lock, struct ww_acquire_ctx *ctx) | |||
| 682 | 682 | ||
| 683 | might_sleep(); | 683 | might_sleep(); |
| 684 | ret = __mutex_lock_common(&lock->base, TASK_UNINTERRUPTIBLE, | 684 | ret = __mutex_lock_common(&lock->base, TASK_UNINTERRUPTIBLE, |
| 685 | 0, &ctx->dep_map, _RET_IP_, ctx); | 685 | 0, &ctx->dep_map, _RET_IP_, ctx, 1); |
| 686 | if (!ret && ctx->acquired > 1) | 686 | if (!ret && ctx->acquired > 1) |
| 687 | return ww_mutex_deadlock_injection(lock, ctx); | 687 | return ww_mutex_deadlock_injection(lock, ctx); |
| 688 | 688 | ||
| @@ -697,7 +697,7 @@ __ww_mutex_lock_interruptible(struct ww_mutex *lock, struct ww_acquire_ctx *ctx) | |||
| 697 | 697 | ||
| 698 | might_sleep(); | 698 | might_sleep(); |
| 699 | ret = __mutex_lock_common(&lock->base, TASK_INTERRUPTIBLE, | 699 | ret = __mutex_lock_common(&lock->base, TASK_INTERRUPTIBLE, |
| 700 | 0, &ctx->dep_map, _RET_IP_, ctx); | 700 | 0, &ctx->dep_map, _RET_IP_, ctx, 1); |
| 701 | 701 | ||
| 702 | if (!ret && ctx->acquired > 1) | 702 | if (!ret && ctx->acquired > 1) |
| 703 | return ww_mutex_deadlock_injection(lock, ctx); | 703 | return ww_mutex_deadlock_injection(lock, ctx); |
| @@ -809,28 +809,28 @@ __mutex_lock_slowpath(atomic_t *lock_count) | |||
| 809 | struct mutex *lock = container_of(lock_count, struct mutex, count); | 809 | struct mutex *lock = container_of(lock_count, struct mutex, count); |
| 810 | 810 | ||
| 811 | __mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, 0, | 811 | __mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, 0, |
| 812 | NULL, _RET_IP_, NULL); | 812 | NULL, _RET_IP_, NULL, 0); |
| 813 | } | 813 | } |
| 814 | 814 | ||
| 815 | static noinline int __sched | 815 | static noinline int __sched |
| 816 | __mutex_lock_killable_slowpath(struct mutex *lock) | 816 | __mutex_lock_killable_slowpath(struct mutex *lock) |
| 817 | { | 817 | { |
| 818 | return __mutex_lock_common(lock, TASK_KILLABLE, 0, | 818 | return __mutex_lock_common(lock, TASK_KILLABLE, 0, |
| 819 | NULL, _RET_IP_, NULL); | 819 | NULL, _RET_IP_, NULL, 0); |
| 820 | } | 820 | } |
| 821 | 821 | ||
| 822 | static noinline int __sched | 822 | static noinline int __sched |
| 823 | __mutex_lock_interruptible_slowpath(struct mutex *lock) | 823 | __mutex_lock_interruptible_slowpath(struct mutex *lock) |
| 824 | { | 824 | { |
| 825 | return __mutex_lock_common(lock, TASK_INTERRUPTIBLE, 0, | 825 | return __mutex_lock_common(lock, TASK_INTERRUPTIBLE, 0, |
| 826 | NULL, _RET_IP_, NULL); | 826 | NULL, _RET_IP_, NULL, 0); |
| 827 | } | 827 | } |
| 828 | 828 | ||
| 829 | static noinline int __sched | 829 | static noinline int __sched |
| 830 | __ww_mutex_lock_slowpath(struct ww_mutex *lock, struct ww_acquire_ctx *ctx) | 830 | __ww_mutex_lock_slowpath(struct ww_mutex *lock, struct ww_acquire_ctx *ctx) |
| 831 | { | 831 | { |
| 832 | return __mutex_lock_common(&lock->base, TASK_UNINTERRUPTIBLE, 0, | 832 | return __mutex_lock_common(&lock->base, TASK_UNINTERRUPTIBLE, 0, |
| 833 | NULL, _RET_IP_, ctx); | 833 | NULL, _RET_IP_, ctx, 1); |
| 834 | } | 834 | } |
| 835 | 835 | ||
| 836 | static noinline int __sched | 836 | static noinline int __sched |
| @@ -838,7 +838,7 @@ __ww_mutex_lock_interruptible_slowpath(struct ww_mutex *lock, | |||
| 838 | struct ww_acquire_ctx *ctx) | 838 | struct ww_acquire_ctx *ctx) |
| 839 | { | 839 | { |
| 840 | return __mutex_lock_common(&lock->base, TASK_INTERRUPTIBLE, 0, | 840 | return __mutex_lock_common(&lock->base, TASK_INTERRUPTIBLE, 0, |
| 841 | NULL, _RET_IP_, ctx); | 841 | NULL, _RET_IP_, ctx, 1); |
| 842 | } | 842 | } |
| 843 | 843 | ||
| 844 | #endif | 844 | #endif |
diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig index d444c4e834f4..2fac9cc79b3d 100644 --- a/kernel/power/Kconfig +++ b/kernel/power/Kconfig | |||
| @@ -178,6 +178,22 @@ config PM_SLEEP_DEBUG | |||
| 178 | def_bool y | 178 | def_bool y |
| 179 | depends on PM_DEBUG && PM_SLEEP | 179 | depends on PM_DEBUG && PM_SLEEP |
| 180 | 180 | ||
| 181 | config DPM_WATCHDOG | ||
| 182 | bool "Device suspend/resume watchdog" | ||
| 183 | depends on PM_DEBUG && PSTORE | ||
| 184 | ---help--- | ||
| 185 | Sets up a watchdog timer to capture drivers that are | ||
| 186 | locked up attempting to suspend/resume a device. | ||
| 187 | A detected lockup causes system panic with message | ||
| 188 | captured in pstore device for inspection in subsequent | ||
| 189 | boot session. | ||
| 190 | |||
| 191 | config DPM_WATCHDOG_TIMEOUT | ||
| 192 | int "Watchdog timeout in seconds" | ||
| 193 | range 1 120 | ||
| 194 | default 12 | ||
| 195 | depends on DPM_WATCHDOG | ||
| 196 | |||
| 181 | config PM_TRACE | 197 | config PM_TRACE |
| 182 | bool | 198 | bool |
| 183 | help | 199 | help |
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index c9c759d5a15c..0121dab83f43 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c | |||
| @@ -846,7 +846,7 @@ static int software_resume(void) | |||
| 846 | goto Finish; | 846 | goto Finish; |
| 847 | } | 847 | } |
| 848 | 848 | ||
| 849 | late_initcall(software_resume); | 849 | late_initcall_sync(software_resume); |
| 850 | 850 | ||
| 851 | 851 | ||
| 852 | static const char * const hibernation_modes[] = { | 852 | static const char * const hibernation_modes[] = { |
diff --git a/kernel/power/qos.c b/kernel/power/qos.c index a394297f8b2f..8dff9b48075a 100644 --- a/kernel/power/qos.c +++ b/kernel/power/qos.c | |||
| @@ -558,30 +558,12 @@ static ssize_t pm_qos_power_write(struct file *filp, const char __user *buf, | |||
| 558 | if (count == sizeof(s32)) { | 558 | if (count == sizeof(s32)) { |
| 559 | if (copy_from_user(&value, buf, sizeof(s32))) | 559 | if (copy_from_user(&value, buf, sizeof(s32))) |
| 560 | return -EFAULT; | 560 | return -EFAULT; |
| 561 | } else if (count <= 11) { /* ASCII perhaps? */ | 561 | } else { |
| 562 | char ascii_value[11]; | ||
| 563 | unsigned long int ulval; | ||
| 564 | int ret; | 562 | int ret; |
| 565 | 563 | ||
| 566 | if (copy_from_user(ascii_value, buf, count)) | 564 | ret = kstrtos32_from_user(buf, count, 16, &value); |
| 567 | return -EFAULT; | 565 | if (ret) |
| 568 | 566 | return ret; | |
| 569 | if (count > 10) { | ||
| 570 | if (ascii_value[10] == '\n') | ||
| 571 | ascii_value[10] = '\0'; | ||
| 572 | else | ||
| 573 | return -EINVAL; | ||
| 574 | } else { | ||
| 575 | ascii_value[count] = '\0'; | ||
| 576 | } | ||
| 577 | ret = kstrtoul(ascii_value, 16, &ulval); | ||
| 578 | if (ret) { | ||
| 579 | pr_debug("%s, 0x%lx, 0x%x\n", ascii_value, ulval, ret); | ||
| 580 | return -EINVAL; | ||
| 581 | } | ||
| 582 | value = (s32)lower_32_bits(ulval); | ||
| 583 | } else { | ||
| 584 | return -EINVAL; | ||
| 585 | } | 567 | } |
| 586 | 568 | ||
| 587 | req = filp->private_data; | 569 | req = filp->private_data; |
diff --git a/kernel/power/user.c b/kernel/power/user.c index 957f06164ad1..24850270c802 100644 --- a/kernel/power/user.c +++ b/kernel/power/user.c | |||
| @@ -36,9 +36,9 @@ static struct snapshot_data { | |||
| 36 | struct snapshot_handle handle; | 36 | struct snapshot_handle handle; |
| 37 | int swap; | 37 | int swap; |
| 38 | int mode; | 38 | int mode; |
| 39 | char frozen; | 39 | bool frozen; |
| 40 | char ready; | 40 | bool ready; |
| 41 | char platform_support; | 41 | bool platform_support; |
| 42 | bool free_bitmaps; | 42 | bool free_bitmaps; |
| 43 | } snapshot_state; | 43 | } snapshot_state; |
| 44 | 44 | ||
| @@ -93,9 +93,9 @@ static int snapshot_open(struct inode *inode, struct file *filp) | |||
| 93 | if (error) | 93 | if (error) |
| 94 | atomic_inc(&snapshot_device_available); | 94 | atomic_inc(&snapshot_device_available); |
| 95 | 95 | ||
| 96 | data->frozen = 0; | 96 | data->frozen = false; |
| 97 | data->ready = 0; | 97 | data->ready = false; |
| 98 | data->platform_support = 0; | 98 | data->platform_support = false; |
| 99 | 99 | ||
| 100 | Unlock: | 100 | Unlock: |
| 101 | unlock_system_sleep(); | 101 | unlock_system_sleep(); |
| @@ -229,7 +229,7 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd, | |||
| 229 | if (error) | 229 | if (error) |
| 230 | thaw_processes(); | 230 | thaw_processes(); |
| 231 | else | 231 | else |
| 232 | data->frozen = 1; | 232 | data->frozen = true; |
| 233 | 233 | ||
| 234 | break; | 234 | break; |
| 235 | 235 | ||
| @@ -240,7 +240,7 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd, | |||
| 240 | free_basic_memory_bitmaps(); | 240 | free_basic_memory_bitmaps(); |
| 241 | data->free_bitmaps = false; | 241 | data->free_bitmaps = false; |
| 242 | thaw_processes(); | 242 | thaw_processes(); |
| 243 | data->frozen = 0; | 243 | data->frozen = false; |
| 244 | break; | 244 | break; |
| 245 | 245 | ||
| 246 | case SNAPSHOT_CREATE_IMAGE: | 246 | case SNAPSHOT_CREATE_IMAGE: |
| @@ -270,7 +270,7 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd, | |||
| 270 | case SNAPSHOT_FREE: | 270 | case SNAPSHOT_FREE: |
| 271 | swsusp_free(); | 271 | swsusp_free(); |
| 272 | memset(&data->handle, 0, sizeof(struct snapshot_handle)); | 272 | memset(&data->handle, 0, sizeof(struct snapshot_handle)); |
| 273 | data->ready = 0; | 273 | data->ready = false; |
| 274 | /* | 274 | /* |
| 275 | * It is necessary to thaw kernel threads here, because | 275 | * It is necessary to thaw kernel threads here, because |
| 276 | * SNAPSHOT_CREATE_IMAGE may be invoked directly after | 276 | * SNAPSHOT_CREATE_IMAGE may be invoked directly after |
| @@ -334,7 +334,7 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd, | |||
| 334 | * PM_HIBERNATION_PREPARE | 334 | * PM_HIBERNATION_PREPARE |
| 335 | */ | 335 | */ |
| 336 | error = suspend_devices_and_enter(PM_SUSPEND_MEM); | 336 | error = suspend_devices_and_enter(PM_SUSPEND_MEM); |
| 337 | data->ready = 0; | 337 | data->ready = false; |
| 338 | break; | 338 | break; |
| 339 | 339 | ||
| 340 | case SNAPSHOT_PLATFORM_SUPPORT: | 340 | case SNAPSHOT_PLATFORM_SUPPORT: |
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 38959c866789..662c5798a685 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c | |||
| @@ -33,29 +33,64 @@ struct ce_unbind { | |||
| 33 | int res; | 33 | int res; |
| 34 | }; | 34 | }; |
| 35 | 35 | ||
| 36 | /** | 36 | static u64 cev_delta2ns(unsigned long latch, struct clock_event_device *evt, |
| 37 | * clockevents_delta2ns - Convert a latch value (device ticks) to nanoseconds | 37 | bool ismax) |
| 38 | * @latch: value to convert | ||
| 39 | * @evt: pointer to clock event device descriptor | ||
| 40 | * | ||
| 41 | * Math helper, returns latch value converted to nanoseconds (bound checked) | ||
| 42 | */ | ||
| 43 | u64 clockevent_delta2ns(unsigned long latch, struct clock_event_device *evt) | ||
| 44 | { | 38 | { |
| 45 | u64 clc = (u64) latch << evt->shift; | 39 | u64 clc = (u64) latch << evt->shift; |
| 40 | u64 rnd; | ||
| 46 | 41 | ||
| 47 | if (unlikely(!evt->mult)) { | 42 | if (unlikely(!evt->mult)) { |
| 48 | evt->mult = 1; | 43 | evt->mult = 1; |
| 49 | WARN_ON(1); | 44 | WARN_ON(1); |
| 50 | } | 45 | } |
| 46 | rnd = (u64) evt->mult - 1; | ||
| 47 | |||
| 48 | /* | ||
| 49 | * Upper bound sanity check. If the backwards conversion is | ||
| 50 | * not equal latch, we know that the above shift overflowed. | ||
| 51 | */ | ||
| 52 | if ((clc >> evt->shift) != (u64)latch) | ||
| 53 | clc = ~0ULL; | ||
| 54 | |||
| 55 | /* | ||
| 56 | * Scaled math oddities: | ||
| 57 | * | ||
| 58 | * For mult <= (1 << shift) we can safely add mult - 1 to | ||
| 59 | * prevent integer rounding loss. So the backwards conversion | ||
| 60 | * from nsec to device ticks will be correct. | ||
| 61 | * | ||
| 62 | * For mult > (1 << shift), i.e. device frequency is > 1GHz we | ||
| 63 | * need to be careful. Adding mult - 1 will result in a value | ||
| 64 | * which when converted back to device ticks can be larger | ||
| 65 | * than latch by up to (mult - 1) >> shift. For the min_delta | ||
| 66 | * calculation we still want to apply this in order to stay | ||
| 67 | * above the minimum device ticks limit. For the upper limit | ||
| 68 | * we would end up with a latch value larger than the upper | ||
| 69 | * limit of the device, so we omit the add to stay below the | ||
| 70 | * device upper boundary. | ||
| 71 | * | ||
| 72 | * Also omit the add if it would overflow the u64 boundary. | ||
| 73 | */ | ||
| 74 | if ((~0ULL - clc > rnd) && | ||
| 75 | (!ismax || evt->mult <= (1U << evt->shift))) | ||
| 76 | clc += rnd; | ||
| 51 | 77 | ||
| 52 | do_div(clc, evt->mult); | 78 | do_div(clc, evt->mult); |
| 53 | if (clc < 1000) | ||
| 54 | clc = 1000; | ||
| 55 | if (clc > KTIME_MAX) | ||
| 56 | clc = KTIME_MAX; | ||
| 57 | 79 | ||
| 58 | return clc; | 80 | /* Deltas less than 1usec are pointless noise */ |
| 81 | return clc > 1000 ? clc : 1000; | ||
| 82 | } | ||
| 83 | |||
| 84 | /** | ||
| 85 | * clockevents_delta2ns - Convert a latch value (device ticks) to nanoseconds | ||
| 86 | * @latch: value to convert | ||
| 87 | * @evt: pointer to clock event device descriptor | ||
| 88 | * | ||
| 89 | * Math helper, returns latch value converted to nanoseconds (bound checked) | ||
| 90 | */ | ||
| 91 | u64 clockevent_delta2ns(unsigned long latch, struct clock_event_device *evt) | ||
| 92 | { | ||
| 93 | return cev_delta2ns(latch, evt, false); | ||
| 59 | } | 94 | } |
| 60 | EXPORT_SYMBOL_GPL(clockevent_delta2ns); | 95 | EXPORT_SYMBOL_GPL(clockevent_delta2ns); |
| 61 | 96 | ||
| @@ -380,8 +415,8 @@ void clockevents_config(struct clock_event_device *dev, u32 freq) | |||
| 380 | sec = 600; | 415 | sec = 600; |
| 381 | 416 | ||
| 382 | clockevents_calc_mult_shift(dev, freq, sec); | 417 | clockevents_calc_mult_shift(dev, freq, sec); |
| 383 | dev->min_delta_ns = clockevent_delta2ns(dev->min_delta_ticks, dev); | 418 | dev->min_delta_ns = cev_delta2ns(dev->min_delta_ticks, dev, false); |
| 384 | dev->max_delta_ns = clockevent_delta2ns(dev->max_delta_ticks, dev); | 419 | dev->max_delta_ns = cev_delta2ns(dev->max_delta_ticks, dev, true); |
| 385 | } | 420 | } |
| 386 | 421 | ||
| 387 | /** | 422 | /** |
