6 files changed, 26 insertions, 45 deletions

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 382109b5baeb..a7267bfd3765 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1133,8 +1133,7 @@ static int cgroup_get_sb(struct file_system_type *fs_type,
  free_cg_links:
         free_cg_links(&tmp_cg_links);
  drop_new_super:
-        up_write(&sb->s_umount);
-        deactivate_super(sb);
+        deactivate_locked_super(sb);
         return ret;
 }
 
diff --git a/kernel/kgdb.c b/kernel/kgdb.c
index e4dcfb2272a4..9147a3190c9d 100644
--- a/kernel/kgdb.c
+++ b/kernel/kgdb.c
@@ -1583,8 +1583,8 @@ static void sysrq_handle_gdb(int key, struct tty_struct *tty)
 
 static struct sysrq_key_op sysrq_gdb_op = {
         .handler        = sysrq_handle_gdb,
-        .help_msg       = "Gdb",
-        .action_msg     = "GDB",
+        .help_msg       = "debug(G)",
+        .action_msg     = "DEBUG",
 };
 #endif
 
diff --git a/kernel/panic.c b/kernel/panic.c
index 874ecf1307ae..984b3ecbd72c 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -340,39 +340,44 @@ void oops_exit(void)
 }
 
 #ifdef WANT_WARN_ON_SLOWPATH
-void warn_slowpath_fmt(const char *file, int line, const char *fmt, ...)
-{
+struct slowpath_args {
+        const char *fmt;
         va_list args;
-        char function[KSYM_SYMBOL_LEN];
-        unsigned long caller = (unsigned long)__builtin_return_address(0);
-        const char *board;
+};
 
-        sprint_symbol(function, caller);
+static void warn_slowpath_common(const char *file, int line, void *caller, struct slowpath_args *args)
+{
+        const char *board;
 
         printk(KERN_WARNING "------------[ cut here ]------------\n");
-        printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
-                line, function);
+        printk(KERN_WARNING "WARNING: at %s:%d %pS()\n", file, line, caller);
         board = dmi_get_system_info(DMI_PRODUCT_NAME);
         if (board)
                 printk(KERN_WARNING "Hardware name: %s\n", board);
 
-        if (*fmt) {
-                va_start(args, fmt);
-                vprintk(fmt, args);
-                va_end(args);
-        }
+        if (args)
+                vprintk(args->fmt, args->args);
 
         print_modules();
         dump_stack();
         print_oops_end_marker();
         add_taint(TAINT_WARN);
 }
+
+void warn_slowpath_fmt(const char *file, int line, const char *fmt, ...)
+{
+        struct slowpath_args args;
+
+        args.fmt = fmt;
+        va_start(args.args, fmt);
+        warn_slowpath_common(file, line, __builtin_return_address(0), &args);
+        va_end(args.args);
+}
 EXPORT_SYMBOL(warn_slowpath_fmt);
 
 void warn_slowpath_null(const char *file, int line)
 {
-        static const char *empty = "";
-        warn_slowpath_fmt(file, line, empty);
+        warn_slowpath_common(file, line, __builtin_return_address(0), NULL);
 }
 EXPORT_SYMBOL(warn_slowpath_null);
 #endif
diff --git a/kernel/power/disk.c b/kernel/power/disk.c
index e71ca9cd81b2..b0dc9e7a0d17 100644
--- a/kernel/power/disk.c
+++ b/kernel/power/disk.c
@@ -241,9 +241,9 @@ static int create_image(int platform_mode)
 
         local_irq_disable();
 
-        sysdev_suspend(PMSG_FREEZE);
+        error = sysdev_suspend(PMSG_FREEZE);
         if (error) {
-                printk(KERN_ERR "PM: Some devices failed to power down, "
+                printk(KERN_ERR "PM: Some system devices failed to power down, "
                         "aborting hibernation\n");
                 goto Enable_irqs;
         }
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index ea78fa101ad6..b2970d56fb76 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -101,7 +101,6 @@ static int __maybe_unused one = 1;
 static int __maybe_unused two = 2;
 static unsigned long one_ul = 1;
 static int one_hundred = 100;
-static int one_thousand = 1000;
 
 /* this is needed for the proc_doulongvec_minmax of vm_dirty_bytes */
 static unsigned long dirty_bytes_min = 2 * PAGE_SIZE;
@@ -1034,28 +1033,6 @@ static struct ctl_table vm_table[] = {
                 .proc_handler   = &proc_dointvec,
         },
         {
-                .ctl_name       = CTL_UNNUMBERED,
-                .procname       = "nr_pdflush_threads_min",
-                .data           = &nr_pdflush_threads_min,
-                .maxlen         = sizeof nr_pdflush_threads_min,
-                .mode           = 0644 /* read-write */,
-                .proc_handler   = &proc_dointvec_minmax,
-                .strategy       = &sysctl_intvec,
-                .extra1         = &one,
-                .extra2         = &nr_pdflush_threads_max,
-        },
-        {
-                .ctl_name       = CTL_UNNUMBERED,
-                .procname       = "nr_pdflush_threads_max",
-                .data           = &nr_pdflush_threads_max,
-                .maxlen         = sizeof nr_pdflush_threads_max,
-                .mode           = 0644 /* read-write */,
-                .proc_handler   = &proc_dointvec_minmax,
-                .strategy       = &sysctl_intvec,
-                .extra1         = &nr_pdflush_threads_min,
-                .extra2         = &one_thousand,
-        },
-        {
                 .ctl_name       = VM_SWAPPINESS,
                 .procname       = "swappiness",
                 .data           = &vm_swappiness,
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index a884c09006c4..cda81ec58d9f 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2380,7 +2380,7 @@ static const char readme_msg[] =
         "# echo print-parent > /debug/tracing/trace_options\n"
         "# echo 1 > /debug/tracing/tracing_enabled\n"
         "# cat /debug/tracing/trace > /tmp/trace.txt\n"
-        "echo 0 > /debug/tracing/tracing_enabled\n"
+        "# echo 0 > /debug/tracing/tracing_enabled\n"
 ;
 
 static ssize_t