diff options
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/Makefile | 1 | ||||
-rw-r--r-- | kernel/irq/spurious.c | 2 | ||||
-rw-r--r-- | kernel/kthread.c | 23 | ||||
-rw-r--r-- | kernel/module.c | 5 | ||||
-rw-r--r-- | kernel/rcutree.c | 16 | ||||
-rw-r--r-- | kernel/rcutree.h | 7 | ||||
-rw-r--r-- | kernel/sched.c | 43 | ||||
-rw-r--r-- | kernel/sched_fair.c | 73 | ||||
-rw-r--r-- | kernel/slow-work-debugfs.c | 227 | ||||
-rw-r--r-- | kernel/slow-work.c | 512 | ||||
-rw-r--r-- | kernel/slow-work.h | 72 | ||||
-rw-r--r-- | kernel/trace/ftrace.c | 6 | ||||
-rw-r--r-- | kernel/trace/ring_buffer.c | 2 | ||||
-rw-r--r-- | kernel/user.c | 2 | ||||
-rw-r--r-- | kernel/workqueue.c | 28 |
15 files changed, 894 insertions, 125 deletions
diff --git a/kernel/Makefile b/kernel/Makefile index b8d4cd8ac0b9..d7c13d249b2d 100644 --- a/kernel/Makefile +++ b/kernel/Makefile | |||
@@ -94,6 +94,7 @@ obj-$(CONFIG_X86_DS) += trace/ | |||
94 | obj-$(CONFIG_RING_BUFFER) += trace/ | 94 | obj-$(CONFIG_RING_BUFFER) += trace/ |
95 | obj-$(CONFIG_SMP) += sched_cpupri.o | 95 | obj-$(CONFIG_SMP) += sched_cpupri.o |
96 | obj-$(CONFIG_SLOW_WORK) += slow-work.o | 96 | obj-$(CONFIG_SLOW_WORK) += slow-work.o |
97 | obj-$(CONFIG_SLOW_WORK_DEBUG) += slow-work-debugfs.o | ||
97 | obj-$(CONFIG_PERF_EVENTS) += perf_event.o | 98 | obj-$(CONFIG_PERF_EVENTS) += perf_event.o |
98 | 99 | ||
99 | ifneq ($(CONFIG_SCHED_OMIT_FRAME_POINTER),y) | 100 | ifneq ($(CONFIG_SCHED_OMIT_FRAME_POINTER),y) |
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c index 114e704760fe..bd7273e6282e 100644 --- a/kernel/irq/spurious.c +++ b/kernel/irq/spurious.c | |||
@@ -121,7 +121,9 @@ static void poll_all_shared_irqs(void) | |||
121 | if (!(status & IRQ_SPURIOUS_DISABLED)) | 121 | if (!(status & IRQ_SPURIOUS_DISABLED)) |
122 | continue; | 122 | continue; |
123 | 123 | ||
124 | local_irq_disable(); | ||
124 | try_one_irq(i, desc); | 125 | try_one_irq(i, desc); |
126 | local_irq_enable(); | ||
125 | } | 127 | } |
126 | } | 128 | } |
127 | 129 | ||
diff --git a/kernel/kthread.c b/kernel/kthread.c index 5fe709982caa..ab7ae57773e1 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c | |||
@@ -150,29 +150,6 @@ struct task_struct *kthread_create(int (*threadfn)(void *data), | |||
150 | EXPORT_SYMBOL(kthread_create); | 150 | EXPORT_SYMBOL(kthread_create); |
151 | 151 | ||
152 | /** | 152 | /** |
153 | * kthread_bind - bind a just-created kthread to a cpu. | ||
154 | * @k: thread created by kthread_create(). | ||
155 | * @cpu: cpu (might not be online, must be possible) for @k to run on. | ||
156 | * | ||
157 | * Description: This function is equivalent to set_cpus_allowed(), | ||
158 | * except that @cpu doesn't need to be online, and the thread must be | ||
159 | * stopped (i.e., just returned from kthread_create()). | ||
160 | */ | ||
161 | void kthread_bind(struct task_struct *k, unsigned int cpu) | ||
162 | { | ||
163 | /* Must have done schedule() in kthread() before we set_task_cpu */ | ||
164 | if (!wait_task_inactive(k, TASK_UNINTERRUPTIBLE)) { | ||
165 | WARN_ON(1); | ||
166 | return; | ||
167 | } | ||
168 | set_task_cpu(k, cpu); | ||
169 | k->cpus_allowed = cpumask_of_cpu(cpu); | ||
170 | k->rt.nr_cpus_allowed = 1; | ||
171 | k->flags |= PF_THREAD_BOUND; | ||
172 | } | ||
173 | EXPORT_SYMBOL(kthread_bind); | ||
174 | |||
175 | /** | ||
176 | * kthread_stop - stop a thread created by kthread_create(). | 153 | * kthread_stop - stop a thread created by kthread_create(). |
177 | * @k: thread created by kthread_create(). | 154 | * @k: thread created by kthread_create(). |
178 | * | 155 | * |
diff --git a/kernel/module.c b/kernel/module.c index 8b7d8805819d..5842a71cf052 100644 --- a/kernel/module.c +++ b/kernel/module.c | |||
@@ -1187,7 +1187,8 @@ static void add_sect_attrs(struct module *mod, unsigned int nsect, | |||
1187 | 1187 | ||
1188 | /* Count loaded sections and allocate structures */ | 1188 | /* Count loaded sections and allocate structures */ |
1189 | for (i = 0; i < nsect; i++) | 1189 | for (i = 0; i < nsect; i++) |
1190 | if (sechdrs[i].sh_flags & SHF_ALLOC) | 1190 | if (sechdrs[i].sh_flags & SHF_ALLOC |
1191 | && sechdrs[i].sh_size) | ||
1191 | nloaded++; | 1192 | nloaded++; |
1192 | size[0] = ALIGN(sizeof(*sect_attrs) | 1193 | size[0] = ALIGN(sizeof(*sect_attrs) |
1193 | + nloaded * sizeof(sect_attrs->attrs[0]), | 1194 | + nloaded * sizeof(sect_attrs->attrs[0]), |
@@ -1207,6 +1208,8 @@ static void add_sect_attrs(struct module *mod, unsigned int nsect, | |||
1207 | for (i = 0; i < nsect; i++) { | 1208 | for (i = 0; i < nsect; i++) { |
1208 | if (! (sechdrs[i].sh_flags & SHF_ALLOC)) | 1209 | if (! (sechdrs[i].sh_flags & SHF_ALLOC)) |
1209 | continue; | 1210 | continue; |
1211 | if (!sechdrs[i].sh_size) | ||
1212 | continue; | ||
1210 | sattr->address = sechdrs[i].sh_addr; | 1213 | sattr->address = sechdrs[i].sh_addr; |
1211 | sattr->name = kstrdup(secstrings + sechdrs[i].sh_name, | 1214 | sattr->name = kstrdup(secstrings + sechdrs[i].sh_name, |
1212 | GFP_KERNEL); | 1215 | GFP_KERNEL); |
diff --git a/kernel/rcutree.c b/kernel/rcutree.c index 0536125b0497..f3077c0ab181 100644 --- a/kernel/rcutree.c +++ b/kernel/rcutree.c | |||
@@ -59,7 +59,7 @@ | |||
59 | NUM_RCU_LVL_2, \ | 59 | NUM_RCU_LVL_2, \ |
60 | NUM_RCU_LVL_3, /* == MAX_RCU_LVLS */ \ | 60 | NUM_RCU_LVL_3, /* == MAX_RCU_LVLS */ \ |
61 | }, \ | 61 | }, \ |
62 | .signaled = RCU_SIGNAL_INIT, \ | 62 | .signaled = RCU_GP_IDLE, \ |
63 | .gpnum = -300, \ | 63 | .gpnum = -300, \ |
64 | .completed = -300, \ | 64 | .completed = -300, \ |
65 | .onofflock = __SPIN_LOCK_UNLOCKED(&name.onofflock), \ | 65 | .onofflock = __SPIN_LOCK_UNLOCKED(&name.onofflock), \ |
@@ -657,14 +657,17 @@ rcu_start_gp(struct rcu_state *rsp, unsigned long flags) | |||
657 | * irqs disabled. | 657 | * irqs disabled. |
658 | */ | 658 | */ |
659 | rcu_for_each_node_breadth_first(rsp, rnp) { | 659 | rcu_for_each_node_breadth_first(rsp, rnp) { |
660 | spin_lock(&rnp->lock); /* irqs already disabled. */ | 660 | spin_lock(&rnp->lock); /* irqs already disabled. */ |
661 | rcu_preempt_check_blocked_tasks(rnp); | 661 | rcu_preempt_check_blocked_tasks(rnp); |
662 | rnp->qsmask = rnp->qsmaskinit; | 662 | rnp->qsmask = rnp->qsmaskinit; |
663 | rnp->gpnum = rsp->gpnum; | 663 | rnp->gpnum = rsp->gpnum; |
664 | spin_unlock(&rnp->lock); /* irqs already disabled. */ | 664 | spin_unlock(&rnp->lock); /* irqs remain disabled. */ |
665 | } | 665 | } |
666 | 666 | ||
667 | rnp = rcu_get_root(rsp); | ||
668 | spin_lock(&rnp->lock); /* irqs already disabled. */ | ||
667 | rsp->signaled = RCU_SIGNAL_INIT; /* force_quiescent_state now OK. */ | 669 | rsp->signaled = RCU_SIGNAL_INIT; /* force_quiescent_state now OK. */ |
670 | spin_unlock(&rnp->lock); /* irqs remain disabled. */ | ||
668 | spin_unlock_irqrestore(&rsp->onofflock, flags); | 671 | spin_unlock_irqrestore(&rsp->onofflock, flags); |
669 | } | 672 | } |
670 | 673 | ||
@@ -706,6 +709,7 @@ static void cpu_quiet_msk_finish(struct rcu_state *rsp, unsigned long flags) | |||
706 | { | 709 | { |
707 | WARN_ON_ONCE(!rcu_gp_in_progress(rsp)); | 710 | WARN_ON_ONCE(!rcu_gp_in_progress(rsp)); |
708 | rsp->completed = rsp->gpnum; | 711 | rsp->completed = rsp->gpnum; |
712 | rsp->signaled = RCU_GP_IDLE; | ||
709 | rcu_process_gp_end(rsp, rsp->rda[smp_processor_id()]); | 713 | rcu_process_gp_end(rsp, rsp->rda[smp_processor_id()]); |
710 | rcu_start_gp(rsp, flags); /* releases root node's rnp->lock. */ | 714 | rcu_start_gp(rsp, flags); /* releases root node's rnp->lock. */ |
711 | } | 715 | } |
@@ -1162,9 +1166,10 @@ static void force_quiescent_state(struct rcu_state *rsp, int relaxed) | |||
1162 | } | 1166 | } |
1163 | spin_unlock(&rnp->lock); | 1167 | spin_unlock(&rnp->lock); |
1164 | switch (signaled) { | 1168 | switch (signaled) { |
1169 | case RCU_GP_IDLE: | ||
1165 | case RCU_GP_INIT: | 1170 | case RCU_GP_INIT: |
1166 | 1171 | ||
1167 | break; /* grace period still initializing, ignore. */ | 1172 | break; /* grace period idle or initializing, ignore. */ |
1168 | 1173 | ||
1169 | case RCU_SAVE_DYNTICK: | 1174 | case RCU_SAVE_DYNTICK: |
1170 | 1175 | ||
@@ -1178,7 +1183,8 @@ static void force_quiescent_state(struct rcu_state *rsp, int relaxed) | |||
1178 | 1183 | ||
1179 | /* Update state, record completion counter. */ | 1184 | /* Update state, record completion counter. */ |
1180 | spin_lock(&rnp->lock); | 1185 | spin_lock(&rnp->lock); |
1181 | if (lastcomp == rsp->completed) { | 1186 | if (lastcomp == rsp->completed && |
1187 | rsp->signaled == RCU_SAVE_DYNTICK) { | ||
1182 | rsp->signaled = RCU_FORCE_QS; | 1188 | rsp->signaled = RCU_FORCE_QS; |
1183 | dyntick_record_completed(rsp, lastcomp); | 1189 | dyntick_record_completed(rsp, lastcomp); |
1184 | } | 1190 | } |
diff --git a/kernel/rcutree.h b/kernel/rcutree.h index 1823c6e20609..1899023b0962 100644 --- a/kernel/rcutree.h +++ b/kernel/rcutree.h | |||
@@ -201,9 +201,10 @@ struct rcu_data { | |||
201 | }; | 201 | }; |
202 | 202 | ||
203 | /* Values for signaled field in struct rcu_state. */ | 203 | /* Values for signaled field in struct rcu_state. */ |
204 | #define RCU_GP_INIT 0 /* Grace period being initialized. */ | 204 | #define RCU_GP_IDLE 0 /* No grace period in progress. */ |
205 | #define RCU_SAVE_DYNTICK 1 /* Need to scan dyntick state. */ | 205 | #define RCU_GP_INIT 1 /* Grace period being initialized. */ |
206 | #define RCU_FORCE_QS 2 /* Need to force quiescent state. */ | 206 | #define RCU_SAVE_DYNTICK 2 /* Need to scan dyntick state. */ |
207 | #define RCU_FORCE_QS 3 /* Need to force quiescent state. */ | ||
207 | #ifdef CONFIG_NO_HZ | 208 | #ifdef CONFIG_NO_HZ |
208 | #define RCU_SIGNAL_INIT RCU_SAVE_DYNTICK | 209 | #define RCU_SIGNAL_INIT RCU_SAVE_DYNTICK |
209 | #else /* #ifdef CONFIG_NO_HZ */ | 210 | #else /* #ifdef CONFIG_NO_HZ */ |
diff --git a/kernel/sched.c b/kernel/sched.c index a455dca884a6..3c11ae0a948d 100644 --- a/kernel/sched.c +++ b/kernel/sched.c | |||
@@ -309,6 +309,8 @@ static DEFINE_PER_CPU_SHARED_ALIGNED(struct rt_rq, init_rt_rq); | |||
309 | */ | 309 | */ |
310 | static DEFINE_SPINLOCK(task_group_lock); | 310 | static DEFINE_SPINLOCK(task_group_lock); |
311 | 311 | ||
312 | #ifdef CONFIG_FAIR_GROUP_SCHED | ||
313 | |||
312 | #ifdef CONFIG_SMP | 314 | #ifdef CONFIG_SMP |
313 | static int root_task_group_empty(void) | 315 | static int root_task_group_empty(void) |
314 | { | 316 | { |
@@ -316,7 +318,6 @@ static int root_task_group_empty(void) | |||
316 | } | 318 | } |
317 | #endif | 319 | #endif |
318 | 320 | ||
319 | #ifdef CONFIG_FAIR_GROUP_SCHED | ||
320 | #ifdef CONFIG_USER_SCHED | 321 | #ifdef CONFIG_USER_SCHED |
321 | # define INIT_TASK_GROUP_LOAD (2*NICE_0_LOAD) | 322 | # define INIT_TASK_GROUP_LOAD (2*NICE_0_LOAD) |
322 | #else /* !CONFIG_USER_SCHED */ | 323 | #else /* !CONFIG_USER_SCHED */ |
@@ -1992,6 +1993,38 @@ static inline void check_class_changed(struct rq *rq, struct task_struct *p, | |||
1992 | p->sched_class->prio_changed(rq, p, oldprio, running); | 1993 | p->sched_class->prio_changed(rq, p, oldprio, running); |
1993 | } | 1994 | } |
1994 | 1995 | ||
1996 | /** | ||
1997 | * kthread_bind - bind a just-created kthread to a cpu. | ||
1998 | * @p: thread created by kthread_create(). | ||
1999 | * @cpu: cpu (might not be online, must be possible) for @k to run on. | ||
2000 | * | ||
2001 | * Description: This function is equivalent to set_cpus_allowed(), | ||
2002 | * except that @cpu doesn't need to be online, and the thread must be | ||
2003 | * stopped (i.e., just returned from kthread_create()). | ||
2004 | * | ||
2005 | * Function lives here instead of kthread.c because it messes with | ||
2006 | * scheduler internals which require locking. | ||
2007 | */ | ||
2008 | void kthread_bind(struct task_struct *p, unsigned int cpu) | ||
2009 | { | ||
2010 | struct rq *rq = cpu_rq(cpu); | ||
2011 | unsigned long flags; | ||
2012 | |||
2013 | /* Must have done schedule() in kthread() before we set_task_cpu */ | ||
2014 | if (!wait_task_inactive(p, TASK_UNINTERRUPTIBLE)) { | ||
2015 | WARN_ON(1); | ||
2016 | return; | ||
2017 | } | ||
2018 | |||
2019 | spin_lock_irqsave(&rq->lock, flags); | ||
2020 | set_task_cpu(p, cpu); | ||
2021 | p->cpus_allowed = cpumask_of_cpu(cpu); | ||
2022 | p->rt.nr_cpus_allowed = 1; | ||
2023 | p->flags |= PF_THREAD_BOUND; | ||
2024 | spin_unlock_irqrestore(&rq->lock, flags); | ||
2025 | } | ||
2026 | EXPORT_SYMBOL(kthread_bind); | ||
2027 | |||
1995 | #ifdef CONFIG_SMP | 2028 | #ifdef CONFIG_SMP |
1996 | /* | 2029 | /* |
1997 | * Is this task likely cache-hot: | 2030 | * Is this task likely cache-hot: |
@@ -2004,7 +2037,7 @@ task_hot(struct task_struct *p, u64 now, struct sched_domain *sd) | |||
2004 | /* | 2037 | /* |
2005 | * Buddy candidates are cache hot: | 2038 | * Buddy candidates are cache hot: |
2006 | */ | 2039 | */ |
2007 | if (sched_feat(CACHE_HOT_BUDDY) && | 2040 | if (sched_feat(CACHE_HOT_BUDDY) && this_rq()->nr_running && |
2008 | (&p->se == cfs_rq_of(&p->se)->next || | 2041 | (&p->se == cfs_rq_of(&p->se)->next || |
2009 | &p->se == cfs_rq_of(&p->se)->last)) | 2042 | &p->se == cfs_rq_of(&p->se)->last)) |
2010 | return 1; | 2043 | return 1; |
@@ -9532,13 +9565,13 @@ void __init sched_init(void) | |||
9532 | current->sched_class = &fair_sched_class; | 9565 | current->sched_class = &fair_sched_class; |
9533 | 9566 | ||
9534 | /* Allocate the nohz_cpu_mask if CONFIG_CPUMASK_OFFSTACK */ | 9567 | /* Allocate the nohz_cpu_mask if CONFIG_CPUMASK_OFFSTACK */ |
9535 | alloc_cpumask_var(&nohz_cpu_mask, GFP_NOWAIT); | 9568 | zalloc_cpumask_var(&nohz_cpu_mask, GFP_NOWAIT); |
9536 | #ifdef CONFIG_SMP | 9569 | #ifdef CONFIG_SMP |
9537 | #ifdef CONFIG_NO_HZ | 9570 | #ifdef CONFIG_NO_HZ |
9538 | alloc_cpumask_var(&nohz.cpu_mask, GFP_NOWAIT); | 9571 | zalloc_cpumask_var(&nohz.cpu_mask, GFP_NOWAIT); |
9539 | alloc_cpumask_var(&nohz.ilb_grp_nohz_mask, GFP_NOWAIT); | 9572 | alloc_cpumask_var(&nohz.ilb_grp_nohz_mask, GFP_NOWAIT); |
9540 | #endif | 9573 | #endif |
9541 | alloc_cpumask_var(&cpu_isolated_map, GFP_NOWAIT); | 9574 | zalloc_cpumask_var(&cpu_isolated_map, GFP_NOWAIT); |
9542 | #endif /* SMP */ | 9575 | #endif /* SMP */ |
9543 | 9576 | ||
9544 | perf_event_init(); | 9577 | perf_event_init(); |
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index c32c3e643daa..37087a7fac22 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c | |||
@@ -822,6 +822,26 @@ check_preempt_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr) | |||
822 | * re-elected due to buddy favours. | 822 | * re-elected due to buddy favours. |
823 | */ | 823 | */ |
824 | clear_buddies(cfs_rq, curr); | 824 | clear_buddies(cfs_rq, curr); |
825 | return; | ||
826 | } | ||
827 | |||
828 | /* | ||
829 | * Ensure that a task that missed wakeup preemption by a | ||
830 | * narrow margin doesn't have to wait for a full slice. | ||
831 | * This also mitigates buddy induced latencies under load. | ||
832 | */ | ||
833 | if (!sched_feat(WAKEUP_PREEMPT)) | ||
834 | return; | ||
835 | |||
836 | if (delta_exec < sysctl_sched_min_granularity) | ||
837 | return; | ||
838 | |||
839 | if (cfs_rq->nr_running > 1) { | ||
840 | struct sched_entity *se = __pick_next_entity(cfs_rq); | ||
841 | s64 delta = curr->vruntime - se->vruntime; | ||
842 | |||
843 | if (delta > ideal_runtime) | ||
844 | resched_task(rq_of(cfs_rq)->curr); | ||
825 | } | 845 | } |
826 | } | 846 | } |
827 | 847 | ||
@@ -861,21 +881,18 @@ wakeup_preempt_entity(struct sched_entity *curr, struct sched_entity *se); | |||
861 | static struct sched_entity *pick_next_entity(struct cfs_rq *cfs_rq) | 881 | static struct sched_entity *pick_next_entity(struct cfs_rq *cfs_rq) |
862 | { | 882 | { |
863 | struct sched_entity *se = __pick_next_entity(cfs_rq); | 883 | struct sched_entity *se = __pick_next_entity(cfs_rq); |
864 | struct sched_entity *buddy; | 884 | struct sched_entity *left = se; |
865 | 885 | ||
866 | if (cfs_rq->next) { | 886 | if (cfs_rq->next && wakeup_preempt_entity(cfs_rq->next, left) < 1) |
867 | buddy = cfs_rq->next; | 887 | se = cfs_rq->next; |
868 | cfs_rq->next = NULL; | ||
869 | if (wakeup_preempt_entity(buddy, se) < 1) | ||
870 | return buddy; | ||
871 | } | ||
872 | 888 | ||
873 | if (cfs_rq->last) { | 889 | /* |
874 | buddy = cfs_rq->last; | 890 | * Prefer last buddy, try to return the CPU to a preempted task. |
875 | cfs_rq->last = NULL; | 891 | */ |
876 | if (wakeup_preempt_entity(buddy, se) < 1) | 892 | if (cfs_rq->last && wakeup_preempt_entity(cfs_rq->last, left) < 1) |
877 | return buddy; | 893 | se = cfs_rq->last; |
878 | } | 894 | |
895 | clear_buddies(cfs_rq, se); | ||
879 | 896 | ||
880 | return se; | 897 | return se; |
881 | } | 898 | } |
@@ -1577,6 +1594,7 @@ static void check_preempt_wakeup(struct rq *rq, struct task_struct *p, int wake_ | |||
1577 | struct sched_entity *se = &curr->se, *pse = &p->se; | 1594 | struct sched_entity *se = &curr->se, *pse = &p->se; |
1578 | struct cfs_rq *cfs_rq = task_cfs_rq(curr); | 1595 | struct cfs_rq *cfs_rq = task_cfs_rq(curr); |
1579 | int sync = wake_flags & WF_SYNC; | 1596 | int sync = wake_flags & WF_SYNC; |
1597 | int scale = cfs_rq->nr_running >= sched_nr_latency; | ||
1580 | 1598 | ||
1581 | update_curr(cfs_rq); | 1599 | update_curr(cfs_rq); |
1582 | 1600 | ||
@@ -1591,18 +1609,7 @@ static void check_preempt_wakeup(struct rq *rq, struct task_struct *p, int wake_ | |||
1591 | if (unlikely(se == pse)) | 1609 | if (unlikely(se == pse)) |
1592 | return; | 1610 | return; |
1593 | 1611 | ||
1594 | /* | 1612 | if (sched_feat(NEXT_BUDDY) && scale && !(wake_flags & WF_FORK)) |
1595 | * Only set the backward buddy when the current task is still on the | ||
1596 | * rq. This can happen when a wakeup gets interleaved with schedule on | ||
1597 | * the ->pre_schedule() or idle_balance() point, either of which can | ||
1598 | * drop the rq lock. | ||
1599 | * | ||
1600 | * Also, during early boot the idle thread is in the fair class, for | ||
1601 | * obvious reasons its a bad idea to schedule back to the idle thread. | ||
1602 | */ | ||
1603 | if (sched_feat(LAST_BUDDY) && likely(se->on_rq && curr != rq->idle)) | ||
1604 | set_last_buddy(se); | ||
1605 | if (sched_feat(NEXT_BUDDY) && !(wake_flags & WF_FORK)) | ||
1606 | set_next_buddy(pse); | 1613 | set_next_buddy(pse); |
1607 | 1614 | ||
1608 | /* | 1615 | /* |
@@ -1648,8 +1655,22 @@ static void check_preempt_wakeup(struct rq *rq, struct task_struct *p, int wake_ | |||
1648 | 1655 | ||
1649 | BUG_ON(!pse); | 1656 | BUG_ON(!pse); |
1650 | 1657 | ||
1651 | if (wakeup_preempt_entity(se, pse) == 1) | 1658 | if (wakeup_preempt_entity(se, pse) == 1) { |
1652 | resched_task(curr); | 1659 | resched_task(curr); |
1660 | /* | ||
1661 | * Only set the backward buddy when the current task is still | ||
1662 | * on the rq. This can happen when a wakeup gets interleaved | ||
1663 | * with schedule on the ->pre_schedule() or idle_balance() | ||
1664 | * point, either of which can * drop the rq lock. | ||
1665 | * | ||
1666 | * Also, during early boot the idle thread is in the fair class, | ||
1667 | * for obvious reasons its a bad idea to schedule back to it. | ||
1668 | */ | ||
1669 | if (unlikely(!se->on_rq || curr == rq->idle)) | ||
1670 | return; | ||
1671 | if (sched_feat(LAST_BUDDY) && scale && entity_is_task(se)) | ||
1672 | set_last_buddy(se); | ||
1673 | } | ||
1653 | } | 1674 | } |
1654 | 1675 | ||
1655 | static struct task_struct *pick_next_task_fair(struct rq *rq) | 1676 | static struct task_struct *pick_next_task_fair(struct rq *rq) |
diff --git a/kernel/slow-work-debugfs.c b/kernel/slow-work-debugfs.c new file mode 100644 index 000000000000..e45c43645298 --- /dev/null +++ b/kernel/slow-work-debugfs.c | |||
@@ -0,0 +1,227 @@ | |||
1 | /* Slow work debugging | ||
2 | * | ||
3 | * Copyright (C) 2009 Red Hat, Inc. All Rights Reserved. | ||
4 | * Written by David Howells (dhowells@redhat.com) | ||
5 | * | ||
6 | * This program is free software; you can redistribute it and/or | ||
7 | * modify it under the terms of the GNU General Public Licence | ||
8 | * as published by the Free Software Foundation; either version | ||
9 | * 2 of the Licence, or (at your option) any later version. | ||
10 | */ | ||
11 | |||
12 | #include <linux/module.h> | ||
13 | #include <linux/slow-work.h> | ||
14 | #include <linux/fs.h> | ||
15 | #include <linux/time.h> | ||
16 | #include <linux/seq_file.h> | ||
17 | #include "slow-work.h" | ||
18 | |||
19 | #define ITERATOR_SHIFT (BITS_PER_LONG - 4) | ||
20 | #define ITERATOR_SELECTOR (0xfUL << ITERATOR_SHIFT) | ||
21 | #define ITERATOR_COUNTER (~ITERATOR_SELECTOR) | ||
22 | |||
23 | void slow_work_new_thread_desc(struct slow_work *work, struct seq_file *m) | ||
24 | { | ||
25 | seq_puts(m, "Slow-work: New thread"); | ||
26 | } | ||
27 | |||
28 | /* | ||
29 | * Render the time mark field on a work item into a 5-char time with units plus | ||
30 | * a space | ||
31 | */ | ||
32 | static void slow_work_print_mark(struct seq_file *m, struct slow_work *work) | ||
33 | { | ||
34 | struct timespec now, diff; | ||
35 | |||
36 | now = CURRENT_TIME; | ||
37 | diff = timespec_sub(now, work->mark); | ||
38 | |||
39 | if (diff.tv_sec < 0) | ||
40 | seq_puts(m, " -ve "); | ||
41 | else if (diff.tv_sec == 0 && diff.tv_nsec < 1000) | ||
42 | seq_printf(m, "%3luns ", diff.tv_nsec); | ||
43 | else if (diff.tv_sec == 0 && diff.tv_nsec < 1000000) | ||
44 | seq_printf(m, "%3luus ", diff.tv_nsec / 1000); | ||
45 | else if (diff.tv_sec == 0 && diff.tv_nsec < 1000000000) | ||
46 | seq_printf(m, "%3lums ", diff.tv_nsec / 1000000); | ||
47 | else if (diff.tv_sec <= 1) | ||
48 | seq_puts(m, " 1s "); | ||
49 | else if (diff.tv_sec < 60) | ||
50 | seq_printf(m, "%4lus ", diff.tv_sec); | ||
51 | else if (diff.tv_sec < 60 * 60) | ||
52 | seq_printf(m, "%4lum ", diff.tv_sec / 60); | ||
53 | else if (diff.tv_sec < 60 * 60 * 24) | ||
54 | seq_printf(m, "%4luh ", diff.tv_sec / 3600); | ||
55 | else | ||
56 | seq_puts(m, "exces "); | ||
57 | } | ||
58 | |||
59 | /* | ||
60 | * Describe a slow work item for debugfs | ||
61 | */ | ||
62 | static int slow_work_runqueue_show(struct seq_file *m, void *v) | ||
63 | { | ||
64 | struct slow_work *work; | ||
65 | struct list_head *p = v; | ||
66 | unsigned long id; | ||
67 | |||
68 | switch ((unsigned long) v) { | ||
69 | case 1: | ||
70 | seq_puts(m, "THR PID ITEM ADDR FL MARK DESC\n"); | ||
71 | return 0; | ||
72 | case 2: | ||
73 | seq_puts(m, "=== ===== ================ == ===== ==========\n"); | ||
74 | return 0; | ||
75 | |||
76 | case 3 ... 3 + SLOW_WORK_THREAD_LIMIT - 1: | ||
77 | id = (unsigned long) v - 3; | ||
78 | |||
79 | read_lock(&slow_work_execs_lock); | ||
80 | work = slow_work_execs[id]; | ||
81 | if (work) { | ||
82 | smp_read_barrier_depends(); | ||
83 | |||
84 | seq_printf(m, "%3lu %5d %16p %2lx ", | ||
85 | id, slow_work_pids[id], work, work->flags); | ||
86 | slow_work_print_mark(m, work); | ||
87 | |||
88 | if (work->ops->desc) | ||
89 | work->ops->desc(work, m); | ||
90 | seq_putc(m, '\n'); | ||
91 | } | ||
92 | read_unlock(&slow_work_execs_lock); | ||
93 | return 0; | ||
94 | |||
95 | default: | ||
96 | work = list_entry(p, struct slow_work, link); | ||
97 | seq_printf(m, "%3s - %16p %2lx ", | ||
98 | work->flags & SLOW_WORK_VERY_SLOW ? "vsq" : "sq", | ||
99 | work, work->flags); | ||
100 | slow_work_print_mark(m, work); | ||
101 | |||
102 | if (work->ops->desc) | ||
103 | work->ops->desc(work, m); | ||
104 | seq_putc(m, '\n'); | ||
105 | return 0; | ||
106 | } | ||
107 | } | ||
108 | |||
109 | /* | ||
110 | * map the iterator to a work item | ||
111 | */ | ||
112 | static void *slow_work_runqueue_index(struct seq_file *m, loff_t *_pos) | ||
113 | { | ||
114 | struct list_head *p; | ||
115 | unsigned long count, id; | ||
116 | |||
117 | switch (*_pos >> ITERATOR_SHIFT) { | ||
118 | case 0x0: | ||
119 | if (*_pos == 0) | ||
120 | *_pos = 1; | ||
121 | if (*_pos < 3) | ||
122 | return (void *)(unsigned long) *_pos; | ||
123 | if (*_pos < 3 + SLOW_WORK_THREAD_LIMIT) | ||
124 | for (id = *_pos - 3; | ||
125 | id < SLOW_WORK_THREAD_LIMIT; | ||
126 | id++, (*_pos)++) | ||
127 | if (slow_work_execs[id]) | ||
128 | return (void *)(unsigned long) *_pos; | ||
129 | *_pos = 0x1UL << ITERATOR_SHIFT; | ||
130 | |||
131 | case 0x1: | ||
132 | count = *_pos & ITERATOR_COUNTER; | ||
133 | list_for_each(p, &slow_work_queue) { | ||
134 | if (count == 0) | ||
135 | return p; | ||
136 | count--; | ||
137 | } | ||
138 | *_pos = 0x2UL << ITERATOR_SHIFT; | ||
139 | |||
140 | case 0x2: | ||
141 | count = *_pos & ITERATOR_COUNTER; | ||
142 | list_for_each(p, &vslow_work_queue) { | ||
143 | if (count == 0) | ||
144 | return p; | ||
145 | count--; | ||
146 | } | ||
147 | *_pos = 0x3UL << ITERATOR_SHIFT; | ||
148 | |||
149 | default: | ||
150 | return NULL; | ||
151 | } | ||
152 | } | ||
153 | |||
154 | /* | ||
155 | * set up the iterator to start reading from the first line | ||
156 | */ | ||
157 | static void *slow_work_runqueue_start(struct seq_file *m, loff_t *_pos) | ||
158 | { | ||
159 | spin_lock_irq(&slow_work_queue_lock); | ||
160 | return slow_work_runqueue_index(m, _pos); | ||
161 | } | ||
162 | |||
163 | /* | ||
164 | * move to the next line | ||
165 | */ | ||
166 | static void *slow_work_runqueue_next(struct seq_file *m, void *v, loff_t *_pos) | ||
167 | { | ||
168 | struct list_head *p = v; | ||
169 | unsigned long selector = *_pos >> ITERATOR_SHIFT; | ||
170 | |||
171 | (*_pos)++; | ||
172 | switch (selector) { | ||
173 | case 0x0: | ||
174 | return slow_work_runqueue_index(m, _pos); | ||
175 | |||
176 | case 0x1: | ||
177 | if (*_pos >> ITERATOR_SHIFT == 0x1) { | ||
178 | p = p->next; | ||
179 | if (p != &slow_work_queue) | ||
180 | return p; | ||
181 | } | ||
182 | *_pos = 0x2UL << ITERATOR_SHIFT; | ||
183 | p = &vslow_work_queue; | ||
184 | |||
185 | case 0x2: | ||
186 | if (*_pos >> ITERATOR_SHIFT == 0x2) { | ||
187 | p = p->next; | ||
188 | if (p != &vslow_work_queue) | ||
189 | return p; | ||
190 | } | ||
191 | *_pos = 0x3UL << ITERATOR_SHIFT; | ||
192 | |||
193 | default: | ||
194 | return NULL; | ||
195 | } | ||
196 | } | ||
197 | |||
198 | /* | ||
199 | * clean up after reading | ||
200 | */ | ||
201 | static void slow_work_runqueue_stop(struct seq_file *m, void *v) | ||
202 | { | ||
203 | spin_unlock_irq(&slow_work_queue_lock); | ||
204 | } | ||
205 | |||
206 | static const struct seq_operations slow_work_runqueue_ops = { | ||
207 | .start = slow_work_runqueue_start, | ||
208 | .stop = slow_work_runqueue_stop, | ||
209 | .next = slow_work_runqueue_next, | ||
210 | .show = slow_work_runqueue_show, | ||
211 | }; | ||
212 | |||
213 | /* | ||
214 | * open "/sys/kernel/debug/slow_work/runqueue" to list queue contents | ||
215 | */ | ||
216 | static int slow_work_runqueue_open(struct inode *inode, struct file *file) | ||
217 | { | ||
218 | return seq_open(file, &slow_work_runqueue_ops); | ||
219 | } | ||
220 | |||
221 | const struct file_operations slow_work_runqueue_fops = { | ||
222 | .owner = THIS_MODULE, | ||
223 | .open = slow_work_runqueue_open, | ||
224 | .read = seq_read, | ||
225 | .llseek = seq_lseek, | ||
226 | .release = seq_release, | ||
227 | }; | ||
diff --git a/kernel/slow-work.c b/kernel/slow-work.c index 0d31135efbf4..00889bd3c590 100644 --- a/kernel/slow-work.c +++ b/kernel/slow-work.c | |||
@@ -16,11 +16,8 @@ | |||
16 | #include <linux/kthread.h> | 16 | #include <linux/kthread.h> |
17 | #include <linux/freezer.h> | 17 | #include <linux/freezer.h> |
18 | #include <linux/wait.h> | 18 | #include <linux/wait.h> |
19 | 19 | #include <linux/debugfs.h> | |
20 | #define SLOW_WORK_CULL_TIMEOUT (5 * HZ) /* cull threads 5s after running out of | 20 | #include "slow-work.h" |
21 | * things to do */ | ||
22 | #define SLOW_WORK_OOM_TIMEOUT (5 * HZ) /* can't start new threads for 5s after | ||
23 | * OOM */ | ||
24 | 21 | ||
25 | static void slow_work_cull_timeout(unsigned long); | 22 | static void slow_work_cull_timeout(unsigned long); |
26 | static void slow_work_oom_timeout(unsigned long); | 23 | static void slow_work_oom_timeout(unsigned long); |
@@ -46,7 +43,7 @@ static unsigned vslow_work_proportion = 50; /* % of threads that may process | |||
46 | 43 | ||
47 | #ifdef CONFIG_SYSCTL | 44 | #ifdef CONFIG_SYSCTL |
48 | static const int slow_work_min_min_threads = 2; | 45 | static const int slow_work_min_min_threads = 2; |
49 | static int slow_work_max_max_threads = 255; | 46 | static int slow_work_max_max_threads = SLOW_WORK_THREAD_LIMIT; |
50 | static const int slow_work_min_vslow = 1; | 47 | static const int slow_work_min_vslow = 1; |
51 | static const int slow_work_max_vslow = 99; | 48 | static const int slow_work_max_vslow = 99; |
52 | 49 | ||
@@ -98,6 +95,56 @@ static DEFINE_TIMER(slow_work_oom_timer, slow_work_oom_timeout, 0, 0); | |||
98 | static struct slow_work slow_work_new_thread; /* new thread starter */ | 95 | static struct slow_work slow_work_new_thread; /* new thread starter */ |
99 | 96 | ||
100 | /* | 97 | /* |
98 | * slow work ID allocation (use slow_work_queue_lock) | ||
99 | */ | ||
100 | static DECLARE_BITMAP(slow_work_ids, SLOW_WORK_THREAD_LIMIT); | ||
101 | |||
102 | /* | ||
103 | * Unregistration tracking to prevent put_ref() from disappearing during module | ||
104 | * unload | ||
105 | */ | ||
106 | #ifdef CONFIG_MODULES | ||
107 | static struct module *slow_work_thread_processing[SLOW_WORK_THREAD_LIMIT]; | ||
108 | static struct module *slow_work_unreg_module; | ||
109 | static struct slow_work *slow_work_unreg_work_item; | ||
110 | static DECLARE_WAIT_QUEUE_HEAD(slow_work_unreg_wq); | ||
111 | static DEFINE_MUTEX(slow_work_unreg_sync_lock); | ||
112 | |||
113 | static void slow_work_set_thread_processing(int id, struct slow_work *work) | ||
114 | { | ||
115 | if (work) | ||
116 | slow_work_thread_processing[id] = work->owner; | ||
117 | } | ||
118 | static void slow_work_done_thread_processing(int id, struct slow_work *work) | ||
119 | { | ||
120 | struct module *module = slow_work_thread_processing[id]; | ||
121 | |||
122 | slow_work_thread_processing[id] = NULL; | ||
123 | smp_mb(); | ||
124 | if (slow_work_unreg_work_item == work || | ||
125 | slow_work_unreg_module == module) | ||
126 | wake_up_all(&slow_work_unreg_wq); | ||
127 | } | ||
128 | static void slow_work_clear_thread_processing(int id) | ||
129 | { | ||
130 | slow_work_thread_processing[id] = NULL; | ||
131 | } | ||
132 | #else | ||
133 | static void slow_work_set_thread_processing(int id, struct slow_work *work) {} | ||
134 | static void slow_work_done_thread_processing(int id, struct slow_work *work) {} | ||
135 | static void slow_work_clear_thread_processing(int id) {} | ||
136 | #endif | ||
137 | |||
138 | /* | ||
139 | * Data for tracking currently executing items for indication through /proc | ||
140 | */ | ||
141 | #ifdef CONFIG_SLOW_WORK_DEBUG | ||
142 | struct slow_work *slow_work_execs[SLOW_WORK_THREAD_LIMIT]; | ||
143 | pid_t slow_work_pids[SLOW_WORK_THREAD_LIMIT]; | ||
144 | DEFINE_RWLOCK(slow_work_execs_lock); | ||
145 | #endif | ||
146 | |||
147 | /* | ||
101 | * The queues of work items and the lock governing access to them. These are | 148 | * The queues of work items and the lock governing access to them. These are |
102 | * shared between all the CPUs. It doesn't make sense to have per-CPU queues | 149 | * shared between all the CPUs. It doesn't make sense to have per-CPU queues |
103 | * as the number of threads bears no relation to the number of CPUs. | 150 | * as the number of threads bears no relation to the number of CPUs. |
@@ -105,9 +152,18 @@ static struct slow_work slow_work_new_thread; /* new thread starter */ | |||
105 | * There are two queues of work items: one for slow work items, and one for | 152 | * There are two queues of work items: one for slow work items, and one for |
106 | * very slow work items. | 153 | * very slow work items. |
107 | */ | 154 | */ |
108 | static LIST_HEAD(slow_work_queue); | 155 | LIST_HEAD(slow_work_queue); |
109 | static LIST_HEAD(vslow_work_queue); | 156 | LIST_HEAD(vslow_work_queue); |
110 | static DEFINE_SPINLOCK(slow_work_queue_lock); | 157 | DEFINE_SPINLOCK(slow_work_queue_lock); |
158 | |||
159 | /* | ||
160 | * The following are two wait queues that get pinged when a work item is placed | ||
161 | * on an empty queue. These allow work items that are hogging a thread by | ||
162 | * sleeping in a way that could be deferred to yield their thread and enqueue | ||
163 | * themselves. | ||
164 | */ | ||
165 | static DECLARE_WAIT_QUEUE_HEAD(slow_work_queue_waits_for_occupation); | ||
166 | static DECLARE_WAIT_QUEUE_HEAD(vslow_work_queue_waits_for_occupation); | ||
111 | 167 | ||
112 | /* | 168 | /* |
113 | * The thread controls. A variable used to signal to the threads that they | 169 | * The thread controls. A variable used to signal to the threads that they |
@@ -126,6 +182,20 @@ static DECLARE_COMPLETION(slow_work_last_thread_exited); | |||
126 | static int slow_work_user_count; | 182 | static int slow_work_user_count; |
127 | static DEFINE_MUTEX(slow_work_user_lock); | 183 | static DEFINE_MUTEX(slow_work_user_lock); |
128 | 184 | ||
185 | static inline int slow_work_get_ref(struct slow_work *work) | ||
186 | { | ||
187 | if (work->ops->get_ref) | ||
188 | return work->ops->get_ref(work); | ||
189 | |||
190 | return 0; | ||
191 | } | ||
192 | |||
193 | static inline void slow_work_put_ref(struct slow_work *work) | ||
194 | { | ||
195 | if (work->ops->put_ref) | ||
196 | work->ops->put_ref(work); | ||
197 | } | ||
198 | |||
129 | /* | 199 | /* |
130 | * Calculate the maximum number of active threads in the pool that are | 200 | * Calculate the maximum number of active threads in the pool that are |
131 | * permitted to process very slow work items. | 201 | * permitted to process very slow work items. |
@@ -149,7 +219,7 @@ static unsigned slow_work_calc_vsmax(void) | |||
149 | * Attempt to execute stuff queued on a slow thread. Return true if we managed | 219 | * Attempt to execute stuff queued on a slow thread. Return true if we managed |
150 | * it, false if there was nothing to do. | 220 | * it, false if there was nothing to do. |
151 | */ | 221 | */ |
152 | static bool slow_work_execute(void) | 222 | static noinline bool slow_work_execute(int id) |
153 | { | 223 | { |
154 | struct slow_work *work = NULL; | 224 | struct slow_work *work = NULL; |
155 | unsigned vsmax; | 225 | unsigned vsmax; |
@@ -186,6 +256,13 @@ static bool slow_work_execute(void) | |||
186 | } else { | 256 | } else { |
187 | very_slow = false; /* avoid the compiler warning */ | 257 | very_slow = false; /* avoid the compiler warning */ |
188 | } | 258 | } |
259 | |||
260 | slow_work_set_thread_processing(id, work); | ||
261 | if (work) { | ||
262 | slow_work_mark_time(work); | ||
263 | slow_work_begin_exec(id, work); | ||
264 | } | ||
265 | |||
189 | spin_unlock_irq(&slow_work_queue_lock); | 266 | spin_unlock_irq(&slow_work_queue_lock); |
190 | 267 | ||
191 | if (!work) | 268 | if (!work) |
@@ -194,12 +271,19 @@ static bool slow_work_execute(void) | |||
194 | if (!test_and_clear_bit(SLOW_WORK_PENDING, &work->flags)) | 271 | if (!test_and_clear_bit(SLOW_WORK_PENDING, &work->flags)) |
195 | BUG(); | 272 | BUG(); |
196 | 273 | ||
197 | work->ops->execute(work); | 274 | /* don't execute if the work is in the process of being cancelled */ |
275 | if (!test_bit(SLOW_WORK_CANCELLING, &work->flags)) | ||
276 | work->ops->execute(work); | ||
198 | 277 | ||
199 | if (very_slow) | 278 | if (very_slow) |
200 | atomic_dec(&vslow_work_executing_count); | 279 | atomic_dec(&vslow_work_executing_count); |
201 | clear_bit_unlock(SLOW_WORK_EXECUTING, &work->flags); | 280 | clear_bit_unlock(SLOW_WORK_EXECUTING, &work->flags); |
202 | 281 | ||
282 | /* wake up anyone waiting for this work to be complete */ | ||
283 | wake_up_bit(&work->flags, SLOW_WORK_EXECUTING); | ||
284 | |||
285 | slow_work_end_exec(id, work); | ||
286 | |||
203 | /* if someone tried to enqueue the item whilst we were executing it, | 287 | /* if someone tried to enqueue the item whilst we were executing it, |
204 | * then it'll be left unenqueued to avoid multiple threads trying to | 288 | * then it'll be left unenqueued to avoid multiple threads trying to |
205 | * execute it simultaneously | 289 | * execute it simultaneously |
@@ -219,7 +303,10 @@ static bool slow_work_execute(void) | |||
219 | spin_unlock_irq(&slow_work_queue_lock); | 303 | spin_unlock_irq(&slow_work_queue_lock); |
220 | } | 304 | } |
221 | 305 | ||
222 | work->ops->put_ref(work); | 306 | /* sort out the race between module unloading and put_ref() */ |
307 | slow_work_put_ref(work); | ||
308 | slow_work_done_thread_processing(id, work); | ||
309 | |||
223 | return true; | 310 | return true; |
224 | 311 | ||
225 | auto_requeue: | 312 | auto_requeue: |
@@ -227,15 +314,61 @@ auto_requeue: | |||
227 | * - we transfer our ref on the item back to the appropriate queue | 314 | * - we transfer our ref on the item back to the appropriate queue |
228 | * - don't wake another thread up as we're awake already | 315 | * - don't wake another thread up as we're awake already |
229 | */ | 316 | */ |
317 | slow_work_mark_time(work); | ||
230 | if (test_bit(SLOW_WORK_VERY_SLOW, &work->flags)) | 318 | if (test_bit(SLOW_WORK_VERY_SLOW, &work->flags)) |
231 | list_add_tail(&work->link, &vslow_work_queue); | 319 | list_add_tail(&work->link, &vslow_work_queue); |
232 | else | 320 | else |
233 | list_add_tail(&work->link, &slow_work_queue); | 321 | list_add_tail(&work->link, &slow_work_queue); |
234 | spin_unlock_irq(&slow_work_queue_lock); | 322 | spin_unlock_irq(&slow_work_queue_lock); |
323 | slow_work_clear_thread_processing(id); | ||
235 | return true; | 324 | return true; |
236 | } | 325 | } |
237 | 326 | ||
238 | /** | 327 | /** |
328 | * slow_work_sleep_till_thread_needed - Sleep till thread needed by other work | ||
329 | * work: The work item under execution that wants to sleep | ||
330 | * _timeout: Scheduler sleep timeout | ||
331 | * | ||
332 | * Allow a requeueable work item to sleep on a slow-work processor thread until | ||
333 | * that thread is needed to do some other work or the sleep is interrupted by | ||
334 | * some other event. | ||
335 | * | ||
336 | * The caller must set up a wake up event before calling this and must have set | ||
337 | * the appropriate sleep mode (such as TASK_UNINTERRUPTIBLE) and tested its own | ||
338 | * condition before calling this function as no test is made here. | ||
339 | * | ||
340 | * False is returned if there is nothing on the queue; true is returned if the | ||
341 | * work item should be requeued | ||
342 | */ | ||
343 | bool slow_work_sleep_till_thread_needed(struct slow_work *work, | ||
344 | signed long *_timeout) | ||
345 | { | ||
346 | wait_queue_head_t *wfo_wq; | ||
347 | struct list_head *queue; | ||
348 | |||
349 | DEFINE_WAIT(wait); | ||
350 | |||
351 | if (test_bit(SLOW_WORK_VERY_SLOW, &work->flags)) { | ||
352 | wfo_wq = &vslow_work_queue_waits_for_occupation; | ||
353 | queue = &vslow_work_queue; | ||
354 | } else { | ||
355 | wfo_wq = &slow_work_queue_waits_for_occupation; | ||
356 | queue = &slow_work_queue; | ||
357 | } | ||
358 | |||
359 | if (!list_empty(queue)) | ||
360 | return true; | ||
361 | |||
362 | add_wait_queue_exclusive(wfo_wq, &wait); | ||
363 | if (list_empty(queue)) | ||
364 | *_timeout = schedule_timeout(*_timeout); | ||
365 | finish_wait(wfo_wq, &wait); | ||
366 | |||
367 | return !list_empty(queue); | ||
368 | } | ||
369 | EXPORT_SYMBOL(slow_work_sleep_till_thread_needed); | ||
370 | |||
371 | /** | ||
239 | * slow_work_enqueue - Schedule a slow work item for processing | 372 | * slow_work_enqueue - Schedule a slow work item for processing |
240 | * @work: The work item to queue | 373 | * @work: The work item to queue |
241 | * | 374 | * |
@@ -260,16 +393,22 @@ auto_requeue: | |||
260 | * allowed to pick items to execute. This ensures that very slow items won't | 393 | * allowed to pick items to execute. This ensures that very slow items won't |
261 | * overly block ones that are just ordinarily slow. | 394 | * overly block ones that are just ordinarily slow. |
262 | * | 395 | * |
263 | * Returns 0 if successful, -EAGAIN if not. | 396 | * Returns 0 if successful, -EAGAIN if not (or -ECANCELED if cancelled work is |
397 | * attempted queued) | ||
264 | */ | 398 | */ |
265 | int slow_work_enqueue(struct slow_work *work) | 399 | int slow_work_enqueue(struct slow_work *work) |
266 | { | 400 | { |
401 | wait_queue_head_t *wfo_wq; | ||
402 | struct list_head *queue; | ||
267 | unsigned long flags; | 403 | unsigned long flags; |
404 | int ret; | ||
405 | |||
406 | if (test_bit(SLOW_WORK_CANCELLING, &work->flags)) | ||
407 | return -ECANCELED; | ||
268 | 408 | ||
269 | BUG_ON(slow_work_user_count <= 0); | 409 | BUG_ON(slow_work_user_count <= 0); |
270 | BUG_ON(!work); | 410 | BUG_ON(!work); |
271 | BUG_ON(!work->ops); | 411 | BUG_ON(!work->ops); |
272 | BUG_ON(!work->ops->get_ref); | ||
273 | 412 | ||
274 | /* when honouring an enqueue request, we only promise that we will run | 413 | /* when honouring an enqueue request, we only promise that we will run |
275 | * the work function in the future; we do not promise to run it once | 414 | * the work function in the future; we do not promise to run it once |
@@ -280,8 +419,19 @@ int slow_work_enqueue(struct slow_work *work) | |||
280 | * maintaining our promise | 419 | * maintaining our promise |
281 | */ | 420 | */ |
282 | if (!test_and_set_bit_lock(SLOW_WORK_PENDING, &work->flags)) { | 421 | if (!test_and_set_bit_lock(SLOW_WORK_PENDING, &work->flags)) { |
422 | if (test_bit(SLOW_WORK_VERY_SLOW, &work->flags)) { | ||
423 | wfo_wq = &vslow_work_queue_waits_for_occupation; | ||
424 | queue = &vslow_work_queue; | ||
425 | } else { | ||
426 | wfo_wq = &slow_work_queue_waits_for_occupation; | ||
427 | queue = &slow_work_queue; | ||
428 | } | ||
429 | |||
283 | spin_lock_irqsave(&slow_work_queue_lock, flags); | 430 | spin_lock_irqsave(&slow_work_queue_lock, flags); |
284 | 431 | ||
432 | if (unlikely(test_bit(SLOW_WORK_CANCELLING, &work->flags))) | ||
433 | goto cancelled; | ||
434 | |||
285 | /* we promise that we will not attempt to execute the work | 435 | /* we promise that we will not attempt to execute the work |
286 | * function in more than one thread simultaneously | 436 | * function in more than one thread simultaneously |
287 | * | 437 | * |
@@ -299,25 +449,221 @@ int slow_work_enqueue(struct slow_work *work) | |||
299 | if (test_bit(SLOW_WORK_EXECUTING, &work->flags)) { | 449 | if (test_bit(SLOW_WORK_EXECUTING, &work->flags)) { |
300 | set_bit(SLOW_WORK_ENQ_DEFERRED, &work->flags); | 450 | set_bit(SLOW_WORK_ENQ_DEFERRED, &work->flags); |
301 | } else { | 451 | } else { |
302 | if (work->ops->get_ref(work) < 0) | 452 | ret = slow_work_get_ref(work); |
303 | goto cant_get_ref; | 453 | if (ret < 0) |
304 | if (test_bit(SLOW_WORK_VERY_SLOW, &work->flags)) | 454 | goto failed; |
305 | list_add_tail(&work->link, &vslow_work_queue); | 455 | slow_work_mark_time(work); |
306 | else | 456 | list_add_tail(&work->link, queue); |
307 | list_add_tail(&work->link, &slow_work_queue); | ||
308 | wake_up(&slow_work_thread_wq); | 457 | wake_up(&slow_work_thread_wq); |
458 | |||
459 | /* if someone who could be requeued is sleeping on a | ||
460 | * thread, then ask them to yield their thread */ | ||
461 | if (work->link.prev == queue) | ||
462 | wake_up(wfo_wq); | ||
309 | } | 463 | } |
310 | 464 | ||
311 | spin_unlock_irqrestore(&slow_work_queue_lock, flags); | 465 | spin_unlock_irqrestore(&slow_work_queue_lock, flags); |
312 | } | 466 | } |
313 | return 0; | 467 | return 0; |
314 | 468 | ||
315 | cant_get_ref: | 469 | cancelled: |
470 | ret = -ECANCELED; | ||
471 | failed: | ||
316 | spin_unlock_irqrestore(&slow_work_queue_lock, flags); | 472 | spin_unlock_irqrestore(&slow_work_queue_lock, flags); |
317 | return -EAGAIN; | 473 | return ret; |
318 | } | 474 | } |
319 | EXPORT_SYMBOL(slow_work_enqueue); | 475 | EXPORT_SYMBOL(slow_work_enqueue); |
320 | 476 | ||
477 | static int slow_work_wait(void *word) | ||
478 | { | ||
479 | schedule(); | ||
480 | return 0; | ||
481 | } | ||
482 | |||
483 | /** | ||
484 | * slow_work_cancel - Cancel a slow work item | ||
485 | * @work: The work item to cancel | ||
486 | * | ||
487 | * This function will cancel a previously enqueued work item. If we cannot | ||
488 | * cancel the work item, it is guarenteed to have run when this function | ||
489 | * returns. | ||
490 | */ | ||
491 | void slow_work_cancel(struct slow_work *work) | ||
492 | { | ||
493 | bool wait = true, put = false; | ||
494 | |||
495 | set_bit(SLOW_WORK_CANCELLING, &work->flags); | ||
496 | smp_mb(); | ||
497 | |||
498 | /* if the work item is a delayed work item with an active timer, we | ||
499 | * need to wait for the timer to finish _before_ getting the spinlock, | ||
500 | * lest we deadlock against the timer routine | ||
501 | * | ||
502 | * the timer routine will leave DELAYED set if it notices the | ||
503 | * CANCELLING flag in time | ||
504 | */ | ||
505 | if (test_bit(SLOW_WORK_DELAYED, &work->flags)) { | ||
506 | struct delayed_slow_work *dwork = | ||
507 | container_of(work, struct delayed_slow_work, work); | ||
508 | del_timer_sync(&dwork->timer); | ||
509 | } | ||
510 | |||
511 | spin_lock_irq(&slow_work_queue_lock); | ||
512 | |||
513 | if (test_bit(SLOW_WORK_DELAYED, &work->flags)) { | ||
514 | /* the timer routine aborted or never happened, so we are left | ||
515 | * holding the timer's reference on the item and should just | ||
516 | * drop the pending flag and wait for any ongoing execution to | ||
517 | * finish */ | ||
518 | struct delayed_slow_work *dwork = | ||
519 | container_of(work, struct delayed_slow_work, work); | ||
520 | |||
521 | BUG_ON(timer_pending(&dwork->timer)); | ||
522 | BUG_ON(!list_empty(&work->link)); | ||
523 | |||
524 | clear_bit(SLOW_WORK_DELAYED, &work->flags); | ||
525 | put = true; | ||
526 | clear_bit(SLOW_WORK_PENDING, &work->flags); | ||
527 | |||
528 | } else if (test_bit(SLOW_WORK_PENDING, &work->flags) && | ||
529 | !list_empty(&work->link)) { | ||
530 | /* the link in the pending queue holds a reference on the item | ||
531 | * that we will need to release */ | ||
532 | list_del_init(&work->link); | ||
533 | wait = false; | ||
534 | put = true; | ||
535 | clear_bit(SLOW_WORK_PENDING, &work->flags); | ||
536 | |||
537 | } else if (test_and_clear_bit(SLOW_WORK_ENQ_DEFERRED, &work->flags)) { | ||
538 | /* the executor is holding our only reference on the item, so | ||
539 | * we merely need to wait for it to finish executing */ | ||
540 | clear_bit(SLOW_WORK_PENDING, &work->flags); | ||
541 | } | ||
542 | |||
543 | spin_unlock_irq(&slow_work_queue_lock); | ||
544 | |||
545 | /* the EXECUTING flag is set by the executor whilst the spinlock is set | ||
546 | * and before the item is dequeued - so assuming the above doesn't | ||
547 | * actually dequeue it, simply waiting for the EXECUTING flag to be | ||
548 | * released here should be sufficient */ | ||
549 | if (wait) | ||
550 | wait_on_bit(&work->flags, SLOW_WORK_EXECUTING, slow_work_wait, | ||
551 | TASK_UNINTERRUPTIBLE); | ||
552 | |||
553 | clear_bit(SLOW_WORK_CANCELLING, &work->flags); | ||
554 | if (put) | ||
555 | slow_work_put_ref(work); | ||
556 | } | ||
557 | EXPORT_SYMBOL(slow_work_cancel); | ||
558 | |||
559 | /* | ||
560 | * Handle expiry of the delay timer, indicating that a delayed slow work item | ||
561 | * should now be queued if not cancelled | ||
562 | */ | ||
563 | static void delayed_slow_work_timer(unsigned long data) | ||
564 | { | ||
565 | wait_queue_head_t *wfo_wq; | ||
566 | struct list_head *queue; | ||
567 | struct slow_work *work = (struct slow_work *) data; | ||
568 | unsigned long flags; | ||
569 | bool queued = false, put = false, first = false; | ||
570 | |||
571 | if (test_bit(SLOW_WORK_VERY_SLOW, &work->flags)) { | ||
572 | wfo_wq = &vslow_work_queue_waits_for_occupation; | ||
573 | queue = &vslow_work_queue; | ||
574 | } else { | ||
575 | wfo_wq = &slow_work_queue_waits_for_occupation; | ||
576 | queue = &slow_work_queue; | ||
577 | } | ||
578 | |||
579 | spin_lock_irqsave(&slow_work_queue_lock, flags); | ||
580 | if (likely(!test_bit(SLOW_WORK_CANCELLING, &work->flags))) { | ||
581 | clear_bit(SLOW_WORK_DELAYED, &work->flags); | ||
582 | |||
583 | if (test_bit(SLOW_WORK_EXECUTING, &work->flags)) { | ||
584 | /* we discard the reference the timer was holding in | ||
585 | * favour of the one the executor holds */ | ||
586 | set_bit(SLOW_WORK_ENQ_DEFERRED, &work->flags); | ||
587 | put = true; | ||
588 | } else { | ||
589 | slow_work_mark_time(work); | ||
590 | list_add_tail(&work->link, queue); | ||
591 | queued = true; | ||
592 | if (work->link.prev == queue) | ||
593 | first = true; | ||
594 | } | ||
595 | } | ||
596 | |||
597 | spin_unlock_irqrestore(&slow_work_queue_lock, flags); | ||
598 | if (put) | ||
599 | slow_work_put_ref(work); | ||
600 | if (first) | ||
601 | wake_up(wfo_wq); | ||
602 | if (queued) | ||
603 | wake_up(&slow_work_thread_wq); | ||
604 | } | ||
605 | |||
606 | /** | ||
607 | * delayed_slow_work_enqueue - Schedule a delayed slow work item for processing | ||
608 | * @dwork: The delayed work item to queue | ||
609 | * @delay: When to start executing the work, in jiffies from now | ||
610 | * | ||
611 | * This is similar to slow_work_enqueue(), but it adds a delay before the work | ||
612 | * is actually queued for processing. | ||
613 | * | ||
614 | * The item can have delayed processing requested on it whilst it is being | ||
615 | * executed. The delay will begin immediately, and if it expires before the | ||
616 | * item finishes executing, the item will be placed back on the queue when it | ||
617 | * has done executing. | ||
618 | */ | ||
619 | int delayed_slow_work_enqueue(struct delayed_slow_work *dwork, | ||
620 | unsigned long delay) | ||
621 | { | ||
622 | struct slow_work *work = &dwork->work; | ||
623 | unsigned long flags; | ||
624 | int ret; | ||
625 | |||
626 | if (delay == 0) | ||
627 | return slow_work_enqueue(&dwork->work); | ||
628 | |||
629 | BUG_ON(slow_work_user_count <= 0); | ||
630 | BUG_ON(!work); | ||
631 | BUG_ON(!work->ops); | ||
632 | |||
633 | if (test_bit(SLOW_WORK_CANCELLING, &work->flags)) | ||
634 | return -ECANCELED; | ||
635 | |||
636 | if (!test_and_set_bit_lock(SLOW_WORK_PENDING, &work->flags)) { | ||
637 | spin_lock_irqsave(&slow_work_queue_lock, flags); | ||
638 | |||
639 | if (test_bit(SLOW_WORK_CANCELLING, &work->flags)) | ||
640 | goto cancelled; | ||
641 | |||
642 | /* the timer holds a reference whilst it is pending */ | ||
643 | ret = work->ops->get_ref(work); | ||
644 | if (ret < 0) | ||
645 | goto cant_get_ref; | ||
646 | |||
647 | if (test_and_set_bit(SLOW_WORK_DELAYED, &work->flags)) | ||
648 | BUG(); | ||
649 | dwork->timer.expires = jiffies + delay; | ||
650 | dwork->timer.data = (unsigned long) work; | ||
651 | dwork->timer.function = delayed_slow_work_timer; | ||
652 | add_timer(&dwork->timer); | ||
653 | |||
654 | spin_unlock_irqrestore(&slow_work_queue_lock, flags); | ||
655 | } | ||
656 | |||
657 | return 0; | ||
658 | |||
659 | cancelled: | ||
660 | ret = -ECANCELED; | ||
661 | cant_get_ref: | ||
662 | spin_unlock_irqrestore(&slow_work_queue_lock, flags); | ||
663 | return ret; | ||
664 | } | ||
665 | EXPORT_SYMBOL(delayed_slow_work_enqueue); | ||
666 | |||
321 | /* | 667 | /* |
322 | * Schedule a cull of the thread pool at some time in the near future | 668 | * Schedule a cull of the thread pool at some time in the near future |
323 | */ | 669 | */ |
@@ -368,13 +714,23 @@ static inline bool slow_work_available(int vsmax) | |||
368 | */ | 714 | */ |
369 | static int slow_work_thread(void *_data) | 715 | static int slow_work_thread(void *_data) |
370 | { | 716 | { |
371 | int vsmax; | 717 | int vsmax, id; |
372 | 718 | ||
373 | DEFINE_WAIT(wait); | 719 | DEFINE_WAIT(wait); |
374 | 720 | ||
375 | set_freezable(); | 721 | set_freezable(); |
376 | set_user_nice(current, -5); | 722 | set_user_nice(current, -5); |
377 | 723 | ||
724 | /* allocate ourselves an ID */ | ||
725 | spin_lock_irq(&slow_work_queue_lock); | ||
726 | id = find_first_zero_bit(slow_work_ids, SLOW_WORK_THREAD_LIMIT); | ||
727 | BUG_ON(id < 0 || id >= SLOW_WORK_THREAD_LIMIT); | ||
728 | __set_bit(id, slow_work_ids); | ||
729 | slow_work_set_thread_pid(id, current->pid); | ||
730 | spin_unlock_irq(&slow_work_queue_lock); | ||
731 | |||
732 | sprintf(current->comm, "kslowd%03u", id); | ||
733 | |||
378 | for (;;) { | 734 | for (;;) { |
379 | vsmax = vslow_work_proportion; | 735 | vsmax = vslow_work_proportion; |
380 | vsmax *= atomic_read(&slow_work_thread_count); | 736 | vsmax *= atomic_read(&slow_work_thread_count); |
@@ -395,7 +751,7 @@ static int slow_work_thread(void *_data) | |||
395 | vsmax *= atomic_read(&slow_work_thread_count); | 751 | vsmax *= atomic_read(&slow_work_thread_count); |
396 | vsmax /= 100; | 752 | vsmax /= 100; |
397 | 753 | ||
398 | if (slow_work_available(vsmax) && slow_work_execute()) { | 754 | if (slow_work_available(vsmax) && slow_work_execute(id)) { |
399 | cond_resched(); | 755 | cond_resched(); |
400 | if (list_empty(&slow_work_queue) && | 756 | if (list_empty(&slow_work_queue) && |
401 | list_empty(&vslow_work_queue) && | 757 | list_empty(&vslow_work_queue) && |
@@ -412,6 +768,11 @@ static int slow_work_thread(void *_data) | |||
412 | break; | 768 | break; |
413 | } | 769 | } |
414 | 770 | ||
771 | spin_lock_irq(&slow_work_queue_lock); | ||
772 | slow_work_set_thread_pid(id, 0); | ||
773 | __clear_bit(id, slow_work_ids); | ||
774 | spin_unlock_irq(&slow_work_queue_lock); | ||
775 | |||
415 | if (atomic_dec_and_test(&slow_work_thread_count)) | 776 | if (atomic_dec_and_test(&slow_work_thread_count)) |
416 | complete_and_exit(&slow_work_last_thread_exited, 0); | 777 | complete_and_exit(&slow_work_last_thread_exited, 0); |
417 | return 0; | 778 | return 0; |
@@ -427,21 +788,6 @@ static void slow_work_cull_timeout(unsigned long data) | |||
427 | } | 788 | } |
428 | 789 | ||
429 | /* | 790 | /* |
430 | * Get a reference on slow work thread starter | ||
431 | */ | ||
432 | static int slow_work_new_thread_get_ref(struct slow_work *work) | ||
433 | { | ||
434 | return 0; | ||
435 | } | ||
436 | |||
437 | /* | ||
438 | * Drop a reference on slow work thread starter | ||
439 | */ | ||
440 | static void slow_work_new_thread_put_ref(struct slow_work *work) | ||
441 | { | ||
442 | } | ||
443 | |||
444 | /* | ||
445 | * Start a new slow work thread | 791 | * Start a new slow work thread |
446 | */ | 792 | */ |
447 | static void slow_work_new_thread_execute(struct slow_work *work) | 793 | static void slow_work_new_thread_execute(struct slow_work *work) |
@@ -475,9 +821,11 @@ static void slow_work_new_thread_execute(struct slow_work *work) | |||
475 | } | 821 | } |
476 | 822 | ||
477 | static const struct slow_work_ops slow_work_new_thread_ops = { | 823 | static const struct slow_work_ops slow_work_new_thread_ops = { |
478 | .get_ref = slow_work_new_thread_get_ref, | 824 | .owner = THIS_MODULE, |
479 | .put_ref = slow_work_new_thread_put_ref, | ||
480 | .execute = slow_work_new_thread_execute, | 825 | .execute = slow_work_new_thread_execute, |
826 | #ifdef CONFIG_SLOW_WORK_DEBUG | ||
827 | .desc = slow_work_new_thread_desc, | ||
828 | #endif | ||
481 | }; | 829 | }; |
482 | 830 | ||
483 | /* | 831 | /* |
@@ -546,12 +894,13 @@ static int slow_work_max_threads_sysctl(struct ctl_table *table, int write, | |||
546 | 894 | ||
547 | /** | 895 | /** |
548 | * slow_work_register_user - Register a user of the facility | 896 | * slow_work_register_user - Register a user of the facility |
897 | * @module: The module about to make use of the facility | ||
549 | * | 898 | * |
550 | * Register a user of the facility, starting up the initial threads if there | 899 | * Register a user of the facility, starting up the initial threads if there |
551 | * aren't any other users at this point. This will return 0 if successful, or | 900 | * aren't any other users at this point. This will return 0 if successful, or |
552 | * an error if not. | 901 | * an error if not. |
553 | */ | 902 | */ |
554 | int slow_work_register_user(void) | 903 | int slow_work_register_user(struct module *module) |
555 | { | 904 | { |
556 | struct task_struct *p; | 905 | struct task_struct *p; |
557 | int loop; | 906 | int loop; |
@@ -598,14 +947,81 @@ error: | |||
598 | } | 947 | } |
599 | EXPORT_SYMBOL(slow_work_register_user); | 948 | EXPORT_SYMBOL(slow_work_register_user); |
600 | 949 | ||
950 | /* | ||
951 | * wait for all outstanding items from the calling module to complete | ||
952 | * - note that more items may be queued whilst we're waiting | ||
953 | */ | ||
954 | static void slow_work_wait_for_items(struct module *module) | ||
955 | { | ||
956 | #ifdef CONFIG_MODULES | ||
957 | DECLARE_WAITQUEUE(myself, current); | ||
958 | struct slow_work *work; | ||
959 | int loop; | ||
960 | |||
961 | mutex_lock(&slow_work_unreg_sync_lock); | ||
962 | add_wait_queue(&slow_work_unreg_wq, &myself); | ||
963 | |||
964 | for (;;) { | ||
965 | spin_lock_irq(&slow_work_queue_lock); | ||
966 | |||
967 | /* first of all, we wait for the last queued item in each list | ||
968 | * to be processed */ | ||
969 | list_for_each_entry_reverse(work, &vslow_work_queue, link) { | ||
970 | if (work->owner == module) { | ||
971 | set_current_state(TASK_UNINTERRUPTIBLE); | ||
972 | slow_work_unreg_work_item = work; | ||
973 | goto do_wait; | ||
974 | } | ||
975 | } | ||
976 | list_for_each_entry_reverse(work, &slow_work_queue, link) { | ||
977 | if (work->owner == module) { | ||
978 | set_current_state(TASK_UNINTERRUPTIBLE); | ||
979 | slow_work_unreg_work_item = work; | ||
980 | goto do_wait; | ||
981 | } | ||
982 | } | ||
983 | |||
984 | /* then we wait for the items being processed to finish */ | ||
985 | slow_work_unreg_module = module; | ||
986 | smp_mb(); | ||
987 | for (loop = 0; loop < SLOW_WORK_THREAD_LIMIT; loop++) { | ||
988 | if (slow_work_thread_processing[loop] == module) | ||
989 | goto do_wait; | ||
990 | } | ||
991 | spin_unlock_irq(&slow_work_queue_lock); | ||
992 | break; /* okay, we're done */ | ||
993 | |||
994 | do_wait: | ||
995 | spin_unlock_irq(&slow_work_queue_lock); | ||
996 | schedule(); | ||
997 | slow_work_unreg_work_item = NULL; | ||
998 | slow_work_unreg_module = NULL; | ||
999 | } | ||
1000 | |||
1001 | remove_wait_queue(&slow_work_unreg_wq, &myself); | ||
1002 | mutex_unlock(&slow_work_unreg_sync_lock); | ||
1003 | #endif /* CONFIG_MODULES */ | ||
1004 | } | ||
1005 | |||
601 | /** | 1006 | /** |
602 | * slow_work_unregister_user - Unregister a user of the facility | 1007 | * slow_work_unregister_user - Unregister a user of the facility |
1008 | * @module: The module whose items should be cleared | ||
603 | * | 1009 | * |
604 | * Unregister a user of the facility, killing all the threads if this was the | 1010 | * Unregister a user of the facility, killing all the threads if this was the |
605 | * last one. | 1011 | * last one. |
1012 | * | ||
1013 | * This waits for all the work items belonging to the nominated module to go | ||
1014 | * away before proceeding. | ||
606 | */ | 1015 | */ |
607 | void slow_work_unregister_user(void) | 1016 | void slow_work_unregister_user(struct module *module) |
608 | { | 1017 | { |
1018 | /* first of all, wait for all outstanding items from the calling module | ||
1019 | * to complete */ | ||
1020 | if (module) | ||
1021 | slow_work_wait_for_items(module); | ||
1022 | |||
1023 | /* then we can actually go about shutting down the facility if need | ||
1024 | * be */ | ||
609 | mutex_lock(&slow_work_user_lock); | 1025 | mutex_lock(&slow_work_user_lock); |
610 | 1026 | ||
611 | BUG_ON(slow_work_user_count <= 0); | 1027 | BUG_ON(slow_work_user_count <= 0); |
@@ -639,6 +1055,16 @@ static int __init init_slow_work(void) | |||
639 | if (slow_work_max_max_threads < nr_cpus * 2) | 1055 | if (slow_work_max_max_threads < nr_cpus * 2) |
640 | slow_work_max_max_threads = nr_cpus * 2; | 1056 | slow_work_max_max_threads = nr_cpus * 2; |
641 | #endif | 1057 | #endif |
1058 | #ifdef CONFIG_SLOW_WORK_DEBUG | ||
1059 | { | ||
1060 | struct dentry *dbdir; | ||
1061 | |||
1062 | dbdir = debugfs_create_dir("slow_work", NULL); | ||
1063 | if (dbdir && !IS_ERR(dbdir)) | ||
1064 | debugfs_create_file("runqueue", S_IFREG | 0400, dbdir, | ||
1065 | NULL, &slow_work_runqueue_fops); | ||
1066 | } | ||
1067 | #endif | ||
642 | return 0; | 1068 | return 0; |
643 | } | 1069 | } |
644 | 1070 | ||
diff --git a/kernel/slow-work.h b/kernel/slow-work.h new file mode 100644 index 000000000000..321f3c59d732 --- /dev/null +++ b/kernel/slow-work.h | |||
@@ -0,0 +1,72 @@ | |||
1 | /* Slow work private definitions | ||
2 | * | ||
3 | * Copyright (C) 2009 Red Hat, Inc. All Rights Reserved. | ||
4 | * Written by David Howells (dhowells@redhat.com) | ||
5 | * | ||
6 | * This program is free software; you can redistribute it and/or | ||
7 | * modify it under the terms of the GNU General Public Licence | ||
8 | * as published by the Free Software Foundation; either version | ||
9 | * 2 of the Licence, or (at your option) any later version. | ||
10 | */ | ||
11 | |||
12 | #define SLOW_WORK_CULL_TIMEOUT (5 * HZ) /* cull threads 5s after running out of | ||
13 | * things to do */ | ||
14 | #define SLOW_WORK_OOM_TIMEOUT (5 * HZ) /* can't start new threads for 5s after | ||
15 | * OOM */ | ||
16 | |||
17 | #define SLOW_WORK_THREAD_LIMIT 255 /* abs maximum number of slow-work threads */ | ||
18 | |||
19 | /* | ||
20 | * slow-work.c | ||
21 | */ | ||
22 | #ifdef CONFIG_SLOW_WORK_DEBUG | ||
23 | extern struct slow_work *slow_work_execs[]; | ||
24 | extern pid_t slow_work_pids[]; | ||
25 | extern rwlock_t slow_work_execs_lock; | ||
26 | #endif | ||
27 | |||
28 | extern struct list_head slow_work_queue; | ||
29 | extern struct list_head vslow_work_queue; | ||
30 | extern spinlock_t slow_work_queue_lock; | ||
31 | |||
32 | /* | ||
33 | * slow-work-debugfs.c | ||
34 | */ | ||
35 | #ifdef CONFIG_SLOW_WORK_DEBUG | ||
36 | extern const struct file_operations slow_work_runqueue_fops; | ||
37 | |||
38 | extern void slow_work_new_thread_desc(struct slow_work *, struct seq_file *); | ||
39 | #endif | ||
40 | |||
41 | /* | ||
42 | * Helper functions | ||
43 | */ | ||
44 | static inline void slow_work_set_thread_pid(int id, pid_t pid) | ||
45 | { | ||
46 | #ifdef CONFIG_SLOW_WORK_PROC | ||
47 | slow_work_pids[id] = pid; | ||
48 | #endif | ||
49 | } | ||
50 | |||
51 | static inline void slow_work_mark_time(struct slow_work *work) | ||
52 | { | ||
53 | #ifdef CONFIG_SLOW_WORK_PROC | ||
54 | work->mark = CURRENT_TIME; | ||
55 | #endif | ||
56 | } | ||
57 | |||
58 | static inline void slow_work_begin_exec(int id, struct slow_work *work) | ||
59 | { | ||
60 | #ifdef CONFIG_SLOW_WORK_PROC | ||
61 | slow_work_execs[id] = work; | ||
62 | #endif | ||
63 | } | ||
64 | |||
65 | static inline void slow_work_end_exec(int id, struct slow_work *work) | ||
66 | { | ||
67 | #ifdef CONFIG_SLOW_WORK_PROC | ||
68 | write_lock(&slow_work_execs_lock); | ||
69 | slow_work_execs[id] = NULL; | ||
70 | write_unlock(&slow_work_execs_lock); | ||
71 | #endif | ||
72 | } | ||
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 9c451a1930b6..6dc4e5ef7a01 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c | |||
@@ -2222,15 +2222,15 @@ ftrace_regex_write(struct file *file, const char __user *ubuf, | |||
2222 | ret = ftrace_process_regex(parser->buffer, | 2222 | ret = ftrace_process_regex(parser->buffer, |
2223 | parser->idx, enable); | 2223 | parser->idx, enable); |
2224 | if (ret) | 2224 | if (ret) |
2225 | goto out; | 2225 | goto out_unlock; |
2226 | 2226 | ||
2227 | trace_parser_clear(parser); | 2227 | trace_parser_clear(parser); |
2228 | } | 2228 | } |
2229 | 2229 | ||
2230 | ret = read; | 2230 | ret = read; |
2231 | 2231 | out_unlock: | |
2232 | mutex_unlock(&ftrace_regex_lock); | 2232 | mutex_unlock(&ftrace_regex_lock); |
2233 | out: | 2233 | |
2234 | return ret; | 2234 | return ret; |
2235 | } | 2235 | } |
2236 | 2236 | ||
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 3ffa502fb243..5dd017fea6f5 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c | |||
@@ -1193,6 +1193,7 @@ rb_remove_pages(struct ring_buffer_per_cpu *cpu_buffer, unsigned nr_pages) | |||
1193 | atomic_inc(&cpu_buffer->record_disabled); | 1193 | atomic_inc(&cpu_buffer->record_disabled); |
1194 | synchronize_sched(); | 1194 | synchronize_sched(); |
1195 | 1195 | ||
1196 | spin_lock_irq(&cpu_buffer->reader_lock); | ||
1196 | rb_head_page_deactivate(cpu_buffer); | 1197 | rb_head_page_deactivate(cpu_buffer); |
1197 | 1198 | ||
1198 | for (i = 0; i < nr_pages; i++) { | 1199 | for (i = 0; i < nr_pages; i++) { |
@@ -1207,6 +1208,7 @@ rb_remove_pages(struct ring_buffer_per_cpu *cpu_buffer, unsigned nr_pages) | |||
1207 | return; | 1208 | return; |
1208 | 1209 | ||
1209 | rb_reset_cpu(cpu_buffer); | 1210 | rb_reset_cpu(cpu_buffer); |
1211 | spin_unlock_irq(&cpu_buffer->reader_lock); | ||
1210 | 1212 | ||
1211 | rb_check_pages(cpu_buffer); | 1213 | rb_check_pages(cpu_buffer); |
1212 | 1214 | ||
diff --git a/kernel/user.c b/kernel/user.c index 2c000e7132ac..46d0165ca70c 100644 --- a/kernel/user.c +++ b/kernel/user.c | |||
@@ -330,9 +330,9 @@ done: | |||
330 | */ | 330 | */ |
331 | static void free_user(struct user_struct *up, unsigned long flags) | 331 | static void free_user(struct user_struct *up, unsigned long flags) |
332 | { | 332 | { |
333 | spin_unlock_irqrestore(&uidhash_lock, flags); | ||
334 | INIT_DELAYED_WORK(&up->work, cleanup_user_struct); | 333 | INIT_DELAYED_WORK(&up->work, cleanup_user_struct); |
335 | schedule_delayed_work(&up->work, msecs_to_jiffies(1000)); | 334 | schedule_delayed_work(&up->work, msecs_to_jiffies(1000)); |
335 | spin_unlock_irqrestore(&uidhash_lock, flags); | ||
336 | } | 336 | } |
337 | 337 | ||
338 | #else /* CONFIG_USER_SCHED && CONFIG_SYSFS */ | 338 | #else /* CONFIG_USER_SCHED && CONFIG_SYSFS */ |
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 12328147132c..67e526b6ae81 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c | |||
@@ -692,31 +692,29 @@ int schedule_on_each_cpu(work_func_t func) | |||
692 | if (!works) | 692 | if (!works) |
693 | return -ENOMEM; | 693 | return -ENOMEM; |
694 | 694 | ||
695 | get_online_cpus(); | ||
696 | |||
695 | /* | 697 | /* |
696 | * when running in keventd don't schedule a work item on itself. | 698 | * When running in keventd don't schedule a work item on |
697 | * Can just call directly because the work queue is already bound. | 699 | * itself. Can just call directly because the work queue is |
698 | * This also is faster. | 700 | * already bound. This also is faster. |
699 | * Make this a generic parameter for other workqueues? | ||
700 | */ | 701 | */ |
701 | if (current_is_keventd()) { | 702 | if (current_is_keventd()) |
702 | orig = raw_smp_processor_id(); | 703 | orig = raw_smp_processor_id(); |
703 | INIT_WORK(per_cpu_ptr(works, orig), func); | ||
704 | func(per_cpu_ptr(works, orig)); | ||
705 | } | ||
706 | 704 | ||
707 | get_online_cpus(); | ||
708 | for_each_online_cpu(cpu) { | 705 | for_each_online_cpu(cpu) { |
709 | struct work_struct *work = per_cpu_ptr(works, cpu); | 706 | struct work_struct *work = per_cpu_ptr(works, cpu); |
710 | 707 | ||
711 | if (cpu == orig) | ||
712 | continue; | ||
713 | INIT_WORK(work, func); | 708 | INIT_WORK(work, func); |
714 | schedule_work_on(cpu, work); | ||
715 | } | ||
716 | for_each_online_cpu(cpu) { | ||
717 | if (cpu != orig) | 709 | if (cpu != orig) |
718 | flush_work(per_cpu_ptr(works, cpu)); | 710 | schedule_work_on(cpu, work); |
719 | } | 711 | } |
712 | if (orig >= 0) | ||
713 | func(per_cpu_ptr(works, orig)); | ||
714 | |||
715 | for_each_online_cpu(cpu) | ||
716 | flush_work(per_cpu_ptr(works, cpu)); | ||
717 | |||
720 | put_online_cpus(); | 718 | put_online_cpus(); |
721 | free_percpu(works); | 719 | free_percpu(works); |
722 | return 0; | 720 | return 0; |