diff options
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/debug/kdb/kdb_private.h | 7 | ||||
| -rw-r--r-- | kernel/debug/kdb/kdb_support.c | 4 | ||||
| -rw-r--r-- | kernel/exit.c | 5 | ||||
| -rw-r--r-- | kernel/fork.c | 17 | ||||
| -rw-r--r-- | kernel/kfifo.c | 9 | ||||
| -rw-r--r-- | kernel/kmod.c | 4 | ||||
| -rw-r--r-- | kernel/trace/ring_buffer.c | 3 | ||||
| -rw-r--r-- | kernel/trace/trace.c | 11 | ||||
| -rw-r--r-- | kernel/trace/trace_events.c | 207 | ||||
| -rw-r--r-- | kernel/trace/trace_functions_graph.c | 10 |
10 files changed, 196 insertions, 81 deletions
diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h index c438f545a321..be775f7e81e0 100644 --- a/kernel/debug/kdb/kdb_private.h +++ b/kernel/debug/kdb/kdb_private.h | |||
| @@ -255,7 +255,14 @@ extern void kdb_ps1(const struct task_struct *p); | |||
| 255 | extern void kdb_print_nameval(const char *name, unsigned long val); | 255 | extern void kdb_print_nameval(const char *name, unsigned long val); |
| 256 | extern void kdb_send_sig_info(struct task_struct *p, struct siginfo *info); | 256 | extern void kdb_send_sig_info(struct task_struct *p, struct siginfo *info); |
| 257 | extern void kdb_meminfo_proc_show(void); | 257 | extern void kdb_meminfo_proc_show(void); |
| 258 | #ifdef CONFIG_KALLSYMS | ||
| 258 | extern const char *kdb_walk_kallsyms(loff_t *pos); | 259 | extern const char *kdb_walk_kallsyms(loff_t *pos); |
| 260 | #else /* ! CONFIG_KALLSYMS */ | ||
| 261 | static inline const char *kdb_walk_kallsyms(loff_t *pos) | ||
| 262 | { | ||
| 263 | return NULL; | ||
| 264 | } | ||
| 265 | #endif /* ! CONFIG_KALLSYMS */ | ||
| 259 | extern char *kdb_getstr(char *, size_t, char *); | 266 | extern char *kdb_getstr(char *, size_t, char *); |
| 260 | 267 | ||
| 261 | /* Defines for kdb_symbol_print */ | 268 | /* Defines for kdb_symbol_print */ |
diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c index 45344d5c53dd..6b2485dcb050 100644 --- a/kernel/debug/kdb/kdb_support.c +++ b/kernel/debug/kdb/kdb_support.c | |||
| @@ -82,8 +82,8 @@ static char *kdb_name_table[100]; /* arbitrary size */ | |||
| 82 | int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab) | 82 | int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab) |
| 83 | { | 83 | { |
| 84 | int ret = 0; | 84 | int ret = 0; |
| 85 | unsigned long symbolsize; | 85 | unsigned long symbolsize = 0; |
| 86 | unsigned long offset; | 86 | unsigned long offset = 0; |
| 87 | #define knt1_size 128 /* must be >= kallsyms table size */ | 87 | #define knt1_size 128 /* must be >= kallsyms table size */ |
| 88 | char *knt1 = NULL; | 88 | char *knt1 = NULL; |
| 89 | 89 | ||
diff --git a/kernel/exit.c b/kernel/exit.c index 671ed56e0a49..03120229db28 100644 --- a/kernel/exit.c +++ b/kernel/exit.c | |||
| @@ -1386,8 +1386,7 @@ static int wait_task_stopped(struct wait_opts *wo, | |||
| 1386 | if (!unlikely(wo->wo_flags & WNOWAIT)) | 1386 | if (!unlikely(wo->wo_flags & WNOWAIT)) |
| 1387 | *p_code = 0; | 1387 | *p_code = 0; |
| 1388 | 1388 | ||
| 1389 | /* don't need the RCU readlock here as we're holding a spinlock */ | 1389 | uid = task_uid(p); |
| 1390 | uid = __task_cred(p)->uid; | ||
| 1391 | unlock_sig: | 1390 | unlock_sig: |
| 1392 | spin_unlock_irq(&p->sighand->siglock); | 1391 | spin_unlock_irq(&p->sighand->siglock); |
| 1393 | if (!exit_code) | 1392 | if (!exit_code) |
| @@ -1460,7 +1459,7 @@ static int wait_task_continued(struct wait_opts *wo, struct task_struct *p) | |||
| 1460 | } | 1459 | } |
| 1461 | if (!unlikely(wo->wo_flags & WNOWAIT)) | 1460 | if (!unlikely(wo->wo_flags & WNOWAIT)) |
| 1462 | p->signal->flags &= ~SIGNAL_STOP_CONTINUED; | 1461 | p->signal->flags &= ~SIGNAL_STOP_CONTINUED; |
| 1463 | uid = __task_cred(p)->uid; | 1462 | uid = task_uid(p); |
| 1464 | spin_unlock_irq(&p->sighand->siglock); | 1463 | spin_unlock_irq(&p->sighand->siglock); |
| 1465 | 1464 | ||
| 1466 | pid = task_pid_vnr(p); | 1465 | pid = task_pid_vnr(p); |
diff --git a/kernel/fork.c b/kernel/fork.c index 98b450876f93..b7e9d60a675d 100644 --- a/kernel/fork.c +++ b/kernel/fork.c | |||
| @@ -300,7 +300,7 @@ out: | |||
| 300 | #ifdef CONFIG_MMU | 300 | #ifdef CONFIG_MMU |
| 301 | static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm) | 301 | static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm) |
| 302 | { | 302 | { |
| 303 | struct vm_area_struct *mpnt, *tmp, **pprev; | 303 | struct vm_area_struct *mpnt, *tmp, *prev, **pprev; |
| 304 | struct rb_node **rb_link, *rb_parent; | 304 | struct rb_node **rb_link, *rb_parent; |
| 305 | int retval; | 305 | int retval; |
| 306 | unsigned long charge; | 306 | unsigned long charge; |
| @@ -328,6 +328,7 @@ static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm) | |||
| 328 | if (retval) | 328 | if (retval) |
| 329 | goto out; | 329 | goto out; |
| 330 | 330 | ||
| 331 | prev = NULL; | ||
| 331 | for (mpnt = oldmm->mmap; mpnt; mpnt = mpnt->vm_next) { | 332 | for (mpnt = oldmm->mmap; mpnt; mpnt = mpnt->vm_next) { |
| 332 | struct file *file; | 333 | struct file *file; |
| 333 | 334 | ||
| @@ -359,7 +360,7 @@ static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm) | |||
| 359 | goto fail_nomem_anon_vma_fork; | 360 | goto fail_nomem_anon_vma_fork; |
| 360 | tmp->vm_flags &= ~VM_LOCKED; | 361 | tmp->vm_flags &= ~VM_LOCKED; |
| 361 | tmp->vm_mm = mm; | 362 | tmp->vm_mm = mm; |
| 362 | tmp->vm_next = NULL; | 363 | tmp->vm_next = tmp->vm_prev = NULL; |
| 363 | file = tmp->vm_file; | 364 | file = tmp->vm_file; |
| 364 | if (file) { | 365 | if (file) { |
| 365 | struct inode *inode = file->f_path.dentry->d_inode; | 366 | struct inode *inode = file->f_path.dentry->d_inode; |
| @@ -392,6 +393,8 @@ static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm) | |||
| 392 | */ | 393 | */ |
| 393 | *pprev = tmp; | 394 | *pprev = tmp; |
| 394 | pprev = &tmp->vm_next; | 395 | pprev = &tmp->vm_next; |
| 396 | tmp->vm_prev = prev; | ||
| 397 | prev = tmp; | ||
| 395 | 398 | ||
| 396 | __vma_link_rb(mm, tmp, rb_link, rb_parent); | 399 | __vma_link_rb(mm, tmp, rb_link, rb_parent); |
| 397 | rb_link = &tmp->vm_rb.rb_right; | 400 | rb_link = &tmp->vm_rb.rb_right; |
| @@ -752,13 +755,13 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk) | |||
| 752 | struct fs_struct *fs = current->fs; | 755 | struct fs_struct *fs = current->fs; |
| 753 | if (clone_flags & CLONE_FS) { | 756 | if (clone_flags & CLONE_FS) { |
| 754 | /* tsk->fs is already what we want */ | 757 | /* tsk->fs is already what we want */ |
| 755 | write_lock(&fs->lock); | 758 | spin_lock(&fs->lock); |
| 756 | if (fs->in_exec) { | 759 | if (fs->in_exec) { |
| 757 | write_unlock(&fs->lock); | 760 | spin_unlock(&fs->lock); |
| 758 | return -EAGAIN; | 761 | return -EAGAIN; |
| 759 | } | 762 | } |
| 760 | fs->users++; | 763 | fs->users++; |
| 761 | write_unlock(&fs->lock); | 764 | spin_unlock(&fs->lock); |
| 762 | return 0; | 765 | return 0; |
| 763 | } | 766 | } |
| 764 | tsk->fs = copy_fs_struct(fs); | 767 | tsk->fs = copy_fs_struct(fs); |
| @@ -1676,13 +1679,13 @@ SYSCALL_DEFINE1(unshare, unsigned long, unshare_flags) | |||
| 1676 | 1679 | ||
| 1677 | if (new_fs) { | 1680 | if (new_fs) { |
| 1678 | fs = current->fs; | 1681 | fs = current->fs; |
| 1679 | write_lock(&fs->lock); | 1682 | spin_lock(&fs->lock); |
| 1680 | current->fs = new_fs; | 1683 | current->fs = new_fs; |
| 1681 | if (--fs->users) | 1684 | if (--fs->users) |
| 1682 | new_fs = NULL; | 1685 | new_fs = NULL; |
| 1683 | else | 1686 | else |
| 1684 | new_fs = fs; | 1687 | new_fs = fs; |
| 1685 | write_unlock(&fs->lock); | 1688 | spin_unlock(&fs->lock); |
| 1686 | } | 1689 | } |
| 1687 | 1690 | ||
| 1688 | if (new_mm) { | 1691 | if (new_mm) { |
diff --git a/kernel/kfifo.c b/kernel/kfifo.c index 4502604ecadf..6b5580c57644 100644 --- a/kernel/kfifo.c +++ b/kernel/kfifo.c | |||
| @@ -503,6 +503,15 @@ unsigned int __kfifo_out_r(struct __kfifo *fifo, void *buf, | |||
| 503 | } | 503 | } |
| 504 | EXPORT_SYMBOL(__kfifo_out_r); | 504 | EXPORT_SYMBOL(__kfifo_out_r); |
| 505 | 505 | ||
| 506 | void __kfifo_skip_r(struct __kfifo *fifo, size_t recsize) | ||
| 507 | { | ||
| 508 | unsigned int n; | ||
| 509 | |||
| 510 | n = __kfifo_peek_n(fifo, recsize); | ||
| 511 | fifo->out += n + recsize; | ||
| 512 | } | ||
| 513 | EXPORT_SYMBOL(__kfifo_skip_r); | ||
| 514 | |||
| 506 | int __kfifo_from_user_r(struct __kfifo *fifo, const void __user *from, | 515 | int __kfifo_from_user_r(struct __kfifo *fifo, const void __user *from, |
| 507 | unsigned long len, unsigned int *copied, size_t recsize) | 516 | unsigned long len, unsigned int *copied, size_t recsize) |
| 508 | { | 517 | { |
diff --git a/kernel/kmod.c b/kernel/kmod.c index 6e9b19667a8d..9cd0591c96a2 100644 --- a/kernel/kmod.c +++ b/kernel/kmod.c | |||
| @@ -153,7 +153,9 @@ static int ____call_usermodehelper(void *data) | |||
| 153 | goto fail; | 153 | goto fail; |
| 154 | } | 154 | } |
| 155 | 155 | ||
| 156 | retval = kernel_execve(sub_info->path, sub_info->argv, sub_info->envp); | 156 | retval = kernel_execve(sub_info->path, |
| 157 | (const char *const *)sub_info->argv, | ||
| 158 | (const char *const *)sub_info->envp); | ||
| 157 | 159 | ||
| 158 | /* Exec failed? */ | 160 | /* Exec failed? */ |
| 159 | fail: | 161 | fail: |
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 3632ce87674f..19cccc3c3028 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c | |||
| @@ -3846,6 +3846,9 @@ int ring_buffer_read_page(struct ring_buffer *buffer, | |||
| 3846 | rpos = reader->read; | 3846 | rpos = reader->read; |
| 3847 | pos += size; | 3847 | pos += size; |
| 3848 | 3848 | ||
| 3849 | if (rpos >= commit) | ||
| 3850 | break; | ||
| 3851 | |||
| 3849 | event = rb_reader_event(cpu_buffer); | 3852 | event = rb_reader_event(cpu_buffer); |
| 3850 | size = rb_event_length(event); | 3853 | size = rb_event_length(event); |
| 3851 | } while (len > size); | 3854 | } while (len > size); |
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index ba14a22be4cc..9ec59f541156 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
| @@ -3463,6 +3463,7 @@ tracing_mark_write(struct file *filp, const char __user *ubuf, | |||
| 3463 | size_t cnt, loff_t *fpos) | 3463 | size_t cnt, loff_t *fpos) |
| 3464 | { | 3464 | { |
| 3465 | char *buf; | 3465 | char *buf; |
| 3466 | size_t written; | ||
| 3466 | 3467 | ||
| 3467 | if (tracing_disabled) | 3468 | if (tracing_disabled) |
| 3468 | return -EINVAL; | 3469 | return -EINVAL; |
| @@ -3484,11 +3485,15 @@ tracing_mark_write(struct file *filp, const char __user *ubuf, | |||
| 3484 | } else | 3485 | } else |
| 3485 | buf[cnt] = '\0'; | 3486 | buf[cnt] = '\0'; |
| 3486 | 3487 | ||
| 3487 | cnt = mark_printk("%s", buf); | 3488 | written = mark_printk("%s", buf); |
| 3488 | kfree(buf); | 3489 | kfree(buf); |
| 3489 | *fpos += cnt; | 3490 | *fpos += written; |
| 3490 | 3491 | ||
| 3491 | return cnt; | 3492 | /* don't tell userspace we wrote more - it might confuse them */ |
| 3493 | if (written > cnt) | ||
| 3494 | written = cnt; | ||
| 3495 | |||
| 3496 | return written; | ||
| 3492 | } | 3497 | } |
| 3493 | 3498 | ||
| 3494 | static int tracing_clock_show(struct seq_file *m, void *v) | 3499 | static int tracing_clock_show(struct seq_file *m, void *v) |
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 09b4fa6e4d3b..4c758f146328 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c | |||
| @@ -598,88 +598,165 @@ out: | |||
| 598 | return ret; | 598 | return ret; |
| 599 | } | 599 | } |
| 600 | 600 | ||
| 601 | static void print_event_fields(struct trace_seq *s, struct list_head *head) | 601 | enum { |
| 602 | FORMAT_HEADER = 1, | ||
| 603 | FORMAT_PRINTFMT = 2, | ||
| 604 | }; | ||
| 605 | |||
| 606 | static void *f_next(struct seq_file *m, void *v, loff_t *pos) | ||
| 602 | { | 607 | { |
| 608 | struct ftrace_event_call *call = m->private; | ||
| 603 | struct ftrace_event_field *field; | 609 | struct ftrace_event_field *field; |
| 610 | struct list_head *head; | ||
| 604 | 611 | ||
| 605 | list_for_each_entry_reverse(field, head, link) { | 612 | (*pos)++; |
| 606 | /* | ||
| 607 | * Smartly shows the array type(except dynamic array). | ||
| 608 | * Normal: | ||
| 609 | * field:TYPE VAR | ||
| 610 | * If TYPE := TYPE[LEN], it is shown: | ||
| 611 | * field:TYPE VAR[LEN] | ||
| 612 | */ | ||
| 613 | const char *array_descriptor = strchr(field->type, '['); | ||
| 614 | 613 | ||
| 615 | if (!strncmp(field->type, "__data_loc", 10)) | 614 | switch ((unsigned long)v) { |
| 616 | array_descriptor = NULL; | 615 | case FORMAT_HEADER: |
| 616 | head = &ftrace_common_fields; | ||
| 617 | 617 | ||
| 618 | if (!array_descriptor) { | 618 | if (unlikely(list_empty(head))) |
| 619 | trace_seq_printf(s, "\tfield:%s %s;\toffset:%u;" | 619 | return NULL; |
| 620 | "\tsize:%u;\tsigned:%d;\n", | 620 | |
| 621 | field->type, field->name, field->offset, | 621 | field = list_entry(head->prev, struct ftrace_event_field, link); |
| 622 | field->size, !!field->is_signed); | 622 | return field; |
| 623 | } else { | 623 | |
| 624 | trace_seq_printf(s, "\tfield:%.*s %s%s;\toffset:%u;" | 624 | case FORMAT_PRINTFMT: |
| 625 | "\tsize:%u;\tsigned:%d;\n", | 625 | /* all done */ |
| 626 | (int)(array_descriptor - field->type), | 626 | return NULL; |
| 627 | field->type, field->name, | 627 | } |
| 628 | array_descriptor, field->offset, | 628 | |
| 629 | field->size, !!field->is_signed); | 629 | head = trace_get_fields(call); |
| 630 | } | 630 | |
| 631 | /* | ||
| 632 | * To separate common fields from event fields, the | ||
| 633 | * LSB is set on the first event field. Clear it in case. | ||
| 634 | */ | ||
| 635 | v = (void *)((unsigned long)v & ~1L); | ||
| 636 | |||
| 637 | field = v; | ||
| 638 | /* | ||
| 639 | * If this is a common field, and at the end of the list, then | ||
| 640 | * continue with main list. | ||
| 641 | */ | ||
| 642 | if (field->link.prev == &ftrace_common_fields) { | ||
| 643 | if (unlikely(list_empty(head))) | ||
| 644 | return NULL; | ||
| 645 | field = list_entry(head->prev, struct ftrace_event_field, link); | ||
| 646 | /* Set the LSB to notify f_show to print an extra newline */ | ||
| 647 | field = (struct ftrace_event_field *) | ||
| 648 | ((unsigned long)field | 1); | ||
| 649 | return field; | ||
| 631 | } | 650 | } |
| 651 | |||
| 652 | /* If we are done tell f_show to print the format */ | ||
| 653 | if (field->link.prev == head) | ||
| 654 | return (void *)FORMAT_PRINTFMT; | ||
| 655 | |||
| 656 | field = list_entry(field->link.prev, struct ftrace_event_field, link); | ||
| 657 | |||
| 658 | return field; | ||
| 632 | } | 659 | } |
| 633 | 660 | ||
| 634 | static ssize_t | 661 | static void *f_start(struct seq_file *m, loff_t *pos) |
| 635 | event_format_read(struct file *filp, char __user *ubuf, size_t cnt, | ||
| 636 | loff_t *ppos) | ||
| 637 | { | 662 | { |
| 638 | struct ftrace_event_call *call = filp->private_data; | 663 | loff_t l = 0; |
| 639 | struct list_head *head; | 664 | void *p; |
| 640 | struct trace_seq *s; | ||
| 641 | char *buf; | ||
| 642 | int r; | ||
| 643 | 665 | ||
| 644 | if (*ppos) | 666 | /* Start by showing the header */ |
| 667 | if (!*pos) | ||
| 668 | return (void *)FORMAT_HEADER; | ||
| 669 | |||
| 670 | p = (void *)FORMAT_HEADER; | ||
| 671 | do { | ||
| 672 | p = f_next(m, p, &l); | ||
| 673 | } while (p && l < *pos); | ||
| 674 | |||
| 675 | return p; | ||
| 676 | } | ||
| 677 | |||
| 678 | static int f_show(struct seq_file *m, void *v) | ||
| 679 | { | ||
| 680 | struct ftrace_event_call *call = m->private; | ||
| 681 | struct ftrace_event_field *field; | ||
| 682 | const char *array_descriptor; | ||
| 683 | |||
| 684 | switch ((unsigned long)v) { | ||
| 685 | case FORMAT_HEADER: | ||
| 686 | seq_printf(m, "name: %s\n", call->name); | ||
| 687 | seq_printf(m, "ID: %d\n", call->event.type); | ||
| 688 | seq_printf(m, "format:\n"); | ||
| 645 | return 0; | 689 | return 0; |
| 646 | 690 | ||
| 647 | s = kmalloc(sizeof(*s), GFP_KERNEL); | 691 | case FORMAT_PRINTFMT: |
| 648 | if (!s) | 692 | seq_printf(m, "\nprint fmt: %s\n", |
| 649 | return -ENOMEM; | 693 | call->print_fmt); |
| 694 | return 0; | ||
| 695 | } | ||
| 650 | 696 | ||
| 651 | trace_seq_init(s); | 697 | /* |
| 698 | * To separate common fields from event fields, the | ||
| 699 | * LSB is set on the first event field. Clear it and | ||
| 700 | * print a newline if it is set. | ||
| 701 | */ | ||
| 702 | if ((unsigned long)v & 1) { | ||
| 703 | seq_putc(m, '\n'); | ||
| 704 | v = (void *)((unsigned long)v & ~1L); | ||
| 705 | } | ||
| 652 | 706 | ||
| 653 | trace_seq_printf(s, "name: %s\n", call->name); | 707 | field = v; |
| 654 | trace_seq_printf(s, "ID: %d\n", call->event.type); | ||
| 655 | trace_seq_printf(s, "format:\n"); | ||
| 656 | 708 | ||
| 657 | /* print common fields */ | 709 | /* |
| 658 | print_event_fields(s, &ftrace_common_fields); | 710 | * Smartly shows the array type(except dynamic array). |
| 711 | * Normal: | ||
| 712 | * field:TYPE VAR | ||
| 713 | * If TYPE := TYPE[LEN], it is shown: | ||
| 714 | * field:TYPE VAR[LEN] | ||
| 715 | */ | ||
| 716 | array_descriptor = strchr(field->type, '['); | ||
| 659 | 717 | ||
| 660 | trace_seq_putc(s, '\n'); | 718 | if (!strncmp(field->type, "__data_loc", 10)) |
| 719 | array_descriptor = NULL; | ||
| 661 | 720 | ||
| 662 | /* print event specific fields */ | 721 | if (!array_descriptor) |
| 663 | head = trace_get_fields(call); | 722 | seq_printf(m, "\tfield:%s %s;\toffset:%u;\tsize:%u;\tsigned:%d;\n", |
| 664 | print_event_fields(s, head); | 723 | field->type, field->name, field->offset, |
| 724 | field->size, !!field->is_signed); | ||
| 725 | else | ||
| 726 | seq_printf(m, "\tfield:%.*s %s%s;\toffset:%u;\tsize:%u;\tsigned:%d;\n", | ||
| 727 | (int)(array_descriptor - field->type), | ||
| 728 | field->type, field->name, | ||
| 729 | array_descriptor, field->offset, | ||
| 730 | field->size, !!field->is_signed); | ||
| 665 | 731 | ||
| 666 | r = trace_seq_printf(s, "\nprint fmt: %s\n", call->print_fmt); | 732 | return 0; |
| 733 | } | ||
| 667 | 734 | ||
| 668 | if (!r) { | 735 | static void f_stop(struct seq_file *m, void *p) |
| 669 | /* | 736 | { |
| 670 | * ug! The format output is bigger than a PAGE!! | 737 | } |
| 671 | */ | ||
| 672 | buf = "FORMAT TOO BIG\n"; | ||
| 673 | r = simple_read_from_buffer(ubuf, cnt, ppos, | ||
| 674 | buf, strlen(buf)); | ||
| 675 | goto out; | ||
| 676 | } | ||
| 677 | 738 | ||
| 678 | r = simple_read_from_buffer(ubuf, cnt, ppos, | 739 | static const struct seq_operations trace_format_seq_ops = { |
| 679 | s->buffer, s->len); | 740 | .start = f_start, |
| 680 | out: | 741 | .next = f_next, |
| 681 | kfree(s); | 742 | .stop = f_stop, |
| 682 | return r; | 743 | .show = f_show, |
| 744 | }; | ||
| 745 | |||
| 746 | static int trace_format_open(struct inode *inode, struct file *file) | ||
| 747 | { | ||
| 748 | struct ftrace_event_call *call = inode->i_private; | ||
| 749 | struct seq_file *m; | ||
| 750 | int ret; | ||
| 751 | |||
| 752 | ret = seq_open(file, &trace_format_seq_ops); | ||
| 753 | if (ret < 0) | ||
| 754 | return ret; | ||
| 755 | |||
| 756 | m = file->private_data; | ||
| 757 | m->private = call; | ||
| 758 | |||
| 759 | return 0; | ||
| 683 | } | 760 | } |
| 684 | 761 | ||
| 685 | static ssize_t | 762 | static ssize_t |
| @@ -877,8 +954,10 @@ static const struct file_operations ftrace_enable_fops = { | |||
| 877 | }; | 954 | }; |
| 878 | 955 | ||
| 879 | static const struct file_operations ftrace_event_format_fops = { | 956 | static const struct file_operations ftrace_event_format_fops = { |
| 880 | .open = tracing_open_generic, | 957 | .open = trace_format_open, |
| 881 | .read = event_format_read, | 958 | .read = seq_read, |
| 959 | .llseek = seq_lseek, | ||
| 960 | .release = seq_release, | ||
| 882 | }; | 961 | }; |
| 883 | 962 | ||
| 884 | static const struct file_operations ftrace_event_id_fops = { | 963 | static const struct file_operations ftrace_event_id_fops = { |
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c index 6bff23625781..6f233698518e 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c | |||
| @@ -507,7 +507,15 @@ get_return_for_leaf(struct trace_iterator *iter, | |||
| 507 | * if the output fails. | 507 | * if the output fails. |
| 508 | */ | 508 | */ |
| 509 | data->ent = *curr; | 509 | data->ent = *curr; |
| 510 | data->ret = *next; | 510 | /* |
| 511 | * If the next event is not a return type, then | ||
| 512 | * we only care about what type it is. Otherwise we can | ||
| 513 | * safely copy the entire event. | ||
| 514 | */ | ||
| 515 | if (next->ent.type == TRACE_GRAPH_RET) | ||
| 516 | data->ret = *next; | ||
| 517 | else | ||
| 518 | data->ret.ent.type = next->ent.type; | ||
| 511 | } | 519 | } |
| 512 | } | 520 | } |
| 513 | 521 | ||
