aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/workqueue.c
diff options
context:
space:
mode:
Diffstat (limited to 'kernel/workqueue.c')
-rw-r--r--kernel/workqueue.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 5fbffd302eb5..828e58230cbc 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -828,7 +828,7 @@ struct workqueue_struct *__create_workqueue_key(const char *name,
828 err = create_workqueue_thread(cwq, singlethread_cpu); 828 err = create_workqueue_thread(cwq, singlethread_cpu);
829 start_workqueue_thread(cwq, -1); 829 start_workqueue_thread(cwq, -1);
830 } else { 830 } else {
831 get_online_cpus(); 831 cpu_maps_update_begin();
832 spin_lock(&workqueue_lock); 832 spin_lock(&workqueue_lock);
833 list_add(&wq->list, &workqueues); 833 list_add(&wq->list, &workqueues);
834 spin_unlock(&workqueue_lock); 834 spin_unlock(&workqueue_lock);
@@ -840,7 +840,7 @@ struct workqueue_struct *__create_workqueue_key(const char *name,
840 err = create_workqueue_thread(cwq, cpu); 840 err = create_workqueue_thread(cwq, cpu);
841 start_workqueue_thread(cwq, cpu); 841 start_workqueue_thread(cwq, cpu);
842 } 842 }
843 put_online_cpus(); 843 cpu_maps_update_done();
844 } 844 }
845 845
846 if (err) { 846 if (err) {
@@ -854,8 +854,8 @@ EXPORT_SYMBOL_GPL(__create_workqueue_key);
854static void cleanup_workqueue_thread(struct cpu_workqueue_struct *cwq) 854static void cleanup_workqueue_thread(struct cpu_workqueue_struct *cwq)
855{ 855{
856 /* 856 /*
857 * Our caller is either destroy_workqueue() or CPU_DEAD, 857 * Our caller is either destroy_workqueue() or CPU_POST_DEAD,
858 * get_online_cpus() protects cwq->thread. 858 * cpu_add_remove_lock protects cwq->thread.
859 */ 859 */
860 if (cwq->thread == NULL) 860 if (cwq->thread == NULL)
861 return; 861 return;
@@ -865,7 +865,7 @@ static void cleanup_workqueue_thread(struct cpu_workqueue_struct *cwq)
865 865
866 flush_cpu_workqueue(cwq); 866 flush_cpu_workqueue(cwq);
867 /* 867 /*
868 * If the caller is CPU_DEAD and cwq->worklist was not empty, 868 * If the caller is CPU_POST_DEAD and cwq->worklist was not empty,
869 * a concurrent flush_workqueue() can insert a barrier after us. 869 * a concurrent flush_workqueue() can insert a barrier after us.
870 * However, in that case run_workqueue() won't return and check 870 * However, in that case run_workqueue() won't return and check
871 * kthread_should_stop() until it flushes all work_struct's. 871 * kthread_should_stop() until it flushes all work_struct's.
@@ -889,14 +889,14 @@ void destroy_workqueue(struct workqueue_struct *wq)
889 const cpumask_t *cpu_map = wq_cpu_map(wq); 889 const cpumask_t *cpu_map = wq_cpu_map(wq);
890 int cpu; 890 int cpu;
891 891
892 get_online_cpus(); 892 cpu_maps_update_begin();
893 spin_lock(&workqueue_lock); 893 spin_lock(&workqueue_lock);
894 list_del(&wq->list); 894 list_del(&wq->list);
895 spin_unlock(&workqueue_lock); 895 spin_unlock(&workqueue_lock);
896 896
897 for_each_cpu_mask_nr(cpu, *cpu_map) 897 for_each_cpu_mask_nr(cpu, *cpu_map)
898 cleanup_workqueue_thread(per_cpu_ptr(wq->cpu_wq, cpu)); 898 cleanup_workqueue_thread(per_cpu_ptr(wq->cpu_wq, cpu));
899 put_online_cpus(); 899 cpu_maps_update_done();
900 900
901 free_percpu(wq->cpu_wq); 901 free_percpu(wq->cpu_wq);
902 kfree(wq); 902 kfree(wq);
@@ -935,7 +935,7 @@ static int __devinit workqueue_cpu_callback(struct notifier_block *nfb,
935 935
936 case CPU_UP_CANCELED: 936 case CPU_UP_CANCELED:
937 start_workqueue_thread(cwq, -1); 937 start_workqueue_thread(cwq, -1);
938 case CPU_DEAD: 938 case CPU_POST_DEAD:
939 cleanup_workqueue_thread(cwq); 939 cleanup_workqueue_thread(cwq);
940 break; 940 break;
941 } 941 }
@@ -943,7 +943,7 @@ static int __devinit workqueue_cpu_callback(struct notifier_block *nfb,
943 943
944 switch (action) { 944 switch (action) {
945 case CPU_UP_CANCELED: 945 case CPU_UP_CANCELED:
946 case CPU_DEAD: 946 case CPU_POST_DEAD:
947 cpu_clear(cpu, cpu_populated_map); 947 cpu_clear(cpu, cpu_populated_map);
948 } 948 }
949 949