1 files changed, 29 insertions, 18 deletions

diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index b52d397e57eb..6ea90c0e2c96 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -282,6 +282,18 @@ static int kprobe_dispatcher(struct kprobe *kp, struct pt_regs *regs);
 static int kretprobe_dispatcher(struct kretprobe_instance *ri,
                                 struct pt_regs *regs);
 
+/* Check the name is good for event/group */
+static int check_event_name(const char *name)
+{
+        if (!isalpha(*name) && *name != '_')
+                return 0;
+        while (*++name != '\0') {
+                if (!isalpha(*name) && !isdigit(*name) && *name != '_')
+                        return 0;
+        }
+        return 1;
+}
+
 /*
  * Allocate new trace_probe and initialize it (including kprobes).
  */
@@ -293,10 +305,11 @@ static struct trace_probe *alloc_trace_probe(const char *group,
                                              int nargs, int is_return)
 {
         struct trace_probe *tp;
+        int ret = -ENOMEM;
 
         tp = kzalloc(SIZEOF_TRACE_PROBE(nargs), GFP_KERNEL);
         if (!tp)
-                return ERR_PTR(-ENOMEM);
+                return ERR_PTR(ret);
 
         if (symbol) {
                 tp->symbol = kstrdup(symbol, GFP_KERNEL);
@@ -312,14 +325,20 @@ static struct trace_probe *alloc_trace_probe(const char *group,
         else
                 tp->rp.kp.pre_handler = kprobe_dispatcher;
 
-        if (!event)
+        if (!event || !check_event_name(event)) {
+                ret = -EINVAL;
                 goto error;
+        }
+
         tp->call.name = kstrdup(event, GFP_KERNEL);
         if (!tp->call.name)
                 goto error;
 
-        if (!group)
+        if (!group || !check_event_name(group)) {
+                ret = -EINVAL;
                 goto error;
+        }
+
         tp->call.system = kstrdup(group, GFP_KERNEL);
         if (!tp->call.system)
                 goto error;
@@ -330,7 +349,7 @@ error:
         kfree(tp->call.name);
         kfree(tp->symbol);
         kfree(tp);
-        return ERR_PTR(-ENOMEM);
+        return ERR_PTR(ret);
 }
 
 static void free_probe_arg(struct probe_arg *arg)
@@ -695,10 +714,10 @@ static int create_trace_probe(int argc, char **argv)
         if (!event) {
                 /* Make a new event name */
                 if (symbol)
-                        snprintf(buf, MAX_EVENT_NAME_LEN, "%c@%s%+ld",
+                        snprintf(buf, MAX_EVENT_NAME_LEN, "%c_%s_%ld",
                                  is_return ? 'r' : 'p', symbol, offset);
                 else
-                        snprintf(buf, MAX_EVENT_NAME_LEN, "%c@0x%p",
+                        snprintf(buf, MAX_EVENT_NAME_LEN, "%c_0x%p",
                                  is_return ? 'r' : 'p', addr);
                 event = buf;
         }
@@ -1132,10 +1151,6 @@ static int kprobe_event_define_fields(struct ftrace_event_call *event_call)
         struct kprobe_trace_entry field;
         struct trace_probe *tp = (struct trace_probe *)event_call->data;
 
-        ret = trace_define_common_fields(event_call);
-        if (ret)
-                return ret;
-
         DEFINE_FIELD(unsigned long, ip, FIELD_STRING_IP, 0);
         DEFINE_FIELD(int, nargs, FIELD_STRING_NARGS, 1);
         /* Set argument names as fields */
@@ -1150,10 +1165,6 @@ static int kretprobe_event_define_fields(struct ftrace_event_call *event_call)
         struct kretprobe_trace_entry field;
         struct trace_probe *tp = (struct trace_probe *)event_call->data;
 
-        ret = trace_define_common_fields(event_call);
-        if (ret)
-                return ret;
-
         DEFINE_FIELD(unsigned long, func, FIELD_STRING_FUNC, 0);
         DEFINE_FIELD(unsigned long, ret_ip, FIELD_STRING_RETIP, 0);
         DEFINE_FIELD(int, nargs, FIELD_STRING_NARGS, 1);
@@ -1190,10 +1201,11 @@ static int __probe_event_show_format(struct trace_seq *s,
 #undef SHOW_FIELD
 #define SHOW_FIELD(type, item, name)                                    \
         do {                                                            \
-                ret = trace_seq_printf(s, "\tfield: " #type " %s;\t"    \
-                                "offset:%u;\tsize:%u;\n", name,         \
+                ret = trace_seq_printf(s, "\tfield:" #type " %s;\t"     \
+                                "offset:%u;\tsize:%u;\tsigned:%d;\n", name,\
                                 (unsigned int)offsetof(typeof(field), item),\
-                                (unsigned int)sizeof(type));            \
+                                (unsigned int)sizeof(type),             \
+                                is_signed_type(type));                  \
                 if (!ret)                                               \
                         return 0;                                       \
         } while (0)
@@ -1453,7 +1465,6 @@ static int register_probe_event(struct trace_probe *tp)
         call->unregfunc = probe_event_disable;
 
 #ifdef CONFIG_EVENT_PROFILE
-        atomic_set(&call->profile_count, -1);
         call->profile_enable = probe_profile_enable;
         call->profile_disable = probe_profile_disable;
 #endif