diff options
Diffstat (limited to 'kernel/smp.c')
| -rw-r--r-- | kernel/smp.c | 40 |
1 files changed, 34 insertions, 6 deletions
diff --git a/kernel/smp.c b/kernel/smp.c index 94188b8ecc33..8e218500ab14 100644 --- a/kernel/smp.c +++ b/kernel/smp.c | |||
| @@ -177,6 +177,11 @@ void generic_smp_call_function_interrupt(void) | |||
| 177 | int cpu = get_cpu(); | 177 | int cpu = get_cpu(); |
| 178 | 178 | ||
| 179 | /* | 179 | /* |
| 180 | * Shouldn't receive this interrupt on a cpu that is not yet online. | ||
| 181 | */ | ||
| 182 | WARN_ON_ONCE(!cpu_online(cpu)); | ||
| 183 | |||
| 184 | /* | ||
| 180 | * Ensure entry is visible on call_function_queue after we have | 185 | * Ensure entry is visible on call_function_queue after we have |
| 181 | * entered the IPI. See comment in smp_call_function_many. | 186 | * entered the IPI. See comment in smp_call_function_many. |
| 182 | * If we don't have this, then we may miss an entry on the list | 187 | * If we don't have this, then we may miss an entry on the list |
| @@ -230,6 +235,11 @@ void generic_smp_call_function_single_interrupt(void) | |||
| 230 | unsigned int data_flags; | 235 | unsigned int data_flags; |
| 231 | LIST_HEAD(list); | 236 | LIST_HEAD(list); |
| 232 | 237 | ||
| 238 | /* | ||
| 239 | * Shouldn't receive this interrupt on a cpu that is not yet online. | ||
| 240 | */ | ||
| 241 | WARN_ON_ONCE(!cpu_online(smp_processor_id())); | ||
| 242 | |||
| 233 | spin_lock(&q->lock); | 243 | spin_lock(&q->lock); |
| 234 | list_replace_init(&q->list, &list); | 244 | list_replace_init(&q->list, &list); |
| 235 | spin_unlock(&q->lock); | 245 | spin_unlock(&q->lock); |
| @@ -285,8 +295,14 @@ int smp_call_function_single(int cpu, void (*func) (void *info), void *info, | |||
| 285 | */ | 295 | */ |
| 286 | this_cpu = get_cpu(); | 296 | this_cpu = get_cpu(); |
| 287 | 297 | ||
| 288 | /* Can deadlock when called with interrupts disabled */ | 298 | /* |
| 289 | WARN_ON_ONCE(irqs_disabled() && !oops_in_progress); | 299 | * Can deadlock when called with interrupts disabled. |
| 300 | * We allow cpu's that are not yet online though, as no one else can | ||
| 301 | * send smp call function interrupt to this cpu and as such deadlocks | ||
| 302 | * can't happen. | ||
| 303 | */ | ||
| 304 | WARN_ON_ONCE(cpu_online(this_cpu) && irqs_disabled() | ||
| 305 | && !oops_in_progress); | ||
| 290 | 306 | ||
| 291 | if (cpu == this_cpu) { | 307 | if (cpu == this_cpu) { |
| 292 | local_irq_save(flags); | 308 | local_irq_save(flags); |
| @@ -329,8 +345,14 @@ void __smp_call_function_single(int cpu, struct call_single_data *data, | |||
| 329 | { | 345 | { |
| 330 | csd_lock(data); | 346 | csd_lock(data); |
| 331 | 347 | ||
| 332 | /* Can deadlock when called with interrupts disabled */ | 348 | /* |
| 333 | WARN_ON_ONCE(wait && irqs_disabled() && !oops_in_progress); | 349 | * Can deadlock when called with interrupts disabled. |
| 350 | * We allow cpu's that are not yet online though, as no one else can | ||
| 351 | * send smp call function interrupt to this cpu and as such deadlocks | ||
| 352 | * can't happen. | ||
| 353 | */ | ||
| 354 | WARN_ON_ONCE(cpu_online(smp_processor_id()) && wait && irqs_disabled() | ||
| 355 | && !oops_in_progress); | ||
| 334 | 356 | ||
| 335 | generic_exec_single(cpu, data, wait); | 357 | generic_exec_single(cpu, data, wait); |
| 336 | } | 358 | } |
| @@ -365,8 +387,14 @@ void smp_call_function_many(const struct cpumask *mask, | |||
| 365 | unsigned long flags; | 387 | unsigned long flags; |
| 366 | int cpu, next_cpu, this_cpu = smp_processor_id(); | 388 | int cpu, next_cpu, this_cpu = smp_processor_id(); |
| 367 | 389 | ||
| 368 | /* Can deadlock when called with interrupts disabled */ | 390 | /* |
| 369 | WARN_ON_ONCE(irqs_disabled() && !oops_in_progress); | 391 | * Can deadlock when called with interrupts disabled. |
| 392 | * We allow cpu's that are not yet online though, as no one else can | ||
| 393 | * send smp call function interrupt to this cpu and as such deadlocks | ||
| 394 | * can't happen. | ||
| 395 | */ | ||
| 396 | WARN_ON_ONCE(cpu_online(this_cpu) && irqs_disabled() | ||
| 397 | && !oops_in_progress); | ||
| 370 | 398 | ||
| 371 | /* So, what's a CPU they want? Ignoring this one. */ | 399 | /* So, what's a CPU they want? Ignoring this one. */ |
| 372 | cpu = cpumask_first_and(mask, cpu_online_mask); | 400 | cpu = cpumask_first_and(mask, cpu_online_mask); |
