diff options
Diffstat (limited to 'kernel/lockdep.c')
-rw-r--r-- | kernel/lockdep.c | 33 |
1 files changed, 21 insertions, 12 deletions
diff --git a/kernel/lockdep.c b/kernel/lockdep.c index 06e157119d2b..a42858303233 100644 --- a/kernel/lockdep.c +++ b/kernel/lockdep.c | |||
@@ -136,16 +136,16 @@ static inline struct lock_class *hlock_class(struct held_lock *hlock) | |||
136 | #ifdef CONFIG_LOCK_STAT | 136 | #ifdef CONFIG_LOCK_STAT |
137 | static DEFINE_PER_CPU(struct lock_class_stats[MAX_LOCKDEP_KEYS], lock_stats); | 137 | static DEFINE_PER_CPU(struct lock_class_stats[MAX_LOCKDEP_KEYS], lock_stats); |
138 | 138 | ||
139 | static int lock_contention_point(struct lock_class *class, unsigned long ip) | 139 | static int lock_point(unsigned long points[], unsigned long ip) |
140 | { | 140 | { |
141 | int i; | 141 | int i; |
142 | 142 | ||
143 | for (i = 0; i < ARRAY_SIZE(class->contention_point); i++) { | 143 | for (i = 0; i < LOCKSTAT_POINTS; i++) { |
144 | if (class->contention_point[i] == 0) { | 144 | if (points[i] == 0) { |
145 | class->contention_point[i] = ip; | 145 | points[i] = ip; |
146 | break; | 146 | break; |
147 | } | 147 | } |
148 | if (class->contention_point[i] == ip) | 148 | if (points[i] == ip) |
149 | break; | 149 | break; |
150 | } | 150 | } |
151 | 151 | ||
@@ -185,6 +185,9 @@ struct lock_class_stats lock_stats(struct lock_class *class) | |||
185 | for (i = 0; i < ARRAY_SIZE(stats.contention_point); i++) | 185 | for (i = 0; i < ARRAY_SIZE(stats.contention_point); i++) |
186 | stats.contention_point[i] += pcs->contention_point[i]; | 186 | stats.contention_point[i] += pcs->contention_point[i]; |
187 | 187 | ||
188 | for (i = 0; i < ARRAY_SIZE(stats.contending_point); i++) | ||
189 | stats.contending_point[i] += pcs->contending_point[i]; | ||
190 | |||
188 | lock_time_add(&pcs->read_waittime, &stats.read_waittime); | 191 | lock_time_add(&pcs->read_waittime, &stats.read_waittime); |
189 | lock_time_add(&pcs->write_waittime, &stats.write_waittime); | 192 | lock_time_add(&pcs->write_waittime, &stats.write_waittime); |
190 | 193 | ||
@@ -209,6 +212,7 @@ void clear_lock_stats(struct lock_class *class) | |||
209 | memset(cpu_stats, 0, sizeof(struct lock_class_stats)); | 212 | memset(cpu_stats, 0, sizeof(struct lock_class_stats)); |
210 | } | 213 | } |
211 | memset(class->contention_point, 0, sizeof(class->contention_point)); | 214 | memset(class->contention_point, 0, sizeof(class->contention_point)); |
215 | memset(class->contending_point, 0, sizeof(class->contending_point)); | ||
212 | } | 216 | } |
213 | 217 | ||
214 | static struct lock_class_stats *get_lock_stats(struct lock_class *class) | 218 | static struct lock_class_stats *get_lock_stats(struct lock_class *class) |
@@ -2999,7 +3003,7 @@ __lock_contended(struct lockdep_map *lock, unsigned long ip) | |||
2999 | struct held_lock *hlock, *prev_hlock; | 3003 | struct held_lock *hlock, *prev_hlock; |
3000 | struct lock_class_stats *stats; | 3004 | struct lock_class_stats *stats; |
3001 | unsigned int depth; | 3005 | unsigned int depth; |
3002 | int i, point; | 3006 | int i, contention_point, contending_point; |
3003 | 3007 | ||
3004 | depth = curr->lockdep_depth; | 3008 | depth = curr->lockdep_depth; |
3005 | if (DEBUG_LOCKS_WARN_ON(!depth)) | 3009 | if (DEBUG_LOCKS_WARN_ON(!depth)) |
@@ -3023,18 +3027,22 @@ __lock_contended(struct lockdep_map *lock, unsigned long ip) | |||
3023 | found_it: | 3027 | found_it: |
3024 | hlock->waittime_stamp = sched_clock(); | 3028 | hlock->waittime_stamp = sched_clock(); |
3025 | 3029 | ||
3026 | point = lock_contention_point(hlock_class(hlock), ip); | 3030 | contention_point = lock_point(hlock_class(hlock)->contention_point, ip); |
3031 | contending_point = lock_point(hlock_class(hlock)->contending_point, | ||
3032 | lock->ip); | ||
3027 | 3033 | ||
3028 | stats = get_lock_stats(hlock_class(hlock)); | 3034 | stats = get_lock_stats(hlock_class(hlock)); |
3029 | if (point < ARRAY_SIZE(stats->contention_point)) | 3035 | if (contention_point < LOCKSTAT_POINTS) |
3030 | stats->contention_point[point]++; | 3036 | stats->contention_point[contention_point]++; |
3037 | if (contending_point < LOCKSTAT_POINTS) | ||
3038 | stats->contending_point[contending_point]++; | ||
3031 | if (lock->cpu != smp_processor_id()) | 3039 | if (lock->cpu != smp_processor_id()) |
3032 | stats->bounces[bounce_contended + !!hlock->read]++; | 3040 | stats->bounces[bounce_contended + !!hlock->read]++; |
3033 | put_lock_stats(stats); | 3041 | put_lock_stats(stats); |
3034 | } | 3042 | } |
3035 | 3043 | ||
3036 | static void | 3044 | static void |
3037 | __lock_acquired(struct lockdep_map *lock) | 3045 | __lock_acquired(struct lockdep_map *lock, unsigned long ip) |
3038 | { | 3046 | { |
3039 | struct task_struct *curr = current; | 3047 | struct task_struct *curr = current; |
3040 | struct held_lock *hlock, *prev_hlock; | 3048 | struct held_lock *hlock, *prev_hlock; |
@@ -3083,6 +3091,7 @@ found_it: | |||
3083 | put_lock_stats(stats); | 3091 | put_lock_stats(stats); |
3084 | 3092 | ||
3085 | lock->cpu = cpu; | 3093 | lock->cpu = cpu; |
3094 | lock->ip = ip; | ||
3086 | } | 3095 | } |
3087 | 3096 | ||
3088 | void lock_contended(struct lockdep_map *lock, unsigned long ip) | 3097 | void lock_contended(struct lockdep_map *lock, unsigned long ip) |
@@ -3104,7 +3113,7 @@ void lock_contended(struct lockdep_map *lock, unsigned long ip) | |||
3104 | } | 3113 | } |
3105 | EXPORT_SYMBOL_GPL(lock_contended); | 3114 | EXPORT_SYMBOL_GPL(lock_contended); |
3106 | 3115 | ||
3107 | void lock_acquired(struct lockdep_map *lock) | 3116 | void lock_acquired(struct lockdep_map *lock, unsigned long ip) |
3108 | { | 3117 | { |
3109 | unsigned long flags; | 3118 | unsigned long flags; |
3110 | 3119 | ||
@@ -3117,7 +3126,7 @@ void lock_acquired(struct lockdep_map *lock) | |||
3117 | raw_local_irq_save(flags); | 3126 | raw_local_irq_save(flags); |
3118 | check_flags(flags); | 3127 | check_flags(flags); |
3119 | current->lockdep_recursion = 1; | 3128 | current->lockdep_recursion = 1; |
3120 | __lock_acquired(lock); | 3129 | __lock_acquired(lock, ip); |
3121 | current->lockdep_recursion = 0; | 3130 | current->lockdep_recursion = 0; |
3122 | raw_local_irq_restore(flags); | 3131 | raw_local_irq_restore(flags); |
3123 | } | 3132 | } |