diff options
Diffstat (limited to 'kernel/kprobes.c')
-rw-r--r-- | kernel/kprobes.c | 32 |
1 files changed, 24 insertions, 8 deletions
diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 1fbf466a29aa..f095178e48c3 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c | |||
@@ -368,16 +368,15 @@ static inline void copy_kprobe(struct kprobe *old_p, struct kprobe *p) | |||
368 | */ | 368 | */ |
369 | static int __kprobes add_new_kprobe(struct kprobe *old_p, struct kprobe *p) | 369 | static int __kprobes add_new_kprobe(struct kprobe *old_p, struct kprobe *p) |
370 | { | 370 | { |
371 | struct kprobe *kp; | ||
372 | |||
373 | if (p->break_handler) { | 371 | if (p->break_handler) { |
374 | list_for_each_entry_rcu(kp, &old_p->list, list) { | 372 | if (old_p->break_handler) |
375 | if (kp->break_handler) | 373 | return -EEXIST; |
376 | return -EEXIST; | ||
377 | } | ||
378 | list_add_tail_rcu(&p->list, &old_p->list); | 374 | list_add_tail_rcu(&p->list, &old_p->list); |
375 | old_p->break_handler = aggr_break_handler; | ||
379 | } else | 376 | } else |
380 | list_add_rcu(&p->list, &old_p->list); | 377 | list_add_rcu(&p->list, &old_p->list); |
378 | if (p->post_handler && !old_p->post_handler) | ||
379 | old_p->post_handler = aggr_post_handler; | ||
381 | return 0; | 380 | return 0; |
382 | } | 381 | } |
383 | 382 | ||
@@ -390,9 +389,11 @@ static inline void add_aggr_kprobe(struct kprobe *ap, struct kprobe *p) | |||
390 | copy_kprobe(p, ap); | 389 | copy_kprobe(p, ap); |
391 | ap->addr = p->addr; | 390 | ap->addr = p->addr; |
392 | ap->pre_handler = aggr_pre_handler; | 391 | ap->pre_handler = aggr_pre_handler; |
393 | ap->post_handler = aggr_post_handler; | ||
394 | ap->fault_handler = aggr_fault_handler; | 392 | ap->fault_handler = aggr_fault_handler; |
395 | ap->break_handler = aggr_break_handler; | 393 | if (p->post_handler) |
394 | ap->post_handler = aggr_post_handler; | ||
395 | if (p->break_handler) | ||
396 | ap->break_handler = aggr_break_handler; | ||
396 | 397 | ||
397 | INIT_LIST_HEAD(&ap->list); | 398 | INIT_LIST_HEAD(&ap->list); |
398 | list_add_rcu(&p->list, &ap->list); | 399 | list_add_rcu(&p->list, &ap->list); |
@@ -536,6 +537,21 @@ valid_p: | |||
536 | kfree(old_p); | 537 | kfree(old_p); |
537 | } | 538 | } |
538 | arch_remove_kprobe(p); | 539 | arch_remove_kprobe(p); |
540 | } else { | ||
541 | mutex_lock(&kprobe_mutex); | ||
542 | if (p->break_handler) | ||
543 | old_p->break_handler = NULL; | ||
544 | if (p->post_handler){ | ||
545 | list_for_each_entry_rcu(list_p, &old_p->list, list){ | ||
546 | if (list_p->post_handler){ | ||
547 | cleanup_p = 2; | ||
548 | break; | ||
549 | } | ||
550 | } | ||
551 | if (cleanup_p == 0) | ||
552 | old_p->post_handler = NULL; | ||
553 | } | ||
554 | mutex_unlock(&kprobe_mutex); | ||
539 | } | 555 | } |
540 | } | 556 | } |
541 | 557 | ||