diff options
Diffstat (limited to 'kernel/futex.c')
-rw-r--r-- | kernel/futex.c | 1067 |
1 files changed, 919 insertions, 148 deletions
diff --git a/kernel/futex.c b/kernel/futex.c index e1a380c77a5a..6c91f938005d 100644 --- a/kernel/futex.c +++ b/kernel/futex.c | |||
@@ -12,6 +12,10 @@ | |||
12 | * (C) Copyright 2006 Red Hat Inc, All Rights Reserved | 12 | * (C) Copyright 2006 Red Hat Inc, All Rights Reserved |
13 | * Thanks to Thomas Gleixner for suggestions, analysis and fixes. | 13 | * Thanks to Thomas Gleixner for suggestions, analysis and fixes. |
14 | * | 14 | * |
15 | * PI-futex support started by Ingo Molnar and Thomas Gleixner | ||
16 | * Copyright (C) 2006 Red Hat, Inc., Ingo Molnar <mingo@redhat.com> | ||
17 | * Copyright (C) 2006 Timesys Corp., Thomas Gleixner <tglx@timesys.com> | ||
18 | * | ||
15 | * Thanks to Ben LaHaise for yelling "hashed waitqueues" loudly | 19 | * Thanks to Ben LaHaise for yelling "hashed waitqueues" loudly |
16 | * enough at me, Linus for the original (flawed) idea, Matthew | 20 | * enough at me, Linus for the original (flawed) idea, Matthew |
17 | * Kirkwood for proof-of-concept implementation. | 21 | * Kirkwood for proof-of-concept implementation. |
@@ -46,6 +50,8 @@ | |||
46 | #include <linux/signal.h> | 50 | #include <linux/signal.h> |
47 | #include <asm/futex.h> | 51 | #include <asm/futex.h> |
48 | 52 | ||
53 | #include "rtmutex_common.h" | ||
54 | |||
49 | #define FUTEX_HASHBITS (CONFIG_BASE_SMALL ? 4 : 8) | 55 | #define FUTEX_HASHBITS (CONFIG_BASE_SMALL ? 4 : 8) |
50 | 56 | ||
51 | /* | 57 | /* |
@@ -63,7 +69,7 @@ union futex_key { | |||
63 | int offset; | 69 | int offset; |
64 | } shared; | 70 | } shared; |
65 | struct { | 71 | struct { |
66 | unsigned long uaddr; | 72 | unsigned long address; |
67 | struct mm_struct *mm; | 73 | struct mm_struct *mm; |
68 | int offset; | 74 | int offset; |
69 | } private; | 75 | } private; |
@@ -75,6 +81,27 @@ union futex_key { | |||
75 | }; | 81 | }; |
76 | 82 | ||
77 | /* | 83 | /* |
84 | * Priority Inheritance state: | ||
85 | */ | ||
86 | struct futex_pi_state { | ||
87 | /* | ||
88 | * list of 'owned' pi_state instances - these have to be | ||
89 | * cleaned up in do_exit() if the task exits prematurely: | ||
90 | */ | ||
91 | struct list_head list; | ||
92 | |||
93 | /* | ||
94 | * The PI object: | ||
95 | */ | ||
96 | struct rt_mutex pi_mutex; | ||
97 | |||
98 | struct task_struct *owner; | ||
99 | atomic_t refcount; | ||
100 | |||
101 | union futex_key key; | ||
102 | }; | ||
103 | |||
104 | /* | ||
78 | * We use this hashed waitqueue instead of a normal wait_queue_t, so | 105 | * We use this hashed waitqueue instead of a normal wait_queue_t, so |
79 | * we can wake only the relevant ones (hashed queues may be shared). | 106 | * we can wake only the relevant ones (hashed queues may be shared). |
80 | * | 107 | * |
@@ -87,15 +114,19 @@ struct futex_q { | |||
87 | struct list_head list; | 114 | struct list_head list; |
88 | wait_queue_head_t waiters; | 115 | wait_queue_head_t waiters; |
89 | 116 | ||
90 | /* Which hash list lock to use. */ | 117 | /* Which hash list lock to use: */ |
91 | spinlock_t *lock_ptr; | 118 | spinlock_t *lock_ptr; |
92 | 119 | ||
93 | /* Key which the futex is hashed on. */ | 120 | /* Key which the futex is hashed on: */ |
94 | union futex_key key; | 121 | union futex_key key; |
95 | 122 | ||
96 | /* For fd, sigio sent using these. */ | 123 | /* For fd, sigio sent using these: */ |
97 | int fd; | 124 | int fd; |
98 | struct file *filp; | 125 | struct file *filp; |
126 | |||
127 | /* Optional priority inheritance state: */ | ||
128 | struct futex_pi_state *pi_state; | ||
129 | struct task_struct *task; | ||
99 | }; | 130 | }; |
100 | 131 | ||
101 | /* | 132 | /* |
@@ -144,8 +175,9 @@ static inline int match_futex(union futex_key *key1, union futex_key *key2) | |||
144 | * | 175 | * |
145 | * Should be called with ¤t->mm->mmap_sem but NOT any spinlocks. | 176 | * Should be called with ¤t->mm->mmap_sem but NOT any spinlocks. |
146 | */ | 177 | */ |
147 | static int get_futex_key(unsigned long uaddr, union futex_key *key) | 178 | static int get_futex_key(u32 __user *uaddr, union futex_key *key) |
148 | { | 179 | { |
180 | unsigned long address = (unsigned long)uaddr; | ||
149 | struct mm_struct *mm = current->mm; | 181 | struct mm_struct *mm = current->mm; |
150 | struct vm_area_struct *vma; | 182 | struct vm_area_struct *vma; |
151 | struct page *page; | 183 | struct page *page; |
@@ -154,16 +186,16 @@ static int get_futex_key(unsigned long uaddr, union futex_key *key) | |||
154 | /* | 186 | /* |
155 | * The futex address must be "naturally" aligned. | 187 | * The futex address must be "naturally" aligned. |
156 | */ | 188 | */ |
157 | key->both.offset = uaddr % PAGE_SIZE; | 189 | key->both.offset = address % PAGE_SIZE; |
158 | if (unlikely((key->both.offset % sizeof(u32)) != 0)) | 190 | if (unlikely((key->both.offset % sizeof(u32)) != 0)) |
159 | return -EINVAL; | 191 | return -EINVAL; |
160 | uaddr -= key->both.offset; | 192 | address -= key->both.offset; |
161 | 193 | ||
162 | /* | 194 | /* |
163 | * The futex is hashed differently depending on whether | 195 | * The futex is hashed differently depending on whether |
164 | * it's in a shared or private mapping. So check vma first. | 196 | * it's in a shared or private mapping. So check vma first. |
165 | */ | 197 | */ |
166 | vma = find_extend_vma(mm, uaddr); | 198 | vma = find_extend_vma(mm, address); |
167 | if (unlikely(!vma)) | 199 | if (unlikely(!vma)) |
168 | return -EFAULT; | 200 | return -EFAULT; |
169 | 201 | ||
@@ -184,7 +216,7 @@ static int get_futex_key(unsigned long uaddr, union futex_key *key) | |||
184 | */ | 216 | */ |
185 | if (likely(!(vma->vm_flags & VM_MAYSHARE))) { | 217 | if (likely(!(vma->vm_flags & VM_MAYSHARE))) { |
186 | key->private.mm = mm; | 218 | key->private.mm = mm; |
187 | key->private.uaddr = uaddr; | 219 | key->private.address = address; |
188 | return 0; | 220 | return 0; |
189 | } | 221 | } |
190 | 222 | ||
@@ -194,7 +226,7 @@ static int get_futex_key(unsigned long uaddr, union futex_key *key) | |||
194 | key->shared.inode = vma->vm_file->f_dentry->d_inode; | 226 | key->shared.inode = vma->vm_file->f_dentry->d_inode; |
195 | key->both.offset++; /* Bit 0 of offset indicates inode-based key. */ | 227 | key->both.offset++; /* Bit 0 of offset indicates inode-based key. */ |
196 | if (likely(!(vma->vm_flags & VM_NONLINEAR))) { | 228 | if (likely(!(vma->vm_flags & VM_NONLINEAR))) { |
197 | key->shared.pgoff = (((uaddr - vma->vm_start) >> PAGE_SHIFT) | 229 | key->shared.pgoff = (((address - vma->vm_start) >> PAGE_SHIFT) |
198 | + vma->vm_pgoff); | 230 | + vma->vm_pgoff); |
199 | return 0; | 231 | return 0; |
200 | } | 232 | } |
@@ -205,7 +237,7 @@ static int get_futex_key(unsigned long uaddr, union futex_key *key) | |||
205 | * from swap. But that's a lot of code to duplicate here | 237 | * from swap. But that's a lot of code to duplicate here |
206 | * for a rare case, so we simply fetch the page. | 238 | * for a rare case, so we simply fetch the page. |
207 | */ | 239 | */ |
208 | err = get_user_pages(current, mm, uaddr, 1, 0, 0, &page, NULL); | 240 | err = get_user_pages(current, mm, address, 1, 0, 0, &page, NULL); |
209 | if (err >= 0) { | 241 | if (err >= 0) { |
210 | key->shared.pgoff = | 242 | key->shared.pgoff = |
211 | page->index << (PAGE_CACHE_SHIFT - PAGE_SHIFT); | 243 | page->index << (PAGE_CACHE_SHIFT - PAGE_SHIFT); |
@@ -246,18 +278,244 @@ static void drop_key_refs(union futex_key *key) | |||
246 | } | 278 | } |
247 | } | 279 | } |
248 | 280 | ||
249 | static inline int get_futex_value_locked(int *dest, int __user *from) | 281 | static inline int get_futex_value_locked(u32 *dest, u32 __user *from) |
250 | { | 282 | { |
251 | int ret; | 283 | int ret; |
252 | 284 | ||
253 | inc_preempt_count(); | 285 | inc_preempt_count(); |
254 | ret = __copy_from_user_inatomic(dest, from, sizeof(int)); | 286 | ret = __copy_from_user_inatomic(dest, from, sizeof(u32)); |
255 | dec_preempt_count(); | 287 | dec_preempt_count(); |
256 | 288 | ||
257 | return ret ? -EFAULT : 0; | 289 | return ret ? -EFAULT : 0; |
258 | } | 290 | } |
259 | 291 | ||
260 | /* | 292 | /* |
293 | * Fault handling. Called with current->mm->mmap_sem held. | ||
294 | */ | ||
295 | static int futex_handle_fault(unsigned long address, int attempt) | ||
296 | { | ||
297 | struct vm_area_struct * vma; | ||
298 | struct mm_struct *mm = current->mm; | ||
299 | |||
300 | if (attempt >= 2 || !(vma = find_vma(mm, address)) || | ||
301 | vma->vm_start > address || !(vma->vm_flags & VM_WRITE)) | ||
302 | return -EFAULT; | ||
303 | |||
304 | switch (handle_mm_fault(mm, vma, address, 1)) { | ||
305 | case VM_FAULT_MINOR: | ||
306 | current->min_flt++; | ||
307 | break; | ||
308 | case VM_FAULT_MAJOR: | ||
309 | current->maj_flt++; | ||
310 | break; | ||
311 | default: | ||
312 | return -EFAULT; | ||
313 | } | ||
314 | return 0; | ||
315 | } | ||
316 | |||
317 | /* | ||
318 | * PI code: | ||
319 | */ | ||
320 | static int refill_pi_state_cache(void) | ||
321 | { | ||
322 | struct futex_pi_state *pi_state; | ||
323 | |||
324 | if (likely(current->pi_state_cache)) | ||
325 | return 0; | ||
326 | |||
327 | pi_state = kmalloc(sizeof(*pi_state), GFP_KERNEL); | ||
328 | |||
329 | if (!pi_state) | ||
330 | return -ENOMEM; | ||
331 | |||
332 | memset(pi_state, 0, sizeof(*pi_state)); | ||
333 | INIT_LIST_HEAD(&pi_state->list); | ||
334 | /* pi_mutex gets initialized later */ | ||
335 | pi_state->owner = NULL; | ||
336 | atomic_set(&pi_state->refcount, 1); | ||
337 | |||
338 | current->pi_state_cache = pi_state; | ||
339 | |||
340 | return 0; | ||
341 | } | ||
342 | |||
343 | static struct futex_pi_state * alloc_pi_state(void) | ||
344 | { | ||
345 | struct futex_pi_state *pi_state = current->pi_state_cache; | ||
346 | |||
347 | WARN_ON(!pi_state); | ||
348 | current->pi_state_cache = NULL; | ||
349 | |||
350 | return pi_state; | ||
351 | } | ||
352 | |||
353 | static void free_pi_state(struct futex_pi_state *pi_state) | ||
354 | { | ||
355 | if (!atomic_dec_and_test(&pi_state->refcount)) | ||
356 | return; | ||
357 | |||
358 | /* | ||
359 | * If pi_state->owner is NULL, the owner is most probably dying | ||
360 | * and has cleaned up the pi_state already | ||
361 | */ | ||
362 | if (pi_state->owner) { | ||
363 | spin_lock_irq(&pi_state->owner->pi_lock); | ||
364 | list_del_init(&pi_state->list); | ||
365 | spin_unlock_irq(&pi_state->owner->pi_lock); | ||
366 | |||
367 | rt_mutex_proxy_unlock(&pi_state->pi_mutex, pi_state->owner); | ||
368 | } | ||
369 | |||
370 | if (current->pi_state_cache) | ||
371 | kfree(pi_state); | ||
372 | else { | ||
373 | /* | ||
374 | * pi_state->list is already empty. | ||
375 | * clear pi_state->owner. | ||
376 | * refcount is at 0 - put it back to 1. | ||
377 | */ | ||
378 | pi_state->owner = NULL; | ||
379 | atomic_set(&pi_state->refcount, 1); | ||
380 | current->pi_state_cache = pi_state; | ||
381 | } | ||
382 | } | ||
383 | |||
384 | /* | ||
385 | * Look up the task based on what TID userspace gave us. | ||
386 | * We dont trust it. | ||
387 | */ | ||
388 | static struct task_struct * futex_find_get_task(pid_t pid) | ||
389 | { | ||
390 | struct task_struct *p; | ||
391 | |||
392 | read_lock(&tasklist_lock); | ||
393 | p = find_task_by_pid(pid); | ||
394 | if (!p) | ||
395 | goto out_unlock; | ||
396 | if ((current->euid != p->euid) && (current->euid != p->uid)) { | ||
397 | p = NULL; | ||
398 | goto out_unlock; | ||
399 | } | ||
400 | if (p->state == EXIT_ZOMBIE || p->exit_state == EXIT_ZOMBIE) { | ||
401 | p = NULL; | ||
402 | goto out_unlock; | ||
403 | } | ||
404 | get_task_struct(p); | ||
405 | out_unlock: | ||
406 | read_unlock(&tasklist_lock); | ||
407 | |||
408 | return p; | ||
409 | } | ||
410 | |||
411 | /* | ||
412 | * This task is holding PI mutexes at exit time => bad. | ||
413 | * Kernel cleans up PI-state, but userspace is likely hosed. | ||
414 | * (Robust-futex cleanup is separate and might save the day for userspace.) | ||
415 | */ | ||
416 | void exit_pi_state_list(struct task_struct *curr) | ||
417 | { | ||
418 | struct futex_hash_bucket *hb; | ||
419 | struct list_head *next, *head = &curr->pi_state_list; | ||
420 | struct futex_pi_state *pi_state; | ||
421 | union futex_key key; | ||
422 | |||
423 | /* | ||
424 | * We are a ZOMBIE and nobody can enqueue itself on | ||
425 | * pi_state_list anymore, but we have to be careful | ||
426 | * versus waiters unqueueing themselfs | ||
427 | */ | ||
428 | spin_lock_irq(&curr->pi_lock); | ||
429 | while (!list_empty(head)) { | ||
430 | |||
431 | next = head->next; | ||
432 | pi_state = list_entry(next, struct futex_pi_state, list); | ||
433 | key = pi_state->key; | ||
434 | spin_unlock_irq(&curr->pi_lock); | ||
435 | |||
436 | hb = hash_futex(&key); | ||
437 | spin_lock(&hb->lock); | ||
438 | |||
439 | spin_lock_irq(&curr->pi_lock); | ||
440 | if (head->next != next) { | ||
441 | spin_unlock(&hb->lock); | ||
442 | continue; | ||
443 | } | ||
444 | |||
445 | list_del_init(&pi_state->list); | ||
446 | |||
447 | WARN_ON(pi_state->owner != curr); | ||
448 | |||
449 | pi_state->owner = NULL; | ||
450 | spin_unlock_irq(&curr->pi_lock); | ||
451 | |||
452 | rt_mutex_unlock(&pi_state->pi_mutex); | ||
453 | |||
454 | spin_unlock(&hb->lock); | ||
455 | |||
456 | spin_lock_irq(&curr->pi_lock); | ||
457 | } | ||
458 | spin_unlock_irq(&curr->pi_lock); | ||
459 | } | ||
460 | |||
461 | static int | ||
462 | lookup_pi_state(u32 uval, struct futex_hash_bucket *hb, struct futex_q *me) | ||
463 | { | ||
464 | struct futex_pi_state *pi_state = NULL; | ||
465 | struct futex_q *this, *next; | ||
466 | struct list_head *head; | ||
467 | struct task_struct *p; | ||
468 | pid_t pid; | ||
469 | |||
470 | head = &hb->chain; | ||
471 | |||
472 | list_for_each_entry_safe(this, next, head, list) { | ||
473 | if (match_futex (&this->key, &me->key)) { | ||
474 | /* | ||
475 | * Another waiter already exists - bump up | ||
476 | * the refcount and return its pi_state: | ||
477 | */ | ||
478 | pi_state = this->pi_state; | ||
479 | atomic_inc(&pi_state->refcount); | ||
480 | me->pi_state = pi_state; | ||
481 | |||
482 | return 0; | ||
483 | } | ||
484 | } | ||
485 | |||
486 | /* | ||
487 | * We are the first waiter - try to look up the real owner and | ||
488 | * attach the new pi_state to it: | ||
489 | */ | ||
490 | pid = uval & FUTEX_TID_MASK; | ||
491 | p = futex_find_get_task(pid); | ||
492 | if (!p) | ||
493 | return -ESRCH; | ||
494 | |||
495 | pi_state = alloc_pi_state(); | ||
496 | |||
497 | /* | ||
498 | * Initialize the pi_mutex in locked state and make 'p' | ||
499 | * the owner of it: | ||
500 | */ | ||
501 | rt_mutex_init_proxy_locked(&pi_state->pi_mutex, p); | ||
502 | |||
503 | /* Store the key for possible exit cleanups: */ | ||
504 | pi_state->key = me->key; | ||
505 | |||
506 | spin_lock_irq(&p->pi_lock); | ||
507 | list_add(&pi_state->list, &p->pi_state_list); | ||
508 | pi_state->owner = p; | ||
509 | spin_unlock_irq(&p->pi_lock); | ||
510 | |||
511 | put_task_struct(p); | ||
512 | |||
513 | me->pi_state = pi_state; | ||
514 | |||
515 | return 0; | ||
516 | } | ||
517 | |||
518 | /* | ||
261 | * The hash bucket lock must be held when this is called. | 519 | * The hash bucket lock must be held when this is called. |
262 | * Afterwards, the futex_q must not be accessed. | 520 | * Afterwards, the futex_q must not be accessed. |
263 | */ | 521 | */ |
@@ -284,16 +542,80 @@ static void wake_futex(struct futex_q *q) | |||
284 | q->lock_ptr = NULL; | 542 | q->lock_ptr = NULL; |
285 | } | 543 | } |
286 | 544 | ||
545 | static int wake_futex_pi(u32 __user *uaddr, u32 uval, struct futex_q *this) | ||
546 | { | ||
547 | struct task_struct *new_owner; | ||
548 | struct futex_pi_state *pi_state = this->pi_state; | ||
549 | u32 curval, newval; | ||
550 | |||
551 | if (!pi_state) | ||
552 | return -EINVAL; | ||
553 | |||
554 | new_owner = rt_mutex_next_owner(&pi_state->pi_mutex); | ||
555 | |||
556 | /* | ||
557 | * This happens when we have stolen the lock and the original | ||
558 | * pending owner did not enqueue itself back on the rt_mutex. | ||
559 | * Thats not a tragedy. We know that way, that a lock waiter | ||
560 | * is on the fly. We make the futex_q waiter the pending owner. | ||
561 | */ | ||
562 | if (!new_owner) | ||
563 | new_owner = this->task; | ||
564 | |||
565 | /* | ||
566 | * We pass it to the next owner. (The WAITERS bit is always | ||
567 | * kept enabled while there is PI state around. We must also | ||
568 | * preserve the owner died bit.) | ||
569 | */ | ||
570 | newval = (uval & FUTEX_OWNER_DIED) | FUTEX_WAITERS | new_owner->pid; | ||
571 | |||
572 | inc_preempt_count(); | ||
573 | curval = futex_atomic_cmpxchg_inatomic(uaddr, uval, newval); | ||
574 | dec_preempt_count(); | ||
575 | |||
576 | if (curval == -EFAULT) | ||
577 | return -EFAULT; | ||
578 | if (curval != uval) | ||
579 | return -EINVAL; | ||
580 | |||
581 | list_del_init(&pi_state->owner->pi_state_list); | ||
582 | list_add(&pi_state->list, &new_owner->pi_state_list); | ||
583 | pi_state->owner = new_owner; | ||
584 | rt_mutex_unlock(&pi_state->pi_mutex); | ||
585 | |||
586 | return 0; | ||
587 | } | ||
588 | |||
589 | static int unlock_futex_pi(u32 __user *uaddr, u32 uval) | ||
590 | { | ||
591 | u32 oldval; | ||
592 | |||
593 | /* | ||
594 | * There is no waiter, so we unlock the futex. The owner died | ||
595 | * bit has not to be preserved here. We are the owner: | ||
596 | */ | ||
597 | inc_preempt_count(); | ||
598 | oldval = futex_atomic_cmpxchg_inatomic(uaddr, uval, 0); | ||
599 | dec_preempt_count(); | ||
600 | |||
601 | if (oldval == -EFAULT) | ||
602 | return oldval; | ||
603 | if (oldval != uval) | ||
604 | return -EAGAIN; | ||
605 | |||
606 | return 0; | ||
607 | } | ||
608 | |||
287 | /* | 609 | /* |
288 | * Wake up all waiters hashed on the physical page that is mapped | 610 | * Wake up all waiters hashed on the physical page that is mapped |
289 | * to this virtual address: | 611 | * to this virtual address: |
290 | */ | 612 | */ |
291 | static int futex_wake(unsigned long uaddr, int nr_wake) | 613 | static int futex_wake(u32 __user *uaddr, int nr_wake) |
292 | { | 614 | { |
293 | union futex_key key; | 615 | struct futex_hash_bucket *hb; |
294 | struct futex_hash_bucket *bh; | ||
295 | struct list_head *head; | ||
296 | struct futex_q *this, *next; | 616 | struct futex_q *this, *next; |
617 | struct list_head *head; | ||
618 | union futex_key key; | ||
297 | int ret; | 619 | int ret; |
298 | 620 | ||
299 | down_read(¤t->mm->mmap_sem); | 621 | down_read(¤t->mm->mmap_sem); |
@@ -302,19 +624,21 @@ static int futex_wake(unsigned long uaddr, int nr_wake) | |||
302 | if (unlikely(ret != 0)) | 624 | if (unlikely(ret != 0)) |
303 | goto out; | 625 | goto out; |
304 | 626 | ||
305 | bh = hash_futex(&key); | 627 | hb = hash_futex(&key); |
306 | spin_lock(&bh->lock); | 628 | spin_lock(&hb->lock); |
307 | head = &bh->chain; | 629 | head = &hb->chain; |
308 | 630 | ||
309 | list_for_each_entry_safe(this, next, head, list) { | 631 | list_for_each_entry_safe(this, next, head, list) { |
310 | if (match_futex (&this->key, &key)) { | 632 | if (match_futex (&this->key, &key)) { |
633 | if (this->pi_state) | ||
634 | return -EINVAL; | ||
311 | wake_futex(this); | 635 | wake_futex(this); |
312 | if (++ret >= nr_wake) | 636 | if (++ret >= nr_wake) |
313 | break; | 637 | break; |
314 | } | 638 | } |
315 | } | 639 | } |
316 | 640 | ||
317 | spin_unlock(&bh->lock); | 641 | spin_unlock(&hb->lock); |
318 | out: | 642 | out: |
319 | up_read(¤t->mm->mmap_sem); | 643 | up_read(¤t->mm->mmap_sem); |
320 | return ret; | 644 | return ret; |
@@ -324,10 +648,12 @@ out: | |||
324 | * Wake up all waiters hashed on the physical page that is mapped | 648 | * Wake up all waiters hashed on the physical page that is mapped |
325 | * to this virtual address: | 649 | * to this virtual address: |
326 | */ | 650 | */ |
327 | static int futex_wake_op(unsigned long uaddr1, unsigned long uaddr2, int nr_wake, int nr_wake2, int op) | 651 | static int |
652 | futex_wake_op(u32 __user *uaddr1, u32 __user *uaddr2, | ||
653 | int nr_wake, int nr_wake2, int op) | ||
328 | { | 654 | { |
329 | union futex_key key1, key2; | 655 | union futex_key key1, key2; |
330 | struct futex_hash_bucket *bh1, *bh2; | 656 | struct futex_hash_bucket *hb1, *hb2; |
331 | struct list_head *head; | 657 | struct list_head *head; |
332 | struct futex_q *this, *next; | 658 | struct futex_q *this, *next; |
333 | int ret, op_ret, attempt = 0; | 659 | int ret, op_ret, attempt = 0; |
@@ -342,27 +668,29 @@ retryfull: | |||
342 | if (unlikely(ret != 0)) | 668 | if (unlikely(ret != 0)) |
343 | goto out; | 669 | goto out; |
344 | 670 | ||
345 | bh1 = hash_futex(&key1); | 671 | hb1 = hash_futex(&key1); |
346 | bh2 = hash_futex(&key2); | 672 | hb2 = hash_futex(&key2); |
347 | 673 | ||
348 | retry: | 674 | retry: |
349 | if (bh1 < bh2) | 675 | if (hb1 < hb2) |
350 | spin_lock(&bh1->lock); | 676 | spin_lock(&hb1->lock); |
351 | spin_lock(&bh2->lock); | 677 | spin_lock(&hb2->lock); |
352 | if (bh1 > bh2) | 678 | if (hb1 > hb2) |
353 | spin_lock(&bh1->lock); | 679 | spin_lock(&hb1->lock); |
354 | 680 | ||
355 | op_ret = futex_atomic_op_inuser(op, (int __user *)uaddr2); | 681 | op_ret = futex_atomic_op_inuser(op, uaddr2); |
356 | if (unlikely(op_ret < 0)) { | 682 | if (unlikely(op_ret < 0)) { |
357 | int dummy; | 683 | u32 dummy; |
358 | 684 | ||
359 | spin_unlock(&bh1->lock); | 685 | spin_unlock(&hb1->lock); |
360 | if (bh1 != bh2) | 686 | if (hb1 != hb2) |
361 | spin_unlock(&bh2->lock); | 687 | spin_unlock(&hb2->lock); |
362 | 688 | ||
363 | #ifndef CONFIG_MMU | 689 | #ifndef CONFIG_MMU |
364 | /* we don't get EFAULT from MMU faults if we don't have an MMU, | 690 | /* |
365 | * but we might get them from range checking */ | 691 | * we don't get EFAULT from MMU faults if we don't have an MMU, |
692 | * but we might get them from range checking | ||
693 | */ | ||
366 | ret = op_ret; | 694 | ret = op_ret; |
367 | goto out; | 695 | goto out; |
368 | #endif | 696 | #endif |
@@ -372,47 +700,34 @@ retry: | |||
372 | goto out; | 700 | goto out; |
373 | } | 701 | } |
374 | 702 | ||
375 | /* futex_atomic_op_inuser needs to both read and write | 703 | /* |
704 | * futex_atomic_op_inuser needs to both read and write | ||
376 | * *(int __user *)uaddr2, but we can't modify it | 705 | * *(int __user *)uaddr2, but we can't modify it |
377 | * non-atomically. Therefore, if get_user below is not | 706 | * non-atomically. Therefore, if get_user below is not |
378 | * enough, we need to handle the fault ourselves, while | 707 | * enough, we need to handle the fault ourselves, while |
379 | * still holding the mmap_sem. */ | 708 | * still holding the mmap_sem. |
709 | */ | ||
380 | if (attempt++) { | 710 | if (attempt++) { |
381 | struct vm_area_struct * vma; | 711 | if (futex_handle_fault((unsigned long)uaddr2, |
382 | struct mm_struct *mm = current->mm; | 712 | attempt)) |
383 | |||
384 | ret = -EFAULT; | ||
385 | if (attempt >= 2 || | ||
386 | !(vma = find_vma(mm, uaddr2)) || | ||
387 | vma->vm_start > uaddr2 || | ||
388 | !(vma->vm_flags & VM_WRITE)) | ||
389 | goto out; | ||
390 | |||
391 | switch (handle_mm_fault(mm, vma, uaddr2, 1)) { | ||
392 | case VM_FAULT_MINOR: | ||
393 | current->min_flt++; | ||
394 | break; | ||
395 | case VM_FAULT_MAJOR: | ||
396 | current->maj_flt++; | ||
397 | break; | ||
398 | default: | ||
399 | goto out; | 713 | goto out; |
400 | } | ||
401 | goto retry; | 714 | goto retry; |
402 | } | 715 | } |
403 | 716 | ||
404 | /* If we would have faulted, release mmap_sem, | 717 | /* |
405 | * fault it in and start all over again. */ | 718 | * If we would have faulted, release mmap_sem, |
719 | * fault it in and start all over again. | ||
720 | */ | ||
406 | up_read(¤t->mm->mmap_sem); | 721 | up_read(¤t->mm->mmap_sem); |
407 | 722 | ||
408 | ret = get_user(dummy, (int __user *)uaddr2); | 723 | ret = get_user(dummy, uaddr2); |
409 | if (ret) | 724 | if (ret) |
410 | return ret; | 725 | return ret; |
411 | 726 | ||
412 | goto retryfull; | 727 | goto retryfull; |
413 | } | 728 | } |
414 | 729 | ||
415 | head = &bh1->chain; | 730 | head = &hb1->chain; |
416 | 731 | ||
417 | list_for_each_entry_safe(this, next, head, list) { | 732 | list_for_each_entry_safe(this, next, head, list) { |
418 | if (match_futex (&this->key, &key1)) { | 733 | if (match_futex (&this->key, &key1)) { |
@@ -423,7 +738,7 @@ retry: | |||
423 | } | 738 | } |
424 | 739 | ||
425 | if (op_ret > 0) { | 740 | if (op_ret > 0) { |
426 | head = &bh2->chain; | 741 | head = &hb2->chain; |
427 | 742 | ||
428 | op_ret = 0; | 743 | op_ret = 0; |
429 | list_for_each_entry_safe(this, next, head, list) { | 744 | list_for_each_entry_safe(this, next, head, list) { |
@@ -436,9 +751,9 @@ retry: | |||
436 | ret += op_ret; | 751 | ret += op_ret; |
437 | } | 752 | } |
438 | 753 | ||
439 | spin_unlock(&bh1->lock); | 754 | spin_unlock(&hb1->lock); |
440 | if (bh1 != bh2) | 755 | if (hb1 != hb2) |
441 | spin_unlock(&bh2->lock); | 756 | spin_unlock(&hb2->lock); |
442 | out: | 757 | out: |
443 | up_read(¤t->mm->mmap_sem); | 758 | up_read(¤t->mm->mmap_sem); |
444 | return ret; | 759 | return ret; |
@@ -448,11 +763,11 @@ out: | |||
448 | * Requeue all waiters hashed on one physical page to another | 763 | * Requeue all waiters hashed on one physical page to another |
449 | * physical page. | 764 | * physical page. |
450 | */ | 765 | */ |
451 | static int futex_requeue(unsigned long uaddr1, unsigned long uaddr2, | 766 | static int futex_requeue(u32 __user *uaddr1, u32 __user *uaddr2, |
452 | int nr_wake, int nr_requeue, int *valp) | 767 | int nr_wake, int nr_requeue, u32 *cmpval) |
453 | { | 768 | { |
454 | union futex_key key1, key2; | 769 | union futex_key key1, key2; |
455 | struct futex_hash_bucket *bh1, *bh2; | 770 | struct futex_hash_bucket *hb1, *hb2; |
456 | struct list_head *head1; | 771 | struct list_head *head1; |
457 | struct futex_q *this, *next; | 772 | struct futex_q *this, *next; |
458 | int ret, drop_count = 0; | 773 | int ret, drop_count = 0; |
@@ -467,68 +782,72 @@ static int futex_requeue(unsigned long uaddr1, unsigned long uaddr2, | |||
467 | if (unlikely(ret != 0)) | 782 | if (unlikely(ret != 0)) |
468 | goto out; | 783 | goto out; |
469 | 784 | ||
470 | bh1 = hash_futex(&key1); | 785 | hb1 = hash_futex(&key1); |
471 | bh2 = hash_futex(&key2); | 786 | hb2 = hash_futex(&key2); |
472 | 787 | ||
473 | if (bh1 < bh2) | 788 | if (hb1 < hb2) |
474 | spin_lock(&bh1->lock); | 789 | spin_lock(&hb1->lock); |
475 | spin_lock(&bh2->lock); | 790 | spin_lock(&hb2->lock); |
476 | if (bh1 > bh2) | 791 | if (hb1 > hb2) |
477 | spin_lock(&bh1->lock); | 792 | spin_lock(&hb1->lock); |
478 | 793 | ||
479 | if (likely(valp != NULL)) { | 794 | if (likely(cmpval != NULL)) { |
480 | int curval; | 795 | u32 curval; |
481 | 796 | ||
482 | ret = get_futex_value_locked(&curval, (int __user *)uaddr1); | 797 | ret = get_futex_value_locked(&curval, uaddr1); |
483 | 798 | ||
484 | if (unlikely(ret)) { | 799 | if (unlikely(ret)) { |
485 | spin_unlock(&bh1->lock); | 800 | spin_unlock(&hb1->lock); |
486 | if (bh1 != bh2) | 801 | if (hb1 != hb2) |
487 | spin_unlock(&bh2->lock); | 802 | spin_unlock(&hb2->lock); |
488 | 803 | ||
489 | /* If we would have faulted, release mmap_sem, fault | 804 | /* |
805 | * If we would have faulted, release mmap_sem, fault | ||
490 | * it in and start all over again. | 806 | * it in and start all over again. |
491 | */ | 807 | */ |
492 | up_read(¤t->mm->mmap_sem); | 808 | up_read(¤t->mm->mmap_sem); |
493 | 809 | ||
494 | ret = get_user(curval, (int __user *)uaddr1); | 810 | ret = get_user(curval, uaddr1); |
495 | 811 | ||
496 | if (!ret) | 812 | if (!ret) |
497 | goto retry; | 813 | goto retry; |
498 | 814 | ||
499 | return ret; | 815 | return ret; |
500 | } | 816 | } |
501 | if (curval != *valp) { | 817 | if (curval != *cmpval) { |
502 | ret = -EAGAIN; | 818 | ret = -EAGAIN; |
503 | goto out_unlock; | 819 | goto out_unlock; |
504 | } | 820 | } |
505 | } | 821 | } |
506 | 822 | ||
507 | head1 = &bh1->chain; | 823 | head1 = &hb1->chain; |
508 | list_for_each_entry_safe(this, next, head1, list) { | 824 | list_for_each_entry_safe(this, next, head1, list) { |
509 | if (!match_futex (&this->key, &key1)) | 825 | if (!match_futex (&this->key, &key1)) |
510 | continue; | 826 | continue; |
511 | if (++ret <= nr_wake) { | 827 | if (++ret <= nr_wake) { |
512 | wake_futex(this); | 828 | wake_futex(this); |
513 | } else { | 829 | } else { |
514 | list_move_tail(&this->list, &bh2->chain); | 830 | /* |
515 | this->lock_ptr = &bh2->lock; | 831 | * If key1 and key2 hash to the same bucket, no need to |
832 | * requeue. | ||
833 | */ | ||
834 | if (likely(head1 != &hb2->chain)) { | ||
835 | list_move_tail(&this->list, &hb2->chain); | ||
836 | this->lock_ptr = &hb2->lock; | ||
837 | } | ||
516 | this->key = key2; | 838 | this->key = key2; |
517 | get_key_refs(&key2); | 839 | get_key_refs(&key2); |
518 | drop_count++; | 840 | drop_count++; |
519 | 841 | ||
520 | if (ret - nr_wake >= nr_requeue) | 842 | if (ret - nr_wake >= nr_requeue) |
521 | break; | 843 | break; |
522 | /* Make sure to stop if key1 == key2 */ | ||
523 | if (head1 == &bh2->chain && head1 != &next->list) | ||
524 | head1 = &this->list; | ||
525 | } | 844 | } |
526 | } | 845 | } |
527 | 846 | ||
528 | out_unlock: | 847 | out_unlock: |
529 | spin_unlock(&bh1->lock); | 848 | spin_unlock(&hb1->lock); |
530 | if (bh1 != bh2) | 849 | if (hb1 != hb2) |
531 | spin_unlock(&bh2->lock); | 850 | spin_unlock(&hb2->lock); |
532 | 851 | ||
533 | /* drop_key_refs() must be called outside the spinlocks. */ | 852 | /* drop_key_refs() must be called outside the spinlocks. */ |
534 | while (--drop_count >= 0) | 853 | while (--drop_count >= 0) |
@@ -543,7 +862,7 @@ out: | |||
543 | static inline struct futex_hash_bucket * | 862 | static inline struct futex_hash_bucket * |
544 | queue_lock(struct futex_q *q, int fd, struct file *filp) | 863 | queue_lock(struct futex_q *q, int fd, struct file *filp) |
545 | { | 864 | { |
546 | struct futex_hash_bucket *bh; | 865 | struct futex_hash_bucket *hb; |
547 | 866 | ||
548 | q->fd = fd; | 867 | q->fd = fd; |
549 | q->filp = filp; | 868 | q->filp = filp; |
@@ -551,23 +870,24 @@ queue_lock(struct futex_q *q, int fd, struct file *filp) | |||
551 | init_waitqueue_head(&q->waiters); | 870 | init_waitqueue_head(&q->waiters); |
552 | 871 | ||
553 | get_key_refs(&q->key); | 872 | get_key_refs(&q->key); |
554 | bh = hash_futex(&q->key); | 873 | hb = hash_futex(&q->key); |
555 | q->lock_ptr = &bh->lock; | 874 | q->lock_ptr = &hb->lock; |
556 | 875 | ||
557 | spin_lock(&bh->lock); | 876 | spin_lock(&hb->lock); |
558 | return bh; | 877 | return hb; |
559 | } | 878 | } |
560 | 879 | ||
561 | static inline void __queue_me(struct futex_q *q, struct futex_hash_bucket *bh) | 880 | static inline void __queue_me(struct futex_q *q, struct futex_hash_bucket *hb) |
562 | { | 881 | { |
563 | list_add_tail(&q->list, &bh->chain); | 882 | list_add_tail(&q->list, &hb->chain); |
564 | spin_unlock(&bh->lock); | 883 | q->task = current; |
884 | spin_unlock(&hb->lock); | ||
565 | } | 885 | } |
566 | 886 | ||
567 | static inline void | 887 | static inline void |
568 | queue_unlock(struct futex_q *q, struct futex_hash_bucket *bh) | 888 | queue_unlock(struct futex_q *q, struct futex_hash_bucket *hb) |
569 | { | 889 | { |
570 | spin_unlock(&bh->lock); | 890 | spin_unlock(&hb->lock); |
571 | drop_key_refs(&q->key); | 891 | drop_key_refs(&q->key); |
572 | } | 892 | } |
573 | 893 | ||
@@ -579,16 +899,17 @@ queue_unlock(struct futex_q *q, struct futex_hash_bucket *bh) | |||
579 | /* The key must be already stored in q->key. */ | 899 | /* The key must be already stored in q->key. */ |
580 | static void queue_me(struct futex_q *q, int fd, struct file *filp) | 900 | static void queue_me(struct futex_q *q, int fd, struct file *filp) |
581 | { | 901 | { |
582 | struct futex_hash_bucket *bh; | 902 | struct futex_hash_bucket *hb; |
583 | bh = queue_lock(q, fd, filp); | 903 | |
584 | __queue_me(q, bh); | 904 | hb = queue_lock(q, fd, filp); |
905 | __queue_me(q, hb); | ||
585 | } | 906 | } |
586 | 907 | ||
587 | /* Return 1 if we were still queued (ie. 0 means we were woken) */ | 908 | /* Return 1 if we were still queued (ie. 0 means we were woken) */ |
588 | static int unqueue_me(struct futex_q *q) | 909 | static int unqueue_me(struct futex_q *q) |
589 | { | 910 | { |
590 | int ret = 0; | ||
591 | spinlock_t *lock_ptr; | 911 | spinlock_t *lock_ptr; |
912 | int ret = 0; | ||
592 | 913 | ||
593 | /* In the common case we don't take the spinlock, which is nice. */ | 914 | /* In the common case we don't take the spinlock, which is nice. */ |
594 | retry: | 915 | retry: |
@@ -614,6 +935,9 @@ static int unqueue_me(struct futex_q *q) | |||
614 | } | 935 | } |
615 | WARN_ON(list_empty(&q->list)); | 936 | WARN_ON(list_empty(&q->list)); |
616 | list_del(&q->list); | 937 | list_del(&q->list); |
938 | |||
939 | BUG_ON(q->pi_state); | ||
940 | |||
617 | spin_unlock(lock_ptr); | 941 | spin_unlock(lock_ptr); |
618 | ret = 1; | 942 | ret = 1; |
619 | } | 943 | } |
@@ -622,21 +946,42 @@ static int unqueue_me(struct futex_q *q) | |||
622 | return ret; | 946 | return ret; |
623 | } | 947 | } |
624 | 948 | ||
625 | static int futex_wait(unsigned long uaddr, int val, unsigned long time) | 949 | /* |
950 | * PI futexes can not be requeued and must remove themself from the | ||
951 | * hash bucket. The hash bucket lock is held on entry and dropped here. | ||
952 | */ | ||
953 | static void unqueue_me_pi(struct futex_q *q, struct futex_hash_bucket *hb) | ||
626 | { | 954 | { |
627 | DECLARE_WAITQUEUE(wait, current); | 955 | WARN_ON(list_empty(&q->list)); |
628 | int ret, curval; | 956 | list_del(&q->list); |
957 | |||
958 | BUG_ON(!q->pi_state); | ||
959 | free_pi_state(q->pi_state); | ||
960 | q->pi_state = NULL; | ||
961 | |||
962 | spin_unlock(&hb->lock); | ||
963 | |||
964 | drop_key_refs(&q->key); | ||
965 | } | ||
966 | |||
967 | static int futex_wait(u32 __user *uaddr, u32 val, unsigned long time) | ||
968 | { | ||
969 | struct task_struct *curr = current; | ||
970 | DECLARE_WAITQUEUE(wait, curr); | ||
971 | struct futex_hash_bucket *hb; | ||
629 | struct futex_q q; | 972 | struct futex_q q; |
630 | struct futex_hash_bucket *bh; | 973 | u32 uval; |
974 | int ret; | ||
631 | 975 | ||
976 | q.pi_state = NULL; | ||
632 | retry: | 977 | retry: |
633 | down_read(¤t->mm->mmap_sem); | 978 | down_read(&curr->mm->mmap_sem); |
634 | 979 | ||
635 | ret = get_futex_key(uaddr, &q.key); | 980 | ret = get_futex_key(uaddr, &q.key); |
636 | if (unlikely(ret != 0)) | 981 | if (unlikely(ret != 0)) |
637 | goto out_release_sem; | 982 | goto out_release_sem; |
638 | 983 | ||
639 | bh = queue_lock(&q, -1, NULL); | 984 | hb = queue_lock(&q, -1, NULL); |
640 | 985 | ||
641 | /* | 986 | /* |
642 | * Access the page AFTER the futex is queued. | 987 | * Access the page AFTER the futex is queued. |
@@ -658,37 +1003,35 @@ static int futex_wait(unsigned long uaddr, int val, unsigned long time) | |||
658 | * We hold the mmap semaphore, so the mapping cannot have changed | 1003 | * We hold the mmap semaphore, so the mapping cannot have changed |
659 | * since we looked it up in get_futex_key. | 1004 | * since we looked it up in get_futex_key. |
660 | */ | 1005 | */ |
661 | 1006 | ret = get_futex_value_locked(&uval, uaddr); | |
662 | ret = get_futex_value_locked(&curval, (int __user *)uaddr); | ||
663 | 1007 | ||
664 | if (unlikely(ret)) { | 1008 | if (unlikely(ret)) { |
665 | queue_unlock(&q, bh); | 1009 | queue_unlock(&q, hb); |
666 | 1010 | ||
667 | /* If we would have faulted, release mmap_sem, fault it in and | 1011 | /* |
1012 | * If we would have faulted, release mmap_sem, fault it in and | ||
668 | * start all over again. | 1013 | * start all over again. |
669 | */ | 1014 | */ |
670 | up_read(¤t->mm->mmap_sem); | 1015 | up_read(&curr->mm->mmap_sem); |
671 | 1016 | ||
672 | ret = get_user(curval, (int __user *)uaddr); | 1017 | ret = get_user(uval, uaddr); |
673 | 1018 | ||
674 | if (!ret) | 1019 | if (!ret) |
675 | goto retry; | 1020 | goto retry; |
676 | return ret; | 1021 | return ret; |
677 | } | 1022 | } |
678 | if (curval != val) { | 1023 | ret = -EWOULDBLOCK; |
679 | ret = -EWOULDBLOCK; | 1024 | if (uval != val) |
680 | queue_unlock(&q, bh); | 1025 | goto out_unlock_release_sem; |
681 | goto out_release_sem; | ||
682 | } | ||
683 | 1026 | ||
684 | /* Only actually queue if *uaddr contained val. */ | 1027 | /* Only actually queue if *uaddr contained val. */ |
685 | __queue_me(&q, bh); | 1028 | __queue_me(&q, hb); |
686 | 1029 | ||
687 | /* | 1030 | /* |
688 | * Now the futex is queued and we have checked the data, we | 1031 | * Now the futex is queued and we have checked the data, we |
689 | * don't want to hold mmap_sem while we sleep. | 1032 | * don't want to hold mmap_sem while we sleep. |
690 | */ | 1033 | */ |
691 | up_read(¤t->mm->mmap_sem); | 1034 | up_read(&curr->mm->mmap_sem); |
692 | 1035 | ||
693 | /* | 1036 | /* |
694 | * There might have been scheduling since the queue_me(), as we | 1037 | * There might have been scheduling since the queue_me(), as we |
@@ -720,12 +1063,421 @@ static int futex_wait(unsigned long uaddr, int val, unsigned long time) | |||
720 | return 0; | 1063 | return 0; |
721 | if (time == 0) | 1064 | if (time == 0) |
722 | return -ETIMEDOUT; | 1065 | return -ETIMEDOUT; |
723 | /* We expect signal_pending(current), but another thread may | 1066 | /* |
724 | * have handled it for us already. */ | 1067 | * We expect signal_pending(current), but another thread may |
1068 | * have handled it for us already. | ||
1069 | */ | ||
725 | return -EINTR; | 1070 | return -EINTR; |
726 | 1071 | ||
1072 | out_unlock_release_sem: | ||
1073 | queue_unlock(&q, hb); | ||
1074 | |||
727 | out_release_sem: | 1075 | out_release_sem: |
1076 | up_read(&curr->mm->mmap_sem); | ||
1077 | return ret; | ||
1078 | } | ||
1079 | |||
1080 | /* | ||
1081 | * Userspace tried a 0 -> TID atomic transition of the futex value | ||
1082 | * and failed. The kernel side here does the whole locking operation: | ||
1083 | * if there are waiters then it will block, it does PI, etc. (Due to | ||
1084 | * races the kernel might see a 0 value of the futex too.) | ||
1085 | */ | ||
1086 | static int do_futex_lock_pi(u32 __user *uaddr, int detect, int trylock, | ||
1087 | struct hrtimer_sleeper *to) | ||
1088 | { | ||
1089 | struct task_struct *curr = current; | ||
1090 | struct futex_hash_bucket *hb; | ||
1091 | u32 uval, newval, curval; | ||
1092 | struct futex_q q; | ||
1093 | int ret, attempt = 0; | ||
1094 | |||
1095 | if (refill_pi_state_cache()) | ||
1096 | return -ENOMEM; | ||
1097 | |||
1098 | q.pi_state = NULL; | ||
1099 | retry: | ||
1100 | down_read(&curr->mm->mmap_sem); | ||
1101 | |||
1102 | ret = get_futex_key(uaddr, &q.key); | ||
1103 | if (unlikely(ret != 0)) | ||
1104 | goto out_release_sem; | ||
1105 | |||
1106 | hb = queue_lock(&q, -1, NULL); | ||
1107 | |||
1108 | retry_locked: | ||
1109 | /* | ||
1110 | * To avoid races, we attempt to take the lock here again | ||
1111 | * (by doing a 0 -> TID atomic cmpxchg), while holding all | ||
1112 | * the locks. It will most likely not succeed. | ||
1113 | */ | ||
1114 | newval = current->pid; | ||
1115 | |||
1116 | inc_preempt_count(); | ||
1117 | curval = futex_atomic_cmpxchg_inatomic(uaddr, 0, newval); | ||
1118 | dec_preempt_count(); | ||
1119 | |||
1120 | if (unlikely(curval == -EFAULT)) | ||
1121 | goto uaddr_faulted; | ||
1122 | |||
1123 | /* We own the lock already */ | ||
1124 | if (unlikely((curval & FUTEX_TID_MASK) == current->pid)) { | ||
1125 | if (!detect && 0) | ||
1126 | force_sig(SIGKILL, current); | ||
1127 | ret = -EDEADLK; | ||
1128 | goto out_unlock_release_sem; | ||
1129 | } | ||
1130 | |||
1131 | /* | ||
1132 | * Surprise - we got the lock. Just return | ||
1133 | * to userspace: | ||
1134 | */ | ||
1135 | if (unlikely(!curval)) | ||
1136 | goto out_unlock_release_sem; | ||
1137 | |||
1138 | uval = curval; | ||
1139 | newval = uval | FUTEX_WAITERS; | ||
1140 | |||
1141 | inc_preempt_count(); | ||
1142 | curval = futex_atomic_cmpxchg_inatomic(uaddr, uval, newval); | ||
1143 | dec_preempt_count(); | ||
1144 | |||
1145 | if (unlikely(curval == -EFAULT)) | ||
1146 | goto uaddr_faulted; | ||
1147 | if (unlikely(curval != uval)) | ||
1148 | goto retry_locked; | ||
1149 | |||
1150 | /* | ||
1151 | * We dont have the lock. Look up the PI state (or create it if | ||
1152 | * we are the first waiter): | ||
1153 | */ | ||
1154 | ret = lookup_pi_state(uval, hb, &q); | ||
1155 | |||
1156 | if (unlikely(ret)) { | ||
1157 | /* | ||
1158 | * There were no waiters and the owner task lookup | ||
1159 | * failed. When the OWNER_DIED bit is set, then we | ||
1160 | * know that this is a robust futex and we actually | ||
1161 | * take the lock. This is safe as we are protected by | ||
1162 | * the hash bucket lock. We also set the waiters bit | ||
1163 | * unconditionally here, to simplify glibc handling of | ||
1164 | * multiple tasks racing to acquire the lock and | ||
1165 | * cleanup the problems which were left by the dead | ||
1166 | * owner. | ||
1167 | */ | ||
1168 | if (curval & FUTEX_OWNER_DIED) { | ||
1169 | uval = newval; | ||
1170 | newval = current->pid | | ||
1171 | FUTEX_OWNER_DIED | FUTEX_WAITERS; | ||
1172 | |||
1173 | inc_preempt_count(); | ||
1174 | curval = futex_atomic_cmpxchg_inatomic(uaddr, | ||
1175 | uval, newval); | ||
1176 | dec_preempt_count(); | ||
1177 | |||
1178 | if (unlikely(curval == -EFAULT)) | ||
1179 | goto uaddr_faulted; | ||
1180 | if (unlikely(curval != uval)) | ||
1181 | goto retry_locked; | ||
1182 | ret = 0; | ||
1183 | } | ||
1184 | goto out_unlock_release_sem; | ||
1185 | } | ||
1186 | |||
1187 | /* | ||
1188 | * Only actually queue now that the atomic ops are done: | ||
1189 | */ | ||
1190 | __queue_me(&q, hb); | ||
1191 | |||
1192 | /* | ||
1193 | * Now the futex is queued and we have checked the data, we | ||
1194 | * don't want to hold mmap_sem while we sleep. | ||
1195 | */ | ||
1196 | up_read(&curr->mm->mmap_sem); | ||
1197 | |||
1198 | WARN_ON(!q.pi_state); | ||
1199 | /* | ||
1200 | * Block on the PI mutex: | ||
1201 | */ | ||
1202 | if (!trylock) | ||
1203 | ret = rt_mutex_timed_lock(&q.pi_state->pi_mutex, to, 1); | ||
1204 | else { | ||
1205 | ret = rt_mutex_trylock(&q.pi_state->pi_mutex); | ||
1206 | /* Fixup the trylock return value: */ | ||
1207 | ret = ret ? 0 : -EWOULDBLOCK; | ||
1208 | } | ||
1209 | |||
1210 | down_read(&curr->mm->mmap_sem); | ||
1211 | hb = queue_lock(&q, -1, NULL); | ||
1212 | |||
1213 | /* | ||
1214 | * Got the lock. We might not be the anticipated owner if we | ||
1215 | * did a lock-steal - fix up the PI-state in that case. | ||
1216 | */ | ||
1217 | if (!ret && q.pi_state->owner != curr) { | ||
1218 | u32 newtid = current->pid | FUTEX_WAITERS; | ||
1219 | |||
1220 | /* Owner died? */ | ||
1221 | if (q.pi_state->owner != NULL) { | ||
1222 | spin_lock_irq(&q.pi_state->owner->pi_lock); | ||
1223 | list_del_init(&q.pi_state->list); | ||
1224 | spin_unlock_irq(&q.pi_state->owner->pi_lock); | ||
1225 | } else | ||
1226 | newtid |= FUTEX_OWNER_DIED; | ||
1227 | |||
1228 | q.pi_state->owner = current; | ||
1229 | |||
1230 | spin_lock_irq(¤t->pi_lock); | ||
1231 | list_add(&q.pi_state->list, ¤t->pi_state_list); | ||
1232 | spin_unlock_irq(¤t->pi_lock); | ||
1233 | |||
1234 | /* Unqueue and drop the lock */ | ||
1235 | unqueue_me_pi(&q, hb); | ||
1236 | up_read(&curr->mm->mmap_sem); | ||
1237 | /* | ||
1238 | * We own it, so we have to replace the pending owner | ||
1239 | * TID. This must be atomic as we have preserve the | ||
1240 | * owner died bit here. | ||
1241 | */ | ||
1242 | ret = get_user(uval, uaddr); | ||
1243 | while (!ret) { | ||
1244 | newval = (uval & FUTEX_OWNER_DIED) | newtid; | ||
1245 | curval = futex_atomic_cmpxchg_inatomic(uaddr, | ||
1246 | uval, newval); | ||
1247 | if (curval == -EFAULT) | ||
1248 | ret = -EFAULT; | ||
1249 | if (curval == uval) | ||
1250 | break; | ||
1251 | uval = curval; | ||
1252 | } | ||
1253 | } else { | ||
1254 | /* | ||
1255 | * Catch the rare case, where the lock was released | ||
1256 | * when we were on the way back before we locked | ||
1257 | * the hash bucket. | ||
1258 | */ | ||
1259 | if (ret && q.pi_state->owner == curr) { | ||
1260 | if (rt_mutex_trylock(&q.pi_state->pi_mutex)) | ||
1261 | ret = 0; | ||
1262 | } | ||
1263 | /* Unqueue and drop the lock */ | ||
1264 | unqueue_me_pi(&q, hb); | ||
1265 | up_read(&curr->mm->mmap_sem); | ||
1266 | } | ||
1267 | |||
1268 | if (!detect && ret == -EDEADLK && 0) | ||
1269 | force_sig(SIGKILL, current); | ||
1270 | |||
1271 | return ret; | ||
1272 | |||
1273 | out_unlock_release_sem: | ||
1274 | queue_unlock(&q, hb); | ||
1275 | |||
1276 | out_release_sem: | ||
1277 | up_read(&curr->mm->mmap_sem); | ||
1278 | return ret; | ||
1279 | |||
1280 | uaddr_faulted: | ||
1281 | /* | ||
1282 | * We have to r/w *(int __user *)uaddr, but we can't modify it | ||
1283 | * non-atomically. Therefore, if get_user below is not | ||
1284 | * enough, we need to handle the fault ourselves, while | ||
1285 | * still holding the mmap_sem. | ||
1286 | */ | ||
1287 | if (attempt++) { | ||
1288 | if (futex_handle_fault((unsigned long)uaddr, attempt)) | ||
1289 | goto out_unlock_release_sem; | ||
1290 | |||
1291 | goto retry_locked; | ||
1292 | } | ||
1293 | |||
1294 | queue_unlock(&q, hb); | ||
1295 | up_read(&curr->mm->mmap_sem); | ||
1296 | |||
1297 | ret = get_user(uval, uaddr); | ||
1298 | if (!ret && (uval != -EFAULT)) | ||
1299 | goto retry; | ||
1300 | |||
1301 | return ret; | ||
1302 | } | ||
1303 | |||
1304 | /* | ||
1305 | * Restart handler | ||
1306 | */ | ||
1307 | static long futex_lock_pi_restart(struct restart_block *restart) | ||
1308 | { | ||
1309 | struct hrtimer_sleeper timeout, *to = NULL; | ||
1310 | int ret; | ||
1311 | |||
1312 | restart->fn = do_no_restart_syscall; | ||
1313 | |||
1314 | if (restart->arg2 || restart->arg3) { | ||
1315 | to = &timeout; | ||
1316 | hrtimer_init(&to->timer, CLOCK_REALTIME, HRTIMER_ABS); | ||
1317 | hrtimer_init_sleeper(to, current); | ||
1318 | to->timer.expires.tv64 = ((u64)restart->arg1 << 32) | | ||
1319 | (u64) restart->arg0; | ||
1320 | } | ||
1321 | |||
1322 | pr_debug("lock_pi restart: %p, %d (%d)\n", | ||
1323 | (u32 __user *)restart->arg0, current->pid); | ||
1324 | |||
1325 | ret = do_futex_lock_pi((u32 __user *)restart->arg0, restart->arg1, | ||
1326 | 0, to); | ||
1327 | |||
1328 | if (ret != -EINTR) | ||
1329 | return ret; | ||
1330 | |||
1331 | restart->fn = futex_lock_pi_restart; | ||
1332 | |||
1333 | /* The other values are filled in */ | ||
1334 | return -ERESTART_RESTARTBLOCK; | ||
1335 | } | ||
1336 | |||
1337 | /* | ||
1338 | * Called from the syscall entry below. | ||
1339 | */ | ||
1340 | static int futex_lock_pi(u32 __user *uaddr, int detect, unsigned long sec, | ||
1341 | long nsec, int trylock) | ||
1342 | { | ||
1343 | struct hrtimer_sleeper timeout, *to = NULL; | ||
1344 | struct restart_block *restart; | ||
1345 | int ret; | ||
1346 | |||
1347 | if (sec != MAX_SCHEDULE_TIMEOUT) { | ||
1348 | to = &timeout; | ||
1349 | hrtimer_init(&to->timer, CLOCK_REALTIME, HRTIMER_ABS); | ||
1350 | hrtimer_init_sleeper(to, current); | ||
1351 | to->timer.expires = ktime_set(sec, nsec); | ||
1352 | } | ||
1353 | |||
1354 | ret = do_futex_lock_pi(uaddr, detect, trylock, to); | ||
1355 | |||
1356 | if (ret != -EINTR) | ||
1357 | return ret; | ||
1358 | |||
1359 | pr_debug("lock_pi interrupted: %p, %d (%d)\n", uaddr, current->pid); | ||
1360 | |||
1361 | restart = ¤t_thread_info()->restart_block; | ||
1362 | restart->fn = futex_lock_pi_restart; | ||
1363 | restart->arg0 = (unsigned long) uaddr; | ||
1364 | restart->arg1 = detect; | ||
1365 | if (to) { | ||
1366 | restart->arg2 = to->timer.expires.tv64 & 0xFFFFFFFF; | ||
1367 | restart->arg3 = to->timer.expires.tv64 >> 32; | ||
1368 | } else | ||
1369 | restart->arg2 = restart->arg3 = 0; | ||
1370 | |||
1371 | return -ERESTART_RESTARTBLOCK; | ||
1372 | } | ||
1373 | |||
1374 | /* | ||
1375 | * Userspace attempted a TID -> 0 atomic transition, and failed. | ||
1376 | * This is the in-kernel slowpath: we look up the PI state (if any), | ||
1377 | * and do the rt-mutex unlock. | ||
1378 | */ | ||
1379 | static int futex_unlock_pi(u32 __user *uaddr) | ||
1380 | { | ||
1381 | struct futex_hash_bucket *hb; | ||
1382 | struct futex_q *this, *next; | ||
1383 | u32 uval; | ||
1384 | struct list_head *head; | ||
1385 | union futex_key key; | ||
1386 | int ret, attempt = 0; | ||
1387 | |||
1388 | retry: | ||
1389 | if (get_user(uval, uaddr)) | ||
1390 | return -EFAULT; | ||
1391 | /* | ||
1392 | * We release only a lock we actually own: | ||
1393 | */ | ||
1394 | if ((uval & FUTEX_TID_MASK) != current->pid) | ||
1395 | return -EPERM; | ||
1396 | /* | ||
1397 | * First take all the futex related locks: | ||
1398 | */ | ||
1399 | down_read(¤t->mm->mmap_sem); | ||
1400 | |||
1401 | ret = get_futex_key(uaddr, &key); | ||
1402 | if (unlikely(ret != 0)) | ||
1403 | goto out; | ||
1404 | |||
1405 | hb = hash_futex(&key); | ||
1406 | spin_lock(&hb->lock); | ||
1407 | |||
1408 | retry_locked: | ||
1409 | /* | ||
1410 | * To avoid races, try to do the TID -> 0 atomic transition | ||
1411 | * again. If it succeeds then we can return without waking | ||
1412 | * anyone else up: | ||
1413 | */ | ||
1414 | inc_preempt_count(); | ||
1415 | uval = futex_atomic_cmpxchg_inatomic(uaddr, current->pid, 0); | ||
1416 | dec_preempt_count(); | ||
1417 | |||
1418 | if (unlikely(uval == -EFAULT)) | ||
1419 | goto pi_faulted; | ||
1420 | /* | ||
1421 | * Rare case: we managed to release the lock atomically, | ||
1422 | * no need to wake anyone else up: | ||
1423 | */ | ||
1424 | if (unlikely(uval == current->pid)) | ||
1425 | goto out_unlock; | ||
1426 | |||
1427 | /* | ||
1428 | * Ok, other tasks may need to be woken up - check waiters | ||
1429 | * and do the wakeup if necessary: | ||
1430 | */ | ||
1431 | head = &hb->chain; | ||
1432 | |||
1433 | list_for_each_entry_safe(this, next, head, list) { | ||
1434 | if (!match_futex (&this->key, &key)) | ||
1435 | continue; | ||
1436 | ret = wake_futex_pi(uaddr, uval, this); | ||
1437 | /* | ||
1438 | * The atomic access to the futex value | ||
1439 | * generated a pagefault, so retry the | ||
1440 | * user-access and the wakeup: | ||
1441 | */ | ||
1442 | if (ret == -EFAULT) | ||
1443 | goto pi_faulted; | ||
1444 | goto out_unlock; | ||
1445 | } | ||
1446 | /* | ||
1447 | * No waiters - kernel unlocks the futex: | ||
1448 | */ | ||
1449 | ret = unlock_futex_pi(uaddr, uval); | ||
1450 | if (ret == -EFAULT) | ||
1451 | goto pi_faulted; | ||
1452 | |||
1453 | out_unlock: | ||
1454 | spin_unlock(&hb->lock); | ||
1455 | out: | ||
728 | up_read(¤t->mm->mmap_sem); | 1456 | up_read(¤t->mm->mmap_sem); |
1457 | |||
1458 | return ret; | ||
1459 | |||
1460 | pi_faulted: | ||
1461 | /* | ||
1462 | * We have to r/w *(int __user *)uaddr, but we can't modify it | ||
1463 | * non-atomically. Therefore, if get_user below is not | ||
1464 | * enough, we need to handle the fault ourselves, while | ||
1465 | * still holding the mmap_sem. | ||
1466 | */ | ||
1467 | if (attempt++) { | ||
1468 | if (futex_handle_fault((unsigned long)uaddr, attempt)) | ||
1469 | goto out_unlock; | ||
1470 | |||
1471 | goto retry_locked; | ||
1472 | } | ||
1473 | |||
1474 | spin_unlock(&hb->lock); | ||
1475 | up_read(¤t->mm->mmap_sem); | ||
1476 | |||
1477 | ret = get_user(uval, uaddr); | ||
1478 | if (!ret && (uval != -EFAULT)) | ||
1479 | goto retry; | ||
1480 | |||
729 | return ret; | 1481 | return ret; |
730 | } | 1482 | } |
731 | 1483 | ||
@@ -735,6 +1487,7 @@ static int futex_close(struct inode *inode, struct file *filp) | |||
735 | 1487 | ||
736 | unqueue_me(q); | 1488 | unqueue_me(q); |
737 | kfree(q); | 1489 | kfree(q); |
1490 | |||
738 | return 0; | 1491 | return 0; |
739 | } | 1492 | } |
740 | 1493 | ||
@@ -766,7 +1519,7 @@ static struct file_operations futex_fops = { | |||
766 | * Signal allows caller to avoid the race which would occur if they | 1519 | * Signal allows caller to avoid the race which would occur if they |
767 | * set the sigio stuff up afterwards. | 1520 | * set the sigio stuff up afterwards. |
768 | */ | 1521 | */ |
769 | static int futex_fd(unsigned long uaddr, int signal) | 1522 | static int futex_fd(u32 __user *uaddr, int signal) |
770 | { | 1523 | { |
771 | struct futex_q *q; | 1524 | struct futex_q *q; |
772 | struct file *filp; | 1525 | struct file *filp; |
@@ -803,6 +1556,7 @@ static int futex_fd(unsigned long uaddr, int signal) | |||
803 | err = -ENOMEM; | 1556 | err = -ENOMEM; |
804 | goto error; | 1557 | goto error; |
805 | } | 1558 | } |
1559 | q->pi_state = NULL; | ||
806 | 1560 | ||
807 | down_read(¤t->mm->mmap_sem); | 1561 | down_read(¤t->mm->mmap_sem); |
808 | err = get_futex_key(uaddr, &q->key); | 1562 | err = get_futex_key(uaddr, &q->key); |
@@ -840,7 +1594,7 @@ error: | |||
840 | * Implementation: user-space maintains a per-thread list of locks it | 1594 | * Implementation: user-space maintains a per-thread list of locks it |
841 | * is holding. Upon do_exit(), the kernel carefully walks this list, | 1595 | * is holding. Upon do_exit(), the kernel carefully walks this list, |
842 | * and marks all locks that are owned by this thread with the | 1596 | * and marks all locks that are owned by this thread with the |
843 | * FUTEX_OWNER_DEAD bit, and wakes up a waiter (if any). The list is | 1597 | * FUTEX_OWNER_DIED bit, and wakes up a waiter (if any). The list is |
844 | * always manipulated with the lock held, so the list is private and | 1598 | * always manipulated with the lock held, so the list is private and |
845 | * per-thread. Userspace also maintains a per-thread 'list_op_pending' | 1599 | * per-thread. Userspace also maintains a per-thread 'list_op_pending' |
846 | * field, to allow the kernel to clean up if the thread dies after | 1600 | * field, to allow the kernel to clean up if the thread dies after |
@@ -915,7 +1669,7 @@ err_unlock: | |||
915 | */ | 1669 | */ |
916 | int handle_futex_death(u32 __user *uaddr, struct task_struct *curr) | 1670 | int handle_futex_death(u32 __user *uaddr, struct task_struct *curr) |
917 | { | 1671 | { |
918 | u32 uval; | 1672 | u32 uval, nval; |
919 | 1673 | ||
920 | retry: | 1674 | retry: |
921 | if (get_user(uval, uaddr)) | 1675 | if (get_user(uval, uaddr)) |
@@ -932,12 +1686,16 @@ retry: | |||
932 | * thread-death.) The rest of the cleanup is done in | 1686 | * thread-death.) The rest of the cleanup is done in |
933 | * userspace. | 1687 | * userspace. |
934 | */ | 1688 | */ |
935 | if (futex_atomic_cmpxchg_inatomic(uaddr, uval, | 1689 | nval = futex_atomic_cmpxchg_inatomic(uaddr, uval, |
936 | uval | FUTEX_OWNER_DIED) != uval) | 1690 | uval | FUTEX_OWNER_DIED); |
1691 | if (nval == -EFAULT) | ||
1692 | return -1; | ||
1693 | |||
1694 | if (nval != uval) | ||
937 | goto retry; | 1695 | goto retry; |
938 | 1696 | ||
939 | if (uval & FUTEX_WAITERS) | 1697 | if (uval & FUTEX_WAITERS) |
940 | futex_wake((unsigned long)uaddr, 1); | 1698 | futex_wake(uaddr, 1); |
941 | } | 1699 | } |
942 | return 0; | 1700 | return 0; |
943 | } | 1701 | } |
@@ -978,7 +1736,7 @@ void exit_robust_list(struct task_struct *curr) | |||
978 | while (entry != &head->list) { | 1736 | while (entry != &head->list) { |
979 | /* | 1737 | /* |
980 | * A pending lock might already be on the list, so | 1738 | * A pending lock might already be on the list, so |
981 | * dont process it twice: | 1739 | * don't process it twice: |
982 | */ | 1740 | */ |
983 | if (entry != pending) | 1741 | if (entry != pending) |
984 | if (handle_futex_death((void *)entry + futex_offset, | 1742 | if (handle_futex_death((void *)entry + futex_offset, |
@@ -999,8 +1757,8 @@ void exit_robust_list(struct task_struct *curr) | |||
999 | } | 1757 | } |
1000 | } | 1758 | } |
1001 | 1759 | ||
1002 | long do_futex(unsigned long uaddr, int op, int val, unsigned long timeout, | 1760 | long do_futex(u32 __user *uaddr, int op, u32 val, unsigned long timeout, |
1003 | unsigned long uaddr2, int val2, int val3) | 1761 | u32 __user *uaddr2, u32 val2, u32 val3) |
1004 | { | 1762 | { |
1005 | int ret; | 1763 | int ret; |
1006 | 1764 | ||
@@ -1024,6 +1782,15 @@ long do_futex(unsigned long uaddr, int op, int val, unsigned long timeout, | |||
1024 | case FUTEX_WAKE_OP: | 1782 | case FUTEX_WAKE_OP: |
1025 | ret = futex_wake_op(uaddr, uaddr2, val, val2, val3); | 1783 | ret = futex_wake_op(uaddr, uaddr2, val, val2, val3); |
1026 | break; | 1784 | break; |
1785 | case FUTEX_LOCK_PI: | ||
1786 | ret = futex_lock_pi(uaddr, val, timeout, val2, 0); | ||
1787 | break; | ||
1788 | case FUTEX_UNLOCK_PI: | ||
1789 | ret = futex_unlock_pi(uaddr); | ||
1790 | break; | ||
1791 | case FUTEX_TRYLOCK_PI: | ||
1792 | ret = futex_lock_pi(uaddr, 0, timeout, val2, 1); | ||
1793 | break; | ||
1027 | default: | 1794 | default: |
1028 | ret = -ENOSYS; | 1795 | ret = -ENOSYS; |
1029 | } | 1796 | } |
@@ -1031,29 +1798,33 @@ long do_futex(unsigned long uaddr, int op, int val, unsigned long timeout, | |||
1031 | } | 1798 | } |
1032 | 1799 | ||
1033 | 1800 | ||
1034 | asmlinkage long sys_futex(u32 __user *uaddr, int op, int val, | 1801 | asmlinkage long sys_futex(u32 __user *uaddr, int op, u32 val, |
1035 | struct timespec __user *utime, u32 __user *uaddr2, | 1802 | struct timespec __user *utime, u32 __user *uaddr2, |
1036 | int val3) | 1803 | u32 val3) |
1037 | { | 1804 | { |
1038 | struct timespec t; | 1805 | struct timespec t; |
1039 | unsigned long timeout = MAX_SCHEDULE_TIMEOUT; | 1806 | unsigned long timeout = MAX_SCHEDULE_TIMEOUT; |
1040 | int val2 = 0; | 1807 | u32 val2 = 0; |
1041 | 1808 | ||
1042 | if (utime && (op == FUTEX_WAIT)) { | 1809 | if (utime && (op == FUTEX_WAIT || op == FUTEX_LOCK_PI)) { |
1043 | if (copy_from_user(&t, utime, sizeof(t)) != 0) | 1810 | if (copy_from_user(&t, utime, sizeof(t)) != 0) |
1044 | return -EFAULT; | 1811 | return -EFAULT; |
1045 | if (!timespec_valid(&t)) | 1812 | if (!timespec_valid(&t)) |
1046 | return -EINVAL; | 1813 | return -EINVAL; |
1047 | timeout = timespec_to_jiffies(&t) + 1; | 1814 | if (op == FUTEX_WAIT) |
1815 | timeout = timespec_to_jiffies(&t) + 1; | ||
1816 | else { | ||
1817 | timeout = t.tv_sec; | ||
1818 | val2 = t.tv_nsec; | ||
1819 | } | ||
1048 | } | 1820 | } |
1049 | /* | 1821 | /* |
1050 | * requeue parameter in 'utime' if op == FUTEX_REQUEUE. | 1822 | * requeue parameter in 'utime' if op == FUTEX_REQUEUE. |
1051 | */ | 1823 | */ |
1052 | if (op >= FUTEX_REQUEUE) | 1824 | if (op == FUTEX_REQUEUE || op == FUTEX_CMP_REQUEUE) |
1053 | val2 = (int) (unsigned long) utime; | 1825 | val2 = (u32) (unsigned long) utime; |
1054 | 1826 | ||
1055 | return do_futex((unsigned long)uaddr, op, val, timeout, | 1827 | return do_futex(uaddr, op, val, timeout, uaddr2, val2, val3); |
1056 | (unsigned long)uaddr2, val2, val3); | ||
1057 | } | 1828 | } |
1058 | 1829 | ||
1059 | static int futexfs_get_sb(struct file_system_type *fs_type, | 1830 | static int futexfs_get_sb(struct file_system_type *fs_type, |