diff options
Diffstat (limited to 'kernel/futex.c')
-rw-r--r-- | kernel/futex.c | 351 |
1 files changed, 136 insertions, 215 deletions
diff --git a/kernel/futex.c b/kernel/futex.c index 4fe790e89d0f..7c6cbabe52b3 100644 --- a/kernel/futex.c +++ b/kernel/futex.c | |||
@@ -92,11 +92,12 @@ struct futex_pi_state { | |||
92 | * A futex_q has a woken state, just like tasks have TASK_RUNNING. | 92 | * A futex_q has a woken state, just like tasks have TASK_RUNNING. |
93 | * It is considered woken when plist_node_empty(&q->list) || q->lock_ptr == 0. | 93 | * It is considered woken when plist_node_empty(&q->list) || q->lock_ptr == 0. |
94 | * The order of wakup is always to make the first condition true, then | 94 | * The order of wakup is always to make the first condition true, then |
95 | * wake up q->waiters, then make the second condition true. | 95 | * wake up q->waiter, then make the second condition true. |
96 | */ | 96 | */ |
97 | struct futex_q { | 97 | struct futex_q { |
98 | struct plist_node list; | 98 | struct plist_node list; |
99 | wait_queue_head_t waiters; | 99 | /* There can only be a single waiter */ |
100 | wait_queue_head_t waiter; | ||
100 | 101 | ||
101 | /* Which hash list lock to use: */ | 102 | /* Which hash list lock to use: */ |
102 | spinlock_t *lock_ptr; | 103 | spinlock_t *lock_ptr; |
@@ -123,24 +124,6 @@ struct futex_hash_bucket { | |||
123 | static struct futex_hash_bucket futex_queues[1<<FUTEX_HASHBITS]; | 124 | static struct futex_hash_bucket futex_queues[1<<FUTEX_HASHBITS]; |
124 | 125 | ||
125 | /* | 126 | /* |
126 | * Take mm->mmap_sem, when futex is shared | ||
127 | */ | ||
128 | static inline void futex_lock_mm(struct rw_semaphore *fshared) | ||
129 | { | ||
130 | if (fshared) | ||
131 | down_read(fshared); | ||
132 | } | ||
133 | |||
134 | /* | ||
135 | * Release mm->mmap_sem, when the futex is shared | ||
136 | */ | ||
137 | static inline void futex_unlock_mm(struct rw_semaphore *fshared) | ||
138 | { | ||
139 | if (fshared) | ||
140 | up_read(fshared); | ||
141 | } | ||
142 | |||
143 | /* | ||
144 | * We hash on the keys returned from get_futex_key (see below). | 127 | * We hash on the keys returned from get_futex_key (see below). |
145 | */ | 128 | */ |
146 | static struct futex_hash_bucket *hash_futex(union futex_key *key) | 129 | static struct futex_hash_bucket *hash_futex(union futex_key *key) |
@@ -161,6 +144,45 @@ static inline int match_futex(union futex_key *key1, union futex_key *key2) | |||
161 | && key1->both.offset == key2->both.offset); | 144 | && key1->both.offset == key2->both.offset); |
162 | } | 145 | } |
163 | 146 | ||
147 | /* | ||
148 | * Take a reference to the resource addressed by a key. | ||
149 | * Can be called while holding spinlocks. | ||
150 | * | ||
151 | */ | ||
152 | static void get_futex_key_refs(union futex_key *key) | ||
153 | { | ||
154 | if (!key->both.ptr) | ||
155 | return; | ||
156 | |||
157 | switch (key->both.offset & (FUT_OFF_INODE|FUT_OFF_MMSHARED)) { | ||
158 | case FUT_OFF_INODE: | ||
159 | atomic_inc(&key->shared.inode->i_count); | ||
160 | break; | ||
161 | case FUT_OFF_MMSHARED: | ||
162 | atomic_inc(&key->private.mm->mm_count); | ||
163 | break; | ||
164 | } | ||
165 | } | ||
166 | |||
167 | /* | ||
168 | * Drop a reference to the resource addressed by a key. | ||
169 | * The hash bucket spinlock must not be held. | ||
170 | */ | ||
171 | static void drop_futex_key_refs(union futex_key *key) | ||
172 | { | ||
173 | if (!key->both.ptr) | ||
174 | return; | ||
175 | |||
176 | switch (key->both.offset & (FUT_OFF_INODE|FUT_OFF_MMSHARED)) { | ||
177 | case FUT_OFF_INODE: | ||
178 | iput(key->shared.inode); | ||
179 | break; | ||
180 | case FUT_OFF_MMSHARED: | ||
181 | mmdrop(key->private.mm); | ||
182 | break; | ||
183 | } | ||
184 | } | ||
185 | |||
164 | /** | 186 | /** |
165 | * get_futex_key - Get parameters which are the keys for a futex. | 187 | * get_futex_key - Get parameters which are the keys for a futex. |
166 | * @uaddr: virtual address of the futex | 188 | * @uaddr: virtual address of the futex |
@@ -179,12 +201,10 @@ static inline int match_futex(union futex_key *key1, union futex_key *key2) | |||
179 | * For other futexes, it points to ¤t->mm->mmap_sem and | 201 | * For other futexes, it points to ¤t->mm->mmap_sem and |
180 | * caller must have taken the reader lock. but NOT any spinlocks. | 202 | * caller must have taken the reader lock. but NOT any spinlocks. |
181 | */ | 203 | */ |
182 | static int get_futex_key(u32 __user *uaddr, struct rw_semaphore *fshared, | 204 | static int get_futex_key(u32 __user *uaddr, int fshared, union futex_key *key) |
183 | union futex_key *key) | ||
184 | { | 205 | { |
185 | unsigned long address = (unsigned long)uaddr; | 206 | unsigned long address = (unsigned long)uaddr; |
186 | struct mm_struct *mm = current->mm; | 207 | struct mm_struct *mm = current->mm; |
187 | struct vm_area_struct *vma; | ||
188 | struct page *page; | 208 | struct page *page; |
189 | int err; | 209 | int err; |
190 | 210 | ||
@@ -208,100 +228,50 @@ static int get_futex_key(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
208 | return -EFAULT; | 228 | return -EFAULT; |
209 | key->private.mm = mm; | 229 | key->private.mm = mm; |
210 | key->private.address = address; | 230 | key->private.address = address; |
231 | get_futex_key_refs(key); | ||
211 | return 0; | 232 | return 0; |
212 | } | 233 | } |
213 | /* | ||
214 | * The futex is hashed differently depending on whether | ||
215 | * it's in a shared or private mapping. So check vma first. | ||
216 | */ | ||
217 | vma = find_extend_vma(mm, address); | ||
218 | if (unlikely(!vma)) | ||
219 | return -EFAULT; | ||
220 | 234 | ||
221 | /* | 235 | again: |
222 | * Permissions. | 236 | err = get_user_pages_fast(address, 1, 0, &page); |
223 | */ | 237 | if (err < 0) |
224 | if (unlikely((vma->vm_flags & (VM_IO|VM_READ)) != VM_READ)) | 238 | return err; |
225 | return (vma->vm_flags & VM_IO) ? -EPERM : -EACCES; | 239 | |
240 | lock_page(page); | ||
241 | if (!page->mapping) { | ||
242 | unlock_page(page); | ||
243 | put_page(page); | ||
244 | goto again; | ||
245 | } | ||
226 | 246 | ||
227 | /* | 247 | /* |
228 | * Private mappings are handled in a simple way. | 248 | * Private mappings are handled in a simple way. |
229 | * | 249 | * |
230 | * NOTE: When userspace waits on a MAP_SHARED mapping, even if | 250 | * NOTE: When userspace waits on a MAP_SHARED mapping, even if |
231 | * it's a read-only handle, it's expected that futexes attach to | 251 | * it's a read-only handle, it's expected that futexes attach to |
232 | * the object not the particular process. Therefore we use | 252 | * the object not the particular process. |
233 | * VM_MAYSHARE here, not VM_SHARED which is restricted to shared | ||
234 | * mappings of _writable_ handles. | ||
235 | */ | 253 | */ |
236 | if (likely(!(vma->vm_flags & VM_MAYSHARE))) { | 254 | if (PageAnon(page)) { |
237 | key->both.offset |= FUT_OFF_MMSHARED; /* reference taken on mm */ | 255 | key->both.offset |= FUT_OFF_MMSHARED; /* ref taken on mm */ |
238 | key->private.mm = mm; | 256 | key->private.mm = mm; |
239 | key->private.address = address; | 257 | key->private.address = address; |
240 | return 0; | 258 | } else { |
259 | key->both.offset |= FUT_OFF_INODE; /* inode-based key */ | ||
260 | key->shared.inode = page->mapping->host; | ||
261 | key->shared.pgoff = page->index; | ||
241 | } | 262 | } |
242 | 263 | ||
243 | /* | 264 | get_futex_key_refs(key); |
244 | * Linear file mappings are also simple. | ||
245 | */ | ||
246 | key->shared.inode = vma->vm_file->f_path.dentry->d_inode; | ||
247 | key->both.offset |= FUT_OFF_INODE; /* inode-based key. */ | ||
248 | if (likely(!(vma->vm_flags & VM_NONLINEAR))) { | ||
249 | key->shared.pgoff = (((address - vma->vm_start) >> PAGE_SHIFT) | ||
250 | + vma->vm_pgoff); | ||
251 | return 0; | ||
252 | } | ||
253 | 265 | ||
254 | /* | 266 | unlock_page(page); |
255 | * We could walk the page table to read the non-linear | 267 | put_page(page); |
256 | * pte, and get the page index without fetching the page | 268 | return 0; |
257 | * from swap. But that's a lot of code to duplicate here | ||
258 | * for a rare case, so we simply fetch the page. | ||
259 | */ | ||
260 | err = get_user_pages(current, mm, address, 1, 0, 0, &page, NULL); | ||
261 | if (err >= 0) { | ||
262 | key->shared.pgoff = | ||
263 | page->index << (PAGE_CACHE_SHIFT - PAGE_SHIFT); | ||
264 | put_page(page); | ||
265 | return 0; | ||
266 | } | ||
267 | return err; | ||
268 | } | ||
269 | |||
270 | /* | ||
271 | * Take a reference to the resource addressed by a key. | ||
272 | * Can be called while holding spinlocks. | ||
273 | * | ||
274 | */ | ||
275 | static void get_futex_key_refs(union futex_key *key) | ||
276 | { | ||
277 | if (key->both.ptr == NULL) | ||
278 | return; | ||
279 | switch (key->both.offset & (FUT_OFF_INODE|FUT_OFF_MMSHARED)) { | ||
280 | case FUT_OFF_INODE: | ||
281 | atomic_inc(&key->shared.inode->i_count); | ||
282 | break; | ||
283 | case FUT_OFF_MMSHARED: | ||
284 | atomic_inc(&key->private.mm->mm_count); | ||
285 | break; | ||
286 | } | ||
287 | } | 269 | } |
288 | 270 | ||
289 | /* | 271 | static inline |
290 | * Drop a reference to the resource addressed by a key. | 272 | void put_futex_key(int fshared, union futex_key *key) |
291 | * The hash bucket spinlock must not be held. | ||
292 | */ | ||
293 | static void drop_futex_key_refs(union futex_key *key) | ||
294 | { | 273 | { |
295 | if (!key->both.ptr) | 274 | drop_futex_key_refs(key); |
296 | return; | ||
297 | switch (key->both.offset & (FUT_OFF_INODE|FUT_OFF_MMSHARED)) { | ||
298 | case FUT_OFF_INODE: | ||
299 | iput(key->shared.inode); | ||
300 | break; | ||
301 | case FUT_OFF_MMSHARED: | ||
302 | mmdrop(key->private.mm); | ||
303 | break; | ||
304 | } | ||
305 | } | 275 | } |
306 | 276 | ||
307 | static u32 cmpxchg_futex_value_locked(u32 __user *uaddr, u32 uval, u32 newval) | 277 | static u32 cmpxchg_futex_value_locked(u32 __user *uaddr, u32 uval, u32 newval) |
@@ -328,10 +298,8 @@ static int get_futex_value_locked(u32 *dest, u32 __user *from) | |||
328 | 298 | ||
329 | /* | 299 | /* |
330 | * Fault handling. | 300 | * Fault handling. |
331 | * if fshared is non NULL, current->mm->mmap_sem is already held | ||
332 | */ | 301 | */ |
333 | static int futex_handle_fault(unsigned long address, | 302 | static int futex_handle_fault(unsigned long address, int attempt) |
334 | struct rw_semaphore *fshared, int attempt) | ||
335 | { | 303 | { |
336 | struct vm_area_struct * vma; | 304 | struct vm_area_struct * vma; |
337 | struct mm_struct *mm = current->mm; | 305 | struct mm_struct *mm = current->mm; |
@@ -340,8 +308,7 @@ static int futex_handle_fault(unsigned long address, | |||
340 | if (attempt > 2) | 308 | if (attempt > 2) |
341 | return ret; | 309 | return ret; |
342 | 310 | ||
343 | if (!fshared) | 311 | down_read(&mm->mmap_sem); |
344 | down_read(&mm->mmap_sem); | ||
345 | vma = find_vma(mm, address); | 312 | vma = find_vma(mm, address); |
346 | if (vma && address >= vma->vm_start && | 313 | if (vma && address >= vma->vm_start && |
347 | (vma->vm_flags & VM_WRITE)) { | 314 | (vma->vm_flags & VM_WRITE)) { |
@@ -361,8 +328,7 @@ static int futex_handle_fault(unsigned long address, | |||
361 | current->min_flt++; | 328 | current->min_flt++; |
362 | } | 329 | } |
363 | } | 330 | } |
364 | if (!fshared) | 331 | up_read(&mm->mmap_sem); |
365 | up_read(&mm->mmap_sem); | ||
366 | return ret; | 332 | return ret; |
367 | } | 333 | } |
368 | 334 | ||
@@ -385,6 +351,7 @@ static int refill_pi_state_cache(void) | |||
385 | /* pi_mutex gets initialized later */ | 351 | /* pi_mutex gets initialized later */ |
386 | pi_state->owner = NULL; | 352 | pi_state->owner = NULL; |
387 | atomic_set(&pi_state->refcount, 1); | 353 | atomic_set(&pi_state->refcount, 1); |
354 | pi_state->key = FUTEX_KEY_INIT; | ||
388 | 355 | ||
389 | current->pi_state_cache = pi_state; | 356 | current->pi_state_cache = pi_state; |
390 | 357 | ||
@@ -469,7 +436,7 @@ void exit_pi_state_list(struct task_struct *curr) | |||
469 | struct list_head *next, *head = &curr->pi_state_list; | 436 | struct list_head *next, *head = &curr->pi_state_list; |
470 | struct futex_pi_state *pi_state; | 437 | struct futex_pi_state *pi_state; |
471 | struct futex_hash_bucket *hb; | 438 | struct futex_hash_bucket *hb; |
472 | union futex_key key; | 439 | union futex_key key = FUTEX_KEY_INIT; |
473 | 440 | ||
474 | if (!futex_cmpxchg_enabled) | 441 | if (!futex_cmpxchg_enabled) |
475 | return; | 442 | return; |
@@ -614,7 +581,7 @@ static void wake_futex(struct futex_q *q) | |||
614 | * The lock in wake_up_all() is a crucial memory barrier after the | 581 | * The lock in wake_up_all() is a crucial memory barrier after the |
615 | * plist_del() and also before assigning to q->lock_ptr. | 582 | * plist_del() and also before assigning to q->lock_ptr. |
616 | */ | 583 | */ |
617 | wake_up_all(&q->waiters); | 584 | wake_up(&q->waiter); |
618 | /* | 585 | /* |
619 | * The waiting task can free the futex_q as soon as this is written, | 586 | * The waiting task can free the futex_q as soon as this is written, |
620 | * without taking any locks. This must come last. | 587 | * without taking any locks. This must come last. |
@@ -726,20 +693,17 @@ double_lock_hb(struct futex_hash_bucket *hb1, struct futex_hash_bucket *hb2) | |||
726 | * Wake up all waiters hashed on the physical page that is mapped | 693 | * Wake up all waiters hashed on the physical page that is mapped |
727 | * to this virtual address: | 694 | * to this virtual address: |
728 | */ | 695 | */ |
729 | static int futex_wake(u32 __user *uaddr, struct rw_semaphore *fshared, | 696 | static int futex_wake(u32 __user *uaddr, int fshared, int nr_wake, u32 bitset) |
730 | int nr_wake, u32 bitset) | ||
731 | { | 697 | { |
732 | struct futex_hash_bucket *hb; | 698 | struct futex_hash_bucket *hb; |
733 | struct futex_q *this, *next; | 699 | struct futex_q *this, *next; |
734 | struct plist_head *head; | 700 | struct plist_head *head; |
735 | union futex_key key; | 701 | union futex_key key = FUTEX_KEY_INIT; |
736 | int ret; | 702 | int ret; |
737 | 703 | ||
738 | if (!bitset) | 704 | if (!bitset) |
739 | return -EINVAL; | 705 | return -EINVAL; |
740 | 706 | ||
741 | futex_lock_mm(fshared); | ||
742 | |||
743 | ret = get_futex_key(uaddr, fshared, &key); | 707 | ret = get_futex_key(uaddr, fshared, &key); |
744 | if (unlikely(ret != 0)) | 708 | if (unlikely(ret != 0)) |
745 | goto out; | 709 | goto out; |
@@ -767,7 +731,7 @@ static int futex_wake(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
767 | 731 | ||
768 | spin_unlock(&hb->lock); | 732 | spin_unlock(&hb->lock); |
769 | out: | 733 | out: |
770 | futex_unlock_mm(fshared); | 734 | put_futex_key(fshared, &key); |
771 | return ret; | 735 | return ret; |
772 | } | 736 | } |
773 | 737 | ||
@@ -776,19 +740,16 @@ out: | |||
776 | * to this virtual address: | 740 | * to this virtual address: |
777 | */ | 741 | */ |
778 | static int | 742 | static int |
779 | futex_wake_op(u32 __user *uaddr1, struct rw_semaphore *fshared, | 743 | futex_wake_op(u32 __user *uaddr1, int fshared, u32 __user *uaddr2, |
780 | u32 __user *uaddr2, | ||
781 | int nr_wake, int nr_wake2, int op) | 744 | int nr_wake, int nr_wake2, int op) |
782 | { | 745 | { |
783 | union futex_key key1, key2; | 746 | union futex_key key1 = FUTEX_KEY_INIT, key2 = FUTEX_KEY_INIT; |
784 | struct futex_hash_bucket *hb1, *hb2; | 747 | struct futex_hash_bucket *hb1, *hb2; |
785 | struct plist_head *head; | 748 | struct plist_head *head; |
786 | struct futex_q *this, *next; | 749 | struct futex_q *this, *next; |
787 | int ret, op_ret, attempt = 0; | 750 | int ret, op_ret, attempt = 0; |
788 | 751 | ||
789 | retryfull: | 752 | retryfull: |
790 | futex_lock_mm(fshared); | ||
791 | |||
792 | ret = get_futex_key(uaddr1, fshared, &key1); | 753 | ret = get_futex_key(uaddr1, fshared, &key1); |
793 | if (unlikely(ret != 0)) | 754 | if (unlikely(ret != 0)) |
794 | goto out; | 755 | goto out; |
@@ -833,18 +794,12 @@ retry: | |||
833 | */ | 794 | */ |
834 | if (attempt++) { | 795 | if (attempt++) { |
835 | ret = futex_handle_fault((unsigned long)uaddr2, | 796 | ret = futex_handle_fault((unsigned long)uaddr2, |
836 | fshared, attempt); | 797 | attempt); |
837 | if (ret) | 798 | if (ret) |
838 | goto out; | 799 | goto out; |
839 | goto retry; | 800 | goto retry; |
840 | } | 801 | } |
841 | 802 | ||
842 | /* | ||
843 | * If we would have faulted, release mmap_sem, | ||
844 | * fault it in and start all over again. | ||
845 | */ | ||
846 | futex_unlock_mm(fshared); | ||
847 | |||
848 | ret = get_user(dummy, uaddr2); | 803 | ret = get_user(dummy, uaddr2); |
849 | if (ret) | 804 | if (ret) |
850 | return ret; | 805 | return ret; |
@@ -880,7 +835,8 @@ retry: | |||
880 | if (hb1 != hb2) | 835 | if (hb1 != hb2) |
881 | spin_unlock(&hb2->lock); | 836 | spin_unlock(&hb2->lock); |
882 | out: | 837 | out: |
883 | futex_unlock_mm(fshared); | 838 | put_futex_key(fshared, &key2); |
839 | put_futex_key(fshared, &key1); | ||
884 | 840 | ||
885 | return ret; | 841 | return ret; |
886 | } | 842 | } |
@@ -889,19 +845,16 @@ out: | |||
889 | * Requeue all waiters hashed on one physical page to another | 845 | * Requeue all waiters hashed on one physical page to another |
890 | * physical page. | 846 | * physical page. |
891 | */ | 847 | */ |
892 | static int futex_requeue(u32 __user *uaddr1, struct rw_semaphore *fshared, | 848 | static int futex_requeue(u32 __user *uaddr1, int fshared, u32 __user *uaddr2, |
893 | u32 __user *uaddr2, | ||
894 | int nr_wake, int nr_requeue, u32 *cmpval) | 849 | int nr_wake, int nr_requeue, u32 *cmpval) |
895 | { | 850 | { |
896 | union futex_key key1, key2; | 851 | union futex_key key1 = FUTEX_KEY_INIT, key2 = FUTEX_KEY_INIT; |
897 | struct futex_hash_bucket *hb1, *hb2; | 852 | struct futex_hash_bucket *hb1, *hb2; |
898 | struct plist_head *head1; | 853 | struct plist_head *head1; |
899 | struct futex_q *this, *next; | 854 | struct futex_q *this, *next; |
900 | int ret, drop_count = 0; | 855 | int ret, drop_count = 0; |
901 | 856 | ||
902 | retry: | 857 | retry: |
903 | futex_lock_mm(fshared); | ||
904 | |||
905 | ret = get_futex_key(uaddr1, fshared, &key1); | 858 | ret = get_futex_key(uaddr1, fshared, &key1); |
906 | if (unlikely(ret != 0)) | 859 | if (unlikely(ret != 0)) |
907 | goto out; | 860 | goto out; |
@@ -924,12 +877,6 @@ static int futex_requeue(u32 __user *uaddr1, struct rw_semaphore *fshared, | |||
924 | if (hb1 != hb2) | 877 | if (hb1 != hb2) |
925 | spin_unlock(&hb2->lock); | 878 | spin_unlock(&hb2->lock); |
926 | 879 | ||
927 | /* | ||
928 | * If we would have faulted, release mmap_sem, fault | ||
929 | * it in and start all over again. | ||
930 | */ | ||
931 | futex_unlock_mm(fshared); | ||
932 | |||
933 | ret = get_user(curval, uaddr1); | 880 | ret = get_user(curval, uaddr1); |
934 | 881 | ||
935 | if (!ret) | 882 | if (!ret) |
@@ -981,7 +928,8 @@ out_unlock: | |||
981 | drop_futex_key_refs(&key1); | 928 | drop_futex_key_refs(&key1); |
982 | 929 | ||
983 | out: | 930 | out: |
984 | futex_unlock_mm(fshared); | 931 | put_futex_key(fshared, &key2); |
932 | put_futex_key(fshared, &key1); | ||
985 | return ret; | 933 | return ret; |
986 | } | 934 | } |
987 | 935 | ||
@@ -990,7 +938,7 @@ static inline struct futex_hash_bucket *queue_lock(struct futex_q *q) | |||
990 | { | 938 | { |
991 | struct futex_hash_bucket *hb; | 939 | struct futex_hash_bucket *hb; |
992 | 940 | ||
993 | init_waitqueue_head(&q->waiters); | 941 | init_waitqueue_head(&q->waiter); |
994 | 942 | ||
995 | get_futex_key_refs(&q->key); | 943 | get_futex_key_refs(&q->key); |
996 | hb = hash_futex(&q->key); | 944 | hb = hash_futex(&q->key); |
@@ -1103,8 +1051,7 @@ static void unqueue_me_pi(struct futex_q *q) | |||
1103 | * private futexes. | 1051 | * private futexes. |
1104 | */ | 1052 | */ |
1105 | static int fixup_pi_state_owner(u32 __user *uaddr, struct futex_q *q, | 1053 | static int fixup_pi_state_owner(u32 __user *uaddr, struct futex_q *q, |
1106 | struct task_struct *newowner, | 1054 | struct task_struct *newowner, int fshared) |
1107 | struct rw_semaphore *fshared) | ||
1108 | { | 1055 | { |
1109 | u32 newtid = task_pid_vnr(newowner) | FUTEX_WAITERS; | 1056 | u32 newtid = task_pid_vnr(newowner) | FUTEX_WAITERS; |
1110 | struct futex_pi_state *pi_state = q->pi_state; | 1057 | struct futex_pi_state *pi_state = q->pi_state; |
@@ -1183,7 +1130,7 @@ retry: | |||
1183 | handle_fault: | 1130 | handle_fault: |
1184 | spin_unlock(q->lock_ptr); | 1131 | spin_unlock(q->lock_ptr); |
1185 | 1132 | ||
1186 | ret = futex_handle_fault((unsigned long)uaddr, fshared, attempt++); | 1133 | ret = futex_handle_fault((unsigned long)uaddr, attempt++); |
1187 | 1134 | ||
1188 | spin_lock(q->lock_ptr); | 1135 | spin_lock(q->lock_ptr); |
1189 | 1136 | ||
@@ -1203,12 +1150,13 @@ handle_fault: | |||
1203 | * In case we must use restart_block to restart a futex_wait, | 1150 | * In case we must use restart_block to restart a futex_wait, |
1204 | * we encode in the 'flags' shared capability | 1151 | * we encode in the 'flags' shared capability |
1205 | */ | 1152 | */ |
1206 | #define FLAGS_SHARED 1 | 1153 | #define FLAGS_SHARED 0x01 |
1154 | #define FLAGS_CLOCKRT 0x02 | ||
1207 | 1155 | ||
1208 | static long futex_wait_restart(struct restart_block *restart); | 1156 | static long futex_wait_restart(struct restart_block *restart); |
1209 | 1157 | ||
1210 | static int futex_wait(u32 __user *uaddr, struct rw_semaphore *fshared, | 1158 | static int futex_wait(u32 __user *uaddr, int fshared, |
1211 | u32 val, ktime_t *abs_time, u32 bitset) | 1159 | u32 val, ktime_t *abs_time, u32 bitset, int clockrt) |
1212 | { | 1160 | { |
1213 | struct task_struct *curr = current; | 1161 | struct task_struct *curr = current; |
1214 | DECLARE_WAITQUEUE(wait, curr); | 1162 | DECLARE_WAITQUEUE(wait, curr); |
@@ -1225,8 +1173,7 @@ static int futex_wait(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1225 | q.pi_state = NULL; | 1173 | q.pi_state = NULL; |
1226 | q.bitset = bitset; | 1174 | q.bitset = bitset; |
1227 | retry: | 1175 | retry: |
1228 | futex_lock_mm(fshared); | 1176 | q.key = FUTEX_KEY_INIT; |
1229 | |||
1230 | ret = get_futex_key(uaddr, fshared, &q.key); | 1177 | ret = get_futex_key(uaddr, fshared, &q.key); |
1231 | if (unlikely(ret != 0)) | 1178 | if (unlikely(ret != 0)) |
1232 | goto out_release_sem; | 1179 | goto out_release_sem; |
@@ -1258,12 +1205,6 @@ static int futex_wait(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1258 | if (unlikely(ret)) { | 1205 | if (unlikely(ret)) { |
1259 | queue_unlock(&q, hb); | 1206 | queue_unlock(&q, hb); |
1260 | 1207 | ||
1261 | /* | ||
1262 | * If we would have faulted, release mmap_sem, fault it in and | ||
1263 | * start all over again. | ||
1264 | */ | ||
1265 | futex_unlock_mm(fshared); | ||
1266 | |||
1267 | ret = get_user(uval, uaddr); | 1208 | ret = get_user(uval, uaddr); |
1268 | 1209 | ||
1269 | if (!ret) | 1210 | if (!ret) |
@@ -1278,12 +1219,6 @@ static int futex_wait(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1278 | queue_me(&q, hb); | 1219 | queue_me(&q, hb); |
1279 | 1220 | ||
1280 | /* | 1221 | /* |
1281 | * Now the futex is queued and we have checked the data, we | ||
1282 | * don't want to hold mmap_sem while we sleep. | ||
1283 | */ | ||
1284 | futex_unlock_mm(fshared); | ||
1285 | |||
1286 | /* | ||
1287 | * There might have been scheduling since the queue_me(), as we | 1222 | * There might have been scheduling since the queue_me(), as we |
1288 | * cannot hold a spinlock across the get_user() in case it | 1223 | * cannot hold a spinlock across the get_user() in case it |
1289 | * faults, and we cannot just set TASK_INTERRUPTIBLE state when | 1224 | * faults, and we cannot just set TASK_INTERRUPTIBLE state when |
@@ -1294,7 +1229,7 @@ static int futex_wait(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1294 | 1229 | ||
1295 | /* add_wait_queue is the barrier after __set_current_state. */ | 1230 | /* add_wait_queue is the barrier after __set_current_state. */ |
1296 | __set_current_state(TASK_INTERRUPTIBLE); | 1231 | __set_current_state(TASK_INTERRUPTIBLE); |
1297 | add_wait_queue(&q.waiters, &wait); | 1232 | add_wait_queue(&q.waiter, &wait); |
1298 | /* | 1233 | /* |
1299 | * !plist_node_empty() is safe here without any lock. | 1234 | * !plist_node_empty() is safe here without any lock. |
1300 | * q.lock_ptr != 0 is not safe, because of ordering against wakeup. | 1235 | * q.lock_ptr != 0 is not safe, because of ordering against wakeup. |
@@ -1307,8 +1242,10 @@ static int futex_wait(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1307 | slack = current->timer_slack_ns; | 1242 | slack = current->timer_slack_ns; |
1308 | if (rt_task(current)) | 1243 | if (rt_task(current)) |
1309 | slack = 0; | 1244 | slack = 0; |
1310 | hrtimer_init_on_stack(&t.timer, CLOCK_MONOTONIC, | 1245 | hrtimer_init_on_stack(&t.timer, |
1311 | HRTIMER_MODE_ABS); | 1246 | clockrt ? CLOCK_REALTIME : |
1247 | CLOCK_MONOTONIC, | ||
1248 | HRTIMER_MODE_ABS); | ||
1312 | hrtimer_init_sleeper(&t, current); | 1249 | hrtimer_init_sleeper(&t, current); |
1313 | hrtimer_set_expires_range_ns(&t.timer, *abs_time, slack); | 1250 | hrtimer_set_expires_range_ns(&t.timer, *abs_time, slack); |
1314 | 1251 | ||
@@ -1363,6 +1300,8 @@ static int futex_wait(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1363 | 1300 | ||
1364 | if (fshared) | 1301 | if (fshared) |
1365 | restart->futex.flags |= FLAGS_SHARED; | 1302 | restart->futex.flags |= FLAGS_SHARED; |
1303 | if (clockrt) | ||
1304 | restart->futex.flags |= FLAGS_CLOCKRT; | ||
1366 | return -ERESTART_RESTARTBLOCK; | 1305 | return -ERESTART_RESTARTBLOCK; |
1367 | } | 1306 | } |
1368 | 1307 | ||
@@ -1370,7 +1309,7 @@ static int futex_wait(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1370 | queue_unlock(&q, hb); | 1309 | queue_unlock(&q, hb); |
1371 | 1310 | ||
1372 | out_release_sem: | 1311 | out_release_sem: |
1373 | futex_unlock_mm(fshared); | 1312 | put_futex_key(fshared, &q.key); |
1374 | return ret; | 1313 | return ret; |
1375 | } | 1314 | } |
1376 | 1315 | ||
@@ -1378,15 +1317,16 @@ static int futex_wait(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1378 | static long futex_wait_restart(struct restart_block *restart) | 1317 | static long futex_wait_restart(struct restart_block *restart) |
1379 | { | 1318 | { |
1380 | u32 __user *uaddr = (u32 __user *)restart->futex.uaddr; | 1319 | u32 __user *uaddr = (u32 __user *)restart->futex.uaddr; |
1381 | struct rw_semaphore *fshared = NULL; | 1320 | int fshared = 0; |
1382 | ktime_t t; | 1321 | ktime_t t; |
1383 | 1322 | ||
1384 | t.tv64 = restart->futex.time; | 1323 | t.tv64 = restart->futex.time; |
1385 | restart->fn = do_no_restart_syscall; | 1324 | restart->fn = do_no_restart_syscall; |
1386 | if (restart->futex.flags & FLAGS_SHARED) | 1325 | if (restart->futex.flags & FLAGS_SHARED) |
1387 | fshared = ¤t->mm->mmap_sem; | 1326 | fshared = 1; |
1388 | return (long)futex_wait(uaddr, fshared, restart->futex.val, &t, | 1327 | return (long)futex_wait(uaddr, fshared, restart->futex.val, &t, |
1389 | restart->futex.bitset); | 1328 | restart->futex.bitset, |
1329 | restart->futex.flags & FLAGS_CLOCKRT); | ||
1390 | } | 1330 | } |
1391 | 1331 | ||
1392 | 1332 | ||
@@ -1396,7 +1336,7 @@ static long futex_wait_restart(struct restart_block *restart) | |||
1396 | * if there are waiters then it will block, it does PI, etc. (Due to | 1336 | * if there are waiters then it will block, it does PI, etc. (Due to |
1397 | * races the kernel might see a 0 value of the futex too.) | 1337 | * races the kernel might see a 0 value of the futex too.) |
1398 | */ | 1338 | */ |
1399 | static int futex_lock_pi(u32 __user *uaddr, struct rw_semaphore *fshared, | 1339 | static int futex_lock_pi(u32 __user *uaddr, int fshared, |
1400 | int detect, ktime_t *time, int trylock) | 1340 | int detect, ktime_t *time, int trylock) |
1401 | { | 1341 | { |
1402 | struct hrtimer_sleeper timeout, *to = NULL; | 1342 | struct hrtimer_sleeper timeout, *to = NULL; |
@@ -1419,8 +1359,7 @@ static int futex_lock_pi(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1419 | 1359 | ||
1420 | q.pi_state = NULL; | 1360 | q.pi_state = NULL; |
1421 | retry: | 1361 | retry: |
1422 | futex_lock_mm(fshared); | 1362 | q.key = FUTEX_KEY_INIT; |
1423 | |||
1424 | ret = get_futex_key(uaddr, fshared, &q.key); | 1363 | ret = get_futex_key(uaddr, fshared, &q.key); |
1425 | if (unlikely(ret != 0)) | 1364 | if (unlikely(ret != 0)) |
1426 | goto out_release_sem; | 1365 | goto out_release_sem; |
@@ -1509,7 +1448,6 @@ static int futex_lock_pi(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1509 | * exit to complete. | 1448 | * exit to complete. |
1510 | */ | 1449 | */ |
1511 | queue_unlock(&q, hb); | 1450 | queue_unlock(&q, hb); |
1512 | futex_unlock_mm(fshared); | ||
1513 | cond_resched(); | 1451 | cond_resched(); |
1514 | goto retry; | 1452 | goto retry; |
1515 | 1453 | ||
@@ -1541,12 +1479,6 @@ static int futex_lock_pi(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1541 | */ | 1479 | */ |
1542 | queue_me(&q, hb); | 1480 | queue_me(&q, hb); |
1543 | 1481 | ||
1544 | /* | ||
1545 | * Now the futex is queued and we have checked the data, we | ||
1546 | * don't want to hold mmap_sem while we sleep. | ||
1547 | */ | ||
1548 | futex_unlock_mm(fshared); | ||
1549 | |||
1550 | WARN_ON(!q.pi_state); | 1482 | WARN_ON(!q.pi_state); |
1551 | /* | 1483 | /* |
1552 | * Block on the PI mutex: | 1484 | * Block on the PI mutex: |
@@ -1559,7 +1491,6 @@ static int futex_lock_pi(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1559 | ret = ret ? 0 : -EWOULDBLOCK; | 1491 | ret = ret ? 0 : -EWOULDBLOCK; |
1560 | } | 1492 | } |
1561 | 1493 | ||
1562 | futex_lock_mm(fshared); | ||
1563 | spin_lock(q.lock_ptr); | 1494 | spin_lock(q.lock_ptr); |
1564 | 1495 | ||
1565 | if (!ret) { | 1496 | if (!ret) { |
@@ -1625,7 +1556,6 @@ static int futex_lock_pi(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1625 | 1556 | ||
1626 | /* Unqueue and drop the lock */ | 1557 | /* Unqueue and drop the lock */ |
1627 | unqueue_me_pi(&q); | 1558 | unqueue_me_pi(&q); |
1628 | futex_unlock_mm(fshared); | ||
1629 | 1559 | ||
1630 | if (to) | 1560 | if (to) |
1631 | destroy_hrtimer_on_stack(&to->timer); | 1561 | destroy_hrtimer_on_stack(&to->timer); |
@@ -1635,34 +1565,30 @@ static int futex_lock_pi(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1635 | queue_unlock(&q, hb); | 1565 | queue_unlock(&q, hb); |
1636 | 1566 | ||
1637 | out_release_sem: | 1567 | out_release_sem: |
1638 | futex_unlock_mm(fshared); | 1568 | put_futex_key(fshared, &q.key); |
1639 | if (to) | 1569 | if (to) |
1640 | destroy_hrtimer_on_stack(&to->timer); | 1570 | destroy_hrtimer_on_stack(&to->timer); |
1641 | return ret; | 1571 | return ret; |
1642 | 1572 | ||
1643 | uaddr_faulted: | 1573 | uaddr_faulted: |
1644 | /* | 1574 | /* |
1645 | * We have to r/w *(int __user *)uaddr, but we can't modify it | 1575 | * We have to r/w *(int __user *)uaddr, and we have to modify it |
1646 | * non-atomically. Therefore, if get_user below is not | 1576 | * atomically. Therefore, if we continue to fault after get_user() |
1647 | * enough, we need to handle the fault ourselves, while | 1577 | * below, we need to handle the fault ourselves, while still holding |
1648 | * still holding the mmap_sem. | 1578 | * the mmap_sem. This can occur if the uaddr is under contention as |
1649 | * | 1579 | * we have to drop the mmap_sem in order to call get_user(). |
1650 | * ... and hb->lock. :-) --ANK | ||
1651 | */ | 1580 | */ |
1652 | queue_unlock(&q, hb); | 1581 | queue_unlock(&q, hb); |
1653 | 1582 | ||
1654 | if (attempt++) { | 1583 | if (attempt++) { |
1655 | ret = futex_handle_fault((unsigned long)uaddr, fshared, | 1584 | ret = futex_handle_fault((unsigned long)uaddr, attempt); |
1656 | attempt); | ||
1657 | if (ret) | 1585 | if (ret) |
1658 | goto out_release_sem; | 1586 | goto out_release_sem; |
1659 | goto retry_unlocked; | 1587 | goto retry_unlocked; |
1660 | } | 1588 | } |
1661 | 1589 | ||
1662 | futex_unlock_mm(fshared); | ||
1663 | |||
1664 | ret = get_user(uval, uaddr); | 1590 | ret = get_user(uval, uaddr); |
1665 | if (!ret && (uval != -EFAULT)) | 1591 | if (!ret) |
1666 | goto retry; | 1592 | goto retry; |
1667 | 1593 | ||
1668 | if (to) | 1594 | if (to) |
@@ -1675,13 +1601,13 @@ static int futex_lock_pi(u32 __user *uaddr, struct rw_semaphore *fshared, | |||
1675 | * This is the in-kernel slowpath: we look up the PI state (if any), | 1601 | * This is the in-kernel slowpath: we look up the PI state (if any), |
1676 | * and do the rt-mutex unlock. | 1602 | * and do the rt-mutex unlock. |
1677 | */ | 1603 | */ |
1678 | static int futex_unlock_pi(u32 __user *uaddr, struct rw_semaphore *fshared) | 1604 | static int futex_unlock_pi(u32 __user *uaddr, int fshared) |
1679 | { | 1605 | { |
1680 | struct futex_hash_bucket *hb; | 1606 | struct futex_hash_bucket *hb; |
1681 | struct futex_q *this, *next; | 1607 | struct futex_q *this, *next; |
1682 | u32 uval; | 1608 | u32 uval; |
1683 | struct plist_head *head; | 1609 | struct plist_head *head; |
1684 | union futex_key key; | 1610 | union futex_key key = FUTEX_KEY_INIT; |
1685 | int ret, attempt = 0; | 1611 | int ret, attempt = 0; |
1686 | 1612 | ||
1687 | retry: | 1613 | retry: |
@@ -1692,10 +1618,6 @@ retry: | |||
1692 | */ | 1618 | */ |
1693 | if ((uval & FUTEX_TID_MASK) != task_pid_vnr(current)) | 1619 | if ((uval & FUTEX_TID_MASK) != task_pid_vnr(current)) |
1694 | return -EPERM; | 1620 | return -EPERM; |
1695 | /* | ||
1696 | * First take all the futex related locks: | ||
1697 | */ | ||
1698 | futex_lock_mm(fshared); | ||
1699 | 1621 | ||
1700 | ret = get_futex_key(uaddr, fshared, &key); | 1622 | ret = get_futex_key(uaddr, fshared, &key); |
1701 | if (unlikely(ret != 0)) | 1623 | if (unlikely(ret != 0)) |
@@ -1754,34 +1676,30 @@ retry_unlocked: | |||
1754 | out_unlock: | 1676 | out_unlock: |
1755 | spin_unlock(&hb->lock); | 1677 | spin_unlock(&hb->lock); |
1756 | out: | 1678 | out: |
1757 | futex_unlock_mm(fshared); | 1679 | put_futex_key(fshared, &key); |
1758 | 1680 | ||
1759 | return ret; | 1681 | return ret; |
1760 | 1682 | ||
1761 | pi_faulted: | 1683 | pi_faulted: |
1762 | /* | 1684 | /* |
1763 | * We have to r/w *(int __user *)uaddr, but we can't modify it | 1685 | * We have to r/w *(int __user *)uaddr, and we have to modify it |
1764 | * non-atomically. Therefore, if get_user below is not | 1686 | * atomically. Therefore, if we continue to fault after get_user() |
1765 | * enough, we need to handle the fault ourselves, while | 1687 | * below, we need to handle the fault ourselves, while still holding |
1766 | * still holding the mmap_sem. | 1688 | * the mmap_sem. This can occur if the uaddr is under contention as |
1767 | * | 1689 | * we have to drop the mmap_sem in order to call get_user(). |
1768 | * ... and hb->lock. --ANK | ||
1769 | */ | 1690 | */ |
1770 | spin_unlock(&hb->lock); | 1691 | spin_unlock(&hb->lock); |
1771 | 1692 | ||
1772 | if (attempt++) { | 1693 | if (attempt++) { |
1773 | ret = futex_handle_fault((unsigned long)uaddr, fshared, | 1694 | ret = futex_handle_fault((unsigned long)uaddr, attempt); |
1774 | attempt); | ||
1775 | if (ret) | 1695 | if (ret) |
1776 | goto out; | 1696 | goto out; |
1777 | uval = 0; | 1697 | uval = 0; |
1778 | goto retry_unlocked; | 1698 | goto retry_unlocked; |
1779 | } | 1699 | } |
1780 | 1700 | ||
1781 | futex_unlock_mm(fshared); | ||
1782 | |||
1783 | ret = get_user(uval, uaddr); | 1701 | ret = get_user(uval, uaddr); |
1784 | if (!ret && (uval != -EFAULT)) | 1702 | if (!ret) |
1785 | goto retry; | 1703 | goto retry; |
1786 | 1704 | ||
1787 | return ret; | 1705 | return ret; |
@@ -1908,8 +1826,7 @@ retry: | |||
1908 | * PI futexes happens in exit_pi_state(): | 1826 | * PI futexes happens in exit_pi_state(): |
1909 | */ | 1827 | */ |
1910 | if (!pi && (uval & FUTEX_WAITERS)) | 1828 | if (!pi && (uval & FUTEX_WAITERS)) |
1911 | futex_wake(uaddr, &curr->mm->mmap_sem, 1, | 1829 | futex_wake(uaddr, 1, 1, FUTEX_BITSET_MATCH_ANY); |
1912 | FUTEX_BITSET_MATCH_ANY); | ||
1913 | } | 1830 | } |
1914 | return 0; | 1831 | return 0; |
1915 | } | 1832 | } |
@@ -2003,18 +1920,22 @@ void exit_robust_list(struct task_struct *curr) | |||
2003 | long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout, | 1920 | long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout, |
2004 | u32 __user *uaddr2, u32 val2, u32 val3) | 1921 | u32 __user *uaddr2, u32 val2, u32 val3) |
2005 | { | 1922 | { |
2006 | int ret = -ENOSYS; | 1923 | int clockrt, ret = -ENOSYS; |
2007 | int cmd = op & FUTEX_CMD_MASK; | 1924 | int cmd = op & FUTEX_CMD_MASK; |
2008 | struct rw_semaphore *fshared = NULL; | 1925 | int fshared = 0; |
2009 | 1926 | ||
2010 | if (!(op & FUTEX_PRIVATE_FLAG)) | 1927 | if (!(op & FUTEX_PRIVATE_FLAG)) |
2011 | fshared = ¤t->mm->mmap_sem; | 1928 | fshared = 1; |
1929 | |||
1930 | clockrt = op & FUTEX_CLOCK_REALTIME; | ||
1931 | if (clockrt && cmd != FUTEX_WAIT_BITSET) | ||
1932 | return -ENOSYS; | ||
2012 | 1933 | ||
2013 | switch (cmd) { | 1934 | switch (cmd) { |
2014 | case FUTEX_WAIT: | 1935 | case FUTEX_WAIT: |
2015 | val3 = FUTEX_BITSET_MATCH_ANY; | 1936 | val3 = FUTEX_BITSET_MATCH_ANY; |
2016 | case FUTEX_WAIT_BITSET: | 1937 | case FUTEX_WAIT_BITSET: |
2017 | ret = futex_wait(uaddr, fshared, val, timeout, val3); | 1938 | ret = futex_wait(uaddr, fshared, val, timeout, val3, clockrt); |
2018 | break; | 1939 | break; |
2019 | case FUTEX_WAKE: | 1940 | case FUTEX_WAKE: |
2020 | val3 = FUTEX_BITSET_MATCH_ANY; | 1941 | val3 = FUTEX_BITSET_MATCH_ANY; |