1 files changed, 26 insertions, 22 deletions

diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h
index b684426a5900..5a3df1d7085f 100644
--- a/include/scsi/scsi_transport_iscsi.h
+++ b/include/scsi/scsi_transport_iscsi.h
@@ -34,6 +34,7 @@ struct iscsi_cls_conn;
 struct iscsi_conn;
 struct iscsi_cmd_task;
 struct iscsi_mgmt_task;
+struct sockaddr;
 
 /**
  * struct iscsi_transport - iSCSI Transport template
@@ -46,7 +47,12 @@ struct iscsi_mgmt_task;
  * @bind_conn:          associate this connection with existing iSCSI session
  *                      and specified transport descriptor
  * @destroy_conn:       destroy inactive iSCSI connection
- * @set_param:          set iSCSI Data-Path operational parameter
+ * @set_param:          set iSCSI parameter. Return 0 on success, -ENODATA
+ *                      when param is not supported, and a -Exx value on other
+ *                      error.
+ * @get_param           get iSCSI parameter. Must return number of bytes
+ *                      copied to buffer on success, -ENODATA when param
+ *                      is not supported, and a -Exx value on other error
  * @start_conn:         set connection to be operational
  * @stop_conn:          suspend/recover/terminate connection
  * @send_pdu:           send iSCSI PDU, Login, Logout, NOP-Out, Reject, Text.
@@ -97,15 +103,11 @@ struct iscsi_transport {
         void (*stop_conn) (struct iscsi_cls_conn *conn, int flag);
         void (*destroy_conn) (struct iscsi_cls_conn *conn);
         int (*set_param) (struct iscsi_cls_conn *conn, enum iscsi_param param,
-                          uint32_t value);
+                          char *buf, int buflen);
         int (*get_conn_param) (struct iscsi_cls_conn *conn,
-                               enum iscsi_param param, uint32_t *value);
+                               enum iscsi_param param, char *buf);
         int (*get_session_param) (struct iscsi_cls_session *session,
-                                  enum iscsi_param param, uint32_t *value);
-        int (*get_conn_str_param) (struct iscsi_cls_conn *conn,
-                                   enum iscsi_param param, char *buf);
-        int (*get_session_str_param) (struct iscsi_cls_session *session,
-                                      enum iscsi_param param, char *buf);
+                                  enum iscsi_param param, char *buf);
         int (*send_pdu) (struct iscsi_cls_conn *conn, struct iscsi_hdr *hdr,
                          char *data, uint32_t data_size);
         void (*get_stats) (struct iscsi_cls_conn *conn,
@@ -127,6 +129,8 @@ struct iscsi_transport {
                            uint64_t *ep_handle);
         int (*ep_poll) (uint64_t ep_handle, int timeout_ms);
         void (*ep_disconnect) (uint64_t ep_handle);
+        int (*tgt_dscvr) (enum iscsi_tgt_dscvr type, uint32_t host_no,
+                          uint32_t enable, struct sockaddr *dst_addr);
 };
 
 /*
@@ -155,13 +159,6 @@ struct iscsi_cls_conn {
         struct iscsi_transport *transport;
         uint32_t cid;                   /* connection id */
 
-        /* portal/group values we got during discovery */
-        char *persistent_address;
-        int persistent_port;
-        /* portal/group values we are currently using */
-        char *address;
-        int port;
-
         int active;                     /* must be accessed with the connlock */
         struct device dev;              /* sysfs transport/container device */
         struct mempool_zone *z_error;
@@ -185,16 +182,11 @@ struct iscsi_cls_session {
         struct list_head host_list;
         struct iscsi_transport *transport;
 
-        /* iSCSI values used as unique id by userspace. */
-        char *targetname;
-        int tpgt;
-
         /* recovery fields */
         int recovery_tmo;
         struct work_struct recovery_work;
 
         int target_id;
-        int channel;
 
         int sid;                                /* session id */
         void *dd_data;                          /* LLD private data */
@@ -207,8 +199,10 @@ struct iscsi_cls_session {
 #define iscsi_session_to_shost(_session) \
         dev_to_shost(_session->dev.parent)
 
+#define starget_to_session(_stgt) \
+        iscsi_dev_to_session(_stgt->dev.parent)
+
 struct iscsi_host {
-        int next_target_id;
         struct list_head sessions;
         struct mutex mutex;
 };
@@ -216,8 +210,17 @@ struct iscsi_host {
 /*
  * session and connection functions that can be used by HW iSCSI LLDs
  */
+extern struct iscsi_cls_session *iscsi_alloc_session(struct Scsi_Host *shost,
+                                        struct iscsi_transport *transport);
+extern int iscsi_add_session(struct iscsi_cls_session *session,
+                             unsigned int target_id);
+extern int iscsi_if_create_session_done(struct iscsi_cls_conn *conn);
+extern int iscsi_if_destroy_session_done(struct iscsi_cls_conn *conn);
 extern struct iscsi_cls_session *iscsi_create_session(struct Scsi_Host *shost,
-                                struct iscsi_transport *t, int channel);
+                                                struct iscsi_transport *t,
+                                                unsigned int target_id);
+extern void iscsi_remove_session(struct iscsi_cls_session *session);
+extern void iscsi_free_session(struct iscsi_cls_session *session);
 extern int iscsi_destroy_session(struct iscsi_cls_session *session);
 extern struct iscsi_cls_conn *iscsi_create_conn(struct iscsi_cls_session *sess,
                                             uint32_t cid);
@@ -225,4 +228,5 @@ extern int iscsi_destroy_conn(struct iscsi_cls_conn *conn);
 extern void iscsi_unblock_session(struct iscsi_cls_session *session);
 extern void iscsi_block_session(struct iscsi_cls_session *session);
 
+
 #endif