1 files changed, 9 insertions, 13 deletions

diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 3a4edd1f7dbb..a4c9336811d1 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -230,9 +230,6 @@ struct scsi_dh_data {
 #define transport_class_to_sdev(class_dev) \
         to_scsi_device(class_dev->parent)
 
-#define sdev_printk(prefix, sdev, fmt, a...)    \
-        dev_printk(prefix, &(sdev)->sdev_gendev, fmt, ##a)
-
 #define sdev_dbg(sdev, fmt, a...) \
         dev_dbg(&(sdev)->sdev_gendev, fmt, ##a)
 
@@ -240,16 +237,15 @@ struct scsi_dh_data {
  * like scmd_printk, but the device name is passed in
  * as a string pointer
  */
-#define sdev_prefix_printk(l, sdev, p, fmt, a...)                       \
-        (p) ?                                                           \
-        sdev_printk(l, sdev, "[%s] " fmt, p, ##a) :                     \
-        sdev_printk(l, sdev, fmt, ##a)
-
-#define scmd_printk(prefix, scmd, fmt, a...)                            \
-        (scmd)->request->rq_disk ?                                      \
-        sdev_printk(prefix, (scmd)->device, "[%s] " fmt,                \
-                    (scmd)->request->rq_disk->disk_name, ##a) :         \
-        sdev_printk(prefix, (scmd)->device, fmt, ##a)
+__printf(4, 5) void
+sdev_prefix_printk(const char *, const struct scsi_device *, const char *,
+                const char *, ...);
+
+#define sdev_printk(l, sdev, fmt, a...)                         \
+        sdev_prefix_printk(l, sdev, NULL, fmt, ##a)
+
+__printf(3, 4) void
+scmd_printk(const char *, const struct scsi_cmnd *, const char *, ...);
 
 #define scmd_dbg(scmd, fmt, a...)                                          \
         do {                                                               \