diff options
Diffstat (limited to 'fs')
263 files changed, 3925 insertions, 3064 deletions
diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h index e78956cbd702..34c59f14a1c9 100644 --- a/fs/9p/v9fs.h +++ b/fs/9p/v9fs.h | |||
@@ -144,7 +144,7 @@ extern void v9fs_session_close(struct v9fs_session_info *v9ses); | |||
144 | extern void v9fs_session_cancel(struct v9fs_session_info *v9ses); | 144 | extern void v9fs_session_cancel(struct v9fs_session_info *v9ses); |
145 | extern void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses); | 145 | extern void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses); |
146 | extern struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry, | 146 | extern struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry, |
147 | struct nameidata *nameidata); | 147 | unsigned int flags); |
148 | extern int v9fs_vfs_unlink(struct inode *i, struct dentry *d); | 148 | extern int v9fs_vfs_unlink(struct inode *i, struct dentry *d); |
149 | extern int v9fs_vfs_rmdir(struct inode *i, struct dentry *d); | 149 | extern int v9fs_vfs_rmdir(struct inode *i, struct dentry *d); |
150 | extern int v9fs_vfs_rename(struct inode *old_dir, struct dentry *old_dentry, | 150 | extern int v9fs_vfs_rename(struct inode *old_dir, struct dentry *old_dentry, |
diff --git a/fs/9p/vfs_dentry.c b/fs/9p/vfs_dentry.c index d529437ff442..64600b5d0522 100644 --- a/fs/9p/vfs_dentry.c +++ b/fs/9p/vfs_dentry.c | |||
@@ -100,13 +100,13 @@ static void v9fs_dentry_release(struct dentry *dentry) | |||
100 | } | 100 | } |
101 | } | 101 | } |
102 | 102 | ||
103 | static int v9fs_lookup_revalidate(struct dentry *dentry, struct nameidata *nd) | 103 | static int v9fs_lookup_revalidate(struct dentry *dentry, unsigned int flags) |
104 | { | 104 | { |
105 | struct p9_fid *fid; | 105 | struct p9_fid *fid; |
106 | struct inode *inode; | 106 | struct inode *inode; |
107 | struct v9fs_inode *v9inode; | 107 | struct v9fs_inode *v9inode; |
108 | 108 | ||
109 | if (nd->flags & LOOKUP_RCU) | 109 | if (flags & LOOKUP_RCU) |
110 | return -ECHILD; | 110 | return -ECHILD; |
111 | 111 | ||
112 | inode = dentry->d_inode; | 112 | inode = dentry->d_inode; |
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index 57ccb7537dae..cbf9dbb1b2a2 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c | |||
@@ -712,88 +712,34 @@ error: | |||
712 | } | 712 | } |
713 | 713 | ||
714 | /** | 714 | /** |
715 | * v9fs_vfs_create - VFS hook to create files | 715 | * v9fs_vfs_create - VFS hook to create a regular file |
716 | * | ||
717 | * open(.., O_CREAT) is handled in v9fs_vfs_atomic_open(). This is only called | ||
718 | * for mknod(2). | ||
719 | * | ||
716 | * @dir: directory inode that is being created | 720 | * @dir: directory inode that is being created |
717 | * @dentry: dentry that is being deleted | 721 | * @dentry: dentry that is being deleted |
718 | * @mode: create permissions | 722 | * @mode: create permissions |
719 | * @nd: path information | ||
720 | * | 723 | * |
721 | */ | 724 | */ |
722 | 725 | ||
723 | static int | 726 | static int |
724 | v9fs_vfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 727 | v9fs_vfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
725 | struct nameidata *nd) | 728 | bool excl) |
726 | { | 729 | { |
727 | int err; | 730 | struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dir); |
728 | u32 perm; | 731 | u32 perm = unixmode2p9mode(v9ses, mode); |
729 | int flags; | 732 | struct p9_fid *fid; |
730 | struct file *filp; | ||
731 | struct v9fs_inode *v9inode; | ||
732 | struct v9fs_session_info *v9ses; | ||
733 | struct p9_fid *fid, *inode_fid; | ||
734 | |||
735 | err = 0; | ||
736 | fid = NULL; | ||
737 | v9ses = v9fs_inode2v9ses(dir); | ||
738 | perm = unixmode2p9mode(v9ses, mode); | ||
739 | if (nd) | ||
740 | flags = nd->intent.open.flags; | ||
741 | else | ||
742 | flags = O_RDWR; | ||
743 | 733 | ||
744 | fid = v9fs_create(v9ses, dir, dentry, NULL, perm, | 734 | /* P9_OEXCL? */ |
745 | v9fs_uflags2omode(flags, | 735 | fid = v9fs_create(v9ses, dir, dentry, NULL, perm, P9_ORDWR); |
746 | v9fs_proto_dotu(v9ses))); | 736 | if (IS_ERR(fid)) |
747 | if (IS_ERR(fid)) { | 737 | return PTR_ERR(fid); |
748 | err = PTR_ERR(fid); | ||
749 | fid = NULL; | ||
750 | goto error; | ||
751 | } | ||
752 | 738 | ||
753 | v9fs_invalidate_inode_attr(dir); | 739 | v9fs_invalidate_inode_attr(dir); |
754 | /* if we are opening a file, assign the open fid to the file */ | 740 | p9_client_clunk(fid); |
755 | if (nd) { | ||
756 | v9inode = V9FS_I(dentry->d_inode); | ||
757 | mutex_lock(&v9inode->v_mutex); | ||
758 | if (v9ses->cache && !v9inode->writeback_fid && | ||
759 | ((flags & O_ACCMODE) != O_RDONLY)) { | ||
760 | /* | ||
761 | * clone a fid and add it to writeback_fid | ||
762 | * we do it during open time instead of | ||
763 | * page dirty time via write_begin/page_mkwrite | ||
764 | * because we want write after unlink usecase | ||
765 | * to work. | ||
766 | */ | ||
767 | inode_fid = v9fs_writeback_fid(dentry); | ||
768 | if (IS_ERR(inode_fid)) { | ||
769 | err = PTR_ERR(inode_fid); | ||
770 | mutex_unlock(&v9inode->v_mutex); | ||
771 | goto error; | ||
772 | } | ||
773 | v9inode->writeback_fid = (void *) inode_fid; | ||
774 | } | ||
775 | mutex_unlock(&v9inode->v_mutex); | ||
776 | filp = lookup_instantiate_filp(nd, dentry, generic_file_open); | ||
777 | if (IS_ERR(filp)) { | ||
778 | err = PTR_ERR(filp); | ||
779 | goto error; | ||
780 | } | ||
781 | |||
782 | filp->private_data = fid; | ||
783 | #ifdef CONFIG_9P_FSCACHE | ||
784 | if (v9ses->cache) | ||
785 | v9fs_cache_inode_set_cookie(dentry->d_inode, filp); | ||
786 | #endif | ||
787 | } else | ||
788 | p9_client_clunk(fid); | ||
789 | 741 | ||
790 | return 0; | 742 | return 0; |
791 | |||
792 | error: | ||
793 | if (fid) | ||
794 | p9_client_clunk(fid); | ||
795 | |||
796 | return err; | ||
797 | } | 743 | } |
798 | 744 | ||
799 | /** | 745 | /** |
@@ -839,7 +785,7 @@ static int v9fs_vfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode | |||
839 | */ | 785 | */ |
840 | 786 | ||
841 | struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry, | 787 | struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry, |
842 | struct nameidata *nameidata) | 788 | unsigned int flags) |
843 | { | 789 | { |
844 | struct dentry *res; | 790 | struct dentry *res; |
845 | struct super_block *sb; | 791 | struct super_block *sb; |
@@ -849,8 +795,8 @@ struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry, | |||
849 | char *name; | 795 | char *name; |
850 | int result = 0; | 796 | int result = 0; |
851 | 797 | ||
852 | p9_debug(P9_DEBUG_VFS, "dir: %p dentry: (%s) %p nameidata: %p\n", | 798 | p9_debug(P9_DEBUG_VFS, "dir: %p dentry: (%s) %p flags: %x\n", |
853 | dir, dentry->d_name.name, dentry, nameidata); | 799 | dir, dentry->d_name.name, dentry, flags); |
854 | 800 | ||
855 | if (dentry->d_name.len > NAME_MAX) | 801 | if (dentry->d_name.len > NAME_MAX) |
856 | return ERR_PTR(-ENAMETOOLONG); | 802 | return ERR_PTR(-ENAMETOOLONG); |
@@ -910,6 +856,86 @@ error: | |||
910 | return ERR_PTR(result); | 856 | return ERR_PTR(result); |
911 | } | 857 | } |
912 | 858 | ||
859 | static int | ||
860 | v9fs_vfs_atomic_open(struct inode *dir, struct dentry *dentry, | ||
861 | struct file *file, unsigned flags, umode_t mode, | ||
862 | int *opened) | ||
863 | { | ||
864 | int err; | ||
865 | u32 perm; | ||
866 | struct v9fs_inode *v9inode; | ||
867 | struct v9fs_session_info *v9ses; | ||
868 | struct p9_fid *fid, *inode_fid; | ||
869 | struct dentry *res = NULL; | ||
870 | |||
871 | if (d_unhashed(dentry)) { | ||
872 | res = v9fs_vfs_lookup(dir, dentry, 0); | ||
873 | if (IS_ERR(res)) | ||
874 | return PTR_ERR(res); | ||
875 | |||
876 | if (res) | ||
877 | dentry = res; | ||
878 | } | ||
879 | |||
880 | /* Only creates */ | ||
881 | if (!(flags & O_CREAT) || dentry->d_inode) | ||
882 | return finish_no_open(file, res); | ||
883 | |||
884 | err = 0; | ||
885 | fid = NULL; | ||
886 | v9ses = v9fs_inode2v9ses(dir); | ||
887 | perm = unixmode2p9mode(v9ses, mode); | ||
888 | fid = v9fs_create(v9ses, dir, dentry, NULL, perm, | ||
889 | v9fs_uflags2omode(flags, | ||
890 | v9fs_proto_dotu(v9ses))); | ||
891 | if (IS_ERR(fid)) { | ||
892 | err = PTR_ERR(fid); | ||
893 | fid = NULL; | ||
894 | goto error; | ||
895 | } | ||
896 | |||
897 | v9fs_invalidate_inode_attr(dir); | ||
898 | v9inode = V9FS_I(dentry->d_inode); | ||
899 | mutex_lock(&v9inode->v_mutex); | ||
900 | if (v9ses->cache && !v9inode->writeback_fid && | ||
901 | ((flags & O_ACCMODE) != O_RDONLY)) { | ||
902 | /* | ||
903 | * clone a fid and add it to writeback_fid | ||
904 | * we do it during open time instead of | ||
905 | * page dirty time via write_begin/page_mkwrite | ||
906 | * because we want write after unlink usecase | ||
907 | * to work. | ||
908 | */ | ||
909 | inode_fid = v9fs_writeback_fid(dentry); | ||
910 | if (IS_ERR(inode_fid)) { | ||
911 | err = PTR_ERR(inode_fid); | ||
912 | mutex_unlock(&v9inode->v_mutex); | ||
913 | goto error; | ||
914 | } | ||
915 | v9inode->writeback_fid = (void *) inode_fid; | ||
916 | } | ||
917 | mutex_unlock(&v9inode->v_mutex); | ||
918 | err = finish_open(file, dentry, generic_file_open, opened); | ||
919 | if (err) | ||
920 | goto error; | ||
921 | |||
922 | file->private_data = fid; | ||
923 | #ifdef CONFIG_9P_FSCACHE | ||
924 | if (v9ses->cache) | ||
925 | v9fs_cache_inode_set_cookie(dentry->d_inode, file); | ||
926 | #endif | ||
927 | |||
928 | *opened |= FILE_CREATED; | ||
929 | out: | ||
930 | dput(res); | ||
931 | return err; | ||
932 | |||
933 | error: | ||
934 | if (fid) | ||
935 | p9_client_clunk(fid); | ||
936 | goto out; | ||
937 | } | ||
938 | |||
913 | /** | 939 | /** |
914 | * v9fs_vfs_unlink - VFS unlink hook to delete an inode | 940 | * v9fs_vfs_unlink - VFS unlink hook to delete an inode |
915 | * @i: inode that is being unlinked | 941 | * @i: inode that is being unlinked |
@@ -1488,6 +1514,7 @@ out: | |||
1488 | static const struct inode_operations v9fs_dir_inode_operations_dotu = { | 1514 | static const struct inode_operations v9fs_dir_inode_operations_dotu = { |
1489 | .create = v9fs_vfs_create, | 1515 | .create = v9fs_vfs_create, |
1490 | .lookup = v9fs_vfs_lookup, | 1516 | .lookup = v9fs_vfs_lookup, |
1517 | .atomic_open = v9fs_vfs_atomic_open, | ||
1491 | .symlink = v9fs_vfs_symlink, | 1518 | .symlink = v9fs_vfs_symlink, |
1492 | .link = v9fs_vfs_link, | 1519 | .link = v9fs_vfs_link, |
1493 | .unlink = v9fs_vfs_unlink, | 1520 | .unlink = v9fs_vfs_unlink, |
@@ -1502,6 +1529,7 @@ static const struct inode_operations v9fs_dir_inode_operations_dotu = { | |||
1502 | static const struct inode_operations v9fs_dir_inode_operations = { | 1529 | static const struct inode_operations v9fs_dir_inode_operations = { |
1503 | .create = v9fs_vfs_create, | 1530 | .create = v9fs_vfs_create, |
1504 | .lookup = v9fs_vfs_lookup, | 1531 | .lookup = v9fs_vfs_lookup, |
1532 | .atomic_open = v9fs_vfs_atomic_open, | ||
1505 | .unlink = v9fs_vfs_unlink, | 1533 | .unlink = v9fs_vfs_unlink, |
1506 | .mkdir = v9fs_vfs_mkdir, | 1534 | .mkdir = v9fs_vfs_mkdir, |
1507 | .rmdir = v9fs_vfs_rmdir, | 1535 | .rmdir = v9fs_vfs_rmdir, |
diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c index e3dd2a1e2bfc..40895546e103 100644 --- a/fs/9p/vfs_inode_dotl.c +++ b/fs/9p/vfs_inode_dotl.c | |||
@@ -230,20 +230,25 @@ int v9fs_open_to_dotl_flags(int flags) | |||
230 | * @dir: directory inode that is being created | 230 | * @dir: directory inode that is being created |
231 | * @dentry: dentry that is being deleted | 231 | * @dentry: dentry that is being deleted |
232 | * @mode: create permissions | 232 | * @mode: create permissions |
233 | * @nd: path information | ||
234 | * | 233 | * |
235 | */ | 234 | */ |
236 | 235 | ||
237 | static int | 236 | static int |
238 | v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, umode_t omode, | 237 | v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, umode_t omode, |
239 | struct nameidata *nd) | 238 | bool excl) |
239 | { | ||
240 | return v9fs_vfs_mknod_dotl(dir, dentry, omode, 0); | ||
241 | } | ||
242 | |||
243 | static int | ||
244 | v9fs_vfs_atomic_open_dotl(struct inode *dir, struct dentry *dentry, | ||
245 | struct file *file, unsigned flags, umode_t omode, | ||
246 | int *opened) | ||
240 | { | 247 | { |
241 | int err = 0; | 248 | int err = 0; |
242 | gid_t gid; | 249 | gid_t gid; |
243 | int flags; | ||
244 | umode_t mode; | 250 | umode_t mode; |
245 | char *name = NULL; | 251 | char *name = NULL; |
246 | struct file *filp; | ||
247 | struct p9_qid qid; | 252 | struct p9_qid qid; |
248 | struct inode *inode; | 253 | struct inode *inode; |
249 | struct p9_fid *fid = NULL; | 254 | struct p9_fid *fid = NULL; |
@@ -251,19 +256,23 @@ v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, umode_t omode, | |||
251 | struct p9_fid *dfid, *ofid, *inode_fid; | 256 | struct p9_fid *dfid, *ofid, *inode_fid; |
252 | struct v9fs_session_info *v9ses; | 257 | struct v9fs_session_info *v9ses; |
253 | struct posix_acl *pacl = NULL, *dacl = NULL; | 258 | struct posix_acl *pacl = NULL, *dacl = NULL; |
259 | struct dentry *res = NULL; | ||
254 | 260 | ||
255 | v9ses = v9fs_inode2v9ses(dir); | 261 | if (d_unhashed(dentry)) { |
256 | if (nd) | 262 | res = v9fs_vfs_lookup(dir, dentry, 0); |
257 | flags = nd->intent.open.flags; | 263 | if (IS_ERR(res)) |
258 | else { | 264 | return PTR_ERR(res); |
259 | /* | 265 | |
260 | * create call without LOOKUP_OPEN is due | 266 | if (res) |
261 | * to mknod of regular files. So use mknod | 267 | dentry = res; |
262 | * operation. | ||
263 | */ | ||
264 | return v9fs_vfs_mknod_dotl(dir, dentry, omode, 0); | ||
265 | } | 268 | } |
266 | 269 | ||
270 | /* Only creates */ | ||
271 | if (!(flags & O_CREAT) || dentry->d_inode) | ||
272 | return finish_no_open(file, res); | ||
273 | |||
274 | v9ses = v9fs_inode2v9ses(dir); | ||
275 | |||
267 | name = (char *) dentry->d_name.name; | 276 | name = (char *) dentry->d_name.name; |
268 | p9_debug(P9_DEBUG_VFS, "name:%s flags:0x%x mode:0x%hx\n", | 277 | p9_debug(P9_DEBUG_VFS, "name:%s flags:0x%x mode:0x%hx\n", |
269 | name, flags, omode); | 278 | name, flags, omode); |
@@ -272,7 +281,7 @@ v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, umode_t omode, | |||
272 | if (IS_ERR(dfid)) { | 281 | if (IS_ERR(dfid)) { |
273 | err = PTR_ERR(dfid); | 282 | err = PTR_ERR(dfid); |
274 | p9_debug(P9_DEBUG_VFS, "fid lookup failed %d\n", err); | 283 | p9_debug(P9_DEBUG_VFS, "fid lookup failed %d\n", err); |
275 | return err; | 284 | goto out; |
276 | } | 285 | } |
277 | 286 | ||
278 | /* clone a fid to use for creation */ | 287 | /* clone a fid to use for creation */ |
@@ -280,7 +289,7 @@ v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, umode_t omode, | |||
280 | if (IS_ERR(ofid)) { | 289 | if (IS_ERR(ofid)) { |
281 | err = PTR_ERR(ofid); | 290 | err = PTR_ERR(ofid); |
282 | p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); | 291 | p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); |
283 | return err; | 292 | goto out; |
284 | } | 293 | } |
285 | 294 | ||
286 | gid = v9fs_get_fsgid_for_create(dir); | 295 | gid = v9fs_get_fsgid_for_create(dir); |
@@ -345,17 +354,18 @@ v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, umode_t omode, | |||
345 | } | 354 | } |
346 | mutex_unlock(&v9inode->v_mutex); | 355 | mutex_unlock(&v9inode->v_mutex); |
347 | /* Since we are opening a file, assign the open fid to the file */ | 356 | /* Since we are opening a file, assign the open fid to the file */ |
348 | filp = lookup_instantiate_filp(nd, dentry, generic_file_open); | 357 | err = finish_open(file, dentry, generic_file_open, opened); |
349 | if (IS_ERR(filp)) { | 358 | if (err) |
350 | err = PTR_ERR(filp); | ||
351 | goto err_clunk_old_fid; | 359 | goto err_clunk_old_fid; |
352 | } | 360 | file->private_data = ofid; |
353 | filp->private_data = ofid; | ||
354 | #ifdef CONFIG_9P_FSCACHE | 361 | #ifdef CONFIG_9P_FSCACHE |
355 | if (v9ses->cache) | 362 | if (v9ses->cache) |
356 | v9fs_cache_inode_set_cookie(inode, filp); | 363 | v9fs_cache_inode_set_cookie(inode, file); |
357 | #endif | 364 | #endif |
358 | return 0; | 365 | *opened |= FILE_CREATED; |
366 | out: | ||
367 | dput(res); | ||
368 | return err; | ||
359 | 369 | ||
360 | error: | 370 | error: |
361 | if (fid) | 371 | if (fid) |
@@ -364,7 +374,7 @@ err_clunk_old_fid: | |||
364 | if (ofid) | 374 | if (ofid) |
365 | p9_client_clunk(ofid); | 375 | p9_client_clunk(ofid); |
366 | v9fs_set_create_acl(NULL, &dacl, &pacl); | 376 | v9fs_set_create_acl(NULL, &dacl, &pacl); |
367 | return err; | 377 | goto out; |
368 | } | 378 | } |
369 | 379 | ||
370 | /** | 380 | /** |
@@ -982,6 +992,7 @@ out: | |||
982 | 992 | ||
983 | const struct inode_operations v9fs_dir_inode_operations_dotl = { | 993 | const struct inode_operations v9fs_dir_inode_operations_dotl = { |
984 | .create = v9fs_vfs_create_dotl, | 994 | .create = v9fs_vfs_create_dotl, |
995 | .atomic_open = v9fs_vfs_atomic_open_dotl, | ||
985 | .lookup = v9fs_vfs_lookup, | 996 | .lookup = v9fs_vfs_lookup, |
986 | .link = v9fs_vfs_link_dotl, | 997 | .link = v9fs_vfs_link_dotl, |
987 | .symlink = v9fs_vfs_symlink_dotl, | 998 | .symlink = v9fs_vfs_symlink_dotl, |
diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c index 8c92a9ba8330..137d50396898 100644 --- a/fs/9p/vfs_super.c +++ b/fs/9p/vfs_super.c | |||
@@ -89,7 +89,7 @@ v9fs_fill_super(struct super_block *sb, struct v9fs_session_info *v9ses, | |||
89 | if (v9ses->cache) | 89 | if (v9ses->cache) |
90 | sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_CACHE_SIZE; | 90 | sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_CACHE_SIZE; |
91 | 91 | ||
92 | sb->s_flags = flags | MS_ACTIVE | MS_DIRSYNC | MS_NOATIME; | 92 | sb->s_flags |= MS_ACTIVE | MS_DIRSYNC | MS_NOATIME; |
93 | if (!v9ses->cache) | 93 | if (!v9ses->cache) |
94 | sb->s_flags |= MS_SYNCHRONOUS; | 94 | sb->s_flags |= MS_SYNCHRONOUS; |
95 | 95 | ||
@@ -137,7 +137,7 @@ static struct dentry *v9fs_mount(struct file_system_type *fs_type, int flags, | |||
137 | goto close_session; | 137 | goto close_session; |
138 | } | 138 | } |
139 | 139 | ||
140 | sb = sget(fs_type, NULL, v9fs_set_super, v9ses); | 140 | sb = sget(fs_type, NULL, v9fs_set_super, flags, v9ses); |
141 | if (IS_ERR(sb)) { | 141 | if (IS_ERR(sb)) { |
142 | retval = PTR_ERR(sb); | 142 | retval = PTR_ERR(sb); |
143 | goto clunk_fid; | 143 | goto clunk_fid; |
diff --git a/fs/adfs/dir.c b/fs/adfs/dir.c index 3d83075aaa2e..b3be2e7c5643 100644 --- a/fs/adfs/dir.c +++ b/fs/adfs/dir.c | |||
@@ -266,7 +266,7 @@ const struct dentry_operations adfs_dentry_operations = { | |||
266 | }; | 266 | }; |
267 | 267 | ||
268 | static struct dentry * | 268 | static struct dentry * |
269 | adfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 269 | adfs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
270 | { | 270 | { |
271 | struct inode *inode = NULL; | 271 | struct inode *inode = NULL; |
272 | struct object_info obj; | 272 | struct object_info obj; |
diff --git a/fs/adfs/super.c b/fs/adfs/super.c index 06fdcc9382c4..bdaec92353c2 100644 --- a/fs/adfs/super.c +++ b/fs/adfs/super.c | |||
@@ -246,7 +246,6 @@ static struct inode *adfs_alloc_inode(struct super_block *sb) | |||
246 | static void adfs_i_callback(struct rcu_head *head) | 246 | static void adfs_i_callback(struct rcu_head *head) |
247 | { | 247 | { |
248 | struct inode *inode = container_of(head, struct inode, i_rcu); | 248 | struct inode *inode = container_of(head, struct inode, i_rcu); |
249 | INIT_LIST_HEAD(&inode->i_dentry); | ||
250 | kmem_cache_free(adfs_inode_cachep, ADFS_I(inode)); | 249 | kmem_cache_free(adfs_inode_cachep, ADFS_I(inode)); |
251 | } | 250 | } |
252 | 251 | ||
diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 1fceb320d2f2..6e216419f340 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h | |||
@@ -3,6 +3,7 @@ | |||
3 | #include <linux/buffer_head.h> | 3 | #include <linux/buffer_head.h> |
4 | #include <linux/amigaffs.h> | 4 | #include <linux/amigaffs.h> |
5 | #include <linux/mutex.h> | 5 | #include <linux/mutex.h> |
6 | #include <linux/workqueue.h> | ||
6 | 7 | ||
7 | /* AmigaOS allows file names with up to 30 characters length. | 8 | /* AmigaOS allows file names with up to 30 characters length. |
8 | * Names longer than that will be silently truncated. If you | 9 | * Names longer than that will be silently truncated. If you |
@@ -100,6 +101,10 @@ struct affs_sb_info { | |||
100 | char *s_prefix; /* Prefix for volumes and assigns. */ | 101 | char *s_prefix; /* Prefix for volumes and assigns. */ |
101 | char s_volume[32]; /* Volume prefix for absolute symlinks. */ | 102 | char s_volume[32]; /* Volume prefix for absolute symlinks. */ |
102 | spinlock_t symlink_lock; /* protects the previous two */ | 103 | spinlock_t symlink_lock; /* protects the previous two */ |
104 | struct super_block *sb; /* the VFS superblock object */ | ||
105 | int work_queued; /* non-zero delayed work is queued */ | ||
106 | struct delayed_work sb_work; /* superblock flush delayed work */ | ||
107 | spinlock_t work_lock; /* protects sb_work and work_queued */ | ||
103 | }; | 108 | }; |
104 | 109 | ||
105 | #define SF_INTL 0x0001 /* International filesystem. */ | 110 | #define SF_INTL 0x0001 /* International filesystem. */ |
@@ -120,6 +125,8 @@ static inline struct affs_sb_info *AFFS_SB(struct super_block *sb) | |||
120 | return sb->s_fs_info; | 125 | return sb->s_fs_info; |
121 | } | 126 | } |
122 | 127 | ||
128 | void affs_mark_sb_dirty(struct super_block *sb); | ||
129 | |||
123 | /* amigaffs.c */ | 130 | /* amigaffs.c */ |
124 | 131 | ||
125 | extern int affs_insert_hash(struct inode *inode, struct buffer_head *bh); | 132 | extern int affs_insert_hash(struct inode *inode, struct buffer_head *bh); |
@@ -146,9 +153,9 @@ extern void affs_free_bitmap(struct super_block *sb); | |||
146 | /* namei.c */ | 153 | /* namei.c */ |
147 | 154 | ||
148 | extern int affs_hash_name(struct super_block *sb, const u8 *name, unsigned int len); | 155 | extern int affs_hash_name(struct super_block *sb, const u8 *name, unsigned int len); |
149 | extern struct dentry *affs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *); | 156 | extern struct dentry *affs_lookup(struct inode *dir, struct dentry *dentry, unsigned int); |
150 | extern int affs_unlink(struct inode *dir, struct dentry *dentry); | 157 | extern int affs_unlink(struct inode *dir, struct dentry *dentry); |
151 | extern int affs_create(struct inode *dir, struct dentry *dentry, umode_t mode, struct nameidata *); | 158 | extern int affs_create(struct inode *dir, struct dentry *dentry, umode_t mode, bool); |
152 | extern int affs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode); | 159 | extern int affs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode); |
153 | extern int affs_rmdir(struct inode *dir, struct dentry *dentry); | 160 | extern int affs_rmdir(struct inode *dir, struct dentry *dentry); |
154 | extern int affs_link(struct dentry *olddentry, struct inode *dir, | 161 | extern int affs_link(struct dentry *olddentry, struct inode *dir, |
diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c index 52a6407682e6..eb82ee53ee0b 100644 --- a/fs/affs/amigaffs.c +++ b/fs/affs/amigaffs.c | |||
@@ -122,22 +122,16 @@ affs_remove_hash(struct inode *dir, struct buffer_head *rem_bh) | |||
122 | } | 122 | } |
123 | 123 | ||
124 | static void | 124 | static void |
125 | affs_fix_dcache(struct dentry *dentry, u32 entry_ino) | 125 | affs_fix_dcache(struct inode *inode, u32 entry_ino) |
126 | { | 126 | { |
127 | struct inode *inode = dentry->d_inode; | 127 | struct dentry *dentry; |
128 | void *data = dentry->d_fsdata; | 128 | struct hlist_node *p; |
129 | struct list_head *head, *next; | ||
130 | |||
131 | spin_lock(&inode->i_lock); | 129 | spin_lock(&inode->i_lock); |
132 | head = &inode->i_dentry; | 130 | hlist_for_each_entry(dentry, p, &inode->i_dentry, d_alias) { |
133 | next = head->next; | ||
134 | while (next != head) { | ||
135 | dentry = list_entry(next, struct dentry, d_alias); | ||
136 | if (entry_ino == (u32)(long)dentry->d_fsdata) { | 131 | if (entry_ino == (u32)(long)dentry->d_fsdata) { |
137 | dentry->d_fsdata = data; | 132 | dentry->d_fsdata = (void *)inode->i_ino; |
138 | break; | 133 | break; |
139 | } | 134 | } |
140 | next = next->next; | ||
141 | } | 135 | } |
142 | spin_unlock(&inode->i_lock); | 136 | spin_unlock(&inode->i_lock); |
143 | } | 137 | } |
@@ -177,7 +171,11 @@ affs_remove_link(struct dentry *dentry) | |||
177 | } | 171 | } |
178 | 172 | ||
179 | affs_lock_dir(dir); | 173 | affs_lock_dir(dir); |
180 | affs_fix_dcache(dentry, link_ino); | 174 | /* |
175 | * if there's a dentry for that block, make it | ||
176 | * refer to inode itself. | ||
177 | */ | ||
178 | affs_fix_dcache(inode, link_ino); | ||
181 | retval = affs_remove_hash(dir, link_bh); | 179 | retval = affs_remove_hash(dir, link_bh); |
182 | if (retval) { | 180 | if (retval) { |
183 | affs_unlock_dir(dir); | 181 | affs_unlock_dir(dir); |
diff --git a/fs/affs/bitmap.c b/fs/affs/bitmap.c index 3e262711ae06..6e0be43ef6ef 100644 --- a/fs/affs/bitmap.c +++ b/fs/affs/bitmap.c | |||
@@ -103,7 +103,7 @@ affs_free_block(struct super_block *sb, u32 block) | |||
103 | *(__be32 *)bh->b_data = cpu_to_be32(tmp - mask); | 103 | *(__be32 *)bh->b_data = cpu_to_be32(tmp - mask); |
104 | 104 | ||
105 | mark_buffer_dirty(bh); | 105 | mark_buffer_dirty(bh); |
106 | sb->s_dirt = 1; | 106 | affs_mark_sb_dirty(sb); |
107 | bm->bm_free++; | 107 | bm->bm_free++; |
108 | 108 | ||
109 | mutex_unlock(&sbi->s_bmlock); | 109 | mutex_unlock(&sbi->s_bmlock); |
@@ -248,7 +248,7 @@ find_bit: | |||
248 | *(__be32 *)bh->b_data = cpu_to_be32(tmp + mask); | 248 | *(__be32 *)bh->b_data = cpu_to_be32(tmp + mask); |
249 | 249 | ||
250 | mark_buffer_dirty(bh); | 250 | mark_buffer_dirty(bh); |
251 | sb->s_dirt = 1; | 251 | affs_mark_sb_dirty(sb); |
252 | 252 | ||
253 | mutex_unlock(&sbi->s_bmlock); | 253 | mutex_unlock(&sbi->s_bmlock); |
254 | 254 | ||
diff --git a/fs/affs/namei.c b/fs/affs/namei.c index 47806940aac0..ff65884a7839 100644 --- a/fs/affs/namei.c +++ b/fs/affs/namei.c | |||
@@ -211,7 +211,7 @@ affs_find_entry(struct inode *dir, struct dentry *dentry) | |||
211 | } | 211 | } |
212 | 212 | ||
213 | struct dentry * | 213 | struct dentry * |
214 | affs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 214 | affs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
215 | { | 215 | { |
216 | struct super_block *sb = dir->i_sb; | 216 | struct super_block *sb = dir->i_sb; |
217 | struct buffer_head *bh; | 217 | struct buffer_head *bh; |
@@ -255,7 +255,7 @@ affs_unlink(struct inode *dir, struct dentry *dentry) | |||
255 | } | 255 | } |
256 | 256 | ||
257 | int | 257 | int |
258 | affs_create(struct inode *dir, struct dentry *dentry, umode_t mode, struct nameidata *nd) | 258 | affs_create(struct inode *dir, struct dentry *dentry, umode_t mode, bool excl) |
259 | { | 259 | { |
260 | struct super_block *sb = dir->i_sb; | 260 | struct super_block *sb = dir->i_sb; |
261 | struct inode *inode; | 261 | struct inode *inode; |
diff --git a/fs/affs/super.c b/fs/affs/super.c index 0782653a05a2..c70f1e5fc024 100644 --- a/fs/affs/super.c +++ b/fs/affs/super.c | |||
@@ -17,6 +17,7 @@ | |||
17 | #include <linux/magic.h> | 17 | #include <linux/magic.h> |
18 | #include <linux/sched.h> | 18 | #include <linux/sched.h> |
19 | #include <linux/slab.h> | 19 | #include <linux/slab.h> |
20 | #include <linux/writeback.h> | ||
20 | #include "affs.h" | 21 | #include "affs.h" |
21 | 22 | ||
22 | extern struct timezone sys_tz; | 23 | extern struct timezone sys_tz; |
@@ -25,15 +26,17 @@ static int affs_statfs(struct dentry *dentry, struct kstatfs *buf); | |||
25 | static int affs_remount (struct super_block *sb, int *flags, char *data); | 26 | static int affs_remount (struct super_block *sb, int *flags, char *data); |
26 | 27 | ||
27 | static void | 28 | static void |
28 | affs_commit_super(struct super_block *sb, int wait, int clean) | 29 | affs_commit_super(struct super_block *sb, int wait) |
29 | { | 30 | { |
30 | struct affs_sb_info *sbi = AFFS_SB(sb); | 31 | struct affs_sb_info *sbi = AFFS_SB(sb); |
31 | struct buffer_head *bh = sbi->s_root_bh; | 32 | struct buffer_head *bh = sbi->s_root_bh; |
32 | struct affs_root_tail *tail = AFFS_ROOT_TAIL(sb, bh); | 33 | struct affs_root_tail *tail = AFFS_ROOT_TAIL(sb, bh); |
33 | 34 | ||
34 | tail->bm_flag = cpu_to_be32(clean); | 35 | lock_buffer(bh); |
35 | secs_to_datestamp(get_seconds(), &tail->disk_change); | 36 | secs_to_datestamp(get_seconds(), &tail->disk_change); |
36 | affs_fix_checksum(sb, bh); | 37 | affs_fix_checksum(sb, bh); |
38 | unlock_buffer(bh); | ||
39 | |||
37 | mark_buffer_dirty(bh); | 40 | mark_buffer_dirty(bh); |
38 | if (wait) | 41 | if (wait) |
39 | sync_dirty_buffer(bh); | 42 | sync_dirty_buffer(bh); |
@@ -45,9 +48,7 @@ affs_put_super(struct super_block *sb) | |||
45 | struct affs_sb_info *sbi = AFFS_SB(sb); | 48 | struct affs_sb_info *sbi = AFFS_SB(sb); |
46 | pr_debug("AFFS: put_super()\n"); | 49 | pr_debug("AFFS: put_super()\n"); |
47 | 50 | ||
48 | if (!(sb->s_flags & MS_RDONLY) && sb->s_dirt) | 51 | cancel_delayed_work_sync(&sbi->sb_work); |
49 | affs_commit_super(sb, 1, 1); | ||
50 | |||
51 | kfree(sbi->s_prefix); | 52 | kfree(sbi->s_prefix); |
52 | affs_free_bitmap(sb); | 53 | affs_free_bitmap(sb); |
53 | affs_brelse(sbi->s_root_bh); | 54 | affs_brelse(sbi->s_root_bh); |
@@ -55,26 +56,43 @@ affs_put_super(struct super_block *sb) | |||
55 | sb->s_fs_info = NULL; | 56 | sb->s_fs_info = NULL; |
56 | } | 57 | } |
57 | 58 | ||
58 | static void | 59 | static int |
59 | affs_write_super(struct super_block *sb) | 60 | affs_sync_fs(struct super_block *sb, int wait) |
60 | { | 61 | { |
61 | lock_super(sb); | 62 | affs_commit_super(sb, wait); |
62 | if (!(sb->s_flags & MS_RDONLY)) | 63 | return 0; |
63 | affs_commit_super(sb, 1, 2); | 64 | } |
64 | sb->s_dirt = 0; | 65 | |
65 | unlock_super(sb); | 66 | static void flush_superblock(struct work_struct *work) |
67 | { | ||
68 | struct affs_sb_info *sbi; | ||
69 | struct super_block *sb; | ||
70 | |||
71 | sbi = container_of(work, struct affs_sb_info, sb_work.work); | ||
72 | sb = sbi->sb; | ||
66 | 73 | ||
67 | pr_debug("AFFS: write_super() at %lu, clean=2\n", get_seconds()); | 74 | spin_lock(&sbi->work_lock); |
75 | sbi->work_queued = 0; | ||
76 | spin_unlock(&sbi->work_lock); | ||
77 | |||
78 | affs_commit_super(sb, 1); | ||
68 | } | 79 | } |
69 | 80 | ||
70 | static int | 81 | void affs_mark_sb_dirty(struct super_block *sb) |
71 | affs_sync_fs(struct super_block *sb, int wait) | ||
72 | { | 82 | { |
73 | lock_super(sb); | 83 | struct affs_sb_info *sbi = AFFS_SB(sb); |
74 | affs_commit_super(sb, wait, 2); | 84 | unsigned long delay; |
75 | sb->s_dirt = 0; | 85 | |
76 | unlock_super(sb); | 86 | if (sb->s_flags & MS_RDONLY) |
77 | return 0; | 87 | return; |
88 | |||
89 | spin_lock(&sbi->work_lock); | ||
90 | if (!sbi->work_queued) { | ||
91 | delay = msecs_to_jiffies(dirty_writeback_interval * 10); | ||
92 | queue_delayed_work(system_long_wq, &sbi->sb_work, delay); | ||
93 | sbi->work_queued = 1; | ||
94 | } | ||
95 | spin_unlock(&sbi->work_lock); | ||
78 | } | 96 | } |
79 | 97 | ||
80 | static struct kmem_cache * affs_inode_cachep; | 98 | static struct kmem_cache * affs_inode_cachep; |
@@ -138,7 +156,6 @@ static const struct super_operations affs_sops = { | |||
138 | .write_inode = affs_write_inode, | 156 | .write_inode = affs_write_inode, |
139 | .evict_inode = affs_evict_inode, | 157 | .evict_inode = affs_evict_inode, |
140 | .put_super = affs_put_super, | 158 | .put_super = affs_put_super, |
141 | .write_super = affs_write_super, | ||
142 | .sync_fs = affs_sync_fs, | 159 | .sync_fs = affs_sync_fs, |
143 | .statfs = affs_statfs, | 160 | .statfs = affs_statfs, |
144 | .remount_fs = affs_remount, | 161 | .remount_fs = affs_remount, |
@@ -305,8 +322,11 @@ static int affs_fill_super(struct super_block *sb, void *data, int silent) | |||
305 | return -ENOMEM; | 322 | return -ENOMEM; |
306 | 323 | ||
307 | sb->s_fs_info = sbi; | 324 | sb->s_fs_info = sbi; |
325 | sbi->sb = sb; | ||
308 | mutex_init(&sbi->s_bmlock); | 326 | mutex_init(&sbi->s_bmlock); |
309 | spin_lock_init(&sbi->symlink_lock); | 327 | spin_lock_init(&sbi->symlink_lock); |
328 | spin_lock_init(&sbi->work_lock); | ||
329 | INIT_DELAYED_WORK(&sbi->sb_work, flush_superblock); | ||
310 | 330 | ||
311 | if (!parse_options(data,&uid,&gid,&i,&reserved,&root_block, | 331 | if (!parse_options(data,&uid,&gid,&i,&reserved,&root_block, |
312 | &blocksize,&sbi->s_prefix, | 332 | &blocksize,&sbi->s_prefix, |
@@ -531,6 +551,7 @@ affs_remount(struct super_block *sb, int *flags, char *data) | |||
531 | return -EINVAL; | 551 | return -EINVAL; |
532 | } | 552 | } |
533 | 553 | ||
554 | flush_delayed_work_sync(&sbi->sb_work); | ||
534 | replace_mount_options(sb, new_opts); | 555 | replace_mount_options(sb, new_opts); |
535 | 556 | ||
536 | sbi->s_flags = mount_flags; | 557 | sbi->s_flags = mount_flags; |
@@ -549,10 +570,9 @@ affs_remount(struct super_block *sb, int *flags, char *data) | |||
549 | if ((*flags & MS_RDONLY) == (sb->s_flags & MS_RDONLY)) | 570 | if ((*flags & MS_RDONLY) == (sb->s_flags & MS_RDONLY)) |
550 | return 0; | 571 | return 0; |
551 | 572 | ||
552 | if (*flags & MS_RDONLY) { | 573 | if (*flags & MS_RDONLY) |
553 | affs_write_super(sb); | ||
554 | affs_free_bitmap(sb); | 574 | affs_free_bitmap(sb); |
555 | } else | 575 | else |
556 | res = affs_init_bitmap(sb, flags); | 576 | res = affs_init_bitmap(sb, flags); |
557 | 577 | ||
558 | return res; | 578 | return res; |
diff --git a/fs/afs/dir.c b/fs/afs/dir.c index e22dc4b4a503..db477906ba4f 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c | |||
@@ -20,16 +20,16 @@ | |||
20 | #include "internal.h" | 20 | #include "internal.h" |
21 | 21 | ||
22 | static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry, | 22 | static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry, |
23 | struct nameidata *nd); | 23 | unsigned int flags); |
24 | static int afs_dir_open(struct inode *inode, struct file *file); | 24 | static int afs_dir_open(struct inode *inode, struct file *file); |
25 | static int afs_readdir(struct file *file, void *dirent, filldir_t filldir); | 25 | static int afs_readdir(struct file *file, void *dirent, filldir_t filldir); |
26 | static int afs_d_revalidate(struct dentry *dentry, struct nameidata *nd); | 26 | static int afs_d_revalidate(struct dentry *dentry, unsigned int flags); |
27 | static int afs_d_delete(const struct dentry *dentry); | 27 | static int afs_d_delete(const struct dentry *dentry); |
28 | static void afs_d_release(struct dentry *dentry); | 28 | static void afs_d_release(struct dentry *dentry); |
29 | static int afs_lookup_filldir(void *_cookie, const char *name, int nlen, | 29 | static int afs_lookup_filldir(void *_cookie, const char *name, int nlen, |
30 | loff_t fpos, u64 ino, unsigned dtype); | 30 | loff_t fpos, u64 ino, unsigned dtype); |
31 | static int afs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 31 | static int afs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
32 | struct nameidata *nd); | 32 | bool excl); |
33 | static int afs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode); | 33 | static int afs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode); |
34 | static int afs_rmdir(struct inode *dir, struct dentry *dentry); | 34 | static int afs_rmdir(struct inode *dir, struct dentry *dentry); |
35 | static int afs_unlink(struct inode *dir, struct dentry *dentry); | 35 | static int afs_unlink(struct inode *dir, struct dentry *dentry); |
@@ -516,7 +516,7 @@ out: | |||
516 | * look up an entry in a directory | 516 | * look up an entry in a directory |
517 | */ | 517 | */ |
518 | static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry, | 518 | static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry, |
519 | struct nameidata *nd) | 519 | unsigned int flags) |
520 | { | 520 | { |
521 | struct afs_vnode *vnode; | 521 | struct afs_vnode *vnode; |
522 | struct afs_fid fid; | 522 | struct afs_fid fid; |
@@ -598,7 +598,7 @@ success: | |||
598 | * - NOTE! the hit can be a negative hit too, so we can't assume we have an | 598 | * - NOTE! the hit can be a negative hit too, so we can't assume we have an |
599 | * inode | 599 | * inode |
600 | */ | 600 | */ |
601 | static int afs_d_revalidate(struct dentry *dentry, struct nameidata *nd) | 601 | static int afs_d_revalidate(struct dentry *dentry, unsigned int flags) |
602 | { | 602 | { |
603 | struct afs_vnode *vnode, *dir; | 603 | struct afs_vnode *vnode, *dir; |
604 | struct afs_fid uninitialized_var(fid); | 604 | struct afs_fid uninitialized_var(fid); |
@@ -607,7 +607,7 @@ static int afs_d_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
607 | void *dir_version; | 607 | void *dir_version; |
608 | int ret; | 608 | int ret; |
609 | 609 | ||
610 | if (nd->flags & LOOKUP_RCU) | 610 | if (flags & LOOKUP_RCU) |
611 | return -ECHILD; | 611 | return -ECHILD; |
612 | 612 | ||
613 | vnode = AFS_FS_I(dentry->d_inode); | 613 | vnode = AFS_FS_I(dentry->d_inode); |
@@ -949,7 +949,7 @@ error: | |||
949 | * create a regular file on an AFS filesystem | 949 | * create a regular file on an AFS filesystem |
950 | */ | 950 | */ |
951 | static int afs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 951 | static int afs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
952 | struct nameidata *nd) | 952 | bool excl) |
953 | { | 953 | { |
954 | struct afs_file_status status; | 954 | struct afs_file_status status; |
955 | struct afs_callback cb; | 955 | struct afs_callback cb; |
diff --git a/fs/afs/mntpt.c b/fs/afs/mntpt.c index 298cf8919ec7..9682c33d5daf 100644 --- a/fs/afs/mntpt.c +++ b/fs/afs/mntpt.c | |||
@@ -22,7 +22,7 @@ | |||
22 | 22 | ||
23 | static struct dentry *afs_mntpt_lookup(struct inode *dir, | 23 | static struct dentry *afs_mntpt_lookup(struct inode *dir, |
24 | struct dentry *dentry, | 24 | struct dentry *dentry, |
25 | struct nameidata *nd); | 25 | unsigned int flags); |
26 | static int afs_mntpt_open(struct inode *inode, struct file *file); | 26 | static int afs_mntpt_open(struct inode *inode, struct file *file); |
27 | static void afs_mntpt_expiry_timed_out(struct work_struct *work); | 27 | static void afs_mntpt_expiry_timed_out(struct work_struct *work); |
28 | 28 | ||
@@ -104,7 +104,7 @@ out: | |||
104 | */ | 104 | */ |
105 | static struct dentry *afs_mntpt_lookup(struct inode *dir, | 105 | static struct dentry *afs_mntpt_lookup(struct inode *dir, |
106 | struct dentry *dentry, | 106 | struct dentry *dentry, |
107 | struct nameidata *nd) | 107 | unsigned int flags) |
108 | { | 108 | { |
109 | _enter("%p,%p{%p{%s},%s}", | 109 | _enter("%p,%p{%p{%s},%s}", |
110 | dir, | 110 | dir, |
diff --git a/fs/afs/super.c b/fs/afs/super.c index f02b31e7e648..df8c6047c2a1 100644 --- a/fs/afs/super.c +++ b/fs/afs/super.c | |||
@@ -395,7 +395,7 @@ static struct dentry *afs_mount(struct file_system_type *fs_type, | |||
395 | as->volume = vol; | 395 | as->volume = vol; |
396 | 396 | ||
397 | /* allocate a deviceless superblock */ | 397 | /* allocate a deviceless superblock */ |
398 | sb = sget(fs_type, afs_test_super, afs_set_super, as); | 398 | sb = sget(fs_type, afs_test_super, afs_set_super, flags, as); |
399 | if (IS_ERR(sb)) { | 399 | if (IS_ERR(sb)) { |
400 | ret = PTR_ERR(sb); | 400 | ret = PTR_ERR(sb); |
401 | afs_put_volume(vol); | 401 | afs_put_volume(vol); |
@@ -406,7 +406,6 @@ static struct dentry *afs_mount(struct file_system_type *fs_type, | |||
406 | if (!sb->s_root) { | 406 | if (!sb->s_root) { |
407 | /* initial superblock/root creation */ | 407 | /* initial superblock/root creation */ |
408 | _debug("create"); | 408 | _debug("create"); |
409 | sb->s_flags = flags; | ||
410 | ret = afs_fill_super(sb, ¶ms); | 409 | ret = afs_fill_super(sb, ¶ms); |
411 | if (ret < 0) { | 410 | if (ret < 0) { |
412 | deactivate_locked_super(sb); | 411 | deactivate_locked_super(sb); |
@@ -56,13 +56,6 @@ static struct kmem_cache *kioctx_cachep; | |||
56 | 56 | ||
57 | static struct workqueue_struct *aio_wq; | 57 | static struct workqueue_struct *aio_wq; |
58 | 58 | ||
59 | /* Used for rare fput completion. */ | ||
60 | static void aio_fput_routine(struct work_struct *); | ||
61 | static DECLARE_WORK(fput_work, aio_fput_routine); | ||
62 | |||
63 | static DEFINE_SPINLOCK(fput_lock); | ||
64 | static LIST_HEAD(fput_head); | ||
65 | |||
66 | static void aio_kick_handler(struct work_struct *); | 59 | static void aio_kick_handler(struct work_struct *); |
67 | static void aio_queue_work(struct kioctx *); | 60 | static void aio_queue_work(struct kioctx *); |
68 | 61 | ||
@@ -479,7 +472,6 @@ static int kiocb_batch_refill(struct kioctx *ctx, struct kiocb_batch *batch) | |||
479 | { | 472 | { |
480 | unsigned short allocated, to_alloc; | 473 | unsigned short allocated, to_alloc; |
481 | long avail; | 474 | long avail; |
482 | bool called_fput = false; | ||
483 | struct kiocb *req, *n; | 475 | struct kiocb *req, *n; |
484 | struct aio_ring *ring; | 476 | struct aio_ring *ring; |
485 | 477 | ||
@@ -495,28 +487,11 @@ static int kiocb_batch_refill(struct kioctx *ctx, struct kiocb_batch *batch) | |||
495 | if (allocated == 0) | 487 | if (allocated == 0) |
496 | goto out; | 488 | goto out; |
497 | 489 | ||
498 | retry: | ||
499 | spin_lock_irq(&ctx->ctx_lock); | 490 | spin_lock_irq(&ctx->ctx_lock); |
500 | ring = kmap_atomic(ctx->ring_info.ring_pages[0]); | 491 | ring = kmap_atomic(ctx->ring_info.ring_pages[0]); |
501 | 492 | ||
502 | avail = aio_ring_avail(&ctx->ring_info, ring) - ctx->reqs_active; | 493 | avail = aio_ring_avail(&ctx->ring_info, ring) - ctx->reqs_active; |
503 | BUG_ON(avail < 0); | 494 | BUG_ON(avail < 0); |
504 | if (avail == 0 && !called_fput) { | ||
505 | /* | ||
506 | * Handle a potential starvation case. It is possible that | ||
507 | * we hold the last reference on a struct file, causing us | ||
508 | * to delay the final fput to non-irq context. In this case, | ||
509 | * ctx->reqs_active is artificially high. Calling the fput | ||
510 | * routine here may free up a slot in the event completion | ||
511 | * ring, allowing this allocation to succeed. | ||
512 | */ | ||
513 | kunmap_atomic(ring); | ||
514 | spin_unlock_irq(&ctx->ctx_lock); | ||
515 | aio_fput_routine(NULL); | ||
516 | called_fput = true; | ||
517 | goto retry; | ||
518 | } | ||
519 | |||
520 | if (avail < allocated) { | 495 | if (avail < allocated) { |
521 | /* Trim back the number of requests. */ | 496 | /* Trim back the number of requests. */ |
522 | list_for_each_entry_safe(req, n, &batch->head, ki_batch) { | 497 | list_for_each_entry_safe(req, n, &batch->head, ki_batch) { |
@@ -570,36 +545,6 @@ static inline void really_put_req(struct kioctx *ctx, struct kiocb *req) | |||
570 | wake_up_all(&ctx->wait); | 545 | wake_up_all(&ctx->wait); |
571 | } | 546 | } |
572 | 547 | ||
573 | static void aio_fput_routine(struct work_struct *data) | ||
574 | { | ||
575 | spin_lock_irq(&fput_lock); | ||
576 | while (likely(!list_empty(&fput_head))) { | ||
577 | struct kiocb *req = list_kiocb(fput_head.next); | ||
578 | struct kioctx *ctx = req->ki_ctx; | ||
579 | |||
580 | list_del(&req->ki_list); | ||
581 | spin_unlock_irq(&fput_lock); | ||
582 | |||
583 | /* Complete the fput(s) */ | ||
584 | if (req->ki_filp != NULL) | ||
585 | fput(req->ki_filp); | ||
586 | |||
587 | /* Link the iocb into the context's free list */ | ||
588 | rcu_read_lock(); | ||
589 | spin_lock_irq(&ctx->ctx_lock); | ||
590 | really_put_req(ctx, req); | ||
591 | /* | ||
592 | * at that point ctx might've been killed, but actual | ||
593 | * freeing is RCU'd | ||
594 | */ | ||
595 | spin_unlock_irq(&ctx->ctx_lock); | ||
596 | rcu_read_unlock(); | ||
597 | |||
598 | spin_lock_irq(&fput_lock); | ||
599 | } | ||
600 | spin_unlock_irq(&fput_lock); | ||
601 | } | ||
602 | |||
603 | /* __aio_put_req | 548 | /* __aio_put_req |
604 | * Returns true if this put was the last user of the request. | 549 | * Returns true if this put was the last user of the request. |
605 | */ | 550 | */ |
@@ -618,21 +563,9 @@ static int __aio_put_req(struct kioctx *ctx, struct kiocb *req) | |||
618 | req->ki_cancel = NULL; | 563 | req->ki_cancel = NULL; |
619 | req->ki_retry = NULL; | 564 | req->ki_retry = NULL; |
620 | 565 | ||
621 | /* | 566 | fput(req->ki_filp); |
622 | * Try to optimize the aio and eventfd file* puts, by avoiding to | 567 | req->ki_filp = NULL; |
623 | * schedule work in case it is not final fput() time. In normal cases, | 568 | really_put_req(ctx, req); |
624 | * we would not be holding the last reference to the file*, so | ||
625 | * this function will be executed w/out any aio kthread wakeup. | ||
626 | */ | ||
627 | if (unlikely(!fput_atomic(req->ki_filp))) { | ||
628 | spin_lock(&fput_lock); | ||
629 | list_add(&req->ki_list, &fput_head); | ||
630 | spin_unlock(&fput_lock); | ||
631 | schedule_work(&fput_work); | ||
632 | } else { | ||
633 | req->ki_filp = NULL; | ||
634 | really_put_req(ctx, req); | ||
635 | } | ||
636 | return 1; | 569 | return 1; |
637 | } | 570 | } |
638 | 571 | ||
@@ -171,6 +171,8 @@ int notify_change(struct dentry * dentry, struct iattr * attr) | |||
171 | struct timespec now; | 171 | struct timespec now; |
172 | unsigned int ia_valid = attr->ia_valid; | 172 | unsigned int ia_valid = attr->ia_valid; |
173 | 173 | ||
174 | WARN_ON_ONCE(!mutex_is_locked(&inode->i_mutex)); | ||
175 | |||
174 | if (ia_valid & (ATTR_MODE | ATTR_UID | ATTR_GID | ATTR_TIMES_SET)) { | 176 | if (ia_valid & (ATTR_MODE | ATTR_UID | ATTR_GID | ATTR_TIMES_SET)) { |
175 | if (IS_IMMUTABLE(inode) || IS_APPEND(inode)) | 177 | if (IS_IMMUTABLE(inode) || IS_APPEND(inode)) |
176 | return -EPERM; | 178 | return -EPERM; |
@@ -250,5 +252,4 @@ int notify_change(struct dentry * dentry, struct iattr * attr) | |||
250 | 252 | ||
251 | return error; | 253 | return error; |
252 | } | 254 | } |
253 | |||
254 | EXPORT_SYMBOL(notify_change); | 255 | EXPORT_SYMBOL(notify_change); |
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c index aa9103f8f01b..abf645c1703b 100644 --- a/fs/autofs4/dev-ioctl.c +++ b/fs/autofs4/dev-ioctl.c | |||
@@ -257,8 +257,8 @@ static int autofs_dev_ioctl_open_mountpoint(const char *name, dev_t devid) | |||
257 | * corresponding to the autofs fs we want to open. | 257 | * corresponding to the autofs fs we want to open. |
258 | */ | 258 | */ |
259 | 259 | ||
260 | filp = dentry_open(path.dentry, path.mnt, O_RDONLY, | 260 | filp = dentry_open(&path, O_RDONLY, current_cred()); |
261 | current_cred()); | 261 | path_put(&path); |
262 | if (IS_ERR(filp)) { | 262 | if (IS_ERR(filp)) { |
263 | err = PTR_ERR(filp); | 263 | err = PTR_ERR(filp); |
264 | goto out; | 264 | goto out; |
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c index 75e5f1c8e028..e7396cfdb109 100644 --- a/fs/autofs4/root.c +++ b/fs/autofs4/root.c | |||
@@ -32,7 +32,7 @@ static long autofs4_root_ioctl(struct file *,unsigned int,unsigned long); | |||
32 | static long autofs4_root_compat_ioctl(struct file *,unsigned int,unsigned long); | 32 | static long autofs4_root_compat_ioctl(struct file *,unsigned int,unsigned long); |
33 | #endif | 33 | #endif |
34 | static int autofs4_dir_open(struct inode *inode, struct file *file); | 34 | static int autofs4_dir_open(struct inode *inode, struct file *file); |
35 | static struct dentry *autofs4_lookup(struct inode *,struct dentry *, struct nameidata *); | 35 | static struct dentry *autofs4_lookup(struct inode *,struct dentry *, unsigned int); |
36 | static struct vfsmount *autofs4_d_automount(struct path *); | 36 | static struct vfsmount *autofs4_d_automount(struct path *); |
37 | static int autofs4_d_manage(struct dentry *, bool); | 37 | static int autofs4_d_manage(struct dentry *, bool); |
38 | static void autofs4_dentry_release(struct dentry *); | 38 | static void autofs4_dentry_release(struct dentry *); |
@@ -458,7 +458,7 @@ int autofs4_d_manage(struct dentry *dentry, bool rcu_walk) | |||
458 | } | 458 | } |
459 | 459 | ||
460 | /* Lookups in the root directory */ | 460 | /* Lookups in the root directory */ |
461 | static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 461 | static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
462 | { | 462 | { |
463 | struct autofs_sb_info *sbi; | 463 | struct autofs_sb_info *sbi; |
464 | struct autofs_info *ino; | 464 | struct autofs_info *ino; |
diff --git a/fs/bad_inode.c b/fs/bad_inode.c index 1b35d6bd06b0..b1342ffb3cf6 100644 --- a/fs/bad_inode.c +++ b/fs/bad_inode.c | |||
@@ -173,13 +173,13 @@ static const struct file_operations bad_file_ops = | |||
173 | }; | 173 | }; |
174 | 174 | ||
175 | static int bad_inode_create (struct inode *dir, struct dentry *dentry, | 175 | static int bad_inode_create (struct inode *dir, struct dentry *dentry, |
176 | umode_t mode, struct nameidata *nd) | 176 | umode_t mode, bool excl) |
177 | { | 177 | { |
178 | return -EIO; | 178 | return -EIO; |
179 | } | 179 | } |
180 | 180 | ||
181 | static struct dentry *bad_inode_lookup(struct inode *dir, | 181 | static struct dentry *bad_inode_lookup(struct inode *dir, |
182 | struct dentry *dentry, struct nameidata *nd) | 182 | struct dentry *dentry, unsigned int flags) |
183 | { | 183 | { |
184 | return ERR_PTR(-EIO); | 184 | return ERR_PTR(-EIO); |
185 | } | 185 | } |
diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index e18da23d42b5..cf7f3c67c8b7 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c | |||
@@ -34,7 +34,7 @@ static int befs_readdir(struct file *, void *, filldir_t); | |||
34 | static int befs_get_block(struct inode *, sector_t, struct buffer_head *, int); | 34 | static int befs_get_block(struct inode *, sector_t, struct buffer_head *, int); |
35 | static int befs_readpage(struct file *file, struct page *page); | 35 | static int befs_readpage(struct file *file, struct page *page); |
36 | static sector_t befs_bmap(struct address_space *mapping, sector_t block); | 36 | static sector_t befs_bmap(struct address_space *mapping, sector_t block); |
37 | static struct dentry *befs_lookup(struct inode *, struct dentry *, struct nameidata *); | 37 | static struct dentry *befs_lookup(struct inode *, struct dentry *, unsigned int); |
38 | static struct inode *befs_iget(struct super_block *, unsigned long); | 38 | static struct inode *befs_iget(struct super_block *, unsigned long); |
39 | static struct inode *befs_alloc_inode(struct super_block *sb); | 39 | static struct inode *befs_alloc_inode(struct super_block *sb); |
40 | static void befs_destroy_inode(struct inode *inode); | 40 | static void befs_destroy_inode(struct inode *inode); |
@@ -159,7 +159,7 @@ befs_get_block(struct inode *inode, sector_t block, | |||
159 | } | 159 | } |
160 | 160 | ||
161 | static struct dentry * | 161 | static struct dentry * |
162 | befs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 162 | befs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
163 | { | 163 | { |
164 | struct inode *inode = NULL; | 164 | struct inode *inode = NULL; |
165 | struct super_block *sb = dir->i_sb; | 165 | struct super_block *sb = dir->i_sb; |
diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index d12c7966db27..2785ef91191a 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c | |||
@@ -85,7 +85,7 @@ const struct file_operations bfs_dir_operations = { | |||
85 | extern void dump_imap(const char *, struct super_block *); | 85 | extern void dump_imap(const char *, struct super_block *); |
86 | 86 | ||
87 | static int bfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 87 | static int bfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
88 | struct nameidata *nd) | 88 | bool excl) |
89 | { | 89 | { |
90 | int err; | 90 | int err; |
91 | struct inode *inode; | 91 | struct inode *inode; |
@@ -133,7 +133,7 @@ static int bfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | |||
133 | } | 133 | } |
134 | 134 | ||
135 | static struct dentry *bfs_lookup(struct inode *dir, struct dentry *dentry, | 135 | static struct dentry *bfs_lookup(struct inode *dir, struct dentry *dentry, |
136 | struct nameidata *nd) | 136 | unsigned int flags) |
137 | { | 137 | { |
138 | struct inode *inode = NULL; | 138 | struct inode *inode = NULL; |
139 | struct buffer_head *bh; | 139 | struct buffer_head *bh; |
diff --git a/fs/block_dev.c b/fs/block_dev.c index c2bbe1fb1326..1e519195d45b 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c | |||
@@ -1710,3 +1710,39 @@ int __invalidate_device(struct block_device *bdev, bool kill_dirty) | |||
1710 | return res; | 1710 | return res; |
1711 | } | 1711 | } |
1712 | EXPORT_SYMBOL(__invalidate_device); | 1712 | EXPORT_SYMBOL(__invalidate_device); |
1713 | |||
1714 | void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg) | ||
1715 | { | ||
1716 | struct inode *inode, *old_inode = NULL; | ||
1717 | |||
1718 | spin_lock(&inode_sb_list_lock); | ||
1719 | list_for_each_entry(inode, &blockdev_superblock->s_inodes, i_sb_list) { | ||
1720 | struct address_space *mapping = inode->i_mapping; | ||
1721 | |||
1722 | spin_lock(&inode->i_lock); | ||
1723 | if (inode->i_state & (I_FREEING|I_WILL_FREE|I_NEW) || | ||
1724 | mapping->nrpages == 0) { | ||
1725 | spin_unlock(&inode->i_lock); | ||
1726 | continue; | ||
1727 | } | ||
1728 | __iget(inode); | ||
1729 | spin_unlock(&inode->i_lock); | ||
1730 | spin_unlock(&inode_sb_list_lock); | ||
1731 | /* | ||
1732 | * We hold a reference to 'inode' so it couldn't have been | ||
1733 | * removed from s_inodes list while we dropped the | ||
1734 | * inode_sb_list_lock. We cannot iput the inode now as we can | ||
1735 | * be holding the last reference and we cannot iput it under | ||
1736 | * inode_sb_list_lock. So we keep the reference and iput it | ||
1737 | * later. | ||
1738 | */ | ||
1739 | iput(old_inode); | ||
1740 | old_inode = inode; | ||
1741 | |||
1742 | func(I_BDEV(inode), arg); | ||
1743 | |||
1744 | spin_lock(&inode_sb_list_lock); | ||
1745 | } | ||
1746 | spin_unlock(&inode_sb_list_lock); | ||
1747 | iput(old_inode); | ||
1748 | } | ||
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 3f75895c919b..a383c18e74e8 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c | |||
@@ -179,60 +179,74 @@ static int __add_prelim_ref(struct list_head *head, u64 root_id, | |||
179 | 179 | ||
180 | static int add_all_parents(struct btrfs_root *root, struct btrfs_path *path, | 180 | static int add_all_parents(struct btrfs_root *root, struct btrfs_path *path, |
181 | struct ulist *parents, int level, | 181 | struct ulist *parents, int level, |
182 | struct btrfs_key *key, u64 wanted_disk_byte, | 182 | struct btrfs_key *key_for_search, u64 time_seq, |
183 | u64 wanted_disk_byte, | ||
183 | const u64 *extent_item_pos) | 184 | const u64 *extent_item_pos) |
184 | { | 185 | { |
185 | int ret; | 186 | int ret = 0; |
186 | int slot = path->slots[level]; | 187 | int slot; |
187 | struct extent_buffer *eb = path->nodes[level]; | 188 | struct extent_buffer *eb; |
189 | struct btrfs_key key; | ||
188 | struct btrfs_file_extent_item *fi; | 190 | struct btrfs_file_extent_item *fi; |
189 | struct extent_inode_elem *eie = NULL; | 191 | struct extent_inode_elem *eie = NULL; |
190 | u64 disk_byte; | 192 | u64 disk_byte; |
191 | u64 wanted_objectid = key->objectid; | ||
192 | 193 | ||
193 | add_parent: | 194 | if (level != 0) { |
194 | if (level == 0 && extent_item_pos) { | 195 | eb = path->nodes[level]; |
195 | fi = btrfs_item_ptr(eb, slot, struct btrfs_file_extent_item); | 196 | ret = ulist_add(parents, eb->start, 0, GFP_NOFS); |
196 | ret = check_extent_in_eb(key, eb, fi, *extent_item_pos, &eie); | ||
197 | if (ret < 0) | 197 | if (ret < 0) |
198 | return ret; | 198 | return ret; |
199 | } | ||
200 | ret = ulist_add(parents, eb->start, (unsigned long)eie, GFP_NOFS); | ||
201 | if (ret < 0) | ||
202 | return ret; | ||
203 | |||
204 | if (level != 0) | ||
205 | return 0; | 199 | return 0; |
200 | } | ||
206 | 201 | ||
207 | /* | 202 | /* |
208 | * if the current leaf is full with EXTENT_DATA items, we must | 203 | * We normally enter this function with the path already pointing to |
209 | * check the next one if that holds a reference as well. | 204 | * the first item to check. But sometimes, we may enter it with |
210 | * ref->count cannot be used to skip this check. | 205 | * slot==nritems. In that case, go to the next leaf before we continue. |
211 | * repeat this until we don't find any additional EXTENT_DATA items. | ||
212 | */ | 206 | */ |
213 | while (1) { | 207 | if (path->slots[0] >= btrfs_header_nritems(path->nodes[0])) |
214 | eie = NULL; | 208 | ret = btrfs_next_old_leaf(root, path, time_seq); |
215 | ret = btrfs_next_leaf(root, path); | ||
216 | if (ret < 0) | ||
217 | return ret; | ||
218 | if (ret) | ||
219 | return 0; | ||
220 | 209 | ||
210 | while (!ret) { | ||
221 | eb = path->nodes[0]; | 211 | eb = path->nodes[0]; |
222 | for (slot = 0; slot < btrfs_header_nritems(eb); ++slot) { | 212 | slot = path->slots[0]; |
223 | btrfs_item_key_to_cpu(eb, key, slot); | 213 | |
224 | if (key->objectid != wanted_objectid || | 214 | btrfs_item_key_to_cpu(eb, &key, slot); |
225 | key->type != BTRFS_EXTENT_DATA_KEY) | 215 | |
226 | return 0; | 216 | if (key.objectid != key_for_search->objectid || |
227 | fi = btrfs_item_ptr(eb, slot, | 217 | key.type != BTRFS_EXTENT_DATA_KEY) |
228 | struct btrfs_file_extent_item); | 218 | break; |
229 | disk_byte = btrfs_file_extent_disk_bytenr(eb, fi); | 219 | |
230 | if (disk_byte == wanted_disk_byte) | 220 | fi = btrfs_item_ptr(eb, slot, struct btrfs_file_extent_item); |
231 | goto add_parent; | 221 | disk_byte = btrfs_file_extent_disk_bytenr(eb, fi); |
222 | |||
223 | if (disk_byte == wanted_disk_byte) { | ||
224 | eie = NULL; | ||
225 | if (extent_item_pos) { | ||
226 | ret = check_extent_in_eb(&key, eb, fi, | ||
227 | *extent_item_pos, | ||
228 | &eie); | ||
229 | if (ret < 0) | ||
230 | break; | ||
231 | } | ||
232 | if (!ret) { | ||
233 | ret = ulist_add(parents, eb->start, | ||
234 | (unsigned long)eie, GFP_NOFS); | ||
235 | if (ret < 0) | ||
236 | break; | ||
237 | if (!extent_item_pos) { | ||
238 | ret = btrfs_next_old_leaf(root, path, | ||
239 | time_seq); | ||
240 | continue; | ||
241 | } | ||
242 | } | ||
232 | } | 243 | } |
244 | ret = btrfs_next_old_item(root, path, time_seq); | ||
233 | } | 245 | } |
234 | 246 | ||
235 | return 0; | 247 | if (ret > 0) |
248 | ret = 0; | ||
249 | return ret; | ||
236 | } | 250 | } |
237 | 251 | ||
238 | /* | 252 | /* |
@@ -249,7 +263,6 @@ static int __resolve_indirect_ref(struct btrfs_fs_info *fs_info, | |||
249 | struct btrfs_path *path; | 263 | struct btrfs_path *path; |
250 | struct btrfs_root *root; | 264 | struct btrfs_root *root; |
251 | struct btrfs_key root_key; | 265 | struct btrfs_key root_key; |
252 | struct btrfs_key key = {0}; | ||
253 | struct extent_buffer *eb; | 266 | struct extent_buffer *eb; |
254 | int ret = 0; | 267 | int ret = 0; |
255 | int root_level; | 268 | int root_level; |
@@ -288,25 +301,19 @@ static int __resolve_indirect_ref(struct btrfs_fs_info *fs_info, | |||
288 | goto out; | 301 | goto out; |
289 | 302 | ||
290 | eb = path->nodes[level]; | 303 | eb = path->nodes[level]; |
291 | if (!eb) { | 304 | while (!eb) { |
292 | WARN_ON(1); | 305 | if (!level) { |
293 | ret = 1; | 306 | WARN_ON(1); |
294 | goto out; | 307 | ret = 1; |
295 | } | 308 | goto out; |
296 | |||
297 | if (level == 0) { | ||
298 | if (ret == 1 && path->slots[0] >= btrfs_header_nritems(eb)) { | ||
299 | ret = btrfs_next_leaf(root, path); | ||
300 | if (ret) | ||
301 | goto out; | ||
302 | eb = path->nodes[0]; | ||
303 | } | 309 | } |
304 | 310 | level--; | |
305 | btrfs_item_key_to_cpu(eb, &key, path->slots[0]); | 311 | eb = path->nodes[level]; |
306 | } | 312 | } |
307 | 313 | ||
308 | ret = add_all_parents(root, path, parents, level, &key, | 314 | ret = add_all_parents(root, path, parents, level, &ref->key_for_search, |
309 | ref->wanted_disk_byte, extent_item_pos); | 315 | time_seq, ref->wanted_disk_byte, |
316 | extent_item_pos); | ||
310 | out: | 317 | out: |
311 | btrfs_free_path(path); | 318 | btrfs_free_path(path); |
312 | return ret; | 319 | return ret; |
@@ -832,6 +839,7 @@ again: | |||
832 | } | 839 | } |
833 | ret = __add_delayed_refs(head, delayed_ref_seq, | 840 | ret = __add_delayed_refs(head, delayed_ref_seq, |
834 | &prefs_delayed); | 841 | &prefs_delayed); |
842 | mutex_unlock(&head->mutex); | ||
835 | if (ret) { | 843 | if (ret) { |
836 | spin_unlock(&delayed_refs->lock); | 844 | spin_unlock(&delayed_refs->lock); |
837 | goto out; | 845 | goto out; |
@@ -925,8 +933,6 @@ again: | |||
925 | } | 933 | } |
926 | 934 | ||
927 | out: | 935 | out: |
928 | if (head) | ||
929 | mutex_unlock(&head->mutex); | ||
930 | btrfs_free_path(path); | 936 | btrfs_free_path(path); |
931 | while (!list_empty(&prefs)) { | 937 | while (!list_empty(&prefs)) { |
932 | ref = list_first_entry(&prefs, struct __prelim_ref, list); | 938 | ref = list_first_entry(&prefs, struct __prelim_ref, list); |
diff --git a/fs/btrfs/btrfs_inode.h b/fs/btrfs/btrfs_inode.h index e616f8872e69..12394a90d60f 100644 --- a/fs/btrfs/btrfs_inode.h +++ b/fs/btrfs/btrfs_inode.h | |||
@@ -37,6 +37,7 @@ | |||
37 | #define BTRFS_INODE_IN_DEFRAG 3 | 37 | #define BTRFS_INODE_IN_DEFRAG 3 |
38 | #define BTRFS_INODE_DELALLOC_META_RESERVED 4 | 38 | #define BTRFS_INODE_DELALLOC_META_RESERVED 4 |
39 | #define BTRFS_INODE_HAS_ORPHAN_ITEM 5 | 39 | #define BTRFS_INODE_HAS_ORPHAN_ITEM 5 |
40 | #define BTRFS_INODE_HAS_ASYNC_EXTENT 6 | ||
40 | 41 | ||
41 | /* in memory btrfs inode */ | 42 | /* in memory btrfs inode */ |
42 | struct btrfs_inode { | 43 | struct btrfs_inode { |
diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index 9cebb1fd6a3c..da6e9364a5e3 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs/btrfs/check-integrity.c | |||
@@ -93,6 +93,7 @@ | |||
93 | #include "print-tree.h" | 93 | #include "print-tree.h" |
94 | #include "locking.h" | 94 | #include "locking.h" |
95 | #include "check-integrity.h" | 95 | #include "check-integrity.h" |
96 | #include "rcu-string.h" | ||
96 | 97 | ||
97 | #define BTRFSIC_BLOCK_HASHTABLE_SIZE 0x10000 | 98 | #define BTRFSIC_BLOCK_HASHTABLE_SIZE 0x10000 |
98 | #define BTRFSIC_BLOCK_LINK_HASHTABLE_SIZE 0x10000 | 99 | #define BTRFSIC_BLOCK_LINK_HASHTABLE_SIZE 0x10000 |
@@ -843,13 +844,14 @@ static int btrfsic_process_superblock_dev_mirror( | |||
843 | superblock_tmp->never_written = 0; | 844 | superblock_tmp->never_written = 0; |
844 | superblock_tmp->mirror_num = 1 + superblock_mirror_num; | 845 | superblock_tmp->mirror_num = 1 + superblock_mirror_num; |
845 | if (state->print_mask & BTRFSIC_PRINT_MASK_SUPERBLOCK_WRITE) | 846 | if (state->print_mask & BTRFSIC_PRINT_MASK_SUPERBLOCK_WRITE) |
846 | printk(KERN_INFO "New initial S-block (bdev %p, %s)" | 847 | printk_in_rcu(KERN_INFO "New initial S-block (bdev %p, %s)" |
847 | " @%llu (%s/%llu/%d)\n", | 848 | " @%llu (%s/%llu/%d)\n", |
848 | superblock_bdev, device->name, | 849 | superblock_bdev, |
849 | (unsigned long long)dev_bytenr, | 850 | rcu_str_deref(device->name), |
850 | dev_state->name, | 851 | (unsigned long long)dev_bytenr, |
851 | (unsigned long long)dev_bytenr, | 852 | dev_state->name, |
852 | superblock_mirror_num); | 853 | (unsigned long long)dev_bytenr, |
854 | superblock_mirror_num); | ||
853 | list_add(&superblock_tmp->all_blocks_node, | 855 | list_add(&superblock_tmp->all_blocks_node, |
854 | &state->all_blocks_list); | 856 | &state->all_blocks_list); |
855 | btrfsic_block_hashtable_add(superblock_tmp, | 857 | btrfsic_block_hashtable_add(superblock_tmp, |
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index d7a96cfdc50a..8206b3900587 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c | |||
@@ -467,6 +467,15 @@ static inline int tree_mod_dont_log(struct btrfs_fs_info *fs_info, | |||
467 | return 0; | 467 | return 0; |
468 | } | 468 | } |
469 | 469 | ||
470 | /* | ||
471 | * This allocates memory and gets a tree modification sequence number when | ||
472 | * needed. | ||
473 | * | ||
474 | * Returns 0 when no sequence number is needed, < 0 on error. | ||
475 | * Returns 1 when a sequence number was added. In this case, | ||
476 | * fs_info->tree_mod_seq_lock was acquired and must be released by the caller | ||
477 | * after inserting into the rb tree. | ||
478 | */ | ||
470 | static inline int tree_mod_alloc(struct btrfs_fs_info *fs_info, gfp_t flags, | 479 | static inline int tree_mod_alloc(struct btrfs_fs_info *fs_info, gfp_t flags, |
471 | struct tree_mod_elem **tm_ret) | 480 | struct tree_mod_elem **tm_ret) |
472 | { | 481 | { |
@@ -491,11 +500,11 @@ static inline int tree_mod_alloc(struct btrfs_fs_info *fs_info, gfp_t flags, | |||
491 | */ | 500 | */ |
492 | kfree(tm); | 501 | kfree(tm); |
493 | seq = 0; | 502 | seq = 0; |
503 | spin_unlock(&fs_info->tree_mod_seq_lock); | ||
494 | } else { | 504 | } else { |
495 | __get_tree_mod_seq(fs_info, &tm->elem); | 505 | __get_tree_mod_seq(fs_info, &tm->elem); |
496 | seq = tm->elem.seq; | 506 | seq = tm->elem.seq; |
497 | } | 507 | } |
498 | spin_unlock(&fs_info->tree_mod_seq_lock); | ||
499 | 508 | ||
500 | return seq; | 509 | return seq; |
501 | } | 510 | } |
@@ -521,7 +530,9 @@ tree_mod_log_insert_key_mask(struct btrfs_fs_info *fs_info, | |||
521 | tm->slot = slot; | 530 | tm->slot = slot; |
522 | tm->generation = btrfs_node_ptr_generation(eb, slot); | 531 | tm->generation = btrfs_node_ptr_generation(eb, slot); |
523 | 532 | ||
524 | return __tree_mod_log_insert(fs_info, tm); | 533 | ret = __tree_mod_log_insert(fs_info, tm); |
534 | spin_unlock(&fs_info->tree_mod_seq_lock); | ||
535 | return ret; | ||
525 | } | 536 | } |
526 | 537 | ||
527 | static noinline int | 538 | static noinline int |
@@ -559,7 +570,9 @@ tree_mod_log_insert_move(struct btrfs_fs_info *fs_info, | |||
559 | tm->move.nr_items = nr_items; | 570 | tm->move.nr_items = nr_items; |
560 | tm->op = MOD_LOG_MOVE_KEYS; | 571 | tm->op = MOD_LOG_MOVE_KEYS; |
561 | 572 | ||
562 | return __tree_mod_log_insert(fs_info, tm); | 573 | ret = __tree_mod_log_insert(fs_info, tm); |
574 | spin_unlock(&fs_info->tree_mod_seq_lock); | ||
575 | return ret; | ||
563 | } | 576 | } |
564 | 577 | ||
565 | static noinline int | 578 | static noinline int |
@@ -580,7 +593,9 @@ tree_mod_log_insert_root(struct btrfs_fs_info *fs_info, | |||
580 | tm->generation = btrfs_header_generation(old_root); | 593 | tm->generation = btrfs_header_generation(old_root); |
581 | tm->op = MOD_LOG_ROOT_REPLACE; | 594 | tm->op = MOD_LOG_ROOT_REPLACE; |
582 | 595 | ||
583 | return __tree_mod_log_insert(fs_info, tm); | 596 | ret = __tree_mod_log_insert(fs_info, tm); |
597 | spin_unlock(&fs_info->tree_mod_seq_lock); | ||
598 | return ret; | ||
584 | } | 599 | } |
585 | 600 | ||
586 | static struct tree_mod_elem * | 601 | static struct tree_mod_elem * |
@@ -1009,11 +1024,18 @@ __tree_mod_log_oldest_root(struct btrfs_fs_info *fs_info, | |||
1009 | if (!looped && !tm) | 1024 | if (!looped && !tm) |
1010 | return 0; | 1025 | return 0; |
1011 | /* | 1026 | /* |
1012 | * we must have key remove operations in the log before the | 1027 | * if there are no tree operation for the oldest root, we simply |
1013 | * replace operation. | 1028 | * return it. this should only happen if that (old) root is at |
1029 | * level 0. | ||
1014 | */ | 1030 | */ |
1015 | BUG_ON(!tm); | 1031 | if (!tm) |
1032 | break; | ||
1016 | 1033 | ||
1034 | /* | ||
1035 | * if there's an operation that's not a root replacement, we | ||
1036 | * found the oldest version of our root. normally, we'll find a | ||
1037 | * MOD_LOG_KEY_REMOVE_WHILE_FREEING operation here. | ||
1038 | */ | ||
1017 | if (tm->op != MOD_LOG_ROOT_REPLACE) | 1039 | if (tm->op != MOD_LOG_ROOT_REPLACE) |
1018 | break; | 1040 | break; |
1019 | 1041 | ||
@@ -1023,6 +1045,10 @@ __tree_mod_log_oldest_root(struct btrfs_fs_info *fs_info, | |||
1023 | looped = 1; | 1045 | looped = 1; |
1024 | } | 1046 | } |
1025 | 1047 | ||
1048 | /* if there's no old root to return, return what we found instead */ | ||
1049 | if (!found) | ||
1050 | found = tm; | ||
1051 | |||
1026 | return found; | 1052 | return found; |
1027 | } | 1053 | } |
1028 | 1054 | ||
@@ -1068,11 +1094,7 @@ __tree_mod_log_rewind(struct extent_buffer *eb, u64 time_seq, | |||
1068 | tm->generation); | 1094 | tm->generation); |
1069 | break; | 1095 | break; |
1070 | case MOD_LOG_KEY_ADD: | 1096 | case MOD_LOG_KEY_ADD: |
1071 | if (tm->slot != n - 1) { | 1097 | /* if a move operation is needed it's in the log */ |
1072 | o_dst = btrfs_node_key_ptr_offset(tm->slot); | ||
1073 | o_src = btrfs_node_key_ptr_offset(tm->slot + 1); | ||
1074 | memmove_extent_buffer(eb, o_dst, o_src, p_size); | ||
1075 | } | ||
1076 | n--; | 1098 | n--; |
1077 | break; | 1099 | break; |
1078 | case MOD_LOG_MOVE_KEYS: | 1100 | case MOD_LOG_MOVE_KEYS: |
@@ -1143,45 +1165,57 @@ tree_mod_log_rewind(struct btrfs_fs_info *fs_info, struct extent_buffer *eb, | |||
1143 | return eb_rewin; | 1165 | return eb_rewin; |
1144 | } | 1166 | } |
1145 | 1167 | ||
1168 | /* | ||
1169 | * get_old_root() rewinds the state of @root's root node to the given @time_seq | ||
1170 | * value. If there are no changes, the current root->root_node is returned. If | ||
1171 | * anything changed in between, there's a fresh buffer allocated on which the | ||
1172 | * rewind operations are done. In any case, the returned buffer is read locked. | ||
1173 | * Returns NULL on error (with no locks held). | ||
1174 | */ | ||
1146 | static inline struct extent_buffer * | 1175 | static inline struct extent_buffer * |
1147 | get_old_root(struct btrfs_root *root, u64 time_seq) | 1176 | get_old_root(struct btrfs_root *root, u64 time_seq) |
1148 | { | 1177 | { |
1149 | struct tree_mod_elem *tm; | 1178 | struct tree_mod_elem *tm; |
1150 | struct extent_buffer *eb; | 1179 | struct extent_buffer *eb; |
1151 | struct tree_mod_root *old_root; | 1180 | struct tree_mod_root *old_root = NULL; |
1152 | u64 old_generation; | 1181 | u64 old_generation = 0; |
1182 | u64 logical; | ||
1153 | 1183 | ||
1184 | eb = btrfs_read_lock_root_node(root); | ||
1154 | tm = __tree_mod_log_oldest_root(root->fs_info, root, time_seq); | 1185 | tm = __tree_mod_log_oldest_root(root->fs_info, root, time_seq); |
1155 | if (!tm) | 1186 | if (!tm) |
1156 | return root->node; | 1187 | return root->node; |
1157 | 1188 | ||
1158 | old_root = &tm->old_root; | 1189 | if (tm->op == MOD_LOG_ROOT_REPLACE) { |
1159 | old_generation = tm->generation; | 1190 | old_root = &tm->old_root; |
1160 | 1191 | old_generation = tm->generation; | |
1161 | tm = tree_mod_log_search(root->fs_info, old_root->logical, time_seq); | 1192 | logical = old_root->logical; |
1162 | /* | 1193 | } else { |
1163 | * there was an item in the log when __tree_mod_log_oldest_root | 1194 | logical = root->node->start; |
1164 | * returned. this one must not go away, because the time_seq passed to | 1195 | } |
1165 | * us must be blocking its removal. | ||
1166 | */ | ||
1167 | BUG_ON(!tm); | ||
1168 | 1196 | ||
1169 | if (old_root->logical == root->node->start) { | 1197 | tm = tree_mod_log_search(root->fs_info, logical, time_seq); |
1170 | /* there are logged operations for the current root */ | 1198 | if (old_root) |
1199 | eb = alloc_dummy_extent_buffer(logical, root->nodesize); | ||
1200 | else | ||
1171 | eb = btrfs_clone_extent_buffer(root->node); | 1201 | eb = btrfs_clone_extent_buffer(root->node); |
1172 | } else { | 1202 | btrfs_tree_read_unlock(root->node); |
1173 | /* there's a root replace operation for the current root */ | 1203 | free_extent_buffer(root->node); |
1174 | eb = alloc_dummy_extent_buffer(tm->index << PAGE_CACHE_SHIFT, | 1204 | if (!eb) |
1175 | root->nodesize); | 1205 | return NULL; |
1206 | btrfs_tree_read_lock(eb); | ||
1207 | if (old_root) { | ||
1176 | btrfs_set_header_bytenr(eb, eb->start); | 1208 | btrfs_set_header_bytenr(eb, eb->start); |
1177 | btrfs_set_header_backref_rev(eb, BTRFS_MIXED_BACKREF_REV); | 1209 | btrfs_set_header_backref_rev(eb, BTRFS_MIXED_BACKREF_REV); |
1178 | btrfs_set_header_owner(eb, root->root_key.objectid); | 1210 | btrfs_set_header_owner(eb, root->root_key.objectid); |
1211 | btrfs_set_header_level(eb, old_root->level); | ||
1212 | btrfs_set_header_generation(eb, old_generation); | ||
1179 | } | 1213 | } |
1180 | if (!eb) | 1214 | if (tm) |
1181 | return NULL; | 1215 | __tree_mod_log_rewind(eb, time_seq, tm); |
1182 | btrfs_set_header_level(eb, old_root->level); | 1216 | else |
1183 | btrfs_set_header_generation(eb, old_generation); | 1217 | WARN_ON(btrfs_header_level(eb) != 0); |
1184 | __tree_mod_log_rewind(eb, time_seq, tm); | 1218 | extent_buffer_get(eb); |
1185 | 1219 | ||
1186 | return eb; | 1220 | return eb; |
1187 | } | 1221 | } |
@@ -1650,8 +1684,6 @@ static noinline int balance_level(struct btrfs_trans_handle *trans, | |||
1650 | BTRFS_NODEPTRS_PER_BLOCK(root) / 4) | 1684 | BTRFS_NODEPTRS_PER_BLOCK(root) / 4) |
1651 | return 0; | 1685 | return 0; |
1652 | 1686 | ||
1653 | btrfs_header_nritems(mid); | ||
1654 | |||
1655 | left = read_node_slot(root, parent, pslot - 1); | 1687 | left = read_node_slot(root, parent, pslot - 1); |
1656 | if (left) { | 1688 | if (left) { |
1657 | btrfs_tree_lock(left); | 1689 | btrfs_tree_lock(left); |
@@ -1681,7 +1713,6 @@ static noinline int balance_level(struct btrfs_trans_handle *trans, | |||
1681 | wret = push_node_left(trans, root, left, mid, 1); | 1713 | wret = push_node_left(trans, root, left, mid, 1); |
1682 | if (wret < 0) | 1714 | if (wret < 0) |
1683 | ret = wret; | 1715 | ret = wret; |
1684 | btrfs_header_nritems(mid); | ||
1685 | } | 1716 | } |
1686 | 1717 | ||
1687 | /* | 1718 | /* |
@@ -2615,9 +2646,7 @@ int btrfs_search_old_slot(struct btrfs_root *root, struct btrfs_key *key, | |||
2615 | 2646 | ||
2616 | again: | 2647 | again: |
2617 | b = get_old_root(root, time_seq); | 2648 | b = get_old_root(root, time_seq); |
2618 | extent_buffer_get(b); | ||
2619 | level = btrfs_header_level(b); | 2649 | level = btrfs_header_level(b); |
2620 | btrfs_tree_read_lock(b); | ||
2621 | p->locks[level] = BTRFS_READ_LOCK; | 2650 | p->locks[level] = BTRFS_READ_LOCK; |
2622 | 2651 | ||
2623 | while (b) { | 2652 | while (b) { |
@@ -2964,7 +2993,7 @@ static noinline int insert_new_root(struct btrfs_trans_handle *trans, | |||
2964 | static void insert_ptr(struct btrfs_trans_handle *trans, | 2993 | static void insert_ptr(struct btrfs_trans_handle *trans, |
2965 | struct btrfs_root *root, struct btrfs_path *path, | 2994 | struct btrfs_root *root, struct btrfs_path *path, |
2966 | struct btrfs_disk_key *key, u64 bytenr, | 2995 | struct btrfs_disk_key *key, u64 bytenr, |
2967 | int slot, int level, int tree_mod_log) | 2996 | int slot, int level) |
2968 | { | 2997 | { |
2969 | struct extent_buffer *lower; | 2998 | struct extent_buffer *lower; |
2970 | int nritems; | 2999 | int nritems; |
@@ -2977,7 +3006,7 @@ static void insert_ptr(struct btrfs_trans_handle *trans, | |||
2977 | BUG_ON(slot > nritems); | 3006 | BUG_ON(slot > nritems); |
2978 | BUG_ON(nritems == BTRFS_NODEPTRS_PER_BLOCK(root)); | 3007 | BUG_ON(nritems == BTRFS_NODEPTRS_PER_BLOCK(root)); |
2979 | if (slot != nritems) { | 3008 | if (slot != nritems) { |
2980 | if (tree_mod_log && level) | 3009 | if (level) |
2981 | tree_mod_log_eb_move(root->fs_info, lower, slot + 1, | 3010 | tree_mod_log_eb_move(root->fs_info, lower, slot + 1, |
2982 | slot, nritems - slot); | 3011 | slot, nritems - slot); |
2983 | memmove_extent_buffer(lower, | 3012 | memmove_extent_buffer(lower, |
@@ -2985,7 +3014,7 @@ static void insert_ptr(struct btrfs_trans_handle *trans, | |||
2985 | btrfs_node_key_ptr_offset(slot), | 3014 | btrfs_node_key_ptr_offset(slot), |
2986 | (nritems - slot) * sizeof(struct btrfs_key_ptr)); | 3015 | (nritems - slot) * sizeof(struct btrfs_key_ptr)); |
2987 | } | 3016 | } |
2988 | if (tree_mod_log && level) { | 3017 | if (level) { |
2989 | ret = tree_mod_log_insert_key(root->fs_info, lower, slot, | 3018 | ret = tree_mod_log_insert_key(root->fs_info, lower, slot, |
2990 | MOD_LOG_KEY_ADD); | 3019 | MOD_LOG_KEY_ADD); |
2991 | BUG_ON(ret < 0); | 3020 | BUG_ON(ret < 0); |
@@ -3073,7 +3102,7 @@ static noinline int split_node(struct btrfs_trans_handle *trans, | |||
3073 | btrfs_mark_buffer_dirty(split); | 3102 | btrfs_mark_buffer_dirty(split); |
3074 | 3103 | ||
3075 | insert_ptr(trans, root, path, &disk_key, split->start, | 3104 | insert_ptr(trans, root, path, &disk_key, split->start, |
3076 | path->slots[level + 1] + 1, level + 1, 1); | 3105 | path->slots[level + 1] + 1, level + 1); |
3077 | 3106 | ||
3078 | if (path->slots[level] >= mid) { | 3107 | if (path->slots[level] >= mid) { |
3079 | path->slots[level] -= mid; | 3108 | path->slots[level] -= mid; |
@@ -3610,7 +3639,7 @@ static noinline void copy_for_split(struct btrfs_trans_handle *trans, | |||
3610 | btrfs_set_header_nritems(l, mid); | 3639 | btrfs_set_header_nritems(l, mid); |
3611 | btrfs_item_key(right, &disk_key, 0); | 3640 | btrfs_item_key(right, &disk_key, 0); |
3612 | insert_ptr(trans, root, path, &disk_key, right->start, | 3641 | insert_ptr(trans, root, path, &disk_key, right->start, |
3613 | path->slots[1] + 1, 1, 0); | 3642 | path->slots[1] + 1, 1); |
3614 | 3643 | ||
3615 | btrfs_mark_buffer_dirty(right); | 3644 | btrfs_mark_buffer_dirty(right); |
3616 | btrfs_mark_buffer_dirty(l); | 3645 | btrfs_mark_buffer_dirty(l); |
@@ -3817,7 +3846,7 @@ again: | |||
3817 | if (mid <= slot) { | 3846 | if (mid <= slot) { |
3818 | btrfs_set_header_nritems(right, 0); | 3847 | btrfs_set_header_nritems(right, 0); |
3819 | insert_ptr(trans, root, path, &disk_key, right->start, | 3848 | insert_ptr(trans, root, path, &disk_key, right->start, |
3820 | path->slots[1] + 1, 1, 0); | 3849 | path->slots[1] + 1, 1); |
3821 | btrfs_tree_unlock(path->nodes[0]); | 3850 | btrfs_tree_unlock(path->nodes[0]); |
3822 | free_extent_buffer(path->nodes[0]); | 3851 | free_extent_buffer(path->nodes[0]); |
3823 | path->nodes[0] = right; | 3852 | path->nodes[0] = right; |
@@ -3826,7 +3855,7 @@ again: | |||
3826 | } else { | 3855 | } else { |
3827 | btrfs_set_header_nritems(right, 0); | 3856 | btrfs_set_header_nritems(right, 0); |
3828 | insert_ptr(trans, root, path, &disk_key, right->start, | 3857 | insert_ptr(trans, root, path, &disk_key, right->start, |
3829 | path->slots[1], 1, 0); | 3858 | path->slots[1], 1); |
3830 | btrfs_tree_unlock(path->nodes[0]); | 3859 | btrfs_tree_unlock(path->nodes[0]); |
3831 | free_extent_buffer(path->nodes[0]); | 3860 | free_extent_buffer(path->nodes[0]); |
3832 | path->nodes[0] = right; | 3861 | path->nodes[0] = right; |
@@ -5001,6 +5030,12 @@ next: | |||
5001 | */ | 5030 | */ |
5002 | int btrfs_next_leaf(struct btrfs_root *root, struct btrfs_path *path) | 5031 | int btrfs_next_leaf(struct btrfs_root *root, struct btrfs_path *path) |
5003 | { | 5032 | { |
5033 | return btrfs_next_old_leaf(root, path, 0); | ||
5034 | } | ||
5035 | |||
5036 | int btrfs_next_old_leaf(struct btrfs_root *root, struct btrfs_path *path, | ||
5037 | u64 time_seq) | ||
5038 | { | ||
5004 | int slot; | 5039 | int slot; |
5005 | int level; | 5040 | int level; |
5006 | struct extent_buffer *c; | 5041 | struct extent_buffer *c; |
@@ -5025,7 +5060,10 @@ again: | |||
5025 | path->keep_locks = 1; | 5060 | path->keep_locks = 1; |
5026 | path->leave_spinning = 1; | 5061 | path->leave_spinning = 1; |
5027 | 5062 | ||
5028 | ret = btrfs_search_slot(NULL, root, &key, path, 0, 0); | 5063 | if (time_seq) |
5064 | ret = btrfs_search_old_slot(root, &key, path, time_seq); | ||
5065 | else | ||
5066 | ret = btrfs_search_slot(NULL, root, &key, path, 0, 0); | ||
5029 | path->keep_locks = 0; | 5067 | path->keep_locks = 0; |
5030 | 5068 | ||
5031 | if (ret < 0) | 5069 | if (ret < 0) |
@@ -5081,6 +5119,18 @@ again: | |||
5081 | 5119 | ||
5082 | if (!path->skip_locking) { | 5120 | if (!path->skip_locking) { |
5083 | ret = btrfs_try_tree_read_lock(next); | 5121 | ret = btrfs_try_tree_read_lock(next); |
5122 | if (!ret && time_seq) { | ||
5123 | /* | ||
5124 | * If we don't get the lock, we may be racing | ||
5125 | * with push_leaf_left, holding that lock while | ||
5126 | * itself waiting for the leaf we've currently | ||
5127 | * locked. To solve this situation, we give up | ||
5128 | * on our lock and cycle. | ||
5129 | */ | ||
5130 | btrfs_release_path(path); | ||
5131 | cond_resched(); | ||
5132 | goto again; | ||
5133 | } | ||
5084 | if (!ret) { | 5134 | if (!ret) { |
5085 | btrfs_set_path_blocking(path); | 5135 | btrfs_set_path_blocking(path); |
5086 | btrfs_tree_read_lock(next); | 5136 | btrfs_tree_read_lock(next); |
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 0236d03c6732..fa5c45b39075 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h | |||
@@ -2753,13 +2753,20 @@ static inline int btrfs_insert_empty_item(struct btrfs_trans_handle *trans, | |||
2753 | } | 2753 | } |
2754 | 2754 | ||
2755 | int btrfs_next_leaf(struct btrfs_root *root, struct btrfs_path *path); | 2755 | int btrfs_next_leaf(struct btrfs_root *root, struct btrfs_path *path); |
2756 | static inline int btrfs_next_item(struct btrfs_root *root, struct btrfs_path *p) | 2756 | int btrfs_next_old_leaf(struct btrfs_root *root, struct btrfs_path *path, |
2757 | u64 time_seq); | ||
2758 | static inline int btrfs_next_old_item(struct btrfs_root *root, | ||
2759 | struct btrfs_path *p, u64 time_seq) | ||
2757 | { | 2760 | { |
2758 | ++p->slots[0]; | 2761 | ++p->slots[0]; |
2759 | if (p->slots[0] >= btrfs_header_nritems(p->nodes[0])) | 2762 | if (p->slots[0] >= btrfs_header_nritems(p->nodes[0])) |
2760 | return btrfs_next_leaf(root, p); | 2763 | return btrfs_next_old_leaf(root, p, time_seq); |
2761 | return 0; | 2764 | return 0; |
2762 | } | 2765 | } |
2766 | static inline int btrfs_next_item(struct btrfs_root *root, struct btrfs_path *p) | ||
2767 | { | ||
2768 | return btrfs_next_old_item(root, p, 0); | ||
2769 | } | ||
2763 | int btrfs_prev_leaf(struct btrfs_root *root, struct btrfs_path *path); | 2770 | int btrfs_prev_leaf(struct btrfs_root *root, struct btrfs_path *path); |
2764 | int btrfs_leaf_free_space(struct btrfs_root *root, struct extent_buffer *leaf); | 2771 | int btrfs_leaf_free_space(struct btrfs_root *root, struct extent_buffer *leaf); |
2765 | int __must_check btrfs_drop_snapshot(struct btrfs_root *root, | 2772 | int __must_check btrfs_drop_snapshot(struct btrfs_root *root, |
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c index c18d0442ae6d..2399f4086915 100644 --- a/fs/btrfs/delayed-inode.c +++ b/fs/btrfs/delayed-inode.c | |||
@@ -1879,3 +1879,21 @@ void btrfs_kill_all_delayed_nodes(struct btrfs_root *root) | |||
1879 | } | 1879 | } |
1880 | } | 1880 | } |
1881 | } | 1881 | } |
1882 | |||
1883 | void btrfs_destroy_delayed_inodes(struct btrfs_root *root) | ||
1884 | { | ||
1885 | struct btrfs_delayed_root *delayed_root; | ||
1886 | struct btrfs_delayed_node *curr_node, *prev_node; | ||
1887 | |||
1888 | delayed_root = btrfs_get_delayed_root(root); | ||
1889 | |||
1890 | curr_node = btrfs_first_delayed_node(delayed_root); | ||
1891 | while (curr_node) { | ||
1892 | __btrfs_kill_delayed_node(curr_node); | ||
1893 | |||
1894 | prev_node = curr_node; | ||
1895 | curr_node = btrfs_next_delayed_node(curr_node); | ||
1896 | btrfs_release_delayed_node(prev_node); | ||
1897 | } | ||
1898 | } | ||
1899 | |||
diff --git a/fs/btrfs/delayed-inode.h b/fs/btrfs/delayed-inode.h index 7083d08b2a21..f5aa4023d3e1 100644 --- a/fs/btrfs/delayed-inode.h +++ b/fs/btrfs/delayed-inode.h | |||
@@ -124,6 +124,9 @@ int btrfs_fill_inode(struct inode *inode, u32 *rdev); | |||
124 | /* Used for drop dead root */ | 124 | /* Used for drop dead root */ |
125 | void btrfs_kill_all_delayed_nodes(struct btrfs_root *root); | 125 | void btrfs_kill_all_delayed_nodes(struct btrfs_root *root); |
126 | 126 | ||
127 | /* Used for clean the transaction */ | ||
128 | void btrfs_destroy_delayed_inodes(struct btrfs_root *root); | ||
129 | |||
127 | /* Used for readdir() */ | 130 | /* Used for readdir() */ |
128 | void btrfs_get_delayed_items(struct inode *inode, struct list_head *ins_list, | 131 | void btrfs_get_delayed_items(struct inode *inode, struct list_head *ins_list, |
129 | struct list_head *del_list); | 132 | struct list_head *del_list); |
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 7ae51decf6d3..2936ca49b3b4 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c | |||
@@ -44,6 +44,7 @@ | |||
44 | #include "free-space-cache.h" | 44 | #include "free-space-cache.h" |
45 | #include "inode-map.h" | 45 | #include "inode-map.h" |
46 | #include "check-integrity.h" | 46 | #include "check-integrity.h" |
47 | #include "rcu-string.h" | ||
47 | 48 | ||
48 | static struct extent_io_ops btree_extent_io_ops; | 49 | static struct extent_io_ops btree_extent_io_ops; |
49 | static void end_workqueue_fn(struct btrfs_work *work); | 50 | static void end_workqueue_fn(struct btrfs_work *work); |
@@ -2118,7 +2119,7 @@ int open_ctree(struct super_block *sb, | |||
2118 | 2119 | ||
2119 | features = btrfs_super_incompat_flags(disk_super); | 2120 | features = btrfs_super_incompat_flags(disk_super); |
2120 | features |= BTRFS_FEATURE_INCOMPAT_MIXED_BACKREF; | 2121 | features |= BTRFS_FEATURE_INCOMPAT_MIXED_BACKREF; |
2121 | if (tree_root->fs_info->compress_type & BTRFS_COMPRESS_LZO) | 2122 | if (tree_root->fs_info->compress_type == BTRFS_COMPRESS_LZO) |
2122 | features |= BTRFS_FEATURE_INCOMPAT_COMPRESS_LZO; | 2123 | features |= BTRFS_FEATURE_INCOMPAT_COMPRESS_LZO; |
2123 | 2124 | ||
2124 | /* | 2125 | /* |
@@ -2353,12 +2354,17 @@ retry_root_backup: | |||
2353 | BTRFS_CSUM_TREE_OBJECTID, csum_root); | 2354 | BTRFS_CSUM_TREE_OBJECTID, csum_root); |
2354 | if (ret) | 2355 | if (ret) |
2355 | goto recovery_tree_root; | 2356 | goto recovery_tree_root; |
2356 | |||
2357 | csum_root->track_dirty = 1; | 2357 | csum_root->track_dirty = 1; |
2358 | 2358 | ||
2359 | fs_info->generation = generation; | 2359 | fs_info->generation = generation; |
2360 | fs_info->last_trans_committed = generation; | 2360 | fs_info->last_trans_committed = generation; |
2361 | 2361 | ||
2362 | ret = btrfs_recover_balance(fs_info); | ||
2363 | if (ret) { | ||
2364 | printk(KERN_WARNING "btrfs: failed to recover balance\n"); | ||
2365 | goto fail_block_groups; | ||
2366 | } | ||
2367 | |||
2362 | ret = btrfs_init_dev_stats(fs_info); | 2368 | ret = btrfs_init_dev_stats(fs_info); |
2363 | if (ret) { | 2369 | if (ret) { |
2364 | printk(KERN_ERR "btrfs: failed to init dev_stats: %d\n", | 2370 | printk(KERN_ERR "btrfs: failed to init dev_stats: %d\n", |
@@ -2484,20 +2490,23 @@ retry_root_backup: | |||
2484 | goto fail_trans_kthread; | 2490 | goto fail_trans_kthread; |
2485 | } | 2491 | } |
2486 | 2492 | ||
2487 | if (!(sb->s_flags & MS_RDONLY)) { | 2493 | if (sb->s_flags & MS_RDONLY) |
2488 | down_read(&fs_info->cleanup_work_sem); | 2494 | return 0; |
2489 | err = btrfs_orphan_cleanup(fs_info->fs_root); | ||
2490 | if (!err) | ||
2491 | err = btrfs_orphan_cleanup(fs_info->tree_root); | ||
2492 | up_read(&fs_info->cleanup_work_sem); | ||
2493 | 2495 | ||
2494 | if (!err) | 2496 | down_read(&fs_info->cleanup_work_sem); |
2495 | err = btrfs_recover_balance(fs_info->tree_root); | 2497 | if ((ret = btrfs_orphan_cleanup(fs_info->fs_root)) || |
2498 | (ret = btrfs_orphan_cleanup(fs_info->tree_root))) { | ||
2499 | up_read(&fs_info->cleanup_work_sem); | ||
2500 | close_ctree(tree_root); | ||
2501 | return ret; | ||
2502 | } | ||
2503 | up_read(&fs_info->cleanup_work_sem); | ||
2496 | 2504 | ||
2497 | if (err) { | 2505 | ret = btrfs_resume_balance_async(fs_info); |
2498 | close_ctree(tree_root); | 2506 | if (ret) { |
2499 | return err; | 2507 | printk(KERN_WARNING "btrfs: failed to resume balance\n"); |
2500 | } | 2508 | close_ctree(tree_root); |
2509 | return ret; | ||
2501 | } | 2510 | } |
2502 | 2511 | ||
2503 | return 0; | 2512 | return 0; |
@@ -2575,8 +2584,9 @@ static void btrfs_end_buffer_write_sync(struct buffer_head *bh, int uptodate) | |||
2575 | struct btrfs_device *device = (struct btrfs_device *) | 2584 | struct btrfs_device *device = (struct btrfs_device *) |
2576 | bh->b_private; | 2585 | bh->b_private; |
2577 | 2586 | ||
2578 | printk_ratelimited(KERN_WARNING "lost page write due to " | 2587 | printk_ratelimited_in_rcu(KERN_WARNING "lost page write due to " |
2579 | "I/O error on %s\n", device->name); | 2588 | "I/O error on %s\n", |
2589 | rcu_str_deref(device->name)); | ||
2580 | /* note, we dont' set_buffer_write_io_error because we have | 2590 | /* note, we dont' set_buffer_write_io_error because we have |
2581 | * our own ways of dealing with the IO errors | 2591 | * our own ways of dealing with the IO errors |
2582 | */ | 2592 | */ |
@@ -2749,8 +2759,8 @@ static int write_dev_flush(struct btrfs_device *device, int wait) | |||
2749 | wait_for_completion(&device->flush_wait); | 2759 | wait_for_completion(&device->flush_wait); |
2750 | 2760 | ||
2751 | if (bio_flagged(bio, BIO_EOPNOTSUPP)) { | 2761 | if (bio_flagged(bio, BIO_EOPNOTSUPP)) { |
2752 | printk("btrfs: disabling barriers on dev %s\n", | 2762 | printk_in_rcu("btrfs: disabling barriers on dev %s\n", |
2753 | device->name); | 2763 | rcu_str_deref(device->name)); |
2754 | device->nobarriers = 1; | 2764 | device->nobarriers = 1; |
2755 | } | 2765 | } |
2756 | if (!bio_flagged(bio, BIO_UPTODATE)) { | 2766 | if (!bio_flagged(bio, BIO_UPTODATE)) { |
@@ -3400,7 +3410,6 @@ int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, | |||
3400 | 3410 | ||
3401 | delayed_refs = &trans->delayed_refs; | 3411 | delayed_refs = &trans->delayed_refs; |
3402 | 3412 | ||
3403 | again: | ||
3404 | spin_lock(&delayed_refs->lock); | 3413 | spin_lock(&delayed_refs->lock); |
3405 | if (delayed_refs->num_entries == 0) { | 3414 | if (delayed_refs->num_entries == 0) { |
3406 | spin_unlock(&delayed_refs->lock); | 3415 | spin_unlock(&delayed_refs->lock); |
@@ -3408,31 +3417,37 @@ again: | |||
3408 | return ret; | 3417 | return ret; |
3409 | } | 3418 | } |
3410 | 3419 | ||
3411 | node = rb_first(&delayed_refs->root); | 3420 | while ((node = rb_first(&delayed_refs->root)) != NULL) { |
3412 | while (node) { | ||
3413 | ref = rb_entry(node, struct btrfs_delayed_ref_node, rb_node); | 3421 | ref = rb_entry(node, struct btrfs_delayed_ref_node, rb_node); |
3414 | node = rb_next(node); | ||
3415 | |||
3416 | ref->in_tree = 0; | ||
3417 | rb_erase(&ref->rb_node, &delayed_refs->root); | ||
3418 | delayed_refs->num_entries--; | ||
3419 | 3422 | ||
3420 | atomic_set(&ref->refs, 1); | 3423 | atomic_set(&ref->refs, 1); |
3421 | if (btrfs_delayed_ref_is_head(ref)) { | 3424 | if (btrfs_delayed_ref_is_head(ref)) { |
3422 | struct btrfs_delayed_ref_head *head; | 3425 | struct btrfs_delayed_ref_head *head; |
3423 | 3426 | ||
3424 | head = btrfs_delayed_node_to_head(ref); | 3427 | head = btrfs_delayed_node_to_head(ref); |
3425 | spin_unlock(&delayed_refs->lock); | 3428 | if (!mutex_trylock(&head->mutex)) { |
3426 | mutex_lock(&head->mutex); | 3429 | atomic_inc(&ref->refs); |
3430 | spin_unlock(&delayed_refs->lock); | ||
3431 | |||
3432 | /* Need to wait for the delayed ref to run */ | ||
3433 | mutex_lock(&head->mutex); | ||
3434 | mutex_unlock(&head->mutex); | ||
3435 | btrfs_put_delayed_ref(ref); | ||
3436 | |||
3437 | spin_lock(&delayed_refs->lock); | ||
3438 | continue; | ||
3439 | } | ||
3440 | |||
3427 | kfree(head->extent_op); | 3441 | kfree(head->extent_op); |
3428 | delayed_refs->num_heads--; | 3442 | delayed_refs->num_heads--; |
3429 | if (list_empty(&head->cluster)) | 3443 | if (list_empty(&head->cluster)) |
3430 | delayed_refs->num_heads_ready--; | 3444 | delayed_refs->num_heads_ready--; |
3431 | list_del_init(&head->cluster); | 3445 | list_del_init(&head->cluster); |
3432 | mutex_unlock(&head->mutex); | ||
3433 | btrfs_put_delayed_ref(ref); | ||
3434 | goto again; | ||
3435 | } | 3446 | } |
3447 | ref->in_tree = 0; | ||
3448 | rb_erase(&ref->rb_node, &delayed_refs->root); | ||
3449 | delayed_refs->num_entries--; | ||
3450 | |||
3436 | spin_unlock(&delayed_refs->lock); | 3451 | spin_unlock(&delayed_refs->lock); |
3437 | btrfs_put_delayed_ref(ref); | 3452 | btrfs_put_delayed_ref(ref); |
3438 | 3453 | ||
@@ -3520,11 +3535,9 @@ static int btrfs_destroy_marked_extents(struct btrfs_root *root, | |||
3520 | &(&BTRFS_I(page->mapping->host)->io_tree)->buffer, | 3535 | &(&BTRFS_I(page->mapping->host)->io_tree)->buffer, |
3521 | offset >> PAGE_CACHE_SHIFT); | 3536 | offset >> PAGE_CACHE_SHIFT); |
3522 | spin_unlock(&dirty_pages->buffer_lock); | 3537 | spin_unlock(&dirty_pages->buffer_lock); |
3523 | if (eb) { | 3538 | if (eb) |
3524 | ret = test_and_clear_bit(EXTENT_BUFFER_DIRTY, | 3539 | ret = test_and_clear_bit(EXTENT_BUFFER_DIRTY, |
3525 | &eb->bflags); | 3540 | &eb->bflags); |
3526 | atomic_set(&eb->refs, 1); | ||
3527 | } | ||
3528 | if (PageWriteback(page)) | 3541 | if (PageWriteback(page)) |
3529 | end_page_writeback(page); | 3542 | end_page_writeback(page); |
3530 | 3543 | ||
@@ -3538,8 +3551,8 @@ static int btrfs_destroy_marked_extents(struct btrfs_root *root, | |||
3538 | spin_unlock_irq(&page->mapping->tree_lock); | 3551 | spin_unlock_irq(&page->mapping->tree_lock); |
3539 | } | 3552 | } |
3540 | 3553 | ||
3541 | page->mapping->a_ops->invalidatepage(page, 0); | ||
3542 | unlock_page(page); | 3554 | unlock_page(page); |
3555 | page_cache_release(page); | ||
3543 | } | 3556 | } |
3544 | } | 3557 | } |
3545 | 3558 | ||
@@ -3553,8 +3566,10 @@ static int btrfs_destroy_pinned_extent(struct btrfs_root *root, | |||
3553 | u64 start; | 3566 | u64 start; |
3554 | u64 end; | 3567 | u64 end; |
3555 | int ret; | 3568 | int ret; |
3569 | bool loop = true; | ||
3556 | 3570 | ||
3557 | unpin = pinned_extents; | 3571 | unpin = pinned_extents; |
3572 | again: | ||
3558 | while (1) { | 3573 | while (1) { |
3559 | ret = find_first_extent_bit(unpin, 0, &start, &end, | 3574 | ret = find_first_extent_bit(unpin, 0, &start, &end, |
3560 | EXTENT_DIRTY); | 3575 | EXTENT_DIRTY); |
@@ -3572,6 +3587,15 @@ static int btrfs_destroy_pinned_extent(struct btrfs_root *root, | |||
3572 | cond_resched(); | 3587 | cond_resched(); |
3573 | } | 3588 | } |
3574 | 3589 | ||
3590 | if (loop) { | ||
3591 | if (unpin == &root->fs_info->freed_extents[0]) | ||
3592 | unpin = &root->fs_info->freed_extents[1]; | ||
3593 | else | ||
3594 | unpin = &root->fs_info->freed_extents[0]; | ||
3595 | loop = false; | ||
3596 | goto again; | ||
3597 | } | ||
3598 | |||
3575 | return 0; | 3599 | return 0; |
3576 | } | 3600 | } |
3577 | 3601 | ||
@@ -3585,21 +3609,23 @@ void btrfs_cleanup_one_transaction(struct btrfs_transaction *cur_trans, | |||
3585 | /* FIXME: cleanup wait for commit */ | 3609 | /* FIXME: cleanup wait for commit */ |
3586 | cur_trans->in_commit = 1; | 3610 | cur_trans->in_commit = 1; |
3587 | cur_trans->blocked = 1; | 3611 | cur_trans->blocked = 1; |
3588 | if (waitqueue_active(&root->fs_info->transaction_blocked_wait)) | 3612 | wake_up(&root->fs_info->transaction_blocked_wait); |
3589 | wake_up(&root->fs_info->transaction_blocked_wait); | ||
3590 | 3613 | ||
3591 | cur_trans->blocked = 0; | 3614 | cur_trans->blocked = 0; |
3592 | if (waitqueue_active(&root->fs_info->transaction_wait)) | 3615 | wake_up(&root->fs_info->transaction_wait); |
3593 | wake_up(&root->fs_info->transaction_wait); | ||
3594 | 3616 | ||
3595 | cur_trans->commit_done = 1; | 3617 | cur_trans->commit_done = 1; |
3596 | if (waitqueue_active(&cur_trans->commit_wait)) | 3618 | wake_up(&cur_trans->commit_wait); |
3597 | wake_up(&cur_trans->commit_wait); | 3619 | |
3620 | btrfs_destroy_delayed_inodes(root); | ||
3621 | btrfs_assert_delayed_root_empty(root); | ||
3598 | 3622 | ||
3599 | btrfs_destroy_pending_snapshots(cur_trans); | 3623 | btrfs_destroy_pending_snapshots(cur_trans); |
3600 | 3624 | ||
3601 | btrfs_destroy_marked_extents(root, &cur_trans->dirty_pages, | 3625 | btrfs_destroy_marked_extents(root, &cur_trans->dirty_pages, |
3602 | EXTENT_DIRTY); | 3626 | EXTENT_DIRTY); |
3627 | btrfs_destroy_pinned_extent(root, | ||
3628 | root->fs_info->pinned_extents); | ||
3603 | 3629 | ||
3604 | /* | 3630 | /* |
3605 | memset(cur_trans, 0, sizeof(*cur_trans)); | 3631 | memset(cur_trans, 0, sizeof(*cur_trans)); |
@@ -3648,6 +3674,9 @@ int btrfs_cleanup_transaction(struct btrfs_root *root) | |||
3648 | if (waitqueue_active(&t->commit_wait)) | 3674 | if (waitqueue_active(&t->commit_wait)) |
3649 | wake_up(&t->commit_wait); | 3675 | wake_up(&t->commit_wait); |
3650 | 3676 | ||
3677 | btrfs_destroy_delayed_inodes(root); | ||
3678 | btrfs_assert_delayed_root_empty(root); | ||
3679 | |||
3651 | btrfs_destroy_pending_snapshots(t); | 3680 | btrfs_destroy_pending_snapshots(t); |
3652 | 3681 | ||
3653 | btrfs_destroy_delalloc_inodes(root); | 3682 | btrfs_destroy_delalloc_inodes(root); |
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 4b5a1e1bdefb..6e1d36702ff7 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c | |||
@@ -2347,12 +2347,10 @@ next: | |||
2347 | return count; | 2347 | return count; |
2348 | } | 2348 | } |
2349 | 2349 | ||
2350 | |||
2351 | static void wait_for_more_refs(struct btrfs_delayed_ref_root *delayed_refs, | 2350 | static void wait_for_more_refs(struct btrfs_delayed_ref_root *delayed_refs, |
2352 | unsigned long num_refs) | 2351 | unsigned long num_refs, |
2352 | struct list_head *first_seq) | ||
2353 | { | 2353 | { |
2354 | struct list_head *first_seq = delayed_refs->seq_head.next; | ||
2355 | |||
2356 | spin_unlock(&delayed_refs->lock); | 2354 | spin_unlock(&delayed_refs->lock); |
2357 | pr_debug("waiting for more refs (num %ld, first %p)\n", | 2355 | pr_debug("waiting for more refs (num %ld, first %p)\n", |
2358 | num_refs, first_seq); | 2356 | num_refs, first_seq); |
@@ -2381,6 +2379,7 @@ int btrfs_run_delayed_refs(struct btrfs_trans_handle *trans, | |||
2381 | struct btrfs_delayed_ref_root *delayed_refs; | 2379 | struct btrfs_delayed_ref_root *delayed_refs; |
2382 | struct btrfs_delayed_ref_node *ref; | 2380 | struct btrfs_delayed_ref_node *ref; |
2383 | struct list_head cluster; | 2381 | struct list_head cluster; |
2382 | struct list_head *first_seq = NULL; | ||
2384 | int ret; | 2383 | int ret; |
2385 | u64 delayed_start; | 2384 | u64 delayed_start; |
2386 | int run_all = count == (unsigned long)-1; | 2385 | int run_all = count == (unsigned long)-1; |
@@ -2436,8 +2435,10 @@ again: | |||
2436 | */ | 2435 | */ |
2437 | consider_waiting = 1; | 2436 | consider_waiting = 1; |
2438 | num_refs = delayed_refs->num_entries; | 2437 | num_refs = delayed_refs->num_entries; |
2438 | first_seq = root->fs_info->tree_mod_seq_list.next; | ||
2439 | } else { | 2439 | } else { |
2440 | wait_for_more_refs(delayed_refs, num_refs); | 2440 | wait_for_more_refs(delayed_refs, |
2441 | num_refs, first_seq); | ||
2441 | /* | 2442 | /* |
2442 | * after waiting, things have changed. we | 2443 | * after waiting, things have changed. we |
2443 | * dropped the lock and someone else might have | 2444 | * dropped the lock and someone else might have |
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 2c8f7b204617..deafe19c34b5 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c | |||
@@ -20,6 +20,7 @@ | |||
20 | #include "volumes.h" | 20 | #include "volumes.h" |
21 | #include "check-integrity.h" | 21 | #include "check-integrity.h" |
22 | #include "locking.h" | 22 | #include "locking.h" |
23 | #include "rcu-string.h" | ||
23 | 24 | ||
24 | static struct kmem_cache *extent_state_cache; | 25 | static struct kmem_cache *extent_state_cache; |
25 | static struct kmem_cache *extent_buffer_cache; | 26 | static struct kmem_cache *extent_buffer_cache; |
@@ -928,7 +929,8 @@ int set_extent_bit(struct extent_io_tree *tree, u64 start, u64 end, int bits, | |||
928 | 929 | ||
929 | 930 | ||
930 | /** | 931 | /** |
931 | * convert_extent - convert all bits in a given range from one bit to another | 932 | * convert_extent_bit - convert all bits in a given range from one bit to |
933 | * another | ||
932 | * @tree: the io tree to search | 934 | * @tree: the io tree to search |
933 | * @start: the start offset in bytes | 935 | * @start: the start offset in bytes |
934 | * @end: the end offset in bytes (inclusive) | 936 | * @end: the end offset in bytes (inclusive) |
@@ -1917,9 +1919,9 @@ int repair_io_failure(struct btrfs_mapping_tree *map_tree, u64 start, | |||
1917 | return -EIO; | 1919 | return -EIO; |
1918 | } | 1920 | } |
1919 | 1921 | ||
1920 | printk(KERN_INFO "btrfs read error corrected: ino %lu off %llu (dev %s " | 1922 | printk_in_rcu(KERN_INFO "btrfs read error corrected: ino %lu off %llu " |
1921 | "sector %llu)\n", page->mapping->host->i_ino, start, | 1923 | "(dev %s sector %llu)\n", page->mapping->host->i_ino, |
1922 | dev->name, sector); | 1924 | start, rcu_str_deref(dev->name), sector); |
1923 | 1925 | ||
1924 | bio_put(bio); | 1926 | bio_put(bio); |
1925 | return 0; | 1927 | return 0; |
@@ -3323,6 +3325,7 @@ static int extent_write_cache_pages(struct extent_io_tree *tree, | |||
3323 | writepage_t writepage, void *data, | 3325 | writepage_t writepage, void *data, |
3324 | void (*flush_fn)(void *)) | 3326 | void (*flush_fn)(void *)) |
3325 | { | 3327 | { |
3328 | struct inode *inode = mapping->host; | ||
3326 | int ret = 0; | 3329 | int ret = 0; |
3327 | int done = 0; | 3330 | int done = 0; |
3328 | int nr_to_write_done = 0; | 3331 | int nr_to_write_done = 0; |
@@ -3333,6 +3336,18 @@ static int extent_write_cache_pages(struct extent_io_tree *tree, | |||
3333 | int scanned = 0; | 3336 | int scanned = 0; |
3334 | int tag; | 3337 | int tag; |
3335 | 3338 | ||
3339 | /* | ||
3340 | * We have to hold onto the inode so that ordered extents can do their | ||
3341 | * work when the IO finishes. The alternative to this is failing to add | ||
3342 | * an ordered extent if the igrab() fails there and that is a huge pain | ||
3343 | * to deal with, so instead just hold onto the inode throughout the | ||
3344 | * writepages operation. If it fails here we are freeing up the inode | ||
3345 | * anyway and we'd rather not waste our time writing out stuff that is | ||
3346 | * going to be truncated anyway. | ||
3347 | */ | ||
3348 | if (!igrab(inode)) | ||
3349 | return 0; | ||
3350 | |||
3336 | pagevec_init(&pvec, 0); | 3351 | pagevec_init(&pvec, 0); |
3337 | if (wbc->range_cyclic) { | 3352 | if (wbc->range_cyclic) { |
3338 | index = mapping->writeback_index; /* Start from prev offset */ | 3353 | index = mapping->writeback_index; /* Start from prev offset */ |
@@ -3427,6 +3442,7 @@ retry: | |||
3427 | index = 0; | 3442 | index = 0; |
3428 | goto retry; | 3443 | goto retry; |
3429 | } | 3444 | } |
3445 | btrfs_add_delayed_iput(inode); | ||
3430 | return ret; | 3446 | return ret; |
3431 | } | 3447 | } |
3432 | 3448 | ||
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 70dc8ca73e25..9aa01ec2138d 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c | |||
@@ -1334,7 +1334,6 @@ static ssize_t __btrfs_direct_write(struct kiocb *iocb, | |||
1334 | loff_t *ppos, size_t count, size_t ocount) | 1334 | loff_t *ppos, size_t count, size_t ocount) |
1335 | { | 1335 | { |
1336 | struct file *file = iocb->ki_filp; | 1336 | struct file *file = iocb->ki_filp; |
1337 | struct inode *inode = fdentry(file)->d_inode; | ||
1338 | struct iov_iter i; | 1337 | struct iov_iter i; |
1339 | ssize_t written; | 1338 | ssize_t written; |
1340 | ssize_t written_buffered; | 1339 | ssize_t written_buffered; |
@@ -1344,18 +1343,6 @@ static ssize_t __btrfs_direct_write(struct kiocb *iocb, | |||
1344 | written = generic_file_direct_write(iocb, iov, &nr_segs, pos, ppos, | 1343 | written = generic_file_direct_write(iocb, iov, &nr_segs, pos, ppos, |
1345 | count, ocount); | 1344 | count, ocount); |
1346 | 1345 | ||
1347 | /* | ||
1348 | * the generic O_DIRECT will update in-memory i_size after the | ||
1349 | * DIOs are done. But our endio handlers that update the on | ||
1350 | * disk i_size never update past the in memory i_size. So we | ||
1351 | * need one more update here to catch any additions to the | ||
1352 | * file | ||
1353 | */ | ||
1354 | if (inode->i_size != BTRFS_I(inode)->disk_i_size) { | ||
1355 | btrfs_ordered_update_i_size(inode, inode->i_size, NULL); | ||
1356 | mark_inode_dirty(inode); | ||
1357 | } | ||
1358 | |||
1359 | if (written < 0 || written == count) | 1346 | if (written < 0 || written == count) |
1360 | return written; | 1347 | return written; |
1361 | 1348 | ||
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index 81296c57405a..6c4e2baa9290 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c | |||
@@ -1543,29 +1543,26 @@ again: | |||
1543 | end = bitmap_info->offset + (u64)(BITS_PER_BITMAP * ctl->unit) - 1; | 1543 | end = bitmap_info->offset + (u64)(BITS_PER_BITMAP * ctl->unit) - 1; |
1544 | 1544 | ||
1545 | /* | 1545 | /* |
1546 | * XXX - this can go away after a few releases. | 1546 | * We need to search for bits in this bitmap. We could only cover some |
1547 | * | 1547 | * of the extent in this bitmap thanks to how we add space, so we need |
1548 | * since the only user of btrfs_remove_free_space is the tree logging | 1548 | * to search for as much as it as we can and clear that amount, and then |
1549 | * stuff, and the only way to test that is under crash conditions, we | 1549 | * go searching for the next bit. |
1550 | * want to have this debug stuff here just in case somethings not | ||
1551 | * working. Search the bitmap for the space we are trying to use to | ||
1552 | * make sure its actually there. If its not there then we need to stop | ||
1553 | * because something has gone wrong. | ||
1554 | */ | 1550 | */ |
1555 | search_start = *offset; | 1551 | search_start = *offset; |
1556 | search_bytes = *bytes; | 1552 | search_bytes = ctl->unit; |
1557 | search_bytes = min(search_bytes, end - search_start + 1); | 1553 | search_bytes = min(search_bytes, end - search_start + 1); |
1558 | ret = search_bitmap(ctl, bitmap_info, &search_start, &search_bytes); | 1554 | ret = search_bitmap(ctl, bitmap_info, &search_start, &search_bytes); |
1559 | BUG_ON(ret < 0 || search_start != *offset); | 1555 | BUG_ON(ret < 0 || search_start != *offset); |
1560 | 1556 | ||
1561 | if (*offset > bitmap_info->offset && *offset + *bytes > end) { | 1557 | /* We may have found more bits than what we need */ |
1562 | bitmap_clear_bits(ctl, bitmap_info, *offset, end - *offset + 1); | 1558 | search_bytes = min(search_bytes, *bytes); |
1563 | *bytes -= end - *offset + 1; | 1559 | |
1564 | *offset = end + 1; | 1560 | /* Cannot clear past the end of the bitmap */ |
1565 | } else if (*offset >= bitmap_info->offset && *offset + *bytes <= end) { | 1561 | search_bytes = min(search_bytes, end - search_start + 1); |
1566 | bitmap_clear_bits(ctl, bitmap_info, *offset, *bytes); | 1562 | |
1567 | *bytes = 0; | 1563 | bitmap_clear_bits(ctl, bitmap_info, search_start, search_bytes); |
1568 | } | 1564 | *offset += search_bytes; |
1565 | *bytes -= search_bytes; | ||
1569 | 1566 | ||
1570 | if (*bytes) { | 1567 | if (*bytes) { |
1571 | struct rb_node *next = rb_next(&bitmap_info->offset_index); | 1568 | struct rb_node *next = rb_next(&bitmap_info->offset_index); |
@@ -1596,7 +1593,7 @@ again: | |||
1596 | * everything over again. | 1593 | * everything over again. |
1597 | */ | 1594 | */ |
1598 | search_start = *offset; | 1595 | search_start = *offset; |
1599 | search_bytes = *bytes; | 1596 | search_bytes = ctl->unit; |
1600 | ret = search_bitmap(ctl, bitmap_info, &search_start, | 1597 | ret = search_bitmap(ctl, bitmap_info, &search_start, |
1601 | &search_bytes); | 1598 | &search_bytes); |
1602 | if (ret < 0 || search_start != *offset) | 1599 | if (ret < 0 || search_start != *offset) |
@@ -1879,12 +1876,14 @@ int btrfs_remove_free_space(struct btrfs_block_group_cache *block_group, | |||
1879 | { | 1876 | { |
1880 | struct btrfs_free_space_ctl *ctl = block_group->free_space_ctl; | 1877 | struct btrfs_free_space_ctl *ctl = block_group->free_space_ctl; |
1881 | struct btrfs_free_space *info; | 1878 | struct btrfs_free_space *info; |
1882 | struct btrfs_free_space *next_info = NULL; | ||
1883 | int ret = 0; | 1879 | int ret = 0; |
1884 | 1880 | ||
1885 | spin_lock(&ctl->tree_lock); | 1881 | spin_lock(&ctl->tree_lock); |
1886 | 1882 | ||
1887 | again: | 1883 | again: |
1884 | if (!bytes) | ||
1885 | goto out_lock; | ||
1886 | |||
1888 | info = tree_search_offset(ctl, offset, 0, 0); | 1887 | info = tree_search_offset(ctl, offset, 0, 0); |
1889 | if (!info) { | 1888 | if (!info) { |
1890 | /* | 1889 | /* |
@@ -1905,88 +1904,48 @@ again: | |||
1905 | } | 1904 | } |
1906 | } | 1905 | } |
1907 | 1906 | ||
1908 | if (info->bytes < bytes && rb_next(&info->offset_index)) { | 1907 | if (!info->bitmap) { |
1909 | u64 end; | ||
1910 | next_info = rb_entry(rb_next(&info->offset_index), | ||
1911 | struct btrfs_free_space, | ||
1912 | offset_index); | ||
1913 | |||
1914 | if (next_info->bitmap) | ||
1915 | end = next_info->offset + | ||
1916 | BITS_PER_BITMAP * ctl->unit - 1; | ||
1917 | else | ||
1918 | end = next_info->offset + next_info->bytes; | ||
1919 | |||
1920 | if (next_info->bytes < bytes || | ||
1921 | next_info->offset > offset || offset > end) { | ||
1922 | printk(KERN_CRIT "Found free space at %llu, size %llu," | ||
1923 | " trying to use %llu\n", | ||
1924 | (unsigned long long)info->offset, | ||
1925 | (unsigned long long)info->bytes, | ||
1926 | (unsigned long long)bytes); | ||
1927 | WARN_ON(1); | ||
1928 | ret = -EINVAL; | ||
1929 | goto out_lock; | ||
1930 | } | ||
1931 | |||
1932 | info = next_info; | ||
1933 | } | ||
1934 | |||
1935 | if (info->bytes == bytes) { | ||
1936 | unlink_free_space(ctl, info); | 1908 | unlink_free_space(ctl, info); |
1937 | if (info->bitmap) { | 1909 | if (offset == info->offset) { |
1938 | kfree(info->bitmap); | 1910 | u64 to_free = min(bytes, info->bytes); |
1939 | ctl->total_bitmaps--; | 1911 | |
1940 | } | 1912 | info->bytes -= to_free; |
1941 | kmem_cache_free(btrfs_free_space_cachep, info); | 1913 | info->offset += to_free; |
1942 | ret = 0; | 1914 | if (info->bytes) { |
1943 | goto out_lock; | 1915 | ret = link_free_space(ctl, info); |
1944 | } | 1916 | WARN_ON(ret); |
1945 | 1917 | } else { | |
1946 | if (!info->bitmap && info->offset == offset) { | 1918 | kmem_cache_free(btrfs_free_space_cachep, info); |
1947 | unlink_free_space(ctl, info); | 1919 | } |
1948 | info->offset += bytes; | ||
1949 | info->bytes -= bytes; | ||
1950 | ret = link_free_space(ctl, info); | ||
1951 | WARN_ON(ret); | ||
1952 | goto out_lock; | ||
1953 | } | ||
1954 | 1920 | ||
1955 | if (!info->bitmap && info->offset <= offset && | 1921 | offset += to_free; |
1956 | info->offset + info->bytes >= offset + bytes) { | 1922 | bytes -= to_free; |
1957 | u64 old_start = info->offset; | 1923 | goto again; |
1958 | /* | 1924 | } else { |
1959 | * we're freeing space in the middle of the info, | 1925 | u64 old_end = info->bytes + info->offset; |
1960 | * this can happen during tree log replay | ||
1961 | * | ||
1962 | * first unlink the old info and then | ||
1963 | * insert it again after the hole we're creating | ||
1964 | */ | ||
1965 | unlink_free_space(ctl, info); | ||
1966 | if (offset + bytes < info->offset + info->bytes) { | ||
1967 | u64 old_end = info->offset + info->bytes; | ||
1968 | 1926 | ||
1969 | info->offset = offset + bytes; | 1927 | info->bytes = offset - info->offset; |
1970 | info->bytes = old_end - info->offset; | ||
1971 | ret = link_free_space(ctl, info); | 1928 | ret = link_free_space(ctl, info); |
1972 | WARN_ON(ret); | 1929 | WARN_ON(ret); |
1973 | if (ret) | 1930 | if (ret) |
1974 | goto out_lock; | 1931 | goto out_lock; |
1975 | } else { | ||
1976 | /* the hole we're creating ends at the end | ||
1977 | * of the info struct, just free the info | ||
1978 | */ | ||
1979 | kmem_cache_free(btrfs_free_space_cachep, info); | ||
1980 | } | ||
1981 | spin_unlock(&ctl->tree_lock); | ||
1982 | 1932 | ||
1983 | /* step two, insert a new info struct to cover | 1933 | /* Not enough bytes in this entry to satisfy us */ |
1984 | * anything before the hole | 1934 | if (old_end < offset + bytes) { |
1985 | */ | 1935 | bytes -= old_end - offset; |
1986 | ret = btrfs_add_free_space(block_group, old_start, | 1936 | offset = old_end; |
1987 | offset - old_start); | 1937 | goto again; |
1988 | WARN_ON(ret); /* -ENOMEM */ | 1938 | } else if (old_end == offset + bytes) { |
1989 | goto out; | 1939 | /* all done */ |
1940 | goto out_lock; | ||
1941 | } | ||
1942 | spin_unlock(&ctl->tree_lock); | ||
1943 | |||
1944 | ret = btrfs_add_free_space(block_group, offset + bytes, | ||
1945 | old_end - (offset + bytes)); | ||
1946 | WARN_ON(ret); | ||
1947 | goto out; | ||
1948 | } | ||
1990 | } | 1949 | } |
1991 | 1950 | ||
1992 | ret = remove_from_bitmap(ctl, info, &offset, &bytes); | 1951 | ret = remove_from_bitmap(ctl, info, &offset, &bytes); |
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index f6ab6f5e635a..fb8d671d00e6 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c | |||
@@ -830,7 +830,7 @@ static noinline int cow_file_range(struct inode *inode, | |||
830 | if (IS_ERR(trans)) { | 830 | if (IS_ERR(trans)) { |
831 | extent_clear_unlock_delalloc(inode, | 831 | extent_clear_unlock_delalloc(inode, |
832 | &BTRFS_I(inode)->io_tree, | 832 | &BTRFS_I(inode)->io_tree, |
833 | start, end, NULL, | 833 | start, end, locked_page, |
834 | EXTENT_CLEAR_UNLOCK_PAGE | | 834 | EXTENT_CLEAR_UNLOCK_PAGE | |
835 | EXTENT_CLEAR_UNLOCK | | 835 | EXTENT_CLEAR_UNLOCK | |
836 | EXTENT_CLEAR_DELALLOC | | 836 | EXTENT_CLEAR_DELALLOC | |
@@ -963,7 +963,7 @@ out: | |||
963 | out_unlock: | 963 | out_unlock: |
964 | extent_clear_unlock_delalloc(inode, | 964 | extent_clear_unlock_delalloc(inode, |
965 | &BTRFS_I(inode)->io_tree, | 965 | &BTRFS_I(inode)->io_tree, |
966 | start, end, NULL, | 966 | start, end, locked_page, |
967 | EXTENT_CLEAR_UNLOCK_PAGE | | 967 | EXTENT_CLEAR_UNLOCK_PAGE | |
968 | EXTENT_CLEAR_UNLOCK | | 968 | EXTENT_CLEAR_UNLOCK | |
969 | EXTENT_CLEAR_DELALLOC | | 969 | EXTENT_CLEAR_DELALLOC | |
@@ -986,8 +986,10 @@ static noinline void async_cow_start(struct btrfs_work *work) | |||
986 | compress_file_range(async_cow->inode, async_cow->locked_page, | 986 | compress_file_range(async_cow->inode, async_cow->locked_page, |
987 | async_cow->start, async_cow->end, async_cow, | 987 | async_cow->start, async_cow->end, async_cow, |
988 | &num_added); | 988 | &num_added); |
989 | if (num_added == 0) | 989 | if (num_added == 0) { |
990 | btrfs_add_delayed_iput(async_cow->inode); | ||
990 | async_cow->inode = NULL; | 991 | async_cow->inode = NULL; |
992 | } | ||
991 | } | 993 | } |
992 | 994 | ||
993 | /* | 995 | /* |
@@ -1020,6 +1022,8 @@ static noinline void async_cow_free(struct btrfs_work *work) | |||
1020 | { | 1022 | { |
1021 | struct async_cow *async_cow; | 1023 | struct async_cow *async_cow; |
1022 | async_cow = container_of(work, struct async_cow, work); | 1024 | async_cow = container_of(work, struct async_cow, work); |
1025 | if (async_cow->inode) | ||
1026 | btrfs_add_delayed_iput(async_cow->inode); | ||
1023 | kfree(async_cow); | 1027 | kfree(async_cow); |
1024 | } | 1028 | } |
1025 | 1029 | ||
@@ -1038,7 +1042,7 @@ static int cow_file_range_async(struct inode *inode, struct page *locked_page, | |||
1038 | while (start < end) { | 1042 | while (start < end) { |
1039 | async_cow = kmalloc(sizeof(*async_cow), GFP_NOFS); | 1043 | async_cow = kmalloc(sizeof(*async_cow), GFP_NOFS); |
1040 | BUG_ON(!async_cow); /* -ENOMEM */ | 1044 | BUG_ON(!async_cow); /* -ENOMEM */ |
1041 | async_cow->inode = inode; | 1045 | async_cow->inode = igrab(inode); |
1042 | async_cow->root = root; | 1046 | async_cow->root = root; |
1043 | async_cow->locked_page = locked_page; | 1047 | async_cow->locked_page = locked_page; |
1044 | async_cow->start = start; | 1048 | async_cow->start = start; |
@@ -1136,8 +1140,18 @@ static noinline int run_delalloc_nocow(struct inode *inode, | |||
1136 | u64 ino = btrfs_ino(inode); | 1140 | u64 ino = btrfs_ino(inode); |
1137 | 1141 | ||
1138 | path = btrfs_alloc_path(); | 1142 | path = btrfs_alloc_path(); |
1139 | if (!path) | 1143 | if (!path) { |
1144 | extent_clear_unlock_delalloc(inode, | ||
1145 | &BTRFS_I(inode)->io_tree, | ||
1146 | start, end, locked_page, | ||
1147 | EXTENT_CLEAR_UNLOCK_PAGE | | ||
1148 | EXTENT_CLEAR_UNLOCK | | ||
1149 | EXTENT_CLEAR_DELALLOC | | ||
1150 | EXTENT_CLEAR_DIRTY | | ||
1151 | EXTENT_SET_WRITEBACK | | ||
1152 | EXTENT_END_WRITEBACK); | ||
1140 | return -ENOMEM; | 1153 | return -ENOMEM; |
1154 | } | ||
1141 | 1155 | ||
1142 | nolock = btrfs_is_free_space_inode(root, inode); | 1156 | nolock = btrfs_is_free_space_inode(root, inode); |
1143 | 1157 | ||
@@ -1147,6 +1161,15 @@ static noinline int run_delalloc_nocow(struct inode *inode, | |||
1147 | trans = btrfs_join_transaction(root); | 1161 | trans = btrfs_join_transaction(root); |
1148 | 1162 | ||
1149 | if (IS_ERR(trans)) { | 1163 | if (IS_ERR(trans)) { |
1164 | extent_clear_unlock_delalloc(inode, | ||
1165 | &BTRFS_I(inode)->io_tree, | ||
1166 | start, end, locked_page, | ||
1167 | EXTENT_CLEAR_UNLOCK_PAGE | | ||
1168 | EXTENT_CLEAR_UNLOCK | | ||
1169 | EXTENT_CLEAR_DELALLOC | | ||
1170 | EXTENT_CLEAR_DIRTY | | ||
1171 | EXTENT_SET_WRITEBACK | | ||
1172 | EXTENT_END_WRITEBACK); | ||
1150 | btrfs_free_path(path); | 1173 | btrfs_free_path(path); |
1151 | return PTR_ERR(trans); | 1174 | return PTR_ERR(trans); |
1152 | } | 1175 | } |
@@ -1327,8 +1350,11 @@ out_check: | |||
1327 | } | 1350 | } |
1328 | btrfs_release_path(path); | 1351 | btrfs_release_path(path); |
1329 | 1352 | ||
1330 | if (cur_offset <= end && cow_start == (u64)-1) | 1353 | if (cur_offset <= end && cow_start == (u64)-1) { |
1331 | cow_start = cur_offset; | 1354 | cow_start = cur_offset; |
1355 | cur_offset = end; | ||
1356 | } | ||
1357 | |||
1332 | if (cow_start != (u64)-1) { | 1358 | if (cow_start != (u64)-1) { |
1333 | ret = cow_file_range(inode, locked_page, cow_start, end, | 1359 | ret = cow_file_range(inode, locked_page, cow_start, end, |
1334 | page_started, nr_written, 1); | 1360 | page_started, nr_written, 1); |
@@ -1347,6 +1373,17 @@ error: | |||
1347 | if (!ret) | 1373 | if (!ret) |
1348 | ret = err; | 1374 | ret = err; |
1349 | 1375 | ||
1376 | if (ret && cur_offset < end) | ||
1377 | extent_clear_unlock_delalloc(inode, | ||
1378 | &BTRFS_I(inode)->io_tree, | ||
1379 | cur_offset, end, locked_page, | ||
1380 | EXTENT_CLEAR_UNLOCK_PAGE | | ||
1381 | EXTENT_CLEAR_UNLOCK | | ||
1382 | EXTENT_CLEAR_DELALLOC | | ||
1383 | EXTENT_CLEAR_DIRTY | | ||
1384 | EXTENT_SET_WRITEBACK | | ||
1385 | EXTENT_END_WRITEBACK); | ||
1386 | |||
1350 | btrfs_free_path(path); | 1387 | btrfs_free_path(path); |
1351 | return ret; | 1388 | return ret; |
1352 | } | 1389 | } |
@@ -1361,20 +1398,23 @@ static int run_delalloc_range(struct inode *inode, struct page *locked_page, | |||
1361 | int ret; | 1398 | int ret; |
1362 | struct btrfs_root *root = BTRFS_I(inode)->root; | 1399 | struct btrfs_root *root = BTRFS_I(inode)->root; |
1363 | 1400 | ||
1364 | if (BTRFS_I(inode)->flags & BTRFS_INODE_NODATACOW) | 1401 | if (BTRFS_I(inode)->flags & BTRFS_INODE_NODATACOW) { |
1365 | ret = run_delalloc_nocow(inode, locked_page, start, end, | 1402 | ret = run_delalloc_nocow(inode, locked_page, start, end, |
1366 | page_started, 1, nr_written); | 1403 | page_started, 1, nr_written); |
1367 | else if (BTRFS_I(inode)->flags & BTRFS_INODE_PREALLOC) | 1404 | } else if (BTRFS_I(inode)->flags & BTRFS_INODE_PREALLOC) { |
1368 | ret = run_delalloc_nocow(inode, locked_page, start, end, | 1405 | ret = run_delalloc_nocow(inode, locked_page, start, end, |
1369 | page_started, 0, nr_written); | 1406 | page_started, 0, nr_written); |
1370 | else if (!btrfs_test_opt(root, COMPRESS) && | 1407 | } else if (!btrfs_test_opt(root, COMPRESS) && |
1371 | !(BTRFS_I(inode)->force_compress) && | 1408 | !(BTRFS_I(inode)->force_compress) && |
1372 | !(BTRFS_I(inode)->flags & BTRFS_INODE_COMPRESS)) | 1409 | !(BTRFS_I(inode)->flags & BTRFS_INODE_COMPRESS)) { |
1373 | ret = cow_file_range(inode, locked_page, start, end, | 1410 | ret = cow_file_range(inode, locked_page, start, end, |
1374 | page_started, nr_written, 1); | 1411 | page_started, nr_written, 1); |
1375 | else | 1412 | } else { |
1413 | set_bit(BTRFS_INODE_HAS_ASYNC_EXTENT, | ||
1414 | &BTRFS_I(inode)->runtime_flags); | ||
1376 | ret = cow_file_range_async(inode, locked_page, start, end, | 1415 | ret = cow_file_range_async(inode, locked_page, start, end, |
1377 | page_started, nr_written); | 1416 | page_started, nr_written); |
1417 | } | ||
1378 | return ret; | 1418 | return ret; |
1379 | } | 1419 | } |
1380 | 1420 | ||
@@ -3714,7 +3754,7 @@ void btrfs_evict_inode(struct inode *inode) | |||
3714 | btrfs_wait_ordered_range(inode, 0, (u64)-1); | 3754 | btrfs_wait_ordered_range(inode, 0, (u64)-1); |
3715 | 3755 | ||
3716 | if (root->fs_info->log_root_recovering) { | 3756 | if (root->fs_info->log_root_recovering) { |
3717 | BUG_ON(!test_bit(BTRFS_INODE_HAS_ORPHAN_ITEM, | 3757 | BUG_ON(test_bit(BTRFS_INODE_HAS_ORPHAN_ITEM, |
3718 | &BTRFS_I(inode)->runtime_flags)); | 3758 | &BTRFS_I(inode)->runtime_flags)); |
3719 | goto no_delete; | 3759 | goto no_delete; |
3720 | } | 3760 | } |
@@ -4207,7 +4247,7 @@ static void btrfs_dentry_release(struct dentry *dentry) | |||
4207 | } | 4247 | } |
4208 | 4248 | ||
4209 | static struct dentry *btrfs_lookup(struct inode *dir, struct dentry *dentry, | 4249 | static struct dentry *btrfs_lookup(struct inode *dir, struct dentry *dentry, |
4210 | struct nameidata *nd) | 4250 | unsigned int flags) |
4211 | { | 4251 | { |
4212 | struct dentry *ret; | 4252 | struct dentry *ret; |
4213 | 4253 | ||
@@ -4853,7 +4893,7 @@ out_unlock: | |||
4853 | } | 4893 | } |
4854 | 4894 | ||
4855 | static int btrfs_create(struct inode *dir, struct dentry *dentry, | 4895 | static int btrfs_create(struct inode *dir, struct dentry *dentry, |
4856 | umode_t mode, struct nameidata *nd) | 4896 | umode_t mode, bool excl) |
4857 | { | 4897 | { |
4858 | struct btrfs_trans_handle *trans; | 4898 | struct btrfs_trans_handle *trans; |
4859 | struct btrfs_root *root = BTRFS_I(dir)->root; | 4899 | struct btrfs_root *root = BTRFS_I(dir)->root; |
@@ -5836,8 +5876,17 @@ map: | |||
5836 | bh_result->b_size = len; | 5876 | bh_result->b_size = len; |
5837 | bh_result->b_bdev = em->bdev; | 5877 | bh_result->b_bdev = em->bdev; |
5838 | set_buffer_mapped(bh_result); | 5878 | set_buffer_mapped(bh_result); |
5839 | if (create && !test_bit(EXTENT_FLAG_PREALLOC, &em->flags)) | 5879 | if (create) { |
5840 | set_buffer_new(bh_result); | 5880 | if (!test_bit(EXTENT_FLAG_PREALLOC, &em->flags)) |
5881 | set_buffer_new(bh_result); | ||
5882 | |||
5883 | /* | ||
5884 | * Need to update the i_size under the extent lock so buffered | ||
5885 | * readers will get the updated i_size when we unlock. | ||
5886 | */ | ||
5887 | if (start + len > i_size_read(inode)) | ||
5888 | i_size_write(inode, start + len); | ||
5889 | } | ||
5841 | 5890 | ||
5842 | free_extent_map(em); | 5891 | free_extent_map(em); |
5843 | 5892 | ||
@@ -6320,12 +6369,48 @@ static ssize_t btrfs_direct_IO(int rw, struct kiocb *iocb, | |||
6320 | */ | 6369 | */ |
6321 | ordered = btrfs_lookup_ordered_range(inode, lockstart, | 6370 | ordered = btrfs_lookup_ordered_range(inode, lockstart, |
6322 | lockend - lockstart + 1); | 6371 | lockend - lockstart + 1); |
6323 | if (!ordered) | 6372 | |
6373 | /* | ||
6374 | * We need to make sure there are no buffered pages in this | ||
6375 | * range either, we could have raced between the invalidate in | ||
6376 | * generic_file_direct_write and locking the extent. The | ||
6377 | * invalidate needs to happen so that reads after a write do not | ||
6378 | * get stale data. | ||
6379 | */ | ||
6380 | if (!ordered && (!writing || | ||
6381 | !test_range_bit(&BTRFS_I(inode)->io_tree, | ||
6382 | lockstart, lockend, EXTENT_UPTODATE, 0, | ||
6383 | cached_state))) | ||
6324 | break; | 6384 | break; |
6385 | |||
6325 | unlock_extent_cached(&BTRFS_I(inode)->io_tree, lockstart, lockend, | 6386 | unlock_extent_cached(&BTRFS_I(inode)->io_tree, lockstart, lockend, |
6326 | &cached_state, GFP_NOFS); | 6387 | &cached_state, GFP_NOFS); |
6327 | btrfs_start_ordered_extent(inode, ordered, 1); | 6388 | |
6328 | btrfs_put_ordered_extent(ordered); | 6389 | if (ordered) { |
6390 | btrfs_start_ordered_extent(inode, ordered, 1); | ||
6391 | btrfs_put_ordered_extent(ordered); | ||
6392 | } else { | ||
6393 | /* Screw you mmap */ | ||
6394 | ret = filemap_write_and_wait_range(file->f_mapping, | ||
6395 | lockstart, | ||
6396 | lockend); | ||
6397 | if (ret) | ||
6398 | goto out; | ||
6399 | |||
6400 | /* | ||
6401 | * If we found a page that couldn't be invalidated just | ||
6402 | * fall back to buffered. | ||
6403 | */ | ||
6404 | ret = invalidate_inode_pages2_range(file->f_mapping, | ||
6405 | lockstart >> PAGE_CACHE_SHIFT, | ||
6406 | lockend >> PAGE_CACHE_SHIFT); | ||
6407 | if (ret) { | ||
6408 | if (ret == -EBUSY) | ||
6409 | ret = 0; | ||
6410 | goto out; | ||
6411 | } | ||
6412 | } | ||
6413 | |||
6329 | cond_resched(); | 6414 | cond_resched(); |
6330 | } | 6415 | } |
6331 | 6416 | ||
@@ -6902,7 +6987,7 @@ void btrfs_destroy_inode(struct inode *inode) | |||
6902 | struct btrfs_ordered_extent *ordered; | 6987 | struct btrfs_ordered_extent *ordered; |
6903 | struct btrfs_root *root = BTRFS_I(inode)->root; | 6988 | struct btrfs_root *root = BTRFS_I(inode)->root; |
6904 | 6989 | ||
6905 | WARN_ON(!list_empty(&inode->i_dentry)); | 6990 | WARN_ON(!hlist_empty(&inode->i_dentry)); |
6906 | WARN_ON(inode->i_data.nrpages); | 6991 | WARN_ON(inode->i_data.nrpages); |
6907 | WARN_ON(BTRFS_I(inode)->outstanding_extents); | 6992 | WARN_ON(BTRFS_I(inode)->outstanding_extents); |
6908 | WARN_ON(BTRFS_I(inode)->reserved_extents); | 6993 | WARN_ON(BTRFS_I(inode)->reserved_extents); |
@@ -7054,10 +7139,13 @@ static void fixup_inode_flags(struct inode *dir, struct inode *inode) | |||
7054 | else | 7139 | else |
7055 | b_inode->flags &= ~BTRFS_INODE_NODATACOW; | 7140 | b_inode->flags &= ~BTRFS_INODE_NODATACOW; |
7056 | 7141 | ||
7057 | if (b_dir->flags & BTRFS_INODE_COMPRESS) | 7142 | if (b_dir->flags & BTRFS_INODE_COMPRESS) { |
7058 | b_inode->flags |= BTRFS_INODE_COMPRESS; | 7143 | b_inode->flags |= BTRFS_INODE_COMPRESS; |
7059 | else | 7144 | b_inode->flags &= ~BTRFS_INODE_NOCOMPRESS; |
7060 | b_inode->flags &= ~BTRFS_INODE_COMPRESS; | 7145 | } else { |
7146 | b_inode->flags &= ~(BTRFS_INODE_COMPRESS | | ||
7147 | BTRFS_INODE_NOCOMPRESS); | ||
7148 | } | ||
7061 | } | 7149 | } |
7062 | 7150 | ||
7063 | static int btrfs_rename(struct inode *old_dir, struct dentry *old_dentry, | 7151 | static int btrfs_rename(struct inode *old_dir, struct dentry *old_dentry, |
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 24b776c08d99..1e9f6c019ad0 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c | |||
@@ -52,6 +52,7 @@ | |||
52 | #include "locking.h" | 52 | #include "locking.h" |
53 | #include "inode-map.h" | 53 | #include "inode-map.h" |
54 | #include "backref.h" | 54 | #include "backref.h" |
55 | #include "rcu-string.h" | ||
55 | 56 | ||
56 | /* Mask out flags that are inappropriate for the given type of inode. */ | 57 | /* Mask out flags that are inappropriate for the given type of inode. */ |
57 | static inline __u32 btrfs_mask_flags(umode_t mode, __u32 flags) | 58 | static inline __u32 btrfs_mask_flags(umode_t mode, __u32 flags) |
@@ -785,39 +786,57 @@ none: | |||
785 | return -ENOENT; | 786 | return -ENOENT; |
786 | } | 787 | } |
787 | 788 | ||
788 | /* | 789 | static struct extent_map *defrag_lookup_extent(struct inode *inode, u64 start) |
789 | * Validaty check of prev em and next em: | ||
790 | * 1) no prev/next em | ||
791 | * 2) prev/next em is an hole/inline extent | ||
792 | */ | ||
793 | static int check_adjacent_extents(struct inode *inode, struct extent_map *em) | ||
794 | { | 790 | { |
795 | struct extent_map_tree *em_tree = &BTRFS_I(inode)->extent_tree; | 791 | struct extent_map_tree *em_tree = &BTRFS_I(inode)->extent_tree; |
796 | struct extent_map *prev = NULL, *next = NULL; | 792 | struct extent_io_tree *io_tree = &BTRFS_I(inode)->io_tree; |
797 | int ret = 0; | 793 | struct extent_map *em; |
794 | u64 len = PAGE_CACHE_SIZE; | ||
798 | 795 | ||
796 | /* | ||
797 | * hopefully we have this extent in the tree already, try without | ||
798 | * the full extent lock | ||
799 | */ | ||
799 | read_lock(&em_tree->lock); | 800 | read_lock(&em_tree->lock); |
800 | prev = lookup_extent_mapping(em_tree, em->start - 1, (u64)-1); | 801 | em = lookup_extent_mapping(em_tree, start, len); |
801 | next = lookup_extent_mapping(em_tree, em->start + em->len, (u64)-1); | ||
802 | read_unlock(&em_tree->lock); | 802 | read_unlock(&em_tree->lock); |
803 | 803 | ||
804 | if ((!prev || prev->block_start >= EXTENT_MAP_LAST_BYTE) && | 804 | if (!em) { |
805 | (!next || next->block_start >= EXTENT_MAP_LAST_BYTE)) | 805 | /* get the big lock and read metadata off disk */ |
806 | ret = 1; | 806 | lock_extent(io_tree, start, start + len - 1); |
807 | free_extent_map(prev); | 807 | em = btrfs_get_extent(inode, NULL, 0, start, len, 0); |
808 | free_extent_map(next); | 808 | unlock_extent(io_tree, start, start + len - 1); |
809 | 809 | ||
810 | if (IS_ERR(em)) | ||
811 | return NULL; | ||
812 | } | ||
813 | |||
814 | return em; | ||
815 | } | ||
816 | |||
817 | static bool defrag_check_next_extent(struct inode *inode, struct extent_map *em) | ||
818 | { | ||
819 | struct extent_map *next; | ||
820 | bool ret = true; | ||
821 | |||
822 | /* this is the last extent */ | ||
823 | if (em->start + em->len >= i_size_read(inode)) | ||
824 | return false; | ||
825 | |||
826 | next = defrag_lookup_extent(inode, em->start + em->len); | ||
827 | if (!next || next->block_start >= EXTENT_MAP_LAST_BYTE) | ||
828 | ret = false; | ||
829 | |||
830 | free_extent_map(next); | ||
810 | return ret; | 831 | return ret; |
811 | } | 832 | } |
812 | 833 | ||
813 | static int should_defrag_range(struct inode *inode, u64 start, u64 len, | 834 | static int should_defrag_range(struct inode *inode, u64 start, int thresh, |
814 | int thresh, u64 *last_len, u64 *skip, | 835 | u64 *last_len, u64 *skip, u64 *defrag_end) |
815 | u64 *defrag_end) | ||
816 | { | 836 | { |
817 | struct extent_io_tree *io_tree = &BTRFS_I(inode)->io_tree; | 837 | struct extent_map *em; |
818 | struct extent_map *em = NULL; | ||
819 | struct extent_map_tree *em_tree = &BTRFS_I(inode)->extent_tree; | ||
820 | int ret = 1; | 838 | int ret = 1; |
839 | bool next_mergeable = true; | ||
821 | 840 | ||
822 | /* | 841 | /* |
823 | * make sure that once we start defragging an extent, we keep on | 842 | * make sure that once we start defragging an extent, we keep on |
@@ -828,23 +847,9 @@ static int should_defrag_range(struct inode *inode, u64 start, u64 len, | |||
828 | 847 | ||
829 | *skip = 0; | 848 | *skip = 0; |
830 | 849 | ||
831 | /* | 850 | em = defrag_lookup_extent(inode, start); |
832 | * hopefully we have this extent in the tree already, try without | 851 | if (!em) |
833 | * the full extent lock | 852 | return 0; |
834 | */ | ||
835 | read_lock(&em_tree->lock); | ||
836 | em = lookup_extent_mapping(em_tree, start, len); | ||
837 | read_unlock(&em_tree->lock); | ||
838 | |||
839 | if (!em) { | ||
840 | /* get the big lock and read metadata off disk */ | ||
841 | lock_extent(io_tree, start, start + len - 1); | ||
842 | em = btrfs_get_extent(inode, NULL, 0, start, len, 0); | ||
843 | unlock_extent(io_tree, start, start + len - 1); | ||
844 | |||
845 | if (IS_ERR(em)) | ||
846 | return 0; | ||
847 | } | ||
848 | 853 | ||
849 | /* this will cover holes, and inline extents */ | 854 | /* this will cover holes, and inline extents */ |
850 | if (em->block_start >= EXTENT_MAP_LAST_BYTE) { | 855 | if (em->block_start >= EXTENT_MAP_LAST_BYTE) { |
@@ -852,18 +857,15 @@ static int should_defrag_range(struct inode *inode, u64 start, u64 len, | |||
852 | goto out; | 857 | goto out; |
853 | } | 858 | } |
854 | 859 | ||
855 | /* If we have nothing to merge with us, just skip. */ | 860 | next_mergeable = defrag_check_next_extent(inode, em); |
856 | if (check_adjacent_extents(inode, em)) { | ||
857 | ret = 0; | ||
858 | goto out; | ||
859 | } | ||
860 | 861 | ||
861 | /* | 862 | /* |
862 | * we hit a real extent, if it is big don't bother defragging it again | 863 | * we hit a real extent, if it is big or the next extent is not a |
864 | * real extent, don't bother defragging it | ||
863 | */ | 865 | */ |
864 | if ((*last_len == 0 || *last_len >= thresh) && em->len >= thresh) | 866 | if ((*last_len == 0 || *last_len >= thresh) && |
867 | (em->len >= thresh || !next_mergeable)) | ||
865 | ret = 0; | 868 | ret = 0; |
866 | |||
867 | out: | 869 | out: |
868 | /* | 870 | /* |
869 | * last_len ends up being a counter of how many bytes we've defragged. | 871 | * last_len ends up being a counter of how many bytes we've defragged. |
@@ -1142,8 +1144,8 @@ int btrfs_defrag_file(struct inode *inode, struct file *file, | |||
1142 | break; | 1144 | break; |
1143 | 1145 | ||
1144 | if (!should_defrag_range(inode, (u64)i << PAGE_CACHE_SHIFT, | 1146 | if (!should_defrag_range(inode, (u64)i << PAGE_CACHE_SHIFT, |
1145 | PAGE_CACHE_SIZE, extent_thresh, | 1147 | extent_thresh, &last_len, &skip, |
1146 | &last_len, &skip, &defrag_end)) { | 1148 | &defrag_end)) { |
1147 | unsigned long next; | 1149 | unsigned long next; |
1148 | /* | 1150 | /* |
1149 | * the should_defrag function tells us how much to skip | 1151 | * the should_defrag function tells us how much to skip |
@@ -1304,6 +1306,14 @@ static noinline int btrfs_ioctl_resize(struct btrfs_root *root, | |||
1304 | ret = -EINVAL; | 1306 | ret = -EINVAL; |
1305 | goto out_free; | 1307 | goto out_free; |
1306 | } | 1308 | } |
1309 | if (device->fs_devices && device->fs_devices->seeding) { | ||
1310 | printk(KERN_INFO "btrfs: resizer unable to apply on " | ||
1311 | "seeding device %llu\n", | ||
1312 | (unsigned long long)devid); | ||
1313 | ret = -EINVAL; | ||
1314 | goto out_free; | ||
1315 | } | ||
1316 | |||
1307 | if (!strcmp(sizestr, "max")) | 1317 | if (!strcmp(sizestr, "max")) |
1308 | new_size = device->bdev->bd_inode->i_size; | 1318 | new_size = device->bdev->bd_inode->i_size; |
1309 | else { | 1319 | else { |
@@ -1345,8 +1355,9 @@ static noinline int btrfs_ioctl_resize(struct btrfs_root *root, | |||
1345 | do_div(new_size, root->sectorsize); | 1355 | do_div(new_size, root->sectorsize); |
1346 | new_size *= root->sectorsize; | 1356 | new_size *= root->sectorsize; |
1347 | 1357 | ||
1348 | printk(KERN_INFO "btrfs: new size for %s is %llu\n", | 1358 | printk_in_rcu(KERN_INFO "btrfs: new size for %s is %llu\n", |
1349 | device->name, (unsigned long long)new_size); | 1359 | rcu_str_deref(device->name), |
1360 | (unsigned long long)new_size); | ||
1350 | 1361 | ||
1351 | if (new_size > old_size) { | 1362 | if (new_size > old_size) { |
1352 | trans = btrfs_start_transaction(root, 0); | 1363 | trans = btrfs_start_transaction(root, 0); |
@@ -2264,7 +2275,12 @@ static long btrfs_ioctl_dev_info(struct btrfs_root *root, void __user *arg) | |||
2264 | di_args->total_bytes = dev->total_bytes; | 2275 | di_args->total_bytes = dev->total_bytes; |
2265 | memcpy(di_args->uuid, dev->uuid, sizeof(di_args->uuid)); | 2276 | memcpy(di_args->uuid, dev->uuid, sizeof(di_args->uuid)); |
2266 | if (dev->name) { | 2277 | if (dev->name) { |
2267 | strncpy(di_args->path, dev->name, sizeof(di_args->path)); | 2278 | struct rcu_string *name; |
2279 | |||
2280 | rcu_read_lock(); | ||
2281 | name = rcu_dereference(dev->name); | ||
2282 | strncpy(di_args->path, name->str, sizeof(di_args->path)); | ||
2283 | rcu_read_unlock(); | ||
2268 | di_args->path[sizeof(di_args->path) - 1] = 0; | 2284 | di_args->path[sizeof(di_args->path) - 1] = 0; |
2269 | } else { | 2285 | } else { |
2270 | di_args->path[0] = '\0'; | 2286 | di_args->path[0] = '\0'; |
@@ -3252,7 +3268,7 @@ static long btrfs_ioctl_balance(struct file *file, void __user *arg) | |||
3252 | if (fs_info->sb->s_flags & MS_RDONLY) | 3268 | if (fs_info->sb->s_flags & MS_RDONLY) |
3253 | return -EROFS; | 3269 | return -EROFS; |
3254 | 3270 | ||
3255 | ret = mnt_want_write(file->f_path.mnt); | 3271 | ret = mnt_want_write_file(file); |
3256 | if (ret) | 3272 | if (ret) |
3257 | return ret; | 3273 | return ret; |
3258 | 3274 | ||
@@ -3322,7 +3338,7 @@ out_bargs: | |||
3322 | out: | 3338 | out: |
3323 | mutex_unlock(&fs_info->balance_mutex); | 3339 | mutex_unlock(&fs_info->balance_mutex); |
3324 | mutex_unlock(&fs_info->volume_mutex); | 3340 | mutex_unlock(&fs_info->volume_mutex); |
3325 | mnt_drop_write(file->f_path.mnt); | 3341 | mnt_drop_write_file(file); |
3326 | return ret; | 3342 | return ret; |
3327 | } | 3343 | } |
3328 | 3344 | ||
diff --git a/fs/btrfs/ioctl.h b/fs/btrfs/ioctl.h index 497c530724cf..e440aa653c30 100644 --- a/fs/btrfs/ioctl.h +++ b/fs/btrfs/ioctl.h | |||
@@ -339,7 +339,7 @@ struct btrfs_ioctl_get_dev_stats { | |||
339 | #define BTRFS_IOC_WAIT_SYNC _IOW(BTRFS_IOCTL_MAGIC, 22, __u64) | 339 | #define BTRFS_IOC_WAIT_SYNC _IOW(BTRFS_IOCTL_MAGIC, 22, __u64) |
340 | #define BTRFS_IOC_SNAP_CREATE_V2 _IOW(BTRFS_IOCTL_MAGIC, 23, \ | 340 | #define BTRFS_IOC_SNAP_CREATE_V2 _IOW(BTRFS_IOCTL_MAGIC, 23, \ |
341 | struct btrfs_ioctl_vol_args_v2) | 341 | struct btrfs_ioctl_vol_args_v2) |
342 | #define BTRFS_IOC_SUBVOL_GETFLAGS _IOW(BTRFS_IOCTL_MAGIC, 25, __u64) | 342 | #define BTRFS_IOC_SUBVOL_GETFLAGS _IOR(BTRFS_IOCTL_MAGIC, 25, __u64) |
343 | #define BTRFS_IOC_SUBVOL_SETFLAGS _IOW(BTRFS_IOCTL_MAGIC, 26, __u64) | 343 | #define BTRFS_IOC_SUBVOL_SETFLAGS _IOW(BTRFS_IOCTL_MAGIC, 26, __u64) |
344 | #define BTRFS_IOC_SCRUB _IOWR(BTRFS_IOCTL_MAGIC, 27, \ | 344 | #define BTRFS_IOC_SCRUB _IOWR(BTRFS_IOCTL_MAGIC, 27, \ |
345 | struct btrfs_ioctl_scrub_args) | 345 | struct btrfs_ioctl_scrub_args) |
diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c index 9e138cdc36c5..643335a4fe3c 100644 --- a/fs/btrfs/ordered-data.c +++ b/fs/btrfs/ordered-data.c | |||
@@ -627,7 +627,27 @@ void btrfs_wait_ordered_range(struct inode *inode, u64 start, u64 len) | |||
627 | /* start IO across the range first to instantiate any delalloc | 627 | /* start IO across the range first to instantiate any delalloc |
628 | * extents | 628 | * extents |
629 | */ | 629 | */ |
630 | filemap_write_and_wait_range(inode->i_mapping, start, orig_end); | 630 | filemap_fdatawrite_range(inode->i_mapping, start, orig_end); |
631 | |||
632 | /* | ||
633 | * So with compression we will find and lock a dirty page and clear the | ||
634 | * first one as dirty, setup an async extent, and immediately return | ||
635 | * with the entire range locked but with nobody actually marked with | ||
636 | * writeback. So we can't just filemap_write_and_wait_range() and | ||
637 | * expect it to work since it will just kick off a thread to do the | ||
638 | * actual work. So we need to call filemap_fdatawrite_range _again_ | ||
639 | * since it will wait on the page lock, which won't be unlocked until | ||
640 | * after the pages have been marked as writeback and so we're good to go | ||
641 | * from there. We have to do this otherwise we'll miss the ordered | ||
642 | * extents and that results in badness. Please Josef, do not think you | ||
643 | * know better and pull this out at some point in the future, it is | ||
644 | * right and you are wrong. | ||
645 | */ | ||
646 | if (test_bit(BTRFS_INODE_HAS_ASYNC_EXTENT, | ||
647 | &BTRFS_I(inode)->runtime_flags)) | ||
648 | filemap_fdatawrite_range(inode->i_mapping, start, orig_end); | ||
649 | |||
650 | filemap_fdatawait_range(inode->i_mapping, start, orig_end); | ||
631 | 651 | ||
632 | end = orig_end; | 652 | end = orig_end; |
633 | found = 0; | 653 | found = 0; |
diff --git a/fs/btrfs/rcu-string.h b/fs/btrfs/rcu-string.h new file mode 100644 index 000000000000..9e111e4576d4 --- /dev/null +++ b/fs/btrfs/rcu-string.h | |||
@@ -0,0 +1,56 @@ | |||
1 | /* | ||
2 | * Copyright (C) 2012 Red Hat. All rights reserved. | ||
3 | * | ||
4 | * This program is free software; you can redistribute it and/or | ||
5 | * modify it under the terms of the GNU General Public | ||
6 | * License v2 as published by the Free Software Foundation. | ||
7 | * | ||
8 | * This program is distributed in the hope that it will be useful, | ||
9 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
10 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
11 | * General Public License for more details. | ||
12 | * | ||
13 | * You should have received a copy of the GNU General Public | ||
14 | * License along with this program; if not, write to the | ||
15 | * Free Software Foundation, Inc., 59 Temple Place - Suite 330, | ||
16 | * Boston, MA 021110-1307, USA. | ||
17 | */ | ||
18 | |||
19 | struct rcu_string { | ||
20 | struct rcu_head rcu; | ||
21 | char str[0]; | ||
22 | }; | ||
23 | |||
24 | static inline struct rcu_string *rcu_string_strdup(const char *src, gfp_t mask) | ||
25 | { | ||
26 | size_t len = strlen(src) + 1; | ||
27 | struct rcu_string *ret = kzalloc(sizeof(struct rcu_string) + | ||
28 | (len * sizeof(char)), mask); | ||
29 | if (!ret) | ||
30 | return ret; | ||
31 | strncpy(ret->str, src, len); | ||
32 | return ret; | ||
33 | } | ||
34 | |||
35 | static inline void rcu_string_free(struct rcu_string *str) | ||
36 | { | ||
37 | if (str) | ||
38 | kfree_rcu(str, rcu); | ||
39 | } | ||
40 | |||
41 | #define printk_in_rcu(fmt, ...) do { \ | ||
42 | rcu_read_lock(); \ | ||
43 | printk(fmt, __VA_ARGS__); \ | ||
44 | rcu_read_unlock(); \ | ||
45 | } while (0) | ||
46 | |||
47 | #define printk_ratelimited_in_rcu(fmt, ...) do { \ | ||
48 | rcu_read_lock(); \ | ||
49 | printk_ratelimited(fmt, __VA_ARGS__); \ | ||
50 | rcu_read_unlock(); \ | ||
51 | } while (0) | ||
52 | |||
53 | #define rcu_str_deref(rcu_str) ({ \ | ||
54 | struct rcu_string *__str = rcu_dereference(rcu_str); \ | ||
55 | __str->str; \ | ||
56 | }) | ||
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index a38cfa4f251e..b223620cd5a6 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c | |||
@@ -26,6 +26,7 @@ | |||
26 | #include "backref.h" | 26 | #include "backref.h" |
27 | #include "extent_io.h" | 27 | #include "extent_io.h" |
28 | #include "check-integrity.h" | 28 | #include "check-integrity.h" |
29 | #include "rcu-string.h" | ||
29 | 30 | ||
30 | /* | 31 | /* |
31 | * This is only the first step towards a full-features scrub. It reads all | 32 | * This is only the first step towards a full-features scrub. It reads all |
@@ -320,10 +321,10 @@ static int scrub_print_warning_inode(u64 inum, u64 offset, u64 root, void *ctx) | |||
320 | * hold all of the paths here | 321 | * hold all of the paths here |
321 | */ | 322 | */ |
322 | for (i = 0; i < ipath->fspath->elem_cnt; ++i) | 323 | for (i = 0; i < ipath->fspath->elem_cnt; ++i) |
323 | printk(KERN_WARNING "btrfs: %s at logical %llu on dev " | 324 | printk_in_rcu(KERN_WARNING "btrfs: %s at logical %llu on dev " |
324 | "%s, sector %llu, root %llu, inode %llu, offset %llu, " | 325 | "%s, sector %llu, root %llu, inode %llu, offset %llu, " |
325 | "length %llu, links %u (path: %s)\n", swarn->errstr, | 326 | "length %llu, links %u (path: %s)\n", swarn->errstr, |
326 | swarn->logical, swarn->dev->name, | 327 | swarn->logical, rcu_str_deref(swarn->dev->name), |
327 | (unsigned long long)swarn->sector, root, inum, offset, | 328 | (unsigned long long)swarn->sector, root, inum, offset, |
328 | min(isize - offset, (u64)PAGE_SIZE), nlink, | 329 | min(isize - offset, (u64)PAGE_SIZE), nlink, |
329 | (char *)(unsigned long)ipath->fspath->val[i]); | 330 | (char *)(unsigned long)ipath->fspath->val[i]); |
@@ -332,10 +333,10 @@ static int scrub_print_warning_inode(u64 inum, u64 offset, u64 root, void *ctx) | |||
332 | return 0; | 333 | return 0; |
333 | 334 | ||
334 | err: | 335 | err: |
335 | printk(KERN_WARNING "btrfs: %s at logical %llu on dev " | 336 | printk_in_rcu(KERN_WARNING "btrfs: %s at logical %llu on dev " |
336 | "%s, sector %llu, root %llu, inode %llu, offset %llu: path " | 337 | "%s, sector %llu, root %llu, inode %llu, offset %llu: path " |
337 | "resolving failed with ret=%d\n", swarn->errstr, | 338 | "resolving failed with ret=%d\n", swarn->errstr, |
338 | swarn->logical, swarn->dev->name, | 339 | swarn->logical, rcu_str_deref(swarn->dev->name), |
339 | (unsigned long long)swarn->sector, root, inum, offset, ret); | 340 | (unsigned long long)swarn->sector, root, inum, offset, ret); |
340 | 341 | ||
341 | free_ipath(ipath); | 342 | free_ipath(ipath); |
@@ -390,10 +391,11 @@ static void scrub_print_warning(const char *errstr, struct scrub_block *sblock) | |||
390 | do { | 391 | do { |
391 | ret = tree_backref_for_extent(&ptr, eb, ei, item_size, | 392 | ret = tree_backref_for_extent(&ptr, eb, ei, item_size, |
392 | &ref_root, &ref_level); | 393 | &ref_root, &ref_level); |
393 | printk(KERN_WARNING | 394 | printk_in_rcu(KERN_WARNING |
394 | "btrfs: %s at logical %llu on dev %s, " | 395 | "btrfs: %s at logical %llu on dev %s, " |
395 | "sector %llu: metadata %s (level %d) in tree " | 396 | "sector %llu: metadata %s (level %d) in tree " |
396 | "%llu\n", errstr, swarn.logical, dev->name, | 397 | "%llu\n", errstr, swarn.logical, |
398 | rcu_str_deref(dev->name), | ||
397 | (unsigned long long)swarn.sector, | 399 | (unsigned long long)swarn.sector, |
398 | ref_level ? "node" : "leaf", | 400 | ref_level ? "node" : "leaf", |
399 | ret < 0 ? -1 : ref_level, | 401 | ret < 0 ? -1 : ref_level, |
@@ -580,9 +582,11 @@ out: | |||
580 | spin_lock(&sdev->stat_lock); | 582 | spin_lock(&sdev->stat_lock); |
581 | ++sdev->stat.uncorrectable_errors; | 583 | ++sdev->stat.uncorrectable_errors; |
582 | spin_unlock(&sdev->stat_lock); | 584 | spin_unlock(&sdev->stat_lock); |
583 | printk_ratelimited(KERN_ERR | 585 | |
586 | printk_ratelimited_in_rcu(KERN_ERR | ||
584 | "btrfs: unable to fixup (nodatasum) error at logical %llu on dev %s\n", | 587 | "btrfs: unable to fixup (nodatasum) error at logical %llu on dev %s\n", |
585 | (unsigned long long)fixup->logical, sdev->dev->name); | 588 | (unsigned long long)fixup->logical, |
589 | rcu_str_deref(sdev->dev->name)); | ||
586 | } | 590 | } |
587 | 591 | ||
588 | btrfs_free_path(path); | 592 | btrfs_free_path(path); |
@@ -936,18 +940,20 @@ corrected_error: | |||
936 | spin_lock(&sdev->stat_lock); | 940 | spin_lock(&sdev->stat_lock); |
937 | sdev->stat.corrected_errors++; | 941 | sdev->stat.corrected_errors++; |
938 | spin_unlock(&sdev->stat_lock); | 942 | spin_unlock(&sdev->stat_lock); |
939 | printk_ratelimited(KERN_ERR | 943 | printk_ratelimited_in_rcu(KERN_ERR |
940 | "btrfs: fixed up error at logical %llu on dev %s\n", | 944 | "btrfs: fixed up error at logical %llu on dev %s\n", |
941 | (unsigned long long)logical, sdev->dev->name); | 945 | (unsigned long long)logical, |
946 | rcu_str_deref(sdev->dev->name)); | ||
942 | } | 947 | } |
943 | } else { | 948 | } else { |
944 | did_not_correct_error: | 949 | did_not_correct_error: |
945 | spin_lock(&sdev->stat_lock); | 950 | spin_lock(&sdev->stat_lock); |
946 | sdev->stat.uncorrectable_errors++; | 951 | sdev->stat.uncorrectable_errors++; |
947 | spin_unlock(&sdev->stat_lock); | 952 | spin_unlock(&sdev->stat_lock); |
948 | printk_ratelimited(KERN_ERR | 953 | printk_ratelimited_in_rcu(KERN_ERR |
949 | "btrfs: unable to fixup (regular) error at logical %llu on dev %s\n", | 954 | "btrfs: unable to fixup (regular) error at logical %llu on dev %s\n", |
950 | (unsigned long long)logical, sdev->dev->name); | 955 | (unsigned long long)logical, |
956 | rcu_str_deref(sdev->dev->name)); | ||
951 | } | 957 | } |
952 | 958 | ||
953 | out: | 959 | out: |
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 96eb9fef7bd2..b19d75567728 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c | |||
@@ -54,6 +54,7 @@ | |||
54 | #include "version.h" | 54 | #include "version.h" |
55 | #include "export.h" | 55 | #include "export.h" |
56 | #include "compression.h" | 56 | #include "compression.h" |
57 | #include "rcu-string.h" | ||
57 | 58 | ||
58 | #define CREATE_TRACE_POINTS | 59 | #define CREATE_TRACE_POINTS |
59 | #include <trace/events/btrfs.h> | 60 | #include <trace/events/btrfs.h> |
@@ -1067,7 +1068,8 @@ static struct dentry *btrfs_mount(struct file_system_type *fs_type, int flags, | |||
1067 | } | 1068 | } |
1068 | 1069 | ||
1069 | bdev = fs_devices->latest_bdev; | 1070 | bdev = fs_devices->latest_bdev; |
1070 | s = sget(fs_type, btrfs_test_super, btrfs_set_super, fs_info); | 1071 | s = sget(fs_type, btrfs_test_super, btrfs_set_super, flags | MS_NOSEC, |
1072 | fs_info); | ||
1071 | if (IS_ERR(s)) { | 1073 | if (IS_ERR(s)) { |
1072 | error = PTR_ERR(s); | 1074 | error = PTR_ERR(s); |
1073 | goto error_close_devices; | 1075 | goto error_close_devices; |
@@ -1081,7 +1083,6 @@ static struct dentry *btrfs_mount(struct file_system_type *fs_type, int flags, | |||
1081 | } else { | 1083 | } else { |
1082 | char b[BDEVNAME_SIZE]; | 1084 | char b[BDEVNAME_SIZE]; |
1083 | 1085 | ||
1084 | s->s_flags = flags | MS_NOSEC; | ||
1085 | strlcpy(s->s_id, bdevname(bdev, b), sizeof(s->s_id)); | 1086 | strlcpy(s->s_id, bdevname(bdev, b), sizeof(s->s_id)); |
1086 | btrfs_sb(s)->bdev_holder = fs_type; | 1087 | btrfs_sb(s)->bdev_holder = fs_type; |
1087 | error = btrfs_fill_super(s, fs_devices, data, | 1088 | error = btrfs_fill_super(s, fs_devices, data, |
@@ -1186,6 +1187,10 @@ static int btrfs_remount(struct super_block *sb, int *flags, char *data) | |||
1186 | if (ret) | 1187 | if (ret) |
1187 | goto restore; | 1188 | goto restore; |
1188 | 1189 | ||
1190 | ret = btrfs_resume_balance_async(fs_info); | ||
1191 | if (ret) | ||
1192 | goto restore; | ||
1193 | |||
1189 | sb->s_flags &= ~MS_RDONLY; | 1194 | sb->s_flags &= ~MS_RDONLY; |
1190 | } | 1195 | } |
1191 | 1196 | ||
@@ -1482,12 +1487,44 @@ static void btrfs_fs_dirty_inode(struct inode *inode, int flags) | |||
1482 | "error %d\n", btrfs_ino(inode), ret); | 1487 | "error %d\n", btrfs_ino(inode), ret); |
1483 | } | 1488 | } |
1484 | 1489 | ||
1490 | static int btrfs_show_devname(struct seq_file *m, struct dentry *root) | ||
1491 | { | ||
1492 | struct btrfs_fs_info *fs_info = btrfs_sb(root->d_sb); | ||
1493 | struct btrfs_fs_devices *cur_devices; | ||
1494 | struct btrfs_device *dev, *first_dev = NULL; | ||
1495 | struct list_head *head; | ||
1496 | struct rcu_string *name; | ||
1497 | |||
1498 | mutex_lock(&fs_info->fs_devices->device_list_mutex); | ||
1499 | cur_devices = fs_info->fs_devices; | ||
1500 | while (cur_devices) { | ||
1501 | head = &cur_devices->devices; | ||
1502 | list_for_each_entry(dev, head, dev_list) { | ||
1503 | if (!first_dev || dev->devid < first_dev->devid) | ||
1504 | first_dev = dev; | ||
1505 | } | ||
1506 | cur_devices = cur_devices->seed; | ||
1507 | } | ||
1508 | |||
1509 | if (first_dev) { | ||
1510 | rcu_read_lock(); | ||
1511 | name = rcu_dereference(first_dev->name); | ||
1512 | seq_escape(m, name->str, " \t\n\\"); | ||
1513 | rcu_read_unlock(); | ||
1514 | } else { | ||
1515 | WARN_ON(1); | ||
1516 | } | ||
1517 | mutex_unlock(&fs_info->fs_devices->device_list_mutex); | ||
1518 | return 0; | ||
1519 | } | ||
1520 | |||
1485 | static const struct super_operations btrfs_super_ops = { | 1521 | static const struct super_operations btrfs_super_ops = { |
1486 | .drop_inode = btrfs_drop_inode, | 1522 | .drop_inode = btrfs_drop_inode, |
1487 | .evict_inode = btrfs_evict_inode, | 1523 | .evict_inode = btrfs_evict_inode, |
1488 | .put_super = btrfs_put_super, | 1524 | .put_super = btrfs_put_super, |
1489 | .sync_fs = btrfs_sync_fs, | 1525 | .sync_fs = btrfs_sync_fs, |
1490 | .show_options = btrfs_show_options, | 1526 | .show_options = btrfs_show_options, |
1527 | .show_devname = btrfs_show_devname, | ||
1491 | .write_inode = btrfs_write_inode, | 1528 | .write_inode = btrfs_write_inode, |
1492 | .dirty_inode = btrfs_fs_dirty_inode, | 1529 | .dirty_inode = btrfs_fs_dirty_inode, |
1493 | .alloc_inode = btrfs_alloc_inode, | 1530 | .alloc_inode = btrfs_alloc_inode, |
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index 1791c6e3d834..b72b068183ec 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c | |||
@@ -100,6 +100,10 @@ loop: | |||
100 | kmem_cache_free(btrfs_transaction_cachep, cur_trans); | 100 | kmem_cache_free(btrfs_transaction_cachep, cur_trans); |
101 | cur_trans = fs_info->running_transaction; | 101 | cur_trans = fs_info->running_transaction; |
102 | goto loop; | 102 | goto loop; |
103 | } else if (root->fs_info->fs_state & BTRFS_SUPER_FLAG_ERROR) { | ||
104 | spin_unlock(&root->fs_info->trans_lock); | ||
105 | kmem_cache_free(btrfs_transaction_cachep, cur_trans); | ||
106 | return -EROFS; | ||
103 | } | 107 | } |
104 | 108 | ||
105 | atomic_set(&cur_trans->num_writers, 1); | 109 | atomic_set(&cur_trans->num_writers, 1); |
@@ -1213,14 +1217,20 @@ int btrfs_commit_transaction_async(struct btrfs_trans_handle *trans, | |||
1213 | 1217 | ||
1214 | 1218 | ||
1215 | static void cleanup_transaction(struct btrfs_trans_handle *trans, | 1219 | static void cleanup_transaction(struct btrfs_trans_handle *trans, |
1216 | struct btrfs_root *root) | 1220 | struct btrfs_root *root, int err) |
1217 | { | 1221 | { |
1218 | struct btrfs_transaction *cur_trans = trans->transaction; | 1222 | struct btrfs_transaction *cur_trans = trans->transaction; |
1219 | 1223 | ||
1220 | WARN_ON(trans->use_count > 1); | 1224 | WARN_ON(trans->use_count > 1); |
1221 | 1225 | ||
1226 | btrfs_abort_transaction(trans, root, err); | ||
1227 | |||
1222 | spin_lock(&root->fs_info->trans_lock); | 1228 | spin_lock(&root->fs_info->trans_lock); |
1223 | list_del_init(&cur_trans->list); | 1229 | list_del_init(&cur_trans->list); |
1230 | if (cur_trans == root->fs_info->running_transaction) { | ||
1231 | root->fs_info->running_transaction = NULL; | ||
1232 | root->fs_info->trans_no_join = 0; | ||
1233 | } | ||
1224 | spin_unlock(&root->fs_info->trans_lock); | 1234 | spin_unlock(&root->fs_info->trans_lock); |
1225 | 1235 | ||
1226 | btrfs_cleanup_one_transaction(trans->transaction, root); | 1236 | btrfs_cleanup_one_transaction(trans->transaction, root); |
@@ -1526,7 +1536,7 @@ cleanup_transaction: | |||
1526 | // WARN_ON(1); | 1536 | // WARN_ON(1); |
1527 | if (current->journal_info == trans) | 1537 | if (current->journal_info == trans) |
1528 | current->journal_info = NULL; | 1538 | current->journal_info = NULL; |
1529 | cleanup_transaction(trans, root); | 1539 | cleanup_transaction(trans, root, ret); |
1530 | 1540 | ||
1531 | return ret; | 1541 | return ret; |
1532 | } | 1542 | } |
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 2017d0ff511c..8abeae4224f9 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c | |||
@@ -690,6 +690,8 @@ static noinline int drop_one_dir_item(struct btrfs_trans_handle *trans, | |||
690 | kfree(name); | 690 | kfree(name); |
691 | 691 | ||
692 | iput(inode); | 692 | iput(inode); |
693 | |||
694 | btrfs_run_delayed_items(trans, root); | ||
693 | return ret; | 695 | return ret; |
694 | } | 696 | } |
695 | 697 | ||
@@ -895,6 +897,7 @@ again: | |||
895 | ret = btrfs_unlink_inode(trans, root, dir, | 897 | ret = btrfs_unlink_inode(trans, root, dir, |
896 | inode, victim_name, | 898 | inode, victim_name, |
897 | victim_name_len); | 899 | victim_name_len); |
900 | btrfs_run_delayed_items(trans, root); | ||
898 | } | 901 | } |
899 | kfree(victim_name); | 902 | kfree(victim_name); |
900 | ptr = (unsigned long)(victim_ref + 1) + victim_name_len; | 903 | ptr = (unsigned long)(victim_ref + 1) + victim_name_len; |
@@ -1475,6 +1478,9 @@ again: | |||
1475 | ret = btrfs_unlink_inode(trans, root, dir, inode, | 1478 | ret = btrfs_unlink_inode(trans, root, dir, inode, |
1476 | name, name_len); | 1479 | name, name_len); |
1477 | BUG_ON(ret); | 1480 | BUG_ON(ret); |
1481 | |||
1482 | btrfs_run_delayed_items(trans, root); | ||
1483 | |||
1478 | kfree(name); | 1484 | kfree(name); |
1479 | iput(inode); | 1485 | iput(inode); |
1480 | 1486 | ||
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 7782020996fe..ecaad40e7ef4 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c | |||
@@ -35,6 +35,7 @@ | |||
35 | #include "volumes.h" | 35 | #include "volumes.h" |
36 | #include "async-thread.h" | 36 | #include "async-thread.h" |
37 | #include "check-integrity.h" | 37 | #include "check-integrity.h" |
38 | #include "rcu-string.h" | ||
38 | 39 | ||
39 | static int init_first_rw_device(struct btrfs_trans_handle *trans, | 40 | static int init_first_rw_device(struct btrfs_trans_handle *trans, |
40 | struct btrfs_root *root, | 41 | struct btrfs_root *root, |
@@ -64,7 +65,7 @@ static void free_fs_devices(struct btrfs_fs_devices *fs_devices) | |||
64 | device = list_entry(fs_devices->devices.next, | 65 | device = list_entry(fs_devices->devices.next, |
65 | struct btrfs_device, dev_list); | 66 | struct btrfs_device, dev_list); |
66 | list_del(&device->dev_list); | 67 | list_del(&device->dev_list); |
67 | kfree(device->name); | 68 | rcu_string_free(device->name); |
68 | kfree(device); | 69 | kfree(device); |
69 | } | 70 | } |
70 | kfree(fs_devices); | 71 | kfree(fs_devices); |
@@ -334,8 +335,8 @@ static noinline int device_list_add(const char *path, | |||
334 | { | 335 | { |
335 | struct btrfs_device *device; | 336 | struct btrfs_device *device; |
336 | struct btrfs_fs_devices *fs_devices; | 337 | struct btrfs_fs_devices *fs_devices; |
338 | struct rcu_string *name; | ||
337 | u64 found_transid = btrfs_super_generation(disk_super); | 339 | u64 found_transid = btrfs_super_generation(disk_super); |
338 | char *name; | ||
339 | 340 | ||
340 | fs_devices = find_fsid(disk_super->fsid); | 341 | fs_devices = find_fsid(disk_super->fsid); |
341 | if (!fs_devices) { | 342 | if (!fs_devices) { |
@@ -369,11 +370,13 @@ static noinline int device_list_add(const char *path, | |||
369 | memcpy(device->uuid, disk_super->dev_item.uuid, | 370 | memcpy(device->uuid, disk_super->dev_item.uuid, |
370 | BTRFS_UUID_SIZE); | 371 | BTRFS_UUID_SIZE); |
371 | spin_lock_init(&device->io_lock); | 372 | spin_lock_init(&device->io_lock); |
372 | device->name = kstrdup(path, GFP_NOFS); | 373 | |
373 | if (!device->name) { | 374 | name = rcu_string_strdup(path, GFP_NOFS); |
375 | if (!name) { | ||
374 | kfree(device); | 376 | kfree(device); |
375 | return -ENOMEM; | 377 | return -ENOMEM; |
376 | } | 378 | } |
379 | rcu_assign_pointer(device->name, name); | ||
377 | INIT_LIST_HEAD(&device->dev_alloc_list); | 380 | INIT_LIST_HEAD(&device->dev_alloc_list); |
378 | 381 | ||
379 | /* init readahead state */ | 382 | /* init readahead state */ |
@@ -390,12 +393,12 @@ static noinline int device_list_add(const char *path, | |||
390 | 393 | ||
391 | device->fs_devices = fs_devices; | 394 | device->fs_devices = fs_devices; |
392 | fs_devices->num_devices++; | 395 | fs_devices->num_devices++; |
393 | } else if (!device->name || strcmp(device->name, path)) { | 396 | } else if (!device->name || strcmp(device->name->str, path)) { |
394 | name = kstrdup(path, GFP_NOFS); | 397 | name = rcu_string_strdup(path, GFP_NOFS); |
395 | if (!name) | 398 | if (!name) |
396 | return -ENOMEM; | 399 | return -ENOMEM; |
397 | kfree(device->name); | 400 | rcu_string_free(device->name); |
398 | device->name = name; | 401 | rcu_assign_pointer(device->name, name); |
399 | if (device->missing) { | 402 | if (device->missing) { |
400 | fs_devices->missing_devices--; | 403 | fs_devices->missing_devices--; |
401 | device->missing = 0; | 404 | device->missing = 0; |
@@ -430,15 +433,22 @@ static struct btrfs_fs_devices *clone_fs_devices(struct btrfs_fs_devices *orig) | |||
430 | 433 | ||
431 | /* We have held the volume lock, it is safe to get the devices. */ | 434 | /* We have held the volume lock, it is safe to get the devices. */ |
432 | list_for_each_entry(orig_dev, &orig->devices, dev_list) { | 435 | list_for_each_entry(orig_dev, &orig->devices, dev_list) { |
436 | struct rcu_string *name; | ||
437 | |||
433 | device = kzalloc(sizeof(*device), GFP_NOFS); | 438 | device = kzalloc(sizeof(*device), GFP_NOFS); |
434 | if (!device) | 439 | if (!device) |
435 | goto error; | 440 | goto error; |
436 | 441 | ||
437 | device->name = kstrdup(orig_dev->name, GFP_NOFS); | 442 | /* |
438 | if (!device->name) { | 443 | * This is ok to do without rcu read locked because we hold the |
444 | * uuid mutex so nothing we touch in here is going to disappear. | ||
445 | */ | ||
446 | name = rcu_string_strdup(orig_dev->name->str, GFP_NOFS); | ||
447 | if (!name) { | ||
439 | kfree(device); | 448 | kfree(device); |
440 | goto error; | 449 | goto error; |
441 | } | 450 | } |
451 | rcu_assign_pointer(device->name, name); | ||
442 | 452 | ||
443 | device->devid = orig_dev->devid; | 453 | device->devid = orig_dev->devid; |
444 | device->work.func = pending_bios_fn; | 454 | device->work.func = pending_bios_fn; |
@@ -491,7 +501,7 @@ again: | |||
491 | } | 501 | } |
492 | list_del_init(&device->dev_list); | 502 | list_del_init(&device->dev_list); |
493 | fs_devices->num_devices--; | 503 | fs_devices->num_devices--; |
494 | kfree(device->name); | 504 | rcu_string_free(device->name); |
495 | kfree(device); | 505 | kfree(device); |
496 | } | 506 | } |
497 | 507 | ||
@@ -516,7 +526,7 @@ static void __free_device(struct work_struct *work) | |||
516 | if (device->bdev) | 526 | if (device->bdev) |
517 | blkdev_put(device->bdev, device->mode); | 527 | blkdev_put(device->bdev, device->mode); |
518 | 528 | ||
519 | kfree(device->name); | 529 | rcu_string_free(device->name); |
520 | kfree(device); | 530 | kfree(device); |
521 | } | 531 | } |
522 | 532 | ||
@@ -540,6 +550,7 @@ static int __btrfs_close_devices(struct btrfs_fs_devices *fs_devices) | |||
540 | mutex_lock(&fs_devices->device_list_mutex); | 550 | mutex_lock(&fs_devices->device_list_mutex); |
541 | list_for_each_entry(device, &fs_devices->devices, dev_list) { | 551 | list_for_each_entry(device, &fs_devices->devices, dev_list) { |
542 | struct btrfs_device *new_device; | 552 | struct btrfs_device *new_device; |
553 | struct rcu_string *name; | ||
543 | 554 | ||
544 | if (device->bdev) | 555 | if (device->bdev) |
545 | fs_devices->open_devices--; | 556 | fs_devices->open_devices--; |
@@ -555,8 +566,11 @@ static int __btrfs_close_devices(struct btrfs_fs_devices *fs_devices) | |||
555 | new_device = kmalloc(sizeof(*new_device), GFP_NOFS); | 566 | new_device = kmalloc(sizeof(*new_device), GFP_NOFS); |
556 | BUG_ON(!new_device); /* -ENOMEM */ | 567 | BUG_ON(!new_device); /* -ENOMEM */ |
557 | memcpy(new_device, device, sizeof(*new_device)); | 568 | memcpy(new_device, device, sizeof(*new_device)); |
558 | new_device->name = kstrdup(device->name, GFP_NOFS); | 569 | |
559 | BUG_ON(device->name && !new_device->name); /* -ENOMEM */ | 570 | /* Safe because we are under uuid_mutex */ |
571 | name = rcu_string_strdup(device->name->str, GFP_NOFS); | ||
572 | BUG_ON(device->name && !name); /* -ENOMEM */ | ||
573 | rcu_assign_pointer(new_device->name, name); | ||
560 | new_device->bdev = NULL; | 574 | new_device->bdev = NULL; |
561 | new_device->writeable = 0; | 575 | new_device->writeable = 0; |
562 | new_device->in_fs_metadata = 0; | 576 | new_device->in_fs_metadata = 0; |
@@ -621,9 +635,9 @@ static int __btrfs_open_devices(struct btrfs_fs_devices *fs_devices, | |||
621 | if (!device->name) | 635 | if (!device->name) |
622 | continue; | 636 | continue; |
623 | 637 | ||
624 | bdev = blkdev_get_by_path(device->name, flags, holder); | 638 | bdev = blkdev_get_by_path(device->name->str, flags, holder); |
625 | if (IS_ERR(bdev)) { | 639 | if (IS_ERR(bdev)) { |
626 | printk(KERN_INFO "open %s failed\n", device->name); | 640 | printk(KERN_INFO "open %s failed\n", device->name->str); |
627 | goto error; | 641 | goto error; |
628 | } | 642 | } |
629 | filemap_write_and_wait(bdev->bd_inode->i_mapping); | 643 | filemap_write_and_wait(bdev->bd_inode->i_mapping); |
@@ -1632,6 +1646,7 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path) | |||
1632 | struct block_device *bdev; | 1646 | struct block_device *bdev; |
1633 | struct list_head *devices; | 1647 | struct list_head *devices; |
1634 | struct super_block *sb = root->fs_info->sb; | 1648 | struct super_block *sb = root->fs_info->sb; |
1649 | struct rcu_string *name; | ||
1635 | u64 total_bytes; | 1650 | u64 total_bytes; |
1636 | int seeding_dev = 0; | 1651 | int seeding_dev = 0; |
1637 | int ret = 0; | 1652 | int ret = 0; |
@@ -1671,23 +1686,24 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path) | |||
1671 | goto error; | 1686 | goto error; |
1672 | } | 1687 | } |
1673 | 1688 | ||
1674 | device->name = kstrdup(device_path, GFP_NOFS); | 1689 | name = rcu_string_strdup(device_path, GFP_NOFS); |
1675 | if (!device->name) { | 1690 | if (!name) { |
1676 | kfree(device); | 1691 | kfree(device); |
1677 | ret = -ENOMEM; | 1692 | ret = -ENOMEM; |
1678 | goto error; | 1693 | goto error; |
1679 | } | 1694 | } |
1695 | rcu_assign_pointer(device->name, name); | ||
1680 | 1696 | ||
1681 | ret = find_next_devid(root, &device->devid); | 1697 | ret = find_next_devid(root, &device->devid); |
1682 | if (ret) { | 1698 | if (ret) { |
1683 | kfree(device->name); | 1699 | rcu_string_free(device->name); |
1684 | kfree(device); | 1700 | kfree(device); |
1685 | goto error; | 1701 | goto error; |
1686 | } | 1702 | } |
1687 | 1703 | ||
1688 | trans = btrfs_start_transaction(root, 0); | 1704 | trans = btrfs_start_transaction(root, 0); |
1689 | if (IS_ERR(trans)) { | 1705 | if (IS_ERR(trans)) { |
1690 | kfree(device->name); | 1706 | rcu_string_free(device->name); |
1691 | kfree(device); | 1707 | kfree(device); |
1692 | ret = PTR_ERR(trans); | 1708 | ret = PTR_ERR(trans); |
1693 | goto error; | 1709 | goto error; |
@@ -1796,7 +1812,7 @@ error_trans: | |||
1796 | unlock_chunks(root); | 1812 | unlock_chunks(root); |
1797 | btrfs_abort_transaction(trans, root, ret); | 1813 | btrfs_abort_transaction(trans, root, ret); |
1798 | btrfs_end_transaction(trans, root); | 1814 | btrfs_end_transaction(trans, root); |
1799 | kfree(device->name); | 1815 | rcu_string_free(device->name); |
1800 | kfree(device); | 1816 | kfree(device); |
1801 | error: | 1817 | error: |
1802 | blkdev_put(bdev, FMODE_EXCL); | 1818 | blkdev_put(bdev, FMODE_EXCL); |
@@ -2829,31 +2845,48 @@ out: | |||
2829 | 2845 | ||
2830 | static int balance_kthread(void *data) | 2846 | static int balance_kthread(void *data) |
2831 | { | 2847 | { |
2832 | struct btrfs_balance_control *bctl = | 2848 | struct btrfs_fs_info *fs_info = data; |
2833 | (struct btrfs_balance_control *)data; | ||
2834 | struct btrfs_fs_info *fs_info = bctl->fs_info; | ||
2835 | int ret = 0; | 2849 | int ret = 0; |
2836 | 2850 | ||
2837 | mutex_lock(&fs_info->volume_mutex); | 2851 | mutex_lock(&fs_info->volume_mutex); |
2838 | mutex_lock(&fs_info->balance_mutex); | 2852 | mutex_lock(&fs_info->balance_mutex); |
2839 | 2853 | ||
2840 | set_balance_control(bctl); | 2854 | if (fs_info->balance_ctl) { |
2841 | |||
2842 | if (btrfs_test_opt(fs_info->tree_root, SKIP_BALANCE)) { | ||
2843 | printk(KERN_INFO "btrfs: force skipping balance\n"); | ||
2844 | } else { | ||
2845 | printk(KERN_INFO "btrfs: continuing balance\n"); | 2855 | printk(KERN_INFO "btrfs: continuing balance\n"); |
2846 | ret = btrfs_balance(bctl, NULL); | 2856 | ret = btrfs_balance(fs_info->balance_ctl, NULL); |
2847 | } | 2857 | } |
2848 | 2858 | ||
2849 | mutex_unlock(&fs_info->balance_mutex); | 2859 | mutex_unlock(&fs_info->balance_mutex); |
2850 | mutex_unlock(&fs_info->volume_mutex); | 2860 | mutex_unlock(&fs_info->volume_mutex); |
2861 | |||
2851 | return ret; | 2862 | return ret; |
2852 | } | 2863 | } |
2853 | 2864 | ||
2854 | int btrfs_recover_balance(struct btrfs_root *tree_root) | 2865 | int btrfs_resume_balance_async(struct btrfs_fs_info *fs_info) |
2855 | { | 2866 | { |
2856 | struct task_struct *tsk; | 2867 | struct task_struct *tsk; |
2868 | |||
2869 | spin_lock(&fs_info->balance_lock); | ||
2870 | if (!fs_info->balance_ctl) { | ||
2871 | spin_unlock(&fs_info->balance_lock); | ||
2872 | return 0; | ||
2873 | } | ||
2874 | spin_unlock(&fs_info->balance_lock); | ||
2875 | |||
2876 | if (btrfs_test_opt(fs_info->tree_root, SKIP_BALANCE)) { | ||
2877 | printk(KERN_INFO "btrfs: force skipping balance\n"); | ||
2878 | return 0; | ||
2879 | } | ||
2880 | |||
2881 | tsk = kthread_run(balance_kthread, fs_info, "btrfs-balance"); | ||
2882 | if (IS_ERR(tsk)) | ||
2883 | return PTR_ERR(tsk); | ||
2884 | |||
2885 | return 0; | ||
2886 | } | ||
2887 | |||
2888 | int btrfs_recover_balance(struct btrfs_fs_info *fs_info) | ||
2889 | { | ||
2857 | struct btrfs_balance_control *bctl; | 2890 | struct btrfs_balance_control *bctl; |
2858 | struct btrfs_balance_item *item; | 2891 | struct btrfs_balance_item *item; |
2859 | struct btrfs_disk_balance_args disk_bargs; | 2892 | struct btrfs_disk_balance_args disk_bargs; |
@@ -2866,29 +2899,30 @@ int btrfs_recover_balance(struct btrfs_root *tree_root) | |||
2866 | if (!path) | 2899 | if (!path) |
2867 | return -ENOMEM; | 2900 | return -ENOMEM; |
2868 | 2901 | ||
2869 | bctl = kzalloc(sizeof(*bctl), GFP_NOFS); | ||
2870 | if (!bctl) { | ||
2871 | ret = -ENOMEM; | ||
2872 | goto out; | ||
2873 | } | ||
2874 | |||
2875 | key.objectid = BTRFS_BALANCE_OBJECTID; | 2902 | key.objectid = BTRFS_BALANCE_OBJECTID; |
2876 | key.type = BTRFS_BALANCE_ITEM_KEY; | 2903 | key.type = BTRFS_BALANCE_ITEM_KEY; |
2877 | key.offset = 0; | 2904 | key.offset = 0; |
2878 | 2905 | ||
2879 | ret = btrfs_search_slot(NULL, tree_root, &key, path, 0, 0); | 2906 | ret = btrfs_search_slot(NULL, fs_info->tree_root, &key, path, 0, 0); |
2880 | if (ret < 0) | 2907 | if (ret < 0) |
2881 | goto out_bctl; | 2908 | goto out; |
2882 | if (ret > 0) { /* ret = -ENOENT; */ | 2909 | if (ret > 0) { /* ret = -ENOENT; */ |
2883 | ret = 0; | 2910 | ret = 0; |
2884 | goto out_bctl; | 2911 | goto out; |
2912 | } | ||
2913 | |||
2914 | bctl = kzalloc(sizeof(*bctl), GFP_NOFS); | ||
2915 | if (!bctl) { | ||
2916 | ret = -ENOMEM; | ||
2917 | goto out; | ||
2885 | } | 2918 | } |
2886 | 2919 | ||
2887 | leaf = path->nodes[0]; | 2920 | leaf = path->nodes[0]; |
2888 | item = btrfs_item_ptr(leaf, path->slots[0], struct btrfs_balance_item); | 2921 | item = btrfs_item_ptr(leaf, path->slots[0], struct btrfs_balance_item); |
2889 | 2922 | ||
2890 | bctl->fs_info = tree_root->fs_info; | 2923 | bctl->fs_info = fs_info; |
2891 | bctl->flags = btrfs_balance_flags(leaf, item) | BTRFS_BALANCE_RESUME; | 2924 | bctl->flags = btrfs_balance_flags(leaf, item); |
2925 | bctl->flags |= BTRFS_BALANCE_RESUME; | ||
2892 | 2926 | ||
2893 | btrfs_balance_data(leaf, item, &disk_bargs); | 2927 | btrfs_balance_data(leaf, item, &disk_bargs); |
2894 | btrfs_disk_balance_args_to_cpu(&bctl->data, &disk_bargs); | 2928 | btrfs_disk_balance_args_to_cpu(&bctl->data, &disk_bargs); |
@@ -2897,14 +2931,13 @@ int btrfs_recover_balance(struct btrfs_root *tree_root) | |||
2897 | btrfs_balance_sys(leaf, item, &disk_bargs); | 2931 | btrfs_balance_sys(leaf, item, &disk_bargs); |
2898 | btrfs_disk_balance_args_to_cpu(&bctl->sys, &disk_bargs); | 2932 | btrfs_disk_balance_args_to_cpu(&bctl->sys, &disk_bargs); |
2899 | 2933 | ||
2900 | tsk = kthread_run(balance_kthread, bctl, "btrfs-balance"); | 2934 | mutex_lock(&fs_info->volume_mutex); |
2901 | if (IS_ERR(tsk)) | 2935 | mutex_lock(&fs_info->balance_mutex); |
2902 | ret = PTR_ERR(tsk); | ||
2903 | else | ||
2904 | goto out; | ||
2905 | 2936 | ||
2906 | out_bctl: | 2937 | set_balance_control(bctl); |
2907 | kfree(bctl); | 2938 | |
2939 | mutex_unlock(&fs_info->balance_mutex); | ||
2940 | mutex_unlock(&fs_info->volume_mutex); | ||
2908 | out: | 2941 | out: |
2909 | btrfs_free_path(path); | 2942 | btrfs_free_path(path); |
2910 | return ret; | 2943 | return ret; |
@@ -4045,16 +4078,18 @@ static void btrfs_end_bio(struct bio *bio, int err) | |||
4045 | 4078 | ||
4046 | BUG_ON(stripe_index >= bbio->num_stripes); | 4079 | BUG_ON(stripe_index >= bbio->num_stripes); |
4047 | dev = bbio->stripes[stripe_index].dev; | 4080 | dev = bbio->stripes[stripe_index].dev; |
4048 | if (bio->bi_rw & WRITE) | 4081 | if (dev->bdev) { |
4049 | btrfs_dev_stat_inc(dev, | 4082 | if (bio->bi_rw & WRITE) |
4050 | BTRFS_DEV_STAT_WRITE_ERRS); | 4083 | btrfs_dev_stat_inc(dev, |
4051 | else | 4084 | BTRFS_DEV_STAT_WRITE_ERRS); |
4052 | btrfs_dev_stat_inc(dev, | 4085 | else |
4053 | BTRFS_DEV_STAT_READ_ERRS); | 4086 | btrfs_dev_stat_inc(dev, |
4054 | if ((bio->bi_rw & WRITE_FLUSH) == WRITE_FLUSH) | 4087 | BTRFS_DEV_STAT_READ_ERRS); |
4055 | btrfs_dev_stat_inc(dev, | 4088 | if ((bio->bi_rw & WRITE_FLUSH) == WRITE_FLUSH) |
4056 | BTRFS_DEV_STAT_FLUSH_ERRS); | 4089 | btrfs_dev_stat_inc(dev, |
4057 | btrfs_dev_stat_print_on_error(dev); | 4090 | BTRFS_DEV_STAT_FLUSH_ERRS); |
4091 | btrfs_dev_stat_print_on_error(dev); | ||
4092 | } | ||
4058 | } | 4093 | } |
4059 | } | 4094 | } |
4060 | 4095 | ||
@@ -4204,10 +4239,17 @@ int btrfs_map_bio(struct btrfs_root *root, int rw, struct bio *bio, | |||
4204 | bio->bi_sector = bbio->stripes[dev_nr].physical >> 9; | 4239 | bio->bi_sector = bbio->stripes[dev_nr].physical >> 9; |
4205 | dev = bbio->stripes[dev_nr].dev; | 4240 | dev = bbio->stripes[dev_nr].dev; |
4206 | if (dev && dev->bdev && (rw != WRITE || dev->writeable)) { | 4241 | if (dev && dev->bdev && (rw != WRITE || dev->writeable)) { |
4242 | #ifdef DEBUG | ||
4243 | struct rcu_string *name; | ||
4244 | |||
4245 | rcu_read_lock(); | ||
4246 | name = rcu_dereference(dev->name); | ||
4207 | pr_debug("btrfs_map_bio: rw %d, secor=%llu, dev=%lu " | 4247 | pr_debug("btrfs_map_bio: rw %d, secor=%llu, dev=%lu " |
4208 | "(%s id %llu), size=%u\n", rw, | 4248 | "(%s id %llu), size=%u\n", rw, |
4209 | (u64)bio->bi_sector, (u_long)dev->bdev->bd_dev, | 4249 | (u64)bio->bi_sector, (u_long)dev->bdev->bd_dev, |
4210 | dev->name, dev->devid, bio->bi_size); | 4250 | name->str, dev->devid, bio->bi_size); |
4251 | rcu_read_unlock(); | ||
4252 | #endif | ||
4211 | bio->bi_bdev = dev->bdev; | 4253 | bio->bi_bdev = dev->bdev; |
4212 | if (async_submit) | 4254 | if (async_submit) |
4213 | schedule_bio(root, dev, rw, bio); | 4255 | schedule_bio(root, dev, rw, bio); |
@@ -4694,8 +4736,9 @@ int btrfs_init_dev_stats(struct btrfs_fs_info *fs_info) | |||
4694 | key.offset = device->devid; | 4736 | key.offset = device->devid; |
4695 | ret = btrfs_search_slot(NULL, dev_root, &key, path, 0, 0); | 4737 | ret = btrfs_search_slot(NULL, dev_root, &key, path, 0, 0); |
4696 | if (ret) { | 4738 | if (ret) { |
4697 | printk(KERN_WARNING "btrfs: no dev_stats entry found for device %s (devid %llu) (OK on first mount after mkfs)\n", | 4739 | printk_in_rcu(KERN_WARNING "btrfs: no dev_stats entry found for device %s (devid %llu) (OK on first mount after mkfs)\n", |
4698 | device->name, (unsigned long long)device->devid); | 4740 | rcu_str_deref(device->name), |
4741 | (unsigned long long)device->devid); | ||
4699 | __btrfs_reset_dev_stats(device); | 4742 | __btrfs_reset_dev_stats(device); |
4700 | device->dev_stats_valid = 1; | 4743 | device->dev_stats_valid = 1; |
4701 | btrfs_release_path(path); | 4744 | btrfs_release_path(path); |
@@ -4747,8 +4790,8 @@ static int update_dev_stat_item(struct btrfs_trans_handle *trans, | |||
4747 | BUG_ON(!path); | 4790 | BUG_ON(!path); |
4748 | ret = btrfs_search_slot(trans, dev_root, &key, path, -1, 1); | 4791 | ret = btrfs_search_slot(trans, dev_root, &key, path, -1, 1); |
4749 | if (ret < 0) { | 4792 | if (ret < 0) { |
4750 | printk(KERN_WARNING "btrfs: error %d while searching for dev_stats item for device %s!\n", | 4793 | printk_in_rcu(KERN_WARNING "btrfs: error %d while searching for dev_stats item for device %s!\n", |
4751 | ret, device->name); | 4794 | ret, rcu_str_deref(device->name)); |
4752 | goto out; | 4795 | goto out; |
4753 | } | 4796 | } |
4754 | 4797 | ||
@@ -4757,8 +4800,8 @@ static int update_dev_stat_item(struct btrfs_trans_handle *trans, | |||
4757 | /* need to delete old one and insert a new one */ | 4800 | /* need to delete old one and insert a new one */ |
4758 | ret = btrfs_del_item(trans, dev_root, path); | 4801 | ret = btrfs_del_item(trans, dev_root, path); |
4759 | if (ret != 0) { | 4802 | if (ret != 0) { |
4760 | printk(KERN_WARNING "btrfs: delete too small dev_stats item for device %s failed %d!\n", | 4803 | printk_in_rcu(KERN_WARNING "btrfs: delete too small dev_stats item for device %s failed %d!\n", |
4761 | device->name, ret); | 4804 | rcu_str_deref(device->name), ret); |
4762 | goto out; | 4805 | goto out; |
4763 | } | 4806 | } |
4764 | ret = 1; | 4807 | ret = 1; |
@@ -4770,8 +4813,8 @@ static int update_dev_stat_item(struct btrfs_trans_handle *trans, | |||
4770 | ret = btrfs_insert_empty_item(trans, dev_root, path, | 4813 | ret = btrfs_insert_empty_item(trans, dev_root, path, |
4771 | &key, sizeof(*ptr)); | 4814 | &key, sizeof(*ptr)); |
4772 | if (ret < 0) { | 4815 | if (ret < 0) { |
4773 | printk(KERN_WARNING "btrfs: insert dev_stats item for device %s failed %d!\n", | 4816 | printk_in_rcu(KERN_WARNING "btrfs: insert dev_stats item for device %s failed %d!\n", |
4774 | device->name, ret); | 4817 | rcu_str_deref(device->name), ret); |
4775 | goto out; | 4818 | goto out; |
4776 | } | 4819 | } |
4777 | } | 4820 | } |
@@ -4823,9 +4866,9 @@ void btrfs_dev_stat_print_on_error(struct btrfs_device *dev) | |||
4823 | { | 4866 | { |
4824 | if (!dev->dev_stats_valid) | 4867 | if (!dev->dev_stats_valid) |
4825 | return; | 4868 | return; |
4826 | printk_ratelimited(KERN_ERR | 4869 | printk_ratelimited_in_rcu(KERN_ERR |
4827 | "btrfs: bdev %s errs: wr %u, rd %u, flush %u, corrupt %u, gen %u\n", | 4870 | "btrfs: bdev %s errs: wr %u, rd %u, flush %u, corrupt %u, gen %u\n", |
4828 | dev->name, | 4871 | rcu_str_deref(dev->name), |
4829 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_WRITE_ERRS), | 4872 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_WRITE_ERRS), |
4830 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_READ_ERRS), | 4873 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_READ_ERRS), |
4831 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_FLUSH_ERRS), | 4874 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_FLUSH_ERRS), |
@@ -4837,8 +4880,8 @@ void btrfs_dev_stat_print_on_error(struct btrfs_device *dev) | |||
4837 | 4880 | ||
4838 | static void btrfs_dev_stat_print_on_load(struct btrfs_device *dev) | 4881 | static void btrfs_dev_stat_print_on_load(struct btrfs_device *dev) |
4839 | { | 4882 | { |
4840 | printk(KERN_INFO "btrfs: bdev %s errs: wr %u, rd %u, flush %u, corrupt %u, gen %u\n", | 4883 | printk_in_rcu(KERN_INFO "btrfs: bdev %s errs: wr %u, rd %u, flush %u, corrupt %u, gen %u\n", |
4841 | dev->name, | 4884 | rcu_str_deref(dev->name), |
4842 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_WRITE_ERRS), | 4885 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_WRITE_ERRS), |
4843 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_READ_ERRS), | 4886 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_READ_ERRS), |
4844 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_FLUSH_ERRS), | 4887 | btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_FLUSH_ERRS), |
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h index 3406a88ca83e..95f6637614db 100644 --- a/fs/btrfs/volumes.h +++ b/fs/btrfs/volumes.h | |||
@@ -58,7 +58,7 @@ struct btrfs_device { | |||
58 | /* the mode sent to blkdev_get */ | 58 | /* the mode sent to blkdev_get */ |
59 | fmode_t mode; | 59 | fmode_t mode; |
60 | 60 | ||
61 | char *name; | 61 | struct rcu_string *name; |
62 | 62 | ||
63 | /* the internal btrfs device id */ | 63 | /* the internal btrfs device id */ |
64 | u64 devid; | 64 | u64 devid; |
@@ -281,7 +281,8 @@ int btrfs_shrink_device(struct btrfs_device *device, u64 new_size); | |||
281 | int btrfs_init_new_device(struct btrfs_root *root, char *path); | 281 | int btrfs_init_new_device(struct btrfs_root *root, char *path); |
282 | int btrfs_balance(struct btrfs_balance_control *bctl, | 282 | int btrfs_balance(struct btrfs_balance_control *bctl, |
283 | struct btrfs_ioctl_balance_args *bargs); | 283 | struct btrfs_ioctl_balance_args *bargs); |
284 | int btrfs_recover_balance(struct btrfs_root *tree_root); | 284 | int btrfs_resume_balance_async(struct btrfs_fs_info *fs_info); |
285 | int btrfs_recover_balance(struct btrfs_fs_info *fs_info); | ||
285 | int btrfs_pause_balance(struct btrfs_fs_info *fs_info); | 286 | int btrfs_pause_balance(struct btrfs_fs_info *fs_info); |
286 | int btrfs_cancel_balance(struct btrfs_fs_info *fs_info); | 287 | int btrfs_cancel_balance(struct btrfs_fs_info *fs_info); |
287 | int btrfs_chunk_readonly(struct btrfs_root *root, u64 chunk_offset); | 288 | int btrfs_chunk_readonly(struct btrfs_root *root, u64 chunk_offset); |
diff --git a/fs/buffer.c b/fs/buffer.c index 838a9cf246bd..c7062c896d7c 100644 --- a/fs/buffer.c +++ b/fs/buffer.c | |||
@@ -1036,6 +1036,9 @@ grow_buffers(struct block_device *bdev, sector_t block, int size) | |||
1036 | static struct buffer_head * | 1036 | static struct buffer_head * |
1037 | __getblk_slow(struct block_device *bdev, sector_t block, int size) | 1037 | __getblk_slow(struct block_device *bdev, sector_t block, int size) |
1038 | { | 1038 | { |
1039 | int ret; | ||
1040 | struct buffer_head *bh; | ||
1041 | |||
1039 | /* Size must be multiple of hard sectorsize */ | 1042 | /* Size must be multiple of hard sectorsize */ |
1040 | if (unlikely(size & (bdev_logical_block_size(bdev)-1) || | 1043 | if (unlikely(size & (bdev_logical_block_size(bdev)-1) || |
1041 | (size < 512 || size > PAGE_SIZE))) { | 1044 | (size < 512 || size > PAGE_SIZE))) { |
@@ -1048,20 +1051,21 @@ __getblk_slow(struct block_device *bdev, sector_t block, int size) | |||
1048 | return NULL; | 1051 | return NULL; |
1049 | } | 1052 | } |
1050 | 1053 | ||
1051 | for (;;) { | 1054 | retry: |
1052 | struct buffer_head * bh; | 1055 | bh = __find_get_block(bdev, block, size); |
1053 | int ret; | 1056 | if (bh) |
1057 | return bh; | ||
1054 | 1058 | ||
1059 | ret = grow_buffers(bdev, block, size); | ||
1060 | if (ret == 0) { | ||
1061 | free_more_memory(); | ||
1062 | goto retry; | ||
1063 | } else if (ret > 0) { | ||
1055 | bh = __find_get_block(bdev, block, size); | 1064 | bh = __find_get_block(bdev, block, size); |
1056 | if (bh) | 1065 | if (bh) |
1057 | return bh; | 1066 | return bh; |
1058 | |||
1059 | ret = grow_buffers(bdev, block, size); | ||
1060 | if (ret < 0) | ||
1061 | return NULL; | ||
1062 | if (ret == 0) | ||
1063 | free_more_memory(); | ||
1064 | } | 1067 | } |
1068 | return NULL; | ||
1065 | } | 1069 | } |
1066 | 1070 | ||
1067 | /* | 1071 | /* |
diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c index 7f0771d3894e..b0b5f7cdfffa 100644 --- a/fs/cachefiles/namei.c +++ b/fs/cachefiles/namei.c | |||
@@ -567,7 +567,7 @@ lookup_again: | |||
567 | if (ret < 0) | 567 | if (ret < 0) |
568 | goto create_error; | 568 | goto create_error; |
569 | start = jiffies; | 569 | start = jiffies; |
570 | ret = vfs_create(dir->d_inode, next, S_IFREG, NULL); | 570 | ret = vfs_create(dir->d_inode, next, S_IFREG, true); |
571 | cachefiles_hist(cachefiles_create_histogram, start); | 571 | cachefiles_hist(cachefiles_create_histogram, start); |
572 | if (ret < 0) | 572 | if (ret < 0) |
573 | goto create_error; | 573 | goto create_error; |
diff --git a/fs/cachefiles/rdwr.c b/fs/cachefiles/rdwr.c index 0e3c0924cc3a..c0353dfac51f 100644 --- a/fs/cachefiles/rdwr.c +++ b/fs/cachefiles/rdwr.c | |||
@@ -891,6 +891,7 @@ int cachefiles_write_page(struct fscache_storage *op, struct page *page) | |||
891 | struct cachefiles_cache *cache; | 891 | struct cachefiles_cache *cache; |
892 | mm_segment_t old_fs; | 892 | mm_segment_t old_fs; |
893 | struct file *file; | 893 | struct file *file; |
894 | struct path path; | ||
894 | loff_t pos, eof; | 895 | loff_t pos, eof; |
895 | size_t len; | 896 | size_t len; |
896 | void *data; | 897 | void *data; |
@@ -916,10 +917,9 @@ int cachefiles_write_page(struct fscache_storage *op, struct page *page) | |||
916 | 917 | ||
917 | /* write the page to the backing filesystem and let it store it in its | 918 | /* write the page to the backing filesystem and let it store it in its |
918 | * own time */ | 919 | * own time */ |
919 | dget(object->backer); | 920 | path.mnt = cache->mnt; |
920 | mntget(cache->mnt); | 921 | path.dentry = object->backer; |
921 | file = dentry_open(object->backer, cache->mnt, O_RDWR, | 922 | file = dentry_open(&path, O_RDWR, cache->cache_cred); |
922 | cache->cache_cred); | ||
923 | if (IS_ERR(file)) { | 923 | if (IS_ERR(file)) { |
924 | ret = PTR_ERR(file); | 924 | ret = PTR_ERR(file); |
925 | } else { | 925 | } else { |
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 173b1d22e59b..8b67304e4b80 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c | |||
@@ -54,7 +54,12 @@ | |||
54 | (CONGESTION_ON_THRESH(congestion_kb) - \ | 54 | (CONGESTION_ON_THRESH(congestion_kb) - \ |
55 | (CONGESTION_ON_THRESH(congestion_kb) >> 2)) | 55 | (CONGESTION_ON_THRESH(congestion_kb) >> 2)) |
56 | 56 | ||
57 | 57 | static inline struct ceph_snap_context *page_snap_context(struct page *page) | |
58 | { | ||
59 | if (PagePrivate(page)) | ||
60 | return (void *)page->private; | ||
61 | return NULL; | ||
62 | } | ||
58 | 63 | ||
59 | /* | 64 | /* |
60 | * Dirty a page. Optimistically adjust accounting, on the assumption | 65 | * Dirty a page. Optimistically adjust accounting, on the assumption |
@@ -142,10 +147,9 @@ static void ceph_invalidatepage(struct page *page, unsigned long offset) | |||
142 | { | 147 | { |
143 | struct inode *inode; | 148 | struct inode *inode; |
144 | struct ceph_inode_info *ci; | 149 | struct ceph_inode_info *ci; |
145 | struct ceph_snap_context *snapc = (void *)page->private; | 150 | struct ceph_snap_context *snapc = page_snap_context(page); |
146 | 151 | ||
147 | BUG_ON(!PageLocked(page)); | 152 | BUG_ON(!PageLocked(page)); |
148 | BUG_ON(!page->private); | ||
149 | BUG_ON(!PagePrivate(page)); | 153 | BUG_ON(!PagePrivate(page)); |
150 | BUG_ON(!page->mapping); | 154 | BUG_ON(!page->mapping); |
151 | 155 | ||
@@ -182,7 +186,6 @@ static int ceph_releasepage(struct page *page, gfp_t g) | |||
182 | struct inode *inode = page->mapping ? page->mapping->host : NULL; | 186 | struct inode *inode = page->mapping ? page->mapping->host : NULL; |
183 | dout("%p releasepage %p idx %lu\n", inode, page, page->index); | 187 | dout("%p releasepage %p idx %lu\n", inode, page, page->index); |
184 | WARN_ON(PageDirty(page)); | 188 | WARN_ON(PageDirty(page)); |
185 | WARN_ON(page->private); | ||
186 | WARN_ON(PagePrivate(page)); | 189 | WARN_ON(PagePrivate(page)); |
187 | return 0; | 190 | return 0; |
188 | } | 191 | } |
@@ -443,7 +446,7 @@ static int writepage_nounlock(struct page *page, struct writeback_control *wbc) | |||
443 | osdc = &fsc->client->osdc; | 446 | osdc = &fsc->client->osdc; |
444 | 447 | ||
445 | /* verify this is a writeable snap context */ | 448 | /* verify this is a writeable snap context */ |
446 | snapc = (void *)page->private; | 449 | snapc = page_snap_context(page); |
447 | if (snapc == NULL) { | 450 | if (snapc == NULL) { |
448 | dout("writepage %p page %p not dirty?\n", inode, page); | 451 | dout("writepage %p page %p not dirty?\n", inode, page); |
449 | goto out; | 452 | goto out; |
@@ -451,7 +454,7 @@ static int writepage_nounlock(struct page *page, struct writeback_control *wbc) | |||
451 | oldest = get_oldest_context(inode, &snap_size); | 454 | oldest = get_oldest_context(inode, &snap_size); |
452 | if (snapc->seq > oldest->seq) { | 455 | if (snapc->seq > oldest->seq) { |
453 | dout("writepage %p page %p snapc %p not writeable - noop\n", | 456 | dout("writepage %p page %p snapc %p not writeable - noop\n", |
454 | inode, page, (void *)page->private); | 457 | inode, page, snapc); |
455 | /* we should only noop if called by kswapd */ | 458 | /* we should only noop if called by kswapd */ |
456 | WARN_ON((current->flags & PF_MEMALLOC) == 0); | 459 | WARN_ON((current->flags & PF_MEMALLOC) == 0); |
457 | ceph_put_snap_context(oldest); | 460 | ceph_put_snap_context(oldest); |
@@ -591,7 +594,7 @@ static void writepages_finish(struct ceph_osd_request *req, | |||
591 | clear_bdi_congested(&fsc->backing_dev_info, | 594 | clear_bdi_congested(&fsc->backing_dev_info, |
592 | BLK_RW_ASYNC); | 595 | BLK_RW_ASYNC); |
593 | 596 | ||
594 | ceph_put_snap_context((void *)page->private); | 597 | ceph_put_snap_context(page_snap_context(page)); |
595 | page->private = 0; | 598 | page->private = 0; |
596 | ClearPagePrivate(page); | 599 | ClearPagePrivate(page); |
597 | dout("unlocking %d %p\n", i, page); | 600 | dout("unlocking %d %p\n", i, page); |
@@ -795,7 +798,7 @@ get_more_pages: | |||
795 | } | 798 | } |
796 | 799 | ||
797 | /* only if matching snap context */ | 800 | /* only if matching snap context */ |
798 | pgsnapc = (void *)page->private; | 801 | pgsnapc = page_snap_context(page); |
799 | if (pgsnapc->seq > snapc->seq) { | 802 | if (pgsnapc->seq > snapc->seq) { |
800 | dout("page snapc %p %lld > oldest %p %lld\n", | 803 | dout("page snapc %p %lld > oldest %p %lld\n", |
801 | pgsnapc, pgsnapc->seq, snapc, snapc->seq); | 804 | pgsnapc, pgsnapc->seq, snapc, snapc->seq); |
@@ -984,7 +987,7 @@ retry_locked: | |||
984 | BUG_ON(!ci->i_snap_realm); | 987 | BUG_ON(!ci->i_snap_realm); |
985 | down_read(&mdsc->snap_rwsem); | 988 | down_read(&mdsc->snap_rwsem); |
986 | BUG_ON(!ci->i_snap_realm->cached_context); | 989 | BUG_ON(!ci->i_snap_realm->cached_context); |
987 | snapc = (void *)page->private; | 990 | snapc = page_snap_context(page); |
988 | if (snapc && snapc != ci->i_head_snapc) { | 991 | if (snapc && snapc != ci->i_head_snapc) { |
989 | /* | 992 | /* |
990 | * this page is already dirty in another (older) snap | 993 | * this page is already dirty in another (older) snap |
diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index 3e8094be4604..00894ff9246c 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c | |||
@@ -576,7 +576,7 @@ static int is_root_ceph_dentry(struct inode *inode, struct dentry *dentry) | |||
576 | * the MDS so that it gets our 'caps wanted' value in a single op. | 576 | * the MDS so that it gets our 'caps wanted' value in a single op. |
577 | */ | 577 | */ |
578 | static struct dentry *ceph_lookup(struct inode *dir, struct dentry *dentry, | 578 | static struct dentry *ceph_lookup(struct inode *dir, struct dentry *dentry, |
579 | struct nameidata *nd) | 579 | unsigned int flags) |
580 | { | 580 | { |
581 | struct ceph_fs_client *fsc = ceph_sb_to_client(dir->i_sb); | 581 | struct ceph_fs_client *fsc = ceph_sb_to_client(dir->i_sb); |
582 | struct ceph_mds_client *mdsc = fsc->mdsc; | 582 | struct ceph_mds_client *mdsc = fsc->mdsc; |
@@ -594,14 +594,6 @@ static struct dentry *ceph_lookup(struct inode *dir, struct dentry *dentry, | |||
594 | if (err < 0) | 594 | if (err < 0) |
595 | return ERR_PTR(err); | 595 | return ERR_PTR(err); |
596 | 596 | ||
597 | /* open (but not create!) intent? */ | ||
598 | if (nd && | ||
599 | (nd->flags & LOOKUP_OPEN) && | ||
600 | !(nd->intent.open.flags & O_CREAT)) { | ||
601 | int mode = nd->intent.open.create_mode & ~current->fs->umask; | ||
602 | return ceph_lookup_open(dir, dentry, nd, mode, 1); | ||
603 | } | ||
604 | |||
605 | /* can we conclude ENOENT locally? */ | 597 | /* can we conclude ENOENT locally? */ |
606 | if (dentry->d_inode == NULL) { | 598 | if (dentry->d_inode == NULL) { |
607 | struct ceph_inode_info *ci = ceph_inode(dir); | 599 | struct ceph_inode_info *ci = ceph_inode(dir); |
@@ -642,13 +634,51 @@ static struct dentry *ceph_lookup(struct inode *dir, struct dentry *dentry, | |||
642 | return dentry; | 634 | return dentry; |
643 | } | 635 | } |
644 | 636 | ||
637 | int ceph_atomic_open(struct inode *dir, struct dentry *dentry, | ||
638 | struct file *file, unsigned flags, umode_t mode, | ||
639 | int *opened) | ||
640 | { | ||
641 | int err; | ||
642 | struct dentry *res = NULL; | ||
643 | |||
644 | if (!(flags & O_CREAT)) { | ||
645 | if (dentry->d_name.len > NAME_MAX) | ||
646 | return -ENAMETOOLONG; | ||
647 | |||
648 | err = ceph_init_dentry(dentry); | ||
649 | if (err < 0) | ||
650 | return err; | ||
651 | |||
652 | return ceph_lookup_open(dir, dentry, file, flags, mode, opened); | ||
653 | } | ||
654 | |||
655 | if (d_unhashed(dentry)) { | ||
656 | res = ceph_lookup(dir, dentry, 0); | ||
657 | if (IS_ERR(res)) | ||
658 | return PTR_ERR(res); | ||
659 | |||
660 | if (res) | ||
661 | dentry = res; | ||
662 | } | ||
663 | |||
664 | /* We don't deal with positive dentries here */ | ||
665 | if (dentry->d_inode) | ||
666 | return finish_no_open(file, res); | ||
667 | |||
668 | *opened |= FILE_CREATED; | ||
669 | err = ceph_lookup_open(dir, dentry, file, flags, mode, opened); | ||
670 | dput(res); | ||
671 | |||
672 | return err; | ||
673 | } | ||
674 | |||
645 | /* | 675 | /* |
646 | * If we do a create but get no trace back from the MDS, follow up with | 676 | * If we do a create but get no trace back from the MDS, follow up with |
647 | * a lookup (the VFS expects us to link up the provided dentry). | 677 | * a lookup (the VFS expects us to link up the provided dentry). |
648 | */ | 678 | */ |
649 | int ceph_handle_notrace_create(struct inode *dir, struct dentry *dentry) | 679 | int ceph_handle_notrace_create(struct inode *dir, struct dentry *dentry) |
650 | { | 680 | { |
651 | struct dentry *result = ceph_lookup(dir, dentry, NULL); | 681 | struct dentry *result = ceph_lookup(dir, dentry, 0); |
652 | 682 | ||
653 | if (result && !IS_ERR(result)) { | 683 | if (result && !IS_ERR(result)) { |
654 | /* | 684 | /* |
@@ -700,25 +730,9 @@ static int ceph_mknod(struct inode *dir, struct dentry *dentry, | |||
700 | } | 730 | } |
701 | 731 | ||
702 | static int ceph_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 732 | static int ceph_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
703 | struct nameidata *nd) | 733 | bool excl) |
704 | { | 734 | { |
705 | dout("create in dir %p dentry %p name '%.*s'\n", | 735 | return ceph_mknod(dir, dentry, mode, 0); |
706 | dir, dentry, dentry->d_name.len, dentry->d_name.name); | ||
707 | |||
708 | if (ceph_snap(dir) != CEPH_NOSNAP) | ||
709 | return -EROFS; | ||
710 | |||
711 | if (nd) { | ||
712 | BUG_ON((nd->flags & LOOKUP_OPEN) == 0); | ||
713 | dentry = ceph_lookup_open(dir, dentry, nd, mode, 0); | ||
714 | /* hrm, what should i do here if we get aliased? */ | ||
715 | if (IS_ERR(dentry)) | ||
716 | return PTR_ERR(dentry); | ||
717 | return 0; | ||
718 | } | ||
719 | |||
720 | /* fall back to mknod */ | ||
721 | return ceph_mknod(dir, dentry, (mode & ~S_IFMT) | S_IFREG, 0); | ||
722 | } | 736 | } |
723 | 737 | ||
724 | static int ceph_symlink(struct inode *dir, struct dentry *dentry, | 738 | static int ceph_symlink(struct inode *dir, struct dentry *dentry, |
@@ -1028,12 +1042,12 @@ static int dir_lease_is_valid(struct inode *dir, struct dentry *dentry) | |||
1028 | /* | 1042 | /* |
1029 | * Check if cached dentry can be trusted. | 1043 | * Check if cached dentry can be trusted. |
1030 | */ | 1044 | */ |
1031 | static int ceph_d_revalidate(struct dentry *dentry, struct nameidata *nd) | 1045 | static int ceph_d_revalidate(struct dentry *dentry, unsigned int flags) |
1032 | { | 1046 | { |
1033 | int valid = 0; | 1047 | int valid = 0; |
1034 | struct inode *dir; | 1048 | struct inode *dir; |
1035 | 1049 | ||
1036 | if (nd && nd->flags & LOOKUP_RCU) | 1050 | if (flags & LOOKUP_RCU) |
1037 | return -ECHILD; | 1051 | return -ECHILD; |
1038 | 1052 | ||
1039 | dout("d_revalidate %p '%.*s' inode %p offset %lld\n", dentry, | 1053 | dout("d_revalidate %p '%.*s' inode %p offset %lld\n", dentry, |
@@ -1080,7 +1094,7 @@ static void ceph_d_release(struct dentry *dentry) | |||
1080 | } | 1094 | } |
1081 | 1095 | ||
1082 | static int ceph_snapdir_d_revalidate(struct dentry *dentry, | 1096 | static int ceph_snapdir_d_revalidate(struct dentry *dentry, |
1083 | struct nameidata *nd) | 1097 | unsigned int flags) |
1084 | { | 1098 | { |
1085 | /* | 1099 | /* |
1086 | * Eventually, we'll want to revalidate snapped metadata | 1100 | * Eventually, we'll want to revalidate snapped metadata |
@@ -1357,6 +1371,7 @@ const struct inode_operations ceph_dir_iops = { | |||
1357 | .rmdir = ceph_unlink, | 1371 | .rmdir = ceph_unlink, |
1358 | .rename = ceph_rename, | 1372 | .rename = ceph_rename, |
1359 | .create = ceph_create, | 1373 | .create = ceph_create, |
1374 | .atomic_open = ceph_atomic_open, | ||
1360 | }; | 1375 | }; |
1361 | 1376 | ||
1362 | const struct dentry_operations ceph_dentry_ops = { | 1377 | const struct dentry_operations ceph_dentry_ops = { |
diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 988d4f302e48..1b81d6c31878 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c | |||
@@ -213,22 +213,15 @@ out: | |||
213 | * may_open() fails, the struct *file gets cleaned up (i.e. | 213 | * may_open() fails, the struct *file gets cleaned up (i.e. |
214 | * ceph_release gets called). So fear not! | 214 | * ceph_release gets called). So fear not! |
215 | */ | 215 | */ |
216 | /* | 216 | int ceph_lookup_open(struct inode *dir, struct dentry *dentry, |
217 | * flags | 217 | struct file *file, unsigned flags, umode_t mode, |
218 | * path_lookup_open -> LOOKUP_OPEN | 218 | int *opened) |
219 | * path_lookup_create -> LOOKUP_OPEN|LOOKUP_CREATE | ||
220 | */ | ||
221 | struct dentry *ceph_lookup_open(struct inode *dir, struct dentry *dentry, | ||
222 | struct nameidata *nd, int mode, | ||
223 | int locked_dir) | ||
224 | { | 219 | { |
225 | struct ceph_fs_client *fsc = ceph_sb_to_client(dir->i_sb); | 220 | struct ceph_fs_client *fsc = ceph_sb_to_client(dir->i_sb); |
226 | struct ceph_mds_client *mdsc = fsc->mdsc; | 221 | struct ceph_mds_client *mdsc = fsc->mdsc; |
227 | struct file *file; | ||
228 | struct ceph_mds_request *req; | 222 | struct ceph_mds_request *req; |
229 | struct dentry *ret; | 223 | struct dentry *ret; |
230 | int err; | 224 | int err; |
231 | int flags = nd->intent.open.flags; | ||
232 | 225 | ||
233 | dout("ceph_lookup_open dentry %p '%.*s' flags %d mode 0%o\n", | 226 | dout("ceph_lookup_open dentry %p '%.*s' flags %d mode 0%o\n", |
234 | dentry, dentry->d_name.len, dentry->d_name.name, flags, mode); | 227 | dentry, dentry->d_name.len, dentry->d_name.name, flags, mode); |
@@ -236,7 +229,7 @@ struct dentry *ceph_lookup_open(struct inode *dir, struct dentry *dentry, | |||
236 | /* do the open */ | 229 | /* do the open */ |
237 | req = prepare_open_request(dir->i_sb, flags, mode); | 230 | req = prepare_open_request(dir->i_sb, flags, mode); |
238 | if (IS_ERR(req)) | 231 | if (IS_ERR(req)) |
239 | return ERR_CAST(req); | 232 | return PTR_ERR(req); |
240 | req->r_dentry = dget(dentry); | 233 | req->r_dentry = dget(dentry); |
241 | req->r_num_caps = 2; | 234 | req->r_num_caps = 2; |
242 | if (flags & O_CREAT) { | 235 | if (flags & O_CREAT) { |
@@ -254,14 +247,17 @@ struct dentry *ceph_lookup_open(struct inode *dir, struct dentry *dentry, | |||
254 | err = ceph_handle_notrace_create(dir, dentry); | 247 | err = ceph_handle_notrace_create(dir, dentry); |
255 | if (err) | 248 | if (err) |
256 | goto out; | 249 | goto out; |
257 | file = lookup_instantiate_filp(nd, req->r_dentry, ceph_open); | 250 | err = finish_open(file, req->r_dentry, ceph_open, opened); |
258 | if (IS_ERR(file)) | ||
259 | err = PTR_ERR(file); | ||
260 | out: | 251 | out: |
261 | ret = ceph_finish_lookup(req, dentry, err); | 252 | ret = ceph_finish_lookup(req, dentry, err); |
262 | ceph_mdsc_put_request(req); | 253 | ceph_mdsc_put_request(req); |
263 | dout("ceph_lookup_open result=%p\n", ret); | 254 | dout("ceph_lookup_open result=%p\n", ret); |
264 | return ret; | 255 | |
256 | if (IS_ERR(ret)) | ||
257 | return PTR_ERR(ret); | ||
258 | |||
259 | dput(ret); | ||
260 | return err; | ||
265 | } | 261 | } |
266 | 262 | ||
267 | int ceph_release(struct inode *inode, struct file *file) | 263 | int ceph_release(struct inode *inode, struct file *file) |
diff --git a/fs/ceph/super.c b/fs/ceph/super.c index 1e67dd7305a4..7076109f014d 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c | |||
@@ -871,7 +871,7 @@ static struct dentry *ceph_mount(struct file_system_type *fs_type, | |||
871 | 871 | ||
872 | if (ceph_test_opt(fsc->client, NOSHARE)) | 872 | if (ceph_test_opt(fsc->client, NOSHARE)) |
873 | compare_super = NULL; | 873 | compare_super = NULL; |
874 | sb = sget(fs_type, compare_super, ceph_set_super, fsc); | 874 | sb = sget(fs_type, compare_super, ceph_set_super, flags, fsc); |
875 | if (IS_ERR(sb)) { | 875 | if (IS_ERR(sb)) { |
876 | res = ERR_CAST(sb); | 876 | res = ERR_CAST(sb); |
877 | goto out; | 877 | goto out; |
diff --git a/fs/ceph/super.h b/fs/ceph/super.h index fc35036d258d..f4d5522cb619 100644 --- a/fs/ceph/super.h +++ b/fs/ceph/super.h | |||
@@ -806,9 +806,9 @@ extern int ceph_copy_from_page_vector(struct page **pages, | |||
806 | loff_t off, size_t len); | 806 | loff_t off, size_t len); |
807 | extern struct page **ceph_alloc_page_vector(int num_pages, gfp_t flags); | 807 | extern struct page **ceph_alloc_page_vector(int num_pages, gfp_t flags); |
808 | extern int ceph_open(struct inode *inode, struct file *file); | 808 | extern int ceph_open(struct inode *inode, struct file *file); |
809 | extern struct dentry *ceph_lookup_open(struct inode *dir, struct dentry *dentry, | 809 | extern int ceph_lookup_open(struct inode *dir, struct dentry *dentry, |
810 | struct nameidata *nd, int mode, | 810 | struct file *od, unsigned flags, |
811 | int locked_dir); | 811 | umode_t mode, int *opened); |
812 | extern int ceph_release(struct inode *inode, struct file *filp); | 812 | extern int ceph_release(struct inode *inode, struct file *filp); |
813 | 813 | ||
814 | /* dir.c */ | 814 | /* dir.c */ |
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 8b6e344eb0ba..a7610cfedf0a 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c | |||
@@ -257,7 +257,6 @@ cifs_alloc_inode(struct super_block *sb) | |||
257 | static void cifs_i_callback(struct rcu_head *head) | 257 | static void cifs_i_callback(struct rcu_head *head) |
258 | { | 258 | { |
259 | struct inode *inode = container_of(head, struct inode, i_rcu); | 259 | struct inode *inode = container_of(head, struct inode, i_rcu); |
260 | INIT_LIST_HEAD(&inode->i_dentry); | ||
261 | kmem_cache_free(cifs_inode_cachep, CIFS_I(inode)); | 260 | kmem_cache_free(cifs_inode_cachep, CIFS_I(inode)); |
262 | } | 261 | } |
263 | 262 | ||
@@ -638,7 +637,10 @@ cifs_do_mount(struct file_system_type *fs_type, | |||
638 | mnt_data.cifs_sb = cifs_sb; | 637 | mnt_data.cifs_sb = cifs_sb; |
639 | mnt_data.flags = flags; | 638 | mnt_data.flags = flags; |
640 | 639 | ||
641 | sb = sget(fs_type, cifs_match_super, cifs_set_super, &mnt_data); | 640 | /* BB should we make this contingent on mount parm? */ |
641 | flags |= MS_NODIRATIME | MS_NOATIME; | ||
642 | |||
643 | sb = sget(fs_type, cifs_match_super, cifs_set_super, flags, &mnt_data); | ||
642 | if (IS_ERR(sb)) { | 644 | if (IS_ERR(sb)) { |
643 | root = ERR_CAST(sb); | 645 | root = ERR_CAST(sb); |
644 | cifs_umount(cifs_sb); | 646 | cifs_umount(cifs_sb); |
@@ -649,10 +651,6 @@ cifs_do_mount(struct file_system_type *fs_type, | |||
649 | cFYI(1, "Use existing superblock"); | 651 | cFYI(1, "Use existing superblock"); |
650 | cifs_umount(cifs_sb); | 652 | cifs_umount(cifs_sb); |
651 | } else { | 653 | } else { |
652 | sb->s_flags = flags; | ||
653 | /* BB should we make this contingent on mount parm? */ | ||
654 | sb->s_flags |= MS_NODIRATIME | MS_NOATIME; | ||
655 | |||
656 | rc = cifs_read_super(sb); | 654 | rc = cifs_read_super(sb); |
657 | if (rc) { | 655 | if (rc) { |
658 | root = ERR_PTR(rc); | 656 | root = ERR_PTR(rc); |
@@ -778,6 +776,7 @@ struct file_system_type cifs_fs_type = { | |||
778 | }; | 776 | }; |
779 | const struct inode_operations cifs_dir_inode_ops = { | 777 | const struct inode_operations cifs_dir_inode_ops = { |
780 | .create = cifs_create, | 778 | .create = cifs_create, |
779 | .atomic_open = cifs_atomic_open, | ||
781 | .lookup = cifs_lookup, | 780 | .lookup = cifs_lookup, |
782 | .getattr = cifs_getattr, | 781 | .getattr = cifs_getattr, |
783 | .unlink = cifs_unlink, | 782 | .unlink = cifs_unlink, |
diff --git a/fs/cifs/cifsfs.h b/fs/cifs/cifsfs.h index 65365358c976..1c49c5a9b27a 100644 --- a/fs/cifs/cifsfs.h +++ b/fs/cifs/cifsfs.h | |||
@@ -45,9 +45,12 @@ extern const struct address_space_operations cifs_addr_ops_smallbuf; | |||
45 | extern const struct inode_operations cifs_dir_inode_ops; | 45 | extern const struct inode_operations cifs_dir_inode_ops; |
46 | extern struct inode *cifs_root_iget(struct super_block *); | 46 | extern struct inode *cifs_root_iget(struct super_block *); |
47 | extern int cifs_create(struct inode *, struct dentry *, umode_t, | 47 | extern int cifs_create(struct inode *, struct dentry *, umode_t, |
48 | struct nameidata *); | 48 | bool excl); |
49 | extern int cifs_atomic_open(struct inode *, struct dentry *, | ||
50 | struct file *, unsigned, umode_t, | ||
51 | int *); | ||
49 | extern struct dentry *cifs_lookup(struct inode *, struct dentry *, | 52 | extern struct dentry *cifs_lookup(struct inode *, struct dentry *, |
50 | struct nameidata *); | 53 | unsigned int); |
51 | extern int cifs_unlink(struct inode *dir, struct dentry *dentry); | 54 | extern int cifs_unlink(struct inode *dir, struct dentry *dentry); |
52 | extern int cifs_hardlink(struct dentry *, struct inode *, struct dentry *); | 55 | extern int cifs_hardlink(struct dentry *, struct inode *, struct dentry *); |
53 | extern int cifs_mknod(struct inode *, struct dentry *, umode_t, dev_t); | 56 | extern int cifs_mknod(struct inode *, struct dentry *, umode_t, dev_t); |
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 5b400730c213..4ee522b3f66f 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c | |||
@@ -86,7 +86,31 @@ static struct { | |||
86 | #endif /* CONFIG_CIFS_WEAK_PW_HASH */ | 86 | #endif /* CONFIG_CIFS_WEAK_PW_HASH */ |
87 | #endif /* CIFS_POSIX */ | 87 | #endif /* CIFS_POSIX */ |
88 | 88 | ||
89 | /* Forward declarations */ | 89 | #ifdef CONFIG_HIGHMEM |
90 | /* | ||
91 | * On arches that have high memory, kmap address space is limited. By | ||
92 | * serializing the kmap operations on those arches, we ensure that we don't | ||
93 | * end up with a bunch of threads in writeback with partially mapped page | ||
94 | * arrays, stuck waiting for kmap to come back. That situation prevents | ||
95 | * progress and can deadlock. | ||
96 | */ | ||
97 | static DEFINE_MUTEX(cifs_kmap_mutex); | ||
98 | |||
99 | static inline void | ||
100 | cifs_kmap_lock(void) | ||
101 | { | ||
102 | mutex_lock(&cifs_kmap_mutex); | ||
103 | } | ||
104 | |||
105 | static inline void | ||
106 | cifs_kmap_unlock(void) | ||
107 | { | ||
108 | mutex_unlock(&cifs_kmap_mutex); | ||
109 | } | ||
110 | #else /* !CONFIG_HIGHMEM */ | ||
111 | #define cifs_kmap_lock() do { ; } while(0) | ||
112 | #define cifs_kmap_unlock() do { ; } while(0) | ||
113 | #endif /* CONFIG_HIGHMEM */ | ||
90 | 114 | ||
91 | /* Mark as invalid, all open files on tree connections since they | 115 | /* Mark as invalid, all open files on tree connections since they |
92 | were closed when session to server was lost */ | 116 | were closed when session to server was lost */ |
@@ -1503,7 +1527,9 @@ cifs_readv_receive(struct TCP_Server_Info *server, struct mid_q_entry *mid) | |||
1503 | } | 1527 | } |
1504 | 1528 | ||
1505 | /* marshal up the page array */ | 1529 | /* marshal up the page array */ |
1530 | cifs_kmap_lock(); | ||
1506 | len = rdata->marshal_iov(rdata, data_len); | 1531 | len = rdata->marshal_iov(rdata, data_len); |
1532 | cifs_kmap_unlock(); | ||
1507 | data_len -= len; | 1533 | data_len -= len; |
1508 | 1534 | ||
1509 | /* issue the read if we have any iovecs left to fill */ | 1535 | /* issue the read if we have any iovecs left to fill */ |
@@ -2069,7 +2095,9 @@ cifs_async_writev(struct cifs_writedata *wdata) | |||
2069 | * and set the iov_len properly for each one. It may also set | 2095 | * and set the iov_len properly for each one. It may also set |
2070 | * wdata->bytes too. | 2096 | * wdata->bytes too. |
2071 | */ | 2097 | */ |
2098 | cifs_kmap_lock(); | ||
2072 | wdata->marshal_iov(iov, wdata); | 2099 | wdata->marshal_iov(iov, wdata); |
2100 | cifs_kmap_unlock(); | ||
2073 | 2101 | ||
2074 | cFYI(1, "async write at %llu %u bytes", wdata->offset, wdata->bytes); | 2102 | cFYI(1, "async write at %llu %u bytes", wdata->offset, wdata->bytes); |
2075 | 2103 | ||
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 78db68a5cf44..94b7788c3189 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c | |||
@@ -1653,24 +1653,26 @@ cifs_parse_mount_options(const char *mountdata, const char *devname, | |||
1653 | * If yes, we have encountered a double deliminator | 1653 | * If yes, we have encountered a double deliminator |
1654 | * reset the NULL character to the deliminator | 1654 | * reset the NULL character to the deliminator |
1655 | */ | 1655 | */ |
1656 | if (tmp_end < end && tmp_end[1] == delim) | 1656 | if (tmp_end < end && tmp_end[1] == delim) { |
1657 | tmp_end[0] = delim; | 1657 | tmp_end[0] = delim; |
1658 | 1658 | ||
1659 | /* Keep iterating until we get to a single deliminator | 1659 | /* Keep iterating until we get to a single |
1660 | * OR the end | 1660 | * deliminator OR the end |
1661 | */ | 1661 | */ |
1662 | while ((tmp_end = strchr(tmp_end, delim)) != NULL && | 1662 | while ((tmp_end = strchr(tmp_end, delim)) |
1663 | (tmp_end[1] == delim)) { | 1663 | != NULL && (tmp_end[1] == delim)) { |
1664 | tmp_end = (char *) &tmp_end[2]; | 1664 | tmp_end = (char *) &tmp_end[2]; |
1665 | } | 1665 | } |
1666 | 1666 | ||
1667 | /* Reset var options to point to next element */ | 1667 | /* Reset var options to point to next element */ |
1668 | if (tmp_end) { | 1668 | if (tmp_end) { |
1669 | tmp_end[0] = '\0'; | 1669 | tmp_end[0] = '\0'; |
1670 | options = (char *) &tmp_end[1]; | 1670 | options = (char *) &tmp_end[1]; |
1671 | } else | 1671 | } else |
1672 | /* Reached the end of the mount option string */ | 1672 | /* Reached the end of the mount option |
1673 | options = end; | 1673 | * string */ |
1674 | options = end; | ||
1675 | } | ||
1674 | 1676 | ||
1675 | /* Now build new password string */ | 1677 | /* Now build new password string */ |
1676 | temp_len = strlen(value); | 1678 | temp_len = strlen(value); |
@@ -3443,6 +3445,18 @@ void cifs_setup_cifs_sb(struct smb_vol *pvolume_info, | |||
3443 | #define CIFS_DEFAULT_NON_POSIX_RSIZE (60 * 1024) | 3445 | #define CIFS_DEFAULT_NON_POSIX_RSIZE (60 * 1024) |
3444 | #define CIFS_DEFAULT_NON_POSIX_WSIZE (65536) | 3446 | #define CIFS_DEFAULT_NON_POSIX_WSIZE (65536) |
3445 | 3447 | ||
3448 | /* | ||
3449 | * On hosts with high memory, we can't currently support wsize/rsize that are | ||
3450 | * larger than we can kmap at once. Cap the rsize/wsize at | ||
3451 | * LAST_PKMAP * PAGE_SIZE. We'll never be able to fill a read or write request | ||
3452 | * larger than that anyway. | ||
3453 | */ | ||
3454 | #ifdef CONFIG_HIGHMEM | ||
3455 | #define CIFS_KMAP_SIZE_LIMIT (LAST_PKMAP * PAGE_CACHE_SIZE) | ||
3456 | #else /* CONFIG_HIGHMEM */ | ||
3457 | #define CIFS_KMAP_SIZE_LIMIT (1<<24) | ||
3458 | #endif /* CONFIG_HIGHMEM */ | ||
3459 | |||
3446 | static unsigned int | 3460 | static unsigned int |
3447 | cifs_negotiate_wsize(struct cifs_tcon *tcon, struct smb_vol *pvolume_info) | 3461 | cifs_negotiate_wsize(struct cifs_tcon *tcon, struct smb_vol *pvolume_info) |
3448 | { | 3462 | { |
@@ -3473,6 +3487,9 @@ cifs_negotiate_wsize(struct cifs_tcon *tcon, struct smb_vol *pvolume_info) | |||
3473 | wsize = min_t(unsigned int, wsize, | 3487 | wsize = min_t(unsigned int, wsize, |
3474 | server->maxBuf - sizeof(WRITE_REQ) + 4); | 3488 | server->maxBuf - sizeof(WRITE_REQ) + 4); |
3475 | 3489 | ||
3490 | /* limit to the amount that we can kmap at once */ | ||
3491 | wsize = min_t(unsigned int, wsize, CIFS_KMAP_SIZE_LIMIT); | ||
3492 | |||
3476 | /* hard limit of CIFS_MAX_WSIZE */ | 3493 | /* hard limit of CIFS_MAX_WSIZE */ |
3477 | wsize = min_t(unsigned int, wsize, CIFS_MAX_WSIZE); | 3494 | wsize = min_t(unsigned int, wsize, CIFS_MAX_WSIZE); |
3478 | 3495 | ||
@@ -3493,18 +3510,15 @@ cifs_negotiate_rsize(struct cifs_tcon *tcon, struct smb_vol *pvolume_info) | |||
3493 | * MS-CIFS indicates that servers are only limited by the client's | 3510 | * MS-CIFS indicates that servers are only limited by the client's |
3494 | * bufsize for reads, testing against win98se shows that it throws | 3511 | * bufsize for reads, testing against win98se shows that it throws |
3495 | * INVALID_PARAMETER errors if you try to request too large a read. | 3512 | * INVALID_PARAMETER errors if you try to request too large a read. |
3513 | * OS/2 just sends back short reads. | ||
3496 | * | 3514 | * |
3497 | * If the server advertises a MaxBufferSize of less than one page, | 3515 | * If the server doesn't advertise CAP_LARGE_READ_X, then assume that |
3498 | * assume that it also can't satisfy reads larger than that either. | 3516 | * it can't handle a read request larger than its MaxBufferSize either. |
3499 | * | ||
3500 | * FIXME: Is there a better heuristic for this? | ||
3501 | */ | 3517 | */ |
3502 | if (tcon->unix_ext && (unix_cap & CIFS_UNIX_LARGE_READ_CAP)) | 3518 | if (tcon->unix_ext && (unix_cap & CIFS_UNIX_LARGE_READ_CAP)) |
3503 | defsize = CIFS_DEFAULT_IOSIZE; | 3519 | defsize = CIFS_DEFAULT_IOSIZE; |
3504 | else if (server->capabilities & CAP_LARGE_READ_X) | 3520 | else if (server->capabilities & CAP_LARGE_READ_X) |
3505 | defsize = CIFS_DEFAULT_NON_POSIX_RSIZE; | 3521 | defsize = CIFS_DEFAULT_NON_POSIX_RSIZE; |
3506 | else if (server->maxBuf >= PAGE_CACHE_SIZE) | ||
3507 | defsize = CIFSMaxBufSize; | ||
3508 | else | 3522 | else |
3509 | defsize = server->maxBuf - sizeof(READ_RSP); | 3523 | defsize = server->maxBuf - sizeof(READ_RSP); |
3510 | 3524 | ||
@@ -3517,6 +3531,9 @@ cifs_negotiate_rsize(struct cifs_tcon *tcon, struct smb_vol *pvolume_info) | |||
3517 | if (!(server->capabilities & CAP_LARGE_READ_X)) | 3531 | if (!(server->capabilities & CAP_LARGE_READ_X)) |
3518 | rsize = min_t(unsigned int, CIFSMaxBufSize, rsize); | 3532 | rsize = min_t(unsigned int, CIFSMaxBufSize, rsize); |
3519 | 3533 | ||
3534 | /* limit to the amount that we can kmap at once */ | ||
3535 | rsize = min_t(unsigned int, rsize, CIFS_KMAP_SIZE_LIMIT); | ||
3536 | |||
3520 | /* hard limit of CIFS_MAX_RSIZE */ | 3537 | /* hard limit of CIFS_MAX_RSIZE */ |
3521 | rsize = min_t(unsigned int, rsize, CIFS_MAX_RSIZE); | 3538 | rsize = min_t(unsigned int, rsize, CIFS_MAX_RSIZE); |
3522 | 3539 | ||
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index ec4e9a2a12f8..a180265a10b5 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c | |||
@@ -133,108 +133,141 @@ cifs_bp_rename_retry: | |||
133 | return full_path; | 133 | return full_path; |
134 | } | 134 | } |
135 | 135 | ||
136 | /* | ||
137 | * Don't allow the separator character in a path component. | ||
138 | * The VFS will not allow "/", but "\" is allowed by posix. | ||
139 | */ | ||
140 | static int | ||
141 | check_name(struct dentry *direntry) | ||
142 | { | ||
143 | struct cifs_sb_info *cifs_sb = CIFS_SB(direntry->d_sb); | ||
144 | int i; | ||
145 | |||
146 | if (!(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_POSIX_PATHS)) { | ||
147 | for (i = 0; i < direntry->d_name.len; i++) { | ||
148 | if (direntry->d_name.name[i] == '\\') { | ||
149 | cFYI(1, "Invalid file name"); | ||
150 | return -EINVAL; | ||
151 | } | ||
152 | } | ||
153 | } | ||
154 | return 0; | ||
155 | } | ||
156 | |||
157 | |||
136 | /* Inode operations in similar order to how they appear in Linux file fs.h */ | 158 | /* Inode operations in similar order to how they appear in Linux file fs.h */ |
137 | 159 | ||
138 | int | 160 | static int cifs_do_create(struct inode *inode, struct dentry *direntry, |
139 | cifs_create(struct inode *inode, struct dentry *direntry, umode_t mode, | 161 | int xid, struct tcon_link *tlink, unsigned oflags, |
140 | struct nameidata *nd) | 162 | umode_t mode, __u32 *oplock, __u16 *fileHandle, |
163 | int *created) | ||
141 | { | 164 | { |
142 | int rc = -ENOENT; | 165 | int rc = -ENOENT; |
143 | int xid; | ||
144 | int create_options = CREATE_NOT_DIR; | 166 | int create_options = CREATE_NOT_DIR; |
145 | __u32 oplock = 0; | 167 | int desiredAccess; |
146 | int oflags; | 168 | struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb); |
147 | /* | 169 | struct cifs_tcon *tcon = tlink_tcon(tlink); |
148 | * BB below access is probably too much for mknod to request | ||
149 | * but we have to do query and setpathinfo so requesting | ||
150 | * less could fail (unless we want to request getatr and setatr | ||
151 | * permissions (only). At least for POSIX we do not have to | ||
152 | * request so much. | ||
153 | */ | ||
154 | int desiredAccess = GENERIC_READ | GENERIC_WRITE; | ||
155 | __u16 fileHandle; | ||
156 | struct cifs_sb_info *cifs_sb; | ||
157 | struct tcon_link *tlink; | ||
158 | struct cifs_tcon *tcon; | ||
159 | char *full_path = NULL; | 170 | char *full_path = NULL; |
160 | FILE_ALL_INFO *buf = NULL; | 171 | FILE_ALL_INFO *buf = NULL; |
161 | struct inode *newinode = NULL; | 172 | struct inode *newinode = NULL; |
162 | int disposition = FILE_OVERWRITE_IF; | 173 | int disposition; |
163 | |||
164 | xid = GetXid(); | ||
165 | |||
166 | cifs_sb = CIFS_SB(inode->i_sb); | ||
167 | tlink = cifs_sb_tlink(cifs_sb); | ||
168 | if (IS_ERR(tlink)) { | ||
169 | FreeXid(xid); | ||
170 | return PTR_ERR(tlink); | ||
171 | } | ||
172 | tcon = tlink_tcon(tlink); | ||
173 | 174 | ||
175 | *oplock = 0; | ||
174 | if (tcon->ses->server->oplocks) | 176 | if (tcon->ses->server->oplocks) |
175 | oplock = REQ_OPLOCK; | 177 | *oplock = REQ_OPLOCK; |
176 | |||
177 | if (nd) | ||
178 | oflags = nd->intent.open.file->f_flags; | ||
179 | else | ||
180 | oflags = O_RDONLY | O_CREAT; | ||
181 | 178 | ||
182 | full_path = build_path_from_dentry(direntry); | 179 | full_path = build_path_from_dentry(direntry); |
183 | if (full_path == NULL) { | 180 | if (full_path == NULL) { |
184 | rc = -ENOMEM; | 181 | rc = -ENOMEM; |
185 | goto cifs_create_out; | 182 | goto out; |
186 | } | 183 | } |
187 | 184 | ||
188 | if (tcon->unix_ext && (tcon->ses->capabilities & CAP_UNIX) && | 185 | if (tcon->unix_ext && (tcon->ses->capabilities & CAP_UNIX) && |
186 | !tcon->broken_posix_open && | ||
189 | (CIFS_UNIX_POSIX_PATH_OPS_CAP & | 187 | (CIFS_UNIX_POSIX_PATH_OPS_CAP & |
190 | le64_to_cpu(tcon->fsUnixInfo.Capability))) { | 188 | le64_to_cpu(tcon->fsUnixInfo.Capability))) { |
191 | rc = cifs_posix_open(full_path, &newinode, | 189 | rc = cifs_posix_open(full_path, &newinode, |
192 | inode->i_sb, mode, oflags, &oplock, &fileHandle, xid); | 190 | inode->i_sb, mode, oflags, oplock, fileHandle, xid); |
193 | /* EIO could indicate that (posix open) operation is not | 191 | switch (rc) { |
194 | supported, despite what server claimed in capability | 192 | case 0: |
195 | negotiation. EREMOTE indicates DFS junction, which is not | 193 | if (newinode == NULL) { |
196 | handled in posix open */ | 194 | /* query inode info */ |
197 | |||
198 | if (rc == 0) { | ||
199 | if (newinode == NULL) /* query inode info */ | ||
200 | goto cifs_create_get_file_info; | 195 | goto cifs_create_get_file_info; |
201 | else /* success, no need to query */ | 196 | } |
202 | goto cifs_create_set_dentry; | 197 | |
203 | } else if ((rc != -EIO) && (rc != -EREMOTE) && | 198 | if (!S_ISREG(newinode->i_mode)) { |
204 | (rc != -EOPNOTSUPP) && (rc != -EINVAL)) | 199 | /* |
205 | goto cifs_create_out; | 200 | * The server may allow us to open things like |
206 | /* else fallthrough to retry, using older open call, this is | 201 | * FIFOs, but the client isn't set up to deal |
207 | case where server does not support this SMB level, and | 202 | * with that. If it's not a regular file, just |
208 | falsely claims capability (also get here for DFS case | 203 | * close it and proceed as if it were a normal |
209 | which should be rare for path not covered on files) */ | 204 | * lookup. |
210 | } | 205 | */ |
206 | CIFSSMBClose(xid, tcon, *fileHandle); | ||
207 | goto cifs_create_get_file_info; | ||
208 | } | ||
209 | /* success, no need to query */ | ||
210 | goto cifs_create_set_dentry; | ||
211 | |||
212 | case -ENOENT: | ||
213 | goto cifs_create_get_file_info; | ||
214 | |||
215 | case -EIO: | ||
216 | case -EINVAL: | ||
217 | /* | ||
218 | * EIO could indicate that (posix open) operation is not | ||
219 | * supported, despite what server claimed in capability | ||
220 | * negotiation. | ||
221 | * | ||
222 | * POSIX open in samba versions 3.3.1 and earlier could | ||
223 | * incorrectly fail with invalid parameter. | ||
224 | */ | ||
225 | tcon->broken_posix_open = true; | ||
226 | break; | ||
227 | |||
228 | case -EREMOTE: | ||
229 | case -EOPNOTSUPP: | ||
230 | /* | ||
231 | * EREMOTE indicates DFS junction, which is not handled | ||
232 | * in posix open. If either that or op not supported | ||
233 | * returned, follow the normal lookup. | ||
234 | */ | ||
235 | break; | ||
211 | 236 | ||
212 | if (nd) { | 237 | default: |
213 | /* if the file is going to stay open, then we | 238 | goto out; |
214 | need to set the desired access properly */ | 239 | } |
215 | desiredAccess = 0; | 240 | /* |
216 | if (OPEN_FMODE(oflags) & FMODE_READ) | 241 | * fallthrough to retry, using older open call, this is case |
217 | desiredAccess |= GENERIC_READ; /* is this too little? */ | 242 | * where server does not support this SMB level, and falsely |
218 | if (OPEN_FMODE(oflags) & FMODE_WRITE) | 243 | * claims capability (also get here for DFS case which should be |
219 | desiredAccess |= GENERIC_WRITE; | 244 | * rare for path not covered on files) |
220 | 245 | */ | |
221 | if ((oflags & (O_CREAT | O_EXCL)) == (O_CREAT | O_EXCL)) | ||
222 | disposition = FILE_CREATE; | ||
223 | else if ((oflags & (O_CREAT | O_TRUNC)) == (O_CREAT | O_TRUNC)) | ||
224 | disposition = FILE_OVERWRITE_IF; | ||
225 | else if ((oflags & O_CREAT) == O_CREAT) | ||
226 | disposition = FILE_OPEN_IF; | ||
227 | else | ||
228 | cFYI(1, "Create flag not set in create function"); | ||
229 | } | 246 | } |
230 | 247 | ||
248 | desiredAccess = 0; | ||
249 | if (OPEN_FMODE(oflags) & FMODE_READ) | ||
250 | desiredAccess |= GENERIC_READ; /* is this too little? */ | ||
251 | if (OPEN_FMODE(oflags) & FMODE_WRITE) | ||
252 | desiredAccess |= GENERIC_WRITE; | ||
253 | |||
254 | disposition = FILE_OVERWRITE_IF; | ||
255 | if ((oflags & (O_CREAT | O_EXCL)) == (O_CREAT | O_EXCL)) | ||
256 | disposition = FILE_CREATE; | ||
257 | else if ((oflags & (O_CREAT | O_TRUNC)) == (O_CREAT | O_TRUNC)) | ||
258 | disposition = FILE_OVERWRITE_IF; | ||
259 | else if ((oflags & O_CREAT) == O_CREAT) | ||
260 | disposition = FILE_OPEN_IF; | ||
261 | else | ||
262 | cFYI(1, "Create flag not set in create function"); | ||
263 | |||
231 | /* BB add processing to set equivalent of mode - e.g. via CreateX with | 264 | /* BB add processing to set equivalent of mode - e.g. via CreateX with |
232 | ACLs */ | 265 | ACLs */ |
233 | 266 | ||
234 | buf = kmalloc(sizeof(FILE_ALL_INFO), GFP_KERNEL); | 267 | buf = kmalloc(sizeof(FILE_ALL_INFO), GFP_KERNEL); |
235 | if (buf == NULL) { | 268 | if (buf == NULL) { |
236 | rc = -ENOMEM; | 269 | rc = -ENOMEM; |
237 | goto cifs_create_out; | 270 | goto out; |
238 | } | 271 | } |
239 | 272 | ||
240 | /* | 273 | /* |
@@ -250,7 +283,7 @@ cifs_create(struct inode *inode, struct dentry *direntry, umode_t mode, | |||
250 | if (tcon->ses->capabilities & CAP_NT_SMBS) | 283 | if (tcon->ses->capabilities & CAP_NT_SMBS) |
251 | rc = CIFSSMBOpen(xid, tcon, full_path, disposition, | 284 | rc = CIFSSMBOpen(xid, tcon, full_path, disposition, |
252 | desiredAccess, create_options, | 285 | desiredAccess, create_options, |
253 | &fileHandle, &oplock, buf, cifs_sb->local_nls, | 286 | fileHandle, oplock, buf, cifs_sb->local_nls, |
254 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); | 287 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); |
255 | else | 288 | else |
256 | rc = -EIO; /* no NT SMB support fall into legacy open below */ | 289 | rc = -EIO; /* no NT SMB support fall into legacy open below */ |
@@ -259,17 +292,17 @@ cifs_create(struct inode *inode, struct dentry *direntry, umode_t mode, | |||
259 | /* old server, retry the open legacy style */ | 292 | /* old server, retry the open legacy style */ |
260 | rc = SMBLegacyOpen(xid, tcon, full_path, disposition, | 293 | rc = SMBLegacyOpen(xid, tcon, full_path, disposition, |
261 | desiredAccess, create_options, | 294 | desiredAccess, create_options, |
262 | &fileHandle, &oplock, buf, cifs_sb->local_nls, | 295 | fileHandle, oplock, buf, cifs_sb->local_nls, |
263 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); | 296 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); |
264 | } | 297 | } |
265 | if (rc) { | 298 | if (rc) { |
266 | cFYI(1, "cifs_create returned 0x%x", rc); | 299 | cFYI(1, "cifs_create returned 0x%x", rc); |
267 | goto cifs_create_out; | 300 | goto out; |
268 | } | 301 | } |
269 | 302 | ||
270 | /* If Open reported that we actually created a file | 303 | /* If Open reported that we actually created a file |
271 | then we now have to set the mode if possible */ | 304 | then we now have to set the mode if possible */ |
272 | if ((tcon->unix_ext) && (oplock & CIFS_CREATE_ACTION)) { | 305 | if ((tcon->unix_ext) && (*oplock & CIFS_CREATE_ACTION)) { |
273 | struct cifs_unix_set_info_args args = { | 306 | struct cifs_unix_set_info_args args = { |
274 | .mode = mode, | 307 | .mode = mode, |
275 | .ctime = NO_CHANGE_64, | 308 | .ctime = NO_CHANGE_64, |
@@ -278,6 +311,7 @@ cifs_create(struct inode *inode, struct dentry *direntry, umode_t mode, | |||
278 | .device = 0, | 311 | .device = 0, |
279 | }; | 312 | }; |
280 | 313 | ||
314 | *created |= FILE_CREATED; | ||
281 | if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID) { | 315 | if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID) { |
282 | args.uid = (__u64) current_fsuid(); | 316 | args.uid = (__u64) current_fsuid(); |
283 | if (inode->i_mode & S_ISGID) | 317 | if (inode->i_mode & S_ISGID) |
@@ -288,7 +322,7 @@ cifs_create(struct inode *inode, struct dentry *direntry, umode_t mode, | |||
288 | args.uid = NO_CHANGE_64; | 322 | args.uid = NO_CHANGE_64; |
289 | args.gid = NO_CHANGE_64; | 323 | args.gid = NO_CHANGE_64; |
290 | } | 324 | } |
291 | CIFSSMBUnixSetFileInfo(xid, tcon, &args, fileHandle, | 325 | CIFSSMBUnixSetFileInfo(xid, tcon, &args, *fileHandle, |
292 | current->tgid); | 326 | current->tgid); |
293 | } else { | 327 | } else { |
294 | /* BB implement mode setting via Windows security | 328 | /* BB implement mode setting via Windows security |
@@ -305,11 +339,11 @@ cifs_create_get_file_info: | |||
305 | inode->i_sb, xid); | 339 | inode->i_sb, xid); |
306 | else { | 340 | else { |
307 | rc = cifs_get_inode_info(&newinode, full_path, buf, | 341 | rc = cifs_get_inode_info(&newinode, full_path, buf, |
308 | inode->i_sb, xid, &fileHandle); | 342 | inode->i_sb, xid, fileHandle); |
309 | if (newinode) { | 343 | if (newinode) { |
310 | if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_DYNPERM) | 344 | if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_DYNPERM) |
311 | newinode->i_mode = mode; | 345 | newinode->i_mode = mode; |
312 | if ((oplock & CIFS_CREATE_ACTION) && | 346 | if ((*oplock & CIFS_CREATE_ACTION) && |
313 | (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID)) { | 347 | (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID)) { |
314 | newinode->i_uid = current_fsuid(); | 348 | newinode->i_uid = current_fsuid(); |
315 | if (inode->i_mode & S_ISGID) | 349 | if (inode->i_mode & S_ISGID) |
@@ -321,40 +355,139 @@ cifs_create_get_file_info: | |||
321 | } | 355 | } |
322 | 356 | ||
323 | cifs_create_set_dentry: | 357 | cifs_create_set_dentry: |
324 | if (rc == 0) | 358 | if (rc != 0) { |
325 | d_instantiate(direntry, newinode); | ||
326 | else | ||
327 | cFYI(1, "Create worked, get_inode_info failed rc = %d", rc); | 359 | cFYI(1, "Create worked, get_inode_info failed rc = %d", rc); |
360 | goto out; | ||
361 | } | ||
362 | d_drop(direntry); | ||
363 | d_add(direntry, newinode); | ||
328 | 364 | ||
329 | if (newinode && nd) { | 365 | /* ENOENT for create? How weird... */ |
330 | struct cifsFileInfo *pfile_info; | 366 | rc = -ENOENT; |
331 | struct file *filp; | 367 | if (!newinode) { |
368 | CIFSSMBClose(xid, tcon, *fileHandle); | ||
369 | goto out; | ||
370 | } | ||
371 | rc = 0; | ||
332 | 372 | ||
333 | filp = lookup_instantiate_filp(nd, direntry, generic_file_open); | 373 | out: |
334 | if (IS_ERR(filp)) { | 374 | kfree(buf); |
335 | rc = PTR_ERR(filp); | 375 | kfree(full_path); |
336 | CIFSSMBClose(xid, tcon, fileHandle); | 376 | return rc; |
337 | goto cifs_create_out; | 377 | } |
338 | } | ||
339 | 378 | ||
340 | pfile_info = cifs_new_fileinfo(fileHandle, filp, tlink, oplock); | 379 | int |
341 | if (pfile_info == NULL) { | 380 | cifs_atomic_open(struct inode *inode, struct dentry *direntry, |
342 | fput(filp); | 381 | struct file *file, unsigned oflags, umode_t mode, |
343 | CIFSSMBClose(xid, tcon, fileHandle); | 382 | int *opened) |
344 | rc = -ENOMEM; | 383 | { |
345 | } | 384 | int rc; |
346 | } else { | 385 | int xid; |
386 | struct tcon_link *tlink; | ||
387 | struct cifs_tcon *tcon; | ||
388 | __u16 fileHandle; | ||
389 | __u32 oplock; | ||
390 | struct file *filp; | ||
391 | struct cifsFileInfo *pfile_info; | ||
392 | |||
393 | /* Posix open is only called (at lookup time) for file create now. For | ||
394 | * opens (rather than creates), because we do not know if it is a file | ||
395 | * or directory yet, and current Samba no longer allows us to do posix | ||
396 | * open on dirs, we could end up wasting an open call on what turns out | ||
397 | * to be a dir. For file opens, we wait to call posix open till | ||
398 | * cifs_open. It could be added to atomic_open in the future but the | ||
399 | * performance tradeoff of the extra network request when EISDIR or | ||
400 | * EACCES is returned would have to be weighed against the 50% reduction | ||
401 | * in network traffic in the other paths. | ||
402 | */ | ||
403 | if (!(oflags & O_CREAT)) { | ||
404 | struct dentry *res = cifs_lookup(inode, direntry, 0); | ||
405 | if (IS_ERR(res)) | ||
406 | return PTR_ERR(res); | ||
407 | |||
408 | return finish_no_open(file, res); | ||
409 | } | ||
410 | |||
411 | rc = check_name(direntry); | ||
412 | if (rc) | ||
413 | return rc; | ||
414 | |||
415 | xid = GetXid(); | ||
416 | |||
417 | cFYI(1, "parent inode = 0x%p name is: %s and dentry = 0x%p", | ||
418 | inode, direntry->d_name.name, direntry); | ||
419 | |||
420 | tlink = cifs_sb_tlink(CIFS_SB(inode->i_sb)); | ||
421 | filp = ERR_CAST(tlink); | ||
422 | if (IS_ERR(tlink)) | ||
423 | goto free_xid; | ||
424 | |||
425 | tcon = tlink_tcon(tlink); | ||
426 | |||
427 | rc = cifs_do_create(inode, direntry, xid, tlink, oflags, mode, | ||
428 | &oplock, &fileHandle, opened); | ||
429 | |||
430 | if (rc) | ||
431 | goto out; | ||
432 | |||
433 | rc = finish_open(file, direntry, generic_file_open, opened); | ||
434 | if (rc) { | ||
347 | CIFSSMBClose(xid, tcon, fileHandle); | 435 | CIFSSMBClose(xid, tcon, fileHandle); |
436 | goto out; | ||
348 | } | 437 | } |
349 | 438 | ||
350 | cifs_create_out: | 439 | pfile_info = cifs_new_fileinfo(fileHandle, filp, tlink, oplock); |
351 | kfree(buf); | 440 | if (pfile_info == NULL) { |
352 | kfree(full_path); | 441 | CIFSSMBClose(xid, tcon, fileHandle); |
442 | fput(filp); | ||
443 | rc = -ENOMEM; | ||
444 | } | ||
445 | |||
446 | out: | ||
353 | cifs_put_tlink(tlink); | 447 | cifs_put_tlink(tlink); |
448 | free_xid: | ||
354 | FreeXid(xid); | 449 | FreeXid(xid); |
355 | return rc; | 450 | return rc; |
356 | } | 451 | } |
357 | 452 | ||
453 | int cifs_create(struct inode *inode, struct dentry *direntry, umode_t mode, | ||
454 | bool excl) | ||
455 | { | ||
456 | int rc; | ||
457 | int xid = GetXid(); | ||
458 | /* | ||
459 | * BB below access is probably too much for mknod to request | ||
460 | * but we have to do query and setpathinfo so requesting | ||
461 | * less could fail (unless we want to request getatr and setatr | ||
462 | * permissions (only). At least for POSIX we do not have to | ||
463 | * request so much. | ||
464 | */ | ||
465 | unsigned oflags = O_EXCL | O_CREAT | O_RDWR; | ||
466 | struct tcon_link *tlink; | ||
467 | __u16 fileHandle; | ||
468 | __u32 oplock; | ||
469 | int created = FILE_CREATED; | ||
470 | |||
471 | cFYI(1, "cifs_create parent inode = 0x%p name is: %s and dentry = 0x%p", | ||
472 | inode, direntry->d_name.name, direntry); | ||
473 | |||
474 | tlink = cifs_sb_tlink(CIFS_SB(inode->i_sb)); | ||
475 | rc = PTR_ERR(tlink); | ||
476 | if (IS_ERR(tlink)) | ||
477 | goto free_xid; | ||
478 | |||
479 | rc = cifs_do_create(inode, direntry, xid, tlink, oflags, mode, | ||
480 | &oplock, &fileHandle, &created); | ||
481 | if (!rc) | ||
482 | CIFSSMBClose(xid, tlink_tcon(tlink), fileHandle); | ||
483 | |||
484 | cifs_put_tlink(tlink); | ||
485 | free_xid: | ||
486 | FreeXid(xid); | ||
487 | |||
488 | return rc; | ||
489 | } | ||
490 | |||
358 | int cifs_mknod(struct inode *inode, struct dentry *direntry, umode_t mode, | 491 | int cifs_mknod(struct inode *inode, struct dentry *direntry, umode_t mode, |
359 | dev_t device_number) | 492 | dev_t device_number) |
360 | { | 493 | { |
@@ -488,20 +621,15 @@ mknod_out: | |||
488 | 621 | ||
489 | struct dentry * | 622 | struct dentry * |
490 | cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry, | 623 | cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry, |
491 | struct nameidata *nd) | 624 | unsigned int flags) |
492 | { | 625 | { |
493 | int xid; | 626 | int xid; |
494 | int rc = 0; /* to get around spurious gcc warning, set to zero here */ | 627 | int rc = 0; /* to get around spurious gcc warning, set to zero here */ |
495 | __u32 oplock; | ||
496 | __u16 fileHandle = 0; | ||
497 | bool posix_open = false; | ||
498 | struct cifs_sb_info *cifs_sb; | 628 | struct cifs_sb_info *cifs_sb; |
499 | struct tcon_link *tlink; | 629 | struct tcon_link *tlink; |
500 | struct cifs_tcon *pTcon; | 630 | struct cifs_tcon *pTcon; |
501 | struct cifsFileInfo *cfile; | ||
502 | struct inode *newInode = NULL; | 631 | struct inode *newInode = NULL; |
503 | char *full_path = NULL; | 632 | char *full_path = NULL; |
504 | struct file *filp; | ||
505 | 633 | ||
506 | xid = GetXid(); | 634 | xid = GetXid(); |
507 | 635 | ||
@@ -518,31 +646,9 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry, | |||
518 | } | 646 | } |
519 | pTcon = tlink_tcon(tlink); | 647 | pTcon = tlink_tcon(tlink); |
520 | 648 | ||
521 | oplock = pTcon->ses->server->oplocks ? REQ_OPLOCK : 0; | 649 | rc = check_name(direntry); |
522 | 650 | if (rc) | |
523 | /* | ||
524 | * Don't allow the separator character in a path component. | ||
525 | * The VFS will not allow "/", but "\" is allowed by posix. | ||
526 | */ | ||
527 | if (!(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_POSIX_PATHS)) { | ||
528 | int i; | ||
529 | for (i = 0; i < direntry->d_name.len; i++) | ||
530 | if (direntry->d_name.name[i] == '\\') { | ||
531 | cFYI(1, "Invalid file name"); | ||
532 | rc = -EINVAL; | ||
533 | goto lookup_out; | ||
534 | } | ||
535 | } | ||
536 | |||
537 | /* | ||
538 | * O_EXCL: optimize away the lookup, but don't hash the dentry. Let | ||
539 | * the VFS handle the create. | ||
540 | */ | ||
541 | if (nd && (nd->flags & LOOKUP_EXCL)) { | ||
542 | d_instantiate(direntry, NULL); | ||
543 | rc = 0; | ||
544 | goto lookup_out; | 651 | goto lookup_out; |
545 | } | ||
546 | 652 | ||
547 | /* can not grab the rename sem here since it would | 653 | /* can not grab the rename sem here since it would |
548 | deadlock in the cases (beginning of sys_rename itself) | 654 | deadlock in the cases (beginning of sys_rename itself) |
@@ -560,80 +666,16 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry, | |||
560 | } | 666 | } |
561 | cFYI(1, "Full path: %s inode = 0x%p", full_path, direntry->d_inode); | 667 | cFYI(1, "Full path: %s inode = 0x%p", full_path, direntry->d_inode); |
562 | 668 | ||
563 | /* Posix open is only called (at lookup time) for file create now. | ||
564 | * For opens (rather than creates), because we do not know if it | ||
565 | * is a file or directory yet, and current Samba no longer allows | ||
566 | * us to do posix open on dirs, we could end up wasting an open call | ||
567 | * on what turns out to be a dir. For file opens, we wait to call posix | ||
568 | * open till cifs_open. It could be added here (lookup) in the future | ||
569 | * but the performance tradeoff of the extra network request when EISDIR | ||
570 | * or EACCES is returned would have to be weighed against the 50% | ||
571 | * reduction in network traffic in the other paths. | ||
572 | */ | ||
573 | if (pTcon->unix_ext) { | 669 | if (pTcon->unix_ext) { |
574 | if (nd && !(nd->flags & LOOKUP_DIRECTORY) && | 670 | rc = cifs_get_inode_info_unix(&newInode, full_path, |
575 | (nd->flags & LOOKUP_OPEN) && !pTcon->broken_posix_open && | 671 | parent_dir_inode->i_sb, xid); |
576 | (nd->intent.open.file->f_flags & O_CREAT)) { | 672 | } else { |
577 | rc = cifs_posix_open(full_path, &newInode, | ||
578 | parent_dir_inode->i_sb, | ||
579 | nd->intent.open.create_mode, | ||
580 | nd->intent.open.file->f_flags, &oplock, | ||
581 | &fileHandle, xid); | ||
582 | /* | ||
583 | * The check below works around a bug in POSIX | ||
584 | * open in samba versions 3.3.1 and earlier where | ||
585 | * open could incorrectly fail with invalid parameter. | ||
586 | * If either that or op not supported returned, follow | ||
587 | * the normal lookup. | ||
588 | */ | ||
589 | switch (rc) { | ||
590 | case 0: | ||
591 | /* | ||
592 | * The server may allow us to open things like | ||
593 | * FIFOs, but the client isn't set up to deal | ||
594 | * with that. If it's not a regular file, just | ||
595 | * close it and proceed as if it were a normal | ||
596 | * lookup. | ||
597 | */ | ||
598 | if (newInode && !S_ISREG(newInode->i_mode)) { | ||
599 | CIFSSMBClose(xid, pTcon, fileHandle); | ||
600 | break; | ||
601 | } | ||
602 | case -ENOENT: | ||
603 | posix_open = true; | ||
604 | case -EOPNOTSUPP: | ||
605 | break; | ||
606 | default: | ||
607 | pTcon->broken_posix_open = true; | ||
608 | } | ||
609 | } | ||
610 | if (!posix_open) | ||
611 | rc = cifs_get_inode_info_unix(&newInode, full_path, | ||
612 | parent_dir_inode->i_sb, xid); | ||
613 | } else | ||
614 | rc = cifs_get_inode_info(&newInode, full_path, NULL, | 673 | rc = cifs_get_inode_info(&newInode, full_path, NULL, |
615 | parent_dir_inode->i_sb, xid, NULL); | 674 | parent_dir_inode->i_sb, xid, NULL); |
675 | } | ||
616 | 676 | ||
617 | if ((rc == 0) && (newInode != NULL)) { | 677 | if ((rc == 0) && (newInode != NULL)) { |
618 | d_add(direntry, newInode); | 678 | d_add(direntry, newInode); |
619 | if (posix_open) { | ||
620 | filp = lookup_instantiate_filp(nd, direntry, | ||
621 | generic_file_open); | ||
622 | if (IS_ERR(filp)) { | ||
623 | rc = PTR_ERR(filp); | ||
624 | CIFSSMBClose(xid, pTcon, fileHandle); | ||
625 | goto lookup_out; | ||
626 | } | ||
627 | |||
628 | cfile = cifs_new_fileinfo(fileHandle, filp, tlink, | ||
629 | oplock); | ||
630 | if (cfile == NULL) { | ||
631 | fput(filp); | ||
632 | CIFSSMBClose(xid, pTcon, fileHandle); | ||
633 | rc = -ENOMEM; | ||
634 | goto lookup_out; | ||
635 | } | ||
636 | } | ||
637 | /* since paths are not looked up by component - the parent | 679 | /* since paths are not looked up by component - the parent |
638 | directories are presumed to be good here */ | 680 | directories are presumed to be good here */ |
639 | renew_parental_timestamps(direntry); | 681 | renew_parental_timestamps(direntry); |
@@ -658,9 +700,9 @@ lookup_out: | |||
658 | } | 700 | } |
659 | 701 | ||
660 | static int | 702 | static int |
661 | cifs_d_revalidate(struct dentry *direntry, struct nameidata *nd) | 703 | cifs_d_revalidate(struct dentry *direntry, unsigned int flags) |
662 | { | 704 | { |
663 | if (nd && (nd->flags & LOOKUP_RCU)) | 705 | if (flags & LOOKUP_RCU) |
664 | return -ECHILD; | 706 | return -ECHILD; |
665 | 707 | ||
666 | if (direntry->d_inode) { | 708 | if (direntry->d_inode) { |
@@ -689,7 +731,7 @@ cifs_d_revalidate(struct dentry *direntry, struct nameidata *nd) | |||
689 | * This may be nfsd (or something), anyway, we can't see the | 731 | * This may be nfsd (or something), anyway, we can't see the |
690 | * intent of this. So, since this can be for creation, drop it. | 732 | * intent of this. So, since this can be for creation, drop it. |
691 | */ | 733 | */ |
692 | if (!nd) | 734 | if (!flags) |
693 | return 0; | 735 | return 0; |
694 | 736 | ||
695 | /* | 737 | /* |
@@ -697,7 +739,7 @@ cifs_d_revalidate(struct dentry *direntry, struct nameidata *nd) | |||
697 | * case sensitive name which is specified by user if this is | 739 | * case sensitive name which is specified by user if this is |
698 | * for creation. | 740 | * for creation. |
699 | */ | 741 | */ |
700 | if (nd->flags & (LOOKUP_CREATE | LOOKUP_RENAME_TARGET)) | 742 | if (flags & (LOOKUP_CREATE | LOOKUP_RENAME_TARGET)) |
701 | return 0; | 743 | return 0; |
702 | 744 | ||
703 | if (time_after(jiffies, direntry->d_time + HZ) || !lookupCacheEnabled) | 745 | if (time_after(jiffies, direntry->d_time + HZ) || !lookupCacheEnabled) |
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 745da3d0653e..8e8bb49112ff 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c | |||
@@ -800,7 +800,7 @@ cifs_find_inode(struct inode *inode, void *opaque) | |||
800 | return 0; | 800 | return 0; |
801 | 801 | ||
802 | /* if it's not a directory or has no dentries, then flag it */ | 802 | /* if it's not a directory or has no dentries, then flag it */ |
803 | if (S_ISDIR(inode->i_mode) && !list_empty(&inode->i_dentry)) | 803 | if (S_ISDIR(inode->i_mode) && !hlist_empty(&inode->i_dentry)) |
804 | fattr->cf_flags |= CIFS_FATTR_INO_COLLISION; | 804 | fattr->cf_flags |= CIFS_FATTR_INO_COLLISION; |
805 | 805 | ||
806 | return 1; | 806 | return 1; |
@@ -825,9 +825,10 @@ static bool | |||
825 | inode_has_hashed_dentries(struct inode *inode) | 825 | inode_has_hashed_dentries(struct inode *inode) |
826 | { | 826 | { |
827 | struct dentry *dentry; | 827 | struct dentry *dentry; |
828 | struct hlist_node *p; | ||
828 | 829 | ||
829 | spin_lock(&inode->i_lock); | 830 | spin_lock(&inode->i_lock); |
830 | list_for_each_entry(dentry, &inode->i_dentry, d_alias) { | 831 | hlist_for_each_entry(dentry, p, &inode->i_dentry, d_alias) { |
831 | if (!d_unhashed(dentry) || IS_ROOT(dentry)) { | 832 | if (!d_unhashed(dentry) || IS_ROOT(dentry)) { |
832 | spin_unlock(&inode->i_lock); | 833 | spin_unlock(&inode->i_lock); |
833 | return true; | 834 | return true; |
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index 0a8224d1c4c5..a4217f02fab2 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c | |||
@@ -86,9 +86,12 @@ cifs_readdir_lookup(struct dentry *parent, struct qstr *name, | |||
86 | 86 | ||
87 | dentry = d_lookup(parent, name); | 87 | dentry = d_lookup(parent, name); |
88 | if (dentry) { | 88 | if (dentry) { |
89 | /* FIXME: check for inode number changes? */ | 89 | inode = dentry->d_inode; |
90 | if (dentry->d_inode != NULL) | 90 | /* update inode in place if i_ino didn't change */ |
91 | if (inode && CIFS_I(inode)->uniqueid == fattr->cf_uniqueid) { | ||
92 | cifs_fattr_to_inode(inode, fattr); | ||
91 | return dentry; | 93 | return dentry; |
94 | } | ||
92 | d_drop(dentry); | 95 | d_drop(dentry); |
93 | dput(dentry); | 96 | dput(dentry); |
94 | } | 97 | } |
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index 3097ee58fd7d..f25d4ea14be4 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c | |||
@@ -365,16 +365,14 @@ cifs_setup_async_request(struct TCP_Server_Info *server, struct kvec *iov, | |||
365 | if (mid == NULL) | 365 | if (mid == NULL) |
366 | return -ENOMEM; | 366 | return -ENOMEM; |
367 | 367 | ||
368 | /* put it on the pending_mid_q */ | ||
369 | spin_lock(&GlobalMid_Lock); | ||
370 | list_add_tail(&mid->qhead, &server->pending_mid_q); | ||
371 | spin_unlock(&GlobalMid_Lock); | ||
372 | |||
373 | rc = cifs_sign_smb2(iov, nvec, server, &mid->sequence_number); | 368 | rc = cifs_sign_smb2(iov, nvec, server, &mid->sequence_number); |
374 | if (rc) | 369 | if (rc) { |
375 | delete_mid(mid); | 370 | DeleteMidQEntry(mid); |
371 | return rc; | ||
372 | } | ||
373 | |||
376 | *ret_mid = mid; | 374 | *ret_mid = mid; |
377 | return rc; | 375 | return 0; |
378 | } | 376 | } |
379 | 377 | ||
380 | /* | 378 | /* |
@@ -407,17 +405,21 @@ cifs_call_async(struct TCP_Server_Info *server, struct kvec *iov, | |||
407 | mid->callback_data = cbdata; | 405 | mid->callback_data = cbdata; |
408 | mid->mid_state = MID_REQUEST_SUBMITTED; | 406 | mid->mid_state = MID_REQUEST_SUBMITTED; |
409 | 407 | ||
408 | /* put it on the pending_mid_q */ | ||
409 | spin_lock(&GlobalMid_Lock); | ||
410 | list_add_tail(&mid->qhead, &server->pending_mid_q); | ||
411 | spin_unlock(&GlobalMid_Lock); | ||
412 | |||
413 | |||
410 | cifs_in_send_inc(server); | 414 | cifs_in_send_inc(server); |
411 | rc = smb_sendv(server, iov, nvec); | 415 | rc = smb_sendv(server, iov, nvec); |
412 | cifs_in_send_dec(server); | 416 | cifs_in_send_dec(server); |
413 | cifs_save_when_sent(mid); | 417 | cifs_save_when_sent(mid); |
414 | mutex_unlock(&server->srv_mutex); | 418 | mutex_unlock(&server->srv_mutex); |
415 | 419 | ||
416 | if (rc) | 420 | if (rc == 0) |
417 | goto out_err; | 421 | return 0; |
418 | 422 | ||
419 | return rc; | ||
420 | out_err: | ||
421 | delete_mid(mid); | 423 | delete_mid(mid); |
422 | add_credits(server, 1); | 424 | add_credits(server, 1); |
423 | wake_up(&server->request_q); | 425 | wake_up(&server->request_q); |
diff --git a/fs/coda/cache.c b/fs/coda/cache.c index 690157876184..958ae0e0ff8c 100644 --- a/fs/coda/cache.c +++ b/fs/coda/cache.c | |||
@@ -89,17 +89,13 @@ int coda_cache_check(struct inode *inode, int mask) | |||
89 | /* this won't do any harm: just flag all children */ | 89 | /* this won't do any harm: just flag all children */ |
90 | static void coda_flag_children(struct dentry *parent, int flag) | 90 | static void coda_flag_children(struct dentry *parent, int flag) |
91 | { | 91 | { |
92 | struct list_head *child; | ||
93 | struct dentry *de; | 92 | struct dentry *de; |
94 | 93 | ||
95 | spin_lock(&parent->d_lock); | 94 | spin_lock(&parent->d_lock); |
96 | list_for_each(child, &parent->d_subdirs) | 95 | list_for_each_entry(de, &parent->d_subdirs, d_u.d_child) { |
97 | { | ||
98 | de = list_entry(child, struct dentry, d_u.d_child); | ||
99 | /* don't know what to do with negative dentries */ | 96 | /* don't know what to do with negative dentries */ |
100 | if ( ! de->d_inode ) | 97 | if (de->d_inode ) |
101 | continue; | 98 | coda_flag_inode(de->d_inode, flag); |
102 | coda_flag_inode(de->d_inode, flag); | ||
103 | } | 99 | } |
104 | spin_unlock(&parent->d_lock); | 100 | spin_unlock(&parent->d_lock); |
105 | return; | 101 | return; |
diff --git a/fs/coda/dir.c b/fs/coda/dir.c index 177515829062..49fe52d25600 100644 --- a/fs/coda/dir.c +++ b/fs/coda/dir.c | |||
@@ -30,8 +30,8 @@ | |||
30 | #include "coda_int.h" | 30 | #include "coda_int.h" |
31 | 31 | ||
32 | /* dir inode-ops */ | 32 | /* dir inode-ops */ |
33 | static int coda_create(struct inode *dir, struct dentry *new, umode_t mode, struct nameidata *nd); | 33 | static int coda_create(struct inode *dir, struct dentry *new, umode_t mode, bool excl); |
34 | static struct dentry *coda_lookup(struct inode *dir, struct dentry *target, struct nameidata *nd); | 34 | static struct dentry *coda_lookup(struct inode *dir, struct dentry *target, unsigned int flags); |
35 | static int coda_link(struct dentry *old_dentry, struct inode *dir_inode, | 35 | static int coda_link(struct dentry *old_dentry, struct inode *dir_inode, |
36 | struct dentry *entry); | 36 | struct dentry *entry); |
37 | static int coda_unlink(struct inode *dir_inode, struct dentry *entry); | 37 | static int coda_unlink(struct inode *dir_inode, struct dentry *entry); |
@@ -46,7 +46,7 @@ static int coda_rename(struct inode *old_inode, struct dentry *old_dentry, | |||
46 | static int coda_readdir(struct file *file, void *buf, filldir_t filldir); | 46 | static int coda_readdir(struct file *file, void *buf, filldir_t filldir); |
47 | 47 | ||
48 | /* dentry ops */ | 48 | /* dentry ops */ |
49 | static int coda_dentry_revalidate(struct dentry *de, struct nameidata *nd); | 49 | static int coda_dentry_revalidate(struct dentry *de, unsigned int flags); |
50 | static int coda_dentry_delete(const struct dentry *); | 50 | static int coda_dentry_delete(const struct dentry *); |
51 | 51 | ||
52 | /* support routines */ | 52 | /* support routines */ |
@@ -94,7 +94,7 @@ const struct file_operations coda_dir_operations = { | |||
94 | 94 | ||
95 | /* inode operations for directories */ | 95 | /* inode operations for directories */ |
96 | /* access routines: lookup, readlink, permission */ | 96 | /* access routines: lookup, readlink, permission */ |
97 | static struct dentry *coda_lookup(struct inode *dir, struct dentry *entry, struct nameidata *nd) | 97 | static struct dentry *coda_lookup(struct inode *dir, struct dentry *entry, unsigned int flags) |
98 | { | 98 | { |
99 | struct super_block *sb = dir->i_sb; | 99 | struct super_block *sb = dir->i_sb; |
100 | const char *name = entry->d_name.name; | 100 | const char *name = entry->d_name.name; |
@@ -188,7 +188,7 @@ static inline void coda_dir_drop_nlink(struct inode *dir) | |||
188 | } | 188 | } |
189 | 189 | ||
190 | /* creation routines: create, mknod, mkdir, link, symlink */ | 190 | /* creation routines: create, mknod, mkdir, link, symlink */ |
191 | static int coda_create(struct inode *dir, struct dentry *de, umode_t mode, struct nameidata *nd) | 191 | static int coda_create(struct inode *dir, struct dentry *de, umode_t mode, bool excl) |
192 | { | 192 | { |
193 | int error; | 193 | int error; |
194 | const char *name=de->d_name.name; | 194 | const char *name=de->d_name.name; |
@@ -536,12 +536,12 @@ out: | |||
536 | } | 536 | } |
537 | 537 | ||
538 | /* called when a cache lookup succeeds */ | 538 | /* called when a cache lookup succeeds */ |
539 | static int coda_dentry_revalidate(struct dentry *de, struct nameidata *nd) | 539 | static int coda_dentry_revalidate(struct dentry *de, unsigned int flags) |
540 | { | 540 | { |
541 | struct inode *inode; | 541 | struct inode *inode; |
542 | struct coda_inode_info *cii; | 542 | struct coda_inode_info *cii; |
543 | 543 | ||
544 | if (nd->flags & LOOKUP_RCU) | 544 | if (flags & LOOKUP_RCU) |
545 | return -ECHILD; | 545 | return -ECHILD; |
546 | 546 | ||
547 | inode = de->d_inode; | 547 | inode = de->d_inode; |
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 7e6c52d8a207..7414ae24a79b 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c | |||
@@ -442,7 +442,7 @@ static int configfs_attach_attr(struct configfs_dirent * sd, struct dentry * den | |||
442 | 442 | ||
443 | static struct dentry * configfs_lookup(struct inode *dir, | 443 | static struct dentry * configfs_lookup(struct inode *dir, |
444 | struct dentry *dentry, | 444 | struct dentry *dentry, |
445 | struct nameidata *nd) | 445 | unsigned int flags) |
446 | { | 446 | { |
447 | struct configfs_dirent * parent_sd = dentry->d_parent->d_fsdata; | 447 | struct configfs_dirent * parent_sd = dentry->d_parent->d_fsdata; |
448 | struct configfs_dirent * sd; | 448 | struct configfs_dirent * sd; |
diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c index d013c46402ed..28cca01ca9c9 100644 --- a/fs/cramfs/inode.c +++ b/fs/cramfs/inode.c | |||
@@ -417,7 +417,7 @@ static int cramfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
417 | /* | 417 | /* |
418 | * Lookup and fill in the inode data.. | 418 | * Lookup and fill in the inode data.. |
419 | */ | 419 | */ |
420 | static struct dentry * cramfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 420 | static struct dentry * cramfs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
421 | { | 421 | { |
422 | unsigned int offset = 0; | 422 | unsigned int offset = 0; |
423 | struct inode *inode = NULL; | 423 | struct inode *inode = NULL; |
diff --git a/fs/dcache.c b/fs/dcache.c index 85c9e2bff8e6..8086636bf796 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
@@ -218,7 +218,7 @@ static void __d_free(struct rcu_head *head) | |||
218 | { | 218 | { |
219 | struct dentry *dentry = container_of(head, struct dentry, d_u.d_rcu); | 219 | struct dentry *dentry = container_of(head, struct dentry, d_u.d_rcu); |
220 | 220 | ||
221 | WARN_ON(!list_empty(&dentry->d_alias)); | 221 | WARN_ON(!hlist_unhashed(&dentry->d_alias)); |
222 | if (dname_external(dentry)) | 222 | if (dname_external(dentry)) |
223 | kfree(dentry->d_name.name); | 223 | kfree(dentry->d_name.name); |
224 | kmem_cache_free(dentry_cache, dentry); | 224 | kmem_cache_free(dentry_cache, dentry); |
@@ -267,7 +267,7 @@ static void dentry_iput(struct dentry * dentry) | |||
267 | struct inode *inode = dentry->d_inode; | 267 | struct inode *inode = dentry->d_inode; |
268 | if (inode) { | 268 | if (inode) { |
269 | dentry->d_inode = NULL; | 269 | dentry->d_inode = NULL; |
270 | list_del_init(&dentry->d_alias); | 270 | hlist_del_init(&dentry->d_alias); |
271 | spin_unlock(&dentry->d_lock); | 271 | spin_unlock(&dentry->d_lock); |
272 | spin_unlock(&inode->i_lock); | 272 | spin_unlock(&inode->i_lock); |
273 | if (!inode->i_nlink) | 273 | if (!inode->i_nlink) |
@@ -291,7 +291,7 @@ static void dentry_unlink_inode(struct dentry * dentry) | |||
291 | { | 291 | { |
292 | struct inode *inode = dentry->d_inode; | 292 | struct inode *inode = dentry->d_inode; |
293 | dentry->d_inode = NULL; | 293 | dentry->d_inode = NULL; |
294 | list_del_init(&dentry->d_alias); | 294 | hlist_del_init(&dentry->d_alias); |
295 | dentry_rcuwalk_barrier(dentry); | 295 | dentry_rcuwalk_barrier(dentry); |
296 | spin_unlock(&dentry->d_lock); | 296 | spin_unlock(&dentry->d_lock); |
297 | spin_unlock(&inode->i_lock); | 297 | spin_unlock(&inode->i_lock); |
@@ -683,6 +683,8 @@ EXPORT_SYMBOL(dget_parent); | |||
683 | /** | 683 | /** |
684 | * d_find_alias - grab a hashed alias of inode | 684 | * d_find_alias - grab a hashed alias of inode |
685 | * @inode: inode in question | 685 | * @inode: inode in question |
686 | * @want_discon: flag, used by d_splice_alias, to request | ||
687 | * that only a DISCONNECTED alias be returned. | ||
686 | * | 688 | * |
687 | * If inode has a hashed alias, or is a directory and has any alias, | 689 | * If inode has a hashed alias, or is a directory and has any alias, |
688 | * acquire the reference to alias and return it. Otherwise return NULL. | 690 | * acquire the reference to alias and return it. Otherwise return NULL. |
@@ -691,21 +693,23 @@ EXPORT_SYMBOL(dget_parent); | |||
691 | * of a filesystem. | 693 | * of a filesystem. |
692 | * | 694 | * |
693 | * If the inode has an IS_ROOT, DCACHE_DISCONNECTED alias, then prefer | 695 | * If the inode has an IS_ROOT, DCACHE_DISCONNECTED alias, then prefer |
694 | * any other hashed alias over that. | 696 | * any other hashed alias over that one unless @want_discon is set, |
697 | * in which case only return an IS_ROOT, DCACHE_DISCONNECTED alias. | ||
695 | */ | 698 | */ |
696 | static struct dentry *__d_find_alias(struct inode *inode) | 699 | static struct dentry *__d_find_alias(struct inode *inode, int want_discon) |
697 | { | 700 | { |
698 | struct dentry *alias, *discon_alias; | 701 | struct dentry *alias, *discon_alias; |
702 | struct hlist_node *p; | ||
699 | 703 | ||
700 | again: | 704 | again: |
701 | discon_alias = NULL; | 705 | discon_alias = NULL; |
702 | list_for_each_entry(alias, &inode->i_dentry, d_alias) { | 706 | hlist_for_each_entry(alias, p, &inode->i_dentry, d_alias) { |
703 | spin_lock(&alias->d_lock); | 707 | spin_lock(&alias->d_lock); |
704 | if (S_ISDIR(inode->i_mode) || !d_unhashed(alias)) { | 708 | if (S_ISDIR(inode->i_mode) || !d_unhashed(alias)) { |
705 | if (IS_ROOT(alias) && | 709 | if (IS_ROOT(alias) && |
706 | (alias->d_flags & DCACHE_DISCONNECTED)) { | 710 | (alias->d_flags & DCACHE_DISCONNECTED)) { |
707 | discon_alias = alias; | 711 | discon_alias = alias; |
708 | } else { | 712 | } else if (!want_discon) { |
709 | __dget_dlock(alias); | 713 | __dget_dlock(alias); |
710 | spin_unlock(&alias->d_lock); | 714 | spin_unlock(&alias->d_lock); |
711 | return alias; | 715 | return alias; |
@@ -734,9 +738,9 @@ struct dentry *d_find_alias(struct inode *inode) | |||
734 | { | 738 | { |
735 | struct dentry *de = NULL; | 739 | struct dentry *de = NULL; |
736 | 740 | ||
737 | if (!list_empty(&inode->i_dentry)) { | 741 | if (!hlist_empty(&inode->i_dentry)) { |
738 | spin_lock(&inode->i_lock); | 742 | spin_lock(&inode->i_lock); |
739 | de = __d_find_alias(inode); | 743 | de = __d_find_alias(inode, 0); |
740 | spin_unlock(&inode->i_lock); | 744 | spin_unlock(&inode->i_lock); |
741 | } | 745 | } |
742 | return de; | 746 | return de; |
@@ -750,9 +754,10 @@ EXPORT_SYMBOL(d_find_alias); | |||
750 | void d_prune_aliases(struct inode *inode) | 754 | void d_prune_aliases(struct inode *inode) |
751 | { | 755 | { |
752 | struct dentry *dentry; | 756 | struct dentry *dentry; |
757 | struct hlist_node *p; | ||
753 | restart: | 758 | restart: |
754 | spin_lock(&inode->i_lock); | 759 | spin_lock(&inode->i_lock); |
755 | list_for_each_entry(dentry, &inode->i_dentry, d_alias) { | 760 | hlist_for_each_entry(dentry, p, &inode->i_dentry, d_alias) { |
756 | spin_lock(&dentry->d_lock); | 761 | spin_lock(&dentry->d_lock); |
757 | if (!dentry->d_count) { | 762 | if (!dentry->d_count) { |
758 | __dget_dlock(dentry); | 763 | __dget_dlock(dentry); |
@@ -974,7 +979,7 @@ static void shrink_dcache_for_umount_subtree(struct dentry *dentry) | |||
974 | inode = dentry->d_inode; | 979 | inode = dentry->d_inode; |
975 | if (inode) { | 980 | if (inode) { |
976 | dentry->d_inode = NULL; | 981 | dentry->d_inode = NULL; |
977 | list_del_init(&dentry->d_alias); | 982 | hlist_del_init(&dentry->d_alias); |
978 | if (dentry->d_op && dentry->d_op->d_iput) | 983 | if (dentry->d_op && dentry->d_op->d_iput) |
979 | dentry->d_op->d_iput(dentry, inode); | 984 | dentry->d_op->d_iput(dentry, inode); |
980 | else | 985 | else |
@@ -1309,7 +1314,7 @@ struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name) | |||
1309 | INIT_HLIST_BL_NODE(&dentry->d_hash); | 1314 | INIT_HLIST_BL_NODE(&dentry->d_hash); |
1310 | INIT_LIST_HEAD(&dentry->d_lru); | 1315 | INIT_LIST_HEAD(&dentry->d_lru); |
1311 | INIT_LIST_HEAD(&dentry->d_subdirs); | 1316 | INIT_LIST_HEAD(&dentry->d_subdirs); |
1312 | INIT_LIST_HEAD(&dentry->d_alias); | 1317 | INIT_HLIST_NODE(&dentry->d_alias); |
1313 | INIT_LIST_HEAD(&dentry->d_u.d_child); | 1318 | INIT_LIST_HEAD(&dentry->d_u.d_child); |
1314 | d_set_d_op(dentry, dentry->d_sb->s_d_op); | 1319 | d_set_d_op(dentry, dentry->d_sb->s_d_op); |
1315 | 1320 | ||
@@ -1397,7 +1402,7 @@ static void __d_instantiate(struct dentry *dentry, struct inode *inode) | |||
1397 | if (inode) { | 1402 | if (inode) { |
1398 | if (unlikely(IS_AUTOMOUNT(inode))) | 1403 | if (unlikely(IS_AUTOMOUNT(inode))) |
1399 | dentry->d_flags |= DCACHE_NEED_AUTOMOUNT; | 1404 | dentry->d_flags |= DCACHE_NEED_AUTOMOUNT; |
1400 | list_add(&dentry->d_alias, &inode->i_dentry); | 1405 | hlist_add_head(&dentry->d_alias, &inode->i_dentry); |
1401 | } | 1406 | } |
1402 | dentry->d_inode = inode; | 1407 | dentry->d_inode = inode; |
1403 | dentry_rcuwalk_barrier(dentry); | 1408 | dentry_rcuwalk_barrier(dentry); |
@@ -1422,7 +1427,7 @@ static void __d_instantiate(struct dentry *dentry, struct inode *inode) | |||
1422 | 1427 | ||
1423 | void d_instantiate(struct dentry *entry, struct inode * inode) | 1428 | void d_instantiate(struct dentry *entry, struct inode * inode) |
1424 | { | 1429 | { |
1425 | BUG_ON(!list_empty(&entry->d_alias)); | 1430 | BUG_ON(!hlist_unhashed(&entry->d_alias)); |
1426 | if (inode) | 1431 | if (inode) |
1427 | spin_lock(&inode->i_lock); | 1432 | spin_lock(&inode->i_lock); |
1428 | __d_instantiate(entry, inode); | 1433 | __d_instantiate(entry, inode); |
@@ -1455,13 +1460,14 @@ static struct dentry *__d_instantiate_unique(struct dentry *entry, | |||
1455 | int len = entry->d_name.len; | 1460 | int len = entry->d_name.len; |
1456 | const char *name = entry->d_name.name; | 1461 | const char *name = entry->d_name.name; |
1457 | unsigned int hash = entry->d_name.hash; | 1462 | unsigned int hash = entry->d_name.hash; |
1463 | struct hlist_node *p; | ||
1458 | 1464 | ||
1459 | if (!inode) { | 1465 | if (!inode) { |
1460 | __d_instantiate(entry, NULL); | 1466 | __d_instantiate(entry, NULL); |
1461 | return NULL; | 1467 | return NULL; |
1462 | } | 1468 | } |
1463 | 1469 | ||
1464 | list_for_each_entry(alias, &inode->i_dentry, d_alias) { | 1470 | hlist_for_each_entry(alias, p, &inode->i_dentry, d_alias) { |
1465 | /* | 1471 | /* |
1466 | * Don't need alias->d_lock here, because aliases with | 1472 | * Don't need alias->d_lock here, because aliases with |
1467 | * d_parent == entry->d_parent are not subject to name or | 1473 | * d_parent == entry->d_parent are not subject to name or |
@@ -1487,7 +1493,7 @@ struct dentry *d_instantiate_unique(struct dentry *entry, struct inode *inode) | |||
1487 | { | 1493 | { |
1488 | struct dentry *result; | 1494 | struct dentry *result; |
1489 | 1495 | ||
1490 | BUG_ON(!list_empty(&entry->d_alias)); | 1496 | BUG_ON(!hlist_unhashed(&entry->d_alias)); |
1491 | 1497 | ||
1492 | if (inode) | 1498 | if (inode) |
1493 | spin_lock(&inode->i_lock); | 1499 | spin_lock(&inode->i_lock); |
@@ -1528,9 +1534,9 @@ static struct dentry * __d_find_any_alias(struct inode *inode) | |||
1528 | { | 1534 | { |
1529 | struct dentry *alias; | 1535 | struct dentry *alias; |
1530 | 1536 | ||
1531 | if (list_empty(&inode->i_dentry)) | 1537 | if (hlist_empty(&inode->i_dentry)) |
1532 | return NULL; | 1538 | return NULL; |
1533 | alias = list_first_entry(&inode->i_dentry, struct dentry, d_alias); | 1539 | alias = hlist_entry(inode->i_dentry.first, struct dentry, d_alias); |
1534 | __dget(alias); | 1540 | __dget(alias); |
1535 | return alias; | 1541 | return alias; |
1536 | } | 1542 | } |
@@ -1604,7 +1610,7 @@ struct dentry *d_obtain_alias(struct inode *inode) | |||
1604 | spin_lock(&tmp->d_lock); | 1610 | spin_lock(&tmp->d_lock); |
1605 | tmp->d_inode = inode; | 1611 | tmp->d_inode = inode; |
1606 | tmp->d_flags |= DCACHE_DISCONNECTED; | 1612 | tmp->d_flags |= DCACHE_DISCONNECTED; |
1607 | list_add(&tmp->d_alias, &inode->i_dentry); | 1613 | hlist_add_head(&tmp->d_alias, &inode->i_dentry); |
1608 | hlist_bl_lock(&tmp->d_sb->s_anon); | 1614 | hlist_bl_lock(&tmp->d_sb->s_anon); |
1609 | hlist_bl_add_head(&tmp->d_hash, &tmp->d_sb->s_anon); | 1615 | hlist_bl_add_head(&tmp->d_hash, &tmp->d_sb->s_anon); |
1610 | hlist_bl_unlock(&tmp->d_sb->s_anon); | 1616 | hlist_bl_unlock(&tmp->d_sb->s_anon); |
@@ -1647,8 +1653,9 @@ struct dentry *d_splice_alias(struct inode *inode, struct dentry *dentry) | |||
1647 | 1653 | ||
1648 | if (inode && S_ISDIR(inode->i_mode)) { | 1654 | if (inode && S_ISDIR(inode->i_mode)) { |
1649 | spin_lock(&inode->i_lock); | 1655 | spin_lock(&inode->i_lock); |
1650 | new = __d_find_any_alias(inode); | 1656 | new = __d_find_alias(inode, 1); |
1651 | if (new) { | 1657 | if (new) { |
1658 | BUG_ON(!(new->d_flags & DCACHE_DISCONNECTED)); | ||
1652 | spin_unlock(&inode->i_lock); | 1659 | spin_unlock(&inode->i_lock); |
1653 | security_d_instantiate(new, inode); | 1660 | security_d_instantiate(new, inode); |
1654 | d_move(new, dentry); | 1661 | d_move(new, dentry); |
@@ -2380,14 +2387,13 @@ static struct dentry *__d_unalias(struct inode *inode, | |||
2380 | struct dentry *dentry, struct dentry *alias) | 2387 | struct dentry *dentry, struct dentry *alias) |
2381 | { | 2388 | { |
2382 | struct mutex *m1 = NULL, *m2 = NULL; | 2389 | struct mutex *m1 = NULL, *m2 = NULL; |
2383 | struct dentry *ret; | 2390 | struct dentry *ret = ERR_PTR(-EBUSY); |
2384 | 2391 | ||
2385 | /* If alias and dentry share a parent, then no extra locks required */ | 2392 | /* If alias and dentry share a parent, then no extra locks required */ |
2386 | if (alias->d_parent == dentry->d_parent) | 2393 | if (alias->d_parent == dentry->d_parent) |
2387 | goto out_unalias; | 2394 | goto out_unalias; |
2388 | 2395 | ||
2389 | /* See lock_rename() */ | 2396 | /* See lock_rename() */ |
2390 | ret = ERR_PTR(-EBUSY); | ||
2391 | if (!mutex_trylock(&dentry->d_sb->s_vfs_rename_mutex)) | 2397 | if (!mutex_trylock(&dentry->d_sb->s_vfs_rename_mutex)) |
2392 | goto out_err; | 2398 | goto out_err; |
2393 | m1 = &dentry->d_sb->s_vfs_rename_mutex; | 2399 | m1 = &dentry->d_sb->s_vfs_rename_mutex; |
@@ -2395,8 +2401,10 @@ static struct dentry *__d_unalias(struct inode *inode, | |||
2395 | goto out_err; | 2401 | goto out_err; |
2396 | m2 = &alias->d_parent->d_inode->i_mutex; | 2402 | m2 = &alias->d_parent->d_inode->i_mutex; |
2397 | out_unalias: | 2403 | out_unalias: |
2398 | __d_move(alias, dentry); | 2404 | if (likely(!d_mountpoint(alias))) { |
2399 | ret = alias; | 2405 | __d_move(alias, dentry); |
2406 | ret = alias; | ||
2407 | } | ||
2400 | out_err: | 2408 | out_err: |
2401 | spin_unlock(&inode->i_lock); | 2409 | spin_unlock(&inode->i_lock); |
2402 | if (m2) | 2410 | if (m2) |
@@ -2478,7 +2486,7 @@ struct dentry *d_materialise_unique(struct dentry *dentry, struct inode *inode) | |||
2478 | struct dentry *alias; | 2486 | struct dentry *alias; |
2479 | 2487 | ||
2480 | /* Does an aliased dentry already exist? */ | 2488 | /* Does an aliased dentry already exist? */ |
2481 | alias = __d_find_alias(inode); | 2489 | alias = __d_find_alias(inode, 0); |
2482 | if (alias) { | 2490 | if (alias) { |
2483 | actual = alias; | 2491 | actual = alias; |
2484 | write_seqlock(&rename_lock); | 2492 | write_seqlock(&rename_lock); |
@@ -2618,7 +2626,7 @@ global_root: | |||
2618 | if (!slash) | 2626 | if (!slash) |
2619 | error = prepend(buffer, buflen, "/", 1); | 2627 | error = prepend(buffer, buflen, "/", 1); |
2620 | if (!error) | 2628 | if (!error) |
2621 | error = real_mount(vfsmnt)->mnt_ns ? 1 : 2; | 2629 | error = is_mounted(vfsmnt) ? 1 : 2; |
2622 | goto out; | 2630 | goto out; |
2623 | } | 2631 | } |
2624 | 2632 | ||
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index b80bc846a15a..d17c20fd74e6 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c | |||
@@ -54,13 +54,12 @@ static struct inode *debugfs_get_inode(struct super_block *sb, umode_t mode, dev | |||
54 | break; | 54 | break; |
55 | case S_IFLNK: | 55 | case S_IFLNK: |
56 | inode->i_op = &debugfs_link_operations; | 56 | inode->i_op = &debugfs_link_operations; |
57 | inode->i_fop = fops; | ||
58 | inode->i_private = data; | 57 | inode->i_private = data; |
59 | break; | 58 | break; |
60 | case S_IFDIR: | 59 | case S_IFDIR: |
61 | inode->i_op = &simple_dir_inode_operations; | 60 | inode->i_op = &simple_dir_inode_operations; |
62 | inode->i_fop = fops ? fops : &simple_dir_operations; | 61 | inode->i_fop = &simple_dir_operations; |
63 | inode->i_private = data; | 62 | inode->i_private = NULL; |
64 | 63 | ||
65 | /* directory inodes start off with i_nlink == 2 | 64 | /* directory inodes start off with i_nlink == 2 |
66 | * (for "." entry) */ | 65 | * (for "." entry) */ |
@@ -91,13 +90,12 @@ static int debugfs_mknod(struct inode *dir, struct dentry *dentry, | |||
91 | return error; | 90 | return error; |
92 | } | 91 | } |
93 | 92 | ||
94 | static int debugfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode, | 93 | static int debugfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) |
95 | void *data, const struct file_operations *fops) | ||
96 | { | 94 | { |
97 | int res; | 95 | int res; |
98 | 96 | ||
99 | mode = (mode & (S_IRWXUGO | S_ISVTX)) | S_IFDIR; | 97 | mode = (mode & (S_IRWXUGO | S_ISVTX)) | S_IFDIR; |
100 | res = debugfs_mknod(dir, dentry, mode, 0, data, fops); | 98 | res = debugfs_mknod(dir, dentry, mode, 0, NULL, NULL); |
101 | if (!res) { | 99 | if (!res) { |
102 | inc_nlink(dir); | 100 | inc_nlink(dir); |
103 | fsnotify_mkdir(dir, dentry); | 101 | fsnotify_mkdir(dir, dentry); |
@@ -106,10 +104,10 @@ static int debugfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode, | |||
106 | } | 104 | } |
107 | 105 | ||
108 | static int debugfs_link(struct inode *dir, struct dentry *dentry, umode_t mode, | 106 | static int debugfs_link(struct inode *dir, struct dentry *dentry, umode_t mode, |
109 | void *data, const struct file_operations *fops) | 107 | void *data) |
110 | { | 108 | { |
111 | mode = (mode & S_IALLUGO) | S_IFLNK; | 109 | mode = (mode & S_IALLUGO) | S_IFLNK; |
112 | return debugfs_mknod(dir, dentry, mode, 0, data, fops); | 110 | return debugfs_mknod(dir, dentry, mode, 0, data, NULL); |
113 | } | 111 | } |
114 | 112 | ||
115 | static int debugfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 113 | static int debugfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
@@ -293,13 +291,19 @@ static struct file_system_type debug_fs_type = { | |||
293 | .kill_sb = kill_litter_super, | 291 | .kill_sb = kill_litter_super, |
294 | }; | 292 | }; |
295 | 293 | ||
296 | static int debugfs_create_by_name(const char *name, umode_t mode, | 294 | struct dentry *__create_file(const char *name, umode_t mode, |
297 | struct dentry *parent, | 295 | struct dentry *parent, void *data, |
298 | struct dentry **dentry, | 296 | const struct file_operations *fops) |
299 | void *data, | ||
300 | const struct file_operations *fops) | ||
301 | { | 297 | { |
302 | int error = 0; | 298 | struct dentry *dentry = NULL; |
299 | int error; | ||
300 | |||
301 | pr_debug("debugfs: creating file '%s'\n",name); | ||
302 | |||
303 | error = simple_pin_fs(&debug_fs_type, &debugfs_mount, | ||
304 | &debugfs_mount_count); | ||
305 | if (error) | ||
306 | goto exit; | ||
303 | 307 | ||
304 | /* If the parent is not specified, we create it in the root. | 308 | /* If the parent is not specified, we create it in the root. |
305 | * We need the root dentry to do this, which is in the super | 309 | * We need the root dentry to do this, which is in the super |
@@ -309,30 +313,35 @@ static int debugfs_create_by_name(const char *name, umode_t mode, | |||
309 | if (!parent) | 313 | if (!parent) |
310 | parent = debugfs_mount->mnt_root; | 314 | parent = debugfs_mount->mnt_root; |
311 | 315 | ||
312 | *dentry = NULL; | 316 | dentry = NULL; |
313 | mutex_lock(&parent->d_inode->i_mutex); | 317 | mutex_lock(&parent->d_inode->i_mutex); |
314 | *dentry = lookup_one_len(name, parent, strlen(name)); | 318 | dentry = lookup_one_len(name, parent, strlen(name)); |
315 | if (!IS_ERR(*dentry)) { | 319 | if (!IS_ERR(dentry)) { |
316 | switch (mode & S_IFMT) { | 320 | switch (mode & S_IFMT) { |
317 | case S_IFDIR: | 321 | case S_IFDIR: |
318 | error = debugfs_mkdir(parent->d_inode, *dentry, mode, | 322 | error = debugfs_mkdir(parent->d_inode, dentry, mode); |
319 | data, fops); | 323 | |
320 | break; | 324 | break; |
321 | case S_IFLNK: | 325 | case S_IFLNK: |
322 | error = debugfs_link(parent->d_inode, *dentry, mode, | 326 | error = debugfs_link(parent->d_inode, dentry, mode, |
323 | data, fops); | 327 | data); |
324 | break; | 328 | break; |
325 | default: | 329 | default: |
326 | error = debugfs_create(parent->d_inode, *dentry, mode, | 330 | error = debugfs_create(parent->d_inode, dentry, mode, |
327 | data, fops); | 331 | data, fops); |
328 | break; | 332 | break; |
329 | } | 333 | } |
330 | dput(*dentry); | 334 | dput(dentry); |
331 | } else | 335 | } else |
332 | error = PTR_ERR(*dentry); | 336 | error = PTR_ERR(dentry); |
333 | mutex_unlock(&parent->d_inode->i_mutex); | 337 | mutex_unlock(&parent->d_inode->i_mutex); |
334 | 338 | ||
335 | return error; | 339 | if (error) { |
340 | dentry = NULL; | ||
341 | simple_release_fs(&debugfs_mount, &debugfs_mount_count); | ||
342 | } | ||
343 | exit: | ||
344 | return dentry; | ||
336 | } | 345 | } |
337 | 346 | ||
338 | /** | 347 | /** |
@@ -365,25 +374,15 @@ struct dentry *debugfs_create_file(const char *name, umode_t mode, | |||
365 | struct dentry *parent, void *data, | 374 | struct dentry *parent, void *data, |
366 | const struct file_operations *fops) | 375 | const struct file_operations *fops) |
367 | { | 376 | { |
368 | struct dentry *dentry = NULL; | 377 | switch (mode & S_IFMT) { |
369 | int error; | 378 | case S_IFREG: |
370 | 379 | case 0: | |
371 | pr_debug("debugfs: creating file '%s'\n",name); | 380 | break; |
372 | 381 | default: | |
373 | error = simple_pin_fs(&debug_fs_type, &debugfs_mount, | 382 | BUG(); |
374 | &debugfs_mount_count); | ||
375 | if (error) | ||
376 | goto exit; | ||
377 | |||
378 | error = debugfs_create_by_name(name, mode, parent, &dentry, | ||
379 | data, fops); | ||
380 | if (error) { | ||
381 | dentry = NULL; | ||
382 | simple_release_fs(&debugfs_mount, &debugfs_mount_count); | ||
383 | goto exit; | ||
384 | } | 383 | } |
385 | exit: | 384 | |
386 | return dentry; | 385 | return __create_file(name, mode, parent, data, fops); |
387 | } | 386 | } |
388 | EXPORT_SYMBOL_GPL(debugfs_create_file); | 387 | EXPORT_SYMBOL_GPL(debugfs_create_file); |
389 | 388 | ||
@@ -407,8 +406,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_file); | |||
407 | */ | 406 | */ |
408 | struct dentry *debugfs_create_dir(const char *name, struct dentry *parent) | 407 | struct dentry *debugfs_create_dir(const char *name, struct dentry *parent) |
409 | { | 408 | { |
410 | return debugfs_create_file(name, | 409 | return __create_file(name, S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO, |
411 | S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO, | ||
412 | parent, NULL, NULL); | 410 | parent, NULL, NULL); |
413 | } | 411 | } |
414 | EXPORT_SYMBOL_GPL(debugfs_create_dir); | 412 | EXPORT_SYMBOL_GPL(debugfs_create_dir); |
@@ -446,8 +444,7 @@ struct dentry *debugfs_create_symlink(const char *name, struct dentry *parent, | |||
446 | if (!link) | 444 | if (!link) |
447 | return NULL; | 445 | return NULL; |
448 | 446 | ||
449 | result = debugfs_create_file(name, S_IFLNK | S_IRWXUGO, parent, link, | 447 | result = __create_file(name, S_IFLNK | S_IRWXUGO, parent, link, NULL); |
450 | NULL); | ||
451 | if (!result) | 448 | if (!result) |
452 | kfree(link); | 449 | kfree(link); |
453 | return result; | 450 | return result; |
diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c index 979c1e309c73..14afbabe6546 100644 --- a/fs/devpts/inode.c +++ b/fs/devpts/inode.c | |||
@@ -439,15 +439,15 @@ static struct dentry *devpts_mount(struct file_system_type *fs_type, | |||
439 | return ERR_PTR(error); | 439 | return ERR_PTR(error); |
440 | 440 | ||
441 | if (opts.newinstance) | 441 | if (opts.newinstance) |
442 | s = sget(fs_type, NULL, set_anon_super, NULL); | 442 | s = sget(fs_type, NULL, set_anon_super, flags, NULL); |
443 | else | 443 | else |
444 | s = sget(fs_type, compare_init_pts_sb, set_anon_super, NULL); | 444 | s = sget(fs_type, compare_init_pts_sb, set_anon_super, flags, |
445 | NULL); | ||
445 | 446 | ||
446 | if (IS_ERR(s)) | 447 | if (IS_ERR(s)) |
447 | return ERR_CAST(s); | 448 | return ERR_CAST(s); |
448 | 449 | ||
449 | if (!s->s_root) { | 450 | if (!s->s_root) { |
450 | s->s_flags = flags; | ||
451 | error = devpts_fill_super(s, data, flags & MS_SILENT ? 1 : 0); | 451 | error = devpts_fill_super(s, data, flags & MS_SILENT ? 1 : 0); |
452 | if (error) | 452 | if (error) |
453 | goto out_undo_sget; | 453 | goto out_undo_sget; |
diff --git a/fs/direct-io.c b/fs/direct-io.c index 0c85fae37666..1faf4cb56f39 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c | |||
@@ -1258,7 +1258,7 @@ do_blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode, | |||
1258 | */ | 1258 | */ |
1259 | BUG_ON(retval == -EIOCBQUEUED); | 1259 | BUG_ON(retval == -EIOCBQUEUED); |
1260 | if (dio->is_async && retval == 0 && dio->result && | 1260 | if (dio->is_async && retval == 0 && dio->result && |
1261 | ((rw & READ) || (dio->result == sdio.size))) | 1261 | ((rw == READ) || (dio->result == sdio.size))) |
1262 | retval = -EIOCBQUEUED; | 1262 | retval = -EIOCBQUEUED; |
1263 | 1263 | ||
1264 | if (retval != -EIOCBQUEUED) | 1264 | if (retval != -EIOCBQUEUED) |
diff --git a/fs/ecryptfs/dentry.c b/fs/ecryptfs/dentry.c index 534c1d46e69e..1b5d9af937df 100644 --- a/fs/ecryptfs/dentry.c +++ b/fs/ecryptfs/dentry.c | |||
@@ -32,7 +32,7 @@ | |||
32 | /** | 32 | /** |
33 | * ecryptfs_d_revalidate - revalidate an ecryptfs dentry | 33 | * ecryptfs_d_revalidate - revalidate an ecryptfs dentry |
34 | * @dentry: The ecryptfs dentry | 34 | * @dentry: The ecryptfs dentry |
35 | * @nd: The associated nameidata | 35 | * @flags: lookup flags |
36 | * | 36 | * |
37 | * Called when the VFS needs to revalidate a dentry. This | 37 | * Called when the VFS needs to revalidate a dentry. This |
38 | * is called whenever a name lookup finds a dentry in the | 38 | * is called whenever a name lookup finds a dentry in the |
@@ -42,32 +42,20 @@ | |||
42 | * Returns 1 if valid, 0 otherwise. | 42 | * Returns 1 if valid, 0 otherwise. |
43 | * | 43 | * |
44 | */ | 44 | */ |
45 | static int ecryptfs_d_revalidate(struct dentry *dentry, struct nameidata *nd) | 45 | static int ecryptfs_d_revalidate(struct dentry *dentry, unsigned int flags) |
46 | { | 46 | { |
47 | struct dentry *lower_dentry; | 47 | struct dentry *lower_dentry; |
48 | struct vfsmount *lower_mnt; | 48 | struct vfsmount *lower_mnt; |
49 | struct dentry *dentry_save = NULL; | ||
50 | struct vfsmount *vfsmount_save = NULL; | ||
51 | int rc = 1; | 49 | int rc = 1; |
52 | 50 | ||
53 | if (nd && nd->flags & LOOKUP_RCU) | 51 | if (flags & LOOKUP_RCU) |
54 | return -ECHILD; | 52 | return -ECHILD; |
55 | 53 | ||
56 | lower_dentry = ecryptfs_dentry_to_lower(dentry); | 54 | lower_dentry = ecryptfs_dentry_to_lower(dentry); |
57 | lower_mnt = ecryptfs_dentry_to_lower_mnt(dentry); | 55 | lower_mnt = ecryptfs_dentry_to_lower_mnt(dentry); |
58 | if (!lower_dentry->d_op || !lower_dentry->d_op->d_revalidate) | 56 | if (!lower_dentry->d_op || !lower_dentry->d_op->d_revalidate) |
59 | goto out; | 57 | goto out; |
60 | if (nd) { | 58 | rc = lower_dentry->d_op->d_revalidate(lower_dentry, flags); |
61 | dentry_save = nd->path.dentry; | ||
62 | vfsmount_save = nd->path.mnt; | ||
63 | nd->path.dentry = lower_dentry; | ||
64 | nd->path.mnt = lower_mnt; | ||
65 | } | ||
66 | rc = lower_dentry->d_op->d_revalidate(lower_dentry, nd); | ||
67 | if (nd) { | ||
68 | nd->path.dentry = dentry_save; | ||
69 | nd->path.mnt = vfsmount_save; | ||
70 | } | ||
71 | if (dentry->d_inode) { | 59 | if (dentry->d_inode) { |
72 | struct inode *lower_inode = | 60 | struct inode *lower_inode = |
73 | ecryptfs_inode_to_lower(dentry->d_inode); | 61 | ecryptfs_inode_to_lower(dentry->d_inode); |
diff --git a/fs/ecryptfs/ecryptfs_kernel.h b/fs/ecryptfs/ecryptfs_kernel.h index 867b64c5d84f..989e034f02bd 100644 --- a/fs/ecryptfs/ecryptfs_kernel.h +++ b/fs/ecryptfs/ecryptfs_kernel.h | |||
@@ -550,20 +550,6 @@ extern struct kmem_cache *ecryptfs_key_record_cache; | |||
550 | extern struct kmem_cache *ecryptfs_key_sig_cache; | 550 | extern struct kmem_cache *ecryptfs_key_sig_cache; |
551 | extern struct kmem_cache *ecryptfs_global_auth_tok_cache; | 551 | extern struct kmem_cache *ecryptfs_global_auth_tok_cache; |
552 | extern struct kmem_cache *ecryptfs_key_tfm_cache; | 552 | extern struct kmem_cache *ecryptfs_key_tfm_cache; |
553 | extern struct kmem_cache *ecryptfs_open_req_cache; | ||
554 | |||
555 | struct ecryptfs_open_req { | ||
556 | #define ECRYPTFS_REQ_PROCESSED 0x00000001 | ||
557 | #define ECRYPTFS_REQ_DROPPED 0x00000002 | ||
558 | #define ECRYPTFS_REQ_ZOMBIE 0x00000004 | ||
559 | u32 flags; | ||
560 | struct file **lower_file; | ||
561 | struct dentry *lower_dentry; | ||
562 | struct vfsmount *lower_mnt; | ||
563 | wait_queue_head_t wait; | ||
564 | struct mutex mux; | ||
565 | struct list_head kthread_ctl_list; | ||
566 | }; | ||
567 | 553 | ||
568 | struct inode *ecryptfs_get_inode(struct inode *lower_inode, | 554 | struct inode *ecryptfs_get_inode(struct inode *lower_inode, |
569 | struct super_block *sb); | 555 | struct super_block *sb); |
diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c index a07441a0a878..ffa2be57804d 100644 --- a/fs/ecryptfs/inode.c +++ b/fs/ecryptfs/inode.c | |||
@@ -173,7 +173,7 @@ ecryptfs_do_create(struct inode *directory_inode, | |||
173 | inode = ERR_CAST(lower_dir_dentry); | 173 | inode = ERR_CAST(lower_dir_dentry); |
174 | goto out; | 174 | goto out; |
175 | } | 175 | } |
176 | rc = vfs_create(lower_dir_dentry->d_inode, lower_dentry, mode, NULL); | 176 | rc = vfs_create(lower_dir_dentry->d_inode, lower_dentry, mode, true); |
177 | if (rc) { | 177 | if (rc) { |
178 | printk(KERN_ERR "%s: Failure to create dentry in lower fs; " | 178 | printk(KERN_ERR "%s: Failure to create dentry in lower fs; " |
179 | "rc = [%d]\n", __func__, rc); | 179 | "rc = [%d]\n", __func__, rc); |
@@ -240,7 +240,6 @@ out: | |||
240 | * @dir: The inode of the directory in which to create the file. | 240 | * @dir: The inode of the directory in which to create the file. |
241 | * @dentry: The eCryptfs dentry | 241 | * @dentry: The eCryptfs dentry |
242 | * @mode: The mode of the new file. | 242 | * @mode: The mode of the new file. |
243 | * @nd: nameidata | ||
244 | * | 243 | * |
245 | * Creates a new file. | 244 | * Creates a new file. |
246 | * | 245 | * |
@@ -248,7 +247,7 @@ out: | |||
248 | */ | 247 | */ |
249 | static int | 248 | static int |
250 | ecryptfs_create(struct inode *directory_inode, struct dentry *ecryptfs_dentry, | 249 | ecryptfs_create(struct inode *directory_inode, struct dentry *ecryptfs_dentry, |
251 | umode_t mode, struct nameidata *nd) | 250 | umode_t mode, bool excl) |
252 | { | 251 | { |
253 | struct inode *ecryptfs_inode; | 252 | struct inode *ecryptfs_inode; |
254 | int rc; | 253 | int rc; |
@@ -270,8 +269,8 @@ ecryptfs_create(struct inode *directory_inode, struct dentry *ecryptfs_dentry, | |||
270 | iput(ecryptfs_inode); | 269 | iput(ecryptfs_inode); |
271 | goto out; | 270 | goto out; |
272 | } | 271 | } |
273 | d_instantiate(ecryptfs_dentry, ecryptfs_inode); | ||
274 | unlock_new_inode(ecryptfs_inode); | 272 | unlock_new_inode(ecryptfs_inode); |
273 | d_instantiate(ecryptfs_dentry, ecryptfs_inode); | ||
275 | out: | 274 | out: |
276 | return rc; | 275 | return rc; |
277 | } | 276 | } |
@@ -374,7 +373,7 @@ static int ecryptfs_lookup_interpose(struct dentry *dentry, | |||
374 | */ | 373 | */ |
375 | static struct dentry *ecryptfs_lookup(struct inode *ecryptfs_dir_inode, | 374 | static struct dentry *ecryptfs_lookup(struct inode *ecryptfs_dir_inode, |
376 | struct dentry *ecryptfs_dentry, | 375 | struct dentry *ecryptfs_dentry, |
377 | struct nameidata *ecryptfs_nd) | 376 | unsigned int flags) |
378 | { | 377 | { |
379 | char *encrypted_and_encoded_name = NULL; | 378 | char *encrypted_and_encoded_name = NULL; |
380 | size_t encrypted_and_encoded_name_size; | 379 | size_t encrypted_and_encoded_name_size; |
diff --git a/fs/ecryptfs/kthread.c b/fs/ecryptfs/kthread.c index 69f994a7d524..809e67d05ca3 100644 --- a/fs/ecryptfs/kthread.c +++ b/fs/ecryptfs/kthread.c | |||
@@ -27,7 +27,12 @@ | |||
27 | #include <linux/mount.h> | 27 | #include <linux/mount.h> |
28 | #include "ecryptfs_kernel.h" | 28 | #include "ecryptfs_kernel.h" |
29 | 29 | ||
30 | struct kmem_cache *ecryptfs_open_req_cache; | 30 | struct ecryptfs_open_req { |
31 | struct file **lower_file; | ||
32 | struct path path; | ||
33 | struct completion done; | ||
34 | struct list_head kthread_ctl_list; | ||
35 | }; | ||
31 | 36 | ||
32 | static struct ecryptfs_kthread_ctl { | 37 | static struct ecryptfs_kthread_ctl { |
33 | #define ECRYPTFS_KTHREAD_ZOMBIE 0x00000001 | 38 | #define ECRYPTFS_KTHREAD_ZOMBIE 0x00000001 |
@@ -67,18 +72,10 @@ static int ecryptfs_threadfn(void *ignored) | |||
67 | req = list_first_entry(&ecryptfs_kthread_ctl.req_list, | 72 | req = list_first_entry(&ecryptfs_kthread_ctl.req_list, |
68 | struct ecryptfs_open_req, | 73 | struct ecryptfs_open_req, |
69 | kthread_ctl_list); | 74 | kthread_ctl_list); |
70 | mutex_lock(&req->mux); | ||
71 | list_del(&req->kthread_ctl_list); | 75 | list_del(&req->kthread_ctl_list); |
72 | if (!(req->flags & ECRYPTFS_REQ_ZOMBIE)) { | 76 | *req->lower_file = dentry_open(&req->path, |
73 | dget(req->lower_dentry); | 77 | (O_RDWR | O_LARGEFILE), current_cred()); |
74 | mntget(req->lower_mnt); | 78 | complete(&req->done); |
75 | (*req->lower_file) = dentry_open( | ||
76 | req->lower_dentry, req->lower_mnt, | ||
77 | (O_RDWR | O_LARGEFILE), current_cred()); | ||
78 | req->flags |= ECRYPTFS_REQ_PROCESSED; | ||
79 | } | ||
80 | wake_up(&req->wait); | ||
81 | mutex_unlock(&req->mux); | ||
82 | } | 79 | } |
83 | mutex_unlock(&ecryptfs_kthread_ctl.mux); | 80 | mutex_unlock(&ecryptfs_kthread_ctl.mux); |
84 | } | 81 | } |
@@ -111,10 +108,9 @@ void ecryptfs_destroy_kthread(void) | |||
111 | ecryptfs_kthread_ctl.flags |= ECRYPTFS_KTHREAD_ZOMBIE; | 108 | ecryptfs_kthread_ctl.flags |= ECRYPTFS_KTHREAD_ZOMBIE; |
112 | list_for_each_entry(req, &ecryptfs_kthread_ctl.req_list, | 109 | list_for_each_entry(req, &ecryptfs_kthread_ctl.req_list, |
113 | kthread_ctl_list) { | 110 | kthread_ctl_list) { |
114 | mutex_lock(&req->mux); | 111 | list_del(&req->kthread_ctl_list); |
115 | req->flags |= ECRYPTFS_REQ_ZOMBIE; | 112 | *req->lower_file = ERR_PTR(-EIO); |
116 | wake_up(&req->wait); | 113 | complete(&req->done); |
117 | mutex_unlock(&req->mux); | ||
118 | } | 114 | } |
119 | mutex_unlock(&ecryptfs_kthread_ctl.mux); | 115 | mutex_unlock(&ecryptfs_kthread_ctl.mux); |
120 | kthread_stop(ecryptfs_kthread); | 116 | kthread_stop(ecryptfs_kthread); |
@@ -136,34 +132,26 @@ int ecryptfs_privileged_open(struct file **lower_file, | |||
136 | struct vfsmount *lower_mnt, | 132 | struct vfsmount *lower_mnt, |
137 | const struct cred *cred) | 133 | const struct cred *cred) |
138 | { | 134 | { |
139 | struct ecryptfs_open_req *req; | 135 | struct ecryptfs_open_req req; |
140 | int flags = O_LARGEFILE; | 136 | int flags = O_LARGEFILE; |
141 | int rc = 0; | 137 | int rc = 0; |
142 | 138 | ||
139 | init_completion(&req.done); | ||
140 | req.lower_file = lower_file; | ||
141 | req.path.dentry = lower_dentry; | ||
142 | req.path.mnt = lower_mnt; | ||
143 | |||
143 | /* Corresponding dput() and mntput() are done when the | 144 | /* Corresponding dput() and mntput() are done when the |
144 | * lower file is fput() when all eCryptfs files for the inode are | 145 | * lower file is fput() when all eCryptfs files for the inode are |
145 | * released. */ | 146 | * released. */ |
146 | dget(lower_dentry); | ||
147 | mntget(lower_mnt); | ||
148 | flags |= IS_RDONLY(lower_dentry->d_inode) ? O_RDONLY : O_RDWR; | 147 | flags |= IS_RDONLY(lower_dentry->d_inode) ? O_RDONLY : O_RDWR; |
149 | (*lower_file) = dentry_open(lower_dentry, lower_mnt, flags, cred); | 148 | (*lower_file) = dentry_open(&req.path, flags, cred); |
150 | if (!IS_ERR(*lower_file)) | 149 | if (!IS_ERR(*lower_file)) |
151 | goto out; | 150 | goto out; |
152 | if (flags & O_RDONLY) { | 151 | if ((flags & O_ACCMODE) == O_RDONLY) { |
153 | rc = PTR_ERR((*lower_file)); | 152 | rc = PTR_ERR((*lower_file)); |
154 | goto out; | 153 | goto out; |
155 | } | 154 | } |
156 | req = kmem_cache_alloc(ecryptfs_open_req_cache, GFP_KERNEL); | ||
157 | if (!req) { | ||
158 | rc = -ENOMEM; | ||
159 | goto out; | ||
160 | } | ||
161 | mutex_init(&req->mux); | ||
162 | req->lower_file = lower_file; | ||
163 | req->lower_dentry = lower_dentry; | ||
164 | req->lower_mnt = lower_mnt; | ||
165 | init_waitqueue_head(&req->wait); | ||
166 | req->flags = 0; | ||
167 | mutex_lock(&ecryptfs_kthread_ctl.mux); | 155 | mutex_lock(&ecryptfs_kthread_ctl.mux); |
168 | if (ecryptfs_kthread_ctl.flags & ECRYPTFS_KTHREAD_ZOMBIE) { | 156 | if (ecryptfs_kthread_ctl.flags & ECRYPTFS_KTHREAD_ZOMBIE) { |
169 | rc = -EIO; | 157 | rc = -EIO; |
@@ -171,27 +159,14 @@ int ecryptfs_privileged_open(struct file **lower_file, | |||
171 | printk(KERN_ERR "%s: We are in the middle of shutting down; " | 159 | printk(KERN_ERR "%s: We are in the middle of shutting down; " |
172 | "aborting privileged request to open lower file\n", | 160 | "aborting privileged request to open lower file\n", |
173 | __func__); | 161 | __func__); |
174 | goto out_free; | 162 | goto out; |
175 | } | 163 | } |
176 | list_add_tail(&req->kthread_ctl_list, &ecryptfs_kthread_ctl.req_list); | 164 | list_add_tail(&req.kthread_ctl_list, &ecryptfs_kthread_ctl.req_list); |
177 | mutex_unlock(&ecryptfs_kthread_ctl.mux); | 165 | mutex_unlock(&ecryptfs_kthread_ctl.mux); |
178 | wake_up(&ecryptfs_kthread_ctl.wait); | 166 | wake_up(&ecryptfs_kthread_ctl.wait); |
179 | wait_event(req->wait, (req->flags != 0)); | 167 | wait_for_completion(&req.done); |
180 | mutex_lock(&req->mux); | 168 | if (IS_ERR(*lower_file)) |
181 | BUG_ON(req->flags == 0); | 169 | rc = PTR_ERR(*lower_file); |
182 | if (req->flags & ECRYPTFS_REQ_DROPPED | ||
183 | || req->flags & ECRYPTFS_REQ_ZOMBIE) { | ||
184 | rc = -EIO; | ||
185 | printk(KERN_WARNING "%s: Privileged open request dropped\n", | ||
186 | __func__); | ||
187 | goto out_unlock; | ||
188 | } | ||
189 | if (IS_ERR(*req->lower_file)) | ||
190 | rc = PTR_ERR(*req->lower_file); | ||
191 | out_unlock: | ||
192 | mutex_unlock(&req->mux); | ||
193 | out_free: | ||
194 | kmem_cache_free(ecryptfs_open_req_cache, req); | ||
195 | out: | 170 | out: |
196 | return rc; | 171 | return rc; |
197 | } | 172 | } |
diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c index 68954937a071..1c0b3b6b75c6 100644 --- a/fs/ecryptfs/main.c +++ b/fs/ecryptfs/main.c | |||
@@ -499,13 +499,12 @@ static struct dentry *ecryptfs_mount(struct file_system_type *fs_type, int flags | |||
499 | goto out; | 499 | goto out; |
500 | } | 500 | } |
501 | 501 | ||
502 | s = sget(fs_type, NULL, set_anon_super, NULL); | 502 | s = sget(fs_type, NULL, set_anon_super, flags, NULL); |
503 | if (IS_ERR(s)) { | 503 | if (IS_ERR(s)) { |
504 | rc = PTR_ERR(s); | 504 | rc = PTR_ERR(s); |
505 | goto out; | 505 | goto out; |
506 | } | 506 | } |
507 | 507 | ||
508 | s->s_flags = flags; | ||
509 | rc = bdi_setup_and_register(&sbi->bdi, "ecryptfs", BDI_CAP_MAP_COPY); | 508 | rc = bdi_setup_and_register(&sbi->bdi, "ecryptfs", BDI_CAP_MAP_COPY); |
510 | if (rc) | 509 | if (rc) |
511 | goto out1; | 510 | goto out1; |
@@ -682,11 +681,6 @@ static struct ecryptfs_cache_info { | |||
682 | .name = "ecryptfs_key_tfm_cache", | 681 | .name = "ecryptfs_key_tfm_cache", |
683 | .size = sizeof(struct ecryptfs_key_tfm), | 682 | .size = sizeof(struct ecryptfs_key_tfm), |
684 | }, | 683 | }, |
685 | { | ||
686 | .cache = &ecryptfs_open_req_cache, | ||
687 | .name = "ecryptfs_open_req_cache", | ||
688 | .size = sizeof(struct ecryptfs_open_req), | ||
689 | }, | ||
690 | }; | 684 | }; |
691 | 685 | ||
692 | static void ecryptfs_free_kmem_caches(void) | 686 | static void ecryptfs_free_kmem_caches(void) |
diff --git a/fs/ecryptfs/miscdev.c b/fs/ecryptfs/miscdev.c index 3a06f4043df4..c0038f6566d4 100644 --- a/fs/ecryptfs/miscdev.c +++ b/fs/ecryptfs/miscdev.c | |||
@@ -49,7 +49,10 @@ ecryptfs_miscdev_poll(struct file *file, poll_table *pt) | |||
49 | mutex_lock(&ecryptfs_daemon_hash_mux); | 49 | mutex_lock(&ecryptfs_daemon_hash_mux); |
50 | /* TODO: Just use file->private_data? */ | 50 | /* TODO: Just use file->private_data? */ |
51 | rc = ecryptfs_find_daemon_by_euid(&daemon, euid, current_user_ns()); | 51 | rc = ecryptfs_find_daemon_by_euid(&daemon, euid, current_user_ns()); |
52 | BUG_ON(rc || !daemon); | 52 | if (rc || !daemon) { |
53 | mutex_unlock(&ecryptfs_daemon_hash_mux); | ||
54 | return -EINVAL; | ||
55 | } | ||
53 | mutex_lock(&daemon->mux); | 56 | mutex_lock(&daemon->mux); |
54 | mutex_unlock(&ecryptfs_daemon_hash_mux); | 57 | mutex_unlock(&ecryptfs_daemon_hash_mux); |
55 | if (daemon->flags & ECRYPTFS_DAEMON_ZOMBIE) { | 58 | if (daemon->flags & ECRYPTFS_DAEMON_ZOMBIE) { |
@@ -122,6 +125,7 @@ ecryptfs_miscdev_open(struct inode *inode, struct file *file) | |||
122 | goto out_unlock_daemon; | 125 | goto out_unlock_daemon; |
123 | } | 126 | } |
124 | daemon->flags |= ECRYPTFS_DAEMON_MISCDEV_OPEN; | 127 | daemon->flags |= ECRYPTFS_DAEMON_MISCDEV_OPEN; |
128 | file->private_data = daemon; | ||
125 | atomic_inc(&ecryptfs_num_miscdev_opens); | 129 | atomic_inc(&ecryptfs_num_miscdev_opens); |
126 | out_unlock_daemon: | 130 | out_unlock_daemon: |
127 | mutex_unlock(&daemon->mux); | 131 | mutex_unlock(&daemon->mux); |
@@ -152,9 +156,9 @@ ecryptfs_miscdev_release(struct inode *inode, struct file *file) | |||
152 | 156 | ||
153 | mutex_lock(&ecryptfs_daemon_hash_mux); | 157 | mutex_lock(&ecryptfs_daemon_hash_mux); |
154 | rc = ecryptfs_find_daemon_by_euid(&daemon, euid, current_user_ns()); | 158 | rc = ecryptfs_find_daemon_by_euid(&daemon, euid, current_user_ns()); |
155 | BUG_ON(rc || !daemon); | 159 | if (rc || !daemon) |
160 | daemon = file->private_data; | ||
156 | mutex_lock(&daemon->mux); | 161 | mutex_lock(&daemon->mux); |
157 | BUG_ON(daemon->pid != task_pid(current)); | ||
158 | BUG_ON(!(daemon->flags & ECRYPTFS_DAEMON_MISCDEV_OPEN)); | 162 | BUG_ON(!(daemon->flags & ECRYPTFS_DAEMON_MISCDEV_OPEN)); |
159 | daemon->flags &= ~ECRYPTFS_DAEMON_MISCDEV_OPEN; | 163 | daemon->flags &= ~ECRYPTFS_DAEMON_MISCDEV_OPEN; |
160 | atomic_dec(&ecryptfs_num_miscdev_opens); | 164 | atomic_dec(&ecryptfs_num_miscdev_opens); |
@@ -191,31 +195,32 @@ int ecryptfs_send_miscdev(char *data, size_t data_size, | |||
191 | struct ecryptfs_msg_ctx *msg_ctx, u8 msg_type, | 195 | struct ecryptfs_msg_ctx *msg_ctx, u8 msg_type, |
192 | u16 msg_flags, struct ecryptfs_daemon *daemon) | 196 | u16 msg_flags, struct ecryptfs_daemon *daemon) |
193 | { | 197 | { |
194 | int rc = 0; | 198 | struct ecryptfs_message *msg; |
195 | 199 | ||
196 | mutex_lock(&msg_ctx->mux); | 200 | msg = kmalloc((sizeof(*msg) + data_size), GFP_KERNEL); |
197 | msg_ctx->msg = kmalloc((sizeof(*msg_ctx->msg) + data_size), | 201 | if (!msg) { |
198 | GFP_KERNEL); | ||
199 | if (!msg_ctx->msg) { | ||
200 | rc = -ENOMEM; | ||
201 | printk(KERN_ERR "%s: Out of memory whilst attempting " | 202 | printk(KERN_ERR "%s: Out of memory whilst attempting " |
202 | "to kmalloc(%zd, GFP_KERNEL)\n", __func__, | 203 | "to kmalloc(%zd, GFP_KERNEL)\n", __func__, |
203 | (sizeof(*msg_ctx->msg) + data_size)); | 204 | (sizeof(*msg) + data_size)); |
204 | goto out_unlock; | 205 | return -ENOMEM; |
205 | } | 206 | } |
207 | |||
208 | mutex_lock(&msg_ctx->mux); | ||
209 | msg_ctx->msg = msg; | ||
206 | msg_ctx->msg->index = msg_ctx->index; | 210 | msg_ctx->msg->index = msg_ctx->index; |
207 | msg_ctx->msg->data_len = data_size; | 211 | msg_ctx->msg->data_len = data_size; |
208 | msg_ctx->type = msg_type; | 212 | msg_ctx->type = msg_type; |
209 | memcpy(msg_ctx->msg->data, data, data_size); | 213 | memcpy(msg_ctx->msg->data, data, data_size); |
210 | msg_ctx->msg_size = (sizeof(*msg_ctx->msg) + data_size); | 214 | msg_ctx->msg_size = (sizeof(*msg_ctx->msg) + data_size); |
211 | mutex_lock(&daemon->mux); | ||
212 | list_add_tail(&msg_ctx->daemon_out_list, &daemon->msg_ctx_out_queue); | 215 | list_add_tail(&msg_ctx->daemon_out_list, &daemon->msg_ctx_out_queue); |
216 | mutex_unlock(&msg_ctx->mux); | ||
217 | |||
218 | mutex_lock(&daemon->mux); | ||
213 | daemon->num_queued_msg_ctx++; | 219 | daemon->num_queued_msg_ctx++; |
214 | wake_up_interruptible(&daemon->wait); | 220 | wake_up_interruptible(&daemon->wait); |
215 | mutex_unlock(&daemon->mux); | 221 | mutex_unlock(&daemon->mux); |
216 | out_unlock: | 222 | |
217 | mutex_unlock(&msg_ctx->mux); | 223 | return 0; |
218 | return rc; | ||
219 | } | 224 | } |
220 | 225 | ||
221 | /* | 226 | /* |
@@ -269,8 +274,16 @@ ecryptfs_miscdev_read(struct file *file, char __user *buf, size_t count, | |||
269 | mutex_lock(&ecryptfs_daemon_hash_mux); | 274 | mutex_lock(&ecryptfs_daemon_hash_mux); |
270 | /* TODO: Just use file->private_data? */ | 275 | /* TODO: Just use file->private_data? */ |
271 | rc = ecryptfs_find_daemon_by_euid(&daemon, euid, current_user_ns()); | 276 | rc = ecryptfs_find_daemon_by_euid(&daemon, euid, current_user_ns()); |
272 | BUG_ON(rc || !daemon); | 277 | if (rc || !daemon) { |
278 | mutex_unlock(&ecryptfs_daemon_hash_mux); | ||
279 | return -EINVAL; | ||
280 | } | ||
273 | mutex_lock(&daemon->mux); | 281 | mutex_lock(&daemon->mux); |
282 | if (task_pid(current) != daemon->pid) { | ||
283 | mutex_unlock(&daemon->mux); | ||
284 | mutex_unlock(&ecryptfs_daemon_hash_mux); | ||
285 | return -EPERM; | ||
286 | } | ||
274 | if (daemon->flags & ECRYPTFS_DAEMON_ZOMBIE) { | 287 | if (daemon->flags & ECRYPTFS_DAEMON_ZOMBIE) { |
275 | rc = 0; | 288 | rc = 0; |
276 | mutex_unlock(&ecryptfs_daemon_hash_mux); | 289 | mutex_unlock(&ecryptfs_daemon_hash_mux); |
@@ -307,9 +320,6 @@ check_list: | |||
307 | * message from the queue; try again */ | 320 | * message from the queue; try again */ |
308 | goto check_list; | 321 | goto check_list; |
309 | } | 322 | } |
310 | BUG_ON(euid != daemon->euid); | ||
311 | BUG_ON(current_user_ns() != daemon->user_ns); | ||
312 | BUG_ON(task_pid(current) != daemon->pid); | ||
313 | msg_ctx = list_first_entry(&daemon->msg_ctx_out_queue, | 323 | msg_ctx = list_first_entry(&daemon->msg_ctx_out_queue, |
314 | struct ecryptfs_msg_ctx, daemon_out_list); | 324 | struct ecryptfs_msg_ctx, daemon_out_list); |
315 | BUG_ON(!msg_ctx); | 325 | BUG_ON(!msg_ctx); |
diff --git a/fs/efs/efs.h b/fs/efs/efs.h index d8305b582ab0..5528926ac7f6 100644 --- a/fs/efs/efs.h +++ b/fs/efs/efs.h | |||
@@ -129,7 +129,7 @@ extern struct inode *efs_iget(struct super_block *, unsigned long); | |||
129 | extern efs_block_t efs_map_block(struct inode *, efs_block_t); | 129 | extern efs_block_t efs_map_block(struct inode *, efs_block_t); |
130 | extern int efs_get_block(struct inode *, sector_t, struct buffer_head *, int); | 130 | extern int efs_get_block(struct inode *, sector_t, struct buffer_head *, int); |
131 | 131 | ||
132 | extern struct dentry *efs_lookup(struct inode *, struct dentry *, struct nameidata *); | 132 | extern struct dentry *efs_lookup(struct inode *, struct dentry *, unsigned int); |
133 | extern struct dentry *efs_fh_to_dentry(struct super_block *sb, struct fid *fid, | 133 | extern struct dentry *efs_fh_to_dentry(struct super_block *sb, struct fid *fid, |
134 | int fh_len, int fh_type); | 134 | int fh_len, int fh_type); |
135 | extern struct dentry *efs_fh_to_parent(struct super_block *sb, struct fid *fid, | 135 | extern struct dentry *efs_fh_to_parent(struct super_block *sb, struct fid *fid, |
diff --git a/fs/efs/namei.c b/fs/efs/namei.c index 832b10ded82f..96f66d213a19 100644 --- a/fs/efs/namei.c +++ b/fs/efs/namei.c | |||
@@ -58,7 +58,8 @@ static efs_ino_t efs_find_entry(struct inode *inode, const char *name, int len) | |||
58 | return(0); | 58 | return(0); |
59 | } | 59 | } |
60 | 60 | ||
61 | struct dentry *efs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) { | 61 | struct dentry *efs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
62 | { | ||
62 | efs_ino_t inodenum; | 63 | efs_ino_t inodenum; |
63 | struct inode *inode = NULL; | 64 | struct inode *inode = NULL; |
64 | 65 | ||
diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 74598f67efeb..1c8b55670804 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c | |||
@@ -1710,7 +1710,7 @@ SYSCALL_DEFINE4(epoll_ctl, int, epfd, int, op, int, fd, | |||
1710 | goto error_tgt_fput; | 1710 | goto error_tgt_fput; |
1711 | 1711 | ||
1712 | /* Check if EPOLLWAKEUP is allowed */ | 1712 | /* Check if EPOLLWAKEUP is allowed */ |
1713 | if ((epds.events & EPOLLWAKEUP) && !capable(CAP_EPOLLWAKEUP)) | 1713 | if ((epds.events & EPOLLWAKEUP) && !capable(CAP_BLOCK_SUSPEND)) |
1714 | epds.events &= ~EPOLLWAKEUP; | 1714 | epds.events &= ~EPOLLWAKEUP; |
1715 | 1715 | ||
1716 | /* | 1716 | /* |
@@ -819,10 +819,10 @@ static int exec_mmap(struct mm_struct *mm) | |||
819 | /* Notify parent that we're no longer interested in the old VM */ | 819 | /* Notify parent that we're no longer interested in the old VM */ |
820 | tsk = current; | 820 | tsk = current; |
821 | old_mm = current->mm; | 821 | old_mm = current->mm; |
822 | sync_mm_rss(old_mm); | ||
823 | mm_release(tsk, old_mm); | 822 | mm_release(tsk, old_mm); |
824 | 823 | ||
825 | if (old_mm) { | 824 | if (old_mm) { |
825 | sync_mm_rss(old_mm); | ||
826 | /* | 826 | /* |
827 | * Make sure that if there is a core dump in progress | 827 | * Make sure that if there is a core dump in progress |
828 | * for the old mm, we get out and die instead of going | 828 | * for the old mm, we get out and die instead of going |
diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c index fc7161d6bf6b..4731fd991efe 100644 --- a/fs/exofs/namei.c +++ b/fs/exofs/namei.c | |||
@@ -46,7 +46,7 @@ static inline int exofs_add_nondir(struct dentry *dentry, struct inode *inode) | |||
46 | } | 46 | } |
47 | 47 | ||
48 | static struct dentry *exofs_lookup(struct inode *dir, struct dentry *dentry, | 48 | static struct dentry *exofs_lookup(struct inode *dir, struct dentry *dentry, |
49 | struct nameidata *nd) | 49 | unsigned int flags) |
50 | { | 50 | { |
51 | struct inode *inode; | 51 | struct inode *inode; |
52 | ino_t ino; | 52 | ino_t ino; |
@@ -60,7 +60,7 @@ static struct dentry *exofs_lookup(struct inode *dir, struct dentry *dentry, | |||
60 | } | 60 | } |
61 | 61 | ||
62 | static int exofs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 62 | static int exofs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
63 | struct nameidata *nd) | 63 | bool excl) |
64 | { | 64 | { |
65 | struct inode *inode = exofs_new_inode(dir, mode); | 65 | struct inode *inode = exofs_new_inode(dir, mode); |
66 | int err = PTR_ERR(inode); | 66 | int err = PTR_ERR(inode); |
diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c index 49cf230554a2..24a49d47e935 100644 --- a/fs/exofs/ore.c +++ b/fs/exofs/ore.c | |||
@@ -735,13 +735,7 @@ static int _prepare_for_striping(struct ore_io_state *ios) | |||
735 | out: | 735 | out: |
736 | ios->numdevs = devs_in_group; | 736 | ios->numdevs = devs_in_group; |
737 | ios->pages_consumed = cur_pg; | 737 | ios->pages_consumed = cur_pg; |
738 | if (unlikely(ret)) { | 738 | return ret; |
739 | if (length == ios->length) | ||
740 | return ret; | ||
741 | else | ||
742 | ios->length -= length; | ||
743 | } | ||
744 | return 0; | ||
745 | } | 739 | } |
746 | 740 | ||
747 | int ore_create(struct ore_io_state *ios) | 741 | int ore_create(struct ore_io_state *ios) |
diff --git a/fs/exofs/ore_raid.c b/fs/exofs/ore_raid.c index d222c77cfa1b..5f376d14fdcc 100644 --- a/fs/exofs/ore_raid.c +++ b/fs/exofs/ore_raid.c | |||
@@ -144,26 +144,26 @@ static void _sp2d_reset(struct __stripe_pages_2d *sp2d, | |||
144 | { | 144 | { |
145 | unsigned data_devs = sp2d->data_devs; | 145 | unsigned data_devs = sp2d->data_devs; |
146 | unsigned group_width = data_devs + sp2d->parity; | 146 | unsigned group_width = data_devs + sp2d->parity; |
147 | unsigned p; | 147 | int p, c; |
148 | 148 | ||
149 | if (!sp2d->needed) | 149 | if (!sp2d->needed) |
150 | return; | 150 | return; |
151 | 151 | ||
152 | for (p = 0; p < sp2d->pages_in_unit; p++) { | 152 | for (c = data_devs - 1; c >= 0; --c) |
153 | struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p]; | 153 | for (p = sp2d->pages_in_unit - 1; p >= 0; --p) { |
154 | 154 | struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p]; | |
155 | if (_1ps->write_count < group_width) { | ||
156 | unsigned c; | ||
157 | 155 | ||
158 | for (c = 0; c < data_devs; c++) | 156 | if (_1ps->page_is_read[c]) { |
159 | if (_1ps->page_is_read[c]) { | 157 | struct page *page = _1ps->pages[c]; |
160 | struct page *page = _1ps->pages[c]; | ||
161 | 158 | ||
162 | r4w->put_page(priv, page); | 159 | r4w->put_page(priv, page); |
163 | _1ps->page_is_read[c] = false; | 160 | _1ps->page_is_read[c] = false; |
164 | } | 161 | } |
165 | } | 162 | } |
166 | 163 | ||
164 | for (p = 0; p < sp2d->pages_in_unit; p++) { | ||
165 | struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p]; | ||
166 | |||
167 | memset(_1ps->pages, 0, group_width * sizeof(*_1ps->pages)); | 167 | memset(_1ps->pages, 0, group_width * sizeof(*_1ps->pages)); |
168 | _1ps->write_count = 0; | 168 | _1ps->write_count = 0; |
169 | _1ps->tx = NULL; | 169 | _1ps->tx = NULL; |
@@ -461,16 +461,12 @@ static void _mark_read4write_pages_uptodate(struct ore_io_state *ios, int ret) | |||
461 | * ios->sp2d[p][*], xor is calculated the same way. These pages are | 461 | * ios->sp2d[p][*], xor is calculated the same way. These pages are |
462 | * allocated/freed and don't go through cache | 462 | * allocated/freed and don't go through cache |
463 | */ | 463 | */ |
464 | static int _read_4_write(struct ore_io_state *ios) | 464 | static int _read_4_write_first_stripe(struct ore_io_state *ios) |
465 | { | 465 | { |
466 | struct ore_io_state *ios_read; | ||
467 | struct ore_striping_info read_si; | 466 | struct ore_striping_info read_si; |
468 | struct __stripe_pages_2d *sp2d = ios->sp2d; | 467 | struct __stripe_pages_2d *sp2d = ios->sp2d; |
469 | u64 offset = ios->si.first_stripe_start; | 468 | u64 offset = ios->si.first_stripe_start; |
470 | u64 last_stripe_end; | 469 | unsigned c, p, min_p = sp2d->pages_in_unit, max_p = -1; |
471 | unsigned bytes_in_stripe = ios->si.bytes_in_stripe; | ||
472 | unsigned i, c, p, min_p = sp2d->pages_in_unit, max_p = -1; | ||
473 | int ret; | ||
474 | 470 | ||
475 | if (offset == ios->offset) /* Go to start collect $200 */ | 471 | if (offset == ios->offset) /* Go to start collect $200 */ |
476 | goto read_last_stripe; | 472 | goto read_last_stripe; |
@@ -478,6 +474,9 @@ static int _read_4_write(struct ore_io_state *ios) | |||
478 | min_p = _sp2d_min_pg(sp2d); | 474 | min_p = _sp2d_min_pg(sp2d); |
479 | max_p = _sp2d_max_pg(sp2d); | 475 | max_p = _sp2d_max_pg(sp2d); |
480 | 476 | ||
477 | ORE_DBGMSG("stripe_start=0x%llx ios->offset=0x%llx min_p=%d max_p=%d\n", | ||
478 | offset, ios->offset, min_p, max_p); | ||
479 | |||
481 | for (c = 0; ; c++) { | 480 | for (c = 0; ; c++) { |
482 | ore_calc_stripe_info(ios->layout, offset, 0, &read_si); | 481 | ore_calc_stripe_info(ios->layout, offset, 0, &read_si); |
483 | read_si.obj_offset += min_p * PAGE_SIZE; | 482 | read_si.obj_offset += min_p * PAGE_SIZE; |
@@ -512,6 +511,18 @@ static int _read_4_write(struct ore_io_state *ios) | |||
512 | } | 511 | } |
513 | 512 | ||
514 | read_last_stripe: | 513 | read_last_stripe: |
514 | return 0; | ||
515 | } | ||
516 | |||
517 | static int _read_4_write_last_stripe(struct ore_io_state *ios) | ||
518 | { | ||
519 | struct ore_striping_info read_si; | ||
520 | struct __stripe_pages_2d *sp2d = ios->sp2d; | ||
521 | u64 offset; | ||
522 | u64 last_stripe_end; | ||
523 | unsigned bytes_in_stripe = ios->si.bytes_in_stripe; | ||
524 | unsigned c, p, min_p = sp2d->pages_in_unit, max_p = -1; | ||
525 | |||
515 | offset = ios->offset + ios->length; | 526 | offset = ios->offset + ios->length; |
516 | if (offset % PAGE_SIZE) | 527 | if (offset % PAGE_SIZE) |
517 | _add_to_r4w_last_page(ios, &offset); | 528 | _add_to_r4w_last_page(ios, &offset); |
@@ -527,15 +538,15 @@ read_last_stripe: | |||
527 | c = _dev_order(ios->layout->group_width * ios->layout->mirrors_p1, | 538 | c = _dev_order(ios->layout->group_width * ios->layout->mirrors_p1, |
528 | ios->layout->mirrors_p1, read_si.par_dev, read_si.dev); | 539 | ios->layout->mirrors_p1, read_si.par_dev, read_si.dev); |
529 | 540 | ||
530 | BUG_ON(ios->si.first_stripe_start + bytes_in_stripe != last_stripe_end); | ||
531 | /* unaligned IO must be within a single stripe */ | ||
532 | |||
533 | if (min_p == sp2d->pages_in_unit) { | 541 | if (min_p == sp2d->pages_in_unit) { |
534 | /* Didn't do it yet */ | 542 | /* Didn't do it yet */ |
535 | min_p = _sp2d_min_pg(sp2d); | 543 | min_p = _sp2d_min_pg(sp2d); |
536 | max_p = _sp2d_max_pg(sp2d); | 544 | max_p = _sp2d_max_pg(sp2d); |
537 | } | 545 | } |
538 | 546 | ||
547 | ORE_DBGMSG("offset=0x%llx stripe_end=0x%llx min_p=%d max_p=%d\n", | ||
548 | offset, last_stripe_end, min_p, max_p); | ||
549 | |||
539 | while (offset < last_stripe_end) { | 550 | while (offset < last_stripe_end) { |
540 | struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p]; | 551 | struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p]; |
541 | 552 | ||
@@ -568,6 +579,15 @@ read_last_stripe: | |||
568 | } | 579 | } |
569 | 580 | ||
570 | read_it: | 581 | read_it: |
582 | return 0; | ||
583 | } | ||
584 | |||
585 | static int _read_4_write_execute(struct ore_io_state *ios) | ||
586 | { | ||
587 | struct ore_io_state *ios_read; | ||
588 | unsigned i; | ||
589 | int ret; | ||
590 | |||
571 | ios_read = ios->ios_read_4_write; | 591 | ios_read = ios->ios_read_4_write; |
572 | if (!ios_read) | 592 | if (!ios_read) |
573 | return 0; | 593 | return 0; |
@@ -591,6 +611,8 @@ read_it: | |||
591 | } | 611 | } |
592 | 612 | ||
593 | _mark_read4write_pages_uptodate(ios_read, ret); | 613 | _mark_read4write_pages_uptodate(ios_read, ret); |
614 | ore_put_io_state(ios_read); | ||
615 | ios->ios_read_4_write = NULL; /* Might need a reuse at last stripe */ | ||
594 | return 0; | 616 | return 0; |
595 | } | 617 | } |
596 | 618 | ||
@@ -626,8 +648,11 @@ int _ore_add_parity_unit(struct ore_io_state *ios, | |||
626 | /* If first stripe, Read in all read4write pages | 648 | /* If first stripe, Read in all read4write pages |
627 | * (if needed) before we calculate the first parity. | 649 | * (if needed) before we calculate the first parity. |
628 | */ | 650 | */ |
629 | _read_4_write(ios); | 651 | _read_4_write_first_stripe(ios); |
630 | } | 652 | } |
653 | if (!cur_len) /* If last stripe r4w pages of last stripe */ | ||
654 | _read_4_write_last_stripe(ios); | ||
655 | _read_4_write_execute(ios); | ||
631 | 656 | ||
632 | for (i = 0; i < num_pages; i++) { | 657 | for (i = 0; i < num_pages; i++) { |
633 | pages[i] = _raid_page_alloc(); | 658 | pages[i] = _raid_page_alloc(); |
@@ -654,34 +679,14 @@ int _ore_add_parity_unit(struct ore_io_state *ios, | |||
654 | 679 | ||
655 | int _ore_post_alloc_raid_stuff(struct ore_io_state *ios) | 680 | int _ore_post_alloc_raid_stuff(struct ore_io_state *ios) |
656 | { | 681 | { |
657 | struct ore_layout *layout = ios->layout; | ||
658 | |||
659 | if (ios->parity_pages) { | 682 | if (ios->parity_pages) { |
683 | struct ore_layout *layout = ios->layout; | ||
660 | unsigned pages_in_unit = layout->stripe_unit / PAGE_SIZE; | 684 | unsigned pages_in_unit = layout->stripe_unit / PAGE_SIZE; |
661 | unsigned stripe_size = ios->si.bytes_in_stripe; | ||
662 | u64 last_stripe, first_stripe; | ||
663 | 685 | ||
664 | if (_sp2d_alloc(pages_in_unit, layout->group_width, | 686 | if (_sp2d_alloc(pages_in_unit, layout->group_width, |
665 | layout->parity, &ios->sp2d)) { | 687 | layout->parity, &ios->sp2d)) { |
666 | return -ENOMEM; | 688 | return -ENOMEM; |
667 | } | 689 | } |
668 | |||
669 | /* Round io down to last full strip */ | ||
670 | first_stripe = div_u64(ios->offset, stripe_size); | ||
671 | last_stripe = div_u64(ios->offset + ios->length, stripe_size); | ||
672 | |||
673 | /* If an IO spans more then a single stripe it must end at | ||
674 | * a stripe boundary. The reminder at the end is pushed into the | ||
675 | * next IO. | ||
676 | */ | ||
677 | if (last_stripe != first_stripe) { | ||
678 | ios->length = last_stripe * stripe_size - ios->offset; | ||
679 | |||
680 | BUG_ON(!ios->length); | ||
681 | ios->nr_pages = (ios->length + PAGE_SIZE - 1) / | ||
682 | PAGE_SIZE; | ||
683 | ios->si.length = ios->length; /*make it consistent */ | ||
684 | } | ||
685 | } | 690 | } |
686 | return 0; | 691 | return 0; |
687 | } | 692 | } |
diff --git a/fs/exofs/sys.c b/fs/exofs/sys.c index e32bc919e4e3..5a7b691e748b 100644 --- a/fs/exofs/sys.c +++ b/fs/exofs/sys.c | |||
@@ -109,7 +109,7 @@ static struct kobj_type odev_ktype = { | |||
109 | static struct kobj_type uuid_ktype = { | 109 | static struct kobj_type uuid_ktype = { |
110 | }; | 110 | }; |
111 | 111 | ||
112 | void exofs_sysfs_dbg_print() | 112 | void exofs_sysfs_dbg_print(void) |
113 | { | 113 | { |
114 | #ifdef CONFIG_EXOFS_DEBUG | 114 | #ifdef CONFIG_EXOFS_DEBUG |
115 | struct kobject *k_name, *k_tmp; | 115 | struct kobject *k_name, *k_tmp; |
diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c index b0201ca6e9c6..29ab099e3e08 100644 --- a/fs/exportfs/expfs.c +++ b/fs/exportfs/expfs.c | |||
@@ -19,19 +19,19 @@ | |||
19 | #define dprintk(fmt, args...) do{}while(0) | 19 | #define dprintk(fmt, args...) do{}while(0) |
20 | 20 | ||
21 | 21 | ||
22 | static int get_name(struct vfsmount *mnt, struct dentry *dentry, char *name, | 22 | static int get_name(const struct path *path, char *name, struct dentry *child); |
23 | struct dentry *child); | ||
24 | 23 | ||
25 | 24 | ||
26 | static int exportfs_get_name(struct vfsmount *mnt, struct dentry *dir, | 25 | static int exportfs_get_name(struct vfsmount *mnt, struct dentry *dir, |
27 | char *name, struct dentry *child) | 26 | char *name, struct dentry *child) |
28 | { | 27 | { |
29 | const struct export_operations *nop = dir->d_sb->s_export_op; | 28 | const struct export_operations *nop = dir->d_sb->s_export_op; |
29 | struct path path = {.mnt = mnt, .dentry = dir}; | ||
30 | 30 | ||
31 | if (nop->get_name) | 31 | if (nop->get_name) |
32 | return nop->get_name(dir, name, child); | 32 | return nop->get_name(dir, name, child); |
33 | else | 33 | else |
34 | return get_name(mnt, dir, name, child); | 34 | return get_name(&path, name, child); |
35 | } | 35 | } |
36 | 36 | ||
37 | /* | 37 | /* |
@@ -44,13 +44,14 @@ find_acceptable_alias(struct dentry *result, | |||
44 | { | 44 | { |
45 | struct dentry *dentry, *toput = NULL; | 45 | struct dentry *dentry, *toput = NULL; |
46 | struct inode *inode; | 46 | struct inode *inode; |
47 | struct hlist_node *p; | ||
47 | 48 | ||
48 | if (acceptable(context, result)) | 49 | if (acceptable(context, result)) |
49 | return result; | 50 | return result; |
50 | 51 | ||
51 | inode = result->d_inode; | 52 | inode = result->d_inode; |
52 | spin_lock(&inode->i_lock); | 53 | spin_lock(&inode->i_lock); |
53 | list_for_each_entry(dentry, &inode->i_dentry, d_alias) { | 54 | hlist_for_each_entry(dentry, p, &inode->i_dentry, d_alias) { |
54 | dget(dentry); | 55 | dget(dentry); |
55 | spin_unlock(&inode->i_lock); | 56 | spin_unlock(&inode->i_lock); |
56 | if (toput) | 57 | if (toput) |
@@ -248,11 +249,10 @@ static int filldir_one(void * __buf, const char * name, int len, | |||
248 | * calls readdir on the parent until it finds an entry with | 249 | * calls readdir on the parent until it finds an entry with |
249 | * the same inode number as the child, and returns that. | 250 | * the same inode number as the child, and returns that. |
250 | */ | 251 | */ |
251 | static int get_name(struct vfsmount *mnt, struct dentry *dentry, | 252 | static int get_name(const struct path *path, char *name, struct dentry *child) |
252 | char *name, struct dentry *child) | ||
253 | { | 253 | { |
254 | const struct cred *cred = current_cred(); | 254 | const struct cred *cred = current_cred(); |
255 | struct inode *dir = dentry->d_inode; | 255 | struct inode *dir = path->dentry->d_inode; |
256 | int error; | 256 | int error; |
257 | struct file *file; | 257 | struct file *file; |
258 | struct getdents_callback buffer; | 258 | struct getdents_callback buffer; |
@@ -266,7 +266,7 @@ static int get_name(struct vfsmount *mnt, struct dentry *dentry, | |||
266 | /* | 266 | /* |
267 | * Open the directory ... | 267 | * Open the directory ... |
268 | */ | 268 | */ |
269 | file = dentry_open(dget(dentry), mntget(mnt), O_RDONLY, cred); | 269 | file = dentry_open(path, O_RDONLY, cred); |
270 | error = PTR_ERR(file); | 270 | error = PTR_ERR(file); |
271 | if (IS_ERR(file)) | 271 | if (IS_ERR(file)) |
272 | goto out; | 272 | goto out; |
diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c index f663a67d7bf0..73b0d9519836 100644 --- a/fs/ext2/namei.c +++ b/fs/ext2/namei.c | |||
@@ -41,8 +41,8 @@ static inline int ext2_add_nondir(struct dentry *dentry, struct inode *inode) | |||
41 | { | 41 | { |
42 | int err = ext2_add_link(dentry, inode); | 42 | int err = ext2_add_link(dentry, inode); |
43 | if (!err) { | 43 | if (!err) { |
44 | d_instantiate(dentry, inode); | ||
45 | unlock_new_inode(inode); | 44 | unlock_new_inode(inode); |
45 | d_instantiate(dentry, inode); | ||
46 | return 0; | 46 | return 0; |
47 | } | 47 | } |
48 | inode_dec_link_count(inode); | 48 | inode_dec_link_count(inode); |
@@ -55,7 +55,7 @@ static inline int ext2_add_nondir(struct dentry *dentry, struct inode *inode) | |||
55 | * Methods themselves. | 55 | * Methods themselves. |
56 | */ | 56 | */ |
57 | 57 | ||
58 | static struct dentry *ext2_lookup(struct inode * dir, struct dentry *dentry, struct nameidata *nd) | 58 | static struct dentry *ext2_lookup(struct inode * dir, struct dentry *dentry, unsigned int flags) |
59 | { | 59 | { |
60 | struct inode * inode; | 60 | struct inode * inode; |
61 | ino_t ino; | 61 | ino_t ino; |
@@ -94,7 +94,7 @@ struct dentry *ext2_get_parent(struct dentry *child) | |||
94 | * If the create succeeds, we fill in the inode information | 94 | * If the create succeeds, we fill in the inode information |
95 | * with d_instantiate(). | 95 | * with d_instantiate(). |
96 | */ | 96 | */ |
97 | static int ext2_create (struct inode * dir, struct dentry * dentry, umode_t mode, struct nameidata *nd) | 97 | static int ext2_create (struct inode * dir, struct dentry * dentry, umode_t mode, bool excl) |
98 | { | 98 | { |
99 | struct inode *inode; | 99 | struct inode *inode; |
100 | 100 | ||
@@ -242,8 +242,8 @@ static int ext2_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) | |||
242 | if (err) | 242 | if (err) |
243 | goto out_fail; | 243 | goto out_fail; |
244 | 244 | ||
245 | d_instantiate(dentry, inode); | ||
246 | unlock_new_inode(inode); | 245 | unlock_new_inode(inode); |
246 | d_instantiate(dentry, inode); | ||
247 | out: | 247 | out: |
248 | return err; | 248 | return err; |
249 | 249 | ||
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index b3621cb7ea31..9f311d27b16f 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c | |||
@@ -771,13 +771,13 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
771 | err = -ENOMEM; | 771 | err = -ENOMEM; |
772 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); | 772 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); |
773 | if (!sbi) | 773 | if (!sbi) |
774 | goto failed_unlock; | 774 | goto failed; |
775 | 775 | ||
776 | sbi->s_blockgroup_lock = | 776 | sbi->s_blockgroup_lock = |
777 | kzalloc(sizeof(struct blockgroup_lock), GFP_KERNEL); | 777 | kzalloc(sizeof(struct blockgroup_lock), GFP_KERNEL); |
778 | if (!sbi->s_blockgroup_lock) { | 778 | if (!sbi->s_blockgroup_lock) { |
779 | kfree(sbi); | 779 | kfree(sbi); |
780 | goto failed_unlock; | 780 | goto failed; |
781 | } | 781 | } |
782 | sb->s_fs_info = sbi; | 782 | sb->s_fs_info = sbi; |
783 | sbi->s_sb_block = sb_block; | 783 | sbi->s_sb_block = sb_block; |
@@ -1130,7 +1130,7 @@ failed_sbi: | |||
1130 | sb->s_fs_info = NULL; | 1130 | sb->s_fs_info = NULL; |
1131 | kfree(sbi->s_blockgroup_lock); | 1131 | kfree(sbi->s_blockgroup_lock); |
1132 | kfree(sbi); | 1132 | kfree(sbi); |
1133 | failed_unlock: | 1133 | failed: |
1134 | return ret; | 1134 | return ret; |
1135 | } | 1135 | } |
1136 | 1136 | ||
@@ -1184,6 +1184,12 @@ static int ext2_sync_fs(struct super_block *sb, int wait) | |||
1184 | struct ext2_sb_info *sbi = EXT2_SB(sb); | 1184 | struct ext2_sb_info *sbi = EXT2_SB(sb); |
1185 | struct ext2_super_block *es = EXT2_SB(sb)->s_es; | 1185 | struct ext2_super_block *es = EXT2_SB(sb)->s_es; |
1186 | 1186 | ||
1187 | /* | ||
1188 | * Write quota structures to quota file, sync_blockdev() will write | ||
1189 | * them to disk later | ||
1190 | */ | ||
1191 | dquot_writeback_dquots(sb, -1); | ||
1192 | |||
1187 | spin_lock(&sbi->s_lock); | 1193 | spin_lock(&sbi->s_lock); |
1188 | if (es->s_state & cpu_to_le16(EXT2_VALID_FS)) { | 1194 | if (es->s_state & cpu_to_le16(EXT2_VALID_FS)) { |
1189 | ext2_debug("setting valid to 0\n"); | 1195 | ext2_debug("setting valid to 0\n"); |
diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c index 92490e9f85ca..c8fff930790d 100644 --- a/fs/ext3/dir.c +++ b/fs/ext3/dir.c | |||
@@ -300,10 +300,11 @@ loff_t ext3_dir_llseek(struct file *file, loff_t offset, int origin) | |||
300 | { | 300 | { |
301 | struct inode *inode = file->f_mapping->host; | 301 | struct inode *inode = file->f_mapping->host; |
302 | int dx_dir = is_dx_dir(inode); | 302 | int dx_dir = is_dx_dir(inode); |
303 | loff_t htree_max = ext3_get_htree_eof(file); | ||
303 | 304 | ||
304 | if (likely(dx_dir)) | 305 | if (likely(dx_dir)) |
305 | return generic_file_llseek_size(file, offset, origin, | 306 | return generic_file_llseek_size(file, offset, origin, |
306 | ext3_get_htree_eof(file)); | 307 | htree_max, htree_max); |
307 | else | 308 | else |
308 | return generic_file_llseek(file, offset, origin); | 309 | return generic_file_llseek(file, offset, origin); |
309 | } | 310 | } |
diff --git a/fs/ext3/fsync.c b/fs/ext3/fsync.c index d4dff278cbd8..b31dbd4c46ad 100644 --- a/fs/ext3/fsync.c +++ b/fs/ext3/fsync.c | |||
@@ -92,8 +92,13 @@ int ext3_sync_file(struct file *file, loff_t start, loff_t end, int datasync) | |||
92 | * disk caches manually so that data really is on persistent | 92 | * disk caches manually so that data really is on persistent |
93 | * storage | 93 | * storage |
94 | */ | 94 | */ |
95 | if (needs_barrier) | 95 | if (needs_barrier) { |
96 | blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL, NULL); | 96 | int err; |
97 | |||
98 | err = blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL, NULL); | ||
99 | if (!ret) | ||
100 | ret = err; | ||
101 | } | ||
97 | out: | 102 | out: |
98 | trace_ext3_sync_file_exit(inode, ret); | 103 | trace_ext3_sync_file_exit(inode, ret); |
99 | return ret; | 104 | return ret; |
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index eeb63dfc5d20..8f4fddac01a6 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c | |||
@@ -1011,7 +1011,7 @@ errout: | |||
1011 | return NULL; | 1011 | return NULL; |
1012 | } | 1012 | } |
1013 | 1013 | ||
1014 | static struct dentry *ext3_lookup(struct inode * dir, struct dentry *dentry, struct nameidata *nd) | 1014 | static struct dentry *ext3_lookup(struct inode * dir, struct dentry *dentry, unsigned int flags) |
1015 | { | 1015 | { |
1016 | struct inode * inode; | 1016 | struct inode * inode; |
1017 | struct ext3_dir_entry_2 * de; | 1017 | struct ext3_dir_entry_2 * de; |
@@ -1671,8 +1671,8 @@ static int ext3_add_nondir(handle_t *handle, | |||
1671 | int err = ext3_add_entry(handle, dentry, inode); | 1671 | int err = ext3_add_entry(handle, dentry, inode); |
1672 | if (!err) { | 1672 | if (!err) { |
1673 | ext3_mark_inode_dirty(handle, inode); | 1673 | ext3_mark_inode_dirty(handle, inode); |
1674 | d_instantiate(dentry, inode); | ||
1675 | unlock_new_inode(inode); | 1674 | unlock_new_inode(inode); |
1675 | d_instantiate(dentry, inode); | ||
1676 | return 0; | 1676 | return 0; |
1677 | } | 1677 | } |
1678 | drop_nlink(inode); | 1678 | drop_nlink(inode); |
@@ -1690,7 +1690,7 @@ static int ext3_add_nondir(handle_t *handle, | |||
1690 | * with d_instantiate(). | 1690 | * with d_instantiate(). |
1691 | */ | 1691 | */ |
1692 | static int ext3_create (struct inode * dir, struct dentry * dentry, umode_t mode, | 1692 | static int ext3_create (struct inode * dir, struct dentry * dentry, umode_t mode, |
1693 | struct nameidata *nd) | 1693 | bool excl) |
1694 | { | 1694 | { |
1695 | handle_t *handle; | 1695 | handle_t *handle; |
1696 | struct inode * inode; | 1696 | struct inode * inode; |
@@ -1836,8 +1836,8 @@ out_clear_inode: | |||
1836 | if (err) | 1836 | if (err) |
1837 | goto out_clear_inode; | 1837 | goto out_clear_inode; |
1838 | 1838 | ||
1839 | d_instantiate(dentry, inode); | ||
1840 | unlock_new_inode(inode); | 1839 | unlock_new_inode(inode); |
1840 | d_instantiate(dentry, inode); | ||
1841 | out_stop: | 1841 | out_stop: |
1842 | brelse(dir_block); | 1842 | brelse(dir_block); |
1843 | ext3_journal_stop(handle); | 1843 | ext3_journal_stop(handle); |
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 8c3a44b7c375..ff9bcdc5b0d5 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
@@ -2058,7 +2058,8 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
2058 | goto failed_mount3; | 2058 | goto failed_mount3; |
2059 | } | 2059 | } |
2060 | 2060 | ||
2061 | ext3_setup_super (sb, es, sb->s_flags & MS_RDONLY); | 2061 | if (ext3_setup_super(sb, es, sb->s_flags & MS_RDONLY)) |
2062 | sb->s_flags |= MS_RDONLY; | ||
2062 | 2063 | ||
2063 | EXT3_SB(sb)->s_mount_state |= EXT3_ORPHAN_FS; | 2064 | EXT3_SB(sb)->s_mount_state |= EXT3_ORPHAN_FS; |
2064 | ext3_orphan_cleanup(sb, es); | 2065 | ext3_orphan_cleanup(sb, es); |
@@ -2526,6 +2527,11 @@ static int ext3_sync_fs(struct super_block *sb, int wait) | |||
2526 | tid_t target; | 2527 | tid_t target; |
2527 | 2528 | ||
2528 | trace_ext3_sync_fs(sb, wait); | 2529 | trace_ext3_sync_fs(sb, wait); |
2530 | /* | ||
2531 | * Writeback quota in non-journalled quota case - journalled quota has | ||
2532 | * no dirty dquots | ||
2533 | */ | ||
2534 | dquot_writeback_dquots(sb, -1); | ||
2529 | if (journal_start_commit(EXT3_SB(sb)->s_journal, &target)) { | 2535 | if (journal_start_commit(EXT3_SB(sb)->s_journal, &target)) { |
2530 | if (wait) | 2536 | if (wait) |
2531 | log_wait_commit(EXT3_SB(sb)->s_journal, target); | 2537 | log_wait_commit(EXT3_SB(sb)->s_journal, target); |
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index 99b6324290db..cee7812cc3cf 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c | |||
@@ -90,8 +90,8 @@ unsigned ext4_num_overhead_clusters(struct super_block *sb, | |||
90 | * unusual file system layouts. | 90 | * unusual file system layouts. |
91 | */ | 91 | */ |
92 | if (ext4_block_in_group(sb, ext4_block_bitmap(sb, gdp), block_group)) { | 92 | if (ext4_block_in_group(sb, ext4_block_bitmap(sb, gdp), block_group)) { |
93 | block_cluster = EXT4_B2C(sbi, (start - | 93 | block_cluster = EXT4_B2C(sbi, |
94 | ext4_block_bitmap(sb, gdp))); | 94 | ext4_block_bitmap(sb, gdp) - start); |
95 | if (block_cluster < num_clusters) | 95 | if (block_cluster < num_clusters) |
96 | block_cluster = -1; | 96 | block_cluster = -1; |
97 | else if (block_cluster == num_clusters) { | 97 | else if (block_cluster == num_clusters) { |
@@ -102,7 +102,7 @@ unsigned ext4_num_overhead_clusters(struct super_block *sb, | |||
102 | 102 | ||
103 | if (ext4_block_in_group(sb, ext4_inode_bitmap(sb, gdp), block_group)) { | 103 | if (ext4_block_in_group(sb, ext4_inode_bitmap(sb, gdp), block_group)) { |
104 | inode_cluster = EXT4_B2C(sbi, | 104 | inode_cluster = EXT4_B2C(sbi, |
105 | start - ext4_inode_bitmap(sb, gdp)); | 105 | ext4_inode_bitmap(sb, gdp) - start); |
106 | if (inode_cluster < num_clusters) | 106 | if (inode_cluster < num_clusters) |
107 | inode_cluster = -1; | 107 | inode_cluster = -1; |
108 | else if (inode_cluster == num_clusters) { | 108 | else if (inode_cluster == num_clusters) { |
@@ -114,7 +114,7 @@ unsigned ext4_num_overhead_clusters(struct super_block *sb, | |||
114 | itbl_blk = ext4_inode_table(sb, gdp); | 114 | itbl_blk = ext4_inode_table(sb, gdp); |
115 | for (i = 0; i < sbi->s_itb_per_group; i++) { | 115 | for (i = 0; i < sbi->s_itb_per_group; i++) { |
116 | if (ext4_block_in_group(sb, itbl_blk + i, block_group)) { | 116 | if (ext4_block_in_group(sb, itbl_blk + i, block_group)) { |
117 | c = EXT4_B2C(sbi, start - itbl_blk + i); | 117 | c = EXT4_B2C(sbi, itbl_blk + i - start); |
118 | if ((c < num_clusters) || (c == inode_cluster) || | 118 | if ((c < num_clusters) || (c == inode_cluster) || |
119 | (c == block_cluster) || (c == itbl_cluster)) | 119 | (c == block_cluster) || (c == itbl_cluster)) |
120 | continue; | 120 | continue; |
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index aa39e600d159..8e07d2a5a139 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c | |||
@@ -324,74 +324,27 @@ static inline loff_t ext4_get_htree_eof(struct file *filp) | |||
324 | 324 | ||
325 | 325 | ||
326 | /* | 326 | /* |
327 | * ext4_dir_llseek() based on generic_file_llseek() to handle both | 327 | * ext4_dir_llseek() calls generic_file_llseek_size to handle htree |
328 | * non-htree and htree directories, where the "offset" is in terms | 328 | * directories, where the "offset" is in terms of the filename hash |
329 | * of the filename hash value instead of the byte offset. | 329 | * value instead of the byte offset. |
330 | * | 330 | * |
331 | * NOTE: offsets obtained *before* ext4_set_inode_flag(dir, EXT4_INODE_INDEX) | 331 | * Because we may return a 64-bit hash that is well beyond offset limits, |
332 | * will be invalid once the directory was converted into a dx directory | 332 | * we need to pass the max hash as the maximum allowable offset in |
333 | * the htree directory case. | ||
334 | * | ||
335 | * For non-htree, ext4_llseek already chooses the proper max offset. | ||
333 | */ | 336 | */ |
334 | loff_t ext4_dir_llseek(struct file *file, loff_t offset, int origin) | 337 | loff_t ext4_dir_llseek(struct file *file, loff_t offset, int origin) |
335 | { | 338 | { |
336 | struct inode *inode = file->f_mapping->host; | 339 | struct inode *inode = file->f_mapping->host; |
337 | loff_t ret = -EINVAL; | ||
338 | int dx_dir = is_dx_dir(inode); | 340 | int dx_dir = is_dx_dir(inode); |
341 | loff_t htree_max = ext4_get_htree_eof(file); | ||
339 | 342 | ||
340 | mutex_lock(&inode->i_mutex); | 343 | if (likely(dx_dir)) |
341 | 344 | return generic_file_llseek_size(file, offset, origin, | |
342 | /* NOTE: relative offsets with dx directories might not work | 345 | htree_max, htree_max); |
343 | * as expected, as it is difficult to figure out the | 346 | else |
344 | * correct offset between dx hashes */ | 347 | return ext4_llseek(file, offset, origin); |
345 | |||
346 | switch (origin) { | ||
347 | case SEEK_END: | ||
348 | if (unlikely(offset > 0)) | ||
349 | goto out_err; /* not supported for directories */ | ||
350 | |||
351 | /* so only negative offsets are left, does that have a | ||
352 | * meaning for directories at all? */ | ||
353 | if (dx_dir) | ||
354 | offset += ext4_get_htree_eof(file); | ||
355 | else | ||
356 | offset += inode->i_size; | ||
357 | break; | ||
358 | case SEEK_CUR: | ||
359 | /* | ||
360 | * Here we special-case the lseek(fd, 0, SEEK_CUR) | ||
361 | * position-querying operation. Avoid rewriting the "same" | ||
362 | * f_pos value back to the file because a concurrent read(), | ||
363 | * write() or lseek() might have altered it | ||
364 | */ | ||
365 | if (offset == 0) { | ||
366 | offset = file->f_pos; | ||
367 | goto out_ok; | ||
368 | } | ||
369 | |||
370 | offset += file->f_pos; | ||
371 | break; | ||
372 | } | ||
373 | |||
374 | if (unlikely(offset < 0)) | ||
375 | goto out_err; | ||
376 | |||
377 | if (!dx_dir) { | ||
378 | if (offset > inode->i_sb->s_maxbytes) | ||
379 | goto out_err; | ||
380 | } else if (offset > ext4_get_htree_eof(file)) | ||
381 | goto out_err; | ||
382 | |||
383 | /* Special lock needed here? */ | ||
384 | if (offset != file->f_pos) { | ||
385 | file->f_pos = offset; | ||
386 | file->f_version = 0; | ||
387 | } | ||
388 | |||
389 | out_ok: | ||
390 | ret = offset; | ||
391 | out_err: | ||
392 | mutex_unlock(&inode->i_mutex); | ||
393 | |||
394 | return ret; | ||
395 | } | 348 | } |
396 | 349 | ||
397 | /* | 350 | /* |
diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 8c7642a00054..782eecb57e43 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c | |||
@@ -211,9 +211,9 @@ static int ext4_file_open(struct inode * inode, struct file * filp) | |||
211 | } | 211 | } |
212 | 212 | ||
213 | /* | 213 | /* |
214 | * ext4_llseek() copied from generic_file_llseek() to handle both | 214 | * ext4_llseek() handles both block-mapped and extent-mapped maxbytes values |
215 | * block-mapped and extent-mapped maxbytes values. This should | 215 | * by calling generic_file_llseek_size() with the appropriate maxbytes |
216 | * otherwise be identical with generic_file_llseek(). | 216 | * value for each. |
217 | */ | 217 | */ |
218 | loff_t ext4_llseek(struct file *file, loff_t offset, int origin) | 218 | loff_t ext4_llseek(struct file *file, loff_t offset, int origin) |
219 | { | 219 | { |
@@ -225,7 +225,8 @@ loff_t ext4_llseek(struct file *file, loff_t offset, int origin) | |||
225 | else | 225 | else |
226 | maxbytes = inode->i_sb->s_maxbytes; | 226 | maxbytes = inode->i_sb->s_maxbytes; |
227 | 227 | ||
228 | return generic_file_llseek_size(file, offset, origin, maxbytes); | 228 | return generic_file_llseek_size(file, offset, origin, |
229 | maxbytes, i_size_read(inode)); | ||
229 | } | 230 | } |
230 | 231 | ||
231 | const struct file_operations ext4_file_operations = { | 232 | const struct file_operations ext4_file_operations = { |
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index bb6c7d811313..2a1dcea4f12e 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c | |||
@@ -135,14 +135,7 @@ static int ext4_sync_parent(struct inode *inode) | |||
135 | inode = igrab(inode); | 135 | inode = igrab(inode); |
136 | while (ext4_test_inode_state(inode, EXT4_STATE_NEWENTRY)) { | 136 | while (ext4_test_inode_state(inode, EXT4_STATE_NEWENTRY)) { |
137 | ext4_clear_inode_state(inode, EXT4_STATE_NEWENTRY); | 137 | ext4_clear_inode_state(inode, EXT4_STATE_NEWENTRY); |
138 | dentry = NULL; | 138 | dentry = d_find_any_alias(inode); |
139 | spin_lock(&inode->i_lock); | ||
140 | if (!list_empty(&inode->i_dentry)) { | ||
141 | dentry = list_first_entry(&inode->i_dentry, | ||
142 | struct dentry, d_alias); | ||
143 | dget(dentry); | ||
144 | } | ||
145 | spin_unlock(&inode->i_lock); | ||
146 | if (!dentry) | 139 | if (!dentry) |
147 | break; | 140 | break; |
148 | next = igrab(dentry->d_parent->d_inode); | 141 | next = igrab(dentry->d_parent->d_inode); |
@@ -232,7 +225,7 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync) | |||
232 | 225 | ||
233 | if (!journal) { | 226 | if (!journal) { |
234 | ret = __sync_inode(inode, datasync); | 227 | ret = __sync_inode(inode, datasync); |
235 | if (!ret && !list_empty(&inode->i_dentry)) | 228 | if (!ret && !hlist_empty(&inode->i_dentry)) |
236 | ret = ext4_sync_parent(inode); | 229 | ret = ext4_sync_parent(inode); |
237 | goto out; | 230 | goto out; |
238 | } | 231 | } |
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 8ad112ae0ade..7f7dad787603 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c | |||
@@ -123,7 +123,6 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) | |||
123 | else | 123 | else |
124 | ext4_clear_inode_flag(inode, i); | 124 | ext4_clear_inode_flag(inode, i); |
125 | } | 125 | } |
126 | ei->i_flags = flags; | ||
127 | 126 | ||
128 | ext4_set_inode_flags(inode); | 127 | ext4_set_inode_flags(inode); |
129 | inode->i_ctime = ext4_current_time(inode); | 128 | inode->i_ctime = ext4_current_time(inode); |
@@ -269,7 +268,6 @@ group_extend_out: | |||
269 | err = ext4_move_extents(filp, donor_filp, me.orig_start, | 268 | err = ext4_move_extents(filp, donor_filp, me.orig_start, |
270 | me.donor_start, me.len, &me.moved_len); | 269 | me.donor_start, me.len, &me.moved_len); |
271 | mnt_drop_write_file(filp); | 270 | mnt_drop_write_file(filp); |
272 | mnt_drop_write(filp->f_path.mnt); | ||
273 | 271 | ||
274 | if (copy_to_user((struct move_extent __user *)arg, | 272 | if (copy_to_user((struct move_extent __user *)arg, |
275 | &me, sizeof(me))) | 273 | &me, sizeof(me))) |
@@ -391,7 +389,7 @@ group_add_out: | |||
391 | if (err) | 389 | if (err) |
392 | return err; | 390 | return err; |
393 | 391 | ||
394 | err = mnt_want_write(filp->f_path.mnt); | 392 | err = mnt_want_write_file(filp); |
395 | if (err) | 393 | if (err) |
396 | goto resizefs_out; | 394 | goto resizefs_out; |
397 | 395 | ||
@@ -403,7 +401,7 @@ group_add_out: | |||
403 | } | 401 | } |
404 | if (err == 0) | 402 | if (err == 0) |
405 | err = err2; | 403 | err = err2; |
406 | mnt_drop_write(filp->f_path.mnt); | 404 | mnt_drop_write_file(filp); |
407 | resizefs_out: | 405 | resizefs_out: |
408 | ext4_resize_end(sb); | 406 | ext4_resize_end(sb); |
409 | return err; | 407 | return err; |
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 5845cd97bf8b..d0d3f0e87f99 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c | |||
@@ -1312,7 +1312,7 @@ errout: | |||
1312 | return NULL; | 1312 | return NULL; |
1313 | } | 1313 | } |
1314 | 1314 | ||
1315 | static struct dentry *ext4_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 1315 | static struct dentry *ext4_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
1316 | { | 1316 | { |
1317 | struct inode *inode; | 1317 | struct inode *inode; |
1318 | struct ext4_dir_entry_2 *de; | 1318 | struct ext4_dir_entry_2 *de; |
@@ -2072,8 +2072,8 @@ static int ext4_add_nondir(handle_t *handle, | |||
2072 | int err = ext4_add_entry(handle, dentry, inode); | 2072 | int err = ext4_add_entry(handle, dentry, inode); |
2073 | if (!err) { | 2073 | if (!err) { |
2074 | ext4_mark_inode_dirty(handle, inode); | 2074 | ext4_mark_inode_dirty(handle, inode); |
2075 | d_instantiate(dentry, inode); | ||
2076 | unlock_new_inode(inode); | 2075 | unlock_new_inode(inode); |
2076 | d_instantiate(dentry, inode); | ||
2077 | return 0; | 2077 | return 0; |
2078 | } | 2078 | } |
2079 | drop_nlink(inode); | 2079 | drop_nlink(inode); |
@@ -2091,7 +2091,7 @@ static int ext4_add_nondir(handle_t *handle, | |||
2091 | * with d_instantiate(). | 2091 | * with d_instantiate(). |
2092 | */ | 2092 | */ |
2093 | static int ext4_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 2093 | static int ext4_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
2094 | struct nameidata *nd) | 2094 | bool excl) |
2095 | { | 2095 | { |
2096 | handle_t *handle; | 2096 | handle_t *handle; |
2097 | struct inode *inode; | 2097 | struct inode *inode; |
@@ -2249,8 +2249,8 @@ out_clear_inode: | |||
2249 | err = ext4_mark_inode_dirty(handle, dir); | 2249 | err = ext4_mark_inode_dirty(handle, dir); |
2250 | if (err) | 2250 | if (err) |
2251 | goto out_clear_inode; | 2251 | goto out_clear_inode; |
2252 | d_instantiate(dentry, inode); | ||
2253 | unlock_new_inode(inode); | 2252 | unlock_new_inode(inode); |
2253 | d_instantiate(dentry, inode); | ||
2254 | out_stop: | 2254 | out_stop: |
2255 | brelse(dir_block); | 2255 | brelse(dir_block); |
2256 | ext4_journal_stop(handle); | 2256 | ext4_journal_stop(handle); |
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index eb7aa3e4ef05..d8759401ecae 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
@@ -4325,6 +4325,11 @@ static int ext4_sync_fs(struct super_block *sb, int wait) | |||
4325 | 4325 | ||
4326 | trace_ext4_sync_fs(sb, wait); | 4326 | trace_ext4_sync_fs(sb, wait); |
4327 | flush_workqueue(sbi->dio_unwritten_wq); | 4327 | flush_workqueue(sbi->dio_unwritten_wq); |
4328 | /* | ||
4329 | * Writeback quota in non-journalled quota case - journalled quota has | ||
4330 | * no dirty dquots | ||
4331 | */ | ||
4332 | dquot_writeback_dquots(sb, -1); | ||
4328 | if (jbd2_journal_start_commit(sbi->s_journal, &target)) { | 4333 | if (jbd2_journal_start_commit(sbi->s_journal, &target)) { |
4329 | if (wait) | 4334 | if (wait) |
4330 | jbd2_log_wait_commit(sbi->s_journal, target); | 4335 | jbd2_log_wait_commit(sbi->s_journal, target); |
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index a3d81ebf6d86..0038b32cb362 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
@@ -738,22 +738,21 @@ static int | |||
738 | fat_encode_fh(struct inode *inode, __u32 *fh, int *lenp, struct inode *parent) | 738 | fat_encode_fh(struct inode *inode, __u32 *fh, int *lenp, struct inode *parent) |
739 | { | 739 | { |
740 | int len = *lenp; | 740 | int len = *lenp; |
741 | u32 ipos_h, ipos_m, ipos_l; | 741 | struct msdos_sb_info *sbi = MSDOS_SB(inode->i_sb); |
742 | loff_t i_pos; | ||
742 | 743 | ||
743 | if (len < 5) { | 744 | if (len < 5) { |
744 | *lenp = 5; | 745 | *lenp = 5; |
745 | return 255; /* no room */ | 746 | return 255; /* no room */ |
746 | } | 747 | } |
747 | 748 | ||
748 | ipos_h = MSDOS_I(inode)->i_pos >> 8; | 749 | i_pos = fat_i_pos_read(sbi, inode); |
749 | ipos_m = (MSDOS_I(inode)->i_pos & 0xf0) << 24; | ||
750 | ipos_l = (MSDOS_I(inode)->i_pos & 0x0f) << 28; | ||
751 | *lenp = 5; | 750 | *lenp = 5; |
752 | fh[0] = inode->i_ino; | 751 | fh[0] = inode->i_ino; |
753 | fh[1] = inode->i_generation; | 752 | fh[1] = inode->i_generation; |
754 | fh[2] = ipos_h; | 753 | fh[2] = i_pos >> 8; |
755 | fh[3] = ipos_m | MSDOS_I(inode)->i_logstart; | 754 | fh[3] = ((i_pos & 0xf0) << 24) | MSDOS_I(inode)->i_logstart; |
756 | fh[4] = ipos_l; | 755 | fh[4] = (i_pos & 0x0f) << 28; |
757 | if (parent) | 756 | if (parent) |
758 | fh[4] |= MSDOS_I(parent)->i_logstart; | 757 | fh[4] |= MSDOS_I(parent)->i_logstart; |
759 | return 3; | 758 | return 3; |
diff --git a/fs/fat/namei_msdos.c b/fs/fat/namei_msdos.c index c5938c9084b9..70d993a93805 100644 --- a/fs/fat/namei_msdos.c +++ b/fs/fat/namei_msdos.c | |||
@@ -201,7 +201,7 @@ static const struct dentry_operations msdos_dentry_operations = { | |||
201 | 201 | ||
202 | /***** Get inode using directory and name */ | 202 | /***** Get inode using directory and name */ |
203 | static struct dentry *msdos_lookup(struct inode *dir, struct dentry *dentry, | 203 | static struct dentry *msdos_lookup(struct inode *dir, struct dentry *dentry, |
204 | struct nameidata *nd) | 204 | unsigned int flags) |
205 | { | 205 | { |
206 | struct super_block *sb = dir->i_sb; | 206 | struct super_block *sb = dir->i_sb; |
207 | struct fat_slot_info sinfo; | 207 | struct fat_slot_info sinfo; |
@@ -265,7 +265,7 @@ static int msdos_add_entry(struct inode *dir, const unsigned char *name, | |||
265 | 265 | ||
266 | /***** Create a file */ | 266 | /***** Create a file */ |
267 | static int msdos_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 267 | static int msdos_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
268 | struct nameidata *nd) | 268 | bool excl) |
269 | { | 269 | { |
270 | struct super_block *sb = dir->i_sb; | 270 | struct super_block *sb = dir->i_sb; |
271 | struct inode *inode = NULL; | 271 | struct inode *inode = NULL; |
diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c index 98ae804f5273..6cc480652433 100644 --- a/fs/fat/namei_vfat.c +++ b/fs/fat/namei_vfat.c | |||
@@ -41,9 +41,9 @@ static int vfat_revalidate_shortname(struct dentry *dentry) | |||
41 | return ret; | 41 | return ret; |
42 | } | 42 | } |
43 | 43 | ||
44 | static int vfat_revalidate(struct dentry *dentry, struct nameidata *nd) | 44 | static int vfat_revalidate(struct dentry *dentry, unsigned int flags) |
45 | { | 45 | { |
46 | if (nd && nd->flags & LOOKUP_RCU) | 46 | if (flags & LOOKUP_RCU) |
47 | return -ECHILD; | 47 | return -ECHILD; |
48 | 48 | ||
49 | /* This is not negative dentry. Always valid. */ | 49 | /* This is not negative dentry. Always valid. */ |
@@ -52,9 +52,9 @@ static int vfat_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
52 | return vfat_revalidate_shortname(dentry); | 52 | return vfat_revalidate_shortname(dentry); |
53 | } | 53 | } |
54 | 54 | ||
55 | static int vfat_revalidate_ci(struct dentry *dentry, struct nameidata *nd) | 55 | static int vfat_revalidate_ci(struct dentry *dentry, unsigned int flags) |
56 | { | 56 | { |
57 | if (nd && nd->flags & LOOKUP_RCU) | 57 | if (flags & LOOKUP_RCU) |
58 | return -ECHILD; | 58 | return -ECHILD; |
59 | 59 | ||
60 | /* | 60 | /* |
@@ -74,7 +74,7 @@ static int vfat_revalidate_ci(struct dentry *dentry, struct nameidata *nd) | |||
74 | * This may be nfsd (or something), anyway, we can't see the | 74 | * This may be nfsd (or something), anyway, we can't see the |
75 | * intent of this. So, since this can be for creation, drop it. | 75 | * intent of this. So, since this can be for creation, drop it. |
76 | */ | 76 | */ |
77 | if (!nd) | 77 | if (!flags) |
78 | return 0; | 78 | return 0; |
79 | 79 | ||
80 | /* | 80 | /* |
@@ -82,7 +82,7 @@ static int vfat_revalidate_ci(struct dentry *dentry, struct nameidata *nd) | |||
82 | * case sensitive name which is specified by user if this is | 82 | * case sensitive name which is specified by user if this is |
83 | * for creation. | 83 | * for creation. |
84 | */ | 84 | */ |
85 | if (nd->flags & (LOOKUP_CREATE | LOOKUP_RENAME_TARGET)) | 85 | if (flags & (LOOKUP_CREATE | LOOKUP_RENAME_TARGET)) |
86 | return 0; | 86 | return 0; |
87 | 87 | ||
88 | return vfat_revalidate_shortname(dentry); | 88 | return vfat_revalidate_shortname(dentry); |
@@ -714,7 +714,7 @@ static int vfat_d_anon_disconn(struct dentry *dentry) | |||
714 | } | 714 | } |
715 | 715 | ||
716 | static struct dentry *vfat_lookup(struct inode *dir, struct dentry *dentry, | 716 | static struct dentry *vfat_lookup(struct inode *dir, struct dentry *dentry, |
717 | struct nameidata *nd) | 717 | unsigned int flags) |
718 | { | 718 | { |
719 | struct super_block *sb = dir->i_sb; | 719 | struct super_block *sb = dir->i_sb; |
720 | struct fat_slot_info sinfo; | 720 | struct fat_slot_info sinfo; |
@@ -772,7 +772,7 @@ error: | |||
772 | } | 772 | } |
773 | 773 | ||
774 | static int vfat_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 774 | static int vfat_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
775 | struct nameidata *nd) | 775 | bool excl) |
776 | { | 776 | { |
777 | struct super_block *sb = dir->i_sb; | 777 | struct super_block *sb = dir->i_sb; |
778 | struct inode *inode; | 778 | struct inode *inode; |
@@ -14,7 +14,7 @@ | |||
14 | #include <linux/sched.h> | 14 | #include <linux/sched.h> |
15 | #include <linux/pipe_fs_i.h> | 15 | #include <linux/pipe_fs_i.h> |
16 | 16 | ||
17 | static void wait_for_partner(struct inode* inode, unsigned int *cnt) | 17 | static int wait_for_partner(struct inode* inode, unsigned int *cnt) |
18 | { | 18 | { |
19 | int cur = *cnt; | 19 | int cur = *cnt; |
20 | 20 | ||
@@ -23,6 +23,7 @@ static void wait_for_partner(struct inode* inode, unsigned int *cnt) | |||
23 | if (signal_pending(current)) | 23 | if (signal_pending(current)) |
24 | break; | 24 | break; |
25 | } | 25 | } |
26 | return cur == *cnt ? -ERESTARTSYS : 0; | ||
26 | } | 27 | } |
27 | 28 | ||
28 | static void wake_up_partner(struct inode* inode) | 29 | static void wake_up_partner(struct inode* inode) |
@@ -67,8 +68,7 @@ static int fifo_open(struct inode *inode, struct file *filp) | |||
67 | * seen a writer */ | 68 | * seen a writer */ |
68 | filp->f_version = pipe->w_counter; | 69 | filp->f_version = pipe->w_counter; |
69 | } else { | 70 | } else { |
70 | wait_for_partner(inode, &pipe->w_counter); | 71 | if (wait_for_partner(inode, &pipe->w_counter)) |
71 | if(signal_pending(current)) | ||
72 | goto err_rd; | 72 | goto err_rd; |
73 | } | 73 | } |
74 | } | 74 | } |
@@ -90,8 +90,7 @@ static int fifo_open(struct inode *inode, struct file *filp) | |||
90 | wake_up_partner(inode); | 90 | wake_up_partner(inode); |
91 | 91 | ||
92 | if (!pipe->readers) { | 92 | if (!pipe->readers) { |
93 | wait_for_partner(inode, &pipe->r_counter); | 93 | if (wait_for_partner(inode, &pipe->r_counter)) |
94 | if (signal_pending(current)) | ||
95 | goto err_wr; | 94 | goto err_wr; |
96 | } | 95 | } |
97 | break; | 96 | break; |
diff --git a/fs/file_table.c b/fs/file_table.c index a305d9e2d1b2..b3fc4d67a26b 100644 --- a/fs/file_table.c +++ b/fs/file_table.c | |||
@@ -23,6 +23,8 @@ | |||
23 | #include <linux/lglock.h> | 23 | #include <linux/lglock.h> |
24 | #include <linux/percpu_counter.h> | 24 | #include <linux/percpu_counter.h> |
25 | #include <linux/percpu.h> | 25 | #include <linux/percpu.h> |
26 | #include <linux/hardirq.h> | ||
27 | #include <linux/task_work.h> | ||
26 | #include <linux/ima.h> | 28 | #include <linux/ima.h> |
27 | 29 | ||
28 | #include <linux/atomic.h> | 30 | #include <linux/atomic.h> |
@@ -251,7 +253,6 @@ static void __fput(struct file *file) | |||
251 | } | 253 | } |
252 | fops_put(file->f_op); | 254 | fops_put(file->f_op); |
253 | put_pid(file->f_owner.pid); | 255 | put_pid(file->f_owner.pid); |
254 | file_sb_list_del(file); | ||
255 | if ((file->f_mode & (FMODE_READ | FMODE_WRITE)) == FMODE_READ) | 256 | if ((file->f_mode & (FMODE_READ | FMODE_WRITE)) == FMODE_READ) |
256 | i_readcount_dec(inode); | 257 | i_readcount_dec(inode); |
257 | if (file->f_mode & FMODE_WRITE) | 258 | if (file->f_mode & FMODE_WRITE) |
@@ -263,10 +264,77 @@ static void __fput(struct file *file) | |||
263 | mntput(mnt); | 264 | mntput(mnt); |
264 | } | 265 | } |
265 | 266 | ||
267 | static DEFINE_SPINLOCK(delayed_fput_lock); | ||
268 | static LIST_HEAD(delayed_fput_list); | ||
269 | static void delayed_fput(struct work_struct *unused) | ||
270 | { | ||
271 | LIST_HEAD(head); | ||
272 | spin_lock_irq(&delayed_fput_lock); | ||
273 | list_splice_init(&delayed_fput_list, &head); | ||
274 | spin_unlock_irq(&delayed_fput_lock); | ||
275 | while (!list_empty(&head)) { | ||
276 | struct file *f = list_first_entry(&head, struct file, f_u.fu_list); | ||
277 | list_del_init(&f->f_u.fu_list); | ||
278 | __fput(f); | ||
279 | } | ||
280 | } | ||
281 | |||
282 | static void ____fput(struct callback_head *work) | ||
283 | { | ||
284 | __fput(container_of(work, struct file, f_u.fu_rcuhead)); | ||
285 | } | ||
286 | |||
287 | /* | ||
288 | * If kernel thread really needs to have the final fput() it has done | ||
289 | * to complete, call this. The only user right now is the boot - we | ||
290 | * *do* need to make sure our writes to binaries on initramfs has | ||
291 | * not left us with opened struct file waiting for __fput() - execve() | ||
292 | * won't work without that. Please, don't add more callers without | ||
293 | * very good reasons; in particular, never call that with locks | ||
294 | * held and never call that from a thread that might need to do | ||
295 | * some work on any kind of umount. | ||
296 | */ | ||
297 | void flush_delayed_fput(void) | ||
298 | { | ||
299 | delayed_fput(NULL); | ||
300 | } | ||
301 | |||
302 | static DECLARE_WORK(delayed_fput_work, delayed_fput); | ||
303 | |||
266 | void fput(struct file *file) | 304 | void fput(struct file *file) |
267 | { | 305 | { |
268 | if (atomic_long_dec_and_test(&file->f_count)) | 306 | if (atomic_long_dec_and_test(&file->f_count)) { |
307 | struct task_struct *task = current; | ||
308 | file_sb_list_del(file); | ||
309 | if (unlikely(in_interrupt() || task->flags & PF_KTHREAD)) { | ||
310 | unsigned long flags; | ||
311 | spin_lock_irqsave(&delayed_fput_lock, flags); | ||
312 | list_add(&file->f_u.fu_list, &delayed_fput_list); | ||
313 | schedule_work(&delayed_fput_work); | ||
314 | spin_unlock_irqrestore(&delayed_fput_lock, flags); | ||
315 | return; | ||
316 | } | ||
317 | init_task_work(&file->f_u.fu_rcuhead, ____fput); | ||
318 | task_work_add(task, &file->f_u.fu_rcuhead, true); | ||
319 | } | ||
320 | } | ||
321 | |||
322 | /* | ||
323 | * synchronous analog of fput(); for kernel threads that might be needed | ||
324 | * in some umount() (and thus can't use flush_delayed_fput() without | ||
325 | * risking deadlocks), need to wait for completion of __fput() and know | ||
326 | * for this specific struct file it won't involve anything that would | ||
327 | * need them. Use only if you really need it - at the very least, | ||
328 | * don't blindly convert fput() by kernel thread to that. | ||
329 | */ | ||
330 | void __fput_sync(struct file *file) | ||
331 | { | ||
332 | if (atomic_long_dec_and_test(&file->f_count)) { | ||
333 | struct task_struct *task = current; | ||
334 | file_sb_list_del(file); | ||
335 | BUG_ON(!(task->flags & PF_KTHREAD)); | ||
269 | __fput(file); | 336 | __fput(file); |
337 | } | ||
270 | } | 338 | } |
271 | 339 | ||
272 | EXPORT_SYMBOL(fput); | 340 | EXPORT_SYMBOL(fput); |
@@ -483,10 +551,8 @@ void mark_files_ro(struct super_block *sb) | |||
483 | { | 551 | { |
484 | struct file *f; | 552 | struct file *f; |
485 | 553 | ||
486 | retry: | ||
487 | lg_global_lock(&files_lglock); | 554 | lg_global_lock(&files_lglock); |
488 | do_file_list_for_each_entry(sb, f) { | 555 | do_file_list_for_each_entry(sb, f) { |
489 | struct vfsmount *mnt; | ||
490 | if (!S_ISREG(f->f_path.dentry->d_inode->i_mode)) | 556 | if (!S_ISREG(f->f_path.dentry->d_inode->i_mode)) |
491 | continue; | 557 | continue; |
492 | if (!file_count(f)) | 558 | if (!file_count(f)) |
@@ -499,12 +565,7 @@ retry: | |||
499 | if (file_check_writeable(f) != 0) | 565 | if (file_check_writeable(f) != 0) |
500 | continue; | 566 | continue; |
501 | file_release_write(f); | 567 | file_release_write(f); |
502 | mnt = mntget(f->f_path.mnt); | 568 | mnt_drop_write_file(f); |
503 | /* This can sleep, so we can't hold the spinlock. */ | ||
504 | lg_global_unlock(&files_lglock); | ||
505 | mnt_drop_write(mnt); | ||
506 | mntput(mnt); | ||
507 | goto retry; | ||
508 | } while_file_list_for_each_entry; | 569 | } while_file_list_for_each_entry; |
509 | lg_global_unlock(&files_lglock); | 570 | lg_global_unlock(&files_lglock); |
510 | } | 571 | } |
diff --git a/fs/freevxfs/vxfs_lookup.c b/fs/freevxfs/vxfs_lookup.c index 3360f1e678ad..bd447e88f208 100644 --- a/fs/freevxfs/vxfs_lookup.c +++ b/fs/freevxfs/vxfs_lookup.c | |||
@@ -48,7 +48,7 @@ | |||
48 | #define VXFS_BLOCK_PER_PAGE(sbp) ((PAGE_CACHE_SIZE / (sbp)->s_blocksize)) | 48 | #define VXFS_BLOCK_PER_PAGE(sbp) ((PAGE_CACHE_SIZE / (sbp)->s_blocksize)) |
49 | 49 | ||
50 | 50 | ||
51 | static struct dentry * vxfs_lookup(struct inode *, struct dentry *, struct nameidata *); | 51 | static struct dentry * vxfs_lookup(struct inode *, struct dentry *, unsigned int); |
52 | static int vxfs_readdir(struct file *, void *, filldir_t); | 52 | static int vxfs_readdir(struct file *, void *, filldir_t); |
53 | 53 | ||
54 | const struct inode_operations vxfs_dir_inode_ops = { | 54 | const struct inode_operations vxfs_dir_inode_ops = { |
@@ -203,7 +203,7 @@ vxfs_inode_by_name(struct inode *dip, struct dentry *dp) | |||
203 | * in the return pointer. | 203 | * in the return pointer. |
204 | */ | 204 | */ |
205 | static struct dentry * | 205 | static struct dentry * |
206 | vxfs_lookup(struct inode *dip, struct dentry *dp, struct nameidata *nd) | 206 | vxfs_lookup(struct inode *dip, struct dentry *dp, unsigned int flags) |
207 | { | 207 | { |
208 | struct inode *ip = NULL; | 208 | struct inode *ip = NULL; |
209 | ino_t ino; | 209 | ino_t ino; |
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 8d2fb8c88cf3..8f660dd6137a 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
@@ -664,6 +664,7 @@ static long writeback_sb_inodes(struct super_block *sb, | |||
664 | /* Wait for I_SYNC. This function drops i_lock... */ | 664 | /* Wait for I_SYNC. This function drops i_lock... */ |
665 | inode_sleep_on_writeback(inode); | 665 | inode_sleep_on_writeback(inode); |
666 | /* Inode may be gone, start again */ | 666 | /* Inode may be gone, start again */ |
667 | spin_lock(&wb->list_lock); | ||
667 | continue; | 668 | continue; |
668 | } | 669 | } |
669 | inode->i_state |= I_SYNC; | 670 | inode->i_state |= I_SYNC; |
@@ -1314,6 +1315,8 @@ void writeback_inodes_sb_nr(struct super_block *sb, | |||
1314 | .reason = reason, | 1315 | .reason = reason, |
1315 | }; | 1316 | }; |
1316 | 1317 | ||
1318 | if (sb->s_bdi == &noop_backing_dev_info) | ||
1319 | return; | ||
1317 | WARN_ON(!rwsem_is_locked(&sb->s_umount)); | 1320 | WARN_ON(!rwsem_is_locked(&sb->s_umount)); |
1318 | bdi_queue_work(sb->s_bdi, &work); | 1321 | bdi_queue_work(sb->s_bdi, &work); |
1319 | wait_for_completion(&done); | 1322 | wait_for_completion(&done); |
@@ -1397,6 +1400,9 @@ void sync_inodes_sb(struct super_block *sb) | |||
1397 | .reason = WB_REASON_SYNC, | 1400 | .reason = WB_REASON_SYNC, |
1398 | }; | 1401 | }; |
1399 | 1402 | ||
1403 | /* Nothing to do? */ | ||
1404 | if (sb->s_bdi == &noop_backing_dev_info) | ||
1405 | return; | ||
1400 | WARN_ON(!rwsem_is_locked(&sb->s_umount)); | 1406 | WARN_ON(!rwsem_is_locked(&sb->s_umount)); |
1401 | 1407 | ||
1402 | bdi_queue_work(sb->s_bdi, &work); | 1408 | bdi_queue_work(sb->s_bdi, &work); |
diff --git a/fs/fs_struct.c b/fs/fs_struct.c index e159e682ad4c..5df4775fea03 100644 --- a/fs/fs_struct.c +++ b/fs/fs_struct.c | |||
@@ -6,18 +6,6 @@ | |||
6 | #include <linux/fs_struct.h> | 6 | #include <linux/fs_struct.h> |
7 | #include "internal.h" | 7 | #include "internal.h" |
8 | 8 | ||
9 | static inline void path_get_longterm(struct path *path) | ||
10 | { | ||
11 | path_get(path); | ||
12 | mnt_make_longterm(path->mnt); | ||
13 | } | ||
14 | |||
15 | static inline void path_put_longterm(struct path *path) | ||
16 | { | ||
17 | mnt_make_shortterm(path->mnt); | ||
18 | path_put(path); | ||
19 | } | ||
20 | |||
21 | /* | 9 | /* |
22 | * Replace the fs->{rootmnt,root} with {mnt,dentry}. Put the old values. | 10 | * Replace the fs->{rootmnt,root} with {mnt,dentry}. Put the old values. |
23 | * It can block. | 11 | * It can block. |
@@ -26,7 +14,7 @@ void set_fs_root(struct fs_struct *fs, struct path *path) | |||
26 | { | 14 | { |
27 | struct path old_root; | 15 | struct path old_root; |
28 | 16 | ||
29 | path_get_longterm(path); | 17 | path_get(path); |
30 | spin_lock(&fs->lock); | 18 | spin_lock(&fs->lock); |
31 | write_seqcount_begin(&fs->seq); | 19 | write_seqcount_begin(&fs->seq); |
32 | old_root = fs->root; | 20 | old_root = fs->root; |
@@ -34,7 +22,7 @@ void set_fs_root(struct fs_struct *fs, struct path *path) | |||
34 | write_seqcount_end(&fs->seq); | 22 | write_seqcount_end(&fs->seq); |
35 | spin_unlock(&fs->lock); | 23 | spin_unlock(&fs->lock); |
36 | if (old_root.dentry) | 24 | if (old_root.dentry) |
37 | path_put_longterm(&old_root); | 25 | path_put(&old_root); |
38 | } | 26 | } |
39 | 27 | ||
40 | /* | 28 | /* |
@@ -45,7 +33,7 @@ void set_fs_pwd(struct fs_struct *fs, struct path *path) | |||
45 | { | 33 | { |
46 | struct path old_pwd; | 34 | struct path old_pwd; |
47 | 35 | ||
48 | path_get_longterm(path); | 36 | path_get(path); |
49 | spin_lock(&fs->lock); | 37 | spin_lock(&fs->lock); |
50 | write_seqcount_begin(&fs->seq); | 38 | write_seqcount_begin(&fs->seq); |
51 | old_pwd = fs->pwd; | 39 | old_pwd = fs->pwd; |
@@ -54,7 +42,7 @@ void set_fs_pwd(struct fs_struct *fs, struct path *path) | |||
54 | spin_unlock(&fs->lock); | 42 | spin_unlock(&fs->lock); |
55 | 43 | ||
56 | if (old_pwd.dentry) | 44 | if (old_pwd.dentry) |
57 | path_put_longterm(&old_pwd); | 45 | path_put(&old_pwd); |
58 | } | 46 | } |
59 | 47 | ||
60 | static inline int replace_path(struct path *p, const struct path *old, const struct path *new) | 48 | static inline int replace_path(struct path *p, const struct path *old, const struct path *new) |
@@ -84,7 +72,7 @@ void chroot_fs_refs(struct path *old_root, struct path *new_root) | |||
84 | write_seqcount_end(&fs->seq); | 72 | write_seqcount_end(&fs->seq); |
85 | while (hits--) { | 73 | while (hits--) { |
86 | count++; | 74 | count++; |
87 | path_get_longterm(new_root); | 75 | path_get(new_root); |
88 | } | 76 | } |
89 | spin_unlock(&fs->lock); | 77 | spin_unlock(&fs->lock); |
90 | } | 78 | } |
@@ -92,13 +80,13 @@ void chroot_fs_refs(struct path *old_root, struct path *new_root) | |||
92 | } while_each_thread(g, p); | 80 | } while_each_thread(g, p); |
93 | read_unlock(&tasklist_lock); | 81 | read_unlock(&tasklist_lock); |
94 | while (count--) | 82 | while (count--) |
95 | path_put_longterm(old_root); | 83 | path_put(old_root); |
96 | } | 84 | } |
97 | 85 | ||
98 | void free_fs_struct(struct fs_struct *fs) | 86 | void free_fs_struct(struct fs_struct *fs) |
99 | { | 87 | { |
100 | path_put_longterm(&fs->root); | 88 | path_put(&fs->root); |
101 | path_put_longterm(&fs->pwd); | 89 | path_put(&fs->pwd); |
102 | kmem_cache_free(fs_cachep, fs); | 90 | kmem_cache_free(fs_cachep, fs); |
103 | } | 91 | } |
104 | 92 | ||
@@ -132,9 +120,9 @@ struct fs_struct *copy_fs_struct(struct fs_struct *old) | |||
132 | 120 | ||
133 | spin_lock(&old->lock); | 121 | spin_lock(&old->lock); |
134 | fs->root = old->root; | 122 | fs->root = old->root; |
135 | path_get_longterm(&fs->root); | 123 | path_get(&fs->root); |
136 | fs->pwd = old->pwd; | 124 | fs->pwd = old->pwd; |
137 | path_get_longterm(&fs->pwd); | 125 | path_get(&fs->pwd); |
138 | spin_unlock(&old->lock); | 126 | spin_unlock(&old->lock); |
139 | } | 127 | } |
140 | return fs; | 128 | return fs; |
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index 334e0b18a014..8964cf3999b2 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c | |||
@@ -154,7 +154,7 @@ u64 fuse_get_attr_version(struct fuse_conn *fc) | |||
154 | * the lookup once more. If the lookup results in the same inode, | 154 | * the lookup once more. If the lookup results in the same inode, |
155 | * then refresh the attributes, timeouts and mark the dentry valid. | 155 | * then refresh the attributes, timeouts and mark the dentry valid. |
156 | */ | 156 | */ |
157 | static int fuse_dentry_revalidate(struct dentry *entry, struct nameidata *nd) | 157 | static int fuse_dentry_revalidate(struct dentry *entry, unsigned int flags) |
158 | { | 158 | { |
159 | struct inode *inode; | 159 | struct inode *inode; |
160 | 160 | ||
@@ -174,7 +174,7 @@ static int fuse_dentry_revalidate(struct dentry *entry, struct nameidata *nd) | |||
174 | if (!inode) | 174 | if (!inode) |
175 | return 0; | 175 | return 0; |
176 | 176 | ||
177 | if (nd && (nd->flags & LOOKUP_RCU)) | 177 | if (flags & LOOKUP_RCU) |
178 | return -ECHILD; | 178 | return -ECHILD; |
179 | 179 | ||
180 | fc = get_fuse_conn(inode); | 180 | fc = get_fuse_conn(inode); |
@@ -249,7 +249,7 @@ static struct dentry *fuse_d_add_directory(struct dentry *entry, | |||
249 | /* This tries to shrink the subtree below alias */ | 249 | /* This tries to shrink the subtree below alias */ |
250 | fuse_invalidate_entry(alias); | 250 | fuse_invalidate_entry(alias); |
251 | dput(alias); | 251 | dput(alias); |
252 | if (!list_empty(&inode->i_dentry)) | 252 | if (!hlist_empty(&inode->i_dentry)) |
253 | return ERR_PTR(-EBUSY); | 253 | return ERR_PTR(-EBUSY); |
254 | } else { | 254 | } else { |
255 | dput(alias); | 255 | dput(alias); |
@@ -316,7 +316,7 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, struct qstr *name, | |||
316 | } | 316 | } |
317 | 317 | ||
318 | static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, | 318 | static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, |
319 | struct nameidata *nd) | 319 | unsigned int flags) |
320 | { | 320 | { |
321 | int err; | 321 | int err; |
322 | struct fuse_entry_out outarg; | 322 | struct fuse_entry_out outarg; |
@@ -370,7 +370,8 @@ static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, | |||
370 | * 'mknod' + 'open' requests. | 370 | * 'mknod' + 'open' requests. |
371 | */ | 371 | */ |
372 | static int fuse_create_open(struct inode *dir, struct dentry *entry, | 372 | static int fuse_create_open(struct inode *dir, struct dentry *entry, |
373 | umode_t mode, struct nameidata *nd) | 373 | struct file *file, unsigned flags, |
374 | umode_t mode, int *opened) | ||
374 | { | 375 | { |
375 | int err; | 376 | int err; |
376 | struct inode *inode; | 377 | struct inode *inode; |
@@ -381,15 +382,11 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry, | |||
381 | struct fuse_open_out outopen; | 382 | struct fuse_open_out outopen; |
382 | struct fuse_entry_out outentry; | 383 | struct fuse_entry_out outentry; |
383 | struct fuse_file *ff; | 384 | struct fuse_file *ff; |
384 | struct file *file; | ||
385 | int flags = nd->intent.open.flags; | ||
386 | |||
387 | if (fc->no_create) | ||
388 | return -ENOSYS; | ||
389 | 385 | ||
390 | forget = fuse_alloc_forget(); | 386 | forget = fuse_alloc_forget(); |
387 | err = -ENOMEM; | ||
391 | if (!forget) | 388 | if (!forget) |
392 | return -ENOMEM; | 389 | goto out_err; |
393 | 390 | ||
394 | req = fuse_get_req(fc); | 391 | req = fuse_get_req(fc); |
395 | err = PTR_ERR(req); | 392 | err = PTR_ERR(req); |
@@ -428,11 +425,8 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry, | |||
428 | req->out.args[1].value = &outopen; | 425 | req->out.args[1].value = &outopen; |
429 | fuse_request_send(fc, req); | 426 | fuse_request_send(fc, req); |
430 | err = req->out.h.error; | 427 | err = req->out.h.error; |
431 | if (err) { | 428 | if (err) |
432 | if (err == -ENOSYS) | ||
433 | fc->no_create = 1; | ||
434 | goto out_free_ff; | 429 | goto out_free_ff; |
435 | } | ||
436 | 430 | ||
437 | err = -EIO; | 431 | err = -EIO; |
438 | if (!S_ISREG(outentry.attr.mode) || invalid_nodeid(outentry.nodeid)) | 432 | if (!S_ISREG(outentry.attr.mode) || invalid_nodeid(outentry.nodeid)) |
@@ -448,28 +442,74 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry, | |||
448 | flags &= ~(O_CREAT | O_EXCL | O_TRUNC); | 442 | flags &= ~(O_CREAT | O_EXCL | O_TRUNC); |
449 | fuse_sync_release(ff, flags); | 443 | fuse_sync_release(ff, flags); |
450 | fuse_queue_forget(fc, forget, outentry.nodeid, 1); | 444 | fuse_queue_forget(fc, forget, outentry.nodeid, 1); |
451 | return -ENOMEM; | 445 | err = -ENOMEM; |
446 | goto out_err; | ||
452 | } | 447 | } |
453 | kfree(forget); | 448 | kfree(forget); |
454 | d_instantiate(entry, inode); | 449 | d_instantiate(entry, inode); |
455 | fuse_change_entry_timeout(entry, &outentry); | 450 | fuse_change_entry_timeout(entry, &outentry); |
456 | fuse_invalidate_attr(dir); | 451 | fuse_invalidate_attr(dir); |
457 | file = lookup_instantiate_filp(nd, entry, generic_file_open); | 452 | err = finish_open(file, entry, generic_file_open, opened); |
458 | if (IS_ERR(file)) { | 453 | if (err) { |
459 | fuse_sync_release(ff, flags); | 454 | fuse_sync_release(ff, flags); |
460 | return PTR_ERR(file); | 455 | } else { |
456 | file->private_data = fuse_file_get(ff); | ||
457 | fuse_finish_open(inode, file); | ||
461 | } | 458 | } |
462 | file->private_data = fuse_file_get(ff); | 459 | return err; |
463 | fuse_finish_open(inode, file); | ||
464 | return 0; | ||
465 | 460 | ||
466 | out_free_ff: | 461 | out_free_ff: |
467 | fuse_file_free(ff); | 462 | fuse_file_free(ff); |
468 | out_put_request: | 463 | out_put_request: |
469 | fuse_put_request(fc, req); | 464 | fuse_put_request(fc, req); |
470 | out_put_forget_req: | 465 | out_put_forget_req: |
471 | kfree(forget); | 466 | kfree(forget); |
467 | out_err: | ||
468 | return err; | ||
469 | } | ||
470 | |||
471 | static int fuse_mknod(struct inode *, struct dentry *, umode_t, dev_t); | ||
472 | static int fuse_atomic_open(struct inode *dir, struct dentry *entry, | ||
473 | struct file *file, unsigned flags, | ||
474 | umode_t mode, int *opened) | ||
475 | { | ||
476 | int err; | ||
477 | struct fuse_conn *fc = get_fuse_conn(dir); | ||
478 | struct dentry *res = NULL; | ||
479 | |||
480 | if (d_unhashed(entry)) { | ||
481 | res = fuse_lookup(dir, entry, 0); | ||
482 | if (IS_ERR(res)) | ||
483 | return PTR_ERR(res); | ||
484 | |||
485 | if (res) | ||
486 | entry = res; | ||
487 | } | ||
488 | |||
489 | if (!(flags & O_CREAT) || entry->d_inode) | ||
490 | goto no_open; | ||
491 | |||
492 | /* Only creates */ | ||
493 | *opened |= FILE_CREATED; | ||
494 | |||
495 | if (fc->no_create) | ||
496 | goto mknod; | ||
497 | |||
498 | err = fuse_create_open(dir, entry, file, flags, mode, opened); | ||
499 | if (err == -ENOSYS) { | ||
500 | fc->no_create = 1; | ||
501 | goto mknod; | ||
502 | } | ||
503 | out_dput: | ||
504 | dput(res); | ||
472 | return err; | 505 | return err; |
506 | |||
507 | mknod: | ||
508 | err = fuse_mknod(dir, entry, mode, 0); | ||
509 | if (err) | ||
510 | goto out_dput; | ||
511 | no_open: | ||
512 | return finish_no_open(file, res); | ||
473 | } | 513 | } |
474 | 514 | ||
475 | /* | 515 | /* |
@@ -571,14 +611,8 @@ static int fuse_mknod(struct inode *dir, struct dentry *entry, umode_t mode, | |||
571 | } | 611 | } |
572 | 612 | ||
573 | static int fuse_create(struct inode *dir, struct dentry *entry, umode_t mode, | 613 | static int fuse_create(struct inode *dir, struct dentry *entry, umode_t mode, |
574 | struct nameidata *nd) | 614 | bool excl) |
575 | { | 615 | { |
576 | if (nd) { | ||
577 | int err = fuse_create_open(dir, entry, mode, nd); | ||
578 | if (err != -ENOSYS) | ||
579 | return err; | ||
580 | /* Fall back on mknod */ | ||
581 | } | ||
582 | return fuse_mknod(dir, entry, mode, 0); | 616 | return fuse_mknod(dir, entry, mode, 0); |
583 | } | 617 | } |
584 | 618 | ||
@@ -1646,6 +1680,7 @@ static const struct inode_operations fuse_dir_inode_operations = { | |||
1646 | .link = fuse_link, | 1680 | .link = fuse_link, |
1647 | .setattr = fuse_setattr, | 1681 | .setattr = fuse_setattr, |
1648 | .create = fuse_create, | 1682 | .create = fuse_create, |
1683 | .atomic_open = fuse_atomic_open, | ||
1649 | .mknod = fuse_mknod, | 1684 | .mknod = fuse_mknod, |
1650 | .permission = fuse_permission, | 1685 | .permission = fuse_permission, |
1651 | .getattr = fuse_getattr, | 1686 | .getattr = fuse_getattr, |
diff --git a/fs/gfs2/dentry.c b/fs/gfs2/dentry.c index 0da8da2c991d..4fddb3c22d25 100644 --- a/fs/gfs2/dentry.c +++ b/fs/gfs2/dentry.c | |||
@@ -25,7 +25,7 @@ | |||
25 | /** | 25 | /** |
26 | * gfs2_drevalidate - Check directory lookup consistency | 26 | * gfs2_drevalidate - Check directory lookup consistency |
27 | * @dentry: the mapping to check | 27 | * @dentry: the mapping to check |
28 | * @nd: | 28 | * @flags: lookup flags |
29 | * | 29 | * |
30 | * Check to make sure the lookup necessary to arrive at this inode from its | 30 | * Check to make sure the lookup necessary to arrive at this inode from its |
31 | * parent is still good. | 31 | * parent is still good. |
@@ -33,7 +33,7 @@ | |||
33 | * Returns: 1 if the dentry is ok, 0 if it isn't | 33 | * Returns: 1 if the dentry is ok, 0 if it isn't |
34 | */ | 34 | */ |
35 | 35 | ||
36 | static int gfs2_drevalidate(struct dentry *dentry, struct nameidata *nd) | 36 | static int gfs2_drevalidate(struct dentry *dentry, unsigned int flags) |
37 | { | 37 | { |
38 | struct dentry *parent; | 38 | struct dentry *parent; |
39 | struct gfs2_sbd *sdp; | 39 | struct gfs2_sbd *sdp; |
@@ -44,7 +44,7 @@ static int gfs2_drevalidate(struct dentry *dentry, struct nameidata *nd) | |||
44 | int error; | 44 | int error; |
45 | int had_lock = 0; | 45 | int had_lock = 0; |
46 | 46 | ||
47 | if (nd && nd->flags & LOOKUP_RCU) | 47 | if (flags & LOOKUP_RCU) |
48 | return -ECHILD; | 48 | return -ECHILD; |
49 | 49 | ||
50 | parent = dget_parent(dentry); | 50 | parent = dget_parent(dentry); |
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index c53c67e30bd4..4ce22e547308 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
@@ -772,11 +772,8 @@ fail: | |||
772 | */ | 772 | */ |
773 | 773 | ||
774 | static int gfs2_create(struct inode *dir, struct dentry *dentry, | 774 | static int gfs2_create(struct inode *dir, struct dentry *dentry, |
775 | umode_t mode, struct nameidata *nd) | 775 | umode_t mode, bool excl) |
776 | { | 776 | { |
777 | int excl = 0; | ||
778 | if (nd && (nd->flags & LOOKUP_EXCL)) | ||
779 | excl = 1; | ||
780 | return gfs2_create_inode(dir, dentry, S_IFREG | mode, 0, NULL, 0, excl); | 777 | return gfs2_create_inode(dir, dentry, S_IFREG | mode, 0, NULL, 0, excl); |
781 | } | 778 | } |
782 | 779 | ||
@@ -792,7 +789,7 @@ static int gfs2_create(struct inode *dir, struct dentry *dentry, | |||
792 | */ | 789 | */ |
793 | 790 | ||
794 | static struct dentry *gfs2_lookup(struct inode *dir, struct dentry *dentry, | 791 | static struct dentry *gfs2_lookup(struct inode *dir, struct dentry *dentry, |
795 | struct nameidata *nd) | 792 | unsigned int flags) |
796 | { | 793 | { |
797 | struct inode *inode = gfs2_lookupi(dir, &dentry->d_name, 0); | 794 | struct inode *inode = gfs2_lookupi(dir, &dentry->d_name, 0); |
798 | if (inode && !IS_ERR(inode)) { | 795 | if (inode && !IS_ERR(inode)) { |
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index 9b2389756acd..e5af9dc420ef 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c | |||
@@ -1299,7 +1299,7 @@ static struct dentry *gfs2_mount(struct file_system_type *fs_type, int flags, | |||
1299 | error = -EBUSY; | 1299 | error = -EBUSY; |
1300 | goto error_bdev; | 1300 | goto error_bdev; |
1301 | } | 1301 | } |
1302 | s = sget(fs_type, test_gfs2_super, set_gfs2_super, bdev); | 1302 | s = sget(fs_type, test_gfs2_super, set_gfs2_super, flags, bdev); |
1303 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | 1303 | mutex_unlock(&bdev->bd_fsfreeze_mutex); |
1304 | error = PTR_ERR(s); | 1304 | error = PTR_ERR(s); |
1305 | if (IS_ERR(s)) | 1305 | if (IS_ERR(s)) |
@@ -1329,7 +1329,6 @@ static struct dentry *gfs2_mount(struct file_system_type *fs_type, int flags, | |||
1329 | } else { | 1329 | } else { |
1330 | char b[BDEVNAME_SIZE]; | 1330 | char b[BDEVNAME_SIZE]; |
1331 | 1331 | ||
1332 | s->s_flags = flags; | ||
1333 | s->s_mode = mode; | 1332 | s->s_mode = mode; |
1334 | strlcpy(s->s_id, bdevname(bdev, b), sizeof(s->s_id)); | 1333 | strlcpy(s->s_id, bdevname(bdev, b), sizeof(s->s_id)); |
1335 | sb_set_blocksize(s, block_size(bdev)); | 1334 | sb_set_blocksize(s, block_size(bdev)); |
@@ -1373,7 +1372,7 @@ static struct dentry *gfs2_mount_meta(struct file_system_type *fs_type, | |||
1373 | dev_name, error); | 1372 | dev_name, error); |
1374 | return ERR_PTR(error); | 1373 | return ERR_PTR(error); |
1375 | } | 1374 | } |
1376 | s = sget(&gfs2_fs_type, test_gfs2_super, set_meta_super, | 1375 | s = sget(&gfs2_fs_type, test_gfs2_super, set_meta_super, flags, |
1377 | path.dentry->d_inode->i_sb->s_bdev); | 1376 | path.dentry->d_inode->i_sb->s_bdev); |
1378 | path_put(&path); | 1377 | path_put(&path); |
1379 | if (IS_ERR(s)) { | 1378 | if (IS_ERR(s)) { |
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 7d1ede7b66fc..a3bde91645c2 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c | |||
@@ -1113,7 +1113,7 @@ void gfs2_quota_change(struct gfs2_inode *ip, s64 change, | |||
1113 | } | 1113 | } |
1114 | } | 1114 | } |
1115 | 1115 | ||
1116 | int gfs2_quota_sync(struct super_block *sb, int type, int wait) | 1116 | int gfs2_quota_sync(struct super_block *sb, int type) |
1117 | { | 1117 | { |
1118 | struct gfs2_sbd *sdp = sb->s_fs_info; | 1118 | struct gfs2_sbd *sdp = sb->s_fs_info; |
1119 | struct gfs2_quota_data **qda; | 1119 | struct gfs2_quota_data **qda; |
@@ -1159,7 +1159,7 @@ int gfs2_quota_sync(struct super_block *sb, int type, int wait) | |||
1159 | 1159 | ||
1160 | static int gfs2_quota_sync_timeo(struct super_block *sb, int type) | 1160 | static int gfs2_quota_sync_timeo(struct super_block *sb, int type) |
1161 | { | 1161 | { |
1162 | return gfs2_quota_sync(sb, type, 0); | 1162 | return gfs2_quota_sync(sb, type); |
1163 | } | 1163 | } |
1164 | 1164 | ||
1165 | int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id) | 1165 | int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id) |
diff --git a/fs/gfs2/quota.h b/fs/gfs2/quota.h index 90bf1c302a98..f25d98b87904 100644 --- a/fs/gfs2/quota.h +++ b/fs/gfs2/quota.h | |||
@@ -26,7 +26,7 @@ extern int gfs2_quota_check(struct gfs2_inode *ip, u32 uid, u32 gid); | |||
26 | extern void gfs2_quota_change(struct gfs2_inode *ip, s64 change, | 26 | extern void gfs2_quota_change(struct gfs2_inode *ip, s64 change, |
27 | u32 uid, u32 gid); | 27 | u32 uid, u32 gid); |
28 | 28 | ||
29 | extern int gfs2_quota_sync(struct super_block *sb, int type, int wait); | 29 | extern int gfs2_quota_sync(struct super_block *sb, int type); |
30 | extern int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id); | 30 | extern int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id); |
31 | 31 | ||
32 | extern int gfs2_quota_init(struct gfs2_sbd *sdp); | 32 | extern int gfs2_quota_init(struct gfs2_sbd *sdp); |
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index b1502c4bc60d..fc3168f47a14 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c | |||
@@ -848,7 +848,7 @@ static int gfs2_make_fs_ro(struct gfs2_sbd *sdp) | |||
848 | int error; | 848 | int error; |
849 | 849 | ||
850 | flush_workqueue(gfs2_delete_workqueue); | 850 | flush_workqueue(gfs2_delete_workqueue); |
851 | gfs2_quota_sync(sdp->sd_vfs, 0, 1); | 851 | gfs2_quota_sync(sdp->sd_vfs, 0); |
852 | gfs2_statfs_sync(sdp->sd_vfs, 0); | 852 | gfs2_statfs_sync(sdp->sd_vfs, 0); |
853 | 853 | ||
854 | error = gfs2_glock_nq_init(sdp->sd_trans_gl, LM_ST_SHARED, GL_NOCACHE, | 854 | error = gfs2_glock_nq_init(sdp->sd_trans_gl, LM_ST_SHARED, GL_NOCACHE, |
@@ -962,6 +962,8 @@ restart: | |||
962 | static int gfs2_sync_fs(struct super_block *sb, int wait) | 962 | static int gfs2_sync_fs(struct super_block *sb, int wait) |
963 | { | 963 | { |
964 | struct gfs2_sbd *sdp = sb->s_fs_info; | 964 | struct gfs2_sbd *sdp = sb->s_fs_info; |
965 | |||
966 | gfs2_quota_sync(sb, -1); | ||
965 | if (wait && sdp) | 967 | if (wait && sdp) |
966 | gfs2_log_flush(sdp, NULL); | 968 | gfs2_log_flush(sdp, NULL); |
967 | return 0; | 969 | return 0; |
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index e4bee4bebbf6..8056b7b7238e 100644 --- a/fs/gfs2/sys.c +++ b/fs/gfs2/sys.c | |||
@@ -168,7 +168,7 @@ static ssize_t quota_sync_store(struct gfs2_sbd *sdp, const char *buf, | |||
168 | if (simple_strtol(buf, NULL, 0) != 1) | 168 | if (simple_strtol(buf, NULL, 0) != 1) |
169 | return -EINVAL; | 169 | return -EINVAL; |
170 | 170 | ||
171 | gfs2_quota_sync(sdp->sd_vfs, 0, 1); | 171 | gfs2_quota_sync(sdp->sd_vfs, 0); |
172 | return len; | 172 | return len; |
173 | } | 173 | } |
174 | 174 | ||
diff --git a/fs/hfs/dir.c b/fs/hfs/dir.c index 62fc14ea4b73..422dde2ec0a1 100644 --- a/fs/hfs/dir.c +++ b/fs/hfs/dir.c | |||
@@ -18,7 +18,7 @@ | |||
18 | * hfs_lookup() | 18 | * hfs_lookup() |
19 | */ | 19 | */ |
20 | static struct dentry *hfs_lookup(struct inode *dir, struct dentry *dentry, | 20 | static struct dentry *hfs_lookup(struct inode *dir, struct dentry *dentry, |
21 | struct nameidata *nd) | 21 | unsigned int flags) |
22 | { | 22 | { |
23 | hfs_cat_rec rec; | 23 | hfs_cat_rec rec; |
24 | struct hfs_find_data fd; | 24 | struct hfs_find_data fd; |
@@ -187,7 +187,7 @@ static int hfs_dir_release(struct inode *inode, struct file *file) | |||
187 | * the directory and the name (and its length) of the new file. | 187 | * the directory and the name (and its length) of the new file. |
188 | */ | 188 | */ |
189 | static int hfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 189 | static int hfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
190 | struct nameidata *nd) | 190 | bool excl) |
191 | { | 191 | { |
192 | struct inode *inode; | 192 | struct inode *inode; |
193 | int res; | 193 | int res; |
diff --git a/fs/hfs/extent.c b/fs/hfs/extent.c index 2c16316d2917..a67955a0c36f 100644 --- a/fs/hfs/extent.c +++ b/fs/hfs/extent.c | |||
@@ -432,7 +432,7 @@ out: | |||
432 | if (inode->i_ino < HFS_FIRSTUSER_CNID) | 432 | if (inode->i_ino < HFS_FIRSTUSER_CNID) |
433 | set_bit(HFS_FLG_ALT_MDB_DIRTY, &HFS_SB(sb)->flags); | 433 | set_bit(HFS_FLG_ALT_MDB_DIRTY, &HFS_SB(sb)->flags); |
434 | set_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags); | 434 | set_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags); |
435 | sb->s_dirt = 1; | 435 | hfs_mark_mdb_dirty(sb); |
436 | } | 436 | } |
437 | return res; | 437 | return res; |
438 | 438 | ||
diff --git a/fs/hfs/hfs_fs.h b/fs/hfs/hfs_fs.h index 1bf967c6bfdc..8275175acf6e 100644 --- a/fs/hfs/hfs_fs.h +++ b/fs/hfs/hfs_fs.h | |||
@@ -14,6 +14,7 @@ | |||
14 | #include <linux/mutex.h> | 14 | #include <linux/mutex.h> |
15 | #include <linux/buffer_head.h> | 15 | #include <linux/buffer_head.h> |
16 | #include <linux/fs.h> | 16 | #include <linux/fs.h> |
17 | #include <linux/workqueue.h> | ||
17 | 18 | ||
18 | #include <asm/byteorder.h> | 19 | #include <asm/byteorder.h> |
19 | #include <asm/uaccess.h> | 20 | #include <asm/uaccess.h> |
@@ -137,16 +138,15 @@ struct hfs_sb_info { | |||
137 | gid_t s_gid; /* The gid of all files */ | 138 | gid_t s_gid; /* The gid of all files */ |
138 | 139 | ||
139 | int session, part; | 140 | int session, part; |
140 | |||
141 | struct nls_table *nls_io, *nls_disk; | 141 | struct nls_table *nls_io, *nls_disk; |
142 | |||
143 | struct mutex bitmap_lock; | 142 | struct mutex bitmap_lock; |
144 | |||
145 | unsigned long flags; | 143 | unsigned long flags; |
146 | |||
147 | u16 blockoffset; | 144 | u16 blockoffset; |
148 | |||
149 | int fs_div; | 145 | int fs_div; |
146 | struct super_block *sb; | ||
147 | int work_queued; /* non-zero delayed work is queued */ | ||
148 | struct delayed_work mdb_work; /* MDB flush delayed work */ | ||
149 | spinlock_t work_lock; /* protects mdb_work and work_queued */ | ||
150 | }; | 150 | }; |
151 | 151 | ||
152 | #define HFS_FLG_BITMAP_DIRTY 0 | 152 | #define HFS_FLG_BITMAP_DIRTY 0 |
@@ -226,6 +226,9 @@ extern int hfs_compare_dentry(const struct dentry *parent, | |||
226 | extern void hfs_asc2mac(struct super_block *, struct hfs_name *, struct qstr *); | 226 | extern void hfs_asc2mac(struct super_block *, struct hfs_name *, struct qstr *); |
227 | extern int hfs_mac2asc(struct super_block *, char *, const struct hfs_name *); | 227 | extern int hfs_mac2asc(struct super_block *, char *, const struct hfs_name *); |
228 | 228 | ||
229 | /* super.c */ | ||
230 | extern void hfs_mark_mdb_dirty(struct super_block *sb); | ||
231 | |||
229 | extern struct timezone sys_tz; | 232 | extern struct timezone sys_tz; |
230 | 233 | ||
231 | /* | 234 | /* |
@@ -253,7 +256,7 @@ static inline const char *hfs_mdb_name(struct super_block *sb) | |||
253 | static inline void hfs_bitmap_dirty(struct super_block *sb) | 256 | static inline void hfs_bitmap_dirty(struct super_block *sb) |
254 | { | 257 | { |
255 | set_bit(HFS_FLG_BITMAP_DIRTY, &HFS_SB(sb)->flags); | 258 | set_bit(HFS_FLG_BITMAP_DIRTY, &HFS_SB(sb)->flags); |
256 | sb->s_dirt = 1; | 259 | hfs_mark_mdb_dirty(sb); |
257 | } | 260 | } |
258 | 261 | ||
259 | #define sb_bread512(sb, sec, data) ({ \ | 262 | #define sb_bread512(sb, sec, data) ({ \ |
diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index 761ec06354b4..ee1bc55677f1 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c | |||
@@ -220,7 +220,7 @@ struct inode *hfs_new_inode(struct inode *dir, struct qstr *name, umode_t mode) | |||
220 | insert_inode_hash(inode); | 220 | insert_inode_hash(inode); |
221 | mark_inode_dirty(inode); | 221 | mark_inode_dirty(inode); |
222 | set_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags); | 222 | set_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags); |
223 | sb->s_dirt = 1; | 223 | hfs_mark_mdb_dirty(sb); |
224 | 224 | ||
225 | return inode; | 225 | return inode; |
226 | } | 226 | } |
@@ -235,7 +235,7 @@ void hfs_delete_inode(struct inode *inode) | |||
235 | if (HFS_I(inode)->cat_key.ParID == cpu_to_be32(HFS_ROOT_CNID)) | 235 | if (HFS_I(inode)->cat_key.ParID == cpu_to_be32(HFS_ROOT_CNID)) |
236 | HFS_SB(sb)->root_dirs--; | 236 | HFS_SB(sb)->root_dirs--; |
237 | set_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags); | 237 | set_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags); |
238 | sb->s_dirt = 1; | 238 | hfs_mark_mdb_dirty(sb); |
239 | return; | 239 | return; |
240 | } | 240 | } |
241 | HFS_SB(sb)->file_count--; | 241 | HFS_SB(sb)->file_count--; |
@@ -248,7 +248,7 @@ void hfs_delete_inode(struct inode *inode) | |||
248 | } | 248 | } |
249 | } | 249 | } |
250 | set_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags); | 250 | set_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags); |
251 | sb->s_dirt = 1; | 251 | hfs_mark_mdb_dirty(sb); |
252 | } | 252 | } |
253 | 253 | ||
254 | void hfs_inode_read_fork(struct inode *inode, struct hfs_extent *ext, | 254 | void hfs_inode_read_fork(struct inode *inode, struct hfs_extent *ext, |
@@ -489,7 +489,7 @@ out: | |||
489 | } | 489 | } |
490 | 490 | ||
491 | static struct dentry *hfs_file_lookup(struct inode *dir, struct dentry *dentry, | 491 | static struct dentry *hfs_file_lookup(struct inode *dir, struct dentry *dentry, |
492 | struct nameidata *nd) | 492 | unsigned int flags) |
493 | { | 493 | { |
494 | struct inode *inode = NULL; | 494 | struct inode *inode = NULL; |
495 | hfs_cat_rec rec; | 495 | hfs_cat_rec rec; |
@@ -644,13 +644,7 @@ static int hfs_file_fsync(struct file *filp, loff_t start, loff_t end, | |||
644 | 644 | ||
645 | /* sync the superblock to buffers */ | 645 | /* sync the superblock to buffers */ |
646 | sb = inode->i_sb; | 646 | sb = inode->i_sb; |
647 | if (sb->s_dirt) { | 647 | flush_delayed_work_sync(&HFS_SB(sb)->mdb_work); |
648 | lock_super(sb); | ||
649 | sb->s_dirt = 0; | ||
650 | if (!(sb->s_flags & MS_RDONLY)) | ||
651 | hfs_mdb_commit(sb); | ||
652 | unlock_super(sb); | ||
653 | } | ||
654 | /* .. finally sync the buffers to disk */ | 648 | /* .. finally sync the buffers to disk */ |
655 | err = sync_blockdev(sb->s_bdev); | 649 | err = sync_blockdev(sb->s_bdev); |
656 | if (!ret) | 650 | if (!ret) |
diff --git a/fs/hfs/mdb.c b/fs/hfs/mdb.c index 1563d5ce5764..5fd51a5833ff 100644 --- a/fs/hfs/mdb.c +++ b/fs/hfs/mdb.c | |||
@@ -260,6 +260,10 @@ void hfs_mdb_commit(struct super_block *sb) | |||
260 | { | 260 | { |
261 | struct hfs_mdb *mdb = HFS_SB(sb)->mdb; | 261 | struct hfs_mdb *mdb = HFS_SB(sb)->mdb; |
262 | 262 | ||
263 | if (sb->s_flags & MS_RDONLY) | ||
264 | return; | ||
265 | |||
266 | lock_buffer(HFS_SB(sb)->mdb_bh); | ||
263 | if (test_and_clear_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags)) { | 267 | if (test_and_clear_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags)) { |
264 | /* These parameters may have been modified, so write them back */ | 268 | /* These parameters may have been modified, so write them back */ |
265 | mdb->drLsMod = hfs_mtime(); | 269 | mdb->drLsMod = hfs_mtime(); |
@@ -283,9 +287,13 @@ void hfs_mdb_commit(struct super_block *sb) | |||
283 | &mdb->drXTFlSize, NULL); | 287 | &mdb->drXTFlSize, NULL); |
284 | hfs_inode_write_fork(HFS_SB(sb)->cat_tree->inode, mdb->drCTExtRec, | 288 | hfs_inode_write_fork(HFS_SB(sb)->cat_tree->inode, mdb->drCTExtRec, |
285 | &mdb->drCTFlSize, NULL); | 289 | &mdb->drCTFlSize, NULL); |
290 | |||
291 | lock_buffer(HFS_SB(sb)->alt_mdb_bh); | ||
286 | memcpy(HFS_SB(sb)->alt_mdb, HFS_SB(sb)->mdb, HFS_SECTOR_SIZE); | 292 | memcpy(HFS_SB(sb)->alt_mdb, HFS_SB(sb)->mdb, HFS_SECTOR_SIZE); |
287 | HFS_SB(sb)->alt_mdb->drAtrb |= cpu_to_be16(HFS_SB_ATTRIB_UNMNT); | 293 | HFS_SB(sb)->alt_mdb->drAtrb |= cpu_to_be16(HFS_SB_ATTRIB_UNMNT); |
288 | HFS_SB(sb)->alt_mdb->drAtrb &= cpu_to_be16(~HFS_SB_ATTRIB_INCNSTNT); | 294 | HFS_SB(sb)->alt_mdb->drAtrb &= cpu_to_be16(~HFS_SB_ATTRIB_INCNSTNT); |
295 | unlock_buffer(HFS_SB(sb)->alt_mdb_bh); | ||
296 | |||
289 | mark_buffer_dirty(HFS_SB(sb)->alt_mdb_bh); | 297 | mark_buffer_dirty(HFS_SB(sb)->alt_mdb_bh); |
290 | sync_dirty_buffer(HFS_SB(sb)->alt_mdb_bh); | 298 | sync_dirty_buffer(HFS_SB(sb)->alt_mdb_bh); |
291 | } | 299 | } |
@@ -308,7 +316,11 @@ void hfs_mdb_commit(struct super_block *sb) | |||
308 | break; | 316 | break; |
309 | } | 317 | } |
310 | len = min((int)sb->s_blocksize - off, size); | 318 | len = min((int)sb->s_blocksize - off, size); |
319 | |||
320 | lock_buffer(bh); | ||
311 | memcpy(bh->b_data + off, ptr, len); | 321 | memcpy(bh->b_data + off, ptr, len); |
322 | unlock_buffer(bh); | ||
323 | |||
312 | mark_buffer_dirty(bh); | 324 | mark_buffer_dirty(bh); |
313 | brelse(bh); | 325 | brelse(bh); |
314 | block++; | 326 | block++; |
@@ -317,6 +329,7 @@ void hfs_mdb_commit(struct super_block *sb) | |||
317 | size -= len; | 329 | size -= len; |
318 | } | 330 | } |
319 | } | 331 | } |
332 | unlock_buffer(HFS_SB(sb)->mdb_bh); | ||
320 | } | 333 | } |
321 | 334 | ||
322 | void hfs_mdb_close(struct super_block *sb) | 335 | void hfs_mdb_close(struct super_block *sb) |
diff --git a/fs/hfs/super.c b/fs/hfs/super.c index 7b4c537d6e13..4eb873e0c07b 100644 --- a/fs/hfs/super.c +++ b/fs/hfs/super.c | |||
@@ -29,43 +29,9 @@ static struct kmem_cache *hfs_inode_cachep; | |||
29 | 29 | ||
30 | MODULE_LICENSE("GPL"); | 30 | MODULE_LICENSE("GPL"); |
31 | 31 | ||
32 | /* | ||
33 | * hfs_write_super() | ||
34 | * | ||
35 | * Description: | ||
36 | * This function is called by the VFS only. When the filesystem | ||
37 | * is mounted r/w it updates the MDB on disk. | ||
38 | * Input Variable(s): | ||
39 | * struct super_block *sb: Pointer to the hfs superblock | ||
40 | * Output Variable(s): | ||
41 | * NONE | ||
42 | * Returns: | ||
43 | * void | ||
44 | * Preconditions: | ||
45 | * 'sb' points to a "valid" (struct super_block). | ||
46 | * Postconditions: | ||
47 | * The MDB is marked 'unsuccessfully unmounted' by clearing bit 8 of drAtrb | ||
48 | * (hfs_put_super() must set this flag!). Some MDB fields are updated | ||
49 | * and the MDB buffer is written to disk by calling hfs_mdb_commit(). | ||
50 | */ | ||
51 | static void hfs_write_super(struct super_block *sb) | ||
52 | { | ||
53 | lock_super(sb); | ||
54 | sb->s_dirt = 0; | ||
55 | |||
56 | /* sync everything to the buffers */ | ||
57 | if (!(sb->s_flags & MS_RDONLY)) | ||
58 | hfs_mdb_commit(sb); | ||
59 | unlock_super(sb); | ||
60 | } | ||
61 | |||
62 | static int hfs_sync_fs(struct super_block *sb, int wait) | 32 | static int hfs_sync_fs(struct super_block *sb, int wait) |
63 | { | 33 | { |
64 | lock_super(sb); | ||
65 | hfs_mdb_commit(sb); | 34 | hfs_mdb_commit(sb); |
66 | sb->s_dirt = 0; | ||
67 | unlock_super(sb); | ||
68 | |||
69 | return 0; | 35 | return 0; |
70 | } | 36 | } |
71 | 37 | ||
@@ -78,13 +44,44 @@ static int hfs_sync_fs(struct super_block *sb, int wait) | |||
78 | */ | 44 | */ |
79 | static void hfs_put_super(struct super_block *sb) | 45 | static void hfs_put_super(struct super_block *sb) |
80 | { | 46 | { |
81 | if (sb->s_dirt) | 47 | cancel_delayed_work_sync(&HFS_SB(sb)->mdb_work); |
82 | hfs_write_super(sb); | ||
83 | hfs_mdb_close(sb); | 48 | hfs_mdb_close(sb); |
84 | /* release the MDB's resources */ | 49 | /* release the MDB's resources */ |
85 | hfs_mdb_put(sb); | 50 | hfs_mdb_put(sb); |
86 | } | 51 | } |
87 | 52 | ||
53 | static void flush_mdb(struct work_struct *work) | ||
54 | { | ||
55 | struct hfs_sb_info *sbi; | ||
56 | struct super_block *sb; | ||
57 | |||
58 | sbi = container_of(work, struct hfs_sb_info, mdb_work.work); | ||
59 | sb = sbi->sb; | ||
60 | |||
61 | spin_lock(&sbi->work_lock); | ||
62 | sbi->work_queued = 0; | ||
63 | spin_unlock(&sbi->work_lock); | ||
64 | |||
65 | hfs_mdb_commit(sb); | ||
66 | } | ||
67 | |||
68 | void hfs_mark_mdb_dirty(struct super_block *sb) | ||
69 | { | ||
70 | struct hfs_sb_info *sbi = HFS_SB(sb); | ||
71 | unsigned long delay; | ||
72 | |||
73 | if (sb->s_flags & MS_RDONLY) | ||
74 | return; | ||
75 | |||
76 | spin_lock(&sbi->work_lock); | ||
77 | if (!sbi->work_queued) { | ||
78 | delay = msecs_to_jiffies(dirty_writeback_interval * 10); | ||
79 | queue_delayed_work(system_long_wq, &sbi->mdb_work, delay); | ||
80 | sbi->work_queued = 1; | ||
81 | } | ||
82 | spin_unlock(&sbi->work_lock); | ||
83 | } | ||
84 | |||
88 | /* | 85 | /* |
89 | * hfs_statfs() | 86 | * hfs_statfs() |
90 | * | 87 | * |
@@ -184,7 +181,6 @@ static const struct super_operations hfs_super_operations = { | |||
184 | .write_inode = hfs_write_inode, | 181 | .write_inode = hfs_write_inode, |
185 | .evict_inode = hfs_evict_inode, | 182 | .evict_inode = hfs_evict_inode, |
186 | .put_super = hfs_put_super, | 183 | .put_super = hfs_put_super, |
187 | .write_super = hfs_write_super, | ||
188 | .sync_fs = hfs_sync_fs, | 184 | .sync_fs = hfs_sync_fs, |
189 | .statfs = hfs_statfs, | 185 | .statfs = hfs_statfs, |
190 | .remount_fs = hfs_remount, | 186 | .remount_fs = hfs_remount, |
@@ -387,7 +383,10 @@ static int hfs_fill_super(struct super_block *sb, void *data, int silent) | |||
387 | if (!sbi) | 383 | if (!sbi) |
388 | return -ENOMEM; | 384 | return -ENOMEM; |
389 | 385 | ||
386 | sbi->sb = sb; | ||
390 | sb->s_fs_info = sbi; | 387 | sb->s_fs_info = sbi; |
388 | spin_lock_init(&sbi->work_lock); | ||
389 | INIT_DELAYED_WORK(&sbi->mdb_work, flush_mdb); | ||
391 | 390 | ||
392 | res = -EINVAL; | 391 | res = -EINVAL; |
393 | if (!parse_options((char *)data, sbi)) { | 392 | if (!parse_options((char *)data, sbi)) { |
diff --git a/fs/hfs/sysdep.c b/fs/hfs/sysdep.c index 19cf291eb91f..91b91fd3a901 100644 --- a/fs/hfs/sysdep.c +++ b/fs/hfs/sysdep.c | |||
@@ -13,12 +13,12 @@ | |||
13 | 13 | ||
14 | /* dentry case-handling: just lowercase everything */ | 14 | /* dentry case-handling: just lowercase everything */ |
15 | 15 | ||
16 | static int hfs_revalidate_dentry(struct dentry *dentry, struct nameidata *nd) | 16 | static int hfs_revalidate_dentry(struct dentry *dentry, unsigned int flags) |
17 | { | 17 | { |
18 | struct inode *inode; | 18 | struct inode *inode; |
19 | int diff; | 19 | int diff; |
20 | 20 | ||
21 | if (nd->flags & LOOKUP_RCU) | 21 | if (flags & LOOKUP_RCU) |
22 | return -ECHILD; | 22 | return -ECHILD; |
23 | 23 | ||
24 | inode = dentry->d_inode; | 24 | inode = dentry->d_inode; |
diff --git a/fs/hfsplus/bitmap.c b/fs/hfsplus/bitmap.c index 1cad80c789cb..4cfbe2edd296 100644 --- a/fs/hfsplus/bitmap.c +++ b/fs/hfsplus/bitmap.c | |||
@@ -153,7 +153,7 @@ done: | |||
153 | kunmap(page); | 153 | kunmap(page); |
154 | *max = offset + (curr - pptr) * 32 + i - start; | 154 | *max = offset + (curr - pptr) * 32 + i - start; |
155 | sbi->free_blocks -= *max; | 155 | sbi->free_blocks -= *max; |
156 | sb->s_dirt = 1; | 156 | hfsplus_mark_mdb_dirty(sb); |
157 | dprint(DBG_BITMAP, "-> %u,%u\n", start, *max); | 157 | dprint(DBG_BITMAP, "-> %u,%u\n", start, *max); |
158 | out: | 158 | out: |
159 | mutex_unlock(&sbi->alloc_mutex); | 159 | mutex_unlock(&sbi->alloc_mutex); |
@@ -228,7 +228,7 @@ out: | |||
228 | set_page_dirty(page); | 228 | set_page_dirty(page); |
229 | kunmap(page); | 229 | kunmap(page); |
230 | sbi->free_blocks += len; | 230 | sbi->free_blocks += len; |
231 | sb->s_dirt = 1; | 231 | hfsplus_mark_mdb_dirty(sb); |
232 | mutex_unlock(&sbi->alloc_mutex); | 232 | mutex_unlock(&sbi->alloc_mutex); |
233 | 233 | ||
234 | return 0; | 234 | return 0; |
diff --git a/fs/hfsplus/dir.c b/fs/hfsplus/dir.c index 26b53fb09f68..6b9f921ef2fa 100644 --- a/fs/hfsplus/dir.c +++ b/fs/hfsplus/dir.c | |||
@@ -25,7 +25,7 @@ static inline void hfsplus_instantiate(struct dentry *dentry, | |||
25 | 25 | ||
26 | /* Find the entry inside dir named dentry->d_name */ | 26 | /* Find the entry inside dir named dentry->d_name */ |
27 | static struct dentry *hfsplus_lookup(struct inode *dir, struct dentry *dentry, | 27 | static struct dentry *hfsplus_lookup(struct inode *dir, struct dentry *dentry, |
28 | struct nameidata *nd) | 28 | unsigned int flags) |
29 | { | 29 | { |
30 | struct inode *inode = NULL; | 30 | struct inode *inode = NULL; |
31 | struct hfs_find_data fd; | 31 | struct hfs_find_data fd; |
@@ -316,7 +316,7 @@ static int hfsplus_link(struct dentry *src_dentry, struct inode *dst_dir, | |||
316 | inode->i_ctime = CURRENT_TIME_SEC; | 316 | inode->i_ctime = CURRENT_TIME_SEC; |
317 | mark_inode_dirty(inode); | 317 | mark_inode_dirty(inode); |
318 | sbi->file_count++; | 318 | sbi->file_count++; |
319 | dst_dir->i_sb->s_dirt = 1; | 319 | hfsplus_mark_mdb_dirty(dst_dir->i_sb); |
320 | out: | 320 | out: |
321 | mutex_unlock(&sbi->vh_mutex); | 321 | mutex_unlock(&sbi->vh_mutex); |
322 | return res; | 322 | return res; |
@@ -465,7 +465,7 @@ out: | |||
465 | } | 465 | } |
466 | 466 | ||
467 | static int hfsplus_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 467 | static int hfsplus_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
468 | struct nameidata *nd) | 468 | bool excl) |
469 | { | 469 | { |
470 | return hfsplus_mknod(dir, dentry, mode, 0); | 470 | return hfsplus_mknod(dir, dentry, mode, 0); |
471 | } | 471 | } |
diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h index 4e75ac646fea..558dbb463a4e 100644 --- a/fs/hfsplus/hfsplus_fs.h +++ b/fs/hfsplus/hfsplus_fs.h | |||
@@ -153,8 +153,11 @@ struct hfsplus_sb_info { | |||
153 | gid_t gid; | 153 | gid_t gid; |
154 | 154 | ||
155 | int part, session; | 155 | int part, session; |
156 | |||
157 | unsigned long flags; | 156 | unsigned long flags; |
157 | |||
158 | int work_queued; /* non-zero delayed work is queued */ | ||
159 | struct delayed_work sync_work; /* FS sync delayed work */ | ||
160 | spinlock_t work_lock; /* protects sync_work and work_queued */ | ||
158 | }; | 161 | }; |
159 | 162 | ||
160 | #define HFSPLUS_SB_WRITEBACKUP 0 | 163 | #define HFSPLUS_SB_WRITEBACKUP 0 |
@@ -428,7 +431,7 @@ int hfsplus_show_options(struct seq_file *, struct dentry *); | |||
428 | 431 | ||
429 | /* super.c */ | 432 | /* super.c */ |
430 | struct inode *hfsplus_iget(struct super_block *, unsigned long); | 433 | struct inode *hfsplus_iget(struct super_block *, unsigned long); |
431 | int hfsplus_sync_fs(struct super_block *sb, int wait); | 434 | void hfsplus_mark_mdb_dirty(struct super_block *sb); |
432 | 435 | ||
433 | /* tables.c */ | 436 | /* tables.c */ |
434 | extern u16 hfsplus_case_fold_table[]; | 437 | extern u16 hfsplus_case_fold_table[]; |
diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c index 82b69ee4dacc..3d8b4a675ba0 100644 --- a/fs/hfsplus/inode.c +++ b/fs/hfsplus/inode.c | |||
@@ -168,7 +168,7 @@ const struct dentry_operations hfsplus_dentry_operations = { | |||
168 | }; | 168 | }; |
169 | 169 | ||
170 | static struct dentry *hfsplus_file_lookup(struct inode *dir, | 170 | static struct dentry *hfsplus_file_lookup(struct inode *dir, |
171 | struct dentry *dentry, struct nameidata *nd) | 171 | struct dentry *dentry, unsigned int flags) |
172 | { | 172 | { |
173 | struct hfs_find_data fd; | 173 | struct hfs_find_data fd; |
174 | struct super_block *sb = dir->i_sb; | 174 | struct super_block *sb = dir->i_sb; |
@@ -431,7 +431,7 @@ struct inode *hfsplus_new_inode(struct super_block *sb, umode_t mode) | |||
431 | sbi->file_count++; | 431 | sbi->file_count++; |
432 | insert_inode_hash(inode); | 432 | insert_inode_hash(inode); |
433 | mark_inode_dirty(inode); | 433 | mark_inode_dirty(inode); |
434 | sb->s_dirt = 1; | 434 | hfsplus_mark_mdb_dirty(sb); |
435 | 435 | ||
436 | return inode; | 436 | return inode; |
437 | } | 437 | } |
@@ -442,7 +442,7 @@ void hfsplus_delete_inode(struct inode *inode) | |||
442 | 442 | ||
443 | if (S_ISDIR(inode->i_mode)) { | 443 | if (S_ISDIR(inode->i_mode)) { |
444 | HFSPLUS_SB(sb)->folder_count--; | 444 | HFSPLUS_SB(sb)->folder_count--; |
445 | sb->s_dirt = 1; | 445 | hfsplus_mark_mdb_dirty(sb); |
446 | return; | 446 | return; |
447 | } | 447 | } |
448 | HFSPLUS_SB(sb)->file_count--; | 448 | HFSPLUS_SB(sb)->file_count--; |
@@ -455,7 +455,7 @@ void hfsplus_delete_inode(struct inode *inode) | |||
455 | inode->i_size = 0; | 455 | inode->i_size = 0; |
456 | hfsplus_file_truncate(inode); | 456 | hfsplus_file_truncate(inode); |
457 | } | 457 | } |
458 | sb->s_dirt = 1; | 458 | hfsplus_mark_mdb_dirty(sb); |
459 | } | 459 | } |
460 | 460 | ||
461 | void hfsplus_inode_read_fork(struct inode *inode, struct hfsplus_fork_raw *fork) | 461 | void hfsplus_inode_read_fork(struct inode *inode, struct hfsplus_fork_raw *fork) |
diff --git a/fs/hfsplus/ioctl.c b/fs/hfsplus/ioctl.c index c640ba57074b..09addc8615fa 100644 --- a/fs/hfsplus/ioctl.c +++ b/fs/hfsplus/ioctl.c | |||
@@ -31,6 +31,7 @@ static int hfsplus_ioctl_bless(struct file *file, int __user *user_flags) | |||
31 | struct hfsplus_sb_info *sbi = HFSPLUS_SB(inode->i_sb); | 31 | struct hfsplus_sb_info *sbi = HFSPLUS_SB(inode->i_sb); |
32 | struct hfsplus_vh *vh = sbi->s_vhdr; | 32 | struct hfsplus_vh *vh = sbi->s_vhdr; |
33 | struct hfsplus_vh *bvh = sbi->s_backup_vhdr; | 33 | struct hfsplus_vh *bvh = sbi->s_backup_vhdr; |
34 | u32 cnid = (unsigned long)dentry->d_fsdata; | ||
34 | 35 | ||
35 | if (!capable(CAP_SYS_ADMIN)) | 36 | if (!capable(CAP_SYS_ADMIN)) |
36 | return -EPERM; | 37 | return -EPERM; |
@@ -41,8 +42,12 @@ static int hfsplus_ioctl_bless(struct file *file, int __user *user_flags) | |||
41 | vh->finder_info[0] = bvh->finder_info[0] = | 42 | vh->finder_info[0] = bvh->finder_info[0] = |
42 | cpu_to_be32(parent_ino(dentry)); | 43 | cpu_to_be32(parent_ino(dentry)); |
43 | 44 | ||
44 | /* Bootloader */ | 45 | /* |
45 | vh->finder_info[1] = bvh->finder_info[1] = cpu_to_be32(inode->i_ino); | 46 | * Bootloader. Just using the inode here breaks in the case of |
47 | * hard links - the firmware wants the ID of the hard link file, | ||
48 | * but the inode points at the indirect inode | ||
49 | */ | ||
50 | vh->finder_info[1] = bvh->finder_info[1] = cpu_to_be32(cnid); | ||
46 | 51 | ||
47 | /* Per spec, the OS X system folder - same as finder_info[0] here */ | 52 | /* Per spec, the OS X system folder - same as finder_info[0] here */ |
48 | vh->finder_info[5] = bvh->finder_info[5] = | 53 | vh->finder_info[5] = bvh->finder_info[5] = |
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c index a9bca4b8768b..473332098013 100644 --- a/fs/hfsplus/super.c +++ b/fs/hfsplus/super.c | |||
@@ -124,7 +124,7 @@ static int hfsplus_system_write_inode(struct inode *inode) | |||
124 | 124 | ||
125 | if (fork->total_size != cpu_to_be64(inode->i_size)) { | 125 | if (fork->total_size != cpu_to_be64(inode->i_size)) { |
126 | set_bit(HFSPLUS_SB_WRITEBACKUP, &sbi->flags); | 126 | set_bit(HFSPLUS_SB_WRITEBACKUP, &sbi->flags); |
127 | inode->i_sb->s_dirt = 1; | 127 | hfsplus_mark_mdb_dirty(inode->i_sb); |
128 | } | 128 | } |
129 | hfsplus_inode_write_fork(inode, fork); | 129 | hfsplus_inode_write_fork(inode, fork); |
130 | if (tree) | 130 | if (tree) |
@@ -161,7 +161,7 @@ static void hfsplus_evict_inode(struct inode *inode) | |||
161 | } | 161 | } |
162 | } | 162 | } |
163 | 163 | ||
164 | int hfsplus_sync_fs(struct super_block *sb, int wait) | 164 | static int hfsplus_sync_fs(struct super_block *sb, int wait) |
165 | { | 165 | { |
166 | struct hfsplus_sb_info *sbi = HFSPLUS_SB(sb); | 166 | struct hfsplus_sb_info *sbi = HFSPLUS_SB(sb); |
167 | struct hfsplus_vh *vhdr = sbi->s_vhdr; | 167 | struct hfsplus_vh *vhdr = sbi->s_vhdr; |
@@ -171,9 +171,7 @@ int hfsplus_sync_fs(struct super_block *sb, int wait) | |||
171 | if (!wait) | 171 | if (!wait) |
172 | return 0; | 172 | return 0; |
173 | 173 | ||
174 | dprint(DBG_SUPER, "hfsplus_write_super\n"); | 174 | dprint(DBG_SUPER, "hfsplus_sync_fs\n"); |
175 | |||
176 | sb->s_dirt = 0; | ||
177 | 175 | ||
178 | /* | 176 | /* |
179 | * Explicitly write out the special metadata inodes. | 177 | * Explicitly write out the special metadata inodes. |
@@ -226,12 +224,34 @@ out: | |||
226 | return error; | 224 | return error; |
227 | } | 225 | } |
228 | 226 | ||
229 | static void hfsplus_write_super(struct super_block *sb) | 227 | static void delayed_sync_fs(struct work_struct *work) |
230 | { | 228 | { |
231 | if (!(sb->s_flags & MS_RDONLY)) | 229 | struct hfsplus_sb_info *sbi; |
232 | hfsplus_sync_fs(sb, 1); | 230 | |
233 | else | 231 | sbi = container_of(work, struct hfsplus_sb_info, sync_work.work); |
234 | sb->s_dirt = 0; | 232 | |
233 | spin_lock(&sbi->work_lock); | ||
234 | sbi->work_queued = 0; | ||
235 | spin_unlock(&sbi->work_lock); | ||
236 | |||
237 | hfsplus_sync_fs(sbi->alloc_file->i_sb, 1); | ||
238 | } | ||
239 | |||
240 | void hfsplus_mark_mdb_dirty(struct super_block *sb) | ||
241 | { | ||
242 | struct hfsplus_sb_info *sbi = HFSPLUS_SB(sb); | ||
243 | unsigned long delay; | ||
244 | |||
245 | if (sb->s_flags & MS_RDONLY) | ||
246 | return; | ||
247 | |||
248 | spin_lock(&sbi->work_lock); | ||
249 | if (!sbi->work_queued) { | ||
250 | delay = msecs_to_jiffies(dirty_writeback_interval * 10); | ||
251 | queue_delayed_work(system_long_wq, &sbi->sync_work, delay); | ||
252 | sbi->work_queued = 1; | ||
253 | } | ||
254 | spin_unlock(&sbi->work_lock); | ||
235 | } | 255 | } |
236 | 256 | ||
237 | static void hfsplus_put_super(struct super_block *sb) | 257 | static void hfsplus_put_super(struct super_block *sb) |
@@ -240,8 +260,7 @@ static void hfsplus_put_super(struct super_block *sb) | |||
240 | 260 | ||
241 | dprint(DBG_SUPER, "hfsplus_put_super\n"); | 261 | dprint(DBG_SUPER, "hfsplus_put_super\n"); |
242 | 262 | ||
243 | if (!sb->s_fs_info) | 263 | cancel_delayed_work_sync(&sbi->sync_work); |
244 | return; | ||
245 | 264 | ||
246 | if (!(sb->s_flags & MS_RDONLY) && sbi->s_vhdr) { | 265 | if (!(sb->s_flags & MS_RDONLY) && sbi->s_vhdr) { |
247 | struct hfsplus_vh *vhdr = sbi->s_vhdr; | 266 | struct hfsplus_vh *vhdr = sbi->s_vhdr; |
@@ -328,7 +347,6 @@ static const struct super_operations hfsplus_sops = { | |||
328 | .write_inode = hfsplus_write_inode, | 347 | .write_inode = hfsplus_write_inode, |
329 | .evict_inode = hfsplus_evict_inode, | 348 | .evict_inode = hfsplus_evict_inode, |
330 | .put_super = hfsplus_put_super, | 349 | .put_super = hfsplus_put_super, |
331 | .write_super = hfsplus_write_super, | ||
332 | .sync_fs = hfsplus_sync_fs, | 350 | .sync_fs = hfsplus_sync_fs, |
333 | .statfs = hfsplus_statfs, | 351 | .statfs = hfsplus_statfs, |
334 | .remount_fs = hfsplus_remount, | 352 | .remount_fs = hfsplus_remount, |
@@ -355,6 +373,8 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent) | |||
355 | sb->s_fs_info = sbi; | 373 | sb->s_fs_info = sbi; |
356 | mutex_init(&sbi->alloc_mutex); | 374 | mutex_init(&sbi->alloc_mutex); |
357 | mutex_init(&sbi->vh_mutex); | 375 | mutex_init(&sbi->vh_mutex); |
376 | spin_lock_init(&sbi->work_lock); | ||
377 | INIT_DELAYED_WORK(&sbi->sync_work, delayed_sync_fs); | ||
358 | hfsplus_fill_defaults(sbi); | 378 | hfsplus_fill_defaults(sbi); |
359 | 379 | ||
360 | err = -EINVAL; | 380 | err = -EINVAL; |
diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c index 7daf4b852d1c..90effcccca9a 100644 --- a/fs/hfsplus/wrapper.c +++ b/fs/hfsplus/wrapper.c | |||
@@ -56,7 +56,7 @@ int hfsplus_submit_bio(struct super_block *sb, sector_t sector, | |||
56 | DECLARE_COMPLETION_ONSTACK(wait); | 56 | DECLARE_COMPLETION_ONSTACK(wait); |
57 | struct bio *bio; | 57 | struct bio *bio; |
58 | int ret = 0; | 58 | int ret = 0; |
59 | unsigned int io_size; | 59 | u64 io_size; |
60 | loff_t start; | 60 | loff_t start; |
61 | int offset; | 61 | int offset; |
62 | 62 | ||
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index 2afa5bbccf9b..124146543aa7 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c | |||
@@ -553,7 +553,7 @@ static int read_name(struct inode *ino, char *name) | |||
553 | } | 553 | } |
554 | 554 | ||
555 | int hostfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 555 | int hostfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
556 | struct nameidata *nd) | 556 | bool excl) |
557 | { | 557 | { |
558 | struct inode *inode; | 558 | struct inode *inode; |
559 | char *name; | 559 | char *name; |
@@ -595,7 +595,7 @@ int hostfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | |||
595 | } | 595 | } |
596 | 596 | ||
597 | struct dentry *hostfs_lookup(struct inode *ino, struct dentry *dentry, | 597 | struct dentry *hostfs_lookup(struct inode *ino, struct dentry *dentry, |
598 | struct nameidata *nd) | 598 | unsigned int flags) |
599 | { | 599 | { |
600 | struct inode *inode; | 600 | struct inode *inode; |
601 | char *name; | 601 | char *name; |
diff --git a/fs/hpfs/dir.c b/fs/hpfs/dir.c index b8472f803f4e..78e12b2e0ea2 100644 --- a/fs/hpfs/dir.c +++ b/fs/hpfs/dir.c | |||
@@ -189,7 +189,7 @@ out: | |||
189 | * to tell read_inode to read fnode or not. | 189 | * to tell read_inode to read fnode or not. |
190 | */ | 190 | */ |
191 | 191 | ||
192 | struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 192 | struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
193 | { | 193 | { |
194 | const unsigned char *name = dentry->d_name.name; | 194 | const unsigned char *name = dentry->d_name.name; |
195 | unsigned len = dentry->d_name.len; | 195 | unsigned len = dentry->d_name.len; |
diff --git a/fs/hpfs/hpfs_fn.h b/fs/hpfs/hpfs_fn.h index c07ef1f1ced6..ac1ead194db5 100644 --- a/fs/hpfs/hpfs_fn.h +++ b/fs/hpfs/hpfs_fn.h | |||
@@ -220,7 +220,7 @@ extern const struct dentry_operations hpfs_dentry_operations; | |||
220 | 220 | ||
221 | /* dir.c */ | 221 | /* dir.c */ |
222 | 222 | ||
223 | struct dentry *hpfs_lookup(struct inode *, struct dentry *, struct nameidata *); | 223 | struct dentry *hpfs_lookup(struct inode *, struct dentry *, unsigned int); |
224 | extern const struct file_operations hpfs_dir_ops; | 224 | extern const struct file_operations hpfs_dir_ops; |
225 | 225 | ||
226 | /* dnode.c */ | 226 | /* dnode.c */ |
diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c index 9083ef8af58c..bc9082482f68 100644 --- a/fs/hpfs/namei.c +++ b/fs/hpfs/namei.c | |||
@@ -115,7 +115,7 @@ bail: | |||
115 | return err; | 115 | return err; |
116 | } | 116 | } |
117 | 117 | ||
118 | static int hpfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, struct nameidata *nd) | 118 | static int hpfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, bool excl) |
119 | { | 119 | { |
120 | const unsigned char *name = dentry->d_name.name; | 120 | const unsigned char *name = dentry->d_name.name; |
121 | unsigned len = dentry->d_name.len; | 121 | unsigned len = dentry->d_name.len; |
diff --git a/fs/hppfs/hppfs.c b/fs/hppfs/hppfs.c index d4f93b52cec5..c1dffe47fde2 100644 --- a/fs/hppfs/hppfs.c +++ b/fs/hppfs/hppfs.c | |||
@@ -138,7 +138,7 @@ static int file_removed(struct dentry *dentry, const char *file) | |||
138 | } | 138 | } |
139 | 139 | ||
140 | static struct dentry *hppfs_lookup(struct inode *ino, struct dentry *dentry, | 140 | static struct dentry *hppfs_lookup(struct inode *ino, struct dentry *dentry, |
141 | struct nameidata *nd) | 141 | unsigned int flags) |
142 | { | 142 | { |
143 | struct dentry *proc_dentry, *parent; | 143 | struct dentry *proc_dentry, *parent; |
144 | struct qstr *name = &dentry->d_name; | 144 | struct qstr *name = &dentry->d_name; |
@@ -420,8 +420,7 @@ static int hppfs_open(struct inode *inode, struct file *file) | |||
420 | { | 420 | { |
421 | const struct cred *cred = file->f_cred; | 421 | const struct cred *cred = file->f_cred; |
422 | struct hppfs_private *data; | 422 | struct hppfs_private *data; |
423 | struct vfsmount *proc_mnt; | 423 | struct path path; |
424 | struct dentry *proc_dentry; | ||
425 | char *host_file; | 424 | char *host_file; |
426 | int err, fd, type, filter; | 425 | int err, fd, type, filter; |
427 | 426 | ||
@@ -434,12 +433,11 @@ static int hppfs_open(struct inode *inode, struct file *file) | |||
434 | if (host_file == NULL) | 433 | if (host_file == NULL) |
435 | goto out_free2; | 434 | goto out_free2; |
436 | 435 | ||
437 | proc_dentry = HPPFS_I(inode)->proc_dentry; | 436 | path.mnt = inode->i_sb->s_fs_info; |
438 | proc_mnt = inode->i_sb->s_fs_info; | 437 | path.dentry = HPPFS_I(inode)->proc_dentry; |
439 | 438 | ||
440 | /* XXX This isn't closed anywhere */ | 439 | /* XXX This isn't closed anywhere */ |
441 | data->proc_file = dentry_open(dget(proc_dentry), mntget(proc_mnt), | 440 | data->proc_file = dentry_open(&path, file_mode(file->f_mode), cred); |
442 | file_mode(file->f_mode), cred); | ||
443 | err = PTR_ERR(data->proc_file); | 441 | err = PTR_ERR(data->proc_file); |
444 | if (IS_ERR(data->proc_file)) | 442 | if (IS_ERR(data->proc_file)) |
445 | goto out_free1; | 443 | goto out_free1; |
@@ -484,8 +482,7 @@ static int hppfs_dir_open(struct inode *inode, struct file *file) | |||
484 | { | 482 | { |
485 | const struct cred *cred = file->f_cred; | 483 | const struct cred *cred = file->f_cred; |
486 | struct hppfs_private *data; | 484 | struct hppfs_private *data; |
487 | struct vfsmount *proc_mnt; | 485 | struct path path; |
488 | struct dentry *proc_dentry; | ||
489 | int err; | 486 | int err; |
490 | 487 | ||
491 | err = -ENOMEM; | 488 | err = -ENOMEM; |
@@ -493,10 +490,9 @@ static int hppfs_dir_open(struct inode *inode, struct file *file) | |||
493 | if (data == NULL) | 490 | if (data == NULL) |
494 | goto out; | 491 | goto out; |
495 | 492 | ||
496 | proc_dentry = HPPFS_I(inode)->proc_dentry; | 493 | path.mnt = inode->i_sb->s_fs_info; |
497 | proc_mnt = inode->i_sb->s_fs_info; | 494 | path.dentry = HPPFS_I(inode)->proc_dentry; |
498 | data->proc_file = dentry_open(dget(proc_dentry), mntget(proc_mnt), | 495 | data->proc_file = dentry_open(&path, file_mode(file->f_mode), cred); |
499 | file_mode(file->f_mode), cred); | ||
500 | err = PTR_ERR(data->proc_file); | 496 | err = PTR_ERR(data->proc_file); |
501 | if (IS_ERR(data->proc_file)) | 497 | if (IS_ERR(data->proc_file)) |
502 | goto out_free; | 498 | goto out_free; |
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index cc9281b6c628..e13e9bdb0bf5 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c | |||
@@ -565,7 +565,7 @@ static int hugetlbfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mod | |||
565 | return retval; | 565 | return retval; |
566 | } | 566 | } |
567 | 567 | ||
568 | static int hugetlbfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, struct nameidata *nd) | 568 | static int hugetlbfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, bool excl) |
569 | { | 569 | { |
570 | return hugetlbfs_mknod(dir, dentry, mode | S_IFREG, 0); | 570 | return hugetlbfs_mknod(dir, dentry, mode | S_IFREG, 0); |
571 | } | 571 | } |
diff --git a/fs/inode.c b/fs/inode.c index c99163b1b310..775cbabd4fa5 100644 --- a/fs/inode.c +++ b/fs/inode.c | |||
@@ -182,7 +182,7 @@ int inode_init_always(struct super_block *sb, struct inode *inode) | |||
182 | } | 182 | } |
183 | inode->i_private = NULL; | 183 | inode->i_private = NULL; |
184 | inode->i_mapping = mapping; | 184 | inode->i_mapping = mapping; |
185 | INIT_LIST_HEAD(&inode->i_dentry); /* buggered by rcu freeing */ | 185 | INIT_HLIST_HEAD(&inode->i_dentry); /* buggered by rcu freeing */ |
186 | #ifdef CONFIG_FS_POSIX_ACL | 186 | #ifdef CONFIG_FS_POSIX_ACL |
187 | inode->i_acl = inode->i_default_acl = ACL_NOT_CACHED; | 187 | inode->i_acl = inode->i_default_acl = ACL_NOT_CACHED; |
188 | #endif | 188 | #endif |
diff --git a/fs/internal.h b/fs/internal.h index 18bc216ea09d..a6fd56c68b11 100644 --- a/fs/internal.h +++ b/fs/internal.h | |||
@@ -42,6 +42,11 @@ static inline int __sync_blockdev(struct block_device *bdev, int wait) | |||
42 | extern void __init chrdev_init(void); | 42 | extern void __init chrdev_init(void); |
43 | 43 | ||
44 | /* | 44 | /* |
45 | * namei.c | ||
46 | */ | ||
47 | extern int __inode_permission(struct inode *, int); | ||
48 | |||
49 | /* | ||
45 | * namespace.c | 50 | * namespace.c |
46 | */ | 51 | */ |
47 | extern int copy_mount_options(const void __user *, unsigned long *); | 52 | extern int copy_mount_options(const void __user *, unsigned long *); |
@@ -50,8 +55,6 @@ extern int copy_mount_string(const void __user *, char **); | |||
50 | extern struct vfsmount *lookup_mnt(struct path *); | 55 | extern struct vfsmount *lookup_mnt(struct path *); |
51 | extern int finish_automount(struct vfsmount *, struct path *); | 56 | extern int finish_automount(struct vfsmount *, struct path *); |
52 | 57 | ||
53 | extern void mnt_make_longterm(struct vfsmount *); | ||
54 | extern void mnt_make_shortterm(struct vfsmount *); | ||
55 | extern int sb_prepare_remount_readonly(struct super_block *); | 58 | extern int sb_prepare_remount_readonly(struct super_block *); |
56 | 59 | ||
57 | extern void __init mnt_init(void); | 60 | extern void __init mnt_init(void); |
@@ -84,9 +87,6 @@ extern struct super_block *user_get_super(dev_t); | |||
84 | /* | 87 | /* |
85 | * open.c | 88 | * open.c |
86 | */ | 89 | */ |
87 | struct nameidata; | ||
88 | extern struct file *nameidata_to_filp(struct nameidata *); | ||
89 | extern void release_open_intent(struct nameidata *); | ||
90 | struct open_flags { | 90 | struct open_flags { |
91 | int open_flag; | 91 | int open_flag; |
92 | umode_t mode; | 92 | umode_t mode; |
diff --git a/fs/isofs/export.c b/fs/isofs/export.c index aa4356d09eee..1d3804492aa7 100644 --- a/fs/isofs/export.c +++ b/fs/isofs/export.c | |||
@@ -134,6 +134,7 @@ isofs_export_encode_fh(struct inode *inode, | |||
134 | len = 3; | 134 | len = 3; |
135 | fh32[0] = ei->i_iget5_block; | 135 | fh32[0] = ei->i_iget5_block; |
136 | fh16[2] = (__u16)ei->i_iget5_offset; /* fh16 [sic] */ | 136 | fh16[2] = (__u16)ei->i_iget5_offset; /* fh16 [sic] */ |
137 | fh16[3] = 0; /* avoid leaking uninitialized data */ | ||
137 | fh32[2] = inode->i_generation; | 138 | fh32[2] = inode->i_generation; |
138 | if (parent) { | 139 | if (parent) { |
139 | struct iso_inode_info *eparent; | 140 | struct iso_inode_info *eparent; |
diff --git a/fs/isofs/isofs.h b/fs/isofs/isofs.h index 0e73f63d9274..3620ad1ea9bc 100644 --- a/fs/isofs/isofs.h +++ b/fs/isofs/isofs.h | |||
@@ -114,7 +114,7 @@ extern int isofs_name_translate(struct iso_directory_record *, char *, struct in | |||
114 | int get_joliet_filename(struct iso_directory_record *, unsigned char *, struct inode *); | 114 | int get_joliet_filename(struct iso_directory_record *, unsigned char *, struct inode *); |
115 | int get_acorn_filename(struct iso_directory_record *, char *, struct inode *); | 115 | int get_acorn_filename(struct iso_directory_record *, char *, struct inode *); |
116 | 116 | ||
117 | extern struct dentry *isofs_lookup(struct inode *, struct dentry *, struct nameidata *); | 117 | extern struct dentry *isofs_lookup(struct inode *, struct dentry *, unsigned int flags); |
118 | extern struct buffer_head *isofs_bread(struct inode *, sector_t); | 118 | extern struct buffer_head *isofs_bread(struct inode *, sector_t); |
119 | extern int isofs_get_blocks(struct inode *, sector_t, struct buffer_head **, unsigned long); | 119 | extern int isofs_get_blocks(struct inode *, sector_t, struct buffer_head **, unsigned long); |
120 | 120 | ||
diff --git a/fs/isofs/namei.c b/fs/isofs/namei.c index 1e2946f2a69e..c167028844ed 100644 --- a/fs/isofs/namei.c +++ b/fs/isofs/namei.c | |||
@@ -163,7 +163,7 @@ isofs_find_entry(struct inode *dir, struct dentry *dentry, | |||
163 | return 0; | 163 | return 0; |
164 | } | 164 | } |
165 | 165 | ||
166 | struct dentry *isofs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 166 | struct dentry *isofs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
167 | { | 167 | { |
168 | int found; | 168 | int found; |
169 | unsigned long uninitialized_var(block); | 169 | unsigned long uninitialized_var(block); |
diff --git a/fs/jbd/recovery.c b/fs/jbd/recovery.c index 008bf062fd26..a748fe21465a 100644 --- a/fs/jbd/recovery.c +++ b/fs/jbd/recovery.c | |||
@@ -265,8 +265,11 @@ int journal_recover(journal_t *journal) | |||
265 | if (!err) | 265 | if (!err) |
266 | err = err2; | 266 | err = err2; |
267 | /* Flush disk caches to get replayed data on the permanent storage */ | 267 | /* Flush disk caches to get replayed data on the permanent storage */ |
268 | if (journal->j_flags & JFS_BARRIER) | 268 | if (journal->j_flags & JFS_BARRIER) { |
269 | blkdev_issue_flush(journal->j_fs_dev, GFP_KERNEL, NULL); | 269 | err2 = blkdev_issue_flush(journal->j_fs_dev, GFP_KERNEL, NULL); |
270 | if (!err) | ||
271 | err = err2; | ||
272 | } | ||
270 | 273 | ||
271 | return err; | 274 | return err; |
272 | } | 275 | } |
diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c index b56018896d5e..ad7774d32095 100644 --- a/fs/jffs2/dir.c +++ b/fs/jffs2/dir.c | |||
@@ -25,9 +25,9 @@ | |||
25 | static int jffs2_readdir (struct file *, void *, filldir_t); | 25 | static int jffs2_readdir (struct file *, void *, filldir_t); |
26 | 26 | ||
27 | static int jffs2_create (struct inode *,struct dentry *,umode_t, | 27 | static int jffs2_create (struct inode *,struct dentry *,umode_t, |
28 | struct nameidata *); | 28 | bool); |
29 | static struct dentry *jffs2_lookup (struct inode *,struct dentry *, | 29 | static struct dentry *jffs2_lookup (struct inode *,struct dentry *, |
30 | struct nameidata *); | 30 | unsigned int); |
31 | static int jffs2_link (struct dentry *,struct inode *,struct dentry *); | 31 | static int jffs2_link (struct dentry *,struct inode *,struct dentry *); |
32 | static int jffs2_unlink (struct inode *,struct dentry *); | 32 | static int jffs2_unlink (struct inode *,struct dentry *); |
33 | static int jffs2_symlink (struct inode *,struct dentry *,const char *); | 33 | static int jffs2_symlink (struct inode *,struct dentry *,const char *); |
@@ -74,7 +74,7 @@ const struct inode_operations jffs2_dir_inode_operations = | |||
74 | nice and simple | 74 | nice and simple |
75 | */ | 75 | */ |
76 | static struct dentry *jffs2_lookup(struct inode *dir_i, struct dentry *target, | 76 | static struct dentry *jffs2_lookup(struct inode *dir_i, struct dentry *target, |
77 | struct nameidata *nd) | 77 | unsigned int flags) |
78 | { | 78 | { |
79 | struct jffs2_inode_info *dir_f; | 79 | struct jffs2_inode_info *dir_f; |
80 | struct jffs2_full_dirent *fd = NULL, *fd_list; | 80 | struct jffs2_full_dirent *fd = NULL, *fd_list; |
@@ -175,7 +175,7 @@ static int jffs2_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
175 | 175 | ||
176 | 176 | ||
177 | static int jffs2_create(struct inode *dir_i, struct dentry *dentry, | 177 | static int jffs2_create(struct inode *dir_i, struct dentry *dentry, |
178 | umode_t mode, struct nameidata *nd) | 178 | umode_t mode, bool excl) |
179 | { | 179 | { |
180 | struct jffs2_raw_inode *ri; | 180 | struct jffs2_raw_inode *ri; |
181 | struct jffs2_inode_info *f, *dir_f; | 181 | struct jffs2_inode_info *f, *dir_f; |
@@ -226,8 +226,8 @@ static int jffs2_create(struct inode *dir_i, struct dentry *dentry, | |||
226 | __func__, inode->i_ino, inode->i_mode, inode->i_nlink, | 226 | __func__, inode->i_ino, inode->i_mode, inode->i_nlink, |
227 | f->inocache->pino_nlink, inode->i_mapping->nrpages); | 227 | f->inocache->pino_nlink, inode->i_mapping->nrpages); |
228 | 228 | ||
229 | d_instantiate(dentry, inode); | ||
230 | unlock_new_inode(inode); | 229 | unlock_new_inode(inode); |
230 | d_instantiate(dentry, inode); | ||
231 | return 0; | 231 | return 0; |
232 | 232 | ||
233 | fail: | 233 | fail: |
@@ -446,8 +446,8 @@ static int jffs2_symlink (struct inode *dir_i, struct dentry *dentry, const char | |||
446 | mutex_unlock(&dir_f->sem); | 446 | mutex_unlock(&dir_f->sem); |
447 | jffs2_complete_reservation(c); | 447 | jffs2_complete_reservation(c); |
448 | 448 | ||
449 | d_instantiate(dentry, inode); | ||
450 | unlock_new_inode(inode); | 449 | unlock_new_inode(inode); |
450 | d_instantiate(dentry, inode); | ||
451 | return 0; | 451 | return 0; |
452 | 452 | ||
453 | fail: | 453 | fail: |
@@ -591,8 +591,8 @@ static int jffs2_mkdir (struct inode *dir_i, struct dentry *dentry, umode_t mode | |||
591 | mutex_unlock(&dir_f->sem); | 591 | mutex_unlock(&dir_f->sem); |
592 | jffs2_complete_reservation(c); | 592 | jffs2_complete_reservation(c); |
593 | 593 | ||
594 | d_instantiate(dentry, inode); | ||
595 | unlock_new_inode(inode); | 594 | unlock_new_inode(inode); |
595 | d_instantiate(dentry, inode); | ||
596 | return 0; | 596 | return 0; |
597 | 597 | ||
598 | fail: | 598 | fail: |
@@ -766,8 +766,8 @@ static int jffs2_mknod (struct inode *dir_i, struct dentry *dentry, umode_t mode | |||
766 | mutex_unlock(&dir_f->sem); | 766 | mutex_unlock(&dir_f->sem); |
767 | jffs2_complete_reservation(c); | 767 | jffs2_complete_reservation(c); |
768 | 768 | ||
769 | d_instantiate(dentry, inode); | ||
770 | unlock_new_inode(inode); | 769 | unlock_new_inode(inode); |
770 | d_instantiate(dentry, inode); | ||
771 | return 0; | 771 | return 0; |
772 | 772 | ||
773 | fail: | 773 | fail: |
diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c index 07c91ca6017d..3b91a7ad6086 100644 --- a/fs/jfs/namei.c +++ b/fs/jfs/namei.c | |||
@@ -73,7 +73,7 @@ static inline void free_ea_wmap(struct inode *inode) | |||
73 | * | 73 | * |
74 | */ | 74 | */ |
75 | static int jfs_create(struct inode *dip, struct dentry *dentry, umode_t mode, | 75 | static int jfs_create(struct inode *dip, struct dentry *dentry, umode_t mode, |
76 | struct nameidata *nd) | 76 | bool excl) |
77 | { | 77 | { |
78 | int rc = 0; | 78 | int rc = 0; |
79 | tid_t tid; /* transaction id */ | 79 | tid_t tid; /* transaction id */ |
@@ -176,8 +176,8 @@ static int jfs_create(struct inode *dip, struct dentry *dentry, umode_t mode, | |||
176 | unlock_new_inode(ip); | 176 | unlock_new_inode(ip); |
177 | iput(ip); | 177 | iput(ip); |
178 | } else { | 178 | } else { |
179 | d_instantiate(dentry, ip); | ||
180 | unlock_new_inode(ip); | 179 | unlock_new_inode(ip); |
180 | d_instantiate(dentry, ip); | ||
181 | } | 181 | } |
182 | 182 | ||
183 | out2: | 183 | out2: |
@@ -309,8 +309,8 @@ static int jfs_mkdir(struct inode *dip, struct dentry *dentry, umode_t mode) | |||
309 | unlock_new_inode(ip); | 309 | unlock_new_inode(ip); |
310 | iput(ip); | 310 | iput(ip); |
311 | } else { | 311 | } else { |
312 | d_instantiate(dentry, ip); | ||
313 | unlock_new_inode(ip); | 312 | unlock_new_inode(ip); |
313 | d_instantiate(dentry, ip); | ||
314 | } | 314 | } |
315 | 315 | ||
316 | out2: | 316 | out2: |
@@ -1043,8 +1043,8 @@ static int jfs_symlink(struct inode *dip, struct dentry *dentry, | |||
1043 | unlock_new_inode(ip); | 1043 | unlock_new_inode(ip); |
1044 | iput(ip); | 1044 | iput(ip); |
1045 | } else { | 1045 | } else { |
1046 | d_instantiate(dentry, ip); | ||
1047 | unlock_new_inode(ip); | 1046 | unlock_new_inode(ip); |
1047 | d_instantiate(dentry, ip); | ||
1048 | } | 1048 | } |
1049 | 1049 | ||
1050 | out2: | 1050 | out2: |
@@ -1424,8 +1424,8 @@ static int jfs_mknod(struct inode *dir, struct dentry *dentry, | |||
1424 | unlock_new_inode(ip); | 1424 | unlock_new_inode(ip); |
1425 | iput(ip); | 1425 | iput(ip); |
1426 | } else { | 1426 | } else { |
1427 | d_instantiate(dentry, ip); | ||
1428 | unlock_new_inode(ip); | 1427 | unlock_new_inode(ip); |
1428 | d_instantiate(dentry, ip); | ||
1429 | } | 1429 | } |
1430 | 1430 | ||
1431 | out1: | 1431 | out1: |
@@ -1436,7 +1436,7 @@ static int jfs_mknod(struct inode *dir, struct dentry *dentry, | |||
1436 | return rc; | 1436 | return rc; |
1437 | } | 1437 | } |
1438 | 1438 | ||
1439 | static struct dentry *jfs_lookup(struct inode *dip, struct dentry *dentry, struct nameidata *nd) | 1439 | static struct dentry *jfs_lookup(struct inode *dip, struct dentry *dentry, unsigned int flags) |
1440 | { | 1440 | { |
1441 | struct btstack btstack; | 1441 | struct btstack btstack; |
1442 | ino_t inum; | 1442 | ino_t inum; |
@@ -1570,7 +1570,7 @@ out: | |||
1570 | return result; | 1570 | return result; |
1571 | } | 1571 | } |
1572 | 1572 | ||
1573 | static int jfs_ci_revalidate(struct dentry *dentry, struct nameidata *nd) | 1573 | static int jfs_ci_revalidate(struct dentry *dentry, unsigned int flags) |
1574 | { | 1574 | { |
1575 | /* | 1575 | /* |
1576 | * This is not negative dentry. Always valid. | 1576 | * This is not negative dentry. Always valid. |
@@ -1589,7 +1589,7 @@ static int jfs_ci_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
1589 | * This may be nfsd (or something), anyway, we can't see the | 1589 | * This may be nfsd (or something), anyway, we can't see the |
1590 | * intent of this. So, since this can be for creation, drop it. | 1590 | * intent of this. So, since this can be for creation, drop it. |
1591 | */ | 1591 | */ |
1592 | if (!nd) | 1592 | if (!flags) |
1593 | return 0; | 1593 | return 0; |
1594 | 1594 | ||
1595 | /* | 1595 | /* |
@@ -1597,7 +1597,7 @@ static int jfs_ci_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
1597 | * case sensitive name which is specified by user if this is | 1597 | * case sensitive name which is specified by user if this is |
1598 | * for creation. | 1598 | * for creation. |
1599 | */ | 1599 | */ |
1600 | if (nd->flags & (LOOKUP_CREATE | LOOKUP_RENAME_TARGET)) | 1600 | if (flags & (LOOKUP_CREATE | LOOKUP_RENAME_TARGET)) |
1601 | return 0; | 1601 | return 0; |
1602 | return 1; | 1602 | return 1; |
1603 | } | 1603 | } |
diff --git a/fs/jfs/super.c b/fs/jfs/super.c index 4a82950f412f..c55c7452d285 100644 --- a/fs/jfs/super.c +++ b/fs/jfs/super.c | |||
@@ -601,6 +601,11 @@ static int jfs_sync_fs(struct super_block *sb, int wait) | |||
601 | 601 | ||
602 | /* log == NULL indicates read-only mount */ | 602 | /* log == NULL indicates read-only mount */ |
603 | if (log) { | 603 | if (log) { |
604 | /* | ||
605 | * Write quota structures to quota file, sync_blockdev() will | ||
606 | * write them to disk later | ||
607 | */ | ||
608 | dquot_writeback_dquots(sb, -1); | ||
604 | jfs_flush_journal(log, wait); | 609 | jfs_flush_journal(log, wait); |
605 | jfs_syncpt(log, 0); | 610 | jfs_syncpt(log, 0); |
606 | } | 611 | } |
diff --git a/fs/libfs.c b/fs/libfs.c index f86ec27a4230..a74cb1725ac6 100644 --- a/fs/libfs.c +++ b/fs/libfs.c | |||
@@ -53,7 +53,7 @@ static int simple_delete_dentry(const struct dentry *dentry) | |||
53 | * Lookup the data. This is trivial - if the dentry didn't already | 53 | * Lookup the data. This is trivial - if the dentry didn't already |
54 | * exist, we know it is negative. Set d_op to delete negative dentries. | 54 | * exist, we know it is negative. Set d_op to delete negative dentries. |
55 | */ | 55 | */ |
56 | struct dentry *simple_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 56 | struct dentry *simple_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
57 | { | 57 | { |
58 | static const struct dentry_operations simple_dentry_operations = { | 58 | static const struct dentry_operations simple_dentry_operations = { |
59 | .d_delete = simple_delete_dentry, | 59 | .d_delete = simple_delete_dentry, |
@@ -222,15 +222,15 @@ struct dentry *mount_pseudo(struct file_system_type *fs_type, char *name, | |||
222 | const struct super_operations *ops, | 222 | const struct super_operations *ops, |
223 | const struct dentry_operations *dops, unsigned long magic) | 223 | const struct dentry_operations *dops, unsigned long magic) |
224 | { | 224 | { |
225 | struct super_block *s = sget(fs_type, NULL, set_anon_super, NULL); | 225 | struct super_block *s; |
226 | struct dentry *dentry; | 226 | struct dentry *dentry; |
227 | struct inode *root; | 227 | struct inode *root; |
228 | struct qstr d_name = QSTR_INIT(name, strlen(name)); | 228 | struct qstr d_name = QSTR_INIT(name, strlen(name)); |
229 | 229 | ||
230 | s = sget(fs_type, NULL, set_anon_super, MS_NOUSER, NULL); | ||
230 | if (IS_ERR(s)) | 231 | if (IS_ERR(s)) |
231 | return ERR_CAST(s); | 232 | return ERR_CAST(s); |
232 | 233 | ||
233 | s->s_flags = MS_NOUSER; | ||
234 | s->s_maxbytes = MAX_LFS_FILESIZE; | 234 | s->s_maxbytes = MAX_LFS_FILESIZE; |
235 | s->s_blocksize = PAGE_SIZE; | 235 | s->s_blocksize = PAGE_SIZE; |
236 | s->s_blocksize_bits = PAGE_SHIFT; | 236 | s->s_blocksize_bits = PAGE_SHIFT; |
diff --git a/fs/locks.c b/fs/locks.c index 814c51d0de47..82c353304f9e 100644 --- a/fs/locks.c +++ b/fs/locks.c | |||
@@ -308,7 +308,7 @@ static int flock_make_lock(struct file *filp, struct file_lock **lock, | |||
308 | return 0; | 308 | return 0; |
309 | } | 309 | } |
310 | 310 | ||
311 | static int assign_type(struct file_lock *fl, int type) | 311 | static int assign_type(struct file_lock *fl, long type) |
312 | { | 312 | { |
313 | switch (type) { | 313 | switch (type) { |
314 | case F_RDLCK: | 314 | case F_RDLCK: |
@@ -445,7 +445,7 @@ static const struct lock_manager_operations lease_manager_ops = { | |||
445 | /* | 445 | /* |
446 | * Initialize a lease, use the default lock manager operations | 446 | * Initialize a lease, use the default lock manager operations |
447 | */ | 447 | */ |
448 | static int lease_init(struct file *filp, int type, struct file_lock *fl) | 448 | static int lease_init(struct file *filp, long type, struct file_lock *fl) |
449 | { | 449 | { |
450 | if (assign_type(fl, type) != 0) | 450 | if (assign_type(fl, type) != 0) |
451 | return -EINVAL; | 451 | return -EINVAL; |
@@ -463,7 +463,7 @@ static int lease_init(struct file *filp, int type, struct file_lock *fl) | |||
463 | } | 463 | } |
464 | 464 | ||
465 | /* Allocate a file_lock initialised to this type of lease */ | 465 | /* Allocate a file_lock initialised to this type of lease */ |
466 | static struct file_lock *lease_alloc(struct file *filp, int type) | 466 | static struct file_lock *lease_alloc(struct file *filp, long type) |
467 | { | 467 | { |
468 | struct file_lock *fl = locks_alloc_lock(); | 468 | struct file_lock *fl = locks_alloc_lock(); |
469 | int error = -ENOMEM; | 469 | int error = -ENOMEM; |
@@ -1465,7 +1465,7 @@ int generic_setlease(struct file *filp, long arg, struct file_lock **flp) | |||
1465 | case F_WRLCK: | 1465 | case F_WRLCK: |
1466 | return generic_add_lease(filp, arg, flp); | 1466 | return generic_add_lease(filp, arg, flp); |
1467 | default: | 1467 | default: |
1468 | BUG(); | 1468 | return -EINVAL; |
1469 | } | 1469 | } |
1470 | } | 1470 | } |
1471 | EXPORT_SYMBOL(generic_setlease); | 1471 | EXPORT_SYMBOL(generic_setlease); |
diff --git a/fs/logfs/dir.c b/fs/logfs/dir.c index bea5d1b9954b..26e4a941532f 100644 --- a/fs/logfs/dir.c +++ b/fs/logfs/dir.c | |||
@@ -349,7 +349,7 @@ static void logfs_set_name(struct logfs_disk_dentry *dd, struct qstr *name) | |||
349 | } | 349 | } |
350 | 350 | ||
351 | static struct dentry *logfs_lookup(struct inode *dir, struct dentry *dentry, | 351 | static struct dentry *logfs_lookup(struct inode *dir, struct dentry *dentry, |
352 | struct nameidata *nd) | 352 | unsigned int flags) |
353 | { | 353 | { |
354 | struct page *page; | 354 | struct page *page; |
355 | struct logfs_disk_dentry *dd; | 355 | struct logfs_disk_dentry *dd; |
@@ -502,7 +502,7 @@ static int logfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) | |||
502 | } | 502 | } |
503 | 503 | ||
504 | static int logfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 504 | static int logfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
505 | struct nameidata *nd) | 505 | bool excl) |
506 | { | 506 | { |
507 | struct inode *inode; | 507 | struct inode *inode; |
508 | 508 | ||
diff --git a/fs/logfs/super.c b/fs/logfs/super.c index 97bca623d893..345c24b8a6f8 100644 --- a/fs/logfs/super.c +++ b/fs/logfs/super.c | |||
@@ -519,7 +519,7 @@ static struct dentry *logfs_get_sb_device(struct logfs_super *super, | |||
519 | log_super("LogFS: Start mount %x\n", mount_count++); | 519 | log_super("LogFS: Start mount %x\n", mount_count++); |
520 | 520 | ||
521 | err = -EINVAL; | 521 | err = -EINVAL; |
522 | sb = sget(type, logfs_sb_test, logfs_sb_set, super); | 522 | sb = sget(type, logfs_sb_test, logfs_sb_set, flags | MS_NOATIME, super); |
523 | if (IS_ERR(sb)) { | 523 | if (IS_ERR(sb)) { |
524 | super->s_devops->put_device(super); | 524 | super->s_devops->put_device(super); |
525 | kfree(super); | 525 | kfree(super); |
@@ -542,7 +542,6 @@ static struct dentry *logfs_get_sb_device(struct logfs_super *super, | |||
542 | sb->s_maxbytes = (1ull << 43) - 1; | 542 | sb->s_maxbytes = (1ull << 43) - 1; |
543 | sb->s_max_links = LOGFS_LINK_MAX; | 543 | sb->s_max_links = LOGFS_LINK_MAX; |
544 | sb->s_op = &logfs_super_operations; | 544 | sb->s_op = &logfs_super_operations; |
545 | sb->s_flags = flags | MS_NOATIME; | ||
546 | 545 | ||
547 | err = logfs_read_sb(sb, sb->s_flags & MS_RDONLY); | 546 | err = logfs_read_sb(sb, sb->s_flags & MS_RDONLY); |
548 | if (err) | 547 | if (err) |
diff --git a/fs/minix/namei.c b/fs/minix/namei.c index 2d0ee1786305..0db73d9dd668 100644 --- a/fs/minix/namei.c +++ b/fs/minix/namei.c | |||
@@ -18,7 +18,7 @@ static int add_nondir(struct dentry *dentry, struct inode *inode) | |||
18 | return err; | 18 | return err; |
19 | } | 19 | } |
20 | 20 | ||
21 | static struct dentry *minix_lookup(struct inode * dir, struct dentry *dentry, struct nameidata *nd) | 21 | static struct dentry *minix_lookup(struct inode * dir, struct dentry *dentry, unsigned int flags) |
22 | { | 22 | { |
23 | struct inode * inode = NULL; | 23 | struct inode * inode = NULL; |
24 | ino_t ino; | 24 | ino_t ino; |
@@ -55,7 +55,7 @@ static int minix_mknod(struct inode * dir, struct dentry *dentry, umode_t mode, | |||
55 | } | 55 | } |
56 | 56 | ||
57 | static int minix_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 57 | static int minix_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
58 | struct nameidata *nd) | 58 | bool excl) |
59 | { | 59 | { |
60 | return minix_mknod(dir, dentry, mode, 0); | 60 | return minix_mknod(dir, dentry, mode, 0); |
61 | } | 61 | } |
diff --git a/fs/mount.h b/fs/mount.h index 4ef36d93e5a2..4f291f9de641 100644 --- a/fs/mount.h +++ b/fs/mount.h | |||
@@ -22,7 +22,6 @@ struct mount { | |||
22 | struct vfsmount mnt; | 22 | struct vfsmount mnt; |
23 | #ifdef CONFIG_SMP | 23 | #ifdef CONFIG_SMP |
24 | struct mnt_pcp __percpu *mnt_pcp; | 24 | struct mnt_pcp __percpu *mnt_pcp; |
25 | atomic_t mnt_longterm; /* how many of the refs are longterm */ | ||
26 | #else | 25 | #else |
27 | int mnt_count; | 26 | int mnt_count; |
28 | int mnt_writers; | 27 | int mnt_writers; |
@@ -49,6 +48,8 @@ struct mount { | |||
49 | int mnt_ghosts; | 48 | int mnt_ghosts; |
50 | }; | 49 | }; |
51 | 50 | ||
51 | #define MNT_NS_INTERNAL ERR_PTR(-EINVAL) /* distinct from any mnt_namespace */ | ||
52 | |||
52 | static inline struct mount *real_mount(struct vfsmount *mnt) | 53 | static inline struct mount *real_mount(struct vfsmount *mnt) |
53 | { | 54 | { |
54 | return container_of(mnt, struct mount, mnt); | 55 | return container_of(mnt, struct mount, mnt); |
@@ -59,6 +60,12 @@ static inline int mnt_has_parent(struct mount *mnt) | |||
59 | return mnt != mnt->mnt_parent; | 60 | return mnt != mnt->mnt_parent; |
60 | } | 61 | } |
61 | 62 | ||
63 | static inline int is_mounted(struct vfsmount *mnt) | ||
64 | { | ||
65 | /* neither detached nor internal? */ | ||
66 | return !IS_ERR_OR_NULL(real_mount(mnt)); | ||
67 | } | ||
68 | |||
62 | extern struct mount *__lookup_mnt(struct vfsmount *, struct dentry *, int); | 69 | extern struct mount *__lookup_mnt(struct vfsmount *, struct dentry *, int); |
63 | 70 | ||
64 | static inline void get_mnt_ns(struct mnt_namespace *ns) | 71 | static inline void get_mnt_ns(struct mnt_namespace *ns) |
@@ -67,10 +74,12 @@ static inline void get_mnt_ns(struct mnt_namespace *ns) | |||
67 | } | 74 | } |
68 | 75 | ||
69 | struct proc_mounts { | 76 | struct proc_mounts { |
70 | struct seq_file m; /* must be the first element */ | 77 | struct seq_file m; |
71 | struct mnt_namespace *ns; | 78 | struct mnt_namespace *ns; |
72 | struct path root; | 79 | struct path root; |
73 | int (*show)(struct seq_file *, struct vfsmount *); | 80 | int (*show)(struct seq_file *, struct vfsmount *); |
74 | }; | 81 | }; |
75 | 82 | ||
83 | #define proc_mounts(p) (container_of((p), struct proc_mounts, m)) | ||
84 | |||
76 | extern const struct seq_operations mounts_op; | 85 | extern const struct seq_operations mounts_op; |
diff --git a/fs/namei.c b/fs/namei.c index 7d694194024a..2ccc35c4dc24 100644 --- a/fs/namei.c +++ b/fs/namei.c | |||
@@ -315,31 +315,22 @@ static inline int do_inode_permission(struct inode *inode, int mask) | |||
315 | } | 315 | } |
316 | 316 | ||
317 | /** | 317 | /** |
318 | * inode_permission - check for access rights to a given inode | 318 | * __inode_permission - Check for access rights to a given inode |
319 | * @inode: inode to check permission on | 319 | * @inode: Inode to check permission on |
320 | * @mask: right to check for (%MAY_READ, %MAY_WRITE, %MAY_EXEC, ...) | 320 | * @mask: Right to check for (%MAY_READ, %MAY_WRITE, %MAY_EXEC) |
321 | * | 321 | * |
322 | * Used to check for read/write/execute permissions on an inode. | 322 | * Check for read/write/execute permissions on an inode. |
323 | * We use "fsuid" for this, letting us set arbitrary permissions | ||
324 | * for filesystem access without changing the "normal" uids which | ||
325 | * are used for other things. | ||
326 | * | 323 | * |
327 | * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask. | 324 | * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask. |
325 | * | ||
326 | * This does not check for a read-only file system. You probably want | ||
327 | * inode_permission(). | ||
328 | */ | 328 | */ |
329 | int inode_permission(struct inode *inode, int mask) | 329 | int __inode_permission(struct inode *inode, int mask) |
330 | { | 330 | { |
331 | int retval; | 331 | int retval; |
332 | 332 | ||
333 | if (unlikely(mask & MAY_WRITE)) { | 333 | if (unlikely(mask & MAY_WRITE)) { |
334 | umode_t mode = inode->i_mode; | ||
335 | |||
336 | /* | ||
337 | * Nobody gets write access to a read-only fs. | ||
338 | */ | ||
339 | if (IS_RDONLY(inode) && | ||
340 | (S_ISREG(mode) || S_ISDIR(mode) || S_ISLNK(mode))) | ||
341 | return -EROFS; | ||
342 | |||
343 | /* | 334 | /* |
344 | * Nobody gets write access to an immutable file. | 335 | * Nobody gets write access to an immutable file. |
345 | */ | 336 | */ |
@@ -359,6 +350,47 @@ int inode_permission(struct inode *inode, int mask) | |||
359 | } | 350 | } |
360 | 351 | ||
361 | /** | 352 | /** |
353 | * sb_permission - Check superblock-level permissions | ||
354 | * @sb: Superblock of inode to check permission on | ||
355 | * @mask: Right to check for (%MAY_READ, %MAY_WRITE, %MAY_EXEC) | ||
356 | * | ||
357 | * Separate out file-system wide checks from inode-specific permission checks. | ||
358 | */ | ||
359 | static int sb_permission(struct super_block *sb, struct inode *inode, int mask) | ||
360 | { | ||
361 | if (unlikely(mask & MAY_WRITE)) { | ||
362 | umode_t mode = inode->i_mode; | ||
363 | |||
364 | /* Nobody gets write access to a read-only fs. */ | ||
365 | if ((sb->s_flags & MS_RDONLY) && | ||
366 | (S_ISREG(mode) || S_ISDIR(mode) || S_ISLNK(mode))) | ||
367 | return -EROFS; | ||
368 | } | ||
369 | return 0; | ||
370 | } | ||
371 | |||
372 | /** | ||
373 | * inode_permission - Check for access rights to a given inode | ||
374 | * @inode: Inode to check permission on | ||
375 | * @mask: Right to check for (%MAY_READ, %MAY_WRITE, %MAY_EXEC) | ||
376 | * | ||
377 | * Check for read/write/execute permissions on an inode. We use fs[ug]id for | ||
378 | * this, letting us set arbitrary permissions for filesystem access without | ||
379 | * changing the "normal" UIDs which are used for other things. | ||
380 | * | ||
381 | * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask. | ||
382 | */ | ||
383 | int inode_permission(struct inode *inode, int mask) | ||
384 | { | ||
385 | int retval; | ||
386 | |||
387 | retval = sb_permission(inode->i_sb, inode, mask); | ||
388 | if (retval) | ||
389 | return retval; | ||
390 | return __inode_permission(inode, mask); | ||
391 | } | ||
392 | |||
393 | /** | ||
362 | * path_get - get a reference to a path | 394 | * path_get - get a reference to a path |
363 | * @path: path to get the reference to | 395 | * @path: path to get the reference to |
364 | * | 396 | * |
@@ -395,6 +427,18 @@ EXPORT_SYMBOL(path_put); | |||
395 | * to restart the path walk from the beginning in ref-walk mode. | 427 | * to restart the path walk from the beginning in ref-walk mode. |
396 | */ | 428 | */ |
397 | 429 | ||
430 | static inline void lock_rcu_walk(void) | ||
431 | { | ||
432 | br_read_lock(&vfsmount_lock); | ||
433 | rcu_read_lock(); | ||
434 | } | ||
435 | |||
436 | static inline void unlock_rcu_walk(void) | ||
437 | { | ||
438 | rcu_read_unlock(); | ||
439 | br_read_unlock(&vfsmount_lock); | ||
440 | } | ||
441 | |||
398 | /** | 442 | /** |
399 | * unlazy_walk - try to switch to ref-walk mode. | 443 | * unlazy_walk - try to switch to ref-walk mode. |
400 | * @nd: nameidata pathwalk data | 444 | * @nd: nameidata pathwalk data |
@@ -448,8 +492,7 @@ static int unlazy_walk(struct nameidata *nd, struct dentry *dentry) | |||
448 | } | 492 | } |
449 | mntget(nd->path.mnt); | 493 | mntget(nd->path.mnt); |
450 | 494 | ||
451 | rcu_read_unlock(); | 495 | unlock_rcu_walk(); |
452 | br_read_unlock(&vfsmount_lock); | ||
453 | nd->flags &= ~LOOKUP_RCU; | 496 | nd->flags &= ~LOOKUP_RCU; |
454 | return 0; | 497 | return 0; |
455 | 498 | ||
@@ -463,25 +506,9 @@ err_root: | |||
463 | return -ECHILD; | 506 | return -ECHILD; |
464 | } | 507 | } |
465 | 508 | ||
466 | /** | 509 | static inline int d_revalidate(struct dentry *dentry, unsigned int flags) |
467 | * release_open_intent - free up open intent resources | ||
468 | * @nd: pointer to nameidata | ||
469 | */ | ||
470 | void release_open_intent(struct nameidata *nd) | ||
471 | { | 510 | { |
472 | struct file *file = nd->intent.open.file; | 511 | return dentry->d_op->d_revalidate(dentry, flags); |
473 | |||
474 | if (file && !IS_ERR(file)) { | ||
475 | if (file->f_path.dentry == NULL) | ||
476 | put_filp(file); | ||
477 | else | ||
478 | fput(file); | ||
479 | } | ||
480 | } | ||
481 | |||
482 | static inline int d_revalidate(struct dentry *dentry, struct nameidata *nd) | ||
483 | { | ||
484 | return dentry->d_op->d_revalidate(dentry, nd); | ||
485 | } | 512 | } |
486 | 513 | ||
487 | /** | 514 | /** |
@@ -506,15 +533,13 @@ static int complete_walk(struct nameidata *nd) | |||
506 | spin_lock(&dentry->d_lock); | 533 | spin_lock(&dentry->d_lock); |
507 | if (unlikely(!__d_rcu_to_refcount(dentry, nd->seq))) { | 534 | if (unlikely(!__d_rcu_to_refcount(dentry, nd->seq))) { |
508 | spin_unlock(&dentry->d_lock); | 535 | spin_unlock(&dentry->d_lock); |
509 | rcu_read_unlock(); | 536 | unlock_rcu_walk(); |
510 | br_read_unlock(&vfsmount_lock); | ||
511 | return -ECHILD; | 537 | return -ECHILD; |
512 | } | 538 | } |
513 | BUG_ON(nd->inode != dentry->d_inode); | 539 | BUG_ON(nd->inode != dentry->d_inode); |
514 | spin_unlock(&dentry->d_lock); | 540 | spin_unlock(&dentry->d_lock); |
515 | mntget(nd->path.mnt); | 541 | mntget(nd->path.mnt); |
516 | rcu_read_unlock(); | 542 | unlock_rcu_walk(); |
517 | br_read_unlock(&vfsmount_lock); | ||
518 | } | 543 | } |
519 | 544 | ||
520 | if (likely(!(nd->flags & LOOKUP_JUMPED))) | 545 | if (likely(!(nd->flags & LOOKUP_JUMPED))) |
@@ -527,7 +552,7 @@ static int complete_walk(struct nameidata *nd) | |||
527 | return 0; | 552 | return 0; |
528 | 553 | ||
529 | /* Note: we do not d_invalidate() */ | 554 | /* Note: we do not d_invalidate() */ |
530 | status = d_revalidate(dentry, nd); | 555 | status = d_revalidate(dentry, nd->flags); |
531 | if (status > 0) | 556 | if (status > 0) |
532 | return 0; | 557 | return 0; |
533 | 558 | ||
@@ -602,10 +627,25 @@ static inline void path_to_nameidata(const struct path *path, | |||
602 | nd->path.dentry = path->dentry; | 627 | nd->path.dentry = path->dentry; |
603 | } | 628 | } |
604 | 629 | ||
630 | /* | ||
631 | * Helper to directly jump to a known parsed path from ->follow_link, | ||
632 | * caller must have taken a reference to path beforehand. | ||
633 | */ | ||
634 | void nd_jump_link(struct nameidata *nd, struct path *path) | ||
635 | { | ||
636 | path_put(&nd->path); | ||
637 | |||
638 | nd->path = *path; | ||
639 | nd->inode = nd->path.dentry->d_inode; | ||
640 | nd->flags |= LOOKUP_JUMPED; | ||
641 | |||
642 | BUG_ON(nd->inode->i_op->follow_link); | ||
643 | } | ||
644 | |||
605 | static inline void put_link(struct nameidata *nd, struct path *link, void *cookie) | 645 | static inline void put_link(struct nameidata *nd, struct path *link, void *cookie) |
606 | { | 646 | { |
607 | struct inode *inode = link->dentry->d_inode; | 647 | struct inode *inode = link->dentry->d_inode; |
608 | if (!IS_ERR(cookie) && inode->i_op->put_link) | 648 | if (inode->i_op->put_link) |
609 | inode->i_op->put_link(link->dentry, nd, cookie); | 649 | inode->i_op->put_link(link->dentry, nd, cookie); |
610 | path_put(link); | 650 | path_put(link); |
611 | } | 651 | } |
@@ -613,19 +653,19 @@ static inline void put_link(struct nameidata *nd, struct path *link, void *cooki | |||
613 | static __always_inline int | 653 | static __always_inline int |
614 | follow_link(struct path *link, struct nameidata *nd, void **p) | 654 | follow_link(struct path *link, struct nameidata *nd, void **p) |
615 | { | 655 | { |
616 | int error; | ||
617 | struct dentry *dentry = link->dentry; | 656 | struct dentry *dentry = link->dentry; |
657 | int error; | ||
658 | char *s; | ||
618 | 659 | ||
619 | BUG_ON(nd->flags & LOOKUP_RCU); | 660 | BUG_ON(nd->flags & LOOKUP_RCU); |
620 | 661 | ||
621 | if (link->mnt == nd->path.mnt) | 662 | if (link->mnt == nd->path.mnt) |
622 | mntget(link->mnt); | 663 | mntget(link->mnt); |
623 | 664 | ||
624 | if (unlikely(current->total_link_count >= 40)) { | 665 | error = -ELOOP; |
625 | *p = ERR_PTR(-ELOOP); /* no ->put_link(), please */ | 666 | if (unlikely(current->total_link_count >= 40)) |
626 | path_put(&nd->path); | 667 | goto out_put_nd_path; |
627 | return -ELOOP; | 668 | |
628 | } | ||
629 | cond_resched(); | 669 | cond_resched(); |
630 | current->total_link_count++; | 670 | current->total_link_count++; |
631 | 671 | ||
@@ -633,30 +673,28 @@ follow_link(struct path *link, struct nameidata *nd, void **p) | |||
633 | nd_set_link(nd, NULL); | 673 | nd_set_link(nd, NULL); |
634 | 674 | ||
635 | error = security_inode_follow_link(link->dentry, nd); | 675 | error = security_inode_follow_link(link->dentry, nd); |
636 | if (error) { | 676 | if (error) |
637 | *p = ERR_PTR(error); /* no ->put_link(), please */ | 677 | goto out_put_nd_path; |
638 | path_put(&nd->path); | ||
639 | return error; | ||
640 | } | ||
641 | 678 | ||
642 | nd->last_type = LAST_BIND; | 679 | nd->last_type = LAST_BIND; |
643 | *p = dentry->d_inode->i_op->follow_link(dentry, nd); | 680 | *p = dentry->d_inode->i_op->follow_link(dentry, nd); |
644 | error = PTR_ERR(*p); | 681 | error = PTR_ERR(*p); |
645 | if (!IS_ERR(*p)) { | 682 | if (IS_ERR(*p)) |
646 | char *s = nd_get_link(nd); | 683 | goto out_put_nd_path; |
647 | error = 0; | 684 | |
648 | if (s) | 685 | error = 0; |
649 | error = __vfs_follow_link(nd, s); | 686 | s = nd_get_link(nd); |
650 | else if (nd->last_type == LAST_BIND) { | 687 | if (s) { |
651 | nd->flags |= LOOKUP_JUMPED; | 688 | error = __vfs_follow_link(nd, s); |
652 | nd->inode = nd->path.dentry->d_inode; | 689 | if (unlikely(error)) |
653 | if (nd->inode->i_op->follow_link) { | 690 | put_link(nd, link, *p); |
654 | /* stepped on a _really_ weird one */ | ||
655 | path_put(&nd->path); | ||
656 | error = -ELOOP; | ||
657 | } | ||
658 | } | ||
659 | } | 691 | } |
692 | |||
693 | return error; | ||
694 | |||
695 | out_put_nd_path: | ||
696 | path_put(&nd->path); | ||
697 | path_put(link); | ||
660 | return error; | 698 | return error; |
661 | } | 699 | } |
662 | 700 | ||
@@ -675,6 +713,16 @@ static int follow_up_rcu(struct path *path) | |||
675 | return 1; | 713 | return 1; |
676 | } | 714 | } |
677 | 715 | ||
716 | /* | ||
717 | * follow_up - Find the mountpoint of path's vfsmount | ||
718 | * | ||
719 | * Given a path, find the mountpoint of its source file system. | ||
720 | * Replace @path with the path of the mountpoint in the parent mount. | ||
721 | * Up is towards /. | ||
722 | * | ||
723 | * Return 1 if we went up a level and 0 if we were already at the | ||
724 | * root. | ||
725 | */ | ||
678 | int follow_up(struct path *path) | 726 | int follow_up(struct path *path) |
679 | { | 727 | { |
680 | struct mount *mnt = real_mount(path->mnt); | 728 | struct mount *mnt = real_mount(path->mnt); |
@@ -683,7 +731,7 @@ int follow_up(struct path *path) | |||
683 | 731 | ||
684 | br_read_lock(&vfsmount_lock); | 732 | br_read_lock(&vfsmount_lock); |
685 | parent = mnt->mnt_parent; | 733 | parent = mnt->mnt_parent; |
686 | if (&parent->mnt == path->mnt) { | 734 | if (parent == mnt) { |
687 | br_read_unlock(&vfsmount_lock); | 735 | br_read_unlock(&vfsmount_lock); |
688 | return 0; | 736 | return 0; |
689 | } | 737 | } |
@@ -946,8 +994,7 @@ failed: | |||
946 | nd->flags &= ~LOOKUP_RCU; | 994 | nd->flags &= ~LOOKUP_RCU; |
947 | if (!(nd->flags & LOOKUP_ROOT)) | 995 | if (!(nd->flags & LOOKUP_ROOT)) |
948 | nd->root.mnt = NULL; | 996 | nd->root.mnt = NULL; |
949 | rcu_read_unlock(); | 997 | unlock_rcu_walk(); |
950 | br_read_unlock(&vfsmount_lock); | ||
951 | return -ECHILD; | 998 | return -ECHILD; |
952 | } | 999 | } |
953 | 1000 | ||
@@ -1048,7 +1095,7 @@ static void follow_dotdot(struct nameidata *nd) | |||
1048 | * dir->d_inode->i_mutex must be held | 1095 | * dir->d_inode->i_mutex must be held |
1049 | */ | 1096 | */ |
1050 | static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir, | 1097 | static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir, |
1051 | struct nameidata *nd, bool *need_lookup) | 1098 | unsigned int flags, bool *need_lookup) |
1052 | { | 1099 | { |
1053 | struct dentry *dentry; | 1100 | struct dentry *dentry; |
1054 | int error; | 1101 | int error; |
@@ -1059,7 +1106,7 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir, | |||
1059 | if (d_need_lookup(dentry)) { | 1106 | if (d_need_lookup(dentry)) { |
1060 | *need_lookup = true; | 1107 | *need_lookup = true; |
1061 | } else if (dentry->d_flags & DCACHE_OP_REVALIDATE) { | 1108 | } else if (dentry->d_flags & DCACHE_OP_REVALIDATE) { |
1062 | error = d_revalidate(dentry, nd); | 1109 | error = d_revalidate(dentry, flags); |
1063 | if (unlikely(error <= 0)) { | 1110 | if (unlikely(error <= 0)) { |
1064 | if (error < 0) { | 1111 | if (error < 0) { |
1065 | dput(dentry); | 1112 | dput(dentry); |
@@ -1089,7 +1136,7 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir, | |||
1089 | * dir->d_inode->i_mutex must be held | 1136 | * dir->d_inode->i_mutex must be held |
1090 | */ | 1137 | */ |
1091 | static struct dentry *lookup_real(struct inode *dir, struct dentry *dentry, | 1138 | static struct dentry *lookup_real(struct inode *dir, struct dentry *dentry, |
1092 | struct nameidata *nd) | 1139 | unsigned int flags) |
1093 | { | 1140 | { |
1094 | struct dentry *old; | 1141 | struct dentry *old; |
1095 | 1142 | ||
@@ -1099,7 +1146,7 @@ static struct dentry *lookup_real(struct inode *dir, struct dentry *dentry, | |||
1099 | return ERR_PTR(-ENOENT); | 1146 | return ERR_PTR(-ENOENT); |
1100 | } | 1147 | } |
1101 | 1148 | ||
1102 | old = dir->i_op->lookup(dir, dentry, nd); | 1149 | old = dir->i_op->lookup(dir, dentry, flags); |
1103 | if (unlikely(old)) { | 1150 | if (unlikely(old)) { |
1104 | dput(dentry); | 1151 | dput(dentry); |
1105 | dentry = old; | 1152 | dentry = old; |
@@ -1108,16 +1155,16 @@ static struct dentry *lookup_real(struct inode *dir, struct dentry *dentry, | |||
1108 | } | 1155 | } |
1109 | 1156 | ||
1110 | static struct dentry *__lookup_hash(struct qstr *name, | 1157 | static struct dentry *__lookup_hash(struct qstr *name, |
1111 | struct dentry *base, struct nameidata *nd) | 1158 | struct dentry *base, unsigned int flags) |
1112 | { | 1159 | { |
1113 | bool need_lookup; | 1160 | bool need_lookup; |
1114 | struct dentry *dentry; | 1161 | struct dentry *dentry; |
1115 | 1162 | ||
1116 | dentry = lookup_dcache(name, base, nd, &need_lookup); | 1163 | dentry = lookup_dcache(name, base, flags, &need_lookup); |
1117 | if (!need_lookup) | 1164 | if (!need_lookup) |
1118 | return dentry; | 1165 | return dentry; |
1119 | 1166 | ||
1120 | return lookup_real(base->d_inode, dentry, nd); | 1167 | return lookup_real(base->d_inode, dentry, flags); |
1121 | } | 1168 | } |
1122 | 1169 | ||
1123 | /* | 1170 | /* |
@@ -1167,7 +1214,7 @@ static int lookup_fast(struct nameidata *nd, struct qstr *name, | |||
1167 | if (unlikely(d_need_lookup(dentry))) | 1214 | if (unlikely(d_need_lookup(dentry))) |
1168 | goto unlazy; | 1215 | goto unlazy; |
1169 | if (unlikely(dentry->d_flags & DCACHE_OP_REVALIDATE)) { | 1216 | if (unlikely(dentry->d_flags & DCACHE_OP_REVALIDATE)) { |
1170 | status = d_revalidate(dentry, nd); | 1217 | status = d_revalidate(dentry, nd->flags); |
1171 | if (unlikely(status <= 0)) { | 1218 | if (unlikely(status <= 0)) { |
1172 | if (status != -ECHILD) | 1219 | if (status != -ECHILD) |
1173 | need_reval = 0; | 1220 | need_reval = 0; |
@@ -1197,7 +1244,7 @@ unlazy: | |||
1197 | } | 1244 | } |
1198 | 1245 | ||
1199 | if (unlikely(dentry->d_flags & DCACHE_OP_REVALIDATE) && need_reval) | 1246 | if (unlikely(dentry->d_flags & DCACHE_OP_REVALIDATE) && need_reval) |
1200 | status = d_revalidate(dentry, nd); | 1247 | status = d_revalidate(dentry, nd->flags); |
1201 | if (unlikely(status <= 0)) { | 1248 | if (unlikely(status <= 0)) { |
1202 | if (status < 0) { | 1249 | if (status < 0) { |
1203 | dput(dentry); | 1250 | dput(dentry); |
@@ -1236,7 +1283,7 @@ static int lookup_slow(struct nameidata *nd, struct qstr *name, | |||
1236 | BUG_ON(nd->inode != parent->d_inode); | 1283 | BUG_ON(nd->inode != parent->d_inode); |
1237 | 1284 | ||
1238 | mutex_lock(&parent->d_inode->i_mutex); | 1285 | mutex_lock(&parent->d_inode->i_mutex); |
1239 | dentry = __lookup_hash(name, parent, nd); | 1286 | dentry = __lookup_hash(name, parent, nd->flags); |
1240 | mutex_unlock(&parent->d_inode->i_mutex); | 1287 | mutex_unlock(&parent->d_inode->i_mutex); |
1241 | if (IS_ERR(dentry)) | 1288 | if (IS_ERR(dentry)) |
1242 | return PTR_ERR(dentry); | 1289 | return PTR_ERR(dentry); |
@@ -1284,8 +1331,7 @@ static void terminate_walk(struct nameidata *nd) | |||
1284 | nd->flags &= ~LOOKUP_RCU; | 1331 | nd->flags &= ~LOOKUP_RCU; |
1285 | if (!(nd->flags & LOOKUP_ROOT)) | 1332 | if (!(nd->flags & LOOKUP_ROOT)) |
1286 | nd->root.mnt = NULL; | 1333 | nd->root.mnt = NULL; |
1287 | rcu_read_unlock(); | 1334 | unlock_rcu_walk(); |
1288 | br_read_unlock(&vfsmount_lock); | ||
1289 | } | 1335 | } |
1290 | } | 1336 | } |
1291 | 1337 | ||
@@ -1383,9 +1429,10 @@ static inline int nested_symlink(struct path *path, struct nameidata *nd) | |||
1383 | void *cookie; | 1429 | void *cookie; |
1384 | 1430 | ||
1385 | res = follow_link(&link, nd, &cookie); | 1431 | res = follow_link(&link, nd, &cookie); |
1386 | if (!res) | 1432 | if (res) |
1387 | res = walk_component(nd, path, &nd->last, | 1433 | break; |
1388 | nd->last_type, LOOKUP_FOLLOW); | 1434 | res = walk_component(nd, path, &nd->last, |
1435 | nd->last_type, LOOKUP_FOLLOW); | ||
1389 | put_link(nd, &link, cookie); | 1436 | put_link(nd, &link, cookie); |
1390 | } while (res > 0); | 1437 | } while (res > 0); |
1391 | 1438 | ||
@@ -1651,8 +1698,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1651 | nd->path = nd->root; | 1698 | nd->path = nd->root; |
1652 | nd->inode = inode; | 1699 | nd->inode = inode; |
1653 | if (flags & LOOKUP_RCU) { | 1700 | if (flags & LOOKUP_RCU) { |
1654 | br_read_lock(&vfsmount_lock); | 1701 | lock_rcu_walk(); |
1655 | rcu_read_lock(); | ||
1656 | nd->seq = __read_seqcount_begin(&nd->path.dentry->d_seq); | 1702 | nd->seq = __read_seqcount_begin(&nd->path.dentry->d_seq); |
1657 | } else { | 1703 | } else { |
1658 | path_get(&nd->path); | 1704 | path_get(&nd->path); |
@@ -1664,8 +1710,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1664 | 1710 | ||
1665 | if (*name=='/') { | 1711 | if (*name=='/') { |
1666 | if (flags & LOOKUP_RCU) { | 1712 | if (flags & LOOKUP_RCU) { |
1667 | br_read_lock(&vfsmount_lock); | 1713 | lock_rcu_walk(); |
1668 | rcu_read_lock(); | ||
1669 | set_root_rcu(nd); | 1714 | set_root_rcu(nd); |
1670 | } else { | 1715 | } else { |
1671 | set_root(nd); | 1716 | set_root(nd); |
@@ -1677,8 +1722,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1677 | struct fs_struct *fs = current->fs; | 1722 | struct fs_struct *fs = current->fs; |
1678 | unsigned seq; | 1723 | unsigned seq; |
1679 | 1724 | ||
1680 | br_read_lock(&vfsmount_lock); | 1725 | lock_rcu_walk(); |
1681 | rcu_read_lock(); | ||
1682 | 1726 | ||
1683 | do { | 1727 | do { |
1684 | seq = read_seqcount_begin(&fs->seq); | 1728 | seq = read_seqcount_begin(&fs->seq); |
@@ -1713,8 +1757,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
1713 | if (fput_needed) | 1757 | if (fput_needed) |
1714 | *fp = file; | 1758 | *fp = file; |
1715 | nd->seq = __read_seqcount_begin(&nd->path.dentry->d_seq); | 1759 | nd->seq = __read_seqcount_begin(&nd->path.dentry->d_seq); |
1716 | br_read_lock(&vfsmount_lock); | 1760 | lock_rcu_walk(); |
1717 | rcu_read_lock(); | ||
1718 | } else { | 1761 | } else { |
1719 | path_get(&file->f_path); | 1762 | path_get(&file->f_path); |
1720 | fput_light(file, fput_needed); | 1763 | fput_light(file, fput_needed); |
@@ -1777,8 +1820,9 @@ static int path_lookupat(int dfd, const char *name, | |||
1777 | struct path link = path; | 1820 | struct path link = path; |
1778 | nd->flags |= LOOKUP_PARENT; | 1821 | nd->flags |= LOOKUP_PARENT; |
1779 | err = follow_link(&link, nd, &cookie); | 1822 | err = follow_link(&link, nd, &cookie); |
1780 | if (!err) | 1823 | if (err) |
1781 | err = lookup_last(nd, &path); | 1824 | break; |
1825 | err = lookup_last(nd, &path); | ||
1782 | put_link(nd, &link, cookie); | 1826 | put_link(nd, &link, cookie); |
1783 | } | 1827 | } |
1784 | } | 1828 | } |
@@ -1821,9 +1865,27 @@ static int do_path_lookup(int dfd, const char *name, | |||
1821 | return retval; | 1865 | return retval; |
1822 | } | 1866 | } |
1823 | 1867 | ||
1824 | int kern_path_parent(const char *name, struct nameidata *nd) | 1868 | /* does lookup, returns the object with parent locked */ |
1869 | struct dentry *kern_path_locked(const char *name, struct path *path) | ||
1825 | { | 1870 | { |
1826 | return do_path_lookup(AT_FDCWD, name, LOOKUP_PARENT, nd); | 1871 | struct nameidata nd; |
1872 | struct dentry *d; | ||
1873 | int err = do_path_lookup(AT_FDCWD, name, LOOKUP_PARENT, &nd); | ||
1874 | if (err) | ||
1875 | return ERR_PTR(err); | ||
1876 | if (nd.last_type != LAST_NORM) { | ||
1877 | path_put(&nd.path); | ||
1878 | return ERR_PTR(-EINVAL); | ||
1879 | } | ||
1880 | mutex_lock_nested(&nd.path.dentry->d_inode->i_mutex, I_MUTEX_PARENT); | ||
1881 | d = __lookup_hash(&nd.last, nd.path.dentry, 0); | ||
1882 | if (IS_ERR(d)) { | ||
1883 | mutex_unlock(&nd.path.dentry->d_inode->i_mutex); | ||
1884 | path_put(&nd.path); | ||
1885 | return d; | ||
1886 | } | ||
1887 | *path = nd.path; | ||
1888 | return d; | ||
1827 | } | 1889 | } |
1828 | 1890 | ||
1829 | int kern_path(const char *name, unsigned int flags, struct path *path) | 1891 | int kern_path(const char *name, unsigned int flags, struct path *path) |
@@ -1866,7 +1928,7 @@ int vfs_path_lookup(struct dentry *dentry, struct vfsmount *mnt, | |||
1866 | */ | 1928 | */ |
1867 | static struct dentry *lookup_hash(struct nameidata *nd) | 1929 | static struct dentry *lookup_hash(struct nameidata *nd) |
1868 | { | 1930 | { |
1869 | return __lookup_hash(&nd->last, nd->path.dentry, nd); | 1931 | return __lookup_hash(&nd->last, nd->path.dentry, nd->flags); |
1870 | } | 1932 | } |
1871 | 1933 | ||
1872 | /** | 1934 | /** |
@@ -1913,7 +1975,7 @@ struct dentry *lookup_one_len(const char *name, struct dentry *base, int len) | |||
1913 | if (err) | 1975 | if (err) |
1914 | return ERR_PTR(err); | 1976 | return ERR_PTR(err); |
1915 | 1977 | ||
1916 | return __lookup_hash(&this, base, NULL); | 1978 | return __lookup_hash(&this, base, 0); |
1917 | } | 1979 | } |
1918 | 1980 | ||
1919 | int user_path_at_empty(int dfd, const char __user *name, unsigned flags, | 1981 | int user_path_at_empty(int dfd, const char __user *name, unsigned flags, |
@@ -2086,10 +2148,9 @@ void unlock_rename(struct dentry *p1, struct dentry *p2) | |||
2086 | } | 2148 | } |
2087 | 2149 | ||
2088 | int vfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 2150 | int vfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
2089 | struct nameidata *nd) | 2151 | bool want_excl) |
2090 | { | 2152 | { |
2091 | int error = may_create(dir, dentry); | 2153 | int error = may_create(dir, dentry); |
2092 | |||
2093 | if (error) | 2154 | if (error) |
2094 | return error; | 2155 | return error; |
2095 | 2156 | ||
@@ -2100,7 +2161,7 @@ int vfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | |||
2100 | error = security_inode_create(dir, dentry, mode); | 2161 | error = security_inode_create(dir, dentry, mode); |
2101 | if (error) | 2162 | if (error) |
2102 | return error; | 2163 | return error; |
2103 | error = dir->i_op->create(dir, dentry, mode, nd); | 2164 | error = dir->i_op->create(dir, dentry, mode, want_excl); |
2104 | if (!error) | 2165 | if (!error) |
2105 | fsnotify_create(dir, dentry); | 2166 | fsnotify_create(dir, dentry); |
2106 | return error; | 2167 | return error; |
@@ -2187,21 +2248,275 @@ static inline int open_to_namei_flags(int flag) | |||
2187 | return flag; | 2248 | return flag; |
2188 | } | 2249 | } |
2189 | 2250 | ||
2251 | static int may_o_create(struct path *dir, struct dentry *dentry, umode_t mode) | ||
2252 | { | ||
2253 | int error = security_path_mknod(dir, dentry, mode, 0); | ||
2254 | if (error) | ||
2255 | return error; | ||
2256 | |||
2257 | error = inode_permission(dir->dentry->d_inode, MAY_WRITE | MAY_EXEC); | ||
2258 | if (error) | ||
2259 | return error; | ||
2260 | |||
2261 | return security_inode_create(dir->dentry->d_inode, dentry, mode); | ||
2262 | } | ||
2263 | |||
2190 | /* | 2264 | /* |
2191 | * Handle the last step of open() | 2265 | * Attempt to atomically look up, create and open a file from a negative |
2266 | * dentry. | ||
2267 | * | ||
2268 | * Returns 0 if successful. The file will have been created and attached to | ||
2269 | * @file by the filesystem calling finish_open(). | ||
2270 | * | ||
2271 | * Returns 1 if the file was looked up only or didn't need creating. The | ||
2272 | * caller will need to perform the open themselves. @path will have been | ||
2273 | * updated to point to the new dentry. This may be negative. | ||
2274 | * | ||
2275 | * Returns an error code otherwise. | ||
2276 | */ | ||
2277 | static int atomic_open(struct nameidata *nd, struct dentry *dentry, | ||
2278 | struct path *path, struct file *file, | ||
2279 | const struct open_flags *op, | ||
2280 | bool *want_write, bool need_lookup, | ||
2281 | int *opened) | ||
2282 | { | ||
2283 | struct inode *dir = nd->path.dentry->d_inode; | ||
2284 | unsigned open_flag = open_to_namei_flags(op->open_flag); | ||
2285 | umode_t mode; | ||
2286 | int error; | ||
2287 | int acc_mode; | ||
2288 | int create_error = 0; | ||
2289 | struct dentry *const DENTRY_NOT_SET = (void *) -1UL; | ||
2290 | |||
2291 | BUG_ON(dentry->d_inode); | ||
2292 | |||
2293 | /* Don't create child dentry for a dead directory. */ | ||
2294 | if (unlikely(IS_DEADDIR(dir))) { | ||
2295 | error = -ENOENT; | ||
2296 | goto out; | ||
2297 | } | ||
2298 | |||
2299 | mode = op->mode & S_IALLUGO; | ||
2300 | if ((open_flag & O_CREAT) && !IS_POSIXACL(dir)) | ||
2301 | mode &= ~current_umask(); | ||
2302 | |||
2303 | if (open_flag & O_EXCL) { | ||
2304 | open_flag &= ~O_TRUNC; | ||
2305 | *opened |= FILE_CREATED; | ||
2306 | } | ||
2307 | |||
2308 | /* | ||
2309 | * Checking write permission is tricky, bacuse we don't know if we are | ||
2310 | * going to actually need it: O_CREAT opens should work as long as the | ||
2311 | * file exists. But checking existence breaks atomicity. The trick is | ||
2312 | * to check access and if not granted clear O_CREAT from the flags. | ||
2313 | * | ||
2314 | * Another problem is returing the "right" error value (e.g. for an | ||
2315 | * O_EXCL open we want to return EEXIST not EROFS). | ||
2316 | */ | ||
2317 | if ((open_flag & (O_CREAT | O_TRUNC)) || | ||
2318 | (open_flag & O_ACCMODE) != O_RDONLY) { | ||
2319 | error = mnt_want_write(nd->path.mnt); | ||
2320 | if (!error) { | ||
2321 | *want_write = true; | ||
2322 | } else if (!(open_flag & O_CREAT)) { | ||
2323 | /* | ||
2324 | * No O_CREATE -> atomicity not a requirement -> fall | ||
2325 | * back to lookup + open | ||
2326 | */ | ||
2327 | goto no_open; | ||
2328 | } else if (open_flag & (O_EXCL | O_TRUNC)) { | ||
2329 | /* Fall back and fail with the right error */ | ||
2330 | create_error = error; | ||
2331 | goto no_open; | ||
2332 | } else { | ||
2333 | /* No side effects, safe to clear O_CREAT */ | ||
2334 | create_error = error; | ||
2335 | open_flag &= ~O_CREAT; | ||
2336 | } | ||
2337 | } | ||
2338 | |||
2339 | if (open_flag & O_CREAT) { | ||
2340 | error = may_o_create(&nd->path, dentry, op->mode); | ||
2341 | if (error) { | ||
2342 | create_error = error; | ||
2343 | if (open_flag & O_EXCL) | ||
2344 | goto no_open; | ||
2345 | open_flag &= ~O_CREAT; | ||
2346 | } | ||
2347 | } | ||
2348 | |||
2349 | if (nd->flags & LOOKUP_DIRECTORY) | ||
2350 | open_flag |= O_DIRECTORY; | ||
2351 | |||
2352 | file->f_path.dentry = DENTRY_NOT_SET; | ||
2353 | file->f_path.mnt = nd->path.mnt; | ||
2354 | error = dir->i_op->atomic_open(dir, dentry, file, open_flag, mode, | ||
2355 | opened); | ||
2356 | if (error < 0) { | ||
2357 | if (create_error && error == -ENOENT) | ||
2358 | error = create_error; | ||
2359 | goto out; | ||
2360 | } | ||
2361 | |||
2362 | acc_mode = op->acc_mode; | ||
2363 | if (*opened & FILE_CREATED) { | ||
2364 | fsnotify_create(dir, dentry); | ||
2365 | acc_mode = MAY_OPEN; | ||
2366 | } | ||
2367 | |||
2368 | if (error) { /* returned 1, that is */ | ||
2369 | if (WARN_ON(file->f_path.dentry == DENTRY_NOT_SET)) { | ||
2370 | error = -EIO; | ||
2371 | goto out; | ||
2372 | } | ||
2373 | if (file->f_path.dentry) { | ||
2374 | dput(dentry); | ||
2375 | dentry = file->f_path.dentry; | ||
2376 | } | ||
2377 | goto looked_up; | ||
2378 | } | ||
2379 | |||
2380 | /* | ||
2381 | * We didn't have the inode before the open, so check open permission | ||
2382 | * here. | ||
2383 | */ | ||
2384 | error = may_open(&file->f_path, acc_mode, open_flag); | ||
2385 | if (error) | ||
2386 | fput(file); | ||
2387 | |||
2388 | out: | ||
2389 | dput(dentry); | ||
2390 | return error; | ||
2391 | |||
2392 | no_open: | ||
2393 | if (need_lookup) { | ||
2394 | dentry = lookup_real(dir, dentry, nd->flags); | ||
2395 | if (IS_ERR(dentry)) | ||
2396 | return PTR_ERR(dentry); | ||
2397 | |||
2398 | if (create_error) { | ||
2399 | int open_flag = op->open_flag; | ||
2400 | |||
2401 | error = create_error; | ||
2402 | if ((open_flag & O_EXCL)) { | ||
2403 | if (!dentry->d_inode) | ||
2404 | goto out; | ||
2405 | } else if (!dentry->d_inode) { | ||
2406 | goto out; | ||
2407 | } else if ((open_flag & O_TRUNC) && | ||
2408 | S_ISREG(dentry->d_inode->i_mode)) { | ||
2409 | goto out; | ||
2410 | } | ||
2411 | /* will fail later, go on to get the right error */ | ||
2412 | } | ||
2413 | } | ||
2414 | looked_up: | ||
2415 | path->dentry = dentry; | ||
2416 | path->mnt = nd->path.mnt; | ||
2417 | return 1; | ||
2418 | } | ||
2419 | |||
2420 | /* | ||
2421 | * Look up and maybe create and open the last component. | ||
2422 | * | ||
2423 | * Must be called with i_mutex held on parent. | ||
2424 | * | ||
2425 | * Returns 0 if the file was successfully atomically created (if necessary) and | ||
2426 | * opened. In this case the file will be returned attached to @file. | ||
2427 | * | ||
2428 | * Returns 1 if the file was not completely opened at this time, though lookups | ||
2429 | * and creations will have been performed and the dentry returned in @path will | ||
2430 | * be positive upon return if O_CREAT was specified. If O_CREAT wasn't | ||
2431 | * specified then a negative dentry may be returned. | ||
2432 | * | ||
2433 | * An error code is returned otherwise. | ||
2434 | * | ||
2435 | * FILE_CREATE will be set in @*opened if the dentry was created and will be | ||
2436 | * cleared otherwise prior to returning. | ||
2192 | */ | 2437 | */ |
2193 | static struct file *do_last(struct nameidata *nd, struct path *path, | 2438 | static int lookup_open(struct nameidata *nd, struct path *path, |
2194 | const struct open_flags *op, const char *pathname) | 2439 | struct file *file, |
2440 | const struct open_flags *op, | ||
2441 | bool *want_write, int *opened) | ||
2195 | { | 2442 | { |
2196 | struct dentry *dir = nd->path.dentry; | 2443 | struct dentry *dir = nd->path.dentry; |
2444 | struct inode *dir_inode = dir->d_inode; | ||
2197 | struct dentry *dentry; | 2445 | struct dentry *dentry; |
2446 | int error; | ||
2447 | bool need_lookup; | ||
2448 | |||
2449 | *opened &= ~FILE_CREATED; | ||
2450 | dentry = lookup_dcache(&nd->last, dir, nd->flags, &need_lookup); | ||
2451 | if (IS_ERR(dentry)) | ||
2452 | return PTR_ERR(dentry); | ||
2453 | |||
2454 | /* Cached positive dentry: will open in f_op->open */ | ||
2455 | if (!need_lookup && dentry->d_inode) | ||
2456 | goto out_no_open; | ||
2457 | |||
2458 | if ((nd->flags & LOOKUP_OPEN) && dir_inode->i_op->atomic_open) { | ||
2459 | return atomic_open(nd, dentry, path, file, op, want_write, | ||
2460 | need_lookup, opened); | ||
2461 | } | ||
2462 | |||
2463 | if (need_lookup) { | ||
2464 | BUG_ON(dentry->d_inode); | ||
2465 | |||
2466 | dentry = lookup_real(dir_inode, dentry, nd->flags); | ||
2467 | if (IS_ERR(dentry)) | ||
2468 | return PTR_ERR(dentry); | ||
2469 | } | ||
2470 | |||
2471 | /* Negative dentry, just create the file */ | ||
2472 | if (!dentry->d_inode && (op->open_flag & O_CREAT)) { | ||
2473 | umode_t mode = op->mode; | ||
2474 | if (!IS_POSIXACL(dir->d_inode)) | ||
2475 | mode &= ~current_umask(); | ||
2476 | /* | ||
2477 | * This write is needed to ensure that a | ||
2478 | * rw->ro transition does not occur between | ||
2479 | * the time when the file is created and when | ||
2480 | * a permanent write count is taken through | ||
2481 | * the 'struct file' in finish_open(). | ||
2482 | */ | ||
2483 | error = mnt_want_write(nd->path.mnt); | ||
2484 | if (error) | ||
2485 | goto out_dput; | ||
2486 | *want_write = true; | ||
2487 | *opened |= FILE_CREATED; | ||
2488 | error = security_path_mknod(&nd->path, dentry, mode, 0); | ||
2489 | if (error) | ||
2490 | goto out_dput; | ||
2491 | error = vfs_create(dir->d_inode, dentry, mode, | ||
2492 | nd->flags & LOOKUP_EXCL); | ||
2493 | if (error) | ||
2494 | goto out_dput; | ||
2495 | } | ||
2496 | out_no_open: | ||
2497 | path->dentry = dentry; | ||
2498 | path->mnt = nd->path.mnt; | ||
2499 | return 1; | ||
2500 | |||
2501 | out_dput: | ||
2502 | dput(dentry); | ||
2503 | return error; | ||
2504 | } | ||
2505 | |||
2506 | /* | ||
2507 | * Handle the last step of open() | ||
2508 | */ | ||
2509 | static int do_last(struct nameidata *nd, struct path *path, | ||
2510 | struct file *file, const struct open_flags *op, | ||
2511 | int *opened, const char *pathname) | ||
2512 | { | ||
2513 | struct dentry *dir = nd->path.dentry; | ||
2198 | int open_flag = op->open_flag; | 2514 | int open_flag = op->open_flag; |
2199 | int will_truncate = open_flag & O_TRUNC; | 2515 | bool will_truncate = (open_flag & O_TRUNC) != 0; |
2200 | int want_write = 0; | 2516 | bool want_write = false; |
2201 | int acc_mode = op->acc_mode; | 2517 | int acc_mode = op->acc_mode; |
2202 | struct file *filp; | ||
2203 | struct inode *inode; | 2518 | struct inode *inode; |
2204 | int symlink_ok = 0; | 2519 | bool symlink_ok = false; |
2205 | struct path save_parent = { .dentry = NULL, .mnt = NULL }; | 2520 | struct path save_parent = { .dentry = NULL, .mnt = NULL }; |
2206 | bool retried = false; | 2521 | bool retried = false; |
2207 | int error; | 2522 | int error; |
@@ -2214,112 +2529,99 @@ static struct file *do_last(struct nameidata *nd, struct path *path, | |||
2214 | case LAST_DOT: | 2529 | case LAST_DOT: |
2215 | error = handle_dots(nd, nd->last_type); | 2530 | error = handle_dots(nd, nd->last_type); |
2216 | if (error) | 2531 | if (error) |
2217 | return ERR_PTR(error); | 2532 | return error; |
2218 | /* fallthrough */ | 2533 | /* fallthrough */ |
2219 | case LAST_ROOT: | 2534 | case LAST_ROOT: |
2220 | error = complete_walk(nd); | 2535 | error = complete_walk(nd); |
2221 | if (error) | 2536 | if (error) |
2222 | return ERR_PTR(error); | 2537 | return error; |
2223 | audit_inode(pathname, nd->path.dentry); | 2538 | audit_inode(pathname, nd->path.dentry); |
2224 | if (open_flag & O_CREAT) { | 2539 | if (open_flag & O_CREAT) { |
2225 | error = -EISDIR; | 2540 | error = -EISDIR; |
2226 | goto exit; | 2541 | goto out; |
2227 | } | 2542 | } |
2228 | goto ok; | 2543 | goto finish_open; |
2229 | case LAST_BIND: | 2544 | case LAST_BIND: |
2230 | error = complete_walk(nd); | 2545 | error = complete_walk(nd); |
2231 | if (error) | 2546 | if (error) |
2232 | return ERR_PTR(error); | 2547 | return error; |
2233 | audit_inode(pathname, dir); | 2548 | audit_inode(pathname, dir); |
2234 | goto ok; | 2549 | goto finish_open; |
2235 | } | 2550 | } |
2236 | 2551 | ||
2237 | if (!(open_flag & O_CREAT)) { | 2552 | if (!(open_flag & O_CREAT)) { |
2238 | if (nd->last.name[nd->last.len]) | 2553 | if (nd->last.name[nd->last.len]) |
2239 | nd->flags |= LOOKUP_FOLLOW | LOOKUP_DIRECTORY; | 2554 | nd->flags |= LOOKUP_FOLLOW | LOOKUP_DIRECTORY; |
2240 | if (open_flag & O_PATH && !(nd->flags & LOOKUP_FOLLOW)) | 2555 | if (open_flag & O_PATH && !(nd->flags & LOOKUP_FOLLOW)) |
2241 | symlink_ok = 1; | 2556 | symlink_ok = true; |
2242 | /* we _can_ be in RCU mode here */ | 2557 | /* we _can_ be in RCU mode here */ |
2243 | error = lookup_fast(nd, &nd->last, path, &inode); | 2558 | error = lookup_fast(nd, &nd->last, path, &inode); |
2244 | if (unlikely(error)) { | 2559 | if (likely(!error)) |
2245 | if (error < 0) | 2560 | goto finish_lookup; |
2246 | goto exit; | ||
2247 | 2561 | ||
2248 | error = lookup_slow(nd, &nd->last, path); | 2562 | if (error < 0) |
2249 | if (error < 0) | 2563 | goto out; |
2250 | goto exit; | ||
2251 | 2564 | ||
2252 | inode = path->dentry->d_inode; | 2565 | BUG_ON(nd->inode != dir->d_inode); |
2253 | } | 2566 | } else { |
2254 | goto finish_lookup; | 2567 | /* create side of things */ |
2255 | } | 2568 | /* |
2256 | 2569 | * This will *only* deal with leaving RCU mode - LOOKUP_JUMPED | |
2257 | /* create side of things */ | 2570 | * has been cleared when we got to the last component we are |
2258 | /* | 2571 | * about to look up |
2259 | * This will *only* deal with leaving RCU mode - LOOKUP_JUMPED has been | 2572 | */ |
2260 | * cleared when we got to the last component we are about to look up | 2573 | error = complete_walk(nd); |
2261 | */ | 2574 | if (error) |
2262 | error = complete_walk(nd); | 2575 | return error; |
2263 | if (error) | ||
2264 | return ERR_PTR(error); | ||
2265 | 2576 | ||
2266 | audit_inode(pathname, dir); | 2577 | audit_inode(pathname, dir); |
2267 | error = -EISDIR; | 2578 | error = -EISDIR; |
2268 | /* trailing slashes? */ | 2579 | /* trailing slashes? */ |
2269 | if (nd->last.name[nd->last.len]) | 2580 | if (nd->last.name[nd->last.len]) |
2270 | goto exit; | 2581 | goto out; |
2582 | } | ||
2271 | 2583 | ||
2272 | retry_lookup: | 2584 | retry_lookup: |
2273 | mutex_lock(&dir->d_inode->i_mutex); | 2585 | mutex_lock(&dir->d_inode->i_mutex); |
2586 | error = lookup_open(nd, path, file, op, &want_write, opened); | ||
2587 | mutex_unlock(&dir->d_inode->i_mutex); | ||
2274 | 2588 | ||
2275 | dentry = lookup_hash(nd); | 2589 | if (error <= 0) { |
2276 | error = PTR_ERR(dentry); | 2590 | if (error) |
2277 | if (IS_ERR(dentry)) { | 2591 | goto out; |
2278 | mutex_unlock(&dir->d_inode->i_mutex); | ||
2279 | goto exit; | ||
2280 | } | ||
2281 | 2592 | ||
2282 | path->dentry = dentry; | 2593 | if ((*opened & FILE_CREATED) || |
2283 | path->mnt = nd->path.mnt; | 2594 | !S_ISREG(file->f_path.dentry->d_inode->i_mode)) |
2595 | will_truncate = false; | ||
2284 | 2596 | ||
2285 | /* Negative dentry, just create the file */ | 2597 | audit_inode(pathname, file->f_path.dentry); |
2286 | if (!dentry->d_inode) { | 2598 | goto opened; |
2287 | umode_t mode = op->mode; | 2599 | } |
2288 | if (!IS_POSIXACL(dir->d_inode)) | 2600 | |
2289 | mode &= ~current_umask(); | 2601 | if (*opened & FILE_CREATED) { |
2290 | /* | ||
2291 | * This write is needed to ensure that a | ||
2292 | * rw->ro transition does not occur between | ||
2293 | * the time when the file is created and when | ||
2294 | * a permanent write count is taken through | ||
2295 | * the 'struct file' in nameidata_to_filp(). | ||
2296 | */ | ||
2297 | error = mnt_want_write(nd->path.mnt); | ||
2298 | if (error) | ||
2299 | goto exit_mutex_unlock; | ||
2300 | want_write = 1; | ||
2301 | /* Don't check for write permission, don't truncate */ | 2602 | /* Don't check for write permission, don't truncate */ |
2302 | open_flag &= ~O_TRUNC; | 2603 | open_flag &= ~O_TRUNC; |
2303 | will_truncate = 0; | 2604 | will_truncate = false; |
2304 | acc_mode = MAY_OPEN; | 2605 | acc_mode = MAY_OPEN; |
2305 | error = security_path_mknod(&nd->path, dentry, mode, 0); | 2606 | path_to_nameidata(path, nd); |
2306 | if (error) | 2607 | goto finish_open_created; |
2307 | goto exit_mutex_unlock; | ||
2308 | error = vfs_create(dir->d_inode, dentry, mode, nd); | ||
2309 | if (error) | ||
2310 | goto exit_mutex_unlock; | ||
2311 | mutex_unlock(&dir->d_inode->i_mutex); | ||
2312 | dput(nd->path.dentry); | ||
2313 | nd->path.dentry = dentry; | ||
2314 | goto common; | ||
2315 | } | 2608 | } |
2316 | 2609 | ||
2317 | /* | 2610 | /* |
2318 | * It already exists. | 2611 | * It already exists. |
2319 | */ | 2612 | */ |
2320 | mutex_unlock(&dir->d_inode->i_mutex); | ||
2321 | audit_inode(pathname, path->dentry); | 2613 | audit_inode(pathname, path->dentry); |
2322 | 2614 | ||
2615 | /* | ||
2616 | * If atomic_open() acquired write access it is dropped now due to | ||
2617 | * possible mount and symlink following (this might be optimized away if | ||
2618 | * necessary...) | ||
2619 | */ | ||
2620 | if (want_write) { | ||
2621 | mnt_drop_write(nd->path.mnt); | ||
2622 | want_write = false; | ||
2623 | } | ||
2624 | |||
2323 | error = -EEXIST; | 2625 | error = -EEXIST; |
2324 | if (open_flag & O_EXCL) | 2626 | if (open_flag & O_EXCL) |
2325 | goto exit_dput; | 2627 | goto exit_dput; |
@@ -2338,18 +2640,18 @@ finish_lookup: | |||
2338 | error = -ENOENT; | 2640 | error = -ENOENT; |
2339 | if (!inode) { | 2641 | if (!inode) { |
2340 | path_to_nameidata(path, nd); | 2642 | path_to_nameidata(path, nd); |
2341 | goto exit; | 2643 | goto out; |
2342 | } | 2644 | } |
2343 | 2645 | ||
2344 | if (should_follow_link(inode, !symlink_ok)) { | 2646 | if (should_follow_link(inode, !symlink_ok)) { |
2345 | if (nd->flags & LOOKUP_RCU) { | 2647 | if (nd->flags & LOOKUP_RCU) { |
2346 | if (unlikely(unlazy_walk(nd, path->dentry))) { | 2648 | if (unlikely(unlazy_walk(nd, path->dentry))) { |
2347 | error = -ECHILD; | 2649 | error = -ECHILD; |
2348 | goto exit; | 2650 | goto out; |
2349 | } | 2651 | } |
2350 | } | 2652 | } |
2351 | BUG_ON(inode != path->dentry->d_inode); | 2653 | BUG_ON(inode != path->dentry->d_inode); |
2352 | return NULL; | 2654 | return 1; |
2353 | } | 2655 | } |
2354 | 2656 | ||
2355 | if ((nd->flags & LOOKUP_RCU) || nd->path.mnt != path->mnt) { | 2657 | if ((nd->flags & LOOKUP_RCU) || nd->path.mnt != path->mnt) { |
@@ -2365,119 +2667,122 @@ finish_lookup: | |||
2365 | error = complete_walk(nd); | 2667 | error = complete_walk(nd); |
2366 | if (error) { | 2668 | if (error) { |
2367 | path_put(&save_parent); | 2669 | path_put(&save_parent); |
2368 | return ERR_PTR(error); | 2670 | return error; |
2369 | } | 2671 | } |
2370 | error = -EISDIR; | 2672 | error = -EISDIR; |
2371 | if ((open_flag & O_CREAT) && S_ISDIR(nd->inode->i_mode)) | 2673 | if ((open_flag & O_CREAT) && S_ISDIR(nd->inode->i_mode)) |
2372 | goto exit; | 2674 | goto out; |
2373 | error = -ENOTDIR; | 2675 | error = -ENOTDIR; |
2374 | if ((nd->flags & LOOKUP_DIRECTORY) && !nd->inode->i_op->lookup) | 2676 | if ((nd->flags & LOOKUP_DIRECTORY) && !nd->inode->i_op->lookup) |
2375 | goto exit; | 2677 | goto out; |
2376 | audit_inode(pathname, nd->path.dentry); | 2678 | audit_inode(pathname, nd->path.dentry); |
2377 | ok: | 2679 | finish_open: |
2378 | if (!S_ISREG(nd->inode->i_mode)) | 2680 | if (!S_ISREG(nd->inode->i_mode)) |
2379 | will_truncate = 0; | 2681 | will_truncate = false; |
2380 | 2682 | ||
2381 | if (will_truncate) { | 2683 | if (will_truncate) { |
2382 | error = mnt_want_write(nd->path.mnt); | 2684 | error = mnt_want_write(nd->path.mnt); |
2383 | if (error) | 2685 | if (error) |
2384 | goto exit; | 2686 | goto out; |
2385 | want_write = 1; | 2687 | want_write = true; |
2386 | } | 2688 | } |
2387 | common: | 2689 | finish_open_created: |
2388 | error = may_open(&nd->path, acc_mode, open_flag); | 2690 | error = may_open(&nd->path, acc_mode, open_flag); |
2389 | if (error) | 2691 | if (error) |
2390 | goto exit; | 2692 | goto out; |
2391 | filp = nameidata_to_filp(nd); | 2693 | file->f_path.mnt = nd->path.mnt; |
2392 | if (filp == ERR_PTR(-EOPENSTALE) && save_parent.dentry && !retried) { | 2694 | error = finish_open(file, nd->path.dentry, NULL, opened); |
2393 | BUG_ON(save_parent.dentry != dir); | 2695 | if (error) { |
2394 | path_put(&nd->path); | 2696 | if (error == -EOPENSTALE) |
2395 | nd->path = save_parent; | 2697 | goto stale_open; |
2396 | nd->inode = dir->d_inode; | 2698 | goto out; |
2397 | save_parent.mnt = NULL; | ||
2398 | save_parent.dentry = NULL; | ||
2399 | if (want_write) { | ||
2400 | mnt_drop_write(nd->path.mnt); | ||
2401 | want_write = 0; | ||
2402 | } | ||
2403 | retried = true; | ||
2404 | goto retry_lookup; | ||
2405 | } | ||
2406 | if (!IS_ERR(filp)) { | ||
2407 | error = ima_file_check(filp, op->acc_mode); | ||
2408 | if (error) { | ||
2409 | fput(filp); | ||
2410 | filp = ERR_PTR(error); | ||
2411 | } | ||
2412 | } | 2699 | } |
2413 | if (!IS_ERR(filp)) { | 2700 | opened: |
2414 | if (will_truncate) { | 2701 | error = open_check_o_direct(file); |
2415 | error = handle_truncate(filp); | 2702 | if (error) |
2416 | if (error) { | 2703 | goto exit_fput; |
2417 | fput(filp); | 2704 | error = ima_file_check(file, op->acc_mode); |
2418 | filp = ERR_PTR(error); | 2705 | if (error) |
2419 | } | 2706 | goto exit_fput; |
2420 | } | 2707 | |
2708 | if (will_truncate) { | ||
2709 | error = handle_truncate(file); | ||
2710 | if (error) | ||
2711 | goto exit_fput; | ||
2421 | } | 2712 | } |
2422 | out: | 2713 | out: |
2423 | if (want_write) | 2714 | if (want_write) |
2424 | mnt_drop_write(nd->path.mnt); | 2715 | mnt_drop_write(nd->path.mnt); |
2425 | path_put(&save_parent); | 2716 | path_put(&save_parent); |
2426 | terminate_walk(nd); | 2717 | terminate_walk(nd); |
2427 | return filp; | 2718 | return error; |
2428 | 2719 | ||
2429 | exit_mutex_unlock: | ||
2430 | mutex_unlock(&dir->d_inode->i_mutex); | ||
2431 | exit_dput: | 2720 | exit_dput: |
2432 | path_put_conditional(path, nd); | 2721 | path_put_conditional(path, nd); |
2433 | exit: | ||
2434 | filp = ERR_PTR(error); | ||
2435 | goto out; | 2722 | goto out; |
2723 | exit_fput: | ||
2724 | fput(file); | ||
2725 | goto out; | ||
2726 | |||
2727 | stale_open: | ||
2728 | /* If no saved parent or already retried then can't retry */ | ||
2729 | if (!save_parent.dentry || retried) | ||
2730 | goto out; | ||
2731 | |||
2732 | BUG_ON(save_parent.dentry != dir); | ||
2733 | path_put(&nd->path); | ||
2734 | nd->path = save_parent; | ||
2735 | nd->inode = dir->d_inode; | ||
2736 | save_parent.mnt = NULL; | ||
2737 | save_parent.dentry = NULL; | ||
2738 | if (want_write) { | ||
2739 | mnt_drop_write(nd->path.mnt); | ||
2740 | want_write = false; | ||
2741 | } | ||
2742 | retried = true; | ||
2743 | goto retry_lookup; | ||
2436 | } | 2744 | } |
2437 | 2745 | ||
2438 | static struct file *path_openat(int dfd, const char *pathname, | 2746 | static struct file *path_openat(int dfd, const char *pathname, |
2439 | struct nameidata *nd, const struct open_flags *op, int flags) | 2747 | struct nameidata *nd, const struct open_flags *op, int flags) |
2440 | { | 2748 | { |
2441 | struct file *base = NULL; | 2749 | struct file *base = NULL; |
2442 | struct file *filp; | 2750 | struct file *file; |
2443 | struct path path; | 2751 | struct path path; |
2752 | int opened = 0; | ||
2444 | int error; | 2753 | int error; |
2445 | 2754 | ||
2446 | filp = get_empty_filp(); | 2755 | file = get_empty_filp(); |
2447 | if (!filp) | 2756 | if (!file) |
2448 | return ERR_PTR(-ENFILE); | 2757 | return ERR_PTR(-ENFILE); |
2449 | 2758 | ||
2450 | filp->f_flags = op->open_flag; | 2759 | file->f_flags = op->open_flag; |
2451 | nd->intent.open.file = filp; | ||
2452 | nd->intent.open.flags = open_to_namei_flags(op->open_flag); | ||
2453 | nd->intent.open.create_mode = op->mode; | ||
2454 | 2760 | ||
2455 | error = path_init(dfd, pathname, flags | LOOKUP_PARENT, nd, &base); | 2761 | error = path_init(dfd, pathname, flags | LOOKUP_PARENT, nd, &base); |
2456 | if (unlikely(error)) | 2762 | if (unlikely(error)) |
2457 | goto out_filp; | 2763 | goto out; |
2458 | 2764 | ||
2459 | current->total_link_count = 0; | 2765 | current->total_link_count = 0; |
2460 | error = link_path_walk(pathname, nd); | 2766 | error = link_path_walk(pathname, nd); |
2461 | if (unlikely(error)) | 2767 | if (unlikely(error)) |
2462 | goto out_filp; | 2768 | goto out; |
2463 | 2769 | ||
2464 | filp = do_last(nd, &path, op, pathname); | 2770 | error = do_last(nd, &path, file, op, &opened, pathname); |
2465 | while (unlikely(!filp)) { /* trailing symlink */ | 2771 | while (unlikely(error > 0)) { /* trailing symlink */ |
2466 | struct path link = path; | 2772 | struct path link = path; |
2467 | void *cookie; | 2773 | void *cookie; |
2468 | if (!(nd->flags & LOOKUP_FOLLOW)) { | 2774 | if (!(nd->flags & LOOKUP_FOLLOW)) { |
2469 | path_put_conditional(&path, nd); | 2775 | path_put_conditional(&path, nd); |
2470 | path_put(&nd->path); | 2776 | path_put(&nd->path); |
2471 | filp = ERR_PTR(-ELOOP); | 2777 | error = -ELOOP; |
2472 | break; | 2778 | break; |
2473 | } | 2779 | } |
2474 | nd->flags |= LOOKUP_PARENT; | 2780 | nd->flags |= LOOKUP_PARENT; |
2475 | nd->flags &= ~(LOOKUP_OPEN|LOOKUP_CREATE|LOOKUP_EXCL); | 2781 | nd->flags &= ~(LOOKUP_OPEN|LOOKUP_CREATE|LOOKUP_EXCL); |
2476 | error = follow_link(&link, nd, &cookie); | 2782 | error = follow_link(&link, nd, &cookie); |
2477 | if (unlikely(error)) | 2783 | if (unlikely(error)) |
2478 | filp = ERR_PTR(error); | 2784 | break; |
2479 | else | 2785 | error = do_last(nd, &path, file, op, &opened, pathname); |
2480 | filp = do_last(nd, &path, op, pathname); | ||
2481 | put_link(nd, &link, cookie); | 2786 | put_link(nd, &link, cookie); |
2482 | } | 2787 | } |
2483 | out: | 2788 | out: |
@@ -2485,18 +2790,20 @@ out: | |||
2485 | path_put(&nd->root); | 2790 | path_put(&nd->root); |
2486 | if (base) | 2791 | if (base) |
2487 | fput(base); | 2792 | fput(base); |
2488 | release_open_intent(nd); | 2793 | if (!(opened & FILE_OPENED)) { |
2489 | if (filp == ERR_PTR(-EOPENSTALE)) { | 2794 | BUG_ON(!error); |
2490 | if (flags & LOOKUP_RCU) | 2795 | put_filp(file); |
2491 | filp = ERR_PTR(-ECHILD); | ||
2492 | else | ||
2493 | filp = ERR_PTR(-ESTALE); | ||
2494 | } | 2796 | } |
2495 | return filp; | 2797 | if (unlikely(error)) { |
2496 | 2798 | if (error == -EOPENSTALE) { | |
2497 | out_filp: | 2799 | if (flags & LOOKUP_RCU) |
2498 | filp = ERR_PTR(error); | 2800 | error = -ECHILD; |
2499 | goto out; | 2801 | else |
2802 | error = -ESTALE; | ||
2803 | } | ||
2804 | file = ERR_PTR(error); | ||
2805 | } | ||
2806 | return file; | ||
2500 | } | 2807 | } |
2501 | 2808 | ||
2502 | struct file *do_filp_open(int dfd, const char *pathname, | 2809 | struct file *do_filp_open(int dfd, const char *pathname, |
@@ -2551,7 +2858,6 @@ struct dentry *kern_path_create(int dfd, const char *pathname, struct path *path | |||
2551 | goto out; | 2858 | goto out; |
2552 | nd.flags &= ~LOOKUP_PARENT; | 2859 | nd.flags &= ~LOOKUP_PARENT; |
2553 | nd.flags |= LOOKUP_CREATE | LOOKUP_EXCL; | 2860 | nd.flags |= LOOKUP_CREATE | LOOKUP_EXCL; |
2554 | nd.intent.open.flags = O_EXCL; | ||
2555 | 2861 | ||
2556 | /* | 2862 | /* |
2557 | * Do the final lookup. | 2863 | * Do the final lookup. |
@@ -2670,7 +2976,7 @@ SYSCALL_DEFINE4(mknodat, int, dfd, const char __user *, filename, umode_t, mode, | |||
2670 | goto out_drop_write; | 2976 | goto out_drop_write; |
2671 | switch (mode & S_IFMT) { | 2977 | switch (mode & S_IFMT) { |
2672 | case 0: case S_IFREG: | 2978 | case 0: case S_IFREG: |
2673 | error = vfs_create(path.dentry->d_inode,dentry,mode,NULL); | 2979 | error = vfs_create(path.dentry->d_inode,dentry,mode,true); |
2674 | break; | 2980 | break; |
2675 | case S_IFCHR: case S_IFBLK: | 2981 | case S_IFCHR: case S_IFBLK: |
2676 | error = vfs_mknod(path.dentry->d_inode,dentry,mode, | 2982 | error = vfs_mknod(path.dentry->d_inode,dentry,mode, |
diff --git a/fs/namespace.c b/fs/namespace.c index 1e4a5fe3d7b7..c53d3381b0d0 100644 --- a/fs/namespace.c +++ b/fs/namespace.c | |||
@@ -515,8 +515,20 @@ struct mount *__lookup_mnt(struct vfsmount *mnt, struct dentry *dentry, | |||
515 | } | 515 | } |
516 | 516 | ||
517 | /* | 517 | /* |
518 | * lookup_mnt increments the ref count before returning | 518 | * lookup_mnt - Return the first child mount mounted at path |
519 | * the vfsmount struct. | 519 | * |
520 | * "First" means first mounted chronologically. If you create the | ||
521 | * following mounts: | ||
522 | * | ||
523 | * mount /dev/sda1 /mnt | ||
524 | * mount /dev/sda2 /mnt | ||
525 | * mount /dev/sda3 /mnt | ||
526 | * | ||
527 | * Then lookup_mnt() on the base /mnt dentry in the root mount will | ||
528 | * return successively the root dentry and vfsmount of /dev/sda1, then | ||
529 | * /dev/sda2, then /dev/sda3, then NULL. | ||
530 | * | ||
531 | * lookup_mnt takes a reference to the found vfsmount. | ||
520 | */ | 532 | */ |
521 | struct vfsmount *lookup_mnt(struct path *path) | 533 | struct vfsmount *lookup_mnt(struct path *path) |
522 | { | 534 | { |
@@ -621,21 +633,6 @@ static void attach_mnt(struct mount *mnt, struct path *path) | |||
621 | list_add_tail(&mnt->mnt_child, &real_mount(path->mnt)->mnt_mounts); | 633 | list_add_tail(&mnt->mnt_child, &real_mount(path->mnt)->mnt_mounts); |
622 | } | 634 | } |
623 | 635 | ||
624 | static inline void __mnt_make_longterm(struct mount *mnt) | ||
625 | { | ||
626 | #ifdef CONFIG_SMP | ||
627 | atomic_inc(&mnt->mnt_longterm); | ||
628 | #endif | ||
629 | } | ||
630 | |||
631 | /* needs vfsmount lock for write */ | ||
632 | static inline void __mnt_make_shortterm(struct mount *mnt) | ||
633 | { | ||
634 | #ifdef CONFIG_SMP | ||
635 | atomic_dec(&mnt->mnt_longterm); | ||
636 | #endif | ||
637 | } | ||
638 | |||
639 | /* | 636 | /* |
640 | * vfsmount lock must be held for write | 637 | * vfsmount lock must be held for write |
641 | */ | 638 | */ |
@@ -649,10 +646,8 @@ static void commit_tree(struct mount *mnt) | |||
649 | BUG_ON(parent == mnt); | 646 | BUG_ON(parent == mnt); |
650 | 647 | ||
651 | list_add_tail(&head, &mnt->mnt_list); | 648 | list_add_tail(&head, &mnt->mnt_list); |
652 | list_for_each_entry(m, &head, mnt_list) { | 649 | list_for_each_entry(m, &head, mnt_list) |
653 | m->mnt_ns = n; | 650 | m->mnt_ns = n; |
654 | __mnt_make_longterm(m); | ||
655 | } | ||
656 | 651 | ||
657 | list_splice(&head, n->list.prev); | 652 | list_splice(&head, n->list.prev); |
658 | 653 | ||
@@ -725,56 +720,60 @@ static struct mount *clone_mnt(struct mount *old, struct dentry *root, | |||
725 | int flag) | 720 | int flag) |
726 | { | 721 | { |
727 | struct super_block *sb = old->mnt.mnt_sb; | 722 | struct super_block *sb = old->mnt.mnt_sb; |
728 | struct mount *mnt = alloc_vfsmnt(old->mnt_devname); | 723 | struct mount *mnt; |
724 | int err; | ||
729 | 725 | ||
730 | if (mnt) { | 726 | mnt = alloc_vfsmnt(old->mnt_devname); |
731 | if (flag & (CL_SLAVE | CL_PRIVATE)) | 727 | if (!mnt) |
732 | mnt->mnt_group_id = 0; /* not a peer of original */ | 728 | return ERR_PTR(-ENOMEM); |
733 | else | ||
734 | mnt->mnt_group_id = old->mnt_group_id; | ||
735 | |||
736 | if ((flag & CL_MAKE_SHARED) && !mnt->mnt_group_id) { | ||
737 | int err = mnt_alloc_group_id(mnt); | ||
738 | if (err) | ||
739 | goto out_free; | ||
740 | } | ||
741 | 729 | ||
742 | mnt->mnt.mnt_flags = old->mnt.mnt_flags & ~MNT_WRITE_HOLD; | 730 | if (flag & (CL_SLAVE | CL_PRIVATE)) |
743 | atomic_inc(&sb->s_active); | 731 | mnt->mnt_group_id = 0; /* not a peer of original */ |
744 | mnt->mnt.mnt_sb = sb; | 732 | else |
745 | mnt->mnt.mnt_root = dget(root); | 733 | mnt->mnt_group_id = old->mnt_group_id; |
746 | mnt->mnt_mountpoint = mnt->mnt.mnt_root; | ||
747 | mnt->mnt_parent = mnt; | ||
748 | br_write_lock(&vfsmount_lock); | ||
749 | list_add_tail(&mnt->mnt_instance, &sb->s_mounts); | ||
750 | br_write_unlock(&vfsmount_lock); | ||
751 | 734 | ||
752 | if (flag & CL_SLAVE) { | 735 | if ((flag & CL_MAKE_SHARED) && !mnt->mnt_group_id) { |
753 | list_add(&mnt->mnt_slave, &old->mnt_slave_list); | 736 | err = mnt_alloc_group_id(mnt); |
754 | mnt->mnt_master = old; | 737 | if (err) |
755 | CLEAR_MNT_SHARED(mnt); | 738 | goto out_free; |
756 | } else if (!(flag & CL_PRIVATE)) { | ||
757 | if ((flag & CL_MAKE_SHARED) || IS_MNT_SHARED(old)) | ||
758 | list_add(&mnt->mnt_share, &old->mnt_share); | ||
759 | if (IS_MNT_SLAVE(old)) | ||
760 | list_add(&mnt->mnt_slave, &old->mnt_slave); | ||
761 | mnt->mnt_master = old->mnt_master; | ||
762 | } | ||
763 | if (flag & CL_MAKE_SHARED) | ||
764 | set_mnt_shared(mnt); | ||
765 | |||
766 | /* stick the duplicate mount on the same expiry list | ||
767 | * as the original if that was on one */ | ||
768 | if (flag & CL_EXPIRE) { | ||
769 | if (!list_empty(&old->mnt_expire)) | ||
770 | list_add(&mnt->mnt_expire, &old->mnt_expire); | ||
771 | } | ||
772 | } | 739 | } |
740 | |||
741 | mnt->mnt.mnt_flags = old->mnt.mnt_flags & ~MNT_WRITE_HOLD; | ||
742 | atomic_inc(&sb->s_active); | ||
743 | mnt->mnt.mnt_sb = sb; | ||
744 | mnt->mnt.mnt_root = dget(root); | ||
745 | mnt->mnt_mountpoint = mnt->mnt.mnt_root; | ||
746 | mnt->mnt_parent = mnt; | ||
747 | br_write_lock(&vfsmount_lock); | ||
748 | list_add_tail(&mnt->mnt_instance, &sb->s_mounts); | ||
749 | br_write_unlock(&vfsmount_lock); | ||
750 | |||
751 | if (flag & CL_SLAVE) { | ||
752 | list_add(&mnt->mnt_slave, &old->mnt_slave_list); | ||
753 | mnt->mnt_master = old; | ||
754 | CLEAR_MNT_SHARED(mnt); | ||
755 | } else if (!(flag & CL_PRIVATE)) { | ||
756 | if ((flag & CL_MAKE_SHARED) || IS_MNT_SHARED(old)) | ||
757 | list_add(&mnt->mnt_share, &old->mnt_share); | ||
758 | if (IS_MNT_SLAVE(old)) | ||
759 | list_add(&mnt->mnt_slave, &old->mnt_slave); | ||
760 | mnt->mnt_master = old->mnt_master; | ||
761 | } | ||
762 | if (flag & CL_MAKE_SHARED) | ||
763 | set_mnt_shared(mnt); | ||
764 | |||
765 | /* stick the duplicate mount on the same expiry list | ||
766 | * as the original if that was on one */ | ||
767 | if (flag & CL_EXPIRE) { | ||
768 | if (!list_empty(&old->mnt_expire)) | ||
769 | list_add(&mnt->mnt_expire, &old->mnt_expire); | ||
770 | } | ||
771 | |||
773 | return mnt; | 772 | return mnt; |
774 | 773 | ||
775 | out_free: | 774 | out_free: |
776 | free_vfsmnt(mnt); | 775 | free_vfsmnt(mnt); |
777 | return NULL; | 776 | return ERR_PTR(err); |
778 | } | 777 | } |
779 | 778 | ||
780 | static inline void mntfree(struct mount *mnt) | 779 | static inline void mntfree(struct mount *mnt) |
@@ -804,7 +803,8 @@ static void mntput_no_expire(struct mount *mnt) | |||
804 | put_again: | 803 | put_again: |
805 | #ifdef CONFIG_SMP | 804 | #ifdef CONFIG_SMP |
806 | br_read_lock(&vfsmount_lock); | 805 | br_read_lock(&vfsmount_lock); |
807 | if (likely(atomic_read(&mnt->mnt_longterm))) { | 806 | if (likely(mnt->mnt_ns)) { |
807 | /* shouldn't be the last one */ | ||
808 | mnt_add_count(mnt, -1); | 808 | mnt_add_count(mnt, -1); |
809 | br_read_unlock(&vfsmount_lock); | 809 | br_read_unlock(&vfsmount_lock); |
810 | return; | 810 | return; |
@@ -939,7 +939,7 @@ EXPORT_SYMBOL(replace_mount_options); | |||
939 | /* iterator; we want it to have access to namespace_sem, thus here... */ | 939 | /* iterator; we want it to have access to namespace_sem, thus here... */ |
940 | static void *m_start(struct seq_file *m, loff_t *pos) | 940 | static void *m_start(struct seq_file *m, loff_t *pos) |
941 | { | 941 | { |
942 | struct proc_mounts *p = container_of(m, struct proc_mounts, m); | 942 | struct proc_mounts *p = proc_mounts(m); |
943 | 943 | ||
944 | down_read(&namespace_sem); | 944 | down_read(&namespace_sem); |
945 | return seq_list_start(&p->ns->list, *pos); | 945 | return seq_list_start(&p->ns->list, *pos); |
@@ -947,7 +947,7 @@ static void *m_start(struct seq_file *m, loff_t *pos) | |||
947 | 947 | ||
948 | static void *m_next(struct seq_file *m, void *v, loff_t *pos) | 948 | static void *m_next(struct seq_file *m, void *v, loff_t *pos) |
949 | { | 949 | { |
950 | struct proc_mounts *p = container_of(m, struct proc_mounts, m); | 950 | struct proc_mounts *p = proc_mounts(m); |
951 | 951 | ||
952 | return seq_list_next(v, &p->ns->list, pos); | 952 | return seq_list_next(v, &p->ns->list, pos); |
953 | } | 953 | } |
@@ -959,7 +959,7 @@ static void m_stop(struct seq_file *m, void *v) | |||
959 | 959 | ||
960 | static int m_show(struct seq_file *m, void *v) | 960 | static int m_show(struct seq_file *m, void *v) |
961 | { | 961 | { |
962 | struct proc_mounts *p = container_of(m, struct proc_mounts, m); | 962 | struct proc_mounts *p = proc_mounts(m); |
963 | struct mount *r = list_entry(v, struct mount, mnt_list); | 963 | struct mount *r = list_entry(v, struct mount, mnt_list); |
964 | return p->show(m, &r->mnt); | 964 | return p->show(m, &r->mnt); |
965 | } | 965 | } |
@@ -1074,8 +1074,6 @@ void umount_tree(struct mount *mnt, int propagate, struct list_head *kill) | |||
1074 | list_del_init(&p->mnt_expire); | 1074 | list_del_init(&p->mnt_expire); |
1075 | list_del_init(&p->mnt_list); | 1075 | list_del_init(&p->mnt_list); |
1076 | __touch_mnt_namespace(p->mnt_ns); | 1076 | __touch_mnt_namespace(p->mnt_ns); |
1077 | if (p->mnt_ns) | ||
1078 | __mnt_make_shortterm(p); | ||
1079 | p->mnt_ns = NULL; | 1077 | p->mnt_ns = NULL; |
1080 | list_del_init(&p->mnt_child); | 1078 | list_del_init(&p->mnt_child); |
1081 | if (mnt_has_parent(p)) { | 1079 | if (mnt_has_parent(p)) { |
@@ -1260,11 +1258,12 @@ struct mount *copy_tree(struct mount *mnt, struct dentry *dentry, | |||
1260 | struct path path; | 1258 | struct path path; |
1261 | 1259 | ||
1262 | if (!(flag & CL_COPY_ALL) && IS_MNT_UNBINDABLE(mnt)) | 1260 | if (!(flag & CL_COPY_ALL) && IS_MNT_UNBINDABLE(mnt)) |
1263 | return NULL; | 1261 | return ERR_PTR(-EINVAL); |
1264 | 1262 | ||
1265 | res = q = clone_mnt(mnt, dentry, flag); | 1263 | res = q = clone_mnt(mnt, dentry, flag); |
1266 | if (!q) | 1264 | if (IS_ERR(q)) |
1267 | goto Enomem; | 1265 | return q; |
1266 | |||
1268 | q->mnt_mountpoint = mnt->mnt_mountpoint; | 1267 | q->mnt_mountpoint = mnt->mnt_mountpoint; |
1269 | 1268 | ||
1270 | p = mnt; | 1269 | p = mnt; |
@@ -1286,8 +1285,8 @@ struct mount *copy_tree(struct mount *mnt, struct dentry *dentry, | |||
1286 | path.mnt = &q->mnt; | 1285 | path.mnt = &q->mnt; |
1287 | path.dentry = p->mnt_mountpoint; | 1286 | path.dentry = p->mnt_mountpoint; |
1288 | q = clone_mnt(p, p->mnt.mnt_root, flag); | 1287 | q = clone_mnt(p, p->mnt.mnt_root, flag); |
1289 | if (!q) | 1288 | if (IS_ERR(q)) |
1290 | goto Enomem; | 1289 | goto out; |
1291 | br_write_lock(&vfsmount_lock); | 1290 | br_write_lock(&vfsmount_lock); |
1292 | list_add_tail(&q->mnt_list, &res->mnt_list); | 1291 | list_add_tail(&q->mnt_list, &res->mnt_list); |
1293 | attach_mnt(q, &path); | 1292 | attach_mnt(q, &path); |
@@ -1295,7 +1294,7 @@ struct mount *copy_tree(struct mount *mnt, struct dentry *dentry, | |||
1295 | } | 1294 | } |
1296 | } | 1295 | } |
1297 | return res; | 1296 | return res; |
1298 | Enomem: | 1297 | out: |
1299 | if (res) { | 1298 | if (res) { |
1300 | LIST_HEAD(umount_list); | 1299 | LIST_HEAD(umount_list); |
1301 | br_write_lock(&vfsmount_lock); | 1300 | br_write_lock(&vfsmount_lock); |
@@ -1303,9 +1302,11 @@ Enomem: | |||
1303 | br_write_unlock(&vfsmount_lock); | 1302 | br_write_unlock(&vfsmount_lock); |
1304 | release_mounts(&umount_list); | 1303 | release_mounts(&umount_list); |
1305 | } | 1304 | } |
1306 | return NULL; | 1305 | return q; |
1307 | } | 1306 | } |
1308 | 1307 | ||
1308 | /* Caller should check returned pointer for errors */ | ||
1309 | |||
1309 | struct vfsmount *collect_mounts(struct path *path) | 1310 | struct vfsmount *collect_mounts(struct path *path) |
1310 | { | 1311 | { |
1311 | struct mount *tree; | 1312 | struct mount *tree; |
@@ -1313,7 +1314,9 @@ struct vfsmount *collect_mounts(struct path *path) | |||
1313 | tree = copy_tree(real_mount(path->mnt), path->dentry, | 1314 | tree = copy_tree(real_mount(path->mnt), path->dentry, |
1314 | CL_COPY_ALL | CL_PRIVATE); | 1315 | CL_COPY_ALL | CL_PRIVATE); |
1315 | up_write(&namespace_sem); | 1316 | up_write(&namespace_sem); |
1316 | return tree ? &tree->mnt : NULL; | 1317 | if (IS_ERR(tree)) |
1318 | return NULL; | ||
1319 | return &tree->mnt; | ||
1317 | } | 1320 | } |
1318 | 1321 | ||
1319 | void drop_collected_mounts(struct vfsmount *mnt) | 1322 | void drop_collected_mounts(struct vfsmount *mnt) |
@@ -1608,14 +1611,15 @@ static int do_loopback(struct path *path, char *old_name, | |||
1608 | if (!check_mnt(real_mount(path->mnt)) || !check_mnt(old)) | 1611 | if (!check_mnt(real_mount(path->mnt)) || !check_mnt(old)) |
1609 | goto out2; | 1612 | goto out2; |
1610 | 1613 | ||
1611 | err = -ENOMEM; | ||
1612 | if (recurse) | 1614 | if (recurse) |
1613 | mnt = copy_tree(old, old_path.dentry, 0); | 1615 | mnt = copy_tree(old, old_path.dentry, 0); |
1614 | else | 1616 | else |
1615 | mnt = clone_mnt(old, old_path.dentry, 0); | 1617 | mnt = clone_mnt(old, old_path.dentry, 0); |
1616 | 1618 | ||
1617 | if (!mnt) | 1619 | if (IS_ERR(mnt)) { |
1618 | goto out2; | 1620 | err = PTR_ERR(mnt); |
1621 | goto out; | ||
1622 | } | ||
1619 | 1623 | ||
1620 | err = graft_tree(mnt, path); | 1624 | err = graft_tree(mnt, path); |
1621 | if (err) { | 1625 | if (err) { |
@@ -2209,23 +2213,6 @@ static struct mnt_namespace *alloc_mnt_ns(void) | |||
2209 | return new_ns; | 2213 | return new_ns; |
2210 | } | 2214 | } |
2211 | 2215 | ||
2212 | void mnt_make_longterm(struct vfsmount *mnt) | ||
2213 | { | ||
2214 | __mnt_make_longterm(real_mount(mnt)); | ||
2215 | } | ||
2216 | |||
2217 | void mnt_make_shortterm(struct vfsmount *m) | ||
2218 | { | ||
2219 | #ifdef CONFIG_SMP | ||
2220 | struct mount *mnt = real_mount(m); | ||
2221 | if (atomic_add_unless(&mnt->mnt_longterm, -1, 1)) | ||
2222 | return; | ||
2223 | br_write_lock(&vfsmount_lock); | ||
2224 | atomic_dec(&mnt->mnt_longterm); | ||
2225 | br_write_unlock(&vfsmount_lock); | ||
2226 | #endif | ||
2227 | } | ||
2228 | |||
2229 | /* | 2216 | /* |
2230 | * Allocate a new namespace structure and populate it with contents | 2217 | * Allocate a new namespace structure and populate it with contents |
2231 | * copied from the namespace of the passed in task structure. | 2218 | * copied from the namespace of the passed in task structure. |
@@ -2246,10 +2233,10 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns, | |||
2246 | down_write(&namespace_sem); | 2233 | down_write(&namespace_sem); |
2247 | /* First pass: copy the tree topology */ | 2234 | /* First pass: copy the tree topology */ |
2248 | new = copy_tree(old, old->mnt.mnt_root, CL_COPY_ALL | CL_EXPIRE); | 2235 | new = copy_tree(old, old->mnt.mnt_root, CL_COPY_ALL | CL_EXPIRE); |
2249 | if (!new) { | 2236 | if (IS_ERR(new)) { |
2250 | up_write(&namespace_sem); | 2237 | up_write(&namespace_sem); |
2251 | kfree(new_ns); | 2238 | kfree(new_ns); |
2252 | return ERR_PTR(-ENOMEM); | 2239 | return ERR_CAST(new); |
2253 | } | 2240 | } |
2254 | new_ns->root = new; | 2241 | new_ns->root = new; |
2255 | br_write_lock(&vfsmount_lock); | 2242 | br_write_lock(&vfsmount_lock); |
@@ -2265,18 +2252,13 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns, | |||
2265 | q = new; | 2252 | q = new; |
2266 | while (p) { | 2253 | while (p) { |
2267 | q->mnt_ns = new_ns; | 2254 | q->mnt_ns = new_ns; |
2268 | __mnt_make_longterm(q); | ||
2269 | if (fs) { | 2255 | if (fs) { |
2270 | if (&p->mnt == fs->root.mnt) { | 2256 | if (&p->mnt == fs->root.mnt) { |
2271 | fs->root.mnt = mntget(&q->mnt); | 2257 | fs->root.mnt = mntget(&q->mnt); |
2272 | __mnt_make_longterm(q); | ||
2273 | mnt_make_shortterm(&p->mnt); | ||
2274 | rootmnt = &p->mnt; | 2258 | rootmnt = &p->mnt; |
2275 | } | 2259 | } |
2276 | if (&p->mnt == fs->pwd.mnt) { | 2260 | if (&p->mnt == fs->pwd.mnt) { |
2277 | fs->pwd.mnt = mntget(&q->mnt); | 2261 | fs->pwd.mnt = mntget(&q->mnt); |
2278 | __mnt_make_longterm(q); | ||
2279 | mnt_make_shortterm(&p->mnt); | ||
2280 | pwdmnt = &p->mnt; | 2262 | pwdmnt = &p->mnt; |
2281 | } | 2263 | } |
2282 | } | 2264 | } |
@@ -2320,7 +2302,6 @@ static struct mnt_namespace *create_mnt_ns(struct vfsmount *m) | |||
2320 | if (!IS_ERR(new_ns)) { | 2302 | if (!IS_ERR(new_ns)) { |
2321 | struct mount *mnt = real_mount(m); | 2303 | struct mount *mnt = real_mount(m); |
2322 | mnt->mnt_ns = new_ns; | 2304 | mnt->mnt_ns = new_ns; |
2323 | __mnt_make_longterm(mnt); | ||
2324 | new_ns->root = mnt; | 2305 | new_ns->root = mnt; |
2325 | list_add(&new_ns->list, &mnt->mnt_list); | 2306 | list_add(&new_ns->list, &mnt->mnt_list); |
2326 | } else { | 2307 | } else { |
@@ -2615,7 +2596,7 @@ struct vfsmount *kern_mount_data(struct file_system_type *type, void *data) | |||
2615 | * it is a longterm mount, don't release mnt until | 2596 | * it is a longterm mount, don't release mnt until |
2616 | * we unmount before file sys is unregistered | 2597 | * we unmount before file sys is unregistered |
2617 | */ | 2598 | */ |
2618 | mnt_make_longterm(mnt); | 2599 | real_mount(mnt)->mnt_ns = MNT_NS_INTERNAL; |
2619 | } | 2600 | } |
2620 | return mnt; | 2601 | return mnt; |
2621 | } | 2602 | } |
@@ -2625,7 +2606,9 @@ void kern_unmount(struct vfsmount *mnt) | |||
2625 | { | 2606 | { |
2626 | /* release long term mount so mount point can be released */ | 2607 | /* release long term mount so mount point can be released */ |
2627 | if (!IS_ERR_OR_NULL(mnt)) { | 2608 | if (!IS_ERR_OR_NULL(mnt)) { |
2628 | mnt_make_shortterm(mnt); | 2609 | br_write_lock(&vfsmount_lock); |
2610 | real_mount(mnt)->mnt_ns = NULL; | ||
2611 | br_write_unlock(&vfsmount_lock); | ||
2629 | mntput(mnt); | 2612 | mntput(mnt); |
2630 | } | 2613 | } |
2631 | } | 2614 | } |
diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index aeed93a6bde0..4117e7b377bb 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c | |||
@@ -30,8 +30,8 @@ static void ncp_do_readdir(struct file *, void *, filldir_t, | |||
30 | 30 | ||
31 | static int ncp_readdir(struct file *, void *, filldir_t); | 31 | static int ncp_readdir(struct file *, void *, filldir_t); |
32 | 32 | ||
33 | static int ncp_create(struct inode *, struct dentry *, umode_t, struct nameidata *); | 33 | static int ncp_create(struct inode *, struct dentry *, umode_t, bool); |
34 | static struct dentry *ncp_lookup(struct inode *, struct dentry *, struct nameidata *); | 34 | static struct dentry *ncp_lookup(struct inode *, struct dentry *, unsigned int); |
35 | static int ncp_unlink(struct inode *, struct dentry *); | 35 | static int ncp_unlink(struct inode *, struct dentry *); |
36 | static int ncp_mkdir(struct inode *, struct dentry *, umode_t); | 36 | static int ncp_mkdir(struct inode *, struct dentry *, umode_t); |
37 | static int ncp_rmdir(struct inode *, struct dentry *); | 37 | static int ncp_rmdir(struct inode *, struct dentry *); |
@@ -72,7 +72,7 @@ const struct inode_operations ncp_dir_inode_operations = | |||
72 | /* | 72 | /* |
73 | * Dentry operations routines | 73 | * Dentry operations routines |
74 | */ | 74 | */ |
75 | static int ncp_lookup_validate(struct dentry *, struct nameidata *); | 75 | static int ncp_lookup_validate(struct dentry *, unsigned int); |
76 | static int ncp_hash_dentry(const struct dentry *, const struct inode *, | 76 | static int ncp_hash_dentry(const struct dentry *, const struct inode *, |
77 | struct qstr *); | 77 | struct qstr *); |
78 | static int ncp_compare_dentry(const struct dentry *, const struct inode *, | 78 | static int ncp_compare_dentry(const struct dentry *, const struct inode *, |
@@ -290,7 +290,7 @@ leave_me:; | |||
290 | 290 | ||
291 | 291 | ||
292 | static int | 292 | static int |
293 | ncp_lookup_validate(struct dentry *dentry, struct nameidata *nd) | 293 | ncp_lookup_validate(struct dentry *dentry, unsigned int flags) |
294 | { | 294 | { |
295 | struct ncp_server *server; | 295 | struct ncp_server *server; |
296 | struct dentry *parent; | 296 | struct dentry *parent; |
@@ -302,7 +302,7 @@ ncp_lookup_validate(struct dentry *dentry, struct nameidata *nd) | |||
302 | if (dentry == dentry->d_sb->s_root) | 302 | if (dentry == dentry->d_sb->s_root) |
303 | return 1; | 303 | return 1; |
304 | 304 | ||
305 | if (nd->flags & LOOKUP_RCU) | 305 | if (flags & LOOKUP_RCU) |
306 | return -ECHILD; | 306 | return -ECHILD; |
307 | 307 | ||
308 | parent = dget_parent(dentry); | 308 | parent = dget_parent(dentry); |
@@ -836,7 +836,7 @@ out: | |||
836 | return result; | 836 | return result; |
837 | } | 837 | } |
838 | 838 | ||
839 | static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 839 | static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
840 | { | 840 | { |
841 | struct ncp_server *server = NCP_SERVER(dir); | 841 | struct ncp_server *server = NCP_SERVER(dir); |
842 | struct inode *inode = NULL; | 842 | struct inode *inode = NULL; |
@@ -980,7 +980,7 @@ out: | |||
980 | } | 980 | } |
981 | 981 | ||
982 | static int ncp_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 982 | static int ncp_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
983 | struct nameidata *nd) | 983 | bool excl) |
984 | { | 984 | { |
985 | return ncp_create_new(dir, dentry, mode, 0, 0); | 985 | return ncp_create_new(dir, dentry, mode, 0, 0); |
986 | } | 986 | } |
diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c index 970659daa323..23ff18fe080a 100644 --- a/fs/nfs/callback.c +++ b/fs/nfs/callback.c | |||
@@ -17,7 +17,6 @@ | |||
17 | #include <linux/kthread.h> | 17 | #include <linux/kthread.h> |
18 | #include <linux/sunrpc/svcauth_gss.h> | 18 | #include <linux/sunrpc/svcauth_gss.h> |
19 | #include <linux/sunrpc/bc_xprt.h> | 19 | #include <linux/sunrpc/bc_xprt.h> |
20 | #include <linux/nsproxy.h> | ||
21 | 20 | ||
22 | #include <net/inet_sock.h> | 21 | #include <net/inet_sock.h> |
23 | 22 | ||
@@ -107,7 +106,7 @@ nfs4_callback_up(struct svc_serv *serv, struct rpc_xprt *xprt) | |||
107 | { | 106 | { |
108 | int ret; | 107 | int ret; |
109 | 108 | ||
110 | ret = svc_create_xprt(serv, "tcp", xprt->xprt_net, PF_INET, | 109 | ret = svc_create_xprt(serv, "tcp", &init_net, PF_INET, |
111 | nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS); | 110 | nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS); |
112 | if (ret <= 0) | 111 | if (ret <= 0) |
113 | goto out_err; | 112 | goto out_err; |
@@ -115,7 +114,7 @@ nfs4_callback_up(struct svc_serv *serv, struct rpc_xprt *xprt) | |||
115 | dprintk("NFS: Callback listener port = %u (af %u)\n", | 114 | dprintk("NFS: Callback listener port = %u (af %u)\n", |
116 | nfs_callback_tcpport, PF_INET); | 115 | nfs_callback_tcpport, PF_INET); |
117 | 116 | ||
118 | ret = svc_create_xprt(serv, "tcp", xprt->xprt_net, PF_INET6, | 117 | ret = svc_create_xprt(serv, "tcp", &init_net, PF_INET6, |
119 | nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS); | 118 | nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS); |
120 | if (ret > 0) { | 119 | if (ret > 0) { |
121 | nfs_callback_tcpport6 = ret; | 120 | nfs_callback_tcpport6 = ret; |
@@ -184,7 +183,7 @@ nfs41_callback_up(struct svc_serv *serv, struct rpc_xprt *xprt) | |||
184 | * fore channel connection. | 183 | * fore channel connection. |
185 | * Returns the input port (0) and sets the svc_serv bc_xprt on success | 184 | * Returns the input port (0) and sets the svc_serv bc_xprt on success |
186 | */ | 185 | */ |
187 | ret = svc_create_xprt(serv, "tcp-bc", xprt->xprt_net, PF_INET, 0, | 186 | ret = svc_create_xprt(serv, "tcp-bc", &init_net, PF_INET, 0, |
188 | SVC_SOCK_ANONYMOUS); | 187 | SVC_SOCK_ANONYMOUS); |
189 | if (ret < 0) { | 188 | if (ret < 0) { |
190 | rqstp = ERR_PTR(ret); | 189 | rqstp = ERR_PTR(ret); |
@@ -254,7 +253,7 @@ int nfs_callback_up(u32 minorversion, struct rpc_xprt *xprt) | |||
254 | char svc_name[12]; | 253 | char svc_name[12]; |
255 | int ret = 0; | 254 | int ret = 0; |
256 | int minorversion_setup; | 255 | int minorversion_setup; |
257 | struct net *net = current->nsproxy->net_ns; | 256 | struct net *net = &init_net; |
258 | 257 | ||
259 | mutex_lock(&nfs_callback_mutex); | 258 | mutex_lock(&nfs_callback_mutex); |
260 | if (cb_info->users++ || cb_info->task != NULL) { | 259 | if (cb_info->users++ || cb_info->task != NULL) { |
@@ -330,7 +329,7 @@ void nfs_callback_down(int minorversion) | |||
330 | cb_info->users--; | 329 | cb_info->users--; |
331 | if (cb_info->users == 0 && cb_info->task != NULL) { | 330 | if (cb_info->users == 0 && cb_info->task != NULL) { |
332 | kthread_stop(cb_info->task); | 331 | kthread_stop(cb_info->task); |
333 | svc_shutdown_net(cb_info->serv, current->nsproxy->net_ns); | 332 | svc_shutdown_net(cb_info->serv, &init_net); |
334 | svc_exit_thread(cb_info->rqst); | 333 | svc_exit_thread(cb_info->rqst); |
335 | cb_info->serv = NULL; | 334 | cb_info->serv = NULL; |
336 | cb_info->rqst = NULL; | 335 | cb_info->rqst = NULL; |
diff --git a/fs/nfs/callback_xdr.c b/fs/nfs/callback_xdr.c index 95bfc243992c..e64b01d2a338 100644 --- a/fs/nfs/callback_xdr.c +++ b/fs/nfs/callback_xdr.c | |||
@@ -455,9 +455,9 @@ static __be32 decode_cb_sequence_args(struct svc_rqst *rqstp, | |||
455 | args->csa_nrclists = ntohl(*p++); | 455 | args->csa_nrclists = ntohl(*p++); |
456 | args->csa_rclists = NULL; | 456 | args->csa_rclists = NULL; |
457 | if (args->csa_nrclists) { | 457 | if (args->csa_nrclists) { |
458 | args->csa_rclists = kmalloc(args->csa_nrclists * | 458 | args->csa_rclists = kmalloc_array(args->csa_nrclists, |
459 | sizeof(*args->csa_rclists), | 459 | sizeof(*args->csa_rclists), |
460 | GFP_KERNEL); | 460 | GFP_KERNEL); |
461 | if (unlikely(args->csa_rclists == NULL)) | 461 | if (unlikely(args->csa_rclists == NULL)) |
462 | goto out; | 462 | goto out; |
463 | 463 | ||
@@ -696,7 +696,7 @@ static __be32 encode_cb_sequence_res(struct svc_rqst *rqstp, | |||
696 | const struct cb_sequenceres *res) | 696 | const struct cb_sequenceres *res) |
697 | { | 697 | { |
698 | __be32 *p; | 698 | __be32 *p; |
699 | unsigned status = res->csr_status; | 699 | __be32 status = res->csr_status; |
700 | 700 | ||
701 | if (unlikely(status != 0)) | 701 | if (unlikely(status != 0)) |
702 | goto out; | 702 | goto out; |
diff --git a/fs/nfs/client.c b/fs/nfs/client.c index 7d108753af81..f005b5bebdc7 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c | |||
@@ -207,7 +207,6 @@ error_0: | |||
207 | static void nfs4_shutdown_session(struct nfs_client *clp) | 207 | static void nfs4_shutdown_session(struct nfs_client *clp) |
208 | { | 208 | { |
209 | if (nfs4_has_session(clp)) { | 209 | if (nfs4_has_session(clp)) { |
210 | nfs4_deviceid_purge_client(clp); | ||
211 | nfs4_destroy_session(clp->cl_session); | 210 | nfs4_destroy_session(clp->cl_session); |
212 | nfs4_destroy_clientid(clp); | 211 | nfs4_destroy_clientid(clp); |
213 | } | 212 | } |
@@ -544,8 +543,6 @@ nfs_found_client(const struct nfs_client_initdata *cl_init, | |||
544 | 543 | ||
545 | smp_rmb(); | 544 | smp_rmb(); |
546 | 545 | ||
547 | BUG_ON(clp->cl_cons_state != NFS_CS_READY); | ||
548 | |||
549 | dprintk("<-- %s found nfs_client %p for %s\n", | 546 | dprintk("<-- %s found nfs_client %p for %s\n", |
550 | __func__, clp, cl_init->hostname ?: ""); | 547 | __func__, clp, cl_init->hostname ?: ""); |
551 | return clp; | 548 | return clp; |
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index f430057ff3b3..a6b1c7fb8232 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c | |||
@@ -46,8 +46,8 @@ | |||
46 | static int nfs_opendir(struct inode *, struct file *); | 46 | static int nfs_opendir(struct inode *, struct file *); |
47 | static int nfs_closedir(struct inode *, struct file *); | 47 | static int nfs_closedir(struct inode *, struct file *); |
48 | static int nfs_readdir(struct file *, void *, filldir_t); | 48 | static int nfs_readdir(struct file *, void *, filldir_t); |
49 | static struct dentry *nfs_lookup(struct inode *, struct dentry *, struct nameidata *); | 49 | static struct dentry *nfs_lookup(struct inode *, struct dentry *, unsigned int); |
50 | static int nfs_create(struct inode *, struct dentry *, umode_t, struct nameidata *); | 50 | static int nfs_create(struct inode *, struct dentry *, umode_t, bool); |
51 | static int nfs_mkdir(struct inode *, struct dentry *, umode_t); | 51 | static int nfs_mkdir(struct inode *, struct dentry *, umode_t); |
52 | static int nfs_rmdir(struct inode *, struct dentry *); | 52 | static int nfs_rmdir(struct inode *, struct dentry *); |
53 | static int nfs_unlink(struct inode *, struct dentry *); | 53 | static int nfs_unlink(struct inode *, struct dentry *); |
@@ -111,11 +111,13 @@ const struct inode_operations nfs3_dir_inode_operations = { | |||
111 | 111 | ||
112 | #ifdef CONFIG_NFS_V4 | 112 | #ifdef CONFIG_NFS_V4 |
113 | 113 | ||
114 | static struct dentry *nfs_atomic_lookup(struct inode *, struct dentry *, struct nameidata *); | 114 | static int nfs_atomic_open(struct inode *, struct dentry *, |
115 | static int nfs_open_create(struct inode *dir, struct dentry *dentry, umode_t mode, struct nameidata *nd); | 115 | struct file *, unsigned, umode_t, |
116 | int *); | ||
116 | const struct inode_operations nfs4_dir_inode_operations = { | 117 | const struct inode_operations nfs4_dir_inode_operations = { |
117 | .create = nfs_open_create, | 118 | .create = nfs_create, |
118 | .lookup = nfs_atomic_lookup, | 119 | .lookup = nfs_lookup, |
120 | .atomic_open = nfs_atomic_open, | ||
119 | .link = nfs_link, | 121 | .link = nfs_link, |
120 | .unlink = nfs_unlink, | 122 | .unlink = nfs_unlink, |
121 | .symlink = nfs_symlink, | 123 | .symlink = nfs_symlink, |
@@ -1029,27 +1031,14 @@ static int nfs_check_verifier(struct inode *dir, struct dentry *dentry) | |||
1029 | } | 1031 | } |
1030 | 1032 | ||
1031 | /* | 1033 | /* |
1032 | * Return the intent data that applies to this particular path component | ||
1033 | * | ||
1034 | * Note that the current set of intents only apply to the very last | ||
1035 | * component of the path and none of them is set before that last | ||
1036 | * component. | ||
1037 | */ | ||
1038 | static inline unsigned int nfs_lookup_check_intent(struct nameidata *nd, | ||
1039 | unsigned int mask) | ||
1040 | { | ||
1041 | return nd->flags & mask; | ||
1042 | } | ||
1043 | |||
1044 | /* | ||
1045 | * Use intent information to check whether or not we're going to do | 1034 | * Use intent information to check whether or not we're going to do |
1046 | * an O_EXCL create using this path component. | 1035 | * an O_EXCL create using this path component. |
1047 | */ | 1036 | */ |
1048 | static int nfs_is_exclusive_create(struct inode *dir, struct nameidata *nd) | 1037 | static int nfs_is_exclusive_create(struct inode *dir, unsigned int flags) |
1049 | { | 1038 | { |
1050 | if (NFS_PROTO(dir)->version == 2) | 1039 | if (NFS_PROTO(dir)->version == 2) |
1051 | return 0; | 1040 | return 0; |
1052 | return nd && nfs_lookup_check_intent(nd, LOOKUP_EXCL); | 1041 | return flags & LOOKUP_EXCL; |
1053 | } | 1042 | } |
1054 | 1043 | ||
1055 | /* | 1044 | /* |
@@ -1061,25 +1050,20 @@ static int nfs_is_exclusive_create(struct inode *dir, struct nameidata *nd) | |||
1061 | * | 1050 | * |
1062 | */ | 1051 | */ |
1063 | static inline | 1052 | static inline |
1064 | int nfs_lookup_verify_inode(struct inode *inode, struct nameidata *nd) | 1053 | int nfs_lookup_verify_inode(struct inode *inode, unsigned int flags) |
1065 | { | 1054 | { |
1066 | struct nfs_server *server = NFS_SERVER(inode); | 1055 | struct nfs_server *server = NFS_SERVER(inode); |
1067 | 1056 | ||
1068 | if (IS_AUTOMOUNT(inode)) | 1057 | if (IS_AUTOMOUNT(inode)) |
1069 | return 0; | 1058 | return 0; |
1070 | if (nd != NULL) { | 1059 | /* VFS wants an on-the-wire revalidation */ |
1071 | /* VFS wants an on-the-wire revalidation */ | 1060 | if (flags & LOOKUP_REVAL) |
1072 | if (nd->flags & LOOKUP_REVAL) | 1061 | goto out_force; |
1073 | goto out_force; | 1062 | /* This is an open(2) */ |
1074 | /* This is an open(2) */ | 1063 | if ((flags & LOOKUP_OPEN) && !(server->flags & NFS_MOUNT_NOCTO) && |
1075 | if (nfs_lookup_check_intent(nd, LOOKUP_OPEN) != 0 && | 1064 | (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode))) |
1076 | !(server->flags & NFS_MOUNT_NOCTO) && | 1065 | goto out_force; |
1077 | (S_ISREG(inode->i_mode) || | 1066 | return 0; |
1078 | S_ISDIR(inode->i_mode))) | ||
1079 | goto out_force; | ||
1080 | return 0; | ||
1081 | } | ||
1082 | return nfs_revalidate_inode(server, inode); | ||
1083 | out_force: | 1067 | out_force: |
1084 | return __nfs_revalidate_inode(server, inode); | 1068 | return __nfs_revalidate_inode(server, inode); |
1085 | } | 1069 | } |
@@ -1093,10 +1077,10 @@ out_force: | |||
1093 | */ | 1077 | */ |
1094 | static inline | 1078 | static inline |
1095 | int nfs_neg_need_reval(struct inode *dir, struct dentry *dentry, | 1079 | int nfs_neg_need_reval(struct inode *dir, struct dentry *dentry, |
1096 | struct nameidata *nd) | 1080 | unsigned int flags) |
1097 | { | 1081 | { |
1098 | /* Don't revalidate a negative dentry if we're creating a new file */ | 1082 | /* Don't revalidate a negative dentry if we're creating a new file */ |
1099 | if (nd != NULL && nfs_lookup_check_intent(nd, LOOKUP_CREATE) != 0) | 1083 | if (flags & LOOKUP_CREATE) |
1100 | return 0; | 1084 | return 0; |
1101 | if (NFS_SERVER(dir)->flags & NFS_MOUNT_LOOKUP_CACHE_NONEG) | 1085 | if (NFS_SERVER(dir)->flags & NFS_MOUNT_LOOKUP_CACHE_NONEG) |
1102 | return 1; | 1086 | return 1; |
@@ -1114,7 +1098,7 @@ int nfs_neg_need_reval(struct inode *dir, struct dentry *dentry, | |||
1114 | * If the parent directory is seen to have changed, we throw out the | 1098 | * If the parent directory is seen to have changed, we throw out the |
1115 | * cached dentry and do a new lookup. | 1099 | * cached dentry and do a new lookup. |
1116 | */ | 1100 | */ |
1117 | static int nfs_lookup_revalidate(struct dentry *dentry, struct nameidata *nd) | 1101 | static int nfs_lookup_revalidate(struct dentry *dentry, unsigned int flags) |
1118 | { | 1102 | { |
1119 | struct inode *dir; | 1103 | struct inode *dir; |
1120 | struct inode *inode; | 1104 | struct inode *inode; |
@@ -1123,7 +1107,7 @@ static int nfs_lookup_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
1123 | struct nfs_fattr *fattr = NULL; | 1107 | struct nfs_fattr *fattr = NULL; |
1124 | int error; | 1108 | int error; |
1125 | 1109 | ||
1126 | if (nd->flags & LOOKUP_RCU) | 1110 | if (flags & LOOKUP_RCU) |
1127 | return -ECHILD; | 1111 | return -ECHILD; |
1128 | 1112 | ||
1129 | parent = dget_parent(dentry); | 1113 | parent = dget_parent(dentry); |
@@ -1132,7 +1116,7 @@ static int nfs_lookup_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
1132 | inode = dentry->d_inode; | 1116 | inode = dentry->d_inode; |
1133 | 1117 | ||
1134 | if (!inode) { | 1118 | if (!inode) { |
1135 | if (nfs_neg_need_reval(dir, dentry, nd)) | 1119 | if (nfs_neg_need_reval(dir, dentry, flags)) |
1136 | goto out_bad; | 1120 | goto out_bad; |
1137 | goto out_valid_noent; | 1121 | goto out_valid_noent; |
1138 | } | 1122 | } |
@@ -1148,8 +1132,8 @@ static int nfs_lookup_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
1148 | goto out_set_verifier; | 1132 | goto out_set_verifier; |
1149 | 1133 | ||
1150 | /* Force a full look up iff the parent directory has changed */ | 1134 | /* Force a full look up iff the parent directory has changed */ |
1151 | if (!nfs_is_exclusive_create(dir, nd) && nfs_check_verifier(dir, dentry)) { | 1135 | if (!nfs_is_exclusive_create(dir, flags) && nfs_check_verifier(dir, dentry)) { |
1152 | if (nfs_lookup_verify_inode(inode, nd)) | 1136 | if (nfs_lookup_verify_inode(inode, flags)) |
1153 | goto out_zap_parent; | 1137 | goto out_zap_parent; |
1154 | goto out_valid; | 1138 | goto out_valid; |
1155 | } | 1139 | } |
@@ -1286,7 +1270,7 @@ const struct dentry_operations nfs_dentry_operations = { | |||
1286 | .d_release = nfs_d_release, | 1270 | .d_release = nfs_d_release, |
1287 | }; | 1271 | }; |
1288 | 1272 | ||
1289 | static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, struct nameidata *nd) | 1273 | static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, unsigned int flags) |
1290 | { | 1274 | { |
1291 | struct dentry *res; | 1275 | struct dentry *res; |
1292 | struct dentry *parent; | 1276 | struct dentry *parent; |
@@ -1307,7 +1291,7 @@ static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, stru | |||
1307 | * If we're doing an exclusive create, optimize away the lookup | 1291 | * If we're doing an exclusive create, optimize away the lookup |
1308 | * but don't hash the dentry. | 1292 | * but don't hash the dentry. |
1309 | */ | 1293 | */ |
1310 | if (nfs_is_exclusive_create(dir, nd)) { | 1294 | if (nfs_is_exclusive_create(dir, flags)) { |
1311 | d_instantiate(dentry, NULL); | 1295 | d_instantiate(dentry, NULL); |
1312 | res = NULL; | 1296 | res = NULL; |
1313 | goto out; | 1297 | goto out; |
@@ -1354,7 +1338,7 @@ out: | |||
1354 | } | 1338 | } |
1355 | 1339 | ||
1356 | #ifdef CONFIG_NFS_V4 | 1340 | #ifdef CONFIG_NFS_V4 |
1357 | static int nfs4_lookup_revalidate(struct dentry *, struct nameidata *); | 1341 | static int nfs4_lookup_revalidate(struct dentry *, unsigned int); |
1358 | 1342 | ||
1359 | const struct dentry_operations nfs4_dentry_operations = { | 1343 | const struct dentry_operations nfs4_dentry_operations = { |
1360 | .d_revalidate = nfs4_lookup_revalidate, | 1344 | .d_revalidate = nfs4_lookup_revalidate, |
@@ -1364,24 +1348,6 @@ const struct dentry_operations nfs4_dentry_operations = { | |||
1364 | .d_release = nfs_d_release, | 1348 | .d_release = nfs_d_release, |
1365 | }; | 1349 | }; |
1366 | 1350 | ||
1367 | /* | ||
1368 | * Use intent information to determine whether we need to substitute | ||
1369 | * the NFSv4-style stateful OPEN for the LOOKUP call | ||
1370 | */ | ||
1371 | static int is_atomic_open(struct nameidata *nd) | ||
1372 | { | ||
1373 | if (nd == NULL || nfs_lookup_check_intent(nd, LOOKUP_OPEN) == 0) | ||
1374 | return 0; | ||
1375 | /* NFS does not (yet) have a stateful open for directories */ | ||
1376 | if (nd->flags & LOOKUP_DIRECTORY) | ||
1377 | return 0; | ||
1378 | /* Are we trying to write to a read only partition? */ | ||
1379 | if (__mnt_is_readonly(nd->path.mnt) && | ||
1380 | (nd->intent.open.flags & (O_CREAT|O_TRUNC|O_ACCMODE))) | ||
1381 | return 0; | ||
1382 | return 1; | ||
1383 | } | ||
1384 | |||
1385 | static fmode_t flags_to_mode(int flags) | 1351 | static fmode_t flags_to_mode(int flags) |
1386 | { | 1352 | { |
1387 | fmode_t res = (__force fmode_t)flags & FMODE_EXEC; | 1353 | fmode_t res = (__force fmode_t)flags & FMODE_EXEC; |
@@ -1403,136 +1369,143 @@ static int do_open(struct inode *inode, struct file *filp) | |||
1403 | return 0; | 1369 | return 0; |
1404 | } | 1370 | } |
1405 | 1371 | ||
1406 | static int nfs_intent_set_file(struct nameidata *nd, struct nfs_open_context *ctx) | 1372 | static int nfs_finish_open(struct nfs_open_context *ctx, |
1373 | struct dentry *dentry, | ||
1374 | struct file *file, unsigned open_flags, | ||
1375 | int *opened) | ||
1407 | { | 1376 | { |
1408 | struct file *filp; | 1377 | int err; |
1409 | int ret = 0; | 1378 | |
1379 | if (ctx->dentry != dentry) { | ||
1380 | dput(ctx->dentry); | ||
1381 | ctx->dentry = dget(dentry); | ||
1382 | } | ||
1410 | 1383 | ||
1411 | /* If the open_intent is for execute, we have an extra check to make */ | 1384 | /* If the open_intent is for execute, we have an extra check to make */ |
1412 | if (ctx->mode & FMODE_EXEC) { | 1385 | if (ctx->mode & FMODE_EXEC) { |
1413 | ret = nfs_may_open(ctx->dentry->d_inode, | 1386 | err = nfs_may_open(dentry->d_inode, ctx->cred, open_flags); |
1414 | ctx->cred, | 1387 | if (err < 0) |
1415 | nd->intent.open.flags); | ||
1416 | if (ret < 0) | ||
1417 | goto out; | 1388 | goto out; |
1418 | } | 1389 | } |
1419 | filp = lookup_instantiate_filp(nd, ctx->dentry, do_open); | 1390 | |
1420 | if (IS_ERR(filp)) | 1391 | err = finish_open(file, dentry, do_open, opened); |
1421 | ret = PTR_ERR(filp); | 1392 | if (err) |
1422 | else | 1393 | goto out; |
1423 | nfs_file_set_open_context(filp, ctx); | 1394 | nfs_file_set_open_context(file, ctx); |
1395 | |||
1424 | out: | 1396 | out: |
1425 | put_nfs_open_context(ctx); | 1397 | put_nfs_open_context(ctx); |
1426 | return ret; | 1398 | return err; |
1427 | } | 1399 | } |
1428 | 1400 | ||
1429 | static struct dentry *nfs_atomic_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 1401 | static int nfs_atomic_open(struct inode *dir, struct dentry *dentry, |
1402 | struct file *file, unsigned open_flags, | ||
1403 | umode_t mode, int *opened) | ||
1430 | { | 1404 | { |
1431 | struct nfs_open_context *ctx; | 1405 | struct nfs_open_context *ctx; |
1432 | struct iattr attr; | 1406 | struct dentry *res; |
1433 | struct dentry *res = NULL; | 1407 | struct iattr attr = { .ia_valid = ATTR_OPEN }; |
1434 | struct inode *inode; | 1408 | struct inode *inode; |
1435 | int open_flags; | ||
1436 | int err; | 1409 | int err; |
1437 | 1410 | ||
1438 | dfprintk(VFS, "NFS: atomic_lookup(%s/%ld), %s\n", | 1411 | /* Expect a negative dentry */ |
1412 | BUG_ON(dentry->d_inode); | ||
1413 | |||
1414 | dfprintk(VFS, "NFS: atomic_open(%s/%ld), %s\n", | ||
1439 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); | 1415 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); |
1440 | 1416 | ||
1441 | /* Check that we are indeed trying to open this file */ | 1417 | /* NFS only supports OPEN on regular files */ |
1442 | if (!is_atomic_open(nd)) | 1418 | if ((open_flags & O_DIRECTORY)) { |
1419 | if (!d_unhashed(dentry)) { | ||
1420 | /* | ||
1421 | * Hashed negative dentry with O_DIRECTORY: dentry was | ||
1422 | * revalidated and is fine, no need to perform lookup | ||
1423 | * again | ||
1424 | */ | ||
1425 | return -ENOENT; | ||
1426 | } | ||
1443 | goto no_open; | 1427 | goto no_open; |
1444 | |||
1445 | if (dentry->d_name.len > NFS_SERVER(dir)->namelen) { | ||
1446 | res = ERR_PTR(-ENAMETOOLONG); | ||
1447 | goto out; | ||
1448 | } | ||
1449 | |||
1450 | /* Let vfs_create() deal with O_EXCL. Instantiate, but don't hash | ||
1451 | * the dentry. */ | ||
1452 | if (nd->flags & LOOKUP_EXCL) { | ||
1453 | d_instantiate(dentry, NULL); | ||
1454 | goto out; | ||
1455 | } | 1428 | } |
1456 | 1429 | ||
1457 | open_flags = nd->intent.open.flags; | 1430 | if (dentry->d_name.len > NFS_SERVER(dir)->namelen) |
1458 | attr.ia_valid = ATTR_OPEN; | 1431 | return -ENAMETOOLONG; |
1459 | |||
1460 | ctx = create_nfs_open_context(dentry, open_flags); | ||
1461 | res = ERR_CAST(ctx); | ||
1462 | if (IS_ERR(ctx)) | ||
1463 | goto out; | ||
1464 | 1432 | ||
1465 | if (nd->flags & LOOKUP_CREATE) { | 1433 | if (open_flags & O_CREAT) { |
1466 | attr.ia_mode = nd->intent.open.create_mode; | ||
1467 | attr.ia_valid |= ATTR_MODE; | 1434 | attr.ia_valid |= ATTR_MODE; |
1468 | attr.ia_mode &= ~current_umask(); | 1435 | attr.ia_mode = mode & ~current_umask(); |
1469 | } else | 1436 | } |
1470 | open_flags &= ~(O_EXCL | O_CREAT); | ||
1471 | |||
1472 | if (open_flags & O_TRUNC) { | 1437 | if (open_flags & O_TRUNC) { |
1473 | attr.ia_valid |= ATTR_SIZE; | 1438 | attr.ia_valid |= ATTR_SIZE; |
1474 | attr.ia_size = 0; | 1439 | attr.ia_size = 0; |
1475 | } | 1440 | } |
1476 | 1441 | ||
1477 | /* Open the file on the server */ | 1442 | ctx = create_nfs_open_context(dentry, open_flags); |
1443 | err = PTR_ERR(ctx); | ||
1444 | if (IS_ERR(ctx)) | ||
1445 | goto out; | ||
1446 | |||
1478 | nfs_block_sillyrename(dentry->d_parent); | 1447 | nfs_block_sillyrename(dentry->d_parent); |
1479 | inode = NFS_PROTO(dir)->open_context(dir, ctx, open_flags, &attr); | 1448 | inode = NFS_PROTO(dir)->open_context(dir, ctx, open_flags, &attr); |
1449 | d_drop(dentry); | ||
1480 | if (IS_ERR(inode)) { | 1450 | if (IS_ERR(inode)) { |
1481 | nfs_unblock_sillyrename(dentry->d_parent); | 1451 | nfs_unblock_sillyrename(dentry->d_parent); |
1482 | put_nfs_open_context(ctx); | 1452 | put_nfs_open_context(ctx); |
1483 | switch (PTR_ERR(inode)) { | 1453 | err = PTR_ERR(inode); |
1484 | /* Make a negative dentry */ | 1454 | switch (err) { |
1485 | case -ENOENT: | 1455 | case -ENOENT: |
1486 | d_add(dentry, NULL); | 1456 | d_add(dentry, NULL); |
1487 | res = NULL; | 1457 | break; |
1488 | goto out; | 1458 | case -EISDIR: |
1489 | /* This turned out not to be a regular file */ | 1459 | case -ENOTDIR: |
1490 | case -EISDIR: | 1460 | goto no_open; |
1491 | case -ENOTDIR: | 1461 | case -ELOOP: |
1462 | if (!(open_flags & O_NOFOLLOW)) | ||
1492 | goto no_open; | 1463 | goto no_open; |
1493 | case -ELOOP: | 1464 | break; |
1494 | if (!(nd->intent.open.flags & O_NOFOLLOW)) | ||
1495 | goto no_open; | ||
1496 | /* case -EINVAL: */ | 1465 | /* case -EINVAL: */ |
1497 | default: | 1466 | default: |
1498 | res = ERR_CAST(inode); | 1467 | break; |
1499 | goto out; | ||
1500 | } | 1468 | } |
1469 | goto out; | ||
1501 | } | 1470 | } |
1502 | res = d_add_unique(dentry, inode); | 1471 | res = d_add_unique(dentry, inode); |
1503 | nfs_unblock_sillyrename(dentry->d_parent); | 1472 | if (res != NULL) |
1504 | if (res != NULL) { | ||
1505 | dput(ctx->dentry); | ||
1506 | ctx->dentry = dget(res); | ||
1507 | dentry = res; | 1473 | dentry = res; |
1508 | } | 1474 | |
1509 | err = nfs_intent_set_file(nd, ctx); | 1475 | nfs_unblock_sillyrename(dentry->d_parent); |
1510 | if (err < 0) { | ||
1511 | if (res != NULL) | ||
1512 | dput(res); | ||
1513 | return ERR_PTR(err); | ||
1514 | } | ||
1515 | out: | ||
1516 | nfs_set_verifier(dentry, nfs_save_change_attribute(dir)); | 1476 | nfs_set_verifier(dentry, nfs_save_change_attribute(dir)); |
1517 | return res; | 1477 | |
1478 | err = nfs_finish_open(ctx, dentry, file, open_flags, opened); | ||
1479 | |||
1480 | dput(res); | ||
1481 | out: | ||
1482 | return err; | ||
1483 | |||
1518 | no_open: | 1484 | no_open: |
1519 | return nfs_lookup(dir, dentry, nd); | 1485 | res = nfs_lookup(dir, dentry, 0); |
1486 | err = PTR_ERR(res); | ||
1487 | if (IS_ERR(res)) | ||
1488 | goto out; | ||
1489 | |||
1490 | return finish_no_open(file, res); | ||
1520 | } | 1491 | } |
1521 | 1492 | ||
1522 | static int nfs4_lookup_revalidate(struct dentry *dentry, struct nameidata *nd) | 1493 | static int nfs4_lookup_revalidate(struct dentry *dentry, unsigned int flags) |
1523 | { | 1494 | { |
1524 | struct dentry *parent = NULL; | 1495 | struct dentry *parent = NULL; |
1525 | struct inode *inode; | 1496 | struct inode *inode; |
1526 | struct inode *dir; | 1497 | struct inode *dir; |
1527 | int openflags, ret = 0; | 1498 | int ret = 0; |
1528 | 1499 | ||
1529 | if (nd->flags & LOOKUP_RCU) | 1500 | if (flags & LOOKUP_RCU) |
1530 | return -ECHILD; | 1501 | return -ECHILD; |
1531 | 1502 | ||
1532 | inode = dentry->d_inode; | 1503 | if (!(flags & LOOKUP_OPEN) || (flags & LOOKUP_DIRECTORY)) |
1533 | if (!is_atomic_open(nd) || d_mountpoint(dentry)) | 1504 | goto no_open; |
1505 | if (d_mountpoint(dentry)) | ||
1534 | goto no_open; | 1506 | goto no_open; |
1535 | 1507 | ||
1508 | inode = dentry->d_inode; | ||
1536 | parent = dget_parent(dentry); | 1509 | parent = dget_parent(dentry); |
1537 | dir = parent->d_inode; | 1510 | dir = parent->d_inode; |
1538 | 1511 | ||
@@ -1540,7 +1513,7 @@ static int nfs4_lookup_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
1540 | * optimize away revalidation of negative dentries. | 1513 | * optimize away revalidation of negative dentries. |
1541 | */ | 1514 | */ |
1542 | if (inode == NULL) { | 1515 | if (inode == NULL) { |
1543 | if (!nfs_neg_need_reval(dir, dentry, nd)) | 1516 | if (!nfs_neg_need_reval(dir, dentry, flags)) |
1544 | ret = 1; | 1517 | ret = 1; |
1545 | goto out; | 1518 | goto out; |
1546 | } | 1519 | } |
@@ -1548,9 +1521,8 @@ static int nfs4_lookup_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
1548 | /* NFS only supports OPEN on regular files */ | 1521 | /* NFS only supports OPEN on regular files */ |
1549 | if (!S_ISREG(inode->i_mode)) | 1522 | if (!S_ISREG(inode->i_mode)) |
1550 | goto no_open_dput; | 1523 | goto no_open_dput; |
1551 | openflags = nd->intent.open.flags; | ||
1552 | /* We cannot do exclusive creation on a positive dentry */ | 1524 | /* We cannot do exclusive creation on a positive dentry */ |
1553 | if ((openflags & (O_CREAT|O_EXCL)) == (O_CREAT|O_EXCL)) | 1525 | if (flags & LOOKUP_EXCL) |
1554 | goto no_open_dput; | 1526 | goto no_open_dput; |
1555 | 1527 | ||
1556 | /* Let f_op->open() actually open (and revalidate) the file */ | 1528 | /* Let f_op->open() actually open (and revalidate) the file */ |
@@ -1563,48 +1535,7 @@ out: | |||
1563 | no_open_dput: | 1535 | no_open_dput: |
1564 | dput(parent); | 1536 | dput(parent); |
1565 | no_open: | 1537 | no_open: |
1566 | return nfs_lookup_revalidate(dentry, nd); | 1538 | return nfs_lookup_revalidate(dentry, flags); |
1567 | } | ||
1568 | |||
1569 | static int nfs_open_create(struct inode *dir, struct dentry *dentry, | ||
1570 | umode_t mode, struct nameidata *nd) | ||
1571 | { | ||
1572 | struct nfs_open_context *ctx = NULL; | ||
1573 | struct iattr attr; | ||
1574 | int error; | ||
1575 | int open_flags = O_CREAT|O_EXCL; | ||
1576 | |||
1577 | dfprintk(VFS, "NFS: create(%s/%ld), %s\n", | ||
1578 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); | ||
1579 | |||
1580 | attr.ia_mode = mode; | ||
1581 | attr.ia_valid = ATTR_MODE; | ||
1582 | |||
1583 | if (nd) | ||
1584 | open_flags = nd->intent.open.flags; | ||
1585 | |||
1586 | ctx = create_nfs_open_context(dentry, open_flags); | ||
1587 | error = PTR_ERR(ctx); | ||
1588 | if (IS_ERR(ctx)) | ||
1589 | goto out_err_drop; | ||
1590 | |||
1591 | error = NFS_PROTO(dir)->create(dir, dentry, &attr, open_flags, ctx); | ||
1592 | if (error != 0) | ||
1593 | goto out_put_ctx; | ||
1594 | if (nd) { | ||
1595 | error = nfs_intent_set_file(nd, ctx); | ||
1596 | if (error < 0) | ||
1597 | goto out_err; | ||
1598 | } else { | ||
1599 | put_nfs_open_context(ctx); | ||
1600 | } | ||
1601 | return 0; | ||
1602 | out_put_ctx: | ||
1603 | put_nfs_open_context(ctx); | ||
1604 | out_err_drop: | ||
1605 | d_drop(dentry); | ||
1606 | out_err: | ||
1607 | return error; | ||
1608 | } | 1539 | } |
1609 | 1540 | ||
1610 | #endif /* CONFIG_NFSV4 */ | 1541 | #endif /* CONFIG_NFSV4 */ |
@@ -1658,11 +1589,11 @@ out_error: | |||
1658 | * reply path made it appear to have failed. | 1589 | * reply path made it appear to have failed. |
1659 | */ | 1590 | */ |
1660 | static int nfs_create(struct inode *dir, struct dentry *dentry, | 1591 | static int nfs_create(struct inode *dir, struct dentry *dentry, |
1661 | umode_t mode, struct nameidata *nd) | 1592 | umode_t mode, bool excl) |
1662 | { | 1593 | { |
1663 | struct iattr attr; | 1594 | struct iattr attr; |
1595 | int open_flags = excl ? O_CREAT | O_EXCL : O_CREAT; | ||
1664 | int error; | 1596 | int error; |
1665 | int open_flags = O_CREAT|O_EXCL; | ||
1666 | 1597 | ||
1667 | dfprintk(VFS, "NFS: create(%s/%ld), %s\n", | 1598 | dfprintk(VFS, "NFS: create(%s/%ld), %s\n", |
1668 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); | 1599 | dir->i_sb->s_id, dir->i_ino, dentry->d_name.name); |
@@ -1670,10 +1601,7 @@ static int nfs_create(struct inode *dir, struct dentry *dentry, | |||
1670 | attr.ia_mode = mode; | 1601 | attr.ia_mode = mode; |
1671 | attr.ia_valid = ATTR_MODE; | 1602 | attr.ia_valid = ATTR_MODE; |
1672 | 1603 | ||
1673 | if (nd) | 1604 | error = NFS_PROTO(dir)->create(dir, dentry, &attr, open_flags); |
1674 | open_flags = nd->intent.open.flags; | ||
1675 | |||
1676 | error = NFS_PROTO(dir)->create(dir, dentry, &attr, open_flags, NULL); | ||
1677 | if (error != 0) | 1605 | if (error != 0) |
1678 | goto out_err; | 1606 | goto out_err; |
1679 | return 0; | 1607 | return 0; |
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index ad2775d3e219..48253372ab1d 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c | |||
@@ -484,17 +484,22 @@ static void nfs_direct_write_reschedule(struct nfs_direct_req *dreq) | |||
484 | 484 | ||
485 | list_for_each_entry_safe(req, tmp, &reqs, wb_list) { | 485 | list_for_each_entry_safe(req, tmp, &reqs, wb_list) { |
486 | if (!nfs_pageio_add_request(&desc, req)) { | 486 | if (!nfs_pageio_add_request(&desc, req)) { |
487 | nfs_list_remove_request(req); | ||
487 | nfs_list_add_request(req, &failed); | 488 | nfs_list_add_request(req, &failed); |
488 | spin_lock(cinfo.lock); | 489 | spin_lock(cinfo.lock); |
489 | dreq->flags = 0; | 490 | dreq->flags = 0; |
490 | dreq->error = -EIO; | 491 | dreq->error = -EIO; |
491 | spin_unlock(cinfo.lock); | 492 | spin_unlock(cinfo.lock); |
492 | } | 493 | } |
494 | nfs_release_request(req); | ||
493 | } | 495 | } |
494 | nfs_pageio_complete(&desc); | 496 | nfs_pageio_complete(&desc); |
495 | 497 | ||
496 | while (!list_empty(&failed)) | 498 | while (!list_empty(&failed)) { |
499 | req = nfs_list_entry(failed.next); | ||
500 | nfs_list_remove_request(req); | ||
497 | nfs_unlock_and_release_request(req); | 501 | nfs_unlock_and_release_request(req); |
502 | } | ||
498 | 503 | ||
499 | if (put_dreq(dreq)) | 504 | if (put_dreq(dreq)) |
500 | nfs_direct_write_complete(dreq, dreq->inode); | 505 | nfs_direct_write_complete(dreq, dreq->inode); |
@@ -523,9 +528,9 @@ static void nfs_direct_commit_complete(struct nfs_commit_data *data) | |||
523 | nfs_list_remove_request(req); | 528 | nfs_list_remove_request(req); |
524 | if (dreq->flags == NFS_ODIRECT_RESCHED_WRITES) { | 529 | if (dreq->flags == NFS_ODIRECT_RESCHED_WRITES) { |
525 | /* Note the rewrite will go through mds */ | 530 | /* Note the rewrite will go through mds */ |
526 | kref_get(&req->wb_kref); | ||
527 | nfs_mark_request_commit(req, NULL, &cinfo); | 531 | nfs_mark_request_commit(req, NULL, &cinfo); |
528 | } | 532 | } else |
533 | nfs_release_request(req); | ||
529 | nfs_unlock_and_release_request(req); | 534 | nfs_unlock_and_release_request(req); |
530 | } | 535 | } |
531 | 536 | ||
@@ -716,12 +721,12 @@ static void nfs_direct_write_completion(struct nfs_pgio_header *hdr) | |||
716 | if (dreq->flags == NFS_ODIRECT_RESCHED_WRITES) | 721 | if (dreq->flags == NFS_ODIRECT_RESCHED_WRITES) |
717 | bit = NFS_IOHDR_NEED_RESCHED; | 722 | bit = NFS_IOHDR_NEED_RESCHED; |
718 | else if (dreq->flags == 0) { | 723 | else if (dreq->flags == 0) { |
719 | memcpy(&dreq->verf, &req->wb_verf, | 724 | memcpy(&dreq->verf, hdr->verf, |
720 | sizeof(dreq->verf)); | 725 | sizeof(dreq->verf)); |
721 | bit = NFS_IOHDR_NEED_COMMIT; | 726 | bit = NFS_IOHDR_NEED_COMMIT; |
722 | dreq->flags = NFS_ODIRECT_DO_COMMIT; | 727 | dreq->flags = NFS_ODIRECT_DO_COMMIT; |
723 | } else if (dreq->flags == NFS_ODIRECT_DO_COMMIT) { | 728 | } else if (dreq->flags == NFS_ODIRECT_DO_COMMIT) { |
724 | if (memcmp(&dreq->verf, &req->wb_verf, sizeof(dreq->verf))) { | 729 | if (memcmp(&dreq->verf, hdr->verf, sizeof(dreq->verf))) { |
725 | dreq->flags = NFS_ODIRECT_RESCHED_WRITES; | 730 | dreq->flags = NFS_ODIRECT_RESCHED_WRITES; |
726 | bit = NFS_IOHDR_NEED_RESCHED; | 731 | bit = NFS_IOHDR_NEED_RESCHED; |
727 | } else | 732 | } else |
diff --git a/fs/nfs/getroot.c b/fs/nfs/getroot.c index 8abfb19bd3aa..a67990f90bd7 100644 --- a/fs/nfs/getroot.c +++ b/fs/nfs/getroot.c | |||
@@ -62,7 +62,7 @@ static int nfs_superblock_set_dummy_root(struct super_block *sb, struct inode *i | |||
62 | */ | 62 | */ |
63 | spin_lock(&sb->s_root->d_inode->i_lock); | 63 | spin_lock(&sb->s_root->d_inode->i_lock); |
64 | spin_lock(&sb->s_root->d_lock); | 64 | spin_lock(&sb->s_root->d_lock); |
65 | list_del_init(&sb->s_root->d_alias); | 65 | hlist_del_init(&sb->s_root->d_alias); |
66 | spin_unlock(&sb->s_root->d_lock); | 66 | spin_unlock(&sb->s_root->d_lock); |
67 | spin_unlock(&sb->s_root->d_inode->i_lock); | 67 | spin_unlock(&sb->s_root->d_inode->i_lock); |
68 | } | 68 | } |
diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c index b5b86a05059c..864c51e4b400 100644 --- a/fs/nfs/idmap.c +++ b/fs/nfs/idmap.c | |||
@@ -57,6 +57,11 @@ unsigned int nfs_idmap_cache_timeout = 600; | |||
57 | static const struct cred *id_resolver_cache; | 57 | static const struct cred *id_resolver_cache; |
58 | static struct key_type key_type_id_resolver_legacy; | 58 | static struct key_type key_type_id_resolver_legacy; |
59 | 59 | ||
60 | struct idmap { | ||
61 | struct rpc_pipe *idmap_pipe; | ||
62 | struct key_construction *idmap_key_cons; | ||
63 | struct mutex idmap_mutex; | ||
64 | }; | ||
60 | 65 | ||
61 | /** | 66 | /** |
62 | * nfs_fattr_init_names - initialise the nfs_fattr owner_name/group_name fields | 67 | * nfs_fattr_init_names - initialise the nfs_fattr owner_name/group_name fields |
@@ -310,9 +315,11 @@ static ssize_t nfs_idmap_get_key(const char *name, size_t namelen, | |||
310 | name, namelen, type, data, | 315 | name, namelen, type, data, |
311 | data_size, NULL); | 316 | data_size, NULL); |
312 | if (ret < 0) { | 317 | if (ret < 0) { |
318 | mutex_lock(&idmap->idmap_mutex); | ||
313 | ret = nfs_idmap_request_key(&key_type_id_resolver_legacy, | 319 | ret = nfs_idmap_request_key(&key_type_id_resolver_legacy, |
314 | name, namelen, type, data, | 320 | name, namelen, type, data, |
315 | data_size, idmap); | 321 | data_size, idmap); |
322 | mutex_unlock(&idmap->idmap_mutex); | ||
316 | } | 323 | } |
317 | return ret; | 324 | return ret; |
318 | } | 325 | } |
@@ -354,11 +361,6 @@ static int nfs_idmap_lookup_id(const char *name, size_t namelen, const char *typ | |||
354 | /* idmap classic begins here */ | 361 | /* idmap classic begins here */ |
355 | module_param(nfs_idmap_cache_timeout, int, 0644); | 362 | module_param(nfs_idmap_cache_timeout, int, 0644); |
356 | 363 | ||
357 | struct idmap { | ||
358 | struct rpc_pipe *idmap_pipe; | ||
359 | struct key_construction *idmap_key_cons; | ||
360 | }; | ||
361 | |||
362 | enum { | 364 | enum { |
363 | Opt_find_uid, Opt_find_gid, Opt_find_user, Opt_find_group, Opt_find_err | 365 | Opt_find_uid, Opt_find_gid, Opt_find_user, Opt_find_group, Opt_find_err |
364 | }; | 366 | }; |
@@ -469,6 +471,7 @@ nfs_idmap_new(struct nfs_client *clp) | |||
469 | return error; | 471 | return error; |
470 | } | 472 | } |
471 | idmap->idmap_pipe = pipe; | 473 | idmap->idmap_pipe = pipe; |
474 | mutex_init(&idmap->idmap_mutex); | ||
472 | 475 | ||
473 | clp->cl_idmap = idmap; | 476 | clp->cl_idmap = idmap; |
474 | return 0; | 477 | return 0; |
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index e605d695dbcb..f7296983eba6 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c | |||
@@ -1530,7 +1530,6 @@ static inline void nfs4_init_once(struct nfs_inode *nfsi) | |||
1530 | nfsi->delegation_state = 0; | 1530 | nfsi->delegation_state = 0; |
1531 | init_rwsem(&nfsi->rwsem); | 1531 | init_rwsem(&nfsi->rwsem); |
1532 | nfsi->layout = NULL; | 1532 | nfsi->layout = NULL; |
1533 | atomic_set(&nfsi->commit_info.rpcs_out, 0); | ||
1534 | #endif | 1533 | #endif |
1535 | } | 1534 | } |
1536 | 1535 | ||
@@ -1545,6 +1544,7 @@ static void init_once(void *foo) | |||
1545 | INIT_LIST_HEAD(&nfsi->commit_info.list); | 1544 | INIT_LIST_HEAD(&nfsi->commit_info.list); |
1546 | nfsi->npages = 0; | 1545 | nfsi->npages = 0; |
1547 | nfsi->commit_info.ncommit = 0; | 1546 | nfsi->commit_info.ncommit = 0; |
1547 | atomic_set(&nfsi->commit_info.rpcs_out, 0); | ||
1548 | atomic_set(&nfsi->silly_count, 1); | 1548 | atomic_set(&nfsi->silly_count, 1); |
1549 | INIT_HLIST_HEAD(&nfsi->silly_list); | 1549 | INIT_HLIST_HEAD(&nfsi->silly_list); |
1550 | init_waitqueue_head(&nfsi->waitqueue); | 1550 | init_waitqueue_head(&nfsi->waitqueue); |
diff --git a/fs/nfs/nfs3proc.c b/fs/nfs/nfs3proc.c index 2292a0fd2bff..3187e24e8f78 100644 --- a/fs/nfs/nfs3proc.c +++ b/fs/nfs/nfs3proc.c | |||
@@ -314,7 +314,7 @@ static void nfs3_free_createdata(struct nfs3_createdata *data) | |||
314 | */ | 314 | */ |
315 | static int | 315 | static int |
316 | nfs3_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, | 316 | nfs3_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, |
317 | int flags, struct nfs_open_context *ctx) | 317 | int flags) |
318 | { | 318 | { |
319 | struct nfs3_createdata *data; | 319 | struct nfs3_createdata *data; |
320 | umode_t mode = sattr->ia_mode; | 320 | umode_t mode = sattr->ia_mode; |
diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h index c6827f93ab57..cc5900ac61b5 100644 --- a/fs/nfs/nfs4_fs.h +++ b/fs/nfs/nfs4_fs.h | |||
@@ -295,7 +295,7 @@ is_ds_client(struct nfs_client *clp) | |||
295 | 295 | ||
296 | extern const struct nfs4_minor_version_ops *nfs_v4_minor_ops[]; | 296 | extern const struct nfs4_minor_version_ops *nfs_v4_minor_ops[]; |
297 | 297 | ||
298 | extern const u32 nfs4_fattr_bitmap[2]; | 298 | extern const u32 nfs4_fattr_bitmap[3]; |
299 | extern const u32 nfs4_statfs_bitmap[2]; | 299 | extern const u32 nfs4_statfs_bitmap[2]; |
300 | extern const u32 nfs4_pathconf_bitmap[2]; | 300 | extern const u32 nfs4_pathconf_bitmap[2]; |
301 | extern const u32 nfs4_fsinfo_bitmap[3]; | 301 | extern const u32 nfs4_fsinfo_bitmap[3]; |
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index d48dbefa0e71..c157b2089b47 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c | |||
@@ -105,6 +105,8 @@ static int nfs4_map_errors(int err) | |||
105 | return -EINVAL; | 105 | return -EINVAL; |
106 | case -NFS4ERR_SHARE_DENIED: | 106 | case -NFS4ERR_SHARE_DENIED: |
107 | return -EACCES; | 107 | return -EACCES; |
108 | case -NFS4ERR_MINOR_VERS_MISMATCH: | ||
109 | return -EPROTONOSUPPORT; | ||
108 | default: | 110 | default: |
109 | dprintk("%s could not handle NFSv4 error %d\n", | 111 | dprintk("%s could not handle NFSv4 error %d\n", |
110 | __func__, -err); | 112 | __func__, -err); |
@@ -116,7 +118,7 @@ static int nfs4_map_errors(int err) | |||
116 | /* | 118 | /* |
117 | * This is our standard bitmap for GETATTR requests. | 119 | * This is our standard bitmap for GETATTR requests. |
118 | */ | 120 | */ |
119 | const u32 nfs4_fattr_bitmap[2] = { | 121 | const u32 nfs4_fattr_bitmap[3] = { |
120 | FATTR4_WORD0_TYPE | 122 | FATTR4_WORD0_TYPE |
121 | | FATTR4_WORD0_CHANGE | 123 | | FATTR4_WORD0_CHANGE |
122 | | FATTR4_WORD0_SIZE | 124 | | FATTR4_WORD0_SIZE |
@@ -133,6 +135,24 @@ const u32 nfs4_fattr_bitmap[2] = { | |||
133 | | FATTR4_WORD1_TIME_MODIFY | 135 | | FATTR4_WORD1_TIME_MODIFY |
134 | }; | 136 | }; |
135 | 137 | ||
138 | static const u32 nfs4_pnfs_open_bitmap[3] = { | ||
139 | FATTR4_WORD0_TYPE | ||
140 | | FATTR4_WORD0_CHANGE | ||
141 | | FATTR4_WORD0_SIZE | ||
142 | | FATTR4_WORD0_FSID | ||
143 | | FATTR4_WORD0_FILEID, | ||
144 | FATTR4_WORD1_MODE | ||
145 | | FATTR4_WORD1_NUMLINKS | ||
146 | | FATTR4_WORD1_OWNER | ||
147 | | FATTR4_WORD1_OWNER_GROUP | ||
148 | | FATTR4_WORD1_RAWDEV | ||
149 | | FATTR4_WORD1_SPACE_USED | ||
150 | | FATTR4_WORD1_TIME_ACCESS | ||
151 | | FATTR4_WORD1_TIME_METADATA | ||
152 | | FATTR4_WORD1_TIME_MODIFY, | ||
153 | FATTR4_WORD2_MDSTHRESHOLD | ||
154 | }; | ||
155 | |||
136 | const u32 nfs4_statfs_bitmap[2] = { | 156 | const u32 nfs4_statfs_bitmap[2] = { |
137 | FATTR4_WORD0_FILES_AVAIL | 157 | FATTR4_WORD0_FILES_AVAIL |
138 | | FATTR4_WORD0_FILES_FREE | 158 | | FATTR4_WORD0_FILES_FREE |
@@ -844,6 +864,7 @@ static struct nfs4_opendata *nfs4_opendata_alloc(struct dentry *dentry, | |||
844 | p->o_arg.name = &dentry->d_name; | 864 | p->o_arg.name = &dentry->d_name; |
845 | p->o_arg.server = server; | 865 | p->o_arg.server = server; |
846 | p->o_arg.bitmask = server->attr_bitmask; | 866 | p->o_arg.bitmask = server->attr_bitmask; |
867 | p->o_arg.open_bitmap = &nfs4_fattr_bitmap[0]; | ||
847 | p->o_arg.claim = NFS4_OPEN_CLAIM_NULL; | 868 | p->o_arg.claim = NFS4_OPEN_CLAIM_NULL; |
848 | if (attrs != NULL && attrs->ia_valid != 0) { | 869 | if (attrs != NULL && attrs->ia_valid != 0) { |
849 | __be32 verf[2]; | 870 | __be32 verf[2]; |
@@ -1820,6 +1841,7 @@ static int _nfs4_do_open(struct inode *dir, | |||
1820 | opendata->f_attr.mdsthreshold = pnfs_mdsthreshold_alloc(); | 1841 | opendata->f_attr.mdsthreshold = pnfs_mdsthreshold_alloc(); |
1821 | if (!opendata->f_attr.mdsthreshold) | 1842 | if (!opendata->f_attr.mdsthreshold) |
1822 | goto err_opendata_put; | 1843 | goto err_opendata_put; |
1844 | opendata->o_arg.open_bitmap = &nfs4_pnfs_open_bitmap[0]; | ||
1823 | } | 1845 | } |
1824 | if (dentry->d_inode != NULL) | 1846 | if (dentry->d_inode != NULL) |
1825 | opendata->state = nfs4_get_open_state(dentry->d_inode, sp); | 1847 | opendata->state = nfs4_get_open_state(dentry->d_inode, sp); |
@@ -1880,6 +1902,7 @@ static struct nfs4_state *nfs4_do_open(struct inode *dir, | |||
1880 | struct nfs4_state *res; | 1902 | struct nfs4_state *res; |
1881 | int status; | 1903 | int status; |
1882 | 1904 | ||
1905 | fmode &= FMODE_READ|FMODE_WRITE; | ||
1883 | do { | 1906 | do { |
1884 | status = _nfs4_do_open(dir, dentry, fmode, flags, sattr, cred, | 1907 | status = _nfs4_do_open(dir, dentry, fmode, flags, sattr, cred, |
1885 | &res, ctx_th); | 1908 | &res, ctx_th); |
@@ -2526,6 +2549,14 @@ nfs4_proc_setattr(struct dentry *dentry, struct nfs_fattr *fattr, | |||
2526 | 2549 | ||
2527 | nfs_fattr_init(fattr); | 2550 | nfs_fattr_init(fattr); |
2528 | 2551 | ||
2552 | /* Deal with open(O_TRUNC) */ | ||
2553 | if (sattr->ia_valid & ATTR_OPEN) | ||
2554 | sattr->ia_valid &= ~(ATTR_MTIME|ATTR_CTIME|ATTR_OPEN); | ||
2555 | |||
2556 | /* Optimization: if the end result is no change, don't RPC */ | ||
2557 | if ((sattr->ia_valid & ~(ATTR_FILE)) == 0) | ||
2558 | return 0; | ||
2559 | |||
2529 | /* Search for an existing open(O_WRITE) file */ | 2560 | /* Search for an existing open(O_WRITE) file */ |
2530 | if (sattr->ia_valid & ATTR_FILE) { | 2561 | if (sattr->ia_valid & ATTR_FILE) { |
2531 | struct nfs_open_context *ctx; | 2562 | struct nfs_open_context *ctx; |
@@ -2537,10 +2568,6 @@ nfs4_proc_setattr(struct dentry *dentry, struct nfs_fattr *fattr, | |||
2537 | } | 2568 | } |
2538 | } | 2569 | } |
2539 | 2570 | ||
2540 | /* Deal with open(O_TRUNC) */ | ||
2541 | if (sattr->ia_valid & ATTR_OPEN) | ||
2542 | sattr->ia_valid &= ~(ATTR_MTIME|ATTR_CTIME|ATTR_OPEN); | ||
2543 | |||
2544 | status = nfs4_do_setattr(inode, cred, fattr, sattr, state); | 2571 | status = nfs4_do_setattr(inode, cred, fattr, sattr, state); |
2545 | if (status == 0) | 2572 | if (status == 0) |
2546 | nfs_setattr_update_inode(inode, sattr); | 2573 | nfs_setattr_update_inode(inode, sattr); |
@@ -2779,37 +2806,22 @@ static int nfs4_proc_readlink(struct inode *inode, struct page *page, | |||
2779 | } | 2806 | } |
2780 | 2807 | ||
2781 | /* | 2808 | /* |
2782 | * Got race? | 2809 | * This is just for mknod. open(O_CREAT) will always do ->open_context(). |
2783 | * We will need to arrange for the VFS layer to provide an atomic open. | ||
2784 | * Until then, this create/open method is prone to inefficiency and race | ||
2785 | * conditions due to the lookup, create, and open VFS calls from sys_open() | ||
2786 | * placed on the wire. | ||
2787 | * | ||
2788 | * Given the above sorry state of affairs, I'm simply sending an OPEN. | ||
2789 | * The file will be opened again in the subsequent VFS open call | ||
2790 | * (nfs4_proc_file_open). | ||
2791 | * | ||
2792 | * The open for read will just hang around to be used by any process that | ||
2793 | * opens the file O_RDONLY. This will all be resolved with the VFS changes. | ||
2794 | */ | 2810 | */ |
2795 | |||
2796 | static int | 2811 | static int |
2797 | nfs4_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, | 2812 | nfs4_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, |
2798 | int flags, struct nfs_open_context *ctx) | 2813 | int flags) |
2799 | { | 2814 | { |
2800 | struct dentry *de = dentry; | 2815 | struct nfs_open_context *ctx; |
2801 | struct nfs4_state *state; | 2816 | struct nfs4_state *state; |
2802 | struct rpc_cred *cred = NULL; | ||
2803 | fmode_t fmode = 0; | ||
2804 | int status = 0; | 2817 | int status = 0; |
2805 | 2818 | ||
2806 | if (ctx != NULL) { | 2819 | ctx = alloc_nfs_open_context(dentry, FMODE_READ); |
2807 | cred = ctx->cred; | 2820 | if (IS_ERR(ctx)) |
2808 | de = ctx->dentry; | 2821 | return PTR_ERR(ctx); |
2809 | fmode = ctx->mode; | 2822 | |
2810 | } | ||
2811 | sattr->ia_mode &= ~current_umask(); | 2823 | sattr->ia_mode &= ~current_umask(); |
2812 | state = nfs4_do_open(dir, de, fmode, flags, sattr, cred, NULL); | 2824 | state = nfs4_do_open(dir, dentry, ctx->mode, flags, sattr, ctx->cred, NULL); |
2813 | d_drop(dentry); | 2825 | d_drop(dentry); |
2814 | if (IS_ERR(state)) { | 2826 | if (IS_ERR(state)) { |
2815 | status = PTR_ERR(state); | 2827 | status = PTR_ERR(state); |
@@ -2817,11 +2829,9 @@ nfs4_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, | |||
2817 | } | 2829 | } |
2818 | d_add(dentry, igrab(state->inode)); | 2830 | d_add(dentry, igrab(state->inode)); |
2819 | nfs_set_verifier(dentry, nfs_save_change_attribute(dir)); | 2831 | nfs_set_verifier(dentry, nfs_save_change_attribute(dir)); |
2820 | if (ctx != NULL) | 2832 | ctx->state = state; |
2821 | ctx->state = state; | ||
2822 | else | ||
2823 | nfs4_close_sync(state, fmode); | ||
2824 | out: | 2833 | out: |
2834 | put_nfs_open_context(ctx); | ||
2825 | return status; | 2835 | return status; |
2826 | } | 2836 | } |
2827 | 2837 | ||
@@ -5275,7 +5285,7 @@ static int _nfs4_proc_destroy_clientid(struct nfs_client *clp, | |||
5275 | 5285 | ||
5276 | status = rpc_call_sync(clp->cl_rpcclient, &msg, RPC_TASK_TIMEOUT); | 5286 | status = rpc_call_sync(clp->cl_rpcclient, &msg, RPC_TASK_TIMEOUT); |
5277 | if (status) | 5287 | if (status) |
5278 | pr_warn("NFS: Got error %d from the server %s on " | 5288 | dprintk("NFS: Got error %d from the server %s on " |
5279 | "DESTROY_CLIENTID.", status, clp->cl_hostname); | 5289 | "DESTROY_CLIENTID.", status, clp->cl_hostname); |
5280 | return status; | 5290 | return status; |
5281 | } | 5291 | } |
@@ -5746,8 +5756,7 @@ int nfs4_proc_destroy_session(struct nfs4_session *session, | |||
5746 | status = rpc_call_sync(session->clp->cl_rpcclient, &msg, RPC_TASK_TIMEOUT); | 5756 | status = rpc_call_sync(session->clp->cl_rpcclient, &msg, RPC_TASK_TIMEOUT); |
5747 | 5757 | ||
5748 | if (status) | 5758 | if (status) |
5749 | printk(KERN_WARNING | 5759 | dprintk("NFS: Got error %d from the server on DESTROY_SESSION. " |
5750 | "NFS: Got error %d from the server on DESTROY_SESSION. " | ||
5751 | "Session has been destroyed regardless...\n", status); | 5760 | "Session has been destroyed regardless...\n", status); |
5752 | 5761 | ||
5753 | dprintk("<-- nfs4_proc_destroy_session\n"); | 5762 | dprintk("<-- nfs4_proc_destroy_session\n"); |
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index c679b9ecef63..f38300e9f171 100644 --- a/fs/nfs/nfs4state.c +++ b/fs/nfs/nfs4state.c | |||
@@ -244,6 +244,16 @@ static int nfs4_begin_drain_session(struct nfs_client *clp) | |||
244 | return nfs4_wait_on_slot_tbl(&ses->fc_slot_table); | 244 | return nfs4_wait_on_slot_tbl(&ses->fc_slot_table); |
245 | } | 245 | } |
246 | 246 | ||
247 | static void nfs41_finish_session_reset(struct nfs_client *clp) | ||
248 | { | ||
249 | clear_bit(NFS4CLNT_LEASE_CONFIRM, &clp->cl_state); | ||
250 | clear_bit(NFS4CLNT_SESSION_RESET, &clp->cl_state); | ||
251 | /* create_session negotiated new slot table */ | ||
252 | clear_bit(NFS4CLNT_RECALL_SLOT, &clp->cl_state); | ||
253 | clear_bit(NFS4CLNT_BIND_CONN_TO_SESSION, &clp->cl_state); | ||
254 | nfs41_setup_state_renewal(clp); | ||
255 | } | ||
256 | |||
247 | int nfs41_init_clientid(struct nfs_client *clp, struct rpc_cred *cred) | 257 | int nfs41_init_clientid(struct nfs_client *clp, struct rpc_cred *cred) |
248 | { | 258 | { |
249 | int status; | 259 | int status; |
@@ -259,8 +269,7 @@ do_confirm: | |||
259 | status = nfs4_proc_create_session(clp, cred); | 269 | status = nfs4_proc_create_session(clp, cred); |
260 | if (status != 0) | 270 | if (status != 0) |
261 | goto out; | 271 | goto out; |
262 | clear_bit(NFS4CLNT_LEASE_CONFIRM, &clp->cl_state); | 272 | nfs41_finish_session_reset(clp); |
263 | nfs41_setup_state_renewal(clp); | ||
264 | nfs_mark_client_ready(clp, NFS_CS_READY); | 273 | nfs_mark_client_ready(clp, NFS_CS_READY); |
265 | out: | 274 | out: |
266 | return status; | 275 | return status; |
@@ -1772,16 +1781,9 @@ static int nfs4_reset_session(struct nfs_client *clp) | |||
1772 | status = nfs4_handle_reclaim_lease_error(clp, status); | 1781 | status = nfs4_handle_reclaim_lease_error(clp, status); |
1773 | goto out; | 1782 | goto out; |
1774 | } | 1783 | } |
1775 | clear_bit(NFS4CLNT_SESSION_RESET, &clp->cl_state); | 1784 | nfs41_finish_session_reset(clp); |
1776 | /* create_session negotiated new slot table */ | ||
1777 | clear_bit(NFS4CLNT_RECALL_SLOT, &clp->cl_state); | ||
1778 | clear_bit(NFS4CLNT_BIND_CONN_TO_SESSION, &clp->cl_state); | ||
1779 | dprintk("%s: session reset was successful for server %s!\n", | 1785 | dprintk("%s: session reset was successful for server %s!\n", |
1780 | __func__, clp->cl_hostname); | 1786 | __func__, clp->cl_hostname); |
1781 | |||
1782 | /* Let the state manager reestablish state */ | ||
1783 | if (!test_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state)) | ||
1784 | nfs41_setup_state_renewal(clp); | ||
1785 | out: | 1787 | out: |
1786 | if (cred) | 1788 | if (cred) |
1787 | put_rpccred(cred); | 1789 | put_rpccred(cred); |
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index ee4a74db95d0..18fae29b0301 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c | |||
@@ -1198,12 +1198,13 @@ static void encode_getfattr(struct xdr_stream *xdr, const u32* bitmask, struct c | |||
1198 | } | 1198 | } |
1199 | 1199 | ||
1200 | static void encode_getfattr_open(struct xdr_stream *xdr, const u32 *bitmask, | 1200 | static void encode_getfattr_open(struct xdr_stream *xdr, const u32 *bitmask, |
1201 | const u32 *open_bitmap, | ||
1201 | struct compound_hdr *hdr) | 1202 | struct compound_hdr *hdr) |
1202 | { | 1203 | { |
1203 | encode_getattr_three(xdr, | 1204 | encode_getattr_three(xdr, |
1204 | bitmask[0] & nfs4_fattr_bitmap[0], | 1205 | bitmask[0] & open_bitmap[0], |
1205 | bitmask[1] & nfs4_fattr_bitmap[1], | 1206 | bitmask[1] & open_bitmap[1], |
1206 | bitmask[2] & FATTR4_WORD2_MDSTHRESHOLD, | 1207 | bitmask[2] & open_bitmap[2], |
1207 | hdr); | 1208 | hdr); |
1208 | } | 1209 | } |
1209 | 1210 | ||
@@ -2221,7 +2222,7 @@ static void nfs4_xdr_enc_open(struct rpc_rqst *req, struct xdr_stream *xdr, | |||
2221 | encode_putfh(xdr, args->fh, &hdr); | 2222 | encode_putfh(xdr, args->fh, &hdr); |
2222 | encode_open(xdr, args, &hdr); | 2223 | encode_open(xdr, args, &hdr); |
2223 | encode_getfh(xdr, &hdr); | 2224 | encode_getfh(xdr, &hdr); |
2224 | encode_getfattr_open(xdr, args->bitmask, &hdr); | 2225 | encode_getfattr_open(xdr, args->bitmask, args->open_bitmap, &hdr); |
2225 | encode_nops(&hdr); | 2226 | encode_nops(&hdr); |
2226 | } | 2227 | } |
2227 | 2228 | ||
@@ -4359,7 +4360,10 @@ static int decode_attr_mdsthreshold(struct xdr_stream *xdr, | |||
4359 | 4360 | ||
4360 | if (unlikely(bitmap[2] & (FATTR4_WORD2_MDSTHRESHOLD - 1U))) | 4361 | if (unlikely(bitmap[2] & (FATTR4_WORD2_MDSTHRESHOLD - 1U))) |
4361 | return -EIO; | 4362 | return -EIO; |
4362 | if (likely(bitmap[2] & FATTR4_WORD2_MDSTHRESHOLD)) { | 4363 | if (bitmap[2] & FATTR4_WORD2_MDSTHRESHOLD) { |
4364 | /* Did the server return an unrequested attribute? */ | ||
4365 | if (unlikely(res == NULL)) | ||
4366 | return -EREMOTEIO; | ||
4363 | p = xdr_inline_decode(xdr, 4); | 4367 | p = xdr_inline_decode(xdr, 4); |
4364 | if (unlikely(!p)) | 4368 | if (unlikely(!p)) |
4365 | goto out_overflow; | 4369 | goto out_overflow; |
@@ -4372,6 +4376,7 @@ static int decode_attr_mdsthreshold(struct xdr_stream *xdr, | |||
4372 | __func__); | 4376 | __func__); |
4373 | 4377 | ||
4374 | status = decode_first_threshold_item4(xdr, res); | 4378 | status = decode_first_threshold_item4(xdr, res); |
4379 | bitmap[2] &= ~FATTR4_WORD2_MDSTHRESHOLD; | ||
4375 | } | 4380 | } |
4376 | return status; | 4381 | return status; |
4377 | out_overflow: | 4382 | out_overflow: |
diff --git a/fs/nfs/objlayout/objio_osd.c b/fs/nfs/objlayout/objio_osd.c index b47277baebab..f50d3e8d6f22 100644 --- a/fs/nfs/objlayout/objio_osd.c +++ b/fs/nfs/objlayout/objio_osd.c | |||
@@ -454,7 +454,10 @@ int objio_read_pagelist(struct nfs_read_data *rdata) | |||
454 | objios->ios->done = _read_done; | 454 | objios->ios->done = _read_done; |
455 | dprintk("%s: offset=0x%llx length=0x%x\n", __func__, | 455 | dprintk("%s: offset=0x%llx length=0x%x\n", __func__, |
456 | rdata->args.offset, rdata->args.count); | 456 | rdata->args.offset, rdata->args.count); |
457 | return ore_read(objios->ios); | 457 | ret = ore_read(objios->ios); |
458 | if (unlikely(ret)) | ||
459 | objio_free_result(&objios->oir); | ||
460 | return ret; | ||
458 | } | 461 | } |
459 | 462 | ||
460 | /* | 463 | /* |
@@ -486,8 +489,16 @@ static struct page *__r4w_get_page(void *priv, u64 offset, bool *uptodate) | |||
486 | struct nfs_write_data *wdata = objios->oir.rpcdata; | 489 | struct nfs_write_data *wdata = objios->oir.rpcdata; |
487 | struct address_space *mapping = wdata->header->inode->i_mapping; | 490 | struct address_space *mapping = wdata->header->inode->i_mapping; |
488 | pgoff_t index = offset / PAGE_SIZE; | 491 | pgoff_t index = offset / PAGE_SIZE; |
489 | struct page *page = find_get_page(mapping, index); | 492 | struct page *page; |
493 | loff_t i_size = i_size_read(wdata->header->inode); | ||
494 | |||
495 | if (offset >= i_size) { | ||
496 | *uptodate = true; | ||
497 | dprintk("%s: g_zero_page index=0x%lx\n", __func__, index); | ||
498 | return ZERO_PAGE(0); | ||
499 | } | ||
490 | 500 | ||
501 | page = find_get_page(mapping, index); | ||
491 | if (!page) { | 502 | if (!page) { |
492 | page = find_or_create_page(mapping, index, GFP_NOFS); | 503 | page = find_or_create_page(mapping, index, GFP_NOFS); |
493 | if (unlikely(!page)) { | 504 | if (unlikely(!page)) { |
@@ -507,8 +518,10 @@ static struct page *__r4w_get_page(void *priv, u64 offset, bool *uptodate) | |||
507 | 518 | ||
508 | static void __r4w_put_page(void *priv, struct page *page) | 519 | static void __r4w_put_page(void *priv, struct page *page) |
509 | { | 520 | { |
510 | dprintk("%s: index=0x%lx\n", __func__, page->index); | 521 | dprintk("%s: index=0x%lx\n", __func__, |
511 | page_cache_release(page); | 522 | (page == ZERO_PAGE(0)) ? -1UL : page->index); |
523 | if (ZERO_PAGE(0) != page) | ||
524 | page_cache_release(page); | ||
512 | return; | 525 | return; |
513 | } | 526 | } |
514 | 527 | ||
@@ -539,8 +552,10 @@ int objio_write_pagelist(struct nfs_write_data *wdata, int how) | |||
539 | dprintk("%s: offset=0x%llx length=0x%x\n", __func__, | 552 | dprintk("%s: offset=0x%llx length=0x%x\n", __func__, |
540 | wdata->args.offset, wdata->args.count); | 553 | wdata->args.offset, wdata->args.count); |
541 | ret = ore_write(objios->ios); | 554 | ret = ore_write(objios->ios); |
542 | if (unlikely(ret)) | 555 | if (unlikely(ret)) { |
556 | objio_free_result(&objios->oir); | ||
543 | return ret; | 557 | return ret; |
558 | } | ||
544 | 559 | ||
545 | if (objios->sync) | 560 | if (objios->sync) |
546 | _write_done(objios->ios, objios); | 561 | _write_done(objios->ios, objios); |
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c index b8323aa7b543..bbc49caa7a82 100644 --- a/fs/nfs/pnfs.c +++ b/fs/nfs/pnfs.c | |||
@@ -70,6 +70,10 @@ find_pnfs_driver(u32 id) | |||
70 | 70 | ||
71 | spin_lock(&pnfs_spinlock); | 71 | spin_lock(&pnfs_spinlock); |
72 | local = find_pnfs_driver_locked(id); | 72 | local = find_pnfs_driver_locked(id); |
73 | if (local != NULL && !try_module_get(local->owner)) { | ||
74 | dprintk("%s: Could not grab reference on module\n", __func__); | ||
75 | local = NULL; | ||
76 | } | ||
73 | spin_unlock(&pnfs_spinlock); | 77 | spin_unlock(&pnfs_spinlock); |
74 | return local; | 78 | return local; |
75 | } | 79 | } |
@@ -80,6 +84,9 @@ unset_pnfs_layoutdriver(struct nfs_server *nfss) | |||
80 | if (nfss->pnfs_curr_ld) { | 84 | if (nfss->pnfs_curr_ld) { |
81 | if (nfss->pnfs_curr_ld->clear_layoutdriver) | 85 | if (nfss->pnfs_curr_ld->clear_layoutdriver) |
82 | nfss->pnfs_curr_ld->clear_layoutdriver(nfss); | 86 | nfss->pnfs_curr_ld->clear_layoutdriver(nfss); |
87 | /* Decrement the MDS count. Purge the deviceid cache if zero */ | ||
88 | if (atomic_dec_and_test(&nfss->nfs_client->cl_mds_count)) | ||
89 | nfs4_deviceid_purge_client(nfss->nfs_client); | ||
83 | module_put(nfss->pnfs_curr_ld->owner); | 90 | module_put(nfss->pnfs_curr_ld->owner); |
84 | } | 91 | } |
85 | nfss->pnfs_curr_ld = NULL; | 92 | nfss->pnfs_curr_ld = NULL; |
@@ -115,10 +122,6 @@ set_pnfs_layoutdriver(struct nfs_server *server, const struct nfs_fh *mntfh, | |||
115 | goto out_no_driver; | 122 | goto out_no_driver; |
116 | } | 123 | } |
117 | } | 124 | } |
118 | if (!try_module_get(ld_type->owner)) { | ||
119 | dprintk("%s: Could not grab reference on module\n", __func__); | ||
120 | goto out_no_driver; | ||
121 | } | ||
122 | server->pnfs_curr_ld = ld_type; | 125 | server->pnfs_curr_ld = ld_type; |
123 | if (ld_type->set_layoutdriver | 126 | if (ld_type->set_layoutdriver |
124 | && ld_type->set_layoutdriver(server, mntfh)) { | 127 | && ld_type->set_layoutdriver(server, mntfh)) { |
@@ -127,6 +130,8 @@ set_pnfs_layoutdriver(struct nfs_server *server, const struct nfs_fh *mntfh, | |||
127 | module_put(ld_type->owner); | 130 | module_put(ld_type->owner); |
128 | goto out_no_driver; | 131 | goto out_no_driver; |
129 | } | 132 | } |
133 | /* Bump the MDS count */ | ||
134 | atomic_inc(&server->nfs_client->cl_mds_count); | ||
130 | 135 | ||
131 | dprintk("%s: pNFS module for %u set\n", __func__, id); | 136 | dprintk("%s: pNFS module for %u set\n", __func__, id); |
132 | return; | 137 | return; |
diff --git a/fs/nfs/pnfs.h b/fs/nfs/pnfs.h index 29fd23c0efdc..64f90d845f6a 100644 --- a/fs/nfs/pnfs.h +++ b/fs/nfs/pnfs.h | |||
@@ -365,7 +365,7 @@ static inline bool | |||
365 | pnfs_use_threshold(struct nfs4_threshold **dst, struct nfs4_threshold *src, | 365 | pnfs_use_threshold(struct nfs4_threshold **dst, struct nfs4_threshold *src, |
366 | struct nfs_server *nfss) | 366 | struct nfs_server *nfss) |
367 | { | 367 | { |
368 | return (dst && src && src->bm != 0 && | 368 | return (dst && src && src->bm != 0 && nfss->pnfs_curr_ld && |
369 | nfss->pnfs_curr_ld->id == src->l_type); | 369 | nfss->pnfs_curr_ld->id == src->l_type); |
370 | } | 370 | } |
371 | 371 | ||
diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index a706b6bcc286..4433806e116f 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c | |||
@@ -259,7 +259,7 @@ static void nfs_free_createdata(const struct nfs_createdata *data) | |||
259 | 259 | ||
260 | static int | 260 | static int |
261 | nfs_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, | 261 | nfs_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, |
262 | int flags, struct nfs_open_context *ctx) | 262 | int flags) |
263 | { | 263 | { |
264 | struct nfs_createdata *data; | 264 | struct nfs_createdata *data; |
265 | struct rpc_message msg = { | 265 | struct rpc_message msg = { |
@@ -651,7 +651,7 @@ static int nfs_read_done(struct rpc_task *task, struct nfs_read_data *data) | |||
651 | /* Emulate the eof flag, which isn't normally needed in NFSv2 | 651 | /* Emulate the eof flag, which isn't normally needed in NFSv2 |
652 | * as it is guaranteed to always return the file attributes | 652 | * as it is guaranteed to always return the file attributes |
653 | */ | 653 | */ |
654 | if (data->args.offset + data->args.count >= data->res.fattr->size) | 654 | if (data->args.offset + data->res.count >= data->res.fattr->size) |
655 | data->res.eof = 1; | 655 | data->res.eof = 1; |
656 | } | 656 | } |
657 | return 0; | 657 | return 0; |
diff --git a/fs/nfs/super.c b/fs/nfs/super.c index ff656c022684..8b2a2977b720 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c | |||
@@ -1867,6 +1867,7 @@ static int nfs23_validate_mount_data(void *options, | |||
1867 | if (data == NULL) | 1867 | if (data == NULL) |
1868 | goto out_no_data; | 1868 | goto out_no_data; |
1869 | 1869 | ||
1870 | args->version = NFS_DEFAULT_VERSION; | ||
1870 | switch (data->version) { | 1871 | switch (data->version) { |
1871 | case 1: | 1872 | case 1: |
1872 | data->namlen = 0; | 1873 | data->namlen = 0; |
@@ -2418,7 +2419,7 @@ static struct dentry *nfs_fs_mount_common(struct file_system_type *fs_type, | |||
2418 | sb_mntdata.mntflags |= MS_SYNCHRONOUS; | 2419 | sb_mntdata.mntflags |= MS_SYNCHRONOUS; |
2419 | 2420 | ||
2420 | /* Get a superblock - note that we may end up sharing one that already exists */ | 2421 | /* Get a superblock - note that we may end up sharing one that already exists */ |
2421 | s = sget(fs_type, compare_super, nfs_set_super, &sb_mntdata); | 2422 | s = sget(fs_type, compare_super, nfs_set_super, flags, &sb_mntdata); |
2422 | if (IS_ERR(s)) { | 2423 | if (IS_ERR(s)) { |
2423 | mntroot = ERR_CAST(s); | 2424 | mntroot = ERR_CAST(s); |
2424 | goto out_err_nosb; | 2425 | goto out_err_nosb; |
@@ -2637,6 +2638,8 @@ static int nfs4_validate_mount_data(void *options, | |||
2637 | if (data == NULL) | 2638 | if (data == NULL) |
2638 | goto out_no_data; | 2639 | goto out_no_data; |
2639 | 2640 | ||
2641 | args->version = 4; | ||
2642 | |||
2640 | switch (data->version) { | 2643 | switch (data->version) { |
2641 | case 1: | 2644 | case 1: |
2642 | if (data->host_addrlen > sizeof(args->nfs_server.address)) | 2645 | if (data->host_addrlen > sizeof(args->nfs_server.address)) |
@@ -2857,6 +2860,8 @@ static struct dentry *nfs4_try_mount(int flags, const char *dev_name, | |||
2857 | 2860 | ||
2858 | dfprintk(MOUNT, "--> nfs4_try_mount()\n"); | 2861 | dfprintk(MOUNT, "--> nfs4_try_mount()\n"); |
2859 | 2862 | ||
2863 | mount_info->fill_super = nfs4_fill_super; | ||
2864 | |||
2860 | export_path = data->nfs_server.export_path; | 2865 | export_path = data->nfs_server.export_path; |
2861 | data->nfs_server.export_path = "/"; | 2866 | data->nfs_server.export_path = "/"; |
2862 | root_mnt = nfs_do_root_mount(&nfs4_remote_fs_type, flags, mount_info, | 2867 | root_mnt = nfs_do_root_mount(&nfs4_remote_fs_type, flags, mount_info, |
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index e6fe3d69d14c..4d6861c0dc14 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c | |||
@@ -80,6 +80,7 @@ struct nfs_write_header *nfs_writehdr_alloc(void) | |||
80 | INIT_LIST_HEAD(&hdr->rpc_list); | 80 | INIT_LIST_HEAD(&hdr->rpc_list); |
81 | spin_lock_init(&hdr->lock); | 81 | spin_lock_init(&hdr->lock); |
82 | atomic_set(&hdr->refcnt, 0); | 82 | atomic_set(&hdr->refcnt, 0); |
83 | hdr->verf = &p->verf; | ||
83 | } | 84 | } |
84 | return p; | 85 | return p; |
85 | } | 86 | } |
@@ -619,6 +620,7 @@ static void nfs_write_completion(struct nfs_pgio_header *hdr) | |||
619 | goto next; | 620 | goto next; |
620 | } | 621 | } |
621 | if (test_bit(NFS_IOHDR_NEED_COMMIT, &hdr->flags)) { | 622 | if (test_bit(NFS_IOHDR_NEED_COMMIT, &hdr->flags)) { |
623 | memcpy(&req->wb_verf, hdr->verf, sizeof(req->wb_verf)); | ||
622 | nfs_mark_request_commit(req, hdr->lseg, &cinfo); | 624 | nfs_mark_request_commit(req, hdr->lseg, &cinfo); |
623 | goto next; | 625 | goto next; |
624 | } | 626 | } |
@@ -1255,15 +1257,14 @@ static void nfs_writeback_release_common(void *calldata) | |||
1255 | struct nfs_write_data *data = calldata; | 1257 | struct nfs_write_data *data = calldata; |
1256 | struct nfs_pgio_header *hdr = data->header; | 1258 | struct nfs_pgio_header *hdr = data->header; |
1257 | int status = data->task.tk_status; | 1259 | int status = data->task.tk_status; |
1258 | struct nfs_page *req = hdr->req; | ||
1259 | 1260 | ||
1260 | if ((status >= 0) && nfs_write_need_commit(data)) { | 1261 | if ((status >= 0) && nfs_write_need_commit(data)) { |
1261 | spin_lock(&hdr->lock); | 1262 | spin_lock(&hdr->lock); |
1262 | if (test_bit(NFS_IOHDR_NEED_RESCHED, &hdr->flags)) | 1263 | if (test_bit(NFS_IOHDR_NEED_RESCHED, &hdr->flags)) |
1263 | ; /* Do nothing */ | 1264 | ; /* Do nothing */ |
1264 | else if (!test_and_set_bit(NFS_IOHDR_NEED_COMMIT, &hdr->flags)) | 1265 | else if (!test_and_set_bit(NFS_IOHDR_NEED_COMMIT, &hdr->flags)) |
1265 | memcpy(&req->wb_verf, &data->verf, sizeof(req->wb_verf)); | 1266 | memcpy(hdr->verf, &data->verf, sizeof(*hdr->verf)); |
1266 | else if (memcmp(&req->wb_verf, &data->verf, sizeof(req->wb_verf))) | 1267 | else if (memcmp(hdr->verf, &data->verf, sizeof(*hdr->verf))) |
1267 | set_bit(NFS_IOHDR_NEED_RESCHED, &hdr->flags); | 1268 | set_bit(NFS_IOHDR_NEED_RESCHED, &hdr->flags); |
1268 | spin_unlock(&hdr->lock); | 1269 | spin_unlock(&hdr->lock); |
1269 | } | 1270 | } |
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 8fdc9ec5c5d3..94effd5bc4a1 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c | |||
@@ -900,7 +900,7 @@ static void free_session(struct kref *kref) | |||
900 | struct nfsd4_session *ses; | 900 | struct nfsd4_session *ses; |
901 | int mem; | 901 | int mem; |
902 | 902 | ||
903 | BUG_ON(!spin_is_locked(&client_lock)); | 903 | lockdep_assert_held(&client_lock); |
904 | ses = container_of(kref, struct nfsd4_session, se_ref); | 904 | ses = container_of(kref, struct nfsd4_session, se_ref); |
905 | nfsd4_del_conns(ses); | 905 | nfsd4_del_conns(ses); |
906 | spin_lock(&nfsd_drc_lock); | 906 | spin_lock(&nfsd_drc_lock); |
@@ -1080,7 +1080,7 @@ static struct nfs4_client *alloc_client(struct xdr_netobj name) | |||
1080 | static inline void | 1080 | static inline void |
1081 | free_client(struct nfs4_client *clp) | 1081 | free_client(struct nfs4_client *clp) |
1082 | { | 1082 | { |
1083 | BUG_ON(!spin_is_locked(&client_lock)); | 1083 | lockdep_assert_held(&client_lock); |
1084 | while (!list_empty(&clp->cl_sessions)) { | 1084 | while (!list_empty(&clp->cl_sessions)) { |
1085 | struct nfsd4_session *ses; | 1085 | struct nfsd4_session *ses; |
1086 | ses = list_entry(clp->cl_sessions.next, struct nfsd4_session, | 1086 | ses = list_entry(clp->cl_sessions.next, struct nfsd4_session, |
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index c8bd9c3be7f7..4700a0a929d7 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -745,7 +745,7 @@ __be32 | |||
745 | nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, | 745 | nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, |
746 | int may_flags, struct file **filp) | 746 | int may_flags, struct file **filp) |
747 | { | 747 | { |
748 | struct dentry *dentry; | 748 | struct path path; |
749 | struct inode *inode; | 749 | struct inode *inode; |
750 | int flags = O_RDONLY|O_LARGEFILE; | 750 | int flags = O_RDONLY|O_LARGEFILE; |
751 | __be32 err; | 751 | __be32 err; |
@@ -762,8 +762,9 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, | |||
762 | if (err) | 762 | if (err) |
763 | goto out; | 763 | goto out; |
764 | 764 | ||
765 | dentry = fhp->fh_dentry; | 765 | path.mnt = fhp->fh_export->ex_path.mnt; |
766 | inode = dentry->d_inode; | 766 | path.dentry = fhp->fh_dentry; |
767 | inode = path.dentry->d_inode; | ||
767 | 768 | ||
768 | /* Disallow write access to files with the append-only bit set | 769 | /* Disallow write access to files with the append-only bit set |
769 | * or any access when mandatory locking enabled | 770 | * or any access when mandatory locking enabled |
@@ -792,8 +793,7 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, | |||
792 | else | 793 | else |
793 | flags = O_WRONLY|O_LARGEFILE; | 794 | flags = O_WRONLY|O_LARGEFILE; |
794 | } | 795 | } |
795 | *filp = dentry_open(dget(dentry), mntget(fhp->fh_export->ex_path.mnt), | 796 | *filp = dentry_open(&path, flags, current_cred()); |
796 | flags, current_cred()); | ||
797 | if (IS_ERR(*filp)) | 797 | if (IS_ERR(*filp)) |
798 | host_err = PTR_ERR(*filp); | 798 | host_err = PTR_ERR(*filp); |
799 | else { | 799 | else { |
@@ -1329,7 +1329,7 @@ nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, | |||
1329 | err = 0; | 1329 | err = 0; |
1330 | switch (type) { | 1330 | switch (type) { |
1331 | case S_IFREG: | 1331 | case S_IFREG: |
1332 | host_err = vfs_create(dirp, dchild, iap->ia_mode, NULL); | 1332 | host_err = vfs_create(dirp, dchild, iap->ia_mode, true); |
1333 | if (!host_err) | 1333 | if (!host_err) |
1334 | nfsd_check_ignore_resizing(iap); | 1334 | nfsd_check_ignore_resizing(iap); |
1335 | break; | 1335 | break; |
@@ -1492,7 +1492,7 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, | |||
1492 | goto out; | 1492 | goto out; |
1493 | } | 1493 | } |
1494 | 1494 | ||
1495 | host_err = vfs_create(dirp, dchild, iap->ia_mode, NULL); | 1495 | host_err = vfs_create(dirp, dchild, iap->ia_mode, true); |
1496 | if (host_err < 0) { | 1496 | if (host_err < 0) { |
1497 | fh_drop_write(fhp); | 1497 | fh_drop_write(fhp); |
1498 | goto out_nfserr; | 1498 | goto out_nfserr; |
diff --git a/fs/nilfs2/gcinode.c b/fs/nilfs2/gcinode.c index 08a07a218d26..57ceaf33d177 100644 --- a/fs/nilfs2/gcinode.c +++ b/fs/nilfs2/gcinode.c | |||
@@ -191,6 +191,8 @@ void nilfs_remove_all_gcinodes(struct the_nilfs *nilfs) | |||
191 | while (!list_empty(head)) { | 191 | while (!list_empty(head)) { |
192 | ii = list_first_entry(head, struct nilfs_inode_info, i_dirty); | 192 | ii = list_first_entry(head, struct nilfs_inode_info, i_dirty); |
193 | list_del_init(&ii->i_dirty); | 193 | list_del_init(&ii->i_dirty); |
194 | truncate_inode_pages(&ii->vfs_inode.i_data, 0); | ||
195 | nilfs_btnode_cache_clear(&ii->i_btnode_cache); | ||
194 | iput(&ii->vfs_inode); | 196 | iput(&ii->vfs_inode); |
195 | } | 197 | } |
196 | } | 198 | } |
diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index b72847988b78..1d0c0b84c5a3 100644 --- a/fs/nilfs2/namei.c +++ b/fs/nilfs2/namei.c | |||
@@ -63,7 +63,7 @@ static inline int nilfs_add_nondir(struct dentry *dentry, struct inode *inode) | |||
63 | */ | 63 | */ |
64 | 64 | ||
65 | static struct dentry * | 65 | static struct dentry * |
66 | nilfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 66 | nilfs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
67 | { | 67 | { |
68 | struct inode *inode; | 68 | struct inode *inode; |
69 | ino_t ino; | 69 | ino_t ino; |
@@ -85,7 +85,7 @@ nilfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | |||
85 | * with d_instantiate(). | 85 | * with d_instantiate(). |
86 | */ | 86 | */ |
87 | static int nilfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 87 | static int nilfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
88 | struct nameidata *nd) | 88 | bool excl) |
89 | { | 89 | { |
90 | struct inode *inode; | 90 | struct inode *inode; |
91 | struct nilfs_transaction_info ti; | 91 | struct nilfs_transaction_info ti; |
diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 0e72ad6f22aa..88e11fb346b6 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c | |||
@@ -2309,6 +2309,8 @@ nilfs_remove_written_gcinodes(struct the_nilfs *nilfs, struct list_head *head) | |||
2309 | if (!test_bit(NILFS_I_UPDATED, &ii->i_state)) | 2309 | if (!test_bit(NILFS_I_UPDATED, &ii->i_state)) |
2310 | continue; | 2310 | continue; |
2311 | list_del_init(&ii->i_dirty); | 2311 | list_del_init(&ii->i_dirty); |
2312 | truncate_inode_pages(&ii->vfs_inode.i_data, 0); | ||
2313 | nilfs_btnode_cache_clear(&ii->i_btnode_cache); | ||
2312 | iput(&ii->vfs_inode); | 2314 | iput(&ii->vfs_inode); |
2313 | } | 2315 | } |
2314 | } | 2316 | } |
diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 1099a76cee59..d57c42f974ea 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c | |||
@@ -1288,7 +1288,8 @@ nilfs_mount(struct file_system_type *fs_type, int flags, | |||
1288 | err = -EBUSY; | 1288 | err = -EBUSY; |
1289 | goto failed; | 1289 | goto failed; |
1290 | } | 1290 | } |
1291 | s = sget(fs_type, nilfs_test_bdev_super, nilfs_set_bdev_super, sd.bdev); | 1291 | s = sget(fs_type, nilfs_test_bdev_super, nilfs_set_bdev_super, flags, |
1292 | sd.bdev); | ||
1292 | mutex_unlock(&sd.bdev->bd_fsfreeze_mutex); | 1293 | mutex_unlock(&sd.bdev->bd_fsfreeze_mutex); |
1293 | if (IS_ERR(s)) { | 1294 | if (IS_ERR(s)) { |
1294 | err = PTR_ERR(s); | 1295 | err = PTR_ERR(s); |
@@ -1301,7 +1302,6 @@ nilfs_mount(struct file_system_type *fs_type, int flags, | |||
1301 | s_new = true; | 1302 | s_new = true; |
1302 | 1303 | ||
1303 | /* New superblock instance created */ | 1304 | /* New superblock instance created */ |
1304 | s->s_flags = flags; | ||
1305 | s->s_mode = mode; | 1305 | s->s_mode = mode; |
1306 | strlcpy(s->s_id, bdevname(sd.bdev, b), sizeof(s->s_id)); | 1306 | strlcpy(s->s_id, bdevname(sd.bdev, b), sizeof(s->s_id)); |
1307 | sb_set_blocksize(s, block_size(sd.bdev)); | 1307 | sb_set_blocksize(s, block_size(sd.bdev)); |
diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c index 3568c8a8b138..d43803669739 100644 --- a/fs/notify/fanotify/fanotify_user.c +++ b/fs/notify/fanotify/fanotify_user.c | |||
@@ -61,8 +61,6 @@ static struct fsnotify_event *get_one_event(struct fsnotify_group *group, | |||
61 | static int create_fd(struct fsnotify_group *group, struct fsnotify_event *event) | 61 | static int create_fd(struct fsnotify_group *group, struct fsnotify_event *event) |
62 | { | 62 | { |
63 | int client_fd; | 63 | int client_fd; |
64 | struct dentry *dentry; | ||
65 | struct vfsmount *mnt; | ||
66 | struct file *new_file; | 64 | struct file *new_file; |
67 | 65 | ||
68 | pr_debug("%s: group=%p event=%p\n", __func__, group, event); | 66 | pr_debug("%s: group=%p event=%p\n", __func__, group, event); |
@@ -81,12 +79,10 @@ static int create_fd(struct fsnotify_group *group, struct fsnotify_event *event) | |||
81 | * we need a new file handle for the userspace program so it can read even if it was | 79 | * we need a new file handle for the userspace program so it can read even if it was |
82 | * originally opened O_WRONLY. | 80 | * originally opened O_WRONLY. |
83 | */ | 81 | */ |
84 | dentry = dget(event->path.dentry); | ||
85 | mnt = mntget(event->path.mnt); | ||
86 | /* it's possible this event was an overflow event. in that case dentry and mnt | 82 | /* it's possible this event was an overflow event. in that case dentry and mnt |
87 | * are NULL; That's fine, just don't call dentry open */ | 83 | * are NULL; That's fine, just don't call dentry open */ |
88 | if (dentry && mnt) | 84 | if (event->path.dentry && event->path.mnt) |
89 | new_file = dentry_open(dentry, mnt, | 85 | new_file = dentry_open(&event->path, |
90 | group->fanotify_data.f_flags | FMODE_NONOTIFY, | 86 | group->fanotify_data.f_flags | FMODE_NONOTIFY, |
91 | current_cred()); | 87 | current_cred()); |
92 | else | 88 | else |
diff --git a/fs/notify/fsnotify.c b/fs/notify/fsnotify.c index b39c5c161adb..6baadb5a8430 100644 --- a/fs/notify/fsnotify.c +++ b/fs/notify/fsnotify.c | |||
@@ -52,6 +52,7 @@ void __fsnotify_vfsmount_delete(struct vfsmount *mnt) | |||
52 | void __fsnotify_update_child_dentry_flags(struct inode *inode) | 52 | void __fsnotify_update_child_dentry_flags(struct inode *inode) |
53 | { | 53 | { |
54 | struct dentry *alias; | 54 | struct dentry *alias; |
55 | struct hlist_node *p; | ||
55 | int watched; | 56 | int watched; |
56 | 57 | ||
57 | if (!S_ISDIR(inode->i_mode)) | 58 | if (!S_ISDIR(inode->i_mode)) |
@@ -63,7 +64,7 @@ void __fsnotify_update_child_dentry_flags(struct inode *inode) | |||
63 | spin_lock(&inode->i_lock); | 64 | spin_lock(&inode->i_lock); |
64 | /* run all of the dentries associated with this inode. Since this is a | 65 | /* run all of the dentries associated with this inode. Since this is a |
65 | * directory, there damn well better only be one item on this list */ | 66 | * directory, there damn well better only be one item on this list */ |
66 | list_for_each_entry(alias, &inode->i_dentry, d_alias) { | 67 | hlist_for_each_entry(alias, p, &inode->i_dentry, d_alias) { |
67 | struct dentry *child; | 68 | struct dentry *child; |
68 | 69 | ||
69 | /* run all of the children of the original inode and fix their | 70 | /* run all of the children of the original inode and fix their |
diff --git a/fs/ntfs/namei.c b/fs/ntfs/namei.c index 358273e59ade..436f36037e09 100644 --- a/fs/ntfs/namei.c +++ b/fs/ntfs/namei.c | |||
@@ -101,7 +101,7 @@ | |||
101 | * Locking: Caller must hold i_mutex on the directory. | 101 | * Locking: Caller must hold i_mutex on the directory. |
102 | */ | 102 | */ |
103 | static struct dentry *ntfs_lookup(struct inode *dir_ino, struct dentry *dent, | 103 | static struct dentry *ntfs_lookup(struct inode *dir_ino, struct dentry *dent, |
104 | struct nameidata *nd) | 104 | unsigned int flags) |
105 | { | 105 | { |
106 | ntfs_volume *vol = NTFS_SB(dir_ino->i_sb); | 106 | ntfs_volume *vol = NTFS_SB(dir_ino->i_sb); |
107 | struct inode *dent_inode; | 107 | struct inode *dent_inode; |
diff --git a/fs/ocfs2/dcache.c b/fs/ocfs2/dcache.c index e5ba34818332..8db4b58b2e4b 100644 --- a/fs/ocfs2/dcache.c +++ b/fs/ocfs2/dcache.c | |||
@@ -49,14 +49,13 @@ void ocfs2_dentry_attach_gen(struct dentry *dentry) | |||
49 | } | 49 | } |
50 | 50 | ||
51 | 51 | ||
52 | static int ocfs2_dentry_revalidate(struct dentry *dentry, | 52 | static int ocfs2_dentry_revalidate(struct dentry *dentry, unsigned int flags) |
53 | struct nameidata *nd) | ||
54 | { | 53 | { |
55 | struct inode *inode; | 54 | struct inode *inode; |
56 | int ret = 0; /* if all else fails, just return false */ | 55 | int ret = 0; /* if all else fails, just return false */ |
57 | struct ocfs2_super *osb; | 56 | struct ocfs2_super *osb; |
58 | 57 | ||
59 | if (nd && nd->flags & LOOKUP_RCU) | 58 | if (flags & LOOKUP_RCU) |
60 | return -ECHILD; | 59 | return -ECHILD; |
61 | 60 | ||
62 | inode = dentry->d_inode; | 61 | inode = dentry->d_inode; |
@@ -170,13 +169,11 @@ struct dentry *ocfs2_find_local_alias(struct inode *inode, | |||
170 | u64 parent_blkno, | 169 | u64 parent_blkno, |
171 | int skip_unhashed) | 170 | int skip_unhashed) |
172 | { | 171 | { |
173 | struct list_head *p; | 172 | struct hlist_node *p; |
174 | struct dentry *dentry = NULL; | 173 | struct dentry *dentry; |
175 | 174 | ||
176 | spin_lock(&inode->i_lock); | 175 | spin_lock(&inode->i_lock); |
177 | list_for_each(p, &inode->i_dentry) { | 176 | hlist_for_each_entry(dentry, p, &inode->i_dentry, d_alias) { |
178 | dentry = list_entry(p, struct dentry, d_alias); | ||
179 | |||
180 | spin_lock(&dentry->d_lock); | 177 | spin_lock(&dentry->d_lock); |
181 | if (ocfs2_match_dentry(dentry, parent_blkno, skip_unhashed)) { | 178 | if (ocfs2_match_dentry(dentry, parent_blkno, skip_unhashed)) { |
182 | trace_ocfs2_find_local_alias(dentry->d_name.len, | 179 | trace_ocfs2_find_local_alias(dentry->d_name.len, |
@@ -184,16 +181,13 @@ struct dentry *ocfs2_find_local_alias(struct inode *inode, | |||
184 | 181 | ||
185 | dget_dlock(dentry); | 182 | dget_dlock(dentry); |
186 | spin_unlock(&dentry->d_lock); | 183 | spin_unlock(&dentry->d_lock); |
187 | break; | 184 | spin_unlock(&inode->i_lock); |
185 | return dentry; | ||
188 | } | 186 | } |
189 | spin_unlock(&dentry->d_lock); | 187 | spin_unlock(&dentry->d_lock); |
190 | |||
191 | dentry = NULL; | ||
192 | } | 188 | } |
193 | |||
194 | spin_unlock(&inode->i_lock); | 189 | spin_unlock(&inode->i_lock); |
195 | 190 | return NULL; | |
196 | return dentry; | ||
197 | } | 191 | } |
198 | 192 | ||
199 | DEFINE_SPINLOCK(dentry_attach_lock); | 193 | DEFINE_SPINLOCK(dentry_attach_lock); |
diff --git a/fs/ocfs2/dlmfs/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c index e31d6ae013ab..83b6f98e0665 100644 --- a/fs/ocfs2/dlmfs/dlmfs.c +++ b/fs/ocfs2/dlmfs/dlmfs.c | |||
@@ -526,7 +526,7 @@ bail: | |||
526 | static int dlmfs_create(struct inode *dir, | 526 | static int dlmfs_create(struct inode *dir, |
527 | struct dentry *dentry, | 527 | struct dentry *dentry, |
528 | umode_t mode, | 528 | umode_t mode, |
529 | struct nameidata *nd) | 529 | bool excl) |
530 | { | 530 | { |
531 | int status = 0; | 531 | int status = 0; |
532 | struct inode *inode; | 532 | struct inode *inode; |
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 81a4cd22f80b..4f7795fb5fc0 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
@@ -456,7 +456,7 @@ static void ocfs2_update_lock_stats(struct ocfs2_lock_res *res, int level, | |||
456 | stats->ls_gets++; | 456 | stats->ls_gets++; |
457 | stats->ls_total += ktime_to_ns(kt); | 457 | stats->ls_total += ktime_to_ns(kt); |
458 | /* overflow */ | 458 | /* overflow */ |
459 | if (unlikely(stats->ls_gets) == 0) { | 459 | if (unlikely(stats->ls_gets == 0)) { |
460 | stats->ls_gets++; | 460 | stats->ls_gets++; |
461 | stats->ls_total = ktime_to_ns(kt); | 461 | stats->ls_total = ktime_to_ns(kt); |
462 | } | 462 | } |
@@ -3932,6 +3932,8 @@ unqueue: | |||
3932 | static void ocfs2_schedule_blocked_lock(struct ocfs2_super *osb, | 3932 | static void ocfs2_schedule_blocked_lock(struct ocfs2_super *osb, |
3933 | struct ocfs2_lock_res *lockres) | 3933 | struct ocfs2_lock_res *lockres) |
3934 | { | 3934 | { |
3935 | unsigned long flags; | ||
3936 | |||
3935 | assert_spin_locked(&lockres->l_lock); | 3937 | assert_spin_locked(&lockres->l_lock); |
3936 | 3938 | ||
3937 | if (lockres->l_flags & OCFS2_LOCK_FREEING) { | 3939 | if (lockres->l_flags & OCFS2_LOCK_FREEING) { |
@@ -3945,21 +3947,22 @@ static void ocfs2_schedule_blocked_lock(struct ocfs2_super *osb, | |||
3945 | 3947 | ||
3946 | lockres_or_flags(lockres, OCFS2_LOCK_QUEUED); | 3948 | lockres_or_flags(lockres, OCFS2_LOCK_QUEUED); |
3947 | 3949 | ||
3948 | spin_lock(&osb->dc_task_lock); | 3950 | spin_lock_irqsave(&osb->dc_task_lock, flags); |
3949 | if (list_empty(&lockres->l_blocked_list)) { | 3951 | if (list_empty(&lockres->l_blocked_list)) { |
3950 | list_add_tail(&lockres->l_blocked_list, | 3952 | list_add_tail(&lockres->l_blocked_list, |
3951 | &osb->blocked_lock_list); | 3953 | &osb->blocked_lock_list); |
3952 | osb->blocked_lock_count++; | 3954 | osb->blocked_lock_count++; |
3953 | } | 3955 | } |
3954 | spin_unlock(&osb->dc_task_lock); | 3956 | spin_unlock_irqrestore(&osb->dc_task_lock, flags); |
3955 | } | 3957 | } |
3956 | 3958 | ||
3957 | static void ocfs2_downconvert_thread_do_work(struct ocfs2_super *osb) | 3959 | static void ocfs2_downconvert_thread_do_work(struct ocfs2_super *osb) |
3958 | { | 3960 | { |
3959 | unsigned long processed; | 3961 | unsigned long processed; |
3962 | unsigned long flags; | ||
3960 | struct ocfs2_lock_res *lockres; | 3963 | struct ocfs2_lock_res *lockres; |
3961 | 3964 | ||
3962 | spin_lock(&osb->dc_task_lock); | 3965 | spin_lock_irqsave(&osb->dc_task_lock, flags); |
3963 | /* grab this early so we know to try again if a state change and | 3966 | /* grab this early so we know to try again if a state change and |
3964 | * wake happens part-way through our work */ | 3967 | * wake happens part-way through our work */ |
3965 | osb->dc_work_sequence = osb->dc_wake_sequence; | 3968 | osb->dc_work_sequence = osb->dc_wake_sequence; |
@@ -3972,38 +3975,40 @@ static void ocfs2_downconvert_thread_do_work(struct ocfs2_super *osb) | |||
3972 | struct ocfs2_lock_res, l_blocked_list); | 3975 | struct ocfs2_lock_res, l_blocked_list); |
3973 | list_del_init(&lockres->l_blocked_list); | 3976 | list_del_init(&lockres->l_blocked_list); |
3974 | osb->blocked_lock_count--; | 3977 | osb->blocked_lock_count--; |
3975 | spin_unlock(&osb->dc_task_lock); | 3978 | spin_unlock_irqrestore(&osb->dc_task_lock, flags); |
3976 | 3979 | ||
3977 | BUG_ON(!processed); | 3980 | BUG_ON(!processed); |
3978 | processed--; | 3981 | processed--; |
3979 | 3982 | ||
3980 | ocfs2_process_blocked_lock(osb, lockres); | 3983 | ocfs2_process_blocked_lock(osb, lockres); |
3981 | 3984 | ||
3982 | spin_lock(&osb->dc_task_lock); | 3985 | spin_lock_irqsave(&osb->dc_task_lock, flags); |
3983 | } | 3986 | } |
3984 | spin_unlock(&osb->dc_task_lock); | 3987 | spin_unlock_irqrestore(&osb->dc_task_lock, flags); |
3985 | } | 3988 | } |
3986 | 3989 | ||
3987 | static int ocfs2_downconvert_thread_lists_empty(struct ocfs2_super *osb) | 3990 | static int ocfs2_downconvert_thread_lists_empty(struct ocfs2_super *osb) |
3988 | { | 3991 | { |
3989 | int empty = 0; | 3992 | int empty = 0; |
3993 | unsigned long flags; | ||
3990 | 3994 | ||
3991 | spin_lock(&osb->dc_task_lock); | 3995 | spin_lock_irqsave(&osb->dc_task_lock, flags); |
3992 | if (list_empty(&osb->blocked_lock_list)) | 3996 | if (list_empty(&osb->blocked_lock_list)) |
3993 | empty = 1; | 3997 | empty = 1; |
3994 | 3998 | ||
3995 | spin_unlock(&osb->dc_task_lock); | 3999 | spin_unlock_irqrestore(&osb->dc_task_lock, flags); |
3996 | return empty; | 4000 | return empty; |
3997 | } | 4001 | } |
3998 | 4002 | ||
3999 | static int ocfs2_downconvert_thread_should_wake(struct ocfs2_super *osb) | 4003 | static int ocfs2_downconvert_thread_should_wake(struct ocfs2_super *osb) |
4000 | { | 4004 | { |
4001 | int should_wake = 0; | 4005 | int should_wake = 0; |
4006 | unsigned long flags; | ||
4002 | 4007 | ||
4003 | spin_lock(&osb->dc_task_lock); | 4008 | spin_lock_irqsave(&osb->dc_task_lock, flags); |
4004 | if (osb->dc_work_sequence != osb->dc_wake_sequence) | 4009 | if (osb->dc_work_sequence != osb->dc_wake_sequence) |
4005 | should_wake = 1; | 4010 | should_wake = 1; |
4006 | spin_unlock(&osb->dc_task_lock); | 4011 | spin_unlock_irqrestore(&osb->dc_task_lock, flags); |
4007 | 4012 | ||
4008 | return should_wake; | 4013 | return should_wake; |
4009 | } | 4014 | } |
@@ -4033,10 +4038,12 @@ static int ocfs2_downconvert_thread(void *arg) | |||
4033 | 4038 | ||
4034 | void ocfs2_wake_downconvert_thread(struct ocfs2_super *osb) | 4039 | void ocfs2_wake_downconvert_thread(struct ocfs2_super *osb) |
4035 | { | 4040 | { |
4036 | spin_lock(&osb->dc_task_lock); | 4041 | unsigned long flags; |
4042 | |||
4043 | spin_lock_irqsave(&osb->dc_task_lock, flags); | ||
4037 | /* make sure the voting thread gets a swipe at whatever changes | 4044 | /* make sure the voting thread gets a swipe at whatever changes |
4038 | * the caller may have made to the voting state */ | 4045 | * the caller may have made to the voting state */ |
4039 | osb->dc_wake_sequence++; | 4046 | osb->dc_wake_sequence++; |
4040 | spin_unlock(&osb->dc_task_lock); | 4047 | spin_unlock_irqrestore(&osb->dc_task_lock, flags); |
4041 | wake_up(&osb->dc_event); | 4048 | wake_up(&osb->dc_event); |
4042 | } | 4049 | } |
diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c index 2f5b92ef0e53..70b5863a2d64 100644 --- a/fs/ocfs2/extent_map.c +++ b/fs/ocfs2/extent_map.c | |||
@@ -923,8 +923,6 @@ out_unlock: | |||
923 | 923 | ||
924 | ocfs2_inode_unlock(inode, 0); | 924 | ocfs2_inode_unlock(inode, 0); |
925 | out: | 925 | out: |
926 | if (ret && ret != -ENXIO) | ||
927 | ret = -ENXIO; | ||
928 | return ret; | 926 | return ret; |
929 | } | 927 | } |
930 | 928 | ||
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 061591a3ab08..7602783d7f41 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c | |||
@@ -1950,7 +1950,7 @@ static int __ocfs2_change_file_space(struct file *file, struct inode *inode, | |||
1950 | if (ret < 0) | 1950 | if (ret < 0) |
1951 | mlog_errno(ret); | 1951 | mlog_errno(ret); |
1952 | 1952 | ||
1953 | if (file->f_flags & O_SYNC) | 1953 | if (file && (file->f_flags & O_SYNC)) |
1954 | handle->h_sync = 1; | 1954 | handle->h_sync = 1; |
1955 | 1955 | ||
1956 | ocfs2_commit_trans(osb, handle); | 1956 | ocfs2_commit_trans(osb, handle); |
@@ -2422,8 +2422,10 @@ out_dio: | |||
2422 | unaligned_dio = 0; | 2422 | unaligned_dio = 0; |
2423 | } | 2423 | } |
2424 | 2424 | ||
2425 | if (unaligned_dio) | 2425 | if (unaligned_dio) { |
2426 | ocfs2_iocb_clear_unaligned_aio(iocb); | ||
2426 | atomic_dec(&OCFS2_I(inode)->ip_unaligned_aio); | 2427 | atomic_dec(&OCFS2_I(inode)->ip_unaligned_aio); |
2428 | } | ||
2427 | 2429 | ||
2428 | out: | 2430 | out: |
2429 | if (rw_level != -1) | 2431 | if (rw_level != -1) |
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 9f39c640cddf..f1fd0741162b 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c | |||
@@ -98,7 +98,7 @@ static int ocfs2_create_symlink_data(struct ocfs2_super *osb, | |||
98 | #define OCFS2_ORPHAN_NAMELEN ((int)(2 * sizeof(u64))) | 98 | #define OCFS2_ORPHAN_NAMELEN ((int)(2 * sizeof(u64))) |
99 | 99 | ||
100 | static struct dentry *ocfs2_lookup(struct inode *dir, struct dentry *dentry, | 100 | static struct dentry *ocfs2_lookup(struct inode *dir, struct dentry *dentry, |
101 | struct nameidata *nd) | 101 | unsigned int flags) |
102 | { | 102 | { |
103 | int status; | 103 | int status; |
104 | u64 blkno; | 104 | u64 blkno; |
@@ -618,7 +618,7 @@ static int ocfs2_mkdir(struct inode *dir, | |||
618 | static int ocfs2_create(struct inode *dir, | 618 | static int ocfs2_create(struct inode *dir, |
619 | struct dentry *dentry, | 619 | struct dentry *dentry, |
620 | umode_t mode, | 620 | umode_t mode, |
621 | struct nameidata *nd) | 621 | bool excl) |
622 | { | 622 | { |
623 | int ret; | 623 | int ret; |
624 | 624 | ||
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index 92fcd575775a..0a86e302655f 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c | |||
@@ -399,8 +399,6 @@ int ocfs2_global_read_info(struct super_block *sb, int type) | |||
399 | msecs_to_jiffies(oinfo->dqi_syncms)); | 399 | msecs_to_jiffies(oinfo->dqi_syncms)); |
400 | 400 | ||
401 | out_err: | 401 | out_err: |
402 | if (status) | ||
403 | mlog_errno(status); | ||
404 | return status; | 402 | return status; |
405 | out_unlock: | 403 | out_unlock: |
406 | ocfs2_unlock_global_qf(oinfo, 0); | 404 | ocfs2_unlock_global_qf(oinfo, 0); |
diff --git a/fs/omfs/dir.c b/fs/omfs/dir.c index f00576ec320f..fb5b3ff79dc6 100644 --- a/fs/omfs/dir.c +++ b/fs/omfs/dir.c | |||
@@ -285,13 +285,13 @@ static int omfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) | |||
285 | } | 285 | } |
286 | 286 | ||
287 | static int omfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 287 | static int omfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
288 | struct nameidata *nd) | 288 | bool excl) |
289 | { | 289 | { |
290 | return omfs_add_node(dir, dentry, mode | S_IFREG); | 290 | return omfs_add_node(dir, dentry, mode | S_IFREG); |
291 | } | 291 | } |
292 | 292 | ||
293 | static struct dentry *omfs_lookup(struct inode *dir, struct dentry *dentry, | 293 | static struct dentry *omfs_lookup(struct inode *dir, struct dentry *dentry, |
294 | struct nameidata *nd) | 294 | unsigned int flags) |
295 | { | 295 | { |
296 | struct buffer_head *bh; | 296 | struct buffer_head *bh; |
297 | struct inode *inode = NULL; | 297 | struct inode *inode = NULL; |
@@ -397,10 +397,10 @@ SYSCALL_DEFINE1(fchdir, unsigned int, fd) | |||
397 | { | 397 | { |
398 | struct file *file; | 398 | struct file *file; |
399 | struct inode *inode; | 399 | struct inode *inode; |
400 | int error; | 400 | int error, fput_needed; |
401 | 401 | ||
402 | error = -EBADF; | 402 | error = -EBADF; |
403 | file = fget(fd); | 403 | file = fget_raw_light(fd, &fput_needed); |
404 | if (!file) | 404 | if (!file) |
405 | goto out; | 405 | goto out; |
406 | 406 | ||
@@ -414,7 +414,7 @@ SYSCALL_DEFINE1(fchdir, unsigned int, fd) | |||
414 | if (!error) | 414 | if (!error) |
415 | set_fs_pwd(current->fs, &file->f_path); | 415 | set_fs_pwd(current->fs, &file->f_path); |
416 | out_putf: | 416 | out_putf: |
417 | fput(file); | 417 | fput_light(file, fput_needed); |
418 | out: | 418 | out: |
419 | return error; | 419 | return error; |
420 | } | 420 | } |
@@ -537,25 +537,6 @@ static int chown_common(struct path *path, uid_t user, gid_t group) | |||
537 | return error; | 537 | return error; |
538 | } | 538 | } |
539 | 539 | ||
540 | SYSCALL_DEFINE3(chown, const char __user *, filename, uid_t, user, gid_t, group) | ||
541 | { | ||
542 | struct path path; | ||
543 | int error; | ||
544 | |||
545 | error = user_path(filename, &path); | ||
546 | if (error) | ||
547 | goto out; | ||
548 | error = mnt_want_write(path.mnt); | ||
549 | if (error) | ||
550 | goto out_release; | ||
551 | error = chown_common(&path, user, group); | ||
552 | mnt_drop_write(path.mnt); | ||
553 | out_release: | ||
554 | path_put(&path); | ||
555 | out: | ||
556 | return error; | ||
557 | } | ||
558 | |||
559 | SYSCALL_DEFINE5(fchownat, int, dfd, const char __user *, filename, uid_t, user, | 540 | SYSCALL_DEFINE5(fchownat, int, dfd, const char __user *, filename, uid_t, user, |
560 | gid_t, group, int, flag) | 541 | gid_t, group, int, flag) |
561 | { | 542 | { |
@@ -583,23 +564,15 @@ out: | |||
583 | return error; | 564 | return error; |
584 | } | 565 | } |
585 | 566 | ||
586 | SYSCALL_DEFINE3(lchown, const char __user *, filename, uid_t, user, gid_t, group) | 567 | SYSCALL_DEFINE3(chown, const char __user *, filename, uid_t, user, gid_t, group) |
587 | { | 568 | { |
588 | struct path path; | 569 | return sys_fchownat(AT_FDCWD, filename, user, group, 0); |
589 | int error; | 570 | } |
590 | 571 | ||
591 | error = user_lpath(filename, &path); | 572 | SYSCALL_DEFINE3(lchown, const char __user *, filename, uid_t, user, gid_t, group) |
592 | if (error) | 573 | { |
593 | goto out; | 574 | return sys_fchownat(AT_FDCWD, filename, user, group, |
594 | error = mnt_want_write(path.mnt); | 575 | AT_SYMLINK_NOFOLLOW); |
595 | if (error) | ||
596 | goto out_release; | ||
597 | error = chown_common(&path, user, group); | ||
598 | mnt_drop_write(path.mnt); | ||
599 | out_release: | ||
600 | path_put(&path); | ||
601 | out: | ||
602 | return error; | ||
603 | } | 576 | } |
604 | 577 | ||
605 | SYSCALL_DEFINE3(fchown, unsigned int, fd, uid_t, user, gid_t, group) | 578 | SYSCALL_DEFINE3(fchown, unsigned int, fd, uid_t, user, gid_t, group) |
@@ -667,10 +640,9 @@ int open_check_o_direct(struct file *f) | |||
667 | return 0; | 640 | return 0; |
668 | } | 641 | } |
669 | 642 | ||
670 | static struct file *do_dentry_open(struct dentry *dentry, struct vfsmount *mnt, | 643 | static int do_dentry_open(struct file *f, |
671 | struct file *f, | 644 | int (*open)(struct inode *, struct file *), |
672 | int (*open)(struct inode *, struct file *), | 645 | const struct cred *cred) |
673 | const struct cred *cred) | ||
674 | { | 646 | { |
675 | static const struct file_operations empty_fops = {}; | 647 | static const struct file_operations empty_fops = {}; |
676 | struct inode *inode; | 648 | struct inode *inode; |
@@ -682,9 +654,9 @@ static struct file *do_dentry_open(struct dentry *dentry, struct vfsmount *mnt, | |||
682 | if (unlikely(f->f_flags & O_PATH)) | 654 | if (unlikely(f->f_flags & O_PATH)) |
683 | f->f_mode = FMODE_PATH; | 655 | f->f_mode = FMODE_PATH; |
684 | 656 | ||
685 | inode = dentry->d_inode; | 657 | inode = f->f_path.dentry->d_inode; |
686 | if (f->f_mode & FMODE_WRITE) { | 658 | if (f->f_mode & FMODE_WRITE) { |
687 | error = __get_file_write_access(inode, mnt); | 659 | error = __get_file_write_access(inode, f->f_path.mnt); |
688 | if (error) | 660 | if (error) |
689 | goto cleanup_file; | 661 | goto cleanup_file; |
690 | if (!special_file(inode->i_mode)) | 662 | if (!special_file(inode->i_mode)) |
@@ -692,14 +664,12 @@ static struct file *do_dentry_open(struct dentry *dentry, struct vfsmount *mnt, | |||
692 | } | 664 | } |
693 | 665 | ||
694 | f->f_mapping = inode->i_mapping; | 666 | f->f_mapping = inode->i_mapping; |
695 | f->f_path.dentry = dentry; | ||
696 | f->f_path.mnt = mnt; | ||
697 | f->f_pos = 0; | 667 | f->f_pos = 0; |
698 | file_sb_list_add(f, inode->i_sb); | 668 | file_sb_list_add(f, inode->i_sb); |
699 | 669 | ||
700 | if (unlikely(f->f_mode & FMODE_PATH)) { | 670 | if (unlikely(f->f_mode & FMODE_PATH)) { |
701 | f->f_op = &empty_fops; | 671 | f->f_op = &empty_fops; |
702 | return f; | 672 | return 0; |
703 | } | 673 | } |
704 | 674 | ||
705 | f->f_op = fops_get(inode->i_fop); | 675 | f->f_op = fops_get(inode->i_fop); |
@@ -726,10 +696,11 @@ static struct file *do_dentry_open(struct dentry *dentry, struct vfsmount *mnt, | |||
726 | 696 | ||
727 | file_ra_state_init(&f->f_ra, f->f_mapping->host->i_mapping); | 697 | file_ra_state_init(&f->f_ra, f->f_mapping->host->i_mapping); |
728 | 698 | ||
729 | return f; | 699 | return 0; |
730 | 700 | ||
731 | cleanup_all: | 701 | cleanup_all: |
732 | fops_put(f->f_op); | 702 | fops_put(f->f_op); |
703 | file_sb_list_del(f); | ||
733 | if (f->f_mode & FMODE_WRITE) { | 704 | if (f->f_mode & FMODE_WRITE) { |
734 | put_write_access(inode); | 705 | put_write_access(inode); |
735 | if (!special_file(inode->i_mode)) { | 706 | if (!special_file(inode->i_mode)) { |
@@ -740,124 +711,62 @@ cleanup_all: | |||
740 | * here, so just reset the state. | 711 | * here, so just reset the state. |
741 | */ | 712 | */ |
742 | file_reset_write(f); | 713 | file_reset_write(f); |
743 | mnt_drop_write(mnt); | 714 | mnt_drop_write(f->f_path.mnt); |
744 | } | 715 | } |
745 | } | 716 | } |
746 | file_sb_list_del(f); | ||
747 | f->f_path.dentry = NULL; | ||
748 | f->f_path.mnt = NULL; | ||
749 | cleanup_file: | 717 | cleanup_file: |
750 | dput(dentry); | 718 | path_put(&f->f_path); |
751 | mntput(mnt); | 719 | f->f_path.mnt = NULL; |
752 | return ERR_PTR(error); | 720 | f->f_path.dentry = NULL; |
753 | } | 721 | return error; |
754 | |||
755 | static struct file *__dentry_open(struct dentry *dentry, struct vfsmount *mnt, | ||
756 | struct file *f, | ||
757 | int (*open)(struct inode *, struct file *), | ||
758 | const struct cred *cred) | ||
759 | { | ||
760 | struct file *res = do_dentry_open(dentry, mnt, f, open, cred); | ||
761 | if (!IS_ERR(res)) { | ||
762 | int error = open_check_o_direct(f); | ||
763 | if (error) { | ||
764 | fput(res); | ||
765 | res = ERR_PTR(error); | ||
766 | } | ||
767 | } else { | ||
768 | put_filp(f); | ||
769 | } | ||
770 | return res; | ||
771 | } | 722 | } |
772 | 723 | ||
773 | /** | 724 | /** |
774 | * lookup_instantiate_filp - instantiates the open intent filp | 725 | * finish_open - finish opening a file |
775 | * @nd: pointer to nameidata | 726 | * @od: opaque open data |
776 | * @dentry: pointer to dentry | 727 | * @dentry: pointer to dentry |
777 | * @open: open callback | 728 | * @open: open callback |
778 | * | 729 | * |
779 | * Helper for filesystems that want to use lookup open intents and pass back | 730 | * This can be used to finish opening a file passed to i_op->atomic_open(). |
780 | * a fully instantiated struct file to the caller. | 731 | * |
781 | * This function is meant to be called from within a filesystem's | ||
782 | * lookup method. | ||
783 | * Beware of calling it for non-regular files! Those ->open methods might block | ||
784 | * (e.g. in fifo_open), leaving you with parent locked (and in case of fifo, | ||
785 | * leading to a deadlock, as nobody can open that fifo anymore, because | ||
786 | * another process to open fifo will block on locked parent when doing lookup). | ||
787 | * Note that in case of error, nd->intent.open.file is destroyed, but the | ||
788 | * path information remains valid. | ||
789 | * If the open callback is set to NULL, then the standard f_op->open() | 732 | * If the open callback is set to NULL, then the standard f_op->open() |
790 | * filesystem callback is substituted. | 733 | * filesystem callback is substituted. |
791 | */ | 734 | */ |
792 | struct file *lookup_instantiate_filp(struct nameidata *nd, struct dentry *dentry, | 735 | int finish_open(struct file *file, struct dentry *dentry, |
793 | int (*open)(struct inode *, struct file *)) | 736 | int (*open)(struct inode *, struct file *), |
737 | int *opened) | ||
794 | { | 738 | { |
795 | const struct cred *cred = current_cred(); | 739 | int error; |
740 | BUG_ON(*opened & FILE_OPENED); /* once it's opened, it's opened */ | ||
796 | 741 | ||
797 | if (IS_ERR(nd->intent.open.file)) | 742 | mntget(file->f_path.mnt); |
798 | goto out; | 743 | file->f_path.dentry = dget(dentry); |
799 | if (IS_ERR(dentry)) | 744 | |
800 | goto out_err; | 745 | error = do_dentry_open(file, open, current_cred()); |
801 | nd->intent.open.file = __dentry_open(dget(dentry), mntget(nd->path.mnt), | 746 | if (!error) |
802 | nd->intent.open.file, | 747 | *opened |= FILE_OPENED; |
803 | open, cred); | 748 | |
804 | out: | 749 | return error; |
805 | return nd->intent.open.file; | ||
806 | out_err: | ||
807 | release_open_intent(nd); | ||
808 | nd->intent.open.file = ERR_CAST(dentry); | ||
809 | goto out; | ||
810 | } | 750 | } |
811 | EXPORT_SYMBOL_GPL(lookup_instantiate_filp); | 751 | EXPORT_SYMBOL(finish_open); |
812 | 752 | ||
813 | /** | 753 | /** |
814 | * nameidata_to_filp - convert a nameidata to an open filp. | 754 | * finish_no_open - finish ->atomic_open() without opening the file |
815 | * @nd: pointer to nameidata | 755 | * |
816 | * @flags: open flags | 756 | * @od: opaque open data |
757 | * @dentry: dentry or NULL (as returned from ->lookup()) | ||
817 | * | 758 | * |
818 | * Note that this function destroys the original nameidata | 759 | * This can be used to set the result of a successful lookup in ->atomic_open(). |
760 | * The filesystem's atomic_open() method shall return NULL after calling this. | ||
819 | */ | 761 | */ |
820 | struct file *nameidata_to_filp(struct nameidata *nd) | 762 | int finish_no_open(struct file *file, struct dentry *dentry) |
821 | { | 763 | { |
822 | const struct cred *cred = current_cred(); | 764 | file->f_path.dentry = dentry; |
823 | struct file *filp; | 765 | return 1; |
824 | |||
825 | /* Pick up the filp from the open intent */ | ||
826 | filp = nd->intent.open.file; | ||
827 | |||
828 | /* Has the filesystem initialised the file for us? */ | ||
829 | if (filp->f_path.dentry != NULL) { | ||
830 | nd->intent.open.file = NULL; | ||
831 | } else { | ||
832 | struct file *res; | ||
833 | |||
834 | path_get(&nd->path); | ||
835 | res = do_dentry_open(nd->path.dentry, nd->path.mnt, | ||
836 | filp, NULL, cred); | ||
837 | if (!IS_ERR(res)) { | ||
838 | int error; | ||
839 | |||
840 | nd->intent.open.file = NULL; | ||
841 | BUG_ON(res != filp); | ||
842 | |||
843 | error = open_check_o_direct(filp); | ||
844 | if (error) { | ||
845 | fput(filp); | ||
846 | filp = ERR_PTR(error); | ||
847 | } | ||
848 | } else { | ||
849 | /* Allow nd->intent.open.file to be recycled */ | ||
850 | filp = res; | ||
851 | } | ||
852 | } | ||
853 | return filp; | ||
854 | } | 766 | } |
767 | EXPORT_SYMBOL(finish_no_open); | ||
855 | 768 | ||
856 | /* | 769 | struct file *dentry_open(const struct path *path, int flags, |
857 | * dentry_open() will have done dput(dentry) and mntput(mnt) if it returns an | ||
858 | * error. | ||
859 | */ | ||
860 | struct file *dentry_open(struct dentry *dentry, struct vfsmount *mnt, int flags, | ||
861 | const struct cred *cred) | 770 | const struct cred *cred) |
862 | { | 771 | { |
863 | int error; | 772 | int error; |
@@ -866,18 +775,28 @@ struct file *dentry_open(struct dentry *dentry, struct vfsmount *mnt, int flags, | |||
866 | validate_creds(cred); | 775 | validate_creds(cred); |
867 | 776 | ||
868 | /* We must always pass in a valid mount pointer. */ | 777 | /* We must always pass in a valid mount pointer. */ |
869 | BUG_ON(!mnt); | 778 | BUG_ON(!path->mnt); |
870 | 779 | ||
871 | error = -ENFILE; | 780 | error = -ENFILE; |
872 | f = get_empty_filp(); | 781 | f = get_empty_filp(); |
873 | if (f == NULL) { | 782 | if (f == NULL) |
874 | dput(dentry); | ||
875 | mntput(mnt); | ||
876 | return ERR_PTR(error); | 783 | return ERR_PTR(error); |
877 | } | ||
878 | 784 | ||
879 | f->f_flags = flags; | 785 | f->f_flags = flags; |
880 | return __dentry_open(dentry, mnt, f, NULL, cred); | 786 | f->f_path = *path; |
787 | path_get(&f->f_path); | ||
788 | error = do_dentry_open(f, NULL, cred); | ||
789 | if (!error) { | ||
790 | error = open_check_o_direct(f); | ||
791 | if (error) { | ||
792 | fput(f); | ||
793 | f = ERR_PTR(error); | ||
794 | } | ||
795 | } else { | ||
796 | put_filp(f); | ||
797 | f = ERR_PTR(error); | ||
798 | } | ||
799 | return f; | ||
881 | } | 800 | } |
882 | EXPORT_SYMBOL(dentry_open); | 801 | EXPORT_SYMBOL(dentry_open); |
883 | 802 | ||
diff --git a/fs/openpromfs/inode.c b/fs/openpromfs/inode.c index bc49c975d501..4a3477949bca 100644 --- a/fs/openpromfs/inode.c +++ b/fs/openpromfs/inode.c | |||
@@ -170,13 +170,13 @@ static const struct file_operations openprom_operations = { | |||
170 | .llseek = generic_file_llseek, | 170 | .llseek = generic_file_llseek, |
171 | }; | 171 | }; |
172 | 172 | ||
173 | static struct dentry *openpromfs_lookup(struct inode *, struct dentry *, struct nameidata *); | 173 | static struct dentry *openpromfs_lookup(struct inode *, struct dentry *, unsigned int); |
174 | 174 | ||
175 | static const struct inode_operations openprom_inode_operations = { | 175 | static const struct inode_operations openprom_inode_operations = { |
176 | .lookup = openpromfs_lookup, | 176 | .lookup = openpromfs_lookup, |
177 | }; | 177 | }; |
178 | 178 | ||
179 | static struct dentry *openpromfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 179 | static struct dentry *openpromfs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
180 | { | 180 | { |
181 | struct op_inode_info *ent_oi, *oi = OP_I(dir); | 181 | struct op_inode_info *ent_oi, *oi = OP_I(dir); |
182 | struct device_node *dp, *child; | 182 | struct device_node *dp, *child; |
diff --git a/fs/pnode.c b/fs/pnode.c index bed378db0758..3e000a51ac0d 100644 --- a/fs/pnode.c +++ b/fs/pnode.c | |||
@@ -237,8 +237,9 @@ int propagate_mnt(struct mount *dest_mnt, struct dentry *dest_dentry, | |||
237 | 237 | ||
238 | source = get_source(m, prev_dest_mnt, prev_src_mnt, &type); | 238 | source = get_source(m, prev_dest_mnt, prev_src_mnt, &type); |
239 | 239 | ||
240 | if (!(child = copy_tree(source, source->mnt.mnt_root, type))) { | 240 | child = copy_tree(source, source->mnt.mnt_root, type); |
241 | ret = -ENOMEM; | 241 | if (IS_ERR(child)) { |
242 | ret = PTR_ERR(child); | ||
242 | list_splice(tree_list, tmp_list.prev); | 243 | list_splice(tree_list, tmp_list.prev); |
243 | goto out; | 244 | goto out; |
244 | } | 245 | } |
diff --git a/fs/proc/base.c b/fs/proc/base.c index 437195f204e1..2772208338f8 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c | |||
@@ -1427,16 +1427,19 @@ static int proc_exe_link(struct dentry *dentry, struct path *exe_path) | |||
1427 | static void *proc_pid_follow_link(struct dentry *dentry, struct nameidata *nd) | 1427 | static void *proc_pid_follow_link(struct dentry *dentry, struct nameidata *nd) |
1428 | { | 1428 | { |
1429 | struct inode *inode = dentry->d_inode; | 1429 | struct inode *inode = dentry->d_inode; |
1430 | struct path path; | ||
1430 | int error = -EACCES; | 1431 | int error = -EACCES; |
1431 | 1432 | ||
1432 | /* We don't need a base pointer in the /proc filesystem */ | ||
1433 | path_put(&nd->path); | ||
1434 | |||
1435 | /* Are we allowed to snoop on the tasks file descriptors? */ | 1433 | /* Are we allowed to snoop on the tasks file descriptors? */ |
1436 | if (!proc_fd_access_allowed(inode)) | 1434 | if (!proc_fd_access_allowed(inode)) |
1437 | goto out; | 1435 | goto out; |
1438 | 1436 | ||
1439 | error = PROC_I(inode)->op.proc_get_link(dentry, &nd->path); | 1437 | error = PROC_I(inode)->op.proc_get_link(dentry, &path); |
1438 | if (error) | ||
1439 | goto out; | ||
1440 | |||
1441 | nd_jump_link(nd, &path); | ||
1442 | return NULL; | ||
1440 | out: | 1443 | out: |
1441 | return ERR_PTR(error); | 1444 | return ERR_PTR(error); |
1442 | } | 1445 | } |
@@ -1601,13 +1604,13 @@ int pid_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat) | |||
1601 | * made this apply to all per process world readable and executable | 1604 | * made this apply to all per process world readable and executable |
1602 | * directories. | 1605 | * directories. |
1603 | */ | 1606 | */ |
1604 | int pid_revalidate(struct dentry *dentry, struct nameidata *nd) | 1607 | int pid_revalidate(struct dentry *dentry, unsigned int flags) |
1605 | { | 1608 | { |
1606 | struct inode *inode; | 1609 | struct inode *inode; |
1607 | struct task_struct *task; | 1610 | struct task_struct *task; |
1608 | const struct cred *cred; | 1611 | const struct cred *cred; |
1609 | 1612 | ||
1610 | if (nd && nd->flags & LOOKUP_RCU) | 1613 | if (flags & LOOKUP_RCU) |
1611 | return -ECHILD; | 1614 | return -ECHILD; |
1612 | 1615 | ||
1613 | inode = dentry->d_inode; | 1616 | inode = dentry->d_inode; |
@@ -1781,7 +1784,7 @@ static int proc_fd_link(struct dentry *dentry, struct path *path) | |||
1781 | return proc_fd_info(dentry->d_inode, path, NULL); | 1784 | return proc_fd_info(dentry->d_inode, path, NULL); |
1782 | } | 1785 | } |
1783 | 1786 | ||
1784 | static int tid_fd_revalidate(struct dentry *dentry, struct nameidata *nd) | 1787 | static int tid_fd_revalidate(struct dentry *dentry, unsigned int flags) |
1785 | { | 1788 | { |
1786 | struct inode *inode; | 1789 | struct inode *inode; |
1787 | struct task_struct *task; | 1790 | struct task_struct *task; |
@@ -1789,7 +1792,7 @@ static int tid_fd_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
1789 | struct files_struct *files; | 1792 | struct files_struct *files; |
1790 | const struct cred *cred; | 1793 | const struct cred *cred; |
1791 | 1794 | ||
1792 | if (nd && nd->flags & LOOKUP_RCU) | 1795 | if (flags & LOOKUP_RCU) |
1793 | return -ECHILD; | 1796 | return -ECHILD; |
1794 | 1797 | ||
1795 | inode = dentry->d_inode; | 1798 | inode = dentry->d_inode; |
@@ -1868,7 +1871,7 @@ static struct dentry *proc_fd_instantiate(struct inode *dir, | |||
1868 | d_set_d_op(dentry, &tid_fd_dentry_operations); | 1871 | d_set_d_op(dentry, &tid_fd_dentry_operations); |
1869 | d_add(dentry, inode); | 1872 | d_add(dentry, inode); |
1870 | /* Close the race of the process dying before we return the dentry */ | 1873 | /* Close the race of the process dying before we return the dentry */ |
1871 | if (tid_fd_revalidate(dentry, NULL)) | 1874 | if (tid_fd_revalidate(dentry, 0)) |
1872 | error = NULL; | 1875 | error = NULL; |
1873 | 1876 | ||
1874 | out: | 1877 | out: |
@@ -1956,7 +1959,7 @@ out_no_task: | |||
1956 | } | 1959 | } |
1957 | 1960 | ||
1958 | static struct dentry *proc_lookupfd(struct inode *dir, struct dentry *dentry, | 1961 | static struct dentry *proc_lookupfd(struct inode *dir, struct dentry *dentry, |
1959 | struct nameidata *nd) | 1962 | unsigned int flags) |
1960 | { | 1963 | { |
1961 | return proc_lookupfd_common(dir, dentry, proc_fd_instantiate); | 1964 | return proc_lookupfd_common(dir, dentry, proc_fd_instantiate); |
1962 | } | 1965 | } |
@@ -2003,7 +2006,7 @@ static int dname_to_vma_addr(struct dentry *dentry, | |||
2003 | return 0; | 2006 | return 0; |
2004 | } | 2007 | } |
2005 | 2008 | ||
2006 | static int map_files_d_revalidate(struct dentry *dentry, struct nameidata *nd) | 2009 | static int map_files_d_revalidate(struct dentry *dentry, unsigned int flags) |
2007 | { | 2010 | { |
2008 | unsigned long vm_start, vm_end; | 2011 | unsigned long vm_start, vm_end; |
2009 | bool exact_vma_exists = false; | 2012 | bool exact_vma_exists = false; |
@@ -2013,7 +2016,7 @@ static int map_files_d_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
2013 | struct inode *inode; | 2016 | struct inode *inode; |
2014 | int status = 0; | 2017 | int status = 0; |
2015 | 2018 | ||
2016 | if (nd && nd->flags & LOOKUP_RCU) | 2019 | if (flags & LOOKUP_RCU) |
2017 | return -ECHILD; | 2020 | return -ECHILD; |
2018 | 2021 | ||
2019 | if (!capable(CAP_SYS_ADMIN)) { | 2022 | if (!capable(CAP_SYS_ADMIN)) { |
@@ -2145,7 +2148,7 @@ proc_map_files_instantiate(struct inode *dir, struct dentry *dentry, | |||
2145 | } | 2148 | } |
2146 | 2149 | ||
2147 | static struct dentry *proc_map_files_lookup(struct inode *dir, | 2150 | static struct dentry *proc_map_files_lookup(struct inode *dir, |
2148 | struct dentry *dentry, struct nameidata *nd) | 2151 | struct dentry *dentry, unsigned int flags) |
2149 | { | 2152 | { |
2150 | unsigned long vm_start, vm_end; | 2153 | unsigned long vm_start, vm_end; |
2151 | struct vm_area_struct *vma; | 2154 | struct vm_area_struct *vma; |
@@ -2371,7 +2374,7 @@ static struct dentry *proc_fdinfo_instantiate(struct inode *dir, | |||
2371 | d_set_d_op(dentry, &tid_fd_dentry_operations); | 2374 | d_set_d_op(dentry, &tid_fd_dentry_operations); |
2372 | d_add(dentry, inode); | 2375 | d_add(dentry, inode); |
2373 | /* Close the race of the process dying before we return the dentry */ | 2376 | /* Close the race of the process dying before we return the dentry */ |
2374 | if (tid_fd_revalidate(dentry, NULL)) | 2377 | if (tid_fd_revalidate(dentry, 0)) |
2375 | error = NULL; | 2378 | error = NULL; |
2376 | 2379 | ||
2377 | out: | 2380 | out: |
@@ -2380,7 +2383,7 @@ static struct dentry *proc_fdinfo_instantiate(struct inode *dir, | |||
2380 | 2383 | ||
2381 | static struct dentry *proc_lookupfdinfo(struct inode *dir, | 2384 | static struct dentry *proc_lookupfdinfo(struct inode *dir, |
2382 | struct dentry *dentry, | 2385 | struct dentry *dentry, |
2383 | struct nameidata *nd) | 2386 | unsigned int flags) |
2384 | { | 2387 | { |
2385 | return proc_lookupfd_common(dir, dentry, proc_fdinfo_instantiate); | 2388 | return proc_lookupfd_common(dir, dentry, proc_fdinfo_instantiate); |
2386 | } | 2389 | } |
@@ -2430,7 +2433,7 @@ static struct dentry *proc_pident_instantiate(struct inode *dir, | |||
2430 | d_set_d_op(dentry, &pid_dentry_operations); | 2433 | d_set_d_op(dentry, &pid_dentry_operations); |
2431 | d_add(dentry, inode); | 2434 | d_add(dentry, inode); |
2432 | /* Close the race of the process dying before we return the dentry */ | 2435 | /* Close the race of the process dying before we return the dentry */ |
2433 | if (pid_revalidate(dentry, NULL)) | 2436 | if (pid_revalidate(dentry, 0)) |
2434 | error = NULL; | 2437 | error = NULL; |
2435 | out: | 2438 | out: |
2436 | return error; | 2439 | return error; |
@@ -2630,7 +2633,7 @@ static const struct file_operations proc_attr_dir_operations = { | |||
2630 | }; | 2633 | }; |
2631 | 2634 | ||
2632 | static struct dentry *proc_attr_dir_lookup(struct inode *dir, | 2635 | static struct dentry *proc_attr_dir_lookup(struct inode *dir, |
2633 | struct dentry *dentry, struct nameidata *nd) | 2636 | struct dentry *dentry, unsigned int flags) |
2634 | { | 2637 | { |
2635 | return proc_pident_lookup(dir, dentry, | 2638 | return proc_pident_lookup(dir, dentry, |
2636 | attr_dir_stuff, ARRAY_SIZE(attr_dir_stuff)); | 2639 | attr_dir_stuff, ARRAY_SIZE(attr_dir_stuff)); |
@@ -3114,7 +3117,8 @@ static const struct file_operations proc_tgid_base_operations = { | |||
3114 | .llseek = default_llseek, | 3117 | .llseek = default_llseek, |
3115 | }; | 3118 | }; |
3116 | 3119 | ||
3117 | static struct dentry *proc_tgid_base_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd){ | 3120 | static struct dentry *proc_tgid_base_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
3121 | { | ||
3118 | return proc_pident_lookup(dir, dentry, | 3122 | return proc_pident_lookup(dir, dentry, |
3119 | tgid_base_stuff, ARRAY_SIZE(tgid_base_stuff)); | 3123 | tgid_base_stuff, ARRAY_SIZE(tgid_base_stuff)); |
3120 | } | 3124 | } |
@@ -3237,13 +3241,13 @@ static struct dentry *proc_pid_instantiate(struct inode *dir, | |||
3237 | 3241 | ||
3238 | d_add(dentry, inode); | 3242 | d_add(dentry, inode); |
3239 | /* Close the race of the process dying before we return the dentry */ | 3243 | /* Close the race of the process dying before we return the dentry */ |
3240 | if (pid_revalidate(dentry, NULL)) | 3244 | if (pid_revalidate(dentry, 0)) |
3241 | error = NULL; | 3245 | error = NULL; |
3242 | out: | 3246 | out: |
3243 | return error; | 3247 | return error; |
3244 | } | 3248 | } |
3245 | 3249 | ||
3246 | struct dentry *proc_pid_lookup(struct inode *dir, struct dentry * dentry, struct nameidata *nd) | 3250 | struct dentry *proc_pid_lookup(struct inode *dir, struct dentry * dentry, unsigned int flags) |
3247 | { | 3251 | { |
3248 | struct dentry *result; | 3252 | struct dentry *result; |
3249 | struct task_struct *task; | 3253 | struct task_struct *task; |
@@ -3470,7 +3474,8 @@ static int proc_tid_base_readdir(struct file * filp, | |||
3470 | tid_base_stuff,ARRAY_SIZE(tid_base_stuff)); | 3474 | tid_base_stuff,ARRAY_SIZE(tid_base_stuff)); |
3471 | } | 3475 | } |
3472 | 3476 | ||
3473 | static struct dentry *proc_tid_base_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd){ | 3477 | static struct dentry *proc_tid_base_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
3478 | { | ||
3474 | return proc_pident_lookup(dir, dentry, | 3479 | return proc_pident_lookup(dir, dentry, |
3475 | tid_base_stuff, ARRAY_SIZE(tid_base_stuff)); | 3480 | tid_base_stuff, ARRAY_SIZE(tid_base_stuff)); |
3476 | } | 3481 | } |
@@ -3508,13 +3513,13 @@ static struct dentry *proc_task_instantiate(struct inode *dir, | |||
3508 | 3513 | ||
3509 | d_add(dentry, inode); | 3514 | d_add(dentry, inode); |
3510 | /* Close the race of the process dying before we return the dentry */ | 3515 | /* Close the race of the process dying before we return the dentry */ |
3511 | if (pid_revalidate(dentry, NULL)) | 3516 | if (pid_revalidate(dentry, 0)) |
3512 | error = NULL; | 3517 | error = NULL; |
3513 | out: | 3518 | out: |
3514 | return error; | 3519 | return error; |
3515 | } | 3520 | } |
3516 | 3521 | ||
3517 | static struct dentry *proc_task_lookup(struct inode *dir, struct dentry * dentry, struct nameidata *nd) | 3522 | static struct dentry *proc_task_lookup(struct inode *dir, struct dentry * dentry, unsigned int flags) |
3518 | { | 3523 | { |
3519 | struct dentry *result = ERR_PTR(-ENOENT); | 3524 | struct dentry *result = ERR_PTR(-ENOENT); |
3520 | struct task_struct *task; | 3525 | struct task_struct *task; |
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 2edf34f2eb61..b3647fe6a608 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c | |||
@@ -446,7 +446,7 @@ out_unlock: | |||
446 | } | 446 | } |
447 | 447 | ||
448 | struct dentry *proc_lookup(struct inode *dir, struct dentry *dentry, | 448 | struct dentry *proc_lookup(struct inode *dir, struct dentry *dentry, |
449 | struct nameidata *nd) | 449 | unsigned int flags) |
450 | { | 450 | { |
451 | return proc_lookup_de(PDE(dir), dir, dentry); | 451 | return proc_lookup_de(PDE(dir), dir, dentry); |
452 | } | 452 | } |
diff --git a/fs/proc/internal.h b/fs/proc/internal.h index eca4aca5b6e2..e1167a1c9126 100644 --- a/fs/proc/internal.h +++ b/fs/proc/internal.h | |||
@@ -106,7 +106,7 @@ void pde_users_dec(struct proc_dir_entry *pde); | |||
106 | 106 | ||
107 | extern spinlock_t proc_subdir_lock; | 107 | extern spinlock_t proc_subdir_lock; |
108 | 108 | ||
109 | struct dentry *proc_pid_lookup(struct inode *dir, struct dentry * dentry, struct nameidata *); | 109 | struct dentry *proc_pid_lookup(struct inode *dir, struct dentry * dentry, unsigned int); |
110 | int proc_pid_readdir(struct file * filp, void * dirent, filldir_t filldir); | 110 | int proc_pid_readdir(struct file * filp, void * dirent, filldir_t filldir); |
111 | unsigned long task_vsize(struct mm_struct *); | 111 | unsigned long task_vsize(struct mm_struct *); |
112 | unsigned long task_statm(struct mm_struct *, | 112 | unsigned long task_statm(struct mm_struct *, |
@@ -132,7 +132,7 @@ int proc_remount(struct super_block *sb, int *flags, char *data); | |||
132 | * of the /proc/<pid> subdirectories. | 132 | * of the /proc/<pid> subdirectories. |
133 | */ | 133 | */ |
134 | int proc_readdir(struct file *, void *, filldir_t); | 134 | int proc_readdir(struct file *, void *, filldir_t); |
135 | struct dentry *proc_lookup(struct inode *, struct dentry *, struct nameidata *); | 135 | struct dentry *proc_lookup(struct inode *, struct dentry *, unsigned int); |
136 | 136 | ||
137 | 137 | ||
138 | 138 | ||
@@ -142,7 +142,7 @@ typedef struct dentry *instantiate_t(struct inode *, struct dentry *, | |||
142 | int proc_fill_cache(struct file *filp, void *dirent, filldir_t filldir, | 142 | int proc_fill_cache(struct file *filp, void *dirent, filldir_t filldir, |
143 | const char *name, int len, | 143 | const char *name, int len, |
144 | instantiate_t instantiate, struct task_struct *task, const void *ptr); | 144 | instantiate_t instantiate, struct task_struct *task, const void *ptr); |
145 | int pid_revalidate(struct dentry *dentry, struct nameidata *nd); | 145 | int pid_revalidate(struct dentry *dentry, unsigned int flags); |
146 | struct inode *proc_pid_make_inode(struct super_block * sb, struct task_struct *task); | 146 | struct inode *proc_pid_make_inode(struct super_block * sb, struct task_struct *task); |
147 | extern const struct dentry_operations pid_dentry_operations; | 147 | extern const struct dentry_operations pid_dentry_operations; |
148 | int pid_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat); | 148 | int pid_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat); |
diff --git a/fs/proc/namespaces.c b/fs/proc/namespaces.c index 0d9e23a39e49..b178ed733c36 100644 --- a/fs/proc/namespaces.c +++ b/fs/proc/namespaces.c | |||
@@ -56,7 +56,7 @@ static struct dentry *proc_ns_instantiate(struct inode *dir, | |||
56 | d_set_d_op(dentry, &pid_dentry_operations); | 56 | d_set_d_op(dentry, &pid_dentry_operations); |
57 | d_add(dentry, inode); | 57 | d_add(dentry, inode); |
58 | /* Close the race of the process dying before we return the dentry */ | 58 | /* Close the race of the process dying before we return the dentry */ |
59 | if (pid_revalidate(dentry, NULL)) | 59 | if (pid_revalidate(dentry, 0)) |
60 | error = NULL; | 60 | error = NULL; |
61 | out: | 61 | out: |
62 | return error; | 62 | return error; |
@@ -140,7 +140,7 @@ const struct file_operations proc_ns_dir_operations = { | |||
140 | }; | 140 | }; |
141 | 141 | ||
142 | static struct dentry *proc_ns_dir_lookup(struct inode *dir, | 142 | static struct dentry *proc_ns_dir_lookup(struct inode *dir, |
143 | struct dentry *dentry, struct nameidata *nd) | 143 | struct dentry *dentry, unsigned int flags) |
144 | { | 144 | { |
145 | struct dentry *error; | 145 | struct dentry *error; |
146 | struct task_struct *task = get_proc_task(dir); | 146 | struct task_struct *task = get_proc_task(dir); |
diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c index 927cbd115e53..df7dd08d4391 100644 --- a/fs/proc/proc_devtree.c +++ b/fs/proc/proc_devtree.c | |||
@@ -101,6 +101,11 @@ void proc_device_tree_update_prop(struct proc_dir_entry *pde, | |||
101 | { | 101 | { |
102 | struct proc_dir_entry *ent; | 102 | struct proc_dir_entry *ent; |
103 | 103 | ||
104 | if (!oldprop) { | ||
105 | proc_device_tree_add_prop(pde, newprop); | ||
106 | return; | ||
107 | } | ||
108 | |||
104 | for (ent = pde->subdir; ent != NULL; ent = ent->next) | 109 | for (ent = pde->subdir; ent != NULL; ent = ent->next) |
105 | if (ent->data == oldprop) | 110 | if (ent->data == oldprop) |
106 | break; | 111 | break; |
diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c index 06e1cc17caf6..fe72cd073dea 100644 --- a/fs/proc/proc_net.c +++ b/fs/proc/proc_net.c | |||
@@ -119,7 +119,7 @@ static struct net *get_proc_task_net(struct inode *dir) | |||
119 | } | 119 | } |
120 | 120 | ||
121 | static struct dentry *proc_tgid_net_lookup(struct inode *dir, | 121 | static struct dentry *proc_tgid_net_lookup(struct inode *dir, |
122 | struct dentry *dentry, struct nameidata *nd) | 122 | struct dentry *dentry, unsigned int flags) |
123 | { | 123 | { |
124 | struct dentry *de; | 124 | struct dentry *de; |
125 | struct net *net; | 125 | struct net *net; |
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 3476bca8f7af..dfafeb2b05a0 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c | |||
@@ -433,7 +433,7 @@ static struct ctl_table_header *grab_header(struct inode *inode) | |||
433 | } | 433 | } |
434 | 434 | ||
435 | static struct dentry *proc_sys_lookup(struct inode *dir, struct dentry *dentry, | 435 | static struct dentry *proc_sys_lookup(struct inode *dir, struct dentry *dentry, |
436 | struct nameidata *nd) | 436 | unsigned int flags) |
437 | { | 437 | { |
438 | struct ctl_table_header *head = grab_header(dir); | 438 | struct ctl_table_header *head = grab_header(dir); |
439 | struct ctl_table_header *h = NULL; | 439 | struct ctl_table_header *h = NULL; |
@@ -794,9 +794,9 @@ static const struct inode_operations proc_sys_dir_operations = { | |||
794 | .getattr = proc_sys_getattr, | 794 | .getattr = proc_sys_getattr, |
795 | }; | 795 | }; |
796 | 796 | ||
797 | static int proc_sys_revalidate(struct dentry *dentry, struct nameidata *nd) | 797 | static int proc_sys_revalidate(struct dentry *dentry, unsigned int flags) |
798 | { | 798 | { |
799 | if (nd->flags & LOOKUP_RCU) | 799 | if (flags & LOOKUP_RCU) |
800 | return -ECHILD; | 800 | return -ECHILD; |
801 | return !PROC_I(dentry->d_inode)->sysctl->unregistering; | 801 | return !PROC_I(dentry->d_inode)->sysctl->unregistering; |
802 | } | 802 | } |
diff --git a/fs/proc/root.c b/fs/proc/root.c index 7c30fce037c0..9a2d9fd7cadd 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c | |||
@@ -111,7 +111,7 @@ static struct dentry *proc_mount(struct file_system_type *fs_type, | |||
111 | options = data; | 111 | options = data; |
112 | } | 112 | } |
113 | 113 | ||
114 | sb = sget(fs_type, proc_test_super, proc_set_super, ns); | 114 | sb = sget(fs_type, proc_test_super, proc_set_super, flags, ns); |
115 | if (IS_ERR(sb)) | 115 | if (IS_ERR(sb)) |
116 | return ERR_CAST(sb); | 116 | return ERR_CAST(sb); |
117 | 117 | ||
@@ -121,7 +121,6 @@ static struct dentry *proc_mount(struct file_system_type *fs_type, | |||
121 | } | 121 | } |
122 | 122 | ||
123 | if (!sb->s_root) { | 123 | if (!sb->s_root) { |
124 | sb->s_flags = flags; | ||
125 | err = proc_fill_super(sb); | 124 | err = proc_fill_super(sb); |
126 | if (err) { | 125 | if (err) { |
127 | deactivate_locked_super(sb); | 126 | deactivate_locked_super(sb); |
@@ -200,13 +199,12 @@ static int proc_root_getattr(struct vfsmount *mnt, struct dentry *dentry, struct | |||
200 | return 0; | 199 | return 0; |
201 | } | 200 | } |
202 | 201 | ||
203 | static struct dentry *proc_root_lookup(struct inode * dir, struct dentry * dentry, struct nameidata *nd) | 202 | static struct dentry *proc_root_lookup(struct inode * dir, struct dentry * dentry, unsigned int flags) |
204 | { | 203 | { |
205 | if (!proc_lookup(dir, dentry, nd)) { | 204 | if (!proc_lookup(dir, dentry, flags)) |
206 | return NULL; | 205 | return NULL; |
207 | } | ||
208 | 206 | ||
209 | return proc_pid_lookup(dir, dentry, nd); | 207 | return proc_pid_lookup(dir, dentry, flags); |
210 | } | 208 | } |
211 | 209 | ||
212 | static int proc_root_readdir(struct file * filp, | 210 | static int proc_root_readdir(struct file * filp, |
diff --git a/fs/proc_namespace.c b/fs/proc_namespace.c index 5e289a7cbad1..5fe34c355e85 100644 --- a/fs/proc_namespace.c +++ b/fs/proc_namespace.c | |||
@@ -17,7 +17,7 @@ | |||
17 | 17 | ||
18 | static unsigned mounts_poll(struct file *file, poll_table *wait) | 18 | static unsigned mounts_poll(struct file *file, poll_table *wait) |
19 | { | 19 | { |
20 | struct proc_mounts *p = file->private_data; | 20 | struct proc_mounts *p = proc_mounts(file->private_data); |
21 | struct mnt_namespace *ns = p->ns; | 21 | struct mnt_namespace *ns = p->ns; |
22 | unsigned res = POLLIN | POLLRDNORM; | 22 | unsigned res = POLLIN | POLLRDNORM; |
23 | 23 | ||
@@ -121,7 +121,7 @@ out: | |||
121 | 121 | ||
122 | static int show_mountinfo(struct seq_file *m, struct vfsmount *mnt) | 122 | static int show_mountinfo(struct seq_file *m, struct vfsmount *mnt) |
123 | { | 123 | { |
124 | struct proc_mounts *p = m->private; | 124 | struct proc_mounts *p = proc_mounts(m); |
125 | struct mount *r = real_mount(mnt); | 125 | struct mount *r = real_mount(mnt); |
126 | struct super_block *sb = mnt->mnt_sb; | 126 | struct super_block *sb = mnt->mnt_sb; |
127 | struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt }; | 127 | struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt }; |
@@ -268,7 +268,6 @@ static int mounts_open_common(struct inode *inode, struct file *file, | |||
268 | if (ret) | 268 | if (ret) |
269 | goto err_free; | 269 | goto err_free; |
270 | 270 | ||
271 | p->m.private = p; | ||
272 | p->ns = ns; | 271 | p->ns = ns; |
273 | p->root = root; | 272 | p->root = root; |
274 | p->m.poll_event = ns->event; | 273 | p->m.poll_event = ns->event; |
@@ -288,7 +287,7 @@ static int mounts_open_common(struct inode *inode, struct file *file, | |||
288 | 287 | ||
289 | static int mounts_release(struct inode *inode, struct file *file) | 288 | static int mounts_release(struct inode *inode, struct file *file) |
290 | { | 289 | { |
291 | struct proc_mounts *p = file->private_data; | 290 | struct proc_mounts *p = proc_mounts(file->private_data); |
292 | path_put(&p->root); | 291 | path_put(&p->root); |
293 | put_mnt_ns(p->ns); | 292 | put_mnt_ns(p->ns); |
294 | return seq_release(inode, file); | 293 | return seq_release(inode, file); |
diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index aeb19e68e086..11a2aa2a56c4 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c | |||
@@ -258,7 +258,7 @@ fail: | |||
258 | return rc; | 258 | return rc; |
259 | } | 259 | } |
260 | 260 | ||
261 | int pstore_fill_super(struct super_block *sb, void *data, int silent) | 261 | static int pstore_fill_super(struct super_block *sb, void *data, int silent) |
262 | { | 262 | { |
263 | struct inode *inode; | 263 | struct inode *inode; |
264 | 264 | ||
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 82c585f715e3..03ce7a9b81cc 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c | |||
@@ -94,20 +94,15 @@ static const char *get_reason_str(enum kmsg_dump_reason reason) | |||
94 | * as we can from the end of the buffer. | 94 | * as we can from the end of the buffer. |
95 | */ | 95 | */ |
96 | static void pstore_dump(struct kmsg_dumper *dumper, | 96 | static void pstore_dump(struct kmsg_dumper *dumper, |
97 | enum kmsg_dump_reason reason, | 97 | enum kmsg_dump_reason reason) |
98 | const char *s1, unsigned long l1, | ||
99 | const char *s2, unsigned long l2) | ||
100 | { | 98 | { |
101 | unsigned long s1_start, s2_start; | 99 | unsigned long total = 0; |
102 | unsigned long l1_cpy, l2_cpy; | ||
103 | unsigned long size, total = 0; | ||
104 | char *dst; | ||
105 | const char *why; | 100 | const char *why; |
106 | u64 id; | 101 | u64 id; |
107 | int hsize, ret; | ||
108 | unsigned int part = 1; | 102 | unsigned int part = 1; |
109 | unsigned long flags = 0; | 103 | unsigned long flags = 0; |
110 | int is_locked = 0; | 104 | int is_locked = 0; |
105 | int ret; | ||
111 | 106 | ||
112 | why = get_reason_str(reason); | 107 | why = get_reason_str(reason); |
113 | 108 | ||
@@ -119,30 +114,25 @@ static void pstore_dump(struct kmsg_dumper *dumper, | |||
119 | spin_lock_irqsave(&psinfo->buf_lock, flags); | 114 | spin_lock_irqsave(&psinfo->buf_lock, flags); |
120 | oopscount++; | 115 | oopscount++; |
121 | while (total < kmsg_bytes) { | 116 | while (total < kmsg_bytes) { |
117 | char *dst; | ||
118 | unsigned long size; | ||
119 | int hsize; | ||
120 | size_t len; | ||
121 | |||
122 | dst = psinfo->buf; | 122 | dst = psinfo->buf; |
123 | hsize = sprintf(dst, "%s#%d Part%d\n", why, oopscount, part); | 123 | hsize = sprintf(dst, "%s#%d Part%d\n", why, oopscount, part); |
124 | size = psinfo->bufsize - hsize; | 124 | size = psinfo->bufsize - hsize; |
125 | dst += hsize; | 125 | dst += hsize; |
126 | 126 | ||
127 | l2_cpy = min(l2, size); | 127 | if (!kmsg_dump_get_buffer(dumper, true, dst, size, &len)) |
128 | l1_cpy = min(l1, size - l2_cpy); | ||
129 | |||
130 | if (l1_cpy + l2_cpy == 0) | ||
131 | break; | 128 | break; |
132 | 129 | ||
133 | s2_start = l2 - l2_cpy; | ||
134 | s1_start = l1 - l1_cpy; | ||
135 | |||
136 | memcpy(dst, s1 + s1_start, l1_cpy); | ||
137 | memcpy(dst + l1_cpy, s2 + s2_start, l2_cpy); | ||
138 | |||
139 | ret = psinfo->write(PSTORE_TYPE_DMESG, reason, &id, part, | 130 | ret = psinfo->write(PSTORE_TYPE_DMESG, reason, &id, part, |
140 | hsize + l1_cpy + l2_cpy, psinfo); | 131 | hsize + len, psinfo); |
141 | if (ret == 0 && reason == KMSG_DUMP_OOPS && pstore_is_mounted()) | 132 | if (ret == 0 && reason == KMSG_DUMP_OOPS && pstore_is_mounted()) |
142 | pstore_new_entry = 1; | 133 | pstore_new_entry = 1; |
143 | l1 -= l1_cpy; | 134 | |
144 | l2 -= l2_cpy; | 135 | total += hsize + len; |
145 | total += l1_cpy + l2_cpy; | ||
146 | part++; | 136 | part++; |
147 | } | 137 | } |
148 | if (in_nmi()) { | 138 | if (in_nmi()) { |
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 9123cce28c1e..453030f9c5bc 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c | |||
@@ -106,6 +106,8 @@ static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type, | |||
106 | time->tv_sec = 0; | 106 | time->tv_sec = 0; |
107 | time->tv_nsec = 0; | 107 | time->tv_nsec = 0; |
108 | 108 | ||
109 | /* Update old/shadowed buffer. */ | ||
110 | persistent_ram_save_old(prz); | ||
109 | size = persistent_ram_old_size(prz); | 111 | size = persistent_ram_old_size(prz); |
110 | *buf = kmalloc(size, GFP_KERNEL); | 112 | *buf = kmalloc(size, GFP_KERNEL); |
111 | if (*buf == NULL) | 113 | if (*buf == NULL) |
@@ -184,6 +186,7 @@ static int ramoops_pstore_erase(enum pstore_type_id type, u64 id, | |||
184 | return -EINVAL; | 186 | return -EINVAL; |
185 | 187 | ||
186 | persistent_ram_free_old(cxt->przs[id]); | 188 | persistent_ram_free_old(cxt->przs[id]); |
189 | persistent_ram_zap(cxt->przs[id]); | ||
187 | 190 | ||
188 | return 0; | 191 | return 0; |
189 | } | 192 | } |
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c index 31f8d184f3a0..c5fbdbbf81ac 100644 --- a/fs/pstore/ram_core.c +++ b/fs/pstore/ram_core.c | |||
@@ -250,23 +250,24 @@ static void notrace persistent_ram_update(struct persistent_ram_zone *prz, | |||
250 | persistent_ram_update_ecc(prz, start, count); | 250 | persistent_ram_update_ecc(prz, start, count); |
251 | } | 251 | } |
252 | 252 | ||
253 | static void __init | 253 | void persistent_ram_save_old(struct persistent_ram_zone *prz) |
254 | persistent_ram_save_old(struct persistent_ram_zone *prz) | ||
255 | { | 254 | { |
256 | struct persistent_ram_buffer *buffer = prz->buffer; | 255 | struct persistent_ram_buffer *buffer = prz->buffer; |
257 | size_t size = buffer_size(prz); | 256 | size_t size = buffer_size(prz); |
258 | size_t start = buffer_start(prz); | 257 | size_t start = buffer_start(prz); |
259 | char *dest; | ||
260 | 258 | ||
261 | persistent_ram_ecc_old(prz); | 259 | if (!size) |
260 | return; | ||
262 | 261 | ||
263 | dest = kmalloc(size, GFP_KERNEL); | 262 | if (!prz->old_log) { |
264 | if (dest == NULL) { | 263 | persistent_ram_ecc_old(prz); |
264 | prz->old_log = kmalloc(size, GFP_KERNEL); | ||
265 | } | ||
266 | if (!prz->old_log) { | ||
265 | pr_err("persistent_ram: failed to allocate buffer\n"); | 267 | pr_err("persistent_ram: failed to allocate buffer\n"); |
266 | return; | 268 | return; |
267 | } | 269 | } |
268 | 270 | ||
269 | prz->old_log = dest; | ||
270 | prz->old_log_size = size; | 271 | prz->old_log_size = size; |
271 | memcpy(prz->old_log, &buffer->data[start], size - start); | 272 | memcpy(prz->old_log, &buffer->data[start], size - start); |
272 | memcpy(prz->old_log + size - start, &buffer->data[0], start); | 273 | memcpy(prz->old_log + size - start, &buffer->data[0], start); |
@@ -319,6 +320,13 @@ void persistent_ram_free_old(struct persistent_ram_zone *prz) | |||
319 | prz->old_log_size = 0; | 320 | prz->old_log_size = 0; |
320 | } | 321 | } |
321 | 322 | ||
323 | void persistent_ram_zap(struct persistent_ram_zone *prz) | ||
324 | { | ||
325 | atomic_set(&prz->buffer->start, 0); | ||
326 | atomic_set(&prz->buffer->size, 0); | ||
327 | persistent_ram_update_header_ecc(prz); | ||
328 | } | ||
329 | |||
322 | static void *persistent_ram_vmap(phys_addr_t start, size_t size) | 330 | static void *persistent_ram_vmap(phys_addr_t start, size_t size) |
323 | { | 331 | { |
324 | struct page **pages; | 332 | struct page **pages; |
@@ -405,6 +413,7 @@ static int __init persistent_ram_post_init(struct persistent_ram_zone *prz, bool | |||
405 | " size %zu, start %zu\n", | 413 | " size %zu, start %zu\n", |
406 | buffer_size(prz), buffer_start(prz)); | 414 | buffer_size(prz), buffer_start(prz)); |
407 | persistent_ram_save_old(prz); | 415 | persistent_ram_save_old(prz); |
416 | return 0; | ||
408 | } | 417 | } |
409 | } else { | 418 | } else { |
410 | pr_info("persistent_ram: no valid data in buffer" | 419 | pr_info("persistent_ram: no valid data in buffer" |
@@ -412,8 +421,7 @@ static int __init persistent_ram_post_init(struct persistent_ram_zone *prz, bool | |||
412 | } | 421 | } |
413 | 422 | ||
414 | prz->buffer->sig = PERSISTENT_RAM_SIG; | 423 | prz->buffer->sig = PERSISTENT_RAM_SIG; |
415 | atomic_set(&prz->buffer->start, 0); | 424 | persistent_ram_zap(prz); |
416 | atomic_set(&prz->buffer->size, 0); | ||
417 | 425 | ||
418 | return 0; | 426 | return 0; |
419 | } | 427 | } |
@@ -448,7 +456,6 @@ struct persistent_ram_zone * __init persistent_ram_new(phys_addr_t start, | |||
448 | goto err; | 456 | goto err; |
449 | 457 | ||
450 | persistent_ram_post_init(prz, ecc); | 458 | persistent_ram_post_init(prz, ecc); |
451 | persistent_ram_update_header_ecc(prz); | ||
452 | 459 | ||
453 | return prz; | 460 | return prz; |
454 | err: | 461 | err: |
diff --git a/fs/qnx4/namei.c b/fs/qnx4/namei.c index a512c0b30e8e..d024505ba007 100644 --- a/fs/qnx4/namei.c +++ b/fs/qnx4/namei.c | |||
@@ -95,7 +95,7 @@ static struct buffer_head *qnx4_find_entry(int len, struct inode *dir, | |||
95 | return NULL; | 95 | return NULL; |
96 | } | 96 | } |
97 | 97 | ||
98 | struct dentry * qnx4_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 98 | struct dentry * qnx4_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) |
99 | { | 99 | { |
100 | int ino; | 100 | int ino; |
101 | struct qnx4_inode_entry *de; | 101 | struct qnx4_inode_entry *de; |
diff --git a/fs/qnx4/qnx4.h b/fs/qnx4/qnx4.h index 244d4620189b..34e2d329c97e 100644 --- a/fs/qnx4/qnx4.h +++ b/fs/qnx4/qnx4.h | |||
@@ -23,7 +23,7 @@ struct qnx4_inode_info { | |||
23 | }; | 23 | }; |
24 | 24 | ||
25 | extern struct inode *qnx4_iget(struct super_block *, unsigned long); | 25 | extern struct inode *qnx4_iget(struct super_block *, unsigned long); |
26 | extern struct dentry *qnx4_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd); | 26 | extern struct dentry *qnx4_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags); |
27 | extern unsigned long qnx4_count_free_blocks(struct super_block *sb); | 27 | extern unsigned long qnx4_count_free_blocks(struct super_block *sb); |
28 | extern unsigned long qnx4_block_map(struct inode *inode, long iblock); | 28 | extern unsigned long qnx4_block_map(struct inode *inode, long iblock); |
29 | 29 | ||
diff --git a/fs/qnx6/inode.c b/fs/qnx6/inode.c index e44012dc5645..2049c814bda4 100644 --- a/fs/qnx6/inode.c +++ b/fs/qnx6/inode.c | |||
@@ -622,7 +622,6 @@ static struct inode *qnx6_alloc_inode(struct super_block *sb) | |||
622 | static void qnx6_i_callback(struct rcu_head *head) | 622 | static void qnx6_i_callback(struct rcu_head *head) |
623 | { | 623 | { |
624 | struct inode *inode = container_of(head, struct inode, i_rcu); | 624 | struct inode *inode = container_of(head, struct inode, i_rcu); |
625 | INIT_LIST_HEAD(&inode->i_dentry); | ||
626 | kmem_cache_free(qnx6_inode_cachep, QNX6_I(inode)); | 625 | kmem_cache_free(qnx6_inode_cachep, QNX6_I(inode)); |
627 | } | 626 | } |
628 | 627 | ||
diff --git a/fs/qnx6/namei.c b/fs/qnx6/namei.c index 8a97289e04ad..0561326a94f5 100644 --- a/fs/qnx6/namei.c +++ b/fs/qnx6/namei.c | |||
@@ -13,7 +13,7 @@ | |||
13 | #include "qnx6.h" | 13 | #include "qnx6.h" |
14 | 14 | ||
15 | struct dentry *qnx6_lookup(struct inode *dir, struct dentry *dentry, | 15 | struct dentry *qnx6_lookup(struct inode *dir, struct dentry *dentry, |
16 | struct nameidata *nd) | 16 | unsigned int flags) |
17 | { | 17 | { |
18 | unsigned ino; | 18 | unsigned ino; |
19 | struct page *page; | 19 | struct page *page; |
diff --git a/fs/qnx6/qnx6.h b/fs/qnx6/qnx6.h index 6c5e02a0b6a8..b00fcc960d37 100644 --- a/fs/qnx6/qnx6.h +++ b/fs/qnx6/qnx6.h | |||
@@ -45,7 +45,7 @@ struct qnx6_inode_info { | |||
45 | 45 | ||
46 | extern struct inode *qnx6_iget(struct super_block *sb, unsigned ino); | 46 | extern struct inode *qnx6_iget(struct super_block *sb, unsigned ino); |
47 | extern struct dentry *qnx6_lookup(struct inode *dir, struct dentry *dentry, | 47 | extern struct dentry *qnx6_lookup(struct inode *dir, struct dentry *dentry, |
48 | struct nameidata *nd); | 48 | unsigned int flags); |
49 | 49 | ||
50 | #ifdef CONFIG_QNX6FS_DEBUG | 50 | #ifdef CONFIG_QNX6FS_DEBUG |
51 | extern void qnx6_superblock_debug(struct qnx6_super_block *, | 51 | extern void qnx6_superblock_debug(struct qnx6_super_block *, |
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 10cbe841cb7e..36a29b753c79 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c | |||
@@ -78,7 +78,7 @@ | |||
78 | #include <linux/quotaops.h> | 78 | #include <linux/quotaops.h> |
79 | #include "../internal.h" /* ugh */ | 79 | #include "../internal.h" /* ugh */ |
80 | 80 | ||
81 | #include <asm/uaccess.h> | 81 | #include <linux/uaccess.h> |
82 | 82 | ||
83 | /* | 83 | /* |
84 | * There are three quota SMP locks. dq_list_lock protects all lists with quotas | 84 | * There are three quota SMP locks. dq_list_lock protects all lists with quotas |
@@ -595,12 +595,14 @@ out: | |||
595 | } | 595 | } |
596 | EXPORT_SYMBOL(dquot_scan_active); | 596 | EXPORT_SYMBOL(dquot_scan_active); |
597 | 597 | ||
598 | int dquot_quota_sync(struct super_block *sb, int type, int wait) | 598 | /* Write all dquot structures to quota files */ |
599 | int dquot_writeback_dquots(struct super_block *sb, int type) | ||
599 | { | 600 | { |
600 | struct list_head *dirty; | 601 | struct list_head *dirty; |
601 | struct dquot *dquot; | 602 | struct dquot *dquot; |
602 | struct quota_info *dqopt = sb_dqopt(sb); | 603 | struct quota_info *dqopt = sb_dqopt(sb); |
603 | int cnt; | 604 | int cnt; |
605 | int err, ret = 0; | ||
604 | 606 | ||
605 | mutex_lock(&dqopt->dqonoff_mutex); | 607 | mutex_lock(&dqopt->dqonoff_mutex); |
606 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 608 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
@@ -624,7 +626,9 @@ int dquot_quota_sync(struct super_block *sb, int type, int wait) | |||
624 | atomic_inc(&dquot->dq_count); | 626 | atomic_inc(&dquot->dq_count); |
625 | spin_unlock(&dq_list_lock); | 627 | spin_unlock(&dq_list_lock); |
626 | dqstats_inc(DQST_LOOKUPS); | 628 | dqstats_inc(DQST_LOOKUPS); |
627 | sb->dq_op->write_dquot(dquot); | 629 | err = sb->dq_op->write_dquot(dquot); |
630 | if (!ret && err) | ||
631 | err = ret; | ||
628 | dqput(dquot); | 632 | dqput(dquot); |
629 | spin_lock(&dq_list_lock); | 633 | spin_lock(&dq_list_lock); |
630 | } | 634 | } |
@@ -638,7 +642,21 @@ int dquot_quota_sync(struct super_block *sb, int type, int wait) | |||
638 | dqstats_inc(DQST_SYNCS); | 642 | dqstats_inc(DQST_SYNCS); |
639 | mutex_unlock(&dqopt->dqonoff_mutex); | 643 | mutex_unlock(&dqopt->dqonoff_mutex); |
640 | 644 | ||
641 | if (!wait || (dqopt->flags & DQUOT_QUOTA_SYS_FILE)) | 645 | return ret; |
646 | } | ||
647 | EXPORT_SYMBOL(dquot_writeback_dquots); | ||
648 | |||
649 | /* Write all dquot structures to disk and make them visible from userspace */ | ||
650 | int dquot_quota_sync(struct super_block *sb, int type) | ||
651 | { | ||
652 | struct quota_info *dqopt = sb_dqopt(sb); | ||
653 | int cnt; | ||
654 | int ret; | ||
655 | |||
656 | ret = dquot_writeback_dquots(sb, type); | ||
657 | if (ret) | ||
658 | return ret; | ||
659 | if (dqopt->flags & DQUOT_QUOTA_SYS_FILE) | ||
642 | return 0; | 660 | return 0; |
643 | 661 | ||
644 | /* This is not very clever (and fast) but currently I don't know about | 662 | /* This is not very clever (and fast) but currently I don't know about |
diff --git a/fs/quota/quota.c b/fs/quota/quota.c index 9a391204ca27..6f155788cbc6 100644 --- a/fs/quota/quota.c +++ b/fs/quota/quota.c | |||
@@ -9,7 +9,7 @@ | |||
9 | #include <linux/namei.h> | 9 | #include <linux/namei.h> |
10 | #include <linux/slab.h> | 10 | #include <linux/slab.h> |
11 | #include <asm/current.h> | 11 | #include <asm/current.h> |
12 | #include <asm/uaccess.h> | 12 | #include <linux/uaccess.h> |
13 | #include <linux/kernel.h> | 13 | #include <linux/kernel.h> |
14 | #include <linux/security.h> | 14 | #include <linux/security.h> |
15 | #include <linux/syscalls.h> | 15 | #include <linux/syscalls.h> |
@@ -47,7 +47,7 @@ static int check_quotactl_permission(struct super_block *sb, int type, int cmd, | |||
47 | static void quota_sync_one(struct super_block *sb, void *arg) | 47 | static void quota_sync_one(struct super_block *sb, void *arg) |
48 | { | 48 | { |
49 | if (sb->s_qcop && sb->s_qcop->quota_sync) | 49 | if (sb->s_qcop && sb->s_qcop->quota_sync) |
50 | sb->s_qcop->quota_sync(sb, *(int *)arg, 1); | 50 | sb->s_qcop->quota_sync(sb, *(int *)arg); |
51 | } | 51 | } |
52 | 52 | ||
53 | static int quota_sync_all(int type) | 53 | static int quota_sync_all(int type) |
@@ -270,7 +270,7 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, | |||
270 | case Q_SYNC: | 270 | case Q_SYNC: |
271 | if (!sb->s_qcop->quota_sync) | 271 | if (!sb->s_qcop->quota_sync) |
272 | return -ENOSYS; | 272 | return -ENOSYS; |
273 | return sb->s_qcop->quota_sync(sb, type, 1); | 273 | return sb->s_qcop->quota_sync(sb, type); |
274 | case Q_XQUOTAON: | 274 | case Q_XQUOTAON: |
275 | case Q_XQUOTAOFF: | 275 | case Q_XQUOTAOFF: |
276 | case Q_XQUOTARM: | 276 | case Q_XQUOTARM: |
diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c index fbb0b478a346..d5378d028589 100644 --- a/fs/ramfs/file-nommu.c +++ b/fs/ramfs/file-nommu.c | |||
@@ -110,6 +110,7 @@ int ramfs_nommu_expand_for_mapping(struct inode *inode, size_t newsize) | |||
110 | 110 | ||
111 | /* prevent the page from being discarded on memory pressure */ | 111 | /* prevent the page from being discarded on memory pressure */ |
112 | SetPageDirty(page); | 112 | SetPageDirty(page); |
113 | SetPageUptodate(page); | ||
113 | 114 | ||
114 | unlock_page(page); | 115 | unlock_page(page); |
115 | put_page(page); | 116 | put_page(page); |
diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c index a1fdabe21dec..eab8c09d3801 100644 --- a/fs/ramfs/inode.c +++ b/fs/ramfs/inode.c | |||
@@ -114,7 +114,7 @@ static int ramfs_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) | |||
114 | return retval; | 114 | return retval; |
115 | } | 115 | } |
116 | 116 | ||
117 | static int ramfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, struct nameidata *nd) | 117 | static int ramfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, bool excl) |
118 | { | 118 | { |
119 | return ramfs_mknod(dir, dentry, mode | S_IFREG, 0); | 119 | return ramfs_mknod(dir, dentry, mode | S_IFREG, 0); |
120 | } | 120 | } |
diff --git a/fs/read_write.c b/fs/read_write.c index c20614f86c01..1adfb691e4f1 100644 --- a/fs/read_write.c +++ b/fs/read_write.c | |||
@@ -55,10 +55,11 @@ static loff_t lseek_execute(struct file *file, struct inode *inode, | |||
55 | * @file: file structure to seek on | 55 | * @file: file structure to seek on |
56 | * @offset: file offset to seek to | 56 | * @offset: file offset to seek to |
57 | * @origin: type of seek | 57 | * @origin: type of seek |
58 | * @size: max size of file system | 58 | * @size: max size of this file in file system |
59 | * @eof: offset used for SEEK_END position | ||
59 | * | 60 | * |
60 | * This is a variant of generic_file_llseek that allows passing in a custom | 61 | * This is a variant of generic_file_llseek that allows passing in a custom |
61 | * file size. | 62 | * maximum file size and a custom EOF position, for e.g. hashed directories |
62 | * | 63 | * |
63 | * Synchronization: | 64 | * Synchronization: |
64 | * SEEK_SET and SEEK_END are unsynchronized (but atomic on 64bit platforms) | 65 | * SEEK_SET and SEEK_END are unsynchronized (but atomic on 64bit platforms) |
@@ -67,13 +68,13 @@ static loff_t lseek_execute(struct file *file, struct inode *inode, | |||
67 | */ | 68 | */ |
68 | loff_t | 69 | loff_t |
69 | generic_file_llseek_size(struct file *file, loff_t offset, int origin, | 70 | generic_file_llseek_size(struct file *file, loff_t offset, int origin, |
70 | loff_t maxsize) | 71 | loff_t maxsize, loff_t eof) |
71 | { | 72 | { |
72 | struct inode *inode = file->f_mapping->host; | 73 | struct inode *inode = file->f_mapping->host; |
73 | 74 | ||
74 | switch (origin) { | 75 | switch (origin) { |
75 | case SEEK_END: | 76 | case SEEK_END: |
76 | offset += i_size_read(inode); | 77 | offset += eof; |
77 | break; | 78 | break; |
78 | case SEEK_CUR: | 79 | case SEEK_CUR: |
79 | /* | 80 | /* |
@@ -99,7 +100,7 @@ generic_file_llseek_size(struct file *file, loff_t offset, int origin, | |||
99 | * In the generic case the entire file is data, so as long as | 100 | * In the generic case the entire file is data, so as long as |
100 | * offset isn't at the end of the file then the offset is data. | 101 | * offset isn't at the end of the file then the offset is data. |
101 | */ | 102 | */ |
102 | if (offset >= i_size_read(inode)) | 103 | if (offset >= eof) |
103 | return -ENXIO; | 104 | return -ENXIO; |
104 | break; | 105 | break; |
105 | case SEEK_HOLE: | 106 | case SEEK_HOLE: |
@@ -107,9 +108,9 @@ generic_file_llseek_size(struct file *file, loff_t offset, int origin, | |||
107 | * There is a virtual hole at the end of the file, so as long as | 108 | * There is a virtual hole at the end of the file, so as long as |
108 | * offset isn't i_size or larger, return i_size. | 109 | * offset isn't i_size or larger, return i_size. |
109 | */ | 110 | */ |
110 | if (offset >= i_size_read(inode)) | 111 | if (offset >= eof) |
111 | return -ENXIO; | 112 | return -ENXIO; |
112 | offset = i_size_read(inode); | 113 | offset = eof; |
113 | break; | 114 | break; |
114 | } | 115 | } |
115 | 116 | ||
@@ -132,7 +133,8 @@ loff_t generic_file_llseek(struct file *file, loff_t offset, int origin) | |||
132 | struct inode *inode = file->f_mapping->host; | 133 | struct inode *inode = file->f_mapping->host; |
133 | 134 | ||
134 | return generic_file_llseek_size(file, offset, origin, | 135 | return generic_file_llseek_size(file, offset, origin, |
135 | inode->i_sb->s_maxbytes); | 136 | inode->i_sb->s_maxbytes, |
137 | i_size_read(inode)); | ||
136 | } | 138 | } |
137 | EXPORT_SYMBOL(generic_file_llseek); | 139 | EXPORT_SYMBOL(generic_file_llseek); |
138 | 140 | ||
diff --git a/fs/reiserfs/namei.c b/fs/reiserfs/namei.c index 84e8a69cee9d..8567fb847601 100644 --- a/fs/reiserfs/namei.c +++ b/fs/reiserfs/namei.c | |||
@@ -322,7 +322,7 @@ static int reiserfs_find_entry(struct inode *dir, const char *name, int namelen, | |||
322 | } | 322 | } |
323 | 323 | ||
324 | static struct dentry *reiserfs_lookup(struct inode *dir, struct dentry *dentry, | 324 | static struct dentry *reiserfs_lookup(struct inode *dir, struct dentry *dentry, |
325 | struct nameidata *nd) | 325 | unsigned int flags) |
326 | { | 326 | { |
327 | int retval; | 327 | int retval; |
328 | int lock_depth; | 328 | int lock_depth; |
@@ -573,7 +573,7 @@ static int new_inode_init(struct inode *inode, struct inode *dir, umode_t mode) | |||
573 | } | 573 | } |
574 | 574 | ||
575 | static int reiserfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 575 | static int reiserfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
576 | struct nameidata *nd) | 576 | bool excl) |
577 | { | 577 | { |
578 | int retval; | 578 | int retval; |
579 | struct inode *inode; | 579 | struct inode *inode; |
@@ -634,8 +634,8 @@ static int reiserfs_create(struct inode *dir, struct dentry *dentry, umode_t mod | |||
634 | reiserfs_update_inode_transaction(inode); | 634 | reiserfs_update_inode_transaction(inode); |
635 | reiserfs_update_inode_transaction(dir); | 635 | reiserfs_update_inode_transaction(dir); |
636 | 636 | ||
637 | d_instantiate(dentry, inode); | ||
638 | unlock_new_inode(inode); | 637 | unlock_new_inode(inode); |
638 | d_instantiate(dentry, inode); | ||
639 | retval = journal_end(&th, dir->i_sb, jbegin_count); | 639 | retval = journal_end(&th, dir->i_sb, jbegin_count); |
640 | 640 | ||
641 | out_failed: | 641 | out_failed: |
@@ -712,8 +712,8 @@ static int reiserfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode | |||
712 | goto out_failed; | 712 | goto out_failed; |
713 | } | 713 | } |
714 | 714 | ||
715 | d_instantiate(dentry, inode); | ||
716 | unlock_new_inode(inode); | 715 | unlock_new_inode(inode); |
716 | d_instantiate(dentry, inode); | ||
717 | retval = journal_end(&th, dir->i_sb, jbegin_count); | 717 | retval = journal_end(&th, dir->i_sb, jbegin_count); |
718 | 718 | ||
719 | out_failed: | 719 | out_failed: |
@@ -800,8 +800,8 @@ static int reiserfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode | |||
800 | // the above add_entry did not update dir's stat data | 800 | // the above add_entry did not update dir's stat data |
801 | reiserfs_update_sd(&th, dir); | 801 | reiserfs_update_sd(&th, dir); |
802 | 802 | ||
803 | d_instantiate(dentry, inode); | ||
804 | unlock_new_inode(inode); | 803 | unlock_new_inode(inode); |
804 | d_instantiate(dentry, inode); | ||
805 | retval = journal_end(&th, dir->i_sb, jbegin_count); | 805 | retval = journal_end(&th, dir->i_sb, jbegin_count); |
806 | out_failed: | 806 | out_failed: |
807 | reiserfs_write_unlock_once(dir->i_sb, lock_depth); | 807 | reiserfs_write_unlock_once(dir->i_sb, lock_depth); |
@@ -1096,8 +1096,8 @@ static int reiserfs_symlink(struct inode *parent_dir, | |||
1096 | goto out_failed; | 1096 | goto out_failed; |
1097 | } | 1097 | } |
1098 | 1098 | ||
1099 | d_instantiate(dentry, inode); | ||
1100 | unlock_new_inode(inode); | 1099 | unlock_new_inode(inode); |
1100 | d_instantiate(dentry, inode); | ||
1101 | retval = journal_end(&th, parent_dir->i_sb, jbegin_count); | 1101 | retval = journal_end(&th, parent_dir->i_sb, jbegin_count); |
1102 | out_failed: | 1102 | out_failed: |
1103 | reiserfs_write_unlock(parent_dir->i_sb); | 1103 | reiserfs_write_unlock(parent_dir->i_sb); |
diff --git a/fs/reiserfs/procfs.c b/fs/reiserfs/procfs.c index 2c1ade692cc8..e60e87035bb3 100644 --- a/fs/reiserfs/procfs.c +++ b/fs/reiserfs/procfs.c | |||
@@ -403,7 +403,7 @@ static void *r_start(struct seq_file *m, loff_t * pos) | |||
403 | if (l) | 403 | if (l) |
404 | return NULL; | 404 | return NULL; |
405 | 405 | ||
406 | if (IS_ERR(sget(&reiserfs_fs_type, test_sb, set_sb, s))) | 406 | if (IS_ERR(sget(&reiserfs_fs_type, test_sb, set_sb, 0, s))) |
407 | return NULL; | 407 | return NULL; |
408 | 408 | ||
409 | up_write(&s->s_umount); | 409 | up_write(&s->s_umount); |
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index 651ce767b55d..7a37dabf5a96 100644 --- a/fs/reiserfs/super.c +++ b/fs/reiserfs/super.c | |||
@@ -68,6 +68,11 @@ static int reiserfs_sync_fs(struct super_block *s, int wait) | |||
68 | { | 68 | { |
69 | struct reiserfs_transaction_handle th; | 69 | struct reiserfs_transaction_handle th; |
70 | 70 | ||
71 | /* | ||
72 | * Writeback quota in non-journalled quota case - journalled quota has | ||
73 | * no dirty dquots | ||
74 | */ | ||
75 | dquot_writeback_dquots(s, -1); | ||
71 | reiserfs_write_lock(s); | 76 | reiserfs_write_lock(s); |
72 | if (!journal_begin(&th, s, 1)) | 77 | if (!journal_begin(&th, s, 1)) |
73 | if (!journal_end_sync(&th, s, 1)) | 78 | if (!journal_end_sync(&th, s, 1)) |
diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c index 46fc1c20a6b1..d319963aeb11 100644 --- a/fs/reiserfs/xattr.c +++ b/fs/reiserfs/xattr.c | |||
@@ -62,7 +62,7 @@ | |||
62 | static int xattr_create(struct inode *dir, struct dentry *dentry, int mode) | 62 | static int xattr_create(struct inode *dir, struct dentry *dentry, int mode) |
63 | { | 63 | { |
64 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); | 64 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); |
65 | return dir->i_op->create(dir, dentry, mode, NULL); | 65 | return dir->i_op->create(dir, dentry, mode, true); |
66 | } | 66 | } |
67 | #endif | 67 | #endif |
68 | 68 | ||
@@ -942,7 +942,7 @@ int reiserfs_permission(struct inode *inode, int mask) | |||
942 | return generic_permission(inode, mask); | 942 | return generic_permission(inode, mask); |
943 | } | 943 | } |
944 | 944 | ||
945 | static int xattr_hide_revalidate(struct dentry *dentry, struct nameidata *nd) | 945 | static int xattr_hide_revalidate(struct dentry *dentry, unsigned int flags) |
946 | { | 946 | { |
947 | return -EPERM; | 947 | return -EPERM; |
948 | } | 948 | } |
diff --git a/fs/romfs/super.c b/fs/romfs/super.c index e64f6b5f7ae5..77c5f2173983 100644 --- a/fs/romfs/super.c +++ b/fs/romfs/super.c | |||
@@ -210,7 +210,7 @@ out: | |||
210 | * look up an entry in a directory | 210 | * look up an entry in a directory |
211 | */ | 211 | */ |
212 | static struct dentry *romfs_lookup(struct inode *dir, struct dentry *dentry, | 212 | static struct dentry *romfs_lookup(struct inode *dir, struct dentry *dentry, |
213 | struct nameidata *nd) | 213 | unsigned int flags) |
214 | { | 214 | { |
215 | unsigned long offset, maxoff; | 215 | unsigned long offset, maxoff; |
216 | struct inode *inode; | 216 | struct inode *inode; |
diff --git a/fs/splice.c b/fs/splice.c index c9f1318a3b82..7bf08fa22ec9 100644 --- a/fs/splice.c +++ b/fs/splice.c | |||
@@ -273,13 +273,16 @@ void spd_release_page(struct splice_pipe_desc *spd, unsigned int i) | |||
273 | * Check if we need to grow the arrays holding pages and partial page | 273 | * Check if we need to grow the arrays holding pages and partial page |
274 | * descriptions. | 274 | * descriptions. |
275 | */ | 275 | */ |
276 | int splice_grow_spd(struct pipe_inode_info *pipe, struct splice_pipe_desc *spd) | 276 | int splice_grow_spd(const struct pipe_inode_info *pipe, struct splice_pipe_desc *spd) |
277 | { | 277 | { |
278 | if (pipe->buffers <= PIPE_DEF_BUFFERS) | 278 | unsigned int buffers = ACCESS_ONCE(pipe->buffers); |
279 | |||
280 | spd->nr_pages_max = buffers; | ||
281 | if (buffers <= PIPE_DEF_BUFFERS) | ||
279 | return 0; | 282 | return 0; |
280 | 283 | ||
281 | spd->pages = kmalloc(pipe->buffers * sizeof(struct page *), GFP_KERNEL); | 284 | spd->pages = kmalloc(buffers * sizeof(struct page *), GFP_KERNEL); |
282 | spd->partial = kmalloc(pipe->buffers * sizeof(struct partial_page), GFP_KERNEL); | 285 | spd->partial = kmalloc(buffers * sizeof(struct partial_page), GFP_KERNEL); |
283 | 286 | ||
284 | if (spd->pages && spd->partial) | 287 | if (spd->pages && spd->partial) |
285 | return 0; | 288 | return 0; |
@@ -289,10 +292,9 @@ int splice_grow_spd(struct pipe_inode_info *pipe, struct splice_pipe_desc *spd) | |||
289 | return -ENOMEM; | 292 | return -ENOMEM; |
290 | } | 293 | } |
291 | 294 | ||
292 | void splice_shrink_spd(struct pipe_inode_info *pipe, | 295 | void splice_shrink_spd(struct splice_pipe_desc *spd) |
293 | struct splice_pipe_desc *spd) | ||
294 | { | 296 | { |
295 | if (pipe->buffers <= PIPE_DEF_BUFFERS) | 297 | if (spd->nr_pages_max <= PIPE_DEF_BUFFERS) |
296 | return; | 298 | return; |
297 | 299 | ||
298 | kfree(spd->pages); | 300 | kfree(spd->pages); |
@@ -315,6 +317,7 @@ __generic_file_splice_read(struct file *in, loff_t *ppos, | |||
315 | struct splice_pipe_desc spd = { | 317 | struct splice_pipe_desc spd = { |
316 | .pages = pages, | 318 | .pages = pages, |
317 | .partial = partial, | 319 | .partial = partial, |
320 | .nr_pages_max = PIPE_DEF_BUFFERS, | ||
318 | .flags = flags, | 321 | .flags = flags, |
319 | .ops = &page_cache_pipe_buf_ops, | 322 | .ops = &page_cache_pipe_buf_ops, |
320 | .spd_release = spd_release_page, | 323 | .spd_release = spd_release_page, |
@@ -326,7 +329,7 @@ __generic_file_splice_read(struct file *in, loff_t *ppos, | |||
326 | index = *ppos >> PAGE_CACHE_SHIFT; | 329 | index = *ppos >> PAGE_CACHE_SHIFT; |
327 | loff = *ppos & ~PAGE_CACHE_MASK; | 330 | loff = *ppos & ~PAGE_CACHE_MASK; |
328 | req_pages = (len + loff + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT; | 331 | req_pages = (len + loff + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT; |
329 | nr_pages = min(req_pages, pipe->buffers); | 332 | nr_pages = min(req_pages, spd.nr_pages_max); |
330 | 333 | ||
331 | /* | 334 | /* |
332 | * Lookup the (hopefully) full range of pages we need. | 335 | * Lookup the (hopefully) full range of pages we need. |
@@ -497,7 +500,7 @@ fill_it: | |||
497 | if (spd.nr_pages) | 500 | if (spd.nr_pages) |
498 | error = splice_to_pipe(pipe, &spd); | 501 | error = splice_to_pipe(pipe, &spd); |
499 | 502 | ||
500 | splice_shrink_spd(pipe, &spd); | 503 | splice_shrink_spd(&spd); |
501 | return error; | 504 | return error; |
502 | } | 505 | } |
503 | 506 | ||
@@ -598,6 +601,7 @@ ssize_t default_file_splice_read(struct file *in, loff_t *ppos, | |||
598 | struct splice_pipe_desc spd = { | 601 | struct splice_pipe_desc spd = { |
599 | .pages = pages, | 602 | .pages = pages, |
600 | .partial = partial, | 603 | .partial = partial, |
604 | .nr_pages_max = PIPE_DEF_BUFFERS, | ||
601 | .flags = flags, | 605 | .flags = flags, |
602 | .ops = &default_pipe_buf_ops, | 606 | .ops = &default_pipe_buf_ops, |
603 | .spd_release = spd_release_page, | 607 | .spd_release = spd_release_page, |
@@ -608,8 +612,8 @@ ssize_t default_file_splice_read(struct file *in, loff_t *ppos, | |||
608 | 612 | ||
609 | res = -ENOMEM; | 613 | res = -ENOMEM; |
610 | vec = __vec; | 614 | vec = __vec; |
611 | if (pipe->buffers > PIPE_DEF_BUFFERS) { | 615 | if (spd.nr_pages_max > PIPE_DEF_BUFFERS) { |
612 | vec = kmalloc(pipe->buffers * sizeof(struct iovec), GFP_KERNEL); | 616 | vec = kmalloc(spd.nr_pages_max * sizeof(struct iovec), GFP_KERNEL); |
613 | if (!vec) | 617 | if (!vec) |
614 | goto shrink_ret; | 618 | goto shrink_ret; |
615 | } | 619 | } |
@@ -617,7 +621,7 @@ ssize_t default_file_splice_read(struct file *in, loff_t *ppos, | |||
617 | offset = *ppos & ~PAGE_CACHE_MASK; | 621 | offset = *ppos & ~PAGE_CACHE_MASK; |
618 | nr_pages = (len + offset + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT; | 622 | nr_pages = (len + offset + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT; |
619 | 623 | ||
620 | for (i = 0; i < nr_pages && i < pipe->buffers && len; i++) { | 624 | for (i = 0; i < nr_pages && i < spd.nr_pages_max && len; i++) { |
621 | struct page *page; | 625 | struct page *page; |
622 | 626 | ||
623 | page = alloc_page(GFP_USER); | 627 | page = alloc_page(GFP_USER); |
@@ -665,7 +669,7 @@ ssize_t default_file_splice_read(struct file *in, loff_t *ppos, | |||
665 | shrink_ret: | 669 | shrink_ret: |
666 | if (vec != __vec) | 670 | if (vec != __vec) |
667 | kfree(vec); | 671 | kfree(vec); |
668 | splice_shrink_spd(pipe, &spd); | 672 | splice_shrink_spd(&spd); |
669 | return res; | 673 | return res; |
670 | 674 | ||
671 | err: | 675 | err: |
@@ -1614,6 +1618,7 @@ static long vmsplice_to_pipe(struct file *file, const struct iovec __user *iov, | |||
1614 | struct splice_pipe_desc spd = { | 1618 | struct splice_pipe_desc spd = { |
1615 | .pages = pages, | 1619 | .pages = pages, |
1616 | .partial = partial, | 1620 | .partial = partial, |
1621 | .nr_pages_max = PIPE_DEF_BUFFERS, | ||
1617 | .flags = flags, | 1622 | .flags = flags, |
1618 | .ops = &user_page_pipe_buf_ops, | 1623 | .ops = &user_page_pipe_buf_ops, |
1619 | .spd_release = spd_release_page, | 1624 | .spd_release = spd_release_page, |
@@ -1629,13 +1634,13 @@ static long vmsplice_to_pipe(struct file *file, const struct iovec __user *iov, | |||
1629 | 1634 | ||
1630 | spd.nr_pages = get_iovec_page_array(iov, nr_segs, spd.pages, | 1635 | spd.nr_pages = get_iovec_page_array(iov, nr_segs, spd.pages, |
1631 | spd.partial, false, | 1636 | spd.partial, false, |
1632 | pipe->buffers); | 1637 | spd.nr_pages_max); |
1633 | if (spd.nr_pages <= 0) | 1638 | if (spd.nr_pages <= 0) |
1634 | ret = spd.nr_pages; | 1639 | ret = spd.nr_pages; |
1635 | else | 1640 | else |
1636 | ret = splice_to_pipe(pipe, &spd); | 1641 | ret = splice_to_pipe(pipe, &spd); |
1637 | 1642 | ||
1638 | splice_shrink_spd(pipe, &spd); | 1643 | splice_shrink_spd(&spd); |
1639 | return ret; | 1644 | return ret; |
1640 | } | 1645 | } |
1641 | 1646 | ||
diff --git a/fs/squashfs/namei.c b/fs/squashfs/namei.c index abcc58f3c152..7834a517f7f4 100644 --- a/fs/squashfs/namei.c +++ b/fs/squashfs/namei.c | |||
@@ -134,7 +134,7 @@ out: | |||
134 | 134 | ||
135 | 135 | ||
136 | static struct dentry *squashfs_lookup(struct inode *dir, struct dentry *dentry, | 136 | static struct dentry *squashfs_lookup(struct inode *dir, struct dentry *dentry, |
137 | struct nameidata *nd) | 137 | unsigned int flags) |
138 | { | 138 | { |
139 | const unsigned char *name = dentry->d_name.name; | 139 | const unsigned char *name = dentry->d_name.name; |
140 | int len = dentry->d_name.len; | 140 | int len = dentry->d_name.len; |
diff --git a/fs/super.c b/fs/super.c index cf001775617f..c743fb3be4b8 100644 --- a/fs/super.c +++ b/fs/super.c | |||
@@ -105,11 +105,12 @@ static int prune_super(struct shrinker *shrink, struct shrink_control *sc) | |||
105 | /** | 105 | /** |
106 | * alloc_super - create new superblock | 106 | * alloc_super - create new superblock |
107 | * @type: filesystem type superblock should belong to | 107 | * @type: filesystem type superblock should belong to |
108 | * @flags: the mount flags | ||
108 | * | 109 | * |
109 | * Allocates and initializes a new &struct super_block. alloc_super() | 110 | * Allocates and initializes a new &struct super_block. alloc_super() |
110 | * returns a pointer new superblock or %NULL if allocation had failed. | 111 | * returns a pointer new superblock or %NULL if allocation had failed. |
111 | */ | 112 | */ |
112 | static struct super_block *alloc_super(struct file_system_type *type) | 113 | static struct super_block *alloc_super(struct file_system_type *type, int flags) |
113 | { | 114 | { |
114 | struct super_block *s = kzalloc(sizeof(struct super_block), GFP_USER); | 115 | struct super_block *s = kzalloc(sizeof(struct super_block), GFP_USER); |
115 | static const struct super_operations default_op; | 116 | static const struct super_operations default_op; |
@@ -136,6 +137,7 @@ static struct super_block *alloc_super(struct file_system_type *type) | |||
136 | #else | 137 | #else |
137 | INIT_LIST_HEAD(&s->s_files); | 138 | INIT_LIST_HEAD(&s->s_files); |
138 | #endif | 139 | #endif |
140 | s->s_flags = flags; | ||
139 | s->s_bdi = &default_backing_dev_info; | 141 | s->s_bdi = &default_backing_dev_info; |
140 | INIT_HLIST_NODE(&s->s_instances); | 142 | INIT_HLIST_NODE(&s->s_instances); |
141 | INIT_HLIST_BL_HEAD(&s->s_anon); | 143 | INIT_HLIST_BL_HEAD(&s->s_anon); |
@@ -415,11 +417,13 @@ EXPORT_SYMBOL(generic_shutdown_super); | |||
415 | * @type: filesystem type superblock should belong to | 417 | * @type: filesystem type superblock should belong to |
416 | * @test: comparison callback | 418 | * @test: comparison callback |
417 | * @set: setup callback | 419 | * @set: setup callback |
420 | * @flags: mount flags | ||
418 | * @data: argument to each of them | 421 | * @data: argument to each of them |
419 | */ | 422 | */ |
420 | struct super_block *sget(struct file_system_type *type, | 423 | struct super_block *sget(struct file_system_type *type, |
421 | int (*test)(struct super_block *,void *), | 424 | int (*test)(struct super_block *,void *), |
422 | int (*set)(struct super_block *,void *), | 425 | int (*set)(struct super_block *,void *), |
426 | int flags, | ||
423 | void *data) | 427 | void *data) |
424 | { | 428 | { |
425 | struct super_block *s = NULL; | 429 | struct super_block *s = NULL; |
@@ -450,7 +454,7 @@ retry: | |||
450 | } | 454 | } |
451 | if (!s) { | 455 | if (!s) { |
452 | spin_unlock(&sb_lock); | 456 | spin_unlock(&sb_lock); |
453 | s = alloc_super(type); | 457 | s = alloc_super(type, flags); |
454 | if (!s) | 458 | if (!s) |
455 | return ERR_PTR(-ENOMEM); | 459 | return ERR_PTR(-ENOMEM); |
456 | goto retry; | 460 | goto retry; |
@@ -925,13 +929,12 @@ struct dentry *mount_ns(struct file_system_type *fs_type, int flags, | |||
925 | { | 929 | { |
926 | struct super_block *sb; | 930 | struct super_block *sb; |
927 | 931 | ||
928 | sb = sget(fs_type, ns_test_super, ns_set_super, data); | 932 | sb = sget(fs_type, ns_test_super, ns_set_super, flags, data); |
929 | if (IS_ERR(sb)) | 933 | if (IS_ERR(sb)) |
930 | return ERR_CAST(sb); | 934 | return ERR_CAST(sb); |
931 | 935 | ||
932 | if (!sb->s_root) { | 936 | if (!sb->s_root) { |
933 | int err; | 937 | int err; |
934 | sb->s_flags = flags; | ||
935 | err = fill_super(sb, data, flags & MS_SILENT ? 1 : 0); | 938 | err = fill_super(sb, data, flags & MS_SILENT ? 1 : 0); |
936 | if (err) { | 939 | if (err) { |
937 | deactivate_locked_super(sb); | 940 | deactivate_locked_super(sb); |
@@ -992,7 +995,8 @@ struct dentry *mount_bdev(struct file_system_type *fs_type, | |||
992 | error = -EBUSY; | 995 | error = -EBUSY; |
993 | goto error_bdev; | 996 | goto error_bdev; |
994 | } | 997 | } |
995 | s = sget(fs_type, test_bdev_super, set_bdev_super, bdev); | 998 | s = sget(fs_type, test_bdev_super, set_bdev_super, flags | MS_NOSEC, |
999 | bdev); | ||
996 | mutex_unlock(&bdev->bd_fsfreeze_mutex); | 1000 | mutex_unlock(&bdev->bd_fsfreeze_mutex); |
997 | if (IS_ERR(s)) | 1001 | if (IS_ERR(s)) |
998 | goto error_s; | 1002 | goto error_s; |
@@ -1017,7 +1021,6 @@ struct dentry *mount_bdev(struct file_system_type *fs_type, | |||
1017 | } else { | 1021 | } else { |
1018 | char b[BDEVNAME_SIZE]; | 1022 | char b[BDEVNAME_SIZE]; |
1019 | 1023 | ||
1020 | s->s_flags = flags | MS_NOSEC; | ||
1021 | s->s_mode = mode; | 1024 | s->s_mode = mode; |
1022 | strlcpy(s->s_id, bdevname(bdev, b), sizeof(s->s_id)); | 1025 | strlcpy(s->s_id, bdevname(bdev, b), sizeof(s->s_id)); |
1023 | sb_set_blocksize(s, block_size(bdev)); | 1026 | sb_set_blocksize(s, block_size(bdev)); |
@@ -1062,13 +1065,11 @@ struct dentry *mount_nodev(struct file_system_type *fs_type, | |||
1062 | int (*fill_super)(struct super_block *, void *, int)) | 1065 | int (*fill_super)(struct super_block *, void *, int)) |
1063 | { | 1066 | { |
1064 | int error; | 1067 | int error; |
1065 | struct super_block *s = sget(fs_type, NULL, set_anon_super, NULL); | 1068 | struct super_block *s = sget(fs_type, NULL, set_anon_super, flags, NULL); |
1066 | 1069 | ||
1067 | if (IS_ERR(s)) | 1070 | if (IS_ERR(s)) |
1068 | return ERR_CAST(s); | 1071 | return ERR_CAST(s); |
1069 | 1072 | ||
1070 | s->s_flags = flags; | ||
1071 | |||
1072 | error = fill_super(s, data, flags & MS_SILENT ? 1 : 0); | 1073 | error = fill_super(s, data, flags & MS_SILENT ? 1 : 0); |
1073 | if (error) { | 1074 | if (error) { |
1074 | deactivate_locked_super(s); | 1075 | deactivate_locked_super(s); |
@@ -1091,11 +1092,10 @@ struct dentry *mount_single(struct file_system_type *fs_type, | |||
1091 | struct super_block *s; | 1092 | struct super_block *s; |
1092 | int error; | 1093 | int error; |
1093 | 1094 | ||
1094 | s = sget(fs_type, compare_single, set_anon_super, NULL); | 1095 | s = sget(fs_type, compare_single, set_anon_super, flags, NULL); |
1095 | if (IS_ERR(s)) | 1096 | if (IS_ERR(s)) |
1096 | return ERR_CAST(s); | 1097 | return ERR_CAST(s); |
1097 | if (!s->s_root) { | 1098 | if (!s->s_root) { |
1098 | s->s_flags = flags; | ||
1099 | error = fill_super(s, data, flags & MS_SILENT ? 1 : 0); | 1099 | error = fill_super(s, data, flags & MS_SILENT ? 1 : 0); |
1100 | if (error) { | 1100 | if (error) { |
1101 | deactivate_locked_super(s); | 1101 | deactivate_locked_super(s); |
@@ -29,16 +29,6 @@ | |||
29 | */ | 29 | */ |
30 | static int __sync_filesystem(struct super_block *sb, int wait) | 30 | static int __sync_filesystem(struct super_block *sb, int wait) |
31 | { | 31 | { |
32 | /* | ||
33 | * This should be safe, as we require bdi backing to actually | ||
34 | * write out data in the first place | ||
35 | */ | ||
36 | if (sb->s_bdi == &noop_backing_dev_info) | ||
37 | return 0; | ||
38 | |||
39 | if (sb->s_qcop && sb->s_qcop->quota_sync) | ||
40 | sb->s_qcop->quota_sync(sb, -1, wait); | ||
41 | |||
42 | if (wait) | 32 | if (wait) |
43 | sync_inodes_sb(sb); | 33 | sync_inodes_sb(sb); |
44 | else | 34 | else |
@@ -77,29 +67,48 @@ int sync_filesystem(struct super_block *sb) | |||
77 | } | 67 | } |
78 | EXPORT_SYMBOL_GPL(sync_filesystem); | 68 | EXPORT_SYMBOL_GPL(sync_filesystem); |
79 | 69 | ||
80 | static void sync_one_sb(struct super_block *sb, void *arg) | 70 | static void sync_inodes_one_sb(struct super_block *sb, void *arg) |
81 | { | 71 | { |
82 | if (!(sb->s_flags & MS_RDONLY)) | 72 | if (!(sb->s_flags & MS_RDONLY)) |
83 | __sync_filesystem(sb, *(int *)arg); | 73 | sync_inodes_sb(sb); |
84 | } | 74 | } |
85 | /* | 75 | |
86 | * Sync all the data for all the filesystems (called by sys_sync() and | 76 | static void sync_fs_one_sb(struct super_block *sb, void *arg) |
87 | * emergency sync) | ||
88 | */ | ||
89 | static void sync_filesystems(int wait) | ||
90 | { | 77 | { |
91 | iterate_supers(sync_one_sb, &wait); | 78 | if (!(sb->s_flags & MS_RDONLY) && sb->s_op->sync_fs) |
79 | sb->s_op->sync_fs(sb, *(int *)arg); | ||
80 | } | ||
81 | |||
82 | static void fdatawrite_one_bdev(struct block_device *bdev, void *arg) | ||
83 | { | ||
84 | filemap_fdatawrite(bdev->bd_inode->i_mapping); | ||
85 | } | ||
86 | |||
87 | static void fdatawait_one_bdev(struct block_device *bdev, void *arg) | ||
88 | { | ||
89 | filemap_fdatawait(bdev->bd_inode->i_mapping); | ||
92 | } | 90 | } |
93 | 91 | ||
94 | /* | 92 | /* |
95 | * sync everything. Start out by waking pdflush, because that writes back | 93 | * Sync everything. We start by waking flusher threads so that most of |
96 | * all queues in parallel. | 94 | * writeback runs on all devices in parallel. Then we sync all inodes reliably |
95 | * which effectively also waits for all flusher threads to finish doing | ||
96 | * writeback. At this point all data is on disk so metadata should be stable | ||
97 | * and we tell filesystems to sync their metadata via ->sync_fs() calls. | ||
98 | * Finally, we writeout all block devices because some filesystems (e.g. ext2) | ||
99 | * just write metadata (such as inodes or bitmaps) to block device page cache | ||
100 | * and do not sync it on their own in ->sync_fs(). | ||
97 | */ | 101 | */ |
98 | SYSCALL_DEFINE0(sync) | 102 | SYSCALL_DEFINE0(sync) |
99 | { | 103 | { |
104 | int nowait = 0, wait = 1; | ||
105 | |||
100 | wakeup_flusher_threads(0, WB_REASON_SYNC); | 106 | wakeup_flusher_threads(0, WB_REASON_SYNC); |
101 | sync_filesystems(0); | 107 | iterate_supers(sync_inodes_one_sb, NULL); |
102 | sync_filesystems(1); | 108 | iterate_supers(sync_fs_one_sb, &nowait); |
109 | iterate_supers(sync_fs_one_sb, &wait); | ||
110 | iterate_bdevs(fdatawrite_one_bdev, NULL); | ||
111 | iterate_bdevs(fdatawait_one_bdev, NULL); | ||
103 | if (unlikely(laptop_mode)) | 112 | if (unlikely(laptop_mode)) |
104 | laptop_sync_completion(); | 113 | laptop_sync_completion(); |
105 | return 0; | 114 | return 0; |
@@ -107,12 +116,18 @@ SYSCALL_DEFINE0(sync) | |||
107 | 116 | ||
108 | static void do_sync_work(struct work_struct *work) | 117 | static void do_sync_work(struct work_struct *work) |
109 | { | 118 | { |
119 | int nowait = 0; | ||
120 | |||
110 | /* | 121 | /* |
111 | * Sync twice to reduce the possibility we skipped some inodes / pages | 122 | * Sync twice to reduce the possibility we skipped some inodes / pages |
112 | * because they were temporarily locked | 123 | * because they were temporarily locked |
113 | */ | 124 | */ |
114 | sync_filesystems(0); | 125 | iterate_supers(sync_inodes_one_sb, &nowait); |
115 | sync_filesystems(0); | 126 | iterate_supers(sync_fs_one_sb, &nowait); |
127 | iterate_bdevs(fdatawrite_one_bdev, NULL); | ||
128 | iterate_supers(sync_inodes_one_sb, &nowait); | ||
129 | iterate_supers(sync_fs_one_sb, &nowait); | ||
130 | iterate_bdevs(fdatawrite_one_bdev, NULL); | ||
116 | printk("Emergency Sync complete\n"); | 131 | printk("Emergency Sync complete\n"); |
117 | kfree(work); | 132 | kfree(work); |
118 | } | 133 | } |
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index e6bb9b2a4cbe..a5cf784f9cc2 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c | |||
@@ -300,15 +300,15 @@ void release_sysfs_dirent(struct sysfs_dirent * sd) | |||
300 | static int sysfs_dentry_delete(const struct dentry *dentry) | 300 | static int sysfs_dentry_delete(const struct dentry *dentry) |
301 | { | 301 | { |
302 | struct sysfs_dirent *sd = dentry->d_fsdata; | 302 | struct sysfs_dirent *sd = dentry->d_fsdata; |
303 | return !!(sd->s_flags & SYSFS_FLAG_REMOVED); | 303 | return !(sd && !(sd->s_flags & SYSFS_FLAG_REMOVED)); |
304 | } | 304 | } |
305 | 305 | ||
306 | static int sysfs_dentry_revalidate(struct dentry *dentry, struct nameidata *nd) | 306 | static int sysfs_dentry_revalidate(struct dentry *dentry, unsigned int flags) |
307 | { | 307 | { |
308 | struct sysfs_dirent *sd; | 308 | struct sysfs_dirent *sd; |
309 | int is_dir; | 309 | int is_dir; |
310 | 310 | ||
311 | if (nd->flags & LOOKUP_RCU) | 311 | if (flags & LOOKUP_RCU) |
312 | return -ECHILD; | 312 | return -ECHILD; |
313 | 313 | ||
314 | sd = dentry->d_fsdata; | 314 | sd = dentry->d_fsdata; |
@@ -355,18 +355,15 @@ out_bad: | |||
355 | return 0; | 355 | return 0; |
356 | } | 356 | } |
357 | 357 | ||
358 | static void sysfs_dentry_iput(struct dentry *dentry, struct inode *inode) | 358 | static void sysfs_dentry_release(struct dentry *dentry) |
359 | { | 359 | { |
360 | struct sysfs_dirent * sd = dentry->d_fsdata; | 360 | sysfs_put(dentry->d_fsdata); |
361 | |||
362 | sysfs_put(sd); | ||
363 | iput(inode); | ||
364 | } | 361 | } |
365 | 362 | ||
366 | static const struct dentry_operations sysfs_dentry_ops = { | 363 | const struct dentry_operations sysfs_dentry_ops = { |
367 | .d_revalidate = sysfs_dentry_revalidate, | 364 | .d_revalidate = sysfs_dentry_revalidate, |
368 | .d_delete = sysfs_dentry_delete, | 365 | .d_delete = sysfs_dentry_delete, |
369 | .d_iput = sysfs_dentry_iput, | 366 | .d_release = sysfs_dentry_release, |
370 | }; | 367 | }; |
371 | 368 | ||
372 | struct sysfs_dirent *sysfs_new_dirent(const char *name, umode_t mode, int type) | 369 | struct sysfs_dirent *sysfs_new_dirent(const char *name, umode_t mode, int type) |
@@ -764,7 +761,7 @@ int sysfs_create_dir(struct kobject * kobj) | |||
764 | } | 761 | } |
765 | 762 | ||
766 | static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, | 763 | static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, |
767 | struct nameidata *nd) | 764 | unsigned int flags) |
768 | { | 765 | { |
769 | struct dentry *ret = NULL; | 766 | struct dentry *ret = NULL; |
770 | struct dentry *parent = dentry->d_parent; | 767 | struct dentry *parent = dentry->d_parent; |
@@ -786,6 +783,7 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, | |||
786 | ret = ERR_PTR(-ENOENT); | 783 | ret = ERR_PTR(-ENOENT); |
787 | goto out_unlock; | 784 | goto out_unlock; |
788 | } | 785 | } |
786 | dentry->d_fsdata = sysfs_get(sd); | ||
789 | 787 | ||
790 | /* attach dentry and inode */ | 788 | /* attach dentry and inode */ |
791 | inode = sysfs_get_inode(dir->i_sb, sd); | 789 | inode = sysfs_get_inode(dir->i_sb, sd); |
@@ -795,16 +793,7 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, | |||
795 | } | 793 | } |
796 | 794 | ||
797 | /* instantiate and hash dentry */ | 795 | /* instantiate and hash dentry */ |
798 | ret = d_find_alias(inode); | 796 | ret = d_materialise_unique(dentry, inode); |
799 | if (!ret) { | ||
800 | d_set_d_op(dentry, &sysfs_dentry_ops); | ||
801 | dentry->d_fsdata = sysfs_get(sd); | ||
802 | d_add(dentry, inode); | ||
803 | } else { | ||
804 | d_move(ret, dentry); | ||
805 | iput(inode); | ||
806 | } | ||
807 | |||
808 | out_unlock: | 797 | out_unlock: |
809 | mutex_unlock(&sysfs_mutex); | 798 | mutex_unlock(&sysfs_mutex); |
810 | return ret; | 799 | return ret; |
diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c index 52c3bdb66a84..71eb7e253927 100644 --- a/fs/sysfs/mount.c +++ b/fs/sysfs/mount.c | |||
@@ -68,6 +68,7 @@ static int sysfs_fill_super(struct super_block *sb, void *data, int silent) | |||
68 | } | 68 | } |
69 | root->d_fsdata = &sysfs_root; | 69 | root->d_fsdata = &sysfs_root; |
70 | sb->s_root = root; | 70 | sb->s_root = root; |
71 | sb->s_d_op = &sysfs_dentry_ops; | ||
71 | return 0; | 72 | return 0; |
72 | } | 73 | } |
73 | 74 | ||
@@ -117,13 +118,12 @@ static struct dentry *sysfs_mount(struct file_system_type *fs_type, | |||
117 | for (type = KOBJ_NS_TYPE_NONE; type < KOBJ_NS_TYPES; type++) | 118 | for (type = KOBJ_NS_TYPE_NONE; type < KOBJ_NS_TYPES; type++) |
118 | info->ns[type] = kobj_ns_grab_current(type); | 119 | info->ns[type] = kobj_ns_grab_current(type); |
119 | 120 | ||
120 | sb = sget(fs_type, sysfs_test_super, sysfs_set_super, info); | 121 | sb = sget(fs_type, sysfs_test_super, sysfs_set_super, flags, info); |
121 | if (IS_ERR(sb) || sb->s_fs_info != info) | 122 | if (IS_ERR(sb) || sb->s_fs_info != info) |
122 | free_sysfs_super_info(info); | 123 | free_sysfs_super_info(info); |
123 | if (IS_ERR(sb)) | 124 | if (IS_ERR(sb)) |
124 | return ERR_CAST(sb); | 125 | return ERR_CAST(sb); |
125 | if (!sb->s_root) { | 126 | if (!sb->s_root) { |
126 | sb->s_flags = flags; | ||
127 | error = sysfs_fill_super(sb, data, flags & MS_SILENT ? 1 : 0); | 127 | error = sysfs_fill_super(sb, data, flags & MS_SILENT ? 1 : 0); |
128 | if (error) { | 128 | if (error) { |
129 | deactivate_locked_super(sb); | 129 | deactivate_locked_super(sb); |
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h index 661a9639570b..d73c0932bbd6 100644 --- a/fs/sysfs/sysfs.h +++ b/fs/sysfs/sysfs.h | |||
@@ -157,6 +157,7 @@ extern struct kmem_cache *sysfs_dir_cachep; | |||
157 | */ | 157 | */ |
158 | extern struct mutex sysfs_mutex; | 158 | extern struct mutex sysfs_mutex; |
159 | extern spinlock_t sysfs_assoc_lock; | 159 | extern spinlock_t sysfs_assoc_lock; |
160 | extern const struct dentry_operations sysfs_dentry_ops; | ||
160 | 161 | ||
161 | extern const struct file_operations sysfs_dir_operations; | 162 | extern const struct file_operations sysfs_dir_operations; |
162 | extern const struct inode_operations sysfs_dir_inode_operations; | 163 | extern const struct inode_operations sysfs_dir_inode_operations; |
diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c index 08d0b2568cd3..80e1e2b18df1 100644 --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c | |||
@@ -43,7 +43,6 @@ static int sysv_sync_fs(struct super_block *sb, int wait) | |||
43 | * then attach current time stamp. | 43 | * then attach current time stamp. |
44 | * But if the filesystem was marked clean, keep it clean. | 44 | * But if the filesystem was marked clean, keep it clean. |
45 | */ | 45 | */ |
46 | sb->s_dirt = 0; | ||
47 | old_time = fs32_to_cpu(sbi, *sbi->s_sb_time); | 46 | old_time = fs32_to_cpu(sbi, *sbi->s_sb_time); |
48 | if (sbi->s_type == FSTYPE_SYSV4) { | 47 | if (sbi->s_type == FSTYPE_SYSV4) { |
49 | if (*sbi->s_sb_state == cpu_to_fs32(sbi, 0x7c269d38 - old_time)) | 48 | if (*sbi->s_sb_state == cpu_to_fs32(sbi, 0x7c269d38 - old_time)) |
@@ -57,23 +56,12 @@ static int sysv_sync_fs(struct super_block *sb, int wait) | |||
57 | return 0; | 56 | return 0; |
58 | } | 57 | } |
59 | 58 | ||
60 | static void sysv_write_super(struct super_block *sb) | ||
61 | { | ||
62 | if (!(sb->s_flags & MS_RDONLY)) | ||
63 | sysv_sync_fs(sb, 1); | ||
64 | else | ||
65 | sb->s_dirt = 0; | ||
66 | } | ||
67 | |||
68 | static int sysv_remount(struct super_block *sb, int *flags, char *data) | 59 | static int sysv_remount(struct super_block *sb, int *flags, char *data) |
69 | { | 60 | { |
70 | struct sysv_sb_info *sbi = SYSV_SB(sb); | 61 | struct sysv_sb_info *sbi = SYSV_SB(sb); |
71 | lock_super(sb); | 62 | |
72 | if (sbi->s_forced_ro) | 63 | if (sbi->s_forced_ro) |
73 | *flags |= MS_RDONLY; | 64 | *flags |= MS_RDONLY; |
74 | if (*flags & MS_RDONLY) | ||
75 | sysv_write_super(sb); | ||
76 | unlock_super(sb); | ||
77 | return 0; | 65 | return 0; |
78 | } | 66 | } |
79 | 67 | ||
@@ -81,9 +69,6 @@ static void sysv_put_super(struct super_block *sb) | |||
81 | { | 69 | { |
82 | struct sysv_sb_info *sbi = SYSV_SB(sb); | 70 | struct sysv_sb_info *sbi = SYSV_SB(sb); |
83 | 71 | ||
84 | if (sb->s_dirt) | ||
85 | sysv_write_super(sb); | ||
86 | |||
87 | if (!(sb->s_flags & MS_RDONLY)) { | 72 | if (!(sb->s_flags & MS_RDONLY)) { |
88 | /* XXX ext2 also updates the state here */ | 73 | /* XXX ext2 also updates the state here */ |
89 | mark_buffer_dirty(sbi->s_bh1); | 74 | mark_buffer_dirty(sbi->s_bh1); |
@@ -357,7 +342,6 @@ const struct super_operations sysv_sops = { | |||
357 | .write_inode = sysv_write_inode, | 342 | .write_inode = sysv_write_inode, |
358 | .evict_inode = sysv_evict_inode, | 343 | .evict_inode = sysv_evict_inode, |
359 | .put_super = sysv_put_super, | 344 | .put_super = sysv_put_super, |
360 | .write_super = sysv_write_super, | ||
361 | .sync_fs = sysv_sync_fs, | 345 | .sync_fs = sysv_sync_fs, |
362 | .remount_fs = sysv_remount, | 346 | .remount_fs = sysv_remount, |
363 | .statfs = sysv_statfs, | 347 | .statfs = sysv_statfs, |
diff --git a/fs/sysv/namei.c b/fs/sysv/namei.c index d7466e293614..1c0d5f264767 100644 --- a/fs/sysv/namei.c +++ b/fs/sysv/namei.c | |||
@@ -43,7 +43,7 @@ const struct dentry_operations sysv_dentry_operations = { | |||
43 | .d_hash = sysv_hash, | 43 | .d_hash = sysv_hash, |
44 | }; | 44 | }; |
45 | 45 | ||
46 | static struct dentry *sysv_lookup(struct inode * dir, struct dentry * dentry, struct nameidata *nd) | 46 | static struct dentry *sysv_lookup(struct inode * dir, struct dentry * dentry, unsigned int flags) |
47 | { | 47 | { |
48 | struct inode * inode = NULL; | 48 | struct inode * inode = NULL; |
49 | ino_t ino; | 49 | ino_t ino; |
@@ -80,7 +80,7 @@ static int sysv_mknod(struct inode * dir, struct dentry * dentry, umode_t mode, | |||
80 | return err; | 80 | return err; |
81 | } | 81 | } |
82 | 82 | ||
83 | static int sysv_create(struct inode * dir, struct dentry * dentry, umode_t mode, struct nameidata *nd) | 83 | static int sysv_create(struct inode * dir, struct dentry * dentry, umode_t mode, bool excl) |
84 | { | 84 | { |
85 | return sysv_mknod(dir, dentry, mode, 0); | 85 | return sysv_mknod(dir, dentry, mode, 0); |
86 | } | 86 | } |
diff --git a/fs/sysv/sysv.h b/fs/sysv/sysv.h index 11b07672f6c5..0bc35fdc58e2 100644 --- a/fs/sysv/sysv.h +++ b/fs/sysv/sysv.h | |||
@@ -117,7 +117,6 @@ static inline void dirty_sb(struct super_block *sb) | |||
117 | mark_buffer_dirty(sbi->s_bh1); | 117 | mark_buffer_dirty(sbi->s_bh1); |
118 | if (sbi->s_bh1 != sbi->s_bh2) | 118 | if (sbi->s_bh1 != sbi->s_bh2) |
119 | mark_buffer_dirty(sbi->s_bh2); | 119 | mark_buffer_dirty(sbi->s_bh2); |
120 | sb->s_dirt = 1; | ||
121 | } | 120 | } |
122 | 121 | ||
123 | 122 | ||
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index 685a83756b2b..bb3167257aab 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c | |||
@@ -2802,6 +2802,8 @@ static ssize_t dfs_file_read(struct file *file, char __user *u, size_t count, | |||
2802 | val = d->chk_fs; | 2802 | val = d->chk_fs; |
2803 | else if (dent == d->dfs_tst_rcvry) | 2803 | else if (dent == d->dfs_tst_rcvry) |
2804 | val = d->tst_rcvry; | 2804 | val = d->tst_rcvry; |
2805 | else if (dent == d->dfs_ro_error) | ||
2806 | val = c->ro_error; | ||
2805 | else | 2807 | else |
2806 | return -EINVAL; | 2808 | return -EINVAL; |
2807 | 2809 | ||
@@ -2885,6 +2887,8 @@ static ssize_t dfs_file_write(struct file *file, const char __user *u, | |||
2885 | d->chk_fs = val; | 2887 | d->chk_fs = val; |
2886 | else if (dent == d->dfs_tst_rcvry) | 2888 | else if (dent == d->dfs_tst_rcvry) |
2887 | d->tst_rcvry = val; | 2889 | d->tst_rcvry = val; |
2890 | else if (dent == d->dfs_ro_error) | ||
2891 | c->ro_error = !!val; | ||
2888 | else | 2892 | else |
2889 | return -EINVAL; | 2893 | return -EINVAL; |
2890 | 2894 | ||
@@ -2918,6 +2922,9 @@ int dbg_debugfs_init_fs(struct ubifs_info *c) | |||
2918 | struct dentry *dent; | 2922 | struct dentry *dent; |
2919 | struct ubifs_debug_info *d = c->dbg; | 2923 | struct ubifs_debug_info *d = c->dbg; |
2920 | 2924 | ||
2925 | if (!IS_ENABLED(CONFIG_DEBUG_FS)) | ||
2926 | return 0; | ||
2927 | |||
2921 | n = snprintf(d->dfs_dir_name, UBIFS_DFS_DIR_LEN + 1, UBIFS_DFS_DIR_NAME, | 2928 | n = snprintf(d->dfs_dir_name, UBIFS_DFS_DIR_LEN + 1, UBIFS_DFS_DIR_NAME, |
2922 | c->vi.ubi_num, c->vi.vol_id); | 2929 | c->vi.ubi_num, c->vi.vol_id); |
2923 | if (n == UBIFS_DFS_DIR_LEN) { | 2930 | if (n == UBIFS_DFS_DIR_LEN) { |
@@ -2993,6 +3000,13 @@ int dbg_debugfs_init_fs(struct ubifs_info *c) | |||
2993 | goto out_remove; | 3000 | goto out_remove; |
2994 | d->dfs_tst_rcvry = dent; | 3001 | d->dfs_tst_rcvry = dent; |
2995 | 3002 | ||
3003 | fname = "ro_error"; | ||
3004 | dent = debugfs_create_file(fname, S_IRUSR | S_IWUSR, d->dfs_dir, c, | ||
3005 | &dfs_fops); | ||
3006 | if (IS_ERR_OR_NULL(dent)) | ||
3007 | goto out_remove; | ||
3008 | d->dfs_ro_error = dent; | ||
3009 | |||
2996 | return 0; | 3010 | return 0; |
2997 | 3011 | ||
2998 | out_remove: | 3012 | out_remove: |
@@ -3010,7 +3024,8 @@ out: | |||
3010 | */ | 3024 | */ |
3011 | void dbg_debugfs_exit_fs(struct ubifs_info *c) | 3025 | void dbg_debugfs_exit_fs(struct ubifs_info *c) |
3012 | { | 3026 | { |
3013 | debugfs_remove_recursive(c->dbg->dfs_dir); | 3027 | if (IS_ENABLED(CONFIG_DEBUG_FS)) |
3028 | debugfs_remove_recursive(c->dbg->dfs_dir); | ||
3014 | } | 3029 | } |
3015 | 3030 | ||
3016 | struct ubifs_global_debug_info ubifs_dbg; | 3031 | struct ubifs_global_debug_info ubifs_dbg; |
@@ -3095,6 +3110,9 @@ int dbg_debugfs_init(void) | |||
3095 | const char *fname; | 3110 | const char *fname; |
3096 | struct dentry *dent; | 3111 | struct dentry *dent; |
3097 | 3112 | ||
3113 | if (!IS_ENABLED(CONFIG_DEBUG_FS)) | ||
3114 | return 0; | ||
3115 | |||
3098 | fname = "ubifs"; | 3116 | fname = "ubifs"; |
3099 | dent = debugfs_create_dir(fname, NULL); | 3117 | dent = debugfs_create_dir(fname, NULL); |
3100 | if (IS_ERR_OR_NULL(dent)) | 3118 | if (IS_ERR_OR_NULL(dent)) |
@@ -3159,7 +3177,8 @@ out: | |||
3159 | */ | 3177 | */ |
3160 | void dbg_debugfs_exit(void) | 3178 | void dbg_debugfs_exit(void) |
3161 | { | 3179 | { |
3162 | debugfs_remove_recursive(dfs_rootdir); | 3180 | if (IS_ENABLED(CONFIG_DEBUG_FS)) |
3181 | debugfs_remove_recursive(dfs_rootdir); | ||
3163 | } | 3182 | } |
3164 | 3183 | ||
3165 | /** | 3184 | /** |
diff --git a/fs/ubifs/debug.h b/fs/ubifs/debug.h index 486a8e024fb6..8b8cc4e945f4 100644 --- a/fs/ubifs/debug.h +++ b/fs/ubifs/debug.h | |||
@@ -79,6 +79,10 @@ typedef int (*dbg_znode_callback)(struct ubifs_info *c, | |||
79 | * @dfs_chk_lprops: debugfs knob to enable UBIFS LEP properties extra checks | 79 | * @dfs_chk_lprops: debugfs knob to enable UBIFS LEP properties extra checks |
80 | * @dfs_chk_fs: debugfs knob to enable UBIFS contents extra checks | 80 | * @dfs_chk_fs: debugfs knob to enable UBIFS contents extra checks |
81 | * @dfs_tst_rcvry: debugfs knob to enable UBIFS recovery testing | 81 | * @dfs_tst_rcvry: debugfs knob to enable UBIFS recovery testing |
82 | * @dfs_ro_error: debugfs knob to switch UBIFS to R/O mode (different to | ||
83 | * re-mounting to R/O mode because it does not flush any buffers | ||
84 | * and UBIFS just starts returning -EROFS on all write | ||
85 | * operations) | ||
82 | */ | 86 | */ |
83 | struct ubifs_debug_info { | 87 | struct ubifs_debug_info { |
84 | struct ubifs_zbranch old_zroot; | 88 | struct ubifs_zbranch old_zroot; |
@@ -122,6 +126,7 @@ struct ubifs_debug_info { | |||
122 | struct dentry *dfs_chk_lprops; | 126 | struct dentry *dfs_chk_lprops; |
123 | struct dentry *dfs_chk_fs; | 127 | struct dentry *dfs_chk_fs; |
124 | struct dentry *dfs_tst_rcvry; | 128 | struct dentry *dfs_tst_rcvry; |
129 | struct dentry *dfs_ro_error; | ||
125 | }; | 130 | }; |
126 | 131 | ||
127 | /** | 132 | /** |
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index a6d42efc76d2..c95681cf1b71 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c | |||
@@ -184,7 +184,7 @@ static int dbg_check_name(const struct ubifs_info *c, | |||
184 | } | 184 | } |
185 | 185 | ||
186 | static struct dentry *ubifs_lookup(struct inode *dir, struct dentry *dentry, | 186 | static struct dentry *ubifs_lookup(struct inode *dir, struct dentry *dentry, |
187 | struct nameidata *nd) | 187 | unsigned int flags) |
188 | { | 188 | { |
189 | int err; | 189 | int err; |
190 | union ubifs_key key; | 190 | union ubifs_key key; |
@@ -246,7 +246,7 @@ out: | |||
246 | } | 246 | } |
247 | 247 | ||
248 | static int ubifs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 248 | static int ubifs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
249 | struct nameidata *nd) | 249 | bool excl) |
250 | { | 250 | { |
251 | struct inode *inode; | 251 | struct inode *inode; |
252 | struct ubifs_info *c = dir->i_sb->s_fs_info; | 252 | struct ubifs_info *c = dir->i_sb->s_fs_info; |
@@ -969,7 +969,7 @@ static int ubifs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
969 | struct ubifs_budget_req ino_req = { .dirtied_ino = 1, | 969 | struct ubifs_budget_req ino_req = { .dirtied_ino = 1, |
970 | .dirtied_ino_d = ALIGN(old_inode_ui->data_len, 8) }; | 970 | .dirtied_ino_d = ALIGN(old_inode_ui->data_len, 8) }; |
971 | struct timespec time; | 971 | struct timespec time; |
972 | unsigned int saved_nlink; | 972 | unsigned int uninitialized_var(saved_nlink); |
973 | 973 | ||
974 | /* | 974 | /* |
975 | * Budget request settings: deletion direntry, new direntry, removing | 975 | * Budget request settings: deletion direntry, new direntry, removing |
diff --git a/fs/ubifs/find.c b/fs/ubifs/find.c index 2559d174e004..28ec13af28d9 100644 --- a/fs/ubifs/find.c +++ b/fs/ubifs/find.c | |||
@@ -939,8 +939,8 @@ static int find_dirtiest_idx_leb(struct ubifs_info *c) | |||
939 | } | 939 | } |
940 | dbg_find("LEB %d, dirty %d and free %d flags %#x", lp->lnum, lp->dirty, | 940 | dbg_find("LEB %d, dirty %d and free %d flags %#x", lp->lnum, lp->dirty, |
941 | lp->free, lp->flags); | 941 | lp->free, lp->flags); |
942 | ubifs_assert(lp->flags | LPROPS_TAKEN); | 942 | ubifs_assert(lp->flags & LPROPS_TAKEN); |
943 | ubifs_assert(lp->flags | LPROPS_INDEX); | 943 | ubifs_assert(lp->flags & LPROPS_INDEX); |
944 | return lnum; | 944 | return lnum; |
945 | } | 945 | } |
946 | 946 | ||
diff --git a/fs/ubifs/orphan.c b/fs/ubifs/orphan.c index b02734db187c..cebf17ea0458 100644 --- a/fs/ubifs/orphan.c +++ b/fs/ubifs/orphan.c | |||
@@ -176,7 +176,7 @@ int ubifs_orphan_start_commit(struct ubifs_info *c) | |||
176 | *last = orphan; | 176 | *last = orphan; |
177 | last = &orphan->cnext; | 177 | last = &orphan->cnext; |
178 | } | 178 | } |
179 | *last = orphan->cnext; | 179 | *last = NULL; |
180 | c->cmt_orphans = c->new_orphans; | 180 | c->cmt_orphans = c->new_orphans; |
181 | c->new_orphans = 0; | 181 | c->new_orphans = 0; |
182 | dbg_cmt("%d orphans to commit", c->cmt_orphans); | 182 | dbg_cmt("%d orphans to commit", c->cmt_orphans); |
@@ -382,7 +382,7 @@ static int consolidate(struct ubifs_info *c) | |||
382 | last = &orphan->cnext; | 382 | last = &orphan->cnext; |
383 | cnt += 1; | 383 | cnt += 1; |
384 | } | 384 | } |
385 | *last = orphan->cnext; | 385 | *last = NULL; |
386 | ubifs_assert(cnt == c->tot_orphans - c->new_orphans); | 386 | ubifs_assert(cnt == c->tot_orphans - c->new_orphans); |
387 | c->cmt_orphans = cnt; | 387 | c->cmt_orphans = cnt; |
388 | c->ohead_lnum = c->orph_first; | 388 | c->ohead_lnum = c->orph_first; |
diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c index 3a2da7e476e5..eba46d4a7619 100644 --- a/fs/ubifs/replay.c +++ b/fs/ubifs/replay.c | |||
@@ -1007,7 +1007,7 @@ out: | |||
1007 | */ | 1007 | */ |
1008 | int ubifs_replay_journal(struct ubifs_info *c) | 1008 | int ubifs_replay_journal(struct ubifs_info *c) |
1009 | { | 1009 | { |
1010 | int err, i, lnum, offs, free; | 1010 | int err, lnum, free; |
1011 | 1011 | ||
1012 | BUILD_BUG_ON(UBIFS_TRUN_KEY > 5); | 1012 | BUILD_BUG_ON(UBIFS_TRUN_KEY > 5); |
1013 | 1013 | ||
@@ -1025,25 +1025,17 @@ int ubifs_replay_journal(struct ubifs_info *c) | |||
1025 | dbg_mnt("start replaying the journal"); | 1025 | dbg_mnt("start replaying the journal"); |
1026 | c->replaying = 1; | 1026 | c->replaying = 1; |
1027 | lnum = c->ltail_lnum = c->lhead_lnum; | 1027 | lnum = c->ltail_lnum = c->lhead_lnum; |
1028 | offs = c->lhead_offs; | ||
1029 | 1028 | ||
1030 | for (i = 0; i < c->log_lebs; i++, lnum++) { | 1029 | lnum = UBIFS_LOG_LNUM; |
1031 | if (lnum >= UBIFS_LOG_LNUM + c->log_lebs) { | 1030 | do { |
1032 | /* | 1031 | err = replay_log_leb(c, lnum, 0, c->sbuf); |
1033 | * The log is logically circular, we reached the last | ||
1034 | * LEB, switch to the first one. | ||
1035 | */ | ||
1036 | lnum = UBIFS_LOG_LNUM; | ||
1037 | offs = 0; | ||
1038 | } | ||
1039 | err = replay_log_leb(c, lnum, offs, c->sbuf); | ||
1040 | if (err == 1) | 1032 | if (err == 1) |
1041 | /* We hit the end of the log */ | 1033 | /* We hit the end of the log */ |
1042 | break; | 1034 | break; |
1043 | if (err) | 1035 | if (err) |
1044 | goto out; | 1036 | goto out; |
1045 | offs = 0; | 1037 | lnum = ubifs_next_log_lnum(c, lnum); |
1046 | } | 1038 | } while (lnum != UBIFS_LOG_LNUM); |
1047 | 1039 | ||
1048 | err = replay_buds(c); | 1040 | err = replay_buds(c); |
1049 | if (err) | 1041 | if (err) |
diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c index ef3d1ba6d992..15e2fc5aa60b 100644 --- a/fs/ubifs/sb.c +++ b/fs/ubifs/sb.c | |||
@@ -718,8 +718,12 @@ static int fixup_free_space(struct ubifs_info *c) | |||
718 | lnum = ubifs_next_log_lnum(c, lnum); | 718 | lnum = ubifs_next_log_lnum(c, lnum); |
719 | } | 719 | } |
720 | 720 | ||
721 | /* Fixup the current log head */ | 721 | /* |
722 | err = fixup_leb(c, c->lhead_lnum, c->lhead_offs); | 722 | * Fixup the log head which contains the only a CS node at the |
723 | * beginning. | ||
724 | */ | ||
725 | err = fixup_leb(c, c->lhead_lnum, | ||
726 | ALIGN(UBIFS_CS_NODE_SZ, c->min_io_size)); | ||
723 | if (err) | 727 | if (err) |
724 | goto out; | 728 | goto out; |
725 | 729 | ||
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 5862dd9d2784..1c766c39c038 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c | |||
@@ -2136,7 +2136,7 @@ static struct dentry *ubifs_mount(struct file_system_type *fs_type, int flags, | |||
2136 | 2136 | ||
2137 | dbg_gen("opened ubi%d_%d", c->vi.ubi_num, c->vi.vol_id); | 2137 | dbg_gen("opened ubi%d_%d", c->vi.ubi_num, c->vi.vol_id); |
2138 | 2138 | ||
2139 | sb = sget(fs_type, sb_test, sb_set, c); | 2139 | sb = sget(fs_type, sb_test, sb_set, flags, c); |
2140 | if (IS_ERR(sb)) { | 2140 | if (IS_ERR(sb)) { |
2141 | err = PTR_ERR(sb); | 2141 | err = PTR_ERR(sb); |
2142 | kfree(c); | 2142 | kfree(c); |
@@ -2153,7 +2153,6 @@ static struct dentry *ubifs_mount(struct file_system_type *fs_type, int flags, | |||
2153 | goto out_deact; | 2153 | goto out_deact; |
2154 | } | 2154 | } |
2155 | } else { | 2155 | } else { |
2156 | sb->s_flags = flags; | ||
2157 | err = ubifs_fill_super(sb, data, flags & MS_SILENT ? 1 : 0); | 2156 | err = ubifs_fill_super(sb, data, flags & MS_SILENT ? 1 : 0); |
2158 | if (err) | 2157 | if (err) |
2159 | goto out_deact; | 2158 | goto out_deact; |
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 873e1bab9c4c..fafaad795cd6 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c | |||
@@ -1247,7 +1247,6 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh) | |||
1247 | { | 1247 | { |
1248 | struct fileEntry *fe; | 1248 | struct fileEntry *fe; |
1249 | struct extendedFileEntry *efe; | 1249 | struct extendedFileEntry *efe; |
1250 | int offset; | ||
1251 | struct udf_sb_info *sbi = UDF_SB(inode->i_sb); | 1250 | struct udf_sb_info *sbi = UDF_SB(inode->i_sb); |
1252 | struct udf_inode_info *iinfo = UDF_I(inode); | 1251 | struct udf_inode_info *iinfo = UDF_I(inode); |
1253 | unsigned int link_count; | 1252 | unsigned int link_count; |
@@ -1359,7 +1358,6 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh) | |||
1359 | iinfo->i_lenEAttr = le32_to_cpu(fe->lengthExtendedAttr); | 1358 | iinfo->i_lenEAttr = le32_to_cpu(fe->lengthExtendedAttr); |
1360 | iinfo->i_lenAlloc = le32_to_cpu(fe->lengthAllocDescs); | 1359 | iinfo->i_lenAlloc = le32_to_cpu(fe->lengthAllocDescs); |
1361 | iinfo->i_checkpoint = le32_to_cpu(fe->checkpoint); | 1360 | iinfo->i_checkpoint = le32_to_cpu(fe->checkpoint); |
1362 | offset = sizeof(struct fileEntry) + iinfo->i_lenEAttr; | ||
1363 | } else { | 1361 | } else { |
1364 | inode->i_blocks = le64_to_cpu(efe->logicalBlocksRecorded) << | 1362 | inode->i_blocks = le64_to_cpu(efe->logicalBlocksRecorded) << |
1365 | (inode->i_sb->s_blocksize_bits - 9); | 1363 | (inode->i_sb->s_blocksize_bits - 9); |
@@ -1381,8 +1379,6 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh) | |||
1381 | iinfo->i_lenEAttr = le32_to_cpu(efe->lengthExtendedAttr); | 1379 | iinfo->i_lenEAttr = le32_to_cpu(efe->lengthExtendedAttr); |
1382 | iinfo->i_lenAlloc = le32_to_cpu(efe->lengthAllocDescs); | 1380 | iinfo->i_lenAlloc = le32_to_cpu(efe->lengthAllocDescs); |
1383 | iinfo->i_checkpoint = le32_to_cpu(efe->checkpoint); | 1381 | iinfo->i_checkpoint = le32_to_cpu(efe->checkpoint); |
1384 | offset = sizeof(struct extendedFileEntry) + | ||
1385 | iinfo->i_lenEAttr; | ||
1386 | } | 1382 | } |
1387 | 1383 | ||
1388 | switch (fe->icbTag.fileType) { | 1384 | switch (fe->icbTag.fileType) { |
diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 18024178ac4c..95fee278ab9d 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c | |||
@@ -251,7 +251,7 @@ out_ok: | |||
251 | } | 251 | } |
252 | 252 | ||
253 | static struct dentry *udf_lookup(struct inode *dir, struct dentry *dentry, | 253 | static struct dentry *udf_lookup(struct inode *dir, struct dentry *dentry, |
254 | struct nameidata *nd) | 254 | unsigned int flags) |
255 | { | 255 | { |
256 | struct inode *inode = NULL; | 256 | struct inode *inode = NULL; |
257 | struct fileIdentDesc cfi; | 257 | struct fileIdentDesc cfi; |
@@ -551,7 +551,7 @@ static int udf_delete_entry(struct inode *inode, struct fileIdentDesc *fi, | |||
551 | } | 551 | } |
552 | 552 | ||
553 | static int udf_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 553 | static int udf_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
554 | struct nameidata *nd) | 554 | bool excl) |
555 | { | 555 | { |
556 | struct udf_fileident_bh fibh; | 556 | struct udf_fileident_bh fibh; |
557 | struct inode *inode; | 557 | struct inode *inode; |
@@ -1279,6 +1279,7 @@ static int udf_encode_fh(struct inode *inode, __u32 *fh, int *lenp, | |||
1279 | *lenp = 3; | 1279 | *lenp = 3; |
1280 | fid->udf.block = location.logicalBlockNum; | 1280 | fid->udf.block = location.logicalBlockNum; |
1281 | fid->udf.partref = location.partitionReferenceNum; | 1281 | fid->udf.partref = location.partitionReferenceNum; |
1282 | fid->udf.parent_partref = 0; | ||
1282 | fid->udf.generation = inode->i_generation; | 1283 | fid->udf.generation = inode->i_generation; |
1283 | 1284 | ||
1284 | if (parent) { | 1285 | if (parent) { |
diff --git a/fs/udf/super.c b/fs/udf/super.c index ac8a348dcb69..dcbf98722afc 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c | |||
@@ -56,6 +56,7 @@ | |||
56 | #include <linux/seq_file.h> | 56 | #include <linux/seq_file.h> |
57 | #include <linux/bitmap.h> | 57 | #include <linux/bitmap.h> |
58 | #include <linux/crc-itu-t.h> | 58 | #include <linux/crc-itu-t.h> |
59 | #include <linux/log2.h> | ||
59 | #include <asm/byteorder.h> | 60 | #include <asm/byteorder.h> |
60 | 61 | ||
61 | #include "udf_sb.h" | 62 | #include "udf_sb.h" |
@@ -251,6 +252,63 @@ static int udf_sb_alloc_partition_maps(struct super_block *sb, u32 count) | |||
251 | return 0; | 252 | return 0; |
252 | } | 253 | } |
253 | 254 | ||
255 | static void udf_sb_free_bitmap(struct udf_bitmap *bitmap) | ||
256 | { | ||
257 | int i; | ||
258 | int nr_groups = bitmap->s_nr_groups; | ||
259 | int size = sizeof(struct udf_bitmap) + (sizeof(struct buffer_head *) * | ||
260 | nr_groups); | ||
261 | |||
262 | for (i = 0; i < nr_groups; i++) | ||
263 | if (bitmap->s_block_bitmap[i]) | ||
264 | brelse(bitmap->s_block_bitmap[i]); | ||
265 | |||
266 | if (size <= PAGE_SIZE) | ||
267 | kfree(bitmap); | ||
268 | else | ||
269 | vfree(bitmap); | ||
270 | } | ||
271 | |||
272 | static void udf_free_partition(struct udf_part_map *map) | ||
273 | { | ||
274 | int i; | ||
275 | struct udf_meta_data *mdata; | ||
276 | |||
277 | if (map->s_partition_flags & UDF_PART_FLAG_UNALLOC_TABLE) | ||
278 | iput(map->s_uspace.s_table); | ||
279 | if (map->s_partition_flags & UDF_PART_FLAG_FREED_TABLE) | ||
280 | iput(map->s_fspace.s_table); | ||
281 | if (map->s_partition_flags & UDF_PART_FLAG_UNALLOC_BITMAP) | ||
282 | udf_sb_free_bitmap(map->s_uspace.s_bitmap); | ||
283 | if (map->s_partition_flags & UDF_PART_FLAG_FREED_BITMAP) | ||
284 | udf_sb_free_bitmap(map->s_fspace.s_bitmap); | ||
285 | if (map->s_partition_type == UDF_SPARABLE_MAP15) | ||
286 | for (i = 0; i < 4; i++) | ||
287 | brelse(map->s_type_specific.s_sparing.s_spar_map[i]); | ||
288 | else if (map->s_partition_type == UDF_METADATA_MAP25) { | ||
289 | mdata = &map->s_type_specific.s_metadata; | ||
290 | iput(mdata->s_metadata_fe); | ||
291 | mdata->s_metadata_fe = NULL; | ||
292 | |||
293 | iput(mdata->s_mirror_fe); | ||
294 | mdata->s_mirror_fe = NULL; | ||
295 | |||
296 | iput(mdata->s_bitmap_fe); | ||
297 | mdata->s_bitmap_fe = NULL; | ||
298 | } | ||
299 | } | ||
300 | |||
301 | static void udf_sb_free_partitions(struct super_block *sb) | ||
302 | { | ||
303 | struct udf_sb_info *sbi = UDF_SB(sb); | ||
304 | int i; | ||
305 | |||
306 | for (i = 0; i < sbi->s_partitions; i++) | ||
307 | udf_free_partition(&sbi->s_partmaps[i]); | ||
308 | kfree(sbi->s_partmaps); | ||
309 | sbi->s_partmaps = NULL; | ||
310 | } | ||
311 | |||
254 | static int udf_show_options(struct seq_file *seq, struct dentry *root) | 312 | static int udf_show_options(struct seq_file *seq, struct dentry *root) |
255 | { | 313 | { |
256 | struct super_block *sb = root->d_sb; | 314 | struct super_block *sb = root->d_sb; |
@@ -1215,16 +1273,65 @@ out_bh: | |||
1215 | return ret; | 1273 | return ret; |
1216 | } | 1274 | } |
1217 | 1275 | ||
1276 | static int udf_load_sparable_map(struct super_block *sb, | ||
1277 | struct udf_part_map *map, | ||
1278 | struct sparablePartitionMap *spm) | ||
1279 | { | ||
1280 | uint32_t loc; | ||
1281 | uint16_t ident; | ||
1282 | struct sparingTable *st; | ||
1283 | struct udf_sparing_data *sdata = &map->s_type_specific.s_sparing; | ||
1284 | int i; | ||
1285 | struct buffer_head *bh; | ||
1286 | |||
1287 | map->s_partition_type = UDF_SPARABLE_MAP15; | ||
1288 | sdata->s_packet_len = le16_to_cpu(spm->packetLength); | ||
1289 | if (!is_power_of_2(sdata->s_packet_len)) { | ||
1290 | udf_err(sb, "error loading logical volume descriptor: " | ||
1291 | "Invalid packet length %u\n", | ||
1292 | (unsigned)sdata->s_packet_len); | ||
1293 | return -EIO; | ||
1294 | } | ||
1295 | if (spm->numSparingTables > 4) { | ||
1296 | udf_err(sb, "error loading logical volume descriptor: " | ||
1297 | "Too many sparing tables (%d)\n", | ||
1298 | (int)spm->numSparingTables); | ||
1299 | return -EIO; | ||
1300 | } | ||
1301 | |||
1302 | for (i = 0; i < spm->numSparingTables; i++) { | ||
1303 | loc = le32_to_cpu(spm->locSparingTable[i]); | ||
1304 | bh = udf_read_tagged(sb, loc, loc, &ident); | ||
1305 | if (!bh) | ||
1306 | continue; | ||
1307 | |||
1308 | st = (struct sparingTable *)bh->b_data; | ||
1309 | if (ident != 0 || | ||
1310 | strncmp(st->sparingIdent.ident, UDF_ID_SPARING, | ||
1311 | strlen(UDF_ID_SPARING)) || | ||
1312 | sizeof(*st) + le16_to_cpu(st->reallocationTableLen) > | ||
1313 | sb->s_blocksize) { | ||
1314 | brelse(bh); | ||
1315 | continue; | ||
1316 | } | ||
1317 | |||
1318 | sdata->s_spar_map[i] = bh; | ||
1319 | } | ||
1320 | map->s_partition_func = udf_get_pblock_spar15; | ||
1321 | return 0; | ||
1322 | } | ||
1323 | |||
1218 | static int udf_load_logicalvol(struct super_block *sb, sector_t block, | 1324 | static int udf_load_logicalvol(struct super_block *sb, sector_t block, |
1219 | struct kernel_lb_addr *fileset) | 1325 | struct kernel_lb_addr *fileset) |
1220 | { | 1326 | { |
1221 | struct logicalVolDesc *lvd; | 1327 | struct logicalVolDesc *lvd; |
1222 | int i, j, offset; | 1328 | int i, offset; |
1223 | uint8_t type; | 1329 | uint8_t type; |
1224 | struct udf_sb_info *sbi = UDF_SB(sb); | 1330 | struct udf_sb_info *sbi = UDF_SB(sb); |
1225 | struct genericPartitionMap *gpm; | 1331 | struct genericPartitionMap *gpm; |
1226 | uint16_t ident; | 1332 | uint16_t ident; |
1227 | struct buffer_head *bh; | 1333 | struct buffer_head *bh; |
1334 | unsigned int table_len; | ||
1228 | int ret = 0; | 1335 | int ret = 0; |
1229 | 1336 | ||
1230 | bh = udf_read_tagged(sb, block, block, &ident); | 1337 | bh = udf_read_tagged(sb, block, block, &ident); |
@@ -1232,15 +1339,20 @@ static int udf_load_logicalvol(struct super_block *sb, sector_t block, | |||
1232 | return 1; | 1339 | return 1; |
1233 | BUG_ON(ident != TAG_IDENT_LVD); | 1340 | BUG_ON(ident != TAG_IDENT_LVD); |
1234 | lvd = (struct logicalVolDesc *)bh->b_data; | 1341 | lvd = (struct logicalVolDesc *)bh->b_data; |
1235 | 1342 | table_len = le32_to_cpu(lvd->mapTableLength); | |
1236 | i = udf_sb_alloc_partition_maps(sb, le32_to_cpu(lvd->numPartitionMaps)); | 1343 | if (table_len > sb->s_blocksize - sizeof(*lvd)) { |
1237 | if (i != 0) { | 1344 | udf_err(sb, "error loading logical volume descriptor: " |
1238 | ret = i; | 1345 | "Partition table too long (%u > %lu)\n", table_len, |
1346 | sb->s_blocksize - sizeof(*lvd)); | ||
1239 | goto out_bh; | 1347 | goto out_bh; |
1240 | } | 1348 | } |
1241 | 1349 | ||
1350 | ret = udf_sb_alloc_partition_maps(sb, le32_to_cpu(lvd->numPartitionMaps)); | ||
1351 | if (ret) | ||
1352 | goto out_bh; | ||
1353 | |||
1242 | for (i = 0, offset = 0; | 1354 | for (i = 0, offset = 0; |
1243 | i < sbi->s_partitions && offset < le32_to_cpu(lvd->mapTableLength); | 1355 | i < sbi->s_partitions && offset < table_len; |
1244 | i++, offset += gpm->partitionMapLength) { | 1356 | i++, offset += gpm->partitionMapLength) { |
1245 | struct udf_part_map *map = &sbi->s_partmaps[i]; | 1357 | struct udf_part_map *map = &sbi->s_partmaps[i]; |
1246 | gpm = (struct genericPartitionMap *) | 1358 | gpm = (struct genericPartitionMap *) |
@@ -1275,38 +1387,9 @@ static int udf_load_logicalvol(struct super_block *sb, sector_t block, | |||
1275 | } else if (!strncmp(upm2->partIdent.ident, | 1387 | } else if (!strncmp(upm2->partIdent.ident, |
1276 | UDF_ID_SPARABLE, | 1388 | UDF_ID_SPARABLE, |
1277 | strlen(UDF_ID_SPARABLE))) { | 1389 | strlen(UDF_ID_SPARABLE))) { |
1278 | uint32_t loc; | 1390 | if (udf_load_sparable_map(sb, map, |
1279 | struct sparingTable *st; | 1391 | (struct sparablePartitionMap *)gpm) < 0) |
1280 | struct sparablePartitionMap *spm = | 1392 | goto out_bh; |
1281 | (struct sparablePartitionMap *)gpm; | ||
1282 | |||
1283 | map->s_partition_type = UDF_SPARABLE_MAP15; | ||
1284 | map->s_type_specific.s_sparing.s_packet_len = | ||
1285 | le16_to_cpu(spm->packetLength); | ||
1286 | for (j = 0; j < spm->numSparingTables; j++) { | ||
1287 | struct buffer_head *bh2; | ||
1288 | |||
1289 | loc = le32_to_cpu( | ||
1290 | spm->locSparingTable[j]); | ||
1291 | bh2 = udf_read_tagged(sb, loc, loc, | ||
1292 | &ident); | ||
1293 | map->s_type_specific.s_sparing. | ||
1294 | s_spar_map[j] = bh2; | ||
1295 | |||
1296 | if (bh2 == NULL) | ||
1297 | continue; | ||
1298 | |||
1299 | st = (struct sparingTable *)bh2->b_data; | ||
1300 | if (ident != 0 || strncmp( | ||
1301 | st->sparingIdent.ident, | ||
1302 | UDF_ID_SPARING, | ||
1303 | strlen(UDF_ID_SPARING))) { | ||
1304 | brelse(bh2); | ||
1305 | map->s_type_specific.s_sparing. | ||
1306 | s_spar_map[j] = NULL; | ||
1307 | } | ||
1308 | } | ||
1309 | map->s_partition_func = udf_get_pblock_spar15; | ||
1310 | } else if (!strncmp(upm2->partIdent.ident, | 1393 | } else if (!strncmp(upm2->partIdent.ident, |
1311 | UDF_ID_METADATA, | 1394 | UDF_ID_METADATA, |
1312 | strlen(UDF_ID_METADATA))) { | 1395 | strlen(UDF_ID_METADATA))) { |
@@ -1570,7 +1653,11 @@ static int udf_load_sequence(struct super_block *sb, struct buffer_head *bh, | |||
1570 | /* responsible for finding the PartitionDesc(s) */ | 1653 | /* responsible for finding the PartitionDesc(s) */ |
1571 | if (!udf_process_sequence(sb, main_s, main_e, fileset)) | 1654 | if (!udf_process_sequence(sb, main_s, main_e, fileset)) |
1572 | return 1; | 1655 | return 1; |
1573 | return !udf_process_sequence(sb, reserve_s, reserve_e, fileset); | 1656 | udf_sb_free_partitions(sb); |
1657 | if (!udf_process_sequence(sb, reserve_s, reserve_e, fileset)) | ||
1658 | return 1; | ||
1659 | udf_sb_free_partitions(sb); | ||
1660 | return 0; | ||
1574 | } | 1661 | } |
1575 | 1662 | ||
1576 | /* | 1663 | /* |
@@ -1835,55 +1922,8 @@ u64 lvid_get_unique_id(struct super_block *sb) | |||
1835 | return ret; | 1922 | return ret; |
1836 | } | 1923 | } |
1837 | 1924 | ||
1838 | static void udf_sb_free_bitmap(struct udf_bitmap *bitmap) | ||
1839 | { | ||
1840 | int i; | ||
1841 | int nr_groups = bitmap->s_nr_groups; | ||
1842 | int size = sizeof(struct udf_bitmap) + (sizeof(struct buffer_head *) * | ||
1843 | nr_groups); | ||
1844 | |||
1845 | for (i = 0; i < nr_groups; i++) | ||
1846 | if (bitmap->s_block_bitmap[i]) | ||
1847 | brelse(bitmap->s_block_bitmap[i]); | ||
1848 | |||
1849 | if (size <= PAGE_SIZE) | ||
1850 | kfree(bitmap); | ||
1851 | else | ||
1852 | vfree(bitmap); | ||
1853 | } | ||
1854 | |||
1855 | static void udf_free_partition(struct udf_part_map *map) | ||
1856 | { | ||
1857 | int i; | ||
1858 | struct udf_meta_data *mdata; | ||
1859 | |||
1860 | if (map->s_partition_flags & UDF_PART_FLAG_UNALLOC_TABLE) | ||
1861 | iput(map->s_uspace.s_table); | ||
1862 | if (map->s_partition_flags & UDF_PART_FLAG_FREED_TABLE) | ||
1863 | iput(map->s_fspace.s_table); | ||
1864 | if (map->s_partition_flags & UDF_PART_FLAG_UNALLOC_BITMAP) | ||
1865 | udf_sb_free_bitmap(map->s_uspace.s_bitmap); | ||
1866 | if (map->s_partition_flags & UDF_PART_FLAG_FREED_BITMAP) | ||
1867 | udf_sb_free_bitmap(map->s_fspace.s_bitmap); | ||
1868 | if (map->s_partition_type == UDF_SPARABLE_MAP15) | ||
1869 | for (i = 0; i < 4; i++) | ||
1870 | brelse(map->s_type_specific.s_sparing.s_spar_map[i]); | ||
1871 | else if (map->s_partition_type == UDF_METADATA_MAP25) { | ||
1872 | mdata = &map->s_type_specific.s_metadata; | ||
1873 | iput(mdata->s_metadata_fe); | ||
1874 | mdata->s_metadata_fe = NULL; | ||
1875 | |||
1876 | iput(mdata->s_mirror_fe); | ||
1877 | mdata->s_mirror_fe = NULL; | ||
1878 | |||
1879 | iput(mdata->s_bitmap_fe); | ||
1880 | mdata->s_bitmap_fe = NULL; | ||
1881 | } | ||
1882 | } | ||
1883 | |||
1884 | static int udf_fill_super(struct super_block *sb, void *options, int silent) | 1925 | static int udf_fill_super(struct super_block *sb, void *options, int silent) |
1885 | { | 1926 | { |
1886 | int i; | ||
1887 | int ret; | 1927 | int ret; |
1888 | struct inode *inode = NULL; | 1928 | struct inode *inode = NULL; |
1889 | struct udf_options uopt; | 1929 | struct udf_options uopt; |
@@ -1948,7 +1988,6 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent) | |||
1948 | sb->s_op = &udf_sb_ops; | 1988 | sb->s_op = &udf_sb_ops; |
1949 | sb->s_export_op = &udf_export_ops; | 1989 | sb->s_export_op = &udf_export_ops; |
1950 | 1990 | ||
1951 | sb->s_dirt = 0; | ||
1952 | sb->s_magic = UDF_SUPER_MAGIC; | 1991 | sb->s_magic = UDF_SUPER_MAGIC; |
1953 | sb->s_time_gran = 1000; | 1992 | sb->s_time_gran = 1000; |
1954 | 1993 | ||
@@ -2046,9 +2085,6 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent) | |||
2046 | error_out: | 2085 | error_out: |
2047 | if (sbi->s_vat_inode) | 2086 | if (sbi->s_vat_inode) |
2048 | iput(sbi->s_vat_inode); | 2087 | iput(sbi->s_vat_inode); |
2049 | if (sbi->s_partitions) | ||
2050 | for (i = 0; i < sbi->s_partitions; i++) | ||
2051 | udf_free_partition(&sbi->s_partmaps[i]); | ||
2052 | #ifdef CONFIG_UDF_NLS | 2088 | #ifdef CONFIG_UDF_NLS |
2053 | if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) | 2089 | if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) |
2054 | unload_nls(sbi->s_nls_map); | 2090 | unload_nls(sbi->s_nls_map); |
@@ -2056,8 +2092,7 @@ error_out: | |||
2056 | if (!(sb->s_flags & MS_RDONLY)) | 2092 | if (!(sb->s_flags & MS_RDONLY)) |
2057 | udf_close_lvid(sb); | 2093 | udf_close_lvid(sb); |
2058 | brelse(sbi->s_lvid_bh); | 2094 | brelse(sbi->s_lvid_bh); |
2059 | 2095 | udf_sb_free_partitions(sb); | |
2060 | kfree(sbi->s_partmaps); | ||
2061 | kfree(sbi); | 2096 | kfree(sbi); |
2062 | sb->s_fs_info = NULL; | 2097 | sb->s_fs_info = NULL; |
2063 | 2098 | ||
@@ -2070,10 +2105,6 @@ void _udf_err(struct super_block *sb, const char *function, | |||
2070 | struct va_format vaf; | 2105 | struct va_format vaf; |
2071 | va_list args; | 2106 | va_list args; |
2072 | 2107 | ||
2073 | /* mark sb error */ | ||
2074 | if (!(sb->s_flags & MS_RDONLY)) | ||
2075 | sb->s_dirt = 1; | ||
2076 | |||
2077 | va_start(args, fmt); | 2108 | va_start(args, fmt); |
2078 | 2109 | ||
2079 | vaf.fmt = fmt; | 2110 | vaf.fmt = fmt; |
@@ -2102,16 +2133,12 @@ void _udf_warn(struct super_block *sb, const char *function, | |||
2102 | 2133 | ||
2103 | static void udf_put_super(struct super_block *sb) | 2134 | static void udf_put_super(struct super_block *sb) |
2104 | { | 2135 | { |
2105 | int i; | ||
2106 | struct udf_sb_info *sbi; | 2136 | struct udf_sb_info *sbi; |
2107 | 2137 | ||
2108 | sbi = UDF_SB(sb); | 2138 | sbi = UDF_SB(sb); |
2109 | 2139 | ||
2110 | if (sbi->s_vat_inode) | 2140 | if (sbi->s_vat_inode) |
2111 | iput(sbi->s_vat_inode); | 2141 | iput(sbi->s_vat_inode); |
2112 | if (sbi->s_partitions) | ||
2113 | for (i = 0; i < sbi->s_partitions; i++) | ||
2114 | udf_free_partition(&sbi->s_partmaps[i]); | ||
2115 | #ifdef CONFIG_UDF_NLS | 2142 | #ifdef CONFIG_UDF_NLS |
2116 | if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) | 2143 | if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) |
2117 | unload_nls(sbi->s_nls_map); | 2144 | unload_nls(sbi->s_nls_map); |
@@ -2119,7 +2146,7 @@ static void udf_put_super(struct super_block *sb) | |||
2119 | if (!(sb->s_flags & MS_RDONLY)) | 2146 | if (!(sb->s_flags & MS_RDONLY)) |
2120 | udf_close_lvid(sb); | 2147 | udf_close_lvid(sb); |
2121 | brelse(sbi->s_lvid_bh); | 2148 | brelse(sbi->s_lvid_bh); |
2122 | kfree(sbi->s_partmaps); | 2149 | udf_sb_free_partitions(sb); |
2123 | kfree(sb->s_fs_info); | 2150 | kfree(sb->s_fs_info); |
2124 | sb->s_fs_info = NULL; | 2151 | sb->s_fs_info = NULL; |
2125 | } | 2152 | } |
@@ -2135,7 +2162,6 @@ static int udf_sync_fs(struct super_block *sb, int wait) | |||
2135 | * the buffer for IO | 2162 | * the buffer for IO |
2136 | */ | 2163 | */ |
2137 | mark_buffer_dirty(sbi->s_lvid_bh); | 2164 | mark_buffer_dirty(sbi->s_lvid_bh); |
2138 | sb->s_dirt = 0; | ||
2139 | sbi->s_lvid_dirty = 0; | 2165 | sbi->s_lvid_dirty = 0; |
2140 | } | 2166 | } |
2141 | mutex_unlock(&sbi->s_alloc_mutex); | 2167 | mutex_unlock(&sbi->s_alloc_mutex); |
diff --git a/fs/udf/truncate.c b/fs/udf/truncate.c index 4b98fee8e161..8a9657d7f7c6 100644 --- a/fs/udf/truncate.c +++ b/fs/udf/truncate.c | |||
@@ -248,7 +248,7 @@ void udf_truncate_extents(struct inode *inode) | |||
248 | /* We managed to free all extents in the | 248 | /* We managed to free all extents in the |
249 | * indirect extent - free it too */ | 249 | * indirect extent - free it too */ |
250 | BUG_ON(!epos.bh); | 250 | BUG_ON(!epos.bh); |
251 | udf_free_blocks(sb, inode, &epos.block, | 251 | udf_free_blocks(sb, NULL, &epos.block, |
252 | 0, indirect_ext_len); | 252 | 0, indirect_ext_len); |
253 | } else if (!epos.bh) { | 253 | } else if (!epos.bh) { |
254 | iinfo->i_lenAlloc = lenalloc; | 254 | iinfo->i_lenAlloc = lenalloc; |
@@ -275,7 +275,7 @@ void udf_truncate_extents(struct inode *inode) | |||
275 | 275 | ||
276 | if (indirect_ext_len) { | 276 | if (indirect_ext_len) { |
277 | BUG_ON(!epos.bh); | 277 | BUG_ON(!epos.bh); |
278 | udf_free_blocks(sb, inode, &epos.block, 0, indirect_ext_len); | 278 | udf_free_blocks(sb, NULL, &epos.block, 0, indirect_ext_len); |
279 | } else if (!epos.bh) { | 279 | } else if (!epos.bh) { |
280 | iinfo->i_lenAlloc = lenalloc; | 280 | iinfo->i_lenAlloc = lenalloc; |
281 | mark_inode_dirty(inode); | 281 | mark_inode_dirty(inode); |
diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h index ebe10314e512..de038da6f6bd 100644 --- a/fs/udf/udfdecl.h +++ b/fs/udf/udfdecl.h | |||
@@ -129,7 +129,6 @@ static inline void udf_updated_lvid(struct super_block *sb) | |||
129 | WARN_ON_ONCE(((struct logicalVolIntegrityDesc *) | 129 | WARN_ON_ONCE(((struct logicalVolIntegrityDesc *) |
130 | bh->b_data)->integrityType != | 130 | bh->b_data)->integrityType != |
131 | cpu_to_le32(LVID_INTEGRITY_TYPE_OPEN)); | 131 | cpu_to_le32(LVID_INTEGRITY_TYPE_OPEN)); |
132 | sb->s_dirt = 1; | ||
133 | UDF_SB(sb)->s_lvid_dirty = 1; | 132 | UDF_SB(sb)->s_lvid_dirty = 1; |
134 | } | 133 | } |
135 | extern u64 lvid_get_unique_id(struct super_block *sb); | 134 | extern u64 lvid_get_unique_id(struct super_block *sb); |
diff --git a/fs/ufs/balloc.c b/fs/ufs/balloc.c index 42694e11c23d..1b3e410bf334 100644 --- a/fs/ufs/balloc.c +++ b/fs/ufs/balloc.c | |||
@@ -116,7 +116,7 @@ void ufs_free_fragments(struct inode *inode, u64 fragment, unsigned count) | |||
116 | ubh_mark_buffer_dirty (UCPI_UBH(ucpi)); | 116 | ubh_mark_buffer_dirty (UCPI_UBH(ucpi)); |
117 | if (sb->s_flags & MS_SYNCHRONOUS) | 117 | if (sb->s_flags & MS_SYNCHRONOUS) |
118 | ubh_sync_block(UCPI_UBH(ucpi)); | 118 | ubh_sync_block(UCPI_UBH(ucpi)); |
119 | sb->s_dirt = 1; | 119 | ufs_mark_sb_dirty(sb); |
120 | 120 | ||
121 | unlock_super (sb); | 121 | unlock_super (sb); |
122 | UFSD("EXIT\n"); | 122 | UFSD("EXIT\n"); |
@@ -214,7 +214,7 @@ do_more: | |||
214 | goto do_more; | 214 | goto do_more; |
215 | } | 215 | } |
216 | 216 | ||
217 | sb->s_dirt = 1; | 217 | ufs_mark_sb_dirty(sb); |
218 | unlock_super (sb); | 218 | unlock_super (sb); |
219 | UFSD("EXIT\n"); | 219 | UFSD("EXIT\n"); |
220 | return; | 220 | return; |
@@ -557,7 +557,7 @@ static u64 ufs_add_fragments(struct inode *inode, u64 fragment, | |||
557 | ubh_mark_buffer_dirty (UCPI_UBH(ucpi)); | 557 | ubh_mark_buffer_dirty (UCPI_UBH(ucpi)); |
558 | if (sb->s_flags & MS_SYNCHRONOUS) | 558 | if (sb->s_flags & MS_SYNCHRONOUS) |
559 | ubh_sync_block(UCPI_UBH(ucpi)); | 559 | ubh_sync_block(UCPI_UBH(ucpi)); |
560 | sb->s_dirt = 1; | 560 | ufs_mark_sb_dirty(sb); |
561 | 561 | ||
562 | UFSD("EXIT, fragment %llu\n", (unsigned long long)fragment); | 562 | UFSD("EXIT, fragment %llu\n", (unsigned long long)fragment); |
563 | 563 | ||
@@ -677,7 +677,7 @@ succed: | |||
677 | ubh_mark_buffer_dirty (UCPI_UBH(ucpi)); | 677 | ubh_mark_buffer_dirty (UCPI_UBH(ucpi)); |
678 | if (sb->s_flags & MS_SYNCHRONOUS) | 678 | if (sb->s_flags & MS_SYNCHRONOUS) |
679 | ubh_sync_block(UCPI_UBH(ucpi)); | 679 | ubh_sync_block(UCPI_UBH(ucpi)); |
680 | sb->s_dirt = 1; | 680 | ufs_mark_sb_dirty(sb); |
681 | 681 | ||
682 | result += cgno * uspi->s_fpg; | 682 | result += cgno * uspi->s_fpg; |
683 | UFSD("EXIT3, result %llu\n", (unsigned long long)result); | 683 | UFSD("EXIT3, result %llu\n", (unsigned long long)result); |
diff --git a/fs/ufs/ialloc.c b/fs/ufs/ialloc.c index 4ec5c1085a87..e84cbe21b986 100644 --- a/fs/ufs/ialloc.c +++ b/fs/ufs/ialloc.c | |||
@@ -116,7 +116,7 @@ void ufs_free_inode (struct inode * inode) | |||
116 | if (sb->s_flags & MS_SYNCHRONOUS) | 116 | if (sb->s_flags & MS_SYNCHRONOUS) |
117 | ubh_sync_block(UCPI_UBH(ucpi)); | 117 | ubh_sync_block(UCPI_UBH(ucpi)); |
118 | 118 | ||
119 | sb->s_dirt = 1; | 119 | ufs_mark_sb_dirty(sb); |
120 | unlock_super (sb); | 120 | unlock_super (sb); |
121 | UFSD("EXIT\n"); | 121 | UFSD("EXIT\n"); |
122 | } | 122 | } |
@@ -288,7 +288,7 @@ cg_found: | |||
288 | ubh_mark_buffer_dirty (UCPI_UBH(ucpi)); | 288 | ubh_mark_buffer_dirty (UCPI_UBH(ucpi)); |
289 | if (sb->s_flags & MS_SYNCHRONOUS) | 289 | if (sb->s_flags & MS_SYNCHRONOUS) |
290 | ubh_sync_block(UCPI_UBH(ucpi)); | 290 | ubh_sync_block(UCPI_UBH(ucpi)); |
291 | sb->s_dirt = 1; | 291 | ufs_mark_sb_dirty(sb); |
292 | 292 | ||
293 | inode->i_ino = cg * uspi->s_ipg + bit; | 293 | inode->i_ino = cg * uspi->s_ipg + bit; |
294 | inode_init_owner(inode, dir, mode); | 294 | inode_init_owner(inode, dir, mode); |
diff --git a/fs/ufs/namei.c b/fs/ufs/namei.c index a2281cadefa1..90d74b8f8eba 100644 --- a/fs/ufs/namei.c +++ b/fs/ufs/namei.c | |||
@@ -46,7 +46,7 @@ static inline int ufs_add_nondir(struct dentry *dentry, struct inode *inode) | |||
46 | return err; | 46 | return err; |
47 | } | 47 | } |
48 | 48 | ||
49 | static struct dentry *ufs_lookup(struct inode * dir, struct dentry *dentry, struct nameidata *nd) | 49 | static struct dentry *ufs_lookup(struct inode * dir, struct dentry *dentry, unsigned int flags) |
50 | { | 50 | { |
51 | struct inode * inode = NULL; | 51 | struct inode * inode = NULL; |
52 | ino_t ino; | 52 | ino_t ino; |
@@ -71,7 +71,7 @@ static struct dentry *ufs_lookup(struct inode * dir, struct dentry *dentry, stru | |||
71 | * with d_instantiate(). | 71 | * with d_instantiate(). |
72 | */ | 72 | */ |
73 | static int ufs_create (struct inode * dir, struct dentry * dentry, umode_t mode, | 73 | static int ufs_create (struct inode * dir, struct dentry * dentry, umode_t mode, |
74 | struct nameidata *nd) | 74 | bool excl) |
75 | { | 75 | { |
76 | struct inode *inode; | 76 | struct inode *inode; |
77 | int err; | 77 | int err; |
diff --git a/fs/ufs/super.c b/fs/ufs/super.c index 302f340d0071..444927e5706b 100644 --- a/fs/ufs/super.c +++ b/fs/ufs/super.c | |||
@@ -302,7 +302,7 @@ void ufs_error (struct super_block * sb, const char * function, | |||
302 | if (!(sb->s_flags & MS_RDONLY)) { | 302 | if (!(sb->s_flags & MS_RDONLY)) { |
303 | usb1->fs_clean = UFS_FSBAD; | 303 | usb1->fs_clean = UFS_FSBAD; |
304 | ubh_mark_buffer_dirty(USPI_UBH(uspi)); | 304 | ubh_mark_buffer_dirty(USPI_UBH(uspi)); |
305 | sb->s_dirt = 1; | 305 | ufs_mark_sb_dirty(sb); |
306 | sb->s_flags |= MS_RDONLY; | 306 | sb->s_flags |= MS_RDONLY; |
307 | } | 307 | } |
308 | va_start (args, fmt); | 308 | va_start (args, fmt); |
@@ -334,7 +334,7 @@ void ufs_panic (struct super_block * sb, const char * function, | |||
334 | if (!(sb->s_flags & MS_RDONLY)) { | 334 | if (!(sb->s_flags & MS_RDONLY)) { |
335 | usb1->fs_clean = UFS_FSBAD; | 335 | usb1->fs_clean = UFS_FSBAD; |
336 | ubh_mark_buffer_dirty(USPI_UBH(uspi)); | 336 | ubh_mark_buffer_dirty(USPI_UBH(uspi)); |
337 | sb->s_dirt = 1; | 337 | ufs_mark_sb_dirty(sb); |
338 | } | 338 | } |
339 | va_start (args, fmt); | 339 | va_start (args, fmt); |
340 | vsnprintf (error_buf, sizeof(error_buf), fmt, args); | 340 | vsnprintf (error_buf, sizeof(error_buf), fmt, args); |
@@ -691,6 +691,83 @@ static void ufs_put_super_internal(struct super_block *sb) | |||
691 | UFSD("EXIT\n"); | 691 | UFSD("EXIT\n"); |
692 | } | 692 | } |
693 | 693 | ||
694 | static int ufs_sync_fs(struct super_block *sb, int wait) | ||
695 | { | ||
696 | struct ufs_sb_private_info * uspi; | ||
697 | struct ufs_super_block_first * usb1; | ||
698 | struct ufs_super_block_third * usb3; | ||
699 | unsigned flags; | ||
700 | |||
701 | lock_ufs(sb); | ||
702 | lock_super(sb); | ||
703 | |||
704 | UFSD("ENTER\n"); | ||
705 | |||
706 | flags = UFS_SB(sb)->s_flags; | ||
707 | uspi = UFS_SB(sb)->s_uspi; | ||
708 | usb1 = ubh_get_usb_first(uspi); | ||
709 | usb3 = ubh_get_usb_third(uspi); | ||
710 | |||
711 | usb1->fs_time = cpu_to_fs32(sb, get_seconds()); | ||
712 | if ((flags & UFS_ST_MASK) == UFS_ST_SUN || | ||
713 | (flags & UFS_ST_MASK) == UFS_ST_SUNOS || | ||
714 | (flags & UFS_ST_MASK) == UFS_ST_SUNx86) | ||
715 | ufs_set_fs_state(sb, usb1, usb3, | ||
716 | UFS_FSOK - fs32_to_cpu(sb, usb1->fs_time)); | ||
717 | ufs_put_cstotal(sb); | ||
718 | |||
719 | UFSD("EXIT\n"); | ||
720 | unlock_super(sb); | ||
721 | unlock_ufs(sb); | ||
722 | |||
723 | return 0; | ||
724 | } | ||
725 | |||
726 | static void delayed_sync_fs(struct work_struct *work) | ||
727 | { | ||
728 | struct ufs_sb_info *sbi; | ||
729 | |||
730 | sbi = container_of(work, struct ufs_sb_info, sync_work.work); | ||
731 | |||
732 | spin_lock(&sbi->work_lock); | ||
733 | sbi->work_queued = 0; | ||
734 | spin_unlock(&sbi->work_lock); | ||
735 | |||
736 | ufs_sync_fs(sbi->sb, 1); | ||
737 | } | ||
738 | |||
739 | void ufs_mark_sb_dirty(struct super_block *sb) | ||
740 | { | ||
741 | struct ufs_sb_info *sbi = UFS_SB(sb); | ||
742 | unsigned long delay; | ||
743 | |||
744 | spin_lock(&sbi->work_lock); | ||
745 | if (!sbi->work_queued) { | ||
746 | delay = msecs_to_jiffies(dirty_writeback_interval * 10); | ||
747 | queue_delayed_work(system_long_wq, &sbi->sync_work, delay); | ||
748 | sbi->work_queued = 1; | ||
749 | } | ||
750 | spin_unlock(&sbi->work_lock); | ||
751 | } | ||
752 | |||
753 | static void ufs_put_super(struct super_block *sb) | ||
754 | { | ||
755 | struct ufs_sb_info * sbi = UFS_SB(sb); | ||
756 | |||
757 | UFSD("ENTER\n"); | ||
758 | |||
759 | if (!(sb->s_flags & MS_RDONLY)) | ||
760 | ufs_put_super_internal(sb); | ||
761 | cancel_delayed_work_sync(&sbi->sync_work); | ||
762 | |||
763 | ubh_brelse_uspi (sbi->s_uspi); | ||
764 | kfree (sbi->s_uspi); | ||
765 | kfree (sbi); | ||
766 | sb->s_fs_info = NULL; | ||
767 | UFSD("EXIT\n"); | ||
768 | return; | ||
769 | } | ||
770 | |||
694 | static int ufs_fill_super(struct super_block *sb, void *data, int silent) | 771 | static int ufs_fill_super(struct super_block *sb, void *data, int silent) |
695 | { | 772 | { |
696 | struct ufs_sb_info * sbi; | 773 | struct ufs_sb_info * sbi; |
@@ -716,6 +793,7 @@ static int ufs_fill_super(struct super_block *sb, void *data, int silent) | |||
716 | if (!sbi) | 793 | if (!sbi) |
717 | goto failed_nomem; | 794 | goto failed_nomem; |
718 | sb->s_fs_info = sbi; | 795 | sb->s_fs_info = sbi; |
796 | sbi->sb = sb; | ||
719 | 797 | ||
720 | UFSD("flag %u\n", (int)(sb->s_flags & MS_RDONLY)); | 798 | UFSD("flag %u\n", (int)(sb->s_flags & MS_RDONLY)); |
721 | 799 | ||
@@ -727,6 +805,8 @@ static int ufs_fill_super(struct super_block *sb, void *data, int silent) | |||
727 | } | 805 | } |
728 | #endif | 806 | #endif |
729 | mutex_init(&sbi->mutex); | 807 | mutex_init(&sbi->mutex); |
808 | spin_lock_init(&sbi->work_lock); | ||
809 | INIT_DELAYED_WORK(&sbi->sync_work, delayed_sync_fs); | ||
730 | /* | 810 | /* |
731 | * Set default mount options | 811 | * Set default mount options |
732 | * Parse mount options | 812 | * Parse mount options |
@@ -1191,68 +1271,6 @@ failed_nomem: | |||
1191 | return -ENOMEM; | 1271 | return -ENOMEM; |
1192 | } | 1272 | } |
1193 | 1273 | ||
1194 | static int ufs_sync_fs(struct super_block *sb, int wait) | ||
1195 | { | ||
1196 | struct ufs_sb_private_info * uspi; | ||
1197 | struct ufs_super_block_first * usb1; | ||
1198 | struct ufs_super_block_third * usb3; | ||
1199 | unsigned flags; | ||
1200 | |||
1201 | lock_ufs(sb); | ||
1202 | lock_super(sb); | ||
1203 | |||
1204 | UFSD("ENTER\n"); | ||
1205 | |||
1206 | flags = UFS_SB(sb)->s_flags; | ||
1207 | uspi = UFS_SB(sb)->s_uspi; | ||
1208 | usb1 = ubh_get_usb_first(uspi); | ||
1209 | usb3 = ubh_get_usb_third(uspi); | ||
1210 | |||
1211 | usb1->fs_time = cpu_to_fs32(sb, get_seconds()); | ||
1212 | if ((flags & UFS_ST_MASK) == UFS_ST_SUN || | ||
1213 | (flags & UFS_ST_MASK) == UFS_ST_SUNOS || | ||
1214 | (flags & UFS_ST_MASK) == UFS_ST_SUNx86) | ||
1215 | ufs_set_fs_state(sb, usb1, usb3, | ||
1216 | UFS_FSOK - fs32_to_cpu(sb, usb1->fs_time)); | ||
1217 | ufs_put_cstotal(sb); | ||
1218 | sb->s_dirt = 0; | ||
1219 | |||
1220 | UFSD("EXIT\n"); | ||
1221 | unlock_super(sb); | ||
1222 | unlock_ufs(sb); | ||
1223 | |||
1224 | return 0; | ||
1225 | } | ||
1226 | |||
1227 | static void ufs_write_super(struct super_block *sb) | ||
1228 | { | ||
1229 | if (!(sb->s_flags & MS_RDONLY)) | ||
1230 | ufs_sync_fs(sb, 1); | ||
1231 | else | ||
1232 | sb->s_dirt = 0; | ||
1233 | } | ||
1234 | |||
1235 | static void ufs_put_super(struct super_block *sb) | ||
1236 | { | ||
1237 | struct ufs_sb_info * sbi = UFS_SB(sb); | ||
1238 | |||
1239 | UFSD("ENTER\n"); | ||
1240 | |||
1241 | if (sb->s_dirt) | ||
1242 | ufs_write_super(sb); | ||
1243 | |||
1244 | if (!(sb->s_flags & MS_RDONLY)) | ||
1245 | ufs_put_super_internal(sb); | ||
1246 | |||
1247 | ubh_brelse_uspi (sbi->s_uspi); | ||
1248 | kfree (sbi->s_uspi); | ||
1249 | kfree (sbi); | ||
1250 | sb->s_fs_info = NULL; | ||
1251 | UFSD("EXIT\n"); | ||
1252 | return; | ||
1253 | } | ||
1254 | |||
1255 | |||
1256 | static int ufs_remount (struct super_block *sb, int *mount_flags, char *data) | 1274 | static int ufs_remount (struct super_block *sb, int *mount_flags, char *data) |
1257 | { | 1275 | { |
1258 | struct ufs_sb_private_info * uspi; | 1276 | struct ufs_sb_private_info * uspi; |
@@ -1308,7 +1326,6 @@ static int ufs_remount (struct super_block *sb, int *mount_flags, char *data) | |||
1308 | ufs_set_fs_state(sb, usb1, usb3, | 1326 | ufs_set_fs_state(sb, usb1, usb3, |
1309 | UFS_FSOK - fs32_to_cpu(sb, usb1->fs_time)); | 1327 | UFS_FSOK - fs32_to_cpu(sb, usb1->fs_time)); |
1310 | ubh_mark_buffer_dirty (USPI_UBH(uspi)); | 1328 | ubh_mark_buffer_dirty (USPI_UBH(uspi)); |
1311 | sb->s_dirt = 0; | ||
1312 | sb->s_flags |= MS_RDONLY; | 1329 | sb->s_flags |= MS_RDONLY; |
1313 | } else { | 1330 | } else { |
1314 | /* | 1331 | /* |
@@ -1458,7 +1475,6 @@ static const struct super_operations ufs_super_ops = { | |||
1458 | .write_inode = ufs_write_inode, | 1475 | .write_inode = ufs_write_inode, |
1459 | .evict_inode = ufs_evict_inode, | 1476 | .evict_inode = ufs_evict_inode, |
1460 | .put_super = ufs_put_super, | 1477 | .put_super = ufs_put_super, |
1461 | .write_super = ufs_write_super, | ||
1462 | .sync_fs = ufs_sync_fs, | 1478 | .sync_fs = ufs_sync_fs, |
1463 | .statfs = ufs_statfs, | 1479 | .statfs = ufs_statfs, |
1464 | .remount_fs = ufs_remount, | 1480 | .remount_fs = ufs_remount, |
diff --git a/fs/ufs/ufs.h b/fs/ufs/ufs.h index 528750b7e701..343e6fc571e5 100644 --- a/fs/ufs/ufs.h +++ b/fs/ufs/ufs.h | |||
@@ -20,6 +20,10 @@ struct ufs_sb_info { | |||
20 | unsigned s_mount_opt; | 20 | unsigned s_mount_opt; |
21 | struct mutex mutex; | 21 | struct mutex mutex; |
22 | struct task_struct *mutex_owner; | 22 | struct task_struct *mutex_owner; |
23 | struct super_block *sb; | ||
24 | int work_queued; /* non-zero if the delayed work is queued */ | ||
25 | struct delayed_work sync_work; /* FS sync delayed work */ | ||
26 | spinlock_t work_lock; /* protects sync_work and work_queued */ | ||
23 | }; | 27 | }; |
24 | 28 | ||
25 | struct ufs_inode_info { | 29 | struct ufs_inode_info { |
@@ -123,6 +127,7 @@ extern __printf(3, 4) | |||
123 | void ufs_error(struct super_block *, const char *, const char *, ...); | 127 | void ufs_error(struct super_block *, const char *, const char *, ...); |
124 | extern __printf(3, 4) | 128 | extern __printf(3, 4) |
125 | void ufs_panic(struct super_block *, const char *, const char *, ...); | 129 | void ufs_panic(struct super_block *, const char *, const char *, ...); |
130 | void ufs_mark_sb_dirty(struct super_block *sb); | ||
126 | 131 | ||
127 | /* symlink.c */ | 132 | /* symlink.c */ |
128 | extern const struct inode_operations ufs_fast_symlink_inode_operations; | 133 | extern const struct inode_operations ufs_fast_symlink_inode_operations; |
diff --git a/fs/ufs/ufs_fs.h b/fs/ufs/ufs_fs.h index 8aba544f9fad..0cbd5d340b67 100644 --- a/fs/ufs/ufs_fs.h +++ b/fs/ufs/ufs_fs.h | |||
@@ -34,6 +34,7 @@ | |||
34 | #include <linux/kernel.h> | 34 | #include <linux/kernel.h> |
35 | #include <linux/stat.h> | 35 | #include <linux/stat.h> |
36 | #include <linux/fs.h> | 36 | #include <linux/fs.h> |
37 | #include <linux/workqueue.h> | ||
37 | 38 | ||
38 | #include <asm/div64.h> | 39 | #include <asm/div64.h> |
39 | typedef __u64 __bitwise __fs64; | 40 | typedef __u64 __bitwise __fs64; |
diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c index 229641fb8e67..4f33c32affe3 100644 --- a/fs/xfs/xfs_alloc.c +++ b/fs/xfs/xfs_alloc.c | |||
@@ -1074,12 +1074,13 @@ restart: | |||
1074 | * If we couldn't get anything, give up. | 1074 | * If we couldn't get anything, give up. |
1075 | */ | 1075 | */ |
1076 | if (bno_cur_lt == NULL && bno_cur_gt == NULL) { | 1076 | if (bno_cur_lt == NULL && bno_cur_gt == NULL) { |
1077 | xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR); | ||
1078 | |||
1077 | if (!forced++) { | 1079 | if (!forced++) { |
1078 | trace_xfs_alloc_near_busy(args); | 1080 | trace_xfs_alloc_near_busy(args); |
1079 | xfs_log_force(args->mp, XFS_LOG_SYNC); | 1081 | xfs_log_force(args->mp, XFS_LOG_SYNC); |
1080 | goto restart; | 1082 | goto restart; |
1081 | } | 1083 | } |
1082 | |||
1083 | trace_xfs_alloc_size_neither(args); | 1084 | trace_xfs_alloc_size_neither(args); |
1084 | args->agbno = NULLAGBLOCK; | 1085 | args->agbno = NULLAGBLOCK; |
1085 | return 0; | 1086 | return 0; |
@@ -2433,15 +2434,24 @@ xfs_alloc_vextent_worker( | |||
2433 | current_restore_flags_nested(&pflags, PF_FSTRANS); | 2434 | current_restore_flags_nested(&pflags, PF_FSTRANS); |
2434 | } | 2435 | } |
2435 | 2436 | ||
2436 | 2437 | /* | |
2437 | int /* error */ | 2438 | * Data allocation requests often come in with little stack to work on. Push |
2439 | * them off to a worker thread so there is lots of stack to use. Metadata | ||
2440 | * requests, OTOH, are generally from low stack usage paths, so avoid the | ||
2441 | * context switch overhead here. | ||
2442 | */ | ||
2443 | int | ||
2438 | xfs_alloc_vextent( | 2444 | xfs_alloc_vextent( |
2439 | xfs_alloc_arg_t *args) /* allocation argument structure */ | 2445 | struct xfs_alloc_arg *args) |
2440 | { | 2446 | { |
2441 | DECLARE_COMPLETION_ONSTACK(done); | 2447 | DECLARE_COMPLETION_ONSTACK(done); |
2442 | 2448 | ||
2449 | if (!args->userdata) | ||
2450 | return __xfs_alloc_vextent(args); | ||
2451 | |||
2452 | |||
2443 | args->done = &done; | 2453 | args->done = &done; |
2444 | INIT_WORK(&args->work, xfs_alloc_vextent_worker); | 2454 | INIT_WORK_ONSTACK(&args->work, xfs_alloc_vextent_worker); |
2445 | queue_work(xfs_alloc_wq, &args->work); | 2455 | queue_work(xfs_alloc_wq, &args->work); |
2446 | wait_for_completion(&done); | 2456 | wait_for_completion(&done); |
2447 | return args->result; | 2457 | return args->result; |
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index ae31c313a79e..8dad722c0041 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c | |||
@@ -981,10 +981,15 @@ xfs_vm_writepage( | |||
981 | imap_valid = 0; | 981 | imap_valid = 0; |
982 | } | 982 | } |
983 | } else { | 983 | } else { |
984 | if (PageUptodate(page)) { | 984 | if (PageUptodate(page)) |
985 | ASSERT(buffer_mapped(bh)); | 985 | ASSERT(buffer_mapped(bh)); |
986 | imap_valid = 0; | 986 | /* |
987 | } | 987 | * This buffer is not uptodate and will not be |
988 | * written to disk. Ensure that we will put any | ||
989 | * subsequent writeable buffers into a new | ||
990 | * ioend. | ||
991 | */ | ||
992 | imap_valid = 0; | ||
988 | continue; | 993 | continue; |
989 | } | 994 | } |
990 | 995 | ||
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 172d3cc8f8cb..269b35c084da 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c | |||
@@ -201,14 +201,7 @@ xfs_buf_alloc( | |||
201 | bp->b_length = numblks; | 201 | bp->b_length = numblks; |
202 | bp->b_io_length = numblks; | 202 | bp->b_io_length = numblks; |
203 | bp->b_flags = flags; | 203 | bp->b_flags = flags; |
204 | 204 | bp->b_bn = blkno; | |
205 | /* | ||
206 | * We do not set the block number here in the buffer because we have not | ||
207 | * finished initialising the buffer. We insert the buffer into the cache | ||
208 | * in this state, so this ensures that we are unable to do IO on a | ||
209 | * buffer that hasn't been fully initialised. | ||
210 | */ | ||
211 | bp->b_bn = XFS_BUF_DADDR_NULL; | ||
212 | atomic_set(&bp->b_pin_count, 0); | 205 | atomic_set(&bp->b_pin_count, 0); |
213 | init_waitqueue_head(&bp->b_waiters); | 206 | init_waitqueue_head(&bp->b_waiters); |
214 | 207 | ||
@@ -567,11 +560,6 @@ xfs_buf_get( | |||
567 | if (bp != new_bp) | 560 | if (bp != new_bp) |
568 | xfs_buf_free(new_bp); | 561 | xfs_buf_free(new_bp); |
569 | 562 | ||
570 | /* | ||
571 | * Now we have a workable buffer, fill in the block number so | ||
572 | * that we can do IO on it. | ||
573 | */ | ||
574 | bp->b_bn = blkno; | ||
575 | bp->b_io_length = bp->b_length; | 563 | bp->b_io_length = bp->b_length; |
576 | 564 | ||
577 | found: | 565 | found: |
@@ -772,7 +760,7 @@ xfs_buf_get_uncached( | |||
772 | int error, i; | 760 | int error, i; |
773 | xfs_buf_t *bp; | 761 | xfs_buf_t *bp; |
774 | 762 | ||
775 | bp = xfs_buf_alloc(target, 0, numblks, 0); | 763 | bp = xfs_buf_alloc(target, XFS_BUF_DADDR_NULL, numblks, 0); |
776 | if (unlikely(bp == NULL)) | 764 | if (unlikely(bp == NULL)) |
777 | goto fail; | 765 | goto fail; |
778 | 766 | ||
@@ -1001,27 +989,6 @@ xfs_buf_ioerror_alert( | |||
1001 | (__uint64_t)XFS_BUF_ADDR(bp), func, bp->b_error, bp->b_length); | 989 | (__uint64_t)XFS_BUF_ADDR(bp), func, bp->b_error, bp->b_length); |
1002 | } | 990 | } |
1003 | 991 | ||
1004 | int | ||
1005 | xfs_bwrite( | ||
1006 | struct xfs_buf *bp) | ||
1007 | { | ||
1008 | int error; | ||
1009 | |||
1010 | ASSERT(xfs_buf_islocked(bp)); | ||
1011 | |||
1012 | bp->b_flags |= XBF_WRITE; | ||
1013 | bp->b_flags &= ~(XBF_ASYNC | XBF_READ | _XBF_DELWRI_Q); | ||
1014 | |||
1015 | xfs_bdstrat_cb(bp); | ||
1016 | |||
1017 | error = xfs_buf_iowait(bp); | ||
1018 | if (error) { | ||
1019 | xfs_force_shutdown(bp->b_target->bt_mount, | ||
1020 | SHUTDOWN_META_IO_ERROR); | ||
1021 | } | ||
1022 | return error; | ||
1023 | } | ||
1024 | |||
1025 | /* | 992 | /* |
1026 | * Called when we want to stop a buffer from getting written or read. | 993 | * Called when we want to stop a buffer from getting written or read. |
1027 | * We attach the EIO error, muck with its flags, and call xfs_buf_ioend | 994 | * We attach the EIO error, muck with its flags, and call xfs_buf_ioend |
@@ -1091,14 +1058,7 @@ xfs_bioerror_relse( | |||
1091 | return EIO; | 1058 | return EIO; |
1092 | } | 1059 | } |
1093 | 1060 | ||
1094 | 1061 | STATIC int | |
1095 | /* | ||
1096 | * All xfs metadata buffers except log state machine buffers | ||
1097 | * get this attached as their b_bdstrat callback function. | ||
1098 | * This is so that we can catch a buffer | ||
1099 | * after prematurely unpinning it to forcibly shutdown the filesystem. | ||
1100 | */ | ||
1101 | int | ||
1102 | xfs_bdstrat_cb( | 1062 | xfs_bdstrat_cb( |
1103 | struct xfs_buf *bp) | 1063 | struct xfs_buf *bp) |
1104 | { | 1064 | { |
@@ -1119,6 +1079,27 @@ xfs_bdstrat_cb( | |||
1119 | return 0; | 1079 | return 0; |
1120 | } | 1080 | } |
1121 | 1081 | ||
1082 | int | ||
1083 | xfs_bwrite( | ||
1084 | struct xfs_buf *bp) | ||
1085 | { | ||
1086 | int error; | ||
1087 | |||
1088 | ASSERT(xfs_buf_islocked(bp)); | ||
1089 | |||
1090 | bp->b_flags |= XBF_WRITE; | ||
1091 | bp->b_flags &= ~(XBF_ASYNC | XBF_READ | _XBF_DELWRI_Q); | ||
1092 | |||
1093 | xfs_bdstrat_cb(bp); | ||
1094 | |||
1095 | error = xfs_buf_iowait(bp); | ||
1096 | if (error) { | ||
1097 | xfs_force_shutdown(bp->b_target->bt_mount, | ||
1098 | SHUTDOWN_META_IO_ERROR); | ||
1099 | } | ||
1100 | return error; | ||
1101 | } | ||
1102 | |||
1122 | /* | 1103 | /* |
1123 | * Wrapper around bdstrat so that we can stop data from going to disk in case | 1104 | * Wrapper around bdstrat so that we can stop data from going to disk in case |
1124 | * we are shutting down the filesystem. Typically user data goes thru this | 1105 | * we are shutting down the filesystem. Typically user data goes thru this |
@@ -1255,7 +1236,7 @@ xfs_buf_iorequest( | |||
1255 | */ | 1236 | */ |
1256 | atomic_set(&bp->b_io_remaining, 1); | 1237 | atomic_set(&bp->b_io_remaining, 1); |
1257 | _xfs_buf_ioapply(bp); | 1238 | _xfs_buf_ioapply(bp); |
1258 | _xfs_buf_ioend(bp, 0); | 1239 | _xfs_buf_ioend(bp, 1); |
1259 | 1240 | ||
1260 | xfs_buf_rele(bp); | 1241 | xfs_buf_rele(bp); |
1261 | } | 1242 | } |
diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h index 7f1d1392ce37..79344c48008e 100644 --- a/fs/xfs/xfs_buf.h +++ b/fs/xfs/xfs_buf.h | |||
@@ -180,7 +180,6 @@ extern void xfs_buf_unlock(xfs_buf_t *); | |||
180 | extern int xfs_bwrite(struct xfs_buf *bp); | 180 | extern int xfs_bwrite(struct xfs_buf *bp); |
181 | 181 | ||
182 | extern void xfsbdstrat(struct xfs_mount *, struct xfs_buf *); | 182 | extern void xfsbdstrat(struct xfs_mount *, struct xfs_buf *); |
183 | extern int xfs_bdstrat_cb(struct xfs_buf *); | ||
184 | 183 | ||
185 | extern void xfs_buf_ioend(xfs_buf_t *, int); | 184 | extern void xfs_buf_ioend(xfs_buf_t *, int); |
186 | extern void xfs_buf_ioerror(xfs_buf_t *, int); | 185 | extern void xfs_buf_ioerror(xfs_buf_t *, int); |
diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c index 45df2b857d48..d9e451115f98 100644 --- a/fs/xfs/xfs_buf_item.c +++ b/fs/xfs/xfs_buf_item.c | |||
@@ -954,7 +954,7 @@ xfs_buf_iodone_callbacks( | |||
954 | 954 | ||
955 | if (!XFS_BUF_ISSTALE(bp)) { | 955 | if (!XFS_BUF_ISSTALE(bp)) { |
956 | bp->b_flags |= XBF_WRITE | XBF_ASYNC | XBF_DONE; | 956 | bp->b_flags |= XBF_WRITE | XBF_ASYNC | XBF_DONE; |
957 | xfs_bdstrat_cb(bp); | 957 | xfs_buf_iorequest(bp); |
958 | } else { | 958 | } else { |
959 | xfs_buf_relse(bp); | 959 | xfs_buf_relse(bp); |
960 | } | 960 | } |
diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c index 6cdbf90c6f7b..d041d47d9d86 100644 --- a/fs/xfs/xfs_inode_item.c +++ b/fs/xfs/xfs_inode_item.c | |||
@@ -505,6 +505,14 @@ xfs_inode_item_push( | |||
505 | } | 505 | } |
506 | 506 | ||
507 | /* | 507 | /* |
508 | * Stale inode items should force out the iclog. | ||
509 | */ | ||
510 | if (ip->i_flags & XFS_ISTALE) { | ||
511 | rval = XFS_ITEM_PINNED; | ||
512 | goto out_unlock; | ||
513 | } | ||
514 | |||
515 | /* | ||
508 | * Someone else is already flushing the inode. Nothing we can do | 516 | * Someone else is already flushing the inode. Nothing we can do |
509 | * here but wait for the flush to finish and remove the item from | 517 | * here but wait for the flush to finish and remove the item from |
510 | * the AIL. | 518 | * the AIL. |
@@ -514,15 +522,6 @@ xfs_inode_item_push( | |||
514 | goto out_unlock; | 522 | goto out_unlock; |
515 | } | 523 | } |
516 | 524 | ||
517 | /* | ||
518 | * Stale inode items should force out the iclog. | ||
519 | */ | ||
520 | if (ip->i_flags & XFS_ISTALE) { | ||
521 | xfs_ifunlock(ip); | ||
522 | xfs_iunlock(ip, XFS_ILOCK_SHARED); | ||
523 | return XFS_ITEM_PINNED; | ||
524 | } | ||
525 | |||
526 | ASSERT(iip->ili_fields != 0 || XFS_FORCED_SHUTDOWN(ip->i_mount)); | 525 | ASSERT(iip->ili_fields != 0 || XFS_FORCED_SHUTDOWN(ip->i_mount)); |
527 | ASSERT(iip->ili_logged == 0 || XFS_FORCED_SHUTDOWN(ip->i_mount)); | 526 | ASSERT(iip->ili_logged == 0 || XFS_FORCED_SHUTDOWN(ip->i_mount)); |
528 | 527 | ||
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 3a05a41b5d76..1f1535d25a9b 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c | |||
@@ -208,6 +208,7 @@ xfs_open_by_handle( | |||
208 | struct inode *inode; | 208 | struct inode *inode; |
209 | struct dentry *dentry; | 209 | struct dentry *dentry; |
210 | fmode_t fmode; | 210 | fmode_t fmode; |
211 | struct path path; | ||
211 | 212 | ||
212 | if (!capable(CAP_SYS_ADMIN)) | 213 | if (!capable(CAP_SYS_ADMIN)) |
213 | return -XFS_ERROR(EPERM); | 214 | return -XFS_ERROR(EPERM); |
@@ -252,8 +253,10 @@ xfs_open_by_handle( | |||
252 | goto out_dput; | 253 | goto out_dput; |
253 | } | 254 | } |
254 | 255 | ||
255 | filp = dentry_open(dentry, mntget(parfilp->f_path.mnt), | 256 | path.mnt = parfilp->f_path.mnt; |
256 | hreq->oflags, cred); | 257 | path.dentry = dentry; |
258 | filp = dentry_open(&path, hreq->oflags, cred); | ||
259 | dput(dentry); | ||
257 | if (IS_ERR(filp)) { | 260 | if (IS_ERR(filp)) { |
258 | put_unused_fd(fd); | 261 | put_unused_fd(fd); |
259 | return PTR_ERR(filp); | 262 | return PTR_ERR(filp); |
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index 1a25fd802798..9c4340f5c3e0 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c | |||
@@ -179,7 +179,7 @@ xfs_vn_create( | |||
179 | struct inode *dir, | 179 | struct inode *dir, |
180 | struct dentry *dentry, | 180 | struct dentry *dentry, |
181 | umode_t mode, | 181 | umode_t mode, |
182 | struct nameidata *nd) | 182 | bool flags) |
183 | { | 183 | { |
184 | return xfs_vn_mknod(dir, dentry, mode, 0); | 184 | return xfs_vn_mknod(dir, dentry, mode, 0); |
185 | } | 185 | } |
@@ -197,7 +197,7 @@ STATIC struct dentry * | |||
197 | xfs_vn_lookup( | 197 | xfs_vn_lookup( |
198 | struct inode *dir, | 198 | struct inode *dir, |
199 | struct dentry *dentry, | 199 | struct dentry *dentry, |
200 | struct nameidata *nd) | 200 | unsigned int flags) |
201 | { | 201 | { |
202 | struct xfs_inode *cip; | 202 | struct xfs_inode *cip; |
203 | struct xfs_name name; | 203 | struct xfs_name name; |
@@ -222,7 +222,7 @@ STATIC struct dentry * | |||
222 | xfs_vn_ci_lookup( | 222 | xfs_vn_ci_lookup( |
223 | struct inode *dir, | 223 | struct inode *dir, |
224 | struct dentry *dentry, | 224 | struct dentry *dentry, |
225 | struct nameidata *nd) | 225 | unsigned int flags) |
226 | { | 226 | { |
227 | struct xfs_inode *ip; | 227 | struct xfs_inode *ip; |
228 | struct xfs_name xname; | 228 | struct xfs_name xname; |
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index f30d9807dc48..d90d4a388609 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c | |||
@@ -38,13 +38,21 @@ | |||
38 | kmem_zone_t *xfs_log_ticket_zone; | 38 | kmem_zone_t *xfs_log_ticket_zone; |
39 | 39 | ||
40 | /* Local miscellaneous function prototypes */ | 40 | /* Local miscellaneous function prototypes */ |
41 | STATIC int xlog_commit_record(struct log *log, struct xlog_ticket *ticket, | 41 | STATIC int |
42 | xlog_in_core_t **, xfs_lsn_t *); | 42 | xlog_commit_record( |
43 | struct xlog *log, | ||
44 | struct xlog_ticket *ticket, | ||
45 | struct xlog_in_core **iclog, | ||
46 | xfs_lsn_t *commitlsnp); | ||
47 | |||
43 | STATIC xlog_t * xlog_alloc_log(xfs_mount_t *mp, | 48 | STATIC xlog_t * xlog_alloc_log(xfs_mount_t *mp, |
44 | xfs_buftarg_t *log_target, | 49 | xfs_buftarg_t *log_target, |
45 | xfs_daddr_t blk_offset, | 50 | xfs_daddr_t blk_offset, |
46 | int num_bblks); | 51 | int num_bblks); |
47 | STATIC int xlog_space_left(struct log *log, atomic64_t *head); | 52 | STATIC int |
53 | xlog_space_left( | ||
54 | struct xlog *log, | ||
55 | atomic64_t *head); | ||
48 | STATIC int xlog_sync(xlog_t *log, xlog_in_core_t *iclog); | 56 | STATIC int xlog_sync(xlog_t *log, xlog_in_core_t *iclog); |
49 | STATIC void xlog_dealloc_log(xlog_t *log); | 57 | STATIC void xlog_dealloc_log(xlog_t *log); |
50 | 58 | ||
@@ -64,8 +72,10 @@ STATIC void xlog_state_switch_iclogs(xlog_t *log, | |||
64 | int eventual_size); | 72 | int eventual_size); |
65 | STATIC void xlog_state_want_sync(xlog_t *log, xlog_in_core_t *iclog); | 73 | STATIC void xlog_state_want_sync(xlog_t *log, xlog_in_core_t *iclog); |
66 | 74 | ||
67 | STATIC void xlog_grant_push_ail(struct log *log, | 75 | STATIC void |
68 | int need_bytes); | 76 | xlog_grant_push_ail( |
77 | struct xlog *log, | ||
78 | int need_bytes); | ||
69 | STATIC void xlog_regrant_reserve_log_space(xlog_t *log, | 79 | STATIC void xlog_regrant_reserve_log_space(xlog_t *log, |
70 | xlog_ticket_t *ticket); | 80 | xlog_ticket_t *ticket); |
71 | STATIC void xlog_ungrant_log_space(xlog_t *log, | 81 | STATIC void xlog_ungrant_log_space(xlog_t *log, |
@@ -73,7 +83,9 @@ STATIC void xlog_ungrant_log_space(xlog_t *log, | |||
73 | 83 | ||
74 | #if defined(DEBUG) | 84 | #if defined(DEBUG) |
75 | STATIC void xlog_verify_dest_ptr(xlog_t *log, char *ptr); | 85 | STATIC void xlog_verify_dest_ptr(xlog_t *log, char *ptr); |
76 | STATIC void xlog_verify_grant_tail(struct log *log); | 86 | STATIC void |
87 | xlog_verify_grant_tail( | ||
88 | struct xlog *log); | ||
77 | STATIC void xlog_verify_iclog(xlog_t *log, xlog_in_core_t *iclog, | 89 | STATIC void xlog_verify_iclog(xlog_t *log, xlog_in_core_t *iclog, |
78 | int count, boolean_t syncing); | 90 | int count, boolean_t syncing); |
79 | STATIC void xlog_verify_tail_lsn(xlog_t *log, xlog_in_core_t *iclog, | 91 | STATIC void xlog_verify_tail_lsn(xlog_t *log, xlog_in_core_t *iclog, |
@@ -89,9 +101,9 @@ STATIC int xlog_iclogs_empty(xlog_t *log); | |||
89 | 101 | ||
90 | static void | 102 | static void |
91 | xlog_grant_sub_space( | 103 | xlog_grant_sub_space( |
92 | struct log *log, | 104 | struct xlog *log, |
93 | atomic64_t *head, | 105 | atomic64_t *head, |
94 | int bytes) | 106 | int bytes) |
95 | { | 107 | { |
96 | int64_t head_val = atomic64_read(head); | 108 | int64_t head_val = atomic64_read(head); |
97 | int64_t new, old; | 109 | int64_t new, old; |
@@ -115,9 +127,9 @@ xlog_grant_sub_space( | |||
115 | 127 | ||
116 | static void | 128 | static void |
117 | xlog_grant_add_space( | 129 | xlog_grant_add_space( |
118 | struct log *log, | 130 | struct xlog *log, |
119 | atomic64_t *head, | 131 | atomic64_t *head, |
120 | int bytes) | 132 | int bytes) |
121 | { | 133 | { |
122 | int64_t head_val = atomic64_read(head); | 134 | int64_t head_val = atomic64_read(head); |
123 | int64_t new, old; | 135 | int64_t new, old; |
@@ -165,7 +177,7 @@ xlog_grant_head_wake_all( | |||
165 | 177 | ||
166 | static inline int | 178 | static inline int |
167 | xlog_ticket_reservation( | 179 | xlog_ticket_reservation( |
168 | struct log *log, | 180 | struct xlog *log, |
169 | struct xlog_grant_head *head, | 181 | struct xlog_grant_head *head, |
170 | struct xlog_ticket *tic) | 182 | struct xlog_ticket *tic) |
171 | { | 183 | { |
@@ -182,7 +194,7 @@ xlog_ticket_reservation( | |||
182 | 194 | ||
183 | STATIC bool | 195 | STATIC bool |
184 | xlog_grant_head_wake( | 196 | xlog_grant_head_wake( |
185 | struct log *log, | 197 | struct xlog *log, |
186 | struct xlog_grant_head *head, | 198 | struct xlog_grant_head *head, |
187 | int *free_bytes) | 199 | int *free_bytes) |
188 | { | 200 | { |
@@ -204,7 +216,7 @@ xlog_grant_head_wake( | |||
204 | 216 | ||
205 | STATIC int | 217 | STATIC int |
206 | xlog_grant_head_wait( | 218 | xlog_grant_head_wait( |
207 | struct log *log, | 219 | struct xlog *log, |
208 | struct xlog_grant_head *head, | 220 | struct xlog_grant_head *head, |
209 | struct xlog_ticket *tic, | 221 | struct xlog_ticket *tic, |
210 | int need_bytes) | 222 | int need_bytes) |
@@ -256,7 +268,7 @@ shutdown: | |||
256 | */ | 268 | */ |
257 | STATIC int | 269 | STATIC int |
258 | xlog_grant_head_check( | 270 | xlog_grant_head_check( |
259 | struct log *log, | 271 | struct xlog *log, |
260 | struct xlog_grant_head *head, | 272 | struct xlog_grant_head *head, |
261 | struct xlog_ticket *tic, | 273 | struct xlog_ticket *tic, |
262 | int *need_bytes) | 274 | int *need_bytes) |
@@ -323,7 +335,7 @@ xfs_log_regrant( | |||
323 | struct xfs_mount *mp, | 335 | struct xfs_mount *mp, |
324 | struct xlog_ticket *tic) | 336 | struct xlog_ticket *tic) |
325 | { | 337 | { |
326 | struct log *log = mp->m_log; | 338 | struct xlog *log = mp->m_log; |
327 | int need_bytes; | 339 | int need_bytes; |
328 | int error = 0; | 340 | int error = 0; |
329 | 341 | ||
@@ -389,7 +401,7 @@ xfs_log_reserve( | |||
389 | bool permanent, | 401 | bool permanent, |
390 | uint t_type) | 402 | uint t_type) |
391 | { | 403 | { |
392 | struct log *log = mp->m_log; | 404 | struct xlog *log = mp->m_log; |
393 | struct xlog_ticket *tic; | 405 | struct xlog_ticket *tic; |
394 | int need_bytes; | 406 | int need_bytes; |
395 | int error = 0; | 407 | int error = 0; |
@@ -465,7 +477,7 @@ xfs_log_done( | |||
465 | struct xlog_in_core **iclog, | 477 | struct xlog_in_core **iclog, |
466 | uint flags) | 478 | uint flags) |
467 | { | 479 | { |
468 | struct log *log = mp->m_log; | 480 | struct xlog *log = mp->m_log; |
469 | xfs_lsn_t lsn = 0; | 481 | xfs_lsn_t lsn = 0; |
470 | 482 | ||
471 | if (XLOG_FORCED_SHUTDOWN(log) || | 483 | if (XLOG_FORCED_SHUTDOWN(log) || |
@@ -810,6 +822,7 @@ xfs_log_unmount_write(xfs_mount_t *mp) | |||
810 | void | 822 | void |
811 | xfs_log_unmount(xfs_mount_t *mp) | 823 | xfs_log_unmount(xfs_mount_t *mp) |
812 | { | 824 | { |
825 | cancel_delayed_work_sync(&mp->m_sync_work); | ||
813 | xfs_trans_ail_destroy(mp); | 826 | xfs_trans_ail_destroy(mp); |
814 | xlog_dealloc_log(mp->m_log); | 827 | xlog_dealloc_log(mp->m_log); |
815 | } | 828 | } |
@@ -838,7 +851,7 @@ void | |||
838 | xfs_log_space_wake( | 851 | xfs_log_space_wake( |
839 | struct xfs_mount *mp) | 852 | struct xfs_mount *mp) |
840 | { | 853 | { |
841 | struct log *log = mp->m_log; | 854 | struct xlog *log = mp->m_log; |
842 | int free_bytes; | 855 | int free_bytes; |
843 | 856 | ||
844 | if (XLOG_FORCED_SHUTDOWN(log)) | 857 | if (XLOG_FORCED_SHUTDOWN(log)) |
@@ -916,7 +929,7 @@ xfs_lsn_t | |||
916 | xlog_assign_tail_lsn_locked( | 929 | xlog_assign_tail_lsn_locked( |
917 | struct xfs_mount *mp) | 930 | struct xfs_mount *mp) |
918 | { | 931 | { |
919 | struct log *log = mp->m_log; | 932 | struct xlog *log = mp->m_log; |
920 | struct xfs_log_item *lip; | 933 | struct xfs_log_item *lip; |
921 | xfs_lsn_t tail_lsn; | 934 | xfs_lsn_t tail_lsn; |
922 | 935 | ||
@@ -965,7 +978,7 @@ xlog_assign_tail_lsn( | |||
965 | */ | 978 | */ |
966 | STATIC int | 979 | STATIC int |
967 | xlog_space_left( | 980 | xlog_space_left( |
968 | struct log *log, | 981 | struct xlog *log, |
969 | atomic64_t *head) | 982 | atomic64_t *head) |
970 | { | 983 | { |
971 | int free_bytes; | 984 | int free_bytes; |
@@ -1277,7 +1290,7 @@ out: | |||
1277 | */ | 1290 | */ |
1278 | STATIC int | 1291 | STATIC int |
1279 | xlog_commit_record( | 1292 | xlog_commit_record( |
1280 | struct log *log, | 1293 | struct xlog *log, |
1281 | struct xlog_ticket *ticket, | 1294 | struct xlog_ticket *ticket, |
1282 | struct xlog_in_core **iclog, | 1295 | struct xlog_in_core **iclog, |
1283 | xfs_lsn_t *commitlsnp) | 1296 | xfs_lsn_t *commitlsnp) |
@@ -1311,7 +1324,7 @@ xlog_commit_record( | |||
1311 | */ | 1324 | */ |
1312 | STATIC void | 1325 | STATIC void |
1313 | xlog_grant_push_ail( | 1326 | xlog_grant_push_ail( |
1314 | struct log *log, | 1327 | struct xlog *log, |
1315 | int need_bytes) | 1328 | int need_bytes) |
1316 | { | 1329 | { |
1317 | xfs_lsn_t threshold_lsn = 0; | 1330 | xfs_lsn_t threshold_lsn = 0; |
@@ -1790,7 +1803,7 @@ xlog_write_start_rec( | |||
1790 | 1803 | ||
1791 | static xlog_op_header_t * | 1804 | static xlog_op_header_t * |
1792 | xlog_write_setup_ophdr( | 1805 | xlog_write_setup_ophdr( |
1793 | struct log *log, | 1806 | struct xlog *log, |
1794 | struct xlog_op_header *ophdr, | 1807 | struct xlog_op_header *ophdr, |
1795 | struct xlog_ticket *ticket, | 1808 | struct xlog_ticket *ticket, |
1796 | uint flags) | 1809 | uint flags) |
@@ -1873,7 +1886,7 @@ xlog_write_setup_copy( | |||
1873 | 1886 | ||
1874 | static int | 1887 | static int |
1875 | xlog_write_copy_finish( | 1888 | xlog_write_copy_finish( |
1876 | struct log *log, | 1889 | struct xlog *log, |
1877 | struct xlog_in_core *iclog, | 1890 | struct xlog_in_core *iclog, |
1878 | uint flags, | 1891 | uint flags, |
1879 | int *record_cnt, | 1892 | int *record_cnt, |
@@ -1958,7 +1971,7 @@ xlog_write_copy_finish( | |||
1958 | */ | 1971 | */ |
1959 | int | 1972 | int |
1960 | xlog_write( | 1973 | xlog_write( |
1961 | struct log *log, | 1974 | struct xlog *log, |
1962 | struct xfs_log_vec *log_vector, | 1975 | struct xfs_log_vec *log_vector, |
1963 | struct xlog_ticket *ticket, | 1976 | struct xlog_ticket *ticket, |
1964 | xfs_lsn_t *start_lsn, | 1977 | xfs_lsn_t *start_lsn, |
@@ -2821,7 +2834,7 @@ _xfs_log_force( | |||
2821 | uint flags, | 2834 | uint flags, |
2822 | int *log_flushed) | 2835 | int *log_flushed) |
2823 | { | 2836 | { |
2824 | struct log *log = mp->m_log; | 2837 | struct xlog *log = mp->m_log; |
2825 | struct xlog_in_core *iclog; | 2838 | struct xlog_in_core *iclog; |
2826 | xfs_lsn_t lsn; | 2839 | xfs_lsn_t lsn; |
2827 | 2840 | ||
@@ -2969,7 +2982,7 @@ _xfs_log_force_lsn( | |||
2969 | uint flags, | 2982 | uint flags, |
2970 | int *log_flushed) | 2983 | int *log_flushed) |
2971 | { | 2984 | { |
2972 | struct log *log = mp->m_log; | 2985 | struct xlog *log = mp->m_log; |
2973 | struct xlog_in_core *iclog; | 2986 | struct xlog_in_core *iclog; |
2974 | int already_slept = 0; | 2987 | int already_slept = 0; |
2975 | 2988 | ||
@@ -3147,7 +3160,7 @@ xfs_log_ticket_get( | |||
3147 | */ | 3160 | */ |
3148 | xlog_ticket_t * | 3161 | xlog_ticket_t * |
3149 | xlog_ticket_alloc( | 3162 | xlog_ticket_alloc( |
3150 | struct log *log, | 3163 | struct xlog *log, |
3151 | int unit_bytes, | 3164 | int unit_bytes, |
3152 | int cnt, | 3165 | int cnt, |
3153 | char client, | 3166 | char client, |
@@ -3278,7 +3291,7 @@ xlog_ticket_alloc( | |||
3278 | */ | 3291 | */ |
3279 | void | 3292 | void |
3280 | xlog_verify_dest_ptr( | 3293 | xlog_verify_dest_ptr( |
3281 | struct log *log, | 3294 | struct xlog *log, |
3282 | char *ptr) | 3295 | char *ptr) |
3283 | { | 3296 | { |
3284 | int i; | 3297 | int i; |
@@ -3307,7 +3320,7 @@ xlog_verify_dest_ptr( | |||
3307 | */ | 3320 | */ |
3308 | STATIC void | 3321 | STATIC void |
3309 | xlog_verify_grant_tail( | 3322 | xlog_verify_grant_tail( |
3310 | struct log *log) | 3323 | struct xlog *log) |
3311 | { | 3324 | { |
3312 | int tail_cycle, tail_blocks; | 3325 | int tail_cycle, tail_blocks; |
3313 | int cycle, space; | 3326 | int cycle, space; |
diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c index 7d6197c58493..ddc4529d07d3 100644 --- a/fs/xfs/xfs_log_cil.c +++ b/fs/xfs/xfs_log_cil.c | |||
@@ -44,7 +44,7 @@ | |||
44 | */ | 44 | */ |
45 | static struct xlog_ticket * | 45 | static struct xlog_ticket * |
46 | xlog_cil_ticket_alloc( | 46 | xlog_cil_ticket_alloc( |
47 | struct log *log) | 47 | struct xlog *log) |
48 | { | 48 | { |
49 | struct xlog_ticket *tic; | 49 | struct xlog_ticket *tic; |
50 | 50 | ||
@@ -72,7 +72,7 @@ xlog_cil_ticket_alloc( | |||
72 | */ | 72 | */ |
73 | void | 73 | void |
74 | xlog_cil_init_post_recovery( | 74 | xlog_cil_init_post_recovery( |
75 | struct log *log) | 75 | struct xlog *log) |
76 | { | 76 | { |
77 | log->l_cilp->xc_ctx->ticket = xlog_cil_ticket_alloc(log); | 77 | log->l_cilp->xc_ctx->ticket = xlog_cil_ticket_alloc(log); |
78 | log->l_cilp->xc_ctx->sequence = 1; | 78 | log->l_cilp->xc_ctx->sequence = 1; |
@@ -182,7 +182,7 @@ xlog_cil_prepare_log_vecs( | |||
182 | */ | 182 | */ |
183 | STATIC void | 183 | STATIC void |
184 | xfs_cil_prepare_item( | 184 | xfs_cil_prepare_item( |
185 | struct log *log, | 185 | struct xlog *log, |
186 | struct xfs_log_vec *lv, | 186 | struct xfs_log_vec *lv, |
187 | int *len, | 187 | int *len, |
188 | int *diff_iovecs) | 188 | int *diff_iovecs) |
@@ -231,7 +231,7 @@ xfs_cil_prepare_item( | |||
231 | */ | 231 | */ |
232 | static void | 232 | static void |
233 | xlog_cil_insert_items( | 233 | xlog_cil_insert_items( |
234 | struct log *log, | 234 | struct xlog *log, |
235 | struct xfs_log_vec *log_vector, | 235 | struct xfs_log_vec *log_vector, |
236 | struct xlog_ticket *ticket) | 236 | struct xlog_ticket *ticket) |
237 | { | 237 | { |
@@ -373,7 +373,7 @@ xlog_cil_committed( | |||
373 | */ | 373 | */ |
374 | STATIC int | 374 | STATIC int |
375 | xlog_cil_push( | 375 | xlog_cil_push( |
376 | struct log *log) | 376 | struct xlog *log) |
377 | { | 377 | { |
378 | struct xfs_cil *cil = log->l_cilp; | 378 | struct xfs_cil *cil = log->l_cilp; |
379 | struct xfs_log_vec *lv; | 379 | struct xfs_log_vec *lv; |
@@ -601,7 +601,7 @@ xlog_cil_push_work( | |||
601 | */ | 601 | */ |
602 | static void | 602 | static void |
603 | xlog_cil_push_background( | 603 | xlog_cil_push_background( |
604 | struct log *log) | 604 | struct xlog *log) |
605 | { | 605 | { |
606 | struct xfs_cil *cil = log->l_cilp; | 606 | struct xfs_cil *cil = log->l_cilp; |
607 | 607 | ||
@@ -629,7 +629,7 @@ xlog_cil_push_background( | |||
629 | 629 | ||
630 | static void | 630 | static void |
631 | xlog_cil_push_foreground( | 631 | xlog_cil_push_foreground( |
632 | struct log *log, | 632 | struct xlog *log, |
633 | xfs_lsn_t push_seq) | 633 | xfs_lsn_t push_seq) |
634 | { | 634 | { |
635 | struct xfs_cil *cil = log->l_cilp; | 635 | struct xfs_cil *cil = log->l_cilp; |
@@ -683,7 +683,7 @@ xfs_log_commit_cil( | |||
683 | xfs_lsn_t *commit_lsn, | 683 | xfs_lsn_t *commit_lsn, |
684 | int flags) | 684 | int flags) |
685 | { | 685 | { |
686 | struct log *log = mp->m_log; | 686 | struct xlog *log = mp->m_log; |
687 | int log_flags = 0; | 687 | int log_flags = 0; |
688 | struct xfs_log_vec *log_vector; | 688 | struct xfs_log_vec *log_vector; |
689 | 689 | ||
@@ -754,7 +754,7 @@ xfs_log_commit_cil( | |||
754 | */ | 754 | */ |
755 | xfs_lsn_t | 755 | xfs_lsn_t |
756 | xlog_cil_force_lsn( | 756 | xlog_cil_force_lsn( |
757 | struct log *log, | 757 | struct xlog *log, |
758 | xfs_lsn_t sequence) | 758 | xfs_lsn_t sequence) |
759 | { | 759 | { |
760 | struct xfs_cil *cil = log->l_cilp; | 760 | struct xfs_cil *cil = log->l_cilp; |
@@ -833,7 +833,7 @@ xfs_log_item_in_current_chkpt( | |||
833 | */ | 833 | */ |
834 | int | 834 | int |
835 | xlog_cil_init( | 835 | xlog_cil_init( |
836 | struct log *log) | 836 | struct xlog *log) |
837 | { | 837 | { |
838 | struct xfs_cil *cil; | 838 | struct xfs_cil *cil; |
839 | struct xfs_cil_ctx *ctx; | 839 | struct xfs_cil_ctx *ctx; |
@@ -869,7 +869,7 @@ xlog_cil_init( | |||
869 | 869 | ||
870 | void | 870 | void |
871 | xlog_cil_destroy( | 871 | xlog_cil_destroy( |
872 | struct log *log) | 872 | struct xlog *log) |
873 | { | 873 | { |
874 | if (log->l_cilp->xc_ctx) { | 874 | if (log->l_cilp->xc_ctx) { |
875 | if (log->l_cilp->xc_ctx->ticket) | 875 | if (log->l_cilp->xc_ctx->ticket) |
diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h index 5bc33261f5be..72eba2201b14 100644 --- a/fs/xfs/xfs_log_priv.h +++ b/fs/xfs/xfs_log_priv.h | |||
@@ -19,7 +19,7 @@ | |||
19 | #define __XFS_LOG_PRIV_H__ | 19 | #define __XFS_LOG_PRIV_H__ |
20 | 20 | ||
21 | struct xfs_buf; | 21 | struct xfs_buf; |
22 | struct log; | 22 | struct xlog; |
23 | struct xlog_ticket; | 23 | struct xlog_ticket; |
24 | struct xfs_mount; | 24 | struct xfs_mount; |
25 | 25 | ||
@@ -352,7 +352,7 @@ typedef struct xlog_in_core { | |||
352 | struct xlog_in_core *ic_next; | 352 | struct xlog_in_core *ic_next; |
353 | struct xlog_in_core *ic_prev; | 353 | struct xlog_in_core *ic_prev; |
354 | struct xfs_buf *ic_bp; | 354 | struct xfs_buf *ic_bp; |
355 | struct log *ic_log; | 355 | struct xlog *ic_log; |
356 | int ic_size; | 356 | int ic_size; |
357 | int ic_offset; | 357 | int ic_offset; |
358 | int ic_bwritecnt; | 358 | int ic_bwritecnt; |
@@ -409,7 +409,7 @@ struct xfs_cil_ctx { | |||
409 | * operations almost as efficient as the old logging methods. | 409 | * operations almost as efficient as the old logging methods. |
410 | */ | 410 | */ |
411 | struct xfs_cil { | 411 | struct xfs_cil { |
412 | struct log *xc_log; | 412 | struct xlog *xc_log; |
413 | struct list_head xc_cil; | 413 | struct list_head xc_cil; |
414 | spinlock_t xc_cil_lock; | 414 | spinlock_t xc_cil_lock; |
415 | struct xfs_cil_ctx *xc_ctx; | 415 | struct xfs_cil_ctx *xc_ctx; |
@@ -487,7 +487,7 @@ struct xlog_grant_head { | |||
487 | * overflow 31 bits worth of byte offset, so using a byte number will mean | 487 | * overflow 31 bits worth of byte offset, so using a byte number will mean |
488 | * that round off problems won't occur when releasing partial reservations. | 488 | * that round off problems won't occur when releasing partial reservations. |
489 | */ | 489 | */ |
490 | typedef struct log { | 490 | typedef struct xlog { |
491 | /* The following fields don't need locking */ | 491 | /* The following fields don't need locking */ |
492 | struct xfs_mount *l_mp; /* mount point */ | 492 | struct xfs_mount *l_mp; /* mount point */ |
493 | struct xfs_ail *l_ailp; /* AIL log is working with */ | 493 | struct xfs_ail *l_ailp; /* AIL log is working with */ |
@@ -553,9 +553,14 @@ extern int xlog_recover_finish(xlog_t *log); | |||
553 | extern void xlog_pack_data(xlog_t *log, xlog_in_core_t *iclog, int); | 553 | extern void xlog_pack_data(xlog_t *log, xlog_in_core_t *iclog, int); |
554 | 554 | ||
555 | extern kmem_zone_t *xfs_log_ticket_zone; | 555 | extern kmem_zone_t *xfs_log_ticket_zone; |
556 | struct xlog_ticket *xlog_ticket_alloc(struct log *log, int unit_bytes, | 556 | struct xlog_ticket * |
557 | int count, char client, bool permanent, | 557 | xlog_ticket_alloc( |
558 | xfs_km_flags_t alloc_flags); | 558 | struct xlog *log, |
559 | int unit_bytes, | ||
560 | int count, | ||
561 | char client, | ||
562 | bool permanent, | ||
563 | xfs_km_flags_t alloc_flags); | ||
559 | 564 | ||
560 | 565 | ||
561 | static inline void | 566 | static inline void |
@@ -567,9 +572,14 @@ xlog_write_adv_cnt(void **ptr, int *len, int *off, size_t bytes) | |||
567 | } | 572 | } |
568 | 573 | ||
569 | void xlog_print_tic_res(struct xfs_mount *mp, struct xlog_ticket *ticket); | 574 | void xlog_print_tic_res(struct xfs_mount *mp, struct xlog_ticket *ticket); |
570 | int xlog_write(struct log *log, struct xfs_log_vec *log_vector, | 575 | int |
571 | struct xlog_ticket *tic, xfs_lsn_t *start_lsn, | 576 | xlog_write( |
572 | xlog_in_core_t **commit_iclog, uint flags); | 577 | struct xlog *log, |
578 | struct xfs_log_vec *log_vector, | ||
579 | struct xlog_ticket *tic, | ||
580 | xfs_lsn_t *start_lsn, | ||
581 | struct xlog_in_core **commit_iclog, | ||
582 | uint flags); | ||
573 | 583 | ||
574 | /* | 584 | /* |
575 | * When we crack an atomic LSN, we sample it first so that the value will not | 585 | * When we crack an atomic LSN, we sample it first so that the value will not |
@@ -629,17 +639,23 @@ xlog_assign_grant_head(atomic64_t *head, int cycle, int space) | |||
629 | /* | 639 | /* |
630 | * Committed Item List interfaces | 640 | * Committed Item List interfaces |
631 | */ | 641 | */ |
632 | int xlog_cil_init(struct log *log); | 642 | int |
633 | void xlog_cil_init_post_recovery(struct log *log); | 643 | xlog_cil_init(struct xlog *log); |
634 | void xlog_cil_destroy(struct log *log); | 644 | void |
645 | xlog_cil_init_post_recovery(struct xlog *log); | ||
646 | void | ||
647 | xlog_cil_destroy(struct xlog *log); | ||
635 | 648 | ||
636 | /* | 649 | /* |
637 | * CIL force routines | 650 | * CIL force routines |
638 | */ | 651 | */ |
639 | xfs_lsn_t xlog_cil_force_lsn(struct log *log, xfs_lsn_t sequence); | 652 | xfs_lsn_t |
653 | xlog_cil_force_lsn( | ||
654 | struct xlog *log, | ||
655 | xfs_lsn_t sequence); | ||
640 | 656 | ||
641 | static inline void | 657 | static inline void |
642 | xlog_cil_force(struct log *log) | 658 | xlog_cil_force(struct xlog *log) |
643 | { | 659 | { |
644 | xlog_cil_force_lsn(log, log->l_cilp->xc_current_sequence); | 660 | xlog_cil_force_lsn(log, log->l_cilp->xc_current_sequence); |
645 | } | 661 | } |
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index ca386909131a..a7be98abd6a9 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c | |||
@@ -1471,8 +1471,8 @@ xlog_recover_add_item( | |||
1471 | 1471 | ||
1472 | STATIC int | 1472 | STATIC int |
1473 | xlog_recover_add_to_cont_trans( | 1473 | xlog_recover_add_to_cont_trans( |
1474 | struct log *log, | 1474 | struct xlog *log, |
1475 | xlog_recover_t *trans, | 1475 | struct xlog_recover *trans, |
1476 | xfs_caddr_t dp, | 1476 | xfs_caddr_t dp, |
1477 | int len) | 1477 | int len) |
1478 | { | 1478 | { |
@@ -1517,8 +1517,8 @@ xlog_recover_add_to_cont_trans( | |||
1517 | */ | 1517 | */ |
1518 | STATIC int | 1518 | STATIC int |
1519 | xlog_recover_add_to_trans( | 1519 | xlog_recover_add_to_trans( |
1520 | struct log *log, | 1520 | struct xlog *log, |
1521 | xlog_recover_t *trans, | 1521 | struct xlog_recover *trans, |
1522 | xfs_caddr_t dp, | 1522 | xfs_caddr_t dp, |
1523 | int len) | 1523 | int len) |
1524 | { | 1524 | { |
@@ -1588,8 +1588,8 @@ xlog_recover_add_to_trans( | |||
1588 | */ | 1588 | */ |
1589 | STATIC int | 1589 | STATIC int |
1590 | xlog_recover_reorder_trans( | 1590 | xlog_recover_reorder_trans( |
1591 | struct log *log, | 1591 | struct xlog *log, |
1592 | xlog_recover_t *trans, | 1592 | struct xlog_recover *trans, |
1593 | int pass) | 1593 | int pass) |
1594 | { | 1594 | { |
1595 | xlog_recover_item_t *item, *n; | 1595 | xlog_recover_item_t *item, *n; |
@@ -1642,8 +1642,8 @@ xlog_recover_reorder_trans( | |||
1642 | */ | 1642 | */ |
1643 | STATIC int | 1643 | STATIC int |
1644 | xlog_recover_buffer_pass1( | 1644 | xlog_recover_buffer_pass1( |
1645 | struct log *log, | 1645 | struct xlog *log, |
1646 | xlog_recover_item_t *item) | 1646 | struct xlog_recover_item *item) |
1647 | { | 1647 | { |
1648 | xfs_buf_log_format_t *buf_f = item->ri_buf[0].i_addr; | 1648 | xfs_buf_log_format_t *buf_f = item->ri_buf[0].i_addr; |
1649 | struct list_head *bucket; | 1649 | struct list_head *bucket; |
@@ -1696,7 +1696,7 @@ xlog_recover_buffer_pass1( | |||
1696 | */ | 1696 | */ |
1697 | STATIC int | 1697 | STATIC int |
1698 | xlog_check_buffer_cancelled( | 1698 | xlog_check_buffer_cancelled( |
1699 | struct log *log, | 1699 | struct xlog *log, |
1700 | xfs_daddr_t blkno, | 1700 | xfs_daddr_t blkno, |
1701 | uint len, | 1701 | uint len, |
1702 | ushort flags) | 1702 | ushort flags) |
@@ -2689,9 +2689,9 @@ xlog_recover_free_trans( | |||
2689 | 2689 | ||
2690 | STATIC int | 2690 | STATIC int |
2691 | xlog_recover_commit_pass1( | 2691 | xlog_recover_commit_pass1( |
2692 | struct log *log, | 2692 | struct xlog *log, |
2693 | struct xlog_recover *trans, | 2693 | struct xlog_recover *trans, |
2694 | xlog_recover_item_t *item) | 2694 | struct xlog_recover_item *item) |
2695 | { | 2695 | { |
2696 | trace_xfs_log_recover_item_recover(log, trans, item, XLOG_RECOVER_PASS1); | 2696 | trace_xfs_log_recover_item_recover(log, trans, item, XLOG_RECOVER_PASS1); |
2697 | 2697 | ||
@@ -2716,10 +2716,10 @@ xlog_recover_commit_pass1( | |||
2716 | 2716 | ||
2717 | STATIC int | 2717 | STATIC int |
2718 | xlog_recover_commit_pass2( | 2718 | xlog_recover_commit_pass2( |
2719 | struct log *log, | 2719 | struct xlog *log, |
2720 | struct xlog_recover *trans, | 2720 | struct xlog_recover *trans, |
2721 | struct list_head *buffer_list, | 2721 | struct list_head *buffer_list, |
2722 | xlog_recover_item_t *item) | 2722 | struct xlog_recover_item *item) |
2723 | { | 2723 | { |
2724 | trace_xfs_log_recover_item_recover(log, trans, item, XLOG_RECOVER_PASS2); | 2724 | trace_xfs_log_recover_item_recover(log, trans, item, XLOG_RECOVER_PASS2); |
2725 | 2725 | ||
@@ -2753,7 +2753,7 @@ xlog_recover_commit_pass2( | |||
2753 | */ | 2753 | */ |
2754 | STATIC int | 2754 | STATIC int |
2755 | xlog_recover_commit_trans( | 2755 | xlog_recover_commit_trans( |
2756 | struct log *log, | 2756 | struct xlog *log, |
2757 | struct xlog_recover *trans, | 2757 | struct xlog_recover *trans, |
2758 | int pass) | 2758 | int pass) |
2759 | { | 2759 | { |
@@ -2793,8 +2793,8 @@ out: | |||
2793 | 2793 | ||
2794 | STATIC int | 2794 | STATIC int |
2795 | xlog_recover_unmount_trans( | 2795 | xlog_recover_unmount_trans( |
2796 | struct log *log, | 2796 | struct xlog *log, |
2797 | xlog_recover_t *trans) | 2797 | struct xlog_recover *trans) |
2798 | { | 2798 | { |
2799 | /* Do nothing now */ | 2799 | /* Do nothing now */ |
2800 | xfs_warn(log->l_mp, "%s: Unmount LR", __func__); | 2800 | xfs_warn(log->l_mp, "%s: Unmount LR", __func__); |
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index 8b89c5ac72d9..90c1fc9eaea4 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h | |||
@@ -53,7 +53,7 @@ typedef struct xfs_trans_reservations { | |||
53 | 53 | ||
54 | #include "xfs_sync.h" | 54 | #include "xfs_sync.h" |
55 | 55 | ||
56 | struct log; | 56 | struct xlog; |
57 | struct xfs_mount_args; | 57 | struct xfs_mount_args; |
58 | struct xfs_inode; | 58 | struct xfs_inode; |
59 | struct xfs_bmbt_irec; | 59 | struct xfs_bmbt_irec; |
@@ -133,7 +133,7 @@ typedef struct xfs_mount { | |||
133 | uint m_readio_blocks; /* min read size blocks */ | 133 | uint m_readio_blocks; /* min read size blocks */ |
134 | uint m_writeio_log; /* min write size log bytes */ | 134 | uint m_writeio_log; /* min write size log bytes */ |
135 | uint m_writeio_blocks; /* min write size blocks */ | 135 | uint m_writeio_blocks; /* min write size blocks */ |
136 | struct log *m_log; /* log specific stuff */ | 136 | struct xlog *m_log; /* log specific stuff */ |
137 | int m_logbufs; /* number of log buffers */ | 137 | int m_logbufs; /* number of log buffers */ |
138 | int m_logbsize; /* size of each log buffer */ | 138 | int m_logbsize; /* size of each log buffer */ |
139 | uint m_rsumlevels; /* rt summary levels */ | 139 | uint m_rsumlevels; /* rt summary levels */ |
diff --git a/fs/xfs/xfs_sync.c b/fs/xfs/xfs_sync.c index c9d3409c5ca3..1e9ee064dbb2 100644 --- a/fs/xfs/xfs_sync.c +++ b/fs/xfs/xfs_sync.c | |||
@@ -386,23 +386,23 @@ xfs_sync_worker( | |||
386 | * We shouldn't write/force the log if we are in the mount/unmount | 386 | * We shouldn't write/force the log if we are in the mount/unmount |
387 | * process or on a read only filesystem. The workqueue still needs to be | 387 | * process or on a read only filesystem. The workqueue still needs to be |
388 | * active in both cases, however, because it is used for inode reclaim | 388 | * active in both cases, however, because it is used for inode reclaim |
389 | * during these times. Use the s_umount semaphore to provide exclusion | 389 | * during these times. Use the MS_ACTIVE flag to avoid doing anything |
390 | * with unmount. | 390 | * during mount. Doing work during unmount is avoided by calling |
391 | * cancel_delayed_work_sync on this work queue before tearing down | ||
392 | * the ail and the log in xfs_log_unmount. | ||
391 | */ | 393 | */ |
392 | if (down_read_trylock(&mp->m_super->s_umount)) { | 394 | if (!(mp->m_super->s_flags & MS_ACTIVE) && |
393 | if (!(mp->m_flags & XFS_MOUNT_RDONLY)) { | 395 | !(mp->m_flags & XFS_MOUNT_RDONLY)) { |
394 | /* dgc: errors ignored here */ | 396 | /* dgc: errors ignored here */ |
395 | if (mp->m_super->s_frozen == SB_UNFROZEN && | 397 | if (mp->m_super->s_frozen == SB_UNFROZEN && |
396 | xfs_log_need_covered(mp)) | 398 | xfs_log_need_covered(mp)) |
397 | error = xfs_fs_log_dummy(mp); | 399 | error = xfs_fs_log_dummy(mp); |
398 | else | 400 | else |
399 | xfs_log_force(mp, 0); | 401 | xfs_log_force(mp, 0); |
400 | 402 | ||
401 | /* start pushing all the metadata that is currently | 403 | /* start pushing all the metadata that is currently |
402 | * dirty */ | 404 | * dirty */ |
403 | xfs_ail_push_all(mp->m_ail); | 405 | xfs_ail_push_all(mp->m_ail); |
404 | } | ||
405 | up_read(&mp->m_super->s_umount); | ||
406 | } | 406 | } |
407 | 407 | ||
408 | /* queue us up again */ | 408 | /* queue us up again */ |
diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 7cf9d3529e51..caf5dabfd553 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h | |||
@@ -32,7 +32,7 @@ struct xfs_da_node_entry; | |||
32 | struct xfs_dquot; | 32 | struct xfs_dquot; |
33 | struct xfs_log_item; | 33 | struct xfs_log_item; |
34 | struct xlog_ticket; | 34 | struct xlog_ticket; |
35 | struct log; | 35 | struct xlog; |
36 | struct xlog_recover; | 36 | struct xlog_recover; |
37 | struct xlog_recover_item; | 37 | struct xlog_recover_item; |
38 | struct xfs_buf_log_format; | 38 | struct xfs_buf_log_format; |
@@ -762,7 +762,7 @@ DEFINE_DQUOT_EVENT(xfs_dqflush_force); | |||
762 | DEFINE_DQUOT_EVENT(xfs_dqflush_done); | 762 | DEFINE_DQUOT_EVENT(xfs_dqflush_done); |
763 | 763 | ||
764 | DECLARE_EVENT_CLASS(xfs_loggrant_class, | 764 | DECLARE_EVENT_CLASS(xfs_loggrant_class, |
765 | TP_PROTO(struct log *log, struct xlog_ticket *tic), | 765 | TP_PROTO(struct xlog *log, struct xlog_ticket *tic), |
766 | TP_ARGS(log, tic), | 766 | TP_ARGS(log, tic), |
767 | TP_STRUCT__entry( | 767 | TP_STRUCT__entry( |
768 | __field(dev_t, dev) | 768 | __field(dev_t, dev) |
@@ -830,7 +830,7 @@ DECLARE_EVENT_CLASS(xfs_loggrant_class, | |||
830 | 830 | ||
831 | #define DEFINE_LOGGRANT_EVENT(name) \ | 831 | #define DEFINE_LOGGRANT_EVENT(name) \ |
832 | DEFINE_EVENT(xfs_loggrant_class, name, \ | 832 | DEFINE_EVENT(xfs_loggrant_class, name, \ |
833 | TP_PROTO(struct log *log, struct xlog_ticket *tic), \ | 833 | TP_PROTO(struct xlog *log, struct xlog_ticket *tic), \ |
834 | TP_ARGS(log, tic)) | 834 | TP_ARGS(log, tic)) |
835 | DEFINE_LOGGRANT_EVENT(xfs_log_done_nonperm); | 835 | DEFINE_LOGGRANT_EVENT(xfs_log_done_nonperm); |
836 | DEFINE_LOGGRANT_EVENT(xfs_log_done_perm); | 836 | DEFINE_LOGGRANT_EVENT(xfs_log_done_perm); |
@@ -1664,7 +1664,7 @@ DEFINE_SWAPEXT_EVENT(xfs_swap_extent_before); | |||
1664 | DEFINE_SWAPEXT_EVENT(xfs_swap_extent_after); | 1664 | DEFINE_SWAPEXT_EVENT(xfs_swap_extent_after); |
1665 | 1665 | ||
1666 | DECLARE_EVENT_CLASS(xfs_log_recover_item_class, | 1666 | DECLARE_EVENT_CLASS(xfs_log_recover_item_class, |
1667 | TP_PROTO(struct log *log, struct xlog_recover *trans, | 1667 | TP_PROTO(struct xlog *log, struct xlog_recover *trans, |
1668 | struct xlog_recover_item *item, int pass), | 1668 | struct xlog_recover_item *item, int pass), |
1669 | TP_ARGS(log, trans, item, pass), | 1669 | TP_ARGS(log, trans, item, pass), |
1670 | TP_STRUCT__entry( | 1670 | TP_STRUCT__entry( |
@@ -1698,7 +1698,7 @@ DECLARE_EVENT_CLASS(xfs_log_recover_item_class, | |||
1698 | 1698 | ||
1699 | #define DEFINE_LOG_RECOVER_ITEM(name) \ | 1699 | #define DEFINE_LOG_RECOVER_ITEM(name) \ |
1700 | DEFINE_EVENT(xfs_log_recover_item_class, name, \ | 1700 | DEFINE_EVENT(xfs_log_recover_item_class, name, \ |
1701 | TP_PROTO(struct log *log, struct xlog_recover *trans, \ | 1701 | TP_PROTO(struct xlog *log, struct xlog_recover *trans, \ |
1702 | struct xlog_recover_item *item, int pass), \ | 1702 | struct xlog_recover_item *item, int pass), \ |
1703 | TP_ARGS(log, trans, item, pass)) | 1703 | TP_ARGS(log, trans, item, pass)) |
1704 | 1704 | ||
@@ -1709,7 +1709,7 @@ DEFINE_LOG_RECOVER_ITEM(xfs_log_recover_item_reorder_tail); | |||
1709 | DEFINE_LOG_RECOVER_ITEM(xfs_log_recover_item_recover); | 1709 | DEFINE_LOG_RECOVER_ITEM(xfs_log_recover_item_recover); |
1710 | 1710 | ||
1711 | DECLARE_EVENT_CLASS(xfs_log_recover_buf_item_class, | 1711 | DECLARE_EVENT_CLASS(xfs_log_recover_buf_item_class, |
1712 | TP_PROTO(struct log *log, struct xfs_buf_log_format *buf_f), | 1712 | TP_PROTO(struct xlog *log, struct xfs_buf_log_format *buf_f), |
1713 | TP_ARGS(log, buf_f), | 1713 | TP_ARGS(log, buf_f), |
1714 | TP_STRUCT__entry( | 1714 | TP_STRUCT__entry( |
1715 | __field(dev_t, dev) | 1715 | __field(dev_t, dev) |
@@ -1739,7 +1739,7 @@ DECLARE_EVENT_CLASS(xfs_log_recover_buf_item_class, | |||
1739 | 1739 | ||
1740 | #define DEFINE_LOG_RECOVER_BUF_ITEM(name) \ | 1740 | #define DEFINE_LOG_RECOVER_BUF_ITEM(name) \ |
1741 | DEFINE_EVENT(xfs_log_recover_buf_item_class, name, \ | 1741 | DEFINE_EVENT(xfs_log_recover_buf_item_class, name, \ |
1742 | TP_PROTO(struct log *log, struct xfs_buf_log_format *buf_f), \ | 1742 | TP_PROTO(struct xlog *log, struct xfs_buf_log_format *buf_f), \ |
1743 | TP_ARGS(log, buf_f)) | 1743 | TP_ARGS(log, buf_f)) |
1744 | 1744 | ||
1745 | DEFINE_LOG_RECOVER_BUF_ITEM(xfs_log_recover_buf_not_cancel); | 1745 | DEFINE_LOG_RECOVER_BUF_ITEM(xfs_log_recover_buf_not_cancel); |
@@ -1752,7 +1752,7 @@ DEFINE_LOG_RECOVER_BUF_ITEM(xfs_log_recover_buf_reg_buf); | |||
1752 | DEFINE_LOG_RECOVER_BUF_ITEM(xfs_log_recover_buf_dquot_buf); | 1752 | DEFINE_LOG_RECOVER_BUF_ITEM(xfs_log_recover_buf_dquot_buf); |
1753 | 1753 | ||
1754 | DECLARE_EVENT_CLASS(xfs_log_recover_ino_item_class, | 1754 | DECLARE_EVENT_CLASS(xfs_log_recover_ino_item_class, |
1755 | TP_PROTO(struct log *log, struct xfs_inode_log_format *in_f), | 1755 | TP_PROTO(struct xlog *log, struct xfs_inode_log_format *in_f), |
1756 | TP_ARGS(log, in_f), | 1756 | TP_ARGS(log, in_f), |
1757 | TP_STRUCT__entry( | 1757 | TP_STRUCT__entry( |
1758 | __field(dev_t, dev) | 1758 | __field(dev_t, dev) |
@@ -1790,7 +1790,7 @@ DECLARE_EVENT_CLASS(xfs_log_recover_ino_item_class, | |||
1790 | ) | 1790 | ) |
1791 | #define DEFINE_LOG_RECOVER_INO_ITEM(name) \ | 1791 | #define DEFINE_LOG_RECOVER_INO_ITEM(name) \ |
1792 | DEFINE_EVENT(xfs_log_recover_ino_item_class, name, \ | 1792 | DEFINE_EVENT(xfs_log_recover_ino_item_class, name, \ |
1793 | TP_PROTO(struct log *log, struct xfs_inode_log_format *in_f), \ | 1793 | TP_PROTO(struct xlog *log, struct xfs_inode_log_format *in_f), \ |
1794 | TP_ARGS(log, in_f)) | 1794 | TP_ARGS(log, in_f)) |
1795 | 1795 | ||
1796 | DEFINE_LOG_RECOVER_INO_ITEM(xfs_log_recover_inode_recover); | 1796 | DEFINE_LOG_RECOVER_INO_ITEM(xfs_log_recover_inode_recover); |