1 files changed, 19 insertions, 5 deletions

diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
index d139405d2bfa..2578a0c0677d 100644
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -506,11 +506,25 @@ static int ovl_remove_and_whiteout(struct dentry *dentry, bool is_dir)
         struct dentry *opaquedir = NULL;
         int err;
 
-        if (is_dir && OVL_TYPE_MERGE_OR_LOWER(ovl_path_type(dentry))) {
-                opaquedir = ovl_check_empty_and_clear(dentry);
-                err = PTR_ERR(opaquedir);
-                if (IS_ERR(opaquedir))
-                        goto out;
+        if (is_dir) {
+                if (OVL_TYPE_MERGE_OR_LOWER(ovl_path_type(dentry))) {
+                        opaquedir = ovl_check_empty_and_clear(dentry);
+                        err = PTR_ERR(opaquedir);
+                        if (IS_ERR(opaquedir))
+                                goto out;
+                } else {
+                        LIST_HEAD(list);
+
+                        /*
+                         * When removing an empty opaque directory, then it
+                         * makes no sense to replace it with an exact replica of
+                         * itself.  But emptiness still needs to be checked.
+                         */
+                        err = ovl_check_empty_dir(dentry, &list);
+                        ovl_cache_free(&list);
+                        if (err)
+                                goto out;
+                }
         }
 
         err = ovl_lock_rename_workdir(workdir, upperdir);